]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/blame - kernel/bpf/verifier.c
bpf: Make reference tracking generic
[mirror_ubuntu-hirsute-kernel.git] / kernel / bpf / verifier.c
CommitLineData
5b497af4 1// SPDX-License-Identifier: GPL-2.0-only
51580e79 2/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
969bf05e 3 * Copyright (c) 2016 Facebook
fd978bf7 4 * Copyright (c) 2018 Covalent IO, Inc. http://covalent.io
51580e79 5 */
838e9690 6#include <uapi/linux/btf.h>
51580e79
AS
7#include <linux/kernel.h>
8#include <linux/types.h>
9#include <linux/slab.h>
10#include <linux/bpf.h>
838e9690 11#include <linux/btf.h>
58e2af8b 12#include <linux/bpf_verifier.h>
51580e79
AS
13#include <linux/filter.h>
14#include <net/netlink.h>
15#include <linux/file.h>
16#include <linux/vmalloc.h>
ebb676da 17#include <linux/stringify.h>
cc8b0b92
AS
18#include <linux/bsearch.h>
19#include <linux/sort.h>
c195651e 20#include <linux/perf_event.h>
d9762e84 21#include <linux/ctype.h>
6ba43b76 22#include <linux/error-injection.h>
9e4e01df 23#include <linux/bpf_lsm.h>
1e6c62a8 24#include <linux/btf_ids.h>
51580e79 25
f4ac7e0b
JK
26#include "disasm.h"
27
00176a34 28static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
91cc1a99 29#define BPF_PROG_TYPE(_id, _name, prog_ctx_type, kern_ctx_type) \
00176a34
JK
30 [_id] = & _name ## _verifier_ops,
31#define BPF_MAP_TYPE(_id, _ops)
f2e10bff 32#define BPF_LINK_TYPE(_id, _name)
00176a34
JK
33#include <linux/bpf_types.h>
34#undef BPF_PROG_TYPE
35#undef BPF_MAP_TYPE
f2e10bff 36#undef BPF_LINK_TYPE
00176a34
JK
37};
38
51580e79
AS
39/* bpf_check() is a static code analyzer that walks eBPF program
40 * instruction by instruction and updates register/stack state.
41 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
42 *
43 * The first pass is depth-first-search to check that the program is a DAG.
44 * It rejects the following programs:
45 * - larger than BPF_MAXINSNS insns
46 * - if loop is present (detected via back-edge)
47 * - unreachable insns exist (shouldn't be a forest. program = one function)
48 * - out of bounds or malformed jumps
49 * The second pass is all possible path descent from the 1st insn.
50 * Since it's analyzing all pathes through the program, the length of the
eba38a96 51 * analysis is limited to 64k insn, which may be hit even if total number of
51580e79
AS
52 * insn is less then 4K, but there are too many branches that change stack/regs.
53 * Number of 'branches to be analyzed' is limited to 1k
54 *
55 * On entry to each instruction, each register has a type, and the instruction
56 * changes the types of the registers depending on instruction semantics.
57 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
58 * copied to R1.
59 *
60 * All registers are 64-bit.
61 * R0 - return register
62 * R1-R5 argument passing registers
63 * R6-R9 callee saved registers
64 * R10 - frame pointer read-only
65 *
66 * At the start of BPF program the register R1 contains a pointer to bpf_context
67 * and has type PTR_TO_CTX.
68 *
69 * Verifier tracks arithmetic operations on pointers in case:
70 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
71 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
72 * 1st insn copies R10 (which has FRAME_PTR) type into R1
73 * and 2nd arithmetic instruction is pattern matched to recognize
74 * that it wants to construct a pointer to some element within stack.
75 * So after 2nd insn, the register R1 has type PTR_TO_STACK
76 * (and -20 constant is saved for further stack bounds checking).
77 * Meaning that this reg is a pointer to stack plus known immediate constant.
78 *
f1174f77 79 * Most of the time the registers have SCALAR_VALUE type, which
51580e79 80 * means the register has some value, but it's not a valid pointer.
f1174f77 81 * (like pointer plus pointer becomes SCALAR_VALUE type)
51580e79
AS
82 *
83 * When verifier sees load or store instructions the type of base register
c64b7983
JS
84 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK, PTR_TO_SOCKET. These are
85 * four pointer types recognized by check_mem_access() function.
51580e79
AS
86 *
87 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
88 * and the range of [ptr, ptr + map's value_size) is accessible.
89 *
90 * registers used to pass values to function calls are checked against
91 * function argument constraints.
92 *
93 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
94 * It means that the register type passed to this function must be
95 * PTR_TO_STACK and it will be used inside the function as
96 * 'pointer to map element key'
97 *
98 * For example the argument constraints for bpf_map_lookup_elem():
99 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
100 * .arg1_type = ARG_CONST_MAP_PTR,
101 * .arg2_type = ARG_PTR_TO_MAP_KEY,
102 *
103 * ret_type says that this function returns 'pointer to map elem value or null'
104 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
105 * 2nd argument should be a pointer to stack, which will be used inside
106 * the helper function as a pointer to map element key.
107 *
108 * On the kernel side the helper function looks like:
109 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
110 * {
111 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
112 * void *key = (void *) (unsigned long) r2;
113 * void *value;
114 *
115 * here kernel can access 'key' and 'map' pointers safely, knowing that
116 * [key, key + map->key_size) bytes are valid and were initialized on
117 * the stack of eBPF program.
118 * }
119 *
120 * Corresponding eBPF program may look like:
121 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
122 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
123 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
124 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
125 * here verifier looks at prototype of map_lookup_elem() and sees:
126 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
127 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
128 *
129 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
130 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
131 * and were initialized prior to this call.
132 * If it's ok, then verifier allows this BPF_CALL insn and looks at
133 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
134 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
135 * returns ether pointer to map value or NULL.
136 *
137 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
138 * insn, the register holding that pointer in the true branch changes state to
139 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
140 * branch. See check_cond_jmp_op().
141 *
142 * After the call R0 is set to return type of the function and registers R1-R5
143 * are set to NOT_INIT to indicate that they are no longer readable.
fd978bf7
JS
144 *
145 * The following reference types represent a potential reference to a kernel
146 * resource which, after first being allocated, must be checked and freed by
147 * the BPF program:
148 * - PTR_TO_SOCKET_OR_NULL, PTR_TO_SOCKET
149 *
150 * When the verifier sees a helper call return a reference type, it allocates a
151 * pointer id for the reference and stores it in the current function state.
152 * Similar to the way that PTR_TO_MAP_VALUE_OR_NULL is converted into
153 * PTR_TO_MAP_VALUE, PTR_TO_SOCKET_OR_NULL becomes PTR_TO_SOCKET when the type
154 * passes through a NULL-check conditional. For the branch wherein the state is
155 * changed to CONST_IMM, the verifier releases the reference.
6acc9b43
JS
156 *
157 * For each helper function that allocates a reference, such as
158 * bpf_sk_lookup_tcp(), there is a corresponding release function, such as
159 * bpf_sk_release(). When a reference type passes into the release function,
160 * the verifier also releases the reference. If any unchecked or unreleased
161 * reference remains at the end of the program, the verifier rejects it.
51580e79
AS
162 */
163
17a52670 164/* verifier_state + insn_idx are pushed to stack when branch is encountered */
58e2af8b 165struct bpf_verifier_stack_elem {
17a52670
AS
166 /* verifer state is 'st'
167 * before processing instruction 'insn_idx'
168 * and after processing instruction 'prev_insn_idx'
169 */
58e2af8b 170 struct bpf_verifier_state st;
17a52670
AS
171 int insn_idx;
172 int prev_insn_idx;
58e2af8b 173 struct bpf_verifier_stack_elem *next;
6f8a57cc
AN
174 /* length of verifier log at the time this state was pushed on stack */
175 u32 log_pos;
cbd35700
AS
176};
177
b285fcb7 178#define BPF_COMPLEXITY_LIMIT_JMP_SEQ 8192
ceefbc96 179#define BPF_COMPLEXITY_LIMIT_STATES 64
07016151 180
d2e4c1e6
DB
181#define BPF_MAP_KEY_POISON (1ULL << 63)
182#define BPF_MAP_KEY_SEEN (1ULL << 62)
183
c93552c4
DB
184#define BPF_MAP_PTR_UNPRIV 1UL
185#define BPF_MAP_PTR_POISON ((void *)((0xeB9FUL << 1) + \
186 POISON_POINTER_DELTA))
187#define BPF_MAP_PTR(X) ((struct bpf_map *)((X) & ~BPF_MAP_PTR_UNPRIV))
188
189static bool bpf_map_ptr_poisoned(const struct bpf_insn_aux_data *aux)
190{
d2e4c1e6 191 return BPF_MAP_PTR(aux->map_ptr_state) == BPF_MAP_PTR_POISON;
c93552c4
DB
192}
193
194static bool bpf_map_ptr_unpriv(const struct bpf_insn_aux_data *aux)
195{
d2e4c1e6 196 return aux->map_ptr_state & BPF_MAP_PTR_UNPRIV;
c93552c4
DB
197}
198
199static void bpf_map_ptr_store(struct bpf_insn_aux_data *aux,
200 const struct bpf_map *map, bool unpriv)
201{
202 BUILD_BUG_ON((unsigned long)BPF_MAP_PTR_POISON & BPF_MAP_PTR_UNPRIV);
203 unpriv |= bpf_map_ptr_unpriv(aux);
d2e4c1e6
DB
204 aux->map_ptr_state = (unsigned long)map |
205 (unpriv ? BPF_MAP_PTR_UNPRIV : 0UL);
206}
207
208static bool bpf_map_key_poisoned(const struct bpf_insn_aux_data *aux)
209{
210 return aux->map_key_state & BPF_MAP_KEY_POISON;
211}
212
213static bool bpf_map_key_unseen(const struct bpf_insn_aux_data *aux)
214{
215 return !(aux->map_key_state & BPF_MAP_KEY_SEEN);
216}
217
218static u64 bpf_map_key_immediate(const struct bpf_insn_aux_data *aux)
219{
220 return aux->map_key_state & ~(BPF_MAP_KEY_SEEN | BPF_MAP_KEY_POISON);
221}
222
223static void bpf_map_key_store(struct bpf_insn_aux_data *aux, u64 state)
224{
225 bool poisoned = bpf_map_key_poisoned(aux);
226
227 aux->map_key_state = state | BPF_MAP_KEY_SEEN |
228 (poisoned ? BPF_MAP_KEY_POISON : 0ULL);
c93552c4 229}
fad73a1a 230
33ff9823
DB
231struct bpf_call_arg_meta {
232 struct bpf_map *map_ptr;
435faee1 233 bool raw_mode;
36bbef52 234 bool pkt_access;
435faee1
DB
235 int regno;
236 int access_size;
457f4436 237 int mem_size;
10060503 238 u64 msize_max_value;
1b986589 239 int ref_obj_id;
d83525ca 240 int func_id;
33ff9823
DB
241};
242
8580ac94
AS
243struct btf *btf_vmlinux;
244
cbd35700
AS
245static DEFINE_MUTEX(bpf_verifier_lock);
246
d9762e84
MKL
247static const struct bpf_line_info *
248find_linfo(const struct bpf_verifier_env *env, u32 insn_off)
249{
250 const struct bpf_line_info *linfo;
251 const struct bpf_prog *prog;
252 u32 i, nr_linfo;
253
254 prog = env->prog;
255 nr_linfo = prog->aux->nr_linfo;
256
257 if (!nr_linfo || insn_off >= prog->len)
258 return NULL;
259
260 linfo = prog->aux->linfo;
261 for (i = 1; i < nr_linfo; i++)
262 if (insn_off < linfo[i].insn_off)
263 break;
264
265 return &linfo[i - 1];
266}
267
77d2e05a
MKL
268void bpf_verifier_vlog(struct bpf_verifier_log *log, const char *fmt,
269 va_list args)
cbd35700 270{
a2a7d570 271 unsigned int n;
cbd35700 272
a2a7d570 273 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
a2a7d570
JK
274
275 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
276 "verifier log line truncated - local buffer too short\n");
277
278 n = min(log->len_total - log->len_used - 1, n);
279 log->kbuf[n] = '\0';
280
8580ac94
AS
281 if (log->level == BPF_LOG_KERNEL) {
282 pr_err("BPF:%s\n", log->kbuf);
283 return;
284 }
a2a7d570
JK
285 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
286 log->len_used += n;
287 else
288 log->ubuf = NULL;
cbd35700 289}
abe08840 290
6f8a57cc
AN
291static void bpf_vlog_reset(struct bpf_verifier_log *log, u32 new_pos)
292{
293 char zero = 0;
294
295 if (!bpf_verifier_log_needed(log))
296 return;
297
298 log->len_used = new_pos;
299 if (put_user(zero, log->ubuf + new_pos))
300 log->ubuf = NULL;
301}
302
abe08840
JO
303/* log_level controls verbosity level of eBPF verifier.
304 * bpf_verifier_log_write() is used to dump the verification trace to the log,
305 * so the user can figure out what's wrong with the program
430e68d1 306 */
abe08840
JO
307__printf(2, 3) void bpf_verifier_log_write(struct bpf_verifier_env *env,
308 const char *fmt, ...)
309{
310 va_list args;
311
77d2e05a
MKL
312 if (!bpf_verifier_log_needed(&env->log))
313 return;
314
abe08840 315 va_start(args, fmt);
77d2e05a 316 bpf_verifier_vlog(&env->log, fmt, args);
abe08840
JO
317 va_end(args);
318}
319EXPORT_SYMBOL_GPL(bpf_verifier_log_write);
320
321__printf(2, 3) static void verbose(void *private_data, const char *fmt, ...)
322{
77d2e05a 323 struct bpf_verifier_env *env = private_data;
abe08840
JO
324 va_list args;
325
77d2e05a
MKL
326 if (!bpf_verifier_log_needed(&env->log))
327 return;
328
abe08840 329 va_start(args, fmt);
77d2e05a 330 bpf_verifier_vlog(&env->log, fmt, args);
abe08840
JO
331 va_end(args);
332}
cbd35700 333
9e15db66
AS
334__printf(2, 3) void bpf_log(struct bpf_verifier_log *log,
335 const char *fmt, ...)
336{
337 va_list args;
338
339 if (!bpf_verifier_log_needed(log))
340 return;
341
342 va_start(args, fmt);
343 bpf_verifier_vlog(log, fmt, args);
344 va_end(args);
345}
346
d9762e84
MKL
347static const char *ltrim(const char *s)
348{
349 while (isspace(*s))
350 s++;
351
352 return s;
353}
354
355__printf(3, 4) static void verbose_linfo(struct bpf_verifier_env *env,
356 u32 insn_off,
357 const char *prefix_fmt, ...)
358{
359 const struct bpf_line_info *linfo;
360
361 if (!bpf_verifier_log_needed(&env->log))
362 return;
363
364 linfo = find_linfo(env, insn_off);
365 if (!linfo || linfo == env->prev_linfo)
366 return;
367
368 if (prefix_fmt) {
369 va_list args;
370
371 va_start(args, prefix_fmt);
372 bpf_verifier_vlog(&env->log, prefix_fmt, args);
373 va_end(args);
374 }
375
376 verbose(env, "%s\n",
377 ltrim(btf_name_by_offset(env->prog->aux->btf,
378 linfo->line_off)));
379
380 env->prev_linfo = linfo;
381}
382
de8f3a83
DB
383static bool type_is_pkt_pointer(enum bpf_reg_type type)
384{
385 return type == PTR_TO_PACKET ||
386 type == PTR_TO_PACKET_META;
387}
388
46f8bc92
MKL
389static bool type_is_sk_pointer(enum bpf_reg_type type)
390{
391 return type == PTR_TO_SOCKET ||
655a51e5 392 type == PTR_TO_SOCK_COMMON ||
fada7fdc
JL
393 type == PTR_TO_TCP_SOCK ||
394 type == PTR_TO_XDP_SOCK;
46f8bc92
MKL
395}
396
cac616db
JF
397static bool reg_type_not_null(enum bpf_reg_type type)
398{
399 return type == PTR_TO_SOCKET ||
400 type == PTR_TO_TCP_SOCK ||
401 type == PTR_TO_MAP_VALUE ||
01c66c48 402 type == PTR_TO_SOCK_COMMON;
cac616db
JF
403}
404
840b9615
JS
405static bool reg_type_may_be_null(enum bpf_reg_type type)
406{
fd978bf7 407 return type == PTR_TO_MAP_VALUE_OR_NULL ||
46f8bc92 408 type == PTR_TO_SOCKET_OR_NULL ||
655a51e5 409 type == PTR_TO_SOCK_COMMON_OR_NULL ||
b121b341 410 type == PTR_TO_TCP_SOCK_OR_NULL ||
457f4436 411 type == PTR_TO_BTF_ID_OR_NULL ||
afbf21dc
YS
412 type == PTR_TO_MEM_OR_NULL ||
413 type == PTR_TO_RDONLY_BUF_OR_NULL ||
414 type == PTR_TO_RDWR_BUF_OR_NULL;
fd978bf7
JS
415}
416
d83525ca
AS
417static bool reg_may_point_to_spin_lock(const struct bpf_reg_state *reg)
418{
419 return reg->type == PTR_TO_MAP_VALUE &&
420 map_value_has_spin_lock(reg->map_ptr);
421}
422
cba368c1
MKL
423static bool reg_type_may_be_refcounted_or_null(enum bpf_reg_type type)
424{
425 return type == PTR_TO_SOCKET ||
426 type == PTR_TO_SOCKET_OR_NULL ||
427 type == PTR_TO_TCP_SOCK ||
457f4436
AN
428 type == PTR_TO_TCP_SOCK_OR_NULL ||
429 type == PTR_TO_MEM ||
430 type == PTR_TO_MEM_OR_NULL;
cba368c1
MKL
431}
432
1b986589 433static bool arg_type_may_be_refcounted(enum bpf_arg_type type)
fd978bf7 434{
1b986589 435 return type == ARG_PTR_TO_SOCK_COMMON;
fd978bf7
JS
436}
437
438/* Determine whether the function releases some resources allocated by another
439 * function call. The first reference type argument will be assumed to be
440 * released by release_reference().
441 */
442static bool is_release_function(enum bpf_func_id func_id)
443{
457f4436
AN
444 return func_id == BPF_FUNC_sk_release ||
445 func_id == BPF_FUNC_ringbuf_submit ||
446 func_id == BPF_FUNC_ringbuf_discard;
840b9615
JS
447}
448
64d85290 449static bool may_be_acquire_function(enum bpf_func_id func_id)
46f8bc92
MKL
450{
451 return func_id == BPF_FUNC_sk_lookup_tcp ||
edbf8c01 452 func_id == BPF_FUNC_sk_lookup_udp ||
64d85290 453 func_id == BPF_FUNC_skc_lookup_tcp ||
457f4436
AN
454 func_id == BPF_FUNC_map_lookup_elem ||
455 func_id == BPF_FUNC_ringbuf_reserve;
64d85290
JS
456}
457
458static bool is_acquire_function(enum bpf_func_id func_id,
459 const struct bpf_map *map)
460{
461 enum bpf_map_type map_type = map ? map->map_type : BPF_MAP_TYPE_UNSPEC;
462
463 if (func_id == BPF_FUNC_sk_lookup_tcp ||
464 func_id == BPF_FUNC_sk_lookup_udp ||
457f4436
AN
465 func_id == BPF_FUNC_skc_lookup_tcp ||
466 func_id == BPF_FUNC_ringbuf_reserve)
64d85290
JS
467 return true;
468
469 if (func_id == BPF_FUNC_map_lookup_elem &&
470 (map_type == BPF_MAP_TYPE_SOCKMAP ||
471 map_type == BPF_MAP_TYPE_SOCKHASH))
472 return true;
473
474 return false;
46f8bc92
MKL
475}
476
1b986589
MKL
477static bool is_ptr_cast_function(enum bpf_func_id func_id)
478{
479 return func_id == BPF_FUNC_tcp_sock ||
480 func_id == BPF_FUNC_sk_fullsock;
481}
482
17a52670
AS
483/* string representation of 'enum bpf_reg_type' */
484static const char * const reg_type_str[] = {
485 [NOT_INIT] = "?",
f1174f77 486 [SCALAR_VALUE] = "inv",
17a52670
AS
487 [PTR_TO_CTX] = "ctx",
488 [CONST_PTR_TO_MAP] = "map_ptr",
489 [PTR_TO_MAP_VALUE] = "map_value",
490 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
17a52670 491 [PTR_TO_STACK] = "fp",
969bf05e 492 [PTR_TO_PACKET] = "pkt",
de8f3a83 493 [PTR_TO_PACKET_META] = "pkt_meta",
969bf05e 494 [PTR_TO_PACKET_END] = "pkt_end",
d58e468b 495 [PTR_TO_FLOW_KEYS] = "flow_keys",
c64b7983
JS
496 [PTR_TO_SOCKET] = "sock",
497 [PTR_TO_SOCKET_OR_NULL] = "sock_or_null",
46f8bc92
MKL
498 [PTR_TO_SOCK_COMMON] = "sock_common",
499 [PTR_TO_SOCK_COMMON_OR_NULL] = "sock_common_or_null",
655a51e5
MKL
500 [PTR_TO_TCP_SOCK] = "tcp_sock",
501 [PTR_TO_TCP_SOCK_OR_NULL] = "tcp_sock_or_null",
9df1c28b 502 [PTR_TO_TP_BUFFER] = "tp_buffer",
fada7fdc 503 [PTR_TO_XDP_SOCK] = "xdp_sock",
9e15db66 504 [PTR_TO_BTF_ID] = "ptr_",
b121b341 505 [PTR_TO_BTF_ID_OR_NULL] = "ptr_or_null_",
457f4436
AN
506 [PTR_TO_MEM] = "mem",
507 [PTR_TO_MEM_OR_NULL] = "mem_or_null",
afbf21dc
YS
508 [PTR_TO_RDONLY_BUF] = "rdonly_buf",
509 [PTR_TO_RDONLY_BUF_OR_NULL] = "rdonly_buf_or_null",
510 [PTR_TO_RDWR_BUF] = "rdwr_buf",
511 [PTR_TO_RDWR_BUF_OR_NULL] = "rdwr_buf_or_null",
17a52670
AS
512};
513
8efea21d
EC
514static char slot_type_char[] = {
515 [STACK_INVALID] = '?',
516 [STACK_SPILL] = 'r',
517 [STACK_MISC] = 'm',
518 [STACK_ZERO] = '0',
519};
520
4e92024a
AS
521static void print_liveness(struct bpf_verifier_env *env,
522 enum bpf_reg_liveness live)
523{
9242b5f5 524 if (live & (REG_LIVE_READ | REG_LIVE_WRITTEN | REG_LIVE_DONE))
4e92024a
AS
525 verbose(env, "_");
526 if (live & REG_LIVE_READ)
527 verbose(env, "r");
528 if (live & REG_LIVE_WRITTEN)
529 verbose(env, "w");
9242b5f5
AS
530 if (live & REG_LIVE_DONE)
531 verbose(env, "D");
4e92024a
AS
532}
533
f4d7e40a
AS
534static struct bpf_func_state *func(struct bpf_verifier_env *env,
535 const struct bpf_reg_state *reg)
536{
537 struct bpf_verifier_state *cur = env->cur_state;
538
539 return cur->frame[reg->frameno];
540}
541
9e15db66
AS
542const char *kernel_type_name(u32 id)
543{
544 return btf_name_by_offset(btf_vmlinux,
545 btf_type_by_id(btf_vmlinux, id)->name_off);
546}
547
61bd5218 548static void print_verifier_state(struct bpf_verifier_env *env,
f4d7e40a 549 const struct bpf_func_state *state)
17a52670 550{
f4d7e40a 551 const struct bpf_reg_state *reg;
17a52670
AS
552 enum bpf_reg_type t;
553 int i;
554
f4d7e40a
AS
555 if (state->frameno)
556 verbose(env, " frame%d:", state->frameno);
17a52670 557 for (i = 0; i < MAX_BPF_REG; i++) {
1a0dc1ac
AS
558 reg = &state->regs[i];
559 t = reg->type;
17a52670
AS
560 if (t == NOT_INIT)
561 continue;
4e92024a
AS
562 verbose(env, " R%d", i);
563 print_liveness(env, reg->live);
564 verbose(env, "=%s", reg_type_str[t]);
b5dc0163
AS
565 if (t == SCALAR_VALUE && reg->precise)
566 verbose(env, "P");
f1174f77
EC
567 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
568 tnum_is_const(reg->var_off)) {
569 /* reg->off should be 0 for SCALAR_VALUE */
61bd5218 570 verbose(env, "%lld", reg->var_off.value + reg->off);
f1174f77 571 } else {
b121b341 572 if (t == PTR_TO_BTF_ID || t == PTR_TO_BTF_ID_OR_NULL)
9e15db66 573 verbose(env, "%s", kernel_type_name(reg->btf_id));
cba368c1
MKL
574 verbose(env, "(id=%d", reg->id);
575 if (reg_type_may_be_refcounted_or_null(t))
576 verbose(env, ",ref_obj_id=%d", reg->ref_obj_id);
f1174f77 577 if (t != SCALAR_VALUE)
61bd5218 578 verbose(env, ",off=%d", reg->off);
de8f3a83 579 if (type_is_pkt_pointer(t))
61bd5218 580 verbose(env, ",r=%d", reg->range);
f1174f77
EC
581 else if (t == CONST_PTR_TO_MAP ||
582 t == PTR_TO_MAP_VALUE ||
583 t == PTR_TO_MAP_VALUE_OR_NULL)
61bd5218 584 verbose(env, ",ks=%d,vs=%d",
f1174f77
EC
585 reg->map_ptr->key_size,
586 reg->map_ptr->value_size);
7d1238f2
EC
587 if (tnum_is_const(reg->var_off)) {
588 /* Typically an immediate SCALAR_VALUE, but
589 * could be a pointer whose offset is too big
590 * for reg->off
591 */
61bd5218 592 verbose(env, ",imm=%llx", reg->var_off.value);
7d1238f2
EC
593 } else {
594 if (reg->smin_value != reg->umin_value &&
595 reg->smin_value != S64_MIN)
61bd5218 596 verbose(env, ",smin_value=%lld",
7d1238f2
EC
597 (long long)reg->smin_value);
598 if (reg->smax_value != reg->umax_value &&
599 reg->smax_value != S64_MAX)
61bd5218 600 verbose(env, ",smax_value=%lld",
7d1238f2
EC
601 (long long)reg->smax_value);
602 if (reg->umin_value != 0)
61bd5218 603 verbose(env, ",umin_value=%llu",
7d1238f2
EC
604 (unsigned long long)reg->umin_value);
605 if (reg->umax_value != U64_MAX)
61bd5218 606 verbose(env, ",umax_value=%llu",
7d1238f2
EC
607 (unsigned long long)reg->umax_value);
608 if (!tnum_is_unknown(reg->var_off)) {
609 char tn_buf[48];
f1174f77 610
7d1238f2 611 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 612 verbose(env, ",var_off=%s", tn_buf);
7d1238f2 613 }
3f50f132
JF
614 if (reg->s32_min_value != reg->smin_value &&
615 reg->s32_min_value != S32_MIN)
616 verbose(env, ",s32_min_value=%d",
617 (int)(reg->s32_min_value));
618 if (reg->s32_max_value != reg->smax_value &&
619 reg->s32_max_value != S32_MAX)
620 verbose(env, ",s32_max_value=%d",
621 (int)(reg->s32_max_value));
622 if (reg->u32_min_value != reg->umin_value &&
623 reg->u32_min_value != U32_MIN)
624 verbose(env, ",u32_min_value=%d",
625 (int)(reg->u32_min_value));
626 if (reg->u32_max_value != reg->umax_value &&
627 reg->u32_max_value != U32_MAX)
628 verbose(env, ",u32_max_value=%d",
629 (int)(reg->u32_max_value));
f1174f77 630 }
61bd5218 631 verbose(env, ")");
f1174f77 632 }
17a52670 633 }
638f5b90 634 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
8efea21d
EC
635 char types_buf[BPF_REG_SIZE + 1];
636 bool valid = false;
637 int j;
638
639 for (j = 0; j < BPF_REG_SIZE; j++) {
640 if (state->stack[i].slot_type[j] != STACK_INVALID)
641 valid = true;
642 types_buf[j] = slot_type_char[
643 state->stack[i].slot_type[j]];
644 }
645 types_buf[BPF_REG_SIZE] = 0;
646 if (!valid)
647 continue;
648 verbose(env, " fp%d", (-i - 1) * BPF_REG_SIZE);
649 print_liveness(env, state->stack[i].spilled_ptr.live);
b5dc0163
AS
650 if (state->stack[i].slot_type[0] == STACK_SPILL) {
651 reg = &state->stack[i].spilled_ptr;
652 t = reg->type;
653 verbose(env, "=%s", reg_type_str[t]);
654 if (t == SCALAR_VALUE && reg->precise)
655 verbose(env, "P");
656 if (t == SCALAR_VALUE && tnum_is_const(reg->var_off))
657 verbose(env, "%lld", reg->var_off.value + reg->off);
658 } else {
8efea21d 659 verbose(env, "=%s", types_buf);
b5dc0163 660 }
17a52670 661 }
fd978bf7
JS
662 if (state->acquired_refs && state->refs[0].id) {
663 verbose(env, " refs=%d", state->refs[0].id);
664 for (i = 1; i < state->acquired_refs; i++)
665 if (state->refs[i].id)
666 verbose(env, ",%d", state->refs[i].id);
667 }
61bd5218 668 verbose(env, "\n");
17a52670
AS
669}
670
84dbf350
JS
671#define COPY_STATE_FN(NAME, COUNT, FIELD, SIZE) \
672static int copy_##NAME##_state(struct bpf_func_state *dst, \
673 const struct bpf_func_state *src) \
674{ \
675 if (!src->FIELD) \
676 return 0; \
677 if (WARN_ON_ONCE(dst->COUNT < src->COUNT)) { \
678 /* internal bug, make state invalid to reject the program */ \
679 memset(dst, 0, sizeof(*dst)); \
680 return -EFAULT; \
681 } \
682 memcpy(dst->FIELD, src->FIELD, \
683 sizeof(*src->FIELD) * (src->COUNT / SIZE)); \
684 return 0; \
638f5b90 685}
fd978bf7
JS
686/* copy_reference_state() */
687COPY_STATE_FN(reference, acquired_refs, refs, 1)
84dbf350
JS
688/* copy_stack_state() */
689COPY_STATE_FN(stack, allocated_stack, stack, BPF_REG_SIZE)
690#undef COPY_STATE_FN
691
692#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE) \
693static int realloc_##NAME##_state(struct bpf_func_state *state, int size, \
694 bool copy_old) \
695{ \
696 u32 old_size = state->COUNT; \
697 struct bpf_##NAME##_state *new_##FIELD; \
698 int slot = size / SIZE; \
699 \
700 if (size <= old_size || !size) { \
701 if (copy_old) \
702 return 0; \
703 state->COUNT = slot * SIZE; \
704 if (!size && old_size) { \
705 kfree(state->FIELD); \
706 state->FIELD = NULL; \
707 } \
708 return 0; \
709 } \
710 new_##FIELD = kmalloc_array(slot, sizeof(struct bpf_##NAME##_state), \
711 GFP_KERNEL); \
712 if (!new_##FIELD) \
713 return -ENOMEM; \
714 if (copy_old) { \
715 if (state->FIELD) \
716 memcpy(new_##FIELD, state->FIELD, \
717 sizeof(*new_##FIELD) * (old_size / SIZE)); \
718 memset(new_##FIELD + old_size / SIZE, 0, \
719 sizeof(*new_##FIELD) * (size - old_size) / SIZE); \
720 } \
721 state->COUNT = slot * SIZE; \
722 kfree(state->FIELD); \
723 state->FIELD = new_##FIELD; \
724 return 0; \
725}
fd978bf7
JS
726/* realloc_reference_state() */
727REALLOC_STATE_FN(reference, acquired_refs, refs, 1)
84dbf350
JS
728/* realloc_stack_state() */
729REALLOC_STATE_FN(stack, allocated_stack, stack, BPF_REG_SIZE)
730#undef REALLOC_STATE_FN
638f5b90
AS
731
732/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
733 * make it consume minimal amount of memory. check_stack_write() access from
f4d7e40a 734 * the program calls into realloc_func_state() to grow the stack size.
84dbf350
JS
735 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
736 * which realloc_stack_state() copies over. It points to previous
737 * bpf_verifier_state which is never reallocated.
638f5b90 738 */
fd978bf7
JS
739static int realloc_func_state(struct bpf_func_state *state, int stack_size,
740 int refs_size, bool copy_old)
638f5b90 741{
fd978bf7
JS
742 int err = realloc_reference_state(state, refs_size, copy_old);
743 if (err)
744 return err;
745 return realloc_stack_state(state, stack_size, copy_old);
746}
747
748/* Acquire a pointer id from the env and update the state->refs to include
749 * this new pointer reference.
750 * On success, returns a valid pointer id to associate with the register
751 * On failure, returns a negative errno.
638f5b90 752 */
fd978bf7 753static int acquire_reference_state(struct bpf_verifier_env *env, int insn_idx)
638f5b90 754{
fd978bf7
JS
755 struct bpf_func_state *state = cur_func(env);
756 int new_ofs = state->acquired_refs;
757 int id, err;
758
759 err = realloc_reference_state(state, state->acquired_refs + 1, true);
760 if (err)
761 return err;
762 id = ++env->id_gen;
763 state->refs[new_ofs].id = id;
764 state->refs[new_ofs].insn_idx = insn_idx;
638f5b90 765
fd978bf7
JS
766 return id;
767}
768
769/* release function corresponding to acquire_reference_state(). Idempotent. */
46f8bc92 770static int release_reference_state(struct bpf_func_state *state, int ptr_id)
fd978bf7
JS
771{
772 int i, last_idx;
773
fd978bf7
JS
774 last_idx = state->acquired_refs - 1;
775 for (i = 0; i < state->acquired_refs; i++) {
776 if (state->refs[i].id == ptr_id) {
777 if (last_idx && i != last_idx)
778 memcpy(&state->refs[i], &state->refs[last_idx],
779 sizeof(*state->refs));
780 memset(&state->refs[last_idx], 0, sizeof(*state->refs));
781 state->acquired_refs--;
638f5b90 782 return 0;
638f5b90 783 }
638f5b90 784 }
46f8bc92 785 return -EINVAL;
fd978bf7
JS
786}
787
788static int transfer_reference_state(struct bpf_func_state *dst,
789 struct bpf_func_state *src)
790{
791 int err = realloc_reference_state(dst, src->acquired_refs, false);
792 if (err)
793 return err;
794 err = copy_reference_state(dst, src);
795 if (err)
796 return err;
638f5b90
AS
797 return 0;
798}
799
f4d7e40a
AS
800static void free_func_state(struct bpf_func_state *state)
801{
5896351e
AS
802 if (!state)
803 return;
fd978bf7 804 kfree(state->refs);
f4d7e40a
AS
805 kfree(state->stack);
806 kfree(state);
807}
808
b5dc0163
AS
809static void clear_jmp_history(struct bpf_verifier_state *state)
810{
811 kfree(state->jmp_history);
812 state->jmp_history = NULL;
813 state->jmp_history_cnt = 0;
814}
815
1969db47
AS
816static void free_verifier_state(struct bpf_verifier_state *state,
817 bool free_self)
638f5b90 818{
f4d7e40a
AS
819 int i;
820
821 for (i = 0; i <= state->curframe; i++) {
822 free_func_state(state->frame[i]);
823 state->frame[i] = NULL;
824 }
b5dc0163 825 clear_jmp_history(state);
1969db47
AS
826 if (free_self)
827 kfree(state);
638f5b90
AS
828}
829
830/* copy verifier state from src to dst growing dst stack space
831 * when necessary to accommodate larger src stack
832 */
f4d7e40a
AS
833static int copy_func_state(struct bpf_func_state *dst,
834 const struct bpf_func_state *src)
638f5b90
AS
835{
836 int err;
837
fd978bf7
JS
838 err = realloc_func_state(dst, src->allocated_stack, src->acquired_refs,
839 false);
840 if (err)
841 return err;
842 memcpy(dst, src, offsetof(struct bpf_func_state, acquired_refs));
843 err = copy_reference_state(dst, src);
638f5b90
AS
844 if (err)
845 return err;
638f5b90
AS
846 return copy_stack_state(dst, src);
847}
848
f4d7e40a
AS
849static int copy_verifier_state(struct bpf_verifier_state *dst_state,
850 const struct bpf_verifier_state *src)
851{
852 struct bpf_func_state *dst;
b5dc0163 853 u32 jmp_sz = sizeof(struct bpf_idx_pair) * src->jmp_history_cnt;
f4d7e40a
AS
854 int i, err;
855
b5dc0163
AS
856 if (dst_state->jmp_history_cnt < src->jmp_history_cnt) {
857 kfree(dst_state->jmp_history);
858 dst_state->jmp_history = kmalloc(jmp_sz, GFP_USER);
859 if (!dst_state->jmp_history)
860 return -ENOMEM;
861 }
862 memcpy(dst_state->jmp_history, src->jmp_history, jmp_sz);
863 dst_state->jmp_history_cnt = src->jmp_history_cnt;
864
f4d7e40a
AS
865 /* if dst has more stack frames then src frame, free them */
866 for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
867 free_func_state(dst_state->frame[i]);
868 dst_state->frame[i] = NULL;
869 }
979d63d5 870 dst_state->speculative = src->speculative;
f4d7e40a 871 dst_state->curframe = src->curframe;
d83525ca 872 dst_state->active_spin_lock = src->active_spin_lock;
2589726d
AS
873 dst_state->branches = src->branches;
874 dst_state->parent = src->parent;
b5dc0163
AS
875 dst_state->first_insn_idx = src->first_insn_idx;
876 dst_state->last_insn_idx = src->last_insn_idx;
f4d7e40a
AS
877 for (i = 0; i <= src->curframe; i++) {
878 dst = dst_state->frame[i];
879 if (!dst) {
880 dst = kzalloc(sizeof(*dst), GFP_KERNEL);
881 if (!dst)
882 return -ENOMEM;
883 dst_state->frame[i] = dst;
884 }
885 err = copy_func_state(dst, src->frame[i]);
886 if (err)
887 return err;
888 }
889 return 0;
890}
891
2589726d
AS
892static void update_branch_counts(struct bpf_verifier_env *env, struct bpf_verifier_state *st)
893{
894 while (st) {
895 u32 br = --st->branches;
896
897 /* WARN_ON(br > 1) technically makes sense here,
898 * but see comment in push_stack(), hence:
899 */
900 WARN_ONCE((int)br < 0,
901 "BUG update_branch_counts:branches_to_explore=%d\n",
902 br);
903 if (br)
904 break;
905 st = st->parent;
906 }
907}
908
638f5b90 909static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
6f8a57cc 910 int *insn_idx, bool pop_log)
638f5b90
AS
911{
912 struct bpf_verifier_state *cur = env->cur_state;
913 struct bpf_verifier_stack_elem *elem, *head = env->head;
914 int err;
17a52670
AS
915
916 if (env->head == NULL)
638f5b90 917 return -ENOENT;
17a52670 918
638f5b90
AS
919 if (cur) {
920 err = copy_verifier_state(cur, &head->st);
921 if (err)
922 return err;
923 }
6f8a57cc
AN
924 if (pop_log)
925 bpf_vlog_reset(&env->log, head->log_pos);
638f5b90
AS
926 if (insn_idx)
927 *insn_idx = head->insn_idx;
17a52670 928 if (prev_insn_idx)
638f5b90
AS
929 *prev_insn_idx = head->prev_insn_idx;
930 elem = head->next;
1969db47 931 free_verifier_state(&head->st, false);
638f5b90 932 kfree(head);
17a52670
AS
933 env->head = elem;
934 env->stack_size--;
638f5b90 935 return 0;
17a52670
AS
936}
937
58e2af8b 938static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
979d63d5
DB
939 int insn_idx, int prev_insn_idx,
940 bool speculative)
17a52670 941{
638f5b90 942 struct bpf_verifier_state *cur = env->cur_state;
58e2af8b 943 struct bpf_verifier_stack_elem *elem;
638f5b90 944 int err;
17a52670 945
638f5b90 946 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
17a52670
AS
947 if (!elem)
948 goto err;
949
17a52670
AS
950 elem->insn_idx = insn_idx;
951 elem->prev_insn_idx = prev_insn_idx;
952 elem->next = env->head;
6f8a57cc 953 elem->log_pos = env->log.len_used;
17a52670
AS
954 env->head = elem;
955 env->stack_size++;
1969db47
AS
956 err = copy_verifier_state(&elem->st, cur);
957 if (err)
958 goto err;
979d63d5 959 elem->st.speculative |= speculative;
b285fcb7
AS
960 if (env->stack_size > BPF_COMPLEXITY_LIMIT_JMP_SEQ) {
961 verbose(env, "The sequence of %d jumps is too complex.\n",
962 env->stack_size);
17a52670
AS
963 goto err;
964 }
2589726d
AS
965 if (elem->st.parent) {
966 ++elem->st.parent->branches;
967 /* WARN_ON(branches > 2) technically makes sense here,
968 * but
969 * 1. speculative states will bump 'branches' for non-branch
970 * instructions
971 * 2. is_state_visited() heuristics may decide not to create
972 * a new state for a sequence of branches and all such current
973 * and cloned states will be pointing to a single parent state
974 * which might have large 'branches' count.
975 */
976 }
17a52670
AS
977 return &elem->st;
978err:
5896351e
AS
979 free_verifier_state(env->cur_state, true);
980 env->cur_state = NULL;
17a52670 981 /* pop all elements and return */
6f8a57cc 982 while (!pop_stack(env, NULL, NULL, false));
17a52670
AS
983 return NULL;
984}
985
986#define CALLER_SAVED_REGS 6
987static const int caller_saved[CALLER_SAVED_REGS] = {
988 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
989};
990
f54c7898
DB
991static void __mark_reg_not_init(const struct bpf_verifier_env *env,
992 struct bpf_reg_state *reg);
f1174f77 993
b03c9f9f
EC
994/* Mark the unknown part of a register (variable offset or scalar value) as
995 * known to have the value @imm.
996 */
997static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
998{
a9c676bc
AS
999 /* Clear id, off, and union(map_ptr, range) */
1000 memset(((u8 *)reg) + sizeof(reg->type), 0,
1001 offsetof(struct bpf_reg_state, var_off) - sizeof(reg->type));
b03c9f9f
EC
1002 reg->var_off = tnum_const(imm);
1003 reg->smin_value = (s64)imm;
1004 reg->smax_value = (s64)imm;
1005 reg->umin_value = imm;
1006 reg->umax_value = imm;
3f50f132
JF
1007
1008 reg->s32_min_value = (s32)imm;
1009 reg->s32_max_value = (s32)imm;
1010 reg->u32_min_value = (u32)imm;
1011 reg->u32_max_value = (u32)imm;
1012}
1013
1014static void __mark_reg32_known(struct bpf_reg_state *reg, u64 imm)
1015{
1016 reg->var_off = tnum_const_subreg(reg->var_off, imm);
1017 reg->s32_min_value = (s32)imm;
1018 reg->s32_max_value = (s32)imm;
1019 reg->u32_min_value = (u32)imm;
1020 reg->u32_max_value = (u32)imm;
b03c9f9f
EC
1021}
1022
f1174f77
EC
1023/* Mark the 'variable offset' part of a register as zero. This should be
1024 * used only on registers holding a pointer type.
1025 */
1026static void __mark_reg_known_zero(struct bpf_reg_state *reg)
a9789ef9 1027{
b03c9f9f 1028 __mark_reg_known(reg, 0);
f1174f77 1029}
a9789ef9 1030
cc2b14d5
AS
1031static void __mark_reg_const_zero(struct bpf_reg_state *reg)
1032{
1033 __mark_reg_known(reg, 0);
cc2b14d5
AS
1034 reg->type = SCALAR_VALUE;
1035}
1036
61bd5218
JK
1037static void mark_reg_known_zero(struct bpf_verifier_env *env,
1038 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
1039{
1040 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 1041 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
f1174f77
EC
1042 /* Something bad happened, let's kill all regs */
1043 for (regno = 0; regno < MAX_BPF_REG; regno++)
f54c7898 1044 __mark_reg_not_init(env, regs + regno);
f1174f77
EC
1045 return;
1046 }
1047 __mark_reg_known_zero(regs + regno);
1048}
1049
de8f3a83
DB
1050static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
1051{
1052 return type_is_pkt_pointer(reg->type);
1053}
1054
1055static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
1056{
1057 return reg_is_pkt_pointer(reg) ||
1058 reg->type == PTR_TO_PACKET_END;
1059}
1060
1061/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
1062static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
1063 enum bpf_reg_type which)
1064{
1065 /* The register can already have a range from prior markings.
1066 * This is fine as long as it hasn't been advanced from its
1067 * origin.
1068 */
1069 return reg->type == which &&
1070 reg->id == 0 &&
1071 reg->off == 0 &&
1072 tnum_equals_const(reg->var_off, 0);
1073}
1074
3f50f132
JF
1075/* Reset the min/max bounds of a register */
1076static void __mark_reg_unbounded(struct bpf_reg_state *reg)
1077{
1078 reg->smin_value = S64_MIN;
1079 reg->smax_value = S64_MAX;
1080 reg->umin_value = 0;
1081 reg->umax_value = U64_MAX;
1082
1083 reg->s32_min_value = S32_MIN;
1084 reg->s32_max_value = S32_MAX;
1085 reg->u32_min_value = 0;
1086 reg->u32_max_value = U32_MAX;
1087}
1088
1089static void __mark_reg64_unbounded(struct bpf_reg_state *reg)
1090{
1091 reg->smin_value = S64_MIN;
1092 reg->smax_value = S64_MAX;
1093 reg->umin_value = 0;
1094 reg->umax_value = U64_MAX;
1095}
1096
1097static void __mark_reg32_unbounded(struct bpf_reg_state *reg)
1098{
1099 reg->s32_min_value = S32_MIN;
1100 reg->s32_max_value = S32_MAX;
1101 reg->u32_min_value = 0;
1102 reg->u32_max_value = U32_MAX;
1103}
1104
1105static void __update_reg32_bounds(struct bpf_reg_state *reg)
1106{
1107 struct tnum var32_off = tnum_subreg(reg->var_off);
1108
1109 /* min signed is max(sign bit) | min(other bits) */
1110 reg->s32_min_value = max_t(s32, reg->s32_min_value,
1111 var32_off.value | (var32_off.mask & S32_MIN));
1112 /* max signed is min(sign bit) | max(other bits) */
1113 reg->s32_max_value = min_t(s32, reg->s32_max_value,
1114 var32_off.value | (var32_off.mask & S32_MAX));
1115 reg->u32_min_value = max_t(u32, reg->u32_min_value, (u32)var32_off.value);
1116 reg->u32_max_value = min(reg->u32_max_value,
1117 (u32)(var32_off.value | var32_off.mask));
1118}
1119
1120static void __update_reg64_bounds(struct bpf_reg_state *reg)
b03c9f9f
EC
1121{
1122 /* min signed is max(sign bit) | min(other bits) */
1123 reg->smin_value = max_t(s64, reg->smin_value,
1124 reg->var_off.value | (reg->var_off.mask & S64_MIN));
1125 /* max signed is min(sign bit) | max(other bits) */
1126 reg->smax_value = min_t(s64, reg->smax_value,
1127 reg->var_off.value | (reg->var_off.mask & S64_MAX));
1128 reg->umin_value = max(reg->umin_value, reg->var_off.value);
1129 reg->umax_value = min(reg->umax_value,
1130 reg->var_off.value | reg->var_off.mask);
1131}
1132
3f50f132
JF
1133static void __update_reg_bounds(struct bpf_reg_state *reg)
1134{
1135 __update_reg32_bounds(reg);
1136 __update_reg64_bounds(reg);
1137}
1138
b03c9f9f 1139/* Uses signed min/max values to inform unsigned, and vice-versa */
3f50f132
JF
1140static void __reg32_deduce_bounds(struct bpf_reg_state *reg)
1141{
1142 /* Learn sign from signed bounds.
1143 * If we cannot cross the sign boundary, then signed and unsigned bounds
1144 * are the same, so combine. This works even in the negative case, e.g.
1145 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
1146 */
1147 if (reg->s32_min_value >= 0 || reg->s32_max_value < 0) {
1148 reg->s32_min_value = reg->u32_min_value =
1149 max_t(u32, reg->s32_min_value, reg->u32_min_value);
1150 reg->s32_max_value = reg->u32_max_value =
1151 min_t(u32, reg->s32_max_value, reg->u32_max_value);
1152 return;
1153 }
1154 /* Learn sign from unsigned bounds. Signed bounds cross the sign
1155 * boundary, so we must be careful.
1156 */
1157 if ((s32)reg->u32_max_value >= 0) {
1158 /* Positive. We can't learn anything from the smin, but smax
1159 * is positive, hence safe.
1160 */
1161 reg->s32_min_value = reg->u32_min_value;
1162 reg->s32_max_value = reg->u32_max_value =
1163 min_t(u32, reg->s32_max_value, reg->u32_max_value);
1164 } else if ((s32)reg->u32_min_value < 0) {
1165 /* Negative. We can't learn anything from the smax, but smin
1166 * is negative, hence safe.
1167 */
1168 reg->s32_min_value = reg->u32_min_value =
1169 max_t(u32, reg->s32_min_value, reg->u32_min_value);
1170 reg->s32_max_value = reg->u32_max_value;
1171 }
1172}
1173
1174static void __reg64_deduce_bounds(struct bpf_reg_state *reg)
b03c9f9f
EC
1175{
1176 /* Learn sign from signed bounds.
1177 * If we cannot cross the sign boundary, then signed and unsigned bounds
1178 * are the same, so combine. This works even in the negative case, e.g.
1179 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
1180 */
1181 if (reg->smin_value >= 0 || reg->smax_value < 0) {
1182 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
1183 reg->umin_value);
1184 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
1185 reg->umax_value);
1186 return;
1187 }
1188 /* Learn sign from unsigned bounds. Signed bounds cross the sign
1189 * boundary, so we must be careful.
1190 */
1191 if ((s64)reg->umax_value >= 0) {
1192 /* Positive. We can't learn anything from the smin, but smax
1193 * is positive, hence safe.
1194 */
1195 reg->smin_value = reg->umin_value;
1196 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
1197 reg->umax_value);
1198 } else if ((s64)reg->umin_value < 0) {
1199 /* Negative. We can't learn anything from the smax, but smin
1200 * is negative, hence safe.
1201 */
1202 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
1203 reg->umin_value);
1204 reg->smax_value = reg->umax_value;
1205 }
1206}
1207
3f50f132
JF
1208static void __reg_deduce_bounds(struct bpf_reg_state *reg)
1209{
1210 __reg32_deduce_bounds(reg);
1211 __reg64_deduce_bounds(reg);
1212}
1213
b03c9f9f
EC
1214/* Attempts to improve var_off based on unsigned min/max information */
1215static void __reg_bound_offset(struct bpf_reg_state *reg)
1216{
3f50f132
JF
1217 struct tnum var64_off = tnum_intersect(reg->var_off,
1218 tnum_range(reg->umin_value,
1219 reg->umax_value));
1220 struct tnum var32_off = tnum_intersect(tnum_subreg(reg->var_off),
1221 tnum_range(reg->u32_min_value,
1222 reg->u32_max_value));
1223
1224 reg->var_off = tnum_or(tnum_clear_subreg(var64_off), var32_off);
b03c9f9f
EC
1225}
1226
3f50f132 1227static void __reg_assign_32_into_64(struct bpf_reg_state *reg)
b03c9f9f 1228{
3f50f132
JF
1229 reg->umin_value = reg->u32_min_value;
1230 reg->umax_value = reg->u32_max_value;
1231 /* Attempt to pull 32-bit signed bounds into 64-bit bounds
1232 * but must be positive otherwise set to worse case bounds
1233 * and refine later from tnum.
1234 */
3a71dc36 1235 if (reg->s32_min_value >= 0 && reg->s32_max_value >= 0)
3f50f132
JF
1236 reg->smax_value = reg->s32_max_value;
1237 else
1238 reg->smax_value = U32_MAX;
3a71dc36
JF
1239 if (reg->s32_min_value >= 0)
1240 reg->smin_value = reg->s32_min_value;
1241 else
1242 reg->smin_value = 0;
3f50f132
JF
1243}
1244
1245static void __reg_combine_32_into_64(struct bpf_reg_state *reg)
1246{
1247 /* special case when 64-bit register has upper 32-bit register
1248 * zeroed. Typically happens after zext or <<32, >>32 sequence
1249 * allowing us to use 32-bit bounds directly,
1250 */
1251 if (tnum_equals_const(tnum_clear_subreg(reg->var_off), 0)) {
1252 __reg_assign_32_into_64(reg);
1253 } else {
1254 /* Otherwise the best we can do is push lower 32bit known and
1255 * unknown bits into register (var_off set from jmp logic)
1256 * then learn as much as possible from the 64-bit tnum
1257 * known and unknown bits. The previous smin/smax bounds are
1258 * invalid here because of jmp32 compare so mark them unknown
1259 * so they do not impact tnum bounds calculation.
1260 */
1261 __mark_reg64_unbounded(reg);
1262 __update_reg_bounds(reg);
1263 }
1264
1265 /* Intersecting with the old var_off might have improved our bounds
1266 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
1267 * then new var_off is (0; 0x7f...fc) which improves our umax.
1268 */
1269 __reg_deduce_bounds(reg);
1270 __reg_bound_offset(reg);
1271 __update_reg_bounds(reg);
1272}
1273
1274static bool __reg64_bound_s32(s64 a)
1275{
1276 if (a > S32_MIN && a < S32_MAX)
1277 return true;
1278 return false;
1279}
1280
1281static bool __reg64_bound_u32(u64 a)
1282{
1283 if (a > U32_MIN && a < U32_MAX)
1284 return true;
1285 return false;
1286}
1287
1288static void __reg_combine_64_into_32(struct bpf_reg_state *reg)
1289{
1290 __mark_reg32_unbounded(reg);
1291
1292 if (__reg64_bound_s32(reg->smin_value))
1293 reg->s32_min_value = (s32)reg->smin_value;
1294 if (__reg64_bound_s32(reg->smax_value))
1295 reg->s32_max_value = (s32)reg->smax_value;
1296 if (__reg64_bound_u32(reg->umin_value))
1297 reg->u32_min_value = (u32)reg->umin_value;
1298 if (__reg64_bound_u32(reg->umax_value))
1299 reg->u32_max_value = (u32)reg->umax_value;
1300
1301 /* Intersecting with the old var_off might have improved our bounds
1302 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
1303 * then new var_off is (0; 0x7f...fc) which improves our umax.
1304 */
1305 __reg_deduce_bounds(reg);
1306 __reg_bound_offset(reg);
1307 __update_reg_bounds(reg);
b03c9f9f
EC
1308}
1309
f1174f77 1310/* Mark a register as having a completely unknown (scalar) value. */
f54c7898
DB
1311static void __mark_reg_unknown(const struct bpf_verifier_env *env,
1312 struct bpf_reg_state *reg)
f1174f77 1313{
a9c676bc
AS
1314 /*
1315 * Clear type, id, off, and union(map_ptr, range) and
1316 * padding between 'type' and union
1317 */
1318 memset(reg, 0, offsetof(struct bpf_reg_state, var_off));
f1174f77 1319 reg->type = SCALAR_VALUE;
f1174f77 1320 reg->var_off = tnum_unknown;
f4d7e40a 1321 reg->frameno = 0;
2c78ee89 1322 reg->precise = env->subprog_cnt > 1 || !env->bpf_capable;
b03c9f9f 1323 __mark_reg_unbounded(reg);
f1174f77
EC
1324}
1325
61bd5218
JK
1326static void mark_reg_unknown(struct bpf_verifier_env *env,
1327 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
1328{
1329 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 1330 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
19ceb417
AS
1331 /* Something bad happened, let's kill all regs except FP */
1332 for (regno = 0; regno < BPF_REG_FP; regno++)
f54c7898 1333 __mark_reg_not_init(env, regs + regno);
f1174f77
EC
1334 return;
1335 }
f54c7898 1336 __mark_reg_unknown(env, regs + regno);
f1174f77
EC
1337}
1338
f54c7898
DB
1339static void __mark_reg_not_init(const struct bpf_verifier_env *env,
1340 struct bpf_reg_state *reg)
f1174f77 1341{
f54c7898 1342 __mark_reg_unknown(env, reg);
f1174f77
EC
1343 reg->type = NOT_INIT;
1344}
1345
61bd5218
JK
1346static void mark_reg_not_init(struct bpf_verifier_env *env,
1347 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
1348{
1349 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 1350 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
19ceb417
AS
1351 /* Something bad happened, let's kill all regs except FP */
1352 for (regno = 0; regno < BPF_REG_FP; regno++)
f54c7898 1353 __mark_reg_not_init(env, regs + regno);
f1174f77
EC
1354 return;
1355 }
f54c7898 1356 __mark_reg_not_init(env, regs + regno);
a9789ef9
DB
1357}
1358
41c48f3a
AI
1359static void mark_btf_ld_reg(struct bpf_verifier_env *env,
1360 struct bpf_reg_state *regs, u32 regno,
1361 enum bpf_reg_type reg_type, u32 btf_id)
1362{
1363 if (reg_type == SCALAR_VALUE) {
1364 mark_reg_unknown(env, regs, regno);
1365 return;
1366 }
1367 mark_reg_known_zero(env, regs, regno);
1368 regs[regno].type = PTR_TO_BTF_ID;
1369 regs[regno].btf_id = btf_id;
1370}
1371
5327ed3d 1372#define DEF_NOT_SUBREG (0)
61bd5218 1373static void init_reg_state(struct bpf_verifier_env *env,
f4d7e40a 1374 struct bpf_func_state *state)
17a52670 1375{
f4d7e40a 1376 struct bpf_reg_state *regs = state->regs;
17a52670
AS
1377 int i;
1378
dc503a8a 1379 for (i = 0; i < MAX_BPF_REG; i++) {
61bd5218 1380 mark_reg_not_init(env, regs, i);
dc503a8a 1381 regs[i].live = REG_LIVE_NONE;
679c782d 1382 regs[i].parent = NULL;
5327ed3d 1383 regs[i].subreg_def = DEF_NOT_SUBREG;
dc503a8a 1384 }
17a52670
AS
1385
1386 /* frame pointer */
f1174f77 1387 regs[BPF_REG_FP].type = PTR_TO_STACK;
61bd5218 1388 mark_reg_known_zero(env, regs, BPF_REG_FP);
f4d7e40a 1389 regs[BPF_REG_FP].frameno = state->frameno;
6760bf2d
DB
1390}
1391
f4d7e40a
AS
1392#define BPF_MAIN_FUNC (-1)
1393static void init_func_state(struct bpf_verifier_env *env,
1394 struct bpf_func_state *state,
1395 int callsite, int frameno, int subprogno)
1396{
1397 state->callsite = callsite;
1398 state->frameno = frameno;
1399 state->subprogno = subprogno;
1400 init_reg_state(env, state);
1401}
1402
17a52670
AS
1403enum reg_arg_type {
1404 SRC_OP, /* register is used as source operand */
1405 DST_OP, /* register is used as destination operand */
1406 DST_OP_NO_MARK /* same as above, check only, don't mark */
1407};
1408
cc8b0b92
AS
1409static int cmp_subprogs(const void *a, const void *b)
1410{
9c8105bd
JW
1411 return ((struct bpf_subprog_info *)a)->start -
1412 ((struct bpf_subprog_info *)b)->start;
cc8b0b92
AS
1413}
1414
1415static int find_subprog(struct bpf_verifier_env *env, int off)
1416{
9c8105bd 1417 struct bpf_subprog_info *p;
cc8b0b92 1418
9c8105bd
JW
1419 p = bsearch(&off, env->subprog_info, env->subprog_cnt,
1420 sizeof(env->subprog_info[0]), cmp_subprogs);
cc8b0b92
AS
1421 if (!p)
1422 return -ENOENT;
9c8105bd 1423 return p - env->subprog_info;
cc8b0b92
AS
1424
1425}
1426
1427static int add_subprog(struct bpf_verifier_env *env, int off)
1428{
1429 int insn_cnt = env->prog->len;
1430 int ret;
1431
1432 if (off >= insn_cnt || off < 0) {
1433 verbose(env, "call to invalid destination\n");
1434 return -EINVAL;
1435 }
1436 ret = find_subprog(env, off);
1437 if (ret >= 0)
1438 return 0;
4cb3d99c 1439 if (env->subprog_cnt >= BPF_MAX_SUBPROGS) {
cc8b0b92
AS
1440 verbose(env, "too many subprograms\n");
1441 return -E2BIG;
1442 }
9c8105bd
JW
1443 env->subprog_info[env->subprog_cnt++].start = off;
1444 sort(env->subprog_info, env->subprog_cnt,
1445 sizeof(env->subprog_info[0]), cmp_subprogs, NULL);
cc8b0b92
AS
1446 return 0;
1447}
1448
1449static int check_subprogs(struct bpf_verifier_env *env)
1450{
1451 int i, ret, subprog_start, subprog_end, off, cur_subprog = 0;
9c8105bd 1452 struct bpf_subprog_info *subprog = env->subprog_info;
cc8b0b92
AS
1453 struct bpf_insn *insn = env->prog->insnsi;
1454 int insn_cnt = env->prog->len;
1455
f910cefa
JW
1456 /* Add entry function. */
1457 ret = add_subprog(env, 0);
1458 if (ret < 0)
1459 return ret;
1460
cc8b0b92
AS
1461 /* determine subprog starts. The end is one before the next starts */
1462 for (i = 0; i < insn_cnt; i++) {
1463 if (insn[i].code != (BPF_JMP | BPF_CALL))
1464 continue;
1465 if (insn[i].src_reg != BPF_PSEUDO_CALL)
1466 continue;
2c78ee89
AS
1467 if (!env->bpf_capable) {
1468 verbose(env,
1469 "function calls to other bpf functions are allowed for CAP_BPF and CAP_SYS_ADMIN\n");
cc8b0b92
AS
1470 return -EPERM;
1471 }
cc8b0b92
AS
1472 ret = add_subprog(env, i + insn[i].imm + 1);
1473 if (ret < 0)
1474 return ret;
1475 }
1476
4cb3d99c
JW
1477 /* Add a fake 'exit' subprog which could simplify subprog iteration
1478 * logic. 'subprog_cnt' should not be increased.
1479 */
1480 subprog[env->subprog_cnt].start = insn_cnt;
1481
06ee7115 1482 if (env->log.level & BPF_LOG_LEVEL2)
cc8b0b92 1483 for (i = 0; i < env->subprog_cnt; i++)
9c8105bd 1484 verbose(env, "func#%d @%d\n", i, subprog[i].start);
cc8b0b92
AS
1485
1486 /* now check that all jumps are within the same subprog */
4cb3d99c
JW
1487 subprog_start = subprog[cur_subprog].start;
1488 subprog_end = subprog[cur_subprog + 1].start;
cc8b0b92
AS
1489 for (i = 0; i < insn_cnt; i++) {
1490 u8 code = insn[i].code;
1491
7f6e4312
MF
1492 if (code == (BPF_JMP | BPF_CALL) &&
1493 insn[i].imm == BPF_FUNC_tail_call &&
1494 insn[i].src_reg != BPF_PSEUDO_CALL)
1495 subprog[cur_subprog].has_tail_call = true;
09b28d76
AS
1496 if (BPF_CLASS(code) == BPF_LD &&
1497 (BPF_MODE(code) == BPF_ABS || BPF_MODE(code) == BPF_IND))
1498 subprog[cur_subprog].has_ld_abs = true;
092ed096 1499 if (BPF_CLASS(code) != BPF_JMP && BPF_CLASS(code) != BPF_JMP32)
cc8b0b92
AS
1500 goto next;
1501 if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
1502 goto next;
1503 off = i + insn[i].off + 1;
1504 if (off < subprog_start || off >= subprog_end) {
1505 verbose(env, "jump out of range from insn %d to %d\n", i, off);
1506 return -EINVAL;
1507 }
1508next:
1509 if (i == subprog_end - 1) {
1510 /* to avoid fall-through from one subprog into another
1511 * the last insn of the subprog should be either exit
1512 * or unconditional jump back
1513 */
1514 if (code != (BPF_JMP | BPF_EXIT) &&
1515 code != (BPF_JMP | BPF_JA)) {
1516 verbose(env, "last insn is not an exit or jmp\n");
1517 return -EINVAL;
1518 }
1519 subprog_start = subprog_end;
4cb3d99c
JW
1520 cur_subprog++;
1521 if (cur_subprog < env->subprog_cnt)
9c8105bd 1522 subprog_end = subprog[cur_subprog + 1].start;
cc8b0b92
AS
1523 }
1524 }
1525 return 0;
1526}
1527
679c782d
EC
1528/* Parentage chain of this register (or stack slot) should take care of all
1529 * issues like callee-saved registers, stack slot allocation time, etc.
1530 */
f4d7e40a 1531static int mark_reg_read(struct bpf_verifier_env *env,
679c782d 1532 const struct bpf_reg_state *state,
5327ed3d 1533 struct bpf_reg_state *parent, u8 flag)
f4d7e40a
AS
1534{
1535 bool writes = parent == state->parent; /* Observe write marks */
06ee7115 1536 int cnt = 0;
dc503a8a
EC
1537
1538 while (parent) {
1539 /* if read wasn't screened by an earlier write ... */
679c782d 1540 if (writes && state->live & REG_LIVE_WRITTEN)
dc503a8a 1541 break;
9242b5f5
AS
1542 if (parent->live & REG_LIVE_DONE) {
1543 verbose(env, "verifier BUG type %s var_off %lld off %d\n",
1544 reg_type_str[parent->type],
1545 parent->var_off.value, parent->off);
1546 return -EFAULT;
1547 }
5327ed3d
JW
1548 /* The first condition is more likely to be true than the
1549 * second, checked it first.
1550 */
1551 if ((parent->live & REG_LIVE_READ) == flag ||
1552 parent->live & REG_LIVE_READ64)
25af32da
AS
1553 /* The parentage chain never changes and
1554 * this parent was already marked as LIVE_READ.
1555 * There is no need to keep walking the chain again and
1556 * keep re-marking all parents as LIVE_READ.
1557 * This case happens when the same register is read
1558 * multiple times without writes into it in-between.
5327ed3d
JW
1559 * Also, if parent has the stronger REG_LIVE_READ64 set,
1560 * then no need to set the weak REG_LIVE_READ32.
25af32da
AS
1561 */
1562 break;
dc503a8a 1563 /* ... then we depend on parent's value */
5327ed3d
JW
1564 parent->live |= flag;
1565 /* REG_LIVE_READ64 overrides REG_LIVE_READ32. */
1566 if (flag == REG_LIVE_READ64)
1567 parent->live &= ~REG_LIVE_READ32;
dc503a8a
EC
1568 state = parent;
1569 parent = state->parent;
f4d7e40a 1570 writes = true;
06ee7115 1571 cnt++;
dc503a8a 1572 }
06ee7115
AS
1573
1574 if (env->longest_mark_read_walk < cnt)
1575 env->longest_mark_read_walk = cnt;
f4d7e40a 1576 return 0;
dc503a8a
EC
1577}
1578
5327ed3d
JW
1579/* This function is supposed to be used by the following 32-bit optimization
1580 * code only. It returns TRUE if the source or destination register operates
1581 * on 64-bit, otherwise return FALSE.
1582 */
1583static bool is_reg64(struct bpf_verifier_env *env, struct bpf_insn *insn,
1584 u32 regno, struct bpf_reg_state *reg, enum reg_arg_type t)
1585{
1586 u8 code, class, op;
1587
1588 code = insn->code;
1589 class = BPF_CLASS(code);
1590 op = BPF_OP(code);
1591 if (class == BPF_JMP) {
1592 /* BPF_EXIT for "main" will reach here. Return TRUE
1593 * conservatively.
1594 */
1595 if (op == BPF_EXIT)
1596 return true;
1597 if (op == BPF_CALL) {
1598 /* BPF to BPF call will reach here because of marking
1599 * caller saved clobber with DST_OP_NO_MARK for which we
1600 * don't care the register def because they are anyway
1601 * marked as NOT_INIT already.
1602 */
1603 if (insn->src_reg == BPF_PSEUDO_CALL)
1604 return false;
1605 /* Helper call will reach here because of arg type
1606 * check, conservatively return TRUE.
1607 */
1608 if (t == SRC_OP)
1609 return true;
1610
1611 return false;
1612 }
1613 }
1614
1615 if (class == BPF_ALU64 || class == BPF_JMP ||
1616 /* BPF_END always use BPF_ALU class. */
1617 (class == BPF_ALU && op == BPF_END && insn->imm == 64))
1618 return true;
1619
1620 if (class == BPF_ALU || class == BPF_JMP32)
1621 return false;
1622
1623 if (class == BPF_LDX) {
1624 if (t != SRC_OP)
1625 return BPF_SIZE(code) == BPF_DW;
1626 /* LDX source must be ptr. */
1627 return true;
1628 }
1629
1630 if (class == BPF_STX) {
1631 if (reg->type != SCALAR_VALUE)
1632 return true;
1633 return BPF_SIZE(code) == BPF_DW;
1634 }
1635
1636 if (class == BPF_LD) {
1637 u8 mode = BPF_MODE(code);
1638
1639 /* LD_IMM64 */
1640 if (mode == BPF_IMM)
1641 return true;
1642
1643 /* Both LD_IND and LD_ABS return 32-bit data. */
1644 if (t != SRC_OP)
1645 return false;
1646
1647 /* Implicit ctx ptr. */
1648 if (regno == BPF_REG_6)
1649 return true;
1650
1651 /* Explicit source could be any width. */
1652 return true;
1653 }
1654
1655 if (class == BPF_ST)
1656 /* The only source register for BPF_ST is a ptr. */
1657 return true;
1658
1659 /* Conservatively return true at default. */
1660 return true;
1661}
1662
b325fbca
JW
1663/* Return TRUE if INSN doesn't have explicit value define. */
1664static bool insn_no_def(struct bpf_insn *insn)
1665{
1666 u8 class = BPF_CLASS(insn->code);
1667
1668 return (class == BPF_JMP || class == BPF_JMP32 ||
1669 class == BPF_STX || class == BPF_ST);
1670}
1671
1672/* Return TRUE if INSN has defined any 32-bit value explicitly. */
1673static bool insn_has_def32(struct bpf_verifier_env *env, struct bpf_insn *insn)
1674{
1675 if (insn_no_def(insn))
1676 return false;
1677
1678 return !is_reg64(env, insn, insn->dst_reg, NULL, DST_OP);
1679}
1680
5327ed3d
JW
1681static void mark_insn_zext(struct bpf_verifier_env *env,
1682 struct bpf_reg_state *reg)
1683{
1684 s32 def_idx = reg->subreg_def;
1685
1686 if (def_idx == DEF_NOT_SUBREG)
1687 return;
1688
1689 env->insn_aux_data[def_idx - 1].zext_dst = true;
1690 /* The dst will be zero extended, so won't be sub-register anymore. */
1691 reg->subreg_def = DEF_NOT_SUBREG;
1692}
1693
dc503a8a 1694static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
17a52670
AS
1695 enum reg_arg_type t)
1696{
f4d7e40a
AS
1697 struct bpf_verifier_state *vstate = env->cur_state;
1698 struct bpf_func_state *state = vstate->frame[vstate->curframe];
5327ed3d 1699 struct bpf_insn *insn = env->prog->insnsi + env->insn_idx;
c342dc10 1700 struct bpf_reg_state *reg, *regs = state->regs;
5327ed3d 1701 bool rw64;
dc503a8a 1702
17a52670 1703 if (regno >= MAX_BPF_REG) {
61bd5218 1704 verbose(env, "R%d is invalid\n", regno);
17a52670
AS
1705 return -EINVAL;
1706 }
1707
c342dc10 1708 reg = &regs[regno];
5327ed3d 1709 rw64 = is_reg64(env, insn, regno, reg, t);
17a52670
AS
1710 if (t == SRC_OP) {
1711 /* check whether register used as source operand can be read */
c342dc10 1712 if (reg->type == NOT_INIT) {
61bd5218 1713 verbose(env, "R%d !read_ok\n", regno);
17a52670
AS
1714 return -EACCES;
1715 }
679c782d 1716 /* We don't need to worry about FP liveness because it's read-only */
c342dc10
JW
1717 if (regno == BPF_REG_FP)
1718 return 0;
1719
5327ed3d
JW
1720 if (rw64)
1721 mark_insn_zext(env, reg);
1722
1723 return mark_reg_read(env, reg, reg->parent,
1724 rw64 ? REG_LIVE_READ64 : REG_LIVE_READ32);
17a52670
AS
1725 } else {
1726 /* check whether register used as dest operand can be written to */
1727 if (regno == BPF_REG_FP) {
61bd5218 1728 verbose(env, "frame pointer is read only\n");
17a52670
AS
1729 return -EACCES;
1730 }
c342dc10 1731 reg->live |= REG_LIVE_WRITTEN;
5327ed3d 1732 reg->subreg_def = rw64 ? DEF_NOT_SUBREG : env->insn_idx + 1;
17a52670 1733 if (t == DST_OP)
61bd5218 1734 mark_reg_unknown(env, regs, regno);
17a52670
AS
1735 }
1736 return 0;
1737}
1738
b5dc0163
AS
1739/* for any branch, call, exit record the history of jmps in the given state */
1740static int push_jmp_history(struct bpf_verifier_env *env,
1741 struct bpf_verifier_state *cur)
1742{
1743 u32 cnt = cur->jmp_history_cnt;
1744 struct bpf_idx_pair *p;
1745
1746 cnt++;
1747 p = krealloc(cur->jmp_history, cnt * sizeof(*p), GFP_USER);
1748 if (!p)
1749 return -ENOMEM;
1750 p[cnt - 1].idx = env->insn_idx;
1751 p[cnt - 1].prev_idx = env->prev_insn_idx;
1752 cur->jmp_history = p;
1753 cur->jmp_history_cnt = cnt;
1754 return 0;
1755}
1756
1757/* Backtrack one insn at a time. If idx is not at the top of recorded
1758 * history then previous instruction came from straight line execution.
1759 */
1760static int get_prev_insn_idx(struct bpf_verifier_state *st, int i,
1761 u32 *history)
1762{
1763 u32 cnt = *history;
1764
1765 if (cnt && st->jmp_history[cnt - 1].idx == i) {
1766 i = st->jmp_history[cnt - 1].prev_idx;
1767 (*history)--;
1768 } else {
1769 i--;
1770 }
1771 return i;
1772}
1773
1774/* For given verifier state backtrack_insn() is called from the last insn to
1775 * the first insn. Its purpose is to compute a bitmask of registers and
1776 * stack slots that needs precision in the parent verifier state.
1777 */
1778static int backtrack_insn(struct bpf_verifier_env *env, int idx,
1779 u32 *reg_mask, u64 *stack_mask)
1780{
1781 const struct bpf_insn_cbs cbs = {
1782 .cb_print = verbose,
1783 .private_data = env,
1784 };
1785 struct bpf_insn *insn = env->prog->insnsi + idx;
1786 u8 class = BPF_CLASS(insn->code);
1787 u8 opcode = BPF_OP(insn->code);
1788 u8 mode = BPF_MODE(insn->code);
1789 u32 dreg = 1u << insn->dst_reg;
1790 u32 sreg = 1u << insn->src_reg;
1791 u32 spi;
1792
1793 if (insn->code == 0)
1794 return 0;
1795 if (env->log.level & BPF_LOG_LEVEL) {
1796 verbose(env, "regs=%x stack=%llx before ", *reg_mask, *stack_mask);
1797 verbose(env, "%d: ", idx);
1798 print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
1799 }
1800
1801 if (class == BPF_ALU || class == BPF_ALU64) {
1802 if (!(*reg_mask & dreg))
1803 return 0;
1804 if (opcode == BPF_MOV) {
1805 if (BPF_SRC(insn->code) == BPF_X) {
1806 /* dreg = sreg
1807 * dreg needs precision after this insn
1808 * sreg needs precision before this insn
1809 */
1810 *reg_mask &= ~dreg;
1811 *reg_mask |= sreg;
1812 } else {
1813 /* dreg = K
1814 * dreg needs precision after this insn.
1815 * Corresponding register is already marked
1816 * as precise=true in this verifier state.
1817 * No further markings in parent are necessary
1818 */
1819 *reg_mask &= ~dreg;
1820 }
1821 } else {
1822 if (BPF_SRC(insn->code) == BPF_X) {
1823 /* dreg += sreg
1824 * both dreg and sreg need precision
1825 * before this insn
1826 */
1827 *reg_mask |= sreg;
1828 } /* else dreg += K
1829 * dreg still needs precision before this insn
1830 */
1831 }
1832 } else if (class == BPF_LDX) {
1833 if (!(*reg_mask & dreg))
1834 return 0;
1835 *reg_mask &= ~dreg;
1836
1837 /* scalars can only be spilled into stack w/o losing precision.
1838 * Load from any other memory can be zero extended.
1839 * The desire to keep that precision is already indicated
1840 * by 'precise' mark in corresponding register of this state.
1841 * No further tracking necessary.
1842 */
1843 if (insn->src_reg != BPF_REG_FP)
1844 return 0;
1845 if (BPF_SIZE(insn->code) != BPF_DW)
1846 return 0;
1847
1848 /* dreg = *(u64 *)[fp - off] was a fill from the stack.
1849 * that [fp - off] slot contains scalar that needs to be
1850 * tracked with precision
1851 */
1852 spi = (-insn->off - 1) / BPF_REG_SIZE;
1853 if (spi >= 64) {
1854 verbose(env, "BUG spi %d\n", spi);
1855 WARN_ONCE(1, "verifier backtracking bug");
1856 return -EFAULT;
1857 }
1858 *stack_mask |= 1ull << spi;
b3b50f05 1859 } else if (class == BPF_STX || class == BPF_ST) {
b5dc0163 1860 if (*reg_mask & dreg)
b3b50f05 1861 /* stx & st shouldn't be using _scalar_ dst_reg
b5dc0163
AS
1862 * to access memory. It means backtracking
1863 * encountered a case of pointer subtraction.
1864 */
1865 return -ENOTSUPP;
1866 /* scalars can only be spilled into stack */
1867 if (insn->dst_reg != BPF_REG_FP)
1868 return 0;
1869 if (BPF_SIZE(insn->code) != BPF_DW)
1870 return 0;
1871 spi = (-insn->off - 1) / BPF_REG_SIZE;
1872 if (spi >= 64) {
1873 verbose(env, "BUG spi %d\n", spi);
1874 WARN_ONCE(1, "verifier backtracking bug");
1875 return -EFAULT;
1876 }
1877 if (!(*stack_mask & (1ull << spi)))
1878 return 0;
1879 *stack_mask &= ~(1ull << spi);
b3b50f05
AN
1880 if (class == BPF_STX)
1881 *reg_mask |= sreg;
b5dc0163
AS
1882 } else if (class == BPF_JMP || class == BPF_JMP32) {
1883 if (opcode == BPF_CALL) {
1884 if (insn->src_reg == BPF_PSEUDO_CALL)
1885 return -ENOTSUPP;
1886 /* regular helper call sets R0 */
1887 *reg_mask &= ~1;
1888 if (*reg_mask & 0x3f) {
1889 /* if backtracing was looking for registers R1-R5
1890 * they should have been found already.
1891 */
1892 verbose(env, "BUG regs %x\n", *reg_mask);
1893 WARN_ONCE(1, "verifier backtracking bug");
1894 return -EFAULT;
1895 }
1896 } else if (opcode == BPF_EXIT) {
1897 return -ENOTSUPP;
1898 }
1899 } else if (class == BPF_LD) {
1900 if (!(*reg_mask & dreg))
1901 return 0;
1902 *reg_mask &= ~dreg;
1903 /* It's ld_imm64 or ld_abs or ld_ind.
1904 * For ld_imm64 no further tracking of precision
1905 * into parent is necessary
1906 */
1907 if (mode == BPF_IND || mode == BPF_ABS)
1908 /* to be analyzed */
1909 return -ENOTSUPP;
b5dc0163
AS
1910 }
1911 return 0;
1912}
1913
1914/* the scalar precision tracking algorithm:
1915 * . at the start all registers have precise=false.
1916 * . scalar ranges are tracked as normal through alu and jmp insns.
1917 * . once precise value of the scalar register is used in:
1918 * . ptr + scalar alu
1919 * . if (scalar cond K|scalar)
1920 * . helper_call(.., scalar, ...) where ARG_CONST is expected
1921 * backtrack through the verifier states and mark all registers and
1922 * stack slots with spilled constants that these scalar regisers
1923 * should be precise.
1924 * . during state pruning two registers (or spilled stack slots)
1925 * are equivalent if both are not precise.
1926 *
1927 * Note the verifier cannot simply walk register parentage chain,
1928 * since many different registers and stack slots could have been
1929 * used to compute single precise scalar.
1930 *
1931 * The approach of starting with precise=true for all registers and then
1932 * backtrack to mark a register as not precise when the verifier detects
1933 * that program doesn't care about specific value (e.g., when helper
1934 * takes register as ARG_ANYTHING parameter) is not safe.
1935 *
1936 * It's ok to walk single parentage chain of the verifier states.
1937 * It's possible that this backtracking will go all the way till 1st insn.
1938 * All other branches will be explored for needing precision later.
1939 *
1940 * The backtracking needs to deal with cases like:
1941 * R8=map_value(id=0,off=0,ks=4,vs=1952,imm=0) R9_w=map_value(id=0,off=40,ks=4,vs=1952,imm=0)
1942 * r9 -= r8
1943 * r5 = r9
1944 * if r5 > 0x79f goto pc+7
1945 * R5_w=inv(id=0,umax_value=1951,var_off=(0x0; 0x7ff))
1946 * r5 += 1
1947 * ...
1948 * call bpf_perf_event_output#25
1949 * where .arg5_type = ARG_CONST_SIZE_OR_ZERO
1950 *
1951 * and this case:
1952 * r6 = 1
1953 * call foo // uses callee's r6 inside to compute r0
1954 * r0 += r6
1955 * if r0 == 0 goto
1956 *
1957 * to track above reg_mask/stack_mask needs to be independent for each frame.
1958 *
1959 * Also if parent's curframe > frame where backtracking started,
1960 * the verifier need to mark registers in both frames, otherwise callees
1961 * may incorrectly prune callers. This is similar to
1962 * commit 7640ead93924 ("bpf: verifier: make sure callees don't prune with caller differences")
1963 *
1964 * For now backtracking falls back into conservative marking.
1965 */
1966static void mark_all_scalars_precise(struct bpf_verifier_env *env,
1967 struct bpf_verifier_state *st)
1968{
1969 struct bpf_func_state *func;
1970 struct bpf_reg_state *reg;
1971 int i, j;
1972
1973 /* big hammer: mark all scalars precise in this path.
1974 * pop_stack may still get !precise scalars.
1975 */
1976 for (; st; st = st->parent)
1977 for (i = 0; i <= st->curframe; i++) {
1978 func = st->frame[i];
1979 for (j = 0; j < BPF_REG_FP; j++) {
1980 reg = &func->regs[j];
1981 if (reg->type != SCALAR_VALUE)
1982 continue;
1983 reg->precise = true;
1984 }
1985 for (j = 0; j < func->allocated_stack / BPF_REG_SIZE; j++) {
1986 if (func->stack[j].slot_type[0] != STACK_SPILL)
1987 continue;
1988 reg = &func->stack[j].spilled_ptr;
1989 if (reg->type != SCALAR_VALUE)
1990 continue;
1991 reg->precise = true;
1992 }
1993 }
1994}
1995
a3ce685d
AS
1996static int __mark_chain_precision(struct bpf_verifier_env *env, int regno,
1997 int spi)
b5dc0163
AS
1998{
1999 struct bpf_verifier_state *st = env->cur_state;
2000 int first_idx = st->first_insn_idx;
2001 int last_idx = env->insn_idx;
2002 struct bpf_func_state *func;
2003 struct bpf_reg_state *reg;
a3ce685d
AS
2004 u32 reg_mask = regno >= 0 ? 1u << regno : 0;
2005 u64 stack_mask = spi >= 0 ? 1ull << spi : 0;
b5dc0163 2006 bool skip_first = true;
a3ce685d 2007 bool new_marks = false;
b5dc0163
AS
2008 int i, err;
2009
2c78ee89 2010 if (!env->bpf_capable)
b5dc0163
AS
2011 return 0;
2012
2013 func = st->frame[st->curframe];
a3ce685d
AS
2014 if (regno >= 0) {
2015 reg = &func->regs[regno];
2016 if (reg->type != SCALAR_VALUE) {
2017 WARN_ONCE(1, "backtracing misuse");
2018 return -EFAULT;
2019 }
2020 if (!reg->precise)
2021 new_marks = true;
2022 else
2023 reg_mask = 0;
2024 reg->precise = true;
b5dc0163 2025 }
b5dc0163 2026
a3ce685d
AS
2027 while (spi >= 0) {
2028 if (func->stack[spi].slot_type[0] != STACK_SPILL) {
2029 stack_mask = 0;
2030 break;
2031 }
2032 reg = &func->stack[spi].spilled_ptr;
2033 if (reg->type != SCALAR_VALUE) {
2034 stack_mask = 0;
2035 break;
2036 }
2037 if (!reg->precise)
2038 new_marks = true;
2039 else
2040 stack_mask = 0;
2041 reg->precise = true;
2042 break;
2043 }
2044
2045 if (!new_marks)
2046 return 0;
2047 if (!reg_mask && !stack_mask)
2048 return 0;
b5dc0163
AS
2049 for (;;) {
2050 DECLARE_BITMAP(mask, 64);
b5dc0163
AS
2051 u32 history = st->jmp_history_cnt;
2052
2053 if (env->log.level & BPF_LOG_LEVEL)
2054 verbose(env, "last_idx %d first_idx %d\n", last_idx, first_idx);
2055 for (i = last_idx;;) {
2056 if (skip_first) {
2057 err = 0;
2058 skip_first = false;
2059 } else {
2060 err = backtrack_insn(env, i, &reg_mask, &stack_mask);
2061 }
2062 if (err == -ENOTSUPP) {
2063 mark_all_scalars_precise(env, st);
2064 return 0;
2065 } else if (err) {
2066 return err;
2067 }
2068 if (!reg_mask && !stack_mask)
2069 /* Found assignment(s) into tracked register in this state.
2070 * Since this state is already marked, just return.
2071 * Nothing to be tracked further in the parent state.
2072 */
2073 return 0;
2074 if (i == first_idx)
2075 break;
2076 i = get_prev_insn_idx(st, i, &history);
2077 if (i >= env->prog->len) {
2078 /* This can happen if backtracking reached insn 0
2079 * and there are still reg_mask or stack_mask
2080 * to backtrack.
2081 * It means the backtracking missed the spot where
2082 * particular register was initialized with a constant.
2083 */
2084 verbose(env, "BUG backtracking idx %d\n", i);
2085 WARN_ONCE(1, "verifier backtracking bug");
2086 return -EFAULT;
2087 }
2088 }
2089 st = st->parent;
2090 if (!st)
2091 break;
2092
a3ce685d 2093 new_marks = false;
b5dc0163
AS
2094 func = st->frame[st->curframe];
2095 bitmap_from_u64(mask, reg_mask);
2096 for_each_set_bit(i, mask, 32) {
2097 reg = &func->regs[i];
a3ce685d
AS
2098 if (reg->type != SCALAR_VALUE) {
2099 reg_mask &= ~(1u << i);
b5dc0163 2100 continue;
a3ce685d 2101 }
b5dc0163
AS
2102 if (!reg->precise)
2103 new_marks = true;
2104 reg->precise = true;
2105 }
2106
2107 bitmap_from_u64(mask, stack_mask);
2108 for_each_set_bit(i, mask, 64) {
2109 if (i >= func->allocated_stack / BPF_REG_SIZE) {
2339cd6c
AS
2110 /* the sequence of instructions:
2111 * 2: (bf) r3 = r10
2112 * 3: (7b) *(u64 *)(r3 -8) = r0
2113 * 4: (79) r4 = *(u64 *)(r10 -8)
2114 * doesn't contain jmps. It's backtracked
2115 * as a single block.
2116 * During backtracking insn 3 is not recognized as
2117 * stack access, so at the end of backtracking
2118 * stack slot fp-8 is still marked in stack_mask.
2119 * However the parent state may not have accessed
2120 * fp-8 and it's "unallocated" stack space.
2121 * In such case fallback to conservative.
b5dc0163 2122 */
2339cd6c
AS
2123 mark_all_scalars_precise(env, st);
2124 return 0;
b5dc0163
AS
2125 }
2126
a3ce685d
AS
2127 if (func->stack[i].slot_type[0] != STACK_SPILL) {
2128 stack_mask &= ~(1ull << i);
b5dc0163 2129 continue;
a3ce685d 2130 }
b5dc0163 2131 reg = &func->stack[i].spilled_ptr;
a3ce685d
AS
2132 if (reg->type != SCALAR_VALUE) {
2133 stack_mask &= ~(1ull << i);
b5dc0163 2134 continue;
a3ce685d 2135 }
b5dc0163
AS
2136 if (!reg->precise)
2137 new_marks = true;
2138 reg->precise = true;
2139 }
2140 if (env->log.level & BPF_LOG_LEVEL) {
2141 print_verifier_state(env, func);
2142 verbose(env, "parent %s regs=%x stack=%llx marks\n",
2143 new_marks ? "didn't have" : "already had",
2144 reg_mask, stack_mask);
2145 }
2146
a3ce685d
AS
2147 if (!reg_mask && !stack_mask)
2148 break;
b5dc0163
AS
2149 if (!new_marks)
2150 break;
2151
2152 last_idx = st->last_insn_idx;
2153 first_idx = st->first_insn_idx;
2154 }
2155 return 0;
2156}
2157
a3ce685d
AS
2158static int mark_chain_precision(struct bpf_verifier_env *env, int regno)
2159{
2160 return __mark_chain_precision(env, regno, -1);
2161}
2162
2163static int mark_chain_precision_stack(struct bpf_verifier_env *env, int spi)
2164{
2165 return __mark_chain_precision(env, -1, spi);
2166}
b5dc0163 2167
1be7f75d
AS
2168static bool is_spillable_regtype(enum bpf_reg_type type)
2169{
2170 switch (type) {
2171 case PTR_TO_MAP_VALUE:
2172 case PTR_TO_MAP_VALUE_OR_NULL:
2173 case PTR_TO_STACK:
2174 case PTR_TO_CTX:
969bf05e 2175 case PTR_TO_PACKET:
de8f3a83 2176 case PTR_TO_PACKET_META:
969bf05e 2177 case PTR_TO_PACKET_END:
d58e468b 2178 case PTR_TO_FLOW_KEYS:
1be7f75d 2179 case CONST_PTR_TO_MAP:
c64b7983
JS
2180 case PTR_TO_SOCKET:
2181 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
2182 case PTR_TO_SOCK_COMMON:
2183 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
2184 case PTR_TO_TCP_SOCK:
2185 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 2186 case PTR_TO_XDP_SOCK:
65726b5b 2187 case PTR_TO_BTF_ID:
b121b341 2188 case PTR_TO_BTF_ID_OR_NULL:
afbf21dc
YS
2189 case PTR_TO_RDONLY_BUF:
2190 case PTR_TO_RDONLY_BUF_OR_NULL:
2191 case PTR_TO_RDWR_BUF:
2192 case PTR_TO_RDWR_BUF_OR_NULL:
1be7f75d
AS
2193 return true;
2194 default:
2195 return false;
2196 }
2197}
2198
cc2b14d5
AS
2199/* Does this register contain a constant zero? */
2200static bool register_is_null(struct bpf_reg_state *reg)
2201{
2202 return reg->type == SCALAR_VALUE && tnum_equals_const(reg->var_off, 0);
2203}
2204
f7cf25b2
AS
2205static bool register_is_const(struct bpf_reg_state *reg)
2206{
2207 return reg->type == SCALAR_VALUE && tnum_is_const(reg->var_off);
2208}
2209
6e7e63cb
JH
2210static bool __is_pointer_value(bool allow_ptr_leaks,
2211 const struct bpf_reg_state *reg)
2212{
2213 if (allow_ptr_leaks)
2214 return false;
2215
2216 return reg->type != SCALAR_VALUE;
2217}
2218
f7cf25b2
AS
2219static void save_register_state(struct bpf_func_state *state,
2220 int spi, struct bpf_reg_state *reg)
2221{
2222 int i;
2223
2224 state->stack[spi].spilled_ptr = *reg;
2225 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
2226
2227 for (i = 0; i < BPF_REG_SIZE; i++)
2228 state->stack[spi].slot_type[i] = STACK_SPILL;
2229}
2230
17a52670
AS
2231/* check_stack_read/write functions track spill/fill of registers,
2232 * stack boundary and alignment are checked in check_mem_access()
2233 */
61bd5218 2234static int check_stack_write(struct bpf_verifier_env *env,
f4d7e40a 2235 struct bpf_func_state *state, /* func where register points to */
af86ca4e 2236 int off, int size, int value_regno, int insn_idx)
17a52670 2237{
f4d7e40a 2238 struct bpf_func_state *cur; /* state of the current function */
638f5b90 2239 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
b5dc0163 2240 u32 dst_reg = env->prog->insnsi[insn_idx].dst_reg;
f7cf25b2 2241 struct bpf_reg_state *reg = NULL;
638f5b90 2242
f4d7e40a 2243 err = realloc_func_state(state, round_up(slot + 1, BPF_REG_SIZE),
fd978bf7 2244 state->acquired_refs, true);
638f5b90
AS
2245 if (err)
2246 return err;
9c399760
AS
2247 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
2248 * so it's aligned access and [off, off + size) are within stack limits
2249 */
638f5b90
AS
2250 if (!env->allow_ptr_leaks &&
2251 state->stack[spi].slot_type[0] == STACK_SPILL &&
2252 size != BPF_REG_SIZE) {
2253 verbose(env, "attempt to corrupt spilled pointer on stack\n");
2254 return -EACCES;
2255 }
17a52670 2256
f4d7e40a 2257 cur = env->cur_state->frame[env->cur_state->curframe];
f7cf25b2
AS
2258 if (value_regno >= 0)
2259 reg = &cur->regs[value_regno];
17a52670 2260
f7cf25b2 2261 if (reg && size == BPF_REG_SIZE && register_is_const(reg) &&
2c78ee89 2262 !register_is_null(reg) && env->bpf_capable) {
b5dc0163
AS
2263 if (dst_reg != BPF_REG_FP) {
2264 /* The backtracking logic can only recognize explicit
2265 * stack slot address like [fp - 8]. Other spill of
2266 * scalar via different register has to be conervative.
2267 * Backtrack from here and mark all registers as precise
2268 * that contributed into 'reg' being a constant.
2269 */
2270 err = mark_chain_precision(env, value_regno);
2271 if (err)
2272 return err;
2273 }
f7cf25b2
AS
2274 save_register_state(state, spi, reg);
2275 } else if (reg && is_spillable_regtype(reg->type)) {
17a52670 2276 /* register containing pointer is being spilled into stack */
9c399760 2277 if (size != BPF_REG_SIZE) {
f7cf25b2 2278 verbose_linfo(env, insn_idx, "; ");
61bd5218 2279 verbose(env, "invalid size of register spill\n");
17a52670
AS
2280 return -EACCES;
2281 }
2282
f7cf25b2 2283 if (state != cur && reg->type == PTR_TO_STACK) {
f4d7e40a
AS
2284 verbose(env, "cannot spill pointers to stack into stack frame of the caller\n");
2285 return -EINVAL;
2286 }
2287
2c78ee89 2288 if (!env->bypass_spec_v4) {
f7cf25b2 2289 bool sanitize = false;
17a52670 2290
f7cf25b2
AS
2291 if (state->stack[spi].slot_type[0] == STACK_SPILL &&
2292 register_is_const(&state->stack[spi].spilled_ptr))
2293 sanitize = true;
2294 for (i = 0; i < BPF_REG_SIZE; i++)
2295 if (state->stack[spi].slot_type[i] == STACK_MISC) {
2296 sanitize = true;
2297 break;
2298 }
2299 if (sanitize) {
af86ca4e
AS
2300 int *poff = &env->insn_aux_data[insn_idx].sanitize_stack_off;
2301 int soff = (-spi - 1) * BPF_REG_SIZE;
2302
2303 /* detected reuse of integer stack slot with a pointer
2304 * which means either llvm is reusing stack slot or
2305 * an attacker is trying to exploit CVE-2018-3639
2306 * (speculative store bypass)
2307 * Have to sanitize that slot with preemptive
2308 * store of zero.
2309 */
2310 if (*poff && *poff != soff) {
2311 /* disallow programs where single insn stores
2312 * into two different stack slots, since verifier
2313 * cannot sanitize them
2314 */
2315 verbose(env,
2316 "insn %d cannot access two stack slots fp%d and fp%d",
2317 insn_idx, *poff, soff);
2318 return -EINVAL;
2319 }
2320 *poff = soff;
2321 }
af86ca4e 2322 }
f7cf25b2 2323 save_register_state(state, spi, reg);
9c399760 2324 } else {
cc2b14d5
AS
2325 u8 type = STACK_MISC;
2326
679c782d
EC
2327 /* regular write of data into stack destroys any spilled ptr */
2328 state->stack[spi].spilled_ptr.type = NOT_INIT;
0bae2d4d
JW
2329 /* Mark slots as STACK_MISC if they belonged to spilled ptr. */
2330 if (state->stack[spi].slot_type[0] == STACK_SPILL)
2331 for (i = 0; i < BPF_REG_SIZE; i++)
2332 state->stack[spi].slot_type[i] = STACK_MISC;
9c399760 2333
cc2b14d5
AS
2334 /* only mark the slot as written if all 8 bytes were written
2335 * otherwise read propagation may incorrectly stop too soon
2336 * when stack slots are partially written.
2337 * This heuristic means that read propagation will be
2338 * conservative, since it will add reg_live_read marks
2339 * to stack slots all the way to first state when programs
2340 * writes+reads less than 8 bytes
2341 */
2342 if (size == BPF_REG_SIZE)
2343 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
2344
2345 /* when we zero initialize stack slots mark them as such */
b5dc0163
AS
2346 if (reg && register_is_null(reg)) {
2347 /* backtracking doesn't work for STACK_ZERO yet. */
2348 err = mark_chain_precision(env, value_regno);
2349 if (err)
2350 return err;
cc2b14d5 2351 type = STACK_ZERO;
b5dc0163 2352 }
cc2b14d5 2353
0bae2d4d 2354 /* Mark slots affected by this stack write. */
9c399760 2355 for (i = 0; i < size; i++)
638f5b90 2356 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
cc2b14d5 2357 type;
17a52670
AS
2358 }
2359 return 0;
2360}
2361
61bd5218 2362static int check_stack_read(struct bpf_verifier_env *env,
f4d7e40a
AS
2363 struct bpf_func_state *reg_state /* func where register points to */,
2364 int off, int size, int value_regno)
17a52670 2365{
f4d7e40a
AS
2366 struct bpf_verifier_state *vstate = env->cur_state;
2367 struct bpf_func_state *state = vstate->frame[vstate->curframe];
638f5b90 2368 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
f7cf25b2 2369 struct bpf_reg_state *reg;
638f5b90 2370 u8 *stype;
17a52670 2371
f4d7e40a 2372 if (reg_state->allocated_stack <= slot) {
638f5b90
AS
2373 verbose(env, "invalid read from stack off %d+0 size %d\n",
2374 off, size);
2375 return -EACCES;
2376 }
f4d7e40a 2377 stype = reg_state->stack[spi].slot_type;
f7cf25b2 2378 reg = &reg_state->stack[spi].spilled_ptr;
17a52670 2379
638f5b90 2380 if (stype[0] == STACK_SPILL) {
9c399760 2381 if (size != BPF_REG_SIZE) {
f7cf25b2
AS
2382 if (reg->type != SCALAR_VALUE) {
2383 verbose_linfo(env, env->insn_idx, "; ");
2384 verbose(env, "invalid size of register fill\n");
2385 return -EACCES;
2386 }
2387 if (value_regno >= 0) {
2388 mark_reg_unknown(env, state->regs, value_regno);
2389 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
2390 }
2391 mark_reg_read(env, reg, reg->parent, REG_LIVE_READ64);
2392 return 0;
17a52670 2393 }
9c399760 2394 for (i = 1; i < BPF_REG_SIZE; i++) {
638f5b90 2395 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
61bd5218 2396 verbose(env, "corrupted spill memory\n");
17a52670
AS
2397 return -EACCES;
2398 }
2399 }
2400
dc503a8a 2401 if (value_regno >= 0) {
17a52670 2402 /* restore register state from stack */
f7cf25b2 2403 state->regs[value_regno] = *reg;
2f18f62e
AS
2404 /* mark reg as written since spilled pointer state likely
2405 * has its liveness marks cleared by is_state_visited()
2406 * which resets stack/reg liveness for state transitions
2407 */
2408 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
6e7e63cb
JH
2409 } else if (__is_pointer_value(env->allow_ptr_leaks, reg)) {
2410 /* If value_regno==-1, the caller is asking us whether
2411 * it is acceptable to use this value as a SCALAR_VALUE
2412 * (e.g. for XADD).
2413 * We must not allow unprivileged callers to do that
2414 * with spilled pointers.
2415 */
2416 verbose(env, "leaking pointer from stack off %d\n",
2417 off);
2418 return -EACCES;
dc503a8a 2419 }
f7cf25b2 2420 mark_reg_read(env, reg, reg->parent, REG_LIVE_READ64);
17a52670 2421 } else {
cc2b14d5
AS
2422 int zeros = 0;
2423
17a52670 2424 for (i = 0; i < size; i++) {
cc2b14d5
AS
2425 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_MISC)
2426 continue;
2427 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_ZERO) {
2428 zeros++;
2429 continue;
17a52670 2430 }
cc2b14d5
AS
2431 verbose(env, "invalid read from stack off %d+%d size %d\n",
2432 off, i, size);
2433 return -EACCES;
2434 }
f7cf25b2 2435 mark_reg_read(env, reg, reg->parent, REG_LIVE_READ64);
cc2b14d5
AS
2436 if (value_regno >= 0) {
2437 if (zeros == size) {
2438 /* any size read into register is zero extended,
2439 * so the whole register == const_zero
2440 */
2441 __mark_reg_const_zero(&state->regs[value_regno]);
b5dc0163
AS
2442 /* backtracking doesn't support STACK_ZERO yet,
2443 * so mark it precise here, so that later
2444 * backtracking can stop here.
2445 * Backtracking may not need this if this register
2446 * doesn't participate in pointer adjustment.
2447 * Forward propagation of precise flag is not
2448 * necessary either. This mark is only to stop
2449 * backtracking. Any register that contributed
2450 * to const 0 was marked precise before spill.
2451 */
2452 state->regs[value_regno].precise = true;
cc2b14d5
AS
2453 } else {
2454 /* have read misc data from the stack */
2455 mark_reg_unknown(env, state->regs, value_regno);
2456 }
2457 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
17a52670 2458 }
17a52670 2459 }
f7cf25b2 2460 return 0;
17a52670
AS
2461}
2462
e4298d25
DB
2463static int check_stack_access(struct bpf_verifier_env *env,
2464 const struct bpf_reg_state *reg,
2465 int off, int size)
2466{
2467 /* Stack accesses must be at a fixed offset, so that we
2468 * can determine what type of data were returned. See
2469 * check_stack_read().
2470 */
2471 if (!tnum_is_const(reg->var_off)) {
2472 char tn_buf[48];
2473
2474 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
1fbd20f8 2475 verbose(env, "variable stack access var_off=%s off=%d size=%d\n",
e4298d25
DB
2476 tn_buf, off, size);
2477 return -EACCES;
2478 }
2479
2480 if (off >= 0 || off < -MAX_BPF_STACK) {
2481 verbose(env, "invalid stack off=%d size=%d\n", off, size);
2482 return -EACCES;
2483 }
2484
2485 return 0;
2486}
2487
591fe988
DB
2488static int check_map_access_type(struct bpf_verifier_env *env, u32 regno,
2489 int off, int size, enum bpf_access_type type)
2490{
2491 struct bpf_reg_state *regs = cur_regs(env);
2492 struct bpf_map *map = regs[regno].map_ptr;
2493 u32 cap = bpf_map_flags_to_cap(map);
2494
2495 if (type == BPF_WRITE && !(cap & BPF_MAP_CAN_WRITE)) {
2496 verbose(env, "write into map forbidden, value_size=%d off=%d size=%d\n",
2497 map->value_size, off, size);
2498 return -EACCES;
2499 }
2500
2501 if (type == BPF_READ && !(cap & BPF_MAP_CAN_READ)) {
2502 verbose(env, "read from map forbidden, value_size=%d off=%d size=%d\n",
2503 map->value_size, off, size);
2504 return -EACCES;
2505 }
2506
2507 return 0;
2508}
2509
457f4436
AN
2510/* check read/write into memory region (e.g., map value, ringbuf sample, etc) */
2511static int __check_mem_access(struct bpf_verifier_env *env, int regno,
2512 int off, int size, u32 mem_size,
2513 bool zero_size_allowed)
17a52670 2514{
457f4436
AN
2515 bool size_ok = size > 0 || (size == 0 && zero_size_allowed);
2516 struct bpf_reg_state *reg;
2517
2518 if (off >= 0 && size_ok && (u64)off + size <= mem_size)
2519 return 0;
17a52670 2520
457f4436
AN
2521 reg = &cur_regs(env)[regno];
2522 switch (reg->type) {
2523 case PTR_TO_MAP_VALUE:
61bd5218 2524 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
457f4436
AN
2525 mem_size, off, size);
2526 break;
2527 case PTR_TO_PACKET:
2528 case PTR_TO_PACKET_META:
2529 case PTR_TO_PACKET_END:
2530 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
2531 off, size, regno, reg->id, off, mem_size);
2532 break;
2533 case PTR_TO_MEM:
2534 default:
2535 verbose(env, "invalid access to memory, mem_size=%u off=%d size=%d\n",
2536 mem_size, off, size);
17a52670 2537 }
457f4436
AN
2538
2539 return -EACCES;
17a52670
AS
2540}
2541
457f4436
AN
2542/* check read/write into a memory region with possible variable offset */
2543static int check_mem_region_access(struct bpf_verifier_env *env, u32 regno,
2544 int off, int size, u32 mem_size,
2545 bool zero_size_allowed)
dbcfe5f7 2546{
f4d7e40a
AS
2547 struct bpf_verifier_state *vstate = env->cur_state;
2548 struct bpf_func_state *state = vstate->frame[vstate->curframe];
dbcfe5f7
GB
2549 struct bpf_reg_state *reg = &state->regs[regno];
2550 int err;
2551
457f4436 2552 /* We may have adjusted the register pointing to memory region, so we
f1174f77
EC
2553 * need to try adding each of min_value and max_value to off
2554 * to make sure our theoretical access will be safe.
dbcfe5f7 2555 */
06ee7115 2556 if (env->log.level & BPF_LOG_LEVEL)
61bd5218 2557 print_verifier_state(env, state);
b7137c4e 2558
dbcfe5f7
GB
2559 /* The minimum value is only important with signed
2560 * comparisons where we can't assume the floor of a
2561 * value is 0. If we are using signed variables for our
2562 * index'es we need to make sure that whatever we use
2563 * will have a set floor within our range.
2564 */
b7137c4e
DB
2565 if (reg->smin_value < 0 &&
2566 (reg->smin_value == S64_MIN ||
2567 (off + reg->smin_value != (s64)(s32)(off + reg->smin_value)) ||
2568 reg->smin_value + off < 0)) {
61bd5218 2569 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
dbcfe5f7
GB
2570 regno);
2571 return -EACCES;
2572 }
457f4436
AN
2573 err = __check_mem_access(env, regno, reg->smin_value + off, size,
2574 mem_size, zero_size_allowed);
dbcfe5f7 2575 if (err) {
457f4436 2576 verbose(env, "R%d min value is outside of the allowed memory range\n",
61bd5218 2577 regno);
dbcfe5f7
GB
2578 return err;
2579 }
2580
b03c9f9f
EC
2581 /* If we haven't set a max value then we need to bail since we can't be
2582 * sure we won't do bad things.
2583 * If reg->umax_value + off could overflow, treat that as unbounded too.
dbcfe5f7 2584 */
b03c9f9f 2585 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
457f4436 2586 verbose(env, "R%d unbounded memory access, make sure to bounds check any such access\n",
dbcfe5f7
GB
2587 regno);
2588 return -EACCES;
2589 }
457f4436
AN
2590 err = __check_mem_access(env, regno, reg->umax_value + off, size,
2591 mem_size, zero_size_allowed);
2592 if (err) {
2593 verbose(env, "R%d max value is outside of the allowed memory range\n",
61bd5218 2594 regno);
457f4436
AN
2595 return err;
2596 }
2597
2598 return 0;
2599}
d83525ca 2600
457f4436
AN
2601/* check read/write into a map element with possible variable offset */
2602static int check_map_access(struct bpf_verifier_env *env, u32 regno,
2603 int off, int size, bool zero_size_allowed)
2604{
2605 struct bpf_verifier_state *vstate = env->cur_state;
2606 struct bpf_func_state *state = vstate->frame[vstate->curframe];
2607 struct bpf_reg_state *reg = &state->regs[regno];
2608 struct bpf_map *map = reg->map_ptr;
2609 int err;
2610
2611 err = check_mem_region_access(env, regno, off, size, map->value_size,
2612 zero_size_allowed);
2613 if (err)
2614 return err;
2615
2616 if (map_value_has_spin_lock(map)) {
2617 u32 lock = map->spin_lock_off;
d83525ca
AS
2618
2619 /* if any part of struct bpf_spin_lock can be touched by
2620 * load/store reject this program.
2621 * To check that [x1, x2) overlaps with [y1, y2)
2622 * it is sufficient to check x1 < y2 && y1 < x2.
2623 */
2624 if (reg->smin_value + off < lock + sizeof(struct bpf_spin_lock) &&
2625 lock < reg->umax_value + off + size) {
2626 verbose(env, "bpf_spin_lock cannot be accessed directly by load/store\n");
2627 return -EACCES;
2628 }
2629 }
f1174f77 2630 return err;
dbcfe5f7
GB
2631}
2632
969bf05e
AS
2633#define MAX_PACKET_OFF 0xffff
2634
7e40781c
UP
2635static enum bpf_prog_type resolve_prog_type(struct bpf_prog *prog)
2636{
2637 return prog->aux->linked_prog ? prog->aux->linked_prog->type
2638 : prog->type;
2639}
2640
58e2af8b 2641static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
3a0af8fd
TG
2642 const struct bpf_call_arg_meta *meta,
2643 enum bpf_access_type t)
4acf6c0b 2644{
7e40781c
UP
2645 enum bpf_prog_type prog_type = resolve_prog_type(env->prog);
2646
2647 switch (prog_type) {
5d66fa7d 2648 /* Program types only with direct read access go here! */
3a0af8fd
TG
2649 case BPF_PROG_TYPE_LWT_IN:
2650 case BPF_PROG_TYPE_LWT_OUT:
004d4b27 2651 case BPF_PROG_TYPE_LWT_SEG6LOCAL:
2dbb9b9e 2652 case BPF_PROG_TYPE_SK_REUSEPORT:
5d66fa7d 2653 case BPF_PROG_TYPE_FLOW_DISSECTOR:
d5563d36 2654 case BPF_PROG_TYPE_CGROUP_SKB:
3a0af8fd
TG
2655 if (t == BPF_WRITE)
2656 return false;
7e57fbb2 2657 /* fallthrough */
5d66fa7d
DB
2658
2659 /* Program types with direct read + write access go here! */
36bbef52
DB
2660 case BPF_PROG_TYPE_SCHED_CLS:
2661 case BPF_PROG_TYPE_SCHED_ACT:
4acf6c0b 2662 case BPF_PROG_TYPE_XDP:
3a0af8fd 2663 case BPF_PROG_TYPE_LWT_XMIT:
8a31db56 2664 case BPF_PROG_TYPE_SK_SKB:
4f738adb 2665 case BPF_PROG_TYPE_SK_MSG:
36bbef52
DB
2666 if (meta)
2667 return meta->pkt_access;
2668
2669 env->seen_direct_write = true;
4acf6c0b 2670 return true;
0d01da6a
SF
2671
2672 case BPF_PROG_TYPE_CGROUP_SOCKOPT:
2673 if (t == BPF_WRITE)
2674 env->seen_direct_write = true;
2675
2676 return true;
2677
4acf6c0b
BB
2678 default:
2679 return false;
2680 }
2681}
2682
f1174f77 2683static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
9fd29c08 2684 int size, bool zero_size_allowed)
f1174f77 2685{
638f5b90 2686 struct bpf_reg_state *regs = cur_regs(env);
f1174f77
EC
2687 struct bpf_reg_state *reg = &regs[regno];
2688 int err;
2689
2690 /* We may have added a variable offset to the packet pointer; but any
2691 * reg->range we have comes after that. We are only checking the fixed
2692 * offset.
2693 */
2694
2695 /* We don't allow negative numbers, because we aren't tracking enough
2696 * detail to prove they're safe.
2697 */
b03c9f9f 2698 if (reg->smin_value < 0) {
61bd5218 2699 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
f1174f77
EC
2700 regno);
2701 return -EACCES;
2702 }
457f4436
AN
2703 err = __check_mem_access(env, regno, off, size, reg->range,
2704 zero_size_allowed);
f1174f77 2705 if (err) {
61bd5218 2706 verbose(env, "R%d offset is outside of the packet\n", regno);
f1174f77
EC
2707 return err;
2708 }
e647815a 2709
457f4436 2710 /* __check_mem_access has made sure "off + size - 1" is within u16.
e647815a
JW
2711 * reg->umax_value can't be bigger than MAX_PACKET_OFF which is 0xffff,
2712 * otherwise find_good_pkt_pointers would have refused to set range info
457f4436 2713 * that __check_mem_access would have rejected this pkt access.
e647815a
JW
2714 * Therefore, "off + reg->umax_value + size - 1" won't overflow u32.
2715 */
2716 env->prog->aux->max_pkt_offset =
2717 max_t(u32, env->prog->aux->max_pkt_offset,
2718 off + reg->umax_value + size - 1);
2719
f1174f77
EC
2720 return err;
2721}
2722
2723/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
31fd8581 2724static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
9e15db66
AS
2725 enum bpf_access_type t, enum bpf_reg_type *reg_type,
2726 u32 *btf_id)
17a52670 2727{
f96da094
DB
2728 struct bpf_insn_access_aux info = {
2729 .reg_type = *reg_type,
9e15db66 2730 .log = &env->log,
f96da094 2731 };
31fd8581 2732
4f9218aa 2733 if (env->ops->is_valid_access &&
5e43f899 2734 env->ops->is_valid_access(off, size, t, env->prog, &info)) {
f96da094
DB
2735 /* A non zero info.ctx_field_size indicates that this field is a
2736 * candidate for later verifier transformation to load the whole
2737 * field and then apply a mask when accessed with a narrower
2738 * access than actual ctx access size. A zero info.ctx_field_size
2739 * will only allow for whole field access and rejects any other
2740 * type of narrower access.
31fd8581 2741 */
23994631 2742 *reg_type = info.reg_type;
31fd8581 2743
b121b341 2744 if (*reg_type == PTR_TO_BTF_ID || *reg_type == PTR_TO_BTF_ID_OR_NULL)
9e15db66
AS
2745 *btf_id = info.btf_id;
2746 else
2747 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
32bbe007
AS
2748 /* remember the offset of last byte accessed in ctx */
2749 if (env->prog->aux->max_ctx_offset < off + size)
2750 env->prog->aux->max_ctx_offset = off + size;
17a52670 2751 return 0;
32bbe007 2752 }
17a52670 2753
61bd5218 2754 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
17a52670
AS
2755 return -EACCES;
2756}
2757
d58e468b
PP
2758static int check_flow_keys_access(struct bpf_verifier_env *env, int off,
2759 int size)
2760{
2761 if (size < 0 || off < 0 ||
2762 (u64)off + size > sizeof(struct bpf_flow_keys)) {
2763 verbose(env, "invalid access to flow keys off=%d size=%d\n",
2764 off, size);
2765 return -EACCES;
2766 }
2767 return 0;
2768}
2769
5f456649
MKL
2770static int check_sock_access(struct bpf_verifier_env *env, int insn_idx,
2771 u32 regno, int off, int size,
2772 enum bpf_access_type t)
c64b7983
JS
2773{
2774 struct bpf_reg_state *regs = cur_regs(env);
2775 struct bpf_reg_state *reg = &regs[regno];
5f456649 2776 struct bpf_insn_access_aux info = {};
46f8bc92 2777 bool valid;
c64b7983
JS
2778
2779 if (reg->smin_value < 0) {
2780 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
2781 regno);
2782 return -EACCES;
2783 }
2784
46f8bc92
MKL
2785 switch (reg->type) {
2786 case PTR_TO_SOCK_COMMON:
2787 valid = bpf_sock_common_is_valid_access(off, size, t, &info);
2788 break;
2789 case PTR_TO_SOCKET:
2790 valid = bpf_sock_is_valid_access(off, size, t, &info);
2791 break;
655a51e5
MKL
2792 case PTR_TO_TCP_SOCK:
2793 valid = bpf_tcp_sock_is_valid_access(off, size, t, &info);
2794 break;
fada7fdc
JL
2795 case PTR_TO_XDP_SOCK:
2796 valid = bpf_xdp_sock_is_valid_access(off, size, t, &info);
2797 break;
46f8bc92
MKL
2798 default:
2799 valid = false;
c64b7983
JS
2800 }
2801
5f456649 2802
46f8bc92
MKL
2803 if (valid) {
2804 env->insn_aux_data[insn_idx].ctx_field_size =
2805 info.ctx_field_size;
2806 return 0;
2807 }
2808
2809 verbose(env, "R%d invalid %s access off=%d size=%d\n",
2810 regno, reg_type_str[reg->type], off, size);
2811
2812 return -EACCES;
c64b7983
JS
2813}
2814
2a159c6f
DB
2815static struct bpf_reg_state *reg_state(struct bpf_verifier_env *env, int regno)
2816{
2817 return cur_regs(env) + regno;
2818}
2819
4cabc5b1
DB
2820static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
2821{
2a159c6f 2822 return __is_pointer_value(env->allow_ptr_leaks, reg_state(env, regno));
4cabc5b1
DB
2823}
2824
f37a8cb8
DB
2825static bool is_ctx_reg(struct bpf_verifier_env *env, int regno)
2826{
2a159c6f 2827 const struct bpf_reg_state *reg = reg_state(env, regno);
f37a8cb8 2828
46f8bc92
MKL
2829 return reg->type == PTR_TO_CTX;
2830}
2831
2832static bool is_sk_reg(struct bpf_verifier_env *env, int regno)
2833{
2834 const struct bpf_reg_state *reg = reg_state(env, regno);
2835
2836 return type_is_sk_pointer(reg->type);
f37a8cb8
DB
2837}
2838
ca369602
DB
2839static bool is_pkt_reg(struct bpf_verifier_env *env, int regno)
2840{
2a159c6f 2841 const struct bpf_reg_state *reg = reg_state(env, regno);
ca369602
DB
2842
2843 return type_is_pkt_pointer(reg->type);
2844}
2845
4b5defde
DB
2846static bool is_flow_key_reg(struct bpf_verifier_env *env, int regno)
2847{
2848 const struct bpf_reg_state *reg = reg_state(env, regno);
2849
2850 /* Separate to is_ctx_reg() since we still want to allow BPF_ST here. */
2851 return reg->type == PTR_TO_FLOW_KEYS;
2852}
2853
61bd5218
JK
2854static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
2855 const struct bpf_reg_state *reg,
d1174416 2856 int off, int size, bool strict)
969bf05e 2857{
f1174f77 2858 struct tnum reg_off;
e07b98d9 2859 int ip_align;
d1174416
DM
2860
2861 /* Byte size accesses are always allowed. */
2862 if (!strict || size == 1)
2863 return 0;
2864
e4eda884
DM
2865 /* For platforms that do not have a Kconfig enabling
2866 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
2867 * NET_IP_ALIGN is universally set to '2'. And on platforms
2868 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
2869 * to this code only in strict mode where we want to emulate
2870 * the NET_IP_ALIGN==2 checking. Therefore use an
2871 * unconditional IP align value of '2'.
e07b98d9 2872 */
e4eda884 2873 ip_align = 2;
f1174f77
EC
2874
2875 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
2876 if (!tnum_is_aligned(reg_off, size)) {
2877 char tn_buf[48];
2878
2879 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218
JK
2880 verbose(env,
2881 "misaligned packet access off %d+%s+%d+%d size %d\n",
f1174f77 2882 ip_align, tn_buf, reg->off, off, size);
969bf05e
AS
2883 return -EACCES;
2884 }
79adffcd 2885
969bf05e
AS
2886 return 0;
2887}
2888
61bd5218
JK
2889static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
2890 const struct bpf_reg_state *reg,
f1174f77
EC
2891 const char *pointer_desc,
2892 int off, int size, bool strict)
79adffcd 2893{
f1174f77
EC
2894 struct tnum reg_off;
2895
2896 /* Byte size accesses are always allowed. */
2897 if (!strict || size == 1)
2898 return 0;
2899
2900 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
2901 if (!tnum_is_aligned(reg_off, size)) {
2902 char tn_buf[48];
2903
2904 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 2905 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
f1174f77 2906 pointer_desc, tn_buf, reg->off, off, size);
79adffcd
DB
2907 return -EACCES;
2908 }
2909
969bf05e
AS
2910 return 0;
2911}
2912
e07b98d9 2913static int check_ptr_alignment(struct bpf_verifier_env *env,
ca369602
DB
2914 const struct bpf_reg_state *reg, int off,
2915 int size, bool strict_alignment_once)
79adffcd 2916{
ca369602 2917 bool strict = env->strict_alignment || strict_alignment_once;
f1174f77 2918 const char *pointer_desc = "";
d1174416 2919
79adffcd
DB
2920 switch (reg->type) {
2921 case PTR_TO_PACKET:
de8f3a83
DB
2922 case PTR_TO_PACKET_META:
2923 /* Special case, because of NET_IP_ALIGN. Given metadata sits
2924 * right in front, treat it the very same way.
2925 */
61bd5218 2926 return check_pkt_ptr_alignment(env, reg, off, size, strict);
d58e468b
PP
2927 case PTR_TO_FLOW_KEYS:
2928 pointer_desc = "flow keys ";
2929 break;
f1174f77
EC
2930 case PTR_TO_MAP_VALUE:
2931 pointer_desc = "value ";
2932 break;
2933 case PTR_TO_CTX:
2934 pointer_desc = "context ";
2935 break;
2936 case PTR_TO_STACK:
2937 pointer_desc = "stack ";
a5ec6ae1
JH
2938 /* The stack spill tracking logic in check_stack_write()
2939 * and check_stack_read() relies on stack accesses being
2940 * aligned.
2941 */
2942 strict = true;
f1174f77 2943 break;
c64b7983
JS
2944 case PTR_TO_SOCKET:
2945 pointer_desc = "sock ";
2946 break;
46f8bc92
MKL
2947 case PTR_TO_SOCK_COMMON:
2948 pointer_desc = "sock_common ";
2949 break;
655a51e5
MKL
2950 case PTR_TO_TCP_SOCK:
2951 pointer_desc = "tcp_sock ";
2952 break;
fada7fdc
JL
2953 case PTR_TO_XDP_SOCK:
2954 pointer_desc = "xdp_sock ";
2955 break;
79adffcd 2956 default:
f1174f77 2957 break;
79adffcd 2958 }
61bd5218
JK
2959 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
2960 strict);
79adffcd
DB
2961}
2962
f4d7e40a
AS
2963static int update_stack_depth(struct bpf_verifier_env *env,
2964 const struct bpf_func_state *func,
2965 int off)
2966{
9c8105bd 2967 u16 stack = env->subprog_info[func->subprogno].stack_depth;
f4d7e40a
AS
2968
2969 if (stack >= -off)
2970 return 0;
2971
2972 /* update known max for given subprogram */
9c8105bd 2973 env->subprog_info[func->subprogno].stack_depth = -off;
70a87ffe
AS
2974 return 0;
2975}
f4d7e40a 2976
70a87ffe
AS
2977/* starting from main bpf function walk all instructions of the function
2978 * and recursively walk all callees that given function can call.
2979 * Ignore jump and exit insns.
2980 * Since recursion is prevented by check_cfg() this algorithm
2981 * only needs a local stack of MAX_CALL_FRAMES to remember callsites
2982 */
2983static int check_max_stack_depth(struct bpf_verifier_env *env)
2984{
9c8105bd
JW
2985 int depth = 0, frame = 0, idx = 0, i = 0, subprog_end;
2986 struct bpf_subprog_info *subprog = env->subprog_info;
70a87ffe 2987 struct bpf_insn *insn = env->prog->insnsi;
ebf7d1f5 2988 bool tail_call_reachable = false;
70a87ffe
AS
2989 int ret_insn[MAX_CALL_FRAMES];
2990 int ret_prog[MAX_CALL_FRAMES];
ebf7d1f5 2991 int j;
f4d7e40a 2992
70a87ffe 2993process_func:
7f6e4312
MF
2994 /* protect against potential stack overflow that might happen when
2995 * bpf2bpf calls get combined with tailcalls. Limit the caller's stack
2996 * depth for such case down to 256 so that the worst case scenario
2997 * would result in 8k stack size (32 which is tailcall limit * 256 =
2998 * 8k).
2999 *
3000 * To get the idea what might happen, see an example:
3001 * func1 -> sub rsp, 128
3002 * subfunc1 -> sub rsp, 256
3003 * tailcall1 -> add rsp, 256
3004 * func2 -> sub rsp, 192 (total stack size = 128 + 192 = 320)
3005 * subfunc2 -> sub rsp, 64
3006 * subfunc22 -> sub rsp, 128
3007 * tailcall2 -> add rsp, 128
3008 * func3 -> sub rsp, 32 (total stack size 128 + 192 + 64 + 32 = 416)
3009 *
3010 * tailcall will unwind the current stack frame but it will not get rid
3011 * of caller's stack as shown on the example above.
3012 */
3013 if (idx && subprog[idx].has_tail_call && depth >= 256) {
3014 verbose(env,
3015 "tail_calls are not allowed when call stack of previous frames is %d bytes. Too large\n",
3016 depth);
3017 return -EACCES;
3018 }
70a87ffe
AS
3019 /* round up to 32-bytes, since this is granularity
3020 * of interpreter stack size
3021 */
9c8105bd 3022 depth += round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
70a87ffe 3023 if (depth > MAX_BPF_STACK) {
f4d7e40a 3024 verbose(env, "combined stack size of %d calls is %d. Too large\n",
70a87ffe 3025 frame + 1, depth);
f4d7e40a
AS
3026 return -EACCES;
3027 }
70a87ffe 3028continue_func:
4cb3d99c 3029 subprog_end = subprog[idx + 1].start;
70a87ffe
AS
3030 for (; i < subprog_end; i++) {
3031 if (insn[i].code != (BPF_JMP | BPF_CALL))
3032 continue;
3033 if (insn[i].src_reg != BPF_PSEUDO_CALL)
3034 continue;
3035 /* remember insn and function to return to */
3036 ret_insn[frame] = i + 1;
9c8105bd 3037 ret_prog[frame] = idx;
70a87ffe
AS
3038
3039 /* find the callee */
3040 i = i + insn[i].imm + 1;
9c8105bd
JW
3041 idx = find_subprog(env, i);
3042 if (idx < 0) {
70a87ffe
AS
3043 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
3044 i);
3045 return -EFAULT;
3046 }
ebf7d1f5
MF
3047
3048 if (subprog[idx].has_tail_call)
3049 tail_call_reachable = true;
3050
70a87ffe
AS
3051 frame++;
3052 if (frame >= MAX_CALL_FRAMES) {
927cb781
PC
3053 verbose(env, "the call stack of %d frames is too deep !\n",
3054 frame);
3055 return -E2BIG;
70a87ffe
AS
3056 }
3057 goto process_func;
3058 }
ebf7d1f5
MF
3059 /* if tail call got detected across bpf2bpf calls then mark each of the
3060 * currently present subprog frames as tail call reachable subprogs;
3061 * this info will be utilized by JIT so that we will be preserving the
3062 * tail call counter throughout bpf2bpf calls combined with tailcalls
3063 */
3064 if (tail_call_reachable)
3065 for (j = 0; j < frame; j++)
3066 subprog[ret_prog[j]].tail_call_reachable = true;
3067
70a87ffe
AS
3068 /* end of for() loop means the last insn of the 'subprog'
3069 * was reached. Doesn't matter whether it was JA or EXIT
3070 */
3071 if (frame == 0)
3072 return 0;
9c8105bd 3073 depth -= round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
70a87ffe
AS
3074 frame--;
3075 i = ret_insn[frame];
9c8105bd 3076 idx = ret_prog[frame];
70a87ffe 3077 goto continue_func;
f4d7e40a
AS
3078}
3079
19d28fbd 3080#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
3081static int get_callee_stack_depth(struct bpf_verifier_env *env,
3082 const struct bpf_insn *insn, int idx)
3083{
3084 int start = idx + insn->imm + 1, subprog;
3085
3086 subprog = find_subprog(env, start);
3087 if (subprog < 0) {
3088 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
3089 start);
3090 return -EFAULT;
3091 }
9c8105bd 3092 return env->subprog_info[subprog].stack_depth;
1ea47e01 3093}
19d28fbd 3094#endif
1ea47e01 3095
51c39bb1
AS
3096int check_ctx_reg(struct bpf_verifier_env *env,
3097 const struct bpf_reg_state *reg, int regno)
58990d1f
DB
3098{
3099 /* Access to ctx or passing it to a helper is only allowed in
3100 * its original, unmodified form.
3101 */
3102
3103 if (reg->off) {
3104 verbose(env, "dereference of modified ctx ptr R%d off=%d disallowed\n",
3105 regno, reg->off);
3106 return -EACCES;
3107 }
3108
3109 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
3110 char tn_buf[48];
3111
3112 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3113 verbose(env, "variable ctx access var_off=%s disallowed\n", tn_buf);
3114 return -EACCES;
3115 }
3116
3117 return 0;
3118}
3119
afbf21dc
YS
3120static int __check_buffer_access(struct bpf_verifier_env *env,
3121 const char *buf_info,
3122 const struct bpf_reg_state *reg,
3123 int regno, int off, int size)
9df1c28b
MM
3124{
3125 if (off < 0) {
3126 verbose(env,
4fc00b79 3127 "R%d invalid %s buffer access: off=%d, size=%d\n",
afbf21dc 3128 regno, buf_info, off, size);
9df1c28b
MM
3129 return -EACCES;
3130 }
3131 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
3132 char tn_buf[48];
3133
3134 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3135 verbose(env,
4fc00b79 3136 "R%d invalid variable buffer offset: off=%d, var_off=%s\n",
9df1c28b
MM
3137 regno, off, tn_buf);
3138 return -EACCES;
3139 }
afbf21dc
YS
3140
3141 return 0;
3142}
3143
3144static int check_tp_buffer_access(struct bpf_verifier_env *env,
3145 const struct bpf_reg_state *reg,
3146 int regno, int off, int size)
3147{
3148 int err;
3149
3150 err = __check_buffer_access(env, "tracepoint", reg, regno, off, size);
3151 if (err)
3152 return err;
3153
9df1c28b
MM
3154 if (off + size > env->prog->aux->max_tp_access)
3155 env->prog->aux->max_tp_access = off + size;
3156
3157 return 0;
3158}
3159
afbf21dc
YS
3160static int check_buffer_access(struct bpf_verifier_env *env,
3161 const struct bpf_reg_state *reg,
3162 int regno, int off, int size,
3163 bool zero_size_allowed,
3164 const char *buf_info,
3165 u32 *max_access)
3166{
3167 int err;
3168
3169 err = __check_buffer_access(env, buf_info, reg, regno, off, size);
3170 if (err)
3171 return err;
3172
3173 if (off + size > *max_access)
3174 *max_access = off + size;
3175
3176 return 0;
3177}
3178
3f50f132
JF
3179/* BPF architecture zero extends alu32 ops into 64-bit registesr */
3180static void zext_32_to_64(struct bpf_reg_state *reg)
3181{
3182 reg->var_off = tnum_subreg(reg->var_off);
3183 __reg_assign_32_into_64(reg);
3184}
9df1c28b 3185
0c17d1d2
JH
3186/* truncate register to smaller size (in bytes)
3187 * must be called with size < BPF_REG_SIZE
3188 */
3189static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
3190{
3191 u64 mask;
3192
3193 /* clear high bits in bit representation */
3194 reg->var_off = tnum_cast(reg->var_off, size);
3195
3196 /* fix arithmetic bounds */
3197 mask = ((u64)1 << (size * 8)) - 1;
3198 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
3199 reg->umin_value &= mask;
3200 reg->umax_value &= mask;
3201 } else {
3202 reg->umin_value = 0;
3203 reg->umax_value = mask;
3204 }
3205 reg->smin_value = reg->umin_value;
3206 reg->smax_value = reg->umax_value;
3f50f132
JF
3207
3208 /* If size is smaller than 32bit register the 32bit register
3209 * values are also truncated so we push 64-bit bounds into
3210 * 32-bit bounds. Above were truncated < 32-bits already.
3211 */
3212 if (size >= 4)
3213 return;
3214 __reg_combine_64_into_32(reg);
0c17d1d2
JH
3215}
3216
a23740ec
AN
3217static bool bpf_map_is_rdonly(const struct bpf_map *map)
3218{
3219 return (map->map_flags & BPF_F_RDONLY_PROG) && map->frozen;
3220}
3221
3222static int bpf_map_direct_read(struct bpf_map *map, int off, int size, u64 *val)
3223{
3224 void *ptr;
3225 u64 addr;
3226 int err;
3227
3228 err = map->ops->map_direct_value_addr(map, &addr, off);
3229 if (err)
3230 return err;
2dedd7d2 3231 ptr = (void *)(long)addr + off;
a23740ec
AN
3232
3233 switch (size) {
3234 case sizeof(u8):
3235 *val = (u64)*(u8 *)ptr;
3236 break;
3237 case sizeof(u16):
3238 *val = (u64)*(u16 *)ptr;
3239 break;
3240 case sizeof(u32):
3241 *val = (u64)*(u32 *)ptr;
3242 break;
3243 case sizeof(u64):
3244 *val = *(u64 *)ptr;
3245 break;
3246 default:
3247 return -EINVAL;
3248 }
3249 return 0;
3250}
3251
9e15db66
AS
3252static int check_ptr_to_btf_access(struct bpf_verifier_env *env,
3253 struct bpf_reg_state *regs,
3254 int regno, int off, int size,
3255 enum bpf_access_type atype,
3256 int value_regno)
3257{
3258 struct bpf_reg_state *reg = regs + regno;
3259 const struct btf_type *t = btf_type_by_id(btf_vmlinux, reg->btf_id);
3260 const char *tname = btf_name_by_offset(btf_vmlinux, t->name_off);
3261 u32 btf_id;
3262 int ret;
3263
9e15db66
AS
3264 if (off < 0) {
3265 verbose(env,
3266 "R%d is ptr_%s invalid negative access: off=%d\n",
3267 regno, tname, off);
3268 return -EACCES;
3269 }
3270 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
3271 char tn_buf[48];
3272
3273 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3274 verbose(env,
3275 "R%d is ptr_%s invalid variable offset: off=%d, var_off=%s\n",
3276 regno, tname, off, tn_buf);
3277 return -EACCES;
3278 }
3279
27ae7997
MKL
3280 if (env->ops->btf_struct_access) {
3281 ret = env->ops->btf_struct_access(&env->log, t, off, size,
3282 atype, &btf_id);
3283 } else {
3284 if (atype != BPF_READ) {
3285 verbose(env, "only read is supported\n");
3286 return -EACCES;
3287 }
3288
3289 ret = btf_struct_access(&env->log, t, off, size, atype,
3290 &btf_id);
3291 }
3292
9e15db66
AS
3293 if (ret < 0)
3294 return ret;
3295
41c48f3a
AI
3296 if (atype == BPF_READ && value_regno >= 0)
3297 mark_btf_ld_reg(env, regs, value_regno, ret, btf_id);
3298
3299 return 0;
3300}
3301
3302static int check_ptr_to_map_access(struct bpf_verifier_env *env,
3303 struct bpf_reg_state *regs,
3304 int regno, int off, int size,
3305 enum bpf_access_type atype,
3306 int value_regno)
3307{
3308 struct bpf_reg_state *reg = regs + regno;
3309 struct bpf_map *map = reg->map_ptr;
3310 const struct btf_type *t;
3311 const char *tname;
3312 u32 btf_id;
3313 int ret;
3314
3315 if (!btf_vmlinux) {
3316 verbose(env, "map_ptr access not supported without CONFIG_DEBUG_INFO_BTF\n");
3317 return -ENOTSUPP;
3318 }
3319
3320 if (!map->ops->map_btf_id || !*map->ops->map_btf_id) {
3321 verbose(env, "map_ptr access not supported for map type %d\n",
3322 map->map_type);
3323 return -ENOTSUPP;
3324 }
3325
3326 t = btf_type_by_id(btf_vmlinux, *map->ops->map_btf_id);
3327 tname = btf_name_by_offset(btf_vmlinux, t->name_off);
3328
3329 if (!env->allow_ptr_to_map_access) {
3330 verbose(env,
3331 "%s access is allowed only to CAP_PERFMON and CAP_SYS_ADMIN\n",
3332 tname);
3333 return -EPERM;
9e15db66 3334 }
27ae7997 3335
41c48f3a
AI
3336 if (off < 0) {
3337 verbose(env, "R%d is %s invalid negative access: off=%d\n",
3338 regno, tname, off);
3339 return -EACCES;
3340 }
3341
3342 if (atype != BPF_READ) {
3343 verbose(env, "only read from %s is supported\n", tname);
3344 return -EACCES;
3345 }
3346
3347 ret = btf_struct_access(&env->log, t, off, size, atype, &btf_id);
3348 if (ret < 0)
3349 return ret;
3350
3351 if (value_regno >= 0)
3352 mark_btf_ld_reg(env, regs, value_regno, ret, btf_id);
3353
9e15db66
AS
3354 return 0;
3355}
3356
41c48f3a 3357
17a52670
AS
3358/* check whether memory at (regno + off) is accessible for t = (read | write)
3359 * if t==write, value_regno is a register which value is stored into memory
3360 * if t==read, value_regno is a register which will receive the value from memory
3361 * if t==write && value_regno==-1, some unknown value is stored into memory
3362 * if t==read && value_regno==-1, don't care what we read from memory
3363 */
ca369602
DB
3364static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno,
3365 int off, int bpf_size, enum bpf_access_type t,
3366 int value_regno, bool strict_alignment_once)
17a52670 3367{
638f5b90
AS
3368 struct bpf_reg_state *regs = cur_regs(env);
3369 struct bpf_reg_state *reg = regs + regno;
f4d7e40a 3370 struct bpf_func_state *state;
17a52670
AS
3371 int size, err = 0;
3372
3373 size = bpf_size_to_bytes(bpf_size);
3374 if (size < 0)
3375 return size;
3376
f1174f77 3377 /* alignment checks will add in reg->off themselves */
ca369602 3378 err = check_ptr_alignment(env, reg, off, size, strict_alignment_once);
969bf05e
AS
3379 if (err)
3380 return err;
17a52670 3381
f1174f77
EC
3382 /* for access checks, reg->off is just part of off */
3383 off += reg->off;
3384
3385 if (reg->type == PTR_TO_MAP_VALUE) {
1be7f75d
AS
3386 if (t == BPF_WRITE && value_regno >= 0 &&
3387 is_pointer_value(env, value_regno)) {
61bd5218 3388 verbose(env, "R%d leaks addr into map\n", value_regno);
1be7f75d
AS
3389 return -EACCES;
3390 }
591fe988
DB
3391 err = check_map_access_type(env, regno, off, size, t);
3392 if (err)
3393 return err;
9fd29c08 3394 err = check_map_access(env, regno, off, size, false);
a23740ec
AN
3395 if (!err && t == BPF_READ && value_regno >= 0) {
3396 struct bpf_map *map = reg->map_ptr;
3397
3398 /* if map is read-only, track its contents as scalars */
3399 if (tnum_is_const(reg->var_off) &&
3400 bpf_map_is_rdonly(map) &&
3401 map->ops->map_direct_value_addr) {
3402 int map_off = off + reg->var_off.value;
3403 u64 val = 0;
3404
3405 err = bpf_map_direct_read(map, map_off, size,
3406 &val);
3407 if (err)
3408 return err;
3409
3410 regs[value_regno].type = SCALAR_VALUE;
3411 __mark_reg_known(&regs[value_regno], val);
3412 } else {
3413 mark_reg_unknown(env, regs, value_regno);
3414 }
3415 }
457f4436
AN
3416 } else if (reg->type == PTR_TO_MEM) {
3417 if (t == BPF_WRITE && value_regno >= 0 &&
3418 is_pointer_value(env, value_regno)) {
3419 verbose(env, "R%d leaks addr into mem\n", value_regno);
3420 return -EACCES;
3421 }
3422 err = check_mem_region_access(env, regno, off, size,
3423 reg->mem_size, false);
3424 if (!err && t == BPF_READ && value_regno >= 0)
3425 mark_reg_unknown(env, regs, value_regno);
1a0dc1ac 3426 } else if (reg->type == PTR_TO_CTX) {
f1174f77 3427 enum bpf_reg_type reg_type = SCALAR_VALUE;
9e15db66 3428 u32 btf_id = 0;
19de99f7 3429
1be7f75d
AS
3430 if (t == BPF_WRITE && value_regno >= 0 &&
3431 is_pointer_value(env, value_regno)) {
61bd5218 3432 verbose(env, "R%d leaks addr into ctx\n", value_regno);
1be7f75d
AS
3433 return -EACCES;
3434 }
f1174f77 3435
58990d1f
DB
3436 err = check_ctx_reg(env, reg, regno);
3437 if (err < 0)
3438 return err;
3439
9e15db66
AS
3440 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type, &btf_id);
3441 if (err)
3442 verbose_linfo(env, insn_idx, "; ");
969bf05e 3443 if (!err && t == BPF_READ && value_regno >= 0) {
f1174f77 3444 /* ctx access returns either a scalar, or a
de8f3a83
DB
3445 * PTR_TO_PACKET[_META,_END]. In the latter
3446 * case, we know the offset is zero.
f1174f77 3447 */
46f8bc92 3448 if (reg_type == SCALAR_VALUE) {
638f5b90 3449 mark_reg_unknown(env, regs, value_regno);
46f8bc92 3450 } else {
638f5b90 3451 mark_reg_known_zero(env, regs,
61bd5218 3452 value_regno);
46f8bc92
MKL
3453 if (reg_type_may_be_null(reg_type))
3454 regs[value_regno].id = ++env->id_gen;
5327ed3d
JW
3455 /* A load of ctx field could have different
3456 * actual load size with the one encoded in the
3457 * insn. When the dst is PTR, it is for sure not
3458 * a sub-register.
3459 */
3460 regs[value_regno].subreg_def = DEF_NOT_SUBREG;
b121b341
YS
3461 if (reg_type == PTR_TO_BTF_ID ||
3462 reg_type == PTR_TO_BTF_ID_OR_NULL)
9e15db66 3463 regs[value_regno].btf_id = btf_id;
46f8bc92 3464 }
638f5b90 3465 regs[value_regno].type = reg_type;
969bf05e 3466 }
17a52670 3467
f1174f77 3468 } else if (reg->type == PTR_TO_STACK) {
f1174f77 3469 off += reg->var_off.value;
e4298d25
DB
3470 err = check_stack_access(env, reg, off, size);
3471 if (err)
3472 return err;
8726679a 3473
f4d7e40a
AS
3474 state = func(env, reg);
3475 err = update_stack_depth(env, state, off);
3476 if (err)
3477 return err;
8726679a 3478
638f5b90 3479 if (t == BPF_WRITE)
61bd5218 3480 err = check_stack_write(env, state, off, size,
af86ca4e 3481 value_regno, insn_idx);
638f5b90 3482 else
61bd5218
JK
3483 err = check_stack_read(env, state, off, size,
3484 value_regno);
de8f3a83 3485 } else if (reg_is_pkt_pointer(reg)) {
3a0af8fd 3486 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
61bd5218 3487 verbose(env, "cannot write into packet\n");
969bf05e
AS
3488 return -EACCES;
3489 }
4acf6c0b
BB
3490 if (t == BPF_WRITE && value_regno >= 0 &&
3491 is_pointer_value(env, value_regno)) {
61bd5218
JK
3492 verbose(env, "R%d leaks addr into packet\n",
3493 value_regno);
4acf6c0b
BB
3494 return -EACCES;
3495 }
9fd29c08 3496 err = check_packet_access(env, regno, off, size, false);
969bf05e 3497 if (!err && t == BPF_READ && value_regno >= 0)
638f5b90 3498 mark_reg_unknown(env, regs, value_regno);
d58e468b
PP
3499 } else if (reg->type == PTR_TO_FLOW_KEYS) {
3500 if (t == BPF_WRITE && value_regno >= 0 &&
3501 is_pointer_value(env, value_regno)) {
3502 verbose(env, "R%d leaks addr into flow keys\n",
3503 value_regno);
3504 return -EACCES;
3505 }
3506
3507 err = check_flow_keys_access(env, off, size);
3508 if (!err && t == BPF_READ && value_regno >= 0)
3509 mark_reg_unknown(env, regs, value_regno);
46f8bc92 3510 } else if (type_is_sk_pointer(reg->type)) {
c64b7983 3511 if (t == BPF_WRITE) {
46f8bc92
MKL
3512 verbose(env, "R%d cannot write into %s\n",
3513 regno, reg_type_str[reg->type]);
c64b7983
JS
3514 return -EACCES;
3515 }
5f456649 3516 err = check_sock_access(env, insn_idx, regno, off, size, t);
c64b7983
JS
3517 if (!err && value_regno >= 0)
3518 mark_reg_unknown(env, regs, value_regno);
9df1c28b
MM
3519 } else if (reg->type == PTR_TO_TP_BUFFER) {
3520 err = check_tp_buffer_access(env, reg, regno, off, size);
3521 if (!err && t == BPF_READ && value_regno >= 0)
3522 mark_reg_unknown(env, regs, value_regno);
9e15db66
AS
3523 } else if (reg->type == PTR_TO_BTF_ID) {
3524 err = check_ptr_to_btf_access(env, regs, regno, off, size, t,
3525 value_regno);
41c48f3a
AI
3526 } else if (reg->type == CONST_PTR_TO_MAP) {
3527 err = check_ptr_to_map_access(env, regs, regno, off, size, t,
3528 value_regno);
afbf21dc
YS
3529 } else if (reg->type == PTR_TO_RDONLY_BUF) {
3530 if (t == BPF_WRITE) {
3531 verbose(env, "R%d cannot write into %s\n",
3532 regno, reg_type_str[reg->type]);
3533 return -EACCES;
3534 }
f6dfbe31
CIK
3535 err = check_buffer_access(env, reg, regno, off, size, false,
3536 "rdonly",
afbf21dc
YS
3537 &env->prog->aux->max_rdonly_access);
3538 if (!err && value_regno >= 0)
3539 mark_reg_unknown(env, regs, value_regno);
3540 } else if (reg->type == PTR_TO_RDWR_BUF) {
f6dfbe31
CIK
3541 err = check_buffer_access(env, reg, regno, off, size, false,
3542 "rdwr",
afbf21dc
YS
3543 &env->prog->aux->max_rdwr_access);
3544 if (!err && t == BPF_READ && value_regno >= 0)
3545 mark_reg_unknown(env, regs, value_regno);
17a52670 3546 } else {
61bd5218
JK
3547 verbose(env, "R%d invalid mem access '%s'\n", regno,
3548 reg_type_str[reg->type]);
17a52670
AS
3549 return -EACCES;
3550 }
969bf05e 3551
f1174f77 3552 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
638f5b90 3553 regs[value_regno].type == SCALAR_VALUE) {
f1174f77 3554 /* b/h/w load zero-extends, mark upper bits as known 0 */
0c17d1d2 3555 coerce_reg_to_size(&regs[value_regno], size);
969bf05e 3556 }
17a52670
AS
3557 return err;
3558}
3559
31fd8581 3560static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
17a52670 3561{
17a52670
AS
3562 int err;
3563
3564 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
3565 insn->imm != 0) {
61bd5218 3566 verbose(env, "BPF_XADD uses reserved fields\n");
17a52670
AS
3567 return -EINVAL;
3568 }
3569
3570 /* check src1 operand */
dc503a8a 3571 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
3572 if (err)
3573 return err;
3574
3575 /* check src2 operand */
dc503a8a 3576 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
3577 if (err)
3578 return err;
3579
6bdf6abc 3580 if (is_pointer_value(env, insn->src_reg)) {
61bd5218 3581 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
6bdf6abc
DB
3582 return -EACCES;
3583 }
3584
ca369602 3585 if (is_ctx_reg(env, insn->dst_reg) ||
4b5defde 3586 is_pkt_reg(env, insn->dst_reg) ||
46f8bc92
MKL
3587 is_flow_key_reg(env, insn->dst_reg) ||
3588 is_sk_reg(env, insn->dst_reg)) {
ca369602 3589 verbose(env, "BPF_XADD stores into R%d %s is not allowed\n",
2a159c6f
DB
3590 insn->dst_reg,
3591 reg_type_str[reg_state(env, insn->dst_reg)->type]);
f37a8cb8
DB
3592 return -EACCES;
3593 }
3594
17a52670 3595 /* check whether atomic_add can read the memory */
31fd8581 3596 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
ca369602 3597 BPF_SIZE(insn->code), BPF_READ, -1, true);
17a52670
AS
3598 if (err)
3599 return err;
3600
3601 /* check whether atomic_add can write into the same memory */
31fd8581 3602 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
ca369602 3603 BPF_SIZE(insn->code), BPF_WRITE, -1, true);
17a52670
AS
3604}
3605
2011fccf
AI
3606static int __check_stack_boundary(struct bpf_verifier_env *env, u32 regno,
3607 int off, int access_size,
3608 bool zero_size_allowed)
3609{
3610 struct bpf_reg_state *reg = reg_state(env, regno);
3611
3612 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
3613 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
3614 if (tnum_is_const(reg->var_off)) {
3615 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
3616 regno, off, access_size);
3617 } else {
3618 char tn_buf[48];
3619
3620 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3621 verbose(env, "invalid stack type R%d var_off=%s access_size=%d\n",
3622 regno, tn_buf, access_size);
3623 }
3624 return -EACCES;
3625 }
3626 return 0;
3627}
3628
17a52670
AS
3629/* when register 'regno' is passed into function that will read 'access_size'
3630 * bytes from that pointer, make sure that it's within stack boundary
f1174f77
EC
3631 * and all elements of stack are initialized.
3632 * Unlike most pointer bounds-checking functions, this one doesn't take an
3633 * 'off' argument, so it has to add in reg->off itself.
17a52670 3634 */
58e2af8b 3635static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
435faee1
DB
3636 int access_size, bool zero_size_allowed,
3637 struct bpf_call_arg_meta *meta)
17a52670 3638{
2a159c6f 3639 struct bpf_reg_state *reg = reg_state(env, regno);
f4d7e40a 3640 struct bpf_func_state *state = func(env, reg);
f7cf25b2 3641 int err, min_off, max_off, i, j, slot, spi;
17a52670 3642
2011fccf
AI
3643 if (tnum_is_const(reg->var_off)) {
3644 min_off = max_off = reg->var_off.value + reg->off;
3645 err = __check_stack_boundary(env, regno, min_off, access_size,
3646 zero_size_allowed);
3647 if (err)
3648 return err;
3649 } else {
088ec26d
AI
3650 /* Variable offset is prohibited for unprivileged mode for
3651 * simplicity since it requires corresponding support in
3652 * Spectre masking for stack ALU.
3653 * See also retrieve_ptr_limit().
3654 */
2c78ee89 3655 if (!env->bypass_spec_v1) {
088ec26d 3656 char tn_buf[48];
f1174f77 3657
088ec26d
AI
3658 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3659 verbose(env, "R%d indirect variable offset stack access prohibited for !root, var_off=%s\n",
3660 regno, tn_buf);
3661 return -EACCES;
3662 }
f2bcd05e
AI
3663 /* Only initialized buffer on stack is allowed to be accessed
3664 * with variable offset. With uninitialized buffer it's hard to
3665 * guarantee that whole memory is marked as initialized on
3666 * helper return since specific bounds are unknown what may
3667 * cause uninitialized stack leaking.
3668 */
3669 if (meta && meta->raw_mode)
3670 meta = NULL;
3671
107c26a7
AI
3672 if (reg->smax_value >= BPF_MAX_VAR_OFF ||
3673 reg->smax_value <= -BPF_MAX_VAR_OFF) {
3674 verbose(env, "R%d unbounded indirect variable offset stack access\n",
3675 regno);
3676 return -EACCES;
3677 }
2011fccf 3678 min_off = reg->smin_value + reg->off;
107c26a7 3679 max_off = reg->smax_value + reg->off;
2011fccf
AI
3680 err = __check_stack_boundary(env, regno, min_off, access_size,
3681 zero_size_allowed);
107c26a7
AI
3682 if (err) {
3683 verbose(env, "R%d min value is outside of stack bound\n",
3684 regno);
2011fccf 3685 return err;
107c26a7 3686 }
2011fccf
AI
3687 err = __check_stack_boundary(env, regno, max_off, access_size,
3688 zero_size_allowed);
107c26a7
AI
3689 if (err) {
3690 verbose(env, "R%d max value is outside of stack bound\n",
3691 regno);
2011fccf 3692 return err;
107c26a7 3693 }
17a52670
AS
3694 }
3695
435faee1
DB
3696 if (meta && meta->raw_mode) {
3697 meta->access_size = access_size;
3698 meta->regno = regno;
3699 return 0;
3700 }
3701
2011fccf 3702 for (i = min_off; i < max_off + access_size; i++) {
cc2b14d5
AS
3703 u8 *stype;
3704
2011fccf 3705 slot = -i - 1;
638f5b90 3706 spi = slot / BPF_REG_SIZE;
cc2b14d5
AS
3707 if (state->allocated_stack <= slot)
3708 goto err;
3709 stype = &state->stack[spi].slot_type[slot % BPF_REG_SIZE];
3710 if (*stype == STACK_MISC)
3711 goto mark;
3712 if (*stype == STACK_ZERO) {
3713 /* helper can write anything into the stack */
3714 *stype = STACK_MISC;
3715 goto mark;
17a52670 3716 }
1d68f22b
YS
3717
3718 if (state->stack[spi].slot_type[0] == STACK_SPILL &&
3719 state->stack[spi].spilled_ptr.type == PTR_TO_BTF_ID)
3720 goto mark;
3721
f7cf25b2
AS
3722 if (state->stack[spi].slot_type[0] == STACK_SPILL &&
3723 state->stack[spi].spilled_ptr.type == SCALAR_VALUE) {
f54c7898 3724 __mark_reg_unknown(env, &state->stack[spi].spilled_ptr);
f7cf25b2
AS
3725 for (j = 0; j < BPF_REG_SIZE; j++)
3726 state->stack[spi].slot_type[j] = STACK_MISC;
3727 goto mark;
3728 }
3729
cc2b14d5 3730err:
2011fccf
AI
3731 if (tnum_is_const(reg->var_off)) {
3732 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
3733 min_off, i - min_off, access_size);
3734 } else {
3735 char tn_buf[48];
3736
3737 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3738 verbose(env, "invalid indirect read from stack var_off %s+%d size %d\n",
3739 tn_buf, i - min_off, access_size);
3740 }
cc2b14d5
AS
3741 return -EACCES;
3742mark:
3743 /* reading any byte out of 8-byte 'spill_slot' will cause
3744 * the whole slot to be marked as 'read'
3745 */
679c782d 3746 mark_reg_read(env, &state->stack[spi].spilled_ptr,
5327ed3d
JW
3747 state->stack[spi].spilled_ptr.parent,
3748 REG_LIVE_READ64);
17a52670 3749 }
2011fccf 3750 return update_stack_depth(env, state, min_off);
17a52670
AS
3751}
3752
06c1c049
GB
3753static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
3754 int access_size, bool zero_size_allowed,
3755 struct bpf_call_arg_meta *meta)
3756{
638f5b90 3757 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
06c1c049 3758
f1174f77 3759 switch (reg->type) {
06c1c049 3760 case PTR_TO_PACKET:
de8f3a83 3761 case PTR_TO_PACKET_META:
9fd29c08
YS
3762 return check_packet_access(env, regno, reg->off, access_size,
3763 zero_size_allowed);
06c1c049 3764 case PTR_TO_MAP_VALUE:
591fe988
DB
3765 if (check_map_access_type(env, regno, reg->off, access_size,
3766 meta && meta->raw_mode ? BPF_WRITE :
3767 BPF_READ))
3768 return -EACCES;
9fd29c08
YS
3769 return check_map_access(env, regno, reg->off, access_size,
3770 zero_size_allowed);
457f4436
AN
3771 case PTR_TO_MEM:
3772 return check_mem_region_access(env, regno, reg->off,
3773 access_size, reg->mem_size,
3774 zero_size_allowed);
afbf21dc
YS
3775 case PTR_TO_RDONLY_BUF:
3776 if (meta && meta->raw_mode)
3777 return -EACCES;
3778 return check_buffer_access(env, reg, regno, reg->off,
3779 access_size, zero_size_allowed,
3780 "rdonly",
3781 &env->prog->aux->max_rdonly_access);
3782 case PTR_TO_RDWR_BUF:
3783 return check_buffer_access(env, reg, regno, reg->off,
3784 access_size, zero_size_allowed,
3785 "rdwr",
3786 &env->prog->aux->max_rdwr_access);
0d004c02 3787 case PTR_TO_STACK:
06c1c049
GB
3788 return check_stack_boundary(env, regno, access_size,
3789 zero_size_allowed, meta);
0d004c02
LB
3790 default: /* scalar_value or invalid ptr */
3791 /* Allow zero-byte read from NULL, regardless of pointer type */
3792 if (zero_size_allowed && access_size == 0 &&
3793 register_is_null(reg))
3794 return 0;
3795
3796 verbose(env, "R%d type=%s expected=%s\n", regno,
3797 reg_type_str[reg->type],
3798 reg_type_str[PTR_TO_STACK]);
3799 return -EACCES;
06c1c049
GB
3800 }
3801}
3802
d83525ca
AS
3803/* Implementation details:
3804 * bpf_map_lookup returns PTR_TO_MAP_VALUE_OR_NULL
3805 * Two bpf_map_lookups (even with the same key) will have different reg->id.
3806 * For traditional PTR_TO_MAP_VALUE the verifier clears reg->id after
3807 * value_or_null->value transition, since the verifier only cares about
3808 * the range of access to valid map value pointer and doesn't care about actual
3809 * address of the map element.
3810 * For maps with 'struct bpf_spin_lock' inside map value the verifier keeps
3811 * reg->id > 0 after value_or_null->value transition. By doing so
3812 * two bpf_map_lookups will be considered two different pointers that
3813 * point to different bpf_spin_locks.
3814 * The verifier allows taking only one bpf_spin_lock at a time to avoid
3815 * dead-locks.
3816 * Since only one bpf_spin_lock is allowed the checks are simpler than
3817 * reg_is_refcounted() logic. The verifier needs to remember only
3818 * one spin_lock instead of array of acquired_refs.
3819 * cur_state->active_spin_lock remembers which map value element got locked
3820 * and clears it after bpf_spin_unlock.
3821 */
3822static int process_spin_lock(struct bpf_verifier_env *env, int regno,
3823 bool is_lock)
3824{
3825 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
3826 struct bpf_verifier_state *cur = env->cur_state;
3827 bool is_const = tnum_is_const(reg->var_off);
3828 struct bpf_map *map = reg->map_ptr;
3829 u64 val = reg->var_off.value;
3830
3831 if (reg->type != PTR_TO_MAP_VALUE) {
3832 verbose(env, "R%d is not a pointer to map_value\n", regno);
3833 return -EINVAL;
3834 }
3835 if (!is_const) {
3836 verbose(env,
3837 "R%d doesn't have constant offset. bpf_spin_lock has to be at the constant offset\n",
3838 regno);
3839 return -EINVAL;
3840 }
3841 if (!map->btf) {
3842 verbose(env,
3843 "map '%s' has to have BTF in order to use bpf_spin_lock\n",
3844 map->name);
3845 return -EINVAL;
3846 }
3847 if (!map_value_has_spin_lock(map)) {
3848 if (map->spin_lock_off == -E2BIG)
3849 verbose(env,
3850 "map '%s' has more than one 'struct bpf_spin_lock'\n",
3851 map->name);
3852 else if (map->spin_lock_off == -ENOENT)
3853 verbose(env,
3854 "map '%s' doesn't have 'struct bpf_spin_lock'\n",
3855 map->name);
3856 else
3857 verbose(env,
3858 "map '%s' is not a struct type or bpf_spin_lock is mangled\n",
3859 map->name);
3860 return -EINVAL;
3861 }
3862 if (map->spin_lock_off != val + reg->off) {
3863 verbose(env, "off %lld doesn't point to 'struct bpf_spin_lock'\n",
3864 val + reg->off);
3865 return -EINVAL;
3866 }
3867 if (is_lock) {
3868 if (cur->active_spin_lock) {
3869 verbose(env,
3870 "Locking two bpf_spin_locks are not allowed\n");
3871 return -EINVAL;
3872 }
3873 cur->active_spin_lock = reg->id;
3874 } else {
3875 if (!cur->active_spin_lock) {
3876 verbose(env, "bpf_spin_unlock without taking a lock\n");
3877 return -EINVAL;
3878 }
3879 if (cur->active_spin_lock != reg->id) {
3880 verbose(env, "bpf_spin_unlock of different lock\n");
3881 return -EINVAL;
3882 }
3883 cur->active_spin_lock = 0;
3884 }
3885 return 0;
3886}
3887
90133415
DB
3888static bool arg_type_is_mem_ptr(enum bpf_arg_type type)
3889{
3890 return type == ARG_PTR_TO_MEM ||
3891 type == ARG_PTR_TO_MEM_OR_NULL ||
3892 type == ARG_PTR_TO_UNINIT_MEM;
3893}
3894
3895static bool arg_type_is_mem_size(enum bpf_arg_type type)
3896{
3897 return type == ARG_CONST_SIZE ||
3898 type == ARG_CONST_SIZE_OR_ZERO;
3899}
3900
457f4436
AN
3901static bool arg_type_is_alloc_mem_ptr(enum bpf_arg_type type)
3902{
3903 return type == ARG_PTR_TO_ALLOC_MEM ||
3904 type == ARG_PTR_TO_ALLOC_MEM_OR_NULL;
3905}
3906
3907static bool arg_type_is_alloc_size(enum bpf_arg_type type)
3908{
3909 return type == ARG_CONST_ALLOC_SIZE_OR_ZERO;
3910}
3911
57c3bb72
AI
3912static bool arg_type_is_int_ptr(enum bpf_arg_type type)
3913{
3914 return type == ARG_PTR_TO_INT ||
3915 type == ARG_PTR_TO_LONG;
3916}
3917
3918static int int_ptr_type_to_size(enum bpf_arg_type type)
3919{
3920 if (type == ARG_PTR_TO_INT)
3921 return sizeof(u32);
3922 else if (type == ARG_PTR_TO_LONG)
3923 return sizeof(u64);
3924
3925 return -EINVAL;
3926}
3927
912f442c
LB
3928static int resolve_map_arg_type(struct bpf_verifier_env *env,
3929 const struct bpf_call_arg_meta *meta,
3930 enum bpf_arg_type *arg_type)
3931{
3932 if (!meta->map_ptr) {
3933 /* kernel subsystem misconfigured verifier */
3934 verbose(env, "invalid map_ptr to access map->type\n");
3935 return -EACCES;
3936 }
3937
3938 switch (meta->map_ptr->map_type) {
3939 case BPF_MAP_TYPE_SOCKMAP:
3940 case BPF_MAP_TYPE_SOCKHASH:
3941 if (*arg_type == ARG_PTR_TO_MAP_VALUE) {
3942 *arg_type = ARG_PTR_TO_SOCKET;
3943 } else {
3944 verbose(env, "invalid arg_type for sockmap/sockhash\n");
3945 return -EINVAL;
3946 }
3947 break;
3948
3949 default:
3950 break;
3951 }
3952 return 0;
3953}
3954
af7ec138
YS
3955static int check_func_arg(struct bpf_verifier_env *env, u32 arg,
3956 struct bpf_call_arg_meta *meta,
3957 const struct bpf_func_proto *fn)
17a52670 3958{
af7ec138 3959 u32 regno = BPF_REG_1 + arg;
638f5b90 3960 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
6841de8b 3961 enum bpf_reg_type expected_type, type = reg->type;
af7ec138 3962 enum bpf_arg_type arg_type = fn->arg_type[arg];
17a52670
AS
3963 int err = 0;
3964
80f1d68c 3965 if (arg_type == ARG_DONTCARE)
17a52670
AS
3966 return 0;
3967
dc503a8a
EC
3968 err = check_reg_arg(env, regno, SRC_OP);
3969 if (err)
3970 return err;
17a52670 3971
1be7f75d
AS
3972 if (arg_type == ARG_ANYTHING) {
3973 if (is_pointer_value(env, regno)) {
61bd5218
JK
3974 verbose(env, "R%d leaks addr into helper function\n",
3975 regno);
1be7f75d
AS
3976 return -EACCES;
3977 }
80f1d68c 3978 return 0;
1be7f75d 3979 }
80f1d68c 3980
de8f3a83 3981 if (type_is_pkt_pointer(type) &&
3a0af8fd 3982 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
61bd5218 3983 verbose(env, "helper access to the packet is not allowed\n");
6841de8b
AS
3984 return -EACCES;
3985 }
3986
912f442c
LB
3987 if (arg_type == ARG_PTR_TO_MAP_VALUE ||
3988 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE ||
3989 arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL) {
3990 err = resolve_map_arg_type(env, meta, &arg_type);
3991 if (err)
3992 return err;
3993 }
3994
8e2fe1d9 3995 if (arg_type == ARG_PTR_TO_MAP_KEY ||
2ea864c5 3996 arg_type == ARG_PTR_TO_MAP_VALUE ||
6ac99e8f
MKL
3997 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE ||
3998 arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL) {
17a52670 3999 expected_type = PTR_TO_STACK;
6ac99e8f
MKL
4000 if (register_is_null(reg) &&
4001 arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL)
4002 /* final test in check_stack_boundary() */;
4003 else if (!type_is_pkt_pointer(type) &&
4004 type != PTR_TO_MAP_VALUE &&
4005 type != expected_type)
6841de8b 4006 goto err_type;
39f19ebb 4007 } else if (arg_type == ARG_CONST_SIZE ||
457f4436
AN
4008 arg_type == ARG_CONST_SIZE_OR_ZERO ||
4009 arg_type == ARG_CONST_ALLOC_SIZE_OR_ZERO) {
f1174f77
EC
4010 expected_type = SCALAR_VALUE;
4011 if (type != expected_type)
6841de8b 4012 goto err_type;
17a52670
AS
4013 } else if (arg_type == ARG_CONST_MAP_PTR) {
4014 expected_type = CONST_PTR_TO_MAP;
6841de8b
AS
4015 if (type != expected_type)
4016 goto err_type;
f318903c
DB
4017 } else if (arg_type == ARG_PTR_TO_CTX ||
4018 arg_type == ARG_PTR_TO_CTX_OR_NULL) {
608cd71a 4019 expected_type = PTR_TO_CTX;
f318903c
DB
4020 if (!(register_is_null(reg) &&
4021 arg_type == ARG_PTR_TO_CTX_OR_NULL)) {
4022 if (type != expected_type)
4023 goto err_type;
4024 err = check_ctx_reg(env, reg, regno);
4025 if (err < 0)
4026 return err;
4027 }
46f8bc92
MKL
4028 } else if (arg_type == ARG_PTR_TO_SOCK_COMMON) {
4029 expected_type = PTR_TO_SOCK_COMMON;
4030 /* Any sk pointer can be ARG_PTR_TO_SOCK_COMMON */
4031 if (!type_is_sk_pointer(type))
4032 goto err_type;
e9ddbb77
JS
4033 } else if (arg_type == ARG_PTR_TO_SOCKET ||
4034 arg_type == ARG_PTR_TO_SOCKET_OR_NULL) {
6ac99e8f 4035 expected_type = PTR_TO_SOCKET;
e9ddbb77
JS
4036 if (!(register_is_null(reg) &&
4037 arg_type == ARG_PTR_TO_SOCKET_OR_NULL)) {
4038 if (type != expected_type)
4039 goto err_type;
4040 }
a7658e1a
AS
4041 } else if (arg_type == ARG_PTR_TO_BTF_ID) {
4042 expected_type = PTR_TO_BTF_ID;
4043 if (type != expected_type)
4044 goto err_type;
d83525ca
AS
4045 } else if (arg_type == ARG_PTR_TO_SPIN_LOCK) {
4046 if (meta->func_id == BPF_FUNC_spin_lock) {
4047 if (process_spin_lock(env, regno, true))
4048 return -EACCES;
4049 } else if (meta->func_id == BPF_FUNC_spin_unlock) {
4050 if (process_spin_lock(env, regno, false))
4051 return -EACCES;
4052 } else {
4053 verbose(env, "verifier internal error\n");
4054 return -EFAULT;
4055 }
90133415 4056 } else if (arg_type_is_mem_ptr(arg_type)) {
8e2fe1d9
DB
4057 expected_type = PTR_TO_STACK;
4058 /* One exception here. In case function allows for NULL to be
f1174f77 4059 * passed in as argument, it's a SCALAR_VALUE type. Final test
8e2fe1d9
DB
4060 * happens during stack boundary checking.
4061 */
914cb781 4062 if (register_is_null(reg) &&
457f4436
AN
4063 (arg_type == ARG_PTR_TO_MEM_OR_NULL ||
4064 arg_type == ARG_PTR_TO_ALLOC_MEM_OR_NULL))
6841de8b 4065 /* final test in check_stack_boundary() */;
de8f3a83
DB
4066 else if (!type_is_pkt_pointer(type) &&
4067 type != PTR_TO_MAP_VALUE &&
457f4436 4068 type != PTR_TO_MEM &&
afbf21dc
YS
4069 type != PTR_TO_RDONLY_BUF &&
4070 type != PTR_TO_RDWR_BUF &&
f1174f77 4071 type != expected_type)
6841de8b 4072 goto err_type;
39f19ebb 4073 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
457f4436
AN
4074 } else if (arg_type_is_alloc_mem_ptr(arg_type)) {
4075 expected_type = PTR_TO_MEM;
4076 if (register_is_null(reg) &&
4077 arg_type == ARG_PTR_TO_ALLOC_MEM_OR_NULL)
4078 /* final test in check_stack_boundary() */;
4079 else if (type != expected_type)
4080 goto err_type;
57c3bb72
AI
4081 } else if (arg_type_is_int_ptr(arg_type)) {
4082 expected_type = PTR_TO_STACK;
4083 if (!type_is_pkt_pointer(type) &&
4084 type != PTR_TO_MAP_VALUE &&
4085 type != expected_type)
4086 goto err_type;
17a52670 4087 } else {
61bd5218 4088 verbose(env, "unsupported arg_type %d\n", arg_type);
17a52670
AS
4089 return -EFAULT;
4090 }
4091
d7b9454a
LB
4092 if (type == PTR_TO_BTF_ID) {
4093 const u32 *btf_id = fn->arg_btf_id[arg];
4094
4095 if (!btf_id) {
4096 verbose(env, "verifier internal error: missing BTF ID\n");
4097 return -EFAULT;
4098 }
4099
4100 if (!btf_struct_ids_match(&env->log, reg->off, reg->btf_id, *btf_id)) {
4101 verbose(env, "R%d is of type %s but %s is expected\n",
4102 regno, kernel_type_name(reg->btf_id), kernel_type_name(*btf_id));
4103 return -EACCES;
4104 }
4105 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
4106 verbose(env, "R%d is a pointer to in-kernel struct with non-zero offset\n",
4107 regno);
4108 return -EACCES;
4109 }
4110 }
4111
02f7c958
LB
4112 if (reg->ref_obj_id) {
4113 if (meta->ref_obj_id) {
4114 verbose(env, "verifier internal error: more than one arg with ref_obj_id R%d %u %u\n",
4115 regno, reg->ref_obj_id,
4116 meta->ref_obj_id);
4117 return -EFAULT;
4118 }
4119 meta->ref_obj_id = reg->ref_obj_id;
4120 }
4121
17a52670
AS
4122 if (arg_type == ARG_CONST_MAP_PTR) {
4123 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
33ff9823 4124 meta->map_ptr = reg->map_ptr;
17a52670
AS
4125 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
4126 /* bpf_map_xxx(..., map_ptr, ..., key) call:
4127 * check that [key, key + map->key_size) are within
4128 * stack limits and initialized
4129 */
33ff9823 4130 if (!meta->map_ptr) {
17a52670
AS
4131 /* in function declaration map_ptr must come before
4132 * map_key, so that it's verified and known before
4133 * we have to check map_key here. Otherwise it means
4134 * that kernel subsystem misconfigured verifier
4135 */
61bd5218 4136 verbose(env, "invalid map_ptr to access map->key\n");
17a52670
AS
4137 return -EACCES;
4138 }
d71962f3
PC
4139 err = check_helper_mem_access(env, regno,
4140 meta->map_ptr->key_size, false,
4141 NULL);
2ea864c5 4142 } else if (arg_type == ARG_PTR_TO_MAP_VALUE ||
6ac99e8f
MKL
4143 (arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL &&
4144 !register_is_null(reg)) ||
2ea864c5 4145 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE) {
17a52670
AS
4146 /* bpf_map_xxx(..., map_ptr, ..., value) call:
4147 * check [value, value + map->value_size) validity
4148 */
33ff9823 4149 if (!meta->map_ptr) {
17a52670 4150 /* kernel subsystem misconfigured verifier */
61bd5218 4151 verbose(env, "invalid map_ptr to access map->value\n");
17a52670
AS
4152 return -EACCES;
4153 }
2ea864c5 4154 meta->raw_mode = (arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE);
d71962f3
PC
4155 err = check_helper_mem_access(env, regno,
4156 meta->map_ptr->value_size, false,
2ea864c5 4157 meta);
90133415 4158 } else if (arg_type_is_mem_size(arg_type)) {
39f19ebb 4159 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
17a52670 4160
10060503
JF
4161 /* This is used to refine r0 return value bounds for helpers
4162 * that enforce this value as an upper bound on return values.
4163 * See do_refine_retval_range() for helpers that can refine
4164 * the return value. C type of helper is u32 so we pull register
4165 * bound from umax_value however, if negative verifier errors
4166 * out. Only upper bounds can be learned because retval is an
4167 * int type and negative retvals are allowed.
849fa506 4168 */
10060503 4169 meta->msize_max_value = reg->umax_value;
849fa506 4170
f1174f77
EC
4171 /* The register is SCALAR_VALUE; the access check
4172 * happens using its boundaries.
06c1c049 4173 */
f1174f77 4174 if (!tnum_is_const(reg->var_off))
06c1c049
GB
4175 /* For unprivileged variable accesses, disable raw
4176 * mode so that the program is required to
4177 * initialize all the memory that the helper could
4178 * just partially fill up.
4179 */
4180 meta = NULL;
4181
b03c9f9f 4182 if (reg->smin_value < 0) {
61bd5218 4183 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
f1174f77
EC
4184 regno);
4185 return -EACCES;
4186 }
06c1c049 4187
b03c9f9f 4188 if (reg->umin_value == 0) {
f1174f77
EC
4189 err = check_helper_mem_access(env, regno - 1, 0,
4190 zero_size_allowed,
4191 meta);
06c1c049
GB
4192 if (err)
4193 return err;
06c1c049 4194 }
f1174f77 4195
b03c9f9f 4196 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
61bd5218 4197 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
f1174f77
EC
4198 regno);
4199 return -EACCES;
4200 }
4201 err = check_helper_mem_access(env, regno - 1,
b03c9f9f 4202 reg->umax_value,
f1174f77 4203 zero_size_allowed, meta);
b5dc0163
AS
4204 if (!err)
4205 err = mark_chain_precision(env, regno);
457f4436
AN
4206 } else if (arg_type_is_alloc_size(arg_type)) {
4207 if (!tnum_is_const(reg->var_off)) {
4208 verbose(env, "R%d unbounded size, use 'var &= const' or 'if (var < const)'\n",
4209 regno);
4210 return -EACCES;
4211 }
4212 meta->mem_size = reg->var_off.value;
57c3bb72
AI
4213 } else if (arg_type_is_int_ptr(arg_type)) {
4214 int size = int_ptr_type_to_size(arg_type);
4215
4216 err = check_helper_mem_access(env, regno, size, false, meta);
4217 if (err)
4218 return err;
4219 err = check_ptr_alignment(env, reg, 0, size, true);
17a52670
AS
4220 }
4221
4222 return err;
6841de8b 4223err_type:
61bd5218 4224 verbose(env, "R%d type=%s expected=%s\n", regno,
6841de8b
AS
4225 reg_type_str[type], reg_type_str[expected_type]);
4226 return -EACCES;
17a52670
AS
4227}
4228
0126240f
LB
4229static bool may_update_sockmap(struct bpf_verifier_env *env, int func_id)
4230{
4231 enum bpf_attach_type eatype = env->prog->expected_attach_type;
7e40781c 4232 enum bpf_prog_type type = resolve_prog_type(env->prog);
0126240f
LB
4233
4234 if (func_id != BPF_FUNC_map_update_elem)
4235 return false;
4236
4237 /* It's not possible to get access to a locked struct sock in these
4238 * contexts, so updating is safe.
4239 */
4240 switch (type) {
4241 case BPF_PROG_TYPE_TRACING:
4242 if (eatype == BPF_TRACE_ITER)
4243 return true;
4244 break;
4245 case BPF_PROG_TYPE_SOCKET_FILTER:
4246 case BPF_PROG_TYPE_SCHED_CLS:
4247 case BPF_PROG_TYPE_SCHED_ACT:
4248 case BPF_PROG_TYPE_XDP:
4249 case BPF_PROG_TYPE_SK_REUSEPORT:
4250 case BPF_PROG_TYPE_FLOW_DISSECTOR:
4251 case BPF_PROG_TYPE_SK_LOOKUP:
4252 return true;
4253 default:
4254 break;
4255 }
4256
4257 verbose(env, "cannot update sockmap in this context\n");
4258 return false;
4259}
4260
e411901c
MF
4261static bool allow_tail_call_in_subprogs(struct bpf_verifier_env *env)
4262{
4263 return env->prog->jit_requested && IS_ENABLED(CONFIG_X86_64);
4264}
4265
61bd5218
JK
4266static int check_map_func_compatibility(struct bpf_verifier_env *env,
4267 struct bpf_map *map, int func_id)
35578d79 4268{
35578d79
KX
4269 if (!map)
4270 return 0;
4271
6aff67c8
AS
4272 /* We need a two way check, first is from map perspective ... */
4273 switch (map->map_type) {
4274 case BPF_MAP_TYPE_PROG_ARRAY:
4275 if (func_id != BPF_FUNC_tail_call)
4276 goto error;
4277 break;
4278 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
4279 if (func_id != BPF_FUNC_perf_event_read &&
908432ca 4280 func_id != BPF_FUNC_perf_event_output &&
a7658e1a 4281 func_id != BPF_FUNC_skb_output &&
d831ee84
EC
4282 func_id != BPF_FUNC_perf_event_read_value &&
4283 func_id != BPF_FUNC_xdp_output)
6aff67c8
AS
4284 goto error;
4285 break;
457f4436
AN
4286 case BPF_MAP_TYPE_RINGBUF:
4287 if (func_id != BPF_FUNC_ringbuf_output &&
4288 func_id != BPF_FUNC_ringbuf_reserve &&
4289 func_id != BPF_FUNC_ringbuf_submit &&
4290 func_id != BPF_FUNC_ringbuf_discard &&
4291 func_id != BPF_FUNC_ringbuf_query)
4292 goto error;
4293 break;
6aff67c8
AS
4294 case BPF_MAP_TYPE_STACK_TRACE:
4295 if (func_id != BPF_FUNC_get_stackid)
4296 goto error;
4297 break;
4ed8ec52 4298 case BPF_MAP_TYPE_CGROUP_ARRAY:
60747ef4 4299 if (func_id != BPF_FUNC_skb_under_cgroup &&
60d20f91 4300 func_id != BPF_FUNC_current_task_under_cgroup)
4a482f34
MKL
4301 goto error;
4302 break;
cd339431 4303 case BPF_MAP_TYPE_CGROUP_STORAGE:
b741f163 4304 case BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE:
cd339431
RG
4305 if (func_id != BPF_FUNC_get_local_storage)
4306 goto error;
4307 break;
546ac1ff 4308 case BPF_MAP_TYPE_DEVMAP:
6f9d451a 4309 case BPF_MAP_TYPE_DEVMAP_HASH:
0cdbb4b0
THJ
4310 if (func_id != BPF_FUNC_redirect_map &&
4311 func_id != BPF_FUNC_map_lookup_elem)
546ac1ff
JF
4312 goto error;
4313 break;
fbfc504a
BT
4314 /* Restrict bpf side of cpumap and xskmap, open when use-cases
4315 * appear.
4316 */
6710e112
JDB
4317 case BPF_MAP_TYPE_CPUMAP:
4318 if (func_id != BPF_FUNC_redirect_map)
4319 goto error;
4320 break;
fada7fdc
JL
4321 case BPF_MAP_TYPE_XSKMAP:
4322 if (func_id != BPF_FUNC_redirect_map &&
4323 func_id != BPF_FUNC_map_lookup_elem)
4324 goto error;
4325 break;
56f668df 4326 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
bcc6b1b7 4327 case BPF_MAP_TYPE_HASH_OF_MAPS:
56f668df
MKL
4328 if (func_id != BPF_FUNC_map_lookup_elem)
4329 goto error;
16a43625 4330 break;
174a79ff
JF
4331 case BPF_MAP_TYPE_SOCKMAP:
4332 if (func_id != BPF_FUNC_sk_redirect_map &&
4333 func_id != BPF_FUNC_sock_map_update &&
4f738adb 4334 func_id != BPF_FUNC_map_delete_elem &&
9fed9000 4335 func_id != BPF_FUNC_msg_redirect_map &&
64d85290 4336 func_id != BPF_FUNC_sk_select_reuseport &&
0126240f
LB
4337 func_id != BPF_FUNC_map_lookup_elem &&
4338 !may_update_sockmap(env, func_id))
174a79ff
JF
4339 goto error;
4340 break;
81110384
JF
4341 case BPF_MAP_TYPE_SOCKHASH:
4342 if (func_id != BPF_FUNC_sk_redirect_hash &&
4343 func_id != BPF_FUNC_sock_hash_update &&
4344 func_id != BPF_FUNC_map_delete_elem &&
9fed9000 4345 func_id != BPF_FUNC_msg_redirect_hash &&
64d85290 4346 func_id != BPF_FUNC_sk_select_reuseport &&
0126240f
LB
4347 func_id != BPF_FUNC_map_lookup_elem &&
4348 !may_update_sockmap(env, func_id))
81110384
JF
4349 goto error;
4350 break;
2dbb9b9e
MKL
4351 case BPF_MAP_TYPE_REUSEPORT_SOCKARRAY:
4352 if (func_id != BPF_FUNC_sk_select_reuseport)
4353 goto error;
4354 break;
f1a2e44a
MV
4355 case BPF_MAP_TYPE_QUEUE:
4356 case BPF_MAP_TYPE_STACK:
4357 if (func_id != BPF_FUNC_map_peek_elem &&
4358 func_id != BPF_FUNC_map_pop_elem &&
4359 func_id != BPF_FUNC_map_push_elem)
4360 goto error;
4361 break;
6ac99e8f
MKL
4362 case BPF_MAP_TYPE_SK_STORAGE:
4363 if (func_id != BPF_FUNC_sk_storage_get &&
4364 func_id != BPF_FUNC_sk_storage_delete)
4365 goto error;
4366 break;
8ea63684
KS
4367 case BPF_MAP_TYPE_INODE_STORAGE:
4368 if (func_id != BPF_FUNC_inode_storage_get &&
4369 func_id != BPF_FUNC_inode_storage_delete)
4370 goto error;
4371 break;
6aff67c8
AS
4372 default:
4373 break;
4374 }
4375
4376 /* ... and second from the function itself. */
4377 switch (func_id) {
4378 case BPF_FUNC_tail_call:
4379 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
4380 goto error;
e411901c
MF
4381 if (env->subprog_cnt > 1 && !allow_tail_call_in_subprogs(env)) {
4382 verbose(env, "tail_calls are not allowed in non-JITed programs with bpf-to-bpf calls\n");
f4d7e40a
AS
4383 return -EINVAL;
4384 }
6aff67c8
AS
4385 break;
4386 case BPF_FUNC_perf_event_read:
4387 case BPF_FUNC_perf_event_output:
908432ca 4388 case BPF_FUNC_perf_event_read_value:
a7658e1a 4389 case BPF_FUNC_skb_output:
d831ee84 4390 case BPF_FUNC_xdp_output:
6aff67c8
AS
4391 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
4392 goto error;
4393 break;
4394 case BPF_FUNC_get_stackid:
4395 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
4396 goto error;
4397 break;
60d20f91 4398 case BPF_FUNC_current_task_under_cgroup:
747ea55e 4399 case BPF_FUNC_skb_under_cgroup:
4a482f34
MKL
4400 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
4401 goto error;
4402 break;
97f91a7c 4403 case BPF_FUNC_redirect_map:
9c270af3 4404 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
6f9d451a 4405 map->map_type != BPF_MAP_TYPE_DEVMAP_HASH &&
fbfc504a
BT
4406 map->map_type != BPF_MAP_TYPE_CPUMAP &&
4407 map->map_type != BPF_MAP_TYPE_XSKMAP)
97f91a7c
JF
4408 goto error;
4409 break;
174a79ff 4410 case BPF_FUNC_sk_redirect_map:
4f738adb 4411 case BPF_FUNC_msg_redirect_map:
81110384 4412 case BPF_FUNC_sock_map_update:
174a79ff
JF
4413 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
4414 goto error;
4415 break;
81110384
JF
4416 case BPF_FUNC_sk_redirect_hash:
4417 case BPF_FUNC_msg_redirect_hash:
4418 case BPF_FUNC_sock_hash_update:
4419 if (map->map_type != BPF_MAP_TYPE_SOCKHASH)
174a79ff
JF
4420 goto error;
4421 break;
cd339431 4422 case BPF_FUNC_get_local_storage:
b741f163
RG
4423 if (map->map_type != BPF_MAP_TYPE_CGROUP_STORAGE &&
4424 map->map_type != BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE)
cd339431
RG
4425 goto error;
4426 break;
2dbb9b9e 4427 case BPF_FUNC_sk_select_reuseport:
9fed9000
JS
4428 if (map->map_type != BPF_MAP_TYPE_REUSEPORT_SOCKARRAY &&
4429 map->map_type != BPF_MAP_TYPE_SOCKMAP &&
4430 map->map_type != BPF_MAP_TYPE_SOCKHASH)
2dbb9b9e
MKL
4431 goto error;
4432 break;
f1a2e44a
MV
4433 case BPF_FUNC_map_peek_elem:
4434 case BPF_FUNC_map_pop_elem:
4435 case BPF_FUNC_map_push_elem:
4436 if (map->map_type != BPF_MAP_TYPE_QUEUE &&
4437 map->map_type != BPF_MAP_TYPE_STACK)
4438 goto error;
4439 break;
6ac99e8f
MKL
4440 case BPF_FUNC_sk_storage_get:
4441 case BPF_FUNC_sk_storage_delete:
4442 if (map->map_type != BPF_MAP_TYPE_SK_STORAGE)
4443 goto error;
4444 break;
8ea63684
KS
4445 case BPF_FUNC_inode_storage_get:
4446 case BPF_FUNC_inode_storage_delete:
4447 if (map->map_type != BPF_MAP_TYPE_INODE_STORAGE)
4448 goto error;
4449 break;
6aff67c8
AS
4450 default:
4451 break;
35578d79
KX
4452 }
4453
4454 return 0;
6aff67c8 4455error:
61bd5218 4456 verbose(env, "cannot pass map_type %d into func %s#%d\n",
ebb676da 4457 map->map_type, func_id_name(func_id), func_id);
6aff67c8 4458 return -EINVAL;
35578d79
KX
4459}
4460
90133415 4461static bool check_raw_mode_ok(const struct bpf_func_proto *fn)
435faee1
DB
4462{
4463 int count = 0;
4464
39f19ebb 4465 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4466 count++;
39f19ebb 4467 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4468 count++;
39f19ebb 4469 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4470 count++;
39f19ebb 4471 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4472 count++;
39f19ebb 4473 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
435faee1
DB
4474 count++;
4475
90133415
DB
4476 /* We only support one arg being in raw mode at the moment,
4477 * which is sufficient for the helper functions we have
4478 * right now.
4479 */
4480 return count <= 1;
4481}
4482
4483static bool check_args_pair_invalid(enum bpf_arg_type arg_curr,
4484 enum bpf_arg_type arg_next)
4485{
4486 return (arg_type_is_mem_ptr(arg_curr) &&
4487 !arg_type_is_mem_size(arg_next)) ||
4488 (!arg_type_is_mem_ptr(arg_curr) &&
4489 arg_type_is_mem_size(arg_next));
4490}
4491
4492static bool check_arg_pair_ok(const struct bpf_func_proto *fn)
4493{
4494 /* bpf_xxx(..., buf, len) call will access 'len'
4495 * bytes from memory 'buf'. Both arg types need
4496 * to be paired, so make sure there's no buggy
4497 * helper function specification.
4498 */
4499 if (arg_type_is_mem_size(fn->arg1_type) ||
4500 arg_type_is_mem_ptr(fn->arg5_type) ||
4501 check_args_pair_invalid(fn->arg1_type, fn->arg2_type) ||
4502 check_args_pair_invalid(fn->arg2_type, fn->arg3_type) ||
4503 check_args_pair_invalid(fn->arg3_type, fn->arg4_type) ||
4504 check_args_pair_invalid(fn->arg4_type, fn->arg5_type))
4505 return false;
4506
4507 return true;
4508}
4509
1b986589 4510static bool check_refcount_ok(const struct bpf_func_proto *fn, int func_id)
fd978bf7
JS
4511{
4512 int count = 0;
4513
1b986589 4514 if (arg_type_may_be_refcounted(fn->arg1_type))
fd978bf7 4515 count++;
1b986589 4516 if (arg_type_may_be_refcounted(fn->arg2_type))
fd978bf7 4517 count++;
1b986589 4518 if (arg_type_may_be_refcounted(fn->arg3_type))
fd978bf7 4519 count++;
1b986589 4520 if (arg_type_may_be_refcounted(fn->arg4_type))
fd978bf7 4521 count++;
1b986589 4522 if (arg_type_may_be_refcounted(fn->arg5_type))
fd978bf7
JS
4523 count++;
4524
1b986589
MKL
4525 /* A reference acquiring function cannot acquire
4526 * another refcounted ptr.
4527 */
64d85290 4528 if (may_be_acquire_function(func_id) && count)
1b986589
MKL
4529 return false;
4530
fd978bf7
JS
4531 /* We only support one arg being unreferenced at the moment,
4532 * which is sufficient for the helper functions we have right now.
4533 */
4534 return count <= 1;
4535}
4536
9436ef6e
LB
4537static bool check_btf_id_ok(const struct bpf_func_proto *fn)
4538{
4539 int i;
4540
4541 for (i = 0; i < ARRAY_SIZE(fn->arg_type); i++)
4542 if (fn->arg_type[i] == ARG_PTR_TO_BTF_ID && !fn->arg_btf_id[i])
4543 return false;
4544
4545 return true;
4546}
4547
1b986589 4548static int check_func_proto(const struct bpf_func_proto *fn, int func_id)
90133415
DB
4549{
4550 return check_raw_mode_ok(fn) &&
fd978bf7 4551 check_arg_pair_ok(fn) &&
9436ef6e 4552 check_btf_id_ok(fn) &&
1b986589 4553 check_refcount_ok(fn, func_id) ? 0 : -EINVAL;
435faee1
DB
4554}
4555
de8f3a83
DB
4556/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
4557 * are now invalid, so turn them into unknown SCALAR_VALUE.
f1174f77 4558 */
f4d7e40a
AS
4559static void __clear_all_pkt_pointers(struct bpf_verifier_env *env,
4560 struct bpf_func_state *state)
969bf05e 4561{
58e2af8b 4562 struct bpf_reg_state *regs = state->regs, *reg;
969bf05e
AS
4563 int i;
4564
4565 for (i = 0; i < MAX_BPF_REG; i++)
de8f3a83 4566 if (reg_is_pkt_pointer_any(&regs[i]))
61bd5218 4567 mark_reg_unknown(env, regs, i);
969bf05e 4568
f3709f69
JS
4569 bpf_for_each_spilled_reg(i, state, reg) {
4570 if (!reg)
969bf05e 4571 continue;
de8f3a83 4572 if (reg_is_pkt_pointer_any(reg))
f54c7898 4573 __mark_reg_unknown(env, reg);
969bf05e
AS
4574 }
4575}
4576
f4d7e40a
AS
4577static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
4578{
4579 struct bpf_verifier_state *vstate = env->cur_state;
4580 int i;
4581
4582 for (i = 0; i <= vstate->curframe; i++)
4583 __clear_all_pkt_pointers(env, vstate->frame[i]);
4584}
4585
fd978bf7 4586static void release_reg_references(struct bpf_verifier_env *env,
1b986589
MKL
4587 struct bpf_func_state *state,
4588 int ref_obj_id)
fd978bf7
JS
4589{
4590 struct bpf_reg_state *regs = state->regs, *reg;
4591 int i;
4592
4593 for (i = 0; i < MAX_BPF_REG; i++)
1b986589 4594 if (regs[i].ref_obj_id == ref_obj_id)
fd978bf7
JS
4595 mark_reg_unknown(env, regs, i);
4596
4597 bpf_for_each_spilled_reg(i, state, reg) {
4598 if (!reg)
4599 continue;
1b986589 4600 if (reg->ref_obj_id == ref_obj_id)
f54c7898 4601 __mark_reg_unknown(env, reg);
fd978bf7
JS
4602 }
4603}
4604
4605/* The pointer with the specified id has released its reference to kernel
4606 * resources. Identify all copies of the same pointer and clear the reference.
4607 */
4608static int release_reference(struct bpf_verifier_env *env,
1b986589 4609 int ref_obj_id)
fd978bf7
JS
4610{
4611 struct bpf_verifier_state *vstate = env->cur_state;
1b986589 4612 int err;
fd978bf7
JS
4613 int i;
4614
1b986589
MKL
4615 err = release_reference_state(cur_func(env), ref_obj_id);
4616 if (err)
4617 return err;
4618
fd978bf7 4619 for (i = 0; i <= vstate->curframe; i++)
1b986589 4620 release_reg_references(env, vstate->frame[i], ref_obj_id);
fd978bf7 4621
1b986589 4622 return 0;
fd978bf7
JS
4623}
4624
51c39bb1
AS
4625static void clear_caller_saved_regs(struct bpf_verifier_env *env,
4626 struct bpf_reg_state *regs)
4627{
4628 int i;
4629
4630 /* after the call registers r0 - r5 were scratched */
4631 for (i = 0; i < CALLER_SAVED_REGS; i++) {
4632 mark_reg_not_init(env, regs, caller_saved[i]);
4633 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
4634 }
4635}
4636
f4d7e40a
AS
4637static int check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
4638 int *insn_idx)
4639{
4640 struct bpf_verifier_state *state = env->cur_state;
51c39bb1 4641 struct bpf_func_info_aux *func_info_aux;
f4d7e40a 4642 struct bpf_func_state *caller, *callee;
fd978bf7 4643 int i, err, subprog, target_insn;
51c39bb1 4644 bool is_global = false;
f4d7e40a 4645
aada9ce6 4646 if (state->curframe + 1 >= MAX_CALL_FRAMES) {
f4d7e40a 4647 verbose(env, "the call stack of %d frames is too deep\n",
aada9ce6 4648 state->curframe + 2);
f4d7e40a
AS
4649 return -E2BIG;
4650 }
4651
4652 target_insn = *insn_idx + insn->imm;
4653 subprog = find_subprog(env, target_insn + 1);
4654 if (subprog < 0) {
4655 verbose(env, "verifier bug. No program starts at insn %d\n",
4656 target_insn + 1);
4657 return -EFAULT;
4658 }
4659
4660 caller = state->frame[state->curframe];
4661 if (state->frame[state->curframe + 1]) {
4662 verbose(env, "verifier bug. Frame %d already allocated\n",
4663 state->curframe + 1);
4664 return -EFAULT;
4665 }
4666
51c39bb1
AS
4667 func_info_aux = env->prog->aux->func_info_aux;
4668 if (func_info_aux)
4669 is_global = func_info_aux[subprog].linkage == BTF_FUNC_GLOBAL;
4670 err = btf_check_func_arg_match(env, subprog, caller->regs);
4671 if (err == -EFAULT)
4672 return err;
4673 if (is_global) {
4674 if (err) {
4675 verbose(env, "Caller passes invalid args into func#%d\n",
4676 subprog);
4677 return err;
4678 } else {
4679 if (env->log.level & BPF_LOG_LEVEL)
4680 verbose(env,
4681 "Func#%d is global and valid. Skipping.\n",
4682 subprog);
4683 clear_caller_saved_regs(env, caller->regs);
4684
4685 /* All global functions return SCALAR_VALUE */
4686 mark_reg_unknown(env, caller->regs, BPF_REG_0);
4687
4688 /* continue with next insn after call */
4689 return 0;
4690 }
4691 }
4692
f4d7e40a
AS
4693 callee = kzalloc(sizeof(*callee), GFP_KERNEL);
4694 if (!callee)
4695 return -ENOMEM;
4696 state->frame[state->curframe + 1] = callee;
4697
4698 /* callee cannot access r0, r6 - r9 for reading and has to write
4699 * into its own stack before reading from it.
4700 * callee can read/write into caller's stack
4701 */
4702 init_func_state(env, callee,
4703 /* remember the callsite, it will be used by bpf_exit */
4704 *insn_idx /* callsite */,
4705 state->curframe + 1 /* frameno within this callchain */,
f910cefa 4706 subprog /* subprog number within this prog */);
f4d7e40a 4707
fd978bf7
JS
4708 /* Transfer references to the callee */
4709 err = transfer_reference_state(callee, caller);
4710 if (err)
4711 return err;
4712
679c782d
EC
4713 /* copy r1 - r5 args that callee can access. The copy includes parent
4714 * pointers, which connects us up to the liveness chain
4715 */
f4d7e40a
AS
4716 for (i = BPF_REG_1; i <= BPF_REG_5; i++)
4717 callee->regs[i] = caller->regs[i];
4718
51c39bb1 4719 clear_caller_saved_regs(env, caller->regs);
f4d7e40a
AS
4720
4721 /* only increment it after check_reg_arg() finished */
4722 state->curframe++;
4723
4724 /* and go analyze first insn of the callee */
4725 *insn_idx = target_insn;
4726
06ee7115 4727 if (env->log.level & BPF_LOG_LEVEL) {
f4d7e40a
AS
4728 verbose(env, "caller:\n");
4729 print_verifier_state(env, caller);
4730 verbose(env, "callee:\n");
4731 print_verifier_state(env, callee);
4732 }
4733 return 0;
4734}
4735
4736static int prepare_func_exit(struct bpf_verifier_env *env, int *insn_idx)
4737{
4738 struct bpf_verifier_state *state = env->cur_state;
4739 struct bpf_func_state *caller, *callee;
4740 struct bpf_reg_state *r0;
fd978bf7 4741 int err;
f4d7e40a
AS
4742
4743 callee = state->frame[state->curframe];
4744 r0 = &callee->regs[BPF_REG_0];
4745 if (r0->type == PTR_TO_STACK) {
4746 /* technically it's ok to return caller's stack pointer
4747 * (or caller's caller's pointer) back to the caller,
4748 * since these pointers are valid. Only current stack
4749 * pointer will be invalid as soon as function exits,
4750 * but let's be conservative
4751 */
4752 verbose(env, "cannot return stack pointer to the caller\n");
4753 return -EINVAL;
4754 }
4755
4756 state->curframe--;
4757 caller = state->frame[state->curframe];
4758 /* return to the caller whatever r0 had in the callee */
4759 caller->regs[BPF_REG_0] = *r0;
4760
fd978bf7
JS
4761 /* Transfer references to the caller */
4762 err = transfer_reference_state(caller, callee);
4763 if (err)
4764 return err;
4765
f4d7e40a 4766 *insn_idx = callee->callsite + 1;
06ee7115 4767 if (env->log.level & BPF_LOG_LEVEL) {
f4d7e40a
AS
4768 verbose(env, "returning from callee:\n");
4769 print_verifier_state(env, callee);
4770 verbose(env, "to caller at %d:\n", *insn_idx);
4771 print_verifier_state(env, caller);
4772 }
4773 /* clear everything in the callee */
4774 free_func_state(callee);
4775 state->frame[state->curframe + 1] = NULL;
4776 return 0;
4777}
4778
849fa506
YS
4779static void do_refine_retval_range(struct bpf_reg_state *regs, int ret_type,
4780 int func_id,
4781 struct bpf_call_arg_meta *meta)
4782{
4783 struct bpf_reg_state *ret_reg = &regs[BPF_REG_0];
4784
4785 if (ret_type != RET_INTEGER ||
4786 (func_id != BPF_FUNC_get_stack &&
47cc0ed5
DB
4787 func_id != BPF_FUNC_probe_read_str &&
4788 func_id != BPF_FUNC_probe_read_kernel_str &&
4789 func_id != BPF_FUNC_probe_read_user_str))
849fa506
YS
4790 return;
4791
10060503 4792 ret_reg->smax_value = meta->msize_max_value;
fa123ac0 4793 ret_reg->s32_max_value = meta->msize_max_value;
849fa506
YS
4794 __reg_deduce_bounds(ret_reg);
4795 __reg_bound_offset(ret_reg);
10060503 4796 __update_reg_bounds(ret_reg);
849fa506
YS
4797}
4798
c93552c4
DB
4799static int
4800record_func_map(struct bpf_verifier_env *env, struct bpf_call_arg_meta *meta,
4801 int func_id, int insn_idx)
4802{
4803 struct bpf_insn_aux_data *aux = &env->insn_aux_data[insn_idx];
591fe988 4804 struct bpf_map *map = meta->map_ptr;
c93552c4
DB
4805
4806 if (func_id != BPF_FUNC_tail_call &&
09772d92
DB
4807 func_id != BPF_FUNC_map_lookup_elem &&
4808 func_id != BPF_FUNC_map_update_elem &&
f1a2e44a
MV
4809 func_id != BPF_FUNC_map_delete_elem &&
4810 func_id != BPF_FUNC_map_push_elem &&
4811 func_id != BPF_FUNC_map_pop_elem &&
4812 func_id != BPF_FUNC_map_peek_elem)
c93552c4 4813 return 0;
09772d92 4814
591fe988 4815 if (map == NULL) {
c93552c4
DB
4816 verbose(env, "kernel subsystem misconfigured verifier\n");
4817 return -EINVAL;
4818 }
4819
591fe988
DB
4820 /* In case of read-only, some additional restrictions
4821 * need to be applied in order to prevent altering the
4822 * state of the map from program side.
4823 */
4824 if ((map->map_flags & BPF_F_RDONLY_PROG) &&
4825 (func_id == BPF_FUNC_map_delete_elem ||
4826 func_id == BPF_FUNC_map_update_elem ||
4827 func_id == BPF_FUNC_map_push_elem ||
4828 func_id == BPF_FUNC_map_pop_elem)) {
4829 verbose(env, "write into map forbidden\n");
4830 return -EACCES;
4831 }
4832
d2e4c1e6 4833 if (!BPF_MAP_PTR(aux->map_ptr_state))
c93552c4 4834 bpf_map_ptr_store(aux, meta->map_ptr,
2c78ee89 4835 !meta->map_ptr->bypass_spec_v1);
d2e4c1e6 4836 else if (BPF_MAP_PTR(aux->map_ptr_state) != meta->map_ptr)
c93552c4 4837 bpf_map_ptr_store(aux, BPF_MAP_PTR_POISON,
2c78ee89 4838 !meta->map_ptr->bypass_spec_v1);
c93552c4
DB
4839 return 0;
4840}
4841
d2e4c1e6
DB
4842static int
4843record_func_key(struct bpf_verifier_env *env, struct bpf_call_arg_meta *meta,
4844 int func_id, int insn_idx)
4845{
4846 struct bpf_insn_aux_data *aux = &env->insn_aux_data[insn_idx];
4847 struct bpf_reg_state *regs = cur_regs(env), *reg;
4848 struct bpf_map *map = meta->map_ptr;
4849 struct tnum range;
4850 u64 val;
cc52d914 4851 int err;
d2e4c1e6
DB
4852
4853 if (func_id != BPF_FUNC_tail_call)
4854 return 0;
4855 if (!map || map->map_type != BPF_MAP_TYPE_PROG_ARRAY) {
4856 verbose(env, "kernel subsystem misconfigured verifier\n");
4857 return -EINVAL;
4858 }
4859
4860 range = tnum_range(0, map->max_entries - 1);
4861 reg = &regs[BPF_REG_3];
4862
4863 if (!register_is_const(reg) || !tnum_in(range, reg->var_off)) {
4864 bpf_map_key_store(aux, BPF_MAP_KEY_POISON);
4865 return 0;
4866 }
4867
cc52d914
DB
4868 err = mark_chain_precision(env, BPF_REG_3);
4869 if (err)
4870 return err;
4871
d2e4c1e6
DB
4872 val = reg->var_off.value;
4873 if (bpf_map_key_unseen(aux))
4874 bpf_map_key_store(aux, val);
4875 else if (!bpf_map_key_poisoned(aux) &&
4876 bpf_map_key_immediate(aux) != val)
4877 bpf_map_key_store(aux, BPF_MAP_KEY_POISON);
4878 return 0;
4879}
4880
fd978bf7
JS
4881static int check_reference_leak(struct bpf_verifier_env *env)
4882{
4883 struct bpf_func_state *state = cur_func(env);
4884 int i;
4885
4886 for (i = 0; i < state->acquired_refs; i++) {
4887 verbose(env, "Unreleased reference id=%d alloc_insn=%d\n",
4888 state->refs[i].id, state->refs[i].insn_idx);
4889 }
4890 return state->acquired_refs ? -EINVAL : 0;
4891}
4892
f4d7e40a 4893static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
17a52670 4894{
17a52670 4895 const struct bpf_func_proto *fn = NULL;
638f5b90 4896 struct bpf_reg_state *regs;
33ff9823 4897 struct bpf_call_arg_meta meta;
969bf05e 4898 bool changes_data;
17a52670
AS
4899 int i, err;
4900
4901 /* find function prototype */
4902 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
61bd5218
JK
4903 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
4904 func_id);
17a52670
AS
4905 return -EINVAL;
4906 }
4907
00176a34 4908 if (env->ops->get_func_proto)
5e43f899 4909 fn = env->ops->get_func_proto(func_id, env->prog);
17a52670 4910 if (!fn) {
61bd5218
JK
4911 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
4912 func_id);
17a52670
AS
4913 return -EINVAL;
4914 }
4915
4916 /* eBPF programs must be GPL compatible to use GPL-ed functions */
24701ece 4917 if (!env->prog->gpl_compatible && fn->gpl_only) {
3fe2867c 4918 verbose(env, "cannot call GPL-restricted function from non-GPL compatible program\n");
17a52670
AS
4919 return -EINVAL;
4920 }
4921
eae2e83e
JO
4922 if (fn->allowed && !fn->allowed(env->prog)) {
4923 verbose(env, "helper call is not allowed in probe\n");
4924 return -EINVAL;
4925 }
4926
04514d13 4927 /* With LD_ABS/IND some JITs save/restore skb from r1. */
17bedab2 4928 changes_data = bpf_helper_changes_pkt_data(fn->func);
04514d13
DB
4929 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
4930 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
4931 func_id_name(func_id), func_id);
4932 return -EINVAL;
4933 }
969bf05e 4934
33ff9823 4935 memset(&meta, 0, sizeof(meta));
36bbef52 4936 meta.pkt_access = fn->pkt_access;
33ff9823 4937
1b986589 4938 err = check_func_proto(fn, func_id);
435faee1 4939 if (err) {
61bd5218 4940 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
ebb676da 4941 func_id_name(func_id), func_id);
435faee1
DB
4942 return err;
4943 }
4944
d83525ca 4945 meta.func_id = func_id;
17a52670 4946 /* check args */
a7658e1a 4947 for (i = 0; i < 5; i++) {
af7ec138 4948 err = check_func_arg(env, i, &meta, fn);
a7658e1a
AS
4949 if (err)
4950 return err;
4951 }
17a52670 4952
c93552c4
DB
4953 err = record_func_map(env, &meta, func_id, insn_idx);
4954 if (err)
4955 return err;
4956
d2e4c1e6
DB
4957 err = record_func_key(env, &meta, func_id, insn_idx);
4958 if (err)
4959 return err;
4960
435faee1
DB
4961 /* Mark slots with STACK_MISC in case of raw mode, stack offset
4962 * is inferred from register state.
4963 */
4964 for (i = 0; i < meta.access_size; i++) {
ca369602
DB
4965 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B,
4966 BPF_WRITE, -1, false);
435faee1
DB
4967 if (err)
4968 return err;
4969 }
4970
fd978bf7
JS
4971 if (func_id == BPF_FUNC_tail_call) {
4972 err = check_reference_leak(env);
4973 if (err) {
4974 verbose(env, "tail_call would lead to reference leak\n");
4975 return err;
4976 }
4977 } else if (is_release_function(func_id)) {
1b986589 4978 err = release_reference(env, meta.ref_obj_id);
46f8bc92
MKL
4979 if (err) {
4980 verbose(env, "func %s#%d reference has not been acquired before\n",
4981 func_id_name(func_id), func_id);
fd978bf7 4982 return err;
46f8bc92 4983 }
fd978bf7
JS
4984 }
4985
638f5b90 4986 regs = cur_regs(env);
cd339431
RG
4987
4988 /* check that flags argument in get_local_storage(map, flags) is 0,
4989 * this is required because get_local_storage() can't return an error.
4990 */
4991 if (func_id == BPF_FUNC_get_local_storage &&
4992 !register_is_null(&regs[BPF_REG_2])) {
4993 verbose(env, "get_local_storage() doesn't support non-zero flags\n");
4994 return -EINVAL;
4995 }
4996
17a52670 4997 /* reset caller saved regs */
dc503a8a 4998 for (i = 0; i < CALLER_SAVED_REGS; i++) {
61bd5218 4999 mark_reg_not_init(env, regs, caller_saved[i]);
dc503a8a
EC
5000 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
5001 }
17a52670 5002
5327ed3d
JW
5003 /* helper call returns 64-bit value. */
5004 regs[BPF_REG_0].subreg_def = DEF_NOT_SUBREG;
5005
dc503a8a 5006 /* update return register (already marked as written above) */
17a52670 5007 if (fn->ret_type == RET_INTEGER) {
f1174f77 5008 /* sets type to SCALAR_VALUE */
61bd5218 5009 mark_reg_unknown(env, regs, BPF_REG_0);
17a52670
AS
5010 } else if (fn->ret_type == RET_VOID) {
5011 regs[BPF_REG_0].type = NOT_INIT;
3e6a4b3e
RG
5012 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL ||
5013 fn->ret_type == RET_PTR_TO_MAP_VALUE) {
f1174f77 5014 /* There is no offset yet applied, variable or fixed */
61bd5218 5015 mark_reg_known_zero(env, regs, BPF_REG_0);
17a52670
AS
5016 /* remember map_ptr, so that check_map_access()
5017 * can check 'value_size' boundary of memory access
5018 * to map element returned from bpf_map_lookup_elem()
5019 */
33ff9823 5020 if (meta.map_ptr == NULL) {
61bd5218
JK
5021 verbose(env,
5022 "kernel subsystem misconfigured verifier\n");
17a52670
AS
5023 return -EINVAL;
5024 }
33ff9823 5025 regs[BPF_REG_0].map_ptr = meta.map_ptr;
4d31f301
DB
5026 if (fn->ret_type == RET_PTR_TO_MAP_VALUE) {
5027 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE;
e16d2f1a
AS
5028 if (map_value_has_spin_lock(meta.map_ptr))
5029 regs[BPF_REG_0].id = ++env->id_gen;
4d31f301
DB
5030 } else {
5031 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
5032 regs[BPF_REG_0].id = ++env->id_gen;
5033 }
c64b7983
JS
5034 } else if (fn->ret_type == RET_PTR_TO_SOCKET_OR_NULL) {
5035 mark_reg_known_zero(env, regs, BPF_REG_0);
5036 regs[BPF_REG_0].type = PTR_TO_SOCKET_OR_NULL;
0f3adc28 5037 regs[BPF_REG_0].id = ++env->id_gen;
85a51f8c
LB
5038 } else if (fn->ret_type == RET_PTR_TO_SOCK_COMMON_OR_NULL) {
5039 mark_reg_known_zero(env, regs, BPF_REG_0);
5040 regs[BPF_REG_0].type = PTR_TO_SOCK_COMMON_OR_NULL;
5041 regs[BPF_REG_0].id = ++env->id_gen;
655a51e5
MKL
5042 } else if (fn->ret_type == RET_PTR_TO_TCP_SOCK_OR_NULL) {
5043 mark_reg_known_zero(env, regs, BPF_REG_0);
5044 regs[BPF_REG_0].type = PTR_TO_TCP_SOCK_OR_NULL;
5045 regs[BPF_REG_0].id = ++env->id_gen;
457f4436
AN
5046 } else if (fn->ret_type == RET_PTR_TO_ALLOC_MEM_OR_NULL) {
5047 mark_reg_known_zero(env, regs, BPF_REG_0);
5048 regs[BPF_REG_0].type = PTR_TO_MEM_OR_NULL;
5049 regs[BPF_REG_0].id = ++env->id_gen;
5050 regs[BPF_REG_0].mem_size = meta.mem_size;
af7ec138
YS
5051 } else if (fn->ret_type == RET_PTR_TO_BTF_ID_OR_NULL) {
5052 int ret_btf_id;
5053
5054 mark_reg_known_zero(env, regs, BPF_REG_0);
5055 regs[BPF_REG_0].type = PTR_TO_BTF_ID_OR_NULL;
5056 ret_btf_id = *fn->ret_btf_id;
5057 if (ret_btf_id == 0) {
5058 verbose(env, "invalid return type %d of func %s#%d\n",
5059 fn->ret_type, func_id_name(func_id), func_id);
5060 return -EINVAL;
5061 }
5062 regs[BPF_REG_0].btf_id = ret_btf_id;
17a52670 5063 } else {
61bd5218 5064 verbose(env, "unknown return type %d of func %s#%d\n",
ebb676da 5065 fn->ret_type, func_id_name(func_id), func_id);
17a52670
AS
5066 return -EINVAL;
5067 }
04fd61ab 5068
0f3adc28 5069 if (is_ptr_cast_function(func_id)) {
1b986589
MKL
5070 /* For release_reference() */
5071 regs[BPF_REG_0].ref_obj_id = meta.ref_obj_id;
64d85290 5072 } else if (is_acquire_function(func_id, meta.map_ptr)) {
0f3adc28
LB
5073 int id = acquire_reference_state(env, insn_idx);
5074
5075 if (id < 0)
5076 return id;
5077 /* For mark_ptr_or_null_reg() */
5078 regs[BPF_REG_0].id = id;
5079 /* For release_reference() */
5080 regs[BPF_REG_0].ref_obj_id = id;
5081 }
1b986589 5082
849fa506
YS
5083 do_refine_retval_range(regs, fn->ret_type, func_id, &meta);
5084
61bd5218 5085 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
35578d79
KX
5086 if (err)
5087 return err;
04fd61ab 5088
fa28dcb8
SL
5089 if ((func_id == BPF_FUNC_get_stack ||
5090 func_id == BPF_FUNC_get_task_stack) &&
5091 !env->prog->has_callchain_buf) {
c195651e
YS
5092 const char *err_str;
5093
5094#ifdef CONFIG_PERF_EVENTS
5095 err = get_callchain_buffers(sysctl_perf_event_max_stack);
5096 err_str = "cannot get callchain buffer for func %s#%d\n";
5097#else
5098 err = -ENOTSUPP;
5099 err_str = "func %s#%d not supported without CONFIG_PERF_EVENTS\n";
5100#endif
5101 if (err) {
5102 verbose(env, err_str, func_id_name(func_id), func_id);
5103 return err;
5104 }
5105
5106 env->prog->has_callchain_buf = true;
5107 }
5108
5d99cb2c
SL
5109 if (func_id == BPF_FUNC_get_stackid || func_id == BPF_FUNC_get_stack)
5110 env->prog->call_get_stack = true;
5111
969bf05e
AS
5112 if (changes_data)
5113 clear_all_pkt_pointers(env);
5114 return 0;
5115}
5116
b03c9f9f
EC
5117static bool signed_add_overflows(s64 a, s64 b)
5118{
5119 /* Do the add in u64, where overflow is well-defined */
5120 s64 res = (s64)((u64)a + (u64)b);
5121
5122 if (b < 0)
5123 return res > a;
5124 return res < a;
5125}
5126
3f50f132
JF
5127static bool signed_add32_overflows(s64 a, s64 b)
5128{
5129 /* Do the add in u32, where overflow is well-defined */
5130 s32 res = (s32)((u32)a + (u32)b);
5131
5132 if (b < 0)
5133 return res > a;
5134 return res < a;
5135}
5136
5137static bool signed_sub_overflows(s32 a, s32 b)
b03c9f9f
EC
5138{
5139 /* Do the sub in u64, where overflow is well-defined */
5140 s64 res = (s64)((u64)a - (u64)b);
5141
5142 if (b < 0)
5143 return res < a;
5144 return res > a;
969bf05e
AS
5145}
5146
3f50f132
JF
5147static bool signed_sub32_overflows(s32 a, s32 b)
5148{
5149 /* Do the sub in u64, where overflow is well-defined */
5150 s32 res = (s32)((u32)a - (u32)b);
5151
5152 if (b < 0)
5153 return res < a;
5154 return res > a;
5155}
5156
bb7f0f98
AS
5157static bool check_reg_sane_offset(struct bpf_verifier_env *env,
5158 const struct bpf_reg_state *reg,
5159 enum bpf_reg_type type)
5160{
5161 bool known = tnum_is_const(reg->var_off);
5162 s64 val = reg->var_off.value;
5163 s64 smin = reg->smin_value;
5164
5165 if (known && (val >= BPF_MAX_VAR_OFF || val <= -BPF_MAX_VAR_OFF)) {
5166 verbose(env, "math between %s pointer and %lld is not allowed\n",
5167 reg_type_str[type], val);
5168 return false;
5169 }
5170
5171 if (reg->off >= BPF_MAX_VAR_OFF || reg->off <= -BPF_MAX_VAR_OFF) {
5172 verbose(env, "%s pointer offset %d is not allowed\n",
5173 reg_type_str[type], reg->off);
5174 return false;
5175 }
5176
5177 if (smin == S64_MIN) {
5178 verbose(env, "math between %s pointer and register with unbounded min value is not allowed\n",
5179 reg_type_str[type]);
5180 return false;
5181 }
5182
5183 if (smin >= BPF_MAX_VAR_OFF || smin <= -BPF_MAX_VAR_OFF) {
5184 verbose(env, "value %lld makes %s pointer be out of bounds\n",
5185 smin, reg_type_str[type]);
5186 return false;
5187 }
5188
5189 return true;
5190}
5191
979d63d5
DB
5192static struct bpf_insn_aux_data *cur_aux(struct bpf_verifier_env *env)
5193{
5194 return &env->insn_aux_data[env->insn_idx];
5195}
5196
5197static int retrieve_ptr_limit(const struct bpf_reg_state *ptr_reg,
5198 u32 *ptr_limit, u8 opcode, bool off_is_neg)
5199{
5200 bool mask_to_left = (opcode == BPF_ADD && off_is_neg) ||
5201 (opcode == BPF_SUB && !off_is_neg);
5202 u32 off;
5203
5204 switch (ptr_reg->type) {
5205 case PTR_TO_STACK:
088ec26d
AI
5206 /* Indirect variable offset stack access is prohibited in
5207 * unprivileged mode so it's not handled here.
5208 */
979d63d5
DB
5209 off = ptr_reg->off + ptr_reg->var_off.value;
5210 if (mask_to_left)
5211 *ptr_limit = MAX_BPF_STACK + off;
5212 else
5213 *ptr_limit = -off;
5214 return 0;
5215 case PTR_TO_MAP_VALUE:
5216 if (mask_to_left) {
5217 *ptr_limit = ptr_reg->umax_value + ptr_reg->off;
5218 } else {
5219 off = ptr_reg->smin_value + ptr_reg->off;
5220 *ptr_limit = ptr_reg->map_ptr->value_size - off;
5221 }
5222 return 0;
5223 default:
5224 return -EINVAL;
5225 }
5226}
5227
d3bd7413
DB
5228static bool can_skip_alu_sanitation(const struct bpf_verifier_env *env,
5229 const struct bpf_insn *insn)
5230{
2c78ee89 5231 return env->bypass_spec_v1 || BPF_SRC(insn->code) == BPF_K;
d3bd7413
DB
5232}
5233
5234static int update_alu_sanitation_state(struct bpf_insn_aux_data *aux,
5235 u32 alu_state, u32 alu_limit)
5236{
5237 /* If we arrived here from different branches with different
5238 * state or limits to sanitize, then this won't work.
5239 */
5240 if (aux->alu_state &&
5241 (aux->alu_state != alu_state ||
5242 aux->alu_limit != alu_limit))
5243 return -EACCES;
5244
5245 /* Corresponding fixup done in fixup_bpf_calls(). */
5246 aux->alu_state = alu_state;
5247 aux->alu_limit = alu_limit;
5248 return 0;
5249}
5250
5251static int sanitize_val_alu(struct bpf_verifier_env *env,
5252 struct bpf_insn *insn)
5253{
5254 struct bpf_insn_aux_data *aux = cur_aux(env);
5255
5256 if (can_skip_alu_sanitation(env, insn))
5257 return 0;
5258
5259 return update_alu_sanitation_state(aux, BPF_ALU_NON_POINTER, 0);
5260}
5261
979d63d5
DB
5262static int sanitize_ptr_alu(struct bpf_verifier_env *env,
5263 struct bpf_insn *insn,
5264 const struct bpf_reg_state *ptr_reg,
5265 struct bpf_reg_state *dst_reg,
5266 bool off_is_neg)
5267{
5268 struct bpf_verifier_state *vstate = env->cur_state;
5269 struct bpf_insn_aux_data *aux = cur_aux(env);
5270 bool ptr_is_dst_reg = ptr_reg == dst_reg;
5271 u8 opcode = BPF_OP(insn->code);
5272 u32 alu_state, alu_limit;
5273 struct bpf_reg_state tmp;
5274 bool ret;
5275
d3bd7413 5276 if (can_skip_alu_sanitation(env, insn))
979d63d5
DB
5277 return 0;
5278
5279 /* We already marked aux for masking from non-speculative
5280 * paths, thus we got here in the first place. We only care
5281 * to explore bad access from here.
5282 */
5283 if (vstate->speculative)
5284 goto do_sim;
5285
5286 alu_state = off_is_neg ? BPF_ALU_NEG_VALUE : 0;
5287 alu_state |= ptr_is_dst_reg ?
5288 BPF_ALU_SANITIZE_SRC : BPF_ALU_SANITIZE_DST;
5289
5290 if (retrieve_ptr_limit(ptr_reg, &alu_limit, opcode, off_is_neg))
5291 return 0;
d3bd7413 5292 if (update_alu_sanitation_state(aux, alu_state, alu_limit))
979d63d5 5293 return -EACCES;
979d63d5
DB
5294do_sim:
5295 /* Simulate and find potential out-of-bounds access under
5296 * speculative execution from truncation as a result of
5297 * masking when off was not within expected range. If off
5298 * sits in dst, then we temporarily need to move ptr there
5299 * to simulate dst (== 0) +/-= ptr. Needed, for example,
5300 * for cases where we use K-based arithmetic in one direction
5301 * and truncated reg-based in the other in order to explore
5302 * bad access.
5303 */
5304 if (!ptr_is_dst_reg) {
5305 tmp = *dst_reg;
5306 *dst_reg = *ptr_reg;
5307 }
5308 ret = push_stack(env, env->insn_idx + 1, env->insn_idx, true);
0803278b 5309 if (!ptr_is_dst_reg && ret)
979d63d5
DB
5310 *dst_reg = tmp;
5311 return !ret ? -EFAULT : 0;
5312}
5313
f1174f77 5314/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
f1174f77
EC
5315 * Caller should also handle BPF_MOV case separately.
5316 * If we return -EACCES, caller may want to try again treating pointer as a
5317 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
5318 */
5319static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
5320 struct bpf_insn *insn,
5321 const struct bpf_reg_state *ptr_reg,
5322 const struct bpf_reg_state *off_reg)
969bf05e 5323{
f4d7e40a
AS
5324 struct bpf_verifier_state *vstate = env->cur_state;
5325 struct bpf_func_state *state = vstate->frame[vstate->curframe];
5326 struct bpf_reg_state *regs = state->regs, *dst_reg;
f1174f77 5327 bool known = tnum_is_const(off_reg->var_off);
b03c9f9f
EC
5328 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
5329 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
5330 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
5331 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
9d7eceed 5332 u32 dst = insn->dst_reg, src = insn->src_reg;
969bf05e 5333 u8 opcode = BPF_OP(insn->code);
979d63d5 5334 int ret;
969bf05e 5335
f1174f77 5336 dst_reg = &regs[dst];
969bf05e 5337
6f16101e
DB
5338 if ((known && (smin_val != smax_val || umin_val != umax_val)) ||
5339 smin_val > smax_val || umin_val > umax_val) {
5340 /* Taint dst register if offset had invalid bounds derived from
5341 * e.g. dead branches.
5342 */
f54c7898 5343 __mark_reg_unknown(env, dst_reg);
6f16101e 5344 return 0;
f1174f77
EC
5345 }
5346
5347 if (BPF_CLASS(insn->code) != BPF_ALU64) {
5348 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
6c693541
YS
5349 if (opcode == BPF_SUB && env->allow_ptr_leaks) {
5350 __mark_reg_unknown(env, dst_reg);
5351 return 0;
5352 }
5353
82abbf8d
AS
5354 verbose(env,
5355 "R%d 32-bit pointer arithmetic prohibited\n",
5356 dst);
f1174f77 5357 return -EACCES;
969bf05e
AS
5358 }
5359
aad2eeaf
JS
5360 switch (ptr_reg->type) {
5361 case PTR_TO_MAP_VALUE_OR_NULL:
5362 verbose(env, "R%d pointer arithmetic on %s prohibited, null-check it first\n",
5363 dst, reg_type_str[ptr_reg->type]);
f1174f77 5364 return -EACCES;
aad2eeaf 5365 case CONST_PTR_TO_MAP:
7c696732
YS
5366 /* smin_val represents the known value */
5367 if (known && smin_val == 0 && opcode == BPF_ADD)
5368 break;
5369 /* fall-through */
aad2eeaf 5370 case PTR_TO_PACKET_END:
c64b7983
JS
5371 case PTR_TO_SOCKET:
5372 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
5373 case PTR_TO_SOCK_COMMON:
5374 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
5375 case PTR_TO_TCP_SOCK:
5376 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 5377 case PTR_TO_XDP_SOCK:
aad2eeaf
JS
5378 verbose(env, "R%d pointer arithmetic on %s prohibited\n",
5379 dst, reg_type_str[ptr_reg->type]);
f1174f77 5380 return -EACCES;
9d7eceed
DB
5381 case PTR_TO_MAP_VALUE:
5382 if (!env->allow_ptr_leaks && !known && (smin_val < 0) != (smax_val < 0)) {
5383 verbose(env, "R%d has unknown scalar with mixed signed bounds, pointer arithmetic with it prohibited for !root\n",
5384 off_reg == dst_reg ? dst : src);
5385 return -EACCES;
5386 }
5387 /* fall-through */
aad2eeaf
JS
5388 default:
5389 break;
f1174f77
EC
5390 }
5391
5392 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
5393 * The id may be overwritten later if we create a new variable offset.
969bf05e 5394 */
f1174f77
EC
5395 dst_reg->type = ptr_reg->type;
5396 dst_reg->id = ptr_reg->id;
969bf05e 5397
bb7f0f98
AS
5398 if (!check_reg_sane_offset(env, off_reg, ptr_reg->type) ||
5399 !check_reg_sane_offset(env, ptr_reg, ptr_reg->type))
5400 return -EINVAL;
5401
3f50f132
JF
5402 /* pointer types do not carry 32-bit bounds at the moment. */
5403 __mark_reg32_unbounded(dst_reg);
5404
f1174f77
EC
5405 switch (opcode) {
5406 case BPF_ADD:
979d63d5
DB
5407 ret = sanitize_ptr_alu(env, insn, ptr_reg, dst_reg, smin_val < 0);
5408 if (ret < 0) {
5409 verbose(env, "R%d tried to add from different maps or paths\n", dst);
5410 return ret;
5411 }
f1174f77
EC
5412 /* We can take a fixed offset as long as it doesn't overflow
5413 * the s32 'off' field
969bf05e 5414 */
b03c9f9f
EC
5415 if (known && (ptr_reg->off + smin_val ==
5416 (s64)(s32)(ptr_reg->off + smin_val))) {
f1174f77 5417 /* pointer += K. Accumulate it into fixed offset */
b03c9f9f
EC
5418 dst_reg->smin_value = smin_ptr;
5419 dst_reg->smax_value = smax_ptr;
5420 dst_reg->umin_value = umin_ptr;
5421 dst_reg->umax_value = umax_ptr;
f1174f77 5422 dst_reg->var_off = ptr_reg->var_off;
b03c9f9f 5423 dst_reg->off = ptr_reg->off + smin_val;
0962590e 5424 dst_reg->raw = ptr_reg->raw;
f1174f77
EC
5425 break;
5426 }
f1174f77
EC
5427 /* A new variable offset is created. Note that off_reg->off
5428 * == 0, since it's a scalar.
5429 * dst_reg gets the pointer type and since some positive
5430 * integer value was added to the pointer, give it a new 'id'
5431 * if it's a PTR_TO_PACKET.
5432 * this creates a new 'base' pointer, off_reg (variable) gets
5433 * added into the variable offset, and we copy the fixed offset
5434 * from ptr_reg.
969bf05e 5435 */
b03c9f9f
EC
5436 if (signed_add_overflows(smin_ptr, smin_val) ||
5437 signed_add_overflows(smax_ptr, smax_val)) {
5438 dst_reg->smin_value = S64_MIN;
5439 dst_reg->smax_value = S64_MAX;
5440 } else {
5441 dst_reg->smin_value = smin_ptr + smin_val;
5442 dst_reg->smax_value = smax_ptr + smax_val;
5443 }
5444 if (umin_ptr + umin_val < umin_ptr ||
5445 umax_ptr + umax_val < umax_ptr) {
5446 dst_reg->umin_value = 0;
5447 dst_reg->umax_value = U64_MAX;
5448 } else {
5449 dst_reg->umin_value = umin_ptr + umin_val;
5450 dst_reg->umax_value = umax_ptr + umax_val;
5451 }
f1174f77
EC
5452 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
5453 dst_reg->off = ptr_reg->off;
0962590e 5454 dst_reg->raw = ptr_reg->raw;
de8f3a83 5455 if (reg_is_pkt_pointer(ptr_reg)) {
f1174f77
EC
5456 dst_reg->id = ++env->id_gen;
5457 /* something was added to pkt_ptr, set range to zero */
0962590e 5458 dst_reg->raw = 0;
f1174f77
EC
5459 }
5460 break;
5461 case BPF_SUB:
979d63d5
DB
5462 ret = sanitize_ptr_alu(env, insn, ptr_reg, dst_reg, smin_val < 0);
5463 if (ret < 0) {
5464 verbose(env, "R%d tried to sub from different maps or paths\n", dst);
5465 return ret;
5466 }
f1174f77
EC
5467 if (dst_reg == off_reg) {
5468 /* scalar -= pointer. Creates an unknown scalar */
82abbf8d
AS
5469 verbose(env, "R%d tried to subtract pointer from scalar\n",
5470 dst);
f1174f77
EC
5471 return -EACCES;
5472 }
5473 /* We don't allow subtraction from FP, because (according to
5474 * test_verifier.c test "invalid fp arithmetic", JITs might not
5475 * be able to deal with it.
969bf05e 5476 */
f1174f77 5477 if (ptr_reg->type == PTR_TO_STACK) {
82abbf8d
AS
5478 verbose(env, "R%d subtraction from stack pointer prohibited\n",
5479 dst);
f1174f77
EC
5480 return -EACCES;
5481 }
b03c9f9f
EC
5482 if (known && (ptr_reg->off - smin_val ==
5483 (s64)(s32)(ptr_reg->off - smin_val))) {
f1174f77 5484 /* pointer -= K. Subtract it from fixed offset */
b03c9f9f
EC
5485 dst_reg->smin_value = smin_ptr;
5486 dst_reg->smax_value = smax_ptr;
5487 dst_reg->umin_value = umin_ptr;
5488 dst_reg->umax_value = umax_ptr;
f1174f77
EC
5489 dst_reg->var_off = ptr_reg->var_off;
5490 dst_reg->id = ptr_reg->id;
b03c9f9f 5491 dst_reg->off = ptr_reg->off - smin_val;
0962590e 5492 dst_reg->raw = ptr_reg->raw;
f1174f77
EC
5493 break;
5494 }
f1174f77
EC
5495 /* A new variable offset is created. If the subtrahend is known
5496 * nonnegative, then any reg->range we had before is still good.
969bf05e 5497 */
b03c9f9f
EC
5498 if (signed_sub_overflows(smin_ptr, smax_val) ||
5499 signed_sub_overflows(smax_ptr, smin_val)) {
5500 /* Overflow possible, we know nothing */
5501 dst_reg->smin_value = S64_MIN;
5502 dst_reg->smax_value = S64_MAX;
5503 } else {
5504 dst_reg->smin_value = smin_ptr - smax_val;
5505 dst_reg->smax_value = smax_ptr - smin_val;
5506 }
5507 if (umin_ptr < umax_val) {
5508 /* Overflow possible, we know nothing */
5509 dst_reg->umin_value = 0;
5510 dst_reg->umax_value = U64_MAX;
5511 } else {
5512 /* Cannot overflow (as long as bounds are consistent) */
5513 dst_reg->umin_value = umin_ptr - umax_val;
5514 dst_reg->umax_value = umax_ptr - umin_val;
5515 }
f1174f77
EC
5516 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
5517 dst_reg->off = ptr_reg->off;
0962590e 5518 dst_reg->raw = ptr_reg->raw;
de8f3a83 5519 if (reg_is_pkt_pointer(ptr_reg)) {
f1174f77
EC
5520 dst_reg->id = ++env->id_gen;
5521 /* something was added to pkt_ptr, set range to zero */
b03c9f9f 5522 if (smin_val < 0)
0962590e 5523 dst_reg->raw = 0;
43188702 5524 }
f1174f77
EC
5525 break;
5526 case BPF_AND:
5527 case BPF_OR:
5528 case BPF_XOR:
82abbf8d
AS
5529 /* bitwise ops on pointers are troublesome, prohibit. */
5530 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
5531 dst, bpf_alu_string[opcode >> 4]);
f1174f77
EC
5532 return -EACCES;
5533 default:
5534 /* other operators (e.g. MUL,LSH) produce non-pointer results */
82abbf8d
AS
5535 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
5536 dst, bpf_alu_string[opcode >> 4]);
f1174f77 5537 return -EACCES;
43188702
JF
5538 }
5539
bb7f0f98
AS
5540 if (!check_reg_sane_offset(env, dst_reg, ptr_reg->type))
5541 return -EINVAL;
5542
b03c9f9f
EC
5543 __update_reg_bounds(dst_reg);
5544 __reg_deduce_bounds(dst_reg);
5545 __reg_bound_offset(dst_reg);
0d6303db
DB
5546
5547 /* For unprivileged we require that resulting offset must be in bounds
5548 * in order to be able to sanitize access later on.
5549 */
2c78ee89 5550 if (!env->bypass_spec_v1) {
e4298d25
DB
5551 if (dst_reg->type == PTR_TO_MAP_VALUE &&
5552 check_map_access(env, dst, dst_reg->off, 1, false)) {
5553 verbose(env, "R%d pointer arithmetic of map value goes out of range, "
5554 "prohibited for !root\n", dst);
5555 return -EACCES;
5556 } else if (dst_reg->type == PTR_TO_STACK &&
5557 check_stack_access(env, dst_reg, dst_reg->off +
5558 dst_reg->var_off.value, 1)) {
5559 verbose(env, "R%d stack pointer arithmetic goes out of range, "
5560 "prohibited for !root\n", dst);
5561 return -EACCES;
5562 }
0d6303db
DB
5563 }
5564
43188702
JF
5565 return 0;
5566}
5567
3f50f132
JF
5568static void scalar32_min_max_add(struct bpf_reg_state *dst_reg,
5569 struct bpf_reg_state *src_reg)
5570{
5571 s32 smin_val = src_reg->s32_min_value;
5572 s32 smax_val = src_reg->s32_max_value;
5573 u32 umin_val = src_reg->u32_min_value;
5574 u32 umax_val = src_reg->u32_max_value;
5575
5576 if (signed_add32_overflows(dst_reg->s32_min_value, smin_val) ||
5577 signed_add32_overflows(dst_reg->s32_max_value, smax_val)) {
5578 dst_reg->s32_min_value = S32_MIN;
5579 dst_reg->s32_max_value = S32_MAX;
5580 } else {
5581 dst_reg->s32_min_value += smin_val;
5582 dst_reg->s32_max_value += smax_val;
5583 }
5584 if (dst_reg->u32_min_value + umin_val < umin_val ||
5585 dst_reg->u32_max_value + umax_val < umax_val) {
5586 dst_reg->u32_min_value = 0;
5587 dst_reg->u32_max_value = U32_MAX;
5588 } else {
5589 dst_reg->u32_min_value += umin_val;
5590 dst_reg->u32_max_value += umax_val;
5591 }
5592}
5593
07cd2631
JF
5594static void scalar_min_max_add(struct bpf_reg_state *dst_reg,
5595 struct bpf_reg_state *src_reg)
5596{
5597 s64 smin_val = src_reg->smin_value;
5598 s64 smax_val = src_reg->smax_value;
5599 u64 umin_val = src_reg->umin_value;
5600 u64 umax_val = src_reg->umax_value;
5601
5602 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
5603 signed_add_overflows(dst_reg->smax_value, smax_val)) {
5604 dst_reg->smin_value = S64_MIN;
5605 dst_reg->smax_value = S64_MAX;
5606 } else {
5607 dst_reg->smin_value += smin_val;
5608 dst_reg->smax_value += smax_val;
5609 }
5610 if (dst_reg->umin_value + umin_val < umin_val ||
5611 dst_reg->umax_value + umax_val < umax_val) {
5612 dst_reg->umin_value = 0;
5613 dst_reg->umax_value = U64_MAX;
5614 } else {
5615 dst_reg->umin_value += umin_val;
5616 dst_reg->umax_value += umax_val;
5617 }
3f50f132
JF
5618}
5619
5620static void scalar32_min_max_sub(struct bpf_reg_state *dst_reg,
5621 struct bpf_reg_state *src_reg)
5622{
5623 s32 smin_val = src_reg->s32_min_value;
5624 s32 smax_val = src_reg->s32_max_value;
5625 u32 umin_val = src_reg->u32_min_value;
5626 u32 umax_val = src_reg->u32_max_value;
5627
5628 if (signed_sub32_overflows(dst_reg->s32_min_value, smax_val) ||
5629 signed_sub32_overflows(dst_reg->s32_max_value, smin_val)) {
5630 /* Overflow possible, we know nothing */
5631 dst_reg->s32_min_value = S32_MIN;
5632 dst_reg->s32_max_value = S32_MAX;
5633 } else {
5634 dst_reg->s32_min_value -= smax_val;
5635 dst_reg->s32_max_value -= smin_val;
5636 }
5637 if (dst_reg->u32_min_value < umax_val) {
5638 /* Overflow possible, we know nothing */
5639 dst_reg->u32_min_value = 0;
5640 dst_reg->u32_max_value = U32_MAX;
5641 } else {
5642 /* Cannot overflow (as long as bounds are consistent) */
5643 dst_reg->u32_min_value -= umax_val;
5644 dst_reg->u32_max_value -= umin_val;
5645 }
07cd2631
JF
5646}
5647
5648static void scalar_min_max_sub(struct bpf_reg_state *dst_reg,
5649 struct bpf_reg_state *src_reg)
5650{
5651 s64 smin_val = src_reg->smin_value;
5652 s64 smax_val = src_reg->smax_value;
5653 u64 umin_val = src_reg->umin_value;
5654 u64 umax_val = src_reg->umax_value;
5655
5656 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
5657 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
5658 /* Overflow possible, we know nothing */
5659 dst_reg->smin_value = S64_MIN;
5660 dst_reg->smax_value = S64_MAX;
5661 } else {
5662 dst_reg->smin_value -= smax_val;
5663 dst_reg->smax_value -= smin_val;
5664 }
5665 if (dst_reg->umin_value < umax_val) {
5666 /* Overflow possible, we know nothing */
5667 dst_reg->umin_value = 0;
5668 dst_reg->umax_value = U64_MAX;
5669 } else {
5670 /* Cannot overflow (as long as bounds are consistent) */
5671 dst_reg->umin_value -= umax_val;
5672 dst_reg->umax_value -= umin_val;
5673 }
3f50f132
JF
5674}
5675
5676static void scalar32_min_max_mul(struct bpf_reg_state *dst_reg,
5677 struct bpf_reg_state *src_reg)
5678{
5679 s32 smin_val = src_reg->s32_min_value;
5680 u32 umin_val = src_reg->u32_min_value;
5681 u32 umax_val = src_reg->u32_max_value;
5682
5683 if (smin_val < 0 || dst_reg->s32_min_value < 0) {
5684 /* Ain't nobody got time to multiply that sign */
5685 __mark_reg32_unbounded(dst_reg);
5686 return;
5687 }
5688 /* Both values are positive, so we can work with unsigned and
5689 * copy the result to signed (unless it exceeds S32_MAX).
5690 */
5691 if (umax_val > U16_MAX || dst_reg->u32_max_value > U16_MAX) {
5692 /* Potential overflow, we know nothing */
5693 __mark_reg32_unbounded(dst_reg);
5694 return;
5695 }
5696 dst_reg->u32_min_value *= umin_val;
5697 dst_reg->u32_max_value *= umax_val;
5698 if (dst_reg->u32_max_value > S32_MAX) {
5699 /* Overflow possible, we know nothing */
5700 dst_reg->s32_min_value = S32_MIN;
5701 dst_reg->s32_max_value = S32_MAX;
5702 } else {
5703 dst_reg->s32_min_value = dst_reg->u32_min_value;
5704 dst_reg->s32_max_value = dst_reg->u32_max_value;
5705 }
07cd2631
JF
5706}
5707
5708static void scalar_min_max_mul(struct bpf_reg_state *dst_reg,
5709 struct bpf_reg_state *src_reg)
5710{
5711 s64 smin_val = src_reg->smin_value;
5712 u64 umin_val = src_reg->umin_value;
5713 u64 umax_val = src_reg->umax_value;
5714
07cd2631
JF
5715 if (smin_val < 0 || dst_reg->smin_value < 0) {
5716 /* Ain't nobody got time to multiply that sign */
3f50f132 5717 __mark_reg64_unbounded(dst_reg);
07cd2631
JF
5718 return;
5719 }
5720 /* Both values are positive, so we can work with unsigned and
5721 * copy the result to signed (unless it exceeds S64_MAX).
5722 */
5723 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
5724 /* Potential overflow, we know nothing */
3f50f132 5725 __mark_reg64_unbounded(dst_reg);
07cd2631
JF
5726 return;
5727 }
5728 dst_reg->umin_value *= umin_val;
5729 dst_reg->umax_value *= umax_val;
5730 if (dst_reg->umax_value > S64_MAX) {
5731 /* Overflow possible, we know nothing */
5732 dst_reg->smin_value = S64_MIN;
5733 dst_reg->smax_value = S64_MAX;
5734 } else {
5735 dst_reg->smin_value = dst_reg->umin_value;
5736 dst_reg->smax_value = dst_reg->umax_value;
5737 }
5738}
5739
3f50f132
JF
5740static void scalar32_min_max_and(struct bpf_reg_state *dst_reg,
5741 struct bpf_reg_state *src_reg)
5742{
5743 bool src_known = tnum_subreg_is_const(src_reg->var_off);
5744 bool dst_known = tnum_subreg_is_const(dst_reg->var_off);
5745 struct tnum var32_off = tnum_subreg(dst_reg->var_off);
5746 s32 smin_val = src_reg->s32_min_value;
5747 u32 umax_val = src_reg->u32_max_value;
5748
5749 /* Assuming scalar64_min_max_and will be called so its safe
5750 * to skip updating register for known 32-bit case.
5751 */
5752 if (src_known && dst_known)
5753 return;
5754
5755 /* We get our minimum from the var_off, since that's inherently
5756 * bitwise. Our maximum is the minimum of the operands' maxima.
5757 */
5758 dst_reg->u32_min_value = var32_off.value;
5759 dst_reg->u32_max_value = min(dst_reg->u32_max_value, umax_val);
5760 if (dst_reg->s32_min_value < 0 || smin_val < 0) {
5761 /* Lose signed bounds when ANDing negative numbers,
5762 * ain't nobody got time for that.
5763 */
5764 dst_reg->s32_min_value = S32_MIN;
5765 dst_reg->s32_max_value = S32_MAX;
5766 } else {
5767 /* ANDing two positives gives a positive, so safe to
5768 * cast result into s64.
5769 */
5770 dst_reg->s32_min_value = dst_reg->u32_min_value;
5771 dst_reg->s32_max_value = dst_reg->u32_max_value;
5772 }
5773
5774}
5775
07cd2631
JF
5776static void scalar_min_max_and(struct bpf_reg_state *dst_reg,
5777 struct bpf_reg_state *src_reg)
5778{
3f50f132
JF
5779 bool src_known = tnum_is_const(src_reg->var_off);
5780 bool dst_known = tnum_is_const(dst_reg->var_off);
07cd2631
JF
5781 s64 smin_val = src_reg->smin_value;
5782 u64 umax_val = src_reg->umax_value;
5783
3f50f132
JF
5784 if (src_known && dst_known) {
5785 __mark_reg_known(dst_reg, dst_reg->var_off.value &
5786 src_reg->var_off.value);
5787 return;
5788 }
5789
07cd2631
JF
5790 /* We get our minimum from the var_off, since that's inherently
5791 * bitwise. Our maximum is the minimum of the operands' maxima.
5792 */
07cd2631
JF
5793 dst_reg->umin_value = dst_reg->var_off.value;
5794 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
5795 if (dst_reg->smin_value < 0 || smin_val < 0) {
5796 /* Lose signed bounds when ANDing negative numbers,
5797 * ain't nobody got time for that.
5798 */
5799 dst_reg->smin_value = S64_MIN;
5800 dst_reg->smax_value = S64_MAX;
5801 } else {
5802 /* ANDing two positives gives a positive, so safe to
5803 * cast result into s64.
5804 */
5805 dst_reg->smin_value = dst_reg->umin_value;
5806 dst_reg->smax_value = dst_reg->umax_value;
5807 }
5808 /* We may learn something more from the var_off */
5809 __update_reg_bounds(dst_reg);
5810}
5811
3f50f132
JF
5812static void scalar32_min_max_or(struct bpf_reg_state *dst_reg,
5813 struct bpf_reg_state *src_reg)
5814{
5815 bool src_known = tnum_subreg_is_const(src_reg->var_off);
5816 bool dst_known = tnum_subreg_is_const(dst_reg->var_off);
5817 struct tnum var32_off = tnum_subreg(dst_reg->var_off);
5818 s32 smin_val = src_reg->smin_value;
5819 u32 umin_val = src_reg->umin_value;
5820
5821 /* Assuming scalar64_min_max_or will be called so it is safe
5822 * to skip updating register for known case.
5823 */
5824 if (src_known && dst_known)
5825 return;
5826
5827 /* We get our maximum from the var_off, and our minimum is the
5828 * maximum of the operands' minima
5829 */
5830 dst_reg->u32_min_value = max(dst_reg->u32_min_value, umin_val);
5831 dst_reg->u32_max_value = var32_off.value | var32_off.mask;
5832 if (dst_reg->s32_min_value < 0 || smin_val < 0) {
5833 /* Lose signed bounds when ORing negative numbers,
5834 * ain't nobody got time for that.
5835 */
5836 dst_reg->s32_min_value = S32_MIN;
5837 dst_reg->s32_max_value = S32_MAX;
5838 } else {
5839 /* ORing two positives gives a positive, so safe to
5840 * cast result into s64.
5841 */
5842 dst_reg->s32_min_value = dst_reg->umin_value;
5843 dst_reg->s32_max_value = dst_reg->umax_value;
5844 }
5845}
5846
07cd2631
JF
5847static void scalar_min_max_or(struct bpf_reg_state *dst_reg,
5848 struct bpf_reg_state *src_reg)
5849{
3f50f132
JF
5850 bool src_known = tnum_is_const(src_reg->var_off);
5851 bool dst_known = tnum_is_const(dst_reg->var_off);
07cd2631
JF
5852 s64 smin_val = src_reg->smin_value;
5853 u64 umin_val = src_reg->umin_value;
5854
3f50f132
JF
5855 if (src_known && dst_known) {
5856 __mark_reg_known(dst_reg, dst_reg->var_off.value |
5857 src_reg->var_off.value);
5858 return;
5859 }
5860
07cd2631
JF
5861 /* We get our maximum from the var_off, and our minimum is the
5862 * maximum of the operands' minima
5863 */
07cd2631
JF
5864 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
5865 dst_reg->umax_value = dst_reg->var_off.value | dst_reg->var_off.mask;
5866 if (dst_reg->smin_value < 0 || smin_val < 0) {
5867 /* Lose signed bounds when ORing negative numbers,
5868 * ain't nobody got time for that.
5869 */
5870 dst_reg->smin_value = S64_MIN;
5871 dst_reg->smax_value = S64_MAX;
5872 } else {
5873 /* ORing two positives gives a positive, so safe to
5874 * cast result into s64.
5875 */
5876 dst_reg->smin_value = dst_reg->umin_value;
5877 dst_reg->smax_value = dst_reg->umax_value;
5878 }
5879 /* We may learn something more from the var_off */
5880 __update_reg_bounds(dst_reg);
5881}
5882
2921c90d
YS
5883static void scalar32_min_max_xor(struct bpf_reg_state *dst_reg,
5884 struct bpf_reg_state *src_reg)
5885{
5886 bool src_known = tnum_subreg_is_const(src_reg->var_off);
5887 bool dst_known = tnum_subreg_is_const(dst_reg->var_off);
5888 struct tnum var32_off = tnum_subreg(dst_reg->var_off);
5889 s32 smin_val = src_reg->s32_min_value;
5890
5891 /* Assuming scalar64_min_max_xor will be called so it is safe
5892 * to skip updating register for known case.
5893 */
5894 if (src_known && dst_known)
5895 return;
5896
5897 /* We get both minimum and maximum from the var32_off. */
5898 dst_reg->u32_min_value = var32_off.value;
5899 dst_reg->u32_max_value = var32_off.value | var32_off.mask;
5900
5901 if (dst_reg->s32_min_value >= 0 && smin_val >= 0) {
5902 /* XORing two positive sign numbers gives a positive,
5903 * so safe to cast u32 result into s32.
5904 */
5905 dst_reg->s32_min_value = dst_reg->u32_min_value;
5906 dst_reg->s32_max_value = dst_reg->u32_max_value;
5907 } else {
5908 dst_reg->s32_min_value = S32_MIN;
5909 dst_reg->s32_max_value = S32_MAX;
5910 }
5911}
5912
5913static void scalar_min_max_xor(struct bpf_reg_state *dst_reg,
5914 struct bpf_reg_state *src_reg)
5915{
5916 bool src_known = tnum_is_const(src_reg->var_off);
5917 bool dst_known = tnum_is_const(dst_reg->var_off);
5918 s64 smin_val = src_reg->smin_value;
5919
5920 if (src_known && dst_known) {
5921 /* dst_reg->var_off.value has been updated earlier */
5922 __mark_reg_known(dst_reg, dst_reg->var_off.value);
5923 return;
5924 }
5925
5926 /* We get both minimum and maximum from the var_off. */
5927 dst_reg->umin_value = dst_reg->var_off.value;
5928 dst_reg->umax_value = dst_reg->var_off.value | dst_reg->var_off.mask;
5929
5930 if (dst_reg->smin_value >= 0 && smin_val >= 0) {
5931 /* XORing two positive sign numbers gives a positive,
5932 * so safe to cast u64 result into s64.
5933 */
5934 dst_reg->smin_value = dst_reg->umin_value;
5935 dst_reg->smax_value = dst_reg->umax_value;
5936 } else {
5937 dst_reg->smin_value = S64_MIN;
5938 dst_reg->smax_value = S64_MAX;
5939 }
5940
5941 __update_reg_bounds(dst_reg);
5942}
5943
3f50f132
JF
5944static void __scalar32_min_max_lsh(struct bpf_reg_state *dst_reg,
5945 u64 umin_val, u64 umax_val)
07cd2631 5946{
07cd2631
JF
5947 /* We lose all sign bit information (except what we can pick
5948 * up from var_off)
5949 */
3f50f132
JF
5950 dst_reg->s32_min_value = S32_MIN;
5951 dst_reg->s32_max_value = S32_MAX;
5952 /* If we might shift our top bit out, then we know nothing */
5953 if (umax_val > 31 || dst_reg->u32_max_value > 1ULL << (31 - umax_val)) {
5954 dst_reg->u32_min_value = 0;
5955 dst_reg->u32_max_value = U32_MAX;
5956 } else {
5957 dst_reg->u32_min_value <<= umin_val;
5958 dst_reg->u32_max_value <<= umax_val;
5959 }
5960}
5961
5962static void scalar32_min_max_lsh(struct bpf_reg_state *dst_reg,
5963 struct bpf_reg_state *src_reg)
5964{
5965 u32 umax_val = src_reg->u32_max_value;
5966 u32 umin_val = src_reg->u32_min_value;
5967 /* u32 alu operation will zext upper bits */
5968 struct tnum subreg = tnum_subreg(dst_reg->var_off);
5969
5970 __scalar32_min_max_lsh(dst_reg, umin_val, umax_val);
5971 dst_reg->var_off = tnum_subreg(tnum_lshift(subreg, umin_val));
5972 /* Not required but being careful mark reg64 bounds as unknown so
5973 * that we are forced to pick them up from tnum and zext later and
5974 * if some path skips this step we are still safe.
5975 */
5976 __mark_reg64_unbounded(dst_reg);
5977 __update_reg32_bounds(dst_reg);
5978}
5979
5980static void __scalar64_min_max_lsh(struct bpf_reg_state *dst_reg,
5981 u64 umin_val, u64 umax_val)
5982{
5983 /* Special case <<32 because it is a common compiler pattern to sign
5984 * extend subreg by doing <<32 s>>32. In this case if 32bit bounds are
5985 * positive we know this shift will also be positive so we can track
5986 * bounds correctly. Otherwise we lose all sign bit information except
5987 * what we can pick up from var_off. Perhaps we can generalize this
5988 * later to shifts of any length.
5989 */
5990 if (umin_val == 32 && umax_val == 32 && dst_reg->s32_max_value >= 0)
5991 dst_reg->smax_value = (s64)dst_reg->s32_max_value << 32;
5992 else
5993 dst_reg->smax_value = S64_MAX;
5994
5995 if (umin_val == 32 && umax_val == 32 && dst_reg->s32_min_value >= 0)
5996 dst_reg->smin_value = (s64)dst_reg->s32_min_value << 32;
5997 else
5998 dst_reg->smin_value = S64_MIN;
5999
07cd2631
JF
6000 /* If we might shift our top bit out, then we know nothing */
6001 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
6002 dst_reg->umin_value = 0;
6003 dst_reg->umax_value = U64_MAX;
6004 } else {
6005 dst_reg->umin_value <<= umin_val;
6006 dst_reg->umax_value <<= umax_val;
6007 }
3f50f132
JF
6008}
6009
6010static void scalar_min_max_lsh(struct bpf_reg_state *dst_reg,
6011 struct bpf_reg_state *src_reg)
6012{
6013 u64 umax_val = src_reg->umax_value;
6014 u64 umin_val = src_reg->umin_value;
6015
6016 /* scalar64 calc uses 32bit unshifted bounds so must be called first */
6017 __scalar64_min_max_lsh(dst_reg, umin_val, umax_val);
6018 __scalar32_min_max_lsh(dst_reg, umin_val, umax_val);
6019
07cd2631
JF
6020 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
6021 /* We may learn something more from the var_off */
6022 __update_reg_bounds(dst_reg);
6023}
6024
3f50f132
JF
6025static void scalar32_min_max_rsh(struct bpf_reg_state *dst_reg,
6026 struct bpf_reg_state *src_reg)
6027{
6028 struct tnum subreg = tnum_subreg(dst_reg->var_off);
6029 u32 umax_val = src_reg->u32_max_value;
6030 u32 umin_val = src_reg->u32_min_value;
6031
6032 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
6033 * be negative, then either:
6034 * 1) src_reg might be zero, so the sign bit of the result is
6035 * unknown, so we lose our signed bounds
6036 * 2) it's known negative, thus the unsigned bounds capture the
6037 * signed bounds
6038 * 3) the signed bounds cross zero, so they tell us nothing
6039 * about the result
6040 * If the value in dst_reg is known nonnegative, then again the
6041 * unsigned bounts capture the signed bounds.
6042 * Thus, in all cases it suffices to blow away our signed bounds
6043 * and rely on inferring new ones from the unsigned bounds and
6044 * var_off of the result.
6045 */
6046 dst_reg->s32_min_value = S32_MIN;
6047 dst_reg->s32_max_value = S32_MAX;
6048
6049 dst_reg->var_off = tnum_rshift(subreg, umin_val);
6050 dst_reg->u32_min_value >>= umax_val;
6051 dst_reg->u32_max_value >>= umin_val;
6052
6053 __mark_reg64_unbounded(dst_reg);
6054 __update_reg32_bounds(dst_reg);
6055}
6056
07cd2631
JF
6057static void scalar_min_max_rsh(struct bpf_reg_state *dst_reg,
6058 struct bpf_reg_state *src_reg)
6059{
6060 u64 umax_val = src_reg->umax_value;
6061 u64 umin_val = src_reg->umin_value;
6062
6063 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
6064 * be negative, then either:
6065 * 1) src_reg might be zero, so the sign bit of the result is
6066 * unknown, so we lose our signed bounds
6067 * 2) it's known negative, thus the unsigned bounds capture the
6068 * signed bounds
6069 * 3) the signed bounds cross zero, so they tell us nothing
6070 * about the result
6071 * If the value in dst_reg is known nonnegative, then again the
6072 * unsigned bounts capture the signed bounds.
6073 * Thus, in all cases it suffices to blow away our signed bounds
6074 * and rely on inferring new ones from the unsigned bounds and
6075 * var_off of the result.
6076 */
6077 dst_reg->smin_value = S64_MIN;
6078 dst_reg->smax_value = S64_MAX;
6079 dst_reg->var_off = tnum_rshift(dst_reg->var_off, umin_val);
6080 dst_reg->umin_value >>= umax_val;
6081 dst_reg->umax_value >>= umin_val;
3f50f132
JF
6082
6083 /* Its not easy to operate on alu32 bounds here because it depends
6084 * on bits being shifted in. Take easy way out and mark unbounded
6085 * so we can recalculate later from tnum.
6086 */
6087 __mark_reg32_unbounded(dst_reg);
07cd2631
JF
6088 __update_reg_bounds(dst_reg);
6089}
6090
3f50f132
JF
6091static void scalar32_min_max_arsh(struct bpf_reg_state *dst_reg,
6092 struct bpf_reg_state *src_reg)
07cd2631 6093{
3f50f132 6094 u64 umin_val = src_reg->u32_min_value;
07cd2631
JF
6095
6096 /* Upon reaching here, src_known is true and
6097 * umax_val is equal to umin_val.
6098 */
3f50f132
JF
6099 dst_reg->s32_min_value = (u32)(((s32)dst_reg->s32_min_value) >> umin_val);
6100 dst_reg->s32_max_value = (u32)(((s32)dst_reg->s32_max_value) >> umin_val);
07cd2631 6101
3f50f132
JF
6102 dst_reg->var_off = tnum_arshift(tnum_subreg(dst_reg->var_off), umin_val, 32);
6103
6104 /* blow away the dst_reg umin_value/umax_value and rely on
6105 * dst_reg var_off to refine the result.
6106 */
6107 dst_reg->u32_min_value = 0;
6108 dst_reg->u32_max_value = U32_MAX;
6109
6110 __mark_reg64_unbounded(dst_reg);
6111 __update_reg32_bounds(dst_reg);
6112}
6113
6114static void scalar_min_max_arsh(struct bpf_reg_state *dst_reg,
6115 struct bpf_reg_state *src_reg)
6116{
6117 u64 umin_val = src_reg->umin_value;
6118
6119 /* Upon reaching here, src_known is true and umax_val is equal
6120 * to umin_val.
6121 */
6122 dst_reg->smin_value >>= umin_val;
6123 dst_reg->smax_value >>= umin_val;
6124
6125 dst_reg->var_off = tnum_arshift(dst_reg->var_off, umin_val, 64);
07cd2631
JF
6126
6127 /* blow away the dst_reg umin_value/umax_value and rely on
6128 * dst_reg var_off to refine the result.
6129 */
6130 dst_reg->umin_value = 0;
6131 dst_reg->umax_value = U64_MAX;
3f50f132
JF
6132
6133 /* Its not easy to operate on alu32 bounds here because it depends
6134 * on bits being shifted in from upper 32-bits. Take easy way out
6135 * and mark unbounded so we can recalculate later from tnum.
6136 */
6137 __mark_reg32_unbounded(dst_reg);
07cd2631
JF
6138 __update_reg_bounds(dst_reg);
6139}
6140
468f6eaf
JH
6141/* WARNING: This function does calculations on 64-bit values, but the actual
6142 * execution may occur on 32-bit values. Therefore, things like bitshifts
6143 * need extra checks in the 32-bit case.
6144 */
f1174f77
EC
6145static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
6146 struct bpf_insn *insn,
6147 struct bpf_reg_state *dst_reg,
6148 struct bpf_reg_state src_reg)
969bf05e 6149{
638f5b90 6150 struct bpf_reg_state *regs = cur_regs(env);
48461135 6151 u8 opcode = BPF_OP(insn->code);
b0b3fb67 6152 bool src_known;
b03c9f9f
EC
6153 s64 smin_val, smax_val;
6154 u64 umin_val, umax_val;
3f50f132
JF
6155 s32 s32_min_val, s32_max_val;
6156 u32 u32_min_val, u32_max_val;
468f6eaf 6157 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
d3bd7413
DB
6158 u32 dst = insn->dst_reg;
6159 int ret;
3f50f132 6160 bool alu32 = (BPF_CLASS(insn->code) != BPF_ALU64);
b799207e 6161
b03c9f9f
EC
6162 smin_val = src_reg.smin_value;
6163 smax_val = src_reg.smax_value;
6164 umin_val = src_reg.umin_value;
6165 umax_val = src_reg.umax_value;
f23cc643 6166
3f50f132
JF
6167 s32_min_val = src_reg.s32_min_value;
6168 s32_max_val = src_reg.s32_max_value;
6169 u32_min_val = src_reg.u32_min_value;
6170 u32_max_val = src_reg.u32_max_value;
6171
6172 if (alu32) {
6173 src_known = tnum_subreg_is_const(src_reg.var_off);
3f50f132
JF
6174 if ((src_known &&
6175 (s32_min_val != s32_max_val || u32_min_val != u32_max_val)) ||
6176 s32_min_val > s32_max_val || u32_min_val > u32_max_val) {
6177 /* Taint dst register if offset had invalid bounds
6178 * derived from e.g. dead branches.
6179 */
6180 __mark_reg_unknown(env, dst_reg);
6181 return 0;
6182 }
6183 } else {
6184 src_known = tnum_is_const(src_reg.var_off);
3f50f132
JF
6185 if ((src_known &&
6186 (smin_val != smax_val || umin_val != umax_val)) ||
6187 smin_val > smax_val || umin_val > umax_val) {
6188 /* Taint dst register if offset had invalid bounds
6189 * derived from e.g. dead branches.
6190 */
6191 __mark_reg_unknown(env, dst_reg);
6192 return 0;
6193 }
6f16101e
DB
6194 }
6195
bb7f0f98
AS
6196 if (!src_known &&
6197 opcode != BPF_ADD && opcode != BPF_SUB && opcode != BPF_AND) {
f54c7898 6198 __mark_reg_unknown(env, dst_reg);
bb7f0f98
AS
6199 return 0;
6200 }
6201
3f50f132
JF
6202 /* Calculate sign/unsigned bounds and tnum for alu32 and alu64 bit ops.
6203 * There are two classes of instructions: The first class we track both
6204 * alu32 and alu64 sign/unsigned bounds independently this provides the
6205 * greatest amount of precision when alu operations are mixed with jmp32
6206 * operations. These operations are BPF_ADD, BPF_SUB, BPF_MUL, BPF_ADD,
6207 * and BPF_OR. This is possible because these ops have fairly easy to
6208 * understand and calculate behavior in both 32-bit and 64-bit alu ops.
6209 * See alu32 verifier tests for examples. The second class of
6210 * operations, BPF_LSH, BPF_RSH, and BPF_ARSH, however are not so easy
6211 * with regards to tracking sign/unsigned bounds because the bits may
6212 * cross subreg boundaries in the alu64 case. When this happens we mark
6213 * the reg unbounded in the subreg bound space and use the resulting
6214 * tnum to calculate an approximation of the sign/unsigned bounds.
6215 */
48461135
JB
6216 switch (opcode) {
6217 case BPF_ADD:
d3bd7413
DB
6218 ret = sanitize_val_alu(env, insn);
6219 if (ret < 0) {
6220 verbose(env, "R%d tried to add from different pointers or scalars\n", dst);
6221 return ret;
6222 }
3f50f132 6223 scalar32_min_max_add(dst_reg, &src_reg);
07cd2631 6224 scalar_min_max_add(dst_reg, &src_reg);
3f50f132 6225 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
48461135
JB
6226 break;
6227 case BPF_SUB:
d3bd7413
DB
6228 ret = sanitize_val_alu(env, insn);
6229 if (ret < 0) {
6230 verbose(env, "R%d tried to sub from different pointers or scalars\n", dst);
6231 return ret;
6232 }
3f50f132 6233 scalar32_min_max_sub(dst_reg, &src_reg);
07cd2631 6234 scalar_min_max_sub(dst_reg, &src_reg);
3f50f132 6235 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
48461135
JB
6236 break;
6237 case BPF_MUL:
3f50f132
JF
6238 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
6239 scalar32_min_max_mul(dst_reg, &src_reg);
07cd2631 6240 scalar_min_max_mul(dst_reg, &src_reg);
48461135
JB
6241 break;
6242 case BPF_AND:
3f50f132
JF
6243 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
6244 scalar32_min_max_and(dst_reg, &src_reg);
07cd2631 6245 scalar_min_max_and(dst_reg, &src_reg);
f1174f77
EC
6246 break;
6247 case BPF_OR:
3f50f132
JF
6248 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
6249 scalar32_min_max_or(dst_reg, &src_reg);
07cd2631 6250 scalar_min_max_or(dst_reg, &src_reg);
48461135 6251 break;
2921c90d
YS
6252 case BPF_XOR:
6253 dst_reg->var_off = tnum_xor(dst_reg->var_off, src_reg.var_off);
6254 scalar32_min_max_xor(dst_reg, &src_reg);
6255 scalar_min_max_xor(dst_reg, &src_reg);
6256 break;
48461135 6257 case BPF_LSH:
468f6eaf
JH
6258 if (umax_val >= insn_bitness) {
6259 /* Shifts greater than 31 or 63 are undefined.
6260 * This includes shifts by a negative number.
b03c9f9f 6261 */
61bd5218 6262 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77
EC
6263 break;
6264 }
3f50f132
JF
6265 if (alu32)
6266 scalar32_min_max_lsh(dst_reg, &src_reg);
6267 else
6268 scalar_min_max_lsh(dst_reg, &src_reg);
48461135
JB
6269 break;
6270 case BPF_RSH:
468f6eaf
JH
6271 if (umax_val >= insn_bitness) {
6272 /* Shifts greater than 31 or 63 are undefined.
6273 * This includes shifts by a negative number.
b03c9f9f 6274 */
61bd5218 6275 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77
EC
6276 break;
6277 }
3f50f132
JF
6278 if (alu32)
6279 scalar32_min_max_rsh(dst_reg, &src_reg);
6280 else
6281 scalar_min_max_rsh(dst_reg, &src_reg);
48461135 6282 break;
9cbe1f5a
YS
6283 case BPF_ARSH:
6284 if (umax_val >= insn_bitness) {
6285 /* Shifts greater than 31 or 63 are undefined.
6286 * This includes shifts by a negative number.
6287 */
6288 mark_reg_unknown(env, regs, insn->dst_reg);
6289 break;
6290 }
3f50f132
JF
6291 if (alu32)
6292 scalar32_min_max_arsh(dst_reg, &src_reg);
6293 else
6294 scalar_min_max_arsh(dst_reg, &src_reg);
9cbe1f5a 6295 break;
48461135 6296 default:
61bd5218 6297 mark_reg_unknown(env, regs, insn->dst_reg);
48461135
JB
6298 break;
6299 }
6300
3f50f132
JF
6301 /* ALU32 ops are zero extended into 64bit register */
6302 if (alu32)
6303 zext_32_to_64(dst_reg);
468f6eaf 6304
294f2fc6 6305 __update_reg_bounds(dst_reg);
b03c9f9f
EC
6306 __reg_deduce_bounds(dst_reg);
6307 __reg_bound_offset(dst_reg);
f1174f77
EC
6308 return 0;
6309}
6310
6311/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
6312 * and var_off.
6313 */
6314static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
6315 struct bpf_insn *insn)
6316{
f4d7e40a
AS
6317 struct bpf_verifier_state *vstate = env->cur_state;
6318 struct bpf_func_state *state = vstate->frame[vstate->curframe];
6319 struct bpf_reg_state *regs = state->regs, *dst_reg, *src_reg;
f1174f77
EC
6320 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
6321 u8 opcode = BPF_OP(insn->code);
b5dc0163 6322 int err;
f1174f77
EC
6323
6324 dst_reg = &regs[insn->dst_reg];
f1174f77
EC
6325 src_reg = NULL;
6326 if (dst_reg->type != SCALAR_VALUE)
6327 ptr_reg = dst_reg;
6328 if (BPF_SRC(insn->code) == BPF_X) {
6329 src_reg = &regs[insn->src_reg];
f1174f77
EC
6330 if (src_reg->type != SCALAR_VALUE) {
6331 if (dst_reg->type != SCALAR_VALUE) {
6332 /* Combining two pointers by any ALU op yields
82abbf8d
AS
6333 * an arbitrary scalar. Disallow all math except
6334 * pointer subtraction
f1174f77 6335 */
dd066823 6336 if (opcode == BPF_SUB && env->allow_ptr_leaks) {
82abbf8d
AS
6337 mark_reg_unknown(env, regs, insn->dst_reg);
6338 return 0;
f1174f77 6339 }
82abbf8d
AS
6340 verbose(env, "R%d pointer %s pointer prohibited\n",
6341 insn->dst_reg,
6342 bpf_alu_string[opcode >> 4]);
6343 return -EACCES;
f1174f77
EC
6344 } else {
6345 /* scalar += pointer
6346 * This is legal, but we have to reverse our
6347 * src/dest handling in computing the range
6348 */
b5dc0163
AS
6349 err = mark_chain_precision(env, insn->dst_reg);
6350 if (err)
6351 return err;
82abbf8d
AS
6352 return adjust_ptr_min_max_vals(env, insn,
6353 src_reg, dst_reg);
f1174f77
EC
6354 }
6355 } else if (ptr_reg) {
6356 /* pointer += scalar */
b5dc0163
AS
6357 err = mark_chain_precision(env, insn->src_reg);
6358 if (err)
6359 return err;
82abbf8d
AS
6360 return adjust_ptr_min_max_vals(env, insn,
6361 dst_reg, src_reg);
f1174f77
EC
6362 }
6363 } else {
6364 /* Pretend the src is a reg with a known value, since we only
6365 * need to be able to read from this state.
6366 */
6367 off_reg.type = SCALAR_VALUE;
b03c9f9f 6368 __mark_reg_known(&off_reg, insn->imm);
f1174f77 6369 src_reg = &off_reg;
82abbf8d
AS
6370 if (ptr_reg) /* pointer += K */
6371 return adjust_ptr_min_max_vals(env, insn,
6372 ptr_reg, src_reg);
f1174f77
EC
6373 }
6374
6375 /* Got here implies adding two SCALAR_VALUEs */
6376 if (WARN_ON_ONCE(ptr_reg)) {
f4d7e40a 6377 print_verifier_state(env, state);
61bd5218 6378 verbose(env, "verifier internal error: unexpected ptr_reg\n");
f1174f77
EC
6379 return -EINVAL;
6380 }
6381 if (WARN_ON(!src_reg)) {
f4d7e40a 6382 print_verifier_state(env, state);
61bd5218 6383 verbose(env, "verifier internal error: no src_reg\n");
f1174f77
EC
6384 return -EINVAL;
6385 }
6386 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
48461135
JB
6387}
6388
17a52670 6389/* check validity of 32-bit and 64-bit arithmetic operations */
58e2af8b 6390static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 6391{
638f5b90 6392 struct bpf_reg_state *regs = cur_regs(env);
17a52670
AS
6393 u8 opcode = BPF_OP(insn->code);
6394 int err;
6395
6396 if (opcode == BPF_END || opcode == BPF_NEG) {
6397 if (opcode == BPF_NEG) {
6398 if (BPF_SRC(insn->code) != 0 ||
6399 insn->src_reg != BPF_REG_0 ||
6400 insn->off != 0 || insn->imm != 0) {
61bd5218 6401 verbose(env, "BPF_NEG uses reserved fields\n");
17a52670
AS
6402 return -EINVAL;
6403 }
6404 } else {
6405 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
e67b8a68
EC
6406 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
6407 BPF_CLASS(insn->code) == BPF_ALU64) {
61bd5218 6408 verbose(env, "BPF_END uses reserved fields\n");
17a52670
AS
6409 return -EINVAL;
6410 }
6411 }
6412
6413 /* check src operand */
dc503a8a 6414 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
6415 if (err)
6416 return err;
6417
1be7f75d 6418 if (is_pointer_value(env, insn->dst_reg)) {
61bd5218 6419 verbose(env, "R%d pointer arithmetic prohibited\n",
1be7f75d
AS
6420 insn->dst_reg);
6421 return -EACCES;
6422 }
6423
17a52670 6424 /* check dest operand */
dc503a8a 6425 err = check_reg_arg(env, insn->dst_reg, DST_OP);
17a52670
AS
6426 if (err)
6427 return err;
6428
6429 } else if (opcode == BPF_MOV) {
6430
6431 if (BPF_SRC(insn->code) == BPF_X) {
6432 if (insn->imm != 0 || insn->off != 0) {
61bd5218 6433 verbose(env, "BPF_MOV uses reserved fields\n");
17a52670
AS
6434 return -EINVAL;
6435 }
6436
6437 /* check src operand */
dc503a8a 6438 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
6439 if (err)
6440 return err;
6441 } else {
6442 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
61bd5218 6443 verbose(env, "BPF_MOV uses reserved fields\n");
17a52670
AS
6444 return -EINVAL;
6445 }
6446 }
6447
fbeb1603
AF
6448 /* check dest operand, mark as required later */
6449 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
17a52670
AS
6450 if (err)
6451 return err;
6452
6453 if (BPF_SRC(insn->code) == BPF_X) {
e434b8cd
JW
6454 struct bpf_reg_state *src_reg = regs + insn->src_reg;
6455 struct bpf_reg_state *dst_reg = regs + insn->dst_reg;
6456
17a52670
AS
6457 if (BPF_CLASS(insn->code) == BPF_ALU64) {
6458 /* case: R1 = R2
6459 * copy register state to dest reg
6460 */
e434b8cd
JW
6461 *dst_reg = *src_reg;
6462 dst_reg->live |= REG_LIVE_WRITTEN;
5327ed3d 6463 dst_reg->subreg_def = DEF_NOT_SUBREG;
17a52670 6464 } else {
f1174f77 6465 /* R1 = (u32) R2 */
1be7f75d 6466 if (is_pointer_value(env, insn->src_reg)) {
61bd5218
JK
6467 verbose(env,
6468 "R%d partial copy of pointer\n",
1be7f75d
AS
6469 insn->src_reg);
6470 return -EACCES;
e434b8cd
JW
6471 } else if (src_reg->type == SCALAR_VALUE) {
6472 *dst_reg = *src_reg;
6473 dst_reg->live |= REG_LIVE_WRITTEN;
5327ed3d 6474 dst_reg->subreg_def = env->insn_idx + 1;
e434b8cd
JW
6475 } else {
6476 mark_reg_unknown(env, regs,
6477 insn->dst_reg);
1be7f75d 6478 }
3f50f132 6479 zext_32_to_64(dst_reg);
17a52670
AS
6480 }
6481 } else {
6482 /* case: R = imm
6483 * remember the value we stored into this reg
6484 */
fbeb1603
AF
6485 /* clear any state __mark_reg_known doesn't set */
6486 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77 6487 regs[insn->dst_reg].type = SCALAR_VALUE;
95a762e2
JH
6488 if (BPF_CLASS(insn->code) == BPF_ALU64) {
6489 __mark_reg_known(regs + insn->dst_reg,
6490 insn->imm);
6491 } else {
6492 __mark_reg_known(regs + insn->dst_reg,
6493 (u32)insn->imm);
6494 }
17a52670
AS
6495 }
6496
6497 } else if (opcode > BPF_END) {
61bd5218 6498 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
17a52670
AS
6499 return -EINVAL;
6500
6501 } else { /* all other ALU ops: and, sub, xor, add, ... */
6502
17a52670
AS
6503 if (BPF_SRC(insn->code) == BPF_X) {
6504 if (insn->imm != 0 || insn->off != 0) {
61bd5218 6505 verbose(env, "BPF_ALU uses reserved fields\n");
17a52670
AS
6506 return -EINVAL;
6507 }
6508 /* check src1 operand */
dc503a8a 6509 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
6510 if (err)
6511 return err;
6512 } else {
6513 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
61bd5218 6514 verbose(env, "BPF_ALU uses reserved fields\n");
17a52670
AS
6515 return -EINVAL;
6516 }
6517 }
6518
6519 /* check src2 operand */
dc503a8a 6520 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
6521 if (err)
6522 return err;
6523
6524 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
6525 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
61bd5218 6526 verbose(env, "div by zero\n");
17a52670
AS
6527 return -EINVAL;
6528 }
6529
229394e8
RV
6530 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
6531 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
6532 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
6533
6534 if (insn->imm < 0 || insn->imm >= size) {
61bd5218 6535 verbose(env, "invalid shift %d\n", insn->imm);
229394e8
RV
6536 return -EINVAL;
6537 }
6538 }
6539
1a0dc1ac 6540 /* check dest operand */
dc503a8a 6541 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
1a0dc1ac
AS
6542 if (err)
6543 return err;
6544
f1174f77 6545 return adjust_reg_min_max_vals(env, insn);
17a52670
AS
6546 }
6547
6548 return 0;
6549}
6550
c6a9efa1
PC
6551static void __find_good_pkt_pointers(struct bpf_func_state *state,
6552 struct bpf_reg_state *dst_reg,
6553 enum bpf_reg_type type, u16 new_range)
6554{
6555 struct bpf_reg_state *reg;
6556 int i;
6557
6558 for (i = 0; i < MAX_BPF_REG; i++) {
6559 reg = &state->regs[i];
6560 if (reg->type == type && reg->id == dst_reg->id)
6561 /* keep the maximum range already checked */
6562 reg->range = max(reg->range, new_range);
6563 }
6564
6565 bpf_for_each_spilled_reg(i, state, reg) {
6566 if (!reg)
6567 continue;
6568 if (reg->type == type && reg->id == dst_reg->id)
6569 reg->range = max(reg->range, new_range);
6570 }
6571}
6572
f4d7e40a 6573static void find_good_pkt_pointers(struct bpf_verifier_state *vstate,
de8f3a83 6574 struct bpf_reg_state *dst_reg,
f8ddadc4 6575 enum bpf_reg_type type,
fb2a311a 6576 bool range_right_open)
969bf05e 6577{
fb2a311a 6578 u16 new_range;
c6a9efa1 6579 int i;
2d2be8ca 6580
fb2a311a
DB
6581 if (dst_reg->off < 0 ||
6582 (dst_reg->off == 0 && range_right_open))
f1174f77
EC
6583 /* This doesn't give us any range */
6584 return;
6585
b03c9f9f
EC
6586 if (dst_reg->umax_value > MAX_PACKET_OFF ||
6587 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
f1174f77
EC
6588 /* Risk of overflow. For instance, ptr + (1<<63) may be less
6589 * than pkt_end, but that's because it's also less than pkt.
6590 */
6591 return;
6592
fb2a311a
DB
6593 new_range = dst_reg->off;
6594 if (range_right_open)
6595 new_range--;
6596
6597 /* Examples for register markings:
2d2be8ca 6598 *
fb2a311a 6599 * pkt_data in dst register:
2d2be8ca
DB
6600 *
6601 * r2 = r3;
6602 * r2 += 8;
6603 * if (r2 > pkt_end) goto <handle exception>
6604 * <access okay>
6605 *
b4e432f1
DB
6606 * r2 = r3;
6607 * r2 += 8;
6608 * if (r2 < pkt_end) goto <access okay>
6609 * <handle exception>
6610 *
2d2be8ca
DB
6611 * Where:
6612 * r2 == dst_reg, pkt_end == src_reg
6613 * r2=pkt(id=n,off=8,r=0)
6614 * r3=pkt(id=n,off=0,r=0)
6615 *
fb2a311a 6616 * pkt_data in src register:
2d2be8ca
DB
6617 *
6618 * r2 = r3;
6619 * r2 += 8;
6620 * if (pkt_end >= r2) goto <access okay>
6621 * <handle exception>
6622 *
b4e432f1
DB
6623 * r2 = r3;
6624 * r2 += 8;
6625 * if (pkt_end <= r2) goto <handle exception>
6626 * <access okay>
6627 *
2d2be8ca
DB
6628 * Where:
6629 * pkt_end == dst_reg, r2 == src_reg
6630 * r2=pkt(id=n,off=8,r=0)
6631 * r3=pkt(id=n,off=0,r=0)
6632 *
6633 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
fb2a311a
DB
6634 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
6635 * and [r3, r3 + 8-1) respectively is safe to access depending on
6636 * the check.
969bf05e 6637 */
2d2be8ca 6638
f1174f77
EC
6639 /* If our ids match, then we must have the same max_value. And we
6640 * don't care about the other reg's fixed offset, since if it's too big
6641 * the range won't allow anything.
6642 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
6643 */
c6a9efa1
PC
6644 for (i = 0; i <= vstate->curframe; i++)
6645 __find_good_pkt_pointers(vstate->frame[i], dst_reg, type,
6646 new_range);
969bf05e
AS
6647}
6648
3f50f132 6649static int is_branch32_taken(struct bpf_reg_state *reg, u32 val, u8 opcode)
4f7b3e82 6650{
3f50f132
JF
6651 struct tnum subreg = tnum_subreg(reg->var_off);
6652 s32 sval = (s32)val;
a72dafaf 6653
3f50f132
JF
6654 switch (opcode) {
6655 case BPF_JEQ:
6656 if (tnum_is_const(subreg))
6657 return !!tnum_equals_const(subreg, val);
6658 break;
6659 case BPF_JNE:
6660 if (tnum_is_const(subreg))
6661 return !tnum_equals_const(subreg, val);
6662 break;
6663 case BPF_JSET:
6664 if ((~subreg.mask & subreg.value) & val)
6665 return 1;
6666 if (!((subreg.mask | subreg.value) & val))
6667 return 0;
6668 break;
6669 case BPF_JGT:
6670 if (reg->u32_min_value > val)
6671 return 1;
6672 else if (reg->u32_max_value <= val)
6673 return 0;
6674 break;
6675 case BPF_JSGT:
6676 if (reg->s32_min_value > sval)
6677 return 1;
6678 else if (reg->s32_max_value < sval)
6679 return 0;
6680 break;
6681 case BPF_JLT:
6682 if (reg->u32_max_value < val)
6683 return 1;
6684 else if (reg->u32_min_value >= val)
6685 return 0;
6686 break;
6687 case BPF_JSLT:
6688 if (reg->s32_max_value < sval)
6689 return 1;
6690 else if (reg->s32_min_value >= sval)
6691 return 0;
6692 break;
6693 case BPF_JGE:
6694 if (reg->u32_min_value >= val)
6695 return 1;
6696 else if (reg->u32_max_value < val)
6697 return 0;
6698 break;
6699 case BPF_JSGE:
6700 if (reg->s32_min_value >= sval)
6701 return 1;
6702 else if (reg->s32_max_value < sval)
6703 return 0;
6704 break;
6705 case BPF_JLE:
6706 if (reg->u32_max_value <= val)
6707 return 1;
6708 else if (reg->u32_min_value > val)
6709 return 0;
6710 break;
6711 case BPF_JSLE:
6712 if (reg->s32_max_value <= sval)
6713 return 1;
6714 else if (reg->s32_min_value > sval)
6715 return 0;
6716 break;
6717 }
4f7b3e82 6718
3f50f132
JF
6719 return -1;
6720}
092ed096 6721
3f50f132
JF
6722
6723static int is_branch64_taken(struct bpf_reg_state *reg, u64 val, u8 opcode)
6724{
6725 s64 sval = (s64)val;
a72dafaf 6726
4f7b3e82
AS
6727 switch (opcode) {
6728 case BPF_JEQ:
6729 if (tnum_is_const(reg->var_off))
6730 return !!tnum_equals_const(reg->var_off, val);
6731 break;
6732 case BPF_JNE:
6733 if (tnum_is_const(reg->var_off))
6734 return !tnum_equals_const(reg->var_off, val);
6735 break;
960ea056
JK
6736 case BPF_JSET:
6737 if ((~reg->var_off.mask & reg->var_off.value) & val)
6738 return 1;
6739 if (!((reg->var_off.mask | reg->var_off.value) & val))
6740 return 0;
6741 break;
4f7b3e82
AS
6742 case BPF_JGT:
6743 if (reg->umin_value > val)
6744 return 1;
6745 else if (reg->umax_value <= val)
6746 return 0;
6747 break;
6748 case BPF_JSGT:
a72dafaf 6749 if (reg->smin_value > sval)
4f7b3e82 6750 return 1;
a72dafaf 6751 else if (reg->smax_value < sval)
4f7b3e82
AS
6752 return 0;
6753 break;
6754 case BPF_JLT:
6755 if (reg->umax_value < val)
6756 return 1;
6757 else if (reg->umin_value >= val)
6758 return 0;
6759 break;
6760 case BPF_JSLT:
a72dafaf 6761 if (reg->smax_value < sval)
4f7b3e82 6762 return 1;
a72dafaf 6763 else if (reg->smin_value >= sval)
4f7b3e82
AS
6764 return 0;
6765 break;
6766 case BPF_JGE:
6767 if (reg->umin_value >= val)
6768 return 1;
6769 else if (reg->umax_value < val)
6770 return 0;
6771 break;
6772 case BPF_JSGE:
a72dafaf 6773 if (reg->smin_value >= sval)
4f7b3e82 6774 return 1;
a72dafaf 6775 else if (reg->smax_value < sval)
4f7b3e82
AS
6776 return 0;
6777 break;
6778 case BPF_JLE:
6779 if (reg->umax_value <= val)
6780 return 1;
6781 else if (reg->umin_value > val)
6782 return 0;
6783 break;
6784 case BPF_JSLE:
a72dafaf 6785 if (reg->smax_value <= sval)
4f7b3e82 6786 return 1;
a72dafaf 6787 else if (reg->smin_value > sval)
4f7b3e82
AS
6788 return 0;
6789 break;
6790 }
6791
6792 return -1;
6793}
6794
3f50f132
JF
6795/* compute branch direction of the expression "if (reg opcode val) goto target;"
6796 * and return:
6797 * 1 - branch will be taken and "goto target" will be executed
6798 * 0 - branch will not be taken and fall-through to next insn
6799 * -1 - unknown. Example: "if (reg < 5)" is unknown when register value
6800 * range [0,10]
604dca5e 6801 */
3f50f132
JF
6802static int is_branch_taken(struct bpf_reg_state *reg, u64 val, u8 opcode,
6803 bool is_jmp32)
604dca5e 6804{
cac616db
JF
6805 if (__is_pointer_value(false, reg)) {
6806 if (!reg_type_not_null(reg->type))
6807 return -1;
6808
6809 /* If pointer is valid tests against zero will fail so we can
6810 * use this to direct branch taken.
6811 */
6812 if (val != 0)
6813 return -1;
6814
6815 switch (opcode) {
6816 case BPF_JEQ:
6817 return 0;
6818 case BPF_JNE:
6819 return 1;
6820 default:
6821 return -1;
6822 }
6823 }
604dca5e 6824
3f50f132
JF
6825 if (is_jmp32)
6826 return is_branch32_taken(reg, val, opcode);
6827 return is_branch64_taken(reg, val, opcode);
604dca5e
JH
6828}
6829
48461135
JB
6830/* Adjusts the register min/max values in the case that the dst_reg is the
6831 * variable register that we are working on, and src_reg is a constant or we're
6832 * simply doing a BPF_K check.
f1174f77 6833 * In JEQ/JNE cases we also adjust the var_off values.
48461135
JB
6834 */
6835static void reg_set_min_max(struct bpf_reg_state *true_reg,
3f50f132
JF
6836 struct bpf_reg_state *false_reg,
6837 u64 val, u32 val32,
092ed096 6838 u8 opcode, bool is_jmp32)
48461135 6839{
3f50f132
JF
6840 struct tnum false_32off = tnum_subreg(false_reg->var_off);
6841 struct tnum false_64off = false_reg->var_off;
6842 struct tnum true_32off = tnum_subreg(true_reg->var_off);
6843 struct tnum true_64off = true_reg->var_off;
6844 s64 sval = (s64)val;
6845 s32 sval32 = (s32)val32;
a72dafaf 6846
f1174f77
EC
6847 /* If the dst_reg is a pointer, we can't learn anything about its
6848 * variable offset from the compare (unless src_reg were a pointer into
6849 * the same object, but we don't bother with that.
6850 * Since false_reg and true_reg have the same type by construction, we
6851 * only need to check one of them for pointerness.
6852 */
6853 if (__is_pointer_value(false, false_reg))
6854 return;
4cabc5b1 6855
48461135
JB
6856 switch (opcode) {
6857 case BPF_JEQ:
48461135 6858 case BPF_JNE:
a72dafaf
JW
6859 {
6860 struct bpf_reg_state *reg =
6861 opcode == BPF_JEQ ? true_reg : false_reg;
6862
6863 /* For BPF_JEQ, if this is false we know nothing Jon Snow, but
6864 * if it is true we know the value for sure. Likewise for
6865 * BPF_JNE.
48461135 6866 */
3f50f132
JF
6867 if (is_jmp32)
6868 __mark_reg32_known(reg, val32);
6869 else
092ed096 6870 __mark_reg_known(reg, val);
48461135 6871 break;
a72dafaf 6872 }
960ea056 6873 case BPF_JSET:
3f50f132
JF
6874 if (is_jmp32) {
6875 false_32off = tnum_and(false_32off, tnum_const(~val32));
6876 if (is_power_of_2(val32))
6877 true_32off = tnum_or(true_32off,
6878 tnum_const(val32));
6879 } else {
6880 false_64off = tnum_and(false_64off, tnum_const(~val));
6881 if (is_power_of_2(val))
6882 true_64off = tnum_or(true_64off,
6883 tnum_const(val));
6884 }
960ea056 6885 break;
48461135 6886 case BPF_JGE:
a72dafaf
JW
6887 case BPF_JGT:
6888 {
3f50f132
JF
6889 if (is_jmp32) {
6890 u32 false_umax = opcode == BPF_JGT ? val32 : val32 - 1;
6891 u32 true_umin = opcode == BPF_JGT ? val32 + 1 : val32;
6892
6893 false_reg->u32_max_value = min(false_reg->u32_max_value,
6894 false_umax);
6895 true_reg->u32_min_value = max(true_reg->u32_min_value,
6896 true_umin);
6897 } else {
6898 u64 false_umax = opcode == BPF_JGT ? val : val - 1;
6899 u64 true_umin = opcode == BPF_JGT ? val + 1 : val;
6900
6901 false_reg->umax_value = min(false_reg->umax_value, false_umax);
6902 true_reg->umin_value = max(true_reg->umin_value, true_umin);
6903 }
b03c9f9f 6904 break;
a72dafaf 6905 }
48461135 6906 case BPF_JSGE:
a72dafaf
JW
6907 case BPF_JSGT:
6908 {
3f50f132
JF
6909 if (is_jmp32) {
6910 s32 false_smax = opcode == BPF_JSGT ? sval32 : sval32 - 1;
6911 s32 true_smin = opcode == BPF_JSGT ? sval32 + 1 : sval32;
a72dafaf 6912
3f50f132
JF
6913 false_reg->s32_max_value = min(false_reg->s32_max_value, false_smax);
6914 true_reg->s32_min_value = max(true_reg->s32_min_value, true_smin);
6915 } else {
6916 s64 false_smax = opcode == BPF_JSGT ? sval : sval - 1;
6917 s64 true_smin = opcode == BPF_JSGT ? sval + 1 : sval;
6918
6919 false_reg->smax_value = min(false_reg->smax_value, false_smax);
6920 true_reg->smin_value = max(true_reg->smin_value, true_smin);
6921 }
48461135 6922 break;
a72dafaf 6923 }
b4e432f1 6924 case BPF_JLE:
a72dafaf
JW
6925 case BPF_JLT:
6926 {
3f50f132
JF
6927 if (is_jmp32) {
6928 u32 false_umin = opcode == BPF_JLT ? val32 : val32 + 1;
6929 u32 true_umax = opcode == BPF_JLT ? val32 - 1 : val32;
6930
6931 false_reg->u32_min_value = max(false_reg->u32_min_value,
6932 false_umin);
6933 true_reg->u32_max_value = min(true_reg->u32_max_value,
6934 true_umax);
6935 } else {
6936 u64 false_umin = opcode == BPF_JLT ? val : val + 1;
6937 u64 true_umax = opcode == BPF_JLT ? val - 1 : val;
6938
6939 false_reg->umin_value = max(false_reg->umin_value, false_umin);
6940 true_reg->umax_value = min(true_reg->umax_value, true_umax);
6941 }
b4e432f1 6942 break;
a72dafaf 6943 }
b4e432f1 6944 case BPF_JSLE:
a72dafaf
JW
6945 case BPF_JSLT:
6946 {
3f50f132
JF
6947 if (is_jmp32) {
6948 s32 false_smin = opcode == BPF_JSLT ? sval32 : sval32 + 1;
6949 s32 true_smax = opcode == BPF_JSLT ? sval32 - 1 : sval32;
a72dafaf 6950
3f50f132
JF
6951 false_reg->s32_min_value = max(false_reg->s32_min_value, false_smin);
6952 true_reg->s32_max_value = min(true_reg->s32_max_value, true_smax);
6953 } else {
6954 s64 false_smin = opcode == BPF_JSLT ? sval : sval + 1;
6955 s64 true_smax = opcode == BPF_JSLT ? sval - 1 : sval;
6956
6957 false_reg->smin_value = max(false_reg->smin_value, false_smin);
6958 true_reg->smax_value = min(true_reg->smax_value, true_smax);
6959 }
b4e432f1 6960 break;
a72dafaf 6961 }
48461135 6962 default:
0fc31b10 6963 return;
48461135
JB
6964 }
6965
3f50f132
JF
6966 if (is_jmp32) {
6967 false_reg->var_off = tnum_or(tnum_clear_subreg(false_64off),
6968 tnum_subreg(false_32off));
6969 true_reg->var_off = tnum_or(tnum_clear_subreg(true_64off),
6970 tnum_subreg(true_32off));
6971 __reg_combine_32_into_64(false_reg);
6972 __reg_combine_32_into_64(true_reg);
6973 } else {
6974 false_reg->var_off = false_64off;
6975 true_reg->var_off = true_64off;
6976 __reg_combine_64_into_32(false_reg);
6977 __reg_combine_64_into_32(true_reg);
6978 }
48461135
JB
6979}
6980
f1174f77
EC
6981/* Same as above, but for the case that dst_reg holds a constant and src_reg is
6982 * the variable reg.
48461135
JB
6983 */
6984static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
3f50f132
JF
6985 struct bpf_reg_state *false_reg,
6986 u64 val, u32 val32,
092ed096 6987 u8 opcode, bool is_jmp32)
48461135 6988{
0fc31b10
JH
6989 /* How can we transform "a <op> b" into "b <op> a"? */
6990 static const u8 opcode_flip[16] = {
6991 /* these stay the same */
6992 [BPF_JEQ >> 4] = BPF_JEQ,
6993 [BPF_JNE >> 4] = BPF_JNE,
6994 [BPF_JSET >> 4] = BPF_JSET,
6995 /* these swap "lesser" and "greater" (L and G in the opcodes) */
6996 [BPF_JGE >> 4] = BPF_JLE,
6997 [BPF_JGT >> 4] = BPF_JLT,
6998 [BPF_JLE >> 4] = BPF_JGE,
6999 [BPF_JLT >> 4] = BPF_JGT,
7000 [BPF_JSGE >> 4] = BPF_JSLE,
7001 [BPF_JSGT >> 4] = BPF_JSLT,
7002 [BPF_JSLE >> 4] = BPF_JSGE,
7003 [BPF_JSLT >> 4] = BPF_JSGT
7004 };
7005 opcode = opcode_flip[opcode >> 4];
7006 /* This uses zero as "not present in table"; luckily the zero opcode,
7007 * BPF_JA, can't get here.
b03c9f9f 7008 */
0fc31b10 7009 if (opcode)
3f50f132 7010 reg_set_min_max(true_reg, false_reg, val, val32, opcode, is_jmp32);
f1174f77
EC
7011}
7012
7013/* Regs are known to be equal, so intersect their min/max/var_off */
7014static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
7015 struct bpf_reg_state *dst_reg)
7016{
b03c9f9f
EC
7017 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
7018 dst_reg->umin_value);
7019 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
7020 dst_reg->umax_value);
7021 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
7022 dst_reg->smin_value);
7023 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
7024 dst_reg->smax_value);
f1174f77
EC
7025 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
7026 dst_reg->var_off);
b03c9f9f
EC
7027 /* We might have learned new bounds from the var_off. */
7028 __update_reg_bounds(src_reg);
7029 __update_reg_bounds(dst_reg);
7030 /* We might have learned something about the sign bit. */
7031 __reg_deduce_bounds(src_reg);
7032 __reg_deduce_bounds(dst_reg);
7033 /* We might have learned some bits from the bounds. */
7034 __reg_bound_offset(src_reg);
7035 __reg_bound_offset(dst_reg);
7036 /* Intersecting with the old var_off might have improved our bounds
7037 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
7038 * then new var_off is (0; 0x7f...fc) which improves our umax.
7039 */
7040 __update_reg_bounds(src_reg);
7041 __update_reg_bounds(dst_reg);
f1174f77
EC
7042}
7043
7044static void reg_combine_min_max(struct bpf_reg_state *true_src,
7045 struct bpf_reg_state *true_dst,
7046 struct bpf_reg_state *false_src,
7047 struct bpf_reg_state *false_dst,
7048 u8 opcode)
7049{
7050 switch (opcode) {
7051 case BPF_JEQ:
7052 __reg_combine_min_max(true_src, true_dst);
7053 break;
7054 case BPF_JNE:
7055 __reg_combine_min_max(false_src, false_dst);
b03c9f9f 7056 break;
4cabc5b1 7057 }
48461135
JB
7058}
7059
fd978bf7
JS
7060static void mark_ptr_or_null_reg(struct bpf_func_state *state,
7061 struct bpf_reg_state *reg, u32 id,
840b9615 7062 bool is_null)
57a09bf0 7063{
840b9615 7064 if (reg_type_may_be_null(reg->type) && reg->id == id) {
f1174f77
EC
7065 /* Old offset (both fixed and variable parts) should
7066 * have been known-zero, because we don't allow pointer
7067 * arithmetic on pointers that might be NULL.
7068 */
b03c9f9f
EC
7069 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
7070 !tnum_equals_const(reg->var_off, 0) ||
f1174f77 7071 reg->off)) {
b03c9f9f
EC
7072 __mark_reg_known_zero(reg);
7073 reg->off = 0;
f1174f77
EC
7074 }
7075 if (is_null) {
7076 reg->type = SCALAR_VALUE;
840b9615 7077 } else if (reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
64d85290
JS
7078 const struct bpf_map *map = reg->map_ptr;
7079
7080 if (map->inner_map_meta) {
840b9615 7081 reg->type = CONST_PTR_TO_MAP;
64d85290
JS
7082 reg->map_ptr = map->inner_map_meta;
7083 } else if (map->map_type == BPF_MAP_TYPE_XSKMAP) {
fada7fdc 7084 reg->type = PTR_TO_XDP_SOCK;
64d85290
JS
7085 } else if (map->map_type == BPF_MAP_TYPE_SOCKMAP ||
7086 map->map_type == BPF_MAP_TYPE_SOCKHASH) {
7087 reg->type = PTR_TO_SOCKET;
840b9615
JS
7088 } else {
7089 reg->type = PTR_TO_MAP_VALUE;
7090 }
c64b7983
JS
7091 } else if (reg->type == PTR_TO_SOCKET_OR_NULL) {
7092 reg->type = PTR_TO_SOCKET;
46f8bc92
MKL
7093 } else if (reg->type == PTR_TO_SOCK_COMMON_OR_NULL) {
7094 reg->type = PTR_TO_SOCK_COMMON;
655a51e5
MKL
7095 } else if (reg->type == PTR_TO_TCP_SOCK_OR_NULL) {
7096 reg->type = PTR_TO_TCP_SOCK;
b121b341
YS
7097 } else if (reg->type == PTR_TO_BTF_ID_OR_NULL) {
7098 reg->type = PTR_TO_BTF_ID;
457f4436
AN
7099 } else if (reg->type == PTR_TO_MEM_OR_NULL) {
7100 reg->type = PTR_TO_MEM;
afbf21dc
YS
7101 } else if (reg->type == PTR_TO_RDONLY_BUF_OR_NULL) {
7102 reg->type = PTR_TO_RDONLY_BUF;
7103 } else if (reg->type == PTR_TO_RDWR_BUF_OR_NULL) {
7104 reg->type = PTR_TO_RDWR_BUF;
56f668df 7105 }
1b986589
MKL
7106 if (is_null) {
7107 /* We don't need id and ref_obj_id from this point
7108 * onwards anymore, thus we should better reset it,
7109 * so that state pruning has chances to take effect.
7110 */
7111 reg->id = 0;
7112 reg->ref_obj_id = 0;
7113 } else if (!reg_may_point_to_spin_lock(reg)) {
7114 /* For not-NULL ptr, reg->ref_obj_id will be reset
7115 * in release_reg_references().
7116 *
7117 * reg->id is still used by spin_lock ptr. Other
7118 * than spin_lock ptr type, reg->id can be reset.
fd978bf7
JS
7119 */
7120 reg->id = 0;
56f668df 7121 }
57a09bf0
TG
7122 }
7123}
7124
c6a9efa1
PC
7125static void __mark_ptr_or_null_regs(struct bpf_func_state *state, u32 id,
7126 bool is_null)
7127{
7128 struct bpf_reg_state *reg;
7129 int i;
7130
7131 for (i = 0; i < MAX_BPF_REG; i++)
7132 mark_ptr_or_null_reg(state, &state->regs[i], id, is_null);
7133
7134 bpf_for_each_spilled_reg(i, state, reg) {
7135 if (!reg)
7136 continue;
7137 mark_ptr_or_null_reg(state, reg, id, is_null);
7138 }
7139}
7140
57a09bf0
TG
7141/* The logic is similar to find_good_pkt_pointers(), both could eventually
7142 * be folded together at some point.
7143 */
840b9615
JS
7144static void mark_ptr_or_null_regs(struct bpf_verifier_state *vstate, u32 regno,
7145 bool is_null)
57a09bf0 7146{
f4d7e40a 7147 struct bpf_func_state *state = vstate->frame[vstate->curframe];
c6a9efa1 7148 struct bpf_reg_state *regs = state->regs;
1b986589 7149 u32 ref_obj_id = regs[regno].ref_obj_id;
a08dd0da 7150 u32 id = regs[regno].id;
c6a9efa1 7151 int i;
57a09bf0 7152
1b986589
MKL
7153 if (ref_obj_id && ref_obj_id == id && is_null)
7154 /* regs[regno] is in the " == NULL" branch.
7155 * No one could have freed the reference state before
7156 * doing the NULL check.
7157 */
7158 WARN_ON_ONCE(release_reference_state(state, id));
fd978bf7 7159
c6a9efa1
PC
7160 for (i = 0; i <= vstate->curframe; i++)
7161 __mark_ptr_or_null_regs(vstate->frame[i], id, is_null);
57a09bf0
TG
7162}
7163
5beca081
DB
7164static bool try_match_pkt_pointers(const struct bpf_insn *insn,
7165 struct bpf_reg_state *dst_reg,
7166 struct bpf_reg_state *src_reg,
7167 struct bpf_verifier_state *this_branch,
7168 struct bpf_verifier_state *other_branch)
7169{
7170 if (BPF_SRC(insn->code) != BPF_X)
7171 return false;
7172
092ed096
JW
7173 /* Pointers are always 64-bit. */
7174 if (BPF_CLASS(insn->code) == BPF_JMP32)
7175 return false;
7176
5beca081
DB
7177 switch (BPF_OP(insn->code)) {
7178 case BPF_JGT:
7179 if ((dst_reg->type == PTR_TO_PACKET &&
7180 src_reg->type == PTR_TO_PACKET_END) ||
7181 (dst_reg->type == PTR_TO_PACKET_META &&
7182 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7183 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
7184 find_good_pkt_pointers(this_branch, dst_reg,
7185 dst_reg->type, false);
7186 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7187 src_reg->type == PTR_TO_PACKET) ||
7188 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7189 src_reg->type == PTR_TO_PACKET_META)) {
7190 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
7191 find_good_pkt_pointers(other_branch, src_reg,
7192 src_reg->type, true);
7193 } else {
7194 return false;
7195 }
7196 break;
7197 case BPF_JLT:
7198 if ((dst_reg->type == PTR_TO_PACKET &&
7199 src_reg->type == PTR_TO_PACKET_END) ||
7200 (dst_reg->type == PTR_TO_PACKET_META &&
7201 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7202 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
7203 find_good_pkt_pointers(other_branch, dst_reg,
7204 dst_reg->type, true);
7205 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7206 src_reg->type == PTR_TO_PACKET) ||
7207 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7208 src_reg->type == PTR_TO_PACKET_META)) {
7209 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
7210 find_good_pkt_pointers(this_branch, src_reg,
7211 src_reg->type, false);
7212 } else {
7213 return false;
7214 }
7215 break;
7216 case BPF_JGE:
7217 if ((dst_reg->type == PTR_TO_PACKET &&
7218 src_reg->type == PTR_TO_PACKET_END) ||
7219 (dst_reg->type == PTR_TO_PACKET_META &&
7220 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7221 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
7222 find_good_pkt_pointers(this_branch, dst_reg,
7223 dst_reg->type, true);
7224 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7225 src_reg->type == PTR_TO_PACKET) ||
7226 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7227 src_reg->type == PTR_TO_PACKET_META)) {
7228 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
7229 find_good_pkt_pointers(other_branch, src_reg,
7230 src_reg->type, false);
7231 } else {
7232 return false;
7233 }
7234 break;
7235 case BPF_JLE:
7236 if ((dst_reg->type == PTR_TO_PACKET &&
7237 src_reg->type == PTR_TO_PACKET_END) ||
7238 (dst_reg->type == PTR_TO_PACKET_META &&
7239 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7240 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
7241 find_good_pkt_pointers(other_branch, dst_reg,
7242 dst_reg->type, false);
7243 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7244 src_reg->type == PTR_TO_PACKET) ||
7245 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7246 src_reg->type == PTR_TO_PACKET_META)) {
7247 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
7248 find_good_pkt_pointers(this_branch, src_reg,
7249 src_reg->type, true);
7250 } else {
7251 return false;
7252 }
7253 break;
7254 default:
7255 return false;
7256 }
7257
7258 return true;
7259}
7260
58e2af8b 7261static int check_cond_jmp_op(struct bpf_verifier_env *env,
17a52670
AS
7262 struct bpf_insn *insn, int *insn_idx)
7263{
f4d7e40a
AS
7264 struct bpf_verifier_state *this_branch = env->cur_state;
7265 struct bpf_verifier_state *other_branch;
7266 struct bpf_reg_state *regs = this_branch->frame[this_branch->curframe]->regs;
fb8d251e 7267 struct bpf_reg_state *dst_reg, *other_branch_regs, *src_reg = NULL;
17a52670 7268 u8 opcode = BPF_OP(insn->code);
092ed096 7269 bool is_jmp32;
fb8d251e 7270 int pred = -1;
17a52670
AS
7271 int err;
7272
092ed096
JW
7273 /* Only conditional jumps are expected to reach here. */
7274 if (opcode == BPF_JA || opcode > BPF_JSLE) {
7275 verbose(env, "invalid BPF_JMP/JMP32 opcode %x\n", opcode);
17a52670
AS
7276 return -EINVAL;
7277 }
7278
7279 if (BPF_SRC(insn->code) == BPF_X) {
7280 if (insn->imm != 0) {
092ed096 7281 verbose(env, "BPF_JMP/JMP32 uses reserved fields\n");
17a52670
AS
7282 return -EINVAL;
7283 }
7284
7285 /* check src1 operand */
dc503a8a 7286 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
7287 if (err)
7288 return err;
1be7f75d
AS
7289
7290 if (is_pointer_value(env, insn->src_reg)) {
61bd5218 7291 verbose(env, "R%d pointer comparison prohibited\n",
1be7f75d
AS
7292 insn->src_reg);
7293 return -EACCES;
7294 }
fb8d251e 7295 src_reg = &regs[insn->src_reg];
17a52670
AS
7296 } else {
7297 if (insn->src_reg != BPF_REG_0) {
092ed096 7298 verbose(env, "BPF_JMP/JMP32 uses reserved fields\n");
17a52670
AS
7299 return -EINVAL;
7300 }
7301 }
7302
7303 /* check src2 operand */
dc503a8a 7304 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
7305 if (err)
7306 return err;
7307
1a0dc1ac 7308 dst_reg = &regs[insn->dst_reg];
092ed096 7309 is_jmp32 = BPF_CLASS(insn->code) == BPF_JMP32;
1a0dc1ac 7310
3f50f132
JF
7311 if (BPF_SRC(insn->code) == BPF_K) {
7312 pred = is_branch_taken(dst_reg, insn->imm, opcode, is_jmp32);
7313 } else if (src_reg->type == SCALAR_VALUE &&
7314 is_jmp32 && tnum_is_const(tnum_subreg(src_reg->var_off))) {
7315 pred = is_branch_taken(dst_reg,
7316 tnum_subreg(src_reg->var_off).value,
7317 opcode,
7318 is_jmp32);
7319 } else if (src_reg->type == SCALAR_VALUE &&
7320 !is_jmp32 && tnum_is_const(src_reg->var_off)) {
7321 pred = is_branch_taken(dst_reg,
7322 src_reg->var_off.value,
7323 opcode,
7324 is_jmp32);
7325 }
7326
b5dc0163 7327 if (pred >= 0) {
cac616db
JF
7328 /* If we get here with a dst_reg pointer type it is because
7329 * above is_branch_taken() special cased the 0 comparison.
7330 */
7331 if (!__is_pointer_value(false, dst_reg))
7332 err = mark_chain_precision(env, insn->dst_reg);
b5dc0163
AS
7333 if (BPF_SRC(insn->code) == BPF_X && !err)
7334 err = mark_chain_precision(env, insn->src_reg);
7335 if (err)
7336 return err;
7337 }
fb8d251e
AS
7338 if (pred == 1) {
7339 /* only follow the goto, ignore fall-through */
7340 *insn_idx += insn->off;
7341 return 0;
7342 } else if (pred == 0) {
7343 /* only follow fall-through branch, since
7344 * that's where the program will go
7345 */
7346 return 0;
17a52670
AS
7347 }
7348
979d63d5
DB
7349 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx,
7350 false);
17a52670
AS
7351 if (!other_branch)
7352 return -EFAULT;
f4d7e40a 7353 other_branch_regs = other_branch->frame[other_branch->curframe]->regs;
17a52670 7354
48461135
JB
7355 /* detect if we are comparing against a constant value so we can adjust
7356 * our min/max values for our dst register.
f1174f77
EC
7357 * this is only legit if both are scalars (or pointers to the same
7358 * object, I suppose, but we don't support that right now), because
7359 * otherwise the different base pointers mean the offsets aren't
7360 * comparable.
48461135
JB
7361 */
7362 if (BPF_SRC(insn->code) == BPF_X) {
092ed096 7363 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
092ed096 7364
f1174f77 7365 if (dst_reg->type == SCALAR_VALUE &&
092ed096
JW
7366 src_reg->type == SCALAR_VALUE) {
7367 if (tnum_is_const(src_reg->var_off) ||
3f50f132
JF
7368 (is_jmp32 &&
7369 tnum_is_const(tnum_subreg(src_reg->var_off))))
f4d7e40a 7370 reg_set_min_max(&other_branch_regs[insn->dst_reg],
092ed096 7371 dst_reg,
3f50f132
JF
7372 src_reg->var_off.value,
7373 tnum_subreg(src_reg->var_off).value,
092ed096
JW
7374 opcode, is_jmp32);
7375 else if (tnum_is_const(dst_reg->var_off) ||
3f50f132
JF
7376 (is_jmp32 &&
7377 tnum_is_const(tnum_subreg(dst_reg->var_off))))
f4d7e40a 7378 reg_set_min_max_inv(&other_branch_regs[insn->src_reg],
092ed096 7379 src_reg,
3f50f132
JF
7380 dst_reg->var_off.value,
7381 tnum_subreg(dst_reg->var_off).value,
092ed096
JW
7382 opcode, is_jmp32);
7383 else if (!is_jmp32 &&
7384 (opcode == BPF_JEQ || opcode == BPF_JNE))
f1174f77 7385 /* Comparing for equality, we can combine knowledge */
f4d7e40a
AS
7386 reg_combine_min_max(&other_branch_regs[insn->src_reg],
7387 &other_branch_regs[insn->dst_reg],
092ed096 7388 src_reg, dst_reg, opcode);
f1174f77
EC
7389 }
7390 } else if (dst_reg->type == SCALAR_VALUE) {
f4d7e40a 7391 reg_set_min_max(&other_branch_regs[insn->dst_reg],
3f50f132
JF
7392 dst_reg, insn->imm, (u32)insn->imm,
7393 opcode, is_jmp32);
48461135
JB
7394 }
7395
092ed096
JW
7396 /* detect if R == 0 where R is returned from bpf_map_lookup_elem().
7397 * NOTE: these optimizations below are related with pointer comparison
7398 * which will never be JMP32.
7399 */
7400 if (!is_jmp32 && BPF_SRC(insn->code) == BPF_K &&
1a0dc1ac 7401 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
840b9615
JS
7402 reg_type_may_be_null(dst_reg->type)) {
7403 /* Mark all identical registers in each branch as either
57a09bf0
TG
7404 * safe or unknown depending R == 0 or R != 0 conditional.
7405 */
840b9615
JS
7406 mark_ptr_or_null_regs(this_branch, insn->dst_reg,
7407 opcode == BPF_JNE);
7408 mark_ptr_or_null_regs(other_branch, insn->dst_reg,
7409 opcode == BPF_JEQ);
5beca081
DB
7410 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
7411 this_branch, other_branch) &&
7412 is_pointer_value(env, insn->dst_reg)) {
61bd5218
JK
7413 verbose(env, "R%d pointer comparison prohibited\n",
7414 insn->dst_reg);
1be7f75d 7415 return -EACCES;
17a52670 7416 }
06ee7115 7417 if (env->log.level & BPF_LOG_LEVEL)
f4d7e40a 7418 print_verifier_state(env, this_branch->frame[this_branch->curframe]);
17a52670
AS
7419 return 0;
7420}
7421
17a52670 7422/* verify BPF_LD_IMM64 instruction */
58e2af8b 7423static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 7424{
d8eca5bb 7425 struct bpf_insn_aux_data *aux = cur_aux(env);
638f5b90 7426 struct bpf_reg_state *regs = cur_regs(env);
d8eca5bb 7427 struct bpf_map *map;
17a52670
AS
7428 int err;
7429
7430 if (BPF_SIZE(insn->code) != BPF_DW) {
61bd5218 7431 verbose(env, "invalid BPF_LD_IMM insn\n");
17a52670
AS
7432 return -EINVAL;
7433 }
7434 if (insn->off != 0) {
61bd5218 7435 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
17a52670
AS
7436 return -EINVAL;
7437 }
7438
dc503a8a 7439 err = check_reg_arg(env, insn->dst_reg, DST_OP);
17a52670
AS
7440 if (err)
7441 return err;
7442
6b173873 7443 if (insn->src_reg == 0) {
6b173873
JK
7444 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
7445
f1174f77 7446 regs[insn->dst_reg].type = SCALAR_VALUE;
b03c9f9f 7447 __mark_reg_known(&regs[insn->dst_reg], imm);
17a52670 7448 return 0;
6b173873 7449 }
17a52670 7450
d8eca5bb
DB
7451 map = env->used_maps[aux->map_index];
7452 mark_reg_known_zero(env, regs, insn->dst_reg);
7453 regs[insn->dst_reg].map_ptr = map;
7454
7455 if (insn->src_reg == BPF_PSEUDO_MAP_VALUE) {
7456 regs[insn->dst_reg].type = PTR_TO_MAP_VALUE;
7457 regs[insn->dst_reg].off = aux->map_off;
7458 if (map_value_has_spin_lock(map))
7459 regs[insn->dst_reg].id = ++env->id_gen;
7460 } else if (insn->src_reg == BPF_PSEUDO_MAP_FD) {
7461 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
7462 } else {
7463 verbose(env, "bpf verifier is misconfigured\n");
7464 return -EINVAL;
7465 }
17a52670 7466
17a52670
AS
7467 return 0;
7468}
7469
96be4325
DB
7470static bool may_access_skb(enum bpf_prog_type type)
7471{
7472 switch (type) {
7473 case BPF_PROG_TYPE_SOCKET_FILTER:
7474 case BPF_PROG_TYPE_SCHED_CLS:
94caee8c 7475 case BPF_PROG_TYPE_SCHED_ACT:
96be4325
DB
7476 return true;
7477 default:
7478 return false;
7479 }
7480}
7481
ddd872bc
AS
7482/* verify safety of LD_ABS|LD_IND instructions:
7483 * - they can only appear in the programs where ctx == skb
7484 * - since they are wrappers of function calls, they scratch R1-R5 registers,
7485 * preserve R6-R9, and store return value into R0
7486 *
7487 * Implicit input:
7488 * ctx == skb == R6 == CTX
7489 *
7490 * Explicit input:
7491 * SRC == any register
7492 * IMM == 32-bit immediate
7493 *
7494 * Output:
7495 * R0 - 8/16/32-bit skb data converted to cpu endianness
7496 */
58e2af8b 7497static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
ddd872bc 7498{
638f5b90 7499 struct bpf_reg_state *regs = cur_regs(env);
6d4f151a 7500 static const int ctx_reg = BPF_REG_6;
ddd872bc 7501 u8 mode = BPF_MODE(insn->code);
ddd872bc
AS
7502 int i, err;
7503
7e40781c 7504 if (!may_access_skb(resolve_prog_type(env->prog))) {
61bd5218 7505 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
ddd872bc
AS
7506 return -EINVAL;
7507 }
7508
e0cea7ce
DB
7509 if (!env->ops->gen_ld_abs) {
7510 verbose(env, "bpf verifier is misconfigured\n");
7511 return -EINVAL;
7512 }
7513
ddd872bc 7514 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
d82bccc6 7515 BPF_SIZE(insn->code) == BPF_DW ||
ddd872bc 7516 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
61bd5218 7517 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
ddd872bc
AS
7518 return -EINVAL;
7519 }
7520
7521 /* check whether implicit source operand (register R6) is readable */
6d4f151a 7522 err = check_reg_arg(env, ctx_reg, SRC_OP);
ddd872bc
AS
7523 if (err)
7524 return err;
7525
fd978bf7
JS
7526 /* Disallow usage of BPF_LD_[ABS|IND] with reference tracking, as
7527 * gen_ld_abs() may terminate the program at runtime, leading to
7528 * reference leak.
7529 */
7530 err = check_reference_leak(env);
7531 if (err) {
7532 verbose(env, "BPF_LD_[ABS|IND] cannot be mixed with socket references\n");
7533 return err;
7534 }
7535
d83525ca
AS
7536 if (env->cur_state->active_spin_lock) {
7537 verbose(env, "BPF_LD_[ABS|IND] cannot be used inside bpf_spin_lock-ed region\n");
7538 return -EINVAL;
7539 }
7540
6d4f151a 7541 if (regs[ctx_reg].type != PTR_TO_CTX) {
61bd5218
JK
7542 verbose(env,
7543 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
ddd872bc
AS
7544 return -EINVAL;
7545 }
7546
7547 if (mode == BPF_IND) {
7548 /* check explicit source operand */
dc503a8a 7549 err = check_reg_arg(env, insn->src_reg, SRC_OP);
ddd872bc
AS
7550 if (err)
7551 return err;
7552 }
7553
6d4f151a
DB
7554 err = check_ctx_reg(env, &regs[ctx_reg], ctx_reg);
7555 if (err < 0)
7556 return err;
7557
ddd872bc 7558 /* reset caller saved regs to unreadable */
dc503a8a 7559 for (i = 0; i < CALLER_SAVED_REGS; i++) {
61bd5218 7560 mark_reg_not_init(env, regs, caller_saved[i]);
dc503a8a
EC
7561 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
7562 }
ddd872bc
AS
7563
7564 /* mark destination R0 register as readable, since it contains
dc503a8a
EC
7565 * the value fetched from the packet.
7566 * Already marked as written above.
ddd872bc 7567 */
61bd5218 7568 mark_reg_unknown(env, regs, BPF_REG_0);
5327ed3d
JW
7569 /* ld_abs load up to 32-bit skb data. */
7570 regs[BPF_REG_0].subreg_def = env->insn_idx + 1;
ddd872bc
AS
7571 return 0;
7572}
7573
390ee7e2
AS
7574static int check_return_code(struct bpf_verifier_env *env)
7575{
5cf1e914 7576 struct tnum enforce_attach_type_range = tnum_unknown;
27ae7997 7577 const struct bpf_prog *prog = env->prog;
390ee7e2
AS
7578 struct bpf_reg_state *reg;
7579 struct tnum range = tnum_range(0, 1);
7e40781c 7580 enum bpf_prog_type prog_type = resolve_prog_type(env->prog);
27ae7997
MKL
7581 int err;
7582
9e4e01df 7583 /* LSM and struct_ops func-ptr's return type could be "void" */
7e40781c
UP
7584 if ((prog_type == BPF_PROG_TYPE_STRUCT_OPS ||
7585 prog_type == BPF_PROG_TYPE_LSM) &&
27ae7997
MKL
7586 !prog->aux->attach_func_proto->type)
7587 return 0;
7588
7589 /* eBPF calling convetion is such that R0 is used
7590 * to return the value from eBPF program.
7591 * Make sure that it's readable at this time
7592 * of bpf_exit, which means that program wrote
7593 * something into it earlier
7594 */
7595 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
7596 if (err)
7597 return err;
7598
7599 if (is_pointer_value(env, BPF_REG_0)) {
7600 verbose(env, "R0 leaks addr as return value\n");
7601 return -EACCES;
7602 }
390ee7e2 7603
7e40781c 7604 switch (prog_type) {
983695fa
DB
7605 case BPF_PROG_TYPE_CGROUP_SOCK_ADDR:
7606 if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG ||
1b66d253
DB
7607 env->prog->expected_attach_type == BPF_CGROUP_UDP6_RECVMSG ||
7608 env->prog->expected_attach_type == BPF_CGROUP_INET4_GETPEERNAME ||
7609 env->prog->expected_attach_type == BPF_CGROUP_INET6_GETPEERNAME ||
7610 env->prog->expected_attach_type == BPF_CGROUP_INET4_GETSOCKNAME ||
7611 env->prog->expected_attach_type == BPF_CGROUP_INET6_GETSOCKNAME)
983695fa 7612 range = tnum_range(1, 1);
ed4ed404 7613 break;
390ee7e2 7614 case BPF_PROG_TYPE_CGROUP_SKB:
5cf1e914 7615 if (env->prog->expected_attach_type == BPF_CGROUP_INET_EGRESS) {
7616 range = tnum_range(0, 3);
7617 enforce_attach_type_range = tnum_range(2, 3);
7618 }
ed4ed404 7619 break;
390ee7e2
AS
7620 case BPF_PROG_TYPE_CGROUP_SOCK:
7621 case BPF_PROG_TYPE_SOCK_OPS:
ebc614f6 7622 case BPF_PROG_TYPE_CGROUP_DEVICE:
7b146ceb 7623 case BPF_PROG_TYPE_CGROUP_SYSCTL:
0d01da6a 7624 case BPF_PROG_TYPE_CGROUP_SOCKOPT:
390ee7e2 7625 break;
15ab09bd
AS
7626 case BPF_PROG_TYPE_RAW_TRACEPOINT:
7627 if (!env->prog->aux->attach_btf_id)
7628 return 0;
7629 range = tnum_const(0);
7630 break;
15d83c4d 7631 case BPF_PROG_TYPE_TRACING:
e92888c7
YS
7632 switch (env->prog->expected_attach_type) {
7633 case BPF_TRACE_FENTRY:
7634 case BPF_TRACE_FEXIT:
7635 range = tnum_const(0);
7636 break;
7637 case BPF_TRACE_RAW_TP:
7638 case BPF_MODIFY_RETURN:
15d83c4d 7639 return 0;
2ec0616e
DB
7640 case BPF_TRACE_ITER:
7641 break;
e92888c7
YS
7642 default:
7643 return -ENOTSUPP;
7644 }
15d83c4d 7645 break;
e9ddbb77
JS
7646 case BPF_PROG_TYPE_SK_LOOKUP:
7647 range = tnum_range(SK_DROP, SK_PASS);
7648 break;
e92888c7
YS
7649 case BPF_PROG_TYPE_EXT:
7650 /* freplace program can return anything as its return value
7651 * depends on the to-be-replaced kernel func or bpf program.
7652 */
390ee7e2
AS
7653 default:
7654 return 0;
7655 }
7656
638f5b90 7657 reg = cur_regs(env) + BPF_REG_0;
390ee7e2 7658 if (reg->type != SCALAR_VALUE) {
61bd5218 7659 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
390ee7e2
AS
7660 reg_type_str[reg->type]);
7661 return -EINVAL;
7662 }
7663
7664 if (!tnum_in(range, reg->var_off)) {
5cf1e914 7665 char tn_buf[48];
7666
61bd5218 7667 verbose(env, "At program exit the register R0 ");
390ee7e2 7668 if (!tnum_is_unknown(reg->var_off)) {
390ee7e2 7669 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 7670 verbose(env, "has value %s", tn_buf);
390ee7e2 7671 } else {
61bd5218 7672 verbose(env, "has unknown scalar value");
390ee7e2 7673 }
5cf1e914 7674 tnum_strn(tn_buf, sizeof(tn_buf), range);
983695fa 7675 verbose(env, " should have been in %s\n", tn_buf);
390ee7e2
AS
7676 return -EINVAL;
7677 }
5cf1e914 7678
7679 if (!tnum_is_unknown(enforce_attach_type_range) &&
7680 tnum_in(enforce_attach_type_range, reg->var_off))
7681 env->prog->enforce_expected_attach_type = 1;
390ee7e2
AS
7682 return 0;
7683}
7684
475fb78f
AS
7685/* non-recursive DFS pseudo code
7686 * 1 procedure DFS-iterative(G,v):
7687 * 2 label v as discovered
7688 * 3 let S be a stack
7689 * 4 S.push(v)
7690 * 5 while S is not empty
7691 * 6 t <- S.pop()
7692 * 7 if t is what we're looking for:
7693 * 8 return t
7694 * 9 for all edges e in G.adjacentEdges(t) do
7695 * 10 if edge e is already labelled
7696 * 11 continue with the next edge
7697 * 12 w <- G.adjacentVertex(t,e)
7698 * 13 if vertex w is not discovered and not explored
7699 * 14 label e as tree-edge
7700 * 15 label w as discovered
7701 * 16 S.push(w)
7702 * 17 continue at 5
7703 * 18 else if vertex w is discovered
7704 * 19 label e as back-edge
7705 * 20 else
7706 * 21 // vertex w is explored
7707 * 22 label e as forward- or cross-edge
7708 * 23 label t as explored
7709 * 24 S.pop()
7710 *
7711 * convention:
7712 * 0x10 - discovered
7713 * 0x11 - discovered and fall-through edge labelled
7714 * 0x12 - discovered and fall-through and branch edges labelled
7715 * 0x20 - explored
7716 */
7717
7718enum {
7719 DISCOVERED = 0x10,
7720 EXPLORED = 0x20,
7721 FALLTHROUGH = 1,
7722 BRANCH = 2,
7723};
7724
dc2a4ebc
AS
7725static u32 state_htab_size(struct bpf_verifier_env *env)
7726{
7727 return env->prog->len;
7728}
7729
5d839021
AS
7730static struct bpf_verifier_state_list **explored_state(
7731 struct bpf_verifier_env *env,
7732 int idx)
7733{
dc2a4ebc
AS
7734 struct bpf_verifier_state *cur = env->cur_state;
7735 struct bpf_func_state *state = cur->frame[cur->curframe];
7736
7737 return &env->explored_states[(idx ^ state->callsite) % state_htab_size(env)];
5d839021
AS
7738}
7739
7740static void init_explored_state(struct bpf_verifier_env *env, int idx)
7741{
a8f500af 7742 env->insn_aux_data[idx].prune_point = true;
5d839021 7743}
f1bca824 7744
475fb78f
AS
7745/* t, w, e - match pseudo-code above:
7746 * t - index of current instruction
7747 * w - next instruction
7748 * e - edge
7749 */
2589726d
AS
7750static int push_insn(int t, int w, int e, struct bpf_verifier_env *env,
7751 bool loop_ok)
475fb78f 7752{
7df737e9
AS
7753 int *insn_stack = env->cfg.insn_stack;
7754 int *insn_state = env->cfg.insn_state;
7755
475fb78f
AS
7756 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
7757 return 0;
7758
7759 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
7760 return 0;
7761
7762 if (w < 0 || w >= env->prog->len) {
d9762e84 7763 verbose_linfo(env, t, "%d: ", t);
61bd5218 7764 verbose(env, "jump out of range from insn %d to %d\n", t, w);
475fb78f
AS
7765 return -EINVAL;
7766 }
7767
f1bca824
AS
7768 if (e == BRANCH)
7769 /* mark branch target for state pruning */
5d839021 7770 init_explored_state(env, w);
f1bca824 7771
475fb78f
AS
7772 if (insn_state[w] == 0) {
7773 /* tree-edge */
7774 insn_state[t] = DISCOVERED | e;
7775 insn_state[w] = DISCOVERED;
7df737e9 7776 if (env->cfg.cur_stack >= env->prog->len)
475fb78f 7777 return -E2BIG;
7df737e9 7778 insn_stack[env->cfg.cur_stack++] = w;
475fb78f
AS
7779 return 1;
7780 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
2c78ee89 7781 if (loop_ok && env->bpf_capable)
2589726d 7782 return 0;
d9762e84
MKL
7783 verbose_linfo(env, t, "%d: ", t);
7784 verbose_linfo(env, w, "%d: ", w);
61bd5218 7785 verbose(env, "back-edge from insn %d to %d\n", t, w);
475fb78f
AS
7786 return -EINVAL;
7787 } else if (insn_state[w] == EXPLORED) {
7788 /* forward- or cross-edge */
7789 insn_state[t] = DISCOVERED | e;
7790 } else {
61bd5218 7791 verbose(env, "insn state internal bug\n");
475fb78f
AS
7792 return -EFAULT;
7793 }
7794 return 0;
7795}
7796
7797/* non-recursive depth-first-search to detect loops in BPF program
7798 * loop == back-edge in directed graph
7799 */
58e2af8b 7800static int check_cfg(struct bpf_verifier_env *env)
475fb78f
AS
7801{
7802 struct bpf_insn *insns = env->prog->insnsi;
7803 int insn_cnt = env->prog->len;
7df737e9 7804 int *insn_stack, *insn_state;
475fb78f
AS
7805 int ret = 0;
7806 int i, t;
7807
7df737e9 7808 insn_state = env->cfg.insn_state = kvcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
475fb78f
AS
7809 if (!insn_state)
7810 return -ENOMEM;
7811
7df737e9 7812 insn_stack = env->cfg.insn_stack = kvcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
475fb78f 7813 if (!insn_stack) {
71dde681 7814 kvfree(insn_state);
475fb78f
AS
7815 return -ENOMEM;
7816 }
7817
7818 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
7819 insn_stack[0] = 0; /* 0 is the first instruction */
7df737e9 7820 env->cfg.cur_stack = 1;
475fb78f
AS
7821
7822peek_stack:
7df737e9 7823 if (env->cfg.cur_stack == 0)
475fb78f 7824 goto check_state;
7df737e9 7825 t = insn_stack[env->cfg.cur_stack - 1];
475fb78f 7826
092ed096
JW
7827 if (BPF_CLASS(insns[t].code) == BPF_JMP ||
7828 BPF_CLASS(insns[t].code) == BPF_JMP32) {
475fb78f
AS
7829 u8 opcode = BPF_OP(insns[t].code);
7830
7831 if (opcode == BPF_EXIT) {
7832 goto mark_explored;
7833 } else if (opcode == BPF_CALL) {
2589726d 7834 ret = push_insn(t, t + 1, FALLTHROUGH, env, false);
475fb78f
AS
7835 if (ret == 1)
7836 goto peek_stack;
7837 else if (ret < 0)
7838 goto err_free;
07016151 7839 if (t + 1 < insn_cnt)
5d839021 7840 init_explored_state(env, t + 1);
cc8b0b92 7841 if (insns[t].src_reg == BPF_PSEUDO_CALL) {
5d839021 7842 init_explored_state(env, t);
2589726d
AS
7843 ret = push_insn(t, t + insns[t].imm + 1, BRANCH,
7844 env, false);
cc8b0b92
AS
7845 if (ret == 1)
7846 goto peek_stack;
7847 else if (ret < 0)
7848 goto err_free;
7849 }
475fb78f
AS
7850 } else if (opcode == BPF_JA) {
7851 if (BPF_SRC(insns[t].code) != BPF_K) {
7852 ret = -EINVAL;
7853 goto err_free;
7854 }
7855 /* unconditional jump with single edge */
7856 ret = push_insn(t, t + insns[t].off + 1,
2589726d 7857 FALLTHROUGH, env, true);
475fb78f
AS
7858 if (ret == 1)
7859 goto peek_stack;
7860 else if (ret < 0)
7861 goto err_free;
b5dc0163
AS
7862 /* unconditional jmp is not a good pruning point,
7863 * but it's marked, since backtracking needs
7864 * to record jmp history in is_state_visited().
7865 */
7866 init_explored_state(env, t + insns[t].off + 1);
f1bca824
AS
7867 /* tell verifier to check for equivalent states
7868 * after every call and jump
7869 */
c3de6317 7870 if (t + 1 < insn_cnt)
5d839021 7871 init_explored_state(env, t + 1);
475fb78f
AS
7872 } else {
7873 /* conditional jump with two edges */
5d839021 7874 init_explored_state(env, t);
2589726d 7875 ret = push_insn(t, t + 1, FALLTHROUGH, env, true);
475fb78f
AS
7876 if (ret == 1)
7877 goto peek_stack;
7878 else if (ret < 0)
7879 goto err_free;
7880
2589726d 7881 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env, true);
475fb78f
AS
7882 if (ret == 1)
7883 goto peek_stack;
7884 else if (ret < 0)
7885 goto err_free;
7886 }
7887 } else {
7888 /* all other non-branch instructions with single
7889 * fall-through edge
7890 */
2589726d 7891 ret = push_insn(t, t + 1, FALLTHROUGH, env, false);
475fb78f
AS
7892 if (ret == 1)
7893 goto peek_stack;
7894 else if (ret < 0)
7895 goto err_free;
7896 }
7897
7898mark_explored:
7899 insn_state[t] = EXPLORED;
7df737e9 7900 if (env->cfg.cur_stack-- <= 0) {
61bd5218 7901 verbose(env, "pop stack internal bug\n");
475fb78f
AS
7902 ret = -EFAULT;
7903 goto err_free;
7904 }
7905 goto peek_stack;
7906
7907check_state:
7908 for (i = 0; i < insn_cnt; i++) {
7909 if (insn_state[i] != EXPLORED) {
61bd5218 7910 verbose(env, "unreachable insn %d\n", i);
475fb78f
AS
7911 ret = -EINVAL;
7912 goto err_free;
7913 }
7914 }
7915 ret = 0; /* cfg looks good */
7916
7917err_free:
71dde681
AS
7918 kvfree(insn_state);
7919 kvfree(insn_stack);
7df737e9 7920 env->cfg.insn_state = env->cfg.insn_stack = NULL;
475fb78f
AS
7921 return ret;
7922}
7923
09b28d76
AS
7924static int check_abnormal_return(struct bpf_verifier_env *env)
7925{
7926 int i;
7927
7928 for (i = 1; i < env->subprog_cnt; i++) {
7929 if (env->subprog_info[i].has_ld_abs) {
7930 verbose(env, "LD_ABS is not allowed in subprogs without BTF\n");
7931 return -EINVAL;
7932 }
7933 if (env->subprog_info[i].has_tail_call) {
7934 verbose(env, "tail_call is not allowed in subprogs without BTF\n");
7935 return -EINVAL;
7936 }
7937 }
7938 return 0;
7939}
7940
838e9690
YS
7941/* The minimum supported BTF func info size */
7942#define MIN_BPF_FUNCINFO_SIZE 8
7943#define MAX_FUNCINFO_REC_SIZE 252
7944
c454a46b
MKL
7945static int check_btf_func(struct bpf_verifier_env *env,
7946 const union bpf_attr *attr,
7947 union bpf_attr __user *uattr)
838e9690 7948{
09b28d76 7949 const struct btf_type *type, *func_proto, *ret_type;
d0b2818e 7950 u32 i, nfuncs, urec_size, min_size;
838e9690 7951 u32 krec_size = sizeof(struct bpf_func_info);
c454a46b 7952 struct bpf_func_info *krecord;
8c1b6e69 7953 struct bpf_func_info_aux *info_aux = NULL;
c454a46b
MKL
7954 struct bpf_prog *prog;
7955 const struct btf *btf;
838e9690 7956 void __user *urecord;
d0b2818e 7957 u32 prev_offset = 0;
09b28d76 7958 bool scalar_return;
e7ed83d6 7959 int ret = -ENOMEM;
838e9690
YS
7960
7961 nfuncs = attr->func_info_cnt;
09b28d76
AS
7962 if (!nfuncs) {
7963 if (check_abnormal_return(env))
7964 return -EINVAL;
838e9690 7965 return 0;
09b28d76 7966 }
838e9690
YS
7967
7968 if (nfuncs != env->subprog_cnt) {
7969 verbose(env, "number of funcs in func_info doesn't match number of subprogs\n");
7970 return -EINVAL;
7971 }
7972
7973 urec_size = attr->func_info_rec_size;
7974 if (urec_size < MIN_BPF_FUNCINFO_SIZE ||
7975 urec_size > MAX_FUNCINFO_REC_SIZE ||
7976 urec_size % sizeof(u32)) {
7977 verbose(env, "invalid func info rec size %u\n", urec_size);
7978 return -EINVAL;
7979 }
7980
c454a46b
MKL
7981 prog = env->prog;
7982 btf = prog->aux->btf;
838e9690
YS
7983
7984 urecord = u64_to_user_ptr(attr->func_info);
7985 min_size = min_t(u32, krec_size, urec_size);
7986
ba64e7d8 7987 krecord = kvcalloc(nfuncs, krec_size, GFP_KERNEL | __GFP_NOWARN);
c454a46b
MKL
7988 if (!krecord)
7989 return -ENOMEM;
8c1b6e69
AS
7990 info_aux = kcalloc(nfuncs, sizeof(*info_aux), GFP_KERNEL | __GFP_NOWARN);
7991 if (!info_aux)
7992 goto err_free;
ba64e7d8 7993
838e9690
YS
7994 for (i = 0; i < nfuncs; i++) {
7995 ret = bpf_check_uarg_tail_zero(urecord, krec_size, urec_size);
7996 if (ret) {
7997 if (ret == -E2BIG) {
7998 verbose(env, "nonzero tailing record in func info");
7999 /* set the size kernel expects so loader can zero
8000 * out the rest of the record.
8001 */
8002 if (put_user(min_size, &uattr->func_info_rec_size))
8003 ret = -EFAULT;
8004 }
c454a46b 8005 goto err_free;
838e9690
YS
8006 }
8007
ba64e7d8 8008 if (copy_from_user(&krecord[i], urecord, min_size)) {
838e9690 8009 ret = -EFAULT;
c454a46b 8010 goto err_free;
838e9690
YS
8011 }
8012
d30d42e0 8013 /* check insn_off */
09b28d76 8014 ret = -EINVAL;
838e9690 8015 if (i == 0) {
d30d42e0 8016 if (krecord[i].insn_off) {
838e9690 8017 verbose(env,
d30d42e0
MKL
8018 "nonzero insn_off %u for the first func info record",
8019 krecord[i].insn_off);
c454a46b 8020 goto err_free;
838e9690 8021 }
d30d42e0 8022 } else if (krecord[i].insn_off <= prev_offset) {
838e9690
YS
8023 verbose(env,
8024 "same or smaller insn offset (%u) than previous func info record (%u)",
d30d42e0 8025 krecord[i].insn_off, prev_offset);
c454a46b 8026 goto err_free;
838e9690
YS
8027 }
8028
d30d42e0 8029 if (env->subprog_info[i].start != krecord[i].insn_off) {
838e9690 8030 verbose(env, "func_info BTF section doesn't match subprog layout in BPF program\n");
c454a46b 8031 goto err_free;
838e9690
YS
8032 }
8033
8034 /* check type_id */
ba64e7d8 8035 type = btf_type_by_id(btf, krecord[i].type_id);
51c39bb1 8036 if (!type || !btf_type_is_func(type)) {
838e9690 8037 verbose(env, "invalid type id %d in func info",
ba64e7d8 8038 krecord[i].type_id);
c454a46b 8039 goto err_free;
838e9690 8040 }
51c39bb1 8041 info_aux[i].linkage = BTF_INFO_VLEN(type->info);
09b28d76
AS
8042
8043 func_proto = btf_type_by_id(btf, type->type);
8044 if (unlikely(!func_proto || !btf_type_is_func_proto(func_proto)))
8045 /* btf_func_check() already verified it during BTF load */
8046 goto err_free;
8047 ret_type = btf_type_skip_modifiers(btf, func_proto->type, NULL);
8048 scalar_return =
8049 btf_type_is_small_int(ret_type) || btf_type_is_enum(ret_type);
8050 if (i && !scalar_return && env->subprog_info[i].has_ld_abs) {
8051 verbose(env, "LD_ABS is only allowed in functions that return 'int'.\n");
8052 goto err_free;
8053 }
8054 if (i && !scalar_return && env->subprog_info[i].has_tail_call) {
8055 verbose(env, "tail_call is only allowed in functions that return 'int'.\n");
8056 goto err_free;
8057 }
8058
d30d42e0 8059 prev_offset = krecord[i].insn_off;
838e9690
YS
8060 urecord += urec_size;
8061 }
8062
ba64e7d8
YS
8063 prog->aux->func_info = krecord;
8064 prog->aux->func_info_cnt = nfuncs;
8c1b6e69 8065 prog->aux->func_info_aux = info_aux;
838e9690
YS
8066 return 0;
8067
c454a46b 8068err_free:
ba64e7d8 8069 kvfree(krecord);
8c1b6e69 8070 kfree(info_aux);
838e9690
YS
8071 return ret;
8072}
8073
ba64e7d8
YS
8074static void adjust_btf_func(struct bpf_verifier_env *env)
8075{
8c1b6e69 8076 struct bpf_prog_aux *aux = env->prog->aux;
ba64e7d8
YS
8077 int i;
8078
8c1b6e69 8079 if (!aux->func_info)
ba64e7d8
YS
8080 return;
8081
8082 for (i = 0; i < env->subprog_cnt; i++)
8c1b6e69 8083 aux->func_info[i].insn_off = env->subprog_info[i].start;
ba64e7d8
YS
8084}
8085
c454a46b
MKL
8086#define MIN_BPF_LINEINFO_SIZE (offsetof(struct bpf_line_info, line_col) + \
8087 sizeof(((struct bpf_line_info *)(0))->line_col))
8088#define MAX_LINEINFO_REC_SIZE MAX_FUNCINFO_REC_SIZE
8089
8090static int check_btf_line(struct bpf_verifier_env *env,
8091 const union bpf_attr *attr,
8092 union bpf_attr __user *uattr)
8093{
8094 u32 i, s, nr_linfo, ncopy, expected_size, rec_size, prev_offset = 0;
8095 struct bpf_subprog_info *sub;
8096 struct bpf_line_info *linfo;
8097 struct bpf_prog *prog;
8098 const struct btf *btf;
8099 void __user *ulinfo;
8100 int err;
8101
8102 nr_linfo = attr->line_info_cnt;
8103 if (!nr_linfo)
8104 return 0;
8105
8106 rec_size = attr->line_info_rec_size;
8107 if (rec_size < MIN_BPF_LINEINFO_SIZE ||
8108 rec_size > MAX_LINEINFO_REC_SIZE ||
8109 rec_size & (sizeof(u32) - 1))
8110 return -EINVAL;
8111
8112 /* Need to zero it in case the userspace may
8113 * pass in a smaller bpf_line_info object.
8114 */
8115 linfo = kvcalloc(nr_linfo, sizeof(struct bpf_line_info),
8116 GFP_KERNEL | __GFP_NOWARN);
8117 if (!linfo)
8118 return -ENOMEM;
8119
8120 prog = env->prog;
8121 btf = prog->aux->btf;
8122
8123 s = 0;
8124 sub = env->subprog_info;
8125 ulinfo = u64_to_user_ptr(attr->line_info);
8126 expected_size = sizeof(struct bpf_line_info);
8127 ncopy = min_t(u32, expected_size, rec_size);
8128 for (i = 0; i < nr_linfo; i++) {
8129 err = bpf_check_uarg_tail_zero(ulinfo, expected_size, rec_size);
8130 if (err) {
8131 if (err == -E2BIG) {
8132 verbose(env, "nonzero tailing record in line_info");
8133 if (put_user(expected_size,
8134 &uattr->line_info_rec_size))
8135 err = -EFAULT;
8136 }
8137 goto err_free;
8138 }
8139
8140 if (copy_from_user(&linfo[i], ulinfo, ncopy)) {
8141 err = -EFAULT;
8142 goto err_free;
8143 }
8144
8145 /*
8146 * Check insn_off to ensure
8147 * 1) strictly increasing AND
8148 * 2) bounded by prog->len
8149 *
8150 * The linfo[0].insn_off == 0 check logically falls into
8151 * the later "missing bpf_line_info for func..." case
8152 * because the first linfo[0].insn_off must be the
8153 * first sub also and the first sub must have
8154 * subprog_info[0].start == 0.
8155 */
8156 if ((i && linfo[i].insn_off <= prev_offset) ||
8157 linfo[i].insn_off >= prog->len) {
8158 verbose(env, "Invalid line_info[%u].insn_off:%u (prev_offset:%u prog->len:%u)\n",
8159 i, linfo[i].insn_off, prev_offset,
8160 prog->len);
8161 err = -EINVAL;
8162 goto err_free;
8163 }
8164
fdbaa0be
MKL
8165 if (!prog->insnsi[linfo[i].insn_off].code) {
8166 verbose(env,
8167 "Invalid insn code at line_info[%u].insn_off\n",
8168 i);
8169 err = -EINVAL;
8170 goto err_free;
8171 }
8172
23127b33
MKL
8173 if (!btf_name_by_offset(btf, linfo[i].line_off) ||
8174 !btf_name_by_offset(btf, linfo[i].file_name_off)) {
c454a46b
MKL
8175 verbose(env, "Invalid line_info[%u].line_off or .file_name_off\n", i);
8176 err = -EINVAL;
8177 goto err_free;
8178 }
8179
8180 if (s != env->subprog_cnt) {
8181 if (linfo[i].insn_off == sub[s].start) {
8182 sub[s].linfo_idx = i;
8183 s++;
8184 } else if (sub[s].start < linfo[i].insn_off) {
8185 verbose(env, "missing bpf_line_info for func#%u\n", s);
8186 err = -EINVAL;
8187 goto err_free;
8188 }
8189 }
8190
8191 prev_offset = linfo[i].insn_off;
8192 ulinfo += rec_size;
8193 }
8194
8195 if (s != env->subprog_cnt) {
8196 verbose(env, "missing bpf_line_info for %u funcs starting from func#%u\n",
8197 env->subprog_cnt - s, s);
8198 err = -EINVAL;
8199 goto err_free;
8200 }
8201
8202 prog->aux->linfo = linfo;
8203 prog->aux->nr_linfo = nr_linfo;
8204
8205 return 0;
8206
8207err_free:
8208 kvfree(linfo);
8209 return err;
8210}
8211
8212static int check_btf_info(struct bpf_verifier_env *env,
8213 const union bpf_attr *attr,
8214 union bpf_attr __user *uattr)
8215{
8216 struct btf *btf;
8217 int err;
8218
09b28d76
AS
8219 if (!attr->func_info_cnt && !attr->line_info_cnt) {
8220 if (check_abnormal_return(env))
8221 return -EINVAL;
c454a46b 8222 return 0;
09b28d76 8223 }
c454a46b
MKL
8224
8225 btf = btf_get_by_fd(attr->prog_btf_fd);
8226 if (IS_ERR(btf))
8227 return PTR_ERR(btf);
8228 env->prog->aux->btf = btf;
8229
8230 err = check_btf_func(env, attr, uattr);
8231 if (err)
8232 return err;
8233
8234 err = check_btf_line(env, attr, uattr);
8235 if (err)
8236 return err;
8237
8238 return 0;
ba64e7d8
YS
8239}
8240
f1174f77
EC
8241/* check %cur's range satisfies %old's */
8242static bool range_within(struct bpf_reg_state *old,
8243 struct bpf_reg_state *cur)
8244{
b03c9f9f
EC
8245 return old->umin_value <= cur->umin_value &&
8246 old->umax_value >= cur->umax_value &&
8247 old->smin_value <= cur->smin_value &&
8248 old->smax_value >= cur->smax_value;
f1174f77
EC
8249}
8250
8251/* Maximum number of register states that can exist at once */
8252#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
8253struct idpair {
8254 u32 old;
8255 u32 cur;
8256};
8257
8258/* If in the old state two registers had the same id, then they need to have
8259 * the same id in the new state as well. But that id could be different from
8260 * the old state, so we need to track the mapping from old to new ids.
8261 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
8262 * regs with old id 5 must also have new id 9 for the new state to be safe. But
8263 * regs with a different old id could still have new id 9, we don't care about
8264 * that.
8265 * So we look through our idmap to see if this old id has been seen before. If
8266 * so, we require the new id to match; otherwise, we add the id pair to the map.
969bf05e 8267 */
f1174f77 8268static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
969bf05e 8269{
f1174f77 8270 unsigned int i;
969bf05e 8271
f1174f77
EC
8272 for (i = 0; i < ID_MAP_SIZE; i++) {
8273 if (!idmap[i].old) {
8274 /* Reached an empty slot; haven't seen this id before */
8275 idmap[i].old = old_id;
8276 idmap[i].cur = cur_id;
8277 return true;
8278 }
8279 if (idmap[i].old == old_id)
8280 return idmap[i].cur == cur_id;
8281 }
8282 /* We ran out of idmap slots, which should be impossible */
8283 WARN_ON_ONCE(1);
8284 return false;
8285}
8286
9242b5f5
AS
8287static void clean_func_state(struct bpf_verifier_env *env,
8288 struct bpf_func_state *st)
8289{
8290 enum bpf_reg_liveness live;
8291 int i, j;
8292
8293 for (i = 0; i < BPF_REG_FP; i++) {
8294 live = st->regs[i].live;
8295 /* liveness must not touch this register anymore */
8296 st->regs[i].live |= REG_LIVE_DONE;
8297 if (!(live & REG_LIVE_READ))
8298 /* since the register is unused, clear its state
8299 * to make further comparison simpler
8300 */
f54c7898 8301 __mark_reg_not_init(env, &st->regs[i]);
9242b5f5
AS
8302 }
8303
8304 for (i = 0; i < st->allocated_stack / BPF_REG_SIZE; i++) {
8305 live = st->stack[i].spilled_ptr.live;
8306 /* liveness must not touch this stack slot anymore */
8307 st->stack[i].spilled_ptr.live |= REG_LIVE_DONE;
8308 if (!(live & REG_LIVE_READ)) {
f54c7898 8309 __mark_reg_not_init(env, &st->stack[i].spilled_ptr);
9242b5f5
AS
8310 for (j = 0; j < BPF_REG_SIZE; j++)
8311 st->stack[i].slot_type[j] = STACK_INVALID;
8312 }
8313 }
8314}
8315
8316static void clean_verifier_state(struct bpf_verifier_env *env,
8317 struct bpf_verifier_state *st)
8318{
8319 int i;
8320
8321 if (st->frame[0]->regs[0].live & REG_LIVE_DONE)
8322 /* all regs in this state in all frames were already marked */
8323 return;
8324
8325 for (i = 0; i <= st->curframe; i++)
8326 clean_func_state(env, st->frame[i]);
8327}
8328
8329/* the parentage chains form a tree.
8330 * the verifier states are added to state lists at given insn and
8331 * pushed into state stack for future exploration.
8332 * when the verifier reaches bpf_exit insn some of the verifer states
8333 * stored in the state lists have their final liveness state already,
8334 * but a lot of states will get revised from liveness point of view when
8335 * the verifier explores other branches.
8336 * Example:
8337 * 1: r0 = 1
8338 * 2: if r1 == 100 goto pc+1
8339 * 3: r0 = 2
8340 * 4: exit
8341 * when the verifier reaches exit insn the register r0 in the state list of
8342 * insn 2 will be seen as !REG_LIVE_READ. Then the verifier pops the other_branch
8343 * of insn 2 and goes exploring further. At the insn 4 it will walk the
8344 * parentage chain from insn 4 into insn 2 and will mark r0 as REG_LIVE_READ.
8345 *
8346 * Since the verifier pushes the branch states as it sees them while exploring
8347 * the program the condition of walking the branch instruction for the second
8348 * time means that all states below this branch were already explored and
8349 * their final liveness markes are already propagated.
8350 * Hence when the verifier completes the search of state list in is_state_visited()
8351 * we can call this clean_live_states() function to mark all liveness states
8352 * as REG_LIVE_DONE to indicate that 'parent' pointers of 'struct bpf_reg_state'
8353 * will not be used.
8354 * This function also clears the registers and stack for states that !READ
8355 * to simplify state merging.
8356 *
8357 * Important note here that walking the same branch instruction in the callee
8358 * doesn't meant that the states are DONE. The verifier has to compare
8359 * the callsites
8360 */
8361static void clean_live_states(struct bpf_verifier_env *env, int insn,
8362 struct bpf_verifier_state *cur)
8363{
8364 struct bpf_verifier_state_list *sl;
8365 int i;
8366
5d839021 8367 sl = *explored_state(env, insn);
a8f500af 8368 while (sl) {
2589726d
AS
8369 if (sl->state.branches)
8370 goto next;
dc2a4ebc
AS
8371 if (sl->state.insn_idx != insn ||
8372 sl->state.curframe != cur->curframe)
9242b5f5
AS
8373 goto next;
8374 for (i = 0; i <= cur->curframe; i++)
8375 if (sl->state.frame[i]->callsite != cur->frame[i]->callsite)
8376 goto next;
8377 clean_verifier_state(env, &sl->state);
8378next:
8379 sl = sl->next;
8380 }
8381}
8382
f1174f77 8383/* Returns true if (rold safe implies rcur safe) */
1b688a19
EC
8384static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
8385 struct idpair *idmap)
f1174f77 8386{
f4d7e40a
AS
8387 bool equal;
8388
dc503a8a
EC
8389 if (!(rold->live & REG_LIVE_READ))
8390 /* explored state didn't use this */
8391 return true;
8392
679c782d 8393 equal = memcmp(rold, rcur, offsetof(struct bpf_reg_state, parent)) == 0;
f4d7e40a
AS
8394
8395 if (rold->type == PTR_TO_STACK)
8396 /* two stack pointers are equal only if they're pointing to
8397 * the same stack frame, since fp-8 in foo != fp-8 in bar
8398 */
8399 return equal && rold->frameno == rcur->frameno;
8400
8401 if (equal)
969bf05e
AS
8402 return true;
8403
f1174f77
EC
8404 if (rold->type == NOT_INIT)
8405 /* explored state can't have used this */
969bf05e 8406 return true;
f1174f77
EC
8407 if (rcur->type == NOT_INIT)
8408 return false;
8409 switch (rold->type) {
8410 case SCALAR_VALUE:
8411 if (rcur->type == SCALAR_VALUE) {
b5dc0163
AS
8412 if (!rold->precise && !rcur->precise)
8413 return true;
f1174f77
EC
8414 /* new val must satisfy old val knowledge */
8415 return range_within(rold, rcur) &&
8416 tnum_in(rold->var_off, rcur->var_off);
8417 } else {
179d1c56
JH
8418 /* We're trying to use a pointer in place of a scalar.
8419 * Even if the scalar was unbounded, this could lead to
8420 * pointer leaks because scalars are allowed to leak
8421 * while pointers are not. We could make this safe in
8422 * special cases if root is calling us, but it's
8423 * probably not worth the hassle.
f1174f77 8424 */
179d1c56 8425 return false;
f1174f77
EC
8426 }
8427 case PTR_TO_MAP_VALUE:
1b688a19
EC
8428 /* If the new min/max/var_off satisfy the old ones and
8429 * everything else matches, we are OK.
d83525ca
AS
8430 * 'id' is not compared, since it's only used for maps with
8431 * bpf_spin_lock inside map element and in such cases if
8432 * the rest of the prog is valid for one map element then
8433 * it's valid for all map elements regardless of the key
8434 * used in bpf_map_lookup()
1b688a19
EC
8435 */
8436 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
8437 range_within(rold, rcur) &&
8438 tnum_in(rold->var_off, rcur->var_off);
f1174f77
EC
8439 case PTR_TO_MAP_VALUE_OR_NULL:
8440 /* a PTR_TO_MAP_VALUE could be safe to use as a
8441 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
8442 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
8443 * checked, doing so could have affected others with the same
8444 * id, and we can't check for that because we lost the id when
8445 * we converted to a PTR_TO_MAP_VALUE.
8446 */
8447 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
8448 return false;
8449 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
8450 return false;
8451 /* Check our ids match any regs they're supposed to */
8452 return check_ids(rold->id, rcur->id, idmap);
de8f3a83 8453 case PTR_TO_PACKET_META:
f1174f77 8454 case PTR_TO_PACKET:
de8f3a83 8455 if (rcur->type != rold->type)
f1174f77
EC
8456 return false;
8457 /* We must have at least as much range as the old ptr
8458 * did, so that any accesses which were safe before are
8459 * still safe. This is true even if old range < old off,
8460 * since someone could have accessed through (ptr - k), or
8461 * even done ptr -= k in a register, to get a safe access.
8462 */
8463 if (rold->range > rcur->range)
8464 return false;
8465 /* If the offsets don't match, we can't trust our alignment;
8466 * nor can we be sure that we won't fall out of range.
8467 */
8468 if (rold->off != rcur->off)
8469 return false;
8470 /* id relations must be preserved */
8471 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
8472 return false;
8473 /* new val must satisfy old val knowledge */
8474 return range_within(rold, rcur) &&
8475 tnum_in(rold->var_off, rcur->var_off);
8476 case PTR_TO_CTX:
8477 case CONST_PTR_TO_MAP:
f1174f77 8478 case PTR_TO_PACKET_END:
d58e468b 8479 case PTR_TO_FLOW_KEYS:
c64b7983
JS
8480 case PTR_TO_SOCKET:
8481 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
8482 case PTR_TO_SOCK_COMMON:
8483 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
8484 case PTR_TO_TCP_SOCK:
8485 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 8486 case PTR_TO_XDP_SOCK:
f1174f77
EC
8487 /* Only valid matches are exact, which memcmp() above
8488 * would have accepted
8489 */
8490 default:
8491 /* Don't know what's going on, just say it's not safe */
8492 return false;
8493 }
969bf05e 8494
f1174f77
EC
8495 /* Shouldn't get here; if we do, say it's not safe */
8496 WARN_ON_ONCE(1);
969bf05e
AS
8497 return false;
8498}
8499
f4d7e40a
AS
8500static bool stacksafe(struct bpf_func_state *old,
8501 struct bpf_func_state *cur,
638f5b90
AS
8502 struct idpair *idmap)
8503{
8504 int i, spi;
8505
638f5b90
AS
8506 /* walk slots of the explored stack and ignore any additional
8507 * slots in the current stack, since explored(safe) state
8508 * didn't use them
8509 */
8510 for (i = 0; i < old->allocated_stack; i++) {
8511 spi = i / BPF_REG_SIZE;
8512
b233920c
AS
8513 if (!(old->stack[spi].spilled_ptr.live & REG_LIVE_READ)) {
8514 i += BPF_REG_SIZE - 1;
cc2b14d5 8515 /* explored state didn't use this */
fd05e57b 8516 continue;
b233920c 8517 }
cc2b14d5 8518
638f5b90
AS
8519 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
8520 continue;
19e2dbb7
AS
8521
8522 /* explored stack has more populated slots than current stack
8523 * and these slots were used
8524 */
8525 if (i >= cur->allocated_stack)
8526 return false;
8527
cc2b14d5
AS
8528 /* if old state was safe with misc data in the stack
8529 * it will be safe with zero-initialized stack.
8530 * The opposite is not true
8531 */
8532 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_MISC &&
8533 cur->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_ZERO)
8534 continue;
638f5b90
AS
8535 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
8536 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
8537 /* Ex: old explored (safe) state has STACK_SPILL in
b8c1a309 8538 * this stack slot, but current has STACK_MISC ->
638f5b90
AS
8539 * this verifier states are not equivalent,
8540 * return false to continue verification of this path
8541 */
8542 return false;
8543 if (i % BPF_REG_SIZE)
8544 continue;
8545 if (old->stack[spi].slot_type[0] != STACK_SPILL)
8546 continue;
8547 if (!regsafe(&old->stack[spi].spilled_ptr,
8548 &cur->stack[spi].spilled_ptr,
8549 idmap))
8550 /* when explored and current stack slot are both storing
8551 * spilled registers, check that stored pointers types
8552 * are the same as well.
8553 * Ex: explored safe path could have stored
8554 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
8555 * but current path has stored:
8556 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
8557 * such verifier states are not equivalent.
8558 * return false to continue verification of this path
8559 */
8560 return false;
8561 }
8562 return true;
8563}
8564
fd978bf7
JS
8565static bool refsafe(struct bpf_func_state *old, struct bpf_func_state *cur)
8566{
8567 if (old->acquired_refs != cur->acquired_refs)
8568 return false;
8569 return !memcmp(old->refs, cur->refs,
8570 sizeof(*old->refs) * old->acquired_refs);
8571}
8572
f1bca824
AS
8573/* compare two verifier states
8574 *
8575 * all states stored in state_list are known to be valid, since
8576 * verifier reached 'bpf_exit' instruction through them
8577 *
8578 * this function is called when verifier exploring different branches of
8579 * execution popped from the state stack. If it sees an old state that has
8580 * more strict register state and more strict stack state then this execution
8581 * branch doesn't need to be explored further, since verifier already
8582 * concluded that more strict state leads to valid finish.
8583 *
8584 * Therefore two states are equivalent if register state is more conservative
8585 * and explored stack state is more conservative than the current one.
8586 * Example:
8587 * explored current
8588 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
8589 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
8590 *
8591 * In other words if current stack state (one being explored) has more
8592 * valid slots than old one that already passed validation, it means
8593 * the verifier can stop exploring and conclude that current state is valid too
8594 *
8595 * Similarly with registers. If explored state has register type as invalid
8596 * whereas register type in current state is meaningful, it means that
8597 * the current state will reach 'bpf_exit' instruction safely
8598 */
f4d7e40a
AS
8599static bool func_states_equal(struct bpf_func_state *old,
8600 struct bpf_func_state *cur)
f1bca824 8601{
f1174f77
EC
8602 struct idpair *idmap;
8603 bool ret = false;
f1bca824
AS
8604 int i;
8605
f1174f77
EC
8606 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
8607 /* If we failed to allocate the idmap, just say it's not safe */
8608 if (!idmap)
1a0dc1ac 8609 return false;
f1174f77
EC
8610
8611 for (i = 0; i < MAX_BPF_REG; i++) {
1b688a19 8612 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
f1174f77 8613 goto out_free;
f1bca824
AS
8614 }
8615
638f5b90
AS
8616 if (!stacksafe(old, cur, idmap))
8617 goto out_free;
fd978bf7
JS
8618
8619 if (!refsafe(old, cur))
8620 goto out_free;
f1174f77
EC
8621 ret = true;
8622out_free:
8623 kfree(idmap);
8624 return ret;
f1bca824
AS
8625}
8626
f4d7e40a
AS
8627static bool states_equal(struct bpf_verifier_env *env,
8628 struct bpf_verifier_state *old,
8629 struct bpf_verifier_state *cur)
8630{
8631 int i;
8632
8633 if (old->curframe != cur->curframe)
8634 return false;
8635
979d63d5
DB
8636 /* Verification state from speculative execution simulation
8637 * must never prune a non-speculative execution one.
8638 */
8639 if (old->speculative && !cur->speculative)
8640 return false;
8641
d83525ca
AS
8642 if (old->active_spin_lock != cur->active_spin_lock)
8643 return false;
8644
f4d7e40a
AS
8645 /* for states to be equal callsites have to be the same
8646 * and all frame states need to be equivalent
8647 */
8648 for (i = 0; i <= old->curframe; i++) {
8649 if (old->frame[i]->callsite != cur->frame[i]->callsite)
8650 return false;
8651 if (!func_states_equal(old->frame[i], cur->frame[i]))
8652 return false;
8653 }
8654 return true;
8655}
8656
5327ed3d
JW
8657/* Return 0 if no propagation happened. Return negative error code if error
8658 * happened. Otherwise, return the propagated bit.
8659 */
55e7f3b5
JW
8660static int propagate_liveness_reg(struct bpf_verifier_env *env,
8661 struct bpf_reg_state *reg,
8662 struct bpf_reg_state *parent_reg)
8663{
5327ed3d
JW
8664 u8 parent_flag = parent_reg->live & REG_LIVE_READ;
8665 u8 flag = reg->live & REG_LIVE_READ;
55e7f3b5
JW
8666 int err;
8667
5327ed3d
JW
8668 /* When comes here, read flags of PARENT_REG or REG could be any of
8669 * REG_LIVE_READ64, REG_LIVE_READ32, REG_LIVE_NONE. There is no need
8670 * of propagation if PARENT_REG has strongest REG_LIVE_READ64.
8671 */
8672 if (parent_flag == REG_LIVE_READ64 ||
8673 /* Or if there is no read flag from REG. */
8674 !flag ||
8675 /* Or if the read flag from REG is the same as PARENT_REG. */
8676 parent_flag == flag)
55e7f3b5
JW
8677 return 0;
8678
5327ed3d 8679 err = mark_reg_read(env, reg, parent_reg, flag);
55e7f3b5
JW
8680 if (err)
8681 return err;
8682
5327ed3d 8683 return flag;
55e7f3b5
JW
8684}
8685
8e9cd9ce 8686/* A write screens off any subsequent reads; but write marks come from the
f4d7e40a
AS
8687 * straight-line code between a state and its parent. When we arrive at an
8688 * equivalent state (jump target or such) we didn't arrive by the straight-line
8689 * code, so read marks in the state must propagate to the parent regardless
8690 * of the state's write marks. That's what 'parent == state->parent' comparison
679c782d 8691 * in mark_reg_read() is for.
8e9cd9ce 8692 */
f4d7e40a
AS
8693static int propagate_liveness(struct bpf_verifier_env *env,
8694 const struct bpf_verifier_state *vstate,
8695 struct bpf_verifier_state *vparent)
dc503a8a 8696{
3f8cafa4 8697 struct bpf_reg_state *state_reg, *parent_reg;
f4d7e40a 8698 struct bpf_func_state *state, *parent;
3f8cafa4 8699 int i, frame, err = 0;
dc503a8a 8700
f4d7e40a
AS
8701 if (vparent->curframe != vstate->curframe) {
8702 WARN(1, "propagate_live: parent frame %d current frame %d\n",
8703 vparent->curframe, vstate->curframe);
8704 return -EFAULT;
8705 }
dc503a8a
EC
8706 /* Propagate read liveness of registers... */
8707 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
83d16312 8708 for (frame = 0; frame <= vstate->curframe; frame++) {
3f8cafa4
JW
8709 parent = vparent->frame[frame];
8710 state = vstate->frame[frame];
8711 parent_reg = parent->regs;
8712 state_reg = state->regs;
83d16312
JK
8713 /* We don't need to worry about FP liveness, it's read-only */
8714 for (i = frame < vstate->curframe ? BPF_REG_6 : 0; i < BPF_REG_FP; i++) {
55e7f3b5
JW
8715 err = propagate_liveness_reg(env, &state_reg[i],
8716 &parent_reg[i]);
5327ed3d 8717 if (err < 0)
3f8cafa4 8718 return err;
5327ed3d
JW
8719 if (err == REG_LIVE_READ64)
8720 mark_insn_zext(env, &parent_reg[i]);
dc503a8a 8721 }
f4d7e40a 8722
1b04aee7 8723 /* Propagate stack slots. */
f4d7e40a
AS
8724 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
8725 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
3f8cafa4
JW
8726 parent_reg = &parent->stack[i].spilled_ptr;
8727 state_reg = &state->stack[i].spilled_ptr;
55e7f3b5
JW
8728 err = propagate_liveness_reg(env, state_reg,
8729 parent_reg);
5327ed3d 8730 if (err < 0)
3f8cafa4 8731 return err;
dc503a8a
EC
8732 }
8733 }
5327ed3d 8734 return 0;
dc503a8a
EC
8735}
8736
a3ce685d
AS
8737/* find precise scalars in the previous equivalent state and
8738 * propagate them into the current state
8739 */
8740static int propagate_precision(struct bpf_verifier_env *env,
8741 const struct bpf_verifier_state *old)
8742{
8743 struct bpf_reg_state *state_reg;
8744 struct bpf_func_state *state;
8745 int i, err = 0;
8746
8747 state = old->frame[old->curframe];
8748 state_reg = state->regs;
8749 for (i = 0; i < BPF_REG_FP; i++, state_reg++) {
8750 if (state_reg->type != SCALAR_VALUE ||
8751 !state_reg->precise)
8752 continue;
8753 if (env->log.level & BPF_LOG_LEVEL2)
8754 verbose(env, "propagating r%d\n", i);
8755 err = mark_chain_precision(env, i);
8756 if (err < 0)
8757 return err;
8758 }
8759
8760 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
8761 if (state->stack[i].slot_type[0] != STACK_SPILL)
8762 continue;
8763 state_reg = &state->stack[i].spilled_ptr;
8764 if (state_reg->type != SCALAR_VALUE ||
8765 !state_reg->precise)
8766 continue;
8767 if (env->log.level & BPF_LOG_LEVEL2)
8768 verbose(env, "propagating fp%d\n",
8769 (-i - 1) * BPF_REG_SIZE);
8770 err = mark_chain_precision_stack(env, i);
8771 if (err < 0)
8772 return err;
8773 }
8774 return 0;
8775}
8776
2589726d
AS
8777static bool states_maybe_looping(struct bpf_verifier_state *old,
8778 struct bpf_verifier_state *cur)
8779{
8780 struct bpf_func_state *fold, *fcur;
8781 int i, fr = cur->curframe;
8782
8783 if (old->curframe != fr)
8784 return false;
8785
8786 fold = old->frame[fr];
8787 fcur = cur->frame[fr];
8788 for (i = 0; i < MAX_BPF_REG; i++)
8789 if (memcmp(&fold->regs[i], &fcur->regs[i],
8790 offsetof(struct bpf_reg_state, parent)))
8791 return false;
8792 return true;
8793}
8794
8795
58e2af8b 8796static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
f1bca824 8797{
58e2af8b 8798 struct bpf_verifier_state_list *new_sl;
9f4686c4 8799 struct bpf_verifier_state_list *sl, **pprev;
679c782d 8800 struct bpf_verifier_state *cur = env->cur_state, *new;
ceefbc96 8801 int i, j, err, states_cnt = 0;
10d274e8 8802 bool add_new_state = env->test_state_freq ? true : false;
f1bca824 8803
b5dc0163 8804 cur->last_insn_idx = env->prev_insn_idx;
a8f500af 8805 if (!env->insn_aux_data[insn_idx].prune_point)
f1bca824
AS
8806 /* this 'insn_idx' instruction wasn't marked, so we will not
8807 * be doing state search here
8808 */
8809 return 0;
8810
2589726d
AS
8811 /* bpf progs typically have pruning point every 4 instructions
8812 * http://vger.kernel.org/bpfconf2019.html#session-1
8813 * Do not add new state for future pruning if the verifier hasn't seen
8814 * at least 2 jumps and at least 8 instructions.
8815 * This heuristics helps decrease 'total_states' and 'peak_states' metric.
8816 * In tests that amounts to up to 50% reduction into total verifier
8817 * memory consumption and 20% verifier time speedup.
8818 */
8819 if (env->jmps_processed - env->prev_jmps_processed >= 2 &&
8820 env->insn_processed - env->prev_insn_processed >= 8)
8821 add_new_state = true;
8822
a8f500af
AS
8823 pprev = explored_state(env, insn_idx);
8824 sl = *pprev;
8825
9242b5f5
AS
8826 clean_live_states(env, insn_idx, cur);
8827
a8f500af 8828 while (sl) {
dc2a4ebc
AS
8829 states_cnt++;
8830 if (sl->state.insn_idx != insn_idx)
8831 goto next;
2589726d
AS
8832 if (sl->state.branches) {
8833 if (states_maybe_looping(&sl->state, cur) &&
8834 states_equal(env, &sl->state, cur)) {
8835 verbose_linfo(env, insn_idx, "; ");
8836 verbose(env, "infinite loop detected at insn %d\n", insn_idx);
8837 return -EINVAL;
8838 }
8839 /* if the verifier is processing a loop, avoid adding new state
8840 * too often, since different loop iterations have distinct
8841 * states and may not help future pruning.
8842 * This threshold shouldn't be too low to make sure that
8843 * a loop with large bound will be rejected quickly.
8844 * The most abusive loop will be:
8845 * r1 += 1
8846 * if r1 < 1000000 goto pc-2
8847 * 1M insn_procssed limit / 100 == 10k peak states.
8848 * This threshold shouldn't be too high either, since states
8849 * at the end of the loop are likely to be useful in pruning.
8850 */
8851 if (env->jmps_processed - env->prev_jmps_processed < 20 &&
8852 env->insn_processed - env->prev_insn_processed < 100)
8853 add_new_state = false;
8854 goto miss;
8855 }
638f5b90 8856 if (states_equal(env, &sl->state, cur)) {
9f4686c4 8857 sl->hit_cnt++;
f1bca824 8858 /* reached equivalent register/stack state,
dc503a8a
EC
8859 * prune the search.
8860 * Registers read by the continuation are read by us.
8e9cd9ce
EC
8861 * If we have any write marks in env->cur_state, they
8862 * will prevent corresponding reads in the continuation
8863 * from reaching our parent (an explored_state). Our
8864 * own state will get the read marks recorded, but
8865 * they'll be immediately forgotten as we're pruning
8866 * this state and will pop a new one.
f1bca824 8867 */
f4d7e40a 8868 err = propagate_liveness(env, &sl->state, cur);
a3ce685d
AS
8869
8870 /* if previous state reached the exit with precision and
8871 * current state is equivalent to it (except precsion marks)
8872 * the precision needs to be propagated back in
8873 * the current state.
8874 */
8875 err = err ? : push_jmp_history(env, cur);
8876 err = err ? : propagate_precision(env, &sl->state);
f4d7e40a
AS
8877 if (err)
8878 return err;
f1bca824 8879 return 1;
dc503a8a 8880 }
2589726d
AS
8881miss:
8882 /* when new state is not going to be added do not increase miss count.
8883 * Otherwise several loop iterations will remove the state
8884 * recorded earlier. The goal of these heuristics is to have
8885 * states from some iterations of the loop (some in the beginning
8886 * and some at the end) to help pruning.
8887 */
8888 if (add_new_state)
8889 sl->miss_cnt++;
9f4686c4
AS
8890 /* heuristic to determine whether this state is beneficial
8891 * to keep checking from state equivalence point of view.
8892 * Higher numbers increase max_states_per_insn and verification time,
8893 * but do not meaningfully decrease insn_processed.
8894 */
8895 if (sl->miss_cnt > sl->hit_cnt * 3 + 3) {
8896 /* the state is unlikely to be useful. Remove it to
8897 * speed up verification
8898 */
8899 *pprev = sl->next;
8900 if (sl->state.frame[0]->regs[0].live & REG_LIVE_DONE) {
2589726d
AS
8901 u32 br = sl->state.branches;
8902
8903 WARN_ONCE(br,
8904 "BUG live_done but branches_to_explore %d\n",
8905 br);
9f4686c4
AS
8906 free_verifier_state(&sl->state, false);
8907 kfree(sl);
8908 env->peak_states--;
8909 } else {
8910 /* cannot free this state, since parentage chain may
8911 * walk it later. Add it for free_list instead to
8912 * be freed at the end of verification
8913 */
8914 sl->next = env->free_list;
8915 env->free_list = sl;
8916 }
8917 sl = *pprev;
8918 continue;
8919 }
dc2a4ebc 8920next:
9f4686c4
AS
8921 pprev = &sl->next;
8922 sl = *pprev;
f1bca824
AS
8923 }
8924
06ee7115
AS
8925 if (env->max_states_per_insn < states_cnt)
8926 env->max_states_per_insn = states_cnt;
8927
2c78ee89 8928 if (!env->bpf_capable && states_cnt > BPF_COMPLEXITY_LIMIT_STATES)
b5dc0163 8929 return push_jmp_history(env, cur);
ceefbc96 8930
2589726d 8931 if (!add_new_state)
b5dc0163 8932 return push_jmp_history(env, cur);
ceefbc96 8933
2589726d
AS
8934 /* There were no equivalent states, remember the current one.
8935 * Technically the current state is not proven to be safe yet,
f4d7e40a 8936 * but it will either reach outer most bpf_exit (which means it's safe)
2589726d 8937 * or it will be rejected. When there are no loops the verifier won't be
f4d7e40a 8938 * seeing this tuple (frame[0].callsite, frame[1].callsite, .. insn_idx)
2589726d
AS
8939 * again on the way to bpf_exit.
8940 * When looping the sl->state.branches will be > 0 and this state
8941 * will not be considered for equivalence until branches == 0.
f1bca824 8942 */
638f5b90 8943 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
f1bca824
AS
8944 if (!new_sl)
8945 return -ENOMEM;
06ee7115
AS
8946 env->total_states++;
8947 env->peak_states++;
2589726d
AS
8948 env->prev_jmps_processed = env->jmps_processed;
8949 env->prev_insn_processed = env->insn_processed;
f1bca824
AS
8950
8951 /* add new state to the head of linked list */
679c782d
EC
8952 new = &new_sl->state;
8953 err = copy_verifier_state(new, cur);
1969db47 8954 if (err) {
679c782d 8955 free_verifier_state(new, false);
1969db47
AS
8956 kfree(new_sl);
8957 return err;
8958 }
dc2a4ebc 8959 new->insn_idx = insn_idx;
2589726d
AS
8960 WARN_ONCE(new->branches != 1,
8961 "BUG is_state_visited:branches_to_explore=%d insn %d\n", new->branches, insn_idx);
b5dc0163 8962
2589726d 8963 cur->parent = new;
b5dc0163
AS
8964 cur->first_insn_idx = insn_idx;
8965 clear_jmp_history(cur);
5d839021
AS
8966 new_sl->next = *explored_state(env, insn_idx);
8967 *explored_state(env, insn_idx) = new_sl;
7640ead9
JK
8968 /* connect new state to parentage chain. Current frame needs all
8969 * registers connected. Only r6 - r9 of the callers are alive (pushed
8970 * to the stack implicitly by JITs) so in callers' frames connect just
8971 * r6 - r9 as an optimization. Callers will have r1 - r5 connected to
8972 * the state of the call instruction (with WRITTEN set), and r0 comes
8973 * from callee with its full parentage chain, anyway.
8974 */
8e9cd9ce
EC
8975 /* clear write marks in current state: the writes we did are not writes
8976 * our child did, so they don't screen off its reads from us.
8977 * (There are no read marks in current state, because reads always mark
8978 * their parent and current state never has children yet. Only
8979 * explored_states can get read marks.)
8980 */
eea1c227
AS
8981 for (j = 0; j <= cur->curframe; j++) {
8982 for (i = j < cur->curframe ? BPF_REG_6 : 0; i < BPF_REG_FP; i++)
8983 cur->frame[j]->regs[i].parent = &new->frame[j]->regs[i];
8984 for (i = 0; i < BPF_REG_FP; i++)
8985 cur->frame[j]->regs[i].live = REG_LIVE_NONE;
8986 }
f4d7e40a
AS
8987
8988 /* all stack frames are accessible from callee, clear them all */
8989 for (j = 0; j <= cur->curframe; j++) {
8990 struct bpf_func_state *frame = cur->frame[j];
679c782d 8991 struct bpf_func_state *newframe = new->frame[j];
f4d7e40a 8992
679c782d 8993 for (i = 0; i < frame->allocated_stack / BPF_REG_SIZE; i++) {
cc2b14d5 8994 frame->stack[i].spilled_ptr.live = REG_LIVE_NONE;
679c782d
EC
8995 frame->stack[i].spilled_ptr.parent =
8996 &newframe->stack[i].spilled_ptr;
8997 }
f4d7e40a 8998 }
f1bca824
AS
8999 return 0;
9000}
9001
c64b7983
JS
9002/* Return true if it's OK to have the same insn return a different type. */
9003static bool reg_type_mismatch_ok(enum bpf_reg_type type)
9004{
9005 switch (type) {
9006 case PTR_TO_CTX:
9007 case PTR_TO_SOCKET:
9008 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
9009 case PTR_TO_SOCK_COMMON:
9010 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
9011 case PTR_TO_TCP_SOCK:
9012 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 9013 case PTR_TO_XDP_SOCK:
2a02759e 9014 case PTR_TO_BTF_ID:
b121b341 9015 case PTR_TO_BTF_ID_OR_NULL:
c64b7983
JS
9016 return false;
9017 default:
9018 return true;
9019 }
9020}
9021
9022/* If an instruction was previously used with particular pointer types, then we
9023 * need to be careful to avoid cases such as the below, where it may be ok
9024 * for one branch accessing the pointer, but not ok for the other branch:
9025 *
9026 * R1 = sock_ptr
9027 * goto X;
9028 * ...
9029 * R1 = some_other_valid_ptr;
9030 * goto X;
9031 * ...
9032 * R2 = *(u32 *)(R1 + 0);
9033 */
9034static bool reg_type_mismatch(enum bpf_reg_type src, enum bpf_reg_type prev)
9035{
9036 return src != prev && (!reg_type_mismatch_ok(src) ||
9037 !reg_type_mismatch_ok(prev));
9038}
9039
58e2af8b 9040static int do_check(struct bpf_verifier_env *env)
17a52670 9041{
6f8a57cc 9042 bool pop_log = !(env->log.level & BPF_LOG_LEVEL2);
51c39bb1 9043 struct bpf_verifier_state *state = env->cur_state;
17a52670 9044 struct bpf_insn *insns = env->prog->insnsi;
638f5b90 9045 struct bpf_reg_state *regs;
06ee7115 9046 int insn_cnt = env->prog->len;
17a52670 9047 bool do_print_state = false;
b5dc0163 9048 int prev_insn_idx = -1;
17a52670 9049
17a52670
AS
9050 for (;;) {
9051 struct bpf_insn *insn;
9052 u8 class;
9053 int err;
9054
b5dc0163 9055 env->prev_insn_idx = prev_insn_idx;
c08435ec 9056 if (env->insn_idx >= insn_cnt) {
61bd5218 9057 verbose(env, "invalid insn idx %d insn_cnt %d\n",
c08435ec 9058 env->insn_idx, insn_cnt);
17a52670
AS
9059 return -EFAULT;
9060 }
9061
c08435ec 9062 insn = &insns[env->insn_idx];
17a52670
AS
9063 class = BPF_CLASS(insn->code);
9064
06ee7115 9065 if (++env->insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
61bd5218
JK
9066 verbose(env,
9067 "BPF program is too large. Processed %d insn\n",
06ee7115 9068 env->insn_processed);
17a52670
AS
9069 return -E2BIG;
9070 }
9071
c08435ec 9072 err = is_state_visited(env, env->insn_idx);
f1bca824
AS
9073 if (err < 0)
9074 return err;
9075 if (err == 1) {
9076 /* found equivalent state, can prune the search */
06ee7115 9077 if (env->log.level & BPF_LOG_LEVEL) {
f1bca824 9078 if (do_print_state)
979d63d5
DB
9079 verbose(env, "\nfrom %d to %d%s: safe\n",
9080 env->prev_insn_idx, env->insn_idx,
9081 env->cur_state->speculative ?
9082 " (speculative execution)" : "");
f1bca824 9083 else
c08435ec 9084 verbose(env, "%d: safe\n", env->insn_idx);
f1bca824
AS
9085 }
9086 goto process_bpf_exit;
9087 }
9088
c3494801
AS
9089 if (signal_pending(current))
9090 return -EAGAIN;
9091
3c2ce60b
DB
9092 if (need_resched())
9093 cond_resched();
9094
06ee7115
AS
9095 if (env->log.level & BPF_LOG_LEVEL2 ||
9096 (env->log.level & BPF_LOG_LEVEL && do_print_state)) {
9097 if (env->log.level & BPF_LOG_LEVEL2)
c08435ec 9098 verbose(env, "%d:", env->insn_idx);
c5fc9692 9099 else
979d63d5
DB
9100 verbose(env, "\nfrom %d to %d%s:",
9101 env->prev_insn_idx, env->insn_idx,
9102 env->cur_state->speculative ?
9103 " (speculative execution)" : "");
f4d7e40a 9104 print_verifier_state(env, state->frame[state->curframe]);
17a52670
AS
9105 do_print_state = false;
9106 }
9107
06ee7115 9108 if (env->log.level & BPF_LOG_LEVEL) {
7105e828
DB
9109 const struct bpf_insn_cbs cbs = {
9110 .cb_print = verbose,
abe08840 9111 .private_data = env,
7105e828
DB
9112 };
9113
c08435ec
DB
9114 verbose_linfo(env, env->insn_idx, "; ");
9115 verbose(env, "%d: ", env->insn_idx);
abe08840 9116 print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
17a52670
AS
9117 }
9118
cae1927c 9119 if (bpf_prog_is_dev_bound(env->prog->aux)) {
c08435ec
DB
9120 err = bpf_prog_offload_verify_insn(env, env->insn_idx,
9121 env->prev_insn_idx);
cae1927c
JK
9122 if (err)
9123 return err;
9124 }
13a27dfc 9125
638f5b90 9126 regs = cur_regs(env);
51c39bb1 9127 env->insn_aux_data[env->insn_idx].seen = env->pass_cnt;
b5dc0163 9128 prev_insn_idx = env->insn_idx;
fd978bf7 9129
17a52670 9130 if (class == BPF_ALU || class == BPF_ALU64) {
1be7f75d 9131 err = check_alu_op(env, insn);
17a52670
AS
9132 if (err)
9133 return err;
9134
9135 } else if (class == BPF_LDX) {
3df126f3 9136 enum bpf_reg_type *prev_src_type, src_reg_type;
9bac3d6d
AS
9137
9138 /* check for reserved fields is already done */
9139
17a52670 9140 /* check src operand */
dc503a8a 9141 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
9142 if (err)
9143 return err;
9144
dc503a8a 9145 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
17a52670
AS
9146 if (err)
9147 return err;
9148
725f9dcd
AS
9149 src_reg_type = regs[insn->src_reg].type;
9150
17a52670
AS
9151 /* check that memory (src_reg + off) is readable,
9152 * the state of dst_reg will be updated by this func
9153 */
c08435ec
DB
9154 err = check_mem_access(env, env->insn_idx, insn->src_reg,
9155 insn->off, BPF_SIZE(insn->code),
9156 BPF_READ, insn->dst_reg, false);
17a52670
AS
9157 if (err)
9158 return err;
9159
c08435ec 9160 prev_src_type = &env->insn_aux_data[env->insn_idx].ptr_type;
3df126f3
JK
9161
9162 if (*prev_src_type == NOT_INIT) {
9bac3d6d
AS
9163 /* saw a valid insn
9164 * dst_reg = *(u32 *)(src_reg + off)
3df126f3 9165 * save type to validate intersecting paths
9bac3d6d 9166 */
3df126f3 9167 *prev_src_type = src_reg_type;
9bac3d6d 9168
c64b7983 9169 } else if (reg_type_mismatch(src_reg_type, *prev_src_type)) {
9bac3d6d
AS
9170 /* ABuser program is trying to use the same insn
9171 * dst_reg = *(u32*) (src_reg + off)
9172 * with different pointer types:
9173 * src_reg == ctx in one branch and
9174 * src_reg == stack|map in some other branch.
9175 * Reject it.
9176 */
61bd5218 9177 verbose(env, "same insn cannot be used with different pointers\n");
9bac3d6d
AS
9178 return -EINVAL;
9179 }
9180
17a52670 9181 } else if (class == BPF_STX) {
3df126f3 9182 enum bpf_reg_type *prev_dst_type, dst_reg_type;
d691f9e8 9183
17a52670 9184 if (BPF_MODE(insn->code) == BPF_XADD) {
c08435ec 9185 err = check_xadd(env, env->insn_idx, insn);
17a52670
AS
9186 if (err)
9187 return err;
c08435ec 9188 env->insn_idx++;
17a52670
AS
9189 continue;
9190 }
9191
17a52670 9192 /* check src1 operand */
dc503a8a 9193 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
9194 if (err)
9195 return err;
9196 /* check src2 operand */
dc503a8a 9197 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
9198 if (err)
9199 return err;
9200
d691f9e8
AS
9201 dst_reg_type = regs[insn->dst_reg].type;
9202
17a52670 9203 /* check that memory (dst_reg + off) is writeable */
c08435ec
DB
9204 err = check_mem_access(env, env->insn_idx, insn->dst_reg,
9205 insn->off, BPF_SIZE(insn->code),
9206 BPF_WRITE, insn->src_reg, false);
17a52670
AS
9207 if (err)
9208 return err;
9209
c08435ec 9210 prev_dst_type = &env->insn_aux_data[env->insn_idx].ptr_type;
3df126f3
JK
9211
9212 if (*prev_dst_type == NOT_INIT) {
9213 *prev_dst_type = dst_reg_type;
c64b7983 9214 } else if (reg_type_mismatch(dst_reg_type, *prev_dst_type)) {
61bd5218 9215 verbose(env, "same insn cannot be used with different pointers\n");
d691f9e8
AS
9216 return -EINVAL;
9217 }
9218
17a52670
AS
9219 } else if (class == BPF_ST) {
9220 if (BPF_MODE(insn->code) != BPF_MEM ||
9221 insn->src_reg != BPF_REG_0) {
61bd5218 9222 verbose(env, "BPF_ST uses reserved fields\n");
17a52670
AS
9223 return -EINVAL;
9224 }
9225 /* check src operand */
dc503a8a 9226 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
9227 if (err)
9228 return err;
9229
f37a8cb8 9230 if (is_ctx_reg(env, insn->dst_reg)) {
9d2be44a 9231 verbose(env, "BPF_ST stores into R%d %s is not allowed\n",
2a159c6f
DB
9232 insn->dst_reg,
9233 reg_type_str[reg_state(env, insn->dst_reg)->type]);
f37a8cb8
DB
9234 return -EACCES;
9235 }
9236
17a52670 9237 /* check that memory (dst_reg + off) is writeable */
c08435ec
DB
9238 err = check_mem_access(env, env->insn_idx, insn->dst_reg,
9239 insn->off, BPF_SIZE(insn->code),
9240 BPF_WRITE, -1, false);
17a52670
AS
9241 if (err)
9242 return err;
9243
092ed096 9244 } else if (class == BPF_JMP || class == BPF_JMP32) {
17a52670
AS
9245 u8 opcode = BPF_OP(insn->code);
9246
2589726d 9247 env->jmps_processed++;
17a52670
AS
9248 if (opcode == BPF_CALL) {
9249 if (BPF_SRC(insn->code) != BPF_K ||
9250 insn->off != 0 ||
f4d7e40a
AS
9251 (insn->src_reg != BPF_REG_0 &&
9252 insn->src_reg != BPF_PSEUDO_CALL) ||
092ed096
JW
9253 insn->dst_reg != BPF_REG_0 ||
9254 class == BPF_JMP32) {
61bd5218 9255 verbose(env, "BPF_CALL uses reserved fields\n");
17a52670
AS
9256 return -EINVAL;
9257 }
9258
d83525ca
AS
9259 if (env->cur_state->active_spin_lock &&
9260 (insn->src_reg == BPF_PSEUDO_CALL ||
9261 insn->imm != BPF_FUNC_spin_unlock)) {
9262 verbose(env, "function calls are not allowed while holding a lock\n");
9263 return -EINVAL;
9264 }
f4d7e40a 9265 if (insn->src_reg == BPF_PSEUDO_CALL)
c08435ec 9266 err = check_func_call(env, insn, &env->insn_idx);
f4d7e40a 9267 else
c08435ec 9268 err = check_helper_call(env, insn->imm, env->insn_idx);
17a52670
AS
9269 if (err)
9270 return err;
9271
9272 } else if (opcode == BPF_JA) {
9273 if (BPF_SRC(insn->code) != BPF_K ||
9274 insn->imm != 0 ||
9275 insn->src_reg != BPF_REG_0 ||
092ed096
JW
9276 insn->dst_reg != BPF_REG_0 ||
9277 class == BPF_JMP32) {
61bd5218 9278 verbose(env, "BPF_JA uses reserved fields\n");
17a52670
AS
9279 return -EINVAL;
9280 }
9281
c08435ec 9282 env->insn_idx += insn->off + 1;
17a52670
AS
9283 continue;
9284
9285 } else if (opcode == BPF_EXIT) {
9286 if (BPF_SRC(insn->code) != BPF_K ||
9287 insn->imm != 0 ||
9288 insn->src_reg != BPF_REG_0 ||
092ed096
JW
9289 insn->dst_reg != BPF_REG_0 ||
9290 class == BPF_JMP32) {
61bd5218 9291 verbose(env, "BPF_EXIT uses reserved fields\n");
17a52670
AS
9292 return -EINVAL;
9293 }
9294
d83525ca
AS
9295 if (env->cur_state->active_spin_lock) {
9296 verbose(env, "bpf_spin_unlock is missing\n");
9297 return -EINVAL;
9298 }
9299
f4d7e40a
AS
9300 if (state->curframe) {
9301 /* exit from nested function */
c08435ec 9302 err = prepare_func_exit(env, &env->insn_idx);
f4d7e40a
AS
9303 if (err)
9304 return err;
9305 do_print_state = true;
9306 continue;
9307 }
9308
fd978bf7
JS
9309 err = check_reference_leak(env);
9310 if (err)
9311 return err;
9312
390ee7e2
AS
9313 err = check_return_code(env);
9314 if (err)
9315 return err;
f1bca824 9316process_bpf_exit:
2589726d 9317 update_branch_counts(env, env->cur_state);
b5dc0163 9318 err = pop_stack(env, &prev_insn_idx,
6f8a57cc 9319 &env->insn_idx, pop_log);
638f5b90
AS
9320 if (err < 0) {
9321 if (err != -ENOENT)
9322 return err;
17a52670
AS
9323 break;
9324 } else {
9325 do_print_state = true;
9326 continue;
9327 }
9328 } else {
c08435ec 9329 err = check_cond_jmp_op(env, insn, &env->insn_idx);
17a52670
AS
9330 if (err)
9331 return err;
9332 }
9333 } else if (class == BPF_LD) {
9334 u8 mode = BPF_MODE(insn->code);
9335
9336 if (mode == BPF_ABS || mode == BPF_IND) {
ddd872bc
AS
9337 err = check_ld_abs(env, insn);
9338 if (err)
9339 return err;
9340
17a52670
AS
9341 } else if (mode == BPF_IMM) {
9342 err = check_ld_imm(env, insn);
9343 if (err)
9344 return err;
9345
c08435ec 9346 env->insn_idx++;
51c39bb1 9347 env->insn_aux_data[env->insn_idx].seen = env->pass_cnt;
17a52670 9348 } else {
61bd5218 9349 verbose(env, "invalid BPF_LD mode\n");
17a52670
AS
9350 return -EINVAL;
9351 }
9352 } else {
61bd5218 9353 verbose(env, "unknown insn class %d\n", class);
17a52670
AS
9354 return -EINVAL;
9355 }
9356
c08435ec 9357 env->insn_idx++;
17a52670
AS
9358 }
9359
9360 return 0;
9361}
9362
56f668df
MKL
9363static int check_map_prealloc(struct bpf_map *map)
9364{
9365 return (map->map_type != BPF_MAP_TYPE_HASH &&
bcc6b1b7
MKL
9366 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
9367 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
56f668df
MKL
9368 !(map->map_flags & BPF_F_NO_PREALLOC);
9369}
9370
d83525ca
AS
9371static bool is_tracing_prog_type(enum bpf_prog_type type)
9372{
9373 switch (type) {
9374 case BPF_PROG_TYPE_KPROBE:
9375 case BPF_PROG_TYPE_TRACEPOINT:
9376 case BPF_PROG_TYPE_PERF_EVENT:
9377 case BPF_PROG_TYPE_RAW_TRACEPOINT:
9378 return true;
9379 default:
9380 return false;
9381 }
9382}
9383
94dacdbd
TG
9384static bool is_preallocated_map(struct bpf_map *map)
9385{
9386 if (!check_map_prealloc(map))
9387 return false;
9388 if (map->inner_map_meta && !check_map_prealloc(map->inner_map_meta))
9389 return false;
9390 return true;
9391}
9392
61bd5218
JK
9393static int check_map_prog_compatibility(struct bpf_verifier_env *env,
9394 struct bpf_map *map,
fdc15d38
AS
9395 struct bpf_prog *prog)
9396
9397{
7e40781c 9398 enum bpf_prog_type prog_type = resolve_prog_type(prog);
94dacdbd
TG
9399 /*
9400 * Validate that trace type programs use preallocated hash maps.
9401 *
9402 * For programs attached to PERF events this is mandatory as the
9403 * perf NMI can hit any arbitrary code sequence.
9404 *
9405 * All other trace types using preallocated hash maps are unsafe as
9406 * well because tracepoint or kprobes can be inside locked regions
9407 * of the memory allocator or at a place where a recursion into the
9408 * memory allocator would see inconsistent state.
9409 *
2ed905c5
TG
9410 * On RT enabled kernels run-time allocation of all trace type
9411 * programs is strictly prohibited due to lock type constraints. On
9412 * !RT kernels it is allowed for backwards compatibility reasons for
9413 * now, but warnings are emitted so developers are made aware of
9414 * the unsafety and can fix their programs before this is enforced.
56f668df 9415 */
7e40781c
UP
9416 if (is_tracing_prog_type(prog_type) && !is_preallocated_map(map)) {
9417 if (prog_type == BPF_PROG_TYPE_PERF_EVENT) {
61bd5218 9418 verbose(env, "perf_event programs can only use preallocated hash map\n");
56f668df
MKL
9419 return -EINVAL;
9420 }
2ed905c5
TG
9421 if (IS_ENABLED(CONFIG_PREEMPT_RT)) {
9422 verbose(env, "trace type programs can only use preallocated hash map\n");
9423 return -EINVAL;
9424 }
94dacdbd
TG
9425 WARN_ONCE(1, "trace type BPF program uses run-time allocation\n");
9426 verbose(env, "trace type programs with run-time allocated hash maps are unsafe. Switch to preallocated hash maps.\n");
fdc15d38 9427 }
a3884572 9428
7e40781c
UP
9429 if ((is_tracing_prog_type(prog_type) ||
9430 prog_type == BPF_PROG_TYPE_SOCKET_FILTER) &&
d83525ca
AS
9431 map_value_has_spin_lock(map)) {
9432 verbose(env, "tracing progs cannot use bpf_spin_lock yet\n");
9433 return -EINVAL;
9434 }
9435
a3884572 9436 if ((bpf_prog_is_dev_bound(prog->aux) || bpf_map_is_dev_bound(map)) &&
09728266 9437 !bpf_offload_prog_map_match(prog, map)) {
a3884572
JK
9438 verbose(env, "offload device mismatch between prog and map\n");
9439 return -EINVAL;
9440 }
9441
85d33df3
MKL
9442 if (map->map_type == BPF_MAP_TYPE_STRUCT_OPS) {
9443 verbose(env, "bpf_struct_ops map cannot be used in prog\n");
9444 return -EINVAL;
9445 }
9446
1e6c62a8
AS
9447 if (prog->aux->sleepable)
9448 switch (map->map_type) {
9449 case BPF_MAP_TYPE_HASH:
9450 case BPF_MAP_TYPE_LRU_HASH:
9451 case BPF_MAP_TYPE_ARRAY:
9452 if (!is_preallocated_map(map)) {
9453 verbose(env,
9454 "Sleepable programs can only use preallocated hash maps\n");
9455 return -EINVAL;
9456 }
9457 break;
9458 default:
9459 verbose(env,
9460 "Sleepable programs can only use array and hash maps\n");
9461 return -EINVAL;
9462 }
9463
fdc15d38
AS
9464 return 0;
9465}
9466
b741f163
RG
9467static bool bpf_map_is_cgroup_storage(struct bpf_map *map)
9468{
9469 return (map->map_type == BPF_MAP_TYPE_CGROUP_STORAGE ||
9470 map->map_type == BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE);
9471}
9472
0246e64d
AS
9473/* look for pseudo eBPF instructions that access map FDs and
9474 * replace them with actual map pointers
9475 */
58e2af8b 9476static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
0246e64d
AS
9477{
9478 struct bpf_insn *insn = env->prog->insnsi;
9479 int insn_cnt = env->prog->len;
fdc15d38 9480 int i, j, err;
0246e64d 9481
f1f7714e 9482 err = bpf_prog_calc_tag(env->prog);
aafe6ae9
DB
9483 if (err)
9484 return err;
9485
0246e64d 9486 for (i = 0; i < insn_cnt; i++, insn++) {
9bac3d6d 9487 if (BPF_CLASS(insn->code) == BPF_LDX &&
d691f9e8 9488 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
61bd5218 9489 verbose(env, "BPF_LDX uses reserved fields\n");
9bac3d6d
AS
9490 return -EINVAL;
9491 }
9492
d691f9e8
AS
9493 if (BPF_CLASS(insn->code) == BPF_STX &&
9494 ((BPF_MODE(insn->code) != BPF_MEM &&
9495 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
61bd5218 9496 verbose(env, "BPF_STX uses reserved fields\n");
d691f9e8
AS
9497 return -EINVAL;
9498 }
9499
0246e64d 9500 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
d8eca5bb 9501 struct bpf_insn_aux_data *aux;
0246e64d
AS
9502 struct bpf_map *map;
9503 struct fd f;
d8eca5bb 9504 u64 addr;
0246e64d
AS
9505
9506 if (i == insn_cnt - 1 || insn[1].code != 0 ||
9507 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
9508 insn[1].off != 0) {
61bd5218 9509 verbose(env, "invalid bpf_ld_imm64 insn\n");
0246e64d
AS
9510 return -EINVAL;
9511 }
9512
d8eca5bb 9513 if (insn[0].src_reg == 0)
0246e64d
AS
9514 /* valid generic load 64-bit imm */
9515 goto next_insn;
9516
d8eca5bb
DB
9517 /* In final convert_pseudo_ld_imm64() step, this is
9518 * converted into regular 64-bit imm load insn.
9519 */
9520 if ((insn[0].src_reg != BPF_PSEUDO_MAP_FD &&
9521 insn[0].src_reg != BPF_PSEUDO_MAP_VALUE) ||
9522 (insn[0].src_reg == BPF_PSEUDO_MAP_FD &&
9523 insn[1].imm != 0)) {
9524 verbose(env,
9525 "unrecognized bpf_ld_imm64 insn\n");
0246e64d
AS
9526 return -EINVAL;
9527 }
9528
20182390 9529 f = fdget(insn[0].imm);
c2101297 9530 map = __bpf_map_get(f);
0246e64d 9531 if (IS_ERR(map)) {
61bd5218 9532 verbose(env, "fd %d is not pointing to valid bpf_map\n",
20182390 9533 insn[0].imm);
0246e64d
AS
9534 return PTR_ERR(map);
9535 }
9536
61bd5218 9537 err = check_map_prog_compatibility(env, map, env->prog);
fdc15d38
AS
9538 if (err) {
9539 fdput(f);
9540 return err;
9541 }
9542
d8eca5bb
DB
9543 aux = &env->insn_aux_data[i];
9544 if (insn->src_reg == BPF_PSEUDO_MAP_FD) {
9545 addr = (unsigned long)map;
9546 } else {
9547 u32 off = insn[1].imm;
9548
9549 if (off >= BPF_MAX_VAR_OFF) {
9550 verbose(env, "direct value offset of %u is not allowed\n", off);
9551 fdput(f);
9552 return -EINVAL;
9553 }
9554
9555 if (!map->ops->map_direct_value_addr) {
9556 verbose(env, "no direct value access support for this map type\n");
9557 fdput(f);
9558 return -EINVAL;
9559 }
9560
9561 err = map->ops->map_direct_value_addr(map, &addr, off);
9562 if (err) {
9563 verbose(env, "invalid access to map value pointer, value_size=%u off=%u\n",
9564 map->value_size, off);
9565 fdput(f);
9566 return err;
9567 }
9568
9569 aux->map_off = off;
9570 addr += off;
9571 }
9572
9573 insn[0].imm = (u32)addr;
9574 insn[1].imm = addr >> 32;
0246e64d
AS
9575
9576 /* check whether we recorded this map already */
d8eca5bb 9577 for (j = 0; j < env->used_map_cnt; j++) {
0246e64d 9578 if (env->used_maps[j] == map) {
d8eca5bb 9579 aux->map_index = j;
0246e64d
AS
9580 fdput(f);
9581 goto next_insn;
9582 }
d8eca5bb 9583 }
0246e64d
AS
9584
9585 if (env->used_map_cnt >= MAX_USED_MAPS) {
9586 fdput(f);
9587 return -E2BIG;
9588 }
9589
0246e64d
AS
9590 /* hold the map. If the program is rejected by verifier,
9591 * the map will be released by release_maps() or it
9592 * will be used by the valid program until it's unloaded
ab7f5bf0 9593 * and all maps are released in free_used_maps()
0246e64d 9594 */
1e0bd5a0 9595 bpf_map_inc(map);
d8eca5bb
DB
9596
9597 aux->map_index = env->used_map_cnt;
92117d84
AS
9598 env->used_maps[env->used_map_cnt++] = map;
9599
b741f163 9600 if (bpf_map_is_cgroup_storage(map) &&
e4730423 9601 bpf_cgroup_storage_assign(env->prog->aux, map)) {
b741f163 9602 verbose(env, "only one cgroup storage of each type is allowed\n");
de9cbbaa
RG
9603 fdput(f);
9604 return -EBUSY;
9605 }
9606
0246e64d
AS
9607 fdput(f);
9608next_insn:
9609 insn++;
9610 i++;
5e581dad
DB
9611 continue;
9612 }
9613
9614 /* Basic sanity check before we invest more work here. */
9615 if (!bpf_opcode_in_insntable(insn->code)) {
9616 verbose(env, "unknown opcode %02x\n", insn->code);
9617 return -EINVAL;
0246e64d
AS
9618 }
9619 }
9620
9621 /* now all pseudo BPF_LD_IMM64 instructions load valid
9622 * 'struct bpf_map *' into a register instead of user map_fd.
9623 * These pointers will be used later by verifier to validate map access.
9624 */
9625 return 0;
9626}
9627
9628/* drop refcnt of maps used by the rejected program */
58e2af8b 9629static void release_maps(struct bpf_verifier_env *env)
0246e64d 9630{
a2ea0746
DB
9631 __bpf_free_used_maps(env->prog->aux, env->used_maps,
9632 env->used_map_cnt);
0246e64d
AS
9633}
9634
9635/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
58e2af8b 9636static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
0246e64d
AS
9637{
9638 struct bpf_insn *insn = env->prog->insnsi;
9639 int insn_cnt = env->prog->len;
9640 int i;
9641
9642 for (i = 0; i < insn_cnt; i++, insn++)
9643 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
9644 insn->src_reg = 0;
9645}
9646
8041902d
AS
9647/* single env->prog->insni[off] instruction was replaced with the range
9648 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
9649 * [0, off) and [off, end) to new locations, so the patched range stays zero
9650 */
b325fbca
JW
9651static int adjust_insn_aux_data(struct bpf_verifier_env *env,
9652 struct bpf_prog *new_prog, u32 off, u32 cnt)
8041902d
AS
9653{
9654 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
b325fbca
JW
9655 struct bpf_insn *insn = new_prog->insnsi;
9656 u32 prog_len;
c131187d 9657 int i;
8041902d 9658
b325fbca
JW
9659 /* aux info at OFF always needs adjustment, no matter fast path
9660 * (cnt == 1) is taken or not. There is no guarantee INSN at OFF is the
9661 * original insn at old prog.
9662 */
9663 old_data[off].zext_dst = insn_has_def32(env, insn + off + cnt - 1);
9664
8041902d
AS
9665 if (cnt == 1)
9666 return 0;
b325fbca 9667 prog_len = new_prog->len;
fad953ce
KC
9668 new_data = vzalloc(array_size(prog_len,
9669 sizeof(struct bpf_insn_aux_data)));
8041902d
AS
9670 if (!new_data)
9671 return -ENOMEM;
9672 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
9673 memcpy(new_data + off + cnt - 1, old_data + off,
9674 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
b325fbca 9675 for (i = off; i < off + cnt - 1; i++) {
51c39bb1 9676 new_data[i].seen = env->pass_cnt;
b325fbca
JW
9677 new_data[i].zext_dst = insn_has_def32(env, insn + i);
9678 }
8041902d
AS
9679 env->insn_aux_data = new_data;
9680 vfree(old_data);
9681 return 0;
9682}
9683
cc8b0b92
AS
9684static void adjust_subprog_starts(struct bpf_verifier_env *env, u32 off, u32 len)
9685{
9686 int i;
9687
9688 if (len == 1)
9689 return;
4cb3d99c
JW
9690 /* NOTE: fake 'exit' subprog should be updated as well. */
9691 for (i = 0; i <= env->subprog_cnt; i++) {
afd59424 9692 if (env->subprog_info[i].start <= off)
cc8b0b92 9693 continue;
9c8105bd 9694 env->subprog_info[i].start += len - 1;
cc8b0b92
AS
9695 }
9696}
9697
a748c697
MF
9698static void adjust_poke_descs(struct bpf_prog *prog, u32 len)
9699{
9700 struct bpf_jit_poke_descriptor *tab = prog->aux->poke_tab;
9701 int i, sz = prog->aux->size_poke_tab;
9702 struct bpf_jit_poke_descriptor *desc;
9703
9704 for (i = 0; i < sz; i++) {
9705 desc = &tab[i];
9706 desc->insn_idx += len - 1;
9707 }
9708}
9709
8041902d
AS
9710static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
9711 const struct bpf_insn *patch, u32 len)
9712{
9713 struct bpf_prog *new_prog;
9714
9715 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
4f73379e
AS
9716 if (IS_ERR(new_prog)) {
9717 if (PTR_ERR(new_prog) == -ERANGE)
9718 verbose(env,
9719 "insn %d cannot be patched due to 16-bit range\n",
9720 env->insn_aux_data[off].orig_idx);
8041902d 9721 return NULL;
4f73379e 9722 }
b325fbca 9723 if (adjust_insn_aux_data(env, new_prog, off, len))
8041902d 9724 return NULL;
cc8b0b92 9725 adjust_subprog_starts(env, off, len);
a748c697 9726 adjust_poke_descs(new_prog, len);
8041902d
AS
9727 return new_prog;
9728}
9729
52875a04
JK
9730static int adjust_subprog_starts_after_remove(struct bpf_verifier_env *env,
9731 u32 off, u32 cnt)
9732{
9733 int i, j;
9734
9735 /* find first prog starting at or after off (first to remove) */
9736 for (i = 0; i < env->subprog_cnt; i++)
9737 if (env->subprog_info[i].start >= off)
9738 break;
9739 /* find first prog starting at or after off + cnt (first to stay) */
9740 for (j = i; j < env->subprog_cnt; j++)
9741 if (env->subprog_info[j].start >= off + cnt)
9742 break;
9743 /* if j doesn't start exactly at off + cnt, we are just removing
9744 * the front of previous prog
9745 */
9746 if (env->subprog_info[j].start != off + cnt)
9747 j--;
9748
9749 if (j > i) {
9750 struct bpf_prog_aux *aux = env->prog->aux;
9751 int move;
9752
9753 /* move fake 'exit' subprog as well */
9754 move = env->subprog_cnt + 1 - j;
9755
9756 memmove(env->subprog_info + i,
9757 env->subprog_info + j,
9758 sizeof(*env->subprog_info) * move);
9759 env->subprog_cnt -= j - i;
9760
9761 /* remove func_info */
9762 if (aux->func_info) {
9763 move = aux->func_info_cnt - j;
9764
9765 memmove(aux->func_info + i,
9766 aux->func_info + j,
9767 sizeof(*aux->func_info) * move);
9768 aux->func_info_cnt -= j - i;
9769 /* func_info->insn_off is set after all code rewrites,
9770 * in adjust_btf_func() - no need to adjust
9771 */
9772 }
9773 } else {
9774 /* convert i from "first prog to remove" to "first to adjust" */
9775 if (env->subprog_info[i].start == off)
9776 i++;
9777 }
9778
9779 /* update fake 'exit' subprog as well */
9780 for (; i <= env->subprog_cnt; i++)
9781 env->subprog_info[i].start -= cnt;
9782
9783 return 0;
9784}
9785
9786static int bpf_adj_linfo_after_remove(struct bpf_verifier_env *env, u32 off,
9787 u32 cnt)
9788{
9789 struct bpf_prog *prog = env->prog;
9790 u32 i, l_off, l_cnt, nr_linfo;
9791 struct bpf_line_info *linfo;
9792
9793 nr_linfo = prog->aux->nr_linfo;
9794 if (!nr_linfo)
9795 return 0;
9796
9797 linfo = prog->aux->linfo;
9798
9799 /* find first line info to remove, count lines to be removed */
9800 for (i = 0; i < nr_linfo; i++)
9801 if (linfo[i].insn_off >= off)
9802 break;
9803
9804 l_off = i;
9805 l_cnt = 0;
9806 for (; i < nr_linfo; i++)
9807 if (linfo[i].insn_off < off + cnt)
9808 l_cnt++;
9809 else
9810 break;
9811
9812 /* First live insn doesn't match first live linfo, it needs to "inherit"
9813 * last removed linfo. prog is already modified, so prog->len == off
9814 * means no live instructions after (tail of the program was removed).
9815 */
9816 if (prog->len != off && l_cnt &&
9817 (i == nr_linfo || linfo[i].insn_off != off + cnt)) {
9818 l_cnt--;
9819 linfo[--i].insn_off = off + cnt;
9820 }
9821
9822 /* remove the line info which refer to the removed instructions */
9823 if (l_cnt) {
9824 memmove(linfo + l_off, linfo + i,
9825 sizeof(*linfo) * (nr_linfo - i));
9826
9827 prog->aux->nr_linfo -= l_cnt;
9828 nr_linfo = prog->aux->nr_linfo;
9829 }
9830
9831 /* pull all linfo[i].insn_off >= off + cnt in by cnt */
9832 for (i = l_off; i < nr_linfo; i++)
9833 linfo[i].insn_off -= cnt;
9834
9835 /* fix up all subprogs (incl. 'exit') which start >= off */
9836 for (i = 0; i <= env->subprog_cnt; i++)
9837 if (env->subprog_info[i].linfo_idx > l_off) {
9838 /* program may have started in the removed region but
9839 * may not be fully removed
9840 */
9841 if (env->subprog_info[i].linfo_idx >= l_off + l_cnt)
9842 env->subprog_info[i].linfo_idx -= l_cnt;
9843 else
9844 env->subprog_info[i].linfo_idx = l_off;
9845 }
9846
9847 return 0;
9848}
9849
9850static int verifier_remove_insns(struct bpf_verifier_env *env, u32 off, u32 cnt)
9851{
9852 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
9853 unsigned int orig_prog_len = env->prog->len;
9854 int err;
9855
08ca90af
JK
9856 if (bpf_prog_is_dev_bound(env->prog->aux))
9857 bpf_prog_offload_remove_insns(env, off, cnt);
9858
52875a04
JK
9859 err = bpf_remove_insns(env->prog, off, cnt);
9860 if (err)
9861 return err;
9862
9863 err = adjust_subprog_starts_after_remove(env, off, cnt);
9864 if (err)
9865 return err;
9866
9867 err = bpf_adj_linfo_after_remove(env, off, cnt);
9868 if (err)
9869 return err;
9870
9871 memmove(aux_data + off, aux_data + off + cnt,
9872 sizeof(*aux_data) * (orig_prog_len - off - cnt));
9873
9874 return 0;
9875}
9876
2a5418a1
DB
9877/* The verifier does more data flow analysis than llvm and will not
9878 * explore branches that are dead at run time. Malicious programs can
9879 * have dead code too. Therefore replace all dead at-run-time code
9880 * with 'ja -1'.
9881 *
9882 * Just nops are not optimal, e.g. if they would sit at the end of the
9883 * program and through another bug we would manage to jump there, then
9884 * we'd execute beyond program memory otherwise. Returning exception
9885 * code also wouldn't work since we can have subprogs where the dead
9886 * code could be located.
c131187d
AS
9887 */
9888static void sanitize_dead_code(struct bpf_verifier_env *env)
9889{
9890 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
2a5418a1 9891 struct bpf_insn trap = BPF_JMP_IMM(BPF_JA, 0, 0, -1);
c131187d
AS
9892 struct bpf_insn *insn = env->prog->insnsi;
9893 const int insn_cnt = env->prog->len;
9894 int i;
9895
9896 for (i = 0; i < insn_cnt; i++) {
9897 if (aux_data[i].seen)
9898 continue;
2a5418a1 9899 memcpy(insn + i, &trap, sizeof(trap));
c131187d
AS
9900 }
9901}
9902
e2ae4ca2
JK
9903static bool insn_is_cond_jump(u8 code)
9904{
9905 u8 op;
9906
092ed096
JW
9907 if (BPF_CLASS(code) == BPF_JMP32)
9908 return true;
9909
e2ae4ca2
JK
9910 if (BPF_CLASS(code) != BPF_JMP)
9911 return false;
9912
9913 op = BPF_OP(code);
9914 return op != BPF_JA && op != BPF_EXIT && op != BPF_CALL;
9915}
9916
9917static void opt_hard_wire_dead_code_branches(struct bpf_verifier_env *env)
9918{
9919 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
9920 struct bpf_insn ja = BPF_JMP_IMM(BPF_JA, 0, 0, 0);
9921 struct bpf_insn *insn = env->prog->insnsi;
9922 const int insn_cnt = env->prog->len;
9923 int i;
9924
9925 for (i = 0; i < insn_cnt; i++, insn++) {
9926 if (!insn_is_cond_jump(insn->code))
9927 continue;
9928
9929 if (!aux_data[i + 1].seen)
9930 ja.off = insn->off;
9931 else if (!aux_data[i + 1 + insn->off].seen)
9932 ja.off = 0;
9933 else
9934 continue;
9935
08ca90af
JK
9936 if (bpf_prog_is_dev_bound(env->prog->aux))
9937 bpf_prog_offload_replace_insn(env, i, &ja);
9938
e2ae4ca2
JK
9939 memcpy(insn, &ja, sizeof(ja));
9940 }
9941}
9942
52875a04
JK
9943static int opt_remove_dead_code(struct bpf_verifier_env *env)
9944{
9945 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
9946 int insn_cnt = env->prog->len;
9947 int i, err;
9948
9949 for (i = 0; i < insn_cnt; i++) {
9950 int j;
9951
9952 j = 0;
9953 while (i + j < insn_cnt && !aux_data[i + j].seen)
9954 j++;
9955 if (!j)
9956 continue;
9957
9958 err = verifier_remove_insns(env, i, j);
9959 if (err)
9960 return err;
9961 insn_cnt = env->prog->len;
9962 }
9963
9964 return 0;
9965}
9966
a1b14abc
JK
9967static int opt_remove_nops(struct bpf_verifier_env *env)
9968{
9969 const struct bpf_insn ja = BPF_JMP_IMM(BPF_JA, 0, 0, 0);
9970 struct bpf_insn *insn = env->prog->insnsi;
9971 int insn_cnt = env->prog->len;
9972 int i, err;
9973
9974 for (i = 0; i < insn_cnt; i++) {
9975 if (memcmp(&insn[i], &ja, sizeof(ja)))
9976 continue;
9977
9978 err = verifier_remove_insns(env, i, 1);
9979 if (err)
9980 return err;
9981 insn_cnt--;
9982 i--;
9983 }
9984
9985 return 0;
9986}
9987
d6c2308c
JW
9988static int opt_subreg_zext_lo32_rnd_hi32(struct bpf_verifier_env *env,
9989 const union bpf_attr *attr)
a4b1d3c1 9990{
d6c2308c 9991 struct bpf_insn *patch, zext_patch[2], rnd_hi32_patch[4];
a4b1d3c1 9992 struct bpf_insn_aux_data *aux = env->insn_aux_data;
d6c2308c 9993 int i, patch_len, delta = 0, len = env->prog->len;
a4b1d3c1 9994 struct bpf_insn *insns = env->prog->insnsi;
a4b1d3c1 9995 struct bpf_prog *new_prog;
d6c2308c 9996 bool rnd_hi32;
a4b1d3c1 9997
d6c2308c 9998 rnd_hi32 = attr->prog_flags & BPF_F_TEST_RND_HI32;
a4b1d3c1 9999 zext_patch[1] = BPF_ZEXT_REG(0);
d6c2308c
JW
10000 rnd_hi32_patch[1] = BPF_ALU64_IMM(BPF_MOV, BPF_REG_AX, 0);
10001 rnd_hi32_patch[2] = BPF_ALU64_IMM(BPF_LSH, BPF_REG_AX, 32);
10002 rnd_hi32_patch[3] = BPF_ALU64_REG(BPF_OR, 0, BPF_REG_AX);
a4b1d3c1
JW
10003 for (i = 0; i < len; i++) {
10004 int adj_idx = i + delta;
10005 struct bpf_insn insn;
10006
d6c2308c
JW
10007 insn = insns[adj_idx];
10008 if (!aux[adj_idx].zext_dst) {
10009 u8 code, class;
10010 u32 imm_rnd;
10011
10012 if (!rnd_hi32)
10013 continue;
10014
10015 code = insn.code;
10016 class = BPF_CLASS(code);
10017 if (insn_no_def(&insn))
10018 continue;
10019
10020 /* NOTE: arg "reg" (the fourth one) is only used for
10021 * BPF_STX which has been ruled out in above
10022 * check, it is safe to pass NULL here.
10023 */
10024 if (is_reg64(env, &insn, insn.dst_reg, NULL, DST_OP)) {
10025 if (class == BPF_LD &&
10026 BPF_MODE(code) == BPF_IMM)
10027 i++;
10028 continue;
10029 }
10030
10031 /* ctx load could be transformed into wider load. */
10032 if (class == BPF_LDX &&
10033 aux[adj_idx].ptr_type == PTR_TO_CTX)
10034 continue;
10035
10036 imm_rnd = get_random_int();
10037 rnd_hi32_patch[0] = insn;
10038 rnd_hi32_patch[1].imm = imm_rnd;
10039 rnd_hi32_patch[3].dst_reg = insn.dst_reg;
10040 patch = rnd_hi32_patch;
10041 patch_len = 4;
10042 goto apply_patch_buffer;
10043 }
10044
10045 if (!bpf_jit_needs_zext())
a4b1d3c1
JW
10046 continue;
10047
a4b1d3c1
JW
10048 zext_patch[0] = insn;
10049 zext_patch[1].dst_reg = insn.dst_reg;
10050 zext_patch[1].src_reg = insn.dst_reg;
d6c2308c
JW
10051 patch = zext_patch;
10052 patch_len = 2;
10053apply_patch_buffer:
10054 new_prog = bpf_patch_insn_data(env, adj_idx, patch, patch_len);
a4b1d3c1
JW
10055 if (!new_prog)
10056 return -ENOMEM;
10057 env->prog = new_prog;
10058 insns = new_prog->insnsi;
10059 aux = env->insn_aux_data;
d6c2308c 10060 delta += patch_len - 1;
a4b1d3c1
JW
10061 }
10062
10063 return 0;
10064}
10065
c64b7983
JS
10066/* convert load instructions that access fields of a context type into a
10067 * sequence of instructions that access fields of the underlying structure:
10068 * struct __sk_buff -> struct sk_buff
10069 * struct bpf_sock_ops -> struct sock
9bac3d6d 10070 */
58e2af8b 10071static int convert_ctx_accesses(struct bpf_verifier_env *env)
9bac3d6d 10072{
00176a34 10073 const struct bpf_verifier_ops *ops = env->ops;
f96da094 10074 int i, cnt, size, ctx_field_size, delta = 0;
3df126f3 10075 const int insn_cnt = env->prog->len;
36bbef52 10076 struct bpf_insn insn_buf[16], *insn;
46f53a65 10077 u32 target_size, size_default, off;
9bac3d6d 10078 struct bpf_prog *new_prog;
d691f9e8 10079 enum bpf_access_type type;
f96da094 10080 bool is_narrower_load;
9bac3d6d 10081
b09928b9
DB
10082 if (ops->gen_prologue || env->seen_direct_write) {
10083 if (!ops->gen_prologue) {
10084 verbose(env, "bpf verifier is misconfigured\n");
10085 return -EINVAL;
10086 }
36bbef52
DB
10087 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
10088 env->prog);
10089 if (cnt >= ARRAY_SIZE(insn_buf)) {
61bd5218 10090 verbose(env, "bpf verifier is misconfigured\n");
36bbef52
DB
10091 return -EINVAL;
10092 } else if (cnt) {
8041902d 10093 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
36bbef52
DB
10094 if (!new_prog)
10095 return -ENOMEM;
8041902d 10096
36bbef52 10097 env->prog = new_prog;
3df126f3 10098 delta += cnt - 1;
36bbef52
DB
10099 }
10100 }
10101
c64b7983 10102 if (bpf_prog_is_dev_bound(env->prog->aux))
9bac3d6d
AS
10103 return 0;
10104
3df126f3 10105 insn = env->prog->insnsi + delta;
36bbef52 10106
9bac3d6d 10107 for (i = 0; i < insn_cnt; i++, insn++) {
c64b7983
JS
10108 bpf_convert_ctx_access_t convert_ctx_access;
10109
62c7989b
DB
10110 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
10111 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
10112 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
ea2e7ce5 10113 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
d691f9e8 10114 type = BPF_READ;
62c7989b
DB
10115 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
10116 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
10117 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
ea2e7ce5 10118 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
d691f9e8
AS
10119 type = BPF_WRITE;
10120 else
9bac3d6d
AS
10121 continue;
10122
af86ca4e
AS
10123 if (type == BPF_WRITE &&
10124 env->insn_aux_data[i + delta].sanitize_stack_off) {
10125 struct bpf_insn patch[] = {
10126 /* Sanitize suspicious stack slot with zero.
10127 * There are no memory dependencies for this store,
10128 * since it's only using frame pointer and immediate
10129 * constant of zero
10130 */
10131 BPF_ST_MEM(BPF_DW, BPF_REG_FP,
10132 env->insn_aux_data[i + delta].sanitize_stack_off,
10133 0),
10134 /* the original STX instruction will immediately
10135 * overwrite the same stack slot with appropriate value
10136 */
10137 *insn,
10138 };
10139
10140 cnt = ARRAY_SIZE(patch);
10141 new_prog = bpf_patch_insn_data(env, i + delta, patch, cnt);
10142 if (!new_prog)
10143 return -ENOMEM;
10144
10145 delta += cnt - 1;
10146 env->prog = new_prog;
10147 insn = new_prog->insnsi + i + delta;
10148 continue;
10149 }
10150
c64b7983
JS
10151 switch (env->insn_aux_data[i + delta].ptr_type) {
10152 case PTR_TO_CTX:
10153 if (!ops->convert_ctx_access)
10154 continue;
10155 convert_ctx_access = ops->convert_ctx_access;
10156 break;
10157 case PTR_TO_SOCKET:
46f8bc92 10158 case PTR_TO_SOCK_COMMON:
c64b7983
JS
10159 convert_ctx_access = bpf_sock_convert_ctx_access;
10160 break;
655a51e5
MKL
10161 case PTR_TO_TCP_SOCK:
10162 convert_ctx_access = bpf_tcp_sock_convert_ctx_access;
10163 break;
fada7fdc
JL
10164 case PTR_TO_XDP_SOCK:
10165 convert_ctx_access = bpf_xdp_sock_convert_ctx_access;
10166 break;
2a02759e 10167 case PTR_TO_BTF_ID:
27ae7997
MKL
10168 if (type == BPF_READ) {
10169 insn->code = BPF_LDX | BPF_PROBE_MEM |
10170 BPF_SIZE((insn)->code);
10171 env->prog->aux->num_exentries++;
7e40781c 10172 } else if (resolve_prog_type(env->prog) != BPF_PROG_TYPE_STRUCT_OPS) {
2a02759e
AS
10173 verbose(env, "Writes through BTF pointers are not allowed\n");
10174 return -EINVAL;
10175 }
2a02759e 10176 continue;
c64b7983 10177 default:
9bac3d6d 10178 continue;
c64b7983 10179 }
9bac3d6d 10180
31fd8581 10181 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
f96da094 10182 size = BPF_LDST_BYTES(insn);
31fd8581
YS
10183
10184 /* If the read access is a narrower load of the field,
10185 * convert to a 4/8-byte load, to minimum program type specific
10186 * convert_ctx_access changes. If conversion is successful,
10187 * we will apply proper mask to the result.
10188 */
f96da094 10189 is_narrower_load = size < ctx_field_size;
46f53a65
AI
10190 size_default = bpf_ctx_off_adjust_machine(ctx_field_size);
10191 off = insn->off;
31fd8581 10192 if (is_narrower_load) {
f96da094
DB
10193 u8 size_code;
10194
10195 if (type == BPF_WRITE) {
61bd5218 10196 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
f96da094
DB
10197 return -EINVAL;
10198 }
31fd8581 10199
f96da094 10200 size_code = BPF_H;
31fd8581
YS
10201 if (ctx_field_size == 4)
10202 size_code = BPF_W;
10203 else if (ctx_field_size == 8)
10204 size_code = BPF_DW;
f96da094 10205
bc23105c 10206 insn->off = off & ~(size_default - 1);
31fd8581
YS
10207 insn->code = BPF_LDX | BPF_MEM | size_code;
10208 }
f96da094
DB
10209
10210 target_size = 0;
c64b7983
JS
10211 cnt = convert_ctx_access(type, insn, insn_buf, env->prog,
10212 &target_size);
f96da094
DB
10213 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
10214 (ctx_field_size && !target_size)) {
61bd5218 10215 verbose(env, "bpf verifier is misconfigured\n");
9bac3d6d
AS
10216 return -EINVAL;
10217 }
f96da094
DB
10218
10219 if (is_narrower_load && size < target_size) {
d895a0f1
IL
10220 u8 shift = bpf_ctx_narrow_access_offset(
10221 off, size, size_default) * 8;
46f53a65
AI
10222 if (ctx_field_size <= 4) {
10223 if (shift)
10224 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_RSH,
10225 insn->dst_reg,
10226 shift);
31fd8581 10227 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
f96da094 10228 (1 << size * 8) - 1);
46f53a65
AI
10229 } else {
10230 if (shift)
10231 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_RSH,
10232 insn->dst_reg,
10233 shift);
31fd8581 10234 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
e2f7fc0a 10235 (1ULL << size * 8) - 1);
46f53a65 10236 }
31fd8581 10237 }
9bac3d6d 10238
8041902d 10239 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
9bac3d6d
AS
10240 if (!new_prog)
10241 return -ENOMEM;
10242
3df126f3 10243 delta += cnt - 1;
9bac3d6d
AS
10244
10245 /* keep walking new program and skip insns we just inserted */
10246 env->prog = new_prog;
3df126f3 10247 insn = new_prog->insnsi + i + delta;
9bac3d6d
AS
10248 }
10249
10250 return 0;
10251}
10252
1c2a088a
AS
10253static int jit_subprogs(struct bpf_verifier_env *env)
10254{
10255 struct bpf_prog *prog = env->prog, **func, *tmp;
10256 int i, j, subprog_start, subprog_end = 0, len, subprog;
a748c697 10257 struct bpf_map *map_ptr;
7105e828 10258 struct bpf_insn *insn;
1c2a088a 10259 void *old_bpf_func;
c4c0bdc0 10260 int err, num_exentries;
1c2a088a 10261
f910cefa 10262 if (env->subprog_cnt <= 1)
1c2a088a
AS
10263 return 0;
10264
7105e828 10265 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
1c2a088a
AS
10266 if (insn->code != (BPF_JMP | BPF_CALL) ||
10267 insn->src_reg != BPF_PSEUDO_CALL)
10268 continue;
c7a89784
DB
10269 /* Upon error here we cannot fall back to interpreter but
10270 * need a hard reject of the program. Thus -EFAULT is
10271 * propagated in any case.
10272 */
1c2a088a
AS
10273 subprog = find_subprog(env, i + insn->imm + 1);
10274 if (subprog < 0) {
10275 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
10276 i + insn->imm + 1);
10277 return -EFAULT;
10278 }
10279 /* temporarily remember subprog id inside insn instead of
10280 * aux_data, since next loop will split up all insns into funcs
10281 */
f910cefa 10282 insn->off = subprog;
1c2a088a
AS
10283 /* remember original imm in case JIT fails and fallback
10284 * to interpreter will be needed
10285 */
10286 env->insn_aux_data[i].call_imm = insn->imm;
10287 /* point imm to __bpf_call_base+1 from JITs point of view */
10288 insn->imm = 1;
10289 }
10290
c454a46b
MKL
10291 err = bpf_prog_alloc_jited_linfo(prog);
10292 if (err)
10293 goto out_undo_insn;
10294
10295 err = -ENOMEM;
6396bb22 10296 func = kcalloc(env->subprog_cnt, sizeof(prog), GFP_KERNEL);
1c2a088a 10297 if (!func)
c7a89784 10298 goto out_undo_insn;
1c2a088a 10299
f910cefa 10300 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a 10301 subprog_start = subprog_end;
4cb3d99c 10302 subprog_end = env->subprog_info[i + 1].start;
1c2a088a
AS
10303
10304 len = subprog_end - subprog_start;
492ecee8
AS
10305 /* BPF_PROG_RUN doesn't call subprogs directly,
10306 * hence main prog stats include the runtime of subprogs.
10307 * subprogs don't have IDs and not reachable via prog_get_next_id
10308 * func[i]->aux->stats will never be accessed and stays NULL
10309 */
10310 func[i] = bpf_prog_alloc_no_stats(bpf_prog_size(len), GFP_USER);
1c2a088a
AS
10311 if (!func[i])
10312 goto out_free;
10313 memcpy(func[i]->insnsi, &prog->insnsi[subprog_start],
10314 len * sizeof(struct bpf_insn));
4f74d809 10315 func[i]->type = prog->type;
1c2a088a 10316 func[i]->len = len;
4f74d809
DB
10317 if (bpf_prog_calc_tag(func[i]))
10318 goto out_free;
1c2a088a 10319 func[i]->is_func = 1;
ba64e7d8
YS
10320 func[i]->aux->func_idx = i;
10321 /* the btf and func_info will be freed only at prog->aux */
10322 func[i]->aux->btf = prog->aux->btf;
10323 func[i]->aux->func_info = prog->aux->func_info;
10324
a748c697
MF
10325 for (j = 0; j < prog->aux->size_poke_tab; j++) {
10326 u32 insn_idx = prog->aux->poke_tab[j].insn_idx;
10327 int ret;
10328
10329 if (!(insn_idx >= subprog_start &&
10330 insn_idx <= subprog_end))
10331 continue;
10332
10333 ret = bpf_jit_add_poke_descriptor(func[i],
10334 &prog->aux->poke_tab[j]);
10335 if (ret < 0) {
10336 verbose(env, "adding tail call poke descriptor failed\n");
10337 goto out_free;
10338 }
10339
10340 func[i]->insnsi[insn_idx - subprog_start].imm = ret + 1;
10341
10342 map_ptr = func[i]->aux->poke_tab[ret].tail_call.map;
10343 ret = map_ptr->ops->map_poke_track(map_ptr, func[i]->aux);
10344 if (ret < 0) {
10345 verbose(env, "tracking tail call prog failed\n");
10346 goto out_free;
10347 }
10348 }
10349
1c2a088a
AS
10350 /* Use bpf_prog_F_tag to indicate functions in stack traces.
10351 * Long term would need debug info to populate names
10352 */
10353 func[i]->aux->name[0] = 'F';
9c8105bd 10354 func[i]->aux->stack_depth = env->subprog_info[i].stack_depth;
1c2a088a 10355 func[i]->jit_requested = 1;
c454a46b
MKL
10356 func[i]->aux->linfo = prog->aux->linfo;
10357 func[i]->aux->nr_linfo = prog->aux->nr_linfo;
10358 func[i]->aux->jited_linfo = prog->aux->jited_linfo;
10359 func[i]->aux->linfo_idx = env->subprog_info[i].linfo_idx;
c4c0bdc0
YS
10360 num_exentries = 0;
10361 insn = func[i]->insnsi;
10362 for (j = 0; j < func[i]->len; j++, insn++) {
10363 if (BPF_CLASS(insn->code) == BPF_LDX &&
10364 BPF_MODE(insn->code) == BPF_PROBE_MEM)
10365 num_exentries++;
10366 }
10367 func[i]->aux->num_exentries = num_exentries;
ebf7d1f5 10368 func[i]->aux->tail_call_reachable = env->subprog_info[i].tail_call_reachable;
1c2a088a
AS
10369 func[i] = bpf_int_jit_compile(func[i]);
10370 if (!func[i]->jited) {
10371 err = -ENOTSUPP;
10372 goto out_free;
10373 }
10374 cond_resched();
10375 }
a748c697
MF
10376
10377 /* Untrack main program's aux structs so that during map_poke_run()
10378 * we will not stumble upon the unfilled poke descriptors; each
10379 * of the main program's poke descs got distributed across subprogs
10380 * and got tracked onto map, so we are sure that none of them will
10381 * be missed after the operation below
10382 */
10383 for (i = 0; i < prog->aux->size_poke_tab; i++) {
10384 map_ptr = prog->aux->poke_tab[i].tail_call.map;
10385
10386 map_ptr->ops->map_poke_untrack(map_ptr, prog->aux);
10387 }
10388
1c2a088a
AS
10389 /* at this point all bpf functions were successfully JITed
10390 * now populate all bpf_calls with correct addresses and
10391 * run last pass of JIT
10392 */
f910cefa 10393 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
10394 insn = func[i]->insnsi;
10395 for (j = 0; j < func[i]->len; j++, insn++) {
10396 if (insn->code != (BPF_JMP | BPF_CALL) ||
10397 insn->src_reg != BPF_PSEUDO_CALL)
10398 continue;
10399 subprog = insn->off;
0d306c31
PB
10400 insn->imm = BPF_CAST_CALL(func[subprog]->bpf_func) -
10401 __bpf_call_base;
1c2a088a 10402 }
2162fed4
SD
10403
10404 /* we use the aux data to keep a list of the start addresses
10405 * of the JITed images for each function in the program
10406 *
10407 * for some architectures, such as powerpc64, the imm field
10408 * might not be large enough to hold the offset of the start
10409 * address of the callee's JITed image from __bpf_call_base
10410 *
10411 * in such cases, we can lookup the start address of a callee
10412 * by using its subprog id, available from the off field of
10413 * the call instruction, as an index for this list
10414 */
10415 func[i]->aux->func = func;
10416 func[i]->aux->func_cnt = env->subprog_cnt;
1c2a088a 10417 }
f910cefa 10418 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
10419 old_bpf_func = func[i]->bpf_func;
10420 tmp = bpf_int_jit_compile(func[i]);
10421 if (tmp != func[i] || func[i]->bpf_func != old_bpf_func) {
10422 verbose(env, "JIT doesn't support bpf-to-bpf calls\n");
c7a89784 10423 err = -ENOTSUPP;
1c2a088a
AS
10424 goto out_free;
10425 }
10426 cond_resched();
10427 }
10428
10429 /* finally lock prog and jit images for all functions and
10430 * populate kallsysm
10431 */
f910cefa 10432 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
10433 bpf_prog_lock_ro(func[i]);
10434 bpf_prog_kallsyms_add(func[i]);
10435 }
7105e828
DB
10436
10437 /* Last step: make now unused interpreter insns from main
10438 * prog consistent for later dump requests, so they can
10439 * later look the same as if they were interpreted only.
10440 */
10441 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
7105e828
DB
10442 if (insn->code != (BPF_JMP | BPF_CALL) ||
10443 insn->src_reg != BPF_PSEUDO_CALL)
10444 continue;
10445 insn->off = env->insn_aux_data[i].call_imm;
10446 subprog = find_subprog(env, i + insn->off + 1);
dbecd738 10447 insn->imm = subprog;
7105e828
DB
10448 }
10449
1c2a088a
AS
10450 prog->jited = 1;
10451 prog->bpf_func = func[0]->bpf_func;
10452 prog->aux->func = func;
f910cefa 10453 prog->aux->func_cnt = env->subprog_cnt;
c454a46b 10454 bpf_prog_free_unused_jited_linfo(prog);
1c2a088a
AS
10455 return 0;
10456out_free:
a748c697
MF
10457 for (i = 0; i < env->subprog_cnt; i++) {
10458 if (!func[i])
10459 continue;
10460
10461 for (j = 0; j < func[i]->aux->size_poke_tab; j++) {
10462 map_ptr = func[i]->aux->poke_tab[j].tail_call.map;
10463 map_ptr->ops->map_poke_untrack(map_ptr, func[i]->aux);
10464 }
10465 bpf_jit_free(func[i]);
10466 }
1c2a088a 10467 kfree(func);
c7a89784 10468out_undo_insn:
1c2a088a
AS
10469 /* cleanup main prog to be interpreted */
10470 prog->jit_requested = 0;
10471 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
10472 if (insn->code != (BPF_JMP | BPF_CALL) ||
10473 insn->src_reg != BPF_PSEUDO_CALL)
10474 continue;
10475 insn->off = 0;
10476 insn->imm = env->insn_aux_data[i].call_imm;
10477 }
c454a46b 10478 bpf_prog_free_jited_linfo(prog);
1c2a088a
AS
10479 return err;
10480}
10481
1ea47e01
AS
10482static int fixup_call_args(struct bpf_verifier_env *env)
10483{
19d28fbd 10484#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
10485 struct bpf_prog *prog = env->prog;
10486 struct bpf_insn *insn = prog->insnsi;
10487 int i, depth;
19d28fbd 10488#endif
e4052d06 10489 int err = 0;
1ea47e01 10490
e4052d06
QM
10491 if (env->prog->jit_requested &&
10492 !bpf_prog_is_dev_bound(env->prog->aux)) {
19d28fbd
DM
10493 err = jit_subprogs(env);
10494 if (err == 0)
1c2a088a 10495 return 0;
c7a89784
DB
10496 if (err == -EFAULT)
10497 return err;
19d28fbd
DM
10498 }
10499#ifndef CONFIG_BPF_JIT_ALWAYS_ON
e411901c
MF
10500 if (env->subprog_cnt > 1 && env->prog->aux->tail_call_reachable) {
10501 /* When JIT fails the progs with bpf2bpf calls and tail_calls
10502 * have to be rejected, since interpreter doesn't support them yet.
10503 */
10504 verbose(env, "tail_calls are not allowed in non-JITed programs with bpf-to-bpf calls\n");
10505 return -EINVAL;
10506 }
1ea47e01
AS
10507 for (i = 0; i < prog->len; i++, insn++) {
10508 if (insn->code != (BPF_JMP | BPF_CALL) ||
10509 insn->src_reg != BPF_PSEUDO_CALL)
10510 continue;
10511 depth = get_callee_stack_depth(env, insn, i);
10512 if (depth < 0)
10513 return depth;
10514 bpf_patch_call_args(insn, depth);
10515 }
19d28fbd
DM
10516 err = 0;
10517#endif
10518 return err;
1ea47e01
AS
10519}
10520
79741b3b 10521/* fixup insn->imm field of bpf_call instructions
81ed18ab 10522 * and inline eligible helpers as explicit sequence of BPF instructions
e245c5c6
AS
10523 *
10524 * this function is called after eBPF program passed verification
10525 */
79741b3b 10526static int fixup_bpf_calls(struct bpf_verifier_env *env)
e245c5c6 10527{
79741b3b 10528 struct bpf_prog *prog = env->prog;
d2e4c1e6 10529 bool expect_blinding = bpf_jit_blinding_enabled(prog);
79741b3b 10530 struct bpf_insn *insn = prog->insnsi;
e245c5c6 10531 const struct bpf_func_proto *fn;
79741b3b 10532 const int insn_cnt = prog->len;
09772d92 10533 const struct bpf_map_ops *ops;
c93552c4 10534 struct bpf_insn_aux_data *aux;
81ed18ab
AS
10535 struct bpf_insn insn_buf[16];
10536 struct bpf_prog *new_prog;
10537 struct bpf_map *map_ptr;
d2e4c1e6 10538 int i, ret, cnt, delta = 0;
e245c5c6 10539
79741b3b 10540 for (i = 0; i < insn_cnt; i++, insn++) {
f6b1b3bf
DB
10541 if (insn->code == (BPF_ALU64 | BPF_MOD | BPF_X) ||
10542 insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
10543 insn->code == (BPF_ALU | BPF_MOD | BPF_X) ||
68fda450 10544 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
f6b1b3bf
DB
10545 bool is64 = BPF_CLASS(insn->code) == BPF_ALU64;
10546 struct bpf_insn mask_and_div[] = {
10547 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
10548 /* Rx div 0 -> 0 */
10549 BPF_JMP_IMM(BPF_JNE, insn->src_reg, 0, 2),
10550 BPF_ALU32_REG(BPF_XOR, insn->dst_reg, insn->dst_reg),
10551 BPF_JMP_IMM(BPF_JA, 0, 0, 1),
10552 *insn,
10553 };
10554 struct bpf_insn mask_and_mod[] = {
10555 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
10556 /* Rx mod 0 -> Rx */
10557 BPF_JMP_IMM(BPF_JEQ, insn->src_reg, 0, 1),
10558 *insn,
10559 };
10560 struct bpf_insn *patchlet;
10561
10562 if (insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
10563 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
10564 patchlet = mask_and_div + (is64 ? 1 : 0);
10565 cnt = ARRAY_SIZE(mask_and_div) - (is64 ? 1 : 0);
10566 } else {
10567 patchlet = mask_and_mod + (is64 ? 1 : 0);
10568 cnt = ARRAY_SIZE(mask_and_mod) - (is64 ? 1 : 0);
10569 }
10570
10571 new_prog = bpf_patch_insn_data(env, i + delta, patchlet, cnt);
68fda450
AS
10572 if (!new_prog)
10573 return -ENOMEM;
10574
10575 delta += cnt - 1;
10576 env->prog = prog = new_prog;
10577 insn = new_prog->insnsi + i + delta;
10578 continue;
10579 }
10580
e0cea7ce
DB
10581 if (BPF_CLASS(insn->code) == BPF_LD &&
10582 (BPF_MODE(insn->code) == BPF_ABS ||
10583 BPF_MODE(insn->code) == BPF_IND)) {
10584 cnt = env->ops->gen_ld_abs(insn, insn_buf);
10585 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
10586 verbose(env, "bpf verifier is misconfigured\n");
10587 return -EINVAL;
10588 }
10589
10590 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
10591 if (!new_prog)
10592 return -ENOMEM;
10593
10594 delta += cnt - 1;
10595 env->prog = prog = new_prog;
10596 insn = new_prog->insnsi + i + delta;
10597 continue;
10598 }
10599
979d63d5
DB
10600 if (insn->code == (BPF_ALU64 | BPF_ADD | BPF_X) ||
10601 insn->code == (BPF_ALU64 | BPF_SUB | BPF_X)) {
10602 const u8 code_add = BPF_ALU64 | BPF_ADD | BPF_X;
10603 const u8 code_sub = BPF_ALU64 | BPF_SUB | BPF_X;
10604 struct bpf_insn insn_buf[16];
10605 struct bpf_insn *patch = &insn_buf[0];
10606 bool issrc, isneg;
10607 u32 off_reg;
10608
10609 aux = &env->insn_aux_data[i + delta];
3612af78
DB
10610 if (!aux->alu_state ||
10611 aux->alu_state == BPF_ALU_NON_POINTER)
979d63d5
DB
10612 continue;
10613
10614 isneg = aux->alu_state & BPF_ALU_NEG_VALUE;
10615 issrc = (aux->alu_state & BPF_ALU_SANITIZE) ==
10616 BPF_ALU_SANITIZE_SRC;
10617
10618 off_reg = issrc ? insn->src_reg : insn->dst_reg;
10619 if (isneg)
10620 *patch++ = BPF_ALU64_IMM(BPF_MUL, off_reg, -1);
10621 *patch++ = BPF_MOV32_IMM(BPF_REG_AX, aux->alu_limit - 1);
10622 *patch++ = BPF_ALU64_REG(BPF_SUB, BPF_REG_AX, off_reg);
10623 *patch++ = BPF_ALU64_REG(BPF_OR, BPF_REG_AX, off_reg);
10624 *patch++ = BPF_ALU64_IMM(BPF_NEG, BPF_REG_AX, 0);
10625 *patch++ = BPF_ALU64_IMM(BPF_ARSH, BPF_REG_AX, 63);
10626 if (issrc) {
10627 *patch++ = BPF_ALU64_REG(BPF_AND, BPF_REG_AX,
10628 off_reg);
10629 insn->src_reg = BPF_REG_AX;
10630 } else {
10631 *patch++ = BPF_ALU64_REG(BPF_AND, off_reg,
10632 BPF_REG_AX);
10633 }
10634 if (isneg)
10635 insn->code = insn->code == code_add ?
10636 code_sub : code_add;
10637 *patch++ = *insn;
10638 if (issrc && isneg)
10639 *patch++ = BPF_ALU64_IMM(BPF_MUL, off_reg, -1);
10640 cnt = patch - insn_buf;
10641
10642 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
10643 if (!new_prog)
10644 return -ENOMEM;
10645
10646 delta += cnt - 1;
10647 env->prog = prog = new_prog;
10648 insn = new_prog->insnsi + i + delta;
10649 continue;
10650 }
10651
79741b3b
AS
10652 if (insn->code != (BPF_JMP | BPF_CALL))
10653 continue;
cc8b0b92
AS
10654 if (insn->src_reg == BPF_PSEUDO_CALL)
10655 continue;
e245c5c6 10656
79741b3b
AS
10657 if (insn->imm == BPF_FUNC_get_route_realm)
10658 prog->dst_needed = 1;
10659 if (insn->imm == BPF_FUNC_get_prandom_u32)
10660 bpf_user_rnd_init_once();
9802d865
JB
10661 if (insn->imm == BPF_FUNC_override_return)
10662 prog->kprobe_override = 1;
79741b3b 10663 if (insn->imm == BPF_FUNC_tail_call) {
7b9f6da1
DM
10664 /* If we tail call into other programs, we
10665 * cannot make any assumptions since they can
10666 * be replaced dynamically during runtime in
10667 * the program array.
10668 */
10669 prog->cb_access = 1;
e411901c
MF
10670 if (!allow_tail_call_in_subprogs(env))
10671 prog->aux->stack_depth = MAX_BPF_STACK;
10672 prog->aux->max_pkt_offset = MAX_PACKET_OFF;
7b9f6da1 10673
79741b3b
AS
10674 /* mark bpf_tail_call as different opcode to avoid
10675 * conditional branch in the interpeter for every normal
10676 * call and to prevent accidental JITing by JIT compiler
10677 * that doesn't support bpf_tail_call yet
e245c5c6 10678 */
79741b3b 10679 insn->imm = 0;
71189fa9 10680 insn->code = BPF_JMP | BPF_TAIL_CALL;
b2157399 10681
c93552c4 10682 aux = &env->insn_aux_data[i + delta];
2c78ee89 10683 if (env->bpf_capable && !expect_blinding &&
cc52d914 10684 prog->jit_requested &&
d2e4c1e6
DB
10685 !bpf_map_key_poisoned(aux) &&
10686 !bpf_map_ptr_poisoned(aux) &&
10687 !bpf_map_ptr_unpriv(aux)) {
10688 struct bpf_jit_poke_descriptor desc = {
10689 .reason = BPF_POKE_REASON_TAIL_CALL,
10690 .tail_call.map = BPF_MAP_PTR(aux->map_ptr_state),
10691 .tail_call.key = bpf_map_key_immediate(aux),
a748c697 10692 .insn_idx = i + delta,
d2e4c1e6
DB
10693 };
10694
10695 ret = bpf_jit_add_poke_descriptor(prog, &desc);
10696 if (ret < 0) {
10697 verbose(env, "adding tail call poke descriptor failed\n");
10698 return ret;
10699 }
10700
10701 insn->imm = ret + 1;
10702 continue;
10703 }
10704
c93552c4
DB
10705 if (!bpf_map_ptr_unpriv(aux))
10706 continue;
10707
b2157399
AS
10708 /* instead of changing every JIT dealing with tail_call
10709 * emit two extra insns:
10710 * if (index >= max_entries) goto out;
10711 * index &= array->index_mask;
10712 * to avoid out-of-bounds cpu speculation
10713 */
c93552c4 10714 if (bpf_map_ptr_poisoned(aux)) {
40950343 10715 verbose(env, "tail_call abusing map_ptr\n");
b2157399
AS
10716 return -EINVAL;
10717 }
c93552c4 10718
d2e4c1e6 10719 map_ptr = BPF_MAP_PTR(aux->map_ptr_state);
b2157399
AS
10720 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
10721 map_ptr->max_entries, 2);
10722 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
10723 container_of(map_ptr,
10724 struct bpf_array,
10725 map)->index_mask);
10726 insn_buf[2] = *insn;
10727 cnt = 3;
10728 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
10729 if (!new_prog)
10730 return -ENOMEM;
10731
10732 delta += cnt - 1;
10733 env->prog = prog = new_prog;
10734 insn = new_prog->insnsi + i + delta;
79741b3b
AS
10735 continue;
10736 }
e245c5c6 10737
89c63074 10738 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
09772d92
DB
10739 * and other inlining handlers are currently limited to 64 bit
10740 * only.
89c63074 10741 */
60b58afc 10742 if (prog->jit_requested && BITS_PER_LONG == 64 &&
09772d92
DB
10743 (insn->imm == BPF_FUNC_map_lookup_elem ||
10744 insn->imm == BPF_FUNC_map_update_elem ||
84430d42
DB
10745 insn->imm == BPF_FUNC_map_delete_elem ||
10746 insn->imm == BPF_FUNC_map_push_elem ||
10747 insn->imm == BPF_FUNC_map_pop_elem ||
10748 insn->imm == BPF_FUNC_map_peek_elem)) {
c93552c4
DB
10749 aux = &env->insn_aux_data[i + delta];
10750 if (bpf_map_ptr_poisoned(aux))
10751 goto patch_call_imm;
10752
d2e4c1e6 10753 map_ptr = BPF_MAP_PTR(aux->map_ptr_state);
09772d92
DB
10754 ops = map_ptr->ops;
10755 if (insn->imm == BPF_FUNC_map_lookup_elem &&
10756 ops->map_gen_lookup) {
10757 cnt = ops->map_gen_lookup(map_ptr, insn_buf);
10758 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
10759 verbose(env, "bpf verifier is misconfigured\n");
10760 return -EINVAL;
10761 }
81ed18ab 10762
09772d92
DB
10763 new_prog = bpf_patch_insn_data(env, i + delta,
10764 insn_buf, cnt);
10765 if (!new_prog)
10766 return -ENOMEM;
81ed18ab 10767
09772d92
DB
10768 delta += cnt - 1;
10769 env->prog = prog = new_prog;
10770 insn = new_prog->insnsi + i + delta;
10771 continue;
10772 }
81ed18ab 10773
09772d92
DB
10774 BUILD_BUG_ON(!__same_type(ops->map_lookup_elem,
10775 (void *(*)(struct bpf_map *map, void *key))NULL));
10776 BUILD_BUG_ON(!__same_type(ops->map_delete_elem,
10777 (int (*)(struct bpf_map *map, void *key))NULL));
10778 BUILD_BUG_ON(!__same_type(ops->map_update_elem,
10779 (int (*)(struct bpf_map *map, void *key, void *value,
10780 u64 flags))NULL));
84430d42
DB
10781 BUILD_BUG_ON(!__same_type(ops->map_push_elem,
10782 (int (*)(struct bpf_map *map, void *value,
10783 u64 flags))NULL));
10784 BUILD_BUG_ON(!__same_type(ops->map_pop_elem,
10785 (int (*)(struct bpf_map *map, void *value))NULL));
10786 BUILD_BUG_ON(!__same_type(ops->map_peek_elem,
10787 (int (*)(struct bpf_map *map, void *value))NULL));
10788
09772d92
DB
10789 switch (insn->imm) {
10790 case BPF_FUNC_map_lookup_elem:
10791 insn->imm = BPF_CAST_CALL(ops->map_lookup_elem) -
10792 __bpf_call_base;
10793 continue;
10794 case BPF_FUNC_map_update_elem:
10795 insn->imm = BPF_CAST_CALL(ops->map_update_elem) -
10796 __bpf_call_base;
10797 continue;
10798 case BPF_FUNC_map_delete_elem:
10799 insn->imm = BPF_CAST_CALL(ops->map_delete_elem) -
10800 __bpf_call_base;
10801 continue;
84430d42
DB
10802 case BPF_FUNC_map_push_elem:
10803 insn->imm = BPF_CAST_CALL(ops->map_push_elem) -
10804 __bpf_call_base;
10805 continue;
10806 case BPF_FUNC_map_pop_elem:
10807 insn->imm = BPF_CAST_CALL(ops->map_pop_elem) -
10808 __bpf_call_base;
10809 continue;
10810 case BPF_FUNC_map_peek_elem:
10811 insn->imm = BPF_CAST_CALL(ops->map_peek_elem) -
10812 __bpf_call_base;
10813 continue;
09772d92 10814 }
81ed18ab 10815
09772d92 10816 goto patch_call_imm;
81ed18ab
AS
10817 }
10818
5576b991
MKL
10819 if (prog->jit_requested && BITS_PER_LONG == 64 &&
10820 insn->imm == BPF_FUNC_jiffies64) {
10821 struct bpf_insn ld_jiffies_addr[2] = {
10822 BPF_LD_IMM64(BPF_REG_0,
10823 (unsigned long)&jiffies),
10824 };
10825
10826 insn_buf[0] = ld_jiffies_addr[0];
10827 insn_buf[1] = ld_jiffies_addr[1];
10828 insn_buf[2] = BPF_LDX_MEM(BPF_DW, BPF_REG_0,
10829 BPF_REG_0, 0);
10830 cnt = 3;
10831
10832 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
10833 cnt);
10834 if (!new_prog)
10835 return -ENOMEM;
10836
10837 delta += cnt - 1;
10838 env->prog = prog = new_prog;
10839 insn = new_prog->insnsi + i + delta;
10840 continue;
10841 }
10842
81ed18ab 10843patch_call_imm:
5e43f899 10844 fn = env->ops->get_func_proto(insn->imm, env->prog);
79741b3b
AS
10845 /* all functions that have prototype and verifier allowed
10846 * programs to call them, must be real in-kernel functions
10847 */
10848 if (!fn->func) {
61bd5218
JK
10849 verbose(env,
10850 "kernel subsystem misconfigured func %s#%d\n",
79741b3b
AS
10851 func_id_name(insn->imm), insn->imm);
10852 return -EFAULT;
e245c5c6 10853 }
79741b3b 10854 insn->imm = fn->func - __bpf_call_base;
e245c5c6 10855 }
e245c5c6 10856
d2e4c1e6
DB
10857 /* Since poke tab is now finalized, publish aux to tracker. */
10858 for (i = 0; i < prog->aux->size_poke_tab; i++) {
10859 map_ptr = prog->aux->poke_tab[i].tail_call.map;
10860 if (!map_ptr->ops->map_poke_track ||
10861 !map_ptr->ops->map_poke_untrack ||
10862 !map_ptr->ops->map_poke_run) {
10863 verbose(env, "bpf verifier is misconfigured\n");
10864 return -EINVAL;
10865 }
10866
10867 ret = map_ptr->ops->map_poke_track(map_ptr, prog->aux);
10868 if (ret < 0) {
10869 verbose(env, "tracking tail call prog failed\n");
10870 return ret;
10871 }
10872 }
10873
79741b3b
AS
10874 return 0;
10875}
e245c5c6 10876
58e2af8b 10877static void free_states(struct bpf_verifier_env *env)
f1bca824 10878{
58e2af8b 10879 struct bpf_verifier_state_list *sl, *sln;
f1bca824
AS
10880 int i;
10881
9f4686c4
AS
10882 sl = env->free_list;
10883 while (sl) {
10884 sln = sl->next;
10885 free_verifier_state(&sl->state, false);
10886 kfree(sl);
10887 sl = sln;
10888 }
51c39bb1 10889 env->free_list = NULL;
9f4686c4 10890
f1bca824
AS
10891 if (!env->explored_states)
10892 return;
10893
dc2a4ebc 10894 for (i = 0; i < state_htab_size(env); i++) {
f1bca824
AS
10895 sl = env->explored_states[i];
10896
a8f500af
AS
10897 while (sl) {
10898 sln = sl->next;
10899 free_verifier_state(&sl->state, false);
10900 kfree(sl);
10901 sl = sln;
10902 }
51c39bb1 10903 env->explored_states[i] = NULL;
f1bca824 10904 }
51c39bb1 10905}
f1bca824 10906
51c39bb1
AS
10907/* The verifier is using insn_aux_data[] to store temporary data during
10908 * verification and to store information for passes that run after the
10909 * verification like dead code sanitization. do_check_common() for subprogram N
10910 * may analyze many other subprograms. sanitize_insn_aux_data() clears all
10911 * temporary data after do_check_common() finds that subprogram N cannot be
10912 * verified independently. pass_cnt counts the number of times
10913 * do_check_common() was run and insn->aux->seen tells the pass number
10914 * insn_aux_data was touched. These variables are compared to clear temporary
10915 * data from failed pass. For testing and experiments do_check_common() can be
10916 * run multiple times even when prior attempt to verify is unsuccessful.
10917 */
10918static void sanitize_insn_aux_data(struct bpf_verifier_env *env)
10919{
10920 struct bpf_insn *insn = env->prog->insnsi;
10921 struct bpf_insn_aux_data *aux;
10922 int i, class;
10923
10924 for (i = 0; i < env->prog->len; i++) {
10925 class = BPF_CLASS(insn[i].code);
10926 if (class != BPF_LDX && class != BPF_STX)
10927 continue;
10928 aux = &env->insn_aux_data[i];
10929 if (aux->seen != env->pass_cnt)
10930 continue;
10931 memset(aux, 0, offsetof(typeof(*aux), orig_idx));
10932 }
f1bca824
AS
10933}
10934
51c39bb1
AS
10935static int do_check_common(struct bpf_verifier_env *env, int subprog)
10936{
6f8a57cc 10937 bool pop_log = !(env->log.level & BPF_LOG_LEVEL2);
51c39bb1
AS
10938 struct bpf_verifier_state *state;
10939 struct bpf_reg_state *regs;
10940 int ret, i;
10941
10942 env->prev_linfo = NULL;
10943 env->pass_cnt++;
10944
10945 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
10946 if (!state)
10947 return -ENOMEM;
10948 state->curframe = 0;
10949 state->speculative = false;
10950 state->branches = 1;
10951 state->frame[0] = kzalloc(sizeof(struct bpf_func_state), GFP_KERNEL);
10952 if (!state->frame[0]) {
10953 kfree(state);
10954 return -ENOMEM;
10955 }
10956 env->cur_state = state;
10957 init_func_state(env, state->frame[0],
10958 BPF_MAIN_FUNC /* callsite */,
10959 0 /* frameno */,
10960 subprog);
10961
10962 regs = state->frame[state->curframe]->regs;
be8704ff 10963 if (subprog || env->prog->type == BPF_PROG_TYPE_EXT) {
51c39bb1
AS
10964 ret = btf_prepare_func_args(env, subprog, regs);
10965 if (ret)
10966 goto out;
10967 for (i = BPF_REG_1; i <= BPF_REG_5; i++) {
10968 if (regs[i].type == PTR_TO_CTX)
10969 mark_reg_known_zero(env, regs, i);
10970 else if (regs[i].type == SCALAR_VALUE)
10971 mark_reg_unknown(env, regs, i);
10972 }
10973 } else {
10974 /* 1st arg to a function */
10975 regs[BPF_REG_1].type = PTR_TO_CTX;
10976 mark_reg_known_zero(env, regs, BPF_REG_1);
10977 ret = btf_check_func_arg_match(env, subprog, regs);
10978 if (ret == -EFAULT)
10979 /* unlikely verifier bug. abort.
10980 * ret == 0 and ret < 0 are sadly acceptable for
10981 * main() function due to backward compatibility.
10982 * Like socket filter program may be written as:
10983 * int bpf_prog(struct pt_regs *ctx)
10984 * and never dereference that ctx in the program.
10985 * 'struct pt_regs' is a type mismatch for socket
10986 * filter that should be using 'struct __sk_buff'.
10987 */
10988 goto out;
10989 }
10990
10991 ret = do_check(env);
10992out:
f59bbfc2
AS
10993 /* check for NULL is necessary, since cur_state can be freed inside
10994 * do_check() under memory pressure.
10995 */
10996 if (env->cur_state) {
10997 free_verifier_state(env->cur_state, true);
10998 env->cur_state = NULL;
10999 }
6f8a57cc
AN
11000 while (!pop_stack(env, NULL, NULL, false));
11001 if (!ret && pop_log)
11002 bpf_vlog_reset(&env->log, 0);
51c39bb1
AS
11003 free_states(env);
11004 if (ret)
11005 /* clean aux data in case subprog was rejected */
11006 sanitize_insn_aux_data(env);
11007 return ret;
11008}
11009
11010/* Verify all global functions in a BPF program one by one based on their BTF.
11011 * All global functions must pass verification. Otherwise the whole program is rejected.
11012 * Consider:
11013 * int bar(int);
11014 * int foo(int f)
11015 * {
11016 * return bar(f);
11017 * }
11018 * int bar(int b)
11019 * {
11020 * ...
11021 * }
11022 * foo() will be verified first for R1=any_scalar_value. During verification it
11023 * will be assumed that bar() already verified successfully and call to bar()
11024 * from foo() will be checked for type match only. Later bar() will be verified
11025 * independently to check that it's safe for R1=any_scalar_value.
11026 */
11027static int do_check_subprogs(struct bpf_verifier_env *env)
11028{
11029 struct bpf_prog_aux *aux = env->prog->aux;
11030 int i, ret;
11031
11032 if (!aux->func_info)
11033 return 0;
11034
11035 for (i = 1; i < env->subprog_cnt; i++) {
11036 if (aux->func_info_aux[i].linkage != BTF_FUNC_GLOBAL)
11037 continue;
11038 env->insn_idx = env->subprog_info[i].start;
11039 WARN_ON_ONCE(env->insn_idx == 0);
11040 ret = do_check_common(env, i);
11041 if (ret) {
11042 return ret;
11043 } else if (env->log.level & BPF_LOG_LEVEL) {
11044 verbose(env,
11045 "Func#%d is safe for any args that match its prototype\n",
11046 i);
11047 }
11048 }
11049 return 0;
11050}
11051
11052static int do_check_main(struct bpf_verifier_env *env)
11053{
11054 int ret;
11055
11056 env->insn_idx = 0;
11057 ret = do_check_common(env, 0);
11058 if (!ret)
11059 env->prog->aux->stack_depth = env->subprog_info[0].stack_depth;
11060 return ret;
11061}
11062
11063
06ee7115
AS
11064static void print_verification_stats(struct bpf_verifier_env *env)
11065{
11066 int i;
11067
11068 if (env->log.level & BPF_LOG_STATS) {
11069 verbose(env, "verification time %lld usec\n",
11070 div_u64(env->verification_time, 1000));
11071 verbose(env, "stack depth ");
11072 for (i = 0; i < env->subprog_cnt; i++) {
11073 u32 depth = env->subprog_info[i].stack_depth;
11074
11075 verbose(env, "%d", depth);
11076 if (i + 1 < env->subprog_cnt)
11077 verbose(env, "+");
11078 }
11079 verbose(env, "\n");
11080 }
11081 verbose(env, "processed %d insns (limit %d) max_states_per_insn %d "
11082 "total_states %d peak_states %d mark_read %d\n",
11083 env->insn_processed, BPF_COMPLEXITY_LIMIT_INSNS,
11084 env->max_states_per_insn, env->total_states,
11085 env->peak_states, env->longest_mark_read_walk);
f1bca824
AS
11086}
11087
27ae7997
MKL
11088static int check_struct_ops_btf_id(struct bpf_verifier_env *env)
11089{
11090 const struct btf_type *t, *func_proto;
11091 const struct bpf_struct_ops *st_ops;
11092 const struct btf_member *member;
11093 struct bpf_prog *prog = env->prog;
11094 u32 btf_id, member_idx;
11095 const char *mname;
11096
11097 btf_id = prog->aux->attach_btf_id;
11098 st_ops = bpf_struct_ops_find(btf_id);
11099 if (!st_ops) {
11100 verbose(env, "attach_btf_id %u is not a supported struct\n",
11101 btf_id);
11102 return -ENOTSUPP;
11103 }
11104
11105 t = st_ops->type;
11106 member_idx = prog->expected_attach_type;
11107 if (member_idx >= btf_type_vlen(t)) {
11108 verbose(env, "attach to invalid member idx %u of struct %s\n",
11109 member_idx, st_ops->name);
11110 return -EINVAL;
11111 }
11112
11113 member = &btf_type_member(t)[member_idx];
11114 mname = btf_name_by_offset(btf_vmlinux, member->name_off);
11115 func_proto = btf_type_resolve_func_ptr(btf_vmlinux, member->type,
11116 NULL);
11117 if (!func_proto) {
11118 verbose(env, "attach to invalid member %s(@idx %u) of struct %s\n",
11119 mname, member_idx, st_ops->name);
11120 return -EINVAL;
11121 }
11122
11123 if (st_ops->check_member) {
11124 int err = st_ops->check_member(t, member);
11125
11126 if (err) {
11127 verbose(env, "attach to unsupported member %s of struct %s\n",
11128 mname, st_ops->name);
11129 return err;
11130 }
11131 }
11132
11133 prog->aux->attach_func_proto = func_proto;
11134 prog->aux->attach_func_name = mname;
11135 env->ops = st_ops->verifier_ops;
11136
11137 return 0;
11138}
6ba43b76
KS
11139#define SECURITY_PREFIX "security_"
11140
18644cec 11141static int check_attach_modify_return(struct bpf_prog *prog, unsigned long addr)
6ba43b76 11142{
69191754
KS
11143 if (within_error_injection_list(addr) ||
11144 !strncmp(SECURITY_PREFIX, prog->aux->attach_func_name,
11145 sizeof(SECURITY_PREFIX) - 1))
6ba43b76 11146 return 0;
6ba43b76 11147
6ba43b76
KS
11148 return -EINVAL;
11149}
27ae7997 11150
1e6c62a8
AS
11151/* non exhaustive list of sleepable bpf_lsm_*() functions */
11152BTF_SET_START(btf_sleepable_lsm_hooks)
11153#ifdef CONFIG_BPF_LSM
1e6c62a8 11154BTF_ID(func, bpf_lsm_bprm_committed_creds)
29523c5e
AS
11155#else
11156BTF_ID_UNUSED
1e6c62a8
AS
11157#endif
11158BTF_SET_END(btf_sleepable_lsm_hooks)
11159
11160static int check_sleepable_lsm_hook(u32 btf_id)
11161{
11162 return btf_id_set_contains(&btf_sleepable_lsm_hooks, btf_id);
11163}
11164
11165/* list of non-sleepable functions that are otherwise on
11166 * ALLOW_ERROR_INJECTION list
11167 */
11168BTF_SET_START(btf_non_sleepable_error_inject)
11169/* Three functions below can be called from sleepable and non-sleepable context.
11170 * Assume non-sleepable from bpf safety point of view.
11171 */
11172BTF_ID(func, __add_to_page_cache_locked)
11173BTF_ID(func, should_fail_alloc_page)
11174BTF_ID(func, should_failslab)
11175BTF_SET_END(btf_non_sleepable_error_inject)
11176
11177static int check_non_sleepable_error_inject(u32 btf_id)
11178{
11179 return btf_id_set_contains(&btf_non_sleepable_error_inject, btf_id);
11180}
11181
38207291
MKL
11182static int check_attach_btf_id(struct bpf_verifier_env *env)
11183{
11184 struct bpf_prog *prog = env->prog;
be8704ff 11185 bool prog_extension = prog->type == BPF_PROG_TYPE_EXT;
5b92a28a 11186 struct bpf_prog *tgt_prog = prog->aux->linked_prog;
38207291 11187 u32 btf_id = prog->aux->attach_btf_id;
f1b9509c 11188 const char prefix[] = "btf_trace_";
15d83c4d 11189 struct btf_func_model fmodel;
5b92a28a 11190 int ret = 0, subprog = -1, i;
fec56f58 11191 struct bpf_trampoline *tr;
38207291 11192 const struct btf_type *t;
5b92a28a 11193 bool conservative = true;
38207291 11194 const char *tname;
5b92a28a 11195 struct btf *btf;
fec56f58 11196 long addr;
5b92a28a 11197 u64 key;
38207291 11198
1e6c62a8
AS
11199 if (prog->aux->sleepable && prog->type != BPF_PROG_TYPE_TRACING &&
11200 prog->type != BPF_PROG_TYPE_LSM) {
11201 verbose(env, "Only fentry/fexit/fmod_ret and lsm programs can be sleepable\n");
11202 return -EINVAL;
11203 }
11204
27ae7997
MKL
11205 if (prog->type == BPF_PROG_TYPE_STRUCT_OPS)
11206 return check_struct_ops_btf_id(env);
11207
9e4e01df
KS
11208 if (prog->type != BPF_PROG_TYPE_TRACING &&
11209 prog->type != BPF_PROG_TYPE_LSM &&
11210 !prog_extension)
f1b9509c 11211 return 0;
38207291 11212
f1b9509c
AS
11213 if (!btf_id) {
11214 verbose(env, "Tracing programs must provide btf_id\n");
11215 return -EINVAL;
11216 }
5b92a28a
AS
11217 btf = bpf_prog_get_target_btf(prog);
11218 if (!btf) {
11219 verbose(env,
11220 "FENTRY/FEXIT program can only be attached to another program annotated with BTF\n");
11221 return -EINVAL;
11222 }
11223 t = btf_type_by_id(btf, btf_id);
f1b9509c
AS
11224 if (!t) {
11225 verbose(env, "attach_btf_id %u is invalid\n", btf_id);
11226 return -EINVAL;
11227 }
5b92a28a 11228 tname = btf_name_by_offset(btf, t->name_off);
f1b9509c
AS
11229 if (!tname) {
11230 verbose(env, "attach_btf_id %u doesn't have a name\n", btf_id);
11231 return -EINVAL;
11232 }
5b92a28a
AS
11233 if (tgt_prog) {
11234 struct bpf_prog_aux *aux = tgt_prog->aux;
11235
11236 for (i = 0; i < aux->func_info_cnt; i++)
11237 if (aux->func_info[i].type_id == btf_id) {
11238 subprog = i;
11239 break;
11240 }
11241 if (subprog == -1) {
11242 verbose(env, "Subprog %s doesn't exist\n", tname);
11243 return -EINVAL;
11244 }
11245 conservative = aux->func_info_aux[subprog].unreliable;
be8704ff
AS
11246 if (prog_extension) {
11247 if (conservative) {
11248 verbose(env,
11249 "Cannot replace static functions\n");
11250 return -EINVAL;
11251 }
11252 if (!prog->jit_requested) {
11253 verbose(env,
11254 "Extension programs should be JITed\n");
11255 return -EINVAL;
11256 }
11257 env->ops = bpf_verifier_ops[tgt_prog->type];
03f87c0b 11258 prog->expected_attach_type = tgt_prog->expected_attach_type;
be8704ff
AS
11259 }
11260 if (!tgt_prog->jited) {
11261 verbose(env, "Can attach to only JITed progs\n");
11262 return -EINVAL;
11263 }
11264 if (tgt_prog->type == prog->type) {
11265 /* Cannot fentry/fexit another fentry/fexit program.
11266 * Cannot attach program extension to another extension.
11267 * It's ok to attach fentry/fexit to extension program.
11268 */
11269 verbose(env, "Cannot recursively attach\n");
11270 return -EINVAL;
11271 }
11272 if (tgt_prog->type == BPF_PROG_TYPE_TRACING &&
11273 prog_extension &&
11274 (tgt_prog->expected_attach_type == BPF_TRACE_FENTRY ||
11275 tgt_prog->expected_attach_type == BPF_TRACE_FEXIT)) {
11276 /* Program extensions can extend all program types
11277 * except fentry/fexit. The reason is the following.
11278 * The fentry/fexit programs are used for performance
11279 * analysis, stats and can be attached to any program
11280 * type except themselves. When extension program is
11281 * replacing XDP function it is necessary to allow
11282 * performance analysis of all functions. Both original
11283 * XDP program and its program extension. Hence
11284 * attaching fentry/fexit to BPF_PROG_TYPE_EXT is
11285 * allowed. If extending of fentry/fexit was allowed it
11286 * would be possible to create long call chain
11287 * fentry->extension->fentry->extension beyond
11288 * reasonable stack size. Hence extending fentry is not
11289 * allowed.
11290 */
11291 verbose(env, "Cannot extend fentry/fexit\n");
11292 return -EINVAL;
11293 }
5b92a28a
AS
11294 key = ((u64)aux->id) << 32 | btf_id;
11295 } else {
be8704ff
AS
11296 if (prog_extension) {
11297 verbose(env, "Cannot replace kernel functions\n");
11298 return -EINVAL;
11299 }
5b92a28a
AS
11300 key = btf_id;
11301 }
f1b9509c
AS
11302
11303 switch (prog->expected_attach_type) {
11304 case BPF_TRACE_RAW_TP:
5b92a28a
AS
11305 if (tgt_prog) {
11306 verbose(env,
11307 "Only FENTRY/FEXIT progs are attachable to another BPF prog\n");
11308 return -EINVAL;
11309 }
38207291
MKL
11310 if (!btf_type_is_typedef(t)) {
11311 verbose(env, "attach_btf_id %u is not a typedef\n",
11312 btf_id);
11313 return -EINVAL;
11314 }
f1b9509c 11315 if (strncmp(prefix, tname, sizeof(prefix) - 1)) {
38207291
MKL
11316 verbose(env, "attach_btf_id %u points to wrong type name %s\n",
11317 btf_id, tname);
11318 return -EINVAL;
11319 }
11320 tname += sizeof(prefix) - 1;
5b92a28a 11321 t = btf_type_by_id(btf, t->type);
38207291
MKL
11322 if (!btf_type_is_ptr(t))
11323 /* should never happen in valid vmlinux build */
11324 return -EINVAL;
5b92a28a 11325 t = btf_type_by_id(btf, t->type);
38207291
MKL
11326 if (!btf_type_is_func_proto(t))
11327 /* should never happen in valid vmlinux build */
11328 return -EINVAL;
11329
11330 /* remember two read only pointers that are valid for
11331 * the life time of the kernel
11332 */
11333 prog->aux->attach_func_name = tname;
11334 prog->aux->attach_func_proto = t;
11335 prog->aux->attach_btf_trace = true;
f1b9509c 11336 return 0;
15d83c4d
YS
11337 case BPF_TRACE_ITER:
11338 if (!btf_type_is_func(t)) {
11339 verbose(env, "attach_btf_id %u is not a function\n",
11340 btf_id);
11341 return -EINVAL;
11342 }
11343 t = btf_type_by_id(btf, t->type);
11344 if (!btf_type_is_func_proto(t))
11345 return -EINVAL;
11346 prog->aux->attach_func_name = tname;
11347 prog->aux->attach_func_proto = t;
11348 if (!bpf_iter_prog_supported(prog))
11349 return -EINVAL;
11350 ret = btf_distill_func_proto(&env->log, btf, t,
11351 tname, &fmodel);
11352 return ret;
be8704ff
AS
11353 default:
11354 if (!prog_extension)
11355 return -EINVAL;
11356 /* fallthrough */
ae240823 11357 case BPF_MODIFY_RETURN:
9e4e01df 11358 case BPF_LSM_MAC:
fec56f58
AS
11359 case BPF_TRACE_FENTRY:
11360 case BPF_TRACE_FEXIT:
9e4e01df
KS
11361 prog->aux->attach_func_name = tname;
11362 if (prog->type == BPF_PROG_TYPE_LSM) {
11363 ret = bpf_lsm_verify_prog(&env->log, prog);
11364 if (ret < 0)
11365 return ret;
11366 }
11367
fec56f58
AS
11368 if (!btf_type_is_func(t)) {
11369 verbose(env, "attach_btf_id %u is not a function\n",
11370 btf_id);
11371 return -EINVAL;
11372 }
be8704ff
AS
11373 if (prog_extension &&
11374 btf_check_type_match(env, prog, btf, t))
11375 return -EINVAL;
5b92a28a 11376 t = btf_type_by_id(btf, t->type);
fec56f58
AS
11377 if (!btf_type_is_func_proto(t))
11378 return -EINVAL;
5b92a28a 11379 tr = bpf_trampoline_lookup(key);
fec56f58
AS
11380 if (!tr)
11381 return -ENOMEM;
5b92a28a 11382 /* t is either vmlinux type or another program's type */
fec56f58
AS
11383 prog->aux->attach_func_proto = t;
11384 mutex_lock(&tr->mutex);
11385 if (tr->func.addr) {
11386 prog->aux->trampoline = tr;
11387 goto out;
11388 }
5b92a28a
AS
11389 if (tgt_prog && conservative) {
11390 prog->aux->attach_func_proto = NULL;
11391 t = NULL;
11392 }
11393 ret = btf_distill_func_proto(&env->log, btf, t,
fec56f58
AS
11394 tname, &tr->func.model);
11395 if (ret < 0)
11396 goto out;
5b92a28a 11397 if (tgt_prog) {
e9eeec58
YS
11398 if (subprog == 0)
11399 addr = (long) tgt_prog->bpf_func;
11400 else
11401 addr = (long) tgt_prog->aux->func[subprog]->bpf_func;
5b92a28a
AS
11402 } else {
11403 addr = kallsyms_lookup_name(tname);
11404 if (!addr) {
11405 verbose(env,
11406 "The address of function %s cannot be found\n",
11407 tname);
11408 ret = -ENOENT;
11409 goto out;
11410 }
fec56f58 11411 }
18644cec 11412
1e6c62a8
AS
11413 if (prog->aux->sleepable) {
11414 ret = -EINVAL;
11415 switch (prog->type) {
11416 case BPF_PROG_TYPE_TRACING:
11417 /* fentry/fexit/fmod_ret progs can be sleepable only if they are
11418 * attached to ALLOW_ERROR_INJECTION and are not in denylist.
11419 */
11420 if (!check_non_sleepable_error_inject(btf_id) &&
11421 within_error_injection_list(addr))
11422 ret = 0;
11423 break;
11424 case BPF_PROG_TYPE_LSM:
11425 /* LSM progs check that they are attached to bpf_lsm_*() funcs.
11426 * Only some of them are sleepable.
11427 */
11428 if (check_sleepable_lsm_hook(btf_id))
11429 ret = 0;
11430 break;
11431 default:
11432 break;
11433 }
11434 if (ret)
11435 verbose(env, "%s is not sleepable\n",
11436 prog->aux->attach_func_name);
11437 } else if (prog->expected_attach_type == BPF_MODIFY_RETURN) {
18644cec
AS
11438 ret = check_attach_modify_return(prog, addr);
11439 if (ret)
11440 verbose(env, "%s() is not modifiable\n",
11441 prog->aux->attach_func_name);
11442 }
18644cec
AS
11443 if (ret)
11444 goto out;
fec56f58
AS
11445 tr->func.addr = (void *)addr;
11446 prog->aux->trampoline = tr;
11447out:
11448 mutex_unlock(&tr->mutex);
11449 if (ret)
11450 bpf_trampoline_put(tr);
11451 return ret;
38207291 11452 }
38207291
MKL
11453}
11454
838e9690
YS
11455int bpf_check(struct bpf_prog **prog, union bpf_attr *attr,
11456 union bpf_attr __user *uattr)
51580e79 11457{
06ee7115 11458 u64 start_time = ktime_get_ns();
58e2af8b 11459 struct bpf_verifier_env *env;
b9193c1b 11460 struct bpf_verifier_log *log;
9e4c24e7 11461 int i, len, ret = -EINVAL;
e2ae4ca2 11462 bool is_priv;
51580e79 11463
eba0c929
AB
11464 /* no program is valid */
11465 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
11466 return -EINVAL;
11467
58e2af8b 11468 /* 'struct bpf_verifier_env' can be global, but since it's not small,
cbd35700
AS
11469 * allocate/free it every time bpf_check() is called
11470 */
58e2af8b 11471 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
cbd35700
AS
11472 if (!env)
11473 return -ENOMEM;
61bd5218 11474 log = &env->log;
cbd35700 11475
9e4c24e7 11476 len = (*prog)->len;
fad953ce 11477 env->insn_aux_data =
9e4c24e7 11478 vzalloc(array_size(sizeof(struct bpf_insn_aux_data), len));
3df126f3
JK
11479 ret = -ENOMEM;
11480 if (!env->insn_aux_data)
11481 goto err_free_env;
9e4c24e7
JK
11482 for (i = 0; i < len; i++)
11483 env->insn_aux_data[i].orig_idx = i;
9bac3d6d 11484 env->prog = *prog;
00176a34 11485 env->ops = bpf_verifier_ops[env->prog->type];
2c78ee89 11486 is_priv = bpf_capable();
0246e64d 11487
8580ac94
AS
11488 if (!btf_vmlinux && IS_ENABLED(CONFIG_DEBUG_INFO_BTF)) {
11489 mutex_lock(&bpf_verifier_lock);
11490 if (!btf_vmlinux)
11491 btf_vmlinux = btf_parse_vmlinux();
11492 mutex_unlock(&bpf_verifier_lock);
11493 }
11494
cbd35700 11495 /* grab the mutex to protect few globals used by verifier */
45a73c17
AS
11496 if (!is_priv)
11497 mutex_lock(&bpf_verifier_lock);
cbd35700
AS
11498
11499 if (attr->log_level || attr->log_buf || attr->log_size) {
11500 /* user requested verbose verifier output
11501 * and supplied buffer to store the verification trace
11502 */
e7bf8249
JK
11503 log->level = attr->log_level;
11504 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
11505 log->len_total = attr->log_size;
cbd35700
AS
11506
11507 ret = -EINVAL;
e7bf8249 11508 /* log attributes have to be sane */
7a9f5c65 11509 if (log->len_total < 128 || log->len_total > UINT_MAX >> 2 ||
06ee7115 11510 !log->level || !log->ubuf || log->level & ~BPF_LOG_MASK)
3df126f3 11511 goto err_unlock;
cbd35700 11512 }
1ad2f583 11513
8580ac94
AS
11514 if (IS_ERR(btf_vmlinux)) {
11515 /* Either gcc or pahole or kernel are broken. */
11516 verbose(env, "in-kernel BTF is malformed\n");
11517 ret = PTR_ERR(btf_vmlinux);
38207291 11518 goto skip_full_check;
8580ac94
AS
11519 }
11520
1ad2f583
DB
11521 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
11522 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
e07b98d9 11523 env->strict_alignment = true;
e9ee9efc
DM
11524 if (attr->prog_flags & BPF_F_ANY_ALIGNMENT)
11525 env->strict_alignment = false;
cbd35700 11526
2c78ee89 11527 env->allow_ptr_leaks = bpf_allow_ptr_leaks();
41c48f3a 11528 env->allow_ptr_to_map_access = bpf_allow_ptr_to_map_access();
2c78ee89
AS
11529 env->bypass_spec_v1 = bpf_bypass_spec_v1();
11530 env->bypass_spec_v4 = bpf_bypass_spec_v4();
11531 env->bpf_capable = bpf_capable();
e2ae4ca2 11532
10d274e8
AS
11533 if (is_priv)
11534 env->test_state_freq = attr->prog_flags & BPF_F_TEST_STATE_FREQ;
11535
f4e3ec0d
JK
11536 ret = replace_map_fd_with_map_ptr(env);
11537 if (ret < 0)
11538 goto skip_full_check;
11539
cae1927c 11540 if (bpf_prog_is_dev_bound(env->prog->aux)) {
a40a2632 11541 ret = bpf_prog_offload_verifier_prep(env->prog);
ab3f0063 11542 if (ret)
f4e3ec0d 11543 goto skip_full_check;
ab3f0063
JK
11544 }
11545
dc2a4ebc 11546 env->explored_states = kvcalloc(state_htab_size(env),
58e2af8b 11547 sizeof(struct bpf_verifier_state_list *),
f1bca824
AS
11548 GFP_USER);
11549 ret = -ENOMEM;
11550 if (!env->explored_states)
11551 goto skip_full_check;
11552
d9762e84 11553 ret = check_subprogs(env);
475fb78f
AS
11554 if (ret < 0)
11555 goto skip_full_check;
11556
c454a46b 11557 ret = check_btf_info(env, attr, uattr);
838e9690
YS
11558 if (ret < 0)
11559 goto skip_full_check;
11560
be8704ff
AS
11561 ret = check_attach_btf_id(env);
11562 if (ret)
11563 goto skip_full_check;
11564
d9762e84
MKL
11565 ret = check_cfg(env);
11566 if (ret < 0)
11567 goto skip_full_check;
11568
51c39bb1
AS
11569 ret = do_check_subprogs(env);
11570 ret = ret ?: do_check_main(env);
cbd35700 11571
c941ce9c
QM
11572 if (ret == 0 && bpf_prog_is_dev_bound(env->prog->aux))
11573 ret = bpf_prog_offload_finalize(env);
11574
0246e64d 11575skip_full_check:
51c39bb1 11576 kvfree(env->explored_states);
0246e64d 11577
c131187d 11578 if (ret == 0)
9b38c405 11579 ret = check_max_stack_depth(env);
c131187d 11580
9b38c405 11581 /* instruction rewrites happen after this point */
e2ae4ca2
JK
11582 if (is_priv) {
11583 if (ret == 0)
11584 opt_hard_wire_dead_code_branches(env);
52875a04
JK
11585 if (ret == 0)
11586 ret = opt_remove_dead_code(env);
a1b14abc
JK
11587 if (ret == 0)
11588 ret = opt_remove_nops(env);
52875a04
JK
11589 } else {
11590 if (ret == 0)
11591 sanitize_dead_code(env);
e2ae4ca2
JK
11592 }
11593
9bac3d6d
AS
11594 if (ret == 0)
11595 /* program is valid, convert *(u32*)(ctx + off) accesses */
11596 ret = convert_ctx_accesses(env);
11597
e245c5c6 11598 if (ret == 0)
79741b3b 11599 ret = fixup_bpf_calls(env);
e245c5c6 11600
a4b1d3c1
JW
11601 /* do 32-bit optimization after insn patching has done so those patched
11602 * insns could be handled correctly.
11603 */
d6c2308c
JW
11604 if (ret == 0 && !bpf_prog_is_dev_bound(env->prog->aux)) {
11605 ret = opt_subreg_zext_lo32_rnd_hi32(env, attr);
11606 env->prog->aux->verifier_zext = bpf_jit_needs_zext() ? !ret
11607 : false;
a4b1d3c1
JW
11608 }
11609
1ea47e01
AS
11610 if (ret == 0)
11611 ret = fixup_call_args(env);
11612
06ee7115
AS
11613 env->verification_time = ktime_get_ns() - start_time;
11614 print_verification_stats(env);
11615
a2a7d570 11616 if (log->level && bpf_verifier_log_full(log))
cbd35700 11617 ret = -ENOSPC;
a2a7d570 11618 if (log->level && !log->ubuf) {
cbd35700 11619 ret = -EFAULT;
a2a7d570 11620 goto err_release_maps;
cbd35700
AS
11621 }
11622
0246e64d
AS
11623 if (ret == 0 && env->used_map_cnt) {
11624 /* if program passed verifier, update used_maps in bpf_prog_info */
9bac3d6d
AS
11625 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
11626 sizeof(env->used_maps[0]),
11627 GFP_KERNEL);
0246e64d 11628
9bac3d6d 11629 if (!env->prog->aux->used_maps) {
0246e64d 11630 ret = -ENOMEM;
a2a7d570 11631 goto err_release_maps;
0246e64d
AS
11632 }
11633
9bac3d6d 11634 memcpy(env->prog->aux->used_maps, env->used_maps,
0246e64d 11635 sizeof(env->used_maps[0]) * env->used_map_cnt);
9bac3d6d 11636 env->prog->aux->used_map_cnt = env->used_map_cnt;
0246e64d
AS
11637
11638 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
11639 * bpf_ld_imm64 instructions
11640 */
11641 convert_pseudo_ld_imm64(env);
11642 }
cbd35700 11643
ba64e7d8
YS
11644 if (ret == 0)
11645 adjust_btf_func(env);
11646
a2a7d570 11647err_release_maps:
9bac3d6d 11648 if (!env->prog->aux->used_maps)
0246e64d 11649 /* if we didn't copy map pointers into bpf_prog_info, release
ab7f5bf0 11650 * them now. Otherwise free_used_maps() will release them.
0246e64d
AS
11651 */
11652 release_maps(env);
03f87c0b
THJ
11653
11654 /* extension progs temporarily inherit the attach_type of their targets
11655 for verification purposes, so set it back to zero before returning
11656 */
11657 if (env->prog->type == BPF_PROG_TYPE_EXT)
11658 env->prog->expected_attach_type = 0;
11659
9bac3d6d 11660 *prog = env->prog;
3df126f3 11661err_unlock:
45a73c17
AS
11662 if (!is_priv)
11663 mutex_unlock(&bpf_verifier_lock);
3df126f3
JK
11664 vfree(env->insn_aux_data);
11665err_free_env:
11666 kfree(env);
51580e79
AS
11667 return ret;
11668}