]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/blame - kernel/bpf/verifier.c
bpf: Factor btf_struct_access function
[mirror_ubuntu-jammy-kernel.git] / kernel / bpf / verifier.c
CommitLineData
5b497af4 1// SPDX-License-Identifier: GPL-2.0-only
51580e79 2/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
969bf05e 3 * Copyright (c) 2016 Facebook
fd978bf7 4 * Copyright (c) 2018 Covalent IO, Inc. http://covalent.io
51580e79 5 */
838e9690 6#include <uapi/linux/btf.h>
51580e79
AS
7#include <linux/kernel.h>
8#include <linux/types.h>
9#include <linux/slab.h>
10#include <linux/bpf.h>
838e9690 11#include <linux/btf.h>
58e2af8b 12#include <linux/bpf_verifier.h>
51580e79
AS
13#include <linux/filter.h>
14#include <net/netlink.h>
15#include <linux/file.h>
16#include <linux/vmalloc.h>
ebb676da 17#include <linux/stringify.h>
cc8b0b92
AS
18#include <linux/bsearch.h>
19#include <linux/sort.h>
c195651e 20#include <linux/perf_event.h>
d9762e84 21#include <linux/ctype.h>
6ba43b76 22#include <linux/error-injection.h>
9e4e01df 23#include <linux/bpf_lsm.h>
51580e79 24
f4ac7e0b
JK
25#include "disasm.h"
26
00176a34 27static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
91cc1a99 28#define BPF_PROG_TYPE(_id, _name, prog_ctx_type, kern_ctx_type) \
00176a34
JK
29 [_id] = & _name ## _verifier_ops,
30#define BPF_MAP_TYPE(_id, _ops)
f2e10bff 31#define BPF_LINK_TYPE(_id, _name)
00176a34
JK
32#include <linux/bpf_types.h>
33#undef BPF_PROG_TYPE
34#undef BPF_MAP_TYPE
f2e10bff 35#undef BPF_LINK_TYPE
00176a34
JK
36};
37
51580e79
AS
38/* bpf_check() is a static code analyzer that walks eBPF program
39 * instruction by instruction and updates register/stack state.
40 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
41 *
42 * The first pass is depth-first-search to check that the program is a DAG.
43 * It rejects the following programs:
44 * - larger than BPF_MAXINSNS insns
45 * - if loop is present (detected via back-edge)
46 * - unreachable insns exist (shouldn't be a forest. program = one function)
47 * - out of bounds or malformed jumps
48 * The second pass is all possible path descent from the 1st insn.
49 * Since it's analyzing all pathes through the program, the length of the
eba38a96 50 * analysis is limited to 64k insn, which may be hit even if total number of
51580e79
AS
51 * insn is less then 4K, but there are too many branches that change stack/regs.
52 * Number of 'branches to be analyzed' is limited to 1k
53 *
54 * On entry to each instruction, each register has a type, and the instruction
55 * changes the types of the registers depending on instruction semantics.
56 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
57 * copied to R1.
58 *
59 * All registers are 64-bit.
60 * R0 - return register
61 * R1-R5 argument passing registers
62 * R6-R9 callee saved registers
63 * R10 - frame pointer read-only
64 *
65 * At the start of BPF program the register R1 contains a pointer to bpf_context
66 * and has type PTR_TO_CTX.
67 *
68 * Verifier tracks arithmetic operations on pointers in case:
69 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
70 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
71 * 1st insn copies R10 (which has FRAME_PTR) type into R1
72 * and 2nd arithmetic instruction is pattern matched to recognize
73 * that it wants to construct a pointer to some element within stack.
74 * So after 2nd insn, the register R1 has type PTR_TO_STACK
75 * (and -20 constant is saved for further stack bounds checking).
76 * Meaning that this reg is a pointer to stack plus known immediate constant.
77 *
f1174f77 78 * Most of the time the registers have SCALAR_VALUE type, which
51580e79 79 * means the register has some value, but it's not a valid pointer.
f1174f77 80 * (like pointer plus pointer becomes SCALAR_VALUE type)
51580e79
AS
81 *
82 * When verifier sees load or store instructions the type of base register
c64b7983
JS
83 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK, PTR_TO_SOCKET. These are
84 * four pointer types recognized by check_mem_access() function.
51580e79
AS
85 *
86 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
87 * and the range of [ptr, ptr + map's value_size) is accessible.
88 *
89 * registers used to pass values to function calls are checked against
90 * function argument constraints.
91 *
92 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
93 * It means that the register type passed to this function must be
94 * PTR_TO_STACK and it will be used inside the function as
95 * 'pointer to map element key'
96 *
97 * For example the argument constraints for bpf_map_lookup_elem():
98 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
99 * .arg1_type = ARG_CONST_MAP_PTR,
100 * .arg2_type = ARG_PTR_TO_MAP_KEY,
101 *
102 * ret_type says that this function returns 'pointer to map elem value or null'
103 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
104 * 2nd argument should be a pointer to stack, which will be used inside
105 * the helper function as a pointer to map element key.
106 *
107 * On the kernel side the helper function looks like:
108 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
109 * {
110 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
111 * void *key = (void *) (unsigned long) r2;
112 * void *value;
113 *
114 * here kernel can access 'key' and 'map' pointers safely, knowing that
115 * [key, key + map->key_size) bytes are valid and were initialized on
116 * the stack of eBPF program.
117 * }
118 *
119 * Corresponding eBPF program may look like:
120 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
121 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
122 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
123 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
124 * here verifier looks at prototype of map_lookup_elem() and sees:
125 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
126 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
127 *
128 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
129 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
130 * and were initialized prior to this call.
131 * If it's ok, then verifier allows this BPF_CALL insn and looks at
132 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
133 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
134 * returns ether pointer to map value or NULL.
135 *
136 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
137 * insn, the register holding that pointer in the true branch changes state to
138 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
139 * branch. See check_cond_jmp_op().
140 *
141 * After the call R0 is set to return type of the function and registers R1-R5
142 * are set to NOT_INIT to indicate that they are no longer readable.
fd978bf7
JS
143 *
144 * The following reference types represent a potential reference to a kernel
145 * resource which, after first being allocated, must be checked and freed by
146 * the BPF program:
147 * - PTR_TO_SOCKET_OR_NULL, PTR_TO_SOCKET
148 *
149 * When the verifier sees a helper call return a reference type, it allocates a
150 * pointer id for the reference and stores it in the current function state.
151 * Similar to the way that PTR_TO_MAP_VALUE_OR_NULL is converted into
152 * PTR_TO_MAP_VALUE, PTR_TO_SOCKET_OR_NULL becomes PTR_TO_SOCKET when the type
153 * passes through a NULL-check conditional. For the branch wherein the state is
154 * changed to CONST_IMM, the verifier releases the reference.
6acc9b43
JS
155 *
156 * For each helper function that allocates a reference, such as
157 * bpf_sk_lookup_tcp(), there is a corresponding release function, such as
158 * bpf_sk_release(). When a reference type passes into the release function,
159 * the verifier also releases the reference. If any unchecked or unreleased
160 * reference remains at the end of the program, the verifier rejects it.
51580e79
AS
161 */
162
17a52670 163/* verifier_state + insn_idx are pushed to stack when branch is encountered */
58e2af8b 164struct bpf_verifier_stack_elem {
17a52670
AS
165 /* verifer state is 'st'
166 * before processing instruction 'insn_idx'
167 * and after processing instruction 'prev_insn_idx'
168 */
58e2af8b 169 struct bpf_verifier_state st;
17a52670
AS
170 int insn_idx;
171 int prev_insn_idx;
58e2af8b 172 struct bpf_verifier_stack_elem *next;
6f8a57cc
AN
173 /* length of verifier log at the time this state was pushed on stack */
174 u32 log_pos;
cbd35700
AS
175};
176
b285fcb7 177#define BPF_COMPLEXITY_LIMIT_JMP_SEQ 8192
ceefbc96 178#define BPF_COMPLEXITY_LIMIT_STATES 64
07016151 179
d2e4c1e6
DB
180#define BPF_MAP_KEY_POISON (1ULL << 63)
181#define BPF_MAP_KEY_SEEN (1ULL << 62)
182
c93552c4
DB
183#define BPF_MAP_PTR_UNPRIV 1UL
184#define BPF_MAP_PTR_POISON ((void *)((0xeB9FUL << 1) + \
185 POISON_POINTER_DELTA))
186#define BPF_MAP_PTR(X) ((struct bpf_map *)((X) & ~BPF_MAP_PTR_UNPRIV))
187
188static bool bpf_map_ptr_poisoned(const struct bpf_insn_aux_data *aux)
189{
d2e4c1e6 190 return BPF_MAP_PTR(aux->map_ptr_state) == BPF_MAP_PTR_POISON;
c93552c4
DB
191}
192
193static bool bpf_map_ptr_unpriv(const struct bpf_insn_aux_data *aux)
194{
d2e4c1e6 195 return aux->map_ptr_state & BPF_MAP_PTR_UNPRIV;
c93552c4
DB
196}
197
198static void bpf_map_ptr_store(struct bpf_insn_aux_data *aux,
199 const struct bpf_map *map, bool unpriv)
200{
201 BUILD_BUG_ON((unsigned long)BPF_MAP_PTR_POISON & BPF_MAP_PTR_UNPRIV);
202 unpriv |= bpf_map_ptr_unpriv(aux);
d2e4c1e6
DB
203 aux->map_ptr_state = (unsigned long)map |
204 (unpriv ? BPF_MAP_PTR_UNPRIV : 0UL);
205}
206
207static bool bpf_map_key_poisoned(const struct bpf_insn_aux_data *aux)
208{
209 return aux->map_key_state & BPF_MAP_KEY_POISON;
210}
211
212static bool bpf_map_key_unseen(const struct bpf_insn_aux_data *aux)
213{
214 return !(aux->map_key_state & BPF_MAP_KEY_SEEN);
215}
216
217static u64 bpf_map_key_immediate(const struct bpf_insn_aux_data *aux)
218{
219 return aux->map_key_state & ~(BPF_MAP_KEY_SEEN | BPF_MAP_KEY_POISON);
220}
221
222static void bpf_map_key_store(struct bpf_insn_aux_data *aux, u64 state)
223{
224 bool poisoned = bpf_map_key_poisoned(aux);
225
226 aux->map_key_state = state | BPF_MAP_KEY_SEEN |
227 (poisoned ? BPF_MAP_KEY_POISON : 0ULL);
c93552c4 228}
fad73a1a 229
33ff9823
DB
230struct bpf_call_arg_meta {
231 struct bpf_map *map_ptr;
435faee1 232 bool raw_mode;
36bbef52 233 bool pkt_access;
435faee1
DB
234 int regno;
235 int access_size;
457f4436 236 int mem_size;
10060503 237 u64 msize_max_value;
1b986589 238 int ref_obj_id;
d83525ca 239 int func_id;
a7658e1a 240 u32 btf_id;
33ff9823
DB
241};
242
8580ac94
AS
243struct btf *btf_vmlinux;
244
cbd35700
AS
245static DEFINE_MUTEX(bpf_verifier_lock);
246
d9762e84
MKL
247static const struct bpf_line_info *
248find_linfo(const struct bpf_verifier_env *env, u32 insn_off)
249{
250 const struct bpf_line_info *linfo;
251 const struct bpf_prog *prog;
252 u32 i, nr_linfo;
253
254 prog = env->prog;
255 nr_linfo = prog->aux->nr_linfo;
256
257 if (!nr_linfo || insn_off >= prog->len)
258 return NULL;
259
260 linfo = prog->aux->linfo;
261 for (i = 1; i < nr_linfo; i++)
262 if (insn_off < linfo[i].insn_off)
263 break;
264
265 return &linfo[i - 1];
266}
267
77d2e05a
MKL
268void bpf_verifier_vlog(struct bpf_verifier_log *log, const char *fmt,
269 va_list args)
cbd35700 270{
a2a7d570 271 unsigned int n;
cbd35700 272
a2a7d570 273 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
a2a7d570
JK
274
275 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
276 "verifier log line truncated - local buffer too short\n");
277
278 n = min(log->len_total - log->len_used - 1, n);
279 log->kbuf[n] = '\0';
280
8580ac94
AS
281 if (log->level == BPF_LOG_KERNEL) {
282 pr_err("BPF:%s\n", log->kbuf);
283 return;
284 }
a2a7d570
JK
285 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
286 log->len_used += n;
287 else
288 log->ubuf = NULL;
cbd35700 289}
abe08840 290
6f8a57cc
AN
291static void bpf_vlog_reset(struct bpf_verifier_log *log, u32 new_pos)
292{
293 char zero = 0;
294
295 if (!bpf_verifier_log_needed(log))
296 return;
297
298 log->len_used = new_pos;
299 if (put_user(zero, log->ubuf + new_pos))
300 log->ubuf = NULL;
301}
302
abe08840
JO
303/* log_level controls verbosity level of eBPF verifier.
304 * bpf_verifier_log_write() is used to dump the verification trace to the log,
305 * so the user can figure out what's wrong with the program
430e68d1 306 */
abe08840
JO
307__printf(2, 3) void bpf_verifier_log_write(struct bpf_verifier_env *env,
308 const char *fmt, ...)
309{
310 va_list args;
311
77d2e05a
MKL
312 if (!bpf_verifier_log_needed(&env->log))
313 return;
314
abe08840 315 va_start(args, fmt);
77d2e05a 316 bpf_verifier_vlog(&env->log, fmt, args);
abe08840
JO
317 va_end(args);
318}
319EXPORT_SYMBOL_GPL(bpf_verifier_log_write);
320
321__printf(2, 3) static void verbose(void *private_data, const char *fmt, ...)
322{
77d2e05a 323 struct bpf_verifier_env *env = private_data;
abe08840
JO
324 va_list args;
325
77d2e05a
MKL
326 if (!bpf_verifier_log_needed(&env->log))
327 return;
328
abe08840 329 va_start(args, fmt);
77d2e05a 330 bpf_verifier_vlog(&env->log, fmt, args);
abe08840
JO
331 va_end(args);
332}
cbd35700 333
9e15db66
AS
334__printf(2, 3) void bpf_log(struct bpf_verifier_log *log,
335 const char *fmt, ...)
336{
337 va_list args;
338
339 if (!bpf_verifier_log_needed(log))
340 return;
341
342 va_start(args, fmt);
343 bpf_verifier_vlog(log, fmt, args);
344 va_end(args);
345}
346
d9762e84
MKL
347static const char *ltrim(const char *s)
348{
349 while (isspace(*s))
350 s++;
351
352 return s;
353}
354
355__printf(3, 4) static void verbose_linfo(struct bpf_verifier_env *env,
356 u32 insn_off,
357 const char *prefix_fmt, ...)
358{
359 const struct bpf_line_info *linfo;
360
361 if (!bpf_verifier_log_needed(&env->log))
362 return;
363
364 linfo = find_linfo(env, insn_off);
365 if (!linfo || linfo == env->prev_linfo)
366 return;
367
368 if (prefix_fmt) {
369 va_list args;
370
371 va_start(args, prefix_fmt);
372 bpf_verifier_vlog(&env->log, prefix_fmt, args);
373 va_end(args);
374 }
375
376 verbose(env, "%s\n",
377 ltrim(btf_name_by_offset(env->prog->aux->btf,
378 linfo->line_off)));
379
380 env->prev_linfo = linfo;
381}
382
de8f3a83
DB
383static bool type_is_pkt_pointer(enum bpf_reg_type type)
384{
385 return type == PTR_TO_PACKET ||
386 type == PTR_TO_PACKET_META;
387}
388
46f8bc92
MKL
389static bool type_is_sk_pointer(enum bpf_reg_type type)
390{
391 return type == PTR_TO_SOCKET ||
655a51e5 392 type == PTR_TO_SOCK_COMMON ||
fada7fdc
JL
393 type == PTR_TO_TCP_SOCK ||
394 type == PTR_TO_XDP_SOCK;
46f8bc92
MKL
395}
396
cac616db
JF
397static bool reg_type_not_null(enum bpf_reg_type type)
398{
399 return type == PTR_TO_SOCKET ||
400 type == PTR_TO_TCP_SOCK ||
401 type == PTR_TO_MAP_VALUE ||
01c66c48 402 type == PTR_TO_SOCK_COMMON;
cac616db
JF
403}
404
840b9615
JS
405static bool reg_type_may_be_null(enum bpf_reg_type type)
406{
fd978bf7 407 return type == PTR_TO_MAP_VALUE_OR_NULL ||
46f8bc92 408 type == PTR_TO_SOCKET_OR_NULL ||
655a51e5 409 type == PTR_TO_SOCK_COMMON_OR_NULL ||
b121b341 410 type == PTR_TO_TCP_SOCK_OR_NULL ||
457f4436 411 type == PTR_TO_BTF_ID_OR_NULL ||
afbf21dc
YS
412 type == PTR_TO_MEM_OR_NULL ||
413 type == PTR_TO_RDONLY_BUF_OR_NULL ||
414 type == PTR_TO_RDWR_BUF_OR_NULL;
fd978bf7
JS
415}
416
d83525ca
AS
417static bool reg_may_point_to_spin_lock(const struct bpf_reg_state *reg)
418{
419 return reg->type == PTR_TO_MAP_VALUE &&
420 map_value_has_spin_lock(reg->map_ptr);
421}
422
cba368c1
MKL
423static bool reg_type_may_be_refcounted_or_null(enum bpf_reg_type type)
424{
425 return type == PTR_TO_SOCKET ||
426 type == PTR_TO_SOCKET_OR_NULL ||
427 type == PTR_TO_TCP_SOCK ||
457f4436
AN
428 type == PTR_TO_TCP_SOCK_OR_NULL ||
429 type == PTR_TO_MEM ||
430 type == PTR_TO_MEM_OR_NULL;
cba368c1
MKL
431}
432
1b986589 433static bool arg_type_may_be_refcounted(enum bpf_arg_type type)
fd978bf7 434{
1b986589 435 return type == ARG_PTR_TO_SOCK_COMMON;
fd978bf7
JS
436}
437
438/* Determine whether the function releases some resources allocated by another
439 * function call. The first reference type argument will be assumed to be
440 * released by release_reference().
441 */
442static bool is_release_function(enum bpf_func_id func_id)
443{
457f4436
AN
444 return func_id == BPF_FUNC_sk_release ||
445 func_id == BPF_FUNC_ringbuf_submit ||
446 func_id == BPF_FUNC_ringbuf_discard;
840b9615
JS
447}
448
64d85290 449static bool may_be_acquire_function(enum bpf_func_id func_id)
46f8bc92
MKL
450{
451 return func_id == BPF_FUNC_sk_lookup_tcp ||
edbf8c01 452 func_id == BPF_FUNC_sk_lookup_udp ||
64d85290 453 func_id == BPF_FUNC_skc_lookup_tcp ||
457f4436
AN
454 func_id == BPF_FUNC_map_lookup_elem ||
455 func_id == BPF_FUNC_ringbuf_reserve;
64d85290
JS
456}
457
458static bool is_acquire_function(enum bpf_func_id func_id,
459 const struct bpf_map *map)
460{
461 enum bpf_map_type map_type = map ? map->map_type : BPF_MAP_TYPE_UNSPEC;
462
463 if (func_id == BPF_FUNC_sk_lookup_tcp ||
464 func_id == BPF_FUNC_sk_lookup_udp ||
457f4436
AN
465 func_id == BPF_FUNC_skc_lookup_tcp ||
466 func_id == BPF_FUNC_ringbuf_reserve)
64d85290
JS
467 return true;
468
469 if (func_id == BPF_FUNC_map_lookup_elem &&
470 (map_type == BPF_MAP_TYPE_SOCKMAP ||
471 map_type == BPF_MAP_TYPE_SOCKHASH))
472 return true;
473
474 return false;
46f8bc92
MKL
475}
476
1b986589
MKL
477static bool is_ptr_cast_function(enum bpf_func_id func_id)
478{
479 return func_id == BPF_FUNC_tcp_sock ||
480 func_id == BPF_FUNC_sk_fullsock;
481}
482
17a52670
AS
483/* string representation of 'enum bpf_reg_type' */
484static const char * const reg_type_str[] = {
485 [NOT_INIT] = "?",
f1174f77 486 [SCALAR_VALUE] = "inv",
17a52670
AS
487 [PTR_TO_CTX] = "ctx",
488 [CONST_PTR_TO_MAP] = "map_ptr",
489 [PTR_TO_MAP_VALUE] = "map_value",
490 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
17a52670 491 [PTR_TO_STACK] = "fp",
969bf05e 492 [PTR_TO_PACKET] = "pkt",
de8f3a83 493 [PTR_TO_PACKET_META] = "pkt_meta",
969bf05e 494 [PTR_TO_PACKET_END] = "pkt_end",
d58e468b 495 [PTR_TO_FLOW_KEYS] = "flow_keys",
c64b7983
JS
496 [PTR_TO_SOCKET] = "sock",
497 [PTR_TO_SOCKET_OR_NULL] = "sock_or_null",
46f8bc92
MKL
498 [PTR_TO_SOCK_COMMON] = "sock_common",
499 [PTR_TO_SOCK_COMMON_OR_NULL] = "sock_common_or_null",
655a51e5
MKL
500 [PTR_TO_TCP_SOCK] = "tcp_sock",
501 [PTR_TO_TCP_SOCK_OR_NULL] = "tcp_sock_or_null",
9df1c28b 502 [PTR_TO_TP_BUFFER] = "tp_buffer",
fada7fdc 503 [PTR_TO_XDP_SOCK] = "xdp_sock",
9e15db66 504 [PTR_TO_BTF_ID] = "ptr_",
b121b341 505 [PTR_TO_BTF_ID_OR_NULL] = "ptr_or_null_",
457f4436
AN
506 [PTR_TO_MEM] = "mem",
507 [PTR_TO_MEM_OR_NULL] = "mem_or_null",
afbf21dc
YS
508 [PTR_TO_RDONLY_BUF] = "rdonly_buf",
509 [PTR_TO_RDONLY_BUF_OR_NULL] = "rdonly_buf_or_null",
510 [PTR_TO_RDWR_BUF] = "rdwr_buf",
511 [PTR_TO_RDWR_BUF_OR_NULL] = "rdwr_buf_or_null",
17a52670
AS
512};
513
8efea21d
EC
514static char slot_type_char[] = {
515 [STACK_INVALID] = '?',
516 [STACK_SPILL] = 'r',
517 [STACK_MISC] = 'm',
518 [STACK_ZERO] = '0',
519};
520
4e92024a
AS
521static void print_liveness(struct bpf_verifier_env *env,
522 enum bpf_reg_liveness live)
523{
9242b5f5 524 if (live & (REG_LIVE_READ | REG_LIVE_WRITTEN | REG_LIVE_DONE))
4e92024a
AS
525 verbose(env, "_");
526 if (live & REG_LIVE_READ)
527 verbose(env, "r");
528 if (live & REG_LIVE_WRITTEN)
529 verbose(env, "w");
9242b5f5
AS
530 if (live & REG_LIVE_DONE)
531 verbose(env, "D");
4e92024a
AS
532}
533
f4d7e40a
AS
534static struct bpf_func_state *func(struct bpf_verifier_env *env,
535 const struct bpf_reg_state *reg)
536{
537 struct bpf_verifier_state *cur = env->cur_state;
538
539 return cur->frame[reg->frameno];
540}
541
9e15db66
AS
542const char *kernel_type_name(u32 id)
543{
544 return btf_name_by_offset(btf_vmlinux,
545 btf_type_by_id(btf_vmlinux, id)->name_off);
546}
547
61bd5218 548static void print_verifier_state(struct bpf_verifier_env *env,
f4d7e40a 549 const struct bpf_func_state *state)
17a52670 550{
f4d7e40a 551 const struct bpf_reg_state *reg;
17a52670
AS
552 enum bpf_reg_type t;
553 int i;
554
f4d7e40a
AS
555 if (state->frameno)
556 verbose(env, " frame%d:", state->frameno);
17a52670 557 for (i = 0; i < MAX_BPF_REG; i++) {
1a0dc1ac
AS
558 reg = &state->regs[i];
559 t = reg->type;
17a52670
AS
560 if (t == NOT_INIT)
561 continue;
4e92024a
AS
562 verbose(env, " R%d", i);
563 print_liveness(env, reg->live);
564 verbose(env, "=%s", reg_type_str[t]);
b5dc0163
AS
565 if (t == SCALAR_VALUE && reg->precise)
566 verbose(env, "P");
f1174f77
EC
567 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
568 tnum_is_const(reg->var_off)) {
569 /* reg->off should be 0 for SCALAR_VALUE */
61bd5218 570 verbose(env, "%lld", reg->var_off.value + reg->off);
f1174f77 571 } else {
b121b341 572 if (t == PTR_TO_BTF_ID || t == PTR_TO_BTF_ID_OR_NULL)
9e15db66 573 verbose(env, "%s", kernel_type_name(reg->btf_id));
cba368c1
MKL
574 verbose(env, "(id=%d", reg->id);
575 if (reg_type_may_be_refcounted_or_null(t))
576 verbose(env, ",ref_obj_id=%d", reg->ref_obj_id);
f1174f77 577 if (t != SCALAR_VALUE)
61bd5218 578 verbose(env, ",off=%d", reg->off);
de8f3a83 579 if (type_is_pkt_pointer(t))
61bd5218 580 verbose(env, ",r=%d", reg->range);
f1174f77
EC
581 else if (t == CONST_PTR_TO_MAP ||
582 t == PTR_TO_MAP_VALUE ||
583 t == PTR_TO_MAP_VALUE_OR_NULL)
61bd5218 584 verbose(env, ",ks=%d,vs=%d",
f1174f77
EC
585 reg->map_ptr->key_size,
586 reg->map_ptr->value_size);
7d1238f2
EC
587 if (tnum_is_const(reg->var_off)) {
588 /* Typically an immediate SCALAR_VALUE, but
589 * could be a pointer whose offset is too big
590 * for reg->off
591 */
61bd5218 592 verbose(env, ",imm=%llx", reg->var_off.value);
7d1238f2
EC
593 } else {
594 if (reg->smin_value != reg->umin_value &&
595 reg->smin_value != S64_MIN)
61bd5218 596 verbose(env, ",smin_value=%lld",
7d1238f2
EC
597 (long long)reg->smin_value);
598 if (reg->smax_value != reg->umax_value &&
599 reg->smax_value != S64_MAX)
61bd5218 600 verbose(env, ",smax_value=%lld",
7d1238f2
EC
601 (long long)reg->smax_value);
602 if (reg->umin_value != 0)
61bd5218 603 verbose(env, ",umin_value=%llu",
7d1238f2
EC
604 (unsigned long long)reg->umin_value);
605 if (reg->umax_value != U64_MAX)
61bd5218 606 verbose(env, ",umax_value=%llu",
7d1238f2
EC
607 (unsigned long long)reg->umax_value);
608 if (!tnum_is_unknown(reg->var_off)) {
609 char tn_buf[48];
f1174f77 610
7d1238f2 611 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 612 verbose(env, ",var_off=%s", tn_buf);
7d1238f2 613 }
3f50f132
JF
614 if (reg->s32_min_value != reg->smin_value &&
615 reg->s32_min_value != S32_MIN)
616 verbose(env, ",s32_min_value=%d",
617 (int)(reg->s32_min_value));
618 if (reg->s32_max_value != reg->smax_value &&
619 reg->s32_max_value != S32_MAX)
620 verbose(env, ",s32_max_value=%d",
621 (int)(reg->s32_max_value));
622 if (reg->u32_min_value != reg->umin_value &&
623 reg->u32_min_value != U32_MIN)
624 verbose(env, ",u32_min_value=%d",
625 (int)(reg->u32_min_value));
626 if (reg->u32_max_value != reg->umax_value &&
627 reg->u32_max_value != U32_MAX)
628 verbose(env, ",u32_max_value=%d",
629 (int)(reg->u32_max_value));
f1174f77 630 }
61bd5218 631 verbose(env, ")");
f1174f77 632 }
17a52670 633 }
638f5b90 634 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
8efea21d
EC
635 char types_buf[BPF_REG_SIZE + 1];
636 bool valid = false;
637 int j;
638
639 for (j = 0; j < BPF_REG_SIZE; j++) {
640 if (state->stack[i].slot_type[j] != STACK_INVALID)
641 valid = true;
642 types_buf[j] = slot_type_char[
643 state->stack[i].slot_type[j]];
644 }
645 types_buf[BPF_REG_SIZE] = 0;
646 if (!valid)
647 continue;
648 verbose(env, " fp%d", (-i - 1) * BPF_REG_SIZE);
649 print_liveness(env, state->stack[i].spilled_ptr.live);
b5dc0163
AS
650 if (state->stack[i].slot_type[0] == STACK_SPILL) {
651 reg = &state->stack[i].spilled_ptr;
652 t = reg->type;
653 verbose(env, "=%s", reg_type_str[t]);
654 if (t == SCALAR_VALUE && reg->precise)
655 verbose(env, "P");
656 if (t == SCALAR_VALUE && tnum_is_const(reg->var_off))
657 verbose(env, "%lld", reg->var_off.value + reg->off);
658 } else {
8efea21d 659 verbose(env, "=%s", types_buf);
b5dc0163 660 }
17a52670 661 }
fd978bf7
JS
662 if (state->acquired_refs && state->refs[0].id) {
663 verbose(env, " refs=%d", state->refs[0].id);
664 for (i = 1; i < state->acquired_refs; i++)
665 if (state->refs[i].id)
666 verbose(env, ",%d", state->refs[i].id);
667 }
61bd5218 668 verbose(env, "\n");
17a52670
AS
669}
670
84dbf350
JS
671#define COPY_STATE_FN(NAME, COUNT, FIELD, SIZE) \
672static int copy_##NAME##_state(struct bpf_func_state *dst, \
673 const struct bpf_func_state *src) \
674{ \
675 if (!src->FIELD) \
676 return 0; \
677 if (WARN_ON_ONCE(dst->COUNT < src->COUNT)) { \
678 /* internal bug, make state invalid to reject the program */ \
679 memset(dst, 0, sizeof(*dst)); \
680 return -EFAULT; \
681 } \
682 memcpy(dst->FIELD, src->FIELD, \
683 sizeof(*src->FIELD) * (src->COUNT / SIZE)); \
684 return 0; \
638f5b90 685}
fd978bf7
JS
686/* copy_reference_state() */
687COPY_STATE_FN(reference, acquired_refs, refs, 1)
84dbf350
JS
688/* copy_stack_state() */
689COPY_STATE_FN(stack, allocated_stack, stack, BPF_REG_SIZE)
690#undef COPY_STATE_FN
691
692#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE) \
693static int realloc_##NAME##_state(struct bpf_func_state *state, int size, \
694 bool copy_old) \
695{ \
696 u32 old_size = state->COUNT; \
697 struct bpf_##NAME##_state *new_##FIELD; \
698 int slot = size / SIZE; \
699 \
700 if (size <= old_size || !size) { \
701 if (copy_old) \
702 return 0; \
703 state->COUNT = slot * SIZE; \
704 if (!size && old_size) { \
705 kfree(state->FIELD); \
706 state->FIELD = NULL; \
707 } \
708 return 0; \
709 } \
710 new_##FIELD = kmalloc_array(slot, sizeof(struct bpf_##NAME##_state), \
711 GFP_KERNEL); \
712 if (!new_##FIELD) \
713 return -ENOMEM; \
714 if (copy_old) { \
715 if (state->FIELD) \
716 memcpy(new_##FIELD, state->FIELD, \
717 sizeof(*new_##FIELD) * (old_size / SIZE)); \
718 memset(new_##FIELD + old_size / SIZE, 0, \
719 sizeof(*new_##FIELD) * (size - old_size) / SIZE); \
720 } \
721 state->COUNT = slot * SIZE; \
722 kfree(state->FIELD); \
723 state->FIELD = new_##FIELD; \
724 return 0; \
725}
fd978bf7
JS
726/* realloc_reference_state() */
727REALLOC_STATE_FN(reference, acquired_refs, refs, 1)
84dbf350
JS
728/* realloc_stack_state() */
729REALLOC_STATE_FN(stack, allocated_stack, stack, BPF_REG_SIZE)
730#undef REALLOC_STATE_FN
638f5b90
AS
731
732/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
733 * make it consume minimal amount of memory. check_stack_write() access from
f4d7e40a 734 * the program calls into realloc_func_state() to grow the stack size.
84dbf350
JS
735 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
736 * which realloc_stack_state() copies over. It points to previous
737 * bpf_verifier_state which is never reallocated.
638f5b90 738 */
fd978bf7
JS
739static int realloc_func_state(struct bpf_func_state *state, int stack_size,
740 int refs_size, bool copy_old)
638f5b90 741{
fd978bf7
JS
742 int err = realloc_reference_state(state, refs_size, copy_old);
743 if (err)
744 return err;
745 return realloc_stack_state(state, stack_size, copy_old);
746}
747
748/* Acquire a pointer id from the env and update the state->refs to include
749 * this new pointer reference.
750 * On success, returns a valid pointer id to associate with the register
751 * On failure, returns a negative errno.
638f5b90 752 */
fd978bf7 753static int acquire_reference_state(struct bpf_verifier_env *env, int insn_idx)
638f5b90 754{
fd978bf7
JS
755 struct bpf_func_state *state = cur_func(env);
756 int new_ofs = state->acquired_refs;
757 int id, err;
758
759 err = realloc_reference_state(state, state->acquired_refs + 1, true);
760 if (err)
761 return err;
762 id = ++env->id_gen;
763 state->refs[new_ofs].id = id;
764 state->refs[new_ofs].insn_idx = insn_idx;
638f5b90 765
fd978bf7
JS
766 return id;
767}
768
769/* release function corresponding to acquire_reference_state(). Idempotent. */
46f8bc92 770static int release_reference_state(struct bpf_func_state *state, int ptr_id)
fd978bf7
JS
771{
772 int i, last_idx;
773
fd978bf7
JS
774 last_idx = state->acquired_refs - 1;
775 for (i = 0; i < state->acquired_refs; i++) {
776 if (state->refs[i].id == ptr_id) {
777 if (last_idx && i != last_idx)
778 memcpy(&state->refs[i], &state->refs[last_idx],
779 sizeof(*state->refs));
780 memset(&state->refs[last_idx], 0, sizeof(*state->refs));
781 state->acquired_refs--;
638f5b90 782 return 0;
638f5b90 783 }
638f5b90 784 }
46f8bc92 785 return -EINVAL;
fd978bf7
JS
786}
787
788static int transfer_reference_state(struct bpf_func_state *dst,
789 struct bpf_func_state *src)
790{
791 int err = realloc_reference_state(dst, src->acquired_refs, false);
792 if (err)
793 return err;
794 err = copy_reference_state(dst, src);
795 if (err)
796 return err;
638f5b90
AS
797 return 0;
798}
799
f4d7e40a
AS
800static void free_func_state(struct bpf_func_state *state)
801{
5896351e
AS
802 if (!state)
803 return;
fd978bf7 804 kfree(state->refs);
f4d7e40a
AS
805 kfree(state->stack);
806 kfree(state);
807}
808
b5dc0163
AS
809static void clear_jmp_history(struct bpf_verifier_state *state)
810{
811 kfree(state->jmp_history);
812 state->jmp_history = NULL;
813 state->jmp_history_cnt = 0;
814}
815
1969db47
AS
816static void free_verifier_state(struct bpf_verifier_state *state,
817 bool free_self)
638f5b90 818{
f4d7e40a
AS
819 int i;
820
821 for (i = 0; i <= state->curframe; i++) {
822 free_func_state(state->frame[i]);
823 state->frame[i] = NULL;
824 }
b5dc0163 825 clear_jmp_history(state);
1969db47
AS
826 if (free_self)
827 kfree(state);
638f5b90
AS
828}
829
830/* copy verifier state from src to dst growing dst stack space
831 * when necessary to accommodate larger src stack
832 */
f4d7e40a
AS
833static int copy_func_state(struct bpf_func_state *dst,
834 const struct bpf_func_state *src)
638f5b90
AS
835{
836 int err;
837
fd978bf7
JS
838 err = realloc_func_state(dst, src->allocated_stack, src->acquired_refs,
839 false);
840 if (err)
841 return err;
842 memcpy(dst, src, offsetof(struct bpf_func_state, acquired_refs));
843 err = copy_reference_state(dst, src);
638f5b90
AS
844 if (err)
845 return err;
638f5b90
AS
846 return copy_stack_state(dst, src);
847}
848
f4d7e40a
AS
849static int copy_verifier_state(struct bpf_verifier_state *dst_state,
850 const struct bpf_verifier_state *src)
851{
852 struct bpf_func_state *dst;
b5dc0163 853 u32 jmp_sz = sizeof(struct bpf_idx_pair) * src->jmp_history_cnt;
f4d7e40a
AS
854 int i, err;
855
b5dc0163
AS
856 if (dst_state->jmp_history_cnt < src->jmp_history_cnt) {
857 kfree(dst_state->jmp_history);
858 dst_state->jmp_history = kmalloc(jmp_sz, GFP_USER);
859 if (!dst_state->jmp_history)
860 return -ENOMEM;
861 }
862 memcpy(dst_state->jmp_history, src->jmp_history, jmp_sz);
863 dst_state->jmp_history_cnt = src->jmp_history_cnt;
864
f4d7e40a
AS
865 /* if dst has more stack frames then src frame, free them */
866 for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
867 free_func_state(dst_state->frame[i]);
868 dst_state->frame[i] = NULL;
869 }
979d63d5 870 dst_state->speculative = src->speculative;
f4d7e40a 871 dst_state->curframe = src->curframe;
d83525ca 872 dst_state->active_spin_lock = src->active_spin_lock;
2589726d
AS
873 dst_state->branches = src->branches;
874 dst_state->parent = src->parent;
b5dc0163
AS
875 dst_state->first_insn_idx = src->first_insn_idx;
876 dst_state->last_insn_idx = src->last_insn_idx;
f4d7e40a
AS
877 for (i = 0; i <= src->curframe; i++) {
878 dst = dst_state->frame[i];
879 if (!dst) {
880 dst = kzalloc(sizeof(*dst), GFP_KERNEL);
881 if (!dst)
882 return -ENOMEM;
883 dst_state->frame[i] = dst;
884 }
885 err = copy_func_state(dst, src->frame[i]);
886 if (err)
887 return err;
888 }
889 return 0;
890}
891
2589726d
AS
892static void update_branch_counts(struct bpf_verifier_env *env, struct bpf_verifier_state *st)
893{
894 while (st) {
895 u32 br = --st->branches;
896
897 /* WARN_ON(br > 1) technically makes sense here,
898 * but see comment in push_stack(), hence:
899 */
900 WARN_ONCE((int)br < 0,
901 "BUG update_branch_counts:branches_to_explore=%d\n",
902 br);
903 if (br)
904 break;
905 st = st->parent;
906 }
907}
908
638f5b90 909static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
6f8a57cc 910 int *insn_idx, bool pop_log)
638f5b90
AS
911{
912 struct bpf_verifier_state *cur = env->cur_state;
913 struct bpf_verifier_stack_elem *elem, *head = env->head;
914 int err;
17a52670
AS
915
916 if (env->head == NULL)
638f5b90 917 return -ENOENT;
17a52670 918
638f5b90
AS
919 if (cur) {
920 err = copy_verifier_state(cur, &head->st);
921 if (err)
922 return err;
923 }
6f8a57cc
AN
924 if (pop_log)
925 bpf_vlog_reset(&env->log, head->log_pos);
638f5b90
AS
926 if (insn_idx)
927 *insn_idx = head->insn_idx;
17a52670 928 if (prev_insn_idx)
638f5b90
AS
929 *prev_insn_idx = head->prev_insn_idx;
930 elem = head->next;
1969db47 931 free_verifier_state(&head->st, false);
638f5b90 932 kfree(head);
17a52670
AS
933 env->head = elem;
934 env->stack_size--;
638f5b90 935 return 0;
17a52670
AS
936}
937
58e2af8b 938static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
979d63d5
DB
939 int insn_idx, int prev_insn_idx,
940 bool speculative)
17a52670 941{
638f5b90 942 struct bpf_verifier_state *cur = env->cur_state;
58e2af8b 943 struct bpf_verifier_stack_elem *elem;
638f5b90 944 int err;
17a52670 945
638f5b90 946 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
17a52670
AS
947 if (!elem)
948 goto err;
949
17a52670
AS
950 elem->insn_idx = insn_idx;
951 elem->prev_insn_idx = prev_insn_idx;
952 elem->next = env->head;
6f8a57cc 953 elem->log_pos = env->log.len_used;
17a52670
AS
954 env->head = elem;
955 env->stack_size++;
1969db47
AS
956 err = copy_verifier_state(&elem->st, cur);
957 if (err)
958 goto err;
979d63d5 959 elem->st.speculative |= speculative;
b285fcb7
AS
960 if (env->stack_size > BPF_COMPLEXITY_LIMIT_JMP_SEQ) {
961 verbose(env, "The sequence of %d jumps is too complex.\n",
962 env->stack_size);
17a52670
AS
963 goto err;
964 }
2589726d
AS
965 if (elem->st.parent) {
966 ++elem->st.parent->branches;
967 /* WARN_ON(branches > 2) technically makes sense here,
968 * but
969 * 1. speculative states will bump 'branches' for non-branch
970 * instructions
971 * 2. is_state_visited() heuristics may decide not to create
972 * a new state for a sequence of branches and all such current
973 * and cloned states will be pointing to a single parent state
974 * which might have large 'branches' count.
975 */
976 }
17a52670
AS
977 return &elem->st;
978err:
5896351e
AS
979 free_verifier_state(env->cur_state, true);
980 env->cur_state = NULL;
17a52670 981 /* pop all elements and return */
6f8a57cc 982 while (!pop_stack(env, NULL, NULL, false));
17a52670
AS
983 return NULL;
984}
985
986#define CALLER_SAVED_REGS 6
987static const int caller_saved[CALLER_SAVED_REGS] = {
988 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
989};
990
f54c7898
DB
991static void __mark_reg_not_init(const struct bpf_verifier_env *env,
992 struct bpf_reg_state *reg);
f1174f77 993
b03c9f9f
EC
994/* Mark the unknown part of a register (variable offset or scalar value) as
995 * known to have the value @imm.
996 */
997static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
998{
a9c676bc
AS
999 /* Clear id, off, and union(map_ptr, range) */
1000 memset(((u8 *)reg) + sizeof(reg->type), 0,
1001 offsetof(struct bpf_reg_state, var_off) - sizeof(reg->type));
b03c9f9f
EC
1002 reg->var_off = tnum_const(imm);
1003 reg->smin_value = (s64)imm;
1004 reg->smax_value = (s64)imm;
1005 reg->umin_value = imm;
1006 reg->umax_value = imm;
3f50f132
JF
1007
1008 reg->s32_min_value = (s32)imm;
1009 reg->s32_max_value = (s32)imm;
1010 reg->u32_min_value = (u32)imm;
1011 reg->u32_max_value = (u32)imm;
1012}
1013
1014static void __mark_reg32_known(struct bpf_reg_state *reg, u64 imm)
1015{
1016 reg->var_off = tnum_const_subreg(reg->var_off, imm);
1017 reg->s32_min_value = (s32)imm;
1018 reg->s32_max_value = (s32)imm;
1019 reg->u32_min_value = (u32)imm;
1020 reg->u32_max_value = (u32)imm;
b03c9f9f
EC
1021}
1022
f1174f77
EC
1023/* Mark the 'variable offset' part of a register as zero. This should be
1024 * used only on registers holding a pointer type.
1025 */
1026static void __mark_reg_known_zero(struct bpf_reg_state *reg)
a9789ef9 1027{
b03c9f9f 1028 __mark_reg_known(reg, 0);
f1174f77 1029}
a9789ef9 1030
cc2b14d5
AS
1031static void __mark_reg_const_zero(struct bpf_reg_state *reg)
1032{
1033 __mark_reg_known(reg, 0);
cc2b14d5
AS
1034 reg->type = SCALAR_VALUE;
1035}
1036
61bd5218
JK
1037static void mark_reg_known_zero(struct bpf_verifier_env *env,
1038 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
1039{
1040 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 1041 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
f1174f77
EC
1042 /* Something bad happened, let's kill all regs */
1043 for (regno = 0; regno < MAX_BPF_REG; regno++)
f54c7898 1044 __mark_reg_not_init(env, regs + regno);
f1174f77
EC
1045 return;
1046 }
1047 __mark_reg_known_zero(regs + regno);
1048}
1049
de8f3a83
DB
1050static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
1051{
1052 return type_is_pkt_pointer(reg->type);
1053}
1054
1055static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
1056{
1057 return reg_is_pkt_pointer(reg) ||
1058 reg->type == PTR_TO_PACKET_END;
1059}
1060
1061/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
1062static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
1063 enum bpf_reg_type which)
1064{
1065 /* The register can already have a range from prior markings.
1066 * This is fine as long as it hasn't been advanced from its
1067 * origin.
1068 */
1069 return reg->type == which &&
1070 reg->id == 0 &&
1071 reg->off == 0 &&
1072 tnum_equals_const(reg->var_off, 0);
1073}
1074
3f50f132
JF
1075/* Reset the min/max bounds of a register */
1076static void __mark_reg_unbounded(struct bpf_reg_state *reg)
1077{
1078 reg->smin_value = S64_MIN;
1079 reg->smax_value = S64_MAX;
1080 reg->umin_value = 0;
1081 reg->umax_value = U64_MAX;
1082
1083 reg->s32_min_value = S32_MIN;
1084 reg->s32_max_value = S32_MAX;
1085 reg->u32_min_value = 0;
1086 reg->u32_max_value = U32_MAX;
1087}
1088
1089static void __mark_reg64_unbounded(struct bpf_reg_state *reg)
1090{
1091 reg->smin_value = S64_MIN;
1092 reg->smax_value = S64_MAX;
1093 reg->umin_value = 0;
1094 reg->umax_value = U64_MAX;
1095}
1096
1097static void __mark_reg32_unbounded(struct bpf_reg_state *reg)
1098{
1099 reg->s32_min_value = S32_MIN;
1100 reg->s32_max_value = S32_MAX;
1101 reg->u32_min_value = 0;
1102 reg->u32_max_value = U32_MAX;
1103}
1104
1105static void __update_reg32_bounds(struct bpf_reg_state *reg)
1106{
1107 struct tnum var32_off = tnum_subreg(reg->var_off);
1108
1109 /* min signed is max(sign bit) | min(other bits) */
1110 reg->s32_min_value = max_t(s32, reg->s32_min_value,
1111 var32_off.value | (var32_off.mask & S32_MIN));
1112 /* max signed is min(sign bit) | max(other bits) */
1113 reg->s32_max_value = min_t(s32, reg->s32_max_value,
1114 var32_off.value | (var32_off.mask & S32_MAX));
1115 reg->u32_min_value = max_t(u32, reg->u32_min_value, (u32)var32_off.value);
1116 reg->u32_max_value = min(reg->u32_max_value,
1117 (u32)(var32_off.value | var32_off.mask));
1118}
1119
1120static void __update_reg64_bounds(struct bpf_reg_state *reg)
b03c9f9f
EC
1121{
1122 /* min signed is max(sign bit) | min(other bits) */
1123 reg->smin_value = max_t(s64, reg->smin_value,
1124 reg->var_off.value | (reg->var_off.mask & S64_MIN));
1125 /* max signed is min(sign bit) | max(other bits) */
1126 reg->smax_value = min_t(s64, reg->smax_value,
1127 reg->var_off.value | (reg->var_off.mask & S64_MAX));
1128 reg->umin_value = max(reg->umin_value, reg->var_off.value);
1129 reg->umax_value = min(reg->umax_value,
1130 reg->var_off.value | reg->var_off.mask);
1131}
1132
3f50f132
JF
1133static void __update_reg_bounds(struct bpf_reg_state *reg)
1134{
1135 __update_reg32_bounds(reg);
1136 __update_reg64_bounds(reg);
1137}
1138
b03c9f9f 1139/* Uses signed min/max values to inform unsigned, and vice-versa */
3f50f132
JF
1140static void __reg32_deduce_bounds(struct bpf_reg_state *reg)
1141{
1142 /* Learn sign from signed bounds.
1143 * If we cannot cross the sign boundary, then signed and unsigned bounds
1144 * are the same, so combine. This works even in the negative case, e.g.
1145 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
1146 */
1147 if (reg->s32_min_value >= 0 || reg->s32_max_value < 0) {
1148 reg->s32_min_value = reg->u32_min_value =
1149 max_t(u32, reg->s32_min_value, reg->u32_min_value);
1150 reg->s32_max_value = reg->u32_max_value =
1151 min_t(u32, reg->s32_max_value, reg->u32_max_value);
1152 return;
1153 }
1154 /* Learn sign from unsigned bounds. Signed bounds cross the sign
1155 * boundary, so we must be careful.
1156 */
1157 if ((s32)reg->u32_max_value >= 0) {
1158 /* Positive. We can't learn anything from the smin, but smax
1159 * is positive, hence safe.
1160 */
1161 reg->s32_min_value = reg->u32_min_value;
1162 reg->s32_max_value = reg->u32_max_value =
1163 min_t(u32, reg->s32_max_value, reg->u32_max_value);
1164 } else if ((s32)reg->u32_min_value < 0) {
1165 /* Negative. We can't learn anything from the smax, but smin
1166 * is negative, hence safe.
1167 */
1168 reg->s32_min_value = reg->u32_min_value =
1169 max_t(u32, reg->s32_min_value, reg->u32_min_value);
1170 reg->s32_max_value = reg->u32_max_value;
1171 }
1172}
1173
1174static void __reg64_deduce_bounds(struct bpf_reg_state *reg)
b03c9f9f
EC
1175{
1176 /* Learn sign from signed bounds.
1177 * If we cannot cross the sign boundary, then signed and unsigned bounds
1178 * are the same, so combine. This works even in the negative case, e.g.
1179 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
1180 */
1181 if (reg->smin_value >= 0 || reg->smax_value < 0) {
1182 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
1183 reg->umin_value);
1184 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
1185 reg->umax_value);
1186 return;
1187 }
1188 /* Learn sign from unsigned bounds. Signed bounds cross the sign
1189 * boundary, so we must be careful.
1190 */
1191 if ((s64)reg->umax_value >= 0) {
1192 /* Positive. We can't learn anything from the smin, but smax
1193 * is positive, hence safe.
1194 */
1195 reg->smin_value = reg->umin_value;
1196 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
1197 reg->umax_value);
1198 } else if ((s64)reg->umin_value < 0) {
1199 /* Negative. We can't learn anything from the smax, but smin
1200 * is negative, hence safe.
1201 */
1202 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
1203 reg->umin_value);
1204 reg->smax_value = reg->umax_value;
1205 }
1206}
1207
3f50f132
JF
1208static void __reg_deduce_bounds(struct bpf_reg_state *reg)
1209{
1210 __reg32_deduce_bounds(reg);
1211 __reg64_deduce_bounds(reg);
1212}
1213
b03c9f9f
EC
1214/* Attempts to improve var_off based on unsigned min/max information */
1215static void __reg_bound_offset(struct bpf_reg_state *reg)
1216{
3f50f132
JF
1217 struct tnum var64_off = tnum_intersect(reg->var_off,
1218 tnum_range(reg->umin_value,
1219 reg->umax_value));
1220 struct tnum var32_off = tnum_intersect(tnum_subreg(reg->var_off),
1221 tnum_range(reg->u32_min_value,
1222 reg->u32_max_value));
1223
1224 reg->var_off = tnum_or(tnum_clear_subreg(var64_off), var32_off);
b03c9f9f
EC
1225}
1226
3f50f132 1227static void __reg_assign_32_into_64(struct bpf_reg_state *reg)
b03c9f9f 1228{
3f50f132
JF
1229 reg->umin_value = reg->u32_min_value;
1230 reg->umax_value = reg->u32_max_value;
1231 /* Attempt to pull 32-bit signed bounds into 64-bit bounds
1232 * but must be positive otherwise set to worse case bounds
1233 * and refine later from tnum.
1234 */
3a71dc36 1235 if (reg->s32_min_value >= 0 && reg->s32_max_value >= 0)
3f50f132
JF
1236 reg->smax_value = reg->s32_max_value;
1237 else
1238 reg->smax_value = U32_MAX;
3a71dc36
JF
1239 if (reg->s32_min_value >= 0)
1240 reg->smin_value = reg->s32_min_value;
1241 else
1242 reg->smin_value = 0;
3f50f132
JF
1243}
1244
1245static void __reg_combine_32_into_64(struct bpf_reg_state *reg)
1246{
1247 /* special case when 64-bit register has upper 32-bit register
1248 * zeroed. Typically happens after zext or <<32, >>32 sequence
1249 * allowing us to use 32-bit bounds directly,
1250 */
1251 if (tnum_equals_const(tnum_clear_subreg(reg->var_off), 0)) {
1252 __reg_assign_32_into_64(reg);
1253 } else {
1254 /* Otherwise the best we can do is push lower 32bit known and
1255 * unknown bits into register (var_off set from jmp logic)
1256 * then learn as much as possible from the 64-bit tnum
1257 * known and unknown bits. The previous smin/smax bounds are
1258 * invalid here because of jmp32 compare so mark them unknown
1259 * so they do not impact tnum bounds calculation.
1260 */
1261 __mark_reg64_unbounded(reg);
1262 __update_reg_bounds(reg);
1263 }
1264
1265 /* Intersecting with the old var_off might have improved our bounds
1266 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
1267 * then new var_off is (0; 0x7f...fc) which improves our umax.
1268 */
1269 __reg_deduce_bounds(reg);
1270 __reg_bound_offset(reg);
1271 __update_reg_bounds(reg);
1272}
1273
1274static bool __reg64_bound_s32(s64 a)
1275{
1276 if (a > S32_MIN && a < S32_MAX)
1277 return true;
1278 return false;
1279}
1280
1281static bool __reg64_bound_u32(u64 a)
1282{
1283 if (a > U32_MIN && a < U32_MAX)
1284 return true;
1285 return false;
1286}
1287
1288static void __reg_combine_64_into_32(struct bpf_reg_state *reg)
1289{
1290 __mark_reg32_unbounded(reg);
1291
1292 if (__reg64_bound_s32(reg->smin_value))
1293 reg->s32_min_value = (s32)reg->smin_value;
1294 if (__reg64_bound_s32(reg->smax_value))
1295 reg->s32_max_value = (s32)reg->smax_value;
1296 if (__reg64_bound_u32(reg->umin_value))
1297 reg->u32_min_value = (u32)reg->umin_value;
1298 if (__reg64_bound_u32(reg->umax_value))
1299 reg->u32_max_value = (u32)reg->umax_value;
1300
1301 /* Intersecting with the old var_off might have improved our bounds
1302 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
1303 * then new var_off is (0; 0x7f...fc) which improves our umax.
1304 */
1305 __reg_deduce_bounds(reg);
1306 __reg_bound_offset(reg);
1307 __update_reg_bounds(reg);
b03c9f9f
EC
1308}
1309
f1174f77 1310/* Mark a register as having a completely unknown (scalar) value. */
f54c7898
DB
1311static void __mark_reg_unknown(const struct bpf_verifier_env *env,
1312 struct bpf_reg_state *reg)
f1174f77 1313{
a9c676bc
AS
1314 /*
1315 * Clear type, id, off, and union(map_ptr, range) and
1316 * padding between 'type' and union
1317 */
1318 memset(reg, 0, offsetof(struct bpf_reg_state, var_off));
f1174f77 1319 reg->type = SCALAR_VALUE;
f1174f77 1320 reg->var_off = tnum_unknown;
f4d7e40a 1321 reg->frameno = 0;
2c78ee89 1322 reg->precise = env->subprog_cnt > 1 || !env->bpf_capable;
b03c9f9f 1323 __mark_reg_unbounded(reg);
f1174f77
EC
1324}
1325
61bd5218
JK
1326static void mark_reg_unknown(struct bpf_verifier_env *env,
1327 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
1328{
1329 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 1330 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
19ceb417
AS
1331 /* Something bad happened, let's kill all regs except FP */
1332 for (regno = 0; regno < BPF_REG_FP; regno++)
f54c7898 1333 __mark_reg_not_init(env, regs + regno);
f1174f77
EC
1334 return;
1335 }
f54c7898 1336 __mark_reg_unknown(env, regs + regno);
f1174f77
EC
1337}
1338
f54c7898
DB
1339static void __mark_reg_not_init(const struct bpf_verifier_env *env,
1340 struct bpf_reg_state *reg)
f1174f77 1341{
f54c7898 1342 __mark_reg_unknown(env, reg);
f1174f77
EC
1343 reg->type = NOT_INIT;
1344}
1345
61bd5218
JK
1346static void mark_reg_not_init(struct bpf_verifier_env *env,
1347 struct bpf_reg_state *regs, u32 regno)
f1174f77
EC
1348{
1349 if (WARN_ON(regno >= MAX_BPF_REG)) {
61bd5218 1350 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
19ceb417
AS
1351 /* Something bad happened, let's kill all regs except FP */
1352 for (regno = 0; regno < BPF_REG_FP; regno++)
f54c7898 1353 __mark_reg_not_init(env, regs + regno);
f1174f77
EC
1354 return;
1355 }
f54c7898 1356 __mark_reg_not_init(env, regs + regno);
a9789ef9
DB
1357}
1358
41c48f3a
AI
1359static void mark_btf_ld_reg(struct bpf_verifier_env *env,
1360 struct bpf_reg_state *regs, u32 regno,
1361 enum bpf_reg_type reg_type, u32 btf_id)
1362{
1363 if (reg_type == SCALAR_VALUE) {
1364 mark_reg_unknown(env, regs, regno);
1365 return;
1366 }
1367 mark_reg_known_zero(env, regs, regno);
1368 regs[regno].type = PTR_TO_BTF_ID;
1369 regs[regno].btf_id = btf_id;
1370}
1371
5327ed3d 1372#define DEF_NOT_SUBREG (0)
61bd5218 1373static void init_reg_state(struct bpf_verifier_env *env,
f4d7e40a 1374 struct bpf_func_state *state)
17a52670 1375{
f4d7e40a 1376 struct bpf_reg_state *regs = state->regs;
17a52670
AS
1377 int i;
1378
dc503a8a 1379 for (i = 0; i < MAX_BPF_REG; i++) {
61bd5218 1380 mark_reg_not_init(env, regs, i);
dc503a8a 1381 regs[i].live = REG_LIVE_NONE;
679c782d 1382 regs[i].parent = NULL;
5327ed3d 1383 regs[i].subreg_def = DEF_NOT_SUBREG;
dc503a8a 1384 }
17a52670
AS
1385
1386 /* frame pointer */
f1174f77 1387 regs[BPF_REG_FP].type = PTR_TO_STACK;
61bd5218 1388 mark_reg_known_zero(env, regs, BPF_REG_FP);
f4d7e40a 1389 regs[BPF_REG_FP].frameno = state->frameno;
6760bf2d
DB
1390}
1391
f4d7e40a
AS
1392#define BPF_MAIN_FUNC (-1)
1393static void init_func_state(struct bpf_verifier_env *env,
1394 struct bpf_func_state *state,
1395 int callsite, int frameno, int subprogno)
1396{
1397 state->callsite = callsite;
1398 state->frameno = frameno;
1399 state->subprogno = subprogno;
1400 init_reg_state(env, state);
1401}
1402
17a52670
AS
1403enum reg_arg_type {
1404 SRC_OP, /* register is used as source operand */
1405 DST_OP, /* register is used as destination operand */
1406 DST_OP_NO_MARK /* same as above, check only, don't mark */
1407};
1408
cc8b0b92
AS
1409static int cmp_subprogs(const void *a, const void *b)
1410{
9c8105bd
JW
1411 return ((struct bpf_subprog_info *)a)->start -
1412 ((struct bpf_subprog_info *)b)->start;
cc8b0b92
AS
1413}
1414
1415static int find_subprog(struct bpf_verifier_env *env, int off)
1416{
9c8105bd 1417 struct bpf_subprog_info *p;
cc8b0b92 1418
9c8105bd
JW
1419 p = bsearch(&off, env->subprog_info, env->subprog_cnt,
1420 sizeof(env->subprog_info[0]), cmp_subprogs);
cc8b0b92
AS
1421 if (!p)
1422 return -ENOENT;
9c8105bd 1423 return p - env->subprog_info;
cc8b0b92
AS
1424
1425}
1426
1427static int add_subprog(struct bpf_verifier_env *env, int off)
1428{
1429 int insn_cnt = env->prog->len;
1430 int ret;
1431
1432 if (off >= insn_cnt || off < 0) {
1433 verbose(env, "call to invalid destination\n");
1434 return -EINVAL;
1435 }
1436 ret = find_subprog(env, off);
1437 if (ret >= 0)
1438 return 0;
4cb3d99c 1439 if (env->subprog_cnt >= BPF_MAX_SUBPROGS) {
cc8b0b92
AS
1440 verbose(env, "too many subprograms\n");
1441 return -E2BIG;
1442 }
9c8105bd
JW
1443 env->subprog_info[env->subprog_cnt++].start = off;
1444 sort(env->subprog_info, env->subprog_cnt,
1445 sizeof(env->subprog_info[0]), cmp_subprogs, NULL);
cc8b0b92
AS
1446 return 0;
1447}
1448
1449static int check_subprogs(struct bpf_verifier_env *env)
1450{
1451 int i, ret, subprog_start, subprog_end, off, cur_subprog = 0;
9c8105bd 1452 struct bpf_subprog_info *subprog = env->subprog_info;
cc8b0b92
AS
1453 struct bpf_insn *insn = env->prog->insnsi;
1454 int insn_cnt = env->prog->len;
1455
f910cefa
JW
1456 /* Add entry function. */
1457 ret = add_subprog(env, 0);
1458 if (ret < 0)
1459 return ret;
1460
cc8b0b92
AS
1461 /* determine subprog starts. The end is one before the next starts */
1462 for (i = 0; i < insn_cnt; i++) {
1463 if (insn[i].code != (BPF_JMP | BPF_CALL))
1464 continue;
1465 if (insn[i].src_reg != BPF_PSEUDO_CALL)
1466 continue;
2c78ee89
AS
1467 if (!env->bpf_capable) {
1468 verbose(env,
1469 "function calls to other bpf functions are allowed for CAP_BPF and CAP_SYS_ADMIN\n");
cc8b0b92
AS
1470 return -EPERM;
1471 }
cc8b0b92
AS
1472 ret = add_subprog(env, i + insn[i].imm + 1);
1473 if (ret < 0)
1474 return ret;
1475 }
1476
4cb3d99c
JW
1477 /* Add a fake 'exit' subprog which could simplify subprog iteration
1478 * logic. 'subprog_cnt' should not be increased.
1479 */
1480 subprog[env->subprog_cnt].start = insn_cnt;
1481
06ee7115 1482 if (env->log.level & BPF_LOG_LEVEL2)
cc8b0b92 1483 for (i = 0; i < env->subprog_cnt; i++)
9c8105bd 1484 verbose(env, "func#%d @%d\n", i, subprog[i].start);
cc8b0b92
AS
1485
1486 /* now check that all jumps are within the same subprog */
4cb3d99c
JW
1487 subprog_start = subprog[cur_subprog].start;
1488 subprog_end = subprog[cur_subprog + 1].start;
cc8b0b92
AS
1489 for (i = 0; i < insn_cnt; i++) {
1490 u8 code = insn[i].code;
1491
092ed096 1492 if (BPF_CLASS(code) != BPF_JMP && BPF_CLASS(code) != BPF_JMP32)
cc8b0b92
AS
1493 goto next;
1494 if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
1495 goto next;
1496 off = i + insn[i].off + 1;
1497 if (off < subprog_start || off >= subprog_end) {
1498 verbose(env, "jump out of range from insn %d to %d\n", i, off);
1499 return -EINVAL;
1500 }
1501next:
1502 if (i == subprog_end - 1) {
1503 /* to avoid fall-through from one subprog into another
1504 * the last insn of the subprog should be either exit
1505 * or unconditional jump back
1506 */
1507 if (code != (BPF_JMP | BPF_EXIT) &&
1508 code != (BPF_JMP | BPF_JA)) {
1509 verbose(env, "last insn is not an exit or jmp\n");
1510 return -EINVAL;
1511 }
1512 subprog_start = subprog_end;
4cb3d99c
JW
1513 cur_subprog++;
1514 if (cur_subprog < env->subprog_cnt)
9c8105bd 1515 subprog_end = subprog[cur_subprog + 1].start;
cc8b0b92
AS
1516 }
1517 }
1518 return 0;
1519}
1520
679c782d
EC
1521/* Parentage chain of this register (or stack slot) should take care of all
1522 * issues like callee-saved registers, stack slot allocation time, etc.
1523 */
f4d7e40a 1524static int mark_reg_read(struct bpf_verifier_env *env,
679c782d 1525 const struct bpf_reg_state *state,
5327ed3d 1526 struct bpf_reg_state *parent, u8 flag)
f4d7e40a
AS
1527{
1528 bool writes = parent == state->parent; /* Observe write marks */
06ee7115 1529 int cnt = 0;
dc503a8a
EC
1530
1531 while (parent) {
1532 /* if read wasn't screened by an earlier write ... */
679c782d 1533 if (writes && state->live & REG_LIVE_WRITTEN)
dc503a8a 1534 break;
9242b5f5
AS
1535 if (parent->live & REG_LIVE_DONE) {
1536 verbose(env, "verifier BUG type %s var_off %lld off %d\n",
1537 reg_type_str[parent->type],
1538 parent->var_off.value, parent->off);
1539 return -EFAULT;
1540 }
5327ed3d
JW
1541 /* The first condition is more likely to be true than the
1542 * second, checked it first.
1543 */
1544 if ((parent->live & REG_LIVE_READ) == flag ||
1545 parent->live & REG_LIVE_READ64)
25af32da
AS
1546 /* The parentage chain never changes and
1547 * this parent was already marked as LIVE_READ.
1548 * There is no need to keep walking the chain again and
1549 * keep re-marking all parents as LIVE_READ.
1550 * This case happens when the same register is read
1551 * multiple times without writes into it in-between.
5327ed3d
JW
1552 * Also, if parent has the stronger REG_LIVE_READ64 set,
1553 * then no need to set the weak REG_LIVE_READ32.
25af32da
AS
1554 */
1555 break;
dc503a8a 1556 /* ... then we depend on parent's value */
5327ed3d
JW
1557 parent->live |= flag;
1558 /* REG_LIVE_READ64 overrides REG_LIVE_READ32. */
1559 if (flag == REG_LIVE_READ64)
1560 parent->live &= ~REG_LIVE_READ32;
dc503a8a
EC
1561 state = parent;
1562 parent = state->parent;
f4d7e40a 1563 writes = true;
06ee7115 1564 cnt++;
dc503a8a 1565 }
06ee7115
AS
1566
1567 if (env->longest_mark_read_walk < cnt)
1568 env->longest_mark_read_walk = cnt;
f4d7e40a 1569 return 0;
dc503a8a
EC
1570}
1571
5327ed3d
JW
1572/* This function is supposed to be used by the following 32-bit optimization
1573 * code only. It returns TRUE if the source or destination register operates
1574 * on 64-bit, otherwise return FALSE.
1575 */
1576static bool is_reg64(struct bpf_verifier_env *env, struct bpf_insn *insn,
1577 u32 regno, struct bpf_reg_state *reg, enum reg_arg_type t)
1578{
1579 u8 code, class, op;
1580
1581 code = insn->code;
1582 class = BPF_CLASS(code);
1583 op = BPF_OP(code);
1584 if (class == BPF_JMP) {
1585 /* BPF_EXIT for "main" will reach here. Return TRUE
1586 * conservatively.
1587 */
1588 if (op == BPF_EXIT)
1589 return true;
1590 if (op == BPF_CALL) {
1591 /* BPF to BPF call will reach here because of marking
1592 * caller saved clobber with DST_OP_NO_MARK for which we
1593 * don't care the register def because they are anyway
1594 * marked as NOT_INIT already.
1595 */
1596 if (insn->src_reg == BPF_PSEUDO_CALL)
1597 return false;
1598 /* Helper call will reach here because of arg type
1599 * check, conservatively return TRUE.
1600 */
1601 if (t == SRC_OP)
1602 return true;
1603
1604 return false;
1605 }
1606 }
1607
1608 if (class == BPF_ALU64 || class == BPF_JMP ||
1609 /* BPF_END always use BPF_ALU class. */
1610 (class == BPF_ALU && op == BPF_END && insn->imm == 64))
1611 return true;
1612
1613 if (class == BPF_ALU || class == BPF_JMP32)
1614 return false;
1615
1616 if (class == BPF_LDX) {
1617 if (t != SRC_OP)
1618 return BPF_SIZE(code) == BPF_DW;
1619 /* LDX source must be ptr. */
1620 return true;
1621 }
1622
1623 if (class == BPF_STX) {
1624 if (reg->type != SCALAR_VALUE)
1625 return true;
1626 return BPF_SIZE(code) == BPF_DW;
1627 }
1628
1629 if (class == BPF_LD) {
1630 u8 mode = BPF_MODE(code);
1631
1632 /* LD_IMM64 */
1633 if (mode == BPF_IMM)
1634 return true;
1635
1636 /* Both LD_IND and LD_ABS return 32-bit data. */
1637 if (t != SRC_OP)
1638 return false;
1639
1640 /* Implicit ctx ptr. */
1641 if (regno == BPF_REG_6)
1642 return true;
1643
1644 /* Explicit source could be any width. */
1645 return true;
1646 }
1647
1648 if (class == BPF_ST)
1649 /* The only source register for BPF_ST is a ptr. */
1650 return true;
1651
1652 /* Conservatively return true at default. */
1653 return true;
1654}
1655
b325fbca
JW
1656/* Return TRUE if INSN doesn't have explicit value define. */
1657static bool insn_no_def(struct bpf_insn *insn)
1658{
1659 u8 class = BPF_CLASS(insn->code);
1660
1661 return (class == BPF_JMP || class == BPF_JMP32 ||
1662 class == BPF_STX || class == BPF_ST);
1663}
1664
1665/* Return TRUE if INSN has defined any 32-bit value explicitly. */
1666static bool insn_has_def32(struct bpf_verifier_env *env, struct bpf_insn *insn)
1667{
1668 if (insn_no_def(insn))
1669 return false;
1670
1671 return !is_reg64(env, insn, insn->dst_reg, NULL, DST_OP);
1672}
1673
5327ed3d
JW
1674static void mark_insn_zext(struct bpf_verifier_env *env,
1675 struct bpf_reg_state *reg)
1676{
1677 s32 def_idx = reg->subreg_def;
1678
1679 if (def_idx == DEF_NOT_SUBREG)
1680 return;
1681
1682 env->insn_aux_data[def_idx - 1].zext_dst = true;
1683 /* The dst will be zero extended, so won't be sub-register anymore. */
1684 reg->subreg_def = DEF_NOT_SUBREG;
1685}
1686
dc503a8a 1687static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
17a52670
AS
1688 enum reg_arg_type t)
1689{
f4d7e40a
AS
1690 struct bpf_verifier_state *vstate = env->cur_state;
1691 struct bpf_func_state *state = vstate->frame[vstate->curframe];
5327ed3d 1692 struct bpf_insn *insn = env->prog->insnsi + env->insn_idx;
c342dc10 1693 struct bpf_reg_state *reg, *regs = state->regs;
5327ed3d 1694 bool rw64;
dc503a8a 1695
17a52670 1696 if (regno >= MAX_BPF_REG) {
61bd5218 1697 verbose(env, "R%d is invalid\n", regno);
17a52670
AS
1698 return -EINVAL;
1699 }
1700
c342dc10 1701 reg = &regs[regno];
5327ed3d 1702 rw64 = is_reg64(env, insn, regno, reg, t);
17a52670
AS
1703 if (t == SRC_OP) {
1704 /* check whether register used as source operand can be read */
c342dc10 1705 if (reg->type == NOT_INIT) {
61bd5218 1706 verbose(env, "R%d !read_ok\n", regno);
17a52670
AS
1707 return -EACCES;
1708 }
679c782d 1709 /* We don't need to worry about FP liveness because it's read-only */
c342dc10
JW
1710 if (regno == BPF_REG_FP)
1711 return 0;
1712
5327ed3d
JW
1713 if (rw64)
1714 mark_insn_zext(env, reg);
1715
1716 return mark_reg_read(env, reg, reg->parent,
1717 rw64 ? REG_LIVE_READ64 : REG_LIVE_READ32);
17a52670
AS
1718 } else {
1719 /* check whether register used as dest operand can be written to */
1720 if (regno == BPF_REG_FP) {
61bd5218 1721 verbose(env, "frame pointer is read only\n");
17a52670
AS
1722 return -EACCES;
1723 }
c342dc10 1724 reg->live |= REG_LIVE_WRITTEN;
5327ed3d 1725 reg->subreg_def = rw64 ? DEF_NOT_SUBREG : env->insn_idx + 1;
17a52670 1726 if (t == DST_OP)
61bd5218 1727 mark_reg_unknown(env, regs, regno);
17a52670
AS
1728 }
1729 return 0;
1730}
1731
b5dc0163
AS
1732/* for any branch, call, exit record the history of jmps in the given state */
1733static int push_jmp_history(struct bpf_verifier_env *env,
1734 struct bpf_verifier_state *cur)
1735{
1736 u32 cnt = cur->jmp_history_cnt;
1737 struct bpf_idx_pair *p;
1738
1739 cnt++;
1740 p = krealloc(cur->jmp_history, cnt * sizeof(*p), GFP_USER);
1741 if (!p)
1742 return -ENOMEM;
1743 p[cnt - 1].idx = env->insn_idx;
1744 p[cnt - 1].prev_idx = env->prev_insn_idx;
1745 cur->jmp_history = p;
1746 cur->jmp_history_cnt = cnt;
1747 return 0;
1748}
1749
1750/* Backtrack one insn at a time. If idx is not at the top of recorded
1751 * history then previous instruction came from straight line execution.
1752 */
1753static int get_prev_insn_idx(struct bpf_verifier_state *st, int i,
1754 u32 *history)
1755{
1756 u32 cnt = *history;
1757
1758 if (cnt && st->jmp_history[cnt - 1].idx == i) {
1759 i = st->jmp_history[cnt - 1].prev_idx;
1760 (*history)--;
1761 } else {
1762 i--;
1763 }
1764 return i;
1765}
1766
1767/* For given verifier state backtrack_insn() is called from the last insn to
1768 * the first insn. Its purpose is to compute a bitmask of registers and
1769 * stack slots that needs precision in the parent verifier state.
1770 */
1771static int backtrack_insn(struct bpf_verifier_env *env, int idx,
1772 u32 *reg_mask, u64 *stack_mask)
1773{
1774 const struct bpf_insn_cbs cbs = {
1775 .cb_print = verbose,
1776 .private_data = env,
1777 };
1778 struct bpf_insn *insn = env->prog->insnsi + idx;
1779 u8 class = BPF_CLASS(insn->code);
1780 u8 opcode = BPF_OP(insn->code);
1781 u8 mode = BPF_MODE(insn->code);
1782 u32 dreg = 1u << insn->dst_reg;
1783 u32 sreg = 1u << insn->src_reg;
1784 u32 spi;
1785
1786 if (insn->code == 0)
1787 return 0;
1788 if (env->log.level & BPF_LOG_LEVEL) {
1789 verbose(env, "regs=%x stack=%llx before ", *reg_mask, *stack_mask);
1790 verbose(env, "%d: ", idx);
1791 print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
1792 }
1793
1794 if (class == BPF_ALU || class == BPF_ALU64) {
1795 if (!(*reg_mask & dreg))
1796 return 0;
1797 if (opcode == BPF_MOV) {
1798 if (BPF_SRC(insn->code) == BPF_X) {
1799 /* dreg = sreg
1800 * dreg needs precision after this insn
1801 * sreg needs precision before this insn
1802 */
1803 *reg_mask &= ~dreg;
1804 *reg_mask |= sreg;
1805 } else {
1806 /* dreg = K
1807 * dreg needs precision after this insn.
1808 * Corresponding register is already marked
1809 * as precise=true in this verifier state.
1810 * No further markings in parent are necessary
1811 */
1812 *reg_mask &= ~dreg;
1813 }
1814 } else {
1815 if (BPF_SRC(insn->code) == BPF_X) {
1816 /* dreg += sreg
1817 * both dreg and sreg need precision
1818 * before this insn
1819 */
1820 *reg_mask |= sreg;
1821 } /* else dreg += K
1822 * dreg still needs precision before this insn
1823 */
1824 }
1825 } else if (class == BPF_LDX) {
1826 if (!(*reg_mask & dreg))
1827 return 0;
1828 *reg_mask &= ~dreg;
1829
1830 /* scalars can only be spilled into stack w/o losing precision.
1831 * Load from any other memory can be zero extended.
1832 * The desire to keep that precision is already indicated
1833 * by 'precise' mark in corresponding register of this state.
1834 * No further tracking necessary.
1835 */
1836 if (insn->src_reg != BPF_REG_FP)
1837 return 0;
1838 if (BPF_SIZE(insn->code) != BPF_DW)
1839 return 0;
1840
1841 /* dreg = *(u64 *)[fp - off] was a fill from the stack.
1842 * that [fp - off] slot contains scalar that needs to be
1843 * tracked with precision
1844 */
1845 spi = (-insn->off - 1) / BPF_REG_SIZE;
1846 if (spi >= 64) {
1847 verbose(env, "BUG spi %d\n", spi);
1848 WARN_ONCE(1, "verifier backtracking bug");
1849 return -EFAULT;
1850 }
1851 *stack_mask |= 1ull << spi;
b3b50f05 1852 } else if (class == BPF_STX || class == BPF_ST) {
b5dc0163 1853 if (*reg_mask & dreg)
b3b50f05 1854 /* stx & st shouldn't be using _scalar_ dst_reg
b5dc0163
AS
1855 * to access memory. It means backtracking
1856 * encountered a case of pointer subtraction.
1857 */
1858 return -ENOTSUPP;
1859 /* scalars can only be spilled into stack */
1860 if (insn->dst_reg != BPF_REG_FP)
1861 return 0;
1862 if (BPF_SIZE(insn->code) != BPF_DW)
1863 return 0;
1864 spi = (-insn->off - 1) / BPF_REG_SIZE;
1865 if (spi >= 64) {
1866 verbose(env, "BUG spi %d\n", spi);
1867 WARN_ONCE(1, "verifier backtracking bug");
1868 return -EFAULT;
1869 }
1870 if (!(*stack_mask & (1ull << spi)))
1871 return 0;
1872 *stack_mask &= ~(1ull << spi);
b3b50f05
AN
1873 if (class == BPF_STX)
1874 *reg_mask |= sreg;
b5dc0163
AS
1875 } else if (class == BPF_JMP || class == BPF_JMP32) {
1876 if (opcode == BPF_CALL) {
1877 if (insn->src_reg == BPF_PSEUDO_CALL)
1878 return -ENOTSUPP;
1879 /* regular helper call sets R0 */
1880 *reg_mask &= ~1;
1881 if (*reg_mask & 0x3f) {
1882 /* if backtracing was looking for registers R1-R5
1883 * they should have been found already.
1884 */
1885 verbose(env, "BUG regs %x\n", *reg_mask);
1886 WARN_ONCE(1, "verifier backtracking bug");
1887 return -EFAULT;
1888 }
1889 } else if (opcode == BPF_EXIT) {
1890 return -ENOTSUPP;
1891 }
1892 } else if (class == BPF_LD) {
1893 if (!(*reg_mask & dreg))
1894 return 0;
1895 *reg_mask &= ~dreg;
1896 /* It's ld_imm64 or ld_abs or ld_ind.
1897 * For ld_imm64 no further tracking of precision
1898 * into parent is necessary
1899 */
1900 if (mode == BPF_IND || mode == BPF_ABS)
1901 /* to be analyzed */
1902 return -ENOTSUPP;
b5dc0163
AS
1903 }
1904 return 0;
1905}
1906
1907/* the scalar precision tracking algorithm:
1908 * . at the start all registers have precise=false.
1909 * . scalar ranges are tracked as normal through alu and jmp insns.
1910 * . once precise value of the scalar register is used in:
1911 * . ptr + scalar alu
1912 * . if (scalar cond K|scalar)
1913 * . helper_call(.., scalar, ...) where ARG_CONST is expected
1914 * backtrack through the verifier states and mark all registers and
1915 * stack slots with spilled constants that these scalar regisers
1916 * should be precise.
1917 * . during state pruning two registers (or spilled stack slots)
1918 * are equivalent if both are not precise.
1919 *
1920 * Note the verifier cannot simply walk register parentage chain,
1921 * since many different registers and stack slots could have been
1922 * used to compute single precise scalar.
1923 *
1924 * The approach of starting with precise=true for all registers and then
1925 * backtrack to mark a register as not precise when the verifier detects
1926 * that program doesn't care about specific value (e.g., when helper
1927 * takes register as ARG_ANYTHING parameter) is not safe.
1928 *
1929 * It's ok to walk single parentage chain of the verifier states.
1930 * It's possible that this backtracking will go all the way till 1st insn.
1931 * All other branches will be explored for needing precision later.
1932 *
1933 * The backtracking needs to deal with cases like:
1934 * R8=map_value(id=0,off=0,ks=4,vs=1952,imm=0) R9_w=map_value(id=0,off=40,ks=4,vs=1952,imm=0)
1935 * r9 -= r8
1936 * r5 = r9
1937 * if r5 > 0x79f goto pc+7
1938 * R5_w=inv(id=0,umax_value=1951,var_off=(0x0; 0x7ff))
1939 * r5 += 1
1940 * ...
1941 * call bpf_perf_event_output#25
1942 * where .arg5_type = ARG_CONST_SIZE_OR_ZERO
1943 *
1944 * and this case:
1945 * r6 = 1
1946 * call foo // uses callee's r6 inside to compute r0
1947 * r0 += r6
1948 * if r0 == 0 goto
1949 *
1950 * to track above reg_mask/stack_mask needs to be independent for each frame.
1951 *
1952 * Also if parent's curframe > frame where backtracking started,
1953 * the verifier need to mark registers in both frames, otherwise callees
1954 * may incorrectly prune callers. This is similar to
1955 * commit 7640ead93924 ("bpf: verifier: make sure callees don't prune with caller differences")
1956 *
1957 * For now backtracking falls back into conservative marking.
1958 */
1959static void mark_all_scalars_precise(struct bpf_verifier_env *env,
1960 struct bpf_verifier_state *st)
1961{
1962 struct bpf_func_state *func;
1963 struct bpf_reg_state *reg;
1964 int i, j;
1965
1966 /* big hammer: mark all scalars precise in this path.
1967 * pop_stack may still get !precise scalars.
1968 */
1969 for (; st; st = st->parent)
1970 for (i = 0; i <= st->curframe; i++) {
1971 func = st->frame[i];
1972 for (j = 0; j < BPF_REG_FP; j++) {
1973 reg = &func->regs[j];
1974 if (reg->type != SCALAR_VALUE)
1975 continue;
1976 reg->precise = true;
1977 }
1978 for (j = 0; j < func->allocated_stack / BPF_REG_SIZE; j++) {
1979 if (func->stack[j].slot_type[0] != STACK_SPILL)
1980 continue;
1981 reg = &func->stack[j].spilled_ptr;
1982 if (reg->type != SCALAR_VALUE)
1983 continue;
1984 reg->precise = true;
1985 }
1986 }
1987}
1988
a3ce685d
AS
1989static int __mark_chain_precision(struct bpf_verifier_env *env, int regno,
1990 int spi)
b5dc0163
AS
1991{
1992 struct bpf_verifier_state *st = env->cur_state;
1993 int first_idx = st->first_insn_idx;
1994 int last_idx = env->insn_idx;
1995 struct bpf_func_state *func;
1996 struct bpf_reg_state *reg;
a3ce685d
AS
1997 u32 reg_mask = regno >= 0 ? 1u << regno : 0;
1998 u64 stack_mask = spi >= 0 ? 1ull << spi : 0;
b5dc0163 1999 bool skip_first = true;
a3ce685d 2000 bool new_marks = false;
b5dc0163
AS
2001 int i, err;
2002
2c78ee89 2003 if (!env->bpf_capable)
b5dc0163
AS
2004 return 0;
2005
2006 func = st->frame[st->curframe];
a3ce685d
AS
2007 if (regno >= 0) {
2008 reg = &func->regs[regno];
2009 if (reg->type != SCALAR_VALUE) {
2010 WARN_ONCE(1, "backtracing misuse");
2011 return -EFAULT;
2012 }
2013 if (!reg->precise)
2014 new_marks = true;
2015 else
2016 reg_mask = 0;
2017 reg->precise = true;
b5dc0163 2018 }
b5dc0163 2019
a3ce685d
AS
2020 while (spi >= 0) {
2021 if (func->stack[spi].slot_type[0] != STACK_SPILL) {
2022 stack_mask = 0;
2023 break;
2024 }
2025 reg = &func->stack[spi].spilled_ptr;
2026 if (reg->type != SCALAR_VALUE) {
2027 stack_mask = 0;
2028 break;
2029 }
2030 if (!reg->precise)
2031 new_marks = true;
2032 else
2033 stack_mask = 0;
2034 reg->precise = true;
2035 break;
2036 }
2037
2038 if (!new_marks)
2039 return 0;
2040 if (!reg_mask && !stack_mask)
2041 return 0;
b5dc0163
AS
2042 for (;;) {
2043 DECLARE_BITMAP(mask, 64);
b5dc0163
AS
2044 u32 history = st->jmp_history_cnt;
2045
2046 if (env->log.level & BPF_LOG_LEVEL)
2047 verbose(env, "last_idx %d first_idx %d\n", last_idx, first_idx);
2048 for (i = last_idx;;) {
2049 if (skip_first) {
2050 err = 0;
2051 skip_first = false;
2052 } else {
2053 err = backtrack_insn(env, i, &reg_mask, &stack_mask);
2054 }
2055 if (err == -ENOTSUPP) {
2056 mark_all_scalars_precise(env, st);
2057 return 0;
2058 } else if (err) {
2059 return err;
2060 }
2061 if (!reg_mask && !stack_mask)
2062 /* Found assignment(s) into tracked register in this state.
2063 * Since this state is already marked, just return.
2064 * Nothing to be tracked further in the parent state.
2065 */
2066 return 0;
2067 if (i == first_idx)
2068 break;
2069 i = get_prev_insn_idx(st, i, &history);
2070 if (i >= env->prog->len) {
2071 /* This can happen if backtracking reached insn 0
2072 * and there are still reg_mask or stack_mask
2073 * to backtrack.
2074 * It means the backtracking missed the spot where
2075 * particular register was initialized with a constant.
2076 */
2077 verbose(env, "BUG backtracking idx %d\n", i);
2078 WARN_ONCE(1, "verifier backtracking bug");
2079 return -EFAULT;
2080 }
2081 }
2082 st = st->parent;
2083 if (!st)
2084 break;
2085
a3ce685d 2086 new_marks = false;
b5dc0163
AS
2087 func = st->frame[st->curframe];
2088 bitmap_from_u64(mask, reg_mask);
2089 for_each_set_bit(i, mask, 32) {
2090 reg = &func->regs[i];
a3ce685d
AS
2091 if (reg->type != SCALAR_VALUE) {
2092 reg_mask &= ~(1u << i);
b5dc0163 2093 continue;
a3ce685d 2094 }
b5dc0163
AS
2095 if (!reg->precise)
2096 new_marks = true;
2097 reg->precise = true;
2098 }
2099
2100 bitmap_from_u64(mask, stack_mask);
2101 for_each_set_bit(i, mask, 64) {
2102 if (i >= func->allocated_stack / BPF_REG_SIZE) {
2339cd6c
AS
2103 /* the sequence of instructions:
2104 * 2: (bf) r3 = r10
2105 * 3: (7b) *(u64 *)(r3 -8) = r0
2106 * 4: (79) r4 = *(u64 *)(r10 -8)
2107 * doesn't contain jmps. It's backtracked
2108 * as a single block.
2109 * During backtracking insn 3 is not recognized as
2110 * stack access, so at the end of backtracking
2111 * stack slot fp-8 is still marked in stack_mask.
2112 * However the parent state may not have accessed
2113 * fp-8 and it's "unallocated" stack space.
2114 * In such case fallback to conservative.
b5dc0163 2115 */
2339cd6c
AS
2116 mark_all_scalars_precise(env, st);
2117 return 0;
b5dc0163
AS
2118 }
2119
a3ce685d
AS
2120 if (func->stack[i].slot_type[0] != STACK_SPILL) {
2121 stack_mask &= ~(1ull << i);
b5dc0163 2122 continue;
a3ce685d 2123 }
b5dc0163 2124 reg = &func->stack[i].spilled_ptr;
a3ce685d
AS
2125 if (reg->type != SCALAR_VALUE) {
2126 stack_mask &= ~(1ull << i);
b5dc0163 2127 continue;
a3ce685d 2128 }
b5dc0163
AS
2129 if (!reg->precise)
2130 new_marks = true;
2131 reg->precise = true;
2132 }
2133 if (env->log.level & BPF_LOG_LEVEL) {
2134 print_verifier_state(env, func);
2135 verbose(env, "parent %s regs=%x stack=%llx marks\n",
2136 new_marks ? "didn't have" : "already had",
2137 reg_mask, stack_mask);
2138 }
2139
a3ce685d
AS
2140 if (!reg_mask && !stack_mask)
2141 break;
b5dc0163
AS
2142 if (!new_marks)
2143 break;
2144
2145 last_idx = st->last_insn_idx;
2146 first_idx = st->first_insn_idx;
2147 }
2148 return 0;
2149}
2150
a3ce685d
AS
2151static int mark_chain_precision(struct bpf_verifier_env *env, int regno)
2152{
2153 return __mark_chain_precision(env, regno, -1);
2154}
2155
2156static int mark_chain_precision_stack(struct bpf_verifier_env *env, int spi)
2157{
2158 return __mark_chain_precision(env, -1, spi);
2159}
b5dc0163 2160
1be7f75d
AS
2161static bool is_spillable_regtype(enum bpf_reg_type type)
2162{
2163 switch (type) {
2164 case PTR_TO_MAP_VALUE:
2165 case PTR_TO_MAP_VALUE_OR_NULL:
2166 case PTR_TO_STACK:
2167 case PTR_TO_CTX:
969bf05e 2168 case PTR_TO_PACKET:
de8f3a83 2169 case PTR_TO_PACKET_META:
969bf05e 2170 case PTR_TO_PACKET_END:
d58e468b 2171 case PTR_TO_FLOW_KEYS:
1be7f75d 2172 case CONST_PTR_TO_MAP:
c64b7983
JS
2173 case PTR_TO_SOCKET:
2174 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
2175 case PTR_TO_SOCK_COMMON:
2176 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
2177 case PTR_TO_TCP_SOCK:
2178 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 2179 case PTR_TO_XDP_SOCK:
65726b5b 2180 case PTR_TO_BTF_ID:
b121b341 2181 case PTR_TO_BTF_ID_OR_NULL:
afbf21dc
YS
2182 case PTR_TO_RDONLY_BUF:
2183 case PTR_TO_RDONLY_BUF_OR_NULL:
2184 case PTR_TO_RDWR_BUF:
2185 case PTR_TO_RDWR_BUF_OR_NULL:
1be7f75d
AS
2186 return true;
2187 default:
2188 return false;
2189 }
2190}
2191
cc2b14d5
AS
2192/* Does this register contain a constant zero? */
2193static bool register_is_null(struct bpf_reg_state *reg)
2194{
2195 return reg->type == SCALAR_VALUE && tnum_equals_const(reg->var_off, 0);
2196}
2197
f7cf25b2
AS
2198static bool register_is_const(struct bpf_reg_state *reg)
2199{
2200 return reg->type == SCALAR_VALUE && tnum_is_const(reg->var_off);
2201}
2202
6e7e63cb
JH
2203static bool __is_pointer_value(bool allow_ptr_leaks,
2204 const struct bpf_reg_state *reg)
2205{
2206 if (allow_ptr_leaks)
2207 return false;
2208
2209 return reg->type != SCALAR_VALUE;
2210}
2211
f7cf25b2
AS
2212static void save_register_state(struct bpf_func_state *state,
2213 int spi, struct bpf_reg_state *reg)
2214{
2215 int i;
2216
2217 state->stack[spi].spilled_ptr = *reg;
2218 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
2219
2220 for (i = 0; i < BPF_REG_SIZE; i++)
2221 state->stack[spi].slot_type[i] = STACK_SPILL;
2222}
2223
17a52670
AS
2224/* check_stack_read/write functions track spill/fill of registers,
2225 * stack boundary and alignment are checked in check_mem_access()
2226 */
61bd5218 2227static int check_stack_write(struct bpf_verifier_env *env,
f4d7e40a 2228 struct bpf_func_state *state, /* func where register points to */
af86ca4e 2229 int off, int size, int value_regno, int insn_idx)
17a52670 2230{
f4d7e40a 2231 struct bpf_func_state *cur; /* state of the current function */
638f5b90 2232 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
b5dc0163 2233 u32 dst_reg = env->prog->insnsi[insn_idx].dst_reg;
f7cf25b2 2234 struct bpf_reg_state *reg = NULL;
638f5b90 2235
f4d7e40a 2236 err = realloc_func_state(state, round_up(slot + 1, BPF_REG_SIZE),
fd978bf7 2237 state->acquired_refs, true);
638f5b90
AS
2238 if (err)
2239 return err;
9c399760
AS
2240 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
2241 * so it's aligned access and [off, off + size) are within stack limits
2242 */
638f5b90
AS
2243 if (!env->allow_ptr_leaks &&
2244 state->stack[spi].slot_type[0] == STACK_SPILL &&
2245 size != BPF_REG_SIZE) {
2246 verbose(env, "attempt to corrupt spilled pointer on stack\n");
2247 return -EACCES;
2248 }
17a52670 2249
f4d7e40a 2250 cur = env->cur_state->frame[env->cur_state->curframe];
f7cf25b2
AS
2251 if (value_regno >= 0)
2252 reg = &cur->regs[value_regno];
17a52670 2253
f7cf25b2 2254 if (reg && size == BPF_REG_SIZE && register_is_const(reg) &&
2c78ee89 2255 !register_is_null(reg) && env->bpf_capable) {
b5dc0163
AS
2256 if (dst_reg != BPF_REG_FP) {
2257 /* The backtracking logic can only recognize explicit
2258 * stack slot address like [fp - 8]. Other spill of
2259 * scalar via different register has to be conervative.
2260 * Backtrack from here and mark all registers as precise
2261 * that contributed into 'reg' being a constant.
2262 */
2263 err = mark_chain_precision(env, value_regno);
2264 if (err)
2265 return err;
2266 }
f7cf25b2
AS
2267 save_register_state(state, spi, reg);
2268 } else if (reg && is_spillable_regtype(reg->type)) {
17a52670 2269 /* register containing pointer is being spilled into stack */
9c399760 2270 if (size != BPF_REG_SIZE) {
f7cf25b2 2271 verbose_linfo(env, insn_idx, "; ");
61bd5218 2272 verbose(env, "invalid size of register spill\n");
17a52670
AS
2273 return -EACCES;
2274 }
2275
f7cf25b2 2276 if (state != cur && reg->type == PTR_TO_STACK) {
f4d7e40a
AS
2277 verbose(env, "cannot spill pointers to stack into stack frame of the caller\n");
2278 return -EINVAL;
2279 }
2280
2c78ee89 2281 if (!env->bypass_spec_v4) {
f7cf25b2 2282 bool sanitize = false;
17a52670 2283
f7cf25b2
AS
2284 if (state->stack[spi].slot_type[0] == STACK_SPILL &&
2285 register_is_const(&state->stack[spi].spilled_ptr))
2286 sanitize = true;
2287 for (i = 0; i < BPF_REG_SIZE; i++)
2288 if (state->stack[spi].slot_type[i] == STACK_MISC) {
2289 sanitize = true;
2290 break;
2291 }
2292 if (sanitize) {
af86ca4e
AS
2293 int *poff = &env->insn_aux_data[insn_idx].sanitize_stack_off;
2294 int soff = (-spi - 1) * BPF_REG_SIZE;
2295
2296 /* detected reuse of integer stack slot with a pointer
2297 * which means either llvm is reusing stack slot or
2298 * an attacker is trying to exploit CVE-2018-3639
2299 * (speculative store bypass)
2300 * Have to sanitize that slot with preemptive
2301 * store of zero.
2302 */
2303 if (*poff && *poff != soff) {
2304 /* disallow programs where single insn stores
2305 * into two different stack slots, since verifier
2306 * cannot sanitize them
2307 */
2308 verbose(env,
2309 "insn %d cannot access two stack slots fp%d and fp%d",
2310 insn_idx, *poff, soff);
2311 return -EINVAL;
2312 }
2313 *poff = soff;
2314 }
af86ca4e 2315 }
f7cf25b2 2316 save_register_state(state, spi, reg);
9c399760 2317 } else {
cc2b14d5
AS
2318 u8 type = STACK_MISC;
2319
679c782d
EC
2320 /* regular write of data into stack destroys any spilled ptr */
2321 state->stack[spi].spilled_ptr.type = NOT_INIT;
0bae2d4d
JW
2322 /* Mark slots as STACK_MISC if they belonged to spilled ptr. */
2323 if (state->stack[spi].slot_type[0] == STACK_SPILL)
2324 for (i = 0; i < BPF_REG_SIZE; i++)
2325 state->stack[spi].slot_type[i] = STACK_MISC;
9c399760 2326
cc2b14d5
AS
2327 /* only mark the slot as written if all 8 bytes were written
2328 * otherwise read propagation may incorrectly stop too soon
2329 * when stack slots are partially written.
2330 * This heuristic means that read propagation will be
2331 * conservative, since it will add reg_live_read marks
2332 * to stack slots all the way to first state when programs
2333 * writes+reads less than 8 bytes
2334 */
2335 if (size == BPF_REG_SIZE)
2336 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
2337
2338 /* when we zero initialize stack slots mark them as such */
b5dc0163
AS
2339 if (reg && register_is_null(reg)) {
2340 /* backtracking doesn't work for STACK_ZERO yet. */
2341 err = mark_chain_precision(env, value_regno);
2342 if (err)
2343 return err;
cc2b14d5 2344 type = STACK_ZERO;
b5dc0163 2345 }
cc2b14d5 2346
0bae2d4d 2347 /* Mark slots affected by this stack write. */
9c399760 2348 for (i = 0; i < size; i++)
638f5b90 2349 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
cc2b14d5 2350 type;
17a52670
AS
2351 }
2352 return 0;
2353}
2354
61bd5218 2355static int check_stack_read(struct bpf_verifier_env *env,
f4d7e40a
AS
2356 struct bpf_func_state *reg_state /* func where register points to */,
2357 int off, int size, int value_regno)
17a52670 2358{
f4d7e40a
AS
2359 struct bpf_verifier_state *vstate = env->cur_state;
2360 struct bpf_func_state *state = vstate->frame[vstate->curframe];
638f5b90 2361 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
f7cf25b2 2362 struct bpf_reg_state *reg;
638f5b90 2363 u8 *stype;
17a52670 2364
f4d7e40a 2365 if (reg_state->allocated_stack <= slot) {
638f5b90
AS
2366 verbose(env, "invalid read from stack off %d+0 size %d\n",
2367 off, size);
2368 return -EACCES;
2369 }
f4d7e40a 2370 stype = reg_state->stack[spi].slot_type;
f7cf25b2 2371 reg = &reg_state->stack[spi].spilled_ptr;
17a52670 2372
638f5b90 2373 if (stype[0] == STACK_SPILL) {
9c399760 2374 if (size != BPF_REG_SIZE) {
f7cf25b2
AS
2375 if (reg->type != SCALAR_VALUE) {
2376 verbose_linfo(env, env->insn_idx, "; ");
2377 verbose(env, "invalid size of register fill\n");
2378 return -EACCES;
2379 }
2380 if (value_regno >= 0) {
2381 mark_reg_unknown(env, state->regs, value_regno);
2382 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
2383 }
2384 mark_reg_read(env, reg, reg->parent, REG_LIVE_READ64);
2385 return 0;
17a52670 2386 }
9c399760 2387 for (i = 1; i < BPF_REG_SIZE; i++) {
638f5b90 2388 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
61bd5218 2389 verbose(env, "corrupted spill memory\n");
17a52670
AS
2390 return -EACCES;
2391 }
2392 }
2393
dc503a8a 2394 if (value_regno >= 0) {
17a52670 2395 /* restore register state from stack */
f7cf25b2 2396 state->regs[value_regno] = *reg;
2f18f62e
AS
2397 /* mark reg as written since spilled pointer state likely
2398 * has its liveness marks cleared by is_state_visited()
2399 * which resets stack/reg liveness for state transitions
2400 */
2401 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
6e7e63cb
JH
2402 } else if (__is_pointer_value(env->allow_ptr_leaks, reg)) {
2403 /* If value_regno==-1, the caller is asking us whether
2404 * it is acceptable to use this value as a SCALAR_VALUE
2405 * (e.g. for XADD).
2406 * We must not allow unprivileged callers to do that
2407 * with spilled pointers.
2408 */
2409 verbose(env, "leaking pointer from stack off %d\n",
2410 off);
2411 return -EACCES;
dc503a8a 2412 }
f7cf25b2 2413 mark_reg_read(env, reg, reg->parent, REG_LIVE_READ64);
17a52670 2414 } else {
cc2b14d5
AS
2415 int zeros = 0;
2416
17a52670 2417 for (i = 0; i < size; i++) {
cc2b14d5
AS
2418 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_MISC)
2419 continue;
2420 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_ZERO) {
2421 zeros++;
2422 continue;
17a52670 2423 }
cc2b14d5
AS
2424 verbose(env, "invalid read from stack off %d+%d size %d\n",
2425 off, i, size);
2426 return -EACCES;
2427 }
f7cf25b2 2428 mark_reg_read(env, reg, reg->parent, REG_LIVE_READ64);
cc2b14d5
AS
2429 if (value_regno >= 0) {
2430 if (zeros == size) {
2431 /* any size read into register is zero extended,
2432 * so the whole register == const_zero
2433 */
2434 __mark_reg_const_zero(&state->regs[value_regno]);
b5dc0163
AS
2435 /* backtracking doesn't support STACK_ZERO yet,
2436 * so mark it precise here, so that later
2437 * backtracking can stop here.
2438 * Backtracking may not need this if this register
2439 * doesn't participate in pointer adjustment.
2440 * Forward propagation of precise flag is not
2441 * necessary either. This mark is only to stop
2442 * backtracking. Any register that contributed
2443 * to const 0 was marked precise before spill.
2444 */
2445 state->regs[value_regno].precise = true;
cc2b14d5
AS
2446 } else {
2447 /* have read misc data from the stack */
2448 mark_reg_unknown(env, state->regs, value_regno);
2449 }
2450 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
17a52670 2451 }
17a52670 2452 }
f7cf25b2 2453 return 0;
17a52670
AS
2454}
2455
e4298d25
DB
2456static int check_stack_access(struct bpf_verifier_env *env,
2457 const struct bpf_reg_state *reg,
2458 int off, int size)
2459{
2460 /* Stack accesses must be at a fixed offset, so that we
2461 * can determine what type of data were returned. See
2462 * check_stack_read().
2463 */
2464 if (!tnum_is_const(reg->var_off)) {
2465 char tn_buf[48];
2466
2467 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
1fbd20f8 2468 verbose(env, "variable stack access var_off=%s off=%d size=%d\n",
e4298d25
DB
2469 tn_buf, off, size);
2470 return -EACCES;
2471 }
2472
2473 if (off >= 0 || off < -MAX_BPF_STACK) {
2474 verbose(env, "invalid stack off=%d size=%d\n", off, size);
2475 return -EACCES;
2476 }
2477
2478 return 0;
2479}
2480
591fe988
DB
2481static int check_map_access_type(struct bpf_verifier_env *env, u32 regno,
2482 int off, int size, enum bpf_access_type type)
2483{
2484 struct bpf_reg_state *regs = cur_regs(env);
2485 struct bpf_map *map = regs[regno].map_ptr;
2486 u32 cap = bpf_map_flags_to_cap(map);
2487
2488 if (type == BPF_WRITE && !(cap & BPF_MAP_CAN_WRITE)) {
2489 verbose(env, "write into map forbidden, value_size=%d off=%d size=%d\n",
2490 map->value_size, off, size);
2491 return -EACCES;
2492 }
2493
2494 if (type == BPF_READ && !(cap & BPF_MAP_CAN_READ)) {
2495 verbose(env, "read from map forbidden, value_size=%d off=%d size=%d\n",
2496 map->value_size, off, size);
2497 return -EACCES;
2498 }
2499
2500 return 0;
2501}
2502
457f4436
AN
2503/* check read/write into memory region (e.g., map value, ringbuf sample, etc) */
2504static int __check_mem_access(struct bpf_verifier_env *env, int regno,
2505 int off, int size, u32 mem_size,
2506 bool zero_size_allowed)
17a52670 2507{
457f4436
AN
2508 bool size_ok = size > 0 || (size == 0 && zero_size_allowed);
2509 struct bpf_reg_state *reg;
2510
2511 if (off >= 0 && size_ok && (u64)off + size <= mem_size)
2512 return 0;
17a52670 2513
457f4436
AN
2514 reg = &cur_regs(env)[regno];
2515 switch (reg->type) {
2516 case PTR_TO_MAP_VALUE:
61bd5218 2517 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
457f4436
AN
2518 mem_size, off, size);
2519 break;
2520 case PTR_TO_PACKET:
2521 case PTR_TO_PACKET_META:
2522 case PTR_TO_PACKET_END:
2523 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
2524 off, size, regno, reg->id, off, mem_size);
2525 break;
2526 case PTR_TO_MEM:
2527 default:
2528 verbose(env, "invalid access to memory, mem_size=%u off=%d size=%d\n",
2529 mem_size, off, size);
17a52670 2530 }
457f4436
AN
2531
2532 return -EACCES;
17a52670
AS
2533}
2534
457f4436
AN
2535/* check read/write into a memory region with possible variable offset */
2536static int check_mem_region_access(struct bpf_verifier_env *env, u32 regno,
2537 int off, int size, u32 mem_size,
2538 bool zero_size_allowed)
dbcfe5f7 2539{
f4d7e40a
AS
2540 struct bpf_verifier_state *vstate = env->cur_state;
2541 struct bpf_func_state *state = vstate->frame[vstate->curframe];
dbcfe5f7
GB
2542 struct bpf_reg_state *reg = &state->regs[regno];
2543 int err;
2544
457f4436 2545 /* We may have adjusted the register pointing to memory region, so we
f1174f77
EC
2546 * need to try adding each of min_value and max_value to off
2547 * to make sure our theoretical access will be safe.
dbcfe5f7 2548 */
06ee7115 2549 if (env->log.level & BPF_LOG_LEVEL)
61bd5218 2550 print_verifier_state(env, state);
b7137c4e 2551
dbcfe5f7
GB
2552 /* The minimum value is only important with signed
2553 * comparisons where we can't assume the floor of a
2554 * value is 0. If we are using signed variables for our
2555 * index'es we need to make sure that whatever we use
2556 * will have a set floor within our range.
2557 */
b7137c4e
DB
2558 if (reg->smin_value < 0 &&
2559 (reg->smin_value == S64_MIN ||
2560 (off + reg->smin_value != (s64)(s32)(off + reg->smin_value)) ||
2561 reg->smin_value + off < 0)) {
61bd5218 2562 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
dbcfe5f7
GB
2563 regno);
2564 return -EACCES;
2565 }
457f4436
AN
2566 err = __check_mem_access(env, regno, reg->smin_value + off, size,
2567 mem_size, zero_size_allowed);
dbcfe5f7 2568 if (err) {
457f4436 2569 verbose(env, "R%d min value is outside of the allowed memory range\n",
61bd5218 2570 regno);
dbcfe5f7
GB
2571 return err;
2572 }
2573
b03c9f9f
EC
2574 /* If we haven't set a max value then we need to bail since we can't be
2575 * sure we won't do bad things.
2576 * If reg->umax_value + off could overflow, treat that as unbounded too.
dbcfe5f7 2577 */
b03c9f9f 2578 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
457f4436 2579 verbose(env, "R%d unbounded memory access, make sure to bounds check any such access\n",
dbcfe5f7
GB
2580 regno);
2581 return -EACCES;
2582 }
457f4436
AN
2583 err = __check_mem_access(env, regno, reg->umax_value + off, size,
2584 mem_size, zero_size_allowed);
2585 if (err) {
2586 verbose(env, "R%d max value is outside of the allowed memory range\n",
61bd5218 2587 regno);
457f4436
AN
2588 return err;
2589 }
2590
2591 return 0;
2592}
d83525ca 2593
457f4436
AN
2594/* check read/write into a map element with possible variable offset */
2595static int check_map_access(struct bpf_verifier_env *env, u32 regno,
2596 int off, int size, bool zero_size_allowed)
2597{
2598 struct bpf_verifier_state *vstate = env->cur_state;
2599 struct bpf_func_state *state = vstate->frame[vstate->curframe];
2600 struct bpf_reg_state *reg = &state->regs[regno];
2601 struct bpf_map *map = reg->map_ptr;
2602 int err;
2603
2604 err = check_mem_region_access(env, regno, off, size, map->value_size,
2605 zero_size_allowed);
2606 if (err)
2607 return err;
2608
2609 if (map_value_has_spin_lock(map)) {
2610 u32 lock = map->spin_lock_off;
d83525ca
AS
2611
2612 /* if any part of struct bpf_spin_lock can be touched by
2613 * load/store reject this program.
2614 * To check that [x1, x2) overlaps with [y1, y2)
2615 * it is sufficient to check x1 < y2 && y1 < x2.
2616 */
2617 if (reg->smin_value + off < lock + sizeof(struct bpf_spin_lock) &&
2618 lock < reg->umax_value + off + size) {
2619 verbose(env, "bpf_spin_lock cannot be accessed directly by load/store\n");
2620 return -EACCES;
2621 }
2622 }
f1174f77 2623 return err;
dbcfe5f7
GB
2624}
2625
969bf05e
AS
2626#define MAX_PACKET_OFF 0xffff
2627
58e2af8b 2628static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
3a0af8fd
TG
2629 const struct bpf_call_arg_meta *meta,
2630 enum bpf_access_type t)
4acf6c0b 2631{
36bbef52 2632 switch (env->prog->type) {
5d66fa7d 2633 /* Program types only with direct read access go here! */
3a0af8fd
TG
2634 case BPF_PROG_TYPE_LWT_IN:
2635 case BPF_PROG_TYPE_LWT_OUT:
004d4b27 2636 case BPF_PROG_TYPE_LWT_SEG6LOCAL:
2dbb9b9e 2637 case BPF_PROG_TYPE_SK_REUSEPORT:
5d66fa7d 2638 case BPF_PROG_TYPE_FLOW_DISSECTOR:
d5563d36 2639 case BPF_PROG_TYPE_CGROUP_SKB:
3a0af8fd
TG
2640 if (t == BPF_WRITE)
2641 return false;
7e57fbb2 2642 /* fallthrough */
5d66fa7d
DB
2643
2644 /* Program types with direct read + write access go here! */
36bbef52
DB
2645 case BPF_PROG_TYPE_SCHED_CLS:
2646 case BPF_PROG_TYPE_SCHED_ACT:
4acf6c0b 2647 case BPF_PROG_TYPE_XDP:
3a0af8fd 2648 case BPF_PROG_TYPE_LWT_XMIT:
8a31db56 2649 case BPF_PROG_TYPE_SK_SKB:
4f738adb 2650 case BPF_PROG_TYPE_SK_MSG:
36bbef52
DB
2651 if (meta)
2652 return meta->pkt_access;
2653
2654 env->seen_direct_write = true;
4acf6c0b 2655 return true;
0d01da6a
SF
2656
2657 case BPF_PROG_TYPE_CGROUP_SOCKOPT:
2658 if (t == BPF_WRITE)
2659 env->seen_direct_write = true;
2660
2661 return true;
2662
4acf6c0b
BB
2663 default:
2664 return false;
2665 }
2666}
2667
f1174f77 2668static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
9fd29c08 2669 int size, bool zero_size_allowed)
f1174f77 2670{
638f5b90 2671 struct bpf_reg_state *regs = cur_regs(env);
f1174f77
EC
2672 struct bpf_reg_state *reg = &regs[regno];
2673 int err;
2674
2675 /* We may have added a variable offset to the packet pointer; but any
2676 * reg->range we have comes after that. We are only checking the fixed
2677 * offset.
2678 */
2679
2680 /* We don't allow negative numbers, because we aren't tracking enough
2681 * detail to prove they're safe.
2682 */
b03c9f9f 2683 if (reg->smin_value < 0) {
61bd5218 2684 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
f1174f77
EC
2685 regno);
2686 return -EACCES;
2687 }
457f4436
AN
2688 err = __check_mem_access(env, regno, off, size, reg->range,
2689 zero_size_allowed);
f1174f77 2690 if (err) {
61bd5218 2691 verbose(env, "R%d offset is outside of the packet\n", regno);
f1174f77
EC
2692 return err;
2693 }
e647815a 2694
457f4436 2695 /* __check_mem_access has made sure "off + size - 1" is within u16.
e647815a
JW
2696 * reg->umax_value can't be bigger than MAX_PACKET_OFF which is 0xffff,
2697 * otherwise find_good_pkt_pointers would have refused to set range info
457f4436 2698 * that __check_mem_access would have rejected this pkt access.
e647815a
JW
2699 * Therefore, "off + reg->umax_value + size - 1" won't overflow u32.
2700 */
2701 env->prog->aux->max_pkt_offset =
2702 max_t(u32, env->prog->aux->max_pkt_offset,
2703 off + reg->umax_value + size - 1);
2704
f1174f77
EC
2705 return err;
2706}
2707
2708/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
31fd8581 2709static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
9e15db66
AS
2710 enum bpf_access_type t, enum bpf_reg_type *reg_type,
2711 u32 *btf_id)
17a52670 2712{
f96da094
DB
2713 struct bpf_insn_access_aux info = {
2714 .reg_type = *reg_type,
9e15db66 2715 .log = &env->log,
f96da094 2716 };
31fd8581 2717
4f9218aa 2718 if (env->ops->is_valid_access &&
5e43f899 2719 env->ops->is_valid_access(off, size, t, env->prog, &info)) {
f96da094
DB
2720 /* A non zero info.ctx_field_size indicates that this field is a
2721 * candidate for later verifier transformation to load the whole
2722 * field and then apply a mask when accessed with a narrower
2723 * access than actual ctx access size. A zero info.ctx_field_size
2724 * will only allow for whole field access and rejects any other
2725 * type of narrower access.
31fd8581 2726 */
23994631 2727 *reg_type = info.reg_type;
31fd8581 2728
b121b341 2729 if (*reg_type == PTR_TO_BTF_ID || *reg_type == PTR_TO_BTF_ID_OR_NULL)
9e15db66
AS
2730 *btf_id = info.btf_id;
2731 else
2732 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
32bbe007
AS
2733 /* remember the offset of last byte accessed in ctx */
2734 if (env->prog->aux->max_ctx_offset < off + size)
2735 env->prog->aux->max_ctx_offset = off + size;
17a52670 2736 return 0;
32bbe007 2737 }
17a52670 2738
61bd5218 2739 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
17a52670
AS
2740 return -EACCES;
2741}
2742
d58e468b
PP
2743static int check_flow_keys_access(struct bpf_verifier_env *env, int off,
2744 int size)
2745{
2746 if (size < 0 || off < 0 ||
2747 (u64)off + size > sizeof(struct bpf_flow_keys)) {
2748 verbose(env, "invalid access to flow keys off=%d size=%d\n",
2749 off, size);
2750 return -EACCES;
2751 }
2752 return 0;
2753}
2754
5f456649
MKL
2755static int check_sock_access(struct bpf_verifier_env *env, int insn_idx,
2756 u32 regno, int off, int size,
2757 enum bpf_access_type t)
c64b7983
JS
2758{
2759 struct bpf_reg_state *regs = cur_regs(env);
2760 struct bpf_reg_state *reg = &regs[regno];
5f456649 2761 struct bpf_insn_access_aux info = {};
46f8bc92 2762 bool valid;
c64b7983
JS
2763
2764 if (reg->smin_value < 0) {
2765 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
2766 regno);
2767 return -EACCES;
2768 }
2769
46f8bc92
MKL
2770 switch (reg->type) {
2771 case PTR_TO_SOCK_COMMON:
2772 valid = bpf_sock_common_is_valid_access(off, size, t, &info);
2773 break;
2774 case PTR_TO_SOCKET:
2775 valid = bpf_sock_is_valid_access(off, size, t, &info);
2776 break;
655a51e5
MKL
2777 case PTR_TO_TCP_SOCK:
2778 valid = bpf_tcp_sock_is_valid_access(off, size, t, &info);
2779 break;
fada7fdc
JL
2780 case PTR_TO_XDP_SOCK:
2781 valid = bpf_xdp_sock_is_valid_access(off, size, t, &info);
2782 break;
46f8bc92
MKL
2783 default:
2784 valid = false;
c64b7983
JS
2785 }
2786
5f456649 2787
46f8bc92
MKL
2788 if (valid) {
2789 env->insn_aux_data[insn_idx].ctx_field_size =
2790 info.ctx_field_size;
2791 return 0;
2792 }
2793
2794 verbose(env, "R%d invalid %s access off=%d size=%d\n",
2795 regno, reg_type_str[reg->type], off, size);
2796
2797 return -EACCES;
c64b7983
JS
2798}
2799
2a159c6f
DB
2800static struct bpf_reg_state *reg_state(struct bpf_verifier_env *env, int regno)
2801{
2802 return cur_regs(env) + regno;
2803}
2804
4cabc5b1
DB
2805static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
2806{
2a159c6f 2807 return __is_pointer_value(env->allow_ptr_leaks, reg_state(env, regno));
4cabc5b1
DB
2808}
2809
f37a8cb8
DB
2810static bool is_ctx_reg(struct bpf_verifier_env *env, int regno)
2811{
2a159c6f 2812 const struct bpf_reg_state *reg = reg_state(env, regno);
f37a8cb8 2813
46f8bc92
MKL
2814 return reg->type == PTR_TO_CTX;
2815}
2816
2817static bool is_sk_reg(struct bpf_verifier_env *env, int regno)
2818{
2819 const struct bpf_reg_state *reg = reg_state(env, regno);
2820
2821 return type_is_sk_pointer(reg->type);
f37a8cb8
DB
2822}
2823
ca369602
DB
2824static bool is_pkt_reg(struct bpf_verifier_env *env, int regno)
2825{
2a159c6f 2826 const struct bpf_reg_state *reg = reg_state(env, regno);
ca369602
DB
2827
2828 return type_is_pkt_pointer(reg->type);
2829}
2830
4b5defde
DB
2831static bool is_flow_key_reg(struct bpf_verifier_env *env, int regno)
2832{
2833 const struct bpf_reg_state *reg = reg_state(env, regno);
2834
2835 /* Separate to is_ctx_reg() since we still want to allow BPF_ST here. */
2836 return reg->type == PTR_TO_FLOW_KEYS;
2837}
2838
61bd5218
JK
2839static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
2840 const struct bpf_reg_state *reg,
d1174416 2841 int off, int size, bool strict)
969bf05e 2842{
f1174f77 2843 struct tnum reg_off;
e07b98d9 2844 int ip_align;
d1174416
DM
2845
2846 /* Byte size accesses are always allowed. */
2847 if (!strict || size == 1)
2848 return 0;
2849
e4eda884
DM
2850 /* For platforms that do not have a Kconfig enabling
2851 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
2852 * NET_IP_ALIGN is universally set to '2'. And on platforms
2853 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
2854 * to this code only in strict mode where we want to emulate
2855 * the NET_IP_ALIGN==2 checking. Therefore use an
2856 * unconditional IP align value of '2'.
e07b98d9 2857 */
e4eda884 2858 ip_align = 2;
f1174f77
EC
2859
2860 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
2861 if (!tnum_is_aligned(reg_off, size)) {
2862 char tn_buf[48];
2863
2864 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218
JK
2865 verbose(env,
2866 "misaligned packet access off %d+%s+%d+%d size %d\n",
f1174f77 2867 ip_align, tn_buf, reg->off, off, size);
969bf05e
AS
2868 return -EACCES;
2869 }
79adffcd 2870
969bf05e
AS
2871 return 0;
2872}
2873
61bd5218
JK
2874static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
2875 const struct bpf_reg_state *reg,
f1174f77
EC
2876 const char *pointer_desc,
2877 int off, int size, bool strict)
79adffcd 2878{
f1174f77
EC
2879 struct tnum reg_off;
2880
2881 /* Byte size accesses are always allowed. */
2882 if (!strict || size == 1)
2883 return 0;
2884
2885 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
2886 if (!tnum_is_aligned(reg_off, size)) {
2887 char tn_buf[48];
2888
2889 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 2890 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
f1174f77 2891 pointer_desc, tn_buf, reg->off, off, size);
79adffcd
DB
2892 return -EACCES;
2893 }
2894
969bf05e
AS
2895 return 0;
2896}
2897
e07b98d9 2898static int check_ptr_alignment(struct bpf_verifier_env *env,
ca369602
DB
2899 const struct bpf_reg_state *reg, int off,
2900 int size, bool strict_alignment_once)
79adffcd 2901{
ca369602 2902 bool strict = env->strict_alignment || strict_alignment_once;
f1174f77 2903 const char *pointer_desc = "";
d1174416 2904
79adffcd
DB
2905 switch (reg->type) {
2906 case PTR_TO_PACKET:
de8f3a83
DB
2907 case PTR_TO_PACKET_META:
2908 /* Special case, because of NET_IP_ALIGN. Given metadata sits
2909 * right in front, treat it the very same way.
2910 */
61bd5218 2911 return check_pkt_ptr_alignment(env, reg, off, size, strict);
d58e468b
PP
2912 case PTR_TO_FLOW_KEYS:
2913 pointer_desc = "flow keys ";
2914 break;
f1174f77
EC
2915 case PTR_TO_MAP_VALUE:
2916 pointer_desc = "value ";
2917 break;
2918 case PTR_TO_CTX:
2919 pointer_desc = "context ";
2920 break;
2921 case PTR_TO_STACK:
2922 pointer_desc = "stack ";
a5ec6ae1
JH
2923 /* The stack spill tracking logic in check_stack_write()
2924 * and check_stack_read() relies on stack accesses being
2925 * aligned.
2926 */
2927 strict = true;
f1174f77 2928 break;
c64b7983
JS
2929 case PTR_TO_SOCKET:
2930 pointer_desc = "sock ";
2931 break;
46f8bc92
MKL
2932 case PTR_TO_SOCK_COMMON:
2933 pointer_desc = "sock_common ";
2934 break;
655a51e5
MKL
2935 case PTR_TO_TCP_SOCK:
2936 pointer_desc = "tcp_sock ";
2937 break;
fada7fdc
JL
2938 case PTR_TO_XDP_SOCK:
2939 pointer_desc = "xdp_sock ";
2940 break;
79adffcd 2941 default:
f1174f77 2942 break;
79adffcd 2943 }
61bd5218
JK
2944 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
2945 strict);
79adffcd
DB
2946}
2947
f4d7e40a
AS
2948static int update_stack_depth(struct bpf_verifier_env *env,
2949 const struct bpf_func_state *func,
2950 int off)
2951{
9c8105bd 2952 u16 stack = env->subprog_info[func->subprogno].stack_depth;
f4d7e40a
AS
2953
2954 if (stack >= -off)
2955 return 0;
2956
2957 /* update known max for given subprogram */
9c8105bd 2958 env->subprog_info[func->subprogno].stack_depth = -off;
70a87ffe
AS
2959 return 0;
2960}
f4d7e40a 2961
70a87ffe
AS
2962/* starting from main bpf function walk all instructions of the function
2963 * and recursively walk all callees that given function can call.
2964 * Ignore jump and exit insns.
2965 * Since recursion is prevented by check_cfg() this algorithm
2966 * only needs a local stack of MAX_CALL_FRAMES to remember callsites
2967 */
2968static int check_max_stack_depth(struct bpf_verifier_env *env)
2969{
9c8105bd
JW
2970 int depth = 0, frame = 0, idx = 0, i = 0, subprog_end;
2971 struct bpf_subprog_info *subprog = env->subprog_info;
70a87ffe 2972 struct bpf_insn *insn = env->prog->insnsi;
70a87ffe
AS
2973 int ret_insn[MAX_CALL_FRAMES];
2974 int ret_prog[MAX_CALL_FRAMES];
f4d7e40a 2975
70a87ffe
AS
2976process_func:
2977 /* round up to 32-bytes, since this is granularity
2978 * of interpreter stack size
2979 */
9c8105bd 2980 depth += round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
70a87ffe 2981 if (depth > MAX_BPF_STACK) {
f4d7e40a 2982 verbose(env, "combined stack size of %d calls is %d. Too large\n",
70a87ffe 2983 frame + 1, depth);
f4d7e40a
AS
2984 return -EACCES;
2985 }
70a87ffe 2986continue_func:
4cb3d99c 2987 subprog_end = subprog[idx + 1].start;
70a87ffe
AS
2988 for (; i < subprog_end; i++) {
2989 if (insn[i].code != (BPF_JMP | BPF_CALL))
2990 continue;
2991 if (insn[i].src_reg != BPF_PSEUDO_CALL)
2992 continue;
2993 /* remember insn and function to return to */
2994 ret_insn[frame] = i + 1;
9c8105bd 2995 ret_prog[frame] = idx;
70a87ffe
AS
2996
2997 /* find the callee */
2998 i = i + insn[i].imm + 1;
9c8105bd
JW
2999 idx = find_subprog(env, i);
3000 if (idx < 0) {
70a87ffe
AS
3001 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
3002 i);
3003 return -EFAULT;
3004 }
70a87ffe
AS
3005 frame++;
3006 if (frame >= MAX_CALL_FRAMES) {
927cb781
PC
3007 verbose(env, "the call stack of %d frames is too deep !\n",
3008 frame);
3009 return -E2BIG;
70a87ffe
AS
3010 }
3011 goto process_func;
3012 }
3013 /* end of for() loop means the last insn of the 'subprog'
3014 * was reached. Doesn't matter whether it was JA or EXIT
3015 */
3016 if (frame == 0)
3017 return 0;
9c8105bd 3018 depth -= round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
70a87ffe
AS
3019 frame--;
3020 i = ret_insn[frame];
9c8105bd 3021 idx = ret_prog[frame];
70a87ffe 3022 goto continue_func;
f4d7e40a
AS
3023}
3024
19d28fbd 3025#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
3026static int get_callee_stack_depth(struct bpf_verifier_env *env,
3027 const struct bpf_insn *insn, int idx)
3028{
3029 int start = idx + insn->imm + 1, subprog;
3030
3031 subprog = find_subprog(env, start);
3032 if (subprog < 0) {
3033 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
3034 start);
3035 return -EFAULT;
3036 }
9c8105bd 3037 return env->subprog_info[subprog].stack_depth;
1ea47e01 3038}
19d28fbd 3039#endif
1ea47e01 3040
51c39bb1
AS
3041int check_ctx_reg(struct bpf_verifier_env *env,
3042 const struct bpf_reg_state *reg, int regno)
58990d1f
DB
3043{
3044 /* Access to ctx or passing it to a helper is only allowed in
3045 * its original, unmodified form.
3046 */
3047
3048 if (reg->off) {
3049 verbose(env, "dereference of modified ctx ptr R%d off=%d disallowed\n",
3050 regno, reg->off);
3051 return -EACCES;
3052 }
3053
3054 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
3055 char tn_buf[48];
3056
3057 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3058 verbose(env, "variable ctx access var_off=%s disallowed\n", tn_buf);
3059 return -EACCES;
3060 }
3061
3062 return 0;
3063}
3064
afbf21dc
YS
3065static int __check_buffer_access(struct bpf_verifier_env *env,
3066 const char *buf_info,
3067 const struct bpf_reg_state *reg,
3068 int regno, int off, int size)
9df1c28b
MM
3069{
3070 if (off < 0) {
3071 verbose(env,
4fc00b79 3072 "R%d invalid %s buffer access: off=%d, size=%d\n",
afbf21dc 3073 regno, buf_info, off, size);
9df1c28b
MM
3074 return -EACCES;
3075 }
3076 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
3077 char tn_buf[48];
3078
3079 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3080 verbose(env,
4fc00b79 3081 "R%d invalid variable buffer offset: off=%d, var_off=%s\n",
9df1c28b
MM
3082 regno, off, tn_buf);
3083 return -EACCES;
3084 }
afbf21dc
YS
3085
3086 return 0;
3087}
3088
3089static int check_tp_buffer_access(struct bpf_verifier_env *env,
3090 const struct bpf_reg_state *reg,
3091 int regno, int off, int size)
3092{
3093 int err;
3094
3095 err = __check_buffer_access(env, "tracepoint", reg, regno, off, size);
3096 if (err)
3097 return err;
3098
9df1c28b
MM
3099 if (off + size > env->prog->aux->max_tp_access)
3100 env->prog->aux->max_tp_access = off + size;
3101
3102 return 0;
3103}
3104
afbf21dc
YS
3105static int check_buffer_access(struct bpf_verifier_env *env,
3106 const struct bpf_reg_state *reg,
3107 int regno, int off, int size,
3108 bool zero_size_allowed,
3109 const char *buf_info,
3110 u32 *max_access)
3111{
3112 int err;
3113
3114 err = __check_buffer_access(env, buf_info, reg, regno, off, size);
3115 if (err)
3116 return err;
3117
3118 if (off + size > *max_access)
3119 *max_access = off + size;
3120
3121 return 0;
3122}
3123
3f50f132
JF
3124/* BPF architecture zero extends alu32 ops into 64-bit registesr */
3125static void zext_32_to_64(struct bpf_reg_state *reg)
3126{
3127 reg->var_off = tnum_subreg(reg->var_off);
3128 __reg_assign_32_into_64(reg);
3129}
9df1c28b 3130
0c17d1d2
JH
3131/* truncate register to smaller size (in bytes)
3132 * must be called with size < BPF_REG_SIZE
3133 */
3134static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
3135{
3136 u64 mask;
3137
3138 /* clear high bits in bit representation */
3139 reg->var_off = tnum_cast(reg->var_off, size);
3140
3141 /* fix arithmetic bounds */
3142 mask = ((u64)1 << (size * 8)) - 1;
3143 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
3144 reg->umin_value &= mask;
3145 reg->umax_value &= mask;
3146 } else {
3147 reg->umin_value = 0;
3148 reg->umax_value = mask;
3149 }
3150 reg->smin_value = reg->umin_value;
3151 reg->smax_value = reg->umax_value;
3f50f132
JF
3152
3153 /* If size is smaller than 32bit register the 32bit register
3154 * values are also truncated so we push 64-bit bounds into
3155 * 32-bit bounds. Above were truncated < 32-bits already.
3156 */
3157 if (size >= 4)
3158 return;
3159 __reg_combine_64_into_32(reg);
0c17d1d2
JH
3160}
3161
a23740ec
AN
3162static bool bpf_map_is_rdonly(const struct bpf_map *map)
3163{
3164 return (map->map_flags & BPF_F_RDONLY_PROG) && map->frozen;
3165}
3166
3167static int bpf_map_direct_read(struct bpf_map *map, int off, int size, u64 *val)
3168{
3169 void *ptr;
3170 u64 addr;
3171 int err;
3172
3173 err = map->ops->map_direct_value_addr(map, &addr, off);
3174 if (err)
3175 return err;
2dedd7d2 3176 ptr = (void *)(long)addr + off;
a23740ec
AN
3177
3178 switch (size) {
3179 case sizeof(u8):
3180 *val = (u64)*(u8 *)ptr;
3181 break;
3182 case sizeof(u16):
3183 *val = (u64)*(u16 *)ptr;
3184 break;
3185 case sizeof(u32):
3186 *val = (u64)*(u32 *)ptr;
3187 break;
3188 case sizeof(u64):
3189 *val = *(u64 *)ptr;
3190 break;
3191 default:
3192 return -EINVAL;
3193 }
3194 return 0;
3195}
3196
9e15db66
AS
3197static int check_ptr_to_btf_access(struct bpf_verifier_env *env,
3198 struct bpf_reg_state *regs,
3199 int regno, int off, int size,
3200 enum bpf_access_type atype,
3201 int value_regno)
3202{
3203 struct bpf_reg_state *reg = regs + regno;
3204 const struct btf_type *t = btf_type_by_id(btf_vmlinux, reg->btf_id);
3205 const char *tname = btf_name_by_offset(btf_vmlinux, t->name_off);
3206 u32 btf_id;
3207 int ret;
3208
9e15db66
AS
3209 if (off < 0) {
3210 verbose(env,
3211 "R%d is ptr_%s invalid negative access: off=%d\n",
3212 regno, tname, off);
3213 return -EACCES;
3214 }
3215 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
3216 char tn_buf[48];
3217
3218 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3219 verbose(env,
3220 "R%d is ptr_%s invalid variable offset: off=%d, var_off=%s\n",
3221 regno, tname, off, tn_buf);
3222 return -EACCES;
3223 }
3224
27ae7997
MKL
3225 if (env->ops->btf_struct_access) {
3226 ret = env->ops->btf_struct_access(&env->log, t, off, size,
3227 atype, &btf_id);
3228 } else {
3229 if (atype != BPF_READ) {
3230 verbose(env, "only read is supported\n");
3231 return -EACCES;
3232 }
3233
3234 ret = btf_struct_access(&env->log, t, off, size, atype,
3235 &btf_id);
3236 }
3237
9e15db66
AS
3238 if (ret < 0)
3239 return ret;
3240
41c48f3a
AI
3241 if (atype == BPF_READ && value_regno >= 0)
3242 mark_btf_ld_reg(env, regs, value_regno, ret, btf_id);
3243
3244 return 0;
3245}
3246
3247static int check_ptr_to_map_access(struct bpf_verifier_env *env,
3248 struct bpf_reg_state *regs,
3249 int regno, int off, int size,
3250 enum bpf_access_type atype,
3251 int value_regno)
3252{
3253 struct bpf_reg_state *reg = regs + regno;
3254 struct bpf_map *map = reg->map_ptr;
3255 const struct btf_type *t;
3256 const char *tname;
3257 u32 btf_id;
3258 int ret;
3259
3260 if (!btf_vmlinux) {
3261 verbose(env, "map_ptr access not supported without CONFIG_DEBUG_INFO_BTF\n");
3262 return -ENOTSUPP;
3263 }
3264
3265 if (!map->ops->map_btf_id || !*map->ops->map_btf_id) {
3266 verbose(env, "map_ptr access not supported for map type %d\n",
3267 map->map_type);
3268 return -ENOTSUPP;
3269 }
3270
3271 t = btf_type_by_id(btf_vmlinux, *map->ops->map_btf_id);
3272 tname = btf_name_by_offset(btf_vmlinux, t->name_off);
3273
3274 if (!env->allow_ptr_to_map_access) {
3275 verbose(env,
3276 "%s access is allowed only to CAP_PERFMON and CAP_SYS_ADMIN\n",
3277 tname);
3278 return -EPERM;
9e15db66 3279 }
27ae7997 3280
41c48f3a
AI
3281 if (off < 0) {
3282 verbose(env, "R%d is %s invalid negative access: off=%d\n",
3283 regno, tname, off);
3284 return -EACCES;
3285 }
3286
3287 if (atype != BPF_READ) {
3288 verbose(env, "only read from %s is supported\n", tname);
3289 return -EACCES;
3290 }
3291
3292 ret = btf_struct_access(&env->log, t, off, size, atype, &btf_id);
3293 if (ret < 0)
3294 return ret;
3295
3296 if (value_regno >= 0)
3297 mark_btf_ld_reg(env, regs, value_regno, ret, btf_id);
3298
9e15db66
AS
3299 return 0;
3300}
3301
41c48f3a 3302
17a52670
AS
3303/* check whether memory at (regno + off) is accessible for t = (read | write)
3304 * if t==write, value_regno is a register which value is stored into memory
3305 * if t==read, value_regno is a register which will receive the value from memory
3306 * if t==write && value_regno==-1, some unknown value is stored into memory
3307 * if t==read && value_regno==-1, don't care what we read from memory
3308 */
ca369602
DB
3309static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno,
3310 int off, int bpf_size, enum bpf_access_type t,
3311 int value_regno, bool strict_alignment_once)
17a52670 3312{
638f5b90
AS
3313 struct bpf_reg_state *regs = cur_regs(env);
3314 struct bpf_reg_state *reg = regs + regno;
f4d7e40a 3315 struct bpf_func_state *state;
17a52670
AS
3316 int size, err = 0;
3317
3318 size = bpf_size_to_bytes(bpf_size);
3319 if (size < 0)
3320 return size;
3321
f1174f77 3322 /* alignment checks will add in reg->off themselves */
ca369602 3323 err = check_ptr_alignment(env, reg, off, size, strict_alignment_once);
969bf05e
AS
3324 if (err)
3325 return err;
17a52670 3326
f1174f77
EC
3327 /* for access checks, reg->off is just part of off */
3328 off += reg->off;
3329
3330 if (reg->type == PTR_TO_MAP_VALUE) {
1be7f75d
AS
3331 if (t == BPF_WRITE && value_regno >= 0 &&
3332 is_pointer_value(env, value_regno)) {
61bd5218 3333 verbose(env, "R%d leaks addr into map\n", value_regno);
1be7f75d
AS
3334 return -EACCES;
3335 }
591fe988
DB
3336 err = check_map_access_type(env, regno, off, size, t);
3337 if (err)
3338 return err;
9fd29c08 3339 err = check_map_access(env, regno, off, size, false);
a23740ec
AN
3340 if (!err && t == BPF_READ && value_regno >= 0) {
3341 struct bpf_map *map = reg->map_ptr;
3342
3343 /* if map is read-only, track its contents as scalars */
3344 if (tnum_is_const(reg->var_off) &&
3345 bpf_map_is_rdonly(map) &&
3346 map->ops->map_direct_value_addr) {
3347 int map_off = off + reg->var_off.value;
3348 u64 val = 0;
3349
3350 err = bpf_map_direct_read(map, map_off, size,
3351 &val);
3352 if (err)
3353 return err;
3354
3355 regs[value_regno].type = SCALAR_VALUE;
3356 __mark_reg_known(&regs[value_regno], val);
3357 } else {
3358 mark_reg_unknown(env, regs, value_regno);
3359 }
3360 }
457f4436
AN
3361 } else if (reg->type == PTR_TO_MEM) {
3362 if (t == BPF_WRITE && value_regno >= 0 &&
3363 is_pointer_value(env, value_regno)) {
3364 verbose(env, "R%d leaks addr into mem\n", value_regno);
3365 return -EACCES;
3366 }
3367 err = check_mem_region_access(env, regno, off, size,
3368 reg->mem_size, false);
3369 if (!err && t == BPF_READ && value_regno >= 0)
3370 mark_reg_unknown(env, regs, value_regno);
1a0dc1ac 3371 } else if (reg->type == PTR_TO_CTX) {
f1174f77 3372 enum bpf_reg_type reg_type = SCALAR_VALUE;
9e15db66 3373 u32 btf_id = 0;
19de99f7 3374
1be7f75d
AS
3375 if (t == BPF_WRITE && value_regno >= 0 &&
3376 is_pointer_value(env, value_regno)) {
61bd5218 3377 verbose(env, "R%d leaks addr into ctx\n", value_regno);
1be7f75d
AS
3378 return -EACCES;
3379 }
f1174f77 3380
58990d1f
DB
3381 err = check_ctx_reg(env, reg, regno);
3382 if (err < 0)
3383 return err;
3384
9e15db66
AS
3385 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type, &btf_id);
3386 if (err)
3387 verbose_linfo(env, insn_idx, "; ");
969bf05e 3388 if (!err && t == BPF_READ && value_regno >= 0) {
f1174f77 3389 /* ctx access returns either a scalar, or a
de8f3a83
DB
3390 * PTR_TO_PACKET[_META,_END]. In the latter
3391 * case, we know the offset is zero.
f1174f77 3392 */
46f8bc92 3393 if (reg_type == SCALAR_VALUE) {
638f5b90 3394 mark_reg_unknown(env, regs, value_regno);
46f8bc92 3395 } else {
638f5b90 3396 mark_reg_known_zero(env, regs,
61bd5218 3397 value_regno);
46f8bc92
MKL
3398 if (reg_type_may_be_null(reg_type))
3399 regs[value_regno].id = ++env->id_gen;
5327ed3d
JW
3400 /* A load of ctx field could have different
3401 * actual load size with the one encoded in the
3402 * insn. When the dst is PTR, it is for sure not
3403 * a sub-register.
3404 */
3405 regs[value_regno].subreg_def = DEF_NOT_SUBREG;
b121b341
YS
3406 if (reg_type == PTR_TO_BTF_ID ||
3407 reg_type == PTR_TO_BTF_ID_OR_NULL)
9e15db66 3408 regs[value_regno].btf_id = btf_id;
46f8bc92 3409 }
638f5b90 3410 regs[value_regno].type = reg_type;
969bf05e 3411 }
17a52670 3412
f1174f77 3413 } else if (reg->type == PTR_TO_STACK) {
f1174f77 3414 off += reg->var_off.value;
e4298d25
DB
3415 err = check_stack_access(env, reg, off, size);
3416 if (err)
3417 return err;
8726679a 3418
f4d7e40a
AS
3419 state = func(env, reg);
3420 err = update_stack_depth(env, state, off);
3421 if (err)
3422 return err;
8726679a 3423
638f5b90 3424 if (t == BPF_WRITE)
61bd5218 3425 err = check_stack_write(env, state, off, size,
af86ca4e 3426 value_regno, insn_idx);
638f5b90 3427 else
61bd5218
JK
3428 err = check_stack_read(env, state, off, size,
3429 value_regno);
de8f3a83 3430 } else if (reg_is_pkt_pointer(reg)) {
3a0af8fd 3431 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
61bd5218 3432 verbose(env, "cannot write into packet\n");
969bf05e
AS
3433 return -EACCES;
3434 }
4acf6c0b
BB
3435 if (t == BPF_WRITE && value_regno >= 0 &&
3436 is_pointer_value(env, value_regno)) {
61bd5218
JK
3437 verbose(env, "R%d leaks addr into packet\n",
3438 value_regno);
4acf6c0b
BB
3439 return -EACCES;
3440 }
9fd29c08 3441 err = check_packet_access(env, regno, off, size, false);
969bf05e 3442 if (!err && t == BPF_READ && value_regno >= 0)
638f5b90 3443 mark_reg_unknown(env, regs, value_regno);
d58e468b
PP
3444 } else if (reg->type == PTR_TO_FLOW_KEYS) {
3445 if (t == BPF_WRITE && value_regno >= 0 &&
3446 is_pointer_value(env, value_regno)) {
3447 verbose(env, "R%d leaks addr into flow keys\n",
3448 value_regno);
3449 return -EACCES;
3450 }
3451
3452 err = check_flow_keys_access(env, off, size);
3453 if (!err && t == BPF_READ && value_regno >= 0)
3454 mark_reg_unknown(env, regs, value_regno);
46f8bc92 3455 } else if (type_is_sk_pointer(reg->type)) {
c64b7983 3456 if (t == BPF_WRITE) {
46f8bc92
MKL
3457 verbose(env, "R%d cannot write into %s\n",
3458 regno, reg_type_str[reg->type]);
c64b7983
JS
3459 return -EACCES;
3460 }
5f456649 3461 err = check_sock_access(env, insn_idx, regno, off, size, t);
c64b7983
JS
3462 if (!err && value_regno >= 0)
3463 mark_reg_unknown(env, regs, value_regno);
9df1c28b
MM
3464 } else if (reg->type == PTR_TO_TP_BUFFER) {
3465 err = check_tp_buffer_access(env, reg, regno, off, size);
3466 if (!err && t == BPF_READ && value_regno >= 0)
3467 mark_reg_unknown(env, regs, value_regno);
9e15db66
AS
3468 } else if (reg->type == PTR_TO_BTF_ID) {
3469 err = check_ptr_to_btf_access(env, regs, regno, off, size, t,
3470 value_regno);
41c48f3a
AI
3471 } else if (reg->type == CONST_PTR_TO_MAP) {
3472 err = check_ptr_to_map_access(env, regs, regno, off, size, t,
3473 value_regno);
afbf21dc
YS
3474 } else if (reg->type == PTR_TO_RDONLY_BUF) {
3475 if (t == BPF_WRITE) {
3476 verbose(env, "R%d cannot write into %s\n",
3477 regno, reg_type_str[reg->type]);
3478 return -EACCES;
3479 }
f6dfbe31
CIK
3480 err = check_buffer_access(env, reg, regno, off, size, false,
3481 "rdonly",
afbf21dc
YS
3482 &env->prog->aux->max_rdonly_access);
3483 if (!err && value_regno >= 0)
3484 mark_reg_unknown(env, regs, value_regno);
3485 } else if (reg->type == PTR_TO_RDWR_BUF) {
f6dfbe31
CIK
3486 err = check_buffer_access(env, reg, regno, off, size, false,
3487 "rdwr",
afbf21dc
YS
3488 &env->prog->aux->max_rdwr_access);
3489 if (!err && t == BPF_READ && value_regno >= 0)
3490 mark_reg_unknown(env, regs, value_regno);
17a52670 3491 } else {
61bd5218
JK
3492 verbose(env, "R%d invalid mem access '%s'\n", regno,
3493 reg_type_str[reg->type]);
17a52670
AS
3494 return -EACCES;
3495 }
969bf05e 3496
f1174f77 3497 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
638f5b90 3498 regs[value_regno].type == SCALAR_VALUE) {
f1174f77 3499 /* b/h/w load zero-extends, mark upper bits as known 0 */
0c17d1d2 3500 coerce_reg_to_size(&regs[value_regno], size);
969bf05e 3501 }
17a52670
AS
3502 return err;
3503}
3504
31fd8581 3505static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
17a52670 3506{
17a52670
AS
3507 int err;
3508
3509 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
3510 insn->imm != 0) {
61bd5218 3511 verbose(env, "BPF_XADD uses reserved fields\n");
17a52670
AS
3512 return -EINVAL;
3513 }
3514
3515 /* check src1 operand */
dc503a8a 3516 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
3517 if (err)
3518 return err;
3519
3520 /* check src2 operand */
dc503a8a 3521 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
3522 if (err)
3523 return err;
3524
6bdf6abc 3525 if (is_pointer_value(env, insn->src_reg)) {
61bd5218 3526 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
6bdf6abc
DB
3527 return -EACCES;
3528 }
3529
ca369602 3530 if (is_ctx_reg(env, insn->dst_reg) ||
4b5defde 3531 is_pkt_reg(env, insn->dst_reg) ||
46f8bc92
MKL
3532 is_flow_key_reg(env, insn->dst_reg) ||
3533 is_sk_reg(env, insn->dst_reg)) {
ca369602 3534 verbose(env, "BPF_XADD stores into R%d %s is not allowed\n",
2a159c6f
DB
3535 insn->dst_reg,
3536 reg_type_str[reg_state(env, insn->dst_reg)->type]);
f37a8cb8
DB
3537 return -EACCES;
3538 }
3539
17a52670 3540 /* check whether atomic_add can read the memory */
31fd8581 3541 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
ca369602 3542 BPF_SIZE(insn->code), BPF_READ, -1, true);
17a52670
AS
3543 if (err)
3544 return err;
3545
3546 /* check whether atomic_add can write into the same memory */
31fd8581 3547 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
ca369602 3548 BPF_SIZE(insn->code), BPF_WRITE, -1, true);
17a52670
AS
3549}
3550
2011fccf
AI
3551static int __check_stack_boundary(struct bpf_verifier_env *env, u32 regno,
3552 int off, int access_size,
3553 bool zero_size_allowed)
3554{
3555 struct bpf_reg_state *reg = reg_state(env, regno);
3556
3557 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
3558 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
3559 if (tnum_is_const(reg->var_off)) {
3560 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
3561 regno, off, access_size);
3562 } else {
3563 char tn_buf[48];
3564
3565 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3566 verbose(env, "invalid stack type R%d var_off=%s access_size=%d\n",
3567 regno, tn_buf, access_size);
3568 }
3569 return -EACCES;
3570 }
3571 return 0;
3572}
3573
17a52670
AS
3574/* when register 'regno' is passed into function that will read 'access_size'
3575 * bytes from that pointer, make sure that it's within stack boundary
f1174f77
EC
3576 * and all elements of stack are initialized.
3577 * Unlike most pointer bounds-checking functions, this one doesn't take an
3578 * 'off' argument, so it has to add in reg->off itself.
17a52670 3579 */
58e2af8b 3580static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
435faee1
DB
3581 int access_size, bool zero_size_allowed,
3582 struct bpf_call_arg_meta *meta)
17a52670 3583{
2a159c6f 3584 struct bpf_reg_state *reg = reg_state(env, regno);
f4d7e40a 3585 struct bpf_func_state *state = func(env, reg);
f7cf25b2 3586 int err, min_off, max_off, i, j, slot, spi;
17a52670 3587
914cb781 3588 if (reg->type != PTR_TO_STACK) {
f1174f77 3589 /* Allow zero-byte read from NULL, regardless of pointer type */
8e2fe1d9 3590 if (zero_size_allowed && access_size == 0 &&
914cb781 3591 register_is_null(reg))
8e2fe1d9
DB
3592 return 0;
3593
61bd5218 3594 verbose(env, "R%d type=%s expected=%s\n", regno,
914cb781 3595 reg_type_str[reg->type],
8e2fe1d9 3596 reg_type_str[PTR_TO_STACK]);
17a52670 3597 return -EACCES;
8e2fe1d9 3598 }
17a52670 3599
2011fccf
AI
3600 if (tnum_is_const(reg->var_off)) {
3601 min_off = max_off = reg->var_off.value + reg->off;
3602 err = __check_stack_boundary(env, regno, min_off, access_size,
3603 zero_size_allowed);
3604 if (err)
3605 return err;
3606 } else {
088ec26d
AI
3607 /* Variable offset is prohibited for unprivileged mode for
3608 * simplicity since it requires corresponding support in
3609 * Spectre masking for stack ALU.
3610 * See also retrieve_ptr_limit().
3611 */
2c78ee89 3612 if (!env->bypass_spec_v1) {
088ec26d 3613 char tn_buf[48];
f1174f77 3614
088ec26d
AI
3615 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3616 verbose(env, "R%d indirect variable offset stack access prohibited for !root, var_off=%s\n",
3617 regno, tn_buf);
3618 return -EACCES;
3619 }
f2bcd05e
AI
3620 /* Only initialized buffer on stack is allowed to be accessed
3621 * with variable offset. With uninitialized buffer it's hard to
3622 * guarantee that whole memory is marked as initialized on
3623 * helper return since specific bounds are unknown what may
3624 * cause uninitialized stack leaking.
3625 */
3626 if (meta && meta->raw_mode)
3627 meta = NULL;
3628
107c26a7
AI
3629 if (reg->smax_value >= BPF_MAX_VAR_OFF ||
3630 reg->smax_value <= -BPF_MAX_VAR_OFF) {
3631 verbose(env, "R%d unbounded indirect variable offset stack access\n",
3632 regno);
3633 return -EACCES;
3634 }
2011fccf 3635 min_off = reg->smin_value + reg->off;
107c26a7 3636 max_off = reg->smax_value + reg->off;
2011fccf
AI
3637 err = __check_stack_boundary(env, regno, min_off, access_size,
3638 zero_size_allowed);
107c26a7
AI
3639 if (err) {
3640 verbose(env, "R%d min value is outside of stack bound\n",
3641 regno);
2011fccf 3642 return err;
107c26a7 3643 }
2011fccf
AI
3644 err = __check_stack_boundary(env, regno, max_off, access_size,
3645 zero_size_allowed);
107c26a7
AI
3646 if (err) {
3647 verbose(env, "R%d max value is outside of stack bound\n",
3648 regno);
2011fccf 3649 return err;
107c26a7 3650 }
17a52670
AS
3651 }
3652
435faee1
DB
3653 if (meta && meta->raw_mode) {
3654 meta->access_size = access_size;
3655 meta->regno = regno;
3656 return 0;
3657 }
3658
2011fccf 3659 for (i = min_off; i < max_off + access_size; i++) {
cc2b14d5
AS
3660 u8 *stype;
3661
2011fccf 3662 slot = -i - 1;
638f5b90 3663 spi = slot / BPF_REG_SIZE;
cc2b14d5
AS
3664 if (state->allocated_stack <= slot)
3665 goto err;
3666 stype = &state->stack[spi].slot_type[slot % BPF_REG_SIZE];
3667 if (*stype == STACK_MISC)
3668 goto mark;
3669 if (*stype == STACK_ZERO) {
3670 /* helper can write anything into the stack */
3671 *stype = STACK_MISC;
3672 goto mark;
17a52670 3673 }
1d68f22b
YS
3674
3675 if (state->stack[spi].slot_type[0] == STACK_SPILL &&
3676 state->stack[spi].spilled_ptr.type == PTR_TO_BTF_ID)
3677 goto mark;
3678
f7cf25b2
AS
3679 if (state->stack[spi].slot_type[0] == STACK_SPILL &&
3680 state->stack[spi].spilled_ptr.type == SCALAR_VALUE) {
f54c7898 3681 __mark_reg_unknown(env, &state->stack[spi].spilled_ptr);
f7cf25b2
AS
3682 for (j = 0; j < BPF_REG_SIZE; j++)
3683 state->stack[spi].slot_type[j] = STACK_MISC;
3684 goto mark;
3685 }
3686
cc2b14d5 3687err:
2011fccf
AI
3688 if (tnum_is_const(reg->var_off)) {
3689 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
3690 min_off, i - min_off, access_size);
3691 } else {
3692 char tn_buf[48];
3693
3694 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
3695 verbose(env, "invalid indirect read from stack var_off %s+%d size %d\n",
3696 tn_buf, i - min_off, access_size);
3697 }
cc2b14d5
AS
3698 return -EACCES;
3699mark:
3700 /* reading any byte out of 8-byte 'spill_slot' will cause
3701 * the whole slot to be marked as 'read'
3702 */
679c782d 3703 mark_reg_read(env, &state->stack[spi].spilled_ptr,
5327ed3d
JW
3704 state->stack[spi].spilled_ptr.parent,
3705 REG_LIVE_READ64);
17a52670 3706 }
2011fccf 3707 return update_stack_depth(env, state, min_off);
17a52670
AS
3708}
3709
06c1c049
GB
3710static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
3711 int access_size, bool zero_size_allowed,
3712 struct bpf_call_arg_meta *meta)
3713{
638f5b90 3714 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
06c1c049 3715
f1174f77 3716 switch (reg->type) {
06c1c049 3717 case PTR_TO_PACKET:
de8f3a83 3718 case PTR_TO_PACKET_META:
9fd29c08
YS
3719 return check_packet_access(env, regno, reg->off, access_size,
3720 zero_size_allowed);
06c1c049 3721 case PTR_TO_MAP_VALUE:
591fe988
DB
3722 if (check_map_access_type(env, regno, reg->off, access_size,
3723 meta && meta->raw_mode ? BPF_WRITE :
3724 BPF_READ))
3725 return -EACCES;
9fd29c08
YS
3726 return check_map_access(env, regno, reg->off, access_size,
3727 zero_size_allowed);
457f4436
AN
3728 case PTR_TO_MEM:
3729 return check_mem_region_access(env, regno, reg->off,
3730 access_size, reg->mem_size,
3731 zero_size_allowed);
afbf21dc
YS
3732 case PTR_TO_RDONLY_BUF:
3733 if (meta && meta->raw_mode)
3734 return -EACCES;
3735 return check_buffer_access(env, reg, regno, reg->off,
3736 access_size, zero_size_allowed,
3737 "rdonly",
3738 &env->prog->aux->max_rdonly_access);
3739 case PTR_TO_RDWR_BUF:
3740 return check_buffer_access(env, reg, regno, reg->off,
3741 access_size, zero_size_allowed,
3742 "rdwr",
3743 &env->prog->aux->max_rdwr_access);
f1174f77 3744 default: /* scalar_value|ptr_to_stack or invalid ptr */
06c1c049
GB
3745 return check_stack_boundary(env, regno, access_size,
3746 zero_size_allowed, meta);
3747 }
3748}
3749
d83525ca
AS
3750/* Implementation details:
3751 * bpf_map_lookup returns PTR_TO_MAP_VALUE_OR_NULL
3752 * Two bpf_map_lookups (even with the same key) will have different reg->id.
3753 * For traditional PTR_TO_MAP_VALUE the verifier clears reg->id after
3754 * value_or_null->value transition, since the verifier only cares about
3755 * the range of access to valid map value pointer and doesn't care about actual
3756 * address of the map element.
3757 * For maps with 'struct bpf_spin_lock' inside map value the verifier keeps
3758 * reg->id > 0 after value_or_null->value transition. By doing so
3759 * two bpf_map_lookups will be considered two different pointers that
3760 * point to different bpf_spin_locks.
3761 * The verifier allows taking only one bpf_spin_lock at a time to avoid
3762 * dead-locks.
3763 * Since only one bpf_spin_lock is allowed the checks are simpler than
3764 * reg_is_refcounted() logic. The verifier needs to remember only
3765 * one spin_lock instead of array of acquired_refs.
3766 * cur_state->active_spin_lock remembers which map value element got locked
3767 * and clears it after bpf_spin_unlock.
3768 */
3769static int process_spin_lock(struct bpf_verifier_env *env, int regno,
3770 bool is_lock)
3771{
3772 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
3773 struct bpf_verifier_state *cur = env->cur_state;
3774 bool is_const = tnum_is_const(reg->var_off);
3775 struct bpf_map *map = reg->map_ptr;
3776 u64 val = reg->var_off.value;
3777
3778 if (reg->type != PTR_TO_MAP_VALUE) {
3779 verbose(env, "R%d is not a pointer to map_value\n", regno);
3780 return -EINVAL;
3781 }
3782 if (!is_const) {
3783 verbose(env,
3784 "R%d doesn't have constant offset. bpf_spin_lock has to be at the constant offset\n",
3785 regno);
3786 return -EINVAL;
3787 }
3788 if (!map->btf) {
3789 verbose(env,
3790 "map '%s' has to have BTF in order to use bpf_spin_lock\n",
3791 map->name);
3792 return -EINVAL;
3793 }
3794 if (!map_value_has_spin_lock(map)) {
3795 if (map->spin_lock_off == -E2BIG)
3796 verbose(env,
3797 "map '%s' has more than one 'struct bpf_spin_lock'\n",
3798 map->name);
3799 else if (map->spin_lock_off == -ENOENT)
3800 verbose(env,
3801 "map '%s' doesn't have 'struct bpf_spin_lock'\n",
3802 map->name);
3803 else
3804 verbose(env,
3805 "map '%s' is not a struct type or bpf_spin_lock is mangled\n",
3806 map->name);
3807 return -EINVAL;
3808 }
3809 if (map->spin_lock_off != val + reg->off) {
3810 verbose(env, "off %lld doesn't point to 'struct bpf_spin_lock'\n",
3811 val + reg->off);
3812 return -EINVAL;
3813 }
3814 if (is_lock) {
3815 if (cur->active_spin_lock) {
3816 verbose(env,
3817 "Locking two bpf_spin_locks are not allowed\n");
3818 return -EINVAL;
3819 }
3820 cur->active_spin_lock = reg->id;
3821 } else {
3822 if (!cur->active_spin_lock) {
3823 verbose(env, "bpf_spin_unlock without taking a lock\n");
3824 return -EINVAL;
3825 }
3826 if (cur->active_spin_lock != reg->id) {
3827 verbose(env, "bpf_spin_unlock of different lock\n");
3828 return -EINVAL;
3829 }
3830 cur->active_spin_lock = 0;
3831 }
3832 return 0;
3833}
3834
90133415
DB
3835static bool arg_type_is_mem_ptr(enum bpf_arg_type type)
3836{
3837 return type == ARG_PTR_TO_MEM ||
3838 type == ARG_PTR_TO_MEM_OR_NULL ||
3839 type == ARG_PTR_TO_UNINIT_MEM;
3840}
3841
3842static bool arg_type_is_mem_size(enum bpf_arg_type type)
3843{
3844 return type == ARG_CONST_SIZE ||
3845 type == ARG_CONST_SIZE_OR_ZERO;
3846}
3847
457f4436
AN
3848static bool arg_type_is_alloc_mem_ptr(enum bpf_arg_type type)
3849{
3850 return type == ARG_PTR_TO_ALLOC_MEM ||
3851 type == ARG_PTR_TO_ALLOC_MEM_OR_NULL;
3852}
3853
3854static bool arg_type_is_alloc_size(enum bpf_arg_type type)
3855{
3856 return type == ARG_CONST_ALLOC_SIZE_OR_ZERO;
3857}
3858
57c3bb72
AI
3859static bool arg_type_is_int_ptr(enum bpf_arg_type type)
3860{
3861 return type == ARG_PTR_TO_INT ||
3862 type == ARG_PTR_TO_LONG;
3863}
3864
3865static int int_ptr_type_to_size(enum bpf_arg_type type)
3866{
3867 if (type == ARG_PTR_TO_INT)
3868 return sizeof(u32);
3869 else if (type == ARG_PTR_TO_LONG)
3870 return sizeof(u64);
3871
3872 return -EINVAL;
3873}
3874
912f442c
LB
3875static int resolve_map_arg_type(struct bpf_verifier_env *env,
3876 const struct bpf_call_arg_meta *meta,
3877 enum bpf_arg_type *arg_type)
3878{
3879 if (!meta->map_ptr) {
3880 /* kernel subsystem misconfigured verifier */
3881 verbose(env, "invalid map_ptr to access map->type\n");
3882 return -EACCES;
3883 }
3884
3885 switch (meta->map_ptr->map_type) {
3886 case BPF_MAP_TYPE_SOCKMAP:
3887 case BPF_MAP_TYPE_SOCKHASH:
3888 if (*arg_type == ARG_PTR_TO_MAP_VALUE) {
3889 *arg_type = ARG_PTR_TO_SOCKET;
3890 } else {
3891 verbose(env, "invalid arg_type for sockmap/sockhash\n");
3892 return -EINVAL;
3893 }
3894 break;
3895
3896 default:
3897 break;
3898 }
3899 return 0;
3900}
3901
af7ec138
YS
3902static int check_func_arg(struct bpf_verifier_env *env, u32 arg,
3903 struct bpf_call_arg_meta *meta,
3904 const struct bpf_func_proto *fn)
17a52670 3905{
af7ec138 3906 u32 regno = BPF_REG_1 + arg;
638f5b90 3907 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
6841de8b 3908 enum bpf_reg_type expected_type, type = reg->type;
af7ec138 3909 enum bpf_arg_type arg_type = fn->arg_type[arg];
17a52670
AS
3910 int err = 0;
3911
80f1d68c 3912 if (arg_type == ARG_DONTCARE)
17a52670
AS
3913 return 0;
3914
dc503a8a
EC
3915 err = check_reg_arg(env, regno, SRC_OP);
3916 if (err)
3917 return err;
17a52670 3918
1be7f75d
AS
3919 if (arg_type == ARG_ANYTHING) {
3920 if (is_pointer_value(env, regno)) {
61bd5218
JK
3921 verbose(env, "R%d leaks addr into helper function\n",
3922 regno);
1be7f75d
AS
3923 return -EACCES;
3924 }
80f1d68c 3925 return 0;
1be7f75d 3926 }
80f1d68c 3927
de8f3a83 3928 if (type_is_pkt_pointer(type) &&
3a0af8fd 3929 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
61bd5218 3930 verbose(env, "helper access to the packet is not allowed\n");
6841de8b
AS
3931 return -EACCES;
3932 }
3933
912f442c
LB
3934 if (arg_type == ARG_PTR_TO_MAP_VALUE ||
3935 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE ||
3936 arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL) {
3937 err = resolve_map_arg_type(env, meta, &arg_type);
3938 if (err)
3939 return err;
3940 }
3941
8e2fe1d9 3942 if (arg_type == ARG_PTR_TO_MAP_KEY ||
2ea864c5 3943 arg_type == ARG_PTR_TO_MAP_VALUE ||
6ac99e8f
MKL
3944 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE ||
3945 arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL) {
17a52670 3946 expected_type = PTR_TO_STACK;
6ac99e8f
MKL
3947 if (register_is_null(reg) &&
3948 arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL)
3949 /* final test in check_stack_boundary() */;
3950 else if (!type_is_pkt_pointer(type) &&
3951 type != PTR_TO_MAP_VALUE &&
3952 type != expected_type)
6841de8b 3953 goto err_type;
39f19ebb 3954 } else if (arg_type == ARG_CONST_SIZE ||
457f4436
AN
3955 arg_type == ARG_CONST_SIZE_OR_ZERO ||
3956 arg_type == ARG_CONST_ALLOC_SIZE_OR_ZERO) {
f1174f77
EC
3957 expected_type = SCALAR_VALUE;
3958 if (type != expected_type)
6841de8b 3959 goto err_type;
17a52670
AS
3960 } else if (arg_type == ARG_CONST_MAP_PTR) {
3961 expected_type = CONST_PTR_TO_MAP;
6841de8b
AS
3962 if (type != expected_type)
3963 goto err_type;
f318903c
DB
3964 } else if (arg_type == ARG_PTR_TO_CTX ||
3965 arg_type == ARG_PTR_TO_CTX_OR_NULL) {
608cd71a 3966 expected_type = PTR_TO_CTX;
f318903c
DB
3967 if (!(register_is_null(reg) &&
3968 arg_type == ARG_PTR_TO_CTX_OR_NULL)) {
3969 if (type != expected_type)
3970 goto err_type;
3971 err = check_ctx_reg(env, reg, regno);
3972 if (err < 0)
3973 return err;
3974 }
46f8bc92
MKL
3975 } else if (arg_type == ARG_PTR_TO_SOCK_COMMON) {
3976 expected_type = PTR_TO_SOCK_COMMON;
3977 /* Any sk pointer can be ARG_PTR_TO_SOCK_COMMON */
3978 if (!type_is_sk_pointer(type))
3979 goto err_type;
1b986589
MKL
3980 if (reg->ref_obj_id) {
3981 if (meta->ref_obj_id) {
3982 verbose(env, "verifier internal error: more than one arg with ref_obj_id R%d %u %u\n",
3983 regno, reg->ref_obj_id,
3984 meta->ref_obj_id);
3985 return -EFAULT;
3986 }
3987 meta->ref_obj_id = reg->ref_obj_id;
fd978bf7 3988 }
e9ddbb77
JS
3989 } else if (arg_type == ARG_PTR_TO_SOCKET ||
3990 arg_type == ARG_PTR_TO_SOCKET_OR_NULL) {
6ac99e8f 3991 expected_type = PTR_TO_SOCKET;
e9ddbb77
JS
3992 if (!(register_is_null(reg) &&
3993 arg_type == ARG_PTR_TO_SOCKET_OR_NULL)) {
3994 if (type != expected_type)
3995 goto err_type;
3996 }
a7658e1a
AS
3997 } else if (arg_type == ARG_PTR_TO_BTF_ID) {
3998 expected_type = PTR_TO_BTF_ID;
3999 if (type != expected_type)
4000 goto err_type;
af7ec138
YS
4001 if (!fn->check_btf_id) {
4002 if (reg->btf_id != meta->btf_id) {
4003 verbose(env, "Helper has type %s got %s in R%d\n",
4004 kernel_type_name(meta->btf_id),
4005 kernel_type_name(reg->btf_id), regno);
4006
4007 return -EACCES;
4008 }
4009 } else if (!fn->check_btf_id(reg->btf_id, arg)) {
4010 verbose(env, "Helper does not support %s in R%d\n",
a7658e1a
AS
4011 kernel_type_name(reg->btf_id), regno);
4012
4013 return -EACCES;
4014 }
4015 if (!tnum_is_const(reg->var_off) || reg->var_off.value || reg->off) {
4016 verbose(env, "R%d is a pointer to in-kernel struct with non-zero offset\n",
4017 regno);
4018 return -EACCES;
4019 }
d83525ca
AS
4020 } else if (arg_type == ARG_PTR_TO_SPIN_LOCK) {
4021 if (meta->func_id == BPF_FUNC_spin_lock) {
4022 if (process_spin_lock(env, regno, true))
4023 return -EACCES;
4024 } else if (meta->func_id == BPF_FUNC_spin_unlock) {
4025 if (process_spin_lock(env, regno, false))
4026 return -EACCES;
4027 } else {
4028 verbose(env, "verifier internal error\n");
4029 return -EFAULT;
4030 }
90133415 4031 } else if (arg_type_is_mem_ptr(arg_type)) {
8e2fe1d9
DB
4032 expected_type = PTR_TO_STACK;
4033 /* One exception here. In case function allows for NULL to be
f1174f77 4034 * passed in as argument, it's a SCALAR_VALUE type. Final test
8e2fe1d9
DB
4035 * happens during stack boundary checking.
4036 */
914cb781 4037 if (register_is_null(reg) &&
457f4436
AN
4038 (arg_type == ARG_PTR_TO_MEM_OR_NULL ||
4039 arg_type == ARG_PTR_TO_ALLOC_MEM_OR_NULL))
6841de8b 4040 /* final test in check_stack_boundary() */;
de8f3a83
DB
4041 else if (!type_is_pkt_pointer(type) &&
4042 type != PTR_TO_MAP_VALUE &&
457f4436 4043 type != PTR_TO_MEM &&
afbf21dc
YS
4044 type != PTR_TO_RDONLY_BUF &&
4045 type != PTR_TO_RDWR_BUF &&
f1174f77 4046 type != expected_type)
6841de8b 4047 goto err_type;
39f19ebb 4048 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
457f4436
AN
4049 } else if (arg_type_is_alloc_mem_ptr(arg_type)) {
4050 expected_type = PTR_TO_MEM;
4051 if (register_is_null(reg) &&
4052 arg_type == ARG_PTR_TO_ALLOC_MEM_OR_NULL)
4053 /* final test in check_stack_boundary() */;
4054 else if (type != expected_type)
4055 goto err_type;
4056 if (meta->ref_obj_id) {
4057 verbose(env, "verifier internal error: more than one arg with ref_obj_id R%d %u %u\n",
4058 regno, reg->ref_obj_id,
4059 meta->ref_obj_id);
4060 return -EFAULT;
4061 }
4062 meta->ref_obj_id = reg->ref_obj_id;
57c3bb72
AI
4063 } else if (arg_type_is_int_ptr(arg_type)) {
4064 expected_type = PTR_TO_STACK;
4065 if (!type_is_pkt_pointer(type) &&
4066 type != PTR_TO_MAP_VALUE &&
4067 type != expected_type)
4068 goto err_type;
17a52670 4069 } else {
61bd5218 4070 verbose(env, "unsupported arg_type %d\n", arg_type);
17a52670
AS
4071 return -EFAULT;
4072 }
4073
17a52670
AS
4074 if (arg_type == ARG_CONST_MAP_PTR) {
4075 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
33ff9823 4076 meta->map_ptr = reg->map_ptr;
17a52670
AS
4077 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
4078 /* bpf_map_xxx(..., map_ptr, ..., key) call:
4079 * check that [key, key + map->key_size) are within
4080 * stack limits and initialized
4081 */
33ff9823 4082 if (!meta->map_ptr) {
17a52670
AS
4083 /* in function declaration map_ptr must come before
4084 * map_key, so that it's verified and known before
4085 * we have to check map_key here. Otherwise it means
4086 * that kernel subsystem misconfigured verifier
4087 */
61bd5218 4088 verbose(env, "invalid map_ptr to access map->key\n");
17a52670
AS
4089 return -EACCES;
4090 }
d71962f3
PC
4091 err = check_helper_mem_access(env, regno,
4092 meta->map_ptr->key_size, false,
4093 NULL);
2ea864c5 4094 } else if (arg_type == ARG_PTR_TO_MAP_VALUE ||
6ac99e8f
MKL
4095 (arg_type == ARG_PTR_TO_MAP_VALUE_OR_NULL &&
4096 !register_is_null(reg)) ||
2ea864c5 4097 arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE) {
17a52670
AS
4098 /* bpf_map_xxx(..., map_ptr, ..., value) call:
4099 * check [value, value + map->value_size) validity
4100 */
33ff9823 4101 if (!meta->map_ptr) {
17a52670 4102 /* kernel subsystem misconfigured verifier */
61bd5218 4103 verbose(env, "invalid map_ptr to access map->value\n");
17a52670
AS
4104 return -EACCES;
4105 }
2ea864c5 4106 meta->raw_mode = (arg_type == ARG_PTR_TO_UNINIT_MAP_VALUE);
d71962f3
PC
4107 err = check_helper_mem_access(env, regno,
4108 meta->map_ptr->value_size, false,
2ea864c5 4109 meta);
90133415 4110 } else if (arg_type_is_mem_size(arg_type)) {
39f19ebb 4111 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
17a52670 4112
10060503
JF
4113 /* This is used to refine r0 return value bounds for helpers
4114 * that enforce this value as an upper bound on return values.
4115 * See do_refine_retval_range() for helpers that can refine
4116 * the return value. C type of helper is u32 so we pull register
4117 * bound from umax_value however, if negative verifier errors
4118 * out. Only upper bounds can be learned because retval is an
4119 * int type and negative retvals are allowed.
849fa506 4120 */
10060503 4121 meta->msize_max_value = reg->umax_value;
849fa506 4122
f1174f77
EC
4123 /* The register is SCALAR_VALUE; the access check
4124 * happens using its boundaries.
06c1c049 4125 */
f1174f77 4126 if (!tnum_is_const(reg->var_off))
06c1c049
GB
4127 /* For unprivileged variable accesses, disable raw
4128 * mode so that the program is required to
4129 * initialize all the memory that the helper could
4130 * just partially fill up.
4131 */
4132 meta = NULL;
4133
b03c9f9f 4134 if (reg->smin_value < 0) {
61bd5218 4135 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
f1174f77
EC
4136 regno);
4137 return -EACCES;
4138 }
06c1c049 4139
b03c9f9f 4140 if (reg->umin_value == 0) {
f1174f77
EC
4141 err = check_helper_mem_access(env, regno - 1, 0,
4142 zero_size_allowed,
4143 meta);
06c1c049
GB
4144 if (err)
4145 return err;
06c1c049 4146 }
f1174f77 4147
b03c9f9f 4148 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
61bd5218 4149 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
f1174f77
EC
4150 regno);
4151 return -EACCES;
4152 }
4153 err = check_helper_mem_access(env, regno - 1,
b03c9f9f 4154 reg->umax_value,
f1174f77 4155 zero_size_allowed, meta);
b5dc0163
AS
4156 if (!err)
4157 err = mark_chain_precision(env, regno);
457f4436
AN
4158 } else if (arg_type_is_alloc_size(arg_type)) {
4159 if (!tnum_is_const(reg->var_off)) {
4160 verbose(env, "R%d unbounded size, use 'var &= const' or 'if (var < const)'\n",
4161 regno);
4162 return -EACCES;
4163 }
4164 meta->mem_size = reg->var_off.value;
57c3bb72
AI
4165 } else if (arg_type_is_int_ptr(arg_type)) {
4166 int size = int_ptr_type_to_size(arg_type);
4167
4168 err = check_helper_mem_access(env, regno, size, false, meta);
4169 if (err)
4170 return err;
4171 err = check_ptr_alignment(env, reg, 0, size, true);
17a52670
AS
4172 }
4173
4174 return err;
6841de8b 4175err_type:
61bd5218 4176 verbose(env, "R%d type=%s expected=%s\n", regno,
6841de8b
AS
4177 reg_type_str[type], reg_type_str[expected_type]);
4178 return -EACCES;
17a52670
AS
4179}
4180
0126240f
LB
4181static bool may_update_sockmap(struct bpf_verifier_env *env, int func_id)
4182{
4183 enum bpf_attach_type eatype = env->prog->expected_attach_type;
4184 enum bpf_prog_type type = env->prog->type;
4185
4186 if (func_id != BPF_FUNC_map_update_elem)
4187 return false;
4188
4189 /* It's not possible to get access to a locked struct sock in these
4190 * contexts, so updating is safe.
4191 */
4192 switch (type) {
4193 case BPF_PROG_TYPE_TRACING:
4194 if (eatype == BPF_TRACE_ITER)
4195 return true;
4196 break;
4197 case BPF_PROG_TYPE_SOCKET_FILTER:
4198 case BPF_PROG_TYPE_SCHED_CLS:
4199 case BPF_PROG_TYPE_SCHED_ACT:
4200 case BPF_PROG_TYPE_XDP:
4201 case BPF_PROG_TYPE_SK_REUSEPORT:
4202 case BPF_PROG_TYPE_FLOW_DISSECTOR:
4203 case BPF_PROG_TYPE_SK_LOOKUP:
4204 return true;
4205 default:
4206 break;
4207 }
4208
4209 verbose(env, "cannot update sockmap in this context\n");
4210 return false;
4211}
4212
61bd5218
JK
4213static int check_map_func_compatibility(struct bpf_verifier_env *env,
4214 struct bpf_map *map, int func_id)
35578d79 4215{
35578d79
KX
4216 if (!map)
4217 return 0;
4218
6aff67c8
AS
4219 /* We need a two way check, first is from map perspective ... */
4220 switch (map->map_type) {
4221 case BPF_MAP_TYPE_PROG_ARRAY:
4222 if (func_id != BPF_FUNC_tail_call)
4223 goto error;
4224 break;
4225 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
4226 if (func_id != BPF_FUNC_perf_event_read &&
908432ca 4227 func_id != BPF_FUNC_perf_event_output &&
a7658e1a 4228 func_id != BPF_FUNC_skb_output &&
d831ee84
EC
4229 func_id != BPF_FUNC_perf_event_read_value &&
4230 func_id != BPF_FUNC_xdp_output)
6aff67c8
AS
4231 goto error;
4232 break;
457f4436
AN
4233 case BPF_MAP_TYPE_RINGBUF:
4234 if (func_id != BPF_FUNC_ringbuf_output &&
4235 func_id != BPF_FUNC_ringbuf_reserve &&
4236 func_id != BPF_FUNC_ringbuf_submit &&
4237 func_id != BPF_FUNC_ringbuf_discard &&
4238 func_id != BPF_FUNC_ringbuf_query)
4239 goto error;
4240 break;
6aff67c8
AS
4241 case BPF_MAP_TYPE_STACK_TRACE:
4242 if (func_id != BPF_FUNC_get_stackid)
4243 goto error;
4244 break;
4ed8ec52 4245 case BPF_MAP_TYPE_CGROUP_ARRAY:
60747ef4 4246 if (func_id != BPF_FUNC_skb_under_cgroup &&
60d20f91 4247 func_id != BPF_FUNC_current_task_under_cgroup)
4a482f34
MKL
4248 goto error;
4249 break;
cd339431 4250 case BPF_MAP_TYPE_CGROUP_STORAGE:
b741f163 4251 case BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE:
cd339431
RG
4252 if (func_id != BPF_FUNC_get_local_storage)
4253 goto error;
4254 break;
546ac1ff 4255 case BPF_MAP_TYPE_DEVMAP:
6f9d451a 4256 case BPF_MAP_TYPE_DEVMAP_HASH:
0cdbb4b0
THJ
4257 if (func_id != BPF_FUNC_redirect_map &&
4258 func_id != BPF_FUNC_map_lookup_elem)
546ac1ff
JF
4259 goto error;
4260 break;
fbfc504a
BT
4261 /* Restrict bpf side of cpumap and xskmap, open when use-cases
4262 * appear.
4263 */
6710e112
JDB
4264 case BPF_MAP_TYPE_CPUMAP:
4265 if (func_id != BPF_FUNC_redirect_map)
4266 goto error;
4267 break;
fada7fdc
JL
4268 case BPF_MAP_TYPE_XSKMAP:
4269 if (func_id != BPF_FUNC_redirect_map &&
4270 func_id != BPF_FUNC_map_lookup_elem)
4271 goto error;
4272 break;
56f668df 4273 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
bcc6b1b7 4274 case BPF_MAP_TYPE_HASH_OF_MAPS:
56f668df
MKL
4275 if (func_id != BPF_FUNC_map_lookup_elem)
4276 goto error;
16a43625 4277 break;
174a79ff
JF
4278 case BPF_MAP_TYPE_SOCKMAP:
4279 if (func_id != BPF_FUNC_sk_redirect_map &&
4280 func_id != BPF_FUNC_sock_map_update &&
4f738adb 4281 func_id != BPF_FUNC_map_delete_elem &&
9fed9000 4282 func_id != BPF_FUNC_msg_redirect_map &&
64d85290 4283 func_id != BPF_FUNC_sk_select_reuseport &&
0126240f
LB
4284 func_id != BPF_FUNC_map_lookup_elem &&
4285 !may_update_sockmap(env, func_id))
174a79ff
JF
4286 goto error;
4287 break;
81110384
JF
4288 case BPF_MAP_TYPE_SOCKHASH:
4289 if (func_id != BPF_FUNC_sk_redirect_hash &&
4290 func_id != BPF_FUNC_sock_hash_update &&
4291 func_id != BPF_FUNC_map_delete_elem &&
9fed9000 4292 func_id != BPF_FUNC_msg_redirect_hash &&
64d85290 4293 func_id != BPF_FUNC_sk_select_reuseport &&
0126240f
LB
4294 func_id != BPF_FUNC_map_lookup_elem &&
4295 !may_update_sockmap(env, func_id))
81110384
JF
4296 goto error;
4297 break;
2dbb9b9e
MKL
4298 case BPF_MAP_TYPE_REUSEPORT_SOCKARRAY:
4299 if (func_id != BPF_FUNC_sk_select_reuseport)
4300 goto error;
4301 break;
f1a2e44a
MV
4302 case BPF_MAP_TYPE_QUEUE:
4303 case BPF_MAP_TYPE_STACK:
4304 if (func_id != BPF_FUNC_map_peek_elem &&
4305 func_id != BPF_FUNC_map_pop_elem &&
4306 func_id != BPF_FUNC_map_push_elem)
4307 goto error;
4308 break;
6ac99e8f
MKL
4309 case BPF_MAP_TYPE_SK_STORAGE:
4310 if (func_id != BPF_FUNC_sk_storage_get &&
4311 func_id != BPF_FUNC_sk_storage_delete)
4312 goto error;
4313 break;
8ea63684
KS
4314 case BPF_MAP_TYPE_INODE_STORAGE:
4315 if (func_id != BPF_FUNC_inode_storage_get &&
4316 func_id != BPF_FUNC_inode_storage_delete)
4317 goto error;
4318 break;
6aff67c8
AS
4319 default:
4320 break;
4321 }
4322
4323 /* ... and second from the function itself. */
4324 switch (func_id) {
4325 case BPF_FUNC_tail_call:
4326 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
4327 goto error;
f910cefa 4328 if (env->subprog_cnt > 1) {
f4d7e40a
AS
4329 verbose(env, "tail_calls are not allowed in programs with bpf-to-bpf calls\n");
4330 return -EINVAL;
4331 }
6aff67c8
AS
4332 break;
4333 case BPF_FUNC_perf_event_read:
4334 case BPF_FUNC_perf_event_output:
908432ca 4335 case BPF_FUNC_perf_event_read_value:
a7658e1a 4336 case BPF_FUNC_skb_output:
d831ee84 4337 case BPF_FUNC_xdp_output:
6aff67c8
AS
4338 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
4339 goto error;
4340 break;
4341 case BPF_FUNC_get_stackid:
4342 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
4343 goto error;
4344 break;
60d20f91 4345 case BPF_FUNC_current_task_under_cgroup:
747ea55e 4346 case BPF_FUNC_skb_under_cgroup:
4a482f34
MKL
4347 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
4348 goto error;
4349 break;
97f91a7c 4350 case BPF_FUNC_redirect_map:
9c270af3 4351 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
6f9d451a 4352 map->map_type != BPF_MAP_TYPE_DEVMAP_HASH &&
fbfc504a
BT
4353 map->map_type != BPF_MAP_TYPE_CPUMAP &&
4354 map->map_type != BPF_MAP_TYPE_XSKMAP)
97f91a7c
JF
4355 goto error;
4356 break;
174a79ff 4357 case BPF_FUNC_sk_redirect_map:
4f738adb 4358 case BPF_FUNC_msg_redirect_map:
81110384 4359 case BPF_FUNC_sock_map_update:
174a79ff
JF
4360 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
4361 goto error;
4362 break;
81110384
JF
4363 case BPF_FUNC_sk_redirect_hash:
4364 case BPF_FUNC_msg_redirect_hash:
4365 case BPF_FUNC_sock_hash_update:
4366 if (map->map_type != BPF_MAP_TYPE_SOCKHASH)
174a79ff
JF
4367 goto error;
4368 break;
cd339431 4369 case BPF_FUNC_get_local_storage:
b741f163
RG
4370 if (map->map_type != BPF_MAP_TYPE_CGROUP_STORAGE &&
4371 map->map_type != BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE)
cd339431
RG
4372 goto error;
4373 break;
2dbb9b9e 4374 case BPF_FUNC_sk_select_reuseport:
9fed9000
JS
4375 if (map->map_type != BPF_MAP_TYPE_REUSEPORT_SOCKARRAY &&
4376 map->map_type != BPF_MAP_TYPE_SOCKMAP &&
4377 map->map_type != BPF_MAP_TYPE_SOCKHASH)
2dbb9b9e
MKL
4378 goto error;
4379 break;
f1a2e44a
MV
4380 case BPF_FUNC_map_peek_elem:
4381 case BPF_FUNC_map_pop_elem:
4382 case BPF_FUNC_map_push_elem:
4383 if (map->map_type != BPF_MAP_TYPE_QUEUE &&
4384 map->map_type != BPF_MAP_TYPE_STACK)
4385 goto error;
4386 break;
6ac99e8f
MKL
4387 case BPF_FUNC_sk_storage_get:
4388 case BPF_FUNC_sk_storage_delete:
4389 if (map->map_type != BPF_MAP_TYPE_SK_STORAGE)
4390 goto error;
4391 break;
8ea63684
KS
4392 case BPF_FUNC_inode_storage_get:
4393 case BPF_FUNC_inode_storage_delete:
4394 if (map->map_type != BPF_MAP_TYPE_INODE_STORAGE)
4395 goto error;
4396 break;
6aff67c8
AS
4397 default:
4398 break;
35578d79
KX
4399 }
4400
4401 return 0;
6aff67c8 4402error:
61bd5218 4403 verbose(env, "cannot pass map_type %d into func %s#%d\n",
ebb676da 4404 map->map_type, func_id_name(func_id), func_id);
6aff67c8 4405 return -EINVAL;
35578d79
KX
4406}
4407
90133415 4408static bool check_raw_mode_ok(const struct bpf_func_proto *fn)
435faee1
DB
4409{
4410 int count = 0;
4411
39f19ebb 4412 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4413 count++;
39f19ebb 4414 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4415 count++;
39f19ebb 4416 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4417 count++;
39f19ebb 4418 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 4419 count++;
39f19ebb 4420 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
435faee1
DB
4421 count++;
4422
90133415
DB
4423 /* We only support one arg being in raw mode at the moment,
4424 * which is sufficient for the helper functions we have
4425 * right now.
4426 */
4427 return count <= 1;
4428}
4429
4430static bool check_args_pair_invalid(enum bpf_arg_type arg_curr,
4431 enum bpf_arg_type arg_next)
4432{
4433 return (arg_type_is_mem_ptr(arg_curr) &&
4434 !arg_type_is_mem_size(arg_next)) ||
4435 (!arg_type_is_mem_ptr(arg_curr) &&
4436 arg_type_is_mem_size(arg_next));
4437}
4438
4439static bool check_arg_pair_ok(const struct bpf_func_proto *fn)
4440{
4441 /* bpf_xxx(..., buf, len) call will access 'len'
4442 * bytes from memory 'buf'. Both arg types need
4443 * to be paired, so make sure there's no buggy
4444 * helper function specification.
4445 */
4446 if (arg_type_is_mem_size(fn->arg1_type) ||
4447 arg_type_is_mem_ptr(fn->arg5_type) ||
4448 check_args_pair_invalid(fn->arg1_type, fn->arg2_type) ||
4449 check_args_pair_invalid(fn->arg2_type, fn->arg3_type) ||
4450 check_args_pair_invalid(fn->arg3_type, fn->arg4_type) ||
4451 check_args_pair_invalid(fn->arg4_type, fn->arg5_type))
4452 return false;
4453
4454 return true;
4455}
4456
1b986589 4457static bool check_refcount_ok(const struct bpf_func_proto *fn, int func_id)
fd978bf7
JS
4458{
4459 int count = 0;
4460
1b986589 4461 if (arg_type_may_be_refcounted(fn->arg1_type))
fd978bf7 4462 count++;
1b986589 4463 if (arg_type_may_be_refcounted(fn->arg2_type))
fd978bf7 4464 count++;
1b986589 4465 if (arg_type_may_be_refcounted(fn->arg3_type))
fd978bf7 4466 count++;
1b986589 4467 if (arg_type_may_be_refcounted(fn->arg4_type))
fd978bf7 4468 count++;
1b986589 4469 if (arg_type_may_be_refcounted(fn->arg5_type))
fd978bf7
JS
4470 count++;
4471
1b986589
MKL
4472 /* A reference acquiring function cannot acquire
4473 * another refcounted ptr.
4474 */
64d85290 4475 if (may_be_acquire_function(func_id) && count)
1b986589
MKL
4476 return false;
4477
fd978bf7
JS
4478 /* We only support one arg being unreferenced at the moment,
4479 * which is sufficient for the helper functions we have right now.
4480 */
4481 return count <= 1;
4482}
4483
1b986589 4484static int check_func_proto(const struct bpf_func_proto *fn, int func_id)
90133415
DB
4485{
4486 return check_raw_mode_ok(fn) &&
fd978bf7 4487 check_arg_pair_ok(fn) &&
1b986589 4488 check_refcount_ok(fn, func_id) ? 0 : -EINVAL;
435faee1
DB
4489}
4490
de8f3a83
DB
4491/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
4492 * are now invalid, so turn them into unknown SCALAR_VALUE.
f1174f77 4493 */
f4d7e40a
AS
4494static void __clear_all_pkt_pointers(struct bpf_verifier_env *env,
4495 struct bpf_func_state *state)
969bf05e 4496{
58e2af8b 4497 struct bpf_reg_state *regs = state->regs, *reg;
969bf05e
AS
4498 int i;
4499
4500 for (i = 0; i < MAX_BPF_REG; i++)
de8f3a83 4501 if (reg_is_pkt_pointer_any(&regs[i]))
61bd5218 4502 mark_reg_unknown(env, regs, i);
969bf05e 4503
f3709f69
JS
4504 bpf_for_each_spilled_reg(i, state, reg) {
4505 if (!reg)
969bf05e 4506 continue;
de8f3a83 4507 if (reg_is_pkt_pointer_any(reg))
f54c7898 4508 __mark_reg_unknown(env, reg);
969bf05e
AS
4509 }
4510}
4511
f4d7e40a
AS
4512static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
4513{
4514 struct bpf_verifier_state *vstate = env->cur_state;
4515 int i;
4516
4517 for (i = 0; i <= vstate->curframe; i++)
4518 __clear_all_pkt_pointers(env, vstate->frame[i]);
4519}
4520
fd978bf7 4521static void release_reg_references(struct bpf_verifier_env *env,
1b986589
MKL
4522 struct bpf_func_state *state,
4523 int ref_obj_id)
fd978bf7
JS
4524{
4525 struct bpf_reg_state *regs = state->regs, *reg;
4526 int i;
4527
4528 for (i = 0; i < MAX_BPF_REG; i++)
1b986589 4529 if (regs[i].ref_obj_id == ref_obj_id)
fd978bf7
JS
4530 mark_reg_unknown(env, regs, i);
4531
4532 bpf_for_each_spilled_reg(i, state, reg) {
4533 if (!reg)
4534 continue;
1b986589 4535 if (reg->ref_obj_id == ref_obj_id)
f54c7898 4536 __mark_reg_unknown(env, reg);
fd978bf7
JS
4537 }
4538}
4539
4540/* The pointer with the specified id has released its reference to kernel
4541 * resources. Identify all copies of the same pointer and clear the reference.
4542 */
4543static int release_reference(struct bpf_verifier_env *env,
1b986589 4544 int ref_obj_id)
fd978bf7
JS
4545{
4546 struct bpf_verifier_state *vstate = env->cur_state;
1b986589 4547 int err;
fd978bf7
JS
4548 int i;
4549
1b986589
MKL
4550 err = release_reference_state(cur_func(env), ref_obj_id);
4551 if (err)
4552 return err;
4553
fd978bf7 4554 for (i = 0; i <= vstate->curframe; i++)
1b986589 4555 release_reg_references(env, vstate->frame[i], ref_obj_id);
fd978bf7 4556
1b986589 4557 return 0;
fd978bf7
JS
4558}
4559
51c39bb1
AS
4560static void clear_caller_saved_regs(struct bpf_verifier_env *env,
4561 struct bpf_reg_state *regs)
4562{
4563 int i;
4564
4565 /* after the call registers r0 - r5 were scratched */
4566 for (i = 0; i < CALLER_SAVED_REGS; i++) {
4567 mark_reg_not_init(env, regs, caller_saved[i]);
4568 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
4569 }
4570}
4571
f4d7e40a
AS
4572static int check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
4573 int *insn_idx)
4574{
4575 struct bpf_verifier_state *state = env->cur_state;
51c39bb1 4576 struct bpf_func_info_aux *func_info_aux;
f4d7e40a 4577 struct bpf_func_state *caller, *callee;
fd978bf7 4578 int i, err, subprog, target_insn;
51c39bb1 4579 bool is_global = false;
f4d7e40a 4580
aada9ce6 4581 if (state->curframe + 1 >= MAX_CALL_FRAMES) {
f4d7e40a 4582 verbose(env, "the call stack of %d frames is too deep\n",
aada9ce6 4583 state->curframe + 2);
f4d7e40a
AS
4584 return -E2BIG;
4585 }
4586
4587 target_insn = *insn_idx + insn->imm;
4588 subprog = find_subprog(env, target_insn + 1);
4589 if (subprog < 0) {
4590 verbose(env, "verifier bug. No program starts at insn %d\n",
4591 target_insn + 1);
4592 return -EFAULT;
4593 }
4594
4595 caller = state->frame[state->curframe];
4596 if (state->frame[state->curframe + 1]) {
4597 verbose(env, "verifier bug. Frame %d already allocated\n",
4598 state->curframe + 1);
4599 return -EFAULT;
4600 }
4601
51c39bb1
AS
4602 func_info_aux = env->prog->aux->func_info_aux;
4603 if (func_info_aux)
4604 is_global = func_info_aux[subprog].linkage == BTF_FUNC_GLOBAL;
4605 err = btf_check_func_arg_match(env, subprog, caller->regs);
4606 if (err == -EFAULT)
4607 return err;
4608 if (is_global) {
4609 if (err) {
4610 verbose(env, "Caller passes invalid args into func#%d\n",
4611 subprog);
4612 return err;
4613 } else {
4614 if (env->log.level & BPF_LOG_LEVEL)
4615 verbose(env,
4616 "Func#%d is global and valid. Skipping.\n",
4617 subprog);
4618 clear_caller_saved_regs(env, caller->regs);
4619
4620 /* All global functions return SCALAR_VALUE */
4621 mark_reg_unknown(env, caller->regs, BPF_REG_0);
4622
4623 /* continue with next insn after call */
4624 return 0;
4625 }
4626 }
4627
f4d7e40a
AS
4628 callee = kzalloc(sizeof(*callee), GFP_KERNEL);
4629 if (!callee)
4630 return -ENOMEM;
4631 state->frame[state->curframe + 1] = callee;
4632
4633 /* callee cannot access r0, r6 - r9 for reading and has to write
4634 * into its own stack before reading from it.
4635 * callee can read/write into caller's stack
4636 */
4637 init_func_state(env, callee,
4638 /* remember the callsite, it will be used by bpf_exit */
4639 *insn_idx /* callsite */,
4640 state->curframe + 1 /* frameno within this callchain */,
f910cefa 4641 subprog /* subprog number within this prog */);
f4d7e40a 4642
fd978bf7
JS
4643 /* Transfer references to the callee */
4644 err = transfer_reference_state(callee, caller);
4645 if (err)
4646 return err;
4647
679c782d
EC
4648 /* copy r1 - r5 args that callee can access. The copy includes parent
4649 * pointers, which connects us up to the liveness chain
4650 */
f4d7e40a
AS
4651 for (i = BPF_REG_1; i <= BPF_REG_5; i++)
4652 callee->regs[i] = caller->regs[i];
4653
51c39bb1 4654 clear_caller_saved_regs(env, caller->regs);
f4d7e40a
AS
4655
4656 /* only increment it after check_reg_arg() finished */
4657 state->curframe++;
4658
4659 /* and go analyze first insn of the callee */
4660 *insn_idx = target_insn;
4661
06ee7115 4662 if (env->log.level & BPF_LOG_LEVEL) {
f4d7e40a
AS
4663 verbose(env, "caller:\n");
4664 print_verifier_state(env, caller);
4665 verbose(env, "callee:\n");
4666 print_verifier_state(env, callee);
4667 }
4668 return 0;
4669}
4670
4671static int prepare_func_exit(struct bpf_verifier_env *env, int *insn_idx)
4672{
4673 struct bpf_verifier_state *state = env->cur_state;
4674 struct bpf_func_state *caller, *callee;
4675 struct bpf_reg_state *r0;
fd978bf7 4676 int err;
f4d7e40a
AS
4677
4678 callee = state->frame[state->curframe];
4679 r0 = &callee->regs[BPF_REG_0];
4680 if (r0->type == PTR_TO_STACK) {
4681 /* technically it's ok to return caller's stack pointer
4682 * (or caller's caller's pointer) back to the caller,
4683 * since these pointers are valid. Only current stack
4684 * pointer will be invalid as soon as function exits,
4685 * but let's be conservative
4686 */
4687 verbose(env, "cannot return stack pointer to the caller\n");
4688 return -EINVAL;
4689 }
4690
4691 state->curframe--;
4692 caller = state->frame[state->curframe];
4693 /* return to the caller whatever r0 had in the callee */
4694 caller->regs[BPF_REG_0] = *r0;
4695
fd978bf7
JS
4696 /* Transfer references to the caller */
4697 err = transfer_reference_state(caller, callee);
4698 if (err)
4699 return err;
4700
f4d7e40a 4701 *insn_idx = callee->callsite + 1;
06ee7115 4702 if (env->log.level & BPF_LOG_LEVEL) {
f4d7e40a
AS
4703 verbose(env, "returning from callee:\n");
4704 print_verifier_state(env, callee);
4705 verbose(env, "to caller at %d:\n", *insn_idx);
4706 print_verifier_state(env, caller);
4707 }
4708 /* clear everything in the callee */
4709 free_func_state(callee);
4710 state->frame[state->curframe + 1] = NULL;
4711 return 0;
4712}
4713
849fa506
YS
4714static void do_refine_retval_range(struct bpf_reg_state *regs, int ret_type,
4715 int func_id,
4716 struct bpf_call_arg_meta *meta)
4717{
4718 struct bpf_reg_state *ret_reg = &regs[BPF_REG_0];
4719
4720 if (ret_type != RET_INTEGER ||
4721 (func_id != BPF_FUNC_get_stack &&
47cc0ed5
DB
4722 func_id != BPF_FUNC_probe_read_str &&
4723 func_id != BPF_FUNC_probe_read_kernel_str &&
4724 func_id != BPF_FUNC_probe_read_user_str))
849fa506
YS
4725 return;
4726
10060503 4727 ret_reg->smax_value = meta->msize_max_value;
fa123ac0 4728 ret_reg->s32_max_value = meta->msize_max_value;
849fa506
YS
4729 __reg_deduce_bounds(ret_reg);
4730 __reg_bound_offset(ret_reg);
10060503 4731 __update_reg_bounds(ret_reg);
849fa506
YS
4732}
4733
c93552c4
DB
4734static int
4735record_func_map(struct bpf_verifier_env *env, struct bpf_call_arg_meta *meta,
4736 int func_id, int insn_idx)
4737{
4738 struct bpf_insn_aux_data *aux = &env->insn_aux_data[insn_idx];
591fe988 4739 struct bpf_map *map = meta->map_ptr;
c93552c4
DB
4740
4741 if (func_id != BPF_FUNC_tail_call &&
09772d92
DB
4742 func_id != BPF_FUNC_map_lookup_elem &&
4743 func_id != BPF_FUNC_map_update_elem &&
f1a2e44a
MV
4744 func_id != BPF_FUNC_map_delete_elem &&
4745 func_id != BPF_FUNC_map_push_elem &&
4746 func_id != BPF_FUNC_map_pop_elem &&
4747 func_id != BPF_FUNC_map_peek_elem)
c93552c4 4748 return 0;
09772d92 4749
591fe988 4750 if (map == NULL) {
c93552c4
DB
4751 verbose(env, "kernel subsystem misconfigured verifier\n");
4752 return -EINVAL;
4753 }
4754
591fe988
DB
4755 /* In case of read-only, some additional restrictions
4756 * need to be applied in order to prevent altering the
4757 * state of the map from program side.
4758 */
4759 if ((map->map_flags & BPF_F_RDONLY_PROG) &&
4760 (func_id == BPF_FUNC_map_delete_elem ||
4761 func_id == BPF_FUNC_map_update_elem ||
4762 func_id == BPF_FUNC_map_push_elem ||
4763 func_id == BPF_FUNC_map_pop_elem)) {
4764 verbose(env, "write into map forbidden\n");
4765 return -EACCES;
4766 }
4767
d2e4c1e6 4768 if (!BPF_MAP_PTR(aux->map_ptr_state))
c93552c4 4769 bpf_map_ptr_store(aux, meta->map_ptr,
2c78ee89 4770 !meta->map_ptr->bypass_spec_v1);
d2e4c1e6 4771 else if (BPF_MAP_PTR(aux->map_ptr_state) != meta->map_ptr)
c93552c4 4772 bpf_map_ptr_store(aux, BPF_MAP_PTR_POISON,
2c78ee89 4773 !meta->map_ptr->bypass_spec_v1);
c93552c4
DB
4774 return 0;
4775}
4776
d2e4c1e6
DB
4777static int
4778record_func_key(struct bpf_verifier_env *env, struct bpf_call_arg_meta *meta,
4779 int func_id, int insn_idx)
4780{
4781 struct bpf_insn_aux_data *aux = &env->insn_aux_data[insn_idx];
4782 struct bpf_reg_state *regs = cur_regs(env), *reg;
4783 struct bpf_map *map = meta->map_ptr;
4784 struct tnum range;
4785 u64 val;
cc52d914 4786 int err;
d2e4c1e6
DB
4787
4788 if (func_id != BPF_FUNC_tail_call)
4789 return 0;
4790 if (!map || map->map_type != BPF_MAP_TYPE_PROG_ARRAY) {
4791 verbose(env, "kernel subsystem misconfigured verifier\n");
4792 return -EINVAL;
4793 }
4794
4795 range = tnum_range(0, map->max_entries - 1);
4796 reg = &regs[BPF_REG_3];
4797
4798 if (!register_is_const(reg) || !tnum_in(range, reg->var_off)) {
4799 bpf_map_key_store(aux, BPF_MAP_KEY_POISON);
4800 return 0;
4801 }
4802
cc52d914
DB
4803 err = mark_chain_precision(env, BPF_REG_3);
4804 if (err)
4805 return err;
4806
d2e4c1e6
DB
4807 val = reg->var_off.value;
4808 if (bpf_map_key_unseen(aux))
4809 bpf_map_key_store(aux, val);
4810 else if (!bpf_map_key_poisoned(aux) &&
4811 bpf_map_key_immediate(aux) != val)
4812 bpf_map_key_store(aux, BPF_MAP_KEY_POISON);
4813 return 0;
4814}
4815
fd978bf7
JS
4816static int check_reference_leak(struct bpf_verifier_env *env)
4817{
4818 struct bpf_func_state *state = cur_func(env);
4819 int i;
4820
4821 for (i = 0; i < state->acquired_refs; i++) {
4822 verbose(env, "Unreleased reference id=%d alloc_insn=%d\n",
4823 state->refs[i].id, state->refs[i].insn_idx);
4824 }
4825 return state->acquired_refs ? -EINVAL : 0;
4826}
4827
f4d7e40a 4828static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
17a52670 4829{
17a52670 4830 const struct bpf_func_proto *fn = NULL;
638f5b90 4831 struct bpf_reg_state *regs;
33ff9823 4832 struct bpf_call_arg_meta meta;
969bf05e 4833 bool changes_data;
17a52670
AS
4834 int i, err;
4835
4836 /* find function prototype */
4837 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
61bd5218
JK
4838 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
4839 func_id);
17a52670
AS
4840 return -EINVAL;
4841 }
4842
00176a34 4843 if (env->ops->get_func_proto)
5e43f899 4844 fn = env->ops->get_func_proto(func_id, env->prog);
17a52670 4845 if (!fn) {
61bd5218
JK
4846 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
4847 func_id);
17a52670
AS
4848 return -EINVAL;
4849 }
4850
4851 /* eBPF programs must be GPL compatible to use GPL-ed functions */
24701ece 4852 if (!env->prog->gpl_compatible && fn->gpl_only) {
3fe2867c 4853 verbose(env, "cannot call GPL-restricted function from non-GPL compatible program\n");
17a52670
AS
4854 return -EINVAL;
4855 }
4856
04514d13 4857 /* With LD_ABS/IND some JITs save/restore skb from r1. */
17bedab2 4858 changes_data = bpf_helper_changes_pkt_data(fn->func);
04514d13
DB
4859 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
4860 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
4861 func_id_name(func_id), func_id);
4862 return -EINVAL;
4863 }
969bf05e 4864
33ff9823 4865 memset(&meta, 0, sizeof(meta));
36bbef52 4866 meta.pkt_access = fn->pkt_access;
33ff9823 4867
1b986589 4868 err = check_func_proto(fn, func_id);
435faee1 4869 if (err) {
61bd5218 4870 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
ebb676da 4871 func_id_name(func_id), func_id);
435faee1
DB
4872 return err;
4873 }
4874
d83525ca 4875 meta.func_id = func_id;
17a52670 4876 /* check args */
a7658e1a 4877 for (i = 0; i < 5; i++) {
af7ec138
YS
4878 if (!fn->check_btf_id) {
4879 err = btf_resolve_helper_id(&env->log, fn, i);
4880 if (err > 0)
4881 meta.btf_id = err;
4882 }
4883 err = check_func_arg(env, i, &meta, fn);
a7658e1a
AS
4884 if (err)
4885 return err;
4886 }
17a52670 4887
c93552c4
DB
4888 err = record_func_map(env, &meta, func_id, insn_idx);
4889 if (err)
4890 return err;
4891
d2e4c1e6
DB
4892 err = record_func_key(env, &meta, func_id, insn_idx);
4893 if (err)
4894 return err;
4895
435faee1
DB
4896 /* Mark slots with STACK_MISC in case of raw mode, stack offset
4897 * is inferred from register state.
4898 */
4899 for (i = 0; i < meta.access_size; i++) {
ca369602
DB
4900 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B,
4901 BPF_WRITE, -1, false);
435faee1
DB
4902 if (err)
4903 return err;
4904 }
4905
fd978bf7
JS
4906 if (func_id == BPF_FUNC_tail_call) {
4907 err = check_reference_leak(env);
4908 if (err) {
4909 verbose(env, "tail_call would lead to reference leak\n");
4910 return err;
4911 }
4912 } else if (is_release_function(func_id)) {
1b986589 4913 err = release_reference(env, meta.ref_obj_id);
46f8bc92
MKL
4914 if (err) {
4915 verbose(env, "func %s#%d reference has not been acquired before\n",
4916 func_id_name(func_id), func_id);
fd978bf7 4917 return err;
46f8bc92 4918 }
fd978bf7
JS
4919 }
4920
638f5b90 4921 regs = cur_regs(env);
cd339431
RG
4922
4923 /* check that flags argument in get_local_storage(map, flags) is 0,
4924 * this is required because get_local_storage() can't return an error.
4925 */
4926 if (func_id == BPF_FUNC_get_local_storage &&
4927 !register_is_null(&regs[BPF_REG_2])) {
4928 verbose(env, "get_local_storage() doesn't support non-zero flags\n");
4929 return -EINVAL;
4930 }
4931
17a52670 4932 /* reset caller saved regs */
dc503a8a 4933 for (i = 0; i < CALLER_SAVED_REGS; i++) {
61bd5218 4934 mark_reg_not_init(env, regs, caller_saved[i]);
dc503a8a
EC
4935 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
4936 }
17a52670 4937
5327ed3d
JW
4938 /* helper call returns 64-bit value. */
4939 regs[BPF_REG_0].subreg_def = DEF_NOT_SUBREG;
4940
dc503a8a 4941 /* update return register (already marked as written above) */
17a52670 4942 if (fn->ret_type == RET_INTEGER) {
f1174f77 4943 /* sets type to SCALAR_VALUE */
61bd5218 4944 mark_reg_unknown(env, regs, BPF_REG_0);
17a52670
AS
4945 } else if (fn->ret_type == RET_VOID) {
4946 regs[BPF_REG_0].type = NOT_INIT;
3e6a4b3e
RG
4947 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL ||
4948 fn->ret_type == RET_PTR_TO_MAP_VALUE) {
f1174f77 4949 /* There is no offset yet applied, variable or fixed */
61bd5218 4950 mark_reg_known_zero(env, regs, BPF_REG_0);
17a52670
AS
4951 /* remember map_ptr, so that check_map_access()
4952 * can check 'value_size' boundary of memory access
4953 * to map element returned from bpf_map_lookup_elem()
4954 */
33ff9823 4955 if (meta.map_ptr == NULL) {
61bd5218
JK
4956 verbose(env,
4957 "kernel subsystem misconfigured verifier\n");
17a52670
AS
4958 return -EINVAL;
4959 }
33ff9823 4960 regs[BPF_REG_0].map_ptr = meta.map_ptr;
4d31f301
DB
4961 if (fn->ret_type == RET_PTR_TO_MAP_VALUE) {
4962 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE;
e16d2f1a
AS
4963 if (map_value_has_spin_lock(meta.map_ptr))
4964 regs[BPF_REG_0].id = ++env->id_gen;
4d31f301
DB
4965 } else {
4966 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
4967 regs[BPF_REG_0].id = ++env->id_gen;
4968 }
c64b7983
JS
4969 } else if (fn->ret_type == RET_PTR_TO_SOCKET_OR_NULL) {
4970 mark_reg_known_zero(env, regs, BPF_REG_0);
4971 regs[BPF_REG_0].type = PTR_TO_SOCKET_OR_NULL;
0f3adc28 4972 regs[BPF_REG_0].id = ++env->id_gen;
85a51f8c
LB
4973 } else if (fn->ret_type == RET_PTR_TO_SOCK_COMMON_OR_NULL) {
4974 mark_reg_known_zero(env, regs, BPF_REG_0);
4975 regs[BPF_REG_0].type = PTR_TO_SOCK_COMMON_OR_NULL;
4976 regs[BPF_REG_0].id = ++env->id_gen;
655a51e5
MKL
4977 } else if (fn->ret_type == RET_PTR_TO_TCP_SOCK_OR_NULL) {
4978 mark_reg_known_zero(env, regs, BPF_REG_0);
4979 regs[BPF_REG_0].type = PTR_TO_TCP_SOCK_OR_NULL;
4980 regs[BPF_REG_0].id = ++env->id_gen;
457f4436
AN
4981 } else if (fn->ret_type == RET_PTR_TO_ALLOC_MEM_OR_NULL) {
4982 mark_reg_known_zero(env, regs, BPF_REG_0);
4983 regs[BPF_REG_0].type = PTR_TO_MEM_OR_NULL;
4984 regs[BPF_REG_0].id = ++env->id_gen;
4985 regs[BPF_REG_0].mem_size = meta.mem_size;
af7ec138
YS
4986 } else if (fn->ret_type == RET_PTR_TO_BTF_ID_OR_NULL) {
4987 int ret_btf_id;
4988
4989 mark_reg_known_zero(env, regs, BPF_REG_0);
4990 regs[BPF_REG_0].type = PTR_TO_BTF_ID_OR_NULL;
4991 ret_btf_id = *fn->ret_btf_id;
4992 if (ret_btf_id == 0) {
4993 verbose(env, "invalid return type %d of func %s#%d\n",
4994 fn->ret_type, func_id_name(func_id), func_id);
4995 return -EINVAL;
4996 }
4997 regs[BPF_REG_0].btf_id = ret_btf_id;
17a52670 4998 } else {
61bd5218 4999 verbose(env, "unknown return type %d of func %s#%d\n",
ebb676da 5000 fn->ret_type, func_id_name(func_id), func_id);
17a52670
AS
5001 return -EINVAL;
5002 }
04fd61ab 5003
0f3adc28 5004 if (is_ptr_cast_function(func_id)) {
1b986589
MKL
5005 /* For release_reference() */
5006 regs[BPF_REG_0].ref_obj_id = meta.ref_obj_id;
64d85290 5007 } else if (is_acquire_function(func_id, meta.map_ptr)) {
0f3adc28
LB
5008 int id = acquire_reference_state(env, insn_idx);
5009
5010 if (id < 0)
5011 return id;
5012 /* For mark_ptr_or_null_reg() */
5013 regs[BPF_REG_0].id = id;
5014 /* For release_reference() */
5015 regs[BPF_REG_0].ref_obj_id = id;
5016 }
1b986589 5017
849fa506
YS
5018 do_refine_retval_range(regs, fn->ret_type, func_id, &meta);
5019
61bd5218 5020 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
35578d79
KX
5021 if (err)
5022 return err;
04fd61ab 5023
fa28dcb8
SL
5024 if ((func_id == BPF_FUNC_get_stack ||
5025 func_id == BPF_FUNC_get_task_stack) &&
5026 !env->prog->has_callchain_buf) {
c195651e
YS
5027 const char *err_str;
5028
5029#ifdef CONFIG_PERF_EVENTS
5030 err = get_callchain_buffers(sysctl_perf_event_max_stack);
5031 err_str = "cannot get callchain buffer for func %s#%d\n";
5032#else
5033 err = -ENOTSUPP;
5034 err_str = "func %s#%d not supported without CONFIG_PERF_EVENTS\n";
5035#endif
5036 if (err) {
5037 verbose(env, err_str, func_id_name(func_id), func_id);
5038 return err;
5039 }
5040
5041 env->prog->has_callchain_buf = true;
5042 }
5043
5d99cb2c
SL
5044 if (func_id == BPF_FUNC_get_stackid || func_id == BPF_FUNC_get_stack)
5045 env->prog->call_get_stack = true;
5046
969bf05e
AS
5047 if (changes_data)
5048 clear_all_pkt_pointers(env);
5049 return 0;
5050}
5051
b03c9f9f
EC
5052static bool signed_add_overflows(s64 a, s64 b)
5053{
5054 /* Do the add in u64, where overflow is well-defined */
5055 s64 res = (s64)((u64)a + (u64)b);
5056
5057 if (b < 0)
5058 return res > a;
5059 return res < a;
5060}
5061
3f50f132
JF
5062static bool signed_add32_overflows(s64 a, s64 b)
5063{
5064 /* Do the add in u32, where overflow is well-defined */
5065 s32 res = (s32)((u32)a + (u32)b);
5066
5067 if (b < 0)
5068 return res > a;
5069 return res < a;
5070}
5071
5072static bool signed_sub_overflows(s32 a, s32 b)
b03c9f9f
EC
5073{
5074 /* Do the sub in u64, where overflow is well-defined */
5075 s64 res = (s64)((u64)a - (u64)b);
5076
5077 if (b < 0)
5078 return res < a;
5079 return res > a;
969bf05e
AS
5080}
5081
3f50f132
JF
5082static bool signed_sub32_overflows(s32 a, s32 b)
5083{
5084 /* Do the sub in u64, where overflow is well-defined */
5085 s32 res = (s32)((u32)a - (u32)b);
5086
5087 if (b < 0)
5088 return res < a;
5089 return res > a;
5090}
5091
bb7f0f98
AS
5092static bool check_reg_sane_offset(struct bpf_verifier_env *env,
5093 const struct bpf_reg_state *reg,
5094 enum bpf_reg_type type)
5095{
5096 bool known = tnum_is_const(reg->var_off);
5097 s64 val = reg->var_off.value;
5098 s64 smin = reg->smin_value;
5099
5100 if (known && (val >= BPF_MAX_VAR_OFF || val <= -BPF_MAX_VAR_OFF)) {
5101 verbose(env, "math between %s pointer and %lld is not allowed\n",
5102 reg_type_str[type], val);
5103 return false;
5104 }
5105
5106 if (reg->off >= BPF_MAX_VAR_OFF || reg->off <= -BPF_MAX_VAR_OFF) {
5107 verbose(env, "%s pointer offset %d is not allowed\n",
5108 reg_type_str[type], reg->off);
5109 return false;
5110 }
5111
5112 if (smin == S64_MIN) {
5113 verbose(env, "math between %s pointer and register with unbounded min value is not allowed\n",
5114 reg_type_str[type]);
5115 return false;
5116 }
5117
5118 if (smin >= BPF_MAX_VAR_OFF || smin <= -BPF_MAX_VAR_OFF) {
5119 verbose(env, "value %lld makes %s pointer be out of bounds\n",
5120 smin, reg_type_str[type]);
5121 return false;
5122 }
5123
5124 return true;
5125}
5126
979d63d5
DB
5127static struct bpf_insn_aux_data *cur_aux(struct bpf_verifier_env *env)
5128{
5129 return &env->insn_aux_data[env->insn_idx];
5130}
5131
5132static int retrieve_ptr_limit(const struct bpf_reg_state *ptr_reg,
5133 u32 *ptr_limit, u8 opcode, bool off_is_neg)
5134{
5135 bool mask_to_left = (opcode == BPF_ADD && off_is_neg) ||
5136 (opcode == BPF_SUB && !off_is_neg);
5137 u32 off;
5138
5139 switch (ptr_reg->type) {
5140 case PTR_TO_STACK:
088ec26d
AI
5141 /* Indirect variable offset stack access is prohibited in
5142 * unprivileged mode so it's not handled here.
5143 */
979d63d5
DB
5144 off = ptr_reg->off + ptr_reg->var_off.value;
5145 if (mask_to_left)
5146 *ptr_limit = MAX_BPF_STACK + off;
5147 else
5148 *ptr_limit = -off;
5149 return 0;
5150 case PTR_TO_MAP_VALUE:
5151 if (mask_to_left) {
5152 *ptr_limit = ptr_reg->umax_value + ptr_reg->off;
5153 } else {
5154 off = ptr_reg->smin_value + ptr_reg->off;
5155 *ptr_limit = ptr_reg->map_ptr->value_size - off;
5156 }
5157 return 0;
5158 default:
5159 return -EINVAL;
5160 }
5161}
5162
d3bd7413
DB
5163static bool can_skip_alu_sanitation(const struct bpf_verifier_env *env,
5164 const struct bpf_insn *insn)
5165{
2c78ee89 5166 return env->bypass_spec_v1 || BPF_SRC(insn->code) == BPF_K;
d3bd7413
DB
5167}
5168
5169static int update_alu_sanitation_state(struct bpf_insn_aux_data *aux,
5170 u32 alu_state, u32 alu_limit)
5171{
5172 /* If we arrived here from different branches with different
5173 * state or limits to sanitize, then this won't work.
5174 */
5175 if (aux->alu_state &&
5176 (aux->alu_state != alu_state ||
5177 aux->alu_limit != alu_limit))
5178 return -EACCES;
5179
5180 /* Corresponding fixup done in fixup_bpf_calls(). */
5181 aux->alu_state = alu_state;
5182 aux->alu_limit = alu_limit;
5183 return 0;
5184}
5185
5186static int sanitize_val_alu(struct bpf_verifier_env *env,
5187 struct bpf_insn *insn)
5188{
5189 struct bpf_insn_aux_data *aux = cur_aux(env);
5190
5191 if (can_skip_alu_sanitation(env, insn))
5192 return 0;
5193
5194 return update_alu_sanitation_state(aux, BPF_ALU_NON_POINTER, 0);
5195}
5196
979d63d5
DB
5197static int sanitize_ptr_alu(struct bpf_verifier_env *env,
5198 struct bpf_insn *insn,
5199 const struct bpf_reg_state *ptr_reg,
5200 struct bpf_reg_state *dst_reg,
5201 bool off_is_neg)
5202{
5203 struct bpf_verifier_state *vstate = env->cur_state;
5204 struct bpf_insn_aux_data *aux = cur_aux(env);
5205 bool ptr_is_dst_reg = ptr_reg == dst_reg;
5206 u8 opcode = BPF_OP(insn->code);
5207 u32 alu_state, alu_limit;
5208 struct bpf_reg_state tmp;
5209 bool ret;
5210
d3bd7413 5211 if (can_skip_alu_sanitation(env, insn))
979d63d5
DB
5212 return 0;
5213
5214 /* We already marked aux for masking from non-speculative
5215 * paths, thus we got here in the first place. We only care
5216 * to explore bad access from here.
5217 */
5218 if (vstate->speculative)
5219 goto do_sim;
5220
5221 alu_state = off_is_neg ? BPF_ALU_NEG_VALUE : 0;
5222 alu_state |= ptr_is_dst_reg ?
5223 BPF_ALU_SANITIZE_SRC : BPF_ALU_SANITIZE_DST;
5224
5225 if (retrieve_ptr_limit(ptr_reg, &alu_limit, opcode, off_is_neg))
5226 return 0;
d3bd7413 5227 if (update_alu_sanitation_state(aux, alu_state, alu_limit))
979d63d5 5228 return -EACCES;
979d63d5
DB
5229do_sim:
5230 /* Simulate and find potential out-of-bounds access under
5231 * speculative execution from truncation as a result of
5232 * masking when off was not within expected range. If off
5233 * sits in dst, then we temporarily need to move ptr there
5234 * to simulate dst (== 0) +/-= ptr. Needed, for example,
5235 * for cases where we use K-based arithmetic in one direction
5236 * and truncated reg-based in the other in order to explore
5237 * bad access.
5238 */
5239 if (!ptr_is_dst_reg) {
5240 tmp = *dst_reg;
5241 *dst_reg = *ptr_reg;
5242 }
5243 ret = push_stack(env, env->insn_idx + 1, env->insn_idx, true);
0803278b 5244 if (!ptr_is_dst_reg && ret)
979d63d5
DB
5245 *dst_reg = tmp;
5246 return !ret ? -EFAULT : 0;
5247}
5248
f1174f77 5249/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
f1174f77
EC
5250 * Caller should also handle BPF_MOV case separately.
5251 * If we return -EACCES, caller may want to try again treating pointer as a
5252 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
5253 */
5254static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
5255 struct bpf_insn *insn,
5256 const struct bpf_reg_state *ptr_reg,
5257 const struct bpf_reg_state *off_reg)
969bf05e 5258{
f4d7e40a
AS
5259 struct bpf_verifier_state *vstate = env->cur_state;
5260 struct bpf_func_state *state = vstate->frame[vstate->curframe];
5261 struct bpf_reg_state *regs = state->regs, *dst_reg;
f1174f77 5262 bool known = tnum_is_const(off_reg->var_off);
b03c9f9f
EC
5263 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
5264 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
5265 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
5266 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
9d7eceed 5267 u32 dst = insn->dst_reg, src = insn->src_reg;
969bf05e 5268 u8 opcode = BPF_OP(insn->code);
979d63d5 5269 int ret;
969bf05e 5270
f1174f77 5271 dst_reg = &regs[dst];
969bf05e 5272
6f16101e
DB
5273 if ((known && (smin_val != smax_val || umin_val != umax_val)) ||
5274 smin_val > smax_val || umin_val > umax_val) {
5275 /* Taint dst register if offset had invalid bounds derived from
5276 * e.g. dead branches.
5277 */
f54c7898 5278 __mark_reg_unknown(env, dst_reg);
6f16101e 5279 return 0;
f1174f77
EC
5280 }
5281
5282 if (BPF_CLASS(insn->code) != BPF_ALU64) {
5283 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
6c693541
YS
5284 if (opcode == BPF_SUB && env->allow_ptr_leaks) {
5285 __mark_reg_unknown(env, dst_reg);
5286 return 0;
5287 }
5288
82abbf8d
AS
5289 verbose(env,
5290 "R%d 32-bit pointer arithmetic prohibited\n",
5291 dst);
f1174f77 5292 return -EACCES;
969bf05e
AS
5293 }
5294
aad2eeaf
JS
5295 switch (ptr_reg->type) {
5296 case PTR_TO_MAP_VALUE_OR_NULL:
5297 verbose(env, "R%d pointer arithmetic on %s prohibited, null-check it first\n",
5298 dst, reg_type_str[ptr_reg->type]);
f1174f77 5299 return -EACCES;
aad2eeaf
JS
5300 case CONST_PTR_TO_MAP:
5301 case PTR_TO_PACKET_END:
c64b7983
JS
5302 case PTR_TO_SOCKET:
5303 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
5304 case PTR_TO_SOCK_COMMON:
5305 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
5306 case PTR_TO_TCP_SOCK:
5307 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 5308 case PTR_TO_XDP_SOCK:
aad2eeaf
JS
5309 verbose(env, "R%d pointer arithmetic on %s prohibited\n",
5310 dst, reg_type_str[ptr_reg->type]);
f1174f77 5311 return -EACCES;
9d7eceed
DB
5312 case PTR_TO_MAP_VALUE:
5313 if (!env->allow_ptr_leaks && !known && (smin_val < 0) != (smax_val < 0)) {
5314 verbose(env, "R%d has unknown scalar with mixed signed bounds, pointer arithmetic with it prohibited for !root\n",
5315 off_reg == dst_reg ? dst : src);
5316 return -EACCES;
5317 }
5318 /* fall-through */
aad2eeaf
JS
5319 default:
5320 break;
f1174f77
EC
5321 }
5322
5323 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
5324 * The id may be overwritten later if we create a new variable offset.
969bf05e 5325 */
f1174f77
EC
5326 dst_reg->type = ptr_reg->type;
5327 dst_reg->id = ptr_reg->id;
969bf05e 5328
bb7f0f98
AS
5329 if (!check_reg_sane_offset(env, off_reg, ptr_reg->type) ||
5330 !check_reg_sane_offset(env, ptr_reg, ptr_reg->type))
5331 return -EINVAL;
5332
3f50f132
JF
5333 /* pointer types do not carry 32-bit bounds at the moment. */
5334 __mark_reg32_unbounded(dst_reg);
5335
f1174f77
EC
5336 switch (opcode) {
5337 case BPF_ADD:
979d63d5
DB
5338 ret = sanitize_ptr_alu(env, insn, ptr_reg, dst_reg, smin_val < 0);
5339 if (ret < 0) {
5340 verbose(env, "R%d tried to add from different maps or paths\n", dst);
5341 return ret;
5342 }
f1174f77
EC
5343 /* We can take a fixed offset as long as it doesn't overflow
5344 * the s32 'off' field
969bf05e 5345 */
b03c9f9f
EC
5346 if (known && (ptr_reg->off + smin_val ==
5347 (s64)(s32)(ptr_reg->off + smin_val))) {
f1174f77 5348 /* pointer += K. Accumulate it into fixed offset */
b03c9f9f
EC
5349 dst_reg->smin_value = smin_ptr;
5350 dst_reg->smax_value = smax_ptr;
5351 dst_reg->umin_value = umin_ptr;
5352 dst_reg->umax_value = umax_ptr;
f1174f77 5353 dst_reg->var_off = ptr_reg->var_off;
b03c9f9f 5354 dst_reg->off = ptr_reg->off + smin_val;
0962590e 5355 dst_reg->raw = ptr_reg->raw;
f1174f77
EC
5356 break;
5357 }
f1174f77
EC
5358 /* A new variable offset is created. Note that off_reg->off
5359 * == 0, since it's a scalar.
5360 * dst_reg gets the pointer type and since some positive
5361 * integer value was added to the pointer, give it a new 'id'
5362 * if it's a PTR_TO_PACKET.
5363 * this creates a new 'base' pointer, off_reg (variable) gets
5364 * added into the variable offset, and we copy the fixed offset
5365 * from ptr_reg.
969bf05e 5366 */
b03c9f9f
EC
5367 if (signed_add_overflows(smin_ptr, smin_val) ||
5368 signed_add_overflows(smax_ptr, smax_val)) {
5369 dst_reg->smin_value = S64_MIN;
5370 dst_reg->smax_value = S64_MAX;
5371 } else {
5372 dst_reg->smin_value = smin_ptr + smin_val;
5373 dst_reg->smax_value = smax_ptr + smax_val;
5374 }
5375 if (umin_ptr + umin_val < umin_ptr ||
5376 umax_ptr + umax_val < umax_ptr) {
5377 dst_reg->umin_value = 0;
5378 dst_reg->umax_value = U64_MAX;
5379 } else {
5380 dst_reg->umin_value = umin_ptr + umin_val;
5381 dst_reg->umax_value = umax_ptr + umax_val;
5382 }
f1174f77
EC
5383 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
5384 dst_reg->off = ptr_reg->off;
0962590e 5385 dst_reg->raw = ptr_reg->raw;
de8f3a83 5386 if (reg_is_pkt_pointer(ptr_reg)) {
f1174f77
EC
5387 dst_reg->id = ++env->id_gen;
5388 /* something was added to pkt_ptr, set range to zero */
0962590e 5389 dst_reg->raw = 0;
f1174f77
EC
5390 }
5391 break;
5392 case BPF_SUB:
979d63d5
DB
5393 ret = sanitize_ptr_alu(env, insn, ptr_reg, dst_reg, smin_val < 0);
5394 if (ret < 0) {
5395 verbose(env, "R%d tried to sub from different maps or paths\n", dst);
5396 return ret;
5397 }
f1174f77
EC
5398 if (dst_reg == off_reg) {
5399 /* scalar -= pointer. Creates an unknown scalar */
82abbf8d
AS
5400 verbose(env, "R%d tried to subtract pointer from scalar\n",
5401 dst);
f1174f77
EC
5402 return -EACCES;
5403 }
5404 /* We don't allow subtraction from FP, because (according to
5405 * test_verifier.c test "invalid fp arithmetic", JITs might not
5406 * be able to deal with it.
969bf05e 5407 */
f1174f77 5408 if (ptr_reg->type == PTR_TO_STACK) {
82abbf8d
AS
5409 verbose(env, "R%d subtraction from stack pointer prohibited\n",
5410 dst);
f1174f77
EC
5411 return -EACCES;
5412 }
b03c9f9f
EC
5413 if (known && (ptr_reg->off - smin_val ==
5414 (s64)(s32)(ptr_reg->off - smin_val))) {
f1174f77 5415 /* pointer -= K. Subtract it from fixed offset */
b03c9f9f
EC
5416 dst_reg->smin_value = smin_ptr;
5417 dst_reg->smax_value = smax_ptr;
5418 dst_reg->umin_value = umin_ptr;
5419 dst_reg->umax_value = umax_ptr;
f1174f77
EC
5420 dst_reg->var_off = ptr_reg->var_off;
5421 dst_reg->id = ptr_reg->id;
b03c9f9f 5422 dst_reg->off = ptr_reg->off - smin_val;
0962590e 5423 dst_reg->raw = ptr_reg->raw;
f1174f77
EC
5424 break;
5425 }
f1174f77
EC
5426 /* A new variable offset is created. If the subtrahend is known
5427 * nonnegative, then any reg->range we had before is still good.
969bf05e 5428 */
b03c9f9f
EC
5429 if (signed_sub_overflows(smin_ptr, smax_val) ||
5430 signed_sub_overflows(smax_ptr, smin_val)) {
5431 /* Overflow possible, we know nothing */
5432 dst_reg->smin_value = S64_MIN;
5433 dst_reg->smax_value = S64_MAX;
5434 } else {
5435 dst_reg->smin_value = smin_ptr - smax_val;
5436 dst_reg->smax_value = smax_ptr - smin_val;
5437 }
5438 if (umin_ptr < umax_val) {
5439 /* Overflow possible, we know nothing */
5440 dst_reg->umin_value = 0;
5441 dst_reg->umax_value = U64_MAX;
5442 } else {
5443 /* Cannot overflow (as long as bounds are consistent) */
5444 dst_reg->umin_value = umin_ptr - umax_val;
5445 dst_reg->umax_value = umax_ptr - umin_val;
5446 }
f1174f77
EC
5447 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
5448 dst_reg->off = ptr_reg->off;
0962590e 5449 dst_reg->raw = ptr_reg->raw;
de8f3a83 5450 if (reg_is_pkt_pointer(ptr_reg)) {
f1174f77
EC
5451 dst_reg->id = ++env->id_gen;
5452 /* something was added to pkt_ptr, set range to zero */
b03c9f9f 5453 if (smin_val < 0)
0962590e 5454 dst_reg->raw = 0;
43188702 5455 }
f1174f77
EC
5456 break;
5457 case BPF_AND:
5458 case BPF_OR:
5459 case BPF_XOR:
82abbf8d
AS
5460 /* bitwise ops on pointers are troublesome, prohibit. */
5461 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
5462 dst, bpf_alu_string[opcode >> 4]);
f1174f77
EC
5463 return -EACCES;
5464 default:
5465 /* other operators (e.g. MUL,LSH) produce non-pointer results */
82abbf8d
AS
5466 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
5467 dst, bpf_alu_string[opcode >> 4]);
f1174f77 5468 return -EACCES;
43188702
JF
5469 }
5470
bb7f0f98
AS
5471 if (!check_reg_sane_offset(env, dst_reg, ptr_reg->type))
5472 return -EINVAL;
5473
b03c9f9f
EC
5474 __update_reg_bounds(dst_reg);
5475 __reg_deduce_bounds(dst_reg);
5476 __reg_bound_offset(dst_reg);
0d6303db
DB
5477
5478 /* For unprivileged we require that resulting offset must be in bounds
5479 * in order to be able to sanitize access later on.
5480 */
2c78ee89 5481 if (!env->bypass_spec_v1) {
e4298d25
DB
5482 if (dst_reg->type == PTR_TO_MAP_VALUE &&
5483 check_map_access(env, dst, dst_reg->off, 1, false)) {
5484 verbose(env, "R%d pointer arithmetic of map value goes out of range, "
5485 "prohibited for !root\n", dst);
5486 return -EACCES;
5487 } else if (dst_reg->type == PTR_TO_STACK &&
5488 check_stack_access(env, dst_reg, dst_reg->off +
5489 dst_reg->var_off.value, 1)) {
5490 verbose(env, "R%d stack pointer arithmetic goes out of range, "
5491 "prohibited for !root\n", dst);
5492 return -EACCES;
5493 }
0d6303db
DB
5494 }
5495
43188702
JF
5496 return 0;
5497}
5498
3f50f132
JF
5499static void scalar32_min_max_add(struct bpf_reg_state *dst_reg,
5500 struct bpf_reg_state *src_reg)
5501{
5502 s32 smin_val = src_reg->s32_min_value;
5503 s32 smax_val = src_reg->s32_max_value;
5504 u32 umin_val = src_reg->u32_min_value;
5505 u32 umax_val = src_reg->u32_max_value;
5506
5507 if (signed_add32_overflows(dst_reg->s32_min_value, smin_val) ||
5508 signed_add32_overflows(dst_reg->s32_max_value, smax_val)) {
5509 dst_reg->s32_min_value = S32_MIN;
5510 dst_reg->s32_max_value = S32_MAX;
5511 } else {
5512 dst_reg->s32_min_value += smin_val;
5513 dst_reg->s32_max_value += smax_val;
5514 }
5515 if (dst_reg->u32_min_value + umin_val < umin_val ||
5516 dst_reg->u32_max_value + umax_val < umax_val) {
5517 dst_reg->u32_min_value = 0;
5518 dst_reg->u32_max_value = U32_MAX;
5519 } else {
5520 dst_reg->u32_min_value += umin_val;
5521 dst_reg->u32_max_value += umax_val;
5522 }
5523}
5524
07cd2631
JF
5525static void scalar_min_max_add(struct bpf_reg_state *dst_reg,
5526 struct bpf_reg_state *src_reg)
5527{
5528 s64 smin_val = src_reg->smin_value;
5529 s64 smax_val = src_reg->smax_value;
5530 u64 umin_val = src_reg->umin_value;
5531 u64 umax_val = src_reg->umax_value;
5532
5533 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
5534 signed_add_overflows(dst_reg->smax_value, smax_val)) {
5535 dst_reg->smin_value = S64_MIN;
5536 dst_reg->smax_value = S64_MAX;
5537 } else {
5538 dst_reg->smin_value += smin_val;
5539 dst_reg->smax_value += smax_val;
5540 }
5541 if (dst_reg->umin_value + umin_val < umin_val ||
5542 dst_reg->umax_value + umax_val < umax_val) {
5543 dst_reg->umin_value = 0;
5544 dst_reg->umax_value = U64_MAX;
5545 } else {
5546 dst_reg->umin_value += umin_val;
5547 dst_reg->umax_value += umax_val;
5548 }
3f50f132
JF
5549}
5550
5551static void scalar32_min_max_sub(struct bpf_reg_state *dst_reg,
5552 struct bpf_reg_state *src_reg)
5553{
5554 s32 smin_val = src_reg->s32_min_value;
5555 s32 smax_val = src_reg->s32_max_value;
5556 u32 umin_val = src_reg->u32_min_value;
5557 u32 umax_val = src_reg->u32_max_value;
5558
5559 if (signed_sub32_overflows(dst_reg->s32_min_value, smax_val) ||
5560 signed_sub32_overflows(dst_reg->s32_max_value, smin_val)) {
5561 /* Overflow possible, we know nothing */
5562 dst_reg->s32_min_value = S32_MIN;
5563 dst_reg->s32_max_value = S32_MAX;
5564 } else {
5565 dst_reg->s32_min_value -= smax_val;
5566 dst_reg->s32_max_value -= smin_val;
5567 }
5568 if (dst_reg->u32_min_value < umax_val) {
5569 /* Overflow possible, we know nothing */
5570 dst_reg->u32_min_value = 0;
5571 dst_reg->u32_max_value = U32_MAX;
5572 } else {
5573 /* Cannot overflow (as long as bounds are consistent) */
5574 dst_reg->u32_min_value -= umax_val;
5575 dst_reg->u32_max_value -= umin_val;
5576 }
07cd2631
JF
5577}
5578
5579static void scalar_min_max_sub(struct bpf_reg_state *dst_reg,
5580 struct bpf_reg_state *src_reg)
5581{
5582 s64 smin_val = src_reg->smin_value;
5583 s64 smax_val = src_reg->smax_value;
5584 u64 umin_val = src_reg->umin_value;
5585 u64 umax_val = src_reg->umax_value;
5586
5587 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
5588 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
5589 /* Overflow possible, we know nothing */
5590 dst_reg->smin_value = S64_MIN;
5591 dst_reg->smax_value = S64_MAX;
5592 } else {
5593 dst_reg->smin_value -= smax_val;
5594 dst_reg->smax_value -= smin_val;
5595 }
5596 if (dst_reg->umin_value < umax_val) {
5597 /* Overflow possible, we know nothing */
5598 dst_reg->umin_value = 0;
5599 dst_reg->umax_value = U64_MAX;
5600 } else {
5601 /* Cannot overflow (as long as bounds are consistent) */
5602 dst_reg->umin_value -= umax_val;
5603 dst_reg->umax_value -= umin_val;
5604 }
3f50f132
JF
5605}
5606
5607static void scalar32_min_max_mul(struct bpf_reg_state *dst_reg,
5608 struct bpf_reg_state *src_reg)
5609{
5610 s32 smin_val = src_reg->s32_min_value;
5611 u32 umin_val = src_reg->u32_min_value;
5612 u32 umax_val = src_reg->u32_max_value;
5613
5614 if (smin_val < 0 || dst_reg->s32_min_value < 0) {
5615 /* Ain't nobody got time to multiply that sign */
5616 __mark_reg32_unbounded(dst_reg);
5617 return;
5618 }
5619 /* Both values are positive, so we can work with unsigned and
5620 * copy the result to signed (unless it exceeds S32_MAX).
5621 */
5622 if (umax_val > U16_MAX || dst_reg->u32_max_value > U16_MAX) {
5623 /* Potential overflow, we know nothing */
5624 __mark_reg32_unbounded(dst_reg);
5625 return;
5626 }
5627 dst_reg->u32_min_value *= umin_val;
5628 dst_reg->u32_max_value *= umax_val;
5629 if (dst_reg->u32_max_value > S32_MAX) {
5630 /* Overflow possible, we know nothing */
5631 dst_reg->s32_min_value = S32_MIN;
5632 dst_reg->s32_max_value = S32_MAX;
5633 } else {
5634 dst_reg->s32_min_value = dst_reg->u32_min_value;
5635 dst_reg->s32_max_value = dst_reg->u32_max_value;
5636 }
07cd2631
JF
5637}
5638
5639static void scalar_min_max_mul(struct bpf_reg_state *dst_reg,
5640 struct bpf_reg_state *src_reg)
5641{
5642 s64 smin_val = src_reg->smin_value;
5643 u64 umin_val = src_reg->umin_value;
5644 u64 umax_val = src_reg->umax_value;
5645
07cd2631
JF
5646 if (smin_val < 0 || dst_reg->smin_value < 0) {
5647 /* Ain't nobody got time to multiply that sign */
3f50f132 5648 __mark_reg64_unbounded(dst_reg);
07cd2631
JF
5649 return;
5650 }
5651 /* Both values are positive, so we can work with unsigned and
5652 * copy the result to signed (unless it exceeds S64_MAX).
5653 */
5654 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
5655 /* Potential overflow, we know nothing */
3f50f132 5656 __mark_reg64_unbounded(dst_reg);
07cd2631
JF
5657 return;
5658 }
5659 dst_reg->umin_value *= umin_val;
5660 dst_reg->umax_value *= umax_val;
5661 if (dst_reg->umax_value > S64_MAX) {
5662 /* Overflow possible, we know nothing */
5663 dst_reg->smin_value = S64_MIN;
5664 dst_reg->smax_value = S64_MAX;
5665 } else {
5666 dst_reg->smin_value = dst_reg->umin_value;
5667 dst_reg->smax_value = dst_reg->umax_value;
5668 }
5669}
5670
3f50f132
JF
5671static void scalar32_min_max_and(struct bpf_reg_state *dst_reg,
5672 struct bpf_reg_state *src_reg)
5673{
5674 bool src_known = tnum_subreg_is_const(src_reg->var_off);
5675 bool dst_known = tnum_subreg_is_const(dst_reg->var_off);
5676 struct tnum var32_off = tnum_subreg(dst_reg->var_off);
5677 s32 smin_val = src_reg->s32_min_value;
5678 u32 umax_val = src_reg->u32_max_value;
5679
5680 /* Assuming scalar64_min_max_and will be called so its safe
5681 * to skip updating register for known 32-bit case.
5682 */
5683 if (src_known && dst_known)
5684 return;
5685
5686 /* We get our minimum from the var_off, since that's inherently
5687 * bitwise. Our maximum is the minimum of the operands' maxima.
5688 */
5689 dst_reg->u32_min_value = var32_off.value;
5690 dst_reg->u32_max_value = min(dst_reg->u32_max_value, umax_val);
5691 if (dst_reg->s32_min_value < 0 || smin_val < 0) {
5692 /* Lose signed bounds when ANDing negative numbers,
5693 * ain't nobody got time for that.
5694 */
5695 dst_reg->s32_min_value = S32_MIN;
5696 dst_reg->s32_max_value = S32_MAX;
5697 } else {
5698 /* ANDing two positives gives a positive, so safe to
5699 * cast result into s64.
5700 */
5701 dst_reg->s32_min_value = dst_reg->u32_min_value;
5702 dst_reg->s32_max_value = dst_reg->u32_max_value;
5703 }
5704
5705}
5706
07cd2631
JF
5707static void scalar_min_max_and(struct bpf_reg_state *dst_reg,
5708 struct bpf_reg_state *src_reg)
5709{
3f50f132
JF
5710 bool src_known = tnum_is_const(src_reg->var_off);
5711 bool dst_known = tnum_is_const(dst_reg->var_off);
07cd2631
JF
5712 s64 smin_val = src_reg->smin_value;
5713 u64 umax_val = src_reg->umax_value;
5714
3f50f132
JF
5715 if (src_known && dst_known) {
5716 __mark_reg_known(dst_reg, dst_reg->var_off.value &
5717 src_reg->var_off.value);
5718 return;
5719 }
5720
07cd2631
JF
5721 /* We get our minimum from the var_off, since that's inherently
5722 * bitwise. Our maximum is the minimum of the operands' maxima.
5723 */
07cd2631
JF
5724 dst_reg->umin_value = dst_reg->var_off.value;
5725 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
5726 if (dst_reg->smin_value < 0 || smin_val < 0) {
5727 /* Lose signed bounds when ANDing negative numbers,
5728 * ain't nobody got time for that.
5729 */
5730 dst_reg->smin_value = S64_MIN;
5731 dst_reg->smax_value = S64_MAX;
5732 } else {
5733 /* ANDing two positives gives a positive, so safe to
5734 * cast result into s64.
5735 */
5736 dst_reg->smin_value = dst_reg->umin_value;
5737 dst_reg->smax_value = dst_reg->umax_value;
5738 }
5739 /* We may learn something more from the var_off */
5740 __update_reg_bounds(dst_reg);
5741}
5742
3f50f132
JF
5743static void scalar32_min_max_or(struct bpf_reg_state *dst_reg,
5744 struct bpf_reg_state *src_reg)
5745{
5746 bool src_known = tnum_subreg_is_const(src_reg->var_off);
5747 bool dst_known = tnum_subreg_is_const(dst_reg->var_off);
5748 struct tnum var32_off = tnum_subreg(dst_reg->var_off);
5749 s32 smin_val = src_reg->smin_value;
5750 u32 umin_val = src_reg->umin_value;
5751
5752 /* Assuming scalar64_min_max_or will be called so it is safe
5753 * to skip updating register for known case.
5754 */
5755 if (src_known && dst_known)
5756 return;
5757
5758 /* We get our maximum from the var_off, and our minimum is the
5759 * maximum of the operands' minima
5760 */
5761 dst_reg->u32_min_value = max(dst_reg->u32_min_value, umin_val);
5762 dst_reg->u32_max_value = var32_off.value | var32_off.mask;
5763 if (dst_reg->s32_min_value < 0 || smin_val < 0) {
5764 /* Lose signed bounds when ORing negative numbers,
5765 * ain't nobody got time for that.
5766 */
5767 dst_reg->s32_min_value = S32_MIN;
5768 dst_reg->s32_max_value = S32_MAX;
5769 } else {
5770 /* ORing two positives gives a positive, so safe to
5771 * cast result into s64.
5772 */
5773 dst_reg->s32_min_value = dst_reg->umin_value;
5774 dst_reg->s32_max_value = dst_reg->umax_value;
5775 }
5776}
5777
07cd2631
JF
5778static void scalar_min_max_or(struct bpf_reg_state *dst_reg,
5779 struct bpf_reg_state *src_reg)
5780{
3f50f132
JF
5781 bool src_known = tnum_is_const(src_reg->var_off);
5782 bool dst_known = tnum_is_const(dst_reg->var_off);
07cd2631
JF
5783 s64 smin_val = src_reg->smin_value;
5784 u64 umin_val = src_reg->umin_value;
5785
3f50f132
JF
5786 if (src_known && dst_known) {
5787 __mark_reg_known(dst_reg, dst_reg->var_off.value |
5788 src_reg->var_off.value);
5789 return;
5790 }
5791
07cd2631
JF
5792 /* We get our maximum from the var_off, and our minimum is the
5793 * maximum of the operands' minima
5794 */
07cd2631
JF
5795 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
5796 dst_reg->umax_value = dst_reg->var_off.value | dst_reg->var_off.mask;
5797 if (dst_reg->smin_value < 0 || smin_val < 0) {
5798 /* Lose signed bounds when ORing negative numbers,
5799 * ain't nobody got time for that.
5800 */
5801 dst_reg->smin_value = S64_MIN;
5802 dst_reg->smax_value = S64_MAX;
5803 } else {
5804 /* ORing two positives gives a positive, so safe to
5805 * cast result into s64.
5806 */
5807 dst_reg->smin_value = dst_reg->umin_value;
5808 dst_reg->smax_value = dst_reg->umax_value;
5809 }
5810 /* We may learn something more from the var_off */
5811 __update_reg_bounds(dst_reg);
5812}
5813
3f50f132
JF
5814static void __scalar32_min_max_lsh(struct bpf_reg_state *dst_reg,
5815 u64 umin_val, u64 umax_val)
07cd2631 5816{
07cd2631
JF
5817 /* We lose all sign bit information (except what we can pick
5818 * up from var_off)
5819 */
3f50f132
JF
5820 dst_reg->s32_min_value = S32_MIN;
5821 dst_reg->s32_max_value = S32_MAX;
5822 /* If we might shift our top bit out, then we know nothing */
5823 if (umax_val > 31 || dst_reg->u32_max_value > 1ULL << (31 - umax_val)) {
5824 dst_reg->u32_min_value = 0;
5825 dst_reg->u32_max_value = U32_MAX;
5826 } else {
5827 dst_reg->u32_min_value <<= umin_val;
5828 dst_reg->u32_max_value <<= umax_val;
5829 }
5830}
5831
5832static void scalar32_min_max_lsh(struct bpf_reg_state *dst_reg,
5833 struct bpf_reg_state *src_reg)
5834{
5835 u32 umax_val = src_reg->u32_max_value;
5836 u32 umin_val = src_reg->u32_min_value;
5837 /* u32 alu operation will zext upper bits */
5838 struct tnum subreg = tnum_subreg(dst_reg->var_off);
5839
5840 __scalar32_min_max_lsh(dst_reg, umin_val, umax_val);
5841 dst_reg->var_off = tnum_subreg(tnum_lshift(subreg, umin_val));
5842 /* Not required but being careful mark reg64 bounds as unknown so
5843 * that we are forced to pick them up from tnum and zext later and
5844 * if some path skips this step we are still safe.
5845 */
5846 __mark_reg64_unbounded(dst_reg);
5847 __update_reg32_bounds(dst_reg);
5848}
5849
5850static void __scalar64_min_max_lsh(struct bpf_reg_state *dst_reg,
5851 u64 umin_val, u64 umax_val)
5852{
5853 /* Special case <<32 because it is a common compiler pattern to sign
5854 * extend subreg by doing <<32 s>>32. In this case if 32bit bounds are
5855 * positive we know this shift will also be positive so we can track
5856 * bounds correctly. Otherwise we lose all sign bit information except
5857 * what we can pick up from var_off. Perhaps we can generalize this
5858 * later to shifts of any length.
5859 */
5860 if (umin_val == 32 && umax_val == 32 && dst_reg->s32_max_value >= 0)
5861 dst_reg->smax_value = (s64)dst_reg->s32_max_value << 32;
5862 else
5863 dst_reg->smax_value = S64_MAX;
5864
5865 if (umin_val == 32 && umax_val == 32 && dst_reg->s32_min_value >= 0)
5866 dst_reg->smin_value = (s64)dst_reg->s32_min_value << 32;
5867 else
5868 dst_reg->smin_value = S64_MIN;
5869
07cd2631
JF
5870 /* If we might shift our top bit out, then we know nothing */
5871 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
5872 dst_reg->umin_value = 0;
5873 dst_reg->umax_value = U64_MAX;
5874 } else {
5875 dst_reg->umin_value <<= umin_val;
5876 dst_reg->umax_value <<= umax_val;
5877 }
3f50f132
JF
5878}
5879
5880static void scalar_min_max_lsh(struct bpf_reg_state *dst_reg,
5881 struct bpf_reg_state *src_reg)
5882{
5883 u64 umax_val = src_reg->umax_value;
5884 u64 umin_val = src_reg->umin_value;
5885
5886 /* scalar64 calc uses 32bit unshifted bounds so must be called first */
5887 __scalar64_min_max_lsh(dst_reg, umin_val, umax_val);
5888 __scalar32_min_max_lsh(dst_reg, umin_val, umax_val);
5889
07cd2631
JF
5890 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
5891 /* We may learn something more from the var_off */
5892 __update_reg_bounds(dst_reg);
5893}
5894
3f50f132
JF
5895static void scalar32_min_max_rsh(struct bpf_reg_state *dst_reg,
5896 struct bpf_reg_state *src_reg)
5897{
5898 struct tnum subreg = tnum_subreg(dst_reg->var_off);
5899 u32 umax_val = src_reg->u32_max_value;
5900 u32 umin_val = src_reg->u32_min_value;
5901
5902 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
5903 * be negative, then either:
5904 * 1) src_reg might be zero, so the sign bit of the result is
5905 * unknown, so we lose our signed bounds
5906 * 2) it's known negative, thus the unsigned bounds capture the
5907 * signed bounds
5908 * 3) the signed bounds cross zero, so they tell us nothing
5909 * about the result
5910 * If the value in dst_reg is known nonnegative, then again the
5911 * unsigned bounts capture the signed bounds.
5912 * Thus, in all cases it suffices to blow away our signed bounds
5913 * and rely on inferring new ones from the unsigned bounds and
5914 * var_off of the result.
5915 */
5916 dst_reg->s32_min_value = S32_MIN;
5917 dst_reg->s32_max_value = S32_MAX;
5918
5919 dst_reg->var_off = tnum_rshift(subreg, umin_val);
5920 dst_reg->u32_min_value >>= umax_val;
5921 dst_reg->u32_max_value >>= umin_val;
5922
5923 __mark_reg64_unbounded(dst_reg);
5924 __update_reg32_bounds(dst_reg);
5925}
5926
07cd2631
JF
5927static void scalar_min_max_rsh(struct bpf_reg_state *dst_reg,
5928 struct bpf_reg_state *src_reg)
5929{
5930 u64 umax_val = src_reg->umax_value;
5931 u64 umin_val = src_reg->umin_value;
5932
5933 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
5934 * be negative, then either:
5935 * 1) src_reg might be zero, so the sign bit of the result is
5936 * unknown, so we lose our signed bounds
5937 * 2) it's known negative, thus the unsigned bounds capture the
5938 * signed bounds
5939 * 3) the signed bounds cross zero, so they tell us nothing
5940 * about the result
5941 * If the value in dst_reg is known nonnegative, then again the
5942 * unsigned bounts capture the signed bounds.
5943 * Thus, in all cases it suffices to blow away our signed bounds
5944 * and rely on inferring new ones from the unsigned bounds and
5945 * var_off of the result.
5946 */
5947 dst_reg->smin_value = S64_MIN;
5948 dst_reg->smax_value = S64_MAX;
5949 dst_reg->var_off = tnum_rshift(dst_reg->var_off, umin_val);
5950 dst_reg->umin_value >>= umax_val;
5951 dst_reg->umax_value >>= umin_val;
3f50f132
JF
5952
5953 /* Its not easy to operate on alu32 bounds here because it depends
5954 * on bits being shifted in. Take easy way out and mark unbounded
5955 * so we can recalculate later from tnum.
5956 */
5957 __mark_reg32_unbounded(dst_reg);
07cd2631
JF
5958 __update_reg_bounds(dst_reg);
5959}
5960
3f50f132
JF
5961static void scalar32_min_max_arsh(struct bpf_reg_state *dst_reg,
5962 struct bpf_reg_state *src_reg)
07cd2631 5963{
3f50f132 5964 u64 umin_val = src_reg->u32_min_value;
07cd2631
JF
5965
5966 /* Upon reaching here, src_known is true and
5967 * umax_val is equal to umin_val.
5968 */
3f50f132
JF
5969 dst_reg->s32_min_value = (u32)(((s32)dst_reg->s32_min_value) >> umin_val);
5970 dst_reg->s32_max_value = (u32)(((s32)dst_reg->s32_max_value) >> umin_val);
07cd2631 5971
3f50f132
JF
5972 dst_reg->var_off = tnum_arshift(tnum_subreg(dst_reg->var_off), umin_val, 32);
5973
5974 /* blow away the dst_reg umin_value/umax_value and rely on
5975 * dst_reg var_off to refine the result.
5976 */
5977 dst_reg->u32_min_value = 0;
5978 dst_reg->u32_max_value = U32_MAX;
5979
5980 __mark_reg64_unbounded(dst_reg);
5981 __update_reg32_bounds(dst_reg);
5982}
5983
5984static void scalar_min_max_arsh(struct bpf_reg_state *dst_reg,
5985 struct bpf_reg_state *src_reg)
5986{
5987 u64 umin_val = src_reg->umin_value;
5988
5989 /* Upon reaching here, src_known is true and umax_val is equal
5990 * to umin_val.
5991 */
5992 dst_reg->smin_value >>= umin_val;
5993 dst_reg->smax_value >>= umin_val;
5994
5995 dst_reg->var_off = tnum_arshift(dst_reg->var_off, umin_val, 64);
07cd2631
JF
5996
5997 /* blow away the dst_reg umin_value/umax_value and rely on
5998 * dst_reg var_off to refine the result.
5999 */
6000 dst_reg->umin_value = 0;
6001 dst_reg->umax_value = U64_MAX;
3f50f132
JF
6002
6003 /* Its not easy to operate on alu32 bounds here because it depends
6004 * on bits being shifted in from upper 32-bits. Take easy way out
6005 * and mark unbounded so we can recalculate later from tnum.
6006 */
6007 __mark_reg32_unbounded(dst_reg);
07cd2631
JF
6008 __update_reg_bounds(dst_reg);
6009}
6010
468f6eaf
JH
6011/* WARNING: This function does calculations on 64-bit values, but the actual
6012 * execution may occur on 32-bit values. Therefore, things like bitshifts
6013 * need extra checks in the 32-bit case.
6014 */
f1174f77
EC
6015static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
6016 struct bpf_insn *insn,
6017 struct bpf_reg_state *dst_reg,
6018 struct bpf_reg_state src_reg)
969bf05e 6019{
638f5b90 6020 struct bpf_reg_state *regs = cur_regs(env);
48461135 6021 u8 opcode = BPF_OP(insn->code);
b0b3fb67 6022 bool src_known;
b03c9f9f
EC
6023 s64 smin_val, smax_val;
6024 u64 umin_val, umax_val;
3f50f132
JF
6025 s32 s32_min_val, s32_max_val;
6026 u32 u32_min_val, u32_max_val;
468f6eaf 6027 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
d3bd7413
DB
6028 u32 dst = insn->dst_reg;
6029 int ret;
3f50f132 6030 bool alu32 = (BPF_CLASS(insn->code) != BPF_ALU64);
b799207e 6031
b03c9f9f
EC
6032 smin_val = src_reg.smin_value;
6033 smax_val = src_reg.smax_value;
6034 umin_val = src_reg.umin_value;
6035 umax_val = src_reg.umax_value;
f23cc643 6036
3f50f132
JF
6037 s32_min_val = src_reg.s32_min_value;
6038 s32_max_val = src_reg.s32_max_value;
6039 u32_min_val = src_reg.u32_min_value;
6040 u32_max_val = src_reg.u32_max_value;
6041
6042 if (alu32) {
6043 src_known = tnum_subreg_is_const(src_reg.var_off);
3f50f132
JF
6044 if ((src_known &&
6045 (s32_min_val != s32_max_val || u32_min_val != u32_max_val)) ||
6046 s32_min_val > s32_max_val || u32_min_val > u32_max_val) {
6047 /* Taint dst register if offset had invalid bounds
6048 * derived from e.g. dead branches.
6049 */
6050 __mark_reg_unknown(env, dst_reg);
6051 return 0;
6052 }
6053 } else {
6054 src_known = tnum_is_const(src_reg.var_off);
3f50f132
JF
6055 if ((src_known &&
6056 (smin_val != smax_val || umin_val != umax_val)) ||
6057 smin_val > smax_val || umin_val > umax_val) {
6058 /* Taint dst register if offset had invalid bounds
6059 * derived from e.g. dead branches.
6060 */
6061 __mark_reg_unknown(env, dst_reg);
6062 return 0;
6063 }
6f16101e
DB
6064 }
6065
bb7f0f98
AS
6066 if (!src_known &&
6067 opcode != BPF_ADD && opcode != BPF_SUB && opcode != BPF_AND) {
f54c7898 6068 __mark_reg_unknown(env, dst_reg);
bb7f0f98
AS
6069 return 0;
6070 }
6071
3f50f132
JF
6072 /* Calculate sign/unsigned bounds and tnum for alu32 and alu64 bit ops.
6073 * There are two classes of instructions: The first class we track both
6074 * alu32 and alu64 sign/unsigned bounds independently this provides the
6075 * greatest amount of precision when alu operations are mixed with jmp32
6076 * operations. These operations are BPF_ADD, BPF_SUB, BPF_MUL, BPF_ADD,
6077 * and BPF_OR. This is possible because these ops have fairly easy to
6078 * understand and calculate behavior in both 32-bit and 64-bit alu ops.
6079 * See alu32 verifier tests for examples. The second class of
6080 * operations, BPF_LSH, BPF_RSH, and BPF_ARSH, however are not so easy
6081 * with regards to tracking sign/unsigned bounds because the bits may
6082 * cross subreg boundaries in the alu64 case. When this happens we mark
6083 * the reg unbounded in the subreg bound space and use the resulting
6084 * tnum to calculate an approximation of the sign/unsigned bounds.
6085 */
48461135
JB
6086 switch (opcode) {
6087 case BPF_ADD:
d3bd7413
DB
6088 ret = sanitize_val_alu(env, insn);
6089 if (ret < 0) {
6090 verbose(env, "R%d tried to add from different pointers or scalars\n", dst);
6091 return ret;
6092 }
3f50f132 6093 scalar32_min_max_add(dst_reg, &src_reg);
07cd2631 6094 scalar_min_max_add(dst_reg, &src_reg);
3f50f132 6095 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
48461135
JB
6096 break;
6097 case BPF_SUB:
d3bd7413
DB
6098 ret = sanitize_val_alu(env, insn);
6099 if (ret < 0) {
6100 verbose(env, "R%d tried to sub from different pointers or scalars\n", dst);
6101 return ret;
6102 }
3f50f132 6103 scalar32_min_max_sub(dst_reg, &src_reg);
07cd2631 6104 scalar_min_max_sub(dst_reg, &src_reg);
3f50f132 6105 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
48461135
JB
6106 break;
6107 case BPF_MUL:
3f50f132
JF
6108 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
6109 scalar32_min_max_mul(dst_reg, &src_reg);
07cd2631 6110 scalar_min_max_mul(dst_reg, &src_reg);
48461135
JB
6111 break;
6112 case BPF_AND:
3f50f132
JF
6113 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
6114 scalar32_min_max_and(dst_reg, &src_reg);
07cd2631 6115 scalar_min_max_and(dst_reg, &src_reg);
f1174f77
EC
6116 break;
6117 case BPF_OR:
3f50f132
JF
6118 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
6119 scalar32_min_max_or(dst_reg, &src_reg);
07cd2631 6120 scalar_min_max_or(dst_reg, &src_reg);
48461135
JB
6121 break;
6122 case BPF_LSH:
468f6eaf
JH
6123 if (umax_val >= insn_bitness) {
6124 /* Shifts greater than 31 or 63 are undefined.
6125 * This includes shifts by a negative number.
b03c9f9f 6126 */
61bd5218 6127 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77
EC
6128 break;
6129 }
3f50f132
JF
6130 if (alu32)
6131 scalar32_min_max_lsh(dst_reg, &src_reg);
6132 else
6133 scalar_min_max_lsh(dst_reg, &src_reg);
48461135
JB
6134 break;
6135 case BPF_RSH:
468f6eaf
JH
6136 if (umax_val >= insn_bitness) {
6137 /* Shifts greater than 31 or 63 are undefined.
6138 * This includes shifts by a negative number.
b03c9f9f 6139 */
61bd5218 6140 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77
EC
6141 break;
6142 }
3f50f132
JF
6143 if (alu32)
6144 scalar32_min_max_rsh(dst_reg, &src_reg);
6145 else
6146 scalar_min_max_rsh(dst_reg, &src_reg);
48461135 6147 break;
9cbe1f5a
YS
6148 case BPF_ARSH:
6149 if (umax_val >= insn_bitness) {
6150 /* Shifts greater than 31 or 63 are undefined.
6151 * This includes shifts by a negative number.
6152 */
6153 mark_reg_unknown(env, regs, insn->dst_reg);
6154 break;
6155 }
3f50f132
JF
6156 if (alu32)
6157 scalar32_min_max_arsh(dst_reg, &src_reg);
6158 else
6159 scalar_min_max_arsh(dst_reg, &src_reg);
9cbe1f5a 6160 break;
48461135 6161 default:
61bd5218 6162 mark_reg_unknown(env, regs, insn->dst_reg);
48461135
JB
6163 break;
6164 }
6165
3f50f132
JF
6166 /* ALU32 ops are zero extended into 64bit register */
6167 if (alu32)
6168 zext_32_to_64(dst_reg);
468f6eaf 6169
294f2fc6 6170 __update_reg_bounds(dst_reg);
b03c9f9f
EC
6171 __reg_deduce_bounds(dst_reg);
6172 __reg_bound_offset(dst_reg);
f1174f77
EC
6173 return 0;
6174}
6175
6176/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
6177 * and var_off.
6178 */
6179static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
6180 struct bpf_insn *insn)
6181{
f4d7e40a
AS
6182 struct bpf_verifier_state *vstate = env->cur_state;
6183 struct bpf_func_state *state = vstate->frame[vstate->curframe];
6184 struct bpf_reg_state *regs = state->regs, *dst_reg, *src_reg;
f1174f77
EC
6185 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
6186 u8 opcode = BPF_OP(insn->code);
b5dc0163 6187 int err;
f1174f77
EC
6188
6189 dst_reg = &regs[insn->dst_reg];
f1174f77
EC
6190 src_reg = NULL;
6191 if (dst_reg->type != SCALAR_VALUE)
6192 ptr_reg = dst_reg;
6193 if (BPF_SRC(insn->code) == BPF_X) {
6194 src_reg = &regs[insn->src_reg];
f1174f77
EC
6195 if (src_reg->type != SCALAR_VALUE) {
6196 if (dst_reg->type != SCALAR_VALUE) {
6197 /* Combining two pointers by any ALU op yields
82abbf8d
AS
6198 * an arbitrary scalar. Disallow all math except
6199 * pointer subtraction
f1174f77 6200 */
dd066823 6201 if (opcode == BPF_SUB && env->allow_ptr_leaks) {
82abbf8d
AS
6202 mark_reg_unknown(env, regs, insn->dst_reg);
6203 return 0;
f1174f77 6204 }
82abbf8d
AS
6205 verbose(env, "R%d pointer %s pointer prohibited\n",
6206 insn->dst_reg,
6207 bpf_alu_string[opcode >> 4]);
6208 return -EACCES;
f1174f77
EC
6209 } else {
6210 /* scalar += pointer
6211 * This is legal, but we have to reverse our
6212 * src/dest handling in computing the range
6213 */
b5dc0163
AS
6214 err = mark_chain_precision(env, insn->dst_reg);
6215 if (err)
6216 return err;
82abbf8d
AS
6217 return adjust_ptr_min_max_vals(env, insn,
6218 src_reg, dst_reg);
f1174f77
EC
6219 }
6220 } else if (ptr_reg) {
6221 /* pointer += scalar */
b5dc0163
AS
6222 err = mark_chain_precision(env, insn->src_reg);
6223 if (err)
6224 return err;
82abbf8d
AS
6225 return adjust_ptr_min_max_vals(env, insn,
6226 dst_reg, src_reg);
f1174f77
EC
6227 }
6228 } else {
6229 /* Pretend the src is a reg with a known value, since we only
6230 * need to be able to read from this state.
6231 */
6232 off_reg.type = SCALAR_VALUE;
b03c9f9f 6233 __mark_reg_known(&off_reg, insn->imm);
f1174f77 6234 src_reg = &off_reg;
82abbf8d
AS
6235 if (ptr_reg) /* pointer += K */
6236 return adjust_ptr_min_max_vals(env, insn,
6237 ptr_reg, src_reg);
f1174f77
EC
6238 }
6239
6240 /* Got here implies adding two SCALAR_VALUEs */
6241 if (WARN_ON_ONCE(ptr_reg)) {
f4d7e40a 6242 print_verifier_state(env, state);
61bd5218 6243 verbose(env, "verifier internal error: unexpected ptr_reg\n");
f1174f77
EC
6244 return -EINVAL;
6245 }
6246 if (WARN_ON(!src_reg)) {
f4d7e40a 6247 print_verifier_state(env, state);
61bd5218 6248 verbose(env, "verifier internal error: no src_reg\n");
f1174f77
EC
6249 return -EINVAL;
6250 }
6251 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
48461135
JB
6252}
6253
17a52670 6254/* check validity of 32-bit and 64-bit arithmetic operations */
58e2af8b 6255static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 6256{
638f5b90 6257 struct bpf_reg_state *regs = cur_regs(env);
17a52670
AS
6258 u8 opcode = BPF_OP(insn->code);
6259 int err;
6260
6261 if (opcode == BPF_END || opcode == BPF_NEG) {
6262 if (opcode == BPF_NEG) {
6263 if (BPF_SRC(insn->code) != 0 ||
6264 insn->src_reg != BPF_REG_0 ||
6265 insn->off != 0 || insn->imm != 0) {
61bd5218 6266 verbose(env, "BPF_NEG uses reserved fields\n");
17a52670
AS
6267 return -EINVAL;
6268 }
6269 } else {
6270 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
e67b8a68
EC
6271 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
6272 BPF_CLASS(insn->code) == BPF_ALU64) {
61bd5218 6273 verbose(env, "BPF_END uses reserved fields\n");
17a52670
AS
6274 return -EINVAL;
6275 }
6276 }
6277
6278 /* check src operand */
dc503a8a 6279 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
6280 if (err)
6281 return err;
6282
1be7f75d 6283 if (is_pointer_value(env, insn->dst_reg)) {
61bd5218 6284 verbose(env, "R%d pointer arithmetic prohibited\n",
1be7f75d
AS
6285 insn->dst_reg);
6286 return -EACCES;
6287 }
6288
17a52670 6289 /* check dest operand */
dc503a8a 6290 err = check_reg_arg(env, insn->dst_reg, DST_OP);
17a52670
AS
6291 if (err)
6292 return err;
6293
6294 } else if (opcode == BPF_MOV) {
6295
6296 if (BPF_SRC(insn->code) == BPF_X) {
6297 if (insn->imm != 0 || insn->off != 0) {
61bd5218 6298 verbose(env, "BPF_MOV uses reserved fields\n");
17a52670
AS
6299 return -EINVAL;
6300 }
6301
6302 /* check src operand */
dc503a8a 6303 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
6304 if (err)
6305 return err;
6306 } else {
6307 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
61bd5218 6308 verbose(env, "BPF_MOV uses reserved fields\n");
17a52670
AS
6309 return -EINVAL;
6310 }
6311 }
6312
fbeb1603
AF
6313 /* check dest operand, mark as required later */
6314 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
17a52670
AS
6315 if (err)
6316 return err;
6317
6318 if (BPF_SRC(insn->code) == BPF_X) {
e434b8cd
JW
6319 struct bpf_reg_state *src_reg = regs + insn->src_reg;
6320 struct bpf_reg_state *dst_reg = regs + insn->dst_reg;
6321
17a52670
AS
6322 if (BPF_CLASS(insn->code) == BPF_ALU64) {
6323 /* case: R1 = R2
6324 * copy register state to dest reg
6325 */
e434b8cd
JW
6326 *dst_reg = *src_reg;
6327 dst_reg->live |= REG_LIVE_WRITTEN;
5327ed3d 6328 dst_reg->subreg_def = DEF_NOT_SUBREG;
17a52670 6329 } else {
f1174f77 6330 /* R1 = (u32) R2 */
1be7f75d 6331 if (is_pointer_value(env, insn->src_reg)) {
61bd5218
JK
6332 verbose(env,
6333 "R%d partial copy of pointer\n",
1be7f75d
AS
6334 insn->src_reg);
6335 return -EACCES;
e434b8cd
JW
6336 } else if (src_reg->type == SCALAR_VALUE) {
6337 *dst_reg = *src_reg;
6338 dst_reg->live |= REG_LIVE_WRITTEN;
5327ed3d 6339 dst_reg->subreg_def = env->insn_idx + 1;
e434b8cd
JW
6340 } else {
6341 mark_reg_unknown(env, regs,
6342 insn->dst_reg);
1be7f75d 6343 }
3f50f132 6344 zext_32_to_64(dst_reg);
17a52670
AS
6345 }
6346 } else {
6347 /* case: R = imm
6348 * remember the value we stored into this reg
6349 */
fbeb1603
AF
6350 /* clear any state __mark_reg_known doesn't set */
6351 mark_reg_unknown(env, regs, insn->dst_reg);
f1174f77 6352 regs[insn->dst_reg].type = SCALAR_VALUE;
95a762e2
JH
6353 if (BPF_CLASS(insn->code) == BPF_ALU64) {
6354 __mark_reg_known(regs + insn->dst_reg,
6355 insn->imm);
6356 } else {
6357 __mark_reg_known(regs + insn->dst_reg,
6358 (u32)insn->imm);
6359 }
17a52670
AS
6360 }
6361
6362 } else if (opcode > BPF_END) {
61bd5218 6363 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
17a52670
AS
6364 return -EINVAL;
6365
6366 } else { /* all other ALU ops: and, sub, xor, add, ... */
6367
17a52670
AS
6368 if (BPF_SRC(insn->code) == BPF_X) {
6369 if (insn->imm != 0 || insn->off != 0) {
61bd5218 6370 verbose(env, "BPF_ALU uses reserved fields\n");
17a52670
AS
6371 return -EINVAL;
6372 }
6373 /* check src1 operand */
dc503a8a 6374 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
6375 if (err)
6376 return err;
6377 } else {
6378 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
61bd5218 6379 verbose(env, "BPF_ALU uses reserved fields\n");
17a52670
AS
6380 return -EINVAL;
6381 }
6382 }
6383
6384 /* check src2 operand */
dc503a8a 6385 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
6386 if (err)
6387 return err;
6388
6389 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
6390 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
61bd5218 6391 verbose(env, "div by zero\n");
17a52670
AS
6392 return -EINVAL;
6393 }
6394
229394e8
RV
6395 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
6396 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
6397 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
6398
6399 if (insn->imm < 0 || insn->imm >= size) {
61bd5218 6400 verbose(env, "invalid shift %d\n", insn->imm);
229394e8
RV
6401 return -EINVAL;
6402 }
6403 }
6404
1a0dc1ac 6405 /* check dest operand */
dc503a8a 6406 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
1a0dc1ac
AS
6407 if (err)
6408 return err;
6409
f1174f77 6410 return adjust_reg_min_max_vals(env, insn);
17a52670
AS
6411 }
6412
6413 return 0;
6414}
6415
c6a9efa1
PC
6416static void __find_good_pkt_pointers(struct bpf_func_state *state,
6417 struct bpf_reg_state *dst_reg,
6418 enum bpf_reg_type type, u16 new_range)
6419{
6420 struct bpf_reg_state *reg;
6421 int i;
6422
6423 for (i = 0; i < MAX_BPF_REG; i++) {
6424 reg = &state->regs[i];
6425 if (reg->type == type && reg->id == dst_reg->id)
6426 /* keep the maximum range already checked */
6427 reg->range = max(reg->range, new_range);
6428 }
6429
6430 bpf_for_each_spilled_reg(i, state, reg) {
6431 if (!reg)
6432 continue;
6433 if (reg->type == type && reg->id == dst_reg->id)
6434 reg->range = max(reg->range, new_range);
6435 }
6436}
6437
f4d7e40a 6438static void find_good_pkt_pointers(struct bpf_verifier_state *vstate,
de8f3a83 6439 struct bpf_reg_state *dst_reg,
f8ddadc4 6440 enum bpf_reg_type type,
fb2a311a 6441 bool range_right_open)
969bf05e 6442{
fb2a311a 6443 u16 new_range;
c6a9efa1 6444 int i;
2d2be8ca 6445
fb2a311a
DB
6446 if (dst_reg->off < 0 ||
6447 (dst_reg->off == 0 && range_right_open))
f1174f77
EC
6448 /* This doesn't give us any range */
6449 return;
6450
b03c9f9f
EC
6451 if (dst_reg->umax_value > MAX_PACKET_OFF ||
6452 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
f1174f77
EC
6453 /* Risk of overflow. For instance, ptr + (1<<63) may be less
6454 * than pkt_end, but that's because it's also less than pkt.
6455 */
6456 return;
6457
fb2a311a
DB
6458 new_range = dst_reg->off;
6459 if (range_right_open)
6460 new_range--;
6461
6462 /* Examples for register markings:
2d2be8ca 6463 *
fb2a311a 6464 * pkt_data in dst register:
2d2be8ca
DB
6465 *
6466 * r2 = r3;
6467 * r2 += 8;
6468 * if (r2 > pkt_end) goto <handle exception>
6469 * <access okay>
6470 *
b4e432f1
DB
6471 * r2 = r3;
6472 * r2 += 8;
6473 * if (r2 < pkt_end) goto <access okay>
6474 * <handle exception>
6475 *
2d2be8ca
DB
6476 * Where:
6477 * r2 == dst_reg, pkt_end == src_reg
6478 * r2=pkt(id=n,off=8,r=0)
6479 * r3=pkt(id=n,off=0,r=0)
6480 *
fb2a311a 6481 * pkt_data in src register:
2d2be8ca
DB
6482 *
6483 * r2 = r3;
6484 * r2 += 8;
6485 * if (pkt_end >= r2) goto <access okay>
6486 * <handle exception>
6487 *
b4e432f1
DB
6488 * r2 = r3;
6489 * r2 += 8;
6490 * if (pkt_end <= r2) goto <handle exception>
6491 * <access okay>
6492 *
2d2be8ca
DB
6493 * Where:
6494 * pkt_end == dst_reg, r2 == src_reg
6495 * r2=pkt(id=n,off=8,r=0)
6496 * r3=pkt(id=n,off=0,r=0)
6497 *
6498 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
fb2a311a
DB
6499 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
6500 * and [r3, r3 + 8-1) respectively is safe to access depending on
6501 * the check.
969bf05e 6502 */
2d2be8ca 6503
f1174f77
EC
6504 /* If our ids match, then we must have the same max_value. And we
6505 * don't care about the other reg's fixed offset, since if it's too big
6506 * the range won't allow anything.
6507 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
6508 */
c6a9efa1
PC
6509 for (i = 0; i <= vstate->curframe; i++)
6510 __find_good_pkt_pointers(vstate->frame[i], dst_reg, type,
6511 new_range);
969bf05e
AS
6512}
6513
3f50f132 6514static int is_branch32_taken(struct bpf_reg_state *reg, u32 val, u8 opcode)
4f7b3e82 6515{
3f50f132
JF
6516 struct tnum subreg = tnum_subreg(reg->var_off);
6517 s32 sval = (s32)val;
a72dafaf 6518
3f50f132
JF
6519 switch (opcode) {
6520 case BPF_JEQ:
6521 if (tnum_is_const(subreg))
6522 return !!tnum_equals_const(subreg, val);
6523 break;
6524 case BPF_JNE:
6525 if (tnum_is_const(subreg))
6526 return !tnum_equals_const(subreg, val);
6527 break;
6528 case BPF_JSET:
6529 if ((~subreg.mask & subreg.value) & val)
6530 return 1;
6531 if (!((subreg.mask | subreg.value) & val))
6532 return 0;
6533 break;
6534 case BPF_JGT:
6535 if (reg->u32_min_value > val)
6536 return 1;
6537 else if (reg->u32_max_value <= val)
6538 return 0;
6539 break;
6540 case BPF_JSGT:
6541 if (reg->s32_min_value > sval)
6542 return 1;
6543 else if (reg->s32_max_value < sval)
6544 return 0;
6545 break;
6546 case BPF_JLT:
6547 if (reg->u32_max_value < val)
6548 return 1;
6549 else if (reg->u32_min_value >= val)
6550 return 0;
6551 break;
6552 case BPF_JSLT:
6553 if (reg->s32_max_value < sval)
6554 return 1;
6555 else if (reg->s32_min_value >= sval)
6556 return 0;
6557 break;
6558 case BPF_JGE:
6559 if (reg->u32_min_value >= val)
6560 return 1;
6561 else if (reg->u32_max_value < val)
6562 return 0;
6563 break;
6564 case BPF_JSGE:
6565 if (reg->s32_min_value >= sval)
6566 return 1;
6567 else if (reg->s32_max_value < sval)
6568 return 0;
6569 break;
6570 case BPF_JLE:
6571 if (reg->u32_max_value <= val)
6572 return 1;
6573 else if (reg->u32_min_value > val)
6574 return 0;
6575 break;
6576 case BPF_JSLE:
6577 if (reg->s32_max_value <= sval)
6578 return 1;
6579 else if (reg->s32_min_value > sval)
6580 return 0;
6581 break;
6582 }
4f7b3e82 6583
3f50f132
JF
6584 return -1;
6585}
092ed096 6586
3f50f132
JF
6587
6588static int is_branch64_taken(struct bpf_reg_state *reg, u64 val, u8 opcode)
6589{
6590 s64 sval = (s64)val;
a72dafaf 6591
4f7b3e82
AS
6592 switch (opcode) {
6593 case BPF_JEQ:
6594 if (tnum_is_const(reg->var_off))
6595 return !!tnum_equals_const(reg->var_off, val);
6596 break;
6597 case BPF_JNE:
6598 if (tnum_is_const(reg->var_off))
6599 return !tnum_equals_const(reg->var_off, val);
6600 break;
960ea056
JK
6601 case BPF_JSET:
6602 if ((~reg->var_off.mask & reg->var_off.value) & val)
6603 return 1;
6604 if (!((reg->var_off.mask | reg->var_off.value) & val))
6605 return 0;
6606 break;
4f7b3e82
AS
6607 case BPF_JGT:
6608 if (reg->umin_value > val)
6609 return 1;
6610 else if (reg->umax_value <= val)
6611 return 0;
6612 break;
6613 case BPF_JSGT:
a72dafaf 6614 if (reg->smin_value > sval)
4f7b3e82 6615 return 1;
a72dafaf 6616 else if (reg->smax_value < sval)
4f7b3e82
AS
6617 return 0;
6618 break;
6619 case BPF_JLT:
6620 if (reg->umax_value < val)
6621 return 1;
6622 else if (reg->umin_value >= val)
6623 return 0;
6624 break;
6625 case BPF_JSLT:
a72dafaf 6626 if (reg->smax_value < sval)
4f7b3e82 6627 return 1;
a72dafaf 6628 else if (reg->smin_value >= sval)
4f7b3e82
AS
6629 return 0;
6630 break;
6631 case BPF_JGE:
6632 if (reg->umin_value >= val)
6633 return 1;
6634 else if (reg->umax_value < val)
6635 return 0;
6636 break;
6637 case BPF_JSGE:
a72dafaf 6638 if (reg->smin_value >= sval)
4f7b3e82 6639 return 1;
a72dafaf 6640 else if (reg->smax_value < sval)
4f7b3e82
AS
6641 return 0;
6642 break;
6643 case BPF_JLE:
6644 if (reg->umax_value <= val)
6645 return 1;
6646 else if (reg->umin_value > val)
6647 return 0;
6648 break;
6649 case BPF_JSLE:
a72dafaf 6650 if (reg->smax_value <= sval)
4f7b3e82 6651 return 1;
a72dafaf 6652 else if (reg->smin_value > sval)
4f7b3e82
AS
6653 return 0;
6654 break;
6655 }
6656
6657 return -1;
6658}
6659
3f50f132
JF
6660/* compute branch direction of the expression "if (reg opcode val) goto target;"
6661 * and return:
6662 * 1 - branch will be taken and "goto target" will be executed
6663 * 0 - branch will not be taken and fall-through to next insn
6664 * -1 - unknown. Example: "if (reg < 5)" is unknown when register value
6665 * range [0,10]
604dca5e 6666 */
3f50f132
JF
6667static int is_branch_taken(struct bpf_reg_state *reg, u64 val, u8 opcode,
6668 bool is_jmp32)
604dca5e 6669{
cac616db
JF
6670 if (__is_pointer_value(false, reg)) {
6671 if (!reg_type_not_null(reg->type))
6672 return -1;
6673
6674 /* If pointer is valid tests against zero will fail so we can
6675 * use this to direct branch taken.
6676 */
6677 if (val != 0)
6678 return -1;
6679
6680 switch (opcode) {
6681 case BPF_JEQ:
6682 return 0;
6683 case BPF_JNE:
6684 return 1;
6685 default:
6686 return -1;
6687 }
6688 }
604dca5e 6689
3f50f132
JF
6690 if (is_jmp32)
6691 return is_branch32_taken(reg, val, opcode);
6692 return is_branch64_taken(reg, val, opcode);
604dca5e
JH
6693}
6694
48461135
JB
6695/* Adjusts the register min/max values in the case that the dst_reg is the
6696 * variable register that we are working on, and src_reg is a constant or we're
6697 * simply doing a BPF_K check.
f1174f77 6698 * In JEQ/JNE cases we also adjust the var_off values.
48461135
JB
6699 */
6700static void reg_set_min_max(struct bpf_reg_state *true_reg,
3f50f132
JF
6701 struct bpf_reg_state *false_reg,
6702 u64 val, u32 val32,
092ed096 6703 u8 opcode, bool is_jmp32)
48461135 6704{
3f50f132
JF
6705 struct tnum false_32off = tnum_subreg(false_reg->var_off);
6706 struct tnum false_64off = false_reg->var_off;
6707 struct tnum true_32off = tnum_subreg(true_reg->var_off);
6708 struct tnum true_64off = true_reg->var_off;
6709 s64 sval = (s64)val;
6710 s32 sval32 = (s32)val32;
a72dafaf 6711
f1174f77
EC
6712 /* If the dst_reg is a pointer, we can't learn anything about its
6713 * variable offset from the compare (unless src_reg were a pointer into
6714 * the same object, but we don't bother with that.
6715 * Since false_reg and true_reg have the same type by construction, we
6716 * only need to check one of them for pointerness.
6717 */
6718 if (__is_pointer_value(false, false_reg))
6719 return;
4cabc5b1 6720
48461135
JB
6721 switch (opcode) {
6722 case BPF_JEQ:
48461135 6723 case BPF_JNE:
a72dafaf
JW
6724 {
6725 struct bpf_reg_state *reg =
6726 opcode == BPF_JEQ ? true_reg : false_reg;
6727
6728 /* For BPF_JEQ, if this is false we know nothing Jon Snow, but
6729 * if it is true we know the value for sure. Likewise for
6730 * BPF_JNE.
48461135 6731 */
3f50f132
JF
6732 if (is_jmp32)
6733 __mark_reg32_known(reg, val32);
6734 else
092ed096 6735 __mark_reg_known(reg, val);
48461135 6736 break;
a72dafaf 6737 }
960ea056 6738 case BPF_JSET:
3f50f132
JF
6739 if (is_jmp32) {
6740 false_32off = tnum_and(false_32off, tnum_const(~val32));
6741 if (is_power_of_2(val32))
6742 true_32off = tnum_or(true_32off,
6743 tnum_const(val32));
6744 } else {
6745 false_64off = tnum_and(false_64off, tnum_const(~val));
6746 if (is_power_of_2(val))
6747 true_64off = tnum_or(true_64off,
6748 tnum_const(val));
6749 }
960ea056 6750 break;
48461135 6751 case BPF_JGE:
a72dafaf
JW
6752 case BPF_JGT:
6753 {
3f50f132
JF
6754 if (is_jmp32) {
6755 u32 false_umax = opcode == BPF_JGT ? val32 : val32 - 1;
6756 u32 true_umin = opcode == BPF_JGT ? val32 + 1 : val32;
6757
6758 false_reg->u32_max_value = min(false_reg->u32_max_value,
6759 false_umax);
6760 true_reg->u32_min_value = max(true_reg->u32_min_value,
6761 true_umin);
6762 } else {
6763 u64 false_umax = opcode == BPF_JGT ? val : val - 1;
6764 u64 true_umin = opcode == BPF_JGT ? val + 1 : val;
6765
6766 false_reg->umax_value = min(false_reg->umax_value, false_umax);
6767 true_reg->umin_value = max(true_reg->umin_value, true_umin);
6768 }
b03c9f9f 6769 break;
a72dafaf 6770 }
48461135 6771 case BPF_JSGE:
a72dafaf
JW
6772 case BPF_JSGT:
6773 {
3f50f132
JF
6774 if (is_jmp32) {
6775 s32 false_smax = opcode == BPF_JSGT ? sval32 : sval32 - 1;
6776 s32 true_smin = opcode == BPF_JSGT ? sval32 + 1 : sval32;
a72dafaf 6777
3f50f132
JF
6778 false_reg->s32_max_value = min(false_reg->s32_max_value, false_smax);
6779 true_reg->s32_min_value = max(true_reg->s32_min_value, true_smin);
6780 } else {
6781 s64 false_smax = opcode == BPF_JSGT ? sval : sval - 1;
6782 s64 true_smin = opcode == BPF_JSGT ? sval + 1 : sval;
6783
6784 false_reg->smax_value = min(false_reg->smax_value, false_smax);
6785 true_reg->smin_value = max(true_reg->smin_value, true_smin);
6786 }
48461135 6787 break;
a72dafaf 6788 }
b4e432f1 6789 case BPF_JLE:
a72dafaf
JW
6790 case BPF_JLT:
6791 {
3f50f132
JF
6792 if (is_jmp32) {
6793 u32 false_umin = opcode == BPF_JLT ? val32 : val32 + 1;
6794 u32 true_umax = opcode == BPF_JLT ? val32 - 1 : val32;
6795
6796 false_reg->u32_min_value = max(false_reg->u32_min_value,
6797 false_umin);
6798 true_reg->u32_max_value = min(true_reg->u32_max_value,
6799 true_umax);
6800 } else {
6801 u64 false_umin = opcode == BPF_JLT ? val : val + 1;
6802 u64 true_umax = opcode == BPF_JLT ? val - 1 : val;
6803
6804 false_reg->umin_value = max(false_reg->umin_value, false_umin);
6805 true_reg->umax_value = min(true_reg->umax_value, true_umax);
6806 }
b4e432f1 6807 break;
a72dafaf 6808 }
b4e432f1 6809 case BPF_JSLE:
a72dafaf
JW
6810 case BPF_JSLT:
6811 {
3f50f132
JF
6812 if (is_jmp32) {
6813 s32 false_smin = opcode == BPF_JSLT ? sval32 : sval32 + 1;
6814 s32 true_smax = opcode == BPF_JSLT ? sval32 - 1 : sval32;
a72dafaf 6815
3f50f132
JF
6816 false_reg->s32_min_value = max(false_reg->s32_min_value, false_smin);
6817 true_reg->s32_max_value = min(true_reg->s32_max_value, true_smax);
6818 } else {
6819 s64 false_smin = opcode == BPF_JSLT ? sval : sval + 1;
6820 s64 true_smax = opcode == BPF_JSLT ? sval - 1 : sval;
6821
6822 false_reg->smin_value = max(false_reg->smin_value, false_smin);
6823 true_reg->smax_value = min(true_reg->smax_value, true_smax);
6824 }
b4e432f1 6825 break;
a72dafaf 6826 }
48461135 6827 default:
0fc31b10 6828 return;
48461135
JB
6829 }
6830
3f50f132
JF
6831 if (is_jmp32) {
6832 false_reg->var_off = tnum_or(tnum_clear_subreg(false_64off),
6833 tnum_subreg(false_32off));
6834 true_reg->var_off = tnum_or(tnum_clear_subreg(true_64off),
6835 tnum_subreg(true_32off));
6836 __reg_combine_32_into_64(false_reg);
6837 __reg_combine_32_into_64(true_reg);
6838 } else {
6839 false_reg->var_off = false_64off;
6840 true_reg->var_off = true_64off;
6841 __reg_combine_64_into_32(false_reg);
6842 __reg_combine_64_into_32(true_reg);
6843 }
48461135
JB
6844}
6845
f1174f77
EC
6846/* Same as above, but for the case that dst_reg holds a constant and src_reg is
6847 * the variable reg.
48461135
JB
6848 */
6849static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
3f50f132
JF
6850 struct bpf_reg_state *false_reg,
6851 u64 val, u32 val32,
092ed096 6852 u8 opcode, bool is_jmp32)
48461135 6853{
0fc31b10
JH
6854 /* How can we transform "a <op> b" into "b <op> a"? */
6855 static const u8 opcode_flip[16] = {
6856 /* these stay the same */
6857 [BPF_JEQ >> 4] = BPF_JEQ,
6858 [BPF_JNE >> 4] = BPF_JNE,
6859 [BPF_JSET >> 4] = BPF_JSET,
6860 /* these swap "lesser" and "greater" (L and G in the opcodes) */
6861 [BPF_JGE >> 4] = BPF_JLE,
6862 [BPF_JGT >> 4] = BPF_JLT,
6863 [BPF_JLE >> 4] = BPF_JGE,
6864 [BPF_JLT >> 4] = BPF_JGT,
6865 [BPF_JSGE >> 4] = BPF_JSLE,
6866 [BPF_JSGT >> 4] = BPF_JSLT,
6867 [BPF_JSLE >> 4] = BPF_JSGE,
6868 [BPF_JSLT >> 4] = BPF_JSGT
6869 };
6870 opcode = opcode_flip[opcode >> 4];
6871 /* This uses zero as "not present in table"; luckily the zero opcode,
6872 * BPF_JA, can't get here.
b03c9f9f 6873 */
0fc31b10 6874 if (opcode)
3f50f132 6875 reg_set_min_max(true_reg, false_reg, val, val32, opcode, is_jmp32);
f1174f77
EC
6876}
6877
6878/* Regs are known to be equal, so intersect their min/max/var_off */
6879static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
6880 struct bpf_reg_state *dst_reg)
6881{
b03c9f9f
EC
6882 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
6883 dst_reg->umin_value);
6884 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
6885 dst_reg->umax_value);
6886 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
6887 dst_reg->smin_value);
6888 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
6889 dst_reg->smax_value);
f1174f77
EC
6890 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
6891 dst_reg->var_off);
b03c9f9f
EC
6892 /* We might have learned new bounds from the var_off. */
6893 __update_reg_bounds(src_reg);
6894 __update_reg_bounds(dst_reg);
6895 /* We might have learned something about the sign bit. */
6896 __reg_deduce_bounds(src_reg);
6897 __reg_deduce_bounds(dst_reg);
6898 /* We might have learned some bits from the bounds. */
6899 __reg_bound_offset(src_reg);
6900 __reg_bound_offset(dst_reg);
6901 /* Intersecting with the old var_off might have improved our bounds
6902 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
6903 * then new var_off is (0; 0x7f...fc) which improves our umax.
6904 */
6905 __update_reg_bounds(src_reg);
6906 __update_reg_bounds(dst_reg);
f1174f77
EC
6907}
6908
6909static void reg_combine_min_max(struct bpf_reg_state *true_src,
6910 struct bpf_reg_state *true_dst,
6911 struct bpf_reg_state *false_src,
6912 struct bpf_reg_state *false_dst,
6913 u8 opcode)
6914{
6915 switch (opcode) {
6916 case BPF_JEQ:
6917 __reg_combine_min_max(true_src, true_dst);
6918 break;
6919 case BPF_JNE:
6920 __reg_combine_min_max(false_src, false_dst);
b03c9f9f 6921 break;
4cabc5b1 6922 }
48461135
JB
6923}
6924
fd978bf7
JS
6925static void mark_ptr_or_null_reg(struct bpf_func_state *state,
6926 struct bpf_reg_state *reg, u32 id,
840b9615 6927 bool is_null)
57a09bf0 6928{
840b9615 6929 if (reg_type_may_be_null(reg->type) && reg->id == id) {
f1174f77
EC
6930 /* Old offset (both fixed and variable parts) should
6931 * have been known-zero, because we don't allow pointer
6932 * arithmetic on pointers that might be NULL.
6933 */
b03c9f9f
EC
6934 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
6935 !tnum_equals_const(reg->var_off, 0) ||
f1174f77 6936 reg->off)) {
b03c9f9f
EC
6937 __mark_reg_known_zero(reg);
6938 reg->off = 0;
f1174f77
EC
6939 }
6940 if (is_null) {
6941 reg->type = SCALAR_VALUE;
840b9615 6942 } else if (reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
64d85290
JS
6943 const struct bpf_map *map = reg->map_ptr;
6944
6945 if (map->inner_map_meta) {
840b9615 6946 reg->type = CONST_PTR_TO_MAP;
64d85290
JS
6947 reg->map_ptr = map->inner_map_meta;
6948 } else if (map->map_type == BPF_MAP_TYPE_XSKMAP) {
fada7fdc 6949 reg->type = PTR_TO_XDP_SOCK;
64d85290
JS
6950 } else if (map->map_type == BPF_MAP_TYPE_SOCKMAP ||
6951 map->map_type == BPF_MAP_TYPE_SOCKHASH) {
6952 reg->type = PTR_TO_SOCKET;
840b9615
JS
6953 } else {
6954 reg->type = PTR_TO_MAP_VALUE;
6955 }
c64b7983
JS
6956 } else if (reg->type == PTR_TO_SOCKET_OR_NULL) {
6957 reg->type = PTR_TO_SOCKET;
46f8bc92
MKL
6958 } else if (reg->type == PTR_TO_SOCK_COMMON_OR_NULL) {
6959 reg->type = PTR_TO_SOCK_COMMON;
655a51e5
MKL
6960 } else if (reg->type == PTR_TO_TCP_SOCK_OR_NULL) {
6961 reg->type = PTR_TO_TCP_SOCK;
b121b341
YS
6962 } else if (reg->type == PTR_TO_BTF_ID_OR_NULL) {
6963 reg->type = PTR_TO_BTF_ID;
457f4436
AN
6964 } else if (reg->type == PTR_TO_MEM_OR_NULL) {
6965 reg->type = PTR_TO_MEM;
afbf21dc
YS
6966 } else if (reg->type == PTR_TO_RDONLY_BUF_OR_NULL) {
6967 reg->type = PTR_TO_RDONLY_BUF;
6968 } else if (reg->type == PTR_TO_RDWR_BUF_OR_NULL) {
6969 reg->type = PTR_TO_RDWR_BUF;
56f668df 6970 }
1b986589
MKL
6971 if (is_null) {
6972 /* We don't need id and ref_obj_id from this point
6973 * onwards anymore, thus we should better reset it,
6974 * so that state pruning has chances to take effect.
6975 */
6976 reg->id = 0;
6977 reg->ref_obj_id = 0;
6978 } else if (!reg_may_point_to_spin_lock(reg)) {
6979 /* For not-NULL ptr, reg->ref_obj_id will be reset
6980 * in release_reg_references().
6981 *
6982 * reg->id is still used by spin_lock ptr. Other
6983 * than spin_lock ptr type, reg->id can be reset.
fd978bf7
JS
6984 */
6985 reg->id = 0;
56f668df 6986 }
57a09bf0
TG
6987 }
6988}
6989
c6a9efa1
PC
6990static void __mark_ptr_or_null_regs(struct bpf_func_state *state, u32 id,
6991 bool is_null)
6992{
6993 struct bpf_reg_state *reg;
6994 int i;
6995
6996 for (i = 0; i < MAX_BPF_REG; i++)
6997 mark_ptr_or_null_reg(state, &state->regs[i], id, is_null);
6998
6999 bpf_for_each_spilled_reg(i, state, reg) {
7000 if (!reg)
7001 continue;
7002 mark_ptr_or_null_reg(state, reg, id, is_null);
7003 }
7004}
7005
57a09bf0
TG
7006/* The logic is similar to find_good_pkt_pointers(), both could eventually
7007 * be folded together at some point.
7008 */
840b9615
JS
7009static void mark_ptr_or_null_regs(struct bpf_verifier_state *vstate, u32 regno,
7010 bool is_null)
57a09bf0 7011{
f4d7e40a 7012 struct bpf_func_state *state = vstate->frame[vstate->curframe];
c6a9efa1 7013 struct bpf_reg_state *regs = state->regs;
1b986589 7014 u32 ref_obj_id = regs[regno].ref_obj_id;
a08dd0da 7015 u32 id = regs[regno].id;
c6a9efa1 7016 int i;
57a09bf0 7017
1b986589
MKL
7018 if (ref_obj_id && ref_obj_id == id && is_null)
7019 /* regs[regno] is in the " == NULL" branch.
7020 * No one could have freed the reference state before
7021 * doing the NULL check.
7022 */
7023 WARN_ON_ONCE(release_reference_state(state, id));
fd978bf7 7024
c6a9efa1
PC
7025 for (i = 0; i <= vstate->curframe; i++)
7026 __mark_ptr_or_null_regs(vstate->frame[i], id, is_null);
57a09bf0
TG
7027}
7028
5beca081
DB
7029static bool try_match_pkt_pointers(const struct bpf_insn *insn,
7030 struct bpf_reg_state *dst_reg,
7031 struct bpf_reg_state *src_reg,
7032 struct bpf_verifier_state *this_branch,
7033 struct bpf_verifier_state *other_branch)
7034{
7035 if (BPF_SRC(insn->code) != BPF_X)
7036 return false;
7037
092ed096
JW
7038 /* Pointers are always 64-bit. */
7039 if (BPF_CLASS(insn->code) == BPF_JMP32)
7040 return false;
7041
5beca081
DB
7042 switch (BPF_OP(insn->code)) {
7043 case BPF_JGT:
7044 if ((dst_reg->type == PTR_TO_PACKET &&
7045 src_reg->type == PTR_TO_PACKET_END) ||
7046 (dst_reg->type == PTR_TO_PACKET_META &&
7047 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7048 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
7049 find_good_pkt_pointers(this_branch, dst_reg,
7050 dst_reg->type, false);
7051 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7052 src_reg->type == PTR_TO_PACKET) ||
7053 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7054 src_reg->type == PTR_TO_PACKET_META)) {
7055 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
7056 find_good_pkt_pointers(other_branch, src_reg,
7057 src_reg->type, true);
7058 } else {
7059 return false;
7060 }
7061 break;
7062 case BPF_JLT:
7063 if ((dst_reg->type == PTR_TO_PACKET &&
7064 src_reg->type == PTR_TO_PACKET_END) ||
7065 (dst_reg->type == PTR_TO_PACKET_META &&
7066 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7067 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
7068 find_good_pkt_pointers(other_branch, dst_reg,
7069 dst_reg->type, true);
7070 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7071 src_reg->type == PTR_TO_PACKET) ||
7072 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7073 src_reg->type == PTR_TO_PACKET_META)) {
7074 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
7075 find_good_pkt_pointers(this_branch, src_reg,
7076 src_reg->type, false);
7077 } else {
7078 return false;
7079 }
7080 break;
7081 case BPF_JGE:
7082 if ((dst_reg->type == PTR_TO_PACKET &&
7083 src_reg->type == PTR_TO_PACKET_END) ||
7084 (dst_reg->type == PTR_TO_PACKET_META &&
7085 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7086 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
7087 find_good_pkt_pointers(this_branch, dst_reg,
7088 dst_reg->type, true);
7089 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7090 src_reg->type == PTR_TO_PACKET) ||
7091 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7092 src_reg->type == PTR_TO_PACKET_META)) {
7093 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
7094 find_good_pkt_pointers(other_branch, src_reg,
7095 src_reg->type, false);
7096 } else {
7097 return false;
7098 }
7099 break;
7100 case BPF_JLE:
7101 if ((dst_reg->type == PTR_TO_PACKET &&
7102 src_reg->type == PTR_TO_PACKET_END) ||
7103 (dst_reg->type == PTR_TO_PACKET_META &&
7104 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
7105 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
7106 find_good_pkt_pointers(other_branch, dst_reg,
7107 dst_reg->type, false);
7108 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
7109 src_reg->type == PTR_TO_PACKET) ||
7110 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
7111 src_reg->type == PTR_TO_PACKET_META)) {
7112 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
7113 find_good_pkt_pointers(this_branch, src_reg,
7114 src_reg->type, true);
7115 } else {
7116 return false;
7117 }
7118 break;
7119 default:
7120 return false;
7121 }
7122
7123 return true;
7124}
7125
58e2af8b 7126static int check_cond_jmp_op(struct bpf_verifier_env *env,
17a52670
AS
7127 struct bpf_insn *insn, int *insn_idx)
7128{
f4d7e40a
AS
7129 struct bpf_verifier_state *this_branch = env->cur_state;
7130 struct bpf_verifier_state *other_branch;
7131 struct bpf_reg_state *regs = this_branch->frame[this_branch->curframe]->regs;
fb8d251e 7132 struct bpf_reg_state *dst_reg, *other_branch_regs, *src_reg = NULL;
17a52670 7133 u8 opcode = BPF_OP(insn->code);
092ed096 7134 bool is_jmp32;
fb8d251e 7135 int pred = -1;
17a52670
AS
7136 int err;
7137
092ed096
JW
7138 /* Only conditional jumps are expected to reach here. */
7139 if (opcode == BPF_JA || opcode > BPF_JSLE) {
7140 verbose(env, "invalid BPF_JMP/JMP32 opcode %x\n", opcode);
17a52670
AS
7141 return -EINVAL;
7142 }
7143
7144 if (BPF_SRC(insn->code) == BPF_X) {
7145 if (insn->imm != 0) {
092ed096 7146 verbose(env, "BPF_JMP/JMP32 uses reserved fields\n");
17a52670
AS
7147 return -EINVAL;
7148 }
7149
7150 /* check src1 operand */
dc503a8a 7151 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
7152 if (err)
7153 return err;
1be7f75d
AS
7154
7155 if (is_pointer_value(env, insn->src_reg)) {
61bd5218 7156 verbose(env, "R%d pointer comparison prohibited\n",
1be7f75d
AS
7157 insn->src_reg);
7158 return -EACCES;
7159 }
fb8d251e 7160 src_reg = &regs[insn->src_reg];
17a52670
AS
7161 } else {
7162 if (insn->src_reg != BPF_REG_0) {
092ed096 7163 verbose(env, "BPF_JMP/JMP32 uses reserved fields\n");
17a52670
AS
7164 return -EINVAL;
7165 }
7166 }
7167
7168 /* check src2 operand */
dc503a8a 7169 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
7170 if (err)
7171 return err;
7172
1a0dc1ac 7173 dst_reg = &regs[insn->dst_reg];
092ed096 7174 is_jmp32 = BPF_CLASS(insn->code) == BPF_JMP32;
1a0dc1ac 7175
3f50f132
JF
7176 if (BPF_SRC(insn->code) == BPF_K) {
7177 pred = is_branch_taken(dst_reg, insn->imm, opcode, is_jmp32);
7178 } else if (src_reg->type == SCALAR_VALUE &&
7179 is_jmp32 && tnum_is_const(tnum_subreg(src_reg->var_off))) {
7180 pred = is_branch_taken(dst_reg,
7181 tnum_subreg(src_reg->var_off).value,
7182 opcode,
7183 is_jmp32);
7184 } else if (src_reg->type == SCALAR_VALUE &&
7185 !is_jmp32 && tnum_is_const(src_reg->var_off)) {
7186 pred = is_branch_taken(dst_reg,
7187 src_reg->var_off.value,
7188 opcode,
7189 is_jmp32);
7190 }
7191
b5dc0163 7192 if (pred >= 0) {
cac616db
JF
7193 /* If we get here with a dst_reg pointer type it is because
7194 * above is_branch_taken() special cased the 0 comparison.
7195 */
7196 if (!__is_pointer_value(false, dst_reg))
7197 err = mark_chain_precision(env, insn->dst_reg);
b5dc0163
AS
7198 if (BPF_SRC(insn->code) == BPF_X && !err)
7199 err = mark_chain_precision(env, insn->src_reg);
7200 if (err)
7201 return err;
7202 }
fb8d251e
AS
7203 if (pred == 1) {
7204 /* only follow the goto, ignore fall-through */
7205 *insn_idx += insn->off;
7206 return 0;
7207 } else if (pred == 0) {
7208 /* only follow fall-through branch, since
7209 * that's where the program will go
7210 */
7211 return 0;
17a52670
AS
7212 }
7213
979d63d5
DB
7214 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx,
7215 false);
17a52670
AS
7216 if (!other_branch)
7217 return -EFAULT;
f4d7e40a 7218 other_branch_regs = other_branch->frame[other_branch->curframe]->regs;
17a52670 7219
48461135
JB
7220 /* detect if we are comparing against a constant value so we can adjust
7221 * our min/max values for our dst register.
f1174f77
EC
7222 * this is only legit if both are scalars (or pointers to the same
7223 * object, I suppose, but we don't support that right now), because
7224 * otherwise the different base pointers mean the offsets aren't
7225 * comparable.
48461135
JB
7226 */
7227 if (BPF_SRC(insn->code) == BPF_X) {
092ed096 7228 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
092ed096 7229
f1174f77 7230 if (dst_reg->type == SCALAR_VALUE &&
092ed096
JW
7231 src_reg->type == SCALAR_VALUE) {
7232 if (tnum_is_const(src_reg->var_off) ||
3f50f132
JF
7233 (is_jmp32 &&
7234 tnum_is_const(tnum_subreg(src_reg->var_off))))
f4d7e40a 7235 reg_set_min_max(&other_branch_regs[insn->dst_reg],
092ed096 7236 dst_reg,
3f50f132
JF
7237 src_reg->var_off.value,
7238 tnum_subreg(src_reg->var_off).value,
092ed096
JW
7239 opcode, is_jmp32);
7240 else if (tnum_is_const(dst_reg->var_off) ||
3f50f132
JF
7241 (is_jmp32 &&
7242 tnum_is_const(tnum_subreg(dst_reg->var_off))))
f4d7e40a 7243 reg_set_min_max_inv(&other_branch_regs[insn->src_reg],
092ed096 7244 src_reg,
3f50f132
JF
7245 dst_reg->var_off.value,
7246 tnum_subreg(dst_reg->var_off).value,
092ed096
JW
7247 opcode, is_jmp32);
7248 else if (!is_jmp32 &&
7249 (opcode == BPF_JEQ || opcode == BPF_JNE))
f1174f77 7250 /* Comparing for equality, we can combine knowledge */
f4d7e40a
AS
7251 reg_combine_min_max(&other_branch_regs[insn->src_reg],
7252 &other_branch_regs[insn->dst_reg],
092ed096 7253 src_reg, dst_reg, opcode);
f1174f77
EC
7254 }
7255 } else if (dst_reg->type == SCALAR_VALUE) {
f4d7e40a 7256 reg_set_min_max(&other_branch_regs[insn->dst_reg],
3f50f132
JF
7257 dst_reg, insn->imm, (u32)insn->imm,
7258 opcode, is_jmp32);
48461135
JB
7259 }
7260
092ed096
JW
7261 /* detect if R == 0 where R is returned from bpf_map_lookup_elem().
7262 * NOTE: these optimizations below are related with pointer comparison
7263 * which will never be JMP32.
7264 */
7265 if (!is_jmp32 && BPF_SRC(insn->code) == BPF_K &&
1a0dc1ac 7266 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
840b9615
JS
7267 reg_type_may_be_null(dst_reg->type)) {
7268 /* Mark all identical registers in each branch as either
57a09bf0
TG
7269 * safe or unknown depending R == 0 or R != 0 conditional.
7270 */
840b9615
JS
7271 mark_ptr_or_null_regs(this_branch, insn->dst_reg,
7272 opcode == BPF_JNE);
7273 mark_ptr_or_null_regs(other_branch, insn->dst_reg,
7274 opcode == BPF_JEQ);
5beca081
DB
7275 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
7276 this_branch, other_branch) &&
7277 is_pointer_value(env, insn->dst_reg)) {
61bd5218
JK
7278 verbose(env, "R%d pointer comparison prohibited\n",
7279 insn->dst_reg);
1be7f75d 7280 return -EACCES;
17a52670 7281 }
06ee7115 7282 if (env->log.level & BPF_LOG_LEVEL)
f4d7e40a 7283 print_verifier_state(env, this_branch->frame[this_branch->curframe]);
17a52670
AS
7284 return 0;
7285}
7286
17a52670 7287/* verify BPF_LD_IMM64 instruction */
58e2af8b 7288static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 7289{
d8eca5bb 7290 struct bpf_insn_aux_data *aux = cur_aux(env);
638f5b90 7291 struct bpf_reg_state *regs = cur_regs(env);
d8eca5bb 7292 struct bpf_map *map;
17a52670
AS
7293 int err;
7294
7295 if (BPF_SIZE(insn->code) != BPF_DW) {
61bd5218 7296 verbose(env, "invalid BPF_LD_IMM insn\n");
17a52670
AS
7297 return -EINVAL;
7298 }
7299 if (insn->off != 0) {
61bd5218 7300 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
17a52670
AS
7301 return -EINVAL;
7302 }
7303
dc503a8a 7304 err = check_reg_arg(env, insn->dst_reg, DST_OP);
17a52670
AS
7305 if (err)
7306 return err;
7307
6b173873 7308 if (insn->src_reg == 0) {
6b173873
JK
7309 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
7310
f1174f77 7311 regs[insn->dst_reg].type = SCALAR_VALUE;
b03c9f9f 7312 __mark_reg_known(&regs[insn->dst_reg], imm);
17a52670 7313 return 0;
6b173873 7314 }
17a52670 7315
d8eca5bb
DB
7316 map = env->used_maps[aux->map_index];
7317 mark_reg_known_zero(env, regs, insn->dst_reg);
7318 regs[insn->dst_reg].map_ptr = map;
7319
7320 if (insn->src_reg == BPF_PSEUDO_MAP_VALUE) {
7321 regs[insn->dst_reg].type = PTR_TO_MAP_VALUE;
7322 regs[insn->dst_reg].off = aux->map_off;
7323 if (map_value_has_spin_lock(map))
7324 regs[insn->dst_reg].id = ++env->id_gen;
7325 } else if (insn->src_reg == BPF_PSEUDO_MAP_FD) {
7326 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
7327 } else {
7328 verbose(env, "bpf verifier is misconfigured\n");
7329 return -EINVAL;
7330 }
17a52670 7331
17a52670
AS
7332 return 0;
7333}
7334
96be4325
DB
7335static bool may_access_skb(enum bpf_prog_type type)
7336{
7337 switch (type) {
7338 case BPF_PROG_TYPE_SOCKET_FILTER:
7339 case BPF_PROG_TYPE_SCHED_CLS:
94caee8c 7340 case BPF_PROG_TYPE_SCHED_ACT:
96be4325
DB
7341 return true;
7342 default:
7343 return false;
7344 }
7345}
7346
ddd872bc
AS
7347/* verify safety of LD_ABS|LD_IND instructions:
7348 * - they can only appear in the programs where ctx == skb
7349 * - since they are wrappers of function calls, they scratch R1-R5 registers,
7350 * preserve R6-R9, and store return value into R0
7351 *
7352 * Implicit input:
7353 * ctx == skb == R6 == CTX
7354 *
7355 * Explicit input:
7356 * SRC == any register
7357 * IMM == 32-bit immediate
7358 *
7359 * Output:
7360 * R0 - 8/16/32-bit skb data converted to cpu endianness
7361 */
58e2af8b 7362static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
ddd872bc 7363{
638f5b90 7364 struct bpf_reg_state *regs = cur_regs(env);
6d4f151a 7365 static const int ctx_reg = BPF_REG_6;
ddd872bc 7366 u8 mode = BPF_MODE(insn->code);
ddd872bc
AS
7367 int i, err;
7368
24701ece 7369 if (!may_access_skb(env->prog->type)) {
61bd5218 7370 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
ddd872bc
AS
7371 return -EINVAL;
7372 }
7373
e0cea7ce
DB
7374 if (!env->ops->gen_ld_abs) {
7375 verbose(env, "bpf verifier is misconfigured\n");
7376 return -EINVAL;
7377 }
7378
f910cefa 7379 if (env->subprog_cnt > 1) {
f4d7e40a
AS
7380 /* when program has LD_ABS insn JITs and interpreter assume
7381 * that r1 == ctx == skb which is not the case for callees
7382 * that can have arbitrary arguments. It's problematic
7383 * for main prog as well since JITs would need to analyze
7384 * all functions in order to make proper register save/restore
7385 * decisions in the main prog. Hence disallow LD_ABS with calls
7386 */
7387 verbose(env, "BPF_LD_[ABS|IND] instructions cannot be mixed with bpf-to-bpf calls\n");
7388 return -EINVAL;
7389 }
7390
ddd872bc 7391 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
d82bccc6 7392 BPF_SIZE(insn->code) == BPF_DW ||
ddd872bc 7393 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
61bd5218 7394 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
ddd872bc
AS
7395 return -EINVAL;
7396 }
7397
7398 /* check whether implicit source operand (register R6) is readable */
6d4f151a 7399 err = check_reg_arg(env, ctx_reg, SRC_OP);
ddd872bc
AS
7400 if (err)
7401 return err;
7402
fd978bf7
JS
7403 /* Disallow usage of BPF_LD_[ABS|IND] with reference tracking, as
7404 * gen_ld_abs() may terminate the program at runtime, leading to
7405 * reference leak.
7406 */
7407 err = check_reference_leak(env);
7408 if (err) {
7409 verbose(env, "BPF_LD_[ABS|IND] cannot be mixed with socket references\n");
7410 return err;
7411 }
7412
d83525ca
AS
7413 if (env->cur_state->active_spin_lock) {
7414 verbose(env, "BPF_LD_[ABS|IND] cannot be used inside bpf_spin_lock-ed region\n");
7415 return -EINVAL;
7416 }
7417
6d4f151a 7418 if (regs[ctx_reg].type != PTR_TO_CTX) {
61bd5218
JK
7419 verbose(env,
7420 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
ddd872bc
AS
7421 return -EINVAL;
7422 }
7423
7424 if (mode == BPF_IND) {
7425 /* check explicit source operand */
dc503a8a 7426 err = check_reg_arg(env, insn->src_reg, SRC_OP);
ddd872bc
AS
7427 if (err)
7428 return err;
7429 }
7430
6d4f151a
DB
7431 err = check_ctx_reg(env, &regs[ctx_reg], ctx_reg);
7432 if (err < 0)
7433 return err;
7434
ddd872bc 7435 /* reset caller saved regs to unreadable */
dc503a8a 7436 for (i = 0; i < CALLER_SAVED_REGS; i++) {
61bd5218 7437 mark_reg_not_init(env, regs, caller_saved[i]);
dc503a8a
EC
7438 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
7439 }
ddd872bc
AS
7440
7441 /* mark destination R0 register as readable, since it contains
dc503a8a
EC
7442 * the value fetched from the packet.
7443 * Already marked as written above.
ddd872bc 7444 */
61bd5218 7445 mark_reg_unknown(env, regs, BPF_REG_0);
5327ed3d
JW
7446 /* ld_abs load up to 32-bit skb data. */
7447 regs[BPF_REG_0].subreg_def = env->insn_idx + 1;
ddd872bc
AS
7448 return 0;
7449}
7450
390ee7e2
AS
7451static int check_return_code(struct bpf_verifier_env *env)
7452{
5cf1e914 7453 struct tnum enforce_attach_type_range = tnum_unknown;
27ae7997 7454 const struct bpf_prog *prog = env->prog;
390ee7e2
AS
7455 struct bpf_reg_state *reg;
7456 struct tnum range = tnum_range(0, 1);
27ae7997
MKL
7457 int err;
7458
9e4e01df
KS
7459 /* LSM and struct_ops func-ptr's return type could be "void" */
7460 if ((env->prog->type == BPF_PROG_TYPE_STRUCT_OPS ||
7461 env->prog->type == BPF_PROG_TYPE_LSM) &&
27ae7997
MKL
7462 !prog->aux->attach_func_proto->type)
7463 return 0;
7464
7465 /* eBPF calling convetion is such that R0 is used
7466 * to return the value from eBPF program.
7467 * Make sure that it's readable at this time
7468 * of bpf_exit, which means that program wrote
7469 * something into it earlier
7470 */
7471 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
7472 if (err)
7473 return err;
7474
7475 if (is_pointer_value(env, BPF_REG_0)) {
7476 verbose(env, "R0 leaks addr as return value\n");
7477 return -EACCES;
7478 }
390ee7e2
AS
7479
7480 switch (env->prog->type) {
983695fa
DB
7481 case BPF_PROG_TYPE_CGROUP_SOCK_ADDR:
7482 if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG ||
1b66d253
DB
7483 env->prog->expected_attach_type == BPF_CGROUP_UDP6_RECVMSG ||
7484 env->prog->expected_attach_type == BPF_CGROUP_INET4_GETPEERNAME ||
7485 env->prog->expected_attach_type == BPF_CGROUP_INET6_GETPEERNAME ||
7486 env->prog->expected_attach_type == BPF_CGROUP_INET4_GETSOCKNAME ||
7487 env->prog->expected_attach_type == BPF_CGROUP_INET6_GETSOCKNAME)
983695fa 7488 range = tnum_range(1, 1);
ed4ed404 7489 break;
390ee7e2 7490 case BPF_PROG_TYPE_CGROUP_SKB:
5cf1e914 7491 if (env->prog->expected_attach_type == BPF_CGROUP_INET_EGRESS) {
7492 range = tnum_range(0, 3);
7493 enforce_attach_type_range = tnum_range(2, 3);
7494 }
ed4ed404 7495 break;
390ee7e2
AS
7496 case BPF_PROG_TYPE_CGROUP_SOCK:
7497 case BPF_PROG_TYPE_SOCK_OPS:
ebc614f6 7498 case BPF_PROG_TYPE_CGROUP_DEVICE:
7b146ceb 7499 case BPF_PROG_TYPE_CGROUP_SYSCTL:
0d01da6a 7500 case BPF_PROG_TYPE_CGROUP_SOCKOPT:
390ee7e2 7501 break;
15ab09bd
AS
7502 case BPF_PROG_TYPE_RAW_TRACEPOINT:
7503 if (!env->prog->aux->attach_btf_id)
7504 return 0;
7505 range = tnum_const(0);
7506 break;
15d83c4d 7507 case BPF_PROG_TYPE_TRACING:
e92888c7
YS
7508 switch (env->prog->expected_attach_type) {
7509 case BPF_TRACE_FENTRY:
7510 case BPF_TRACE_FEXIT:
7511 range = tnum_const(0);
7512 break;
7513 case BPF_TRACE_RAW_TP:
7514 case BPF_MODIFY_RETURN:
15d83c4d 7515 return 0;
2ec0616e
DB
7516 case BPF_TRACE_ITER:
7517 break;
e92888c7
YS
7518 default:
7519 return -ENOTSUPP;
7520 }
15d83c4d 7521 break;
e9ddbb77
JS
7522 case BPF_PROG_TYPE_SK_LOOKUP:
7523 range = tnum_range(SK_DROP, SK_PASS);
7524 break;
e92888c7
YS
7525 case BPF_PROG_TYPE_EXT:
7526 /* freplace program can return anything as its return value
7527 * depends on the to-be-replaced kernel func or bpf program.
7528 */
390ee7e2
AS
7529 default:
7530 return 0;
7531 }
7532
638f5b90 7533 reg = cur_regs(env) + BPF_REG_0;
390ee7e2 7534 if (reg->type != SCALAR_VALUE) {
61bd5218 7535 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
390ee7e2
AS
7536 reg_type_str[reg->type]);
7537 return -EINVAL;
7538 }
7539
7540 if (!tnum_in(range, reg->var_off)) {
5cf1e914 7541 char tn_buf[48];
7542
61bd5218 7543 verbose(env, "At program exit the register R0 ");
390ee7e2 7544 if (!tnum_is_unknown(reg->var_off)) {
390ee7e2 7545 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
61bd5218 7546 verbose(env, "has value %s", tn_buf);
390ee7e2 7547 } else {
61bd5218 7548 verbose(env, "has unknown scalar value");
390ee7e2 7549 }
5cf1e914 7550 tnum_strn(tn_buf, sizeof(tn_buf), range);
983695fa 7551 verbose(env, " should have been in %s\n", tn_buf);
390ee7e2
AS
7552 return -EINVAL;
7553 }
5cf1e914 7554
7555 if (!tnum_is_unknown(enforce_attach_type_range) &&
7556 tnum_in(enforce_attach_type_range, reg->var_off))
7557 env->prog->enforce_expected_attach_type = 1;
390ee7e2
AS
7558 return 0;
7559}
7560
475fb78f
AS
7561/* non-recursive DFS pseudo code
7562 * 1 procedure DFS-iterative(G,v):
7563 * 2 label v as discovered
7564 * 3 let S be a stack
7565 * 4 S.push(v)
7566 * 5 while S is not empty
7567 * 6 t <- S.pop()
7568 * 7 if t is what we're looking for:
7569 * 8 return t
7570 * 9 for all edges e in G.adjacentEdges(t) do
7571 * 10 if edge e is already labelled
7572 * 11 continue with the next edge
7573 * 12 w <- G.adjacentVertex(t,e)
7574 * 13 if vertex w is not discovered and not explored
7575 * 14 label e as tree-edge
7576 * 15 label w as discovered
7577 * 16 S.push(w)
7578 * 17 continue at 5
7579 * 18 else if vertex w is discovered
7580 * 19 label e as back-edge
7581 * 20 else
7582 * 21 // vertex w is explored
7583 * 22 label e as forward- or cross-edge
7584 * 23 label t as explored
7585 * 24 S.pop()
7586 *
7587 * convention:
7588 * 0x10 - discovered
7589 * 0x11 - discovered and fall-through edge labelled
7590 * 0x12 - discovered and fall-through and branch edges labelled
7591 * 0x20 - explored
7592 */
7593
7594enum {
7595 DISCOVERED = 0x10,
7596 EXPLORED = 0x20,
7597 FALLTHROUGH = 1,
7598 BRANCH = 2,
7599};
7600
dc2a4ebc
AS
7601static u32 state_htab_size(struct bpf_verifier_env *env)
7602{
7603 return env->prog->len;
7604}
7605
5d839021
AS
7606static struct bpf_verifier_state_list **explored_state(
7607 struct bpf_verifier_env *env,
7608 int idx)
7609{
dc2a4ebc
AS
7610 struct bpf_verifier_state *cur = env->cur_state;
7611 struct bpf_func_state *state = cur->frame[cur->curframe];
7612
7613 return &env->explored_states[(idx ^ state->callsite) % state_htab_size(env)];
5d839021
AS
7614}
7615
7616static void init_explored_state(struct bpf_verifier_env *env, int idx)
7617{
a8f500af 7618 env->insn_aux_data[idx].prune_point = true;
5d839021 7619}
f1bca824 7620
475fb78f
AS
7621/* t, w, e - match pseudo-code above:
7622 * t - index of current instruction
7623 * w - next instruction
7624 * e - edge
7625 */
2589726d
AS
7626static int push_insn(int t, int w, int e, struct bpf_verifier_env *env,
7627 bool loop_ok)
475fb78f 7628{
7df737e9
AS
7629 int *insn_stack = env->cfg.insn_stack;
7630 int *insn_state = env->cfg.insn_state;
7631
475fb78f
AS
7632 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
7633 return 0;
7634
7635 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
7636 return 0;
7637
7638 if (w < 0 || w >= env->prog->len) {
d9762e84 7639 verbose_linfo(env, t, "%d: ", t);
61bd5218 7640 verbose(env, "jump out of range from insn %d to %d\n", t, w);
475fb78f
AS
7641 return -EINVAL;
7642 }
7643
f1bca824
AS
7644 if (e == BRANCH)
7645 /* mark branch target for state pruning */
5d839021 7646 init_explored_state(env, w);
f1bca824 7647
475fb78f
AS
7648 if (insn_state[w] == 0) {
7649 /* tree-edge */
7650 insn_state[t] = DISCOVERED | e;
7651 insn_state[w] = DISCOVERED;
7df737e9 7652 if (env->cfg.cur_stack >= env->prog->len)
475fb78f 7653 return -E2BIG;
7df737e9 7654 insn_stack[env->cfg.cur_stack++] = w;
475fb78f
AS
7655 return 1;
7656 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
2c78ee89 7657 if (loop_ok && env->bpf_capable)
2589726d 7658 return 0;
d9762e84
MKL
7659 verbose_linfo(env, t, "%d: ", t);
7660 verbose_linfo(env, w, "%d: ", w);
61bd5218 7661 verbose(env, "back-edge from insn %d to %d\n", t, w);
475fb78f
AS
7662 return -EINVAL;
7663 } else if (insn_state[w] == EXPLORED) {
7664 /* forward- or cross-edge */
7665 insn_state[t] = DISCOVERED | e;
7666 } else {
61bd5218 7667 verbose(env, "insn state internal bug\n");
475fb78f
AS
7668 return -EFAULT;
7669 }
7670 return 0;
7671}
7672
7673/* non-recursive depth-first-search to detect loops in BPF program
7674 * loop == back-edge in directed graph
7675 */
58e2af8b 7676static int check_cfg(struct bpf_verifier_env *env)
475fb78f
AS
7677{
7678 struct bpf_insn *insns = env->prog->insnsi;
7679 int insn_cnt = env->prog->len;
7df737e9 7680 int *insn_stack, *insn_state;
475fb78f
AS
7681 int ret = 0;
7682 int i, t;
7683
7df737e9 7684 insn_state = env->cfg.insn_state = kvcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
475fb78f
AS
7685 if (!insn_state)
7686 return -ENOMEM;
7687
7df737e9 7688 insn_stack = env->cfg.insn_stack = kvcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
475fb78f 7689 if (!insn_stack) {
71dde681 7690 kvfree(insn_state);
475fb78f
AS
7691 return -ENOMEM;
7692 }
7693
7694 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
7695 insn_stack[0] = 0; /* 0 is the first instruction */
7df737e9 7696 env->cfg.cur_stack = 1;
475fb78f
AS
7697
7698peek_stack:
7df737e9 7699 if (env->cfg.cur_stack == 0)
475fb78f 7700 goto check_state;
7df737e9 7701 t = insn_stack[env->cfg.cur_stack - 1];
475fb78f 7702
092ed096
JW
7703 if (BPF_CLASS(insns[t].code) == BPF_JMP ||
7704 BPF_CLASS(insns[t].code) == BPF_JMP32) {
475fb78f
AS
7705 u8 opcode = BPF_OP(insns[t].code);
7706
7707 if (opcode == BPF_EXIT) {
7708 goto mark_explored;
7709 } else if (opcode == BPF_CALL) {
2589726d 7710 ret = push_insn(t, t + 1, FALLTHROUGH, env, false);
475fb78f
AS
7711 if (ret == 1)
7712 goto peek_stack;
7713 else if (ret < 0)
7714 goto err_free;
07016151 7715 if (t + 1 < insn_cnt)
5d839021 7716 init_explored_state(env, t + 1);
cc8b0b92 7717 if (insns[t].src_reg == BPF_PSEUDO_CALL) {
5d839021 7718 init_explored_state(env, t);
2589726d
AS
7719 ret = push_insn(t, t + insns[t].imm + 1, BRANCH,
7720 env, false);
cc8b0b92
AS
7721 if (ret == 1)
7722 goto peek_stack;
7723 else if (ret < 0)
7724 goto err_free;
7725 }
475fb78f
AS
7726 } else if (opcode == BPF_JA) {
7727 if (BPF_SRC(insns[t].code) != BPF_K) {
7728 ret = -EINVAL;
7729 goto err_free;
7730 }
7731 /* unconditional jump with single edge */
7732 ret = push_insn(t, t + insns[t].off + 1,
2589726d 7733 FALLTHROUGH, env, true);
475fb78f
AS
7734 if (ret == 1)
7735 goto peek_stack;
7736 else if (ret < 0)
7737 goto err_free;
b5dc0163
AS
7738 /* unconditional jmp is not a good pruning point,
7739 * but it's marked, since backtracking needs
7740 * to record jmp history in is_state_visited().
7741 */
7742 init_explored_state(env, t + insns[t].off + 1);
f1bca824
AS
7743 /* tell verifier to check for equivalent states
7744 * after every call and jump
7745 */
c3de6317 7746 if (t + 1 < insn_cnt)
5d839021 7747 init_explored_state(env, t + 1);
475fb78f
AS
7748 } else {
7749 /* conditional jump with two edges */
5d839021 7750 init_explored_state(env, t);
2589726d 7751 ret = push_insn(t, t + 1, FALLTHROUGH, env, true);
475fb78f
AS
7752 if (ret == 1)
7753 goto peek_stack;
7754 else if (ret < 0)
7755 goto err_free;
7756
2589726d 7757 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env, true);
475fb78f
AS
7758 if (ret == 1)
7759 goto peek_stack;
7760 else if (ret < 0)
7761 goto err_free;
7762 }
7763 } else {
7764 /* all other non-branch instructions with single
7765 * fall-through edge
7766 */
2589726d 7767 ret = push_insn(t, t + 1, FALLTHROUGH, env, false);
475fb78f
AS
7768 if (ret == 1)
7769 goto peek_stack;
7770 else if (ret < 0)
7771 goto err_free;
7772 }
7773
7774mark_explored:
7775 insn_state[t] = EXPLORED;
7df737e9 7776 if (env->cfg.cur_stack-- <= 0) {
61bd5218 7777 verbose(env, "pop stack internal bug\n");
475fb78f
AS
7778 ret = -EFAULT;
7779 goto err_free;
7780 }
7781 goto peek_stack;
7782
7783check_state:
7784 for (i = 0; i < insn_cnt; i++) {
7785 if (insn_state[i] != EXPLORED) {
61bd5218 7786 verbose(env, "unreachable insn %d\n", i);
475fb78f
AS
7787 ret = -EINVAL;
7788 goto err_free;
7789 }
7790 }
7791 ret = 0; /* cfg looks good */
7792
7793err_free:
71dde681
AS
7794 kvfree(insn_state);
7795 kvfree(insn_stack);
7df737e9 7796 env->cfg.insn_state = env->cfg.insn_stack = NULL;
475fb78f
AS
7797 return ret;
7798}
7799
838e9690
YS
7800/* The minimum supported BTF func info size */
7801#define MIN_BPF_FUNCINFO_SIZE 8
7802#define MAX_FUNCINFO_REC_SIZE 252
7803
c454a46b
MKL
7804static int check_btf_func(struct bpf_verifier_env *env,
7805 const union bpf_attr *attr,
7806 union bpf_attr __user *uattr)
838e9690 7807{
d0b2818e 7808 u32 i, nfuncs, urec_size, min_size;
838e9690 7809 u32 krec_size = sizeof(struct bpf_func_info);
c454a46b 7810 struct bpf_func_info *krecord;
8c1b6e69 7811 struct bpf_func_info_aux *info_aux = NULL;
838e9690 7812 const struct btf_type *type;
c454a46b
MKL
7813 struct bpf_prog *prog;
7814 const struct btf *btf;
838e9690 7815 void __user *urecord;
d0b2818e 7816 u32 prev_offset = 0;
e7ed83d6 7817 int ret = -ENOMEM;
838e9690
YS
7818
7819 nfuncs = attr->func_info_cnt;
7820 if (!nfuncs)
7821 return 0;
7822
7823 if (nfuncs != env->subprog_cnt) {
7824 verbose(env, "number of funcs in func_info doesn't match number of subprogs\n");
7825 return -EINVAL;
7826 }
7827
7828 urec_size = attr->func_info_rec_size;
7829 if (urec_size < MIN_BPF_FUNCINFO_SIZE ||
7830 urec_size > MAX_FUNCINFO_REC_SIZE ||
7831 urec_size % sizeof(u32)) {
7832 verbose(env, "invalid func info rec size %u\n", urec_size);
7833 return -EINVAL;
7834 }
7835
c454a46b
MKL
7836 prog = env->prog;
7837 btf = prog->aux->btf;
838e9690
YS
7838
7839 urecord = u64_to_user_ptr(attr->func_info);
7840 min_size = min_t(u32, krec_size, urec_size);
7841
ba64e7d8 7842 krecord = kvcalloc(nfuncs, krec_size, GFP_KERNEL | __GFP_NOWARN);
c454a46b
MKL
7843 if (!krecord)
7844 return -ENOMEM;
8c1b6e69
AS
7845 info_aux = kcalloc(nfuncs, sizeof(*info_aux), GFP_KERNEL | __GFP_NOWARN);
7846 if (!info_aux)
7847 goto err_free;
ba64e7d8 7848
838e9690
YS
7849 for (i = 0; i < nfuncs; i++) {
7850 ret = bpf_check_uarg_tail_zero(urecord, krec_size, urec_size);
7851 if (ret) {
7852 if (ret == -E2BIG) {
7853 verbose(env, "nonzero tailing record in func info");
7854 /* set the size kernel expects so loader can zero
7855 * out the rest of the record.
7856 */
7857 if (put_user(min_size, &uattr->func_info_rec_size))
7858 ret = -EFAULT;
7859 }
c454a46b 7860 goto err_free;
838e9690
YS
7861 }
7862
ba64e7d8 7863 if (copy_from_user(&krecord[i], urecord, min_size)) {
838e9690 7864 ret = -EFAULT;
c454a46b 7865 goto err_free;
838e9690
YS
7866 }
7867
d30d42e0 7868 /* check insn_off */
838e9690 7869 if (i == 0) {
d30d42e0 7870 if (krecord[i].insn_off) {
838e9690 7871 verbose(env,
d30d42e0
MKL
7872 "nonzero insn_off %u for the first func info record",
7873 krecord[i].insn_off);
838e9690 7874 ret = -EINVAL;
c454a46b 7875 goto err_free;
838e9690 7876 }
d30d42e0 7877 } else if (krecord[i].insn_off <= prev_offset) {
838e9690
YS
7878 verbose(env,
7879 "same or smaller insn offset (%u) than previous func info record (%u)",
d30d42e0 7880 krecord[i].insn_off, prev_offset);
838e9690 7881 ret = -EINVAL;
c454a46b 7882 goto err_free;
838e9690
YS
7883 }
7884
d30d42e0 7885 if (env->subprog_info[i].start != krecord[i].insn_off) {
838e9690
YS
7886 verbose(env, "func_info BTF section doesn't match subprog layout in BPF program\n");
7887 ret = -EINVAL;
c454a46b 7888 goto err_free;
838e9690
YS
7889 }
7890
7891 /* check type_id */
ba64e7d8 7892 type = btf_type_by_id(btf, krecord[i].type_id);
51c39bb1 7893 if (!type || !btf_type_is_func(type)) {
838e9690 7894 verbose(env, "invalid type id %d in func info",
ba64e7d8 7895 krecord[i].type_id);
838e9690 7896 ret = -EINVAL;
c454a46b 7897 goto err_free;
838e9690 7898 }
51c39bb1 7899 info_aux[i].linkage = BTF_INFO_VLEN(type->info);
d30d42e0 7900 prev_offset = krecord[i].insn_off;
838e9690
YS
7901 urecord += urec_size;
7902 }
7903
ba64e7d8
YS
7904 prog->aux->func_info = krecord;
7905 prog->aux->func_info_cnt = nfuncs;
8c1b6e69 7906 prog->aux->func_info_aux = info_aux;
838e9690
YS
7907 return 0;
7908
c454a46b 7909err_free:
ba64e7d8 7910 kvfree(krecord);
8c1b6e69 7911 kfree(info_aux);
838e9690
YS
7912 return ret;
7913}
7914
ba64e7d8
YS
7915static void adjust_btf_func(struct bpf_verifier_env *env)
7916{
8c1b6e69 7917 struct bpf_prog_aux *aux = env->prog->aux;
ba64e7d8
YS
7918 int i;
7919
8c1b6e69 7920 if (!aux->func_info)
ba64e7d8
YS
7921 return;
7922
7923 for (i = 0; i < env->subprog_cnt; i++)
8c1b6e69 7924 aux->func_info[i].insn_off = env->subprog_info[i].start;
ba64e7d8
YS
7925}
7926
c454a46b
MKL
7927#define MIN_BPF_LINEINFO_SIZE (offsetof(struct bpf_line_info, line_col) + \
7928 sizeof(((struct bpf_line_info *)(0))->line_col))
7929#define MAX_LINEINFO_REC_SIZE MAX_FUNCINFO_REC_SIZE
7930
7931static int check_btf_line(struct bpf_verifier_env *env,
7932 const union bpf_attr *attr,
7933 union bpf_attr __user *uattr)
7934{
7935 u32 i, s, nr_linfo, ncopy, expected_size, rec_size, prev_offset = 0;
7936 struct bpf_subprog_info *sub;
7937 struct bpf_line_info *linfo;
7938 struct bpf_prog *prog;
7939 const struct btf *btf;
7940 void __user *ulinfo;
7941 int err;
7942
7943 nr_linfo = attr->line_info_cnt;
7944 if (!nr_linfo)
7945 return 0;
7946
7947 rec_size = attr->line_info_rec_size;
7948 if (rec_size < MIN_BPF_LINEINFO_SIZE ||
7949 rec_size > MAX_LINEINFO_REC_SIZE ||
7950 rec_size & (sizeof(u32) - 1))
7951 return -EINVAL;
7952
7953 /* Need to zero it in case the userspace may
7954 * pass in a smaller bpf_line_info object.
7955 */
7956 linfo = kvcalloc(nr_linfo, sizeof(struct bpf_line_info),
7957 GFP_KERNEL | __GFP_NOWARN);
7958 if (!linfo)
7959 return -ENOMEM;
7960
7961 prog = env->prog;
7962 btf = prog->aux->btf;
7963
7964 s = 0;
7965 sub = env->subprog_info;
7966 ulinfo = u64_to_user_ptr(attr->line_info);
7967 expected_size = sizeof(struct bpf_line_info);
7968 ncopy = min_t(u32, expected_size, rec_size);
7969 for (i = 0; i < nr_linfo; i++) {
7970 err = bpf_check_uarg_tail_zero(ulinfo, expected_size, rec_size);
7971 if (err) {
7972 if (err == -E2BIG) {
7973 verbose(env, "nonzero tailing record in line_info");
7974 if (put_user(expected_size,
7975 &uattr->line_info_rec_size))
7976 err = -EFAULT;
7977 }
7978 goto err_free;
7979 }
7980
7981 if (copy_from_user(&linfo[i], ulinfo, ncopy)) {
7982 err = -EFAULT;
7983 goto err_free;
7984 }
7985
7986 /*
7987 * Check insn_off to ensure
7988 * 1) strictly increasing AND
7989 * 2) bounded by prog->len
7990 *
7991 * The linfo[0].insn_off == 0 check logically falls into
7992 * the later "missing bpf_line_info for func..." case
7993 * because the first linfo[0].insn_off must be the
7994 * first sub also and the first sub must have
7995 * subprog_info[0].start == 0.
7996 */
7997 if ((i && linfo[i].insn_off <= prev_offset) ||
7998 linfo[i].insn_off >= prog->len) {
7999 verbose(env, "Invalid line_info[%u].insn_off:%u (prev_offset:%u prog->len:%u)\n",
8000 i, linfo[i].insn_off, prev_offset,
8001 prog->len);
8002 err = -EINVAL;
8003 goto err_free;
8004 }
8005
fdbaa0be
MKL
8006 if (!prog->insnsi[linfo[i].insn_off].code) {
8007 verbose(env,
8008 "Invalid insn code at line_info[%u].insn_off\n",
8009 i);
8010 err = -EINVAL;
8011 goto err_free;
8012 }
8013
23127b33
MKL
8014 if (!btf_name_by_offset(btf, linfo[i].line_off) ||
8015 !btf_name_by_offset(btf, linfo[i].file_name_off)) {
c454a46b
MKL
8016 verbose(env, "Invalid line_info[%u].line_off or .file_name_off\n", i);
8017 err = -EINVAL;
8018 goto err_free;
8019 }
8020
8021 if (s != env->subprog_cnt) {
8022 if (linfo[i].insn_off == sub[s].start) {
8023 sub[s].linfo_idx = i;
8024 s++;
8025 } else if (sub[s].start < linfo[i].insn_off) {
8026 verbose(env, "missing bpf_line_info for func#%u\n", s);
8027 err = -EINVAL;
8028 goto err_free;
8029 }
8030 }
8031
8032 prev_offset = linfo[i].insn_off;
8033 ulinfo += rec_size;
8034 }
8035
8036 if (s != env->subprog_cnt) {
8037 verbose(env, "missing bpf_line_info for %u funcs starting from func#%u\n",
8038 env->subprog_cnt - s, s);
8039 err = -EINVAL;
8040 goto err_free;
8041 }
8042
8043 prog->aux->linfo = linfo;
8044 prog->aux->nr_linfo = nr_linfo;
8045
8046 return 0;
8047
8048err_free:
8049 kvfree(linfo);
8050 return err;
8051}
8052
8053static int check_btf_info(struct bpf_verifier_env *env,
8054 const union bpf_attr *attr,
8055 union bpf_attr __user *uattr)
8056{
8057 struct btf *btf;
8058 int err;
8059
8060 if (!attr->func_info_cnt && !attr->line_info_cnt)
8061 return 0;
8062
8063 btf = btf_get_by_fd(attr->prog_btf_fd);
8064 if (IS_ERR(btf))
8065 return PTR_ERR(btf);
8066 env->prog->aux->btf = btf;
8067
8068 err = check_btf_func(env, attr, uattr);
8069 if (err)
8070 return err;
8071
8072 err = check_btf_line(env, attr, uattr);
8073 if (err)
8074 return err;
8075
8076 return 0;
ba64e7d8
YS
8077}
8078
f1174f77
EC
8079/* check %cur's range satisfies %old's */
8080static bool range_within(struct bpf_reg_state *old,
8081 struct bpf_reg_state *cur)
8082{
b03c9f9f
EC
8083 return old->umin_value <= cur->umin_value &&
8084 old->umax_value >= cur->umax_value &&
8085 old->smin_value <= cur->smin_value &&
8086 old->smax_value >= cur->smax_value;
f1174f77
EC
8087}
8088
8089/* Maximum number of register states that can exist at once */
8090#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
8091struct idpair {
8092 u32 old;
8093 u32 cur;
8094};
8095
8096/* If in the old state two registers had the same id, then they need to have
8097 * the same id in the new state as well. But that id could be different from
8098 * the old state, so we need to track the mapping from old to new ids.
8099 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
8100 * regs with old id 5 must also have new id 9 for the new state to be safe. But
8101 * regs with a different old id could still have new id 9, we don't care about
8102 * that.
8103 * So we look through our idmap to see if this old id has been seen before. If
8104 * so, we require the new id to match; otherwise, we add the id pair to the map.
969bf05e 8105 */
f1174f77 8106static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
969bf05e 8107{
f1174f77 8108 unsigned int i;
969bf05e 8109
f1174f77
EC
8110 for (i = 0; i < ID_MAP_SIZE; i++) {
8111 if (!idmap[i].old) {
8112 /* Reached an empty slot; haven't seen this id before */
8113 idmap[i].old = old_id;
8114 idmap[i].cur = cur_id;
8115 return true;
8116 }
8117 if (idmap[i].old == old_id)
8118 return idmap[i].cur == cur_id;
8119 }
8120 /* We ran out of idmap slots, which should be impossible */
8121 WARN_ON_ONCE(1);
8122 return false;
8123}
8124
9242b5f5
AS
8125static void clean_func_state(struct bpf_verifier_env *env,
8126 struct bpf_func_state *st)
8127{
8128 enum bpf_reg_liveness live;
8129 int i, j;
8130
8131 for (i = 0; i < BPF_REG_FP; i++) {
8132 live = st->regs[i].live;
8133 /* liveness must not touch this register anymore */
8134 st->regs[i].live |= REG_LIVE_DONE;
8135 if (!(live & REG_LIVE_READ))
8136 /* since the register is unused, clear its state
8137 * to make further comparison simpler
8138 */
f54c7898 8139 __mark_reg_not_init(env, &st->regs[i]);
9242b5f5
AS
8140 }
8141
8142 for (i = 0; i < st->allocated_stack / BPF_REG_SIZE; i++) {
8143 live = st->stack[i].spilled_ptr.live;
8144 /* liveness must not touch this stack slot anymore */
8145 st->stack[i].spilled_ptr.live |= REG_LIVE_DONE;
8146 if (!(live & REG_LIVE_READ)) {
f54c7898 8147 __mark_reg_not_init(env, &st->stack[i].spilled_ptr);
9242b5f5
AS
8148 for (j = 0; j < BPF_REG_SIZE; j++)
8149 st->stack[i].slot_type[j] = STACK_INVALID;
8150 }
8151 }
8152}
8153
8154static void clean_verifier_state(struct bpf_verifier_env *env,
8155 struct bpf_verifier_state *st)
8156{
8157 int i;
8158
8159 if (st->frame[0]->regs[0].live & REG_LIVE_DONE)
8160 /* all regs in this state in all frames were already marked */
8161 return;
8162
8163 for (i = 0; i <= st->curframe; i++)
8164 clean_func_state(env, st->frame[i]);
8165}
8166
8167/* the parentage chains form a tree.
8168 * the verifier states are added to state lists at given insn and
8169 * pushed into state stack for future exploration.
8170 * when the verifier reaches bpf_exit insn some of the verifer states
8171 * stored in the state lists have their final liveness state already,
8172 * but a lot of states will get revised from liveness point of view when
8173 * the verifier explores other branches.
8174 * Example:
8175 * 1: r0 = 1
8176 * 2: if r1 == 100 goto pc+1
8177 * 3: r0 = 2
8178 * 4: exit
8179 * when the verifier reaches exit insn the register r0 in the state list of
8180 * insn 2 will be seen as !REG_LIVE_READ. Then the verifier pops the other_branch
8181 * of insn 2 and goes exploring further. At the insn 4 it will walk the
8182 * parentage chain from insn 4 into insn 2 and will mark r0 as REG_LIVE_READ.
8183 *
8184 * Since the verifier pushes the branch states as it sees them while exploring
8185 * the program the condition of walking the branch instruction for the second
8186 * time means that all states below this branch were already explored and
8187 * their final liveness markes are already propagated.
8188 * Hence when the verifier completes the search of state list in is_state_visited()
8189 * we can call this clean_live_states() function to mark all liveness states
8190 * as REG_LIVE_DONE to indicate that 'parent' pointers of 'struct bpf_reg_state'
8191 * will not be used.
8192 * This function also clears the registers and stack for states that !READ
8193 * to simplify state merging.
8194 *
8195 * Important note here that walking the same branch instruction in the callee
8196 * doesn't meant that the states are DONE. The verifier has to compare
8197 * the callsites
8198 */
8199static void clean_live_states(struct bpf_verifier_env *env, int insn,
8200 struct bpf_verifier_state *cur)
8201{
8202 struct bpf_verifier_state_list *sl;
8203 int i;
8204
5d839021 8205 sl = *explored_state(env, insn);
a8f500af 8206 while (sl) {
2589726d
AS
8207 if (sl->state.branches)
8208 goto next;
dc2a4ebc
AS
8209 if (sl->state.insn_idx != insn ||
8210 sl->state.curframe != cur->curframe)
9242b5f5
AS
8211 goto next;
8212 for (i = 0; i <= cur->curframe; i++)
8213 if (sl->state.frame[i]->callsite != cur->frame[i]->callsite)
8214 goto next;
8215 clean_verifier_state(env, &sl->state);
8216next:
8217 sl = sl->next;
8218 }
8219}
8220
f1174f77 8221/* Returns true if (rold safe implies rcur safe) */
1b688a19
EC
8222static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
8223 struct idpair *idmap)
f1174f77 8224{
f4d7e40a
AS
8225 bool equal;
8226
dc503a8a
EC
8227 if (!(rold->live & REG_LIVE_READ))
8228 /* explored state didn't use this */
8229 return true;
8230
679c782d 8231 equal = memcmp(rold, rcur, offsetof(struct bpf_reg_state, parent)) == 0;
f4d7e40a
AS
8232
8233 if (rold->type == PTR_TO_STACK)
8234 /* two stack pointers are equal only if they're pointing to
8235 * the same stack frame, since fp-8 in foo != fp-8 in bar
8236 */
8237 return equal && rold->frameno == rcur->frameno;
8238
8239 if (equal)
969bf05e
AS
8240 return true;
8241
f1174f77
EC
8242 if (rold->type == NOT_INIT)
8243 /* explored state can't have used this */
969bf05e 8244 return true;
f1174f77
EC
8245 if (rcur->type == NOT_INIT)
8246 return false;
8247 switch (rold->type) {
8248 case SCALAR_VALUE:
8249 if (rcur->type == SCALAR_VALUE) {
b5dc0163
AS
8250 if (!rold->precise && !rcur->precise)
8251 return true;
f1174f77
EC
8252 /* new val must satisfy old val knowledge */
8253 return range_within(rold, rcur) &&
8254 tnum_in(rold->var_off, rcur->var_off);
8255 } else {
179d1c56
JH
8256 /* We're trying to use a pointer in place of a scalar.
8257 * Even if the scalar was unbounded, this could lead to
8258 * pointer leaks because scalars are allowed to leak
8259 * while pointers are not. We could make this safe in
8260 * special cases if root is calling us, but it's
8261 * probably not worth the hassle.
f1174f77 8262 */
179d1c56 8263 return false;
f1174f77
EC
8264 }
8265 case PTR_TO_MAP_VALUE:
1b688a19
EC
8266 /* If the new min/max/var_off satisfy the old ones and
8267 * everything else matches, we are OK.
d83525ca
AS
8268 * 'id' is not compared, since it's only used for maps with
8269 * bpf_spin_lock inside map element and in such cases if
8270 * the rest of the prog is valid for one map element then
8271 * it's valid for all map elements regardless of the key
8272 * used in bpf_map_lookup()
1b688a19
EC
8273 */
8274 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
8275 range_within(rold, rcur) &&
8276 tnum_in(rold->var_off, rcur->var_off);
f1174f77
EC
8277 case PTR_TO_MAP_VALUE_OR_NULL:
8278 /* a PTR_TO_MAP_VALUE could be safe to use as a
8279 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
8280 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
8281 * checked, doing so could have affected others with the same
8282 * id, and we can't check for that because we lost the id when
8283 * we converted to a PTR_TO_MAP_VALUE.
8284 */
8285 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
8286 return false;
8287 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
8288 return false;
8289 /* Check our ids match any regs they're supposed to */
8290 return check_ids(rold->id, rcur->id, idmap);
de8f3a83 8291 case PTR_TO_PACKET_META:
f1174f77 8292 case PTR_TO_PACKET:
de8f3a83 8293 if (rcur->type != rold->type)
f1174f77
EC
8294 return false;
8295 /* We must have at least as much range as the old ptr
8296 * did, so that any accesses which were safe before are
8297 * still safe. This is true even if old range < old off,
8298 * since someone could have accessed through (ptr - k), or
8299 * even done ptr -= k in a register, to get a safe access.
8300 */
8301 if (rold->range > rcur->range)
8302 return false;
8303 /* If the offsets don't match, we can't trust our alignment;
8304 * nor can we be sure that we won't fall out of range.
8305 */
8306 if (rold->off != rcur->off)
8307 return false;
8308 /* id relations must be preserved */
8309 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
8310 return false;
8311 /* new val must satisfy old val knowledge */
8312 return range_within(rold, rcur) &&
8313 tnum_in(rold->var_off, rcur->var_off);
8314 case PTR_TO_CTX:
8315 case CONST_PTR_TO_MAP:
f1174f77 8316 case PTR_TO_PACKET_END:
d58e468b 8317 case PTR_TO_FLOW_KEYS:
c64b7983
JS
8318 case PTR_TO_SOCKET:
8319 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
8320 case PTR_TO_SOCK_COMMON:
8321 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
8322 case PTR_TO_TCP_SOCK:
8323 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 8324 case PTR_TO_XDP_SOCK:
f1174f77
EC
8325 /* Only valid matches are exact, which memcmp() above
8326 * would have accepted
8327 */
8328 default:
8329 /* Don't know what's going on, just say it's not safe */
8330 return false;
8331 }
969bf05e 8332
f1174f77
EC
8333 /* Shouldn't get here; if we do, say it's not safe */
8334 WARN_ON_ONCE(1);
969bf05e
AS
8335 return false;
8336}
8337
f4d7e40a
AS
8338static bool stacksafe(struct bpf_func_state *old,
8339 struct bpf_func_state *cur,
638f5b90
AS
8340 struct idpair *idmap)
8341{
8342 int i, spi;
8343
638f5b90
AS
8344 /* walk slots of the explored stack and ignore any additional
8345 * slots in the current stack, since explored(safe) state
8346 * didn't use them
8347 */
8348 for (i = 0; i < old->allocated_stack; i++) {
8349 spi = i / BPF_REG_SIZE;
8350
b233920c
AS
8351 if (!(old->stack[spi].spilled_ptr.live & REG_LIVE_READ)) {
8352 i += BPF_REG_SIZE - 1;
cc2b14d5 8353 /* explored state didn't use this */
fd05e57b 8354 continue;
b233920c 8355 }
cc2b14d5 8356
638f5b90
AS
8357 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
8358 continue;
19e2dbb7
AS
8359
8360 /* explored stack has more populated slots than current stack
8361 * and these slots were used
8362 */
8363 if (i >= cur->allocated_stack)
8364 return false;
8365
cc2b14d5
AS
8366 /* if old state was safe with misc data in the stack
8367 * it will be safe with zero-initialized stack.
8368 * The opposite is not true
8369 */
8370 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_MISC &&
8371 cur->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_ZERO)
8372 continue;
638f5b90
AS
8373 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
8374 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
8375 /* Ex: old explored (safe) state has STACK_SPILL in
b8c1a309 8376 * this stack slot, but current has STACK_MISC ->
638f5b90
AS
8377 * this verifier states are not equivalent,
8378 * return false to continue verification of this path
8379 */
8380 return false;
8381 if (i % BPF_REG_SIZE)
8382 continue;
8383 if (old->stack[spi].slot_type[0] != STACK_SPILL)
8384 continue;
8385 if (!regsafe(&old->stack[spi].spilled_ptr,
8386 &cur->stack[spi].spilled_ptr,
8387 idmap))
8388 /* when explored and current stack slot are both storing
8389 * spilled registers, check that stored pointers types
8390 * are the same as well.
8391 * Ex: explored safe path could have stored
8392 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
8393 * but current path has stored:
8394 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
8395 * such verifier states are not equivalent.
8396 * return false to continue verification of this path
8397 */
8398 return false;
8399 }
8400 return true;
8401}
8402
fd978bf7
JS
8403static bool refsafe(struct bpf_func_state *old, struct bpf_func_state *cur)
8404{
8405 if (old->acquired_refs != cur->acquired_refs)
8406 return false;
8407 return !memcmp(old->refs, cur->refs,
8408 sizeof(*old->refs) * old->acquired_refs);
8409}
8410
f1bca824
AS
8411/* compare two verifier states
8412 *
8413 * all states stored in state_list are known to be valid, since
8414 * verifier reached 'bpf_exit' instruction through them
8415 *
8416 * this function is called when verifier exploring different branches of
8417 * execution popped from the state stack. If it sees an old state that has
8418 * more strict register state and more strict stack state then this execution
8419 * branch doesn't need to be explored further, since verifier already
8420 * concluded that more strict state leads to valid finish.
8421 *
8422 * Therefore two states are equivalent if register state is more conservative
8423 * and explored stack state is more conservative than the current one.
8424 * Example:
8425 * explored current
8426 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
8427 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
8428 *
8429 * In other words if current stack state (one being explored) has more
8430 * valid slots than old one that already passed validation, it means
8431 * the verifier can stop exploring and conclude that current state is valid too
8432 *
8433 * Similarly with registers. If explored state has register type as invalid
8434 * whereas register type in current state is meaningful, it means that
8435 * the current state will reach 'bpf_exit' instruction safely
8436 */
f4d7e40a
AS
8437static bool func_states_equal(struct bpf_func_state *old,
8438 struct bpf_func_state *cur)
f1bca824 8439{
f1174f77
EC
8440 struct idpair *idmap;
8441 bool ret = false;
f1bca824
AS
8442 int i;
8443
f1174f77
EC
8444 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
8445 /* If we failed to allocate the idmap, just say it's not safe */
8446 if (!idmap)
1a0dc1ac 8447 return false;
f1174f77
EC
8448
8449 for (i = 0; i < MAX_BPF_REG; i++) {
1b688a19 8450 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
f1174f77 8451 goto out_free;
f1bca824
AS
8452 }
8453
638f5b90
AS
8454 if (!stacksafe(old, cur, idmap))
8455 goto out_free;
fd978bf7
JS
8456
8457 if (!refsafe(old, cur))
8458 goto out_free;
f1174f77
EC
8459 ret = true;
8460out_free:
8461 kfree(idmap);
8462 return ret;
f1bca824
AS
8463}
8464
f4d7e40a
AS
8465static bool states_equal(struct bpf_verifier_env *env,
8466 struct bpf_verifier_state *old,
8467 struct bpf_verifier_state *cur)
8468{
8469 int i;
8470
8471 if (old->curframe != cur->curframe)
8472 return false;
8473
979d63d5
DB
8474 /* Verification state from speculative execution simulation
8475 * must never prune a non-speculative execution one.
8476 */
8477 if (old->speculative && !cur->speculative)
8478 return false;
8479
d83525ca
AS
8480 if (old->active_spin_lock != cur->active_spin_lock)
8481 return false;
8482
f4d7e40a
AS
8483 /* for states to be equal callsites have to be the same
8484 * and all frame states need to be equivalent
8485 */
8486 for (i = 0; i <= old->curframe; i++) {
8487 if (old->frame[i]->callsite != cur->frame[i]->callsite)
8488 return false;
8489 if (!func_states_equal(old->frame[i], cur->frame[i]))
8490 return false;
8491 }
8492 return true;
8493}
8494
5327ed3d
JW
8495/* Return 0 if no propagation happened. Return negative error code if error
8496 * happened. Otherwise, return the propagated bit.
8497 */
55e7f3b5
JW
8498static int propagate_liveness_reg(struct bpf_verifier_env *env,
8499 struct bpf_reg_state *reg,
8500 struct bpf_reg_state *parent_reg)
8501{
5327ed3d
JW
8502 u8 parent_flag = parent_reg->live & REG_LIVE_READ;
8503 u8 flag = reg->live & REG_LIVE_READ;
55e7f3b5
JW
8504 int err;
8505
5327ed3d
JW
8506 /* When comes here, read flags of PARENT_REG or REG could be any of
8507 * REG_LIVE_READ64, REG_LIVE_READ32, REG_LIVE_NONE. There is no need
8508 * of propagation if PARENT_REG has strongest REG_LIVE_READ64.
8509 */
8510 if (parent_flag == REG_LIVE_READ64 ||
8511 /* Or if there is no read flag from REG. */
8512 !flag ||
8513 /* Or if the read flag from REG is the same as PARENT_REG. */
8514 parent_flag == flag)
55e7f3b5
JW
8515 return 0;
8516
5327ed3d 8517 err = mark_reg_read(env, reg, parent_reg, flag);
55e7f3b5
JW
8518 if (err)
8519 return err;
8520
5327ed3d 8521 return flag;
55e7f3b5
JW
8522}
8523
8e9cd9ce 8524/* A write screens off any subsequent reads; but write marks come from the
f4d7e40a
AS
8525 * straight-line code between a state and its parent. When we arrive at an
8526 * equivalent state (jump target or such) we didn't arrive by the straight-line
8527 * code, so read marks in the state must propagate to the parent regardless
8528 * of the state's write marks. That's what 'parent == state->parent' comparison
679c782d 8529 * in mark_reg_read() is for.
8e9cd9ce 8530 */
f4d7e40a
AS
8531static int propagate_liveness(struct bpf_verifier_env *env,
8532 const struct bpf_verifier_state *vstate,
8533 struct bpf_verifier_state *vparent)
dc503a8a 8534{
3f8cafa4 8535 struct bpf_reg_state *state_reg, *parent_reg;
f4d7e40a 8536 struct bpf_func_state *state, *parent;
3f8cafa4 8537 int i, frame, err = 0;
dc503a8a 8538
f4d7e40a
AS
8539 if (vparent->curframe != vstate->curframe) {
8540 WARN(1, "propagate_live: parent frame %d current frame %d\n",
8541 vparent->curframe, vstate->curframe);
8542 return -EFAULT;
8543 }
dc503a8a
EC
8544 /* Propagate read liveness of registers... */
8545 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
83d16312 8546 for (frame = 0; frame <= vstate->curframe; frame++) {
3f8cafa4
JW
8547 parent = vparent->frame[frame];
8548 state = vstate->frame[frame];
8549 parent_reg = parent->regs;
8550 state_reg = state->regs;
83d16312
JK
8551 /* We don't need to worry about FP liveness, it's read-only */
8552 for (i = frame < vstate->curframe ? BPF_REG_6 : 0; i < BPF_REG_FP; i++) {
55e7f3b5
JW
8553 err = propagate_liveness_reg(env, &state_reg[i],
8554 &parent_reg[i]);
5327ed3d 8555 if (err < 0)
3f8cafa4 8556 return err;
5327ed3d
JW
8557 if (err == REG_LIVE_READ64)
8558 mark_insn_zext(env, &parent_reg[i]);
dc503a8a 8559 }
f4d7e40a 8560
1b04aee7 8561 /* Propagate stack slots. */
f4d7e40a
AS
8562 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
8563 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
3f8cafa4
JW
8564 parent_reg = &parent->stack[i].spilled_ptr;
8565 state_reg = &state->stack[i].spilled_ptr;
55e7f3b5
JW
8566 err = propagate_liveness_reg(env, state_reg,
8567 parent_reg);
5327ed3d 8568 if (err < 0)
3f8cafa4 8569 return err;
dc503a8a
EC
8570 }
8571 }
5327ed3d 8572 return 0;
dc503a8a
EC
8573}
8574
a3ce685d
AS
8575/* find precise scalars in the previous equivalent state and
8576 * propagate them into the current state
8577 */
8578static int propagate_precision(struct bpf_verifier_env *env,
8579 const struct bpf_verifier_state *old)
8580{
8581 struct bpf_reg_state *state_reg;
8582 struct bpf_func_state *state;
8583 int i, err = 0;
8584
8585 state = old->frame[old->curframe];
8586 state_reg = state->regs;
8587 for (i = 0; i < BPF_REG_FP; i++, state_reg++) {
8588 if (state_reg->type != SCALAR_VALUE ||
8589 !state_reg->precise)
8590 continue;
8591 if (env->log.level & BPF_LOG_LEVEL2)
8592 verbose(env, "propagating r%d\n", i);
8593 err = mark_chain_precision(env, i);
8594 if (err < 0)
8595 return err;
8596 }
8597
8598 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
8599 if (state->stack[i].slot_type[0] != STACK_SPILL)
8600 continue;
8601 state_reg = &state->stack[i].spilled_ptr;
8602 if (state_reg->type != SCALAR_VALUE ||
8603 !state_reg->precise)
8604 continue;
8605 if (env->log.level & BPF_LOG_LEVEL2)
8606 verbose(env, "propagating fp%d\n",
8607 (-i - 1) * BPF_REG_SIZE);
8608 err = mark_chain_precision_stack(env, i);
8609 if (err < 0)
8610 return err;
8611 }
8612 return 0;
8613}
8614
2589726d
AS
8615static bool states_maybe_looping(struct bpf_verifier_state *old,
8616 struct bpf_verifier_state *cur)
8617{
8618 struct bpf_func_state *fold, *fcur;
8619 int i, fr = cur->curframe;
8620
8621 if (old->curframe != fr)
8622 return false;
8623
8624 fold = old->frame[fr];
8625 fcur = cur->frame[fr];
8626 for (i = 0; i < MAX_BPF_REG; i++)
8627 if (memcmp(&fold->regs[i], &fcur->regs[i],
8628 offsetof(struct bpf_reg_state, parent)))
8629 return false;
8630 return true;
8631}
8632
8633
58e2af8b 8634static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
f1bca824 8635{
58e2af8b 8636 struct bpf_verifier_state_list *new_sl;
9f4686c4 8637 struct bpf_verifier_state_list *sl, **pprev;
679c782d 8638 struct bpf_verifier_state *cur = env->cur_state, *new;
ceefbc96 8639 int i, j, err, states_cnt = 0;
10d274e8 8640 bool add_new_state = env->test_state_freq ? true : false;
f1bca824 8641
b5dc0163 8642 cur->last_insn_idx = env->prev_insn_idx;
a8f500af 8643 if (!env->insn_aux_data[insn_idx].prune_point)
f1bca824
AS
8644 /* this 'insn_idx' instruction wasn't marked, so we will not
8645 * be doing state search here
8646 */
8647 return 0;
8648
2589726d
AS
8649 /* bpf progs typically have pruning point every 4 instructions
8650 * http://vger.kernel.org/bpfconf2019.html#session-1
8651 * Do not add new state for future pruning if the verifier hasn't seen
8652 * at least 2 jumps and at least 8 instructions.
8653 * This heuristics helps decrease 'total_states' and 'peak_states' metric.
8654 * In tests that amounts to up to 50% reduction into total verifier
8655 * memory consumption and 20% verifier time speedup.
8656 */
8657 if (env->jmps_processed - env->prev_jmps_processed >= 2 &&
8658 env->insn_processed - env->prev_insn_processed >= 8)
8659 add_new_state = true;
8660
a8f500af
AS
8661 pprev = explored_state(env, insn_idx);
8662 sl = *pprev;
8663
9242b5f5
AS
8664 clean_live_states(env, insn_idx, cur);
8665
a8f500af 8666 while (sl) {
dc2a4ebc
AS
8667 states_cnt++;
8668 if (sl->state.insn_idx != insn_idx)
8669 goto next;
2589726d
AS
8670 if (sl->state.branches) {
8671 if (states_maybe_looping(&sl->state, cur) &&
8672 states_equal(env, &sl->state, cur)) {
8673 verbose_linfo(env, insn_idx, "; ");
8674 verbose(env, "infinite loop detected at insn %d\n", insn_idx);
8675 return -EINVAL;
8676 }
8677 /* if the verifier is processing a loop, avoid adding new state
8678 * too often, since different loop iterations have distinct
8679 * states and may not help future pruning.
8680 * This threshold shouldn't be too low to make sure that
8681 * a loop with large bound will be rejected quickly.
8682 * The most abusive loop will be:
8683 * r1 += 1
8684 * if r1 < 1000000 goto pc-2
8685 * 1M insn_procssed limit / 100 == 10k peak states.
8686 * This threshold shouldn't be too high either, since states
8687 * at the end of the loop are likely to be useful in pruning.
8688 */
8689 if (env->jmps_processed - env->prev_jmps_processed < 20 &&
8690 env->insn_processed - env->prev_insn_processed < 100)
8691 add_new_state = false;
8692 goto miss;
8693 }
638f5b90 8694 if (states_equal(env, &sl->state, cur)) {
9f4686c4 8695 sl->hit_cnt++;
f1bca824 8696 /* reached equivalent register/stack state,
dc503a8a
EC
8697 * prune the search.
8698 * Registers read by the continuation are read by us.
8e9cd9ce
EC
8699 * If we have any write marks in env->cur_state, they
8700 * will prevent corresponding reads in the continuation
8701 * from reaching our parent (an explored_state). Our
8702 * own state will get the read marks recorded, but
8703 * they'll be immediately forgotten as we're pruning
8704 * this state and will pop a new one.
f1bca824 8705 */
f4d7e40a 8706 err = propagate_liveness(env, &sl->state, cur);
a3ce685d
AS
8707
8708 /* if previous state reached the exit with precision and
8709 * current state is equivalent to it (except precsion marks)
8710 * the precision needs to be propagated back in
8711 * the current state.
8712 */
8713 err = err ? : push_jmp_history(env, cur);
8714 err = err ? : propagate_precision(env, &sl->state);
f4d7e40a
AS
8715 if (err)
8716 return err;
f1bca824 8717 return 1;
dc503a8a 8718 }
2589726d
AS
8719miss:
8720 /* when new state is not going to be added do not increase miss count.
8721 * Otherwise several loop iterations will remove the state
8722 * recorded earlier. The goal of these heuristics is to have
8723 * states from some iterations of the loop (some in the beginning
8724 * and some at the end) to help pruning.
8725 */
8726 if (add_new_state)
8727 sl->miss_cnt++;
9f4686c4
AS
8728 /* heuristic to determine whether this state is beneficial
8729 * to keep checking from state equivalence point of view.
8730 * Higher numbers increase max_states_per_insn and verification time,
8731 * but do not meaningfully decrease insn_processed.
8732 */
8733 if (sl->miss_cnt > sl->hit_cnt * 3 + 3) {
8734 /* the state is unlikely to be useful. Remove it to
8735 * speed up verification
8736 */
8737 *pprev = sl->next;
8738 if (sl->state.frame[0]->regs[0].live & REG_LIVE_DONE) {
2589726d
AS
8739 u32 br = sl->state.branches;
8740
8741 WARN_ONCE(br,
8742 "BUG live_done but branches_to_explore %d\n",
8743 br);
9f4686c4
AS
8744 free_verifier_state(&sl->state, false);
8745 kfree(sl);
8746 env->peak_states--;
8747 } else {
8748 /* cannot free this state, since parentage chain may
8749 * walk it later. Add it for free_list instead to
8750 * be freed at the end of verification
8751 */
8752 sl->next = env->free_list;
8753 env->free_list = sl;
8754 }
8755 sl = *pprev;
8756 continue;
8757 }
dc2a4ebc 8758next:
9f4686c4
AS
8759 pprev = &sl->next;
8760 sl = *pprev;
f1bca824
AS
8761 }
8762
06ee7115
AS
8763 if (env->max_states_per_insn < states_cnt)
8764 env->max_states_per_insn = states_cnt;
8765
2c78ee89 8766 if (!env->bpf_capable && states_cnt > BPF_COMPLEXITY_LIMIT_STATES)
b5dc0163 8767 return push_jmp_history(env, cur);
ceefbc96 8768
2589726d 8769 if (!add_new_state)
b5dc0163 8770 return push_jmp_history(env, cur);
ceefbc96 8771
2589726d
AS
8772 /* There were no equivalent states, remember the current one.
8773 * Technically the current state is not proven to be safe yet,
f4d7e40a 8774 * but it will either reach outer most bpf_exit (which means it's safe)
2589726d 8775 * or it will be rejected. When there are no loops the verifier won't be
f4d7e40a 8776 * seeing this tuple (frame[0].callsite, frame[1].callsite, .. insn_idx)
2589726d
AS
8777 * again on the way to bpf_exit.
8778 * When looping the sl->state.branches will be > 0 and this state
8779 * will not be considered for equivalence until branches == 0.
f1bca824 8780 */
638f5b90 8781 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
f1bca824
AS
8782 if (!new_sl)
8783 return -ENOMEM;
06ee7115
AS
8784 env->total_states++;
8785 env->peak_states++;
2589726d
AS
8786 env->prev_jmps_processed = env->jmps_processed;
8787 env->prev_insn_processed = env->insn_processed;
f1bca824
AS
8788
8789 /* add new state to the head of linked list */
679c782d
EC
8790 new = &new_sl->state;
8791 err = copy_verifier_state(new, cur);
1969db47 8792 if (err) {
679c782d 8793 free_verifier_state(new, false);
1969db47
AS
8794 kfree(new_sl);
8795 return err;
8796 }
dc2a4ebc 8797 new->insn_idx = insn_idx;
2589726d
AS
8798 WARN_ONCE(new->branches != 1,
8799 "BUG is_state_visited:branches_to_explore=%d insn %d\n", new->branches, insn_idx);
b5dc0163 8800
2589726d 8801 cur->parent = new;
b5dc0163
AS
8802 cur->first_insn_idx = insn_idx;
8803 clear_jmp_history(cur);
5d839021
AS
8804 new_sl->next = *explored_state(env, insn_idx);
8805 *explored_state(env, insn_idx) = new_sl;
7640ead9
JK
8806 /* connect new state to parentage chain. Current frame needs all
8807 * registers connected. Only r6 - r9 of the callers are alive (pushed
8808 * to the stack implicitly by JITs) so in callers' frames connect just
8809 * r6 - r9 as an optimization. Callers will have r1 - r5 connected to
8810 * the state of the call instruction (with WRITTEN set), and r0 comes
8811 * from callee with its full parentage chain, anyway.
8812 */
8e9cd9ce
EC
8813 /* clear write marks in current state: the writes we did are not writes
8814 * our child did, so they don't screen off its reads from us.
8815 * (There are no read marks in current state, because reads always mark
8816 * their parent and current state never has children yet. Only
8817 * explored_states can get read marks.)
8818 */
eea1c227
AS
8819 for (j = 0; j <= cur->curframe; j++) {
8820 for (i = j < cur->curframe ? BPF_REG_6 : 0; i < BPF_REG_FP; i++)
8821 cur->frame[j]->regs[i].parent = &new->frame[j]->regs[i];
8822 for (i = 0; i < BPF_REG_FP; i++)
8823 cur->frame[j]->regs[i].live = REG_LIVE_NONE;
8824 }
f4d7e40a
AS
8825
8826 /* all stack frames are accessible from callee, clear them all */
8827 for (j = 0; j <= cur->curframe; j++) {
8828 struct bpf_func_state *frame = cur->frame[j];
679c782d 8829 struct bpf_func_state *newframe = new->frame[j];
f4d7e40a 8830
679c782d 8831 for (i = 0; i < frame->allocated_stack / BPF_REG_SIZE; i++) {
cc2b14d5 8832 frame->stack[i].spilled_ptr.live = REG_LIVE_NONE;
679c782d
EC
8833 frame->stack[i].spilled_ptr.parent =
8834 &newframe->stack[i].spilled_ptr;
8835 }
f4d7e40a 8836 }
f1bca824
AS
8837 return 0;
8838}
8839
c64b7983
JS
8840/* Return true if it's OK to have the same insn return a different type. */
8841static bool reg_type_mismatch_ok(enum bpf_reg_type type)
8842{
8843 switch (type) {
8844 case PTR_TO_CTX:
8845 case PTR_TO_SOCKET:
8846 case PTR_TO_SOCKET_OR_NULL:
46f8bc92
MKL
8847 case PTR_TO_SOCK_COMMON:
8848 case PTR_TO_SOCK_COMMON_OR_NULL:
655a51e5
MKL
8849 case PTR_TO_TCP_SOCK:
8850 case PTR_TO_TCP_SOCK_OR_NULL:
fada7fdc 8851 case PTR_TO_XDP_SOCK:
2a02759e 8852 case PTR_TO_BTF_ID:
b121b341 8853 case PTR_TO_BTF_ID_OR_NULL:
c64b7983
JS
8854 return false;
8855 default:
8856 return true;
8857 }
8858}
8859
8860/* If an instruction was previously used with particular pointer types, then we
8861 * need to be careful to avoid cases such as the below, where it may be ok
8862 * for one branch accessing the pointer, but not ok for the other branch:
8863 *
8864 * R1 = sock_ptr
8865 * goto X;
8866 * ...
8867 * R1 = some_other_valid_ptr;
8868 * goto X;
8869 * ...
8870 * R2 = *(u32 *)(R1 + 0);
8871 */
8872static bool reg_type_mismatch(enum bpf_reg_type src, enum bpf_reg_type prev)
8873{
8874 return src != prev && (!reg_type_mismatch_ok(src) ||
8875 !reg_type_mismatch_ok(prev));
8876}
8877
58e2af8b 8878static int do_check(struct bpf_verifier_env *env)
17a52670 8879{
6f8a57cc 8880 bool pop_log = !(env->log.level & BPF_LOG_LEVEL2);
51c39bb1 8881 struct bpf_verifier_state *state = env->cur_state;
17a52670 8882 struct bpf_insn *insns = env->prog->insnsi;
638f5b90 8883 struct bpf_reg_state *regs;
06ee7115 8884 int insn_cnt = env->prog->len;
17a52670 8885 bool do_print_state = false;
b5dc0163 8886 int prev_insn_idx = -1;
17a52670 8887
17a52670
AS
8888 for (;;) {
8889 struct bpf_insn *insn;
8890 u8 class;
8891 int err;
8892
b5dc0163 8893 env->prev_insn_idx = prev_insn_idx;
c08435ec 8894 if (env->insn_idx >= insn_cnt) {
61bd5218 8895 verbose(env, "invalid insn idx %d insn_cnt %d\n",
c08435ec 8896 env->insn_idx, insn_cnt);
17a52670
AS
8897 return -EFAULT;
8898 }
8899
c08435ec 8900 insn = &insns[env->insn_idx];
17a52670
AS
8901 class = BPF_CLASS(insn->code);
8902
06ee7115 8903 if (++env->insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
61bd5218
JK
8904 verbose(env,
8905 "BPF program is too large. Processed %d insn\n",
06ee7115 8906 env->insn_processed);
17a52670
AS
8907 return -E2BIG;
8908 }
8909
c08435ec 8910 err = is_state_visited(env, env->insn_idx);
f1bca824
AS
8911 if (err < 0)
8912 return err;
8913 if (err == 1) {
8914 /* found equivalent state, can prune the search */
06ee7115 8915 if (env->log.level & BPF_LOG_LEVEL) {
f1bca824 8916 if (do_print_state)
979d63d5
DB
8917 verbose(env, "\nfrom %d to %d%s: safe\n",
8918 env->prev_insn_idx, env->insn_idx,
8919 env->cur_state->speculative ?
8920 " (speculative execution)" : "");
f1bca824 8921 else
c08435ec 8922 verbose(env, "%d: safe\n", env->insn_idx);
f1bca824
AS
8923 }
8924 goto process_bpf_exit;
8925 }
8926
c3494801
AS
8927 if (signal_pending(current))
8928 return -EAGAIN;
8929
3c2ce60b
DB
8930 if (need_resched())
8931 cond_resched();
8932
06ee7115
AS
8933 if (env->log.level & BPF_LOG_LEVEL2 ||
8934 (env->log.level & BPF_LOG_LEVEL && do_print_state)) {
8935 if (env->log.level & BPF_LOG_LEVEL2)
c08435ec 8936 verbose(env, "%d:", env->insn_idx);
c5fc9692 8937 else
979d63d5
DB
8938 verbose(env, "\nfrom %d to %d%s:",
8939 env->prev_insn_idx, env->insn_idx,
8940 env->cur_state->speculative ?
8941 " (speculative execution)" : "");
f4d7e40a 8942 print_verifier_state(env, state->frame[state->curframe]);
17a52670
AS
8943 do_print_state = false;
8944 }
8945
06ee7115 8946 if (env->log.level & BPF_LOG_LEVEL) {
7105e828
DB
8947 const struct bpf_insn_cbs cbs = {
8948 .cb_print = verbose,
abe08840 8949 .private_data = env,
7105e828
DB
8950 };
8951
c08435ec
DB
8952 verbose_linfo(env, env->insn_idx, "; ");
8953 verbose(env, "%d: ", env->insn_idx);
abe08840 8954 print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
17a52670
AS
8955 }
8956
cae1927c 8957 if (bpf_prog_is_dev_bound(env->prog->aux)) {
c08435ec
DB
8958 err = bpf_prog_offload_verify_insn(env, env->insn_idx,
8959 env->prev_insn_idx);
cae1927c
JK
8960 if (err)
8961 return err;
8962 }
13a27dfc 8963
638f5b90 8964 regs = cur_regs(env);
51c39bb1 8965 env->insn_aux_data[env->insn_idx].seen = env->pass_cnt;
b5dc0163 8966 prev_insn_idx = env->insn_idx;
fd978bf7 8967
17a52670 8968 if (class == BPF_ALU || class == BPF_ALU64) {
1be7f75d 8969 err = check_alu_op(env, insn);
17a52670
AS
8970 if (err)
8971 return err;
8972
8973 } else if (class == BPF_LDX) {
3df126f3 8974 enum bpf_reg_type *prev_src_type, src_reg_type;
9bac3d6d
AS
8975
8976 /* check for reserved fields is already done */
8977
17a52670 8978 /* check src operand */
dc503a8a 8979 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
8980 if (err)
8981 return err;
8982
dc503a8a 8983 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
17a52670
AS
8984 if (err)
8985 return err;
8986
725f9dcd
AS
8987 src_reg_type = regs[insn->src_reg].type;
8988
17a52670
AS
8989 /* check that memory (src_reg + off) is readable,
8990 * the state of dst_reg will be updated by this func
8991 */
c08435ec
DB
8992 err = check_mem_access(env, env->insn_idx, insn->src_reg,
8993 insn->off, BPF_SIZE(insn->code),
8994 BPF_READ, insn->dst_reg, false);
17a52670
AS
8995 if (err)
8996 return err;
8997
c08435ec 8998 prev_src_type = &env->insn_aux_data[env->insn_idx].ptr_type;
3df126f3
JK
8999
9000 if (*prev_src_type == NOT_INIT) {
9bac3d6d
AS
9001 /* saw a valid insn
9002 * dst_reg = *(u32 *)(src_reg + off)
3df126f3 9003 * save type to validate intersecting paths
9bac3d6d 9004 */
3df126f3 9005 *prev_src_type = src_reg_type;
9bac3d6d 9006
c64b7983 9007 } else if (reg_type_mismatch(src_reg_type, *prev_src_type)) {
9bac3d6d
AS
9008 /* ABuser program is trying to use the same insn
9009 * dst_reg = *(u32*) (src_reg + off)
9010 * with different pointer types:
9011 * src_reg == ctx in one branch and
9012 * src_reg == stack|map in some other branch.
9013 * Reject it.
9014 */
61bd5218 9015 verbose(env, "same insn cannot be used with different pointers\n");
9bac3d6d
AS
9016 return -EINVAL;
9017 }
9018
17a52670 9019 } else if (class == BPF_STX) {
3df126f3 9020 enum bpf_reg_type *prev_dst_type, dst_reg_type;
d691f9e8 9021
17a52670 9022 if (BPF_MODE(insn->code) == BPF_XADD) {
c08435ec 9023 err = check_xadd(env, env->insn_idx, insn);
17a52670
AS
9024 if (err)
9025 return err;
c08435ec 9026 env->insn_idx++;
17a52670
AS
9027 continue;
9028 }
9029
17a52670 9030 /* check src1 operand */
dc503a8a 9031 err = check_reg_arg(env, insn->src_reg, SRC_OP);
17a52670
AS
9032 if (err)
9033 return err;
9034 /* check src2 operand */
dc503a8a 9035 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
9036 if (err)
9037 return err;
9038
d691f9e8
AS
9039 dst_reg_type = regs[insn->dst_reg].type;
9040
17a52670 9041 /* check that memory (dst_reg + off) is writeable */
c08435ec
DB
9042 err = check_mem_access(env, env->insn_idx, insn->dst_reg,
9043 insn->off, BPF_SIZE(insn->code),
9044 BPF_WRITE, insn->src_reg, false);
17a52670
AS
9045 if (err)
9046 return err;
9047
c08435ec 9048 prev_dst_type = &env->insn_aux_data[env->insn_idx].ptr_type;
3df126f3
JK
9049
9050 if (*prev_dst_type == NOT_INIT) {
9051 *prev_dst_type = dst_reg_type;
c64b7983 9052 } else if (reg_type_mismatch(dst_reg_type, *prev_dst_type)) {
61bd5218 9053 verbose(env, "same insn cannot be used with different pointers\n");
d691f9e8
AS
9054 return -EINVAL;
9055 }
9056
17a52670
AS
9057 } else if (class == BPF_ST) {
9058 if (BPF_MODE(insn->code) != BPF_MEM ||
9059 insn->src_reg != BPF_REG_0) {
61bd5218 9060 verbose(env, "BPF_ST uses reserved fields\n");
17a52670
AS
9061 return -EINVAL;
9062 }
9063 /* check src operand */
dc503a8a 9064 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
17a52670
AS
9065 if (err)
9066 return err;
9067
f37a8cb8 9068 if (is_ctx_reg(env, insn->dst_reg)) {
9d2be44a 9069 verbose(env, "BPF_ST stores into R%d %s is not allowed\n",
2a159c6f
DB
9070 insn->dst_reg,
9071 reg_type_str[reg_state(env, insn->dst_reg)->type]);
f37a8cb8
DB
9072 return -EACCES;
9073 }
9074
17a52670 9075 /* check that memory (dst_reg + off) is writeable */
c08435ec
DB
9076 err = check_mem_access(env, env->insn_idx, insn->dst_reg,
9077 insn->off, BPF_SIZE(insn->code),
9078 BPF_WRITE, -1, false);
17a52670
AS
9079 if (err)
9080 return err;
9081
092ed096 9082 } else if (class == BPF_JMP || class == BPF_JMP32) {
17a52670
AS
9083 u8 opcode = BPF_OP(insn->code);
9084
2589726d 9085 env->jmps_processed++;
17a52670
AS
9086 if (opcode == BPF_CALL) {
9087 if (BPF_SRC(insn->code) != BPF_K ||
9088 insn->off != 0 ||
f4d7e40a
AS
9089 (insn->src_reg != BPF_REG_0 &&
9090 insn->src_reg != BPF_PSEUDO_CALL) ||
092ed096
JW
9091 insn->dst_reg != BPF_REG_0 ||
9092 class == BPF_JMP32) {
61bd5218 9093 verbose(env, "BPF_CALL uses reserved fields\n");
17a52670
AS
9094 return -EINVAL;
9095 }
9096
d83525ca
AS
9097 if (env->cur_state->active_spin_lock &&
9098 (insn->src_reg == BPF_PSEUDO_CALL ||
9099 insn->imm != BPF_FUNC_spin_unlock)) {
9100 verbose(env, "function calls are not allowed while holding a lock\n");
9101 return -EINVAL;
9102 }
f4d7e40a 9103 if (insn->src_reg == BPF_PSEUDO_CALL)
c08435ec 9104 err = check_func_call(env, insn, &env->insn_idx);
f4d7e40a 9105 else
c08435ec 9106 err = check_helper_call(env, insn->imm, env->insn_idx);
17a52670
AS
9107 if (err)
9108 return err;
9109
9110 } else if (opcode == BPF_JA) {
9111 if (BPF_SRC(insn->code) != BPF_K ||
9112 insn->imm != 0 ||
9113 insn->src_reg != BPF_REG_0 ||
092ed096
JW
9114 insn->dst_reg != BPF_REG_0 ||
9115 class == BPF_JMP32) {
61bd5218 9116 verbose(env, "BPF_JA uses reserved fields\n");
17a52670
AS
9117 return -EINVAL;
9118 }
9119
c08435ec 9120 env->insn_idx += insn->off + 1;
17a52670
AS
9121 continue;
9122
9123 } else if (opcode == BPF_EXIT) {
9124 if (BPF_SRC(insn->code) != BPF_K ||
9125 insn->imm != 0 ||
9126 insn->src_reg != BPF_REG_0 ||
092ed096
JW
9127 insn->dst_reg != BPF_REG_0 ||
9128 class == BPF_JMP32) {
61bd5218 9129 verbose(env, "BPF_EXIT uses reserved fields\n");
17a52670
AS
9130 return -EINVAL;
9131 }
9132
d83525ca
AS
9133 if (env->cur_state->active_spin_lock) {
9134 verbose(env, "bpf_spin_unlock is missing\n");
9135 return -EINVAL;
9136 }
9137
f4d7e40a
AS
9138 if (state->curframe) {
9139 /* exit from nested function */
c08435ec 9140 err = prepare_func_exit(env, &env->insn_idx);
f4d7e40a
AS
9141 if (err)
9142 return err;
9143 do_print_state = true;
9144 continue;
9145 }
9146
fd978bf7
JS
9147 err = check_reference_leak(env);
9148 if (err)
9149 return err;
9150
390ee7e2
AS
9151 err = check_return_code(env);
9152 if (err)
9153 return err;
f1bca824 9154process_bpf_exit:
2589726d 9155 update_branch_counts(env, env->cur_state);
b5dc0163 9156 err = pop_stack(env, &prev_insn_idx,
6f8a57cc 9157 &env->insn_idx, pop_log);
638f5b90
AS
9158 if (err < 0) {
9159 if (err != -ENOENT)
9160 return err;
17a52670
AS
9161 break;
9162 } else {
9163 do_print_state = true;
9164 continue;
9165 }
9166 } else {
c08435ec 9167 err = check_cond_jmp_op(env, insn, &env->insn_idx);
17a52670
AS
9168 if (err)
9169 return err;
9170 }
9171 } else if (class == BPF_LD) {
9172 u8 mode = BPF_MODE(insn->code);
9173
9174 if (mode == BPF_ABS || mode == BPF_IND) {
ddd872bc
AS
9175 err = check_ld_abs(env, insn);
9176 if (err)
9177 return err;
9178
17a52670
AS
9179 } else if (mode == BPF_IMM) {
9180 err = check_ld_imm(env, insn);
9181 if (err)
9182 return err;
9183
c08435ec 9184 env->insn_idx++;
51c39bb1 9185 env->insn_aux_data[env->insn_idx].seen = env->pass_cnt;
17a52670 9186 } else {
61bd5218 9187 verbose(env, "invalid BPF_LD mode\n");
17a52670
AS
9188 return -EINVAL;
9189 }
9190 } else {
61bd5218 9191 verbose(env, "unknown insn class %d\n", class);
17a52670
AS
9192 return -EINVAL;
9193 }
9194
c08435ec 9195 env->insn_idx++;
17a52670
AS
9196 }
9197
9198 return 0;
9199}
9200
56f668df
MKL
9201static int check_map_prealloc(struct bpf_map *map)
9202{
9203 return (map->map_type != BPF_MAP_TYPE_HASH &&
bcc6b1b7
MKL
9204 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
9205 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
56f668df
MKL
9206 !(map->map_flags & BPF_F_NO_PREALLOC);
9207}
9208
d83525ca
AS
9209static bool is_tracing_prog_type(enum bpf_prog_type type)
9210{
9211 switch (type) {
9212 case BPF_PROG_TYPE_KPROBE:
9213 case BPF_PROG_TYPE_TRACEPOINT:
9214 case BPF_PROG_TYPE_PERF_EVENT:
9215 case BPF_PROG_TYPE_RAW_TRACEPOINT:
9216 return true;
9217 default:
9218 return false;
9219 }
9220}
9221
94dacdbd
TG
9222static bool is_preallocated_map(struct bpf_map *map)
9223{
9224 if (!check_map_prealloc(map))
9225 return false;
9226 if (map->inner_map_meta && !check_map_prealloc(map->inner_map_meta))
9227 return false;
9228 return true;
9229}
9230
61bd5218
JK
9231static int check_map_prog_compatibility(struct bpf_verifier_env *env,
9232 struct bpf_map *map,
fdc15d38
AS
9233 struct bpf_prog *prog)
9234
9235{
94dacdbd
TG
9236 /*
9237 * Validate that trace type programs use preallocated hash maps.
9238 *
9239 * For programs attached to PERF events this is mandatory as the
9240 * perf NMI can hit any arbitrary code sequence.
9241 *
9242 * All other trace types using preallocated hash maps are unsafe as
9243 * well because tracepoint or kprobes can be inside locked regions
9244 * of the memory allocator or at a place where a recursion into the
9245 * memory allocator would see inconsistent state.
9246 *
2ed905c5
TG
9247 * On RT enabled kernels run-time allocation of all trace type
9248 * programs is strictly prohibited due to lock type constraints. On
9249 * !RT kernels it is allowed for backwards compatibility reasons for
9250 * now, but warnings are emitted so developers are made aware of
9251 * the unsafety and can fix their programs before this is enforced.
56f668df 9252 */
94dacdbd
TG
9253 if (is_tracing_prog_type(prog->type) && !is_preallocated_map(map)) {
9254 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
61bd5218 9255 verbose(env, "perf_event programs can only use preallocated hash map\n");
56f668df
MKL
9256 return -EINVAL;
9257 }
2ed905c5
TG
9258 if (IS_ENABLED(CONFIG_PREEMPT_RT)) {
9259 verbose(env, "trace type programs can only use preallocated hash map\n");
9260 return -EINVAL;
9261 }
94dacdbd
TG
9262 WARN_ONCE(1, "trace type BPF program uses run-time allocation\n");
9263 verbose(env, "trace type programs with run-time allocated hash maps are unsafe. Switch to preallocated hash maps.\n");
fdc15d38 9264 }
a3884572 9265
d83525ca
AS
9266 if ((is_tracing_prog_type(prog->type) ||
9267 prog->type == BPF_PROG_TYPE_SOCKET_FILTER) &&
9268 map_value_has_spin_lock(map)) {
9269 verbose(env, "tracing progs cannot use bpf_spin_lock yet\n");
9270 return -EINVAL;
9271 }
9272
a3884572 9273 if ((bpf_prog_is_dev_bound(prog->aux) || bpf_map_is_dev_bound(map)) &&
09728266 9274 !bpf_offload_prog_map_match(prog, map)) {
a3884572
JK
9275 verbose(env, "offload device mismatch between prog and map\n");
9276 return -EINVAL;
9277 }
9278
85d33df3
MKL
9279 if (map->map_type == BPF_MAP_TYPE_STRUCT_OPS) {
9280 verbose(env, "bpf_struct_ops map cannot be used in prog\n");
9281 return -EINVAL;
9282 }
9283
fdc15d38
AS
9284 return 0;
9285}
9286
b741f163
RG
9287static bool bpf_map_is_cgroup_storage(struct bpf_map *map)
9288{
9289 return (map->map_type == BPF_MAP_TYPE_CGROUP_STORAGE ||
9290 map->map_type == BPF_MAP_TYPE_PERCPU_CGROUP_STORAGE);
9291}
9292
0246e64d
AS
9293/* look for pseudo eBPF instructions that access map FDs and
9294 * replace them with actual map pointers
9295 */
58e2af8b 9296static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
0246e64d
AS
9297{
9298 struct bpf_insn *insn = env->prog->insnsi;
9299 int insn_cnt = env->prog->len;
fdc15d38 9300 int i, j, err;
0246e64d 9301
f1f7714e 9302 err = bpf_prog_calc_tag(env->prog);
aafe6ae9
DB
9303 if (err)
9304 return err;
9305
0246e64d 9306 for (i = 0; i < insn_cnt; i++, insn++) {
9bac3d6d 9307 if (BPF_CLASS(insn->code) == BPF_LDX &&
d691f9e8 9308 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
61bd5218 9309 verbose(env, "BPF_LDX uses reserved fields\n");
9bac3d6d
AS
9310 return -EINVAL;
9311 }
9312
d691f9e8
AS
9313 if (BPF_CLASS(insn->code) == BPF_STX &&
9314 ((BPF_MODE(insn->code) != BPF_MEM &&
9315 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
61bd5218 9316 verbose(env, "BPF_STX uses reserved fields\n");
d691f9e8
AS
9317 return -EINVAL;
9318 }
9319
0246e64d 9320 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
d8eca5bb 9321 struct bpf_insn_aux_data *aux;
0246e64d
AS
9322 struct bpf_map *map;
9323 struct fd f;
d8eca5bb 9324 u64 addr;
0246e64d
AS
9325
9326 if (i == insn_cnt - 1 || insn[1].code != 0 ||
9327 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
9328 insn[1].off != 0) {
61bd5218 9329 verbose(env, "invalid bpf_ld_imm64 insn\n");
0246e64d
AS
9330 return -EINVAL;
9331 }
9332
d8eca5bb 9333 if (insn[0].src_reg == 0)
0246e64d
AS
9334 /* valid generic load 64-bit imm */
9335 goto next_insn;
9336
d8eca5bb
DB
9337 /* In final convert_pseudo_ld_imm64() step, this is
9338 * converted into regular 64-bit imm load insn.
9339 */
9340 if ((insn[0].src_reg != BPF_PSEUDO_MAP_FD &&
9341 insn[0].src_reg != BPF_PSEUDO_MAP_VALUE) ||
9342 (insn[0].src_reg == BPF_PSEUDO_MAP_FD &&
9343 insn[1].imm != 0)) {
9344 verbose(env,
9345 "unrecognized bpf_ld_imm64 insn\n");
0246e64d
AS
9346 return -EINVAL;
9347 }
9348
20182390 9349 f = fdget(insn[0].imm);
c2101297 9350 map = __bpf_map_get(f);
0246e64d 9351 if (IS_ERR(map)) {
61bd5218 9352 verbose(env, "fd %d is not pointing to valid bpf_map\n",
20182390 9353 insn[0].imm);
0246e64d
AS
9354 return PTR_ERR(map);
9355 }
9356
61bd5218 9357 err = check_map_prog_compatibility(env, map, env->prog);
fdc15d38
AS
9358 if (err) {
9359 fdput(f);
9360 return err;
9361 }
9362
d8eca5bb
DB
9363 aux = &env->insn_aux_data[i];
9364 if (insn->src_reg == BPF_PSEUDO_MAP_FD) {
9365 addr = (unsigned long)map;
9366 } else {
9367 u32 off = insn[1].imm;
9368
9369 if (off >= BPF_MAX_VAR_OFF) {
9370 verbose(env, "direct value offset of %u is not allowed\n", off);
9371 fdput(f);
9372 return -EINVAL;
9373 }
9374
9375 if (!map->ops->map_direct_value_addr) {
9376 verbose(env, "no direct value access support for this map type\n");
9377 fdput(f);
9378 return -EINVAL;
9379 }
9380
9381 err = map->ops->map_direct_value_addr(map, &addr, off);
9382 if (err) {
9383 verbose(env, "invalid access to map value pointer, value_size=%u off=%u\n",
9384 map->value_size, off);
9385 fdput(f);
9386 return err;
9387 }
9388
9389 aux->map_off = off;
9390 addr += off;
9391 }
9392
9393 insn[0].imm = (u32)addr;
9394 insn[1].imm = addr >> 32;
0246e64d
AS
9395
9396 /* check whether we recorded this map already */
d8eca5bb 9397 for (j = 0; j < env->used_map_cnt; j++) {
0246e64d 9398 if (env->used_maps[j] == map) {
d8eca5bb 9399 aux->map_index = j;
0246e64d
AS
9400 fdput(f);
9401 goto next_insn;
9402 }
d8eca5bb 9403 }
0246e64d
AS
9404
9405 if (env->used_map_cnt >= MAX_USED_MAPS) {
9406 fdput(f);
9407 return -E2BIG;
9408 }
9409
0246e64d
AS
9410 /* hold the map. If the program is rejected by verifier,
9411 * the map will be released by release_maps() or it
9412 * will be used by the valid program until it's unloaded
ab7f5bf0 9413 * and all maps are released in free_used_maps()
0246e64d 9414 */
1e0bd5a0 9415 bpf_map_inc(map);
d8eca5bb
DB
9416
9417 aux->map_index = env->used_map_cnt;
92117d84
AS
9418 env->used_maps[env->used_map_cnt++] = map;
9419
b741f163 9420 if (bpf_map_is_cgroup_storage(map) &&
e4730423 9421 bpf_cgroup_storage_assign(env->prog->aux, map)) {
b741f163 9422 verbose(env, "only one cgroup storage of each type is allowed\n");
de9cbbaa
RG
9423 fdput(f);
9424 return -EBUSY;
9425 }
9426
0246e64d
AS
9427 fdput(f);
9428next_insn:
9429 insn++;
9430 i++;
5e581dad
DB
9431 continue;
9432 }
9433
9434 /* Basic sanity check before we invest more work here. */
9435 if (!bpf_opcode_in_insntable(insn->code)) {
9436 verbose(env, "unknown opcode %02x\n", insn->code);
9437 return -EINVAL;
0246e64d
AS
9438 }
9439 }
9440
9441 /* now all pseudo BPF_LD_IMM64 instructions load valid
9442 * 'struct bpf_map *' into a register instead of user map_fd.
9443 * These pointers will be used later by verifier to validate map access.
9444 */
9445 return 0;
9446}
9447
9448/* drop refcnt of maps used by the rejected program */
58e2af8b 9449static void release_maps(struct bpf_verifier_env *env)
0246e64d 9450{
a2ea0746
DB
9451 __bpf_free_used_maps(env->prog->aux, env->used_maps,
9452 env->used_map_cnt);
0246e64d
AS
9453}
9454
9455/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
58e2af8b 9456static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
0246e64d
AS
9457{
9458 struct bpf_insn *insn = env->prog->insnsi;
9459 int insn_cnt = env->prog->len;
9460 int i;
9461
9462 for (i = 0; i < insn_cnt; i++, insn++)
9463 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
9464 insn->src_reg = 0;
9465}
9466
8041902d
AS
9467/* single env->prog->insni[off] instruction was replaced with the range
9468 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
9469 * [0, off) and [off, end) to new locations, so the patched range stays zero
9470 */
b325fbca
JW
9471static int adjust_insn_aux_data(struct bpf_verifier_env *env,
9472 struct bpf_prog *new_prog, u32 off, u32 cnt)
8041902d
AS
9473{
9474 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
b325fbca
JW
9475 struct bpf_insn *insn = new_prog->insnsi;
9476 u32 prog_len;
c131187d 9477 int i;
8041902d 9478
b325fbca
JW
9479 /* aux info at OFF always needs adjustment, no matter fast path
9480 * (cnt == 1) is taken or not. There is no guarantee INSN at OFF is the
9481 * original insn at old prog.
9482 */
9483 old_data[off].zext_dst = insn_has_def32(env, insn + off + cnt - 1);
9484
8041902d
AS
9485 if (cnt == 1)
9486 return 0;
b325fbca 9487 prog_len = new_prog->len;
fad953ce
KC
9488 new_data = vzalloc(array_size(prog_len,
9489 sizeof(struct bpf_insn_aux_data)));
8041902d
AS
9490 if (!new_data)
9491 return -ENOMEM;
9492 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
9493 memcpy(new_data + off + cnt - 1, old_data + off,
9494 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
b325fbca 9495 for (i = off; i < off + cnt - 1; i++) {
51c39bb1 9496 new_data[i].seen = env->pass_cnt;
b325fbca
JW
9497 new_data[i].zext_dst = insn_has_def32(env, insn + i);
9498 }
8041902d
AS
9499 env->insn_aux_data = new_data;
9500 vfree(old_data);
9501 return 0;
9502}
9503
cc8b0b92
AS
9504static void adjust_subprog_starts(struct bpf_verifier_env *env, u32 off, u32 len)
9505{
9506 int i;
9507
9508 if (len == 1)
9509 return;
4cb3d99c
JW
9510 /* NOTE: fake 'exit' subprog should be updated as well. */
9511 for (i = 0; i <= env->subprog_cnt; i++) {
afd59424 9512 if (env->subprog_info[i].start <= off)
cc8b0b92 9513 continue;
9c8105bd 9514 env->subprog_info[i].start += len - 1;
cc8b0b92
AS
9515 }
9516}
9517
8041902d
AS
9518static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
9519 const struct bpf_insn *patch, u32 len)
9520{
9521 struct bpf_prog *new_prog;
9522
9523 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
4f73379e
AS
9524 if (IS_ERR(new_prog)) {
9525 if (PTR_ERR(new_prog) == -ERANGE)
9526 verbose(env,
9527 "insn %d cannot be patched due to 16-bit range\n",
9528 env->insn_aux_data[off].orig_idx);
8041902d 9529 return NULL;
4f73379e 9530 }
b325fbca 9531 if (adjust_insn_aux_data(env, new_prog, off, len))
8041902d 9532 return NULL;
cc8b0b92 9533 adjust_subprog_starts(env, off, len);
8041902d
AS
9534 return new_prog;
9535}
9536
52875a04
JK
9537static int adjust_subprog_starts_after_remove(struct bpf_verifier_env *env,
9538 u32 off, u32 cnt)
9539{
9540 int i, j;
9541
9542 /* find first prog starting at or after off (first to remove) */
9543 for (i = 0; i < env->subprog_cnt; i++)
9544 if (env->subprog_info[i].start >= off)
9545 break;
9546 /* find first prog starting at or after off + cnt (first to stay) */
9547 for (j = i; j < env->subprog_cnt; j++)
9548 if (env->subprog_info[j].start >= off + cnt)
9549 break;
9550 /* if j doesn't start exactly at off + cnt, we are just removing
9551 * the front of previous prog
9552 */
9553 if (env->subprog_info[j].start != off + cnt)
9554 j--;
9555
9556 if (j > i) {
9557 struct bpf_prog_aux *aux = env->prog->aux;
9558 int move;
9559
9560 /* move fake 'exit' subprog as well */
9561 move = env->subprog_cnt + 1 - j;
9562
9563 memmove(env->subprog_info + i,
9564 env->subprog_info + j,
9565 sizeof(*env->subprog_info) * move);
9566 env->subprog_cnt -= j - i;
9567
9568 /* remove func_info */
9569 if (aux->func_info) {
9570 move = aux->func_info_cnt - j;
9571
9572 memmove(aux->func_info + i,
9573 aux->func_info + j,
9574 sizeof(*aux->func_info) * move);
9575 aux->func_info_cnt -= j - i;
9576 /* func_info->insn_off is set after all code rewrites,
9577 * in adjust_btf_func() - no need to adjust
9578 */
9579 }
9580 } else {
9581 /* convert i from "first prog to remove" to "first to adjust" */
9582 if (env->subprog_info[i].start == off)
9583 i++;
9584 }
9585
9586 /* update fake 'exit' subprog as well */
9587 for (; i <= env->subprog_cnt; i++)
9588 env->subprog_info[i].start -= cnt;
9589
9590 return 0;
9591}
9592
9593static int bpf_adj_linfo_after_remove(struct bpf_verifier_env *env, u32 off,
9594 u32 cnt)
9595{
9596 struct bpf_prog *prog = env->prog;
9597 u32 i, l_off, l_cnt, nr_linfo;
9598 struct bpf_line_info *linfo;
9599
9600 nr_linfo = prog->aux->nr_linfo;
9601 if (!nr_linfo)
9602 return 0;
9603
9604 linfo = prog->aux->linfo;
9605
9606 /* find first line info to remove, count lines to be removed */
9607 for (i = 0; i < nr_linfo; i++)
9608 if (linfo[i].insn_off >= off)
9609 break;
9610
9611 l_off = i;
9612 l_cnt = 0;
9613 for (; i < nr_linfo; i++)
9614 if (linfo[i].insn_off < off + cnt)
9615 l_cnt++;
9616 else
9617 break;
9618
9619 /* First live insn doesn't match first live linfo, it needs to "inherit"
9620 * last removed linfo. prog is already modified, so prog->len == off
9621 * means no live instructions after (tail of the program was removed).
9622 */
9623 if (prog->len != off && l_cnt &&
9624 (i == nr_linfo || linfo[i].insn_off != off + cnt)) {
9625 l_cnt--;
9626 linfo[--i].insn_off = off + cnt;
9627 }
9628
9629 /* remove the line info which refer to the removed instructions */
9630 if (l_cnt) {
9631 memmove(linfo + l_off, linfo + i,
9632 sizeof(*linfo) * (nr_linfo - i));
9633
9634 prog->aux->nr_linfo -= l_cnt;
9635 nr_linfo = prog->aux->nr_linfo;
9636 }
9637
9638 /* pull all linfo[i].insn_off >= off + cnt in by cnt */
9639 for (i = l_off; i < nr_linfo; i++)
9640 linfo[i].insn_off -= cnt;
9641
9642 /* fix up all subprogs (incl. 'exit') which start >= off */
9643 for (i = 0; i <= env->subprog_cnt; i++)
9644 if (env->subprog_info[i].linfo_idx > l_off) {
9645 /* program may have started in the removed region but
9646 * may not be fully removed
9647 */
9648 if (env->subprog_info[i].linfo_idx >= l_off + l_cnt)
9649 env->subprog_info[i].linfo_idx -= l_cnt;
9650 else
9651 env->subprog_info[i].linfo_idx = l_off;
9652 }
9653
9654 return 0;
9655}
9656
9657static int verifier_remove_insns(struct bpf_verifier_env *env, u32 off, u32 cnt)
9658{
9659 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
9660 unsigned int orig_prog_len = env->prog->len;
9661 int err;
9662
08ca90af
JK
9663 if (bpf_prog_is_dev_bound(env->prog->aux))
9664 bpf_prog_offload_remove_insns(env, off, cnt);
9665
52875a04
JK
9666 err = bpf_remove_insns(env->prog, off, cnt);
9667 if (err)
9668 return err;
9669
9670 err = adjust_subprog_starts_after_remove(env, off, cnt);
9671 if (err)
9672 return err;
9673
9674 err = bpf_adj_linfo_after_remove(env, off, cnt);
9675 if (err)
9676 return err;
9677
9678 memmove(aux_data + off, aux_data + off + cnt,
9679 sizeof(*aux_data) * (orig_prog_len - off - cnt));
9680
9681 return 0;
9682}
9683
2a5418a1
DB
9684/* The verifier does more data flow analysis than llvm and will not
9685 * explore branches that are dead at run time. Malicious programs can
9686 * have dead code too. Therefore replace all dead at-run-time code
9687 * with 'ja -1'.
9688 *
9689 * Just nops are not optimal, e.g. if they would sit at the end of the
9690 * program and through another bug we would manage to jump there, then
9691 * we'd execute beyond program memory otherwise. Returning exception
9692 * code also wouldn't work since we can have subprogs where the dead
9693 * code could be located.
c131187d
AS
9694 */
9695static void sanitize_dead_code(struct bpf_verifier_env *env)
9696{
9697 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
2a5418a1 9698 struct bpf_insn trap = BPF_JMP_IMM(BPF_JA, 0, 0, -1);
c131187d
AS
9699 struct bpf_insn *insn = env->prog->insnsi;
9700 const int insn_cnt = env->prog->len;
9701 int i;
9702
9703 for (i = 0; i < insn_cnt; i++) {
9704 if (aux_data[i].seen)
9705 continue;
2a5418a1 9706 memcpy(insn + i, &trap, sizeof(trap));
c131187d
AS
9707 }
9708}
9709
e2ae4ca2
JK
9710static bool insn_is_cond_jump(u8 code)
9711{
9712 u8 op;
9713
092ed096
JW
9714 if (BPF_CLASS(code) == BPF_JMP32)
9715 return true;
9716
e2ae4ca2
JK
9717 if (BPF_CLASS(code) != BPF_JMP)
9718 return false;
9719
9720 op = BPF_OP(code);
9721 return op != BPF_JA && op != BPF_EXIT && op != BPF_CALL;
9722}
9723
9724static void opt_hard_wire_dead_code_branches(struct bpf_verifier_env *env)
9725{
9726 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
9727 struct bpf_insn ja = BPF_JMP_IMM(BPF_JA, 0, 0, 0);
9728 struct bpf_insn *insn = env->prog->insnsi;
9729 const int insn_cnt = env->prog->len;
9730 int i;
9731
9732 for (i = 0; i < insn_cnt; i++, insn++) {
9733 if (!insn_is_cond_jump(insn->code))
9734 continue;
9735
9736 if (!aux_data[i + 1].seen)
9737 ja.off = insn->off;
9738 else if (!aux_data[i + 1 + insn->off].seen)
9739 ja.off = 0;
9740 else
9741 continue;
9742
08ca90af
JK
9743 if (bpf_prog_is_dev_bound(env->prog->aux))
9744 bpf_prog_offload_replace_insn(env, i, &ja);
9745
e2ae4ca2
JK
9746 memcpy(insn, &ja, sizeof(ja));
9747 }
9748}
9749
52875a04
JK
9750static int opt_remove_dead_code(struct bpf_verifier_env *env)
9751{
9752 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
9753 int insn_cnt = env->prog->len;
9754 int i, err;
9755
9756 for (i = 0; i < insn_cnt; i++) {
9757 int j;
9758
9759 j = 0;
9760 while (i + j < insn_cnt && !aux_data[i + j].seen)
9761 j++;
9762 if (!j)
9763 continue;
9764
9765 err = verifier_remove_insns(env, i, j);
9766 if (err)
9767 return err;
9768 insn_cnt = env->prog->len;
9769 }
9770
9771 return 0;
9772}
9773
a1b14abc
JK
9774static int opt_remove_nops(struct bpf_verifier_env *env)
9775{
9776 const struct bpf_insn ja = BPF_JMP_IMM(BPF_JA, 0, 0, 0);
9777 struct bpf_insn *insn = env->prog->insnsi;
9778 int insn_cnt = env->prog->len;
9779 int i, err;
9780
9781 for (i = 0; i < insn_cnt; i++) {
9782 if (memcmp(&insn[i], &ja, sizeof(ja)))
9783 continue;
9784
9785 err = verifier_remove_insns(env, i, 1);
9786 if (err)
9787 return err;
9788 insn_cnt--;
9789 i--;
9790 }
9791
9792 return 0;
9793}
9794
d6c2308c
JW
9795static int opt_subreg_zext_lo32_rnd_hi32(struct bpf_verifier_env *env,
9796 const union bpf_attr *attr)
a4b1d3c1 9797{
d6c2308c 9798 struct bpf_insn *patch, zext_patch[2], rnd_hi32_patch[4];
a4b1d3c1 9799 struct bpf_insn_aux_data *aux = env->insn_aux_data;
d6c2308c 9800 int i, patch_len, delta = 0, len = env->prog->len;
a4b1d3c1 9801 struct bpf_insn *insns = env->prog->insnsi;
a4b1d3c1 9802 struct bpf_prog *new_prog;
d6c2308c 9803 bool rnd_hi32;
a4b1d3c1 9804
d6c2308c 9805 rnd_hi32 = attr->prog_flags & BPF_F_TEST_RND_HI32;
a4b1d3c1 9806 zext_patch[1] = BPF_ZEXT_REG(0);
d6c2308c
JW
9807 rnd_hi32_patch[1] = BPF_ALU64_IMM(BPF_MOV, BPF_REG_AX, 0);
9808 rnd_hi32_patch[2] = BPF_ALU64_IMM(BPF_LSH, BPF_REG_AX, 32);
9809 rnd_hi32_patch[3] = BPF_ALU64_REG(BPF_OR, 0, BPF_REG_AX);
a4b1d3c1
JW
9810 for (i = 0; i < len; i++) {
9811 int adj_idx = i + delta;
9812 struct bpf_insn insn;
9813
d6c2308c
JW
9814 insn = insns[adj_idx];
9815 if (!aux[adj_idx].zext_dst) {
9816 u8 code, class;
9817 u32 imm_rnd;
9818
9819 if (!rnd_hi32)
9820 continue;
9821
9822 code = insn.code;
9823 class = BPF_CLASS(code);
9824 if (insn_no_def(&insn))
9825 continue;
9826
9827 /* NOTE: arg "reg" (the fourth one) is only used for
9828 * BPF_STX which has been ruled out in above
9829 * check, it is safe to pass NULL here.
9830 */
9831 if (is_reg64(env, &insn, insn.dst_reg, NULL, DST_OP)) {
9832 if (class == BPF_LD &&
9833 BPF_MODE(code) == BPF_IMM)
9834 i++;
9835 continue;
9836 }
9837
9838 /* ctx load could be transformed into wider load. */
9839 if (class == BPF_LDX &&
9840 aux[adj_idx].ptr_type == PTR_TO_CTX)
9841 continue;
9842
9843 imm_rnd = get_random_int();
9844 rnd_hi32_patch[0] = insn;
9845 rnd_hi32_patch[1].imm = imm_rnd;
9846 rnd_hi32_patch[3].dst_reg = insn.dst_reg;
9847 patch = rnd_hi32_patch;
9848 patch_len = 4;
9849 goto apply_patch_buffer;
9850 }
9851
9852 if (!bpf_jit_needs_zext())
a4b1d3c1
JW
9853 continue;
9854
a4b1d3c1
JW
9855 zext_patch[0] = insn;
9856 zext_patch[1].dst_reg = insn.dst_reg;
9857 zext_patch[1].src_reg = insn.dst_reg;
d6c2308c
JW
9858 patch = zext_patch;
9859 patch_len = 2;
9860apply_patch_buffer:
9861 new_prog = bpf_patch_insn_data(env, adj_idx, patch, patch_len);
a4b1d3c1
JW
9862 if (!new_prog)
9863 return -ENOMEM;
9864 env->prog = new_prog;
9865 insns = new_prog->insnsi;
9866 aux = env->insn_aux_data;
d6c2308c 9867 delta += patch_len - 1;
a4b1d3c1
JW
9868 }
9869
9870 return 0;
9871}
9872
c64b7983
JS
9873/* convert load instructions that access fields of a context type into a
9874 * sequence of instructions that access fields of the underlying structure:
9875 * struct __sk_buff -> struct sk_buff
9876 * struct bpf_sock_ops -> struct sock
9bac3d6d 9877 */
58e2af8b 9878static int convert_ctx_accesses(struct bpf_verifier_env *env)
9bac3d6d 9879{
00176a34 9880 const struct bpf_verifier_ops *ops = env->ops;
f96da094 9881 int i, cnt, size, ctx_field_size, delta = 0;
3df126f3 9882 const int insn_cnt = env->prog->len;
36bbef52 9883 struct bpf_insn insn_buf[16], *insn;
46f53a65 9884 u32 target_size, size_default, off;
9bac3d6d 9885 struct bpf_prog *new_prog;
d691f9e8 9886 enum bpf_access_type type;
f96da094 9887 bool is_narrower_load;
9bac3d6d 9888
b09928b9
DB
9889 if (ops->gen_prologue || env->seen_direct_write) {
9890 if (!ops->gen_prologue) {
9891 verbose(env, "bpf verifier is misconfigured\n");
9892 return -EINVAL;
9893 }
36bbef52
DB
9894 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
9895 env->prog);
9896 if (cnt >= ARRAY_SIZE(insn_buf)) {
61bd5218 9897 verbose(env, "bpf verifier is misconfigured\n");
36bbef52
DB
9898 return -EINVAL;
9899 } else if (cnt) {
8041902d 9900 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
36bbef52
DB
9901 if (!new_prog)
9902 return -ENOMEM;
8041902d 9903
36bbef52 9904 env->prog = new_prog;
3df126f3 9905 delta += cnt - 1;
36bbef52
DB
9906 }
9907 }
9908
c64b7983 9909 if (bpf_prog_is_dev_bound(env->prog->aux))
9bac3d6d
AS
9910 return 0;
9911
3df126f3 9912 insn = env->prog->insnsi + delta;
36bbef52 9913
9bac3d6d 9914 for (i = 0; i < insn_cnt; i++, insn++) {
c64b7983
JS
9915 bpf_convert_ctx_access_t convert_ctx_access;
9916
62c7989b
DB
9917 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
9918 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
9919 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
ea2e7ce5 9920 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
d691f9e8 9921 type = BPF_READ;
62c7989b
DB
9922 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
9923 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
9924 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
ea2e7ce5 9925 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
d691f9e8
AS
9926 type = BPF_WRITE;
9927 else
9bac3d6d
AS
9928 continue;
9929
af86ca4e
AS
9930 if (type == BPF_WRITE &&
9931 env->insn_aux_data[i + delta].sanitize_stack_off) {
9932 struct bpf_insn patch[] = {
9933 /* Sanitize suspicious stack slot with zero.
9934 * There are no memory dependencies for this store,
9935 * since it's only using frame pointer and immediate
9936 * constant of zero
9937 */
9938 BPF_ST_MEM(BPF_DW, BPF_REG_FP,
9939 env->insn_aux_data[i + delta].sanitize_stack_off,
9940 0),
9941 /* the original STX instruction will immediately
9942 * overwrite the same stack slot with appropriate value
9943 */
9944 *insn,
9945 };
9946
9947 cnt = ARRAY_SIZE(patch);
9948 new_prog = bpf_patch_insn_data(env, i + delta, patch, cnt);
9949 if (!new_prog)
9950 return -ENOMEM;
9951
9952 delta += cnt - 1;
9953 env->prog = new_prog;
9954 insn = new_prog->insnsi + i + delta;
9955 continue;
9956 }
9957
c64b7983
JS
9958 switch (env->insn_aux_data[i + delta].ptr_type) {
9959 case PTR_TO_CTX:
9960 if (!ops->convert_ctx_access)
9961 continue;
9962 convert_ctx_access = ops->convert_ctx_access;
9963 break;
9964 case PTR_TO_SOCKET:
46f8bc92 9965 case PTR_TO_SOCK_COMMON:
c64b7983
JS
9966 convert_ctx_access = bpf_sock_convert_ctx_access;
9967 break;
655a51e5
MKL
9968 case PTR_TO_TCP_SOCK:
9969 convert_ctx_access = bpf_tcp_sock_convert_ctx_access;
9970 break;
fada7fdc
JL
9971 case PTR_TO_XDP_SOCK:
9972 convert_ctx_access = bpf_xdp_sock_convert_ctx_access;
9973 break;
2a02759e 9974 case PTR_TO_BTF_ID:
27ae7997
MKL
9975 if (type == BPF_READ) {
9976 insn->code = BPF_LDX | BPF_PROBE_MEM |
9977 BPF_SIZE((insn)->code);
9978 env->prog->aux->num_exentries++;
9979 } else if (env->prog->type != BPF_PROG_TYPE_STRUCT_OPS) {
2a02759e
AS
9980 verbose(env, "Writes through BTF pointers are not allowed\n");
9981 return -EINVAL;
9982 }
2a02759e 9983 continue;
c64b7983 9984 default:
9bac3d6d 9985 continue;
c64b7983 9986 }
9bac3d6d 9987
31fd8581 9988 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
f96da094 9989 size = BPF_LDST_BYTES(insn);
31fd8581
YS
9990
9991 /* If the read access is a narrower load of the field,
9992 * convert to a 4/8-byte load, to minimum program type specific
9993 * convert_ctx_access changes. If conversion is successful,
9994 * we will apply proper mask to the result.
9995 */
f96da094 9996 is_narrower_load = size < ctx_field_size;
46f53a65
AI
9997 size_default = bpf_ctx_off_adjust_machine(ctx_field_size);
9998 off = insn->off;
31fd8581 9999 if (is_narrower_load) {
f96da094
DB
10000 u8 size_code;
10001
10002 if (type == BPF_WRITE) {
61bd5218 10003 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
f96da094
DB
10004 return -EINVAL;
10005 }
31fd8581 10006
f96da094 10007 size_code = BPF_H;
31fd8581
YS
10008 if (ctx_field_size == 4)
10009 size_code = BPF_W;
10010 else if (ctx_field_size == 8)
10011 size_code = BPF_DW;
f96da094 10012
bc23105c 10013 insn->off = off & ~(size_default - 1);
31fd8581
YS
10014 insn->code = BPF_LDX | BPF_MEM | size_code;
10015 }
f96da094
DB
10016
10017 target_size = 0;
c64b7983
JS
10018 cnt = convert_ctx_access(type, insn, insn_buf, env->prog,
10019 &target_size);
f96da094
DB
10020 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
10021 (ctx_field_size && !target_size)) {
61bd5218 10022 verbose(env, "bpf verifier is misconfigured\n");
9bac3d6d
AS
10023 return -EINVAL;
10024 }
f96da094
DB
10025
10026 if (is_narrower_load && size < target_size) {
d895a0f1
IL
10027 u8 shift = bpf_ctx_narrow_access_offset(
10028 off, size, size_default) * 8;
46f53a65
AI
10029 if (ctx_field_size <= 4) {
10030 if (shift)
10031 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_RSH,
10032 insn->dst_reg,
10033 shift);
31fd8581 10034 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
f96da094 10035 (1 << size * 8) - 1);
46f53a65
AI
10036 } else {
10037 if (shift)
10038 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_RSH,
10039 insn->dst_reg,
10040 shift);
31fd8581 10041 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
e2f7fc0a 10042 (1ULL << size * 8) - 1);
46f53a65 10043 }
31fd8581 10044 }
9bac3d6d 10045
8041902d 10046 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
9bac3d6d
AS
10047 if (!new_prog)
10048 return -ENOMEM;
10049
3df126f3 10050 delta += cnt - 1;
9bac3d6d
AS
10051
10052 /* keep walking new program and skip insns we just inserted */
10053 env->prog = new_prog;
3df126f3 10054 insn = new_prog->insnsi + i + delta;
9bac3d6d
AS
10055 }
10056
10057 return 0;
10058}
10059
1c2a088a
AS
10060static int jit_subprogs(struct bpf_verifier_env *env)
10061{
10062 struct bpf_prog *prog = env->prog, **func, *tmp;
10063 int i, j, subprog_start, subprog_end = 0, len, subprog;
7105e828 10064 struct bpf_insn *insn;
1c2a088a 10065 void *old_bpf_func;
c4c0bdc0 10066 int err, num_exentries;
1c2a088a 10067
f910cefa 10068 if (env->subprog_cnt <= 1)
1c2a088a
AS
10069 return 0;
10070
7105e828 10071 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
1c2a088a
AS
10072 if (insn->code != (BPF_JMP | BPF_CALL) ||
10073 insn->src_reg != BPF_PSEUDO_CALL)
10074 continue;
c7a89784
DB
10075 /* Upon error here we cannot fall back to interpreter but
10076 * need a hard reject of the program. Thus -EFAULT is
10077 * propagated in any case.
10078 */
1c2a088a
AS
10079 subprog = find_subprog(env, i + insn->imm + 1);
10080 if (subprog < 0) {
10081 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
10082 i + insn->imm + 1);
10083 return -EFAULT;
10084 }
10085 /* temporarily remember subprog id inside insn instead of
10086 * aux_data, since next loop will split up all insns into funcs
10087 */
f910cefa 10088 insn->off = subprog;
1c2a088a
AS
10089 /* remember original imm in case JIT fails and fallback
10090 * to interpreter will be needed
10091 */
10092 env->insn_aux_data[i].call_imm = insn->imm;
10093 /* point imm to __bpf_call_base+1 from JITs point of view */
10094 insn->imm = 1;
10095 }
10096
c454a46b
MKL
10097 err = bpf_prog_alloc_jited_linfo(prog);
10098 if (err)
10099 goto out_undo_insn;
10100
10101 err = -ENOMEM;
6396bb22 10102 func = kcalloc(env->subprog_cnt, sizeof(prog), GFP_KERNEL);
1c2a088a 10103 if (!func)
c7a89784 10104 goto out_undo_insn;
1c2a088a 10105
f910cefa 10106 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a 10107 subprog_start = subprog_end;
4cb3d99c 10108 subprog_end = env->subprog_info[i + 1].start;
1c2a088a
AS
10109
10110 len = subprog_end - subprog_start;
492ecee8
AS
10111 /* BPF_PROG_RUN doesn't call subprogs directly,
10112 * hence main prog stats include the runtime of subprogs.
10113 * subprogs don't have IDs and not reachable via prog_get_next_id
10114 * func[i]->aux->stats will never be accessed and stays NULL
10115 */
10116 func[i] = bpf_prog_alloc_no_stats(bpf_prog_size(len), GFP_USER);
1c2a088a
AS
10117 if (!func[i])
10118 goto out_free;
10119 memcpy(func[i]->insnsi, &prog->insnsi[subprog_start],
10120 len * sizeof(struct bpf_insn));
4f74d809 10121 func[i]->type = prog->type;
1c2a088a 10122 func[i]->len = len;
4f74d809
DB
10123 if (bpf_prog_calc_tag(func[i]))
10124 goto out_free;
1c2a088a 10125 func[i]->is_func = 1;
ba64e7d8
YS
10126 func[i]->aux->func_idx = i;
10127 /* the btf and func_info will be freed only at prog->aux */
10128 func[i]->aux->btf = prog->aux->btf;
10129 func[i]->aux->func_info = prog->aux->func_info;
10130
1c2a088a
AS
10131 /* Use bpf_prog_F_tag to indicate functions in stack traces.
10132 * Long term would need debug info to populate names
10133 */
10134 func[i]->aux->name[0] = 'F';
9c8105bd 10135 func[i]->aux->stack_depth = env->subprog_info[i].stack_depth;
1c2a088a 10136 func[i]->jit_requested = 1;
c454a46b
MKL
10137 func[i]->aux->linfo = prog->aux->linfo;
10138 func[i]->aux->nr_linfo = prog->aux->nr_linfo;
10139 func[i]->aux->jited_linfo = prog->aux->jited_linfo;
10140 func[i]->aux->linfo_idx = env->subprog_info[i].linfo_idx;
c4c0bdc0
YS
10141 num_exentries = 0;
10142 insn = func[i]->insnsi;
10143 for (j = 0; j < func[i]->len; j++, insn++) {
10144 if (BPF_CLASS(insn->code) == BPF_LDX &&
10145 BPF_MODE(insn->code) == BPF_PROBE_MEM)
10146 num_exentries++;
10147 }
10148 func[i]->aux->num_exentries = num_exentries;
1c2a088a
AS
10149 func[i] = bpf_int_jit_compile(func[i]);
10150 if (!func[i]->jited) {
10151 err = -ENOTSUPP;
10152 goto out_free;
10153 }
10154 cond_resched();
10155 }
10156 /* at this point all bpf functions were successfully JITed
10157 * now populate all bpf_calls with correct addresses and
10158 * run last pass of JIT
10159 */
f910cefa 10160 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
10161 insn = func[i]->insnsi;
10162 for (j = 0; j < func[i]->len; j++, insn++) {
10163 if (insn->code != (BPF_JMP | BPF_CALL) ||
10164 insn->src_reg != BPF_PSEUDO_CALL)
10165 continue;
10166 subprog = insn->off;
0d306c31
PB
10167 insn->imm = BPF_CAST_CALL(func[subprog]->bpf_func) -
10168 __bpf_call_base;
1c2a088a 10169 }
2162fed4
SD
10170
10171 /* we use the aux data to keep a list of the start addresses
10172 * of the JITed images for each function in the program
10173 *
10174 * for some architectures, such as powerpc64, the imm field
10175 * might not be large enough to hold the offset of the start
10176 * address of the callee's JITed image from __bpf_call_base
10177 *
10178 * in such cases, we can lookup the start address of a callee
10179 * by using its subprog id, available from the off field of
10180 * the call instruction, as an index for this list
10181 */
10182 func[i]->aux->func = func;
10183 func[i]->aux->func_cnt = env->subprog_cnt;
1c2a088a 10184 }
f910cefa 10185 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
10186 old_bpf_func = func[i]->bpf_func;
10187 tmp = bpf_int_jit_compile(func[i]);
10188 if (tmp != func[i] || func[i]->bpf_func != old_bpf_func) {
10189 verbose(env, "JIT doesn't support bpf-to-bpf calls\n");
c7a89784 10190 err = -ENOTSUPP;
1c2a088a
AS
10191 goto out_free;
10192 }
10193 cond_resched();
10194 }
10195
10196 /* finally lock prog and jit images for all functions and
10197 * populate kallsysm
10198 */
f910cefa 10199 for (i = 0; i < env->subprog_cnt; i++) {
1c2a088a
AS
10200 bpf_prog_lock_ro(func[i]);
10201 bpf_prog_kallsyms_add(func[i]);
10202 }
7105e828
DB
10203
10204 /* Last step: make now unused interpreter insns from main
10205 * prog consistent for later dump requests, so they can
10206 * later look the same as if they were interpreted only.
10207 */
10208 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
7105e828
DB
10209 if (insn->code != (BPF_JMP | BPF_CALL) ||
10210 insn->src_reg != BPF_PSEUDO_CALL)
10211 continue;
10212 insn->off = env->insn_aux_data[i].call_imm;
10213 subprog = find_subprog(env, i + insn->off + 1);
dbecd738 10214 insn->imm = subprog;
7105e828
DB
10215 }
10216
1c2a088a
AS
10217 prog->jited = 1;
10218 prog->bpf_func = func[0]->bpf_func;
10219 prog->aux->func = func;
f910cefa 10220 prog->aux->func_cnt = env->subprog_cnt;
c454a46b 10221 bpf_prog_free_unused_jited_linfo(prog);
1c2a088a
AS
10222 return 0;
10223out_free:
f910cefa 10224 for (i = 0; i < env->subprog_cnt; i++)
1c2a088a
AS
10225 if (func[i])
10226 bpf_jit_free(func[i]);
10227 kfree(func);
c7a89784 10228out_undo_insn:
1c2a088a
AS
10229 /* cleanup main prog to be interpreted */
10230 prog->jit_requested = 0;
10231 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
10232 if (insn->code != (BPF_JMP | BPF_CALL) ||
10233 insn->src_reg != BPF_PSEUDO_CALL)
10234 continue;
10235 insn->off = 0;
10236 insn->imm = env->insn_aux_data[i].call_imm;
10237 }
c454a46b 10238 bpf_prog_free_jited_linfo(prog);
1c2a088a
AS
10239 return err;
10240}
10241
1ea47e01
AS
10242static int fixup_call_args(struct bpf_verifier_env *env)
10243{
19d28fbd 10244#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
10245 struct bpf_prog *prog = env->prog;
10246 struct bpf_insn *insn = prog->insnsi;
10247 int i, depth;
19d28fbd 10248#endif
e4052d06 10249 int err = 0;
1ea47e01 10250
e4052d06
QM
10251 if (env->prog->jit_requested &&
10252 !bpf_prog_is_dev_bound(env->prog->aux)) {
19d28fbd
DM
10253 err = jit_subprogs(env);
10254 if (err == 0)
1c2a088a 10255 return 0;
c7a89784
DB
10256 if (err == -EFAULT)
10257 return err;
19d28fbd
DM
10258 }
10259#ifndef CONFIG_BPF_JIT_ALWAYS_ON
1ea47e01
AS
10260 for (i = 0; i < prog->len; i++, insn++) {
10261 if (insn->code != (BPF_JMP | BPF_CALL) ||
10262 insn->src_reg != BPF_PSEUDO_CALL)
10263 continue;
10264 depth = get_callee_stack_depth(env, insn, i);
10265 if (depth < 0)
10266 return depth;
10267 bpf_patch_call_args(insn, depth);
10268 }
19d28fbd
DM
10269 err = 0;
10270#endif
10271 return err;
1ea47e01
AS
10272}
10273
79741b3b 10274/* fixup insn->imm field of bpf_call instructions
81ed18ab 10275 * and inline eligible helpers as explicit sequence of BPF instructions
e245c5c6
AS
10276 *
10277 * this function is called after eBPF program passed verification
10278 */
79741b3b 10279static int fixup_bpf_calls(struct bpf_verifier_env *env)
e245c5c6 10280{
79741b3b 10281 struct bpf_prog *prog = env->prog;
d2e4c1e6 10282 bool expect_blinding = bpf_jit_blinding_enabled(prog);
79741b3b 10283 struct bpf_insn *insn = prog->insnsi;
e245c5c6 10284 const struct bpf_func_proto *fn;
79741b3b 10285 const int insn_cnt = prog->len;
09772d92 10286 const struct bpf_map_ops *ops;
c93552c4 10287 struct bpf_insn_aux_data *aux;
81ed18ab
AS
10288 struct bpf_insn insn_buf[16];
10289 struct bpf_prog *new_prog;
10290 struct bpf_map *map_ptr;
d2e4c1e6 10291 int i, ret, cnt, delta = 0;
e245c5c6 10292
79741b3b 10293 for (i = 0; i < insn_cnt; i++, insn++) {
f6b1b3bf
DB
10294 if (insn->code == (BPF_ALU64 | BPF_MOD | BPF_X) ||
10295 insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
10296 insn->code == (BPF_ALU | BPF_MOD | BPF_X) ||
68fda450 10297 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
f6b1b3bf
DB
10298 bool is64 = BPF_CLASS(insn->code) == BPF_ALU64;
10299 struct bpf_insn mask_and_div[] = {
10300 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
10301 /* Rx div 0 -> 0 */
10302 BPF_JMP_IMM(BPF_JNE, insn->src_reg, 0, 2),
10303 BPF_ALU32_REG(BPF_XOR, insn->dst_reg, insn->dst_reg),
10304 BPF_JMP_IMM(BPF_JA, 0, 0, 1),
10305 *insn,
10306 };
10307 struct bpf_insn mask_and_mod[] = {
10308 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
10309 /* Rx mod 0 -> Rx */
10310 BPF_JMP_IMM(BPF_JEQ, insn->src_reg, 0, 1),
10311 *insn,
10312 };
10313 struct bpf_insn *patchlet;
10314
10315 if (insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
10316 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
10317 patchlet = mask_and_div + (is64 ? 1 : 0);
10318 cnt = ARRAY_SIZE(mask_and_div) - (is64 ? 1 : 0);
10319 } else {
10320 patchlet = mask_and_mod + (is64 ? 1 : 0);
10321 cnt = ARRAY_SIZE(mask_and_mod) - (is64 ? 1 : 0);
10322 }
10323
10324 new_prog = bpf_patch_insn_data(env, i + delta, patchlet, cnt);
68fda450
AS
10325 if (!new_prog)
10326 return -ENOMEM;
10327
10328 delta += cnt - 1;
10329 env->prog = prog = new_prog;
10330 insn = new_prog->insnsi + i + delta;
10331 continue;
10332 }
10333
e0cea7ce
DB
10334 if (BPF_CLASS(insn->code) == BPF_LD &&
10335 (BPF_MODE(insn->code) == BPF_ABS ||
10336 BPF_MODE(insn->code) == BPF_IND)) {
10337 cnt = env->ops->gen_ld_abs(insn, insn_buf);
10338 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
10339 verbose(env, "bpf verifier is misconfigured\n");
10340 return -EINVAL;
10341 }
10342
10343 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
10344 if (!new_prog)
10345 return -ENOMEM;
10346
10347 delta += cnt - 1;
10348 env->prog = prog = new_prog;
10349 insn = new_prog->insnsi + i + delta;
10350 continue;
10351 }
10352
979d63d5
DB
10353 if (insn->code == (BPF_ALU64 | BPF_ADD | BPF_X) ||
10354 insn->code == (BPF_ALU64 | BPF_SUB | BPF_X)) {
10355 const u8 code_add = BPF_ALU64 | BPF_ADD | BPF_X;
10356 const u8 code_sub = BPF_ALU64 | BPF_SUB | BPF_X;
10357 struct bpf_insn insn_buf[16];
10358 struct bpf_insn *patch = &insn_buf[0];
10359 bool issrc, isneg;
10360 u32 off_reg;
10361
10362 aux = &env->insn_aux_data[i + delta];
3612af78
DB
10363 if (!aux->alu_state ||
10364 aux->alu_state == BPF_ALU_NON_POINTER)
979d63d5
DB
10365 continue;
10366
10367 isneg = aux->alu_state & BPF_ALU_NEG_VALUE;
10368 issrc = (aux->alu_state & BPF_ALU_SANITIZE) ==
10369 BPF_ALU_SANITIZE_SRC;
10370
10371 off_reg = issrc ? insn->src_reg : insn->dst_reg;
10372 if (isneg)
10373 *patch++ = BPF_ALU64_IMM(BPF_MUL, off_reg, -1);
10374 *patch++ = BPF_MOV32_IMM(BPF_REG_AX, aux->alu_limit - 1);
10375 *patch++ = BPF_ALU64_REG(BPF_SUB, BPF_REG_AX, off_reg);
10376 *patch++ = BPF_ALU64_REG(BPF_OR, BPF_REG_AX, off_reg);
10377 *patch++ = BPF_ALU64_IMM(BPF_NEG, BPF_REG_AX, 0);
10378 *patch++ = BPF_ALU64_IMM(BPF_ARSH, BPF_REG_AX, 63);
10379 if (issrc) {
10380 *patch++ = BPF_ALU64_REG(BPF_AND, BPF_REG_AX,
10381 off_reg);
10382 insn->src_reg = BPF_REG_AX;
10383 } else {
10384 *patch++ = BPF_ALU64_REG(BPF_AND, off_reg,
10385 BPF_REG_AX);
10386 }
10387 if (isneg)
10388 insn->code = insn->code == code_add ?
10389 code_sub : code_add;
10390 *patch++ = *insn;
10391 if (issrc && isneg)
10392 *patch++ = BPF_ALU64_IMM(BPF_MUL, off_reg, -1);
10393 cnt = patch - insn_buf;
10394
10395 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
10396 if (!new_prog)
10397 return -ENOMEM;
10398
10399 delta += cnt - 1;
10400 env->prog = prog = new_prog;
10401 insn = new_prog->insnsi + i + delta;
10402 continue;
10403 }
10404
79741b3b
AS
10405 if (insn->code != (BPF_JMP | BPF_CALL))
10406 continue;
cc8b0b92
AS
10407 if (insn->src_reg == BPF_PSEUDO_CALL)
10408 continue;
e245c5c6 10409
79741b3b
AS
10410 if (insn->imm == BPF_FUNC_get_route_realm)
10411 prog->dst_needed = 1;
10412 if (insn->imm == BPF_FUNC_get_prandom_u32)
10413 bpf_user_rnd_init_once();
9802d865
JB
10414 if (insn->imm == BPF_FUNC_override_return)
10415 prog->kprobe_override = 1;
79741b3b 10416 if (insn->imm == BPF_FUNC_tail_call) {
7b9f6da1
DM
10417 /* If we tail call into other programs, we
10418 * cannot make any assumptions since they can
10419 * be replaced dynamically during runtime in
10420 * the program array.
10421 */
10422 prog->cb_access = 1;
80a58d02 10423 env->prog->aux->stack_depth = MAX_BPF_STACK;
e647815a 10424 env->prog->aux->max_pkt_offset = MAX_PACKET_OFF;
7b9f6da1 10425
79741b3b
AS
10426 /* mark bpf_tail_call as different opcode to avoid
10427 * conditional branch in the interpeter for every normal
10428 * call and to prevent accidental JITing by JIT compiler
10429 * that doesn't support bpf_tail_call yet
e245c5c6 10430 */
79741b3b 10431 insn->imm = 0;
71189fa9 10432 insn->code = BPF_JMP | BPF_TAIL_CALL;
b2157399 10433
c93552c4 10434 aux = &env->insn_aux_data[i + delta];
2c78ee89 10435 if (env->bpf_capable && !expect_blinding &&
cc52d914 10436 prog->jit_requested &&
d2e4c1e6
DB
10437 !bpf_map_key_poisoned(aux) &&
10438 !bpf_map_ptr_poisoned(aux) &&
10439 !bpf_map_ptr_unpriv(aux)) {
10440 struct bpf_jit_poke_descriptor desc = {
10441 .reason = BPF_POKE_REASON_TAIL_CALL,
10442 .tail_call.map = BPF_MAP_PTR(aux->map_ptr_state),
10443 .tail_call.key = bpf_map_key_immediate(aux),
10444 };
10445
10446 ret = bpf_jit_add_poke_descriptor(prog, &desc);
10447 if (ret < 0) {
10448 verbose(env, "adding tail call poke descriptor failed\n");
10449 return ret;
10450 }
10451
10452 insn->imm = ret + 1;
10453 continue;
10454 }
10455
c93552c4
DB
10456 if (!bpf_map_ptr_unpriv(aux))
10457 continue;
10458
b2157399
AS
10459 /* instead of changing every JIT dealing with tail_call
10460 * emit two extra insns:
10461 * if (index >= max_entries) goto out;
10462 * index &= array->index_mask;
10463 * to avoid out-of-bounds cpu speculation
10464 */
c93552c4 10465 if (bpf_map_ptr_poisoned(aux)) {
40950343 10466 verbose(env, "tail_call abusing map_ptr\n");
b2157399
AS
10467 return -EINVAL;
10468 }
c93552c4 10469
d2e4c1e6 10470 map_ptr = BPF_MAP_PTR(aux->map_ptr_state);
b2157399
AS
10471 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
10472 map_ptr->max_entries, 2);
10473 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
10474 container_of(map_ptr,
10475 struct bpf_array,
10476 map)->index_mask);
10477 insn_buf[2] = *insn;
10478 cnt = 3;
10479 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
10480 if (!new_prog)
10481 return -ENOMEM;
10482
10483 delta += cnt - 1;
10484 env->prog = prog = new_prog;
10485 insn = new_prog->insnsi + i + delta;
79741b3b
AS
10486 continue;
10487 }
e245c5c6 10488
89c63074 10489 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
09772d92
DB
10490 * and other inlining handlers are currently limited to 64 bit
10491 * only.
89c63074 10492 */
60b58afc 10493 if (prog->jit_requested && BITS_PER_LONG == 64 &&
09772d92
DB
10494 (insn->imm == BPF_FUNC_map_lookup_elem ||
10495 insn->imm == BPF_FUNC_map_update_elem ||
84430d42
DB
10496 insn->imm == BPF_FUNC_map_delete_elem ||
10497 insn->imm == BPF_FUNC_map_push_elem ||
10498 insn->imm == BPF_FUNC_map_pop_elem ||
10499 insn->imm == BPF_FUNC_map_peek_elem)) {
c93552c4
DB
10500 aux = &env->insn_aux_data[i + delta];
10501 if (bpf_map_ptr_poisoned(aux))
10502 goto patch_call_imm;
10503
d2e4c1e6 10504 map_ptr = BPF_MAP_PTR(aux->map_ptr_state);
09772d92
DB
10505 ops = map_ptr->ops;
10506 if (insn->imm == BPF_FUNC_map_lookup_elem &&
10507 ops->map_gen_lookup) {
10508 cnt = ops->map_gen_lookup(map_ptr, insn_buf);
10509 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
10510 verbose(env, "bpf verifier is misconfigured\n");
10511 return -EINVAL;
10512 }
81ed18ab 10513
09772d92
DB
10514 new_prog = bpf_patch_insn_data(env, i + delta,
10515 insn_buf, cnt);
10516 if (!new_prog)
10517 return -ENOMEM;
81ed18ab 10518
09772d92
DB
10519 delta += cnt - 1;
10520 env->prog = prog = new_prog;
10521 insn = new_prog->insnsi + i + delta;
10522 continue;
10523 }
81ed18ab 10524
09772d92
DB
10525 BUILD_BUG_ON(!__same_type(ops->map_lookup_elem,
10526 (void *(*)(struct bpf_map *map, void *key))NULL));
10527 BUILD_BUG_ON(!__same_type(ops->map_delete_elem,
10528 (int (*)(struct bpf_map *map, void *key))NULL));
10529 BUILD_BUG_ON(!__same_type(ops->map_update_elem,
10530 (int (*)(struct bpf_map *map, void *key, void *value,
10531 u64 flags))NULL));
84430d42
DB
10532 BUILD_BUG_ON(!__same_type(ops->map_push_elem,
10533 (int (*)(struct bpf_map *map, void *value,
10534 u64 flags))NULL));
10535 BUILD_BUG_ON(!__same_type(ops->map_pop_elem,
10536 (int (*)(struct bpf_map *map, void *value))NULL));
10537 BUILD_BUG_ON(!__same_type(ops->map_peek_elem,
10538 (int (*)(struct bpf_map *map, void *value))NULL));
10539
09772d92
DB
10540 switch (insn->imm) {
10541 case BPF_FUNC_map_lookup_elem:
10542 insn->imm = BPF_CAST_CALL(ops->map_lookup_elem) -
10543 __bpf_call_base;
10544 continue;
10545 case BPF_FUNC_map_update_elem:
10546 insn->imm = BPF_CAST_CALL(ops->map_update_elem) -
10547 __bpf_call_base;
10548 continue;
10549 case BPF_FUNC_map_delete_elem:
10550 insn->imm = BPF_CAST_CALL(ops->map_delete_elem) -
10551 __bpf_call_base;
10552 continue;
84430d42
DB
10553 case BPF_FUNC_map_push_elem:
10554 insn->imm = BPF_CAST_CALL(ops->map_push_elem) -
10555 __bpf_call_base;
10556 continue;
10557 case BPF_FUNC_map_pop_elem:
10558 insn->imm = BPF_CAST_CALL(ops->map_pop_elem) -
10559 __bpf_call_base;
10560 continue;
10561 case BPF_FUNC_map_peek_elem:
10562 insn->imm = BPF_CAST_CALL(ops->map_peek_elem) -
10563 __bpf_call_base;
10564 continue;
09772d92 10565 }
81ed18ab 10566
09772d92 10567 goto patch_call_imm;
81ed18ab
AS
10568 }
10569
5576b991
MKL
10570 if (prog->jit_requested && BITS_PER_LONG == 64 &&
10571 insn->imm == BPF_FUNC_jiffies64) {
10572 struct bpf_insn ld_jiffies_addr[2] = {
10573 BPF_LD_IMM64(BPF_REG_0,
10574 (unsigned long)&jiffies),
10575 };
10576
10577 insn_buf[0] = ld_jiffies_addr[0];
10578 insn_buf[1] = ld_jiffies_addr[1];
10579 insn_buf[2] = BPF_LDX_MEM(BPF_DW, BPF_REG_0,
10580 BPF_REG_0, 0);
10581 cnt = 3;
10582
10583 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
10584 cnt);
10585 if (!new_prog)
10586 return -ENOMEM;
10587
10588 delta += cnt - 1;
10589 env->prog = prog = new_prog;
10590 insn = new_prog->insnsi + i + delta;
10591 continue;
10592 }
10593
81ed18ab 10594patch_call_imm:
5e43f899 10595 fn = env->ops->get_func_proto(insn->imm, env->prog);
79741b3b
AS
10596 /* all functions that have prototype and verifier allowed
10597 * programs to call them, must be real in-kernel functions
10598 */
10599 if (!fn->func) {
61bd5218
JK
10600 verbose(env,
10601 "kernel subsystem misconfigured func %s#%d\n",
79741b3b
AS
10602 func_id_name(insn->imm), insn->imm);
10603 return -EFAULT;
e245c5c6 10604 }
79741b3b 10605 insn->imm = fn->func - __bpf_call_base;
e245c5c6 10606 }
e245c5c6 10607
d2e4c1e6
DB
10608 /* Since poke tab is now finalized, publish aux to tracker. */
10609 for (i = 0; i < prog->aux->size_poke_tab; i++) {
10610 map_ptr = prog->aux->poke_tab[i].tail_call.map;
10611 if (!map_ptr->ops->map_poke_track ||
10612 !map_ptr->ops->map_poke_untrack ||
10613 !map_ptr->ops->map_poke_run) {
10614 verbose(env, "bpf verifier is misconfigured\n");
10615 return -EINVAL;
10616 }
10617
10618 ret = map_ptr->ops->map_poke_track(map_ptr, prog->aux);
10619 if (ret < 0) {
10620 verbose(env, "tracking tail call prog failed\n");
10621 return ret;
10622 }
10623 }
10624
79741b3b
AS
10625 return 0;
10626}
e245c5c6 10627
58e2af8b 10628static void free_states(struct bpf_verifier_env *env)
f1bca824 10629{
58e2af8b 10630 struct bpf_verifier_state_list *sl, *sln;
f1bca824
AS
10631 int i;
10632
9f4686c4
AS
10633 sl = env->free_list;
10634 while (sl) {
10635 sln = sl->next;
10636 free_verifier_state(&sl->state, false);
10637 kfree(sl);
10638 sl = sln;
10639 }
51c39bb1 10640 env->free_list = NULL;
9f4686c4 10641
f1bca824
AS
10642 if (!env->explored_states)
10643 return;
10644
dc2a4ebc 10645 for (i = 0; i < state_htab_size(env); i++) {
f1bca824
AS
10646 sl = env->explored_states[i];
10647
a8f500af
AS
10648 while (sl) {
10649 sln = sl->next;
10650 free_verifier_state(&sl->state, false);
10651 kfree(sl);
10652 sl = sln;
10653 }
51c39bb1 10654 env->explored_states[i] = NULL;
f1bca824 10655 }
51c39bb1 10656}
f1bca824 10657
51c39bb1
AS
10658/* The verifier is using insn_aux_data[] to store temporary data during
10659 * verification and to store information for passes that run after the
10660 * verification like dead code sanitization. do_check_common() for subprogram N
10661 * may analyze many other subprograms. sanitize_insn_aux_data() clears all
10662 * temporary data after do_check_common() finds that subprogram N cannot be
10663 * verified independently. pass_cnt counts the number of times
10664 * do_check_common() was run and insn->aux->seen tells the pass number
10665 * insn_aux_data was touched. These variables are compared to clear temporary
10666 * data from failed pass. For testing and experiments do_check_common() can be
10667 * run multiple times even when prior attempt to verify is unsuccessful.
10668 */
10669static void sanitize_insn_aux_data(struct bpf_verifier_env *env)
10670{
10671 struct bpf_insn *insn = env->prog->insnsi;
10672 struct bpf_insn_aux_data *aux;
10673 int i, class;
10674
10675 for (i = 0; i < env->prog->len; i++) {
10676 class = BPF_CLASS(insn[i].code);
10677 if (class != BPF_LDX && class != BPF_STX)
10678 continue;
10679 aux = &env->insn_aux_data[i];
10680 if (aux->seen != env->pass_cnt)
10681 continue;
10682 memset(aux, 0, offsetof(typeof(*aux), orig_idx));
10683 }
f1bca824
AS
10684}
10685
51c39bb1
AS
10686static int do_check_common(struct bpf_verifier_env *env, int subprog)
10687{
6f8a57cc 10688 bool pop_log = !(env->log.level & BPF_LOG_LEVEL2);
51c39bb1
AS
10689 struct bpf_verifier_state *state;
10690 struct bpf_reg_state *regs;
10691 int ret, i;
10692
10693 env->prev_linfo = NULL;
10694 env->pass_cnt++;
10695
10696 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
10697 if (!state)
10698 return -ENOMEM;
10699 state->curframe = 0;
10700 state->speculative = false;
10701 state->branches = 1;
10702 state->frame[0] = kzalloc(sizeof(struct bpf_func_state), GFP_KERNEL);
10703 if (!state->frame[0]) {
10704 kfree(state);
10705 return -ENOMEM;
10706 }
10707 env->cur_state = state;
10708 init_func_state(env, state->frame[0],
10709 BPF_MAIN_FUNC /* callsite */,
10710 0 /* frameno */,
10711 subprog);
10712
10713 regs = state->frame[state->curframe]->regs;
be8704ff 10714 if (subprog || env->prog->type == BPF_PROG_TYPE_EXT) {
51c39bb1
AS
10715 ret = btf_prepare_func_args(env, subprog, regs);
10716 if (ret)
10717 goto out;
10718 for (i = BPF_REG_1; i <= BPF_REG_5; i++) {
10719 if (regs[i].type == PTR_TO_CTX)
10720 mark_reg_known_zero(env, regs, i);
10721 else if (regs[i].type == SCALAR_VALUE)
10722 mark_reg_unknown(env, regs, i);
10723 }
10724 } else {
10725 /* 1st arg to a function */
10726 regs[BPF_REG_1].type = PTR_TO_CTX;
10727 mark_reg_known_zero(env, regs, BPF_REG_1);
10728 ret = btf_check_func_arg_match(env, subprog, regs);
10729 if (ret == -EFAULT)
10730 /* unlikely verifier bug. abort.
10731 * ret == 0 and ret < 0 are sadly acceptable for
10732 * main() function due to backward compatibility.
10733 * Like socket filter program may be written as:
10734 * int bpf_prog(struct pt_regs *ctx)
10735 * and never dereference that ctx in the program.
10736 * 'struct pt_regs' is a type mismatch for socket
10737 * filter that should be using 'struct __sk_buff'.
10738 */
10739 goto out;
10740 }
10741
10742 ret = do_check(env);
10743out:
f59bbfc2
AS
10744 /* check for NULL is necessary, since cur_state can be freed inside
10745 * do_check() under memory pressure.
10746 */
10747 if (env->cur_state) {
10748 free_verifier_state(env->cur_state, true);
10749 env->cur_state = NULL;
10750 }
6f8a57cc
AN
10751 while (!pop_stack(env, NULL, NULL, false));
10752 if (!ret && pop_log)
10753 bpf_vlog_reset(&env->log, 0);
51c39bb1
AS
10754 free_states(env);
10755 if (ret)
10756 /* clean aux data in case subprog was rejected */
10757 sanitize_insn_aux_data(env);
10758 return ret;
10759}
10760
10761/* Verify all global functions in a BPF program one by one based on their BTF.
10762 * All global functions must pass verification. Otherwise the whole program is rejected.
10763 * Consider:
10764 * int bar(int);
10765 * int foo(int f)
10766 * {
10767 * return bar(f);
10768 * }
10769 * int bar(int b)
10770 * {
10771 * ...
10772 * }
10773 * foo() will be verified first for R1=any_scalar_value. During verification it
10774 * will be assumed that bar() already verified successfully and call to bar()
10775 * from foo() will be checked for type match only. Later bar() will be verified
10776 * independently to check that it's safe for R1=any_scalar_value.
10777 */
10778static int do_check_subprogs(struct bpf_verifier_env *env)
10779{
10780 struct bpf_prog_aux *aux = env->prog->aux;
10781 int i, ret;
10782
10783 if (!aux->func_info)
10784 return 0;
10785
10786 for (i = 1; i < env->subprog_cnt; i++) {
10787 if (aux->func_info_aux[i].linkage != BTF_FUNC_GLOBAL)
10788 continue;
10789 env->insn_idx = env->subprog_info[i].start;
10790 WARN_ON_ONCE(env->insn_idx == 0);
10791 ret = do_check_common(env, i);
10792 if (ret) {
10793 return ret;
10794 } else if (env->log.level & BPF_LOG_LEVEL) {
10795 verbose(env,
10796 "Func#%d is safe for any args that match its prototype\n",
10797 i);
10798 }
10799 }
10800 return 0;
10801}
10802
10803static int do_check_main(struct bpf_verifier_env *env)
10804{
10805 int ret;
10806
10807 env->insn_idx = 0;
10808 ret = do_check_common(env, 0);
10809 if (!ret)
10810 env->prog->aux->stack_depth = env->subprog_info[0].stack_depth;
10811 return ret;
10812}
10813
10814
06ee7115
AS
10815static void print_verification_stats(struct bpf_verifier_env *env)
10816{
10817 int i;
10818
10819 if (env->log.level & BPF_LOG_STATS) {
10820 verbose(env, "verification time %lld usec\n",
10821 div_u64(env->verification_time, 1000));
10822 verbose(env, "stack depth ");
10823 for (i = 0; i < env->subprog_cnt; i++) {
10824 u32 depth = env->subprog_info[i].stack_depth;
10825
10826 verbose(env, "%d", depth);
10827 if (i + 1 < env->subprog_cnt)
10828 verbose(env, "+");
10829 }
10830 verbose(env, "\n");
10831 }
10832 verbose(env, "processed %d insns (limit %d) max_states_per_insn %d "
10833 "total_states %d peak_states %d mark_read %d\n",
10834 env->insn_processed, BPF_COMPLEXITY_LIMIT_INSNS,
10835 env->max_states_per_insn, env->total_states,
10836 env->peak_states, env->longest_mark_read_walk);
f1bca824
AS
10837}
10838
27ae7997
MKL
10839static int check_struct_ops_btf_id(struct bpf_verifier_env *env)
10840{
10841 const struct btf_type *t, *func_proto;
10842 const struct bpf_struct_ops *st_ops;
10843 const struct btf_member *member;
10844 struct bpf_prog *prog = env->prog;
10845 u32 btf_id, member_idx;
10846 const char *mname;
10847
10848 btf_id = prog->aux->attach_btf_id;
10849 st_ops = bpf_struct_ops_find(btf_id);
10850 if (!st_ops) {
10851 verbose(env, "attach_btf_id %u is not a supported struct\n",
10852 btf_id);
10853 return -ENOTSUPP;
10854 }
10855
10856 t = st_ops->type;
10857 member_idx = prog->expected_attach_type;
10858 if (member_idx >= btf_type_vlen(t)) {
10859 verbose(env, "attach to invalid member idx %u of struct %s\n",
10860 member_idx, st_ops->name);
10861 return -EINVAL;
10862 }
10863
10864 member = &btf_type_member(t)[member_idx];
10865 mname = btf_name_by_offset(btf_vmlinux, member->name_off);
10866 func_proto = btf_type_resolve_func_ptr(btf_vmlinux, member->type,
10867 NULL);
10868 if (!func_proto) {
10869 verbose(env, "attach to invalid member %s(@idx %u) of struct %s\n",
10870 mname, member_idx, st_ops->name);
10871 return -EINVAL;
10872 }
10873
10874 if (st_ops->check_member) {
10875 int err = st_ops->check_member(t, member);
10876
10877 if (err) {
10878 verbose(env, "attach to unsupported member %s of struct %s\n",
10879 mname, st_ops->name);
10880 return err;
10881 }
10882 }
10883
10884 prog->aux->attach_func_proto = func_proto;
10885 prog->aux->attach_func_name = mname;
10886 env->ops = st_ops->verifier_ops;
10887
10888 return 0;
10889}
6ba43b76
KS
10890#define SECURITY_PREFIX "security_"
10891
18644cec 10892static int check_attach_modify_return(struct bpf_prog *prog, unsigned long addr)
6ba43b76 10893{
69191754
KS
10894 if (within_error_injection_list(addr) ||
10895 !strncmp(SECURITY_PREFIX, prog->aux->attach_func_name,
10896 sizeof(SECURITY_PREFIX) - 1))
6ba43b76 10897 return 0;
6ba43b76 10898
6ba43b76
KS
10899 return -EINVAL;
10900}
27ae7997 10901
38207291
MKL
10902static int check_attach_btf_id(struct bpf_verifier_env *env)
10903{
10904 struct bpf_prog *prog = env->prog;
be8704ff 10905 bool prog_extension = prog->type == BPF_PROG_TYPE_EXT;
5b92a28a 10906 struct bpf_prog *tgt_prog = prog->aux->linked_prog;
38207291 10907 u32 btf_id = prog->aux->attach_btf_id;
f1b9509c 10908 const char prefix[] = "btf_trace_";
15d83c4d 10909 struct btf_func_model fmodel;
5b92a28a 10910 int ret = 0, subprog = -1, i;
fec56f58 10911 struct bpf_trampoline *tr;
38207291 10912 const struct btf_type *t;
5b92a28a 10913 bool conservative = true;
38207291 10914 const char *tname;
5b92a28a 10915 struct btf *btf;
fec56f58 10916 long addr;
5b92a28a 10917 u64 key;
38207291 10918
27ae7997
MKL
10919 if (prog->type == BPF_PROG_TYPE_STRUCT_OPS)
10920 return check_struct_ops_btf_id(env);
10921
9e4e01df
KS
10922 if (prog->type != BPF_PROG_TYPE_TRACING &&
10923 prog->type != BPF_PROG_TYPE_LSM &&
10924 !prog_extension)
f1b9509c 10925 return 0;
38207291 10926
f1b9509c
AS
10927 if (!btf_id) {
10928 verbose(env, "Tracing programs must provide btf_id\n");
10929 return -EINVAL;
10930 }
5b92a28a
AS
10931 btf = bpf_prog_get_target_btf(prog);
10932 if (!btf) {
10933 verbose(env,
10934 "FENTRY/FEXIT program can only be attached to another program annotated with BTF\n");
10935 return -EINVAL;
10936 }
10937 t = btf_type_by_id(btf, btf_id);
f1b9509c
AS
10938 if (!t) {
10939 verbose(env, "attach_btf_id %u is invalid\n", btf_id);
10940 return -EINVAL;
10941 }
5b92a28a 10942 tname = btf_name_by_offset(btf, t->name_off);
f1b9509c
AS
10943 if (!tname) {
10944 verbose(env, "attach_btf_id %u doesn't have a name\n", btf_id);
10945 return -EINVAL;
10946 }
5b92a28a
AS
10947 if (tgt_prog) {
10948 struct bpf_prog_aux *aux = tgt_prog->aux;
10949
10950 for (i = 0; i < aux->func_info_cnt; i++)
10951 if (aux->func_info[i].type_id == btf_id) {
10952 subprog = i;
10953 break;
10954 }
10955 if (subprog == -1) {
10956 verbose(env, "Subprog %s doesn't exist\n", tname);
10957 return -EINVAL;
10958 }
10959 conservative = aux->func_info_aux[subprog].unreliable;
be8704ff
AS
10960 if (prog_extension) {
10961 if (conservative) {
10962 verbose(env,
10963 "Cannot replace static functions\n");
10964 return -EINVAL;
10965 }
10966 if (!prog->jit_requested) {
10967 verbose(env,
10968 "Extension programs should be JITed\n");
10969 return -EINVAL;
10970 }
10971 env->ops = bpf_verifier_ops[tgt_prog->type];
03f87c0b 10972 prog->expected_attach_type = tgt_prog->expected_attach_type;
be8704ff
AS
10973 }
10974 if (!tgt_prog->jited) {
10975 verbose(env, "Can attach to only JITed progs\n");
10976 return -EINVAL;
10977 }
10978 if (tgt_prog->type == prog->type) {
10979 /* Cannot fentry/fexit another fentry/fexit program.
10980 * Cannot attach program extension to another extension.
10981 * It's ok to attach fentry/fexit to extension program.
10982 */
10983 verbose(env, "Cannot recursively attach\n");
10984 return -EINVAL;
10985 }
10986 if (tgt_prog->type == BPF_PROG_TYPE_TRACING &&
10987 prog_extension &&
10988 (tgt_prog->expected_attach_type == BPF_TRACE_FENTRY ||
10989 tgt_prog->expected_attach_type == BPF_TRACE_FEXIT)) {
10990 /* Program extensions can extend all program types
10991 * except fentry/fexit. The reason is the following.
10992 * The fentry/fexit programs are used for performance
10993 * analysis, stats and can be attached to any program
10994 * type except themselves. When extension program is
10995 * replacing XDP function it is necessary to allow
10996 * performance analysis of all functions. Both original
10997 * XDP program and its program extension. Hence
10998 * attaching fentry/fexit to BPF_PROG_TYPE_EXT is
10999 * allowed. If extending of fentry/fexit was allowed it
11000 * would be possible to create long call chain
11001 * fentry->extension->fentry->extension beyond
11002 * reasonable stack size. Hence extending fentry is not
11003 * allowed.
11004 */
11005 verbose(env, "Cannot extend fentry/fexit\n");
11006 return -EINVAL;
11007 }
5b92a28a
AS
11008 key = ((u64)aux->id) << 32 | btf_id;
11009 } else {
be8704ff
AS
11010 if (prog_extension) {
11011 verbose(env, "Cannot replace kernel functions\n");
11012 return -EINVAL;
11013 }
5b92a28a
AS
11014 key = btf_id;
11015 }
f1b9509c
AS
11016
11017 switch (prog->expected_attach_type) {
11018 case BPF_TRACE_RAW_TP:
5b92a28a
AS
11019 if (tgt_prog) {
11020 verbose(env,
11021 "Only FENTRY/FEXIT progs are attachable to another BPF prog\n");
11022 return -EINVAL;
11023 }
38207291
MKL
11024 if (!btf_type_is_typedef(t)) {
11025 verbose(env, "attach_btf_id %u is not a typedef\n",
11026 btf_id);
11027 return -EINVAL;
11028 }
f1b9509c 11029 if (strncmp(prefix, tname, sizeof(prefix) - 1)) {
38207291
MKL
11030 verbose(env, "attach_btf_id %u points to wrong type name %s\n",
11031 btf_id, tname);
11032 return -EINVAL;
11033 }
11034 tname += sizeof(prefix) - 1;
5b92a28a 11035 t = btf_type_by_id(btf, t->type);
38207291
MKL
11036 if (!btf_type_is_ptr(t))
11037 /* should never happen in valid vmlinux build */
11038 return -EINVAL;
5b92a28a 11039 t = btf_type_by_id(btf, t->type);
38207291
MKL
11040 if (!btf_type_is_func_proto(t))
11041 /* should never happen in valid vmlinux build */
11042 return -EINVAL;
11043
11044 /* remember two read only pointers that are valid for
11045 * the life time of the kernel
11046 */
11047 prog->aux->attach_func_name = tname;
11048 prog->aux->attach_func_proto = t;
11049 prog->aux->attach_btf_trace = true;
f1b9509c 11050 return 0;
15d83c4d
YS
11051 case BPF_TRACE_ITER:
11052 if (!btf_type_is_func(t)) {
11053 verbose(env, "attach_btf_id %u is not a function\n",
11054 btf_id);
11055 return -EINVAL;
11056 }
11057 t = btf_type_by_id(btf, t->type);
11058 if (!btf_type_is_func_proto(t))
11059 return -EINVAL;
11060 prog->aux->attach_func_name = tname;
11061 prog->aux->attach_func_proto = t;
11062 if (!bpf_iter_prog_supported(prog))
11063 return -EINVAL;
11064 ret = btf_distill_func_proto(&env->log, btf, t,
11065 tname, &fmodel);
11066 return ret;
be8704ff
AS
11067 default:
11068 if (!prog_extension)
11069 return -EINVAL;
11070 /* fallthrough */
ae240823 11071 case BPF_MODIFY_RETURN:
9e4e01df 11072 case BPF_LSM_MAC:
fec56f58
AS
11073 case BPF_TRACE_FENTRY:
11074 case BPF_TRACE_FEXIT:
9e4e01df
KS
11075 prog->aux->attach_func_name = tname;
11076 if (prog->type == BPF_PROG_TYPE_LSM) {
11077 ret = bpf_lsm_verify_prog(&env->log, prog);
11078 if (ret < 0)
11079 return ret;
11080 }
11081
fec56f58
AS
11082 if (!btf_type_is_func(t)) {
11083 verbose(env, "attach_btf_id %u is not a function\n",
11084 btf_id);
11085 return -EINVAL;
11086 }
be8704ff
AS
11087 if (prog_extension &&
11088 btf_check_type_match(env, prog, btf, t))
11089 return -EINVAL;
5b92a28a 11090 t = btf_type_by_id(btf, t->type);
fec56f58
AS
11091 if (!btf_type_is_func_proto(t))
11092 return -EINVAL;
5b92a28a 11093 tr = bpf_trampoline_lookup(key);
fec56f58
AS
11094 if (!tr)
11095 return -ENOMEM;
5b92a28a 11096 /* t is either vmlinux type or another program's type */
fec56f58
AS
11097 prog->aux->attach_func_proto = t;
11098 mutex_lock(&tr->mutex);
11099 if (tr->func.addr) {
11100 prog->aux->trampoline = tr;
11101 goto out;
11102 }
5b92a28a
AS
11103 if (tgt_prog && conservative) {
11104 prog->aux->attach_func_proto = NULL;
11105 t = NULL;
11106 }
11107 ret = btf_distill_func_proto(&env->log, btf, t,
fec56f58
AS
11108 tname, &tr->func.model);
11109 if (ret < 0)
11110 goto out;
5b92a28a 11111 if (tgt_prog) {
e9eeec58
YS
11112 if (subprog == 0)
11113 addr = (long) tgt_prog->bpf_func;
11114 else
11115 addr = (long) tgt_prog->aux->func[subprog]->bpf_func;
5b92a28a
AS
11116 } else {
11117 addr = kallsyms_lookup_name(tname);
11118 if (!addr) {
11119 verbose(env,
11120 "The address of function %s cannot be found\n",
11121 tname);
11122 ret = -ENOENT;
11123 goto out;
11124 }
fec56f58 11125 }
18644cec
AS
11126
11127 if (prog->expected_attach_type == BPF_MODIFY_RETURN) {
11128 ret = check_attach_modify_return(prog, addr);
11129 if (ret)
11130 verbose(env, "%s() is not modifiable\n",
11131 prog->aux->attach_func_name);
11132 }
11133
11134 if (ret)
11135 goto out;
fec56f58
AS
11136 tr->func.addr = (void *)addr;
11137 prog->aux->trampoline = tr;
11138out:
11139 mutex_unlock(&tr->mutex);
11140 if (ret)
11141 bpf_trampoline_put(tr);
11142 return ret;
38207291 11143 }
38207291
MKL
11144}
11145
838e9690
YS
11146int bpf_check(struct bpf_prog **prog, union bpf_attr *attr,
11147 union bpf_attr __user *uattr)
51580e79 11148{
06ee7115 11149 u64 start_time = ktime_get_ns();
58e2af8b 11150 struct bpf_verifier_env *env;
b9193c1b 11151 struct bpf_verifier_log *log;
9e4c24e7 11152 int i, len, ret = -EINVAL;
e2ae4ca2 11153 bool is_priv;
51580e79 11154
eba0c929
AB
11155 /* no program is valid */
11156 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
11157 return -EINVAL;
11158
58e2af8b 11159 /* 'struct bpf_verifier_env' can be global, but since it's not small,
cbd35700
AS
11160 * allocate/free it every time bpf_check() is called
11161 */
58e2af8b 11162 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
cbd35700
AS
11163 if (!env)
11164 return -ENOMEM;
61bd5218 11165 log = &env->log;
cbd35700 11166
9e4c24e7 11167 len = (*prog)->len;
fad953ce 11168 env->insn_aux_data =
9e4c24e7 11169 vzalloc(array_size(sizeof(struct bpf_insn_aux_data), len));
3df126f3
JK
11170 ret = -ENOMEM;
11171 if (!env->insn_aux_data)
11172 goto err_free_env;
9e4c24e7
JK
11173 for (i = 0; i < len; i++)
11174 env->insn_aux_data[i].orig_idx = i;
9bac3d6d 11175 env->prog = *prog;
00176a34 11176 env->ops = bpf_verifier_ops[env->prog->type];
2c78ee89 11177 is_priv = bpf_capable();
0246e64d 11178
8580ac94
AS
11179 if (!btf_vmlinux && IS_ENABLED(CONFIG_DEBUG_INFO_BTF)) {
11180 mutex_lock(&bpf_verifier_lock);
11181 if (!btf_vmlinux)
11182 btf_vmlinux = btf_parse_vmlinux();
11183 mutex_unlock(&bpf_verifier_lock);
11184 }
11185
cbd35700 11186 /* grab the mutex to protect few globals used by verifier */
45a73c17
AS
11187 if (!is_priv)
11188 mutex_lock(&bpf_verifier_lock);
cbd35700
AS
11189
11190 if (attr->log_level || attr->log_buf || attr->log_size) {
11191 /* user requested verbose verifier output
11192 * and supplied buffer to store the verification trace
11193 */
e7bf8249
JK
11194 log->level = attr->log_level;
11195 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
11196 log->len_total = attr->log_size;
cbd35700
AS
11197
11198 ret = -EINVAL;
e7bf8249 11199 /* log attributes have to be sane */
7a9f5c65 11200 if (log->len_total < 128 || log->len_total > UINT_MAX >> 2 ||
06ee7115 11201 !log->level || !log->ubuf || log->level & ~BPF_LOG_MASK)
3df126f3 11202 goto err_unlock;
cbd35700 11203 }
1ad2f583 11204
8580ac94
AS
11205 if (IS_ERR(btf_vmlinux)) {
11206 /* Either gcc or pahole or kernel are broken. */
11207 verbose(env, "in-kernel BTF is malformed\n");
11208 ret = PTR_ERR(btf_vmlinux);
38207291 11209 goto skip_full_check;
8580ac94
AS
11210 }
11211
1ad2f583
DB
11212 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
11213 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
e07b98d9 11214 env->strict_alignment = true;
e9ee9efc
DM
11215 if (attr->prog_flags & BPF_F_ANY_ALIGNMENT)
11216 env->strict_alignment = false;
cbd35700 11217
2c78ee89 11218 env->allow_ptr_leaks = bpf_allow_ptr_leaks();
41c48f3a 11219 env->allow_ptr_to_map_access = bpf_allow_ptr_to_map_access();
2c78ee89
AS
11220 env->bypass_spec_v1 = bpf_bypass_spec_v1();
11221 env->bypass_spec_v4 = bpf_bypass_spec_v4();
11222 env->bpf_capable = bpf_capable();
e2ae4ca2 11223
10d274e8
AS
11224 if (is_priv)
11225 env->test_state_freq = attr->prog_flags & BPF_F_TEST_STATE_FREQ;
11226
f4e3ec0d
JK
11227 ret = replace_map_fd_with_map_ptr(env);
11228 if (ret < 0)
11229 goto skip_full_check;
11230
cae1927c 11231 if (bpf_prog_is_dev_bound(env->prog->aux)) {
a40a2632 11232 ret = bpf_prog_offload_verifier_prep(env->prog);
ab3f0063 11233 if (ret)
f4e3ec0d 11234 goto skip_full_check;
ab3f0063
JK
11235 }
11236
dc2a4ebc 11237 env->explored_states = kvcalloc(state_htab_size(env),
58e2af8b 11238 sizeof(struct bpf_verifier_state_list *),
f1bca824
AS
11239 GFP_USER);
11240 ret = -ENOMEM;
11241 if (!env->explored_states)
11242 goto skip_full_check;
11243
d9762e84 11244 ret = check_subprogs(env);
475fb78f
AS
11245 if (ret < 0)
11246 goto skip_full_check;
11247
c454a46b 11248 ret = check_btf_info(env, attr, uattr);
838e9690
YS
11249 if (ret < 0)
11250 goto skip_full_check;
11251
be8704ff
AS
11252 ret = check_attach_btf_id(env);
11253 if (ret)
11254 goto skip_full_check;
11255
d9762e84
MKL
11256 ret = check_cfg(env);
11257 if (ret < 0)
11258 goto skip_full_check;
11259
51c39bb1
AS
11260 ret = do_check_subprogs(env);
11261 ret = ret ?: do_check_main(env);
cbd35700 11262
c941ce9c
QM
11263 if (ret == 0 && bpf_prog_is_dev_bound(env->prog->aux))
11264 ret = bpf_prog_offload_finalize(env);
11265
0246e64d 11266skip_full_check:
51c39bb1 11267 kvfree(env->explored_states);
0246e64d 11268
c131187d 11269 if (ret == 0)
9b38c405 11270 ret = check_max_stack_depth(env);
c131187d 11271
9b38c405 11272 /* instruction rewrites happen after this point */
e2ae4ca2
JK
11273 if (is_priv) {
11274 if (ret == 0)
11275 opt_hard_wire_dead_code_branches(env);
52875a04
JK
11276 if (ret == 0)
11277 ret = opt_remove_dead_code(env);
a1b14abc
JK
11278 if (ret == 0)
11279 ret = opt_remove_nops(env);
52875a04
JK
11280 } else {
11281 if (ret == 0)
11282 sanitize_dead_code(env);
e2ae4ca2
JK
11283 }
11284
9bac3d6d
AS
11285 if (ret == 0)
11286 /* program is valid, convert *(u32*)(ctx + off) accesses */
11287 ret = convert_ctx_accesses(env);
11288
e245c5c6 11289 if (ret == 0)
79741b3b 11290 ret = fixup_bpf_calls(env);
e245c5c6 11291
a4b1d3c1
JW
11292 /* do 32-bit optimization after insn patching has done so those patched
11293 * insns could be handled correctly.
11294 */
d6c2308c
JW
11295 if (ret == 0 && !bpf_prog_is_dev_bound(env->prog->aux)) {
11296 ret = opt_subreg_zext_lo32_rnd_hi32(env, attr);
11297 env->prog->aux->verifier_zext = bpf_jit_needs_zext() ? !ret
11298 : false;
a4b1d3c1
JW
11299 }
11300
1ea47e01
AS
11301 if (ret == 0)
11302 ret = fixup_call_args(env);
11303
06ee7115
AS
11304 env->verification_time = ktime_get_ns() - start_time;
11305 print_verification_stats(env);
11306
a2a7d570 11307 if (log->level && bpf_verifier_log_full(log))
cbd35700 11308 ret = -ENOSPC;
a2a7d570 11309 if (log->level && !log->ubuf) {
cbd35700 11310 ret = -EFAULT;
a2a7d570 11311 goto err_release_maps;
cbd35700
AS
11312 }
11313
0246e64d
AS
11314 if (ret == 0 && env->used_map_cnt) {
11315 /* if program passed verifier, update used_maps in bpf_prog_info */
9bac3d6d
AS
11316 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
11317 sizeof(env->used_maps[0]),
11318 GFP_KERNEL);
0246e64d 11319
9bac3d6d 11320 if (!env->prog->aux->used_maps) {
0246e64d 11321 ret = -ENOMEM;
a2a7d570 11322 goto err_release_maps;
0246e64d
AS
11323 }
11324
9bac3d6d 11325 memcpy(env->prog->aux->used_maps, env->used_maps,
0246e64d 11326 sizeof(env->used_maps[0]) * env->used_map_cnt);
9bac3d6d 11327 env->prog->aux->used_map_cnt = env->used_map_cnt;
0246e64d
AS
11328
11329 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
11330 * bpf_ld_imm64 instructions
11331 */
11332 convert_pseudo_ld_imm64(env);
11333 }
cbd35700 11334
ba64e7d8
YS
11335 if (ret == 0)
11336 adjust_btf_func(env);
11337
a2a7d570 11338err_release_maps:
9bac3d6d 11339 if (!env->prog->aux->used_maps)
0246e64d 11340 /* if we didn't copy map pointers into bpf_prog_info, release
ab7f5bf0 11341 * them now. Otherwise free_used_maps() will release them.
0246e64d
AS
11342 */
11343 release_maps(env);
03f87c0b
THJ
11344
11345 /* extension progs temporarily inherit the attach_type of their targets
11346 for verification purposes, so set it back to zero before returning
11347 */
11348 if (env->prog->type == BPF_PROG_TYPE_EXT)
11349 env->prog->expected_attach_type = 0;
11350
9bac3d6d 11351 *prog = env->prog;
3df126f3 11352err_unlock:
45a73c17
AS
11353 if (!is_priv)
11354 mutex_unlock(&bpf_verifier_lock);
3df126f3
JK
11355 vfree(env->insn_aux_data);
11356err_free_env:
11357 kfree(env);
51580e79
AS
11358 return ret;
11359}