]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blame - kernel/bpf/verifier.c
ipv6: Check ip6_find_1stfragopt() return value properly.
[mirror_ubuntu-artful-kernel.git] / kernel / bpf / verifier.c
CommitLineData
51580e79 1/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
969bf05e 2 * Copyright (c) 2016 Facebook
51580e79
AS
3 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
58e2af8b 17#include <linux/bpf_verifier.h>
51580e79
AS
18#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
ebb676da 22#include <linux/stringify.h>
51580e79
AS
23
24/* bpf_check() is a static code analyzer that walks eBPF program
25 * instruction by instruction and updates register/stack state.
26 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
27 *
28 * The first pass is depth-first-search to check that the program is a DAG.
29 * It rejects the following programs:
30 * - larger than BPF_MAXINSNS insns
31 * - if loop is present (detected via back-edge)
32 * - unreachable insns exist (shouldn't be a forest. program = one function)
33 * - out of bounds or malformed jumps
34 * The second pass is all possible path descent from the 1st insn.
35 * Since it's analyzing all pathes through the program, the length of the
eba38a96 36 * analysis is limited to 64k insn, which may be hit even if total number of
51580e79
AS
37 * insn is less then 4K, but there are too many branches that change stack/regs.
38 * Number of 'branches to be analyzed' is limited to 1k
39 *
40 * On entry to each instruction, each register has a type, and the instruction
41 * changes the types of the registers depending on instruction semantics.
42 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
43 * copied to R1.
44 *
45 * All registers are 64-bit.
46 * R0 - return register
47 * R1-R5 argument passing registers
48 * R6-R9 callee saved registers
49 * R10 - frame pointer read-only
50 *
51 * At the start of BPF program the register R1 contains a pointer to bpf_context
52 * and has type PTR_TO_CTX.
53 *
54 * Verifier tracks arithmetic operations on pointers in case:
55 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
56 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
57 * 1st insn copies R10 (which has FRAME_PTR) type into R1
58 * and 2nd arithmetic instruction is pattern matched to recognize
59 * that it wants to construct a pointer to some element within stack.
60 * So after 2nd insn, the register R1 has type PTR_TO_STACK
61 * (and -20 constant is saved for further stack bounds checking).
62 * Meaning that this reg is a pointer to stack plus known immediate constant.
63 *
64 * Most of the time the registers have UNKNOWN_VALUE type, which
65 * means the register has some value, but it's not a valid pointer.
66 * (like pointer plus pointer becomes UNKNOWN_VALUE type)
67 *
68 * When verifier sees load or store instructions the type of base register
69 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, FRAME_PTR. These are three pointer
70 * types recognized by check_mem_access() function.
71 *
72 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
73 * and the range of [ptr, ptr + map's value_size) is accessible.
74 *
75 * registers used to pass values to function calls are checked against
76 * function argument constraints.
77 *
78 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
79 * It means that the register type passed to this function must be
80 * PTR_TO_STACK and it will be used inside the function as
81 * 'pointer to map element key'
82 *
83 * For example the argument constraints for bpf_map_lookup_elem():
84 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
85 * .arg1_type = ARG_CONST_MAP_PTR,
86 * .arg2_type = ARG_PTR_TO_MAP_KEY,
87 *
88 * ret_type says that this function returns 'pointer to map elem value or null'
89 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
90 * 2nd argument should be a pointer to stack, which will be used inside
91 * the helper function as a pointer to map element key.
92 *
93 * On the kernel side the helper function looks like:
94 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
95 * {
96 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
97 * void *key = (void *) (unsigned long) r2;
98 * void *value;
99 *
100 * here kernel can access 'key' and 'map' pointers safely, knowing that
101 * [key, key + map->key_size) bytes are valid and were initialized on
102 * the stack of eBPF program.
103 * }
104 *
105 * Corresponding eBPF program may look like:
106 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
107 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
108 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
109 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
110 * here verifier looks at prototype of map_lookup_elem() and sees:
111 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
112 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
113 *
114 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
115 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
116 * and were initialized prior to this call.
117 * If it's ok, then verifier allows this BPF_CALL insn and looks at
118 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
119 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
120 * returns ether pointer to map value or NULL.
121 *
122 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
123 * insn, the register holding that pointer in the true branch changes state to
124 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
125 * branch. See check_cond_jmp_op().
126 *
127 * After the call R0 is set to return type of the function and registers R1-R5
128 * are set to NOT_INIT to indicate that they are no longer readable.
129 */
130
17a52670 131/* verifier_state + insn_idx are pushed to stack when branch is encountered */
58e2af8b 132struct bpf_verifier_stack_elem {
17a52670
AS
133 /* verifer state is 'st'
134 * before processing instruction 'insn_idx'
135 * and after processing instruction 'prev_insn_idx'
136 */
58e2af8b 137 struct bpf_verifier_state st;
17a52670
AS
138 int insn_idx;
139 int prev_insn_idx;
58e2af8b 140 struct bpf_verifier_stack_elem *next;
cbd35700
AS
141};
142
07016151
DB
143#define BPF_COMPLEXITY_LIMIT_INSNS 65536
144#define BPF_COMPLEXITY_LIMIT_STACK 1024
145
fad73a1a
MKL
146#define BPF_MAP_PTR_POISON ((void *)0xeB9F + POISON_POINTER_DELTA)
147
33ff9823
DB
148struct bpf_call_arg_meta {
149 struct bpf_map *map_ptr;
435faee1 150 bool raw_mode;
36bbef52 151 bool pkt_access;
435faee1
DB
152 int regno;
153 int access_size;
33ff9823
DB
154};
155
cbd35700
AS
156/* verbose verifier prints what it's seeing
157 * bpf_check() is called under lock, so no race to access these global vars
158 */
159static u32 log_level, log_size, log_len;
160static char *log_buf;
161
162static DEFINE_MUTEX(bpf_verifier_lock);
163
164/* log_level controls verbosity level of eBPF verifier.
165 * verbose() is used to dump the verification trace to the log, so the user
166 * can figure out what's wrong with the program
167 */
1d056d9c 168static __printf(1, 2) void verbose(const char *fmt, ...)
cbd35700
AS
169{
170 va_list args;
171
172 if (log_level == 0 || log_len >= log_size - 1)
173 return;
174
175 va_start(args, fmt);
176 log_len += vscnprintf(log_buf + log_len, log_size - log_len, fmt, args);
177 va_end(args);
178}
179
17a52670
AS
180/* string representation of 'enum bpf_reg_type' */
181static const char * const reg_type_str[] = {
182 [NOT_INIT] = "?",
183 [UNKNOWN_VALUE] = "inv",
184 [PTR_TO_CTX] = "ctx",
185 [CONST_PTR_TO_MAP] = "map_ptr",
186 [PTR_TO_MAP_VALUE] = "map_value",
187 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
48461135 188 [PTR_TO_MAP_VALUE_ADJ] = "map_value_adj",
17a52670
AS
189 [FRAME_PTR] = "fp",
190 [PTR_TO_STACK] = "fp",
191 [CONST_IMM] = "imm",
969bf05e
AS
192 [PTR_TO_PACKET] = "pkt",
193 [PTR_TO_PACKET_END] = "pkt_end",
17a52670
AS
194};
195
ebb676da
TG
196#define __BPF_FUNC_STR_FN(x) [BPF_FUNC_ ## x] = __stringify(bpf_ ## x)
197static const char * const func_id_str[] = {
198 __BPF_FUNC_MAPPER(__BPF_FUNC_STR_FN)
199};
200#undef __BPF_FUNC_STR_FN
201
202static const char *func_id_name(int id)
203{
204 BUILD_BUG_ON(ARRAY_SIZE(func_id_str) != __BPF_FUNC_MAX_ID);
205
206 if (id >= 0 && id < __BPF_FUNC_MAX_ID && func_id_str[id])
207 return func_id_str[id];
208 else
209 return "unknown";
210}
211
58e2af8b 212static void print_verifier_state(struct bpf_verifier_state *state)
17a52670 213{
58e2af8b 214 struct bpf_reg_state *reg;
17a52670
AS
215 enum bpf_reg_type t;
216 int i;
217
218 for (i = 0; i < MAX_BPF_REG; i++) {
1a0dc1ac
AS
219 reg = &state->regs[i];
220 t = reg->type;
17a52670
AS
221 if (t == NOT_INIT)
222 continue;
223 verbose(" R%d=%s", i, reg_type_str[t]);
224 if (t == CONST_IMM || t == PTR_TO_STACK)
969bf05e
AS
225 verbose("%lld", reg->imm);
226 else if (t == PTR_TO_PACKET)
227 verbose("(id=%d,off=%d,r=%d)",
228 reg->id, reg->off, reg->range);
229 else if (t == UNKNOWN_VALUE && reg->imm)
230 verbose("%lld", reg->imm);
17a52670 231 else if (t == CONST_PTR_TO_MAP || t == PTR_TO_MAP_VALUE ||
48461135
JB
232 t == PTR_TO_MAP_VALUE_OR_NULL ||
233 t == PTR_TO_MAP_VALUE_ADJ)
57a09bf0 234 verbose("(ks=%d,vs=%d,id=%u)",
1a0dc1ac 235 reg->map_ptr->key_size,
57a09bf0
TG
236 reg->map_ptr->value_size,
237 reg->id);
48461135 238 if (reg->min_value != BPF_REGISTER_MIN_RANGE)
f23cc643
JB
239 verbose(",min_value=%lld",
240 (long long)reg->min_value);
48461135
JB
241 if (reg->max_value != BPF_REGISTER_MAX_RANGE)
242 verbose(",max_value=%llu",
243 (unsigned long long)reg->max_value);
d1174416
DM
244 if (reg->min_align)
245 verbose(",min_align=%u", reg->min_align);
246 if (reg->aux_off)
247 verbose(",aux_off=%u", reg->aux_off);
248 if (reg->aux_off_align)
249 verbose(",aux_off_align=%u", reg->aux_off_align);
17a52670 250 }
9c399760 251 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
1a0dc1ac 252 if (state->stack_slot_type[i] == STACK_SPILL)
17a52670 253 verbose(" fp%d=%s", -MAX_BPF_STACK + i,
1a0dc1ac 254 reg_type_str[state->spilled_regs[i / BPF_REG_SIZE].type]);
17a52670
AS
255 }
256 verbose("\n");
257}
258
cbd35700
AS
259static const char *const bpf_class_string[] = {
260 [BPF_LD] = "ld",
261 [BPF_LDX] = "ldx",
262 [BPF_ST] = "st",
263 [BPF_STX] = "stx",
264 [BPF_ALU] = "alu",
265 [BPF_JMP] = "jmp",
266 [BPF_RET] = "BUG",
267 [BPF_ALU64] = "alu64",
268};
269
687f0715 270static const char *const bpf_alu_string[16] = {
cbd35700
AS
271 [BPF_ADD >> 4] = "+=",
272 [BPF_SUB >> 4] = "-=",
273 [BPF_MUL >> 4] = "*=",
274 [BPF_DIV >> 4] = "/=",
275 [BPF_OR >> 4] = "|=",
276 [BPF_AND >> 4] = "&=",
277 [BPF_LSH >> 4] = "<<=",
278 [BPF_RSH >> 4] = ">>=",
279 [BPF_NEG >> 4] = "neg",
280 [BPF_MOD >> 4] = "%=",
281 [BPF_XOR >> 4] = "^=",
282 [BPF_MOV >> 4] = "=",
283 [BPF_ARSH >> 4] = "s>>=",
284 [BPF_END >> 4] = "endian",
285};
286
287static const char *const bpf_ldst_string[] = {
288 [BPF_W >> 3] = "u32",
289 [BPF_H >> 3] = "u16",
290 [BPF_B >> 3] = "u8",
291 [BPF_DW >> 3] = "u64",
292};
293
687f0715 294static const char *const bpf_jmp_string[16] = {
cbd35700
AS
295 [BPF_JA >> 4] = "jmp",
296 [BPF_JEQ >> 4] = "==",
297 [BPF_JGT >> 4] = ">",
298 [BPF_JGE >> 4] = ">=",
299 [BPF_JSET >> 4] = "&",
300 [BPF_JNE >> 4] = "!=",
301 [BPF_JSGT >> 4] = "s>",
302 [BPF_JSGE >> 4] = "s>=",
303 [BPF_CALL >> 4] = "call",
304 [BPF_EXIT >> 4] = "exit",
305};
306
0d0e5769
DB
307static void print_bpf_insn(const struct bpf_verifier_env *env,
308 const struct bpf_insn *insn)
cbd35700
AS
309{
310 u8 class = BPF_CLASS(insn->code);
311
312 if (class == BPF_ALU || class == BPF_ALU64) {
313 if (BPF_SRC(insn->code) == BPF_X)
314 verbose("(%02x) %sr%d %s %sr%d\n",
315 insn->code, class == BPF_ALU ? "(u32) " : "",
316 insn->dst_reg,
317 bpf_alu_string[BPF_OP(insn->code) >> 4],
318 class == BPF_ALU ? "(u32) " : "",
319 insn->src_reg);
320 else
321 verbose("(%02x) %sr%d %s %s%d\n",
322 insn->code, class == BPF_ALU ? "(u32) " : "",
323 insn->dst_reg,
324 bpf_alu_string[BPF_OP(insn->code) >> 4],
325 class == BPF_ALU ? "(u32) " : "",
326 insn->imm);
327 } else if (class == BPF_STX) {
328 if (BPF_MODE(insn->code) == BPF_MEM)
329 verbose("(%02x) *(%s *)(r%d %+d) = r%d\n",
330 insn->code,
331 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
332 insn->dst_reg,
333 insn->off, insn->src_reg);
334 else if (BPF_MODE(insn->code) == BPF_XADD)
335 verbose("(%02x) lock *(%s *)(r%d %+d) += r%d\n",
336 insn->code,
337 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
338 insn->dst_reg, insn->off,
339 insn->src_reg);
340 else
341 verbose("BUG_%02x\n", insn->code);
342 } else if (class == BPF_ST) {
343 if (BPF_MODE(insn->code) != BPF_MEM) {
344 verbose("BUG_st_%02x\n", insn->code);
345 return;
346 }
347 verbose("(%02x) *(%s *)(r%d %+d) = %d\n",
348 insn->code,
349 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
350 insn->dst_reg,
351 insn->off, insn->imm);
352 } else if (class == BPF_LDX) {
353 if (BPF_MODE(insn->code) != BPF_MEM) {
354 verbose("BUG_ldx_%02x\n", insn->code);
355 return;
356 }
357 verbose("(%02x) r%d = *(%s *)(r%d %+d)\n",
358 insn->code, insn->dst_reg,
359 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
360 insn->src_reg, insn->off);
361 } else if (class == BPF_LD) {
362 if (BPF_MODE(insn->code) == BPF_ABS) {
363 verbose("(%02x) r0 = *(%s *)skb[%d]\n",
364 insn->code,
365 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
366 insn->imm);
367 } else if (BPF_MODE(insn->code) == BPF_IND) {
368 verbose("(%02x) r0 = *(%s *)skb[r%d + %d]\n",
369 insn->code,
370 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
371 insn->src_reg, insn->imm);
0d0e5769
DB
372 } else if (BPF_MODE(insn->code) == BPF_IMM &&
373 BPF_SIZE(insn->code) == BPF_DW) {
374 /* At this point, we already made sure that the second
375 * part of the ldimm64 insn is accessible.
376 */
377 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
378 bool map_ptr = insn->src_reg == BPF_PSEUDO_MAP_FD;
379
380 if (map_ptr && !env->allow_ptr_leaks)
381 imm = 0;
382
383 verbose("(%02x) r%d = 0x%llx\n", insn->code,
384 insn->dst_reg, (unsigned long long)imm);
cbd35700
AS
385 } else {
386 verbose("BUG_ld_%02x\n", insn->code);
387 return;
388 }
389 } else if (class == BPF_JMP) {
390 u8 opcode = BPF_OP(insn->code);
391
392 if (opcode == BPF_CALL) {
ebb676da
TG
393 verbose("(%02x) call %s#%d\n", insn->code,
394 func_id_name(insn->imm), insn->imm);
cbd35700
AS
395 } else if (insn->code == (BPF_JMP | BPF_JA)) {
396 verbose("(%02x) goto pc%+d\n",
397 insn->code, insn->off);
398 } else if (insn->code == (BPF_JMP | BPF_EXIT)) {
399 verbose("(%02x) exit\n", insn->code);
400 } else if (BPF_SRC(insn->code) == BPF_X) {
401 verbose("(%02x) if r%d %s r%d goto pc%+d\n",
402 insn->code, insn->dst_reg,
403 bpf_jmp_string[BPF_OP(insn->code) >> 4],
404 insn->src_reg, insn->off);
405 } else {
406 verbose("(%02x) if r%d %s 0x%x goto pc%+d\n",
407 insn->code, insn->dst_reg,
408 bpf_jmp_string[BPF_OP(insn->code) >> 4],
409 insn->imm, insn->off);
410 }
411 } else {
412 verbose("(%02x) %s\n", insn->code, bpf_class_string[class]);
413 }
414}
415
58e2af8b 416static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx)
17a52670 417{
58e2af8b 418 struct bpf_verifier_stack_elem *elem;
17a52670
AS
419 int insn_idx;
420
421 if (env->head == NULL)
422 return -1;
423
424 memcpy(&env->cur_state, &env->head->st, sizeof(env->cur_state));
425 insn_idx = env->head->insn_idx;
426 if (prev_insn_idx)
427 *prev_insn_idx = env->head->prev_insn_idx;
428 elem = env->head->next;
429 kfree(env->head);
430 env->head = elem;
431 env->stack_size--;
432 return insn_idx;
433}
434
58e2af8b
JK
435static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
436 int insn_idx, int prev_insn_idx)
17a52670 437{
58e2af8b 438 struct bpf_verifier_stack_elem *elem;
17a52670 439
58e2af8b 440 elem = kmalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
17a52670
AS
441 if (!elem)
442 goto err;
443
444 memcpy(&elem->st, &env->cur_state, sizeof(env->cur_state));
445 elem->insn_idx = insn_idx;
446 elem->prev_insn_idx = prev_insn_idx;
447 elem->next = env->head;
448 env->head = elem;
449 env->stack_size++;
07016151 450 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
17a52670
AS
451 verbose("BPF program is too complex\n");
452 goto err;
453 }
454 return &elem->st;
455err:
456 /* pop all elements and return */
457 while (pop_stack(env, NULL) >= 0);
458 return NULL;
459}
460
461#define CALLER_SAVED_REGS 6
462static const int caller_saved[CALLER_SAVED_REGS] = {
463 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
464};
465
58e2af8b 466static void init_reg_state(struct bpf_reg_state *regs)
17a52670
AS
467{
468 int i;
469
470 for (i = 0; i < MAX_BPF_REG; i++) {
471 regs[i].type = NOT_INIT;
472 regs[i].imm = 0;
48461135
JB
473 regs[i].min_value = BPF_REGISTER_MIN_RANGE;
474 regs[i].max_value = BPF_REGISTER_MAX_RANGE;
d1174416
DM
475 regs[i].min_align = 0;
476 regs[i].aux_off = 0;
477 regs[i].aux_off_align = 0;
17a52670
AS
478 }
479
480 /* frame pointer */
481 regs[BPF_REG_FP].type = FRAME_PTR;
482
483 /* 1st arg to a function */
484 regs[BPF_REG_1].type = PTR_TO_CTX;
485}
486
6760bf2d 487static void __mark_reg_unknown_value(struct bpf_reg_state *regs, u32 regno)
17a52670 488{
17a52670 489 regs[regno].type = UNKNOWN_VALUE;
57a09bf0 490 regs[regno].id = 0;
17a52670 491 regs[regno].imm = 0;
17a52670
AS
492}
493
6760bf2d
DB
494static void mark_reg_unknown_value(struct bpf_reg_state *regs, u32 regno)
495{
496 BUG_ON(regno >= MAX_BPF_REG);
497 __mark_reg_unknown_value(regs, regno);
498}
499
48461135
JB
500static void reset_reg_range_values(struct bpf_reg_state *regs, u32 regno)
501{
502 regs[regno].min_value = BPF_REGISTER_MIN_RANGE;
503 regs[regno].max_value = BPF_REGISTER_MAX_RANGE;
d1174416 504 regs[regno].min_align = 0;
48461135
JB
505}
506
f0318d01
GB
507static void mark_reg_unknown_value_and_range(struct bpf_reg_state *regs,
508 u32 regno)
509{
510 mark_reg_unknown_value(regs, regno);
511 reset_reg_range_values(regs, regno);
512}
513
17a52670
AS
514enum reg_arg_type {
515 SRC_OP, /* register is used as source operand */
516 DST_OP, /* register is used as destination operand */
517 DST_OP_NO_MARK /* same as above, check only, don't mark */
518};
519
58e2af8b 520static int check_reg_arg(struct bpf_reg_state *regs, u32 regno,
17a52670
AS
521 enum reg_arg_type t)
522{
523 if (regno >= MAX_BPF_REG) {
524 verbose("R%d is invalid\n", regno);
525 return -EINVAL;
526 }
527
528 if (t == SRC_OP) {
529 /* check whether register used as source operand can be read */
530 if (regs[regno].type == NOT_INIT) {
531 verbose("R%d !read_ok\n", regno);
532 return -EACCES;
533 }
534 } else {
535 /* check whether register used as dest operand can be written to */
536 if (regno == BPF_REG_FP) {
537 verbose("frame pointer is read only\n");
538 return -EACCES;
539 }
540 if (t == DST_OP)
541 mark_reg_unknown_value(regs, regno);
542 }
543 return 0;
544}
545
546static int bpf_size_to_bytes(int bpf_size)
547{
548 if (bpf_size == BPF_W)
549 return 4;
550 else if (bpf_size == BPF_H)
551 return 2;
552 else if (bpf_size == BPF_B)
553 return 1;
554 else if (bpf_size == BPF_DW)
555 return 8;
556 else
557 return -EINVAL;
558}
559
1be7f75d
AS
560static bool is_spillable_regtype(enum bpf_reg_type type)
561{
562 switch (type) {
563 case PTR_TO_MAP_VALUE:
564 case PTR_TO_MAP_VALUE_OR_NULL:
f0318d01 565 case PTR_TO_MAP_VALUE_ADJ:
1be7f75d
AS
566 case PTR_TO_STACK:
567 case PTR_TO_CTX:
969bf05e
AS
568 case PTR_TO_PACKET:
569 case PTR_TO_PACKET_END:
1be7f75d
AS
570 case FRAME_PTR:
571 case CONST_PTR_TO_MAP:
572 return true;
573 default:
574 return false;
575 }
576}
577
17a52670
AS
578/* check_stack_read/write functions track spill/fill of registers,
579 * stack boundary and alignment are checked in check_mem_access()
580 */
58e2af8b
JK
581static int check_stack_write(struct bpf_verifier_state *state, int off,
582 int size, int value_regno)
17a52670 583{
17a52670 584 int i;
9c399760
AS
585 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
586 * so it's aligned access and [off, off + size) are within stack limits
587 */
17a52670
AS
588
589 if (value_regno >= 0 &&
1be7f75d 590 is_spillable_regtype(state->regs[value_regno].type)) {
17a52670
AS
591
592 /* register containing pointer is being spilled into stack */
9c399760 593 if (size != BPF_REG_SIZE) {
17a52670
AS
594 verbose("invalid size of register spill\n");
595 return -EACCES;
596 }
597
17a52670 598 /* save register state */
9c399760
AS
599 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE] =
600 state->regs[value_regno];
17a52670 601
9c399760
AS
602 for (i = 0; i < BPF_REG_SIZE; i++)
603 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_SPILL;
604 } else {
17a52670 605 /* regular write of data into stack */
9c399760 606 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE] =
58e2af8b 607 (struct bpf_reg_state) {};
9c399760
AS
608
609 for (i = 0; i < size; i++)
610 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_MISC;
17a52670
AS
611 }
612 return 0;
613}
614
58e2af8b 615static int check_stack_read(struct bpf_verifier_state *state, int off, int size,
17a52670
AS
616 int value_regno)
617{
9c399760 618 u8 *slot_type;
17a52670 619 int i;
17a52670 620
9c399760 621 slot_type = &state->stack_slot_type[MAX_BPF_STACK + off];
17a52670 622
9c399760
AS
623 if (slot_type[0] == STACK_SPILL) {
624 if (size != BPF_REG_SIZE) {
17a52670
AS
625 verbose("invalid size of register spill\n");
626 return -EACCES;
627 }
9c399760
AS
628 for (i = 1; i < BPF_REG_SIZE; i++) {
629 if (slot_type[i] != STACK_SPILL) {
17a52670
AS
630 verbose("corrupted spill memory\n");
631 return -EACCES;
632 }
633 }
634
635 if (value_regno >= 0)
636 /* restore register state from stack */
9c399760
AS
637 state->regs[value_regno] =
638 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE];
17a52670
AS
639 return 0;
640 } else {
641 for (i = 0; i < size; i++) {
9c399760 642 if (slot_type[i] != STACK_MISC) {
17a52670
AS
643 verbose("invalid read from stack off %d+%d size %d\n",
644 off, i, size);
645 return -EACCES;
646 }
647 }
648 if (value_regno >= 0)
649 /* have read misc data from the stack */
f0318d01
GB
650 mark_reg_unknown_value_and_range(state->regs,
651 value_regno);
17a52670
AS
652 return 0;
653 }
654}
655
656/* check read/write into map element returned by bpf_map_lookup_elem() */
58e2af8b 657static int check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
17a52670
AS
658 int size)
659{
660 struct bpf_map *map = env->cur_state.regs[regno].map_ptr;
661
5722569b 662 if (off < 0 || size <= 0 || off + size > map->value_size) {
17a52670
AS
663 verbose("invalid access to map value, value_size=%d off=%d size=%d\n",
664 map->value_size, off, size);
665 return -EACCES;
666 }
667 return 0;
668}
669
dbcfe5f7
GB
670/* check read/write into an adjusted map element */
671static int check_map_access_adj(struct bpf_verifier_env *env, u32 regno,
672 int off, int size)
673{
674 struct bpf_verifier_state *state = &env->cur_state;
675 struct bpf_reg_state *reg = &state->regs[regno];
676 int err;
677
678 /* We adjusted the register to this map value, so we
679 * need to change off and size to min_value and max_value
680 * respectively to make sure our theoretical access will be
681 * safe.
682 */
683 if (log_level)
684 print_verifier_state(state);
685 env->varlen_map_value_access = true;
686 /* The minimum value is only important with signed
687 * comparisons where we can't assume the floor of a
688 * value is 0. If we are using signed variables for our
689 * index'es we need to make sure that whatever we use
690 * will have a set floor within our range.
691 */
692 if (reg->min_value < 0) {
693 verbose("R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
694 regno);
695 return -EACCES;
696 }
697 err = check_map_access(env, regno, reg->min_value + off, size);
698 if (err) {
699 verbose("R%d min value is outside of the array range\n",
700 regno);
701 return err;
702 }
703
704 /* If we haven't set a max value then we need to bail
705 * since we can't be sure we won't do bad things.
706 */
707 if (reg->max_value == BPF_REGISTER_MAX_RANGE) {
708 verbose("R%d unbounded memory access, make sure to bounds check any array access into a map\n",
709 regno);
710 return -EACCES;
711 }
712 return check_map_access(env, regno, reg->max_value + off, size);
713}
714
969bf05e
AS
715#define MAX_PACKET_OFF 0xffff
716
58e2af8b 717static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
3a0af8fd
TG
718 const struct bpf_call_arg_meta *meta,
719 enum bpf_access_type t)
4acf6c0b 720{
36bbef52 721 switch (env->prog->type) {
3a0af8fd
TG
722 case BPF_PROG_TYPE_LWT_IN:
723 case BPF_PROG_TYPE_LWT_OUT:
724 /* dst_input() and dst_output() can't write for now */
725 if (t == BPF_WRITE)
726 return false;
7e57fbb2 727 /* fallthrough */
36bbef52
DB
728 case BPF_PROG_TYPE_SCHED_CLS:
729 case BPF_PROG_TYPE_SCHED_ACT:
4acf6c0b 730 case BPF_PROG_TYPE_XDP:
3a0af8fd 731 case BPF_PROG_TYPE_LWT_XMIT:
36bbef52
DB
732 if (meta)
733 return meta->pkt_access;
734
735 env->seen_direct_write = true;
4acf6c0b
BB
736 return true;
737 default:
738 return false;
739 }
740}
741
58e2af8b 742static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
969bf05e
AS
743 int size)
744{
58e2af8b
JK
745 struct bpf_reg_state *regs = env->cur_state.regs;
746 struct bpf_reg_state *reg = &regs[regno];
969bf05e 747
d91b28ed 748 off += reg->off;
b399cf64 749 if (off < 0 || size <= 0 || off + size > reg->range) {
d91b28ed
AS
750 verbose("invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
751 off, size, regno, reg->id, reg->off, reg->range);
969bf05e
AS
752 return -EACCES;
753 }
754 return 0;
755}
756
17a52670 757/* check access to 'struct bpf_context' fields */
58e2af8b 758static int check_ctx_access(struct bpf_verifier_env *env, int off, int size,
19de99f7 759 enum bpf_access_type t, enum bpf_reg_type *reg_type)
17a52670 760{
13a27dfc
JK
761 /* for analyzer ctx accesses are already validated and converted */
762 if (env->analyzer_ops)
763 return 0;
764
17a52670 765 if (env->prog->aux->ops->is_valid_access &&
19de99f7 766 env->prog->aux->ops->is_valid_access(off, size, t, reg_type)) {
32bbe007
AS
767 /* remember the offset of last byte accessed in ctx */
768 if (env->prog->aux->max_ctx_offset < off + size)
769 env->prog->aux->max_ctx_offset = off + size;
17a52670 770 return 0;
32bbe007 771 }
17a52670
AS
772
773 verbose("invalid bpf_context access off=%d size=%d\n", off, size);
774 return -EACCES;
775}
776
58e2af8b 777static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
1be7f75d
AS
778{
779 if (env->allow_ptr_leaks)
780 return false;
781
782 switch (env->cur_state.regs[regno].type) {
783 case UNKNOWN_VALUE:
784 case CONST_IMM:
785 return false;
786 default:
787 return true;
788 }
789}
790
79adffcd 791static int check_pkt_ptr_alignment(const struct bpf_reg_state *reg,
d1174416 792 int off, int size, bool strict)
969bf05e 793{
e07b98d9 794 int ip_align;
d1174416
DM
795 int reg_off;
796
797 /* Byte size accesses are always allowed. */
798 if (!strict || size == 1)
799 return 0;
800
801 reg_off = reg->off;
802 if (reg->id) {
803 if (reg->aux_off_align % size) {
804 verbose("Packet access is only %u byte aligned, %d byte access not allowed\n",
805 reg->aux_off_align, size);
806 return -EACCES;
807 }
808 reg_off += reg->aux_off;
969bf05e
AS
809 }
810
e07b98d9
DM
811 /* skb->data is NET_IP_ALIGN-ed, but for strict alignment checking
812 * we force this to 2 which is universally what architectures use
813 * when they don't set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS.
814 */
815 ip_align = strict ? 2 : NET_IP_ALIGN;
816 if ((ip_align + reg_off + off) % size != 0) {
969bf05e 817 verbose("misaligned packet access off %d+%d+%d size %d\n",
e07b98d9 818 ip_align, reg_off, off, size);
969bf05e
AS
819 return -EACCES;
820 }
79adffcd 821
969bf05e
AS
822 return 0;
823}
824
79adffcd 825static int check_val_ptr_alignment(const struct bpf_reg_state *reg,
d1174416 826 int size, bool strict)
79adffcd 827{
d1174416 828 if (strict && size != 1) {
79adffcd
DB
829 verbose("Unknown alignment. Only byte-sized access allowed in value access.\n");
830 return -EACCES;
831 }
832
969bf05e
AS
833 return 0;
834}
835
e07b98d9
DM
836static int check_ptr_alignment(struct bpf_verifier_env *env,
837 const struct bpf_reg_state *reg,
79adffcd
DB
838 int off, int size)
839{
e07b98d9 840 bool strict = env->strict_alignment;
d1174416
DM
841
842 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
843 strict = true;
844
79adffcd
DB
845 switch (reg->type) {
846 case PTR_TO_PACKET:
d1174416 847 return check_pkt_ptr_alignment(reg, off, size, strict);
79adffcd 848 case PTR_TO_MAP_VALUE_ADJ:
d1174416 849 return check_val_ptr_alignment(reg, size, strict);
79adffcd
DB
850 default:
851 if (off % size != 0) {
852 verbose("misaligned access off %d size %d\n",
853 off, size);
854 return -EACCES;
855 }
856
857 return 0;
858 }
859}
860
17a52670
AS
861/* check whether memory at (regno + off) is accessible for t = (read | write)
862 * if t==write, value_regno is a register which value is stored into memory
863 * if t==read, value_regno is a register which will receive the value from memory
864 * if t==write && value_regno==-1, some unknown value is stored into memory
865 * if t==read && value_regno==-1, don't care what we read from memory
866 */
58e2af8b 867static int check_mem_access(struct bpf_verifier_env *env, u32 regno, int off,
17a52670
AS
868 int bpf_size, enum bpf_access_type t,
869 int value_regno)
870{
58e2af8b
JK
871 struct bpf_verifier_state *state = &env->cur_state;
872 struct bpf_reg_state *reg = &state->regs[regno];
17a52670
AS
873 int size, err = 0;
874
1a0dc1ac
AS
875 if (reg->type == PTR_TO_STACK)
876 off += reg->imm;
24b4d2ab 877
17a52670
AS
878 size = bpf_size_to_bytes(bpf_size);
879 if (size < 0)
880 return size;
881
e07b98d9 882 err = check_ptr_alignment(env, reg, off, size);
969bf05e
AS
883 if (err)
884 return err;
17a52670 885
48461135
JB
886 if (reg->type == PTR_TO_MAP_VALUE ||
887 reg->type == PTR_TO_MAP_VALUE_ADJ) {
1be7f75d
AS
888 if (t == BPF_WRITE && value_regno >= 0 &&
889 is_pointer_value(env, value_regno)) {
890 verbose("R%d leaks addr into map\n", value_regno);
891 return -EACCES;
892 }
48461135 893
dbcfe5f7
GB
894 if (reg->type == PTR_TO_MAP_VALUE_ADJ)
895 err = check_map_access_adj(env, regno, off, size);
896 else
897 err = check_map_access(env, regno, off, size);
17a52670 898 if (!err && t == BPF_READ && value_regno >= 0)
f0318d01
GB
899 mark_reg_unknown_value_and_range(state->regs,
900 value_regno);
17a52670 901
1a0dc1ac 902 } else if (reg->type == PTR_TO_CTX) {
19de99f7
AS
903 enum bpf_reg_type reg_type = UNKNOWN_VALUE;
904
1be7f75d
AS
905 if (t == BPF_WRITE && value_regno >= 0 &&
906 is_pointer_value(env, value_regno)) {
907 verbose("R%d leaks addr into ctx\n", value_regno);
908 return -EACCES;
909 }
19de99f7 910 err = check_ctx_access(env, off, size, t, &reg_type);
969bf05e 911 if (!err && t == BPF_READ && value_regno >= 0) {
f0318d01
GB
912 mark_reg_unknown_value_and_range(state->regs,
913 value_regno);
1955351d
MS
914 /* note that reg.[id|off|range] == 0 */
915 state->regs[value_regno].type = reg_type;
d1174416
DM
916 state->regs[value_regno].aux_off = 0;
917 state->regs[value_regno].aux_off_align = 0;
969bf05e 918 }
17a52670 919
1a0dc1ac 920 } else if (reg->type == FRAME_PTR || reg->type == PTR_TO_STACK) {
17a52670
AS
921 if (off >= 0 || off < -MAX_BPF_STACK) {
922 verbose("invalid stack off=%d size=%d\n", off, size);
923 return -EACCES;
924 }
1be7f75d
AS
925 if (t == BPF_WRITE) {
926 if (!env->allow_ptr_leaks &&
927 state->stack_slot_type[MAX_BPF_STACK + off] == STACK_SPILL &&
928 size != BPF_REG_SIZE) {
929 verbose("attempt to corrupt spilled pointer on stack\n");
930 return -EACCES;
931 }
17a52670 932 err = check_stack_write(state, off, size, value_regno);
1be7f75d 933 } else {
17a52670 934 err = check_stack_read(state, off, size, value_regno);
1be7f75d 935 }
969bf05e 936 } else if (state->regs[regno].type == PTR_TO_PACKET) {
3a0af8fd 937 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
969bf05e
AS
938 verbose("cannot write into packet\n");
939 return -EACCES;
940 }
4acf6c0b
BB
941 if (t == BPF_WRITE && value_regno >= 0 &&
942 is_pointer_value(env, value_regno)) {
943 verbose("R%d leaks addr into packet\n", value_regno);
944 return -EACCES;
945 }
969bf05e
AS
946 err = check_packet_access(env, regno, off, size);
947 if (!err && t == BPF_READ && value_regno >= 0)
f0318d01
GB
948 mark_reg_unknown_value_and_range(state->regs,
949 value_regno);
17a52670
AS
950 } else {
951 verbose("R%d invalid mem access '%s'\n",
1a0dc1ac 952 regno, reg_type_str[reg->type]);
17a52670
AS
953 return -EACCES;
954 }
969bf05e
AS
955
956 if (!err && size <= 2 && value_regno >= 0 && env->allow_ptr_leaks &&
957 state->regs[value_regno].type == UNKNOWN_VALUE) {
958 /* 1 or 2 byte load zero-extends, determine the number of
959 * zero upper bits. Not doing it fo 4 byte load, since
960 * such values cannot be added to ptr_to_packet anyway.
961 */
962 state->regs[value_regno].imm = 64 - size * 8;
963 }
17a52670
AS
964 return err;
965}
966
58e2af8b 967static int check_xadd(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 968{
58e2af8b 969 struct bpf_reg_state *regs = env->cur_state.regs;
17a52670
AS
970 int err;
971
972 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
973 insn->imm != 0) {
974 verbose("BPF_XADD uses reserved fields\n");
975 return -EINVAL;
976 }
977
978 /* check src1 operand */
979 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
980 if (err)
981 return err;
982
983 /* check src2 operand */
984 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
985 if (err)
986 return err;
987
988 /* check whether atomic_add can read the memory */
989 err = check_mem_access(env, insn->dst_reg, insn->off,
990 BPF_SIZE(insn->code), BPF_READ, -1);
991 if (err)
992 return err;
993
994 /* check whether atomic_add can write into the same memory */
995 return check_mem_access(env, insn->dst_reg, insn->off,
996 BPF_SIZE(insn->code), BPF_WRITE, -1);
997}
998
999/* when register 'regno' is passed into function that will read 'access_size'
1000 * bytes from that pointer, make sure that it's within stack boundary
1001 * and all elements of stack are initialized
1002 */
58e2af8b 1003static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
435faee1
DB
1004 int access_size, bool zero_size_allowed,
1005 struct bpf_call_arg_meta *meta)
17a52670 1006{
58e2af8b
JK
1007 struct bpf_verifier_state *state = &env->cur_state;
1008 struct bpf_reg_state *regs = state->regs;
17a52670
AS
1009 int off, i;
1010
8e2fe1d9
DB
1011 if (regs[regno].type != PTR_TO_STACK) {
1012 if (zero_size_allowed && access_size == 0 &&
1013 regs[regno].type == CONST_IMM &&
1014 regs[regno].imm == 0)
1015 return 0;
1016
1017 verbose("R%d type=%s expected=%s\n", regno,
1018 reg_type_str[regs[regno].type],
1019 reg_type_str[PTR_TO_STACK]);
17a52670 1020 return -EACCES;
8e2fe1d9 1021 }
17a52670
AS
1022
1023 off = regs[regno].imm;
1024 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
1025 access_size <= 0) {
1026 verbose("invalid stack type R%d off=%d access_size=%d\n",
1027 regno, off, access_size);
1028 return -EACCES;
1029 }
1030
435faee1
DB
1031 if (meta && meta->raw_mode) {
1032 meta->access_size = access_size;
1033 meta->regno = regno;
1034 return 0;
1035 }
1036
17a52670 1037 for (i = 0; i < access_size; i++) {
9c399760 1038 if (state->stack_slot_type[MAX_BPF_STACK + off + i] != STACK_MISC) {
17a52670
AS
1039 verbose("invalid indirect read from stack off %d+%d size %d\n",
1040 off, i, access_size);
1041 return -EACCES;
1042 }
1043 }
1044 return 0;
1045}
1046
06c1c049
GB
1047static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
1048 int access_size, bool zero_size_allowed,
1049 struct bpf_call_arg_meta *meta)
1050{
1051 struct bpf_reg_state *regs = env->cur_state.regs;
1052
1053 switch (regs[regno].type) {
1054 case PTR_TO_PACKET:
1055 return check_packet_access(env, regno, 0, access_size);
1056 case PTR_TO_MAP_VALUE:
1057 return check_map_access(env, regno, 0, access_size);
1058 case PTR_TO_MAP_VALUE_ADJ:
1059 return check_map_access_adj(env, regno, 0, access_size);
1060 default: /* const_imm|ptr_to_stack or invalid ptr */
1061 return check_stack_boundary(env, regno, access_size,
1062 zero_size_allowed, meta);
1063 }
1064}
1065
58e2af8b 1066static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
33ff9823
DB
1067 enum bpf_arg_type arg_type,
1068 struct bpf_call_arg_meta *meta)
17a52670 1069{
58e2af8b 1070 struct bpf_reg_state *regs = env->cur_state.regs, *reg = &regs[regno];
6841de8b 1071 enum bpf_reg_type expected_type, type = reg->type;
17a52670
AS
1072 int err = 0;
1073
80f1d68c 1074 if (arg_type == ARG_DONTCARE)
17a52670
AS
1075 return 0;
1076
6841de8b 1077 if (type == NOT_INIT) {
17a52670
AS
1078 verbose("R%d !read_ok\n", regno);
1079 return -EACCES;
1080 }
1081
1be7f75d
AS
1082 if (arg_type == ARG_ANYTHING) {
1083 if (is_pointer_value(env, regno)) {
1084 verbose("R%d leaks addr into helper function\n", regno);
1085 return -EACCES;
1086 }
80f1d68c 1087 return 0;
1be7f75d 1088 }
80f1d68c 1089
3a0af8fd
TG
1090 if (type == PTR_TO_PACKET &&
1091 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
36bbef52 1092 verbose("helper access to the packet is not allowed\n");
6841de8b
AS
1093 return -EACCES;
1094 }
1095
8e2fe1d9 1096 if (arg_type == ARG_PTR_TO_MAP_KEY ||
17a52670
AS
1097 arg_type == ARG_PTR_TO_MAP_VALUE) {
1098 expected_type = PTR_TO_STACK;
6841de8b
AS
1099 if (type != PTR_TO_PACKET && type != expected_type)
1100 goto err_type;
39f19ebb
AS
1101 } else if (arg_type == ARG_CONST_SIZE ||
1102 arg_type == ARG_CONST_SIZE_OR_ZERO) {
17a52670 1103 expected_type = CONST_IMM;
06c1c049
GB
1104 /* One exception. Allow UNKNOWN_VALUE registers when the
1105 * boundaries are known and don't cause unsafe memory accesses
1106 */
1107 if (type != UNKNOWN_VALUE && type != expected_type)
6841de8b 1108 goto err_type;
17a52670
AS
1109 } else if (arg_type == ARG_CONST_MAP_PTR) {
1110 expected_type = CONST_PTR_TO_MAP;
6841de8b
AS
1111 if (type != expected_type)
1112 goto err_type;
608cd71a
AS
1113 } else if (arg_type == ARG_PTR_TO_CTX) {
1114 expected_type = PTR_TO_CTX;
6841de8b
AS
1115 if (type != expected_type)
1116 goto err_type;
39f19ebb
AS
1117 } else if (arg_type == ARG_PTR_TO_MEM ||
1118 arg_type == ARG_PTR_TO_UNINIT_MEM) {
8e2fe1d9
DB
1119 expected_type = PTR_TO_STACK;
1120 /* One exception here. In case function allows for NULL to be
1121 * passed in as argument, it's a CONST_IMM type. Final test
1122 * happens during stack boundary checking.
1123 */
6841de8b
AS
1124 if (type == CONST_IMM && reg->imm == 0)
1125 /* final test in check_stack_boundary() */;
5722569b
GB
1126 else if (type != PTR_TO_PACKET && type != PTR_TO_MAP_VALUE &&
1127 type != PTR_TO_MAP_VALUE_ADJ && type != expected_type)
6841de8b 1128 goto err_type;
39f19ebb 1129 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
17a52670
AS
1130 } else {
1131 verbose("unsupported arg_type %d\n", arg_type);
1132 return -EFAULT;
1133 }
1134
17a52670
AS
1135 if (arg_type == ARG_CONST_MAP_PTR) {
1136 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
33ff9823 1137 meta->map_ptr = reg->map_ptr;
17a52670
AS
1138 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1139 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1140 * check that [key, key + map->key_size) are within
1141 * stack limits and initialized
1142 */
33ff9823 1143 if (!meta->map_ptr) {
17a52670
AS
1144 /* in function declaration map_ptr must come before
1145 * map_key, so that it's verified and known before
1146 * we have to check map_key here. Otherwise it means
1147 * that kernel subsystem misconfigured verifier
1148 */
1149 verbose("invalid map_ptr to access map->key\n");
1150 return -EACCES;
1151 }
6841de8b
AS
1152 if (type == PTR_TO_PACKET)
1153 err = check_packet_access(env, regno, 0,
1154 meta->map_ptr->key_size);
1155 else
1156 err = check_stack_boundary(env, regno,
1157 meta->map_ptr->key_size,
1158 false, NULL);
17a52670
AS
1159 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1160 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1161 * check [value, value + map->value_size) validity
1162 */
33ff9823 1163 if (!meta->map_ptr) {
17a52670
AS
1164 /* kernel subsystem misconfigured verifier */
1165 verbose("invalid map_ptr to access map->value\n");
1166 return -EACCES;
1167 }
6841de8b
AS
1168 if (type == PTR_TO_PACKET)
1169 err = check_packet_access(env, regno, 0,
1170 meta->map_ptr->value_size);
1171 else
1172 err = check_stack_boundary(env, regno,
1173 meta->map_ptr->value_size,
1174 false, NULL);
39f19ebb
AS
1175 } else if (arg_type == ARG_CONST_SIZE ||
1176 arg_type == ARG_CONST_SIZE_OR_ZERO) {
1177 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
17a52670 1178
17a52670
AS
1179 /* bpf_xxx(..., buf, len) call will access 'len' bytes
1180 * from stack pointer 'buf'. Check it
1181 * note: regno == len, regno - 1 == buf
1182 */
1183 if (regno == 0) {
1184 /* kernel subsystem misconfigured verifier */
39f19ebb 1185 verbose("ARG_CONST_SIZE cannot be first argument\n");
17a52670
AS
1186 return -EACCES;
1187 }
06c1c049
GB
1188
1189 /* If the register is UNKNOWN_VALUE, the access check happens
1190 * using its boundaries. Otherwise, just use its imm
1191 */
1192 if (type == UNKNOWN_VALUE) {
1193 /* For unprivileged variable accesses, disable raw
1194 * mode so that the program is required to
1195 * initialize all the memory that the helper could
1196 * just partially fill up.
1197 */
1198 meta = NULL;
1199
1200 if (reg->min_value < 0) {
1201 verbose("R%d min value is negative, either use unsigned or 'var &= const'\n",
1202 regno);
1203 return -EACCES;
1204 }
1205
1206 if (reg->min_value == 0) {
1207 err = check_helper_mem_access(env, regno - 1, 0,
1208 zero_size_allowed,
1209 meta);
1210 if (err)
1211 return err;
1212 }
1213
1214 if (reg->max_value == BPF_REGISTER_MAX_RANGE) {
1215 verbose("R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
1216 regno);
1217 return -EACCES;
1218 }
1219 err = check_helper_mem_access(env, regno - 1,
1220 reg->max_value,
1221 zero_size_allowed, meta);
1222 if (err)
1223 return err;
1224 } else {
1225 /* register is CONST_IMM */
1226 err = check_helper_mem_access(env, regno - 1, reg->imm,
1227 zero_size_allowed, meta);
1228 }
17a52670
AS
1229 }
1230
1231 return err;
6841de8b
AS
1232err_type:
1233 verbose("R%d type=%s expected=%s\n", regno,
1234 reg_type_str[type], reg_type_str[expected_type]);
1235 return -EACCES;
17a52670
AS
1236}
1237
35578d79
KX
1238static int check_map_func_compatibility(struct bpf_map *map, int func_id)
1239{
35578d79
KX
1240 if (!map)
1241 return 0;
1242
6aff67c8
AS
1243 /* We need a two way check, first is from map perspective ... */
1244 switch (map->map_type) {
1245 case BPF_MAP_TYPE_PROG_ARRAY:
1246 if (func_id != BPF_FUNC_tail_call)
1247 goto error;
1248 break;
1249 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
1250 if (func_id != BPF_FUNC_perf_event_read &&
1251 func_id != BPF_FUNC_perf_event_output)
1252 goto error;
1253 break;
1254 case BPF_MAP_TYPE_STACK_TRACE:
1255 if (func_id != BPF_FUNC_get_stackid)
1256 goto error;
1257 break;
4ed8ec52 1258 case BPF_MAP_TYPE_CGROUP_ARRAY:
60747ef4 1259 if (func_id != BPF_FUNC_skb_under_cgroup &&
60d20f91 1260 func_id != BPF_FUNC_current_task_under_cgroup)
4a482f34
MKL
1261 goto error;
1262 break;
56f668df 1263 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
bcc6b1b7 1264 case BPF_MAP_TYPE_HASH_OF_MAPS:
56f668df
MKL
1265 if (func_id != BPF_FUNC_map_lookup_elem)
1266 goto error;
6aff67c8
AS
1267 default:
1268 break;
1269 }
1270
1271 /* ... and second from the function itself. */
1272 switch (func_id) {
1273 case BPF_FUNC_tail_call:
1274 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
1275 goto error;
1276 break;
1277 case BPF_FUNC_perf_event_read:
1278 case BPF_FUNC_perf_event_output:
1279 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
1280 goto error;
1281 break;
1282 case BPF_FUNC_get_stackid:
1283 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
1284 goto error;
1285 break;
60d20f91 1286 case BPF_FUNC_current_task_under_cgroup:
747ea55e 1287 case BPF_FUNC_skb_under_cgroup:
4a482f34
MKL
1288 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
1289 goto error;
1290 break;
6aff67c8
AS
1291 default:
1292 break;
35578d79
KX
1293 }
1294
1295 return 0;
6aff67c8 1296error:
ebb676da
TG
1297 verbose("cannot pass map_type %d into func %s#%d\n",
1298 map->map_type, func_id_name(func_id), func_id);
6aff67c8 1299 return -EINVAL;
35578d79
KX
1300}
1301
435faee1
DB
1302static int check_raw_mode(const struct bpf_func_proto *fn)
1303{
1304 int count = 0;
1305
39f19ebb 1306 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 1307 count++;
39f19ebb 1308 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 1309 count++;
39f19ebb 1310 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 1311 count++;
39f19ebb 1312 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
435faee1 1313 count++;
39f19ebb 1314 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
435faee1
DB
1315 count++;
1316
1317 return count > 1 ? -EINVAL : 0;
1318}
1319
58e2af8b 1320static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
969bf05e 1321{
58e2af8b
JK
1322 struct bpf_verifier_state *state = &env->cur_state;
1323 struct bpf_reg_state *regs = state->regs, *reg;
969bf05e
AS
1324 int i;
1325
1326 for (i = 0; i < MAX_BPF_REG; i++)
1327 if (regs[i].type == PTR_TO_PACKET ||
1328 regs[i].type == PTR_TO_PACKET_END)
1329 mark_reg_unknown_value(regs, i);
1330
1331 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
1332 if (state->stack_slot_type[i] != STACK_SPILL)
1333 continue;
1334 reg = &state->spilled_regs[i / BPF_REG_SIZE];
1335 if (reg->type != PTR_TO_PACKET &&
1336 reg->type != PTR_TO_PACKET_END)
1337 continue;
1338 reg->type = UNKNOWN_VALUE;
1339 reg->imm = 0;
1340 }
1341}
1342
81ed18ab 1343static int check_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
17a52670 1344{
58e2af8b 1345 struct bpf_verifier_state *state = &env->cur_state;
17a52670 1346 const struct bpf_func_proto *fn = NULL;
58e2af8b
JK
1347 struct bpf_reg_state *regs = state->regs;
1348 struct bpf_reg_state *reg;
33ff9823 1349 struct bpf_call_arg_meta meta;
969bf05e 1350 bool changes_data;
17a52670
AS
1351 int i, err;
1352
1353 /* find function prototype */
1354 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
ebb676da 1355 verbose("invalid func %s#%d\n", func_id_name(func_id), func_id);
17a52670
AS
1356 return -EINVAL;
1357 }
1358
1359 if (env->prog->aux->ops->get_func_proto)
1360 fn = env->prog->aux->ops->get_func_proto(func_id);
1361
1362 if (!fn) {
ebb676da 1363 verbose("unknown func %s#%d\n", func_id_name(func_id), func_id);
17a52670
AS
1364 return -EINVAL;
1365 }
1366
1367 /* eBPF programs must be GPL compatible to use GPL-ed functions */
24701ece 1368 if (!env->prog->gpl_compatible && fn->gpl_only) {
17a52670
AS
1369 verbose("cannot call GPL only function from proprietary program\n");
1370 return -EINVAL;
1371 }
1372
17bedab2 1373 changes_data = bpf_helper_changes_pkt_data(fn->func);
969bf05e 1374
33ff9823 1375 memset(&meta, 0, sizeof(meta));
36bbef52 1376 meta.pkt_access = fn->pkt_access;
33ff9823 1377
435faee1
DB
1378 /* We only support one arg being in raw mode at the moment, which
1379 * is sufficient for the helper functions we have right now.
1380 */
1381 err = check_raw_mode(fn);
1382 if (err) {
ebb676da
TG
1383 verbose("kernel subsystem misconfigured func %s#%d\n",
1384 func_id_name(func_id), func_id);
435faee1
DB
1385 return err;
1386 }
1387
17a52670 1388 /* check args */
33ff9823 1389 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
17a52670
AS
1390 if (err)
1391 return err;
33ff9823 1392 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
17a52670
AS
1393 if (err)
1394 return err;
33ff9823 1395 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
17a52670
AS
1396 if (err)
1397 return err;
33ff9823 1398 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
17a52670
AS
1399 if (err)
1400 return err;
33ff9823 1401 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
17a52670
AS
1402 if (err)
1403 return err;
1404
435faee1
DB
1405 /* Mark slots with STACK_MISC in case of raw mode, stack offset
1406 * is inferred from register state.
1407 */
1408 for (i = 0; i < meta.access_size; i++) {
1409 err = check_mem_access(env, meta.regno, i, BPF_B, BPF_WRITE, -1);
1410 if (err)
1411 return err;
1412 }
1413
17a52670
AS
1414 /* reset caller saved regs */
1415 for (i = 0; i < CALLER_SAVED_REGS; i++) {
1416 reg = regs + caller_saved[i];
1417 reg->type = NOT_INIT;
1418 reg->imm = 0;
1419 }
1420
1421 /* update return register */
1422 if (fn->ret_type == RET_INTEGER) {
1423 regs[BPF_REG_0].type = UNKNOWN_VALUE;
1424 } else if (fn->ret_type == RET_VOID) {
1425 regs[BPF_REG_0].type = NOT_INIT;
1426 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
fad73a1a
MKL
1427 struct bpf_insn_aux_data *insn_aux;
1428
17a52670 1429 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
48461135 1430 regs[BPF_REG_0].max_value = regs[BPF_REG_0].min_value = 0;
17a52670
AS
1431 /* remember map_ptr, so that check_map_access()
1432 * can check 'value_size' boundary of memory access
1433 * to map element returned from bpf_map_lookup_elem()
1434 */
33ff9823 1435 if (meta.map_ptr == NULL) {
17a52670
AS
1436 verbose("kernel subsystem misconfigured verifier\n");
1437 return -EINVAL;
1438 }
33ff9823 1439 regs[BPF_REG_0].map_ptr = meta.map_ptr;
57a09bf0 1440 regs[BPF_REG_0].id = ++env->id_gen;
fad73a1a
MKL
1441 insn_aux = &env->insn_aux_data[insn_idx];
1442 if (!insn_aux->map_ptr)
1443 insn_aux->map_ptr = meta.map_ptr;
1444 else if (insn_aux->map_ptr != meta.map_ptr)
1445 insn_aux->map_ptr = BPF_MAP_PTR_POISON;
17a52670 1446 } else {
ebb676da
TG
1447 verbose("unknown return type %d of func %s#%d\n",
1448 fn->ret_type, func_id_name(func_id), func_id);
17a52670
AS
1449 return -EINVAL;
1450 }
04fd61ab 1451
33ff9823 1452 err = check_map_func_compatibility(meta.map_ptr, func_id);
35578d79
KX
1453 if (err)
1454 return err;
04fd61ab 1455
969bf05e
AS
1456 if (changes_data)
1457 clear_all_pkt_pointers(env);
1458 return 0;
1459}
1460
58e2af8b
JK
1461static int check_packet_ptr_add(struct bpf_verifier_env *env,
1462 struct bpf_insn *insn)
969bf05e 1463{
58e2af8b
JK
1464 struct bpf_reg_state *regs = env->cur_state.regs;
1465 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1466 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
1467 struct bpf_reg_state tmp_reg;
969bf05e
AS
1468 s32 imm;
1469
1470 if (BPF_SRC(insn->code) == BPF_K) {
1471 /* pkt_ptr += imm */
1472 imm = insn->imm;
1473
1474add_imm:
63dfef75 1475 if (imm < 0) {
969bf05e
AS
1476 verbose("addition of negative constant to packet pointer is not allowed\n");
1477 return -EACCES;
1478 }
1479 if (imm >= MAX_PACKET_OFF ||
1480 imm + dst_reg->off >= MAX_PACKET_OFF) {
1481 verbose("constant %d is too large to add to packet pointer\n",
1482 imm);
1483 return -EACCES;
1484 }
1485 /* a constant was added to pkt_ptr.
1486 * Remember it while keeping the same 'id'
1487 */
1488 dst_reg->off += imm;
1489 } else {
d1174416
DM
1490 bool had_id;
1491
1b9b69ec
AS
1492 if (src_reg->type == PTR_TO_PACKET) {
1493 /* R6=pkt(id=0,off=0,r=62) R7=imm22; r7 += r6 */
1494 tmp_reg = *dst_reg; /* save r7 state */
1495 *dst_reg = *src_reg; /* copy pkt_ptr state r6 into r7 */
1496 src_reg = &tmp_reg; /* pretend it's src_reg state */
1497 /* if the checks below reject it, the copy won't matter,
1498 * since we're rejecting the whole program. If all ok,
1499 * then imm22 state will be added to r7
1500 * and r7 will be pkt(id=0,off=22,r=62) while
1501 * r6 will stay as pkt(id=0,off=0,r=62)
1502 */
1503 }
1504
969bf05e
AS
1505 if (src_reg->type == CONST_IMM) {
1506 /* pkt_ptr += reg where reg is known constant */
1507 imm = src_reg->imm;
1508 goto add_imm;
1509 }
1510 /* disallow pkt_ptr += reg
1511 * if reg is not uknown_value with guaranteed zero upper bits
1512 * otherwise pkt_ptr may overflow and addition will become
1513 * subtraction which is not allowed
1514 */
1515 if (src_reg->type != UNKNOWN_VALUE) {
1516 verbose("cannot add '%s' to ptr_to_packet\n",
1517 reg_type_str[src_reg->type]);
1518 return -EACCES;
1519 }
1520 if (src_reg->imm < 48) {
1521 verbose("cannot add integer value with %lld upper zero bits to ptr_to_packet\n",
1522 src_reg->imm);
1523 return -EACCES;
1524 }
d1174416
DM
1525
1526 had_id = (dst_reg->id != 0);
1527
969bf05e
AS
1528 /* dst_reg stays as pkt_ptr type and since some positive
1529 * integer value was added to the pointer, increment its 'id'
1530 */
1f415a74 1531 dst_reg->id = ++env->id_gen;
969bf05e 1532
d1174416 1533 /* something was added to pkt_ptr, set range to zero */
6832a333 1534 dst_reg->aux_off += dst_reg->off;
969bf05e
AS
1535 dst_reg->off = 0;
1536 dst_reg->range = 0;
d1174416
DM
1537 if (had_id)
1538 dst_reg->aux_off_align = min(dst_reg->aux_off_align,
1539 src_reg->min_align);
1540 else
1541 dst_reg->aux_off_align = src_reg->min_align;
969bf05e
AS
1542 }
1543 return 0;
1544}
1545
58e2af8b 1546static int evaluate_reg_alu(struct bpf_verifier_env *env, struct bpf_insn *insn)
969bf05e 1547{
58e2af8b
JK
1548 struct bpf_reg_state *regs = env->cur_state.regs;
1549 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
969bf05e
AS
1550 u8 opcode = BPF_OP(insn->code);
1551 s64 imm_log2;
1552
1553 /* for type == UNKNOWN_VALUE:
1554 * imm > 0 -> number of zero upper bits
1555 * imm == 0 -> don't track which is the same as all bits can be non-zero
1556 */
1557
1558 if (BPF_SRC(insn->code) == BPF_X) {
58e2af8b 1559 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
969bf05e
AS
1560
1561 if (src_reg->type == UNKNOWN_VALUE && src_reg->imm > 0 &&
1562 dst_reg->imm && opcode == BPF_ADD) {
1563 /* dreg += sreg
1564 * where both have zero upper bits. Adding them
1565 * can only result making one more bit non-zero
1566 * in the larger value.
1567 * Ex. 0xffff (imm=48) + 1 (imm=63) = 0x10000 (imm=47)
1568 * 0xffff (imm=48) + 0xffff = 0x1fffe (imm=47)
1569 */
1570 dst_reg->imm = min(dst_reg->imm, src_reg->imm);
1571 dst_reg->imm--;
1572 return 0;
1573 }
1574 if (src_reg->type == CONST_IMM && src_reg->imm > 0 &&
1575 dst_reg->imm && opcode == BPF_ADD) {
1576 /* dreg += sreg
1577 * where dreg has zero upper bits and sreg is const.
1578 * Adding them can only result making one more bit
1579 * non-zero in the larger value.
1580 */
1581 imm_log2 = __ilog2_u64((long long)src_reg->imm);
1582 dst_reg->imm = min(dst_reg->imm, 63 - imm_log2);
1583 dst_reg->imm--;
1584 return 0;
1585 }
1586 /* all other cases non supported yet, just mark dst_reg */
1587 dst_reg->imm = 0;
1588 return 0;
1589 }
1590
1591 /* sign extend 32-bit imm into 64-bit to make sure that
1592 * negative values occupy bit 63. Note ilog2() would have
1593 * been incorrect, since sizeof(insn->imm) == 4
1594 */
1595 imm_log2 = __ilog2_u64((long long)insn->imm);
1596
1597 if (dst_reg->imm && opcode == BPF_LSH) {
1598 /* reg <<= imm
1599 * if reg was a result of 2 byte load, then its imm == 48
1600 * which means that upper 48 bits are zero and shifting this reg
1601 * left by 4 would mean that upper 44 bits are still zero
1602 */
1603 dst_reg->imm -= insn->imm;
1604 } else if (dst_reg->imm && opcode == BPF_MUL) {
1605 /* reg *= imm
1606 * if multiplying by 14 subtract 4
1607 * This is conservative calculation of upper zero bits.
1608 * It's not trying to special case insn->imm == 1 or 0 cases
1609 */
1610 dst_reg->imm -= imm_log2 + 1;
1611 } else if (opcode == BPF_AND) {
1612 /* reg &= imm */
1613 dst_reg->imm = 63 - imm_log2;
1614 } else if (dst_reg->imm && opcode == BPF_ADD) {
1615 /* reg += imm */
1616 dst_reg->imm = min(dst_reg->imm, 63 - imm_log2);
1617 dst_reg->imm--;
1618 } else if (opcode == BPF_RSH) {
1619 /* reg >>= imm
1620 * which means that after right shift, upper bits will be zero
1621 * note that verifier already checked that
1622 * 0 <= imm < 64 for shift insn
1623 */
1624 dst_reg->imm += insn->imm;
1625 if (unlikely(dst_reg->imm > 64))
1626 /* some dumb code did:
1627 * r2 = *(u32 *)mem;
1628 * r2 >>= 32;
1629 * and all bits are zero now */
1630 dst_reg->imm = 64;
1631 } else {
1632 /* all other alu ops, means that we don't know what will
1633 * happen to the value, mark it with unknown number of zero bits
1634 */
1635 dst_reg->imm = 0;
1636 }
1637
1638 if (dst_reg->imm < 0) {
1639 /* all 64 bits of the register can contain non-zero bits
1640 * and such value cannot be added to ptr_to_packet, since it
1641 * may overflow, mark it as unknown to avoid further eval
1642 */
1643 dst_reg->imm = 0;
1644 }
1645 return 0;
1646}
1647
58e2af8b
JK
1648static int evaluate_reg_imm_alu(struct bpf_verifier_env *env,
1649 struct bpf_insn *insn)
969bf05e 1650{
58e2af8b
JK
1651 struct bpf_reg_state *regs = env->cur_state.regs;
1652 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1653 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
969bf05e 1654 u8 opcode = BPF_OP(insn->code);
3fadc801 1655 u64 dst_imm = dst_reg->imm;
969bf05e 1656
3fadc801
DB
1657 /* dst_reg->type == CONST_IMM here. Simulate execution of insns
1658 * containing ALU ops. Don't care about overflow or negative
1659 * values, just add/sub/... them; registers are in u64.
969bf05e 1660 */
3fadc801
DB
1661 if (opcode == BPF_ADD && BPF_SRC(insn->code) == BPF_K) {
1662 dst_imm += insn->imm;
1663 } else if (opcode == BPF_ADD && BPF_SRC(insn->code) == BPF_X &&
1664 src_reg->type == CONST_IMM) {
1665 dst_imm += src_reg->imm;
1666 } else if (opcode == BPF_SUB && BPF_SRC(insn->code) == BPF_K) {
1667 dst_imm -= insn->imm;
1668 } else if (opcode == BPF_SUB && BPF_SRC(insn->code) == BPF_X &&
1669 src_reg->type == CONST_IMM) {
1670 dst_imm -= src_reg->imm;
1671 } else if (opcode == BPF_MUL && BPF_SRC(insn->code) == BPF_K) {
1672 dst_imm *= insn->imm;
1673 } else if (opcode == BPF_MUL && BPF_SRC(insn->code) == BPF_X &&
1674 src_reg->type == CONST_IMM) {
1675 dst_imm *= src_reg->imm;
1676 } else if (opcode == BPF_OR && BPF_SRC(insn->code) == BPF_K) {
1677 dst_imm |= insn->imm;
1678 } else if (opcode == BPF_OR && BPF_SRC(insn->code) == BPF_X &&
1679 src_reg->type == CONST_IMM) {
1680 dst_imm |= src_reg->imm;
1681 } else if (opcode == BPF_AND && BPF_SRC(insn->code) == BPF_K) {
1682 dst_imm &= insn->imm;
1683 } else if (opcode == BPF_AND && BPF_SRC(insn->code) == BPF_X &&
1684 src_reg->type == CONST_IMM) {
1685 dst_imm &= src_reg->imm;
1686 } else if (opcode == BPF_RSH && BPF_SRC(insn->code) == BPF_K) {
1687 dst_imm >>= insn->imm;
1688 } else if (opcode == BPF_RSH && BPF_SRC(insn->code) == BPF_X &&
1689 src_reg->type == CONST_IMM) {
1690 dst_imm >>= src_reg->imm;
1691 } else if (opcode == BPF_LSH && BPF_SRC(insn->code) == BPF_K) {
1692 dst_imm <<= insn->imm;
1693 } else if (opcode == BPF_LSH && BPF_SRC(insn->code) == BPF_X &&
1694 src_reg->type == CONST_IMM) {
1695 dst_imm <<= src_reg->imm;
1696 } else {
969bf05e 1697 mark_reg_unknown_value(regs, insn->dst_reg);
3fadc801
DB
1698 goto out;
1699 }
1700
1701 dst_reg->imm = dst_imm;
1702out:
17a52670
AS
1703 return 0;
1704}
1705
48461135
JB
1706static void check_reg_overflow(struct bpf_reg_state *reg)
1707{
1708 if (reg->max_value > BPF_REGISTER_MAX_RANGE)
1709 reg->max_value = BPF_REGISTER_MAX_RANGE;
f23cc643
JB
1710 if (reg->min_value < BPF_REGISTER_MIN_RANGE ||
1711 reg->min_value > BPF_REGISTER_MAX_RANGE)
48461135
JB
1712 reg->min_value = BPF_REGISTER_MIN_RANGE;
1713}
1714
d1174416
DM
1715static u32 calc_align(u32 imm)
1716{
1717 if (!imm)
1718 return 1U << 31;
1719 return imm - ((imm - 1) & imm);
1720}
1721
48461135
JB
1722static void adjust_reg_min_max_vals(struct bpf_verifier_env *env,
1723 struct bpf_insn *insn)
1724{
1725 struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg;
f23cc643
JB
1726 s64 min_val = BPF_REGISTER_MIN_RANGE;
1727 u64 max_val = BPF_REGISTER_MAX_RANGE;
48461135 1728 u8 opcode = BPF_OP(insn->code);
d1174416 1729 u32 dst_align, src_align;
48461135
JB
1730
1731 dst_reg = &regs[insn->dst_reg];
d1174416 1732 src_align = 0;
48461135
JB
1733 if (BPF_SRC(insn->code) == BPF_X) {
1734 check_reg_overflow(&regs[insn->src_reg]);
1735 min_val = regs[insn->src_reg].min_value;
1736 max_val = regs[insn->src_reg].max_value;
1737
1738 /* If the source register is a random pointer then the
1739 * min_value/max_value values represent the range of the known
1740 * accesses into that value, not the actual min/max value of the
1741 * register itself. In this case we have to reset the reg range
1742 * values so we know it is not safe to look at.
1743 */
1744 if (regs[insn->src_reg].type != CONST_IMM &&
1745 regs[insn->src_reg].type != UNKNOWN_VALUE) {
1746 min_val = BPF_REGISTER_MIN_RANGE;
1747 max_val = BPF_REGISTER_MAX_RANGE;
d1174416
DM
1748 src_align = 0;
1749 } else {
1750 src_align = regs[insn->src_reg].min_align;
48461135
JB
1751 }
1752 } else if (insn->imm < BPF_REGISTER_MAX_RANGE &&
1753 (s64)insn->imm > BPF_REGISTER_MIN_RANGE) {
1754 min_val = max_val = insn->imm;
d1174416 1755 src_align = calc_align(insn->imm);
48461135
JB
1756 }
1757
d1174416
DM
1758 dst_align = dst_reg->min_align;
1759
48461135
JB
1760 /* We don't know anything about what was done to this register, mark it
1761 * as unknown.
1762 */
1763 if (min_val == BPF_REGISTER_MIN_RANGE &&
1764 max_val == BPF_REGISTER_MAX_RANGE) {
1765 reset_reg_range_values(regs, insn->dst_reg);
1766 return;
1767 }
1768
f23cc643
JB
1769 /* If one of our values was at the end of our ranges then we can't just
1770 * do our normal operations to the register, we need to set the values
1771 * to the min/max since they are undefined.
1772 */
1773 if (min_val == BPF_REGISTER_MIN_RANGE)
1774 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1775 if (max_val == BPF_REGISTER_MAX_RANGE)
1776 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
1777
48461135
JB
1778 switch (opcode) {
1779 case BPF_ADD:
f23cc643
JB
1780 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1781 dst_reg->min_value += min_val;
1782 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1783 dst_reg->max_value += max_val;
d1174416 1784 dst_reg->min_align = min(src_align, dst_align);
48461135
JB
1785 break;
1786 case BPF_SUB:
f23cc643
JB
1787 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1788 dst_reg->min_value -= min_val;
1789 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1790 dst_reg->max_value -= max_val;
d1174416 1791 dst_reg->min_align = min(src_align, dst_align);
48461135
JB
1792 break;
1793 case BPF_MUL:
f23cc643
JB
1794 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1795 dst_reg->min_value *= min_val;
1796 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1797 dst_reg->max_value *= max_val;
d1174416 1798 dst_reg->min_align = max(src_align, dst_align);
48461135
JB
1799 break;
1800 case BPF_AND:
f23cc643
JB
1801 /* Disallow AND'ing of negative numbers, ain't nobody got time
1802 * for that. Otherwise the minimum is 0 and the max is the max
1803 * value we could AND against.
1804 */
1805 if (min_val < 0)
1806 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1807 else
1808 dst_reg->min_value = 0;
48461135 1809 dst_reg->max_value = max_val;
d1174416 1810 dst_reg->min_align = max(src_align, dst_align);
48461135
JB
1811 break;
1812 case BPF_LSH:
1813 /* Gotta have special overflow logic here, if we're shifting
1814 * more than MAX_RANGE then just assume we have an invalid
1815 * range.
1816 */
d1174416 1817 if (min_val > ilog2(BPF_REGISTER_MAX_RANGE)) {
48461135 1818 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
d1174416
DM
1819 dst_reg->min_align = 1;
1820 } else {
1821 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1822 dst_reg->min_value <<= min_val;
1823 if (!dst_reg->min_align)
1824 dst_reg->min_align = 1;
1825 dst_reg->min_align <<= min_val;
1826 }
48461135
JB
1827 if (max_val > ilog2(BPF_REGISTER_MAX_RANGE))
1828 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
f23cc643 1829 else if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
48461135
JB
1830 dst_reg->max_value <<= max_val;
1831 break;
1832 case BPF_RSH:
f23cc643
JB
1833 /* RSH by a negative number is undefined, and the BPF_RSH is an
1834 * unsigned shift, so make the appropriate casts.
48461135 1835 */
d1174416 1836 if (min_val < 0 || dst_reg->min_value < 0) {
f23cc643 1837 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
d1174416 1838 } else {
f23cc643
JB
1839 dst_reg->min_value =
1840 (u64)(dst_reg->min_value) >> min_val;
d1174416
DM
1841 }
1842 if (min_val < 0) {
1843 dst_reg->min_align = 1;
1844 } else {
1845 dst_reg->min_align >>= (u64) min_val;
1846 if (!dst_reg->min_align)
1847 dst_reg->min_align = 1;
1848 }
f23cc643
JB
1849 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1850 dst_reg->max_value >>= max_val;
48461135
JB
1851 break;
1852 default:
1853 reset_reg_range_values(regs, insn->dst_reg);
1854 break;
1855 }
1856
1857 check_reg_overflow(dst_reg);
1858}
1859
17a52670 1860/* check validity of 32-bit and 64-bit arithmetic operations */
58e2af8b 1861static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 1862{
58e2af8b 1863 struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg;
17a52670
AS
1864 u8 opcode = BPF_OP(insn->code);
1865 int err;
1866
1867 if (opcode == BPF_END || opcode == BPF_NEG) {
1868 if (opcode == BPF_NEG) {
1869 if (BPF_SRC(insn->code) != 0 ||
1870 insn->src_reg != BPF_REG_0 ||
1871 insn->off != 0 || insn->imm != 0) {
1872 verbose("BPF_NEG uses reserved fields\n");
1873 return -EINVAL;
1874 }
1875 } else {
1876 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
1877 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64)) {
1878 verbose("BPF_END uses reserved fields\n");
1879 return -EINVAL;
1880 }
1881 }
1882
1883 /* check src operand */
1884 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1885 if (err)
1886 return err;
1887
1be7f75d
AS
1888 if (is_pointer_value(env, insn->dst_reg)) {
1889 verbose("R%d pointer arithmetic prohibited\n",
1890 insn->dst_reg);
1891 return -EACCES;
1892 }
1893
17a52670
AS
1894 /* check dest operand */
1895 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1896 if (err)
1897 return err;
1898
1899 } else if (opcode == BPF_MOV) {
1900
1901 if (BPF_SRC(insn->code) == BPF_X) {
1902 if (insn->imm != 0 || insn->off != 0) {
1903 verbose("BPF_MOV uses reserved fields\n");
1904 return -EINVAL;
1905 }
1906
1907 /* check src operand */
1908 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1909 if (err)
1910 return err;
1911 } else {
1912 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1913 verbose("BPF_MOV uses reserved fields\n");
1914 return -EINVAL;
1915 }
1916 }
1917
1918 /* check dest operand */
1919 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1920 if (err)
1921 return err;
1922
48461135
JB
1923 /* we are setting our register to something new, we need to
1924 * reset its range values.
1925 */
1926 reset_reg_range_values(regs, insn->dst_reg);
1927
17a52670
AS
1928 if (BPF_SRC(insn->code) == BPF_X) {
1929 if (BPF_CLASS(insn->code) == BPF_ALU64) {
1930 /* case: R1 = R2
1931 * copy register state to dest reg
1932 */
1933 regs[insn->dst_reg] = regs[insn->src_reg];
1934 } else {
1be7f75d
AS
1935 if (is_pointer_value(env, insn->src_reg)) {
1936 verbose("R%d partial copy of pointer\n",
1937 insn->src_reg);
1938 return -EACCES;
1939 }
57a09bf0 1940 mark_reg_unknown_value(regs, insn->dst_reg);
17a52670
AS
1941 }
1942 } else {
1943 /* case: R = imm
1944 * remember the value we stored into this reg
1945 */
1946 regs[insn->dst_reg].type = CONST_IMM;
1947 regs[insn->dst_reg].imm = insn->imm;
48461135
JB
1948 regs[insn->dst_reg].max_value = insn->imm;
1949 regs[insn->dst_reg].min_value = insn->imm;
d1174416 1950 regs[insn->dst_reg].min_align = calc_align(insn->imm);
17a52670
AS
1951 }
1952
1953 } else if (opcode > BPF_END) {
1954 verbose("invalid BPF_ALU opcode %x\n", opcode);
1955 return -EINVAL;
1956
1957 } else { /* all other ALU ops: and, sub, xor, add, ... */
1958
17a52670
AS
1959 if (BPF_SRC(insn->code) == BPF_X) {
1960 if (insn->imm != 0 || insn->off != 0) {
1961 verbose("BPF_ALU uses reserved fields\n");
1962 return -EINVAL;
1963 }
1964 /* check src1 operand */
1965 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1966 if (err)
1967 return err;
1968 } else {
1969 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1970 verbose("BPF_ALU uses reserved fields\n");
1971 return -EINVAL;
1972 }
1973 }
1974
1975 /* check src2 operand */
1976 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1977 if (err)
1978 return err;
1979
1980 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
1981 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
1982 verbose("div by zero\n");
1983 return -EINVAL;
1984 }
1985
229394e8
RV
1986 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
1987 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
1988 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
1989
1990 if (insn->imm < 0 || insn->imm >= size) {
1991 verbose("invalid shift %d\n", insn->imm);
1992 return -EINVAL;
1993 }
1994 }
1995
1a0dc1ac
AS
1996 /* check dest operand */
1997 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
1998 if (err)
1999 return err;
2000
2001 dst_reg = &regs[insn->dst_reg];
2002
48461135
JB
2003 /* first we want to adjust our ranges. */
2004 adjust_reg_min_max_vals(env, insn);
2005
17a52670
AS
2006 /* pattern match 'bpf_add Rx, imm' instruction */
2007 if (opcode == BPF_ADD && BPF_CLASS(insn->code) == BPF_ALU64 &&
1a0dc1ac
AS
2008 dst_reg->type == FRAME_PTR && BPF_SRC(insn->code) == BPF_K) {
2009 dst_reg->type = PTR_TO_STACK;
2010 dst_reg->imm = insn->imm;
2011 return 0;
332270fd
YS
2012 } else if (opcode == BPF_ADD &&
2013 BPF_CLASS(insn->code) == BPF_ALU64 &&
2014 dst_reg->type == PTR_TO_STACK &&
2015 ((BPF_SRC(insn->code) == BPF_X &&
2016 regs[insn->src_reg].type == CONST_IMM) ||
2017 BPF_SRC(insn->code) == BPF_K)) {
2018 if (BPF_SRC(insn->code) == BPF_X)
2019 dst_reg->imm += regs[insn->src_reg].imm;
2020 else
2021 dst_reg->imm += insn->imm;
2022 return 0;
969bf05e
AS
2023 } else if (opcode == BPF_ADD &&
2024 BPF_CLASS(insn->code) == BPF_ALU64 &&
1b9b69ec
AS
2025 (dst_reg->type == PTR_TO_PACKET ||
2026 (BPF_SRC(insn->code) == BPF_X &&
2027 regs[insn->src_reg].type == PTR_TO_PACKET))) {
969bf05e
AS
2028 /* ptr_to_packet += K|X */
2029 return check_packet_ptr_add(env, insn);
2030 } else if (BPF_CLASS(insn->code) == BPF_ALU64 &&
2031 dst_reg->type == UNKNOWN_VALUE &&
2032 env->allow_ptr_leaks) {
2033 /* unknown += K|X */
2034 return evaluate_reg_alu(env, insn);
2035 } else if (BPF_CLASS(insn->code) == BPF_ALU64 &&
2036 dst_reg->type == CONST_IMM &&
2037 env->allow_ptr_leaks) {
2038 /* reg_imm += K|X */
2039 return evaluate_reg_imm_alu(env, insn);
1be7f75d
AS
2040 } else if (is_pointer_value(env, insn->dst_reg)) {
2041 verbose("R%d pointer arithmetic prohibited\n",
2042 insn->dst_reg);
2043 return -EACCES;
2044 } else if (BPF_SRC(insn->code) == BPF_X &&
2045 is_pointer_value(env, insn->src_reg)) {
2046 verbose("R%d pointer arithmetic prohibited\n",
2047 insn->src_reg);
2048 return -EACCES;
2049 }
17a52670 2050
48461135
JB
2051 /* If we did pointer math on a map value then just set it to our
2052 * PTR_TO_MAP_VALUE_ADJ type so we can deal with any stores or
2053 * loads to this register appropriately, otherwise just mark the
2054 * register as unknown.
2055 */
2056 if (env->allow_ptr_leaks &&
fce366a9 2057 BPF_CLASS(insn->code) == BPF_ALU64 && opcode == BPF_ADD &&
48461135
JB
2058 (dst_reg->type == PTR_TO_MAP_VALUE ||
2059 dst_reg->type == PTR_TO_MAP_VALUE_ADJ))
2060 dst_reg->type = PTR_TO_MAP_VALUE_ADJ;
2061 else
2062 mark_reg_unknown_value(regs, insn->dst_reg);
17a52670
AS
2063 }
2064
2065 return 0;
2066}
2067
58e2af8b
JK
2068static void find_good_pkt_pointers(struct bpf_verifier_state *state,
2069 struct bpf_reg_state *dst_reg)
969bf05e 2070{
58e2af8b 2071 struct bpf_reg_state *regs = state->regs, *reg;
969bf05e 2072 int i;
2d2be8ca
DB
2073
2074 /* LLVM can generate two kind of checks:
2075 *
2076 * Type 1:
2077 *
2078 * r2 = r3;
2079 * r2 += 8;
2080 * if (r2 > pkt_end) goto <handle exception>
2081 * <access okay>
2082 *
2083 * Where:
2084 * r2 == dst_reg, pkt_end == src_reg
2085 * r2=pkt(id=n,off=8,r=0)
2086 * r3=pkt(id=n,off=0,r=0)
2087 *
2088 * Type 2:
2089 *
2090 * r2 = r3;
2091 * r2 += 8;
2092 * if (pkt_end >= r2) goto <access okay>
2093 * <handle exception>
2094 *
2095 * Where:
2096 * pkt_end == dst_reg, r2 == src_reg
2097 * r2=pkt(id=n,off=8,r=0)
2098 * r3=pkt(id=n,off=0,r=0)
2099 *
2100 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
2101 * so that range of bytes [r3, r3 + 8) is safe to access.
969bf05e 2102 */
2d2be8ca 2103
969bf05e
AS
2104 for (i = 0; i < MAX_BPF_REG; i++)
2105 if (regs[i].type == PTR_TO_PACKET && regs[i].id == dst_reg->id)
b1977682
AS
2106 /* keep the maximum range already checked */
2107 regs[i].range = max(regs[i].range, dst_reg->off);
969bf05e
AS
2108
2109 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
2110 if (state->stack_slot_type[i] != STACK_SPILL)
2111 continue;
2112 reg = &state->spilled_regs[i / BPF_REG_SIZE];
2113 if (reg->type == PTR_TO_PACKET && reg->id == dst_reg->id)
b1977682 2114 reg->range = max(reg->range, dst_reg->off);
969bf05e
AS
2115 }
2116}
2117
48461135
JB
2118/* Adjusts the register min/max values in the case that the dst_reg is the
2119 * variable register that we are working on, and src_reg is a constant or we're
2120 * simply doing a BPF_K check.
2121 */
2122static void reg_set_min_max(struct bpf_reg_state *true_reg,
2123 struct bpf_reg_state *false_reg, u64 val,
2124 u8 opcode)
2125{
2126 switch (opcode) {
2127 case BPF_JEQ:
2128 /* If this is false then we know nothing Jon Snow, but if it is
2129 * true then we know for sure.
2130 */
2131 true_reg->max_value = true_reg->min_value = val;
2132 break;
2133 case BPF_JNE:
2134 /* If this is true we know nothing Jon Snow, but if it is false
2135 * we know the value for sure;
2136 */
2137 false_reg->max_value = false_reg->min_value = val;
2138 break;
2139 case BPF_JGT:
2140 /* Unsigned comparison, the minimum value is 0. */
2141 false_reg->min_value = 0;
7e57fbb2 2142 /* fallthrough */
48461135
JB
2143 case BPF_JSGT:
2144 /* If this is false then we know the maximum val is val,
2145 * otherwise we know the min val is val+1.
2146 */
2147 false_reg->max_value = val;
2148 true_reg->min_value = val + 1;
2149 break;
2150 case BPF_JGE:
2151 /* Unsigned comparison, the minimum value is 0. */
2152 false_reg->min_value = 0;
7e57fbb2 2153 /* fallthrough */
48461135
JB
2154 case BPF_JSGE:
2155 /* If this is false then we know the maximum value is val - 1,
2156 * otherwise we know the mimimum value is val.
2157 */
2158 false_reg->max_value = val - 1;
2159 true_reg->min_value = val;
2160 break;
2161 default:
2162 break;
2163 }
2164
2165 check_reg_overflow(false_reg);
2166 check_reg_overflow(true_reg);
2167}
2168
2169/* Same as above, but for the case that dst_reg is a CONST_IMM reg and src_reg
2170 * is the variable reg.
2171 */
2172static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
2173 struct bpf_reg_state *false_reg, u64 val,
2174 u8 opcode)
2175{
2176 switch (opcode) {
2177 case BPF_JEQ:
2178 /* If this is false then we know nothing Jon Snow, but if it is
2179 * true then we know for sure.
2180 */
2181 true_reg->max_value = true_reg->min_value = val;
2182 break;
2183 case BPF_JNE:
2184 /* If this is true we know nothing Jon Snow, but if it is false
2185 * we know the value for sure;
2186 */
2187 false_reg->max_value = false_reg->min_value = val;
2188 break;
2189 case BPF_JGT:
2190 /* Unsigned comparison, the minimum value is 0. */
2191 true_reg->min_value = 0;
7e57fbb2 2192 /* fallthrough */
48461135
JB
2193 case BPF_JSGT:
2194 /*
2195 * If this is false, then the val is <= the register, if it is
2196 * true the register <= to the val.
2197 */
2198 false_reg->min_value = val;
2199 true_reg->max_value = val - 1;
2200 break;
2201 case BPF_JGE:
2202 /* Unsigned comparison, the minimum value is 0. */
2203 true_reg->min_value = 0;
7e57fbb2 2204 /* fallthrough */
48461135
JB
2205 case BPF_JSGE:
2206 /* If this is false then constant < register, if it is true then
2207 * the register < constant.
2208 */
2209 false_reg->min_value = val + 1;
2210 true_reg->max_value = val;
2211 break;
2212 default:
2213 break;
2214 }
2215
2216 check_reg_overflow(false_reg);
2217 check_reg_overflow(true_reg);
2218}
2219
57a09bf0
TG
2220static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
2221 enum bpf_reg_type type)
2222{
2223 struct bpf_reg_state *reg = &regs[regno];
2224
2225 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
56f668df
MKL
2226 if (type == UNKNOWN_VALUE) {
2227 __mark_reg_unknown_value(regs, regno);
2228 } else if (reg->map_ptr->inner_map_meta) {
2229 reg->type = CONST_PTR_TO_MAP;
2230 reg->map_ptr = reg->map_ptr->inner_map_meta;
2231 } else {
2232 reg->type = type;
2233 }
a08dd0da
DB
2234 /* We don't need id from this point onwards anymore, thus we
2235 * should better reset it, so that state pruning has chances
2236 * to take effect.
2237 */
2238 reg->id = 0;
57a09bf0
TG
2239 }
2240}
2241
2242/* The logic is similar to find_good_pkt_pointers(), both could eventually
2243 * be folded together at some point.
2244 */
2245static void mark_map_regs(struct bpf_verifier_state *state, u32 regno,
2246 enum bpf_reg_type type)
2247{
2248 struct bpf_reg_state *regs = state->regs;
a08dd0da 2249 u32 id = regs[regno].id;
57a09bf0
TG
2250 int i;
2251
2252 for (i = 0; i < MAX_BPF_REG; i++)
a08dd0da 2253 mark_map_reg(regs, i, id, type);
57a09bf0
TG
2254
2255 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
2256 if (state->stack_slot_type[i] != STACK_SPILL)
2257 continue;
a08dd0da 2258 mark_map_reg(state->spilled_regs, i / BPF_REG_SIZE, id, type);
57a09bf0
TG
2259 }
2260}
2261
58e2af8b 2262static int check_cond_jmp_op(struct bpf_verifier_env *env,
17a52670
AS
2263 struct bpf_insn *insn, int *insn_idx)
2264{
58e2af8b
JK
2265 struct bpf_verifier_state *other_branch, *this_branch = &env->cur_state;
2266 struct bpf_reg_state *regs = this_branch->regs, *dst_reg;
17a52670
AS
2267 u8 opcode = BPF_OP(insn->code);
2268 int err;
2269
2270 if (opcode > BPF_EXIT) {
2271 verbose("invalid BPF_JMP opcode %x\n", opcode);
2272 return -EINVAL;
2273 }
2274
2275 if (BPF_SRC(insn->code) == BPF_X) {
2276 if (insn->imm != 0) {
2277 verbose("BPF_JMP uses reserved fields\n");
2278 return -EINVAL;
2279 }
2280
2281 /* check src1 operand */
2282 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2283 if (err)
2284 return err;
1be7f75d
AS
2285
2286 if (is_pointer_value(env, insn->src_reg)) {
2287 verbose("R%d pointer comparison prohibited\n",
2288 insn->src_reg);
2289 return -EACCES;
2290 }
17a52670
AS
2291 } else {
2292 if (insn->src_reg != BPF_REG_0) {
2293 verbose("BPF_JMP uses reserved fields\n");
2294 return -EINVAL;
2295 }
2296 }
2297
2298 /* check src2 operand */
2299 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
2300 if (err)
2301 return err;
2302
1a0dc1ac
AS
2303 dst_reg = &regs[insn->dst_reg];
2304
17a52670
AS
2305 /* detect if R == 0 where R was initialized to zero earlier */
2306 if (BPF_SRC(insn->code) == BPF_K &&
2307 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
1a0dc1ac 2308 dst_reg->type == CONST_IMM && dst_reg->imm == insn->imm) {
17a52670
AS
2309 if (opcode == BPF_JEQ) {
2310 /* if (imm == imm) goto pc+off;
2311 * only follow the goto, ignore fall-through
2312 */
2313 *insn_idx += insn->off;
2314 return 0;
2315 } else {
2316 /* if (imm != imm) goto pc+off;
2317 * only follow fall-through branch, since
2318 * that's where the program will go
2319 */
2320 return 0;
2321 }
2322 }
2323
2324 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
2325 if (!other_branch)
2326 return -EFAULT;
2327
48461135
JB
2328 /* detect if we are comparing against a constant value so we can adjust
2329 * our min/max values for our dst register.
2330 */
2331 if (BPF_SRC(insn->code) == BPF_X) {
2332 if (regs[insn->src_reg].type == CONST_IMM)
2333 reg_set_min_max(&other_branch->regs[insn->dst_reg],
2334 dst_reg, regs[insn->src_reg].imm,
2335 opcode);
2336 else if (dst_reg->type == CONST_IMM)
2337 reg_set_min_max_inv(&other_branch->regs[insn->src_reg],
2338 &regs[insn->src_reg], dst_reg->imm,
2339 opcode);
2340 } else {
2341 reg_set_min_max(&other_branch->regs[insn->dst_reg],
2342 dst_reg, insn->imm, opcode);
2343 }
2344
58e2af8b 2345 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
17a52670 2346 if (BPF_SRC(insn->code) == BPF_K &&
1a0dc1ac
AS
2347 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
2348 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
57a09bf0
TG
2349 /* Mark all identical map registers in each branch as either
2350 * safe or unknown depending R == 0 or R != 0 conditional.
2351 */
2352 mark_map_regs(this_branch, insn->dst_reg,
2353 opcode == BPF_JEQ ? PTR_TO_MAP_VALUE : UNKNOWN_VALUE);
2354 mark_map_regs(other_branch, insn->dst_reg,
2355 opcode == BPF_JEQ ? UNKNOWN_VALUE : PTR_TO_MAP_VALUE);
969bf05e
AS
2356 } else if (BPF_SRC(insn->code) == BPF_X && opcode == BPF_JGT &&
2357 dst_reg->type == PTR_TO_PACKET &&
2358 regs[insn->src_reg].type == PTR_TO_PACKET_END) {
2d2be8ca
DB
2359 find_good_pkt_pointers(this_branch, dst_reg);
2360 } else if (BPF_SRC(insn->code) == BPF_X && opcode == BPF_JGE &&
2361 dst_reg->type == PTR_TO_PACKET_END &&
2362 regs[insn->src_reg].type == PTR_TO_PACKET) {
2363 find_good_pkt_pointers(other_branch, &regs[insn->src_reg]);
1be7f75d
AS
2364 } else if (is_pointer_value(env, insn->dst_reg)) {
2365 verbose("R%d pointer comparison prohibited\n", insn->dst_reg);
2366 return -EACCES;
17a52670
AS
2367 }
2368 if (log_level)
2d2be8ca 2369 print_verifier_state(this_branch);
17a52670
AS
2370 return 0;
2371}
2372
0246e64d
AS
2373/* return the map pointer stored inside BPF_LD_IMM64 instruction */
2374static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
2375{
2376 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
2377
2378 return (struct bpf_map *) (unsigned long) imm64;
2379}
2380
17a52670 2381/* verify BPF_LD_IMM64 instruction */
58e2af8b 2382static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
17a52670 2383{
58e2af8b 2384 struct bpf_reg_state *regs = env->cur_state.regs;
17a52670
AS
2385 int err;
2386
2387 if (BPF_SIZE(insn->code) != BPF_DW) {
2388 verbose("invalid BPF_LD_IMM insn\n");
2389 return -EINVAL;
2390 }
2391 if (insn->off != 0) {
2392 verbose("BPF_LD_IMM64 uses reserved fields\n");
2393 return -EINVAL;
2394 }
2395
2396 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
2397 if (err)
2398 return err;
2399
6b173873 2400 if (insn->src_reg == 0) {
6b173873
JK
2401 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
2402
6b173873
JK
2403 regs[insn->dst_reg].type = CONST_IMM;
2404 regs[insn->dst_reg].imm = imm;
17a52670 2405 return 0;
6b173873 2406 }
17a52670
AS
2407
2408 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
2409 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
2410
2411 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
2412 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
2413 return 0;
2414}
2415
96be4325
DB
2416static bool may_access_skb(enum bpf_prog_type type)
2417{
2418 switch (type) {
2419 case BPF_PROG_TYPE_SOCKET_FILTER:
2420 case BPF_PROG_TYPE_SCHED_CLS:
94caee8c 2421 case BPF_PROG_TYPE_SCHED_ACT:
96be4325
DB
2422 return true;
2423 default:
2424 return false;
2425 }
2426}
2427
ddd872bc
AS
2428/* verify safety of LD_ABS|LD_IND instructions:
2429 * - they can only appear in the programs where ctx == skb
2430 * - since they are wrappers of function calls, they scratch R1-R5 registers,
2431 * preserve R6-R9, and store return value into R0
2432 *
2433 * Implicit input:
2434 * ctx == skb == R6 == CTX
2435 *
2436 * Explicit input:
2437 * SRC == any register
2438 * IMM == 32-bit immediate
2439 *
2440 * Output:
2441 * R0 - 8/16/32-bit skb data converted to cpu endianness
2442 */
58e2af8b 2443static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
ddd872bc 2444{
58e2af8b 2445 struct bpf_reg_state *regs = env->cur_state.regs;
ddd872bc 2446 u8 mode = BPF_MODE(insn->code);
58e2af8b 2447 struct bpf_reg_state *reg;
ddd872bc
AS
2448 int i, err;
2449
24701ece 2450 if (!may_access_skb(env->prog->type)) {
1a0dc1ac 2451 verbose("BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
ddd872bc
AS
2452 return -EINVAL;
2453 }
2454
2455 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
d82bccc6 2456 BPF_SIZE(insn->code) == BPF_DW ||
ddd872bc 2457 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
1a0dc1ac 2458 verbose("BPF_LD_[ABS|IND] uses reserved fields\n");
ddd872bc
AS
2459 return -EINVAL;
2460 }
2461
2462 /* check whether implicit source operand (register R6) is readable */
2463 err = check_reg_arg(regs, BPF_REG_6, SRC_OP);
2464 if (err)
2465 return err;
2466
2467 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
2468 verbose("at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
2469 return -EINVAL;
2470 }
2471
2472 if (mode == BPF_IND) {
2473 /* check explicit source operand */
2474 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2475 if (err)
2476 return err;
2477 }
2478
2479 /* reset caller saved regs to unreadable */
2480 for (i = 0; i < CALLER_SAVED_REGS; i++) {
2481 reg = regs + caller_saved[i];
2482 reg->type = NOT_INIT;
2483 reg->imm = 0;
2484 }
2485
2486 /* mark destination R0 register as readable, since it contains
2487 * the value fetched from the packet
2488 */
2489 regs[BPF_REG_0].type = UNKNOWN_VALUE;
2490 return 0;
2491}
2492
475fb78f
AS
2493/* non-recursive DFS pseudo code
2494 * 1 procedure DFS-iterative(G,v):
2495 * 2 label v as discovered
2496 * 3 let S be a stack
2497 * 4 S.push(v)
2498 * 5 while S is not empty
2499 * 6 t <- S.pop()
2500 * 7 if t is what we're looking for:
2501 * 8 return t
2502 * 9 for all edges e in G.adjacentEdges(t) do
2503 * 10 if edge e is already labelled
2504 * 11 continue with the next edge
2505 * 12 w <- G.adjacentVertex(t,e)
2506 * 13 if vertex w is not discovered and not explored
2507 * 14 label e as tree-edge
2508 * 15 label w as discovered
2509 * 16 S.push(w)
2510 * 17 continue at 5
2511 * 18 else if vertex w is discovered
2512 * 19 label e as back-edge
2513 * 20 else
2514 * 21 // vertex w is explored
2515 * 22 label e as forward- or cross-edge
2516 * 23 label t as explored
2517 * 24 S.pop()
2518 *
2519 * convention:
2520 * 0x10 - discovered
2521 * 0x11 - discovered and fall-through edge labelled
2522 * 0x12 - discovered and fall-through and branch edges labelled
2523 * 0x20 - explored
2524 */
2525
2526enum {
2527 DISCOVERED = 0x10,
2528 EXPLORED = 0x20,
2529 FALLTHROUGH = 1,
2530 BRANCH = 2,
2531};
2532
58e2af8b 2533#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
f1bca824 2534
475fb78f
AS
2535static int *insn_stack; /* stack of insns to process */
2536static int cur_stack; /* current stack index */
2537static int *insn_state;
2538
2539/* t, w, e - match pseudo-code above:
2540 * t - index of current instruction
2541 * w - next instruction
2542 * e - edge
2543 */
58e2af8b 2544static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
475fb78f
AS
2545{
2546 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
2547 return 0;
2548
2549 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
2550 return 0;
2551
2552 if (w < 0 || w >= env->prog->len) {
2553 verbose("jump out of range from insn %d to %d\n", t, w);
2554 return -EINVAL;
2555 }
2556
f1bca824
AS
2557 if (e == BRANCH)
2558 /* mark branch target for state pruning */
2559 env->explored_states[w] = STATE_LIST_MARK;
2560
475fb78f
AS
2561 if (insn_state[w] == 0) {
2562 /* tree-edge */
2563 insn_state[t] = DISCOVERED | e;
2564 insn_state[w] = DISCOVERED;
2565 if (cur_stack >= env->prog->len)
2566 return -E2BIG;
2567 insn_stack[cur_stack++] = w;
2568 return 1;
2569 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
2570 verbose("back-edge from insn %d to %d\n", t, w);
2571 return -EINVAL;
2572 } else if (insn_state[w] == EXPLORED) {
2573 /* forward- or cross-edge */
2574 insn_state[t] = DISCOVERED | e;
2575 } else {
2576 verbose("insn state internal bug\n");
2577 return -EFAULT;
2578 }
2579 return 0;
2580}
2581
2582/* non-recursive depth-first-search to detect loops in BPF program
2583 * loop == back-edge in directed graph
2584 */
58e2af8b 2585static int check_cfg(struct bpf_verifier_env *env)
475fb78f
AS
2586{
2587 struct bpf_insn *insns = env->prog->insnsi;
2588 int insn_cnt = env->prog->len;
2589 int ret = 0;
2590 int i, t;
2591
2592 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
2593 if (!insn_state)
2594 return -ENOMEM;
2595
2596 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
2597 if (!insn_stack) {
2598 kfree(insn_state);
2599 return -ENOMEM;
2600 }
2601
2602 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
2603 insn_stack[0] = 0; /* 0 is the first instruction */
2604 cur_stack = 1;
2605
2606peek_stack:
2607 if (cur_stack == 0)
2608 goto check_state;
2609 t = insn_stack[cur_stack - 1];
2610
2611 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
2612 u8 opcode = BPF_OP(insns[t].code);
2613
2614 if (opcode == BPF_EXIT) {
2615 goto mark_explored;
2616 } else if (opcode == BPF_CALL) {
2617 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2618 if (ret == 1)
2619 goto peek_stack;
2620 else if (ret < 0)
2621 goto err_free;
07016151
DB
2622 if (t + 1 < insn_cnt)
2623 env->explored_states[t + 1] = STATE_LIST_MARK;
475fb78f
AS
2624 } else if (opcode == BPF_JA) {
2625 if (BPF_SRC(insns[t].code) != BPF_K) {
2626 ret = -EINVAL;
2627 goto err_free;
2628 }
2629 /* unconditional jump with single edge */
2630 ret = push_insn(t, t + insns[t].off + 1,
2631 FALLTHROUGH, env);
2632 if (ret == 1)
2633 goto peek_stack;
2634 else if (ret < 0)
2635 goto err_free;
f1bca824
AS
2636 /* tell verifier to check for equivalent states
2637 * after every call and jump
2638 */
c3de6317
AS
2639 if (t + 1 < insn_cnt)
2640 env->explored_states[t + 1] = STATE_LIST_MARK;
475fb78f
AS
2641 } else {
2642 /* conditional jump with two edges */
2643 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2644 if (ret == 1)
2645 goto peek_stack;
2646 else if (ret < 0)
2647 goto err_free;
2648
2649 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
2650 if (ret == 1)
2651 goto peek_stack;
2652 else if (ret < 0)
2653 goto err_free;
2654 }
2655 } else {
2656 /* all other non-branch instructions with single
2657 * fall-through edge
2658 */
2659 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2660 if (ret == 1)
2661 goto peek_stack;
2662 else if (ret < 0)
2663 goto err_free;
2664 }
2665
2666mark_explored:
2667 insn_state[t] = EXPLORED;
2668 if (cur_stack-- <= 0) {
2669 verbose("pop stack internal bug\n");
2670 ret = -EFAULT;
2671 goto err_free;
2672 }
2673 goto peek_stack;
2674
2675check_state:
2676 for (i = 0; i < insn_cnt; i++) {
2677 if (insn_state[i] != EXPLORED) {
2678 verbose("unreachable insn %d\n", i);
2679 ret = -EINVAL;
2680 goto err_free;
2681 }
2682 }
2683 ret = 0; /* cfg looks good */
2684
2685err_free:
2686 kfree(insn_state);
2687 kfree(insn_stack);
2688 return ret;
2689}
2690
969bf05e
AS
2691/* the following conditions reduce the number of explored insns
2692 * from ~140k to ~80k for ultra large programs that use a lot of ptr_to_packet
2693 */
58e2af8b
JK
2694static bool compare_ptrs_to_packet(struct bpf_reg_state *old,
2695 struct bpf_reg_state *cur)
969bf05e
AS
2696{
2697 if (old->id != cur->id)
2698 return false;
2699
2700 /* old ptr_to_packet is more conservative, since it allows smaller
2701 * range. Ex:
2702 * old(off=0,r=10) is equal to cur(off=0,r=20), because
2703 * old(off=0,r=10) means that with range=10 the verifier proceeded
2704 * further and found no issues with the program. Now we're in the same
2705 * spot with cur(off=0,r=20), so we're safe too, since anything further
2706 * will only be looking at most 10 bytes after this pointer.
2707 */
2708 if (old->off == cur->off && old->range < cur->range)
2709 return true;
2710
2711 /* old(off=20,r=10) is equal to cur(off=22,re=22 or 5 or 0)
2712 * since both cannot be used for packet access and safe(old)
2713 * pointer has smaller off that could be used for further
2714 * 'if (ptr > data_end)' check
2715 * Ex:
2716 * old(off=20,r=10) and cur(off=22,r=22) and cur(off=22,r=0) mean
2717 * that we cannot access the packet.
2718 * The safe range is:
2719 * [ptr, ptr + range - off)
2720 * so whenever off >=range, it means no safe bytes from this pointer.
2721 * When comparing old->off <= cur->off, it means that older code
2722 * went with smaller offset and that offset was later
2723 * used to figure out the safe range after 'if (ptr > data_end)' check
2724 * Say, 'old' state was explored like:
2725 * ... R3(off=0, r=0)
2726 * R4 = R3 + 20
2727 * ... now R4(off=20,r=0) <-- here
2728 * if (R4 > data_end)
2729 * ... R4(off=20,r=20), R3(off=0,r=20) and R3 can be used to access.
2730 * ... the code further went all the way to bpf_exit.
2731 * Now the 'cur' state at the mark 'here' has R4(off=30,r=0).
2732 * old_R4(off=20,r=0) equal to cur_R4(off=30,r=0), since if the verifier
2733 * goes further, such cur_R4 will give larger safe packet range after
2734 * 'if (R4 > data_end)' and all further insn were already good with r=20,
2735 * so they will be good with r=30 and we can prune the search.
2736 */
2737 if (old->off <= cur->off &&
2738 old->off >= old->range && cur->off >= cur->range)
2739 return true;
2740
2741 return false;
2742}
2743
f1bca824
AS
2744/* compare two verifier states
2745 *
2746 * all states stored in state_list are known to be valid, since
2747 * verifier reached 'bpf_exit' instruction through them
2748 *
2749 * this function is called when verifier exploring different branches of
2750 * execution popped from the state stack. If it sees an old state that has
2751 * more strict register state and more strict stack state then this execution
2752 * branch doesn't need to be explored further, since verifier already
2753 * concluded that more strict state leads to valid finish.
2754 *
2755 * Therefore two states are equivalent if register state is more conservative
2756 * and explored stack state is more conservative than the current one.
2757 * Example:
2758 * explored current
2759 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
2760 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
2761 *
2762 * In other words if current stack state (one being explored) has more
2763 * valid slots than old one that already passed validation, it means
2764 * the verifier can stop exploring and conclude that current state is valid too
2765 *
2766 * Similarly with registers. If explored state has register type as invalid
2767 * whereas register type in current state is meaningful, it means that
2768 * the current state will reach 'bpf_exit' instruction safely
2769 */
48461135
JB
2770static bool states_equal(struct bpf_verifier_env *env,
2771 struct bpf_verifier_state *old,
58e2af8b 2772 struct bpf_verifier_state *cur)
f1bca824 2773{
e2d2afe1 2774 bool varlen_map_access = env->varlen_map_value_access;
58e2af8b 2775 struct bpf_reg_state *rold, *rcur;
f1bca824
AS
2776 int i;
2777
2778 for (i = 0; i < MAX_BPF_REG; i++) {
1a0dc1ac
AS
2779 rold = &old->regs[i];
2780 rcur = &cur->regs[i];
2781
2782 if (memcmp(rold, rcur, sizeof(*rold)) == 0)
2783 continue;
2784
48461135
JB
2785 /* If the ranges were not the same, but everything else was and
2786 * we didn't do a variable access into a map then we are a-ok.
2787 */
e2d2afe1 2788 if (!varlen_map_access &&
d2a4dd37 2789 memcmp(rold, rcur, offsetofend(struct bpf_reg_state, id)) == 0)
48461135
JB
2790 continue;
2791
e2d2afe1
JB
2792 /* If we didn't map access then again we don't care about the
2793 * mismatched range values and it's ok if our old type was
2794 * UNKNOWN and we didn't go to a NOT_INIT'ed reg.
2795 */
1a0dc1ac 2796 if (rold->type == NOT_INIT ||
e2d2afe1
JB
2797 (!varlen_map_access && rold->type == UNKNOWN_VALUE &&
2798 rcur->type != NOT_INIT))
1a0dc1ac
AS
2799 continue;
2800
969bf05e
AS
2801 if (rold->type == PTR_TO_PACKET && rcur->type == PTR_TO_PACKET &&
2802 compare_ptrs_to_packet(rold, rcur))
2803 continue;
2804
1a0dc1ac 2805 return false;
f1bca824
AS
2806 }
2807
2808 for (i = 0; i < MAX_BPF_STACK; i++) {
9c399760
AS
2809 if (old->stack_slot_type[i] == STACK_INVALID)
2810 continue;
2811 if (old->stack_slot_type[i] != cur->stack_slot_type[i])
2812 /* Ex: old explored (safe) state has STACK_SPILL in
2813 * this stack slot, but current has has STACK_MISC ->
2814 * this verifier states are not equivalent,
2815 * return false to continue verification of this path
2816 */
f1bca824 2817 return false;
9c399760
AS
2818 if (i % BPF_REG_SIZE)
2819 continue;
2820 if (memcmp(&old->spilled_regs[i / BPF_REG_SIZE],
2821 &cur->spilled_regs[i / BPF_REG_SIZE],
2822 sizeof(old->spilled_regs[0])))
2823 /* when explored and current stack slot types are
2824 * the same, check that stored pointers types
2825 * are the same as well.
2826 * Ex: explored safe path could have stored
58e2af8b 2827 * (bpf_reg_state) {.type = PTR_TO_STACK, .imm = -8}
9c399760 2828 * but current path has stored:
58e2af8b 2829 * (bpf_reg_state) {.type = PTR_TO_STACK, .imm = -16}
9c399760
AS
2830 * such verifier states are not equivalent.
2831 * return false to continue verification of this path
2832 */
2833 return false;
2834 else
2835 continue;
f1bca824
AS
2836 }
2837 return true;
2838}
2839
58e2af8b 2840static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
f1bca824 2841{
58e2af8b
JK
2842 struct bpf_verifier_state_list *new_sl;
2843 struct bpf_verifier_state_list *sl;
f1bca824
AS
2844
2845 sl = env->explored_states[insn_idx];
2846 if (!sl)
2847 /* this 'insn_idx' instruction wasn't marked, so we will not
2848 * be doing state search here
2849 */
2850 return 0;
2851
2852 while (sl != STATE_LIST_MARK) {
48461135 2853 if (states_equal(env, &sl->state, &env->cur_state))
f1bca824
AS
2854 /* reached equivalent register/stack state,
2855 * prune the search
2856 */
2857 return 1;
2858 sl = sl->next;
2859 }
2860
2861 /* there were no equivalent states, remember current one.
2862 * technically the current state is not proven to be safe yet,
2863 * but it will either reach bpf_exit (which means it's safe) or
2864 * it will be rejected. Since there are no loops, we won't be
2865 * seeing this 'insn_idx' instruction again on the way to bpf_exit
2866 */
58e2af8b 2867 new_sl = kmalloc(sizeof(struct bpf_verifier_state_list), GFP_USER);
f1bca824
AS
2868 if (!new_sl)
2869 return -ENOMEM;
2870
2871 /* add new state to the head of linked list */
2872 memcpy(&new_sl->state, &env->cur_state, sizeof(env->cur_state));
2873 new_sl->next = env->explored_states[insn_idx];
2874 env->explored_states[insn_idx] = new_sl;
2875 return 0;
2876}
2877
13a27dfc
JK
2878static int ext_analyzer_insn_hook(struct bpf_verifier_env *env,
2879 int insn_idx, int prev_insn_idx)
2880{
2881 if (!env->analyzer_ops || !env->analyzer_ops->insn_hook)
2882 return 0;
2883
2884 return env->analyzer_ops->insn_hook(env, insn_idx, prev_insn_idx);
2885}
2886
58e2af8b 2887static int do_check(struct bpf_verifier_env *env)
17a52670 2888{
58e2af8b 2889 struct bpf_verifier_state *state = &env->cur_state;
17a52670 2890 struct bpf_insn *insns = env->prog->insnsi;
58e2af8b 2891 struct bpf_reg_state *regs = state->regs;
17a52670
AS
2892 int insn_cnt = env->prog->len;
2893 int insn_idx, prev_insn_idx = 0;
2894 int insn_processed = 0;
2895 bool do_print_state = false;
2896
2897 init_reg_state(regs);
2898 insn_idx = 0;
48461135 2899 env->varlen_map_value_access = false;
17a52670
AS
2900 for (;;) {
2901 struct bpf_insn *insn;
2902 u8 class;
2903 int err;
2904
2905 if (insn_idx >= insn_cnt) {
2906 verbose("invalid insn idx %d insn_cnt %d\n",
2907 insn_idx, insn_cnt);
2908 return -EFAULT;
2909 }
2910
2911 insn = &insns[insn_idx];
2912 class = BPF_CLASS(insn->code);
2913
07016151 2914 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
bc1750f3 2915 verbose("BPF program is too large. Processed %d insn\n",
17a52670
AS
2916 insn_processed);
2917 return -E2BIG;
2918 }
2919
f1bca824
AS
2920 err = is_state_visited(env, insn_idx);
2921 if (err < 0)
2922 return err;
2923 if (err == 1) {
2924 /* found equivalent state, can prune the search */
2925 if (log_level) {
2926 if (do_print_state)
2927 verbose("\nfrom %d to %d: safe\n",
2928 prev_insn_idx, insn_idx);
2929 else
2930 verbose("%d: safe\n", insn_idx);
2931 }
2932 goto process_bpf_exit;
2933 }
2934
c5fc9692
DM
2935 if (log_level > 1 || (log_level && do_print_state)) {
2936 if (log_level > 1)
2937 verbose("%d:", insn_idx);
2938 else
2939 verbose("\nfrom %d to %d:",
2940 prev_insn_idx, insn_idx);
1a0dc1ac 2941 print_verifier_state(&env->cur_state);
17a52670
AS
2942 do_print_state = false;
2943 }
2944
2945 if (log_level) {
2946 verbose("%d: ", insn_idx);
0d0e5769 2947 print_bpf_insn(env, insn);
17a52670
AS
2948 }
2949
13a27dfc
JK
2950 err = ext_analyzer_insn_hook(env, insn_idx, prev_insn_idx);
2951 if (err)
2952 return err;
2953
17a52670 2954 if (class == BPF_ALU || class == BPF_ALU64) {
1be7f75d 2955 err = check_alu_op(env, insn);
17a52670
AS
2956 if (err)
2957 return err;
2958
2959 } else if (class == BPF_LDX) {
3df126f3 2960 enum bpf_reg_type *prev_src_type, src_reg_type;
9bac3d6d
AS
2961
2962 /* check for reserved fields is already done */
2963
17a52670
AS
2964 /* check src operand */
2965 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2966 if (err)
2967 return err;
2968
2969 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
2970 if (err)
2971 return err;
2972
725f9dcd
AS
2973 src_reg_type = regs[insn->src_reg].type;
2974
17a52670
AS
2975 /* check that memory (src_reg + off) is readable,
2976 * the state of dst_reg will be updated by this func
2977 */
2978 err = check_mem_access(env, insn->src_reg, insn->off,
2979 BPF_SIZE(insn->code), BPF_READ,
2980 insn->dst_reg);
2981 if (err)
2982 return err;
2983
ea2e7ce5
AS
2984 if (BPF_SIZE(insn->code) != BPF_W &&
2985 BPF_SIZE(insn->code) != BPF_DW) {
725f9dcd
AS
2986 insn_idx++;
2987 continue;
2988 }
9bac3d6d 2989
3df126f3
JK
2990 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
2991
2992 if (*prev_src_type == NOT_INIT) {
9bac3d6d
AS
2993 /* saw a valid insn
2994 * dst_reg = *(u32 *)(src_reg + off)
3df126f3 2995 * save type to validate intersecting paths
9bac3d6d 2996 */
3df126f3 2997 *prev_src_type = src_reg_type;
9bac3d6d 2998
3df126f3 2999 } else if (src_reg_type != *prev_src_type &&
9bac3d6d 3000 (src_reg_type == PTR_TO_CTX ||
3df126f3 3001 *prev_src_type == PTR_TO_CTX)) {
9bac3d6d
AS
3002 /* ABuser program is trying to use the same insn
3003 * dst_reg = *(u32*) (src_reg + off)
3004 * with different pointer types:
3005 * src_reg == ctx in one branch and
3006 * src_reg == stack|map in some other branch.
3007 * Reject it.
3008 */
3009 verbose("same insn cannot be used with different pointers\n");
3010 return -EINVAL;
3011 }
3012
17a52670 3013 } else if (class == BPF_STX) {
3df126f3 3014 enum bpf_reg_type *prev_dst_type, dst_reg_type;
d691f9e8 3015
17a52670
AS
3016 if (BPF_MODE(insn->code) == BPF_XADD) {
3017 err = check_xadd(env, insn);
3018 if (err)
3019 return err;
3020 insn_idx++;
3021 continue;
3022 }
3023
17a52670
AS
3024 /* check src1 operand */
3025 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
3026 if (err)
3027 return err;
3028 /* check src2 operand */
3029 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
3030 if (err)
3031 return err;
3032
d691f9e8
AS
3033 dst_reg_type = regs[insn->dst_reg].type;
3034
17a52670
AS
3035 /* check that memory (dst_reg + off) is writeable */
3036 err = check_mem_access(env, insn->dst_reg, insn->off,
3037 BPF_SIZE(insn->code), BPF_WRITE,
3038 insn->src_reg);
3039 if (err)
3040 return err;
3041
3df126f3
JK
3042 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
3043
3044 if (*prev_dst_type == NOT_INIT) {
3045 *prev_dst_type = dst_reg_type;
3046 } else if (dst_reg_type != *prev_dst_type &&
d691f9e8 3047 (dst_reg_type == PTR_TO_CTX ||
3df126f3 3048 *prev_dst_type == PTR_TO_CTX)) {
d691f9e8
AS
3049 verbose("same insn cannot be used with different pointers\n");
3050 return -EINVAL;
3051 }
3052
17a52670
AS
3053 } else if (class == BPF_ST) {
3054 if (BPF_MODE(insn->code) != BPF_MEM ||
3055 insn->src_reg != BPF_REG_0) {
3056 verbose("BPF_ST uses reserved fields\n");
3057 return -EINVAL;
3058 }
3059 /* check src operand */
3060 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
3061 if (err)
3062 return err;
3063
3064 /* check that memory (dst_reg + off) is writeable */
3065 err = check_mem_access(env, insn->dst_reg, insn->off,
3066 BPF_SIZE(insn->code), BPF_WRITE,
3067 -1);
3068 if (err)
3069 return err;
3070
3071 } else if (class == BPF_JMP) {
3072 u8 opcode = BPF_OP(insn->code);
3073
3074 if (opcode == BPF_CALL) {
3075 if (BPF_SRC(insn->code) != BPF_K ||
3076 insn->off != 0 ||
3077 insn->src_reg != BPF_REG_0 ||
3078 insn->dst_reg != BPF_REG_0) {
3079 verbose("BPF_CALL uses reserved fields\n");
3080 return -EINVAL;
3081 }
3082
81ed18ab 3083 err = check_call(env, insn->imm, insn_idx);
17a52670
AS
3084 if (err)
3085 return err;
3086
3087 } else if (opcode == BPF_JA) {
3088 if (BPF_SRC(insn->code) != BPF_K ||
3089 insn->imm != 0 ||
3090 insn->src_reg != BPF_REG_0 ||
3091 insn->dst_reg != BPF_REG_0) {
3092 verbose("BPF_JA uses reserved fields\n");
3093 return -EINVAL;
3094 }
3095
3096 insn_idx += insn->off + 1;
3097 continue;
3098
3099 } else if (opcode == BPF_EXIT) {
3100 if (BPF_SRC(insn->code) != BPF_K ||
3101 insn->imm != 0 ||
3102 insn->src_reg != BPF_REG_0 ||
3103 insn->dst_reg != BPF_REG_0) {
3104 verbose("BPF_EXIT uses reserved fields\n");
3105 return -EINVAL;
3106 }
3107
3108 /* eBPF calling convetion is such that R0 is used
3109 * to return the value from eBPF program.
3110 * Make sure that it's readable at this time
3111 * of bpf_exit, which means that program wrote
3112 * something into it earlier
3113 */
3114 err = check_reg_arg(regs, BPF_REG_0, SRC_OP);
3115 if (err)
3116 return err;
3117
1be7f75d
AS
3118 if (is_pointer_value(env, BPF_REG_0)) {
3119 verbose("R0 leaks addr as return value\n");
3120 return -EACCES;
3121 }
3122
f1bca824 3123process_bpf_exit:
17a52670
AS
3124 insn_idx = pop_stack(env, &prev_insn_idx);
3125 if (insn_idx < 0) {
3126 break;
3127 } else {
3128 do_print_state = true;
3129 continue;
3130 }
3131 } else {
3132 err = check_cond_jmp_op(env, insn, &insn_idx);
3133 if (err)
3134 return err;
3135 }
3136 } else if (class == BPF_LD) {
3137 u8 mode = BPF_MODE(insn->code);
3138
3139 if (mode == BPF_ABS || mode == BPF_IND) {
ddd872bc
AS
3140 err = check_ld_abs(env, insn);
3141 if (err)
3142 return err;
3143
17a52670
AS
3144 } else if (mode == BPF_IMM) {
3145 err = check_ld_imm(env, insn);
3146 if (err)
3147 return err;
3148
3149 insn_idx++;
3150 } else {
3151 verbose("invalid BPF_LD mode\n");
3152 return -EINVAL;
3153 }
48461135 3154 reset_reg_range_values(regs, insn->dst_reg);
17a52670
AS
3155 } else {
3156 verbose("unknown insn class %d\n", class);
3157 return -EINVAL;
3158 }
3159
3160 insn_idx++;
3161 }
3162
1a0dc1ac 3163 verbose("processed %d insns\n", insn_processed);
17a52670
AS
3164 return 0;
3165}
3166
56f668df
MKL
3167static int check_map_prealloc(struct bpf_map *map)
3168{
3169 return (map->map_type != BPF_MAP_TYPE_HASH &&
bcc6b1b7
MKL
3170 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
3171 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
56f668df
MKL
3172 !(map->map_flags & BPF_F_NO_PREALLOC);
3173}
3174
fdc15d38
AS
3175static int check_map_prog_compatibility(struct bpf_map *map,
3176 struct bpf_prog *prog)
3177
3178{
56f668df
MKL
3179 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
3180 * preallocated hash maps, since doing memory allocation
3181 * in overflow_handler can crash depending on where nmi got
3182 * triggered.
3183 */
3184 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
3185 if (!check_map_prealloc(map)) {
3186 verbose("perf_event programs can only use preallocated hash map\n");
3187 return -EINVAL;
3188 }
3189 if (map->inner_map_meta &&
3190 !check_map_prealloc(map->inner_map_meta)) {
3191 verbose("perf_event programs can only use preallocated inner hash map\n");
3192 return -EINVAL;
3193 }
fdc15d38
AS
3194 }
3195 return 0;
3196}
3197
0246e64d
AS
3198/* look for pseudo eBPF instructions that access map FDs and
3199 * replace them with actual map pointers
3200 */
58e2af8b 3201static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
0246e64d
AS
3202{
3203 struct bpf_insn *insn = env->prog->insnsi;
3204 int insn_cnt = env->prog->len;
fdc15d38 3205 int i, j, err;
0246e64d 3206
f1f7714e 3207 err = bpf_prog_calc_tag(env->prog);
aafe6ae9
DB
3208 if (err)
3209 return err;
3210
0246e64d 3211 for (i = 0; i < insn_cnt; i++, insn++) {
9bac3d6d 3212 if (BPF_CLASS(insn->code) == BPF_LDX &&
d691f9e8 3213 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
9bac3d6d
AS
3214 verbose("BPF_LDX uses reserved fields\n");
3215 return -EINVAL;
3216 }
3217
d691f9e8
AS
3218 if (BPF_CLASS(insn->code) == BPF_STX &&
3219 ((BPF_MODE(insn->code) != BPF_MEM &&
3220 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
3221 verbose("BPF_STX uses reserved fields\n");
3222 return -EINVAL;
3223 }
3224
0246e64d
AS
3225 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
3226 struct bpf_map *map;
3227 struct fd f;
3228
3229 if (i == insn_cnt - 1 || insn[1].code != 0 ||
3230 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
3231 insn[1].off != 0) {
3232 verbose("invalid bpf_ld_imm64 insn\n");
3233 return -EINVAL;
3234 }
3235
3236 if (insn->src_reg == 0)
3237 /* valid generic load 64-bit imm */
3238 goto next_insn;
3239
3240 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
3241 verbose("unrecognized bpf_ld_imm64 insn\n");
3242 return -EINVAL;
3243 }
3244
3245 f = fdget(insn->imm);
c2101297 3246 map = __bpf_map_get(f);
0246e64d
AS
3247 if (IS_ERR(map)) {
3248 verbose("fd %d is not pointing to valid bpf_map\n",
3249 insn->imm);
0246e64d
AS
3250 return PTR_ERR(map);
3251 }
3252
fdc15d38
AS
3253 err = check_map_prog_compatibility(map, env->prog);
3254 if (err) {
3255 fdput(f);
3256 return err;
3257 }
3258
0246e64d
AS
3259 /* store map pointer inside BPF_LD_IMM64 instruction */
3260 insn[0].imm = (u32) (unsigned long) map;
3261 insn[1].imm = ((u64) (unsigned long) map) >> 32;
3262
3263 /* check whether we recorded this map already */
3264 for (j = 0; j < env->used_map_cnt; j++)
3265 if (env->used_maps[j] == map) {
3266 fdput(f);
3267 goto next_insn;
3268 }
3269
3270 if (env->used_map_cnt >= MAX_USED_MAPS) {
3271 fdput(f);
3272 return -E2BIG;
3273 }
3274
0246e64d
AS
3275 /* hold the map. If the program is rejected by verifier,
3276 * the map will be released by release_maps() or it
3277 * will be used by the valid program until it's unloaded
3278 * and all maps are released in free_bpf_prog_info()
3279 */
92117d84
AS
3280 map = bpf_map_inc(map, false);
3281 if (IS_ERR(map)) {
3282 fdput(f);
3283 return PTR_ERR(map);
3284 }
3285 env->used_maps[env->used_map_cnt++] = map;
3286
0246e64d
AS
3287 fdput(f);
3288next_insn:
3289 insn++;
3290 i++;
3291 }
3292 }
3293
3294 /* now all pseudo BPF_LD_IMM64 instructions load valid
3295 * 'struct bpf_map *' into a register instead of user map_fd.
3296 * These pointers will be used later by verifier to validate map access.
3297 */
3298 return 0;
3299}
3300
3301/* drop refcnt of maps used by the rejected program */
58e2af8b 3302static void release_maps(struct bpf_verifier_env *env)
0246e64d
AS
3303{
3304 int i;
3305
3306 for (i = 0; i < env->used_map_cnt; i++)
3307 bpf_map_put(env->used_maps[i]);
3308}
3309
3310/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
58e2af8b 3311static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
0246e64d
AS
3312{
3313 struct bpf_insn *insn = env->prog->insnsi;
3314 int insn_cnt = env->prog->len;
3315 int i;
3316
3317 for (i = 0; i < insn_cnt; i++, insn++)
3318 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
3319 insn->src_reg = 0;
3320}
3321
8041902d
AS
3322/* single env->prog->insni[off] instruction was replaced with the range
3323 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
3324 * [0, off) and [off, end) to new locations, so the patched range stays zero
3325 */
3326static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
3327 u32 off, u32 cnt)
3328{
3329 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
3330
3331 if (cnt == 1)
3332 return 0;
3333 new_data = vzalloc(sizeof(struct bpf_insn_aux_data) * prog_len);
3334 if (!new_data)
3335 return -ENOMEM;
3336 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
3337 memcpy(new_data + off + cnt - 1, old_data + off,
3338 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
3339 env->insn_aux_data = new_data;
3340 vfree(old_data);
3341 return 0;
3342}
3343
3344static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
3345 const struct bpf_insn *patch, u32 len)
3346{
3347 struct bpf_prog *new_prog;
3348
3349 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
3350 if (!new_prog)
3351 return NULL;
3352 if (adjust_insn_aux_data(env, new_prog->len, off, len))
3353 return NULL;
3354 return new_prog;
3355}
3356
9bac3d6d
AS
3357/* convert load instructions that access fields of 'struct __sk_buff'
3358 * into sequence of instructions that access fields of 'struct sk_buff'
3359 */
58e2af8b 3360static int convert_ctx_accesses(struct bpf_verifier_env *env)
9bac3d6d 3361{
36bbef52 3362 const struct bpf_verifier_ops *ops = env->prog->aux->ops;
3df126f3 3363 const int insn_cnt = env->prog->len;
36bbef52 3364 struct bpf_insn insn_buf[16], *insn;
9bac3d6d 3365 struct bpf_prog *new_prog;
d691f9e8 3366 enum bpf_access_type type;
3df126f3 3367 int i, cnt, delta = 0;
9bac3d6d 3368
36bbef52
DB
3369 if (ops->gen_prologue) {
3370 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
3371 env->prog);
3372 if (cnt >= ARRAY_SIZE(insn_buf)) {
3373 verbose("bpf verifier is misconfigured\n");
3374 return -EINVAL;
3375 } else if (cnt) {
8041902d 3376 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
36bbef52
DB
3377 if (!new_prog)
3378 return -ENOMEM;
8041902d 3379
36bbef52 3380 env->prog = new_prog;
3df126f3 3381 delta += cnt - 1;
36bbef52
DB
3382 }
3383 }
3384
3385 if (!ops->convert_ctx_access)
9bac3d6d
AS
3386 return 0;
3387
3df126f3 3388 insn = env->prog->insnsi + delta;
36bbef52 3389
9bac3d6d 3390 for (i = 0; i < insn_cnt; i++, insn++) {
62c7989b
DB
3391 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
3392 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
3393 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
ea2e7ce5 3394 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
d691f9e8 3395 type = BPF_READ;
62c7989b
DB
3396 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
3397 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
3398 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
ea2e7ce5 3399 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
d691f9e8
AS
3400 type = BPF_WRITE;
3401 else
9bac3d6d
AS
3402 continue;
3403
8041902d 3404 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
9bac3d6d 3405 continue;
9bac3d6d 3406
6b8cc1d1 3407 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog);
9bac3d6d
AS
3408 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
3409 verbose("bpf verifier is misconfigured\n");
3410 return -EINVAL;
3411 }
3412
8041902d 3413 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
9bac3d6d
AS
3414 if (!new_prog)
3415 return -ENOMEM;
3416
3df126f3 3417 delta += cnt - 1;
9bac3d6d
AS
3418
3419 /* keep walking new program and skip insns we just inserted */
3420 env->prog = new_prog;
3df126f3 3421 insn = new_prog->insnsi + i + delta;
9bac3d6d
AS
3422 }
3423
3424 return 0;
3425}
3426
79741b3b 3427/* fixup insn->imm field of bpf_call instructions
81ed18ab 3428 * and inline eligible helpers as explicit sequence of BPF instructions
e245c5c6
AS
3429 *
3430 * this function is called after eBPF program passed verification
3431 */
79741b3b 3432static int fixup_bpf_calls(struct bpf_verifier_env *env)
e245c5c6 3433{
79741b3b
AS
3434 struct bpf_prog *prog = env->prog;
3435 struct bpf_insn *insn = prog->insnsi;
e245c5c6 3436 const struct bpf_func_proto *fn;
79741b3b 3437 const int insn_cnt = prog->len;
81ed18ab
AS
3438 struct bpf_insn insn_buf[16];
3439 struct bpf_prog *new_prog;
3440 struct bpf_map *map_ptr;
3441 int i, cnt, delta = 0;
e245c5c6 3442
79741b3b
AS
3443 for (i = 0; i < insn_cnt; i++, insn++) {
3444 if (insn->code != (BPF_JMP | BPF_CALL))
3445 continue;
e245c5c6 3446
79741b3b
AS
3447 if (insn->imm == BPF_FUNC_get_route_realm)
3448 prog->dst_needed = 1;
3449 if (insn->imm == BPF_FUNC_get_prandom_u32)
3450 bpf_user_rnd_init_once();
79741b3b 3451 if (insn->imm == BPF_FUNC_tail_call) {
7b9f6da1
DM
3452 /* If we tail call into other programs, we
3453 * cannot make any assumptions since they can
3454 * be replaced dynamically during runtime in
3455 * the program array.
3456 */
3457 prog->cb_access = 1;
7b9f6da1 3458
79741b3b
AS
3459 /* mark bpf_tail_call as different opcode to avoid
3460 * conditional branch in the interpeter for every normal
3461 * call and to prevent accidental JITing by JIT compiler
3462 * that doesn't support bpf_tail_call yet
e245c5c6 3463 */
79741b3b
AS
3464 insn->imm = 0;
3465 insn->code |= BPF_X;
3466 continue;
3467 }
e245c5c6 3468
81ed18ab
AS
3469 if (ebpf_jit_enabled() && insn->imm == BPF_FUNC_map_lookup_elem) {
3470 map_ptr = env->insn_aux_data[i + delta].map_ptr;
fad73a1a
MKL
3471 if (map_ptr == BPF_MAP_PTR_POISON ||
3472 !map_ptr->ops->map_gen_lookup)
81ed18ab
AS
3473 goto patch_call_imm;
3474
3475 cnt = map_ptr->ops->map_gen_lookup(map_ptr, insn_buf);
3476 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
3477 verbose("bpf verifier is misconfigured\n");
3478 return -EINVAL;
3479 }
3480
3481 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
3482 cnt);
3483 if (!new_prog)
3484 return -ENOMEM;
3485
3486 delta += cnt - 1;
3487
3488 /* keep walking new program and skip insns we just inserted */
3489 env->prog = prog = new_prog;
3490 insn = new_prog->insnsi + i + delta;
3491 continue;
3492 }
3493
3494patch_call_imm:
79741b3b
AS
3495 fn = prog->aux->ops->get_func_proto(insn->imm);
3496 /* all functions that have prototype and verifier allowed
3497 * programs to call them, must be real in-kernel functions
3498 */
3499 if (!fn->func) {
3500 verbose("kernel subsystem misconfigured func %s#%d\n",
3501 func_id_name(insn->imm), insn->imm);
3502 return -EFAULT;
e245c5c6 3503 }
79741b3b 3504 insn->imm = fn->func - __bpf_call_base;
e245c5c6 3505 }
e245c5c6 3506
79741b3b
AS
3507 return 0;
3508}
e245c5c6 3509
58e2af8b 3510static void free_states(struct bpf_verifier_env *env)
f1bca824 3511{
58e2af8b 3512 struct bpf_verifier_state_list *sl, *sln;
f1bca824
AS
3513 int i;
3514
3515 if (!env->explored_states)
3516 return;
3517
3518 for (i = 0; i < env->prog->len; i++) {
3519 sl = env->explored_states[i];
3520
3521 if (sl)
3522 while (sl != STATE_LIST_MARK) {
3523 sln = sl->next;
3524 kfree(sl);
3525 sl = sln;
3526 }
3527 }
3528
3529 kfree(env->explored_states);
3530}
3531
9bac3d6d 3532int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
51580e79 3533{
cbd35700 3534 char __user *log_ubuf = NULL;
58e2af8b 3535 struct bpf_verifier_env *env;
51580e79
AS
3536 int ret = -EINVAL;
3537
58e2af8b 3538 /* 'struct bpf_verifier_env' can be global, but since it's not small,
cbd35700
AS
3539 * allocate/free it every time bpf_check() is called
3540 */
58e2af8b 3541 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
cbd35700
AS
3542 if (!env)
3543 return -ENOMEM;
3544
3df126f3
JK
3545 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
3546 (*prog)->len);
3547 ret = -ENOMEM;
3548 if (!env->insn_aux_data)
3549 goto err_free_env;
9bac3d6d 3550 env->prog = *prog;
0246e64d 3551
cbd35700
AS
3552 /* grab the mutex to protect few globals used by verifier */
3553 mutex_lock(&bpf_verifier_lock);
3554
3555 if (attr->log_level || attr->log_buf || attr->log_size) {
3556 /* user requested verbose verifier output
3557 * and supplied buffer to store the verification trace
3558 */
3559 log_level = attr->log_level;
3560 log_ubuf = (char __user *) (unsigned long) attr->log_buf;
3561 log_size = attr->log_size;
3562 log_len = 0;
3563
3564 ret = -EINVAL;
3565 /* log_* values have to be sane */
3566 if (log_size < 128 || log_size > UINT_MAX >> 8 ||
3567 log_level == 0 || log_ubuf == NULL)
3df126f3 3568 goto err_unlock;
cbd35700
AS
3569
3570 ret = -ENOMEM;
3571 log_buf = vmalloc(log_size);
3572 if (!log_buf)
3df126f3 3573 goto err_unlock;
cbd35700
AS
3574 } else {
3575 log_level = 0;
3576 }
e07b98d9
DM
3577 if (attr->prog_flags & BPF_F_STRICT_ALIGNMENT)
3578 env->strict_alignment = true;
3579 else
3580 env->strict_alignment = false;
cbd35700 3581
0246e64d
AS
3582 ret = replace_map_fd_with_map_ptr(env);
3583 if (ret < 0)
3584 goto skip_full_check;
3585
9bac3d6d 3586 env->explored_states = kcalloc(env->prog->len,
58e2af8b 3587 sizeof(struct bpf_verifier_state_list *),
f1bca824
AS
3588 GFP_USER);
3589 ret = -ENOMEM;
3590 if (!env->explored_states)
3591 goto skip_full_check;
3592
475fb78f
AS
3593 ret = check_cfg(env);
3594 if (ret < 0)
3595 goto skip_full_check;
3596
1be7f75d
AS
3597 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
3598
17a52670 3599 ret = do_check(env);
cbd35700 3600
0246e64d 3601skip_full_check:
17a52670 3602 while (pop_stack(env, NULL) >= 0);
f1bca824 3603 free_states(env);
0246e64d 3604
9bac3d6d
AS
3605 if (ret == 0)
3606 /* program is valid, convert *(u32*)(ctx + off) accesses */
3607 ret = convert_ctx_accesses(env);
3608
e245c5c6 3609 if (ret == 0)
79741b3b 3610 ret = fixup_bpf_calls(env);
e245c5c6 3611
cbd35700
AS
3612 if (log_level && log_len >= log_size - 1) {
3613 BUG_ON(log_len >= log_size);
3614 /* verifier log exceeded user supplied buffer */
3615 ret = -ENOSPC;
3616 /* fall through to return what was recorded */
3617 }
3618
3619 /* copy verifier log back to user space including trailing zero */
3620 if (log_level && copy_to_user(log_ubuf, log_buf, log_len + 1) != 0) {
3621 ret = -EFAULT;
3622 goto free_log_buf;
3623 }
3624
0246e64d
AS
3625 if (ret == 0 && env->used_map_cnt) {
3626 /* if program passed verifier, update used_maps in bpf_prog_info */
9bac3d6d
AS
3627 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
3628 sizeof(env->used_maps[0]),
3629 GFP_KERNEL);
0246e64d 3630
9bac3d6d 3631 if (!env->prog->aux->used_maps) {
0246e64d
AS
3632 ret = -ENOMEM;
3633 goto free_log_buf;
3634 }
3635
9bac3d6d 3636 memcpy(env->prog->aux->used_maps, env->used_maps,
0246e64d 3637 sizeof(env->used_maps[0]) * env->used_map_cnt);
9bac3d6d 3638 env->prog->aux->used_map_cnt = env->used_map_cnt;
0246e64d
AS
3639
3640 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
3641 * bpf_ld_imm64 instructions
3642 */
3643 convert_pseudo_ld_imm64(env);
3644 }
cbd35700
AS
3645
3646free_log_buf:
3647 if (log_level)
3648 vfree(log_buf);
9bac3d6d 3649 if (!env->prog->aux->used_maps)
0246e64d
AS
3650 /* if we didn't copy map pointers into bpf_prog_info, release
3651 * them now. Otherwise free_bpf_prog_info() will release them.
3652 */
3653 release_maps(env);
9bac3d6d 3654 *prog = env->prog;
3df126f3 3655err_unlock:
cbd35700 3656 mutex_unlock(&bpf_verifier_lock);
3df126f3
JK
3657 vfree(env->insn_aux_data);
3658err_free_env:
3659 kfree(env);
51580e79
AS
3660 return ret;
3661}
13a27dfc
JK
3662
3663int bpf_analyzer(struct bpf_prog *prog, const struct bpf_ext_analyzer_ops *ops,
3664 void *priv)
3665{
3666 struct bpf_verifier_env *env;
3667 int ret;
3668
3669 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
3670 if (!env)
3671 return -ENOMEM;
3672
3673 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
3674 prog->len);
3675 ret = -ENOMEM;
3676 if (!env->insn_aux_data)
3677 goto err_free_env;
3678 env->prog = prog;
3679 env->analyzer_ops = ops;
3680 env->analyzer_priv = priv;
3681
3682 /* grab the mutex to protect few globals used by verifier */
3683 mutex_lock(&bpf_verifier_lock);
3684
3685 log_level = 0;
e07b98d9 3686 env->strict_alignment = false;
13a27dfc
JK
3687
3688 env->explored_states = kcalloc(env->prog->len,
3689 sizeof(struct bpf_verifier_state_list *),
3690 GFP_KERNEL);
3691 ret = -ENOMEM;
3692 if (!env->explored_states)
3693 goto skip_full_check;
3694
3695 ret = check_cfg(env);
3696 if (ret < 0)
3697 goto skip_full_check;
3698
3699 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
3700
3701 ret = do_check(env);
3702
3703skip_full_check:
3704 while (pop_stack(env, NULL) >= 0);
3705 free_states(env);
3706
3707 mutex_unlock(&bpf_verifier_lock);
3708 vfree(env->insn_aux_data);
3709err_free_env:
3710 kfree(env);
3711 return ret;
3712}
3713EXPORT_SYMBOL_GPL(bpf_analyzer);