]>
Commit | Line | Data |
---|---|---|
dc52ddc0 MH |
1 | /* |
2 | * cgroup_freezer.c - control group freezer subsystem | |
3 | * | |
4 | * Copyright IBM Corporation, 2007 | |
5 | * | |
6 | * Author : Cedric Le Goater <clg@fr.ibm.com> | |
7 | * | |
8 | * This program is free software; you can redistribute it and/or modify it | |
9 | * under the terms of version 2.1 of the GNU Lesser General Public License | |
10 | * as published by the Free Software Foundation. | |
11 | * | |
12 | * This program is distributed in the hope that it would be useful, but | |
13 | * WITHOUT ANY WARRANTY; without even the implied warranty of | |
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | |
15 | */ | |
16 | ||
9984de1a | 17 | #include <linux/export.h> |
5a0e3ad6 | 18 | #include <linux/slab.h> |
dc52ddc0 MH |
19 | #include <linux/cgroup.h> |
20 | #include <linux/fs.h> | |
21 | #include <linux/uaccess.h> | |
22 | #include <linux/freezer.h> | |
23 | #include <linux/seq_file.h> | |
24 | ||
ef9fe980 TH |
25 | /* |
26 | * A cgroup is freezing if any FREEZING flags are set. FREEZING_SELF is | |
27 | * set if "FROZEN" is written to freezer.state cgroupfs file, and cleared | |
28 | * for "THAWED". FREEZING_PARENT is set if the parent freezer is FREEZING | |
29 | * for whatever reason. IOW, a cgroup has FREEZING_PARENT set if one of | |
30 | * its ancestors has FREEZING_SELF set. | |
31 | */ | |
d6a2fe13 | 32 | enum freezer_state_flags { |
5300a9b3 | 33 | CGROUP_FREEZER_ONLINE = (1 << 0), /* freezer is fully online */ |
a2252180 TH |
34 | CGROUP_FREEZING_SELF = (1 << 1), /* this freezer is freezing */ |
35 | CGROUP_FREEZING_PARENT = (1 << 2), /* the parent freezer is freezing */ | |
d6a2fe13 | 36 | CGROUP_FROZEN = (1 << 3), /* this and its descendants frozen */ |
a2252180 TH |
37 | |
38 | /* mask for all FREEZING flags */ | |
39 | CGROUP_FREEZING = CGROUP_FREEZING_SELF | CGROUP_FREEZING_PARENT, | |
dc52ddc0 MH |
40 | }; |
41 | ||
42 | struct freezer { | |
bcd66c89 | 43 | struct cgroup_subsys_state css; |
d6a2fe13 | 44 | unsigned int state; |
bcd66c89 | 45 | spinlock_t lock; |
dc52ddc0 MH |
46 | }; |
47 | ||
bcd66c89 | 48 | static inline struct freezer *cgroup_freezer(struct cgroup *cgroup) |
dc52ddc0 | 49 | { |
bcd66c89 TH |
50 | return container_of(cgroup_subsys_state(cgroup, freezer_subsys_id), |
51 | struct freezer, css); | |
dc52ddc0 MH |
52 | } |
53 | ||
54 | static inline struct freezer *task_freezer(struct task_struct *task) | |
55 | { | |
56 | return container_of(task_subsys_state(task, freezer_subsys_id), | |
57 | struct freezer, css); | |
58 | } | |
59 | ||
ef9fe980 TH |
60 | static struct freezer *parent_freezer(struct freezer *freezer) |
61 | { | |
62 | struct cgroup *pcg = freezer->css.cgroup->parent; | |
63 | ||
64 | if (pcg) | |
65 | return cgroup_freezer(pcg); | |
66 | return NULL; | |
67 | } | |
68 | ||
22b4e111 | 69 | bool cgroup_freezing(struct task_struct *task) |
dc52ddc0 | 70 | { |
22b4e111 | 71 | bool ret; |
dc52ddc0 | 72 | |
22b4e111 | 73 | rcu_read_lock(); |
d6a2fe13 | 74 | ret = task_freezer(task)->state & CGROUP_FREEZING; |
22b4e111 TH |
75 | rcu_read_unlock(); |
76 | ||
77 | return ret; | |
dc52ddc0 MH |
78 | } |
79 | ||
80 | /* | |
81 | * cgroups_write_string() limits the size of freezer state strings to | |
82 | * CGROUP_LOCAL_BUFFER_SIZE | |
83 | */ | |
d6a2fe13 TH |
84 | static const char *freezer_state_strs(unsigned int state) |
85 | { | |
86 | if (state & CGROUP_FROZEN) | |
87 | return "FROZEN"; | |
88 | if (state & CGROUP_FREEZING) | |
89 | return "FREEZING"; | |
90 | return "THAWED"; | |
dc52ddc0 MH |
91 | }; |
92 | ||
dc52ddc0 MH |
93 | struct cgroup_subsys freezer_subsys; |
94 | ||
761b3ef5 | 95 | static struct cgroup_subsys_state *freezer_create(struct cgroup *cgroup) |
dc52ddc0 MH |
96 | { |
97 | struct freezer *freezer; | |
98 | ||
99 | freezer = kzalloc(sizeof(struct freezer), GFP_KERNEL); | |
100 | if (!freezer) | |
101 | return ERR_PTR(-ENOMEM); | |
102 | ||
103 | spin_lock_init(&freezer->lock); | |
dc52ddc0 MH |
104 | return &freezer->css; |
105 | } | |
106 | ||
5300a9b3 TH |
107 | /** |
108 | * freezer_post_create - commit creation of a freezer cgroup | |
109 | * @cgroup: cgroup being created | |
110 | * | |
ef9fe980 TH |
111 | * We're committing to creation of @cgroup. Mark it online and inherit |
112 | * parent's freezing state while holding both parent's and our | |
113 | * freezer->lock. | |
5300a9b3 TH |
114 | */ |
115 | static void freezer_post_create(struct cgroup *cgroup) | |
dc52ddc0 | 116 | { |
a3201227 | 117 | struct freezer *freezer = cgroup_freezer(cgroup); |
ef9fe980 TH |
118 | struct freezer *parent = parent_freezer(freezer); |
119 | ||
120 | /* | |
121 | * The following double locking and freezing state inheritance | |
122 | * guarantee that @cgroup can never escape ancestors' freezing | |
123 | * states. See cgroup_for_each_descendant_pre() for details. | |
124 | */ | |
125 | if (parent) | |
126 | spin_lock_irq(&parent->lock); | |
127 | spin_lock_nested(&freezer->lock, SINGLE_DEPTH_NESTING); | |
a3201227 | 128 | |
5300a9b3 | 129 | freezer->state |= CGROUP_FREEZER_ONLINE; |
ef9fe980 TH |
130 | |
131 | if (parent && (parent->state & CGROUP_FREEZING)) { | |
132 | freezer->state |= CGROUP_FREEZING_PARENT | CGROUP_FROZEN; | |
133 | atomic_inc(&system_freezing_cnt); | |
134 | } | |
135 | ||
136 | spin_unlock(&freezer->lock); | |
137 | if (parent) | |
138 | spin_unlock_irq(&parent->lock); | |
5300a9b3 TH |
139 | } |
140 | ||
141 | /** | |
142 | * freezer_pre_destroy - initiate destruction of @cgroup | |
143 | * @cgroup: cgroup being destroyed | |
144 | * | |
145 | * @cgroup is going away. Mark it dead and decrement system_freezing_count | |
146 | * if it was holding one. | |
147 | */ | |
148 | static void freezer_pre_destroy(struct cgroup *cgroup) | |
149 | { | |
150 | struct freezer *freezer = cgroup_freezer(cgroup); | |
151 | ||
152 | spin_lock_irq(&freezer->lock); | |
153 | ||
d6a2fe13 | 154 | if (freezer->state & CGROUP_FREEZING) |
a3201227 | 155 | atomic_dec(&system_freezing_cnt); |
5300a9b3 TH |
156 | |
157 | freezer->state = 0; | |
158 | ||
159 | spin_unlock_irq(&freezer->lock); | |
160 | } | |
161 | ||
162 | static void freezer_destroy(struct cgroup *cgroup) | |
163 | { | |
164 | kfree(cgroup_freezer(cgroup)); | |
dc52ddc0 MH |
165 | } |
166 | ||
957a4eea | 167 | /* |
ead5c473 TH |
168 | * Tasks can be migrated into a different freezer anytime regardless of its |
169 | * current state. freezer_attach() is responsible for making new tasks | |
170 | * conform to the current state. | |
171 | * | |
172 | * Freezer state changes and task migration are synchronized via | |
173 | * @freezer->lock. freezer_attach() makes the new tasks conform to the | |
174 | * current state and all following state changes can see the new tasks. | |
957a4eea | 175 | */ |
8755ade6 | 176 | static void freezer_attach(struct cgroup *new_cgrp, struct cgroup_taskset *tset) |
dc52ddc0 | 177 | { |
8755ade6 | 178 | struct freezer *freezer = cgroup_freezer(new_cgrp); |
bb9d97b6 | 179 | struct task_struct *task; |
ef9fe980 | 180 | bool clear_frozen = false; |
957a4eea | 181 | |
8755ade6 TH |
182 | spin_lock_irq(&freezer->lock); |
183 | ||
80a6a2cf | 184 | /* |
8755ade6 TH |
185 | * Make the new tasks conform to the current state of @new_cgrp. |
186 | * For simplicity, when migrating any task to a FROZEN cgroup, we | |
187 | * revert it to FREEZING and let update_if_frozen() determine the | |
188 | * correct state later. | |
189 | * | |
190 | * Tasks in @tset are on @new_cgrp but may not conform to its | |
191 | * current state before executing the following - !frozen tasks may | |
192 | * be visible in a FROZEN cgroup and frozen tasks in a THAWED one. | |
80a6a2cf | 193 | */ |
8755ade6 | 194 | cgroup_taskset_for_each(task, new_cgrp, tset) { |
d6a2fe13 | 195 | if (!(freezer->state & CGROUP_FREEZING)) { |
8755ade6 TH |
196 | __thaw_task(task); |
197 | } else { | |
198 | freeze_task(task); | |
d6a2fe13 | 199 | freezer->state &= ~CGROUP_FROZEN; |
ef9fe980 | 200 | clear_frozen = true; |
8755ade6 TH |
201 | } |
202 | } | |
dc52ddc0 | 203 | |
8755ade6 | 204 | spin_unlock_irq(&freezer->lock); |
ef9fe980 TH |
205 | |
206 | /* | |
207 | * Propagate FROZEN clearing upwards. We may race with | |
208 | * update_if_frozen(), but as long as both work bottom-up, either | |
209 | * update_if_frozen() sees child's FROZEN cleared or we clear the | |
210 | * parent's FROZEN later. No parent w/ !FROZEN children can be | |
211 | * left FROZEN. | |
212 | */ | |
213 | while (clear_frozen && (freezer = parent_freezer(freezer))) { | |
214 | spin_lock_irq(&freezer->lock); | |
215 | freezer->state &= ~CGROUP_FROZEN; | |
216 | clear_frozen = freezer->state & CGROUP_FREEZING; | |
217 | spin_unlock_irq(&freezer->lock); | |
218 | } | |
f780bdb7 BB |
219 | } |
220 | ||
761b3ef5 | 221 | static void freezer_fork(struct task_struct *task) |
dc52ddc0 MH |
222 | { |
223 | struct freezer *freezer; | |
224 | ||
8b46f880 | 225 | rcu_read_lock(); |
dc52ddc0 | 226 | freezer = task_freezer(task); |
dc52ddc0 | 227 | |
3b1b3f6e LZ |
228 | /* |
229 | * The root cgroup is non-freezable, so we can skip the | |
230 | * following check. | |
231 | */ | |
232 | if (!freezer->css.cgroup->parent) | |
5edee61e | 233 | goto out; |
3b1b3f6e | 234 | |
dc52ddc0 | 235 | spin_lock_irq(&freezer->lock); |
d6a2fe13 | 236 | if (freezer->state & CGROUP_FREEZING) |
839e3407 | 237 | freeze_task(task); |
dc52ddc0 | 238 | spin_unlock_irq(&freezer->lock); |
5edee61e TH |
239 | out: |
240 | rcu_read_unlock(); | |
dc52ddc0 MH |
241 | } |
242 | ||
ef9fe980 TH |
243 | /** |
244 | * update_if_frozen - update whether a cgroup finished freezing | |
245 | * @cgroup: cgroup of interest | |
246 | * | |
247 | * Once FREEZING is initiated, transition to FROZEN is lazily updated by | |
248 | * calling this function. If the current state is FREEZING but not FROZEN, | |
249 | * this function checks whether all tasks of this cgroup and the descendant | |
250 | * cgroups finished freezing and, if so, sets FROZEN. | |
251 | * | |
252 | * The caller is responsible for grabbing RCU read lock and calling | |
253 | * update_if_frozen() on all descendants prior to invoking this function. | |
b4d18311 TH |
254 | * |
255 | * Task states and freezer state might disagree while tasks are being | |
ead5c473 TH |
256 | * migrated into or out of @cgroup, so we can't verify task states against |
257 | * @freezer state here. See freezer_attach() for details. | |
dc52ddc0 | 258 | */ |
ef9fe980 | 259 | static void update_if_frozen(struct cgroup *cgroup) |
dc52ddc0 | 260 | { |
ef9fe980 TH |
261 | struct freezer *freezer = cgroup_freezer(cgroup); |
262 | struct cgroup *pos; | |
dc52ddc0 MH |
263 | struct cgroup_iter it; |
264 | struct task_struct *task; | |
b4d18311 | 265 | |
ef9fe980 TH |
266 | WARN_ON_ONCE(!rcu_read_lock_held()); |
267 | ||
268 | spin_lock_irq(&freezer->lock); | |
269 | ||
d6a2fe13 TH |
270 | if (!(freezer->state & CGROUP_FREEZING) || |
271 | (freezer->state & CGROUP_FROZEN)) | |
ef9fe980 TH |
272 | goto out_unlock; |
273 | ||
274 | /* are all (live) children frozen? */ | |
275 | cgroup_for_each_child(pos, cgroup) { | |
276 | struct freezer *child = cgroup_freezer(pos); | |
dc52ddc0 | 277 | |
ef9fe980 TH |
278 | if ((child->state & CGROUP_FREEZER_ONLINE) && |
279 | !(child->state & CGROUP_FROZEN)) | |
280 | goto out_unlock; | |
281 | } | |
282 | ||
283 | /* are all tasks frozen? */ | |
dc52ddc0 | 284 | cgroup_iter_start(cgroup, &it); |
b4d18311 | 285 | |
dc52ddc0 | 286 | while ((task = cgroup_iter_next(cgroup, &it))) { |
3c426d5e | 287 | if (freezing(task)) { |
3c426d5e TH |
288 | /* |
289 | * freezer_should_skip() indicates that the task | |
290 | * should be skipped when determining freezing | |
291 | * completion. Consider it frozen in addition to | |
292 | * the usual frozen condition. | |
293 | */ | |
5d8f72b5 | 294 | if (!frozen(task) && !freezer_should_skip(task)) |
ef9fe980 | 295 | goto out_iter_end; |
3c426d5e | 296 | } |
dc52ddc0 MH |
297 | } |
298 | ||
d6a2fe13 | 299 | freezer->state |= CGROUP_FROZEN; |
ef9fe980 | 300 | out_iter_end: |
dc52ddc0 | 301 | cgroup_iter_end(cgroup, &it); |
ef9fe980 TH |
302 | out_unlock: |
303 | spin_unlock_irq(&freezer->lock); | |
dc52ddc0 MH |
304 | } |
305 | ||
306 | static int freezer_read(struct cgroup *cgroup, struct cftype *cft, | |
307 | struct seq_file *m) | |
308 | { | |
ef9fe980 | 309 | struct cgroup *pos; |
dc52ddc0 | 310 | |
ef9fe980 | 311 | rcu_read_lock(); |
dc52ddc0 | 312 | |
ef9fe980 TH |
313 | /* update states bottom-up */ |
314 | cgroup_for_each_descendant_post(pos, cgroup) | |
315 | update_if_frozen(pos); | |
316 | update_if_frozen(cgroup); | |
317 | ||
318 | rcu_read_unlock(); | |
319 | ||
320 | seq_puts(m, freezer_state_strs(cgroup_freezer(cgroup)->state)); | |
dc52ddc0 MH |
321 | seq_putc(m, '\n'); |
322 | return 0; | |
323 | } | |
324 | ||
bcd66c89 | 325 | static void freeze_cgroup(struct freezer *freezer) |
dc52ddc0 | 326 | { |
bcd66c89 | 327 | struct cgroup *cgroup = freezer->css.cgroup; |
dc52ddc0 MH |
328 | struct cgroup_iter it; |
329 | struct task_struct *task; | |
dc52ddc0 | 330 | |
dc52ddc0 | 331 | cgroup_iter_start(cgroup, &it); |
51f246ed TH |
332 | while ((task = cgroup_iter_next(cgroup, &it))) |
333 | freeze_task(task); | |
dc52ddc0 | 334 | cgroup_iter_end(cgroup, &it); |
dc52ddc0 MH |
335 | } |
336 | ||
bcd66c89 | 337 | static void unfreeze_cgroup(struct freezer *freezer) |
dc52ddc0 | 338 | { |
bcd66c89 | 339 | struct cgroup *cgroup = freezer->css.cgroup; |
dc52ddc0 MH |
340 | struct cgroup_iter it; |
341 | struct task_struct *task; | |
342 | ||
343 | cgroup_iter_start(cgroup, &it); | |
a5be2d0d TH |
344 | while ((task = cgroup_iter_next(cgroup, &it))) |
345 | __thaw_task(task); | |
dc52ddc0 | 346 | cgroup_iter_end(cgroup, &it); |
dc52ddc0 MH |
347 | } |
348 | ||
04a4ec32 TH |
349 | /** |
350 | * freezer_apply_state - apply state change to a single cgroup_freezer | |
351 | * @freezer: freezer to apply state change to | |
352 | * @freeze: whether to freeze or unfreeze | |
a2252180 TH |
353 | * @state: CGROUP_FREEZING_* flag to set or clear |
354 | * | |
355 | * Set or clear @state on @cgroup according to @freeze, and perform | |
356 | * freezing or thawing as necessary. | |
04a4ec32 | 357 | */ |
a2252180 TH |
358 | static void freezer_apply_state(struct freezer *freezer, bool freeze, |
359 | unsigned int state) | |
dc52ddc0 | 360 | { |
ead5c473 | 361 | /* also synchronizes against task migration, see freezer_attach() */ |
04a4ec32 | 362 | lockdep_assert_held(&freezer->lock); |
51308ee5 | 363 | |
5300a9b3 TH |
364 | if (!(freezer->state & CGROUP_FREEZER_ONLINE)) |
365 | return; | |
366 | ||
04a4ec32 | 367 | if (freeze) { |
d6a2fe13 | 368 | if (!(freezer->state & CGROUP_FREEZING)) |
a3201227 | 369 | atomic_inc(&system_freezing_cnt); |
a2252180 | 370 | freezer->state |= state; |
bcd66c89 | 371 | freeze_cgroup(freezer); |
04a4ec32 | 372 | } else { |
a2252180 TH |
373 | bool was_freezing = freezer->state & CGROUP_FREEZING; |
374 | ||
375 | freezer->state &= ~state; | |
376 | ||
377 | if (!(freezer->state & CGROUP_FREEZING)) { | |
378 | if (was_freezing) | |
379 | atomic_dec(&system_freezing_cnt); | |
380 | freezer->state &= ~CGROUP_FROZEN; | |
381 | unfreeze_cgroup(freezer); | |
382 | } | |
dc52ddc0 | 383 | } |
04a4ec32 | 384 | } |
22b4e111 | 385 | |
04a4ec32 TH |
386 | /** |
387 | * freezer_change_state - change the freezing state of a cgroup_freezer | |
388 | * @freezer: freezer of interest | |
389 | * @freeze: whether to freeze or thaw | |
390 | * | |
ef9fe980 TH |
391 | * Freeze or thaw @freezer according to @freeze. The operations are |
392 | * recursive - all descendants of @freezer will be affected. | |
04a4ec32 TH |
393 | */ |
394 | static void freezer_change_state(struct freezer *freezer, bool freeze) | |
395 | { | |
ef9fe980 TH |
396 | struct cgroup *pos; |
397 | ||
04a4ec32 TH |
398 | /* update @freezer */ |
399 | spin_lock_irq(&freezer->lock); | |
a2252180 | 400 | freezer_apply_state(freezer, freeze, CGROUP_FREEZING_SELF); |
dc52ddc0 | 401 | spin_unlock_irq(&freezer->lock); |
ef9fe980 TH |
402 | |
403 | /* | |
404 | * Update all its descendants in pre-order traversal. Each | |
405 | * descendant will try to inherit its parent's FREEZING state as | |
406 | * CGROUP_FREEZING_PARENT. | |
407 | */ | |
408 | rcu_read_lock(); | |
409 | cgroup_for_each_descendant_pre(pos, freezer->css.cgroup) { | |
410 | struct freezer *pos_f = cgroup_freezer(pos); | |
411 | struct freezer *parent = parent_freezer(pos_f); | |
412 | ||
413 | /* | |
414 | * Our update to @parent->state is already visible which is | |
415 | * all we need. No need to lock @parent. For more info on | |
416 | * synchronization, see freezer_post_create(). | |
417 | */ | |
418 | spin_lock_irq(&pos_f->lock); | |
419 | freezer_apply_state(pos_f, parent->state & CGROUP_FREEZING, | |
420 | CGROUP_FREEZING_PARENT); | |
421 | spin_unlock_irq(&pos_f->lock); | |
422 | } | |
423 | rcu_read_unlock(); | |
dc52ddc0 MH |
424 | } |
425 | ||
bcd66c89 | 426 | static int freezer_write(struct cgroup *cgroup, struct cftype *cft, |
dc52ddc0 MH |
427 | const char *buffer) |
428 | { | |
04a4ec32 | 429 | bool freeze; |
dc52ddc0 | 430 | |
d6a2fe13 | 431 | if (strcmp(buffer, freezer_state_strs(0)) == 0) |
04a4ec32 | 432 | freeze = false; |
d6a2fe13 | 433 | else if (strcmp(buffer, freezer_state_strs(CGROUP_FROZEN)) == 0) |
04a4ec32 | 434 | freeze = true; |
dc52ddc0 | 435 | else |
3b1b3f6e | 436 | return -EINVAL; |
dc52ddc0 | 437 | |
04a4ec32 | 438 | freezer_change_state(cgroup_freezer(cgroup), freeze); |
51f246ed | 439 | return 0; |
dc52ddc0 MH |
440 | } |
441 | ||
a2252180 TH |
442 | static u64 freezer_self_freezing_read(struct cgroup *cgroup, struct cftype *cft) |
443 | { | |
444 | struct freezer *freezer = cgroup_freezer(cgroup); | |
445 | ||
446 | return (bool)(freezer->state & CGROUP_FREEZING_SELF); | |
447 | } | |
448 | ||
449 | static u64 freezer_parent_freezing_read(struct cgroup *cgroup, struct cftype *cft) | |
450 | { | |
451 | struct freezer *freezer = cgroup_freezer(cgroup); | |
452 | ||
453 | return (bool)(freezer->state & CGROUP_FREEZING_PARENT); | |
454 | } | |
455 | ||
dc52ddc0 MH |
456 | static struct cftype files[] = { |
457 | { | |
458 | .name = "state", | |
4baf6e33 | 459 | .flags = CFTYPE_NOT_ON_ROOT, |
dc52ddc0 MH |
460 | .read_seq_string = freezer_read, |
461 | .write_string = freezer_write, | |
462 | }, | |
a2252180 TH |
463 | { |
464 | .name = "self_freezing", | |
465 | .flags = CFTYPE_NOT_ON_ROOT, | |
466 | .read_u64 = freezer_self_freezing_read, | |
467 | }, | |
468 | { | |
469 | .name = "parent_freezing", | |
470 | .flags = CFTYPE_NOT_ON_ROOT, | |
471 | .read_u64 = freezer_parent_freezing_read, | |
472 | }, | |
4baf6e33 | 473 | { } /* terminate */ |
dc52ddc0 MH |
474 | }; |
475 | ||
dc52ddc0 MH |
476 | struct cgroup_subsys freezer_subsys = { |
477 | .name = "freezer", | |
478 | .create = freezer_create, | |
5300a9b3 TH |
479 | .post_create = freezer_post_create, |
480 | .pre_destroy = freezer_pre_destroy, | |
dc52ddc0 | 481 | .destroy = freezer_destroy, |
dc52ddc0 | 482 | .subsys_id = freezer_subsys_id, |
8755ade6 | 483 | .attach = freezer_attach, |
dc52ddc0 | 484 | .fork = freezer_fork, |
4baf6e33 | 485 | .base_cftypes = files, |
dc52ddc0 | 486 | }; |