]> git.proxmox.com Git - mirror_ovs.git/blame - lib/cfm.c
ovs-rcu: Call ovsrcu_init() in ovsrcu_quiesce().
[mirror_ovs.git] / lib / cfm.c
CommitLineData
b31bcf60 1/*
8917f72c 2 * Copyright (c) 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
b31bcf60
EJ
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at:
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include <config.h>
18#include "cfm.h"
19
20#include <stdint.h>
21#include <stdlib.h>
22#include <string.h>
23
348f01e3 24#include "byte-order.h"
f23d157c 25#include "connectivity.h"
20c8e971 26#include "dynamic-string.h"
b31bcf60
EJ
27#include "flow.h"
28#include "hash.h"
29#include "hmap.h"
90967e95 30#include "netdev.h"
b31bcf60
EJ
31#include "ofpbuf.h"
32#include "packets.h"
33#include "poll-loop.h"
189cb9e4 34#include "random.h"
f23d157c 35#include "seq.h"
6fabb78d 36#include "timer.h"
b31bcf60 37#include "timeval.h"
9ac3fce4 38#include "unixctl.h"
b31bcf60
EJ
39#include "vlog.h"
40
41VLOG_DEFINE_THIS_MODULE(cfm);
42
144216a3
EJ
43#define CFM_MAX_RMPS 256
44
c0a2e71d
EJ
45/* Ethernet destination address of CCM packets. */
46static const uint8_t eth_addr_ccm[6] = { 0x01, 0x80, 0xC2, 0x00, 0x00, 0x30 };
ef9819b5
EJ
47static const uint8_t eth_addr_ccm_x[6] = {
48 0x01, 0x23, 0x20, 0x00, 0x00, 0x30
49};
c0a2e71d
EJ
50
51#define ETH_TYPE_CFM 0x8902
52
53/* A 'ccm' represents a Continuity Check Message from the 802.1ag
54 * specification. Continuity Check Messages are broadcast periodically so that
ce27cbee
BP
55 * hosts can determine whom they have connectivity to.
56 *
57 * The minimum length of a CCM as specified by IEEE 802.1ag is 75 bytes.
58 * Previous versions of Open vSwitch generated 74-byte CCM messages, so we
59 * accept such messages too. */
60#define CCM_LEN 75
61#define CCM_ACCEPT_LEN 74
c0a2e71d
EJ
62#define CCM_MAID_LEN 48
63#define CCM_OPCODE 1 /* CFM message opcode meaning CCM. */
aa62994c 64#define CCM_RDI_MASK 0x80
3967a833 65#define CFM_HEALTH_INTERVAL 6
13b6bae6
LS
66
67OVS_PACKED(
c0a2e71d 68struct ccm {
6bdf30ee
EJ
69 uint8_t mdlevel_version; /* MD Level and Version */
70 uint8_t opcode;
71 uint8_t flags;
72 uint8_t tlv_offset;
c0a2e71d
EJ
73 ovs_be32 seq;
74 ovs_be16 mpid;
6bdf30ee 75 uint8_t maid[CCM_MAID_LEN];
de724029
EJ
76
77 /* Defined by ITU-T Y.1731 should be zero */
78 ovs_be16 interval_ms_x; /* Transmission interval in ms. */
348f01e3 79 ovs_be64 mpid64; /* MPID in extended mode. */
86dc6501 80 uint8_t opdown; /* Operationally down. */
6bdf30ee 81 uint8_t zero[5];
ce27cbee
BP
82
83 /* TLV space. */
84 uint8_t end_tlv;
13b6bae6 85});
c0a2e71d 86BUILD_ASSERT_DECL(CCM_LEN == sizeof(struct ccm));
b31bcf60 87
a5610457 88struct cfm {
90967e95 89 const char *name; /* Name of this CFM object. */
6f629657 90 struct hmap_node hmap_node; /* Node in all_cfms list. */
b31bcf60 91
90967e95
EJ
92 struct netdev *netdev;
93 uint64_t rx_packets; /* Packets received by 'netdev'. */
94
348f01e3 95 uint64_t mpid;
90967e95 96 bool demand; /* Demand mode. */
ec9f40dc 97 bool booted; /* A full fault interval has occurred. */
2b540ecb 98 enum cfm_fault_reason fault; /* Connectivity fault status. */
ec9f40dc 99 enum cfm_fault_reason recv_fault; /* Bit mask of faults occurring on
2b540ecb 100 receive. */
86dc6501
EJ
101 bool opup; /* Operational State. */
102 bool remote_opup; /* Remote Operational State. */
a5610457 103
d7243b93
EJ
104 int fault_override; /* Manual override of 'fault' status.
105 Ignored if negative. */
106
9ac3fce4 107 uint32_t seq; /* The sequence number of our last CCM. */
b31bcf60
EJ
108 uint8_t ccm_interval; /* The CCM transmission interval. */
109 int ccm_interval_ms; /* 'ccm_interval' in milliseconds. */
189cb9e4
EJ
110 uint16_t ccm_vlan; /* Vlan tag of CCM PDUs. CFM_RANDOM_VLAN if
111 random. */
a7aa2d3c 112 uint8_t ccm_pcp; /* Priority of CCM PDUs. */
84c5d450 113 uint8_t maid[CCM_MAID_LEN]; /* The MAID of this CFM. */
b31bcf60 114
6fabb78d
EJ
115 struct timer tx_timer; /* Send CCM when expired. */
116 struct timer fault_timer; /* Check for faults when expired. */
93b8df38 117
144216a3 118 struct hmap remote_mps; /* Remote MPs. */
1de11730
EJ
119
120 /* Result of cfm_get_remote_mpids(). Updated only during fault check to
121 * avoid flapping. */
122 uint64_t *rmps_array; /* Cache of remote_mps. */
123 size_t rmps_array_len; /* Number of rmps in 'rmps_array'. */
3967a833
MM
124
125 int health; /* Percentage of the number of CCM frames
126 received. */
127 int health_interval; /* Number of fault_intervals since health was
128 recomputed. */
b03c6f99 129 long long int last_tx; /* Last CCM transmission time. */
8e9a73fa 130
13b1b2ae
EJ
131 atomic_bool check_tnl_key; /* Verify the tunnel key of inbound packets? */
132 atomic_bool extended; /* Extended mode. */
37bec3d3 133 struct ovs_refcount ref_cnt;
76c4290d
AW
134
135 uint64_t flap_count; /* Count the flaps since boot. */
93b8df38
EJ
136};
137
138/* Remote MPs represent foreign network entities that are configured to have
139 * the same MAID as this CFM instance. */
140struct remote_mp {
348f01e3 141 uint64_t mpid; /* The Maintenance Point ID of this 'remote_mp'. */
93b8df38
EJ
142 struct hmap_node node; /* Node in 'remote_mps' map. */
143
144 bool recv; /* CCM was received since last fault check. */
86dc6501 145 bool opup; /* Operational State. */
8210113e 146 uint32_t seq; /* Most recently received sequence number. */
3967a833
MM
147 uint8_t num_health_ccm; /* Number of received ccm frames every
148 CFM_HEALTH_INTERVAL * 'fault_interval'. */
c3f72482 149 long long int last_rx; /* Last CCM reception time. */
3967a833 150
b31bcf60
EJ
151};
152
8210113e 153static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(20, 30);
13b1b2ae
EJ
154
155static struct ovs_mutex mutex = OVS_MUTEX_INITIALIZER;
156static struct hmap all_cfms__ = HMAP_INITIALIZER(&all_cfms__);
157static struct hmap *const all_cfms OVS_GUARDED_BY(mutex) = &all_cfms__;
9ac3fce4 158
0e15264f 159static unixctl_cb_func cfm_unixctl_show;
d7243b93 160static unixctl_cb_func cfm_unixctl_set_fault;
dd986e09 161
90967e95 162static uint64_t
bd3950dd 163cfm_rx_packets(const struct cfm *cfm) OVS_REQUIRES(mutex)
90967e95
EJ
164{
165 struct netdev_stats stats;
166
167 if (!netdev_get_stats(cfm->netdev, &stats)) {
168 return stats.rx_packets;
169 } else {
170 return 0;
171 }
172}
173
ef9819b5 174static const uint8_t *
5675cb4c 175cfm_ccm_addr(struct cfm *cfm)
ef9819b5 176{
13b1b2ae
EJ
177 bool extended;
178 atomic_read(&cfm->extended, &extended);
179 return extended ? eth_addr_ccm_x : eth_addr_ccm;
ef9819b5
EJ
180}
181
b9380396
EJ
182/* Returns the string representation of the given cfm_fault_reason 'reason'. */
183const char *
13b1b2ae
EJ
184cfm_fault_reason_to_str(int reason)
185{
b9380396
EJ
186 switch (reason) {
187#define CFM_FAULT_REASON(NAME, STR) case CFM_FAULT_##NAME: return #STR;
188 CFM_FAULT_REASONS
189#undef CFM_FAULT_REASON
190 default: return "<unknown>";
191 }
192}
193
194static void
c3f72482 195ds_put_cfm_fault(struct ds *ds, int fault)
b9380396 196{
b9380396
EJ
197 int i;
198
199 for (i = 0; i < CFM_FAULT_N_REASONS; i++) {
200 int reason = 1 << i;
201
c3f72482
EJ
202 if (fault & reason) {
203 ds_put_format(ds, "%s ", cfm_fault_reason_to_str(reason));
b9380396
EJ
204 }
205 }
c3f72482
EJ
206
207 ds_chomp(ds, ' ');
b9380396
EJ
208}
209
84c5d450 210static void
bd3950dd 211cfm_generate_maid(struct cfm *cfm) OVS_REQUIRES(mutex)
84c5d450 212{
db16e36e
EJ
213 const char *ovs_md_name = "ovs";
214 const char *ovs_ma_name = "ovs";
84c5d450
EJ
215 uint8_t *ma_p;
216 size_t md_len, ma_len;
217
a5610457 218 memset(cfm->maid, 0, CCM_MAID_LEN);
84c5d450
EJ
219
220 md_len = strlen(ovs_md_name);
221 ma_len = strlen(ovs_ma_name);
222
cb22974d 223 ovs_assert(md_len && ma_len && md_len + ma_len + 4 <= CCM_MAID_LEN);
84c5d450 224
a5610457
EJ
225 cfm->maid[0] = 4; /* MD name string format. */
226 cfm->maid[1] = md_len; /* MD name size. */
227 memcpy(&cfm->maid[2], ovs_md_name, md_len); /* MD name. */
84c5d450 228
a5610457 229 ma_p = cfm->maid + 2 + md_len;
84c5d450
EJ
230 ma_p[0] = 2; /* MA name string format. */
231 ma_p[1] = ma_len; /* MA name size. */
232 memcpy(&ma_p[2], ovs_ma_name, ma_len); /* MA name. */
233}
234
b31bcf60
EJ
235static int
236ccm_interval_to_ms(uint8_t interval)
237{
238 switch (interval) {
428b2edd 239 case 0: OVS_NOT_REACHED(); /* Explicitly not supported by 802.1ag. */
b31bcf60
EJ
240 case 1: return 3; /* Not recommended due to timer resolution. */
241 case 2: return 10; /* Not recommended due to timer resolution. */
242 case 3: return 100;
243 case 4: return 1000;
244 case 5: return 10000;
245 case 6: return 60000;
246 case 7: return 600000;
428b2edd 247 default: OVS_NOT_REACHED(); /* Explicitly not supported by 802.1ag. */
b31bcf60
EJ
248 }
249
428b2edd 250 OVS_NOT_REACHED();
b31bcf60
EJ
251}
252
aac19178 253static long long int
bd3950dd 254cfm_fault_interval(struct cfm *cfm) OVS_REQUIRES(mutex)
aac19178
EJ
255{
256 /* According to the 802.1ag specification we should assume every other MP
257 * with the same MAID has the same transmission interval that we have. If
258 * an MP has a different interval, cfm_process_heartbeat will register it
259 * as a fault (likely due to a configuration error). Thus we can check all
260 * MPs at once making this quite a bit simpler.
261 *
03f209ba
AW
262 * When cfm is not in demand mode, we check when (ccm_interval_ms * 3.5) ms
263 * have passed. When cfm is in demand mode, we check when
264 * (MAX(ccm_interval_ms, 500) * 3.5) ms have passed. This ensures that
265 * ovs-vswitchd has enough time to pull statistics from the datapath. */
266
267 return (MAX(cfm->ccm_interval_ms, cfm->demand ? 500 : cfm->ccm_interval_ms)
268 * 7) / 2;
aac19178
EJ
269}
270
b31bcf60
EJ
271static uint8_t
272ms_to_ccm_interval(int interval_ms)
273{
274 uint8_t i;
275
276 for (i = 7; i > 0; i--) {
277 if (ccm_interval_to_ms(i) <= interval_ms) {
278 return i;
279 }
280 }
281
282 return 1;
283}
284
b31bcf60 285static uint32_t
348f01e3 286hash_mpid(uint64_t mpid)
b31bcf60 287{
348f01e3 288 return hash_bytes(&mpid, sizeof mpid, 0);
b31bcf60
EJ
289}
290
291static bool
348f01e3 292cfm_is_valid_mpid(bool extended, uint64_t mpid)
b31bcf60 293{
348f01e3
EJ
294 /* 802.1ag specification requires MPIDs to be within the range [1, 8191].
295 * In extended mode we relax this requirement. */
296 return mpid >= 1 && (extended || mpid <= 8191);
b31bcf60
EJ
297}
298
299static struct remote_mp *
bd3950dd 300lookup_remote_mp(const struct cfm *cfm, uint64_t mpid) OVS_REQUIRES(mutex)
b31bcf60
EJ
301{
302 struct remote_mp *rmp;
303
144216a3 304 HMAP_FOR_EACH_IN_BUCKET (rmp, node, hash_mpid(mpid), &cfm->remote_mps) {
b31bcf60
EJ
305 if (rmp->mpid == mpid) {
306 return rmp;
307 }
308 }
309
310 return NULL;
311}
312
9ac3fce4
EJ
313void
314cfm_init(void)
315{
0e15264f 316 unixctl_command_register("cfm/show", "[interface]", 0, 1, cfm_unixctl_show,
ae75dae3 317 NULL);
d7243b93
EJ
318 unixctl_command_register("cfm/set-fault", "[interface] normal|false|true",
319 1, 2, cfm_unixctl_set_fault, NULL);
9ac3fce4
EJ
320}
321
6f629657
EJ
322/* Allocates a 'cfm' object called 'name'. 'cfm' should be initialized by
323 * cfm_configure() before use. */
b31bcf60 324struct cfm *
13b1b2ae 325cfm_create(const struct netdev *netdev) OVS_EXCLUDED(mutex)
b31bcf60
EJ
326{
327 struct cfm *cfm;
b31bcf60 328
a5610457 329 cfm = xzalloc(sizeof *cfm);
90967e95
EJ
330 cfm->netdev = netdev_ref(netdev);
331 cfm->name = netdev_get_name(cfm->netdev);
a5610457 332 hmap_init(&cfm->remote_mps);
86dc6501 333 cfm->remote_opup = true;
d7243b93 334 cfm->fault_override = -1;
3967a833 335 cfm->health = -1;
b03c6f99 336 cfm->last_tx = 0;
76c4290d 337 cfm->flap_count = 0;
13b1b2ae
EJ
338 atomic_init(&cfm->extended, false);
339 atomic_init(&cfm->check_tnl_key, false);
37bec3d3 340 ovs_refcount_init(&cfm->ref_cnt);
13b1b2ae
EJ
341
342 ovs_mutex_lock(&mutex);
343 cfm_generate_maid(cfm);
344 hmap_insert(all_cfms, &cfm->hmap_node, hash_string(cfm->name, 0));
345 ovs_mutex_unlock(&mutex);
b31bcf60
EJ
346 return cfm;
347}
348
349void
13b1b2ae 350cfm_unref(struct cfm *cfm) OVS_EXCLUDED(mutex)
b31bcf60
EJ
351{
352 struct remote_mp *rmp, *rmp_next;
b31bcf60
EJ
353
354 if (!cfm) {
355 return;
356 }
357
37bec3d3 358 if (ovs_refcount_unref(&cfm->ref_cnt) != 1) {
8e9a73fa
EJ
359 return;
360 }
361
13b1b2ae
EJ
362 ovs_mutex_lock(&mutex);
363 hmap_remove(all_cfms, &cfm->hmap_node);
364 ovs_mutex_unlock(&mutex);
365
a5610457
EJ
366 HMAP_FOR_EACH_SAFE (rmp, rmp_next, node, &cfm->remote_mps) {
367 hmap_remove(&cfm->remote_mps, &rmp->node);
b31bcf60
EJ
368 free(rmp);
369 }
370
a5610457 371 hmap_destroy(&cfm->remote_mps);
90967e95 372 netdev_close(cfm->netdev);
1de11730 373 free(cfm->rmps_array);
c5f81b20 374
a5610457 375 free(cfm);
b31bcf60
EJ
376}
377
8e9a73fa
EJ
378struct cfm *
379cfm_ref(const struct cfm *cfm_)
380{
381 struct cfm *cfm = CONST_CAST(struct cfm *, cfm_);
382 if (cfm) {
37bec3d3 383 ovs_refcount_ref(&cfm->ref_cnt);
8e9a73fa
EJ
384 }
385 return cfm;
386}
387
a58727fb
EJ
388/* Should be run periodically to update fault statistics messages. */
389void
13b1b2ae 390cfm_run(struct cfm *cfm) OVS_EXCLUDED(mutex)
b31bcf60 391{
13b1b2ae 392 ovs_mutex_lock(&mutex);
a5610457
EJ
393 if (timer_expired(&cfm->fault_timer)) {
394 long long int interval = cfm_fault_interval(cfm);
144216a3 395 struct remote_mp *rmp, *rmp_next;
8210113e 396 bool old_cfm_fault = cfm->fault;
f23d157c 397 bool old_rmp_opup = cfm->remote_opup;
90967e95 398 bool demand_override;
016953ae
PI
399 bool rmp_set_opup = false;
400 bool rmp_set_opdown = false;
b31bcf60 401
b9380396
EJ
402 cfm->fault = cfm->recv_fault;
403 cfm->recv_fault = 0;
e14749fa 404
1de11730
EJ
405 cfm->rmps_array_len = 0;
406 free(cfm->rmps_array);
407 cfm->rmps_array = xmalloc(hmap_count(&cfm->remote_mps) *
408 sizeof *cfm->rmps_array);
409
3967a833
MM
410 if (cfm->health_interval == CFM_HEALTH_INTERVAL) {
411 /* Calculate the cfm health of the interface. If the number of
412 * remote_mpids of a cfm interface is > 1, the cfm health is
413 * undefined. If the number of remote_mpids is 1, the cfm health is
414 * the percentage of the ccm frames received in the
415 * (CFM_HEALTH_INTERVAL * 3.5)ms, else it is 0. */
416 if (hmap_count(&cfm->remote_mps) > 1) {
417 cfm->health = -1;
418 } else if (hmap_is_empty(&cfm->remote_mps)) {
419 cfm->health = 0;
420 } else {
421 int exp_ccm_recvd;
f23d157c 422 int old_health = cfm->health;
3967a833
MM
423
424 rmp = CONTAINER_OF(hmap_first(&cfm->remote_mps),
425 struct remote_mp, node);
426 exp_ccm_recvd = (CFM_HEALTH_INTERVAL * 7) / 2;
427 /* Calculate the percentage of healthy ccm frames received.
428 * Since the 'fault_interval' is (3.5 * cfm_interval), and
429 * 1 CCM packet must be received every cfm_interval,
430 * the 'remote_mpid' health reports the percentage of
431 * healthy CCM frames received every
432 * 'CFM_HEALTH_INTERVAL'th 'fault_interval'. */
433 cfm->health = (rmp->num_health_ccm * 100) / exp_ccm_recvd;
434 cfm->health = MIN(cfm->health, 100);
435 rmp->num_health_ccm = 0;
cb22974d 436 ovs_assert(cfm->health >= 0 && cfm->health <= 100);
f23d157c
JS
437
438 if (cfm->health != old_health) {
439 seq_change(connectivity_seq_get());
440 }
3967a833
MM
441 }
442 cfm->health_interval = 0;
443 }
444 cfm->health_interval++;
445
90967e95
EJ
446 demand_override = false;
447 if (cfm->demand) {
448 uint64_t rx_packets = cfm_rx_packets(cfm);
449 demand_override = hmap_count(&cfm->remote_mps) == 1
450 && rx_packets > cfm->rx_packets;
451 cfm->rx_packets = rx_packets;
452 }
6fabb78d 453
90967e95 454 HMAP_FOR_EACH_SAFE (rmp, rmp_next, node, &cfm->remote_mps) {
144216a3 455 if (!rmp->recv) {
c3f72482
EJ
456 VLOG_INFO("%s: Received no CCM from RMP %"PRIu64" in the last"
457 " %lldms", cfm->name, rmp->mpid,
458 time_msec() - rmp->last_rx);
90967e95
EJ
459 if (!demand_override) {
460 hmap_remove(&cfm->remote_mps, &rmp->node);
461 free(rmp);
462 }
144216a3
EJ
463 } else {
464 rmp->recv = false;
465
016953ae
PI
466 if (rmp->opup) {
467 rmp_set_opup = true;
468 } else {
469 rmp_set_opdown = true;
86dc6501
EJ
470 }
471
1de11730 472 cfm->rmps_array[cfm->rmps_array_len++] = rmp->mpid;
6fabb78d 473 }
b31bcf60
EJ
474 }
475
016953ae
PI
476 if (rmp_set_opdown) {
477 cfm->remote_opup = false;
478 }
479 else if (rmp_set_opup) {
480 cfm->remote_opup = true;
481 }
482
f23d157c
JS
483 if (old_rmp_opup != cfm->remote_opup) {
484 seq_change(connectivity_seq_get());
485 }
486
144216a3 487 if (hmap_is_empty(&cfm->remote_mps)) {
b9380396 488 cfm->fault |= CFM_FAULT_RECV;
dd986e09
EJ
489 }
490
fb668e3a
JS
491 if (old_cfm_fault != cfm->fault) {
492 if (!VLOG_DROP_INFO(&rl)) {
493 struct ds ds = DS_EMPTY_INITIALIZER;
494
495 ds_put_cstr(&ds, "from [");
496 ds_put_cfm_fault(&ds, old_cfm_fault);
497 ds_put_cstr(&ds, "] to [");
498 ds_put_cfm_fault(&ds, cfm->fault);
499 ds_put_char(&ds, ']');
500 VLOG_INFO("%s: CFM faults changed %s.", cfm->name, ds_cstr(&ds));
501 ds_destroy(&ds);
502 }
76c4290d
AW
503
504 /* If there is a flap, increments the counter. */
505 if (old_cfm_fault == false || cfm->fault == false) {
506 cfm->flap_count++;
507 }
f23d157c
JS
508
509 seq_change(connectivity_seq_get());
8210113e
EJ
510 }
511
0d0c0bb5 512 cfm->booted = true;
a5610457 513 timer_set_duration(&cfm->fault_timer, interval);
2f478344 514 VLOG_DBG("%s: new fault interval", cfm->name);
b31bcf60 515 }
13b1b2ae 516 ovs_mutex_unlock(&mutex);
a58727fb 517}
b31bcf60 518
a58727fb
EJ
519/* Should be run periodically to check if the CFM module has a CCM message it
520 * wishes to send. */
521bool
13b1b2ae 522cfm_should_send_ccm(struct cfm *cfm) OVS_EXCLUDED(mutex)
a58727fb 523{
13b1b2ae
EJ
524 bool ret;
525
526 ovs_mutex_lock(&mutex);
527 ret = timer_expired(&cfm->tx_timer);
528 ovs_mutex_unlock(&mutex);
529 return ret;
a58727fb
EJ
530}
531
c0a2e71d 532/* Composes a CCM message into 'packet'. Messages generated with this function
a58727fb
EJ
533 * should be sent whenever cfm_should_send_ccm() indicates. */
534void
c0a2e71d 535cfm_compose_ccm(struct cfm *cfm, struct ofpbuf *packet,
13b1b2ae 536 uint8_t eth_src[ETH_ADDR_LEN]) OVS_EXCLUDED(mutex)
a58727fb 537{
189cb9e4 538 uint16_t ccm_vlan;
c0a2e71d 539 struct ccm *ccm;
13b1b2ae 540 bool extended;
c0a2e71d 541
13b1b2ae 542 ovs_mutex_lock(&mutex);
a5610457 543 timer_set_duration(&cfm->tx_timer, cfm->ccm_interval_ms);
75a4ead1
EJ
544 eth_compose(packet, cfm_ccm_addr(cfm), eth_src, ETH_TYPE_CFM, sizeof *ccm);
545
189cb9e4
EJ
546 ccm_vlan = (cfm->ccm_vlan != CFM_RANDOM_VLAN
547 ? cfm->ccm_vlan
548 : random_uint16());
549 ccm_vlan = ccm_vlan & VLAN_VID_MASK;
550
551 if (ccm_vlan || cfm->ccm_pcp) {
552 uint16_t tci = ccm_vlan | (cfm->ccm_pcp << VLAN_PCP_SHIFT);
1bf02876 553 eth_push_vlan(packet, htons(ETH_TYPE_VLAN), htons(tci));
75a4ead1
EJ
554 }
555
556 ccm = packet->l3;
a58727fb
EJ
557 ccm->mdlevel_version = 0;
558 ccm->opcode = CCM_OPCODE;
559 ccm->tlv_offset = 70;
a5610457 560 ccm->seq = htonl(++cfm->seq);
a5610457
EJ
561 ccm->flags = cfm->ccm_interval;
562 memcpy(ccm->maid, cfm->maid, sizeof ccm->maid);
56717eb1 563 memset(ccm->zero, 0, sizeof ccm->zero);
ce27cbee 564 ccm->end_tlv = 0;
aa62994c 565
13b1b2ae
EJ
566 atomic_read(&cfm->extended, &extended);
567 if (extended) {
348f01e3
EJ
568 ccm->mpid = htons(hash_mpid(cfm->mpid));
569 ccm->mpid64 = htonll(cfm->mpid);
86dc6501 570 ccm->opdown = !cfm->opup;
348f01e3
EJ
571 } else {
572 ccm->mpid = htons(cfm->mpid);
573 ccm->mpid64 = htonll(0);
86dc6501 574 ccm->opdown = 0;
348f01e3
EJ
575 }
576
de724029 577 if (cfm->ccm_interval == 0) {
13b1b2ae 578 ovs_assert(extended);
de724029 579 ccm->interval_ms_x = htons(cfm->ccm_interval_ms);
d2859659
BP
580 } else {
581 ccm->interval_ms_x = htons(0);
de724029
EJ
582 }
583
0d0c0bb5 584 if (cfm->booted && hmap_is_empty(&cfm->remote_mps)) {
aa62994c
EJ
585 ccm->flags |= CCM_RDI_MASK;
586 }
b03c6f99
EJ
587
588 if (cfm->last_tx) {
589 long long int delay = time_msec() - cfm->last_tx;
590 if (delay > (cfm->ccm_interval_ms * 3 / 2)) {
591 VLOG_WARN("%s: long delay of %lldms (expected %dms) sending CCM"
592 " seq %"PRIu32, cfm->name, delay, cfm->ccm_interval_ms,
593 cfm->seq);
594 }
595 }
596 cfm->last_tx = time_msec();
13b1b2ae 597 ovs_mutex_unlock(&mutex);
b31bcf60
EJ
598}
599
600void
13b1b2ae 601cfm_wait(struct cfm *cfm) OVS_EXCLUDED(mutex)
b31bcf60 602{
526d174a
AW
603 poll_timer_wait_until(cfm_wake_time(cfm));
604}
605
606
607/* Returns the next cfm wakeup time. */
608long long int
609cfm_wake_time(struct cfm *cfm) OVS_EXCLUDED(mutex)
610{
611 long long int retval;
612
613 if (!cfm) {
614 return LLONG_MAX;
615 }
616
13b1b2ae 617 ovs_mutex_lock(&mutex);
526d174a 618 retval = MIN(cfm->tx_timer.t, cfm->fault_timer.t);
13b1b2ae 619 ovs_mutex_unlock(&mutex);
526d174a 620 return retval;
b31bcf60
EJ
621}
622
526d174a 623
a5610457 624/* Configures 'cfm' with settings from 's'. */
b31bcf60 625bool
a5610457 626cfm_configure(struct cfm *cfm, const struct cfm_settings *s)
13b1b2ae 627 OVS_EXCLUDED(mutex)
b31bcf60 628{
9aa952b2 629 uint8_t interval;
de724029 630 int interval_ms;
b31bcf60 631
348f01e3 632 if (!cfm_is_valid_mpid(s->extended, s->mpid) || s->interval <= 0) {
b31bcf60
EJ
633 return false;
634 }
635
13b1b2ae 636 ovs_mutex_lock(&mutex);
a5610457 637 cfm->mpid = s->mpid;
86dc6501 638 cfm->opup = s->opup;
a5610457 639 interval = ms_to_ccm_interval(s->interval);
de724029
EJ
640 interval_ms = ccm_interval_to_ms(interval);
641
13b1b2ae
EJ
642 atomic_store(&cfm->check_tnl_key, s->check_tnl_key);
643 atomic_store(&cfm->extended, s->extended);
644
189cb9e4 645 cfm->ccm_vlan = s->ccm_vlan;
a7aa2d3c 646 cfm->ccm_pcp = s->ccm_pcp & (VLAN_PCP_MASK >> VLAN_PCP_SHIFT);
13b1b2ae 647 if (s->extended && interval_ms != s->interval) {
de724029
EJ
648 interval = 0;
649 interval_ms = MIN(s->interval, UINT16_MAX);
650 }
9aa952b2 651
13b1b2ae 652 if (s->extended && s->demand) {
90967e95
EJ
653 if (!cfm->demand) {
654 cfm->demand = true;
655 cfm->rx_packets = cfm_rx_packets(cfm);
656 }
657 } else {
658 cfm->demand = false;
659 }
660
de724029 661 if (interval != cfm->ccm_interval || interval_ms != cfm->ccm_interval_ms) {
a5610457 662 cfm->ccm_interval = interval;
de724029 663 cfm->ccm_interval_ms = interval_ms;
b31bcf60 664
a5610457
EJ
665 timer_set_expired(&cfm->tx_timer);
666 timer_set_duration(&cfm->fault_timer, cfm_fault_interval(cfm));
667 }
b31bcf60 668
13b1b2ae 669 ovs_mutex_unlock(&mutex);
a5610457 670 return true;
b31bcf60
EJ
671}
672
9d46b444
EJ
673/* Must be called when the netdev owned by 'cfm' should change. */
674void
675cfm_set_netdev(struct cfm *cfm, const struct netdev *netdev)
13b1b2ae 676 OVS_EXCLUDED(mutex)
9d46b444 677{
13b1b2ae 678 ovs_mutex_lock(&mutex);
9d46b444
EJ
679 if (cfm->netdev != netdev) {
680 netdev_close(cfm->netdev);
681 cfm->netdev = netdev_ref(netdev);
682 }
13b1b2ae 683 ovs_mutex_unlock(&mutex);
9d46b444
EJ
684}
685
642dc74d
JP
686/* Returns true if 'cfm' should process packets from 'flow'. Sets
687 * fields in 'wc' that were used to make the determination. */
b31bcf60 688bool
5675cb4c 689cfm_should_process_flow(const struct cfm *cfm_, const struct flow *flow,
642dc74d 690 struct flow_wildcards *wc)
b31bcf60 691{
5675cb4c 692 struct cfm *cfm = CONST_CAST(struct cfm *, cfm_);
13b1b2ae
EJ
693 bool check_tnl_key;
694
695 atomic_read(&cfm->check_tnl_key, &check_tnl_key);
642dc74d 696 memset(&wc->masks.dl_dst, 0xff, sizeof wc->masks.dl_dst);
13b1b2ae 697 if (check_tnl_key) {
642dc74d
JP
698 memset(&wc->masks.tunnel.tun_id, 0xff, sizeof wc->masks.tunnel.tun_id);
699 }
b31bcf60 700 return (ntohs(flow->dl_type) == ETH_TYPE_CFM
b363bae4 701 && eth_addr_equals(flow->dl_dst, cfm_ccm_addr(cfm))
13b1b2ae 702 && (!check_tnl_key || flow->tunnel.tun_id == htonll(0)));
b31bcf60
EJ
703}
704
705/* Updates internal statistics relevant to packet 'p'. Should be called on
706 * every packet whose flow returned true when passed to
707 * cfm_should_process_flow. */
708void
709cfm_process_heartbeat(struct cfm *cfm, const struct ofpbuf *p)
13b1b2ae 710 OVS_EXCLUDED(mutex)
b31bcf60
EJ
711{
712 struct ccm *ccm;
0dd17bfd 713 struct eth_header *eth;
b31bcf60 714
13b1b2ae
EJ
715 ovs_mutex_lock(&mutex);
716
0dd17bfd 717 eth = p->l2;
ce27cbee 718 ccm = ofpbuf_at(p, (uint8_t *)p->l3 - (uint8_t *)p->data, CCM_ACCEPT_LEN);
b31bcf60
EJ
719
720 if (!ccm) {
32977975
EJ
721 VLOG_INFO_RL(&rl, "%s: Received an unparseable 802.1ag CCM heartbeat.",
722 cfm->name);
13b1b2ae 723 goto out;
b31bcf60
EJ
724 }
725
726 if (ccm->opcode != CCM_OPCODE) {
32977975
EJ
727 VLOG_INFO_RL(&rl, "%s: Received an unsupported 802.1ag message. "
728 "(opcode %u)", cfm->name, ccm->opcode);
13b1b2ae 729 goto out;
b31bcf60
EJ
730 }
731
5e809322 732 /* According to the 802.1ag specification, reception of a CCM with an
aa7f1158
EJ
733 * incorrect ccm_interval, unexpected MAID, or unexpected MPID should
734 * trigger a fault. We ignore this requirement for several reasons.
5e809322
EJ
735 *
736 * Faults can cause a controller or Open vSwitch to make potentially
737 * expensive changes to the network topology. It seems prudent to trigger
738 * them judiciously, especially when CFM is used to check slave status of
739 * bonds. Furthermore, faults can be maliciously triggered by crafting
2b540ecb 740 * unexpected CCMs. */
a5610457 741 if (memcmp(ccm->maid, cfm->maid, sizeof ccm->maid)) {
b9380396 742 cfm->recv_fault |= CFM_FAULT_MAID;
32977975
EJ
743 VLOG_WARN_RL(&rl, "%s: Received unexpected remote MAID from MAC "
744 ETH_ADDR_FMT, cfm->name, ETH_ADDR_ARGS(eth->eth_src));
f805c4cc 745 } else {
de724029
EJ
746 uint8_t ccm_interval = ccm->flags & 0x7;
747 bool ccm_rdi = ccm->flags & CCM_RDI_MASK;
748 uint16_t ccm_interval_ms_x = ntohs(ccm->interval_ms_x);
749
750 struct remote_mp *rmp;
348f01e3 751 uint64_t ccm_mpid;
8210113e 752 uint32_t ccm_seq;
86dc6501 753 bool ccm_opdown;
13b1b2ae 754 bool extended;
2b540ecb 755 enum cfm_fault_reason cfm_fault = 0;
348f01e3 756
13b1b2ae
EJ
757 atomic_read(&cfm->extended, &extended);
758 if (extended) {
86dc6501
EJ
759 ccm_mpid = ntohll(ccm->mpid64);
760 ccm_opdown = ccm->opdown;
761 } else {
762 ccm_mpid = ntohs(ccm->mpid);
763 ccm_opdown = false;
764 }
8210113e 765 ccm_seq = ntohl(ccm->seq);
b31bcf60 766
144216a3 767 if (ccm_interval != cfm->ccm_interval) {
2b540ecb 768 VLOG_WARN_RL(&rl, "%s: received a CCM with an unexpected interval"
348f01e3 769 " (%"PRIu8") from RMP %"PRIu64, cfm->name,
144216a3
EJ
770 ccm_interval, ccm_mpid);
771 }
b31bcf60 772
13b1b2ae 773 if (extended && ccm_interval == 0
de724029 774 && ccm_interval_ms_x != cfm->ccm_interval_ms) {
2b540ecb 775 VLOG_WARN_RL(&rl, "%s: received a CCM with an unexpected extended"
348f01e3 776 " interval (%"PRIu16"ms) from RMP %"PRIu64, cfm->name,
de724029
EJ
777 ccm_interval_ms_x, ccm_mpid);
778 }
779
144216a3 780 rmp = lookup_remote_mp(cfm, ccm_mpid);
86dc6501
EJ
781 if (!rmp) {
782 if (hmap_count(&cfm->remote_mps) < CFM_MAX_RMPS) {
8210113e 783 rmp = xzalloc(sizeof *rmp);
86dc6501
EJ
784 hmap_insert(&cfm->remote_mps, &rmp->node, hash_mpid(ccm_mpid));
785 } else {
2b540ecb 786 cfm_fault |= CFM_FAULT_OVERFLOW;
86dc6501
EJ
787 VLOG_WARN_RL(&rl,
788 "%s: dropped CCM with MPID %"PRIu64" from MAC "
789 ETH_ADDR_FMT, cfm->name, ccm_mpid,
790 ETH_ADDR_ARGS(eth->eth_src));
791 }
792 }
793
2b540ecb
MM
794 if (ccm_rdi) {
795 cfm_fault |= CFM_FAULT_RDI;
796 VLOG_DBG("%s: RDI bit flagged from RMP %"PRIu64, cfm->name,
66fb94b5 797 ccm_mpid);
2b540ecb
MM
798 }
799
8210113e
EJ
800 VLOG_DBG("%s: received CCM (seq %"PRIu32") (mpid %"PRIu64")"
801 " (interval %"PRIu8") (RDI %s)", cfm->name, ccm_seq,
802 ccm_mpid, ccm_interval, ccm_rdi ? "true" : "false");
803
0dd17bfd 804 if (rmp) {
2b540ecb
MM
805 if (rmp->mpid == cfm->mpid) {
806 cfm_fault |= CFM_FAULT_LOOPBACK;
807 VLOG_WARN_RL(&rl,"%s: received CCM with local MPID"
808 " %"PRIu64, cfm->name, rmp->mpid);
809 }
810
8210113e
EJ
811 if (rmp->seq && ccm_seq != (rmp->seq + 1)) {
812 VLOG_WARN_RL(&rl, "%s: (mpid %"PRIu64") detected sequence"
813 " numbers which indicate possible connectivity"
814 " problems (previous %"PRIu32") (current %"PRIu32
815 ")", cfm->name, ccm_mpid, rmp->seq, ccm_seq);
816 }
817
144216a3 818 rmp->mpid = ccm_mpid;
2b540ecb 819 if (!cfm_fault) {
3967a833
MM
820 rmp->num_health_ccm++;
821 }
2b540ecb
MM
822 rmp->recv = true;
823 cfm->recv_fault |= cfm_fault;
8210113e 824 rmp->seq = ccm_seq;
86dc6501 825 rmp->opup = !ccm_opdown;
c3f72482 826 rmp->last_rx = time_msec();
f805c4cc 827 }
b31bcf60 828 }
13b1b2ae
EJ
829
830out:
831 ovs_mutex_unlock(&mutex);
b31bcf60 832}
20c8e971 833
13b1b2ae 834static int
bd3950dd 835cfm_get_fault__(const struct cfm *cfm) OVS_REQUIRES(mutex)
a5610457 836{
d7243b93 837 if (cfm->fault_override >= 0) {
b9380396 838 return cfm->fault_override ? CFM_FAULT_OVERRIDE : 0;
d7243b93 839 }
a5610457
EJ
840 return cfm->fault;
841}
842
13b1b2ae
EJ
843/* Gets the fault status of 'cfm'. Returns a bit mask of 'cfm_fault_reason's
844 * indicating the cause of the connectivity fault, or zero if there is no
845 * fault. */
846int
847cfm_get_fault(const struct cfm *cfm) OVS_EXCLUDED(mutex)
848{
849 int fault;
850
851 ovs_mutex_lock(&mutex);
852 fault = cfm_get_fault__(cfm);
853 ovs_mutex_unlock(&mutex);
854 return fault;
855}
856
76c4290d
AW
857/* Gets the number of cfm fault flapping since start. */
858uint64_t
859cfm_get_flap_count(const struct cfm *cfm) OVS_EXCLUDED(mutex)
860{
861 uint64_t flap_count;
862 ovs_mutex_lock(&mutex);
863 flap_count = cfm->flap_count;
864 ovs_mutex_unlock(&mutex);
865 return flap_count;
866}
867
3967a833
MM
868/* Gets the health of 'cfm'. Returns an integer between 0 and 100 indicating
869 * the health of the link as a percentage of ccm frames received in
870 * CFM_HEALTH_INTERVAL * 'fault_interval' if there is only 1 remote_mpid,
871 * returns 0 if there are no remote_mpids, and returns -1 if there are more
872 * than 1 remote_mpids. */
873int
13b1b2ae 874cfm_get_health(const struct cfm *cfm) OVS_EXCLUDED(mutex)
3967a833 875{
13b1b2ae
EJ
876 int health;
877
878 ovs_mutex_lock(&mutex);
879 health = cfm->health;
880 ovs_mutex_unlock(&mutex);
881 return health;
3967a833
MM
882}
883
86dc6501
EJ
884/* Gets the operational state of 'cfm'. 'cfm' is considered operationally down
885 * if it has received a CCM with the operationally down bit set from any of its
4653c558
EJ
886 * remote maintenance points. Returns 1 if 'cfm' is operationally up, 0 if
887 * 'cfm' is operationally down, or -1 if 'cfm' has no operational state
888 * (because it isn't in extended mode). */
889int
5675cb4c 890cfm_get_opup(const struct cfm *cfm_) OVS_EXCLUDED(mutex)
86dc6501 891{
5675cb4c 892 struct cfm *cfm = CONST_CAST(struct cfm *, cfm_);
13b1b2ae
EJ
893 bool extended;
894 int opup;
895
896 ovs_mutex_lock(&mutex);
897 atomic_read(&cfm->extended, &extended);
898 opup = extended ? cfm->remote_opup : -1;
899 ovs_mutex_unlock(&mutex);
900
901 return opup;
86dc6501
EJ
902}
903
1de11730
EJ
904/* Populates 'rmps' with an array of remote maintenance points reachable by
905 * 'cfm'. The number of remote maintenance points is written to 'n_rmps'.
906 * 'cfm' retains ownership of the array written to 'rmps' */
907void
13b1b2ae
EJ
908cfm_get_remote_mpids(const struct cfm *cfm, uint64_t **rmps, size_t *n_rmps)
909 OVS_EXCLUDED(mutex)
1de11730 910{
13b1b2ae 911 ovs_mutex_lock(&mutex);
95e22d67 912 *rmps = xmemdup(cfm->rmps_array, cfm->rmps_array_len * sizeof **rmps);
1de11730 913 *n_rmps = cfm->rmps_array_len;
13b1b2ae 914 ovs_mutex_unlock(&mutex);
1de11730
EJ
915}
916
a5610457 917static struct cfm *
344e21d4 918cfm_find(const char *name) OVS_REQUIRES(mutex)
20c8e971 919{
a5610457 920 struct cfm *cfm;
9ac3fce4 921
13b1b2ae 922 HMAP_FOR_EACH_WITH_HASH (cfm, hmap_node, hash_string(name, 0), all_cfms) {
6f629657 923 if (!strcmp(cfm->name, name)) {
a5610457 924 return cfm;
9ac3fce4
EJ
925 }
926 }
927 return NULL;
928}
929
930static void
5675cb4c 931cfm_print_details(struct ds *ds, struct cfm *cfm) OVS_REQUIRES(mutex)
9ac3fce4 932{
20c8e971 933 struct remote_mp *rmp;
13b1b2ae 934 bool extended;
906bb3d0 935 int fault;
20c8e971 936
13b1b2ae
EJ
937 atomic_read(&cfm->extended, &extended);
938
ae75dae3 939 ds_put_format(ds, "---- %s ----\n", cfm->name);
b9380396 940 ds_put_format(ds, "MPID %"PRIu64":%s%s\n", cfm->mpid,
13b1b2ae 941 extended ? " extended" : "",
b9380396
EJ
942 cfm->fault_override >= 0 ? " fault_override" : "");
943
13b1b2ae 944 fault = cfm_get_fault__(cfm);
906bb3d0 945 if (fault) {
c3f72482
EJ
946 ds_put_cstr(ds, "\tfault: ");
947 ds_put_cfm_fault(ds, fault);
b9380396
EJ
948 ds_put_cstr(ds, "\n");
949 }
9ac3fce4 950
3967a833
MM
951 if (cfm->health == -1) {
952 ds_put_format(ds, "\taverage health: undefined\n");
953 } else {
954 ds_put_format(ds, "\taverage health: %d\n", cfm->health);
955 }
86dc6501
EJ
956 ds_put_format(ds, "\topstate: %s\n", cfm->opup ? "up" : "down");
957 ds_put_format(ds, "\tremote_opstate: %s\n",
958 cfm->remote_opup ? "up" : "down");
ae75dae3
JP
959 ds_put_format(ds, "\tinterval: %dms\n", cfm->ccm_interval_ms);
960 ds_put_format(ds, "\tnext CCM tx: %lldms\n",
a5610457 961 timer_msecs_until_expired(&cfm->tx_timer));
ae75dae3 962 ds_put_format(ds, "\tnext fault check: %lldms\n",
a5610457 963 timer_msecs_until_expired(&cfm->fault_timer));
20c8e971 964
a5610457 965 HMAP_FOR_EACH (rmp, node, &cfm->remote_mps) {
2b540ecb 966 ds_put_format(ds, "Remote MPID %"PRIu64"\n", rmp->mpid);
7593daa2 967 ds_put_format(ds, "\trecv since check: %s\n",
dd986e09 968 rmp->recv ? "true" : "false");
86dc6501 969 ds_put_format(ds, "\topstate: %s\n", rmp->opup? "up" : "down");
20c8e971 970 }
ae75dae3
JP
971}
972
973static void
0e15264f 974cfm_unixctl_show(struct unixctl_conn *conn, int argc, const char *argv[],
13b1b2ae 975 void *aux OVS_UNUSED) OVS_EXCLUDED(mutex)
ae75dae3
JP
976{
977 struct ds ds = DS_EMPTY_INITIALIZER;
5675cb4c 978 struct cfm *cfm;
ae75dae3 979
13b1b2ae 980 ovs_mutex_lock(&mutex);
0e15264f
BP
981 if (argc > 1) {
982 cfm = cfm_find(argv[1]);
ae75dae3 983 if (!cfm) {
bde9f75d 984 unixctl_command_reply_error(conn, "no such CFM object");
13b1b2ae 985 goto out;
ae75dae3
JP
986 }
987 cfm_print_details(&ds, cfm);
988 } else {
13b1b2ae 989 HMAP_FOR_EACH (cfm, hmap_node, all_cfms) {
ae75dae3
JP
990 cfm_print_details(&ds, cfm);
991 }
992 }
9ac3fce4 993
bde9f75d 994 unixctl_command_reply(conn, ds_cstr(&ds));
9ac3fce4 995 ds_destroy(&ds);
13b1b2ae
EJ
996out:
997 ovs_mutex_unlock(&mutex);
20c8e971 998}
d7243b93
EJ
999
1000static void
1001cfm_unixctl_set_fault(struct unixctl_conn *conn, int argc, const char *argv[],
13b1b2ae 1002 void *aux OVS_UNUSED) OVS_EXCLUDED(mutex)
d7243b93
EJ
1003{
1004 const char *fault_str = argv[argc - 1];
1005 int fault_override;
1006 struct cfm *cfm;
1007
13b1b2ae 1008 ovs_mutex_lock(&mutex);
d7243b93
EJ
1009 if (!strcasecmp("true", fault_str)) {
1010 fault_override = 1;
1011 } else if (!strcasecmp("false", fault_str)) {
1012 fault_override = 0;
1013 } else if (!strcasecmp("normal", fault_str)) {
1014 fault_override = -1;
1015 } else {
bde9f75d 1016 unixctl_command_reply_error(conn, "unknown fault string");
13b1b2ae 1017 goto out;
d7243b93
EJ
1018 }
1019
1020 if (argc > 2) {
1021 cfm = cfm_find(argv[1]);
1022 if (!cfm) {
bde9f75d 1023 unixctl_command_reply_error(conn, "no such CFM object");
13b1b2ae 1024 goto out;
d7243b93
EJ
1025 }
1026 cfm->fault_override = fault_override;
1027 } else {
13b1b2ae 1028 HMAP_FOR_EACH (cfm, hmap_node, all_cfms) {
d7243b93
EJ
1029 cfm->fault_override = fault_override;
1030 }
1031 }
1032
c95e2783 1033 seq_change(connectivity_seq_get());
bde9f75d 1034 unixctl_command_reply(conn, "OK");
13b1b2ae
EJ
1035
1036out:
1037 ovs_mutex_unlock(&mutex);
d7243b93 1038}