]> git.proxmox.com Git - mirror_ovs.git/blame - lib/stp.c
lldp: increase statsTLVsUnrecognizedTotal on unknown TLV
[mirror_ovs.git] / lib / stp.c
CommitLineData
829a7d02 1/*
1620b7ea 2 * Copyright (c) 2008-2014, 2016-2017 Nicira, Inc.
829a7d02
JP
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at:
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17/* Based on sample implementation in 802.1D-1998. Above copyright and license
18 * applies to all modifications. */
19
20#include <config.h>
21
22#include "stp.h"
23#include <sys/types.h>
24#include <netinet/in.h>
25#include <arpa/inet.h>
829a7d02
JP
26#include <inttypes.h>
27#include <stdlib.h>
28#include "byte-order.h"
f23d157c 29#include "connectivity.h"
64c96779 30#include "openvswitch/ofpbuf.h"
e6211adc 31#include "ovs-atomic.h"
cf62fa4c 32#include "dp-packet.h"
829a7d02 33#include "packets.h"
f23d157c 34#include "seq.h"
fe4a02e4 35#include "unixctl.h"
829a7d02 36#include "util.h"
e6211adc 37#include "openvswitch/vlog.h"
829a7d02
JP
38
39VLOG_DEFINE_THIS_MODULE(stp);
40
11306274
AW
41static struct vlog_rate_limit stp_rl = VLOG_RATE_LIMIT_INIT(60, 60);
42
829a7d02
JP
43#define STP_PROTOCOL_ID 0x0000
44#define STP_PROTOCOL_VERSION 0x00
45#define STP_TYPE_CONFIG 0x00
46#define STP_TYPE_TCN 0x80
47
48struct stp_bpdu_header {
49 ovs_be16 protocol_id; /* STP_PROTOCOL_ID. */
50 uint8_t protocol_version; /* STP_PROTOCOL_VERSION. */
51 uint8_t bpdu_type; /* One of STP_TYPE_*. */
1620b7ea 52};
829a7d02
JP
53BUILD_ASSERT_DECL(sizeof(struct stp_bpdu_header) == 4);
54
55enum stp_config_bpdu_flags {
56 STP_CONFIG_TOPOLOGY_CHANGE_ACK = 0x80,
57 STP_CONFIG_TOPOLOGY_CHANGE = 0x01
58};
59
13b6bae6 60OVS_PACKED(
829a7d02
JP
61struct stp_config_bpdu {
62 struct stp_bpdu_header header; /* Type STP_TYPE_CONFIG. */
63 uint8_t flags; /* STP_CONFIG_* flags. */
64 ovs_be64 root_id; /* 8.5.1.1: Bridge believed to be root. */
65 ovs_be32 root_path_cost; /* 8.5.1.2: Cost of path to root. */
66 ovs_be64 bridge_id; /* 8.5.1.3: ID of transmitting bridge. */
67 ovs_be16 port_id; /* 8.5.1.4: Port transmitting the BPDU. */
68 ovs_be16 message_age; /* 8.5.1.5: Age of BPDU at tx time. */
69 ovs_be16 max_age; /* 8.5.1.6: Timeout for received data. */
70 ovs_be16 hello_time; /* 8.5.1.7: Time between BPDU generation. */
71 ovs_be16 forward_delay; /* 8.5.1.8: State progression delay. */
13b6bae6 72});
829a7d02
JP
73BUILD_ASSERT_DECL(sizeof(struct stp_config_bpdu) == 35);
74
75struct stp_tcn_bpdu {
76 struct stp_bpdu_header header; /* Type STP_TYPE_TCN. */
1620b7ea 77};
829a7d02
JP
78BUILD_ASSERT_DECL(sizeof(struct stp_tcn_bpdu) == 4);
79
80struct stp_timer {
81 bool active; /* Timer in use? */
82 int value; /* Current value of timer, counting up. */
83};
84
85struct stp_port {
86 struct stp *stp;
11306274 87 char *port_name; /* Human-readable name for log messages. */
3310b570 88 void *aux; /* Auxiliary data the user may retrieve. */
829a7d02
JP
89 int port_id; /* 8.5.5.1: Unique port identifier. */
90 enum stp_state state; /* 8.5.5.2: Current state. */
91 int path_cost; /* 8.5.5.3: Cost of tx/rx on this port. */
92 stp_identifier designated_root; /* 8.5.5.4. */
93 int designated_cost; /* 8.5.5.5: Path cost to root on port. */
94 stp_identifier designated_bridge; /* 8.5.5.6. */
95 int designated_port; /* 8.5.5.7: Port to send config msgs on. */
96 bool topology_change_ack; /* 8.5.5.8: Flag for next config BPDU. */
97 bool config_pending; /* 8.5.5.9: Send BPDU when hold expires? */
98 bool change_detection_enabled; /* 8.5.5.10: Detect topology changes? */
99
100 struct stp_timer message_age_timer; /* 8.5.6.1: Age of received info. */
101 struct stp_timer forward_delay_timer; /* 8.5.6.2: State change timer. */
102 struct stp_timer hold_timer; /* 8.5.6.3: BPDU rate limit timer. */
103
80740385
JP
104 int tx_count; /* Number of BPDUs transmitted. */
105 int rx_count; /* Number of valid BPDUs received. */
106 int error_count; /* Number of bad BPDUs received. */
107
829a7d02
JP
108 bool state_changed;
109};
110
111struct stp {
ca6ba700 112 struct ovs_list node; /* Node in all_stps list. */
fe4a02e4 113
829a7d02
JP
114 /* Static bridge data. */
115 char *name; /* Human-readable name for log messages. */
116 stp_identifier bridge_id; /* 8.5.3.7: This bridge. */
117 int max_age; /* 8.5.3.4: Time to drop received data. */
118 int hello_time; /* 8.5.3.5: Time between sending BPDUs. */
119 int forward_delay; /* 8.5.3.6: Delay between state changes. */
120 int bridge_max_age; /* 8.5.3.8: max_age when we're root. */
121 int bridge_hello_time; /* 8.5.3.9: hello_time as root. */
122 int bridge_forward_delay; /* 8.5.3.10: forward_delay as root. */
123 int rq_max_age; /* User-requested max age, in ms. */
124 int rq_hello_time; /* User-requested hello time, in ms. */
125 int rq_forward_delay; /* User-requested forward delay, in ms. */
126 int elapsed_remainder; /* Left-over msecs from last stp_tick(). */
127
128 /* Dynamic bridge data. */
129 stp_identifier designated_root; /* 8.5.3.1: Bridge believed to be root. */
130 unsigned int root_path_cost; /* 8.5.3.2: Cost of path to root. */
131 struct stp_port *root_port; /* 8.5.3.3: Lowest cost port to root. */
132 bool topology_change_detected; /* 8.5.3.11: Detected a topology change? */
133 bool topology_change; /* 8.5.3.12: Received topology change? */
134
135 /* Bridge timers. */
136 struct stp_timer hello_timer; /* 8.5.4.1: Hello timer. */
137 struct stp_timer tcn_timer; /* 8.5.4.2: Topology change timer. */
138 struct stp_timer topology_change_timer; /* 8.5.4.3. */
139
140 /* Ports. */
141 struct stp_port ports[STP_MAX_PORTS];
142
143 /* Interface to client. */
6ae50723 144 bool fdb_needs_flush; /* MAC learning tables needs flushing. */
829a7d02 145 struct stp_port *first_changed_port;
cf62fa4c 146 void (*send_bpdu)(struct dp_packet *bpdu, int port_no, void *aux);
829a7d02 147 void *aux;
bd54dbcd 148
37bec3d3 149 struct ovs_refcount ref_cnt;
829a7d02
JP
150};
151
bd54dbcd 152static struct ovs_mutex mutex;
55951e15 153static struct ovs_list all_stps__ = OVS_LIST_INITIALIZER(&all_stps__);
ca6ba700 154static struct ovs_list *const all_stps OVS_GUARDED_BY(mutex) = &all_stps__;
fe4a02e4 155
829a7d02
JP
156#define FOR_EACH_ENABLED_PORT(PORT, STP) \
157 for ((PORT) = stp_next_enabled_port((STP), (STP)->ports); \
158 (PORT); \
159 (PORT) = stp_next_enabled_port((STP), (PORT) + 1))
160static struct stp_port *
161stp_next_enabled_port(const struct stp *stp, const struct stp_port *port)
bd3950dd 162 OVS_REQUIRES(mutex)
829a7d02
JP
163{
164 for (; port < &stp->ports[ARRAY_SIZE(stp->ports)]; port++) {
165 if (port->state != STP_DISABLED) {
ebc56baa 166 return CONST_CAST(struct stp_port *, port);
829a7d02
JP
167 }
168 }
169 return NULL;
170}
171
172#define MESSAGE_AGE_INCREMENT 1
173
bd3950dd 174static void stp_transmit_config(struct stp_port *) OVS_REQUIRES(mutex);
829a7d02 175static bool stp_supersedes_port_info(const struct stp_port *,
bd54dbcd 176 const struct stp_config_bpdu *)
bd3950dd 177 OVS_REQUIRES(mutex);
829a7d02 178static void stp_record_config_information(struct stp_port *,
bd54dbcd 179 const struct stp_config_bpdu *)
bd3950dd 180 OVS_REQUIRES(mutex);
829a7d02 181static void stp_record_config_timeout_values(struct stp *,
bd54dbcd 182 const struct stp_config_bpdu *)
bd3950dd 183 OVS_REQUIRES(mutex);
bd54dbcd 184static bool stp_is_designated_port(const struct stp_port *)
bd3950dd
AW
185 OVS_REQUIRES(mutex);
186static void stp_config_bpdu_generation(struct stp *) OVS_REQUIRES(mutex);
187static void stp_transmit_tcn(struct stp *) OVS_REQUIRES(mutex);
188static void stp_configuration_update(struct stp *) OVS_REQUIRES(mutex);
829a7d02 189static bool stp_supersedes_root(const struct stp_port *root,
bd3950dd
AW
190 const struct stp_port *) OVS_REQUIRES(mutex);
191static void stp_root_selection(struct stp *) OVS_REQUIRES(mutex);
192static void stp_designated_port_selection(struct stp *) OVS_REQUIRES(mutex);
bd54dbcd 193static void stp_become_designated_port(struct stp_port *)
bd3950dd
AW
194 OVS_REQUIRES(mutex);
195static void stp_port_state_selection(struct stp *) OVS_REQUIRES(mutex);
196static void stp_make_forwarding(struct stp_port *) OVS_REQUIRES(mutex);
197static void stp_make_blocking(struct stp_port *) OVS_REQUIRES(mutex);
bd54dbcd 198static void stp_set_port_state(struct stp_port *, enum stp_state)
bd3950dd
AW
199 OVS_REQUIRES(mutex);
200static void stp_topology_change_detection(struct stp *) OVS_REQUIRES(mutex);
bd54dbcd 201static void stp_topology_change_acknowledged(struct stp *)
bd3950dd 202 OVS_REQUIRES(mutex);
bd54dbcd 203static void stp_acknowledge_topology_change(struct stp_port *)
bd3950dd 204 OVS_REQUIRES(mutex);
829a7d02 205static void stp_received_config_bpdu(struct stp *, struct stp_port *,
bd54dbcd 206 const struct stp_config_bpdu *)
bd3950dd 207 OVS_REQUIRES(mutex);
bd54dbcd 208static void stp_received_tcn_bpdu(struct stp *, struct stp_port *)
bd3950dd
AW
209 OVS_REQUIRES(mutex);
210static void stp_hello_timer_expiry(struct stp *) OVS_REQUIRES(mutex);
bd54dbcd 211static void stp_message_age_timer_expiry(struct stp_port *)
bd3950dd 212 OVS_REQUIRES(mutex);
bd54dbcd 213static bool stp_is_designated_for_some_port(const struct stp *)
bd3950dd 214 OVS_REQUIRES(mutex);
bd54dbcd 215static void stp_forward_delay_timer_expiry(struct stp_port *)
bd3950dd
AW
216 OVS_REQUIRES(mutex);
217static void stp_tcn_timer_expiry(struct stp *) OVS_REQUIRES(mutex);
bd54dbcd 218static void stp_topology_change_timer_expiry(struct stp *)
bd3950dd
AW
219 OVS_REQUIRES(mutex);
220static void stp_hold_timer_expiry(struct stp_port *) OVS_REQUIRES(mutex);
bd54dbcd 221static void stp_initialize_port(struct stp_port *, enum stp_state)
bd3950dd
AW
222 OVS_REQUIRES(mutex);
223static void stp_become_root_bridge(struct stp *) OVS_REQUIRES(mutex);
224static void stp_update_bridge_timers(struct stp *) OVS_REQUIRES(mutex);
829a7d02
JP
225
226static int clamp(int x, int min, int max);
227static int ms_to_timer(int ms);
829a7d02
JP
228static int timer_to_ms(int timer);
229static void stp_start_timer(struct stp_timer *, int value);
230static void stp_stop_timer(struct stp_timer *);
231static bool stp_timer_expired(struct stp_timer *, int elapsed, int timeout);
232
bd54dbcd 233static void stp_send_bpdu(struct stp_port *, const void *, size_t)
bd3950dd 234 OVS_REQUIRES(mutex);
fe4a02e4
EJ
235static void stp_unixctl_tcn(struct unixctl_conn *, int argc,
236 const char *argv[], void *aux);
5f206eb6 237static void stp_unixctl_show(struct unixctl_conn *, int argc,
238 const char *argv[], void *aux);
fe4a02e4
EJ
239
240void
241stp_init(void)
242{
49558bf6
BP
243 static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
244
245 if (ovsthread_once_start(&once)) {
246 /* We need a recursive mutex because stp_send_bpdu() could loop back
247 * into the stp module through a patch port. This happens
248 * intentionally as part of the unit tests. Ideally we'd ditch
249 * the call back function, but for now this is what we have. */
250 ovs_mutex_init_recursive(&mutex);
251
252 unixctl_command_register("stp/tcn", "[bridge]", 0, 1, stp_unixctl_tcn,
253 NULL);
5f206eb6 254 unixctl_command_register("stp/show", "[bridge]", 0, 1,
255 stp_unixctl_show, NULL);
49558bf6
BP
256 ovsthread_once_done(&once);
257 }
fe4a02e4 258}
829a7d02
JP
259
260/* Creates and returns a new STP instance that initially has no ports enabled.
261 *
262 * 'bridge_id' should be a 48-bit MAC address as returned by
263 * eth_addr_to_uint64(). 'bridge_id' may also have a priority value in its top
264 * 16 bits; if those bits are set to 0, STP_DEFAULT_BRIDGE_PRIORITY is used.
265 * (This priority may be changed with stp_set_bridge_priority().)
266 *
267 * When the bridge needs to send out a BPDU, it calls 'send_bpdu'. This
268 * callback may be called from stp_tick() or stp_received_bpdu(). The
269 * arguments to 'send_bpdu' are an STP BPDU encapsulated in 'bpdu',
270 * the spanning tree port number 'port_no' that should transmit the
271 * packet, and auxiliary data to be passed to the callback in 'aux'.
272 */
273struct stp *
274stp_create(const char *name, stp_identifier bridge_id,
cf62fa4c 275 void (*send_bpdu)(struct dp_packet *bpdu, int port_no, void *aux),
829a7d02
JP
276 void *aux)
277{
278 struct stp *stp;
279 struct stp_port *p;
280
49558bf6 281 stp_init();
bd54dbcd
EJ
282
283 ovs_mutex_lock(&mutex);
829a7d02
JP
284 stp = xzalloc(sizeof *stp);
285 stp->name = xstrdup(name);
286 stp->bridge_id = bridge_id;
287 if (!(stp->bridge_id >> 48)) {
288 stp->bridge_id |= (uint64_t) STP_DEFAULT_BRIDGE_PRIORITY << 48;
289 }
290
3310b570
JP
291 stp->rq_max_age = STP_DEFAULT_MAX_AGE;
292 stp->rq_hello_time = STP_DEFAULT_HELLO_TIME;
293 stp->rq_forward_delay = STP_DEFAULT_FWD_DELAY;
829a7d02
JP
294 stp_update_bridge_timers(stp);
295 stp->max_age = stp->bridge_max_age;
296 stp->hello_time = stp->bridge_hello_time;
297 stp->forward_delay = stp->bridge_forward_delay;
298
299 stp->designated_root = stp->bridge_id;
300 stp->root_path_cost = 0;
301 stp->root_port = NULL;
302 stp->topology_change_detected = false;
303 stp->topology_change = false;
304
305 stp_stop_timer(&stp->tcn_timer);
306 stp_stop_timer(&stp->topology_change_timer);
ef0bd569 307 stp_start_timer(&stp->hello_timer, stp->hello_time);
829a7d02
JP
308
309 stp->send_bpdu = send_bpdu;
310 stp->aux = aux;
311
312 stp->first_changed_port = &stp->ports[ARRAY_SIZE(stp->ports)];
313 for (p = stp->ports; p < &stp->ports[ARRAY_SIZE(stp->ports)]; p++) {
314 p->stp = stp;
315 p->port_id = (stp_port_no(p) + 1) | (STP_DEFAULT_PORT_PRIORITY << 8);
316 p->path_cost = 19; /* Recommended default for 100 Mb/s link. */
317 stp_initialize_port(p, STP_DISABLED);
318 }
37bec3d3 319 ovs_refcount_init(&stp->ref_cnt);
bd54dbcd 320
417e7e66 321 ovs_list_push_back(all_stps, &stp->node);
bd54dbcd
EJ
322 ovs_mutex_unlock(&mutex);
323 return stp;
324}
325
326struct stp *
327stp_ref(const struct stp *stp_)
328{
329 struct stp *stp = CONST_CAST(struct stp *, stp_);
330 if (stp) {
37bec3d3 331 ovs_refcount_ref(&stp->ref_cnt);
bd54dbcd 332 }
829a7d02
JP
333 return stp;
334}
335
336/* Destroys 'stp'. */
337void
bd54dbcd 338stp_unref(struct stp *stp)
829a7d02 339{
24f83812 340 if (stp && ovs_refcount_unref_relaxed(&stp->ref_cnt) == 1) {
11306274
AW
341 size_t i;
342
bd54dbcd 343 ovs_mutex_lock(&mutex);
417e7e66 344 ovs_list_remove(&stp->node);
bd54dbcd 345 ovs_mutex_unlock(&mutex);
829a7d02 346 free(stp->name);
11306274
AW
347
348 for (i = 0; i < STP_MAX_PORTS; i++) {
349 free(stp->ports[i].port_name);
350 }
829a7d02
JP
351 free(stp);
352 }
353}
354
355/* Runs 'stp' given that 'ms' milliseconds have passed. */
356void
357stp_tick(struct stp *stp, int ms)
358{
359 struct stp_port *p;
360 int elapsed;
361
bd54dbcd 362 ovs_mutex_lock(&mutex);
829a7d02
JP
363 /* Convert 'ms' to STP timer ticks. Preserve any leftover milliseconds
364 * from previous stp_tick() calls so that we don't lose STP ticks when we
365 * are called too frequently. */
366 ms = clamp(ms, 0, INT_MAX - 1000) + stp->elapsed_remainder;
367 elapsed = ms_to_timer(ms);
ba25773f 368 stp->elapsed_remainder = ms - timer_to_ms(elapsed);
829a7d02 369 if (!elapsed) {
bd54dbcd 370 goto out;
829a7d02
JP
371 }
372
373 if (stp_timer_expired(&stp->hello_timer, elapsed, stp->hello_time)) {
374 stp_hello_timer_expiry(stp);
375 }
376 if (stp_timer_expired(&stp->tcn_timer, elapsed, stp->bridge_hello_time)) {
377 stp_tcn_timer_expiry(stp);
378 }
379 if (stp_timer_expired(&stp->topology_change_timer, elapsed,
380 stp->max_age + stp->forward_delay)) {
381 stp_topology_change_timer_expiry(stp);
382 }
383 FOR_EACH_ENABLED_PORT (p, stp) {
384 if (stp_timer_expired(&p->message_age_timer, elapsed, stp->max_age)) {
385 stp_message_age_timer_expiry(p);
386 }
387 }
388 FOR_EACH_ENABLED_PORT (p, stp) {
389 if (stp_timer_expired(&p->forward_delay_timer, elapsed,
390 stp->forward_delay)) {
391 stp_forward_delay_timer_expiry(p);
392 }
393 if (stp_timer_expired(&p->hold_timer, elapsed, ms_to_timer(1000))) {
394 stp_hold_timer_expiry(p);
395 }
396 }
bd54dbcd
EJ
397
398out:
399 ovs_mutex_unlock(&mutex);
829a7d02
JP
400}
401
402static void
403set_bridge_id(struct stp *stp, stp_identifier new_bridge_id)
bd3950dd 404 OVS_REQUIRES(mutex)
829a7d02
JP
405{
406 if (new_bridge_id != stp->bridge_id) {
407 bool root;
408 struct stp_port *p;
409
410 root = stp_is_root_bridge(stp);
411 FOR_EACH_ENABLED_PORT (p, stp) {
412 if (stp_is_designated_port(p)) {
413 p->designated_bridge = new_bridge_id;
414 }
415 }
416 stp->bridge_id = new_bridge_id;
417 stp_configuration_update(stp);
418 stp_port_state_selection(stp);
419 if (stp_is_root_bridge(stp) && !root) {
420 stp_become_root_bridge(stp);
421 }
422 }
423}
424
425void
426stp_set_bridge_id(struct stp *stp, stp_identifier bridge_id)
427{
428 const uint64_t mac_bits = (UINT64_C(1) << 48) - 1;
429 const uint64_t pri_bits = ~mac_bits;
bd54dbcd 430 ovs_mutex_lock(&mutex);
829a7d02 431 set_bridge_id(stp, (stp->bridge_id & pri_bits) | (bridge_id & mac_bits));
bd54dbcd 432 ovs_mutex_unlock(&mutex);
829a7d02
JP
433}
434
435void
436stp_set_bridge_priority(struct stp *stp, uint16_t new_priority)
437{
438 const uint64_t mac_bits = (UINT64_C(1) << 48) - 1;
bd54dbcd 439 ovs_mutex_lock(&mutex);
829a7d02
JP
440 set_bridge_id(stp, ((stp->bridge_id & mac_bits)
441 | ((uint64_t) new_priority << 48)));
bd54dbcd 442 ovs_mutex_unlock(&mutex);
829a7d02
JP
443}
444
445/* Sets the desired hello time for 'stp' to 'ms', in milliseconds. The actual
446 * hello time is clamped to the range of 1 to 10 seconds and subject to the
447 * relationship (bridge_max_age >= 2 * (bridge_hello_time + 1 s)). The bridge
448 * hello time is only used when 'stp' is the root bridge. */
449void
450stp_set_hello_time(struct stp *stp, int ms)
451{
bd54dbcd 452 ovs_mutex_lock(&mutex);
829a7d02
JP
453 stp->rq_hello_time = ms;
454 stp_update_bridge_timers(stp);
bd54dbcd 455 ovs_mutex_unlock(&mutex);
829a7d02
JP
456}
457
458/* Sets the desired max age for 'stp' to 'ms', in milliseconds. The actual max
459 * age is clamped to the range of 6 to 40 seconds and subject to the
460 * relationships (2 * (bridge_forward_delay - 1 s) >= bridge_max_age) and
461 * (bridge_max_age >= 2 * (bridge_hello_time + 1 s)). The bridge max age is
462 * only used when 'stp' is the root bridge. */
463void
464stp_set_max_age(struct stp *stp, int ms)
465{
bd54dbcd 466 ovs_mutex_lock(&mutex);
829a7d02
JP
467 stp->rq_max_age = ms;
468 stp_update_bridge_timers(stp);
bd54dbcd 469 ovs_mutex_unlock(&mutex);
829a7d02
JP
470}
471
472/* Sets the desired forward delay for 'stp' to 'ms', in milliseconds. The
473 * actual forward delay is clamped to the range of 4 to 30 seconds and subject
474 * to the relationship (2 * (bridge_forward_delay - 1 s) >= bridge_max_age).
475 * The bridge forward delay is only used when 'stp' is the root bridge. */
476void
477stp_set_forward_delay(struct stp *stp, int ms)
478{
bd54dbcd 479 ovs_mutex_lock(&mutex);
829a7d02
JP
480 stp->rq_forward_delay = ms;
481 stp_update_bridge_timers(stp);
bd54dbcd 482 ovs_mutex_unlock(&mutex);
829a7d02
JP
483}
484
485/* Returns the name given to 'stp' in the call to stp_create(). */
486const char *
487stp_get_name(const struct stp *stp)
488{
bd54dbcd
EJ
489 char *name;
490
491 ovs_mutex_lock(&mutex);
492 name = stp->name;
493 ovs_mutex_unlock(&mutex);
494 return name;
829a7d02
JP
495}
496
497/* Returns the bridge ID for 'stp'. */
498stp_identifier
499stp_get_bridge_id(const struct stp *stp)
500{
bd54dbcd
EJ
501 stp_identifier bridge_id;
502
503 ovs_mutex_lock(&mutex);
504 bridge_id = stp->bridge_id;
505 ovs_mutex_unlock(&mutex);
506 return bridge_id;
829a7d02
JP
507}
508
509/* Returns the bridge ID of the bridge currently believed to be the root. */
510stp_identifier
511stp_get_designated_root(const struct stp *stp)
512{
bd54dbcd
EJ
513 stp_identifier designated_root;
514
515 ovs_mutex_lock(&mutex);
516 designated_root = stp->designated_root;
517 ovs_mutex_unlock(&mutex);
518 return designated_root;
829a7d02
JP
519}
520
521/* Returns true if 'stp' believes itself to the be root of the spanning tree,
522 * false otherwise. */
523bool
524stp_is_root_bridge(const struct stp *stp)
525{
bd54dbcd
EJ
526 bool is_root;
527
528 ovs_mutex_lock(&mutex);
529 is_root = stp->bridge_id == stp->designated_root;
530 ovs_mutex_unlock(&mutex);
531 return is_root;
829a7d02
JP
532}
533
534/* Returns the cost of the path from 'stp' to the root of the spanning tree. */
535int
536stp_get_root_path_cost(const struct stp *stp)
537{
bd54dbcd
EJ
538 int cost;
539
540 ovs_mutex_lock(&mutex);
541 cost = stp->root_path_cost;
542 ovs_mutex_unlock(&mutex);
543 return cost;
829a7d02
JP
544}
545
546/* Returns the bridge hello time, in ms. The returned value is not necessarily
547 * the value passed to stp_set_hello_time(): it is clamped to the valid range
548 * and quantized to the STP timer resolution. */
549int
550stp_get_hello_time(const struct stp *stp)
551{
bd54dbcd
EJ
552 int time;
553
554 ovs_mutex_lock(&mutex);
555 time = timer_to_ms(stp->bridge_hello_time);
556 ovs_mutex_unlock(&mutex);
557 return time;
829a7d02
JP
558}
559
560/* Returns the bridge max age, in ms. The returned value is not necessarily
561 * the value passed to stp_set_max_age(): it is clamped to the valid range,
562 * quantized to the STP timer resolution, and adjusted to match the constraints
563 * due to the hello time. */
564int
565stp_get_max_age(const struct stp *stp)
566{
bd54dbcd
EJ
567 int time;
568
569 ovs_mutex_lock(&mutex);
570 time = timer_to_ms(stp->bridge_max_age);
571 ovs_mutex_unlock(&mutex);
572 return time;
829a7d02
JP
573}
574
575/* Returns the bridge forward delay, in ms. The returned value is not
576 * necessarily the value passed to stp_set_forward_delay(): it is clamped to
577 * the valid range, quantized to the STP timer resolution, and adjusted to
578 * match the constraints due to the forward delay. */
579int
580stp_get_forward_delay(const struct stp *stp)
581{
bd54dbcd
EJ
582 int time;
583
584 ovs_mutex_lock(&mutex);
585 time = timer_to_ms(stp->bridge_forward_delay);
586 ovs_mutex_unlock(&mutex);
587 return time;
829a7d02
JP
588}
589
6ae50723
EJ
590/* Returns true if something has happened to 'stp' which necessitates flushing
591 * the client's MAC learning table. Calling this function resets 'stp' so that
592 * future calls will return false until flushing is required again. */
593bool
594stp_check_and_reset_fdb_flush(struct stp *stp)
595{
bd54dbcd
EJ
596 bool needs_flush;
597
598 ovs_mutex_lock(&mutex);
599 needs_flush = stp->fdb_needs_flush;
6ae50723 600 stp->fdb_needs_flush = false;
bd54dbcd 601 ovs_mutex_unlock(&mutex);
6ae50723
EJ
602 return needs_flush;
603}
604
829a7d02
JP
605/* Returns the port in 'stp' with index 'port_no', which must be between 0 and
606 * STP_MAX_PORTS. */
607struct stp_port *
608stp_get_port(struct stp *stp, int port_no)
609{
bd54dbcd
EJ
610 struct stp_port *port;
611
612 ovs_mutex_lock(&mutex);
cb22974d 613 ovs_assert(port_no >= 0 && port_no < ARRAY_SIZE(stp->ports));
bd54dbcd
EJ
614 port = &stp->ports[port_no];
615 ovs_mutex_unlock(&mutex);
616 return port;
829a7d02
JP
617}
618
619/* Returns the port connecting 'stp' to the root bridge, or a null pointer if
620 * there is no such port. */
621struct stp_port *
622stp_get_root_port(struct stp *stp)
623{
bd54dbcd
EJ
624 struct stp_port *port;
625
626 ovs_mutex_lock(&mutex);
627 port = stp->root_port;
628 ovs_mutex_unlock(&mutex);
629 return port;
829a7d02
JP
630}
631
632/* Finds a port whose state has changed. If successful, stores the port whose
633 * state changed in '*portp' and returns true. If no port has changed, stores
634 * NULL in '*portp' and returns false. */
635bool
636stp_get_changed_port(struct stp *stp, struct stp_port **portp)
637{
bd54dbcd
EJ
638 struct stp_port *end, *p;
639 bool changed = false;
829a7d02 640
bd54dbcd
EJ
641 ovs_mutex_lock(&mutex);
642 end = &stp->ports[ARRAY_SIZE(stp->ports)];
829a7d02
JP
643 for (p = stp->first_changed_port; p < end; p++) {
644 if (p->state_changed) {
645 p->state_changed = false;
646 stp->first_changed_port = p + 1;
647 *portp = p;
bd54dbcd
EJ
648 changed = true;
649 goto out;
829a7d02
JP
650 }
651 }
652 stp->first_changed_port = end;
653 *portp = NULL;
bd54dbcd
EJ
654
655out:
656 ovs_mutex_unlock(&mutex);
657 return changed;
829a7d02
JP
658}
659
660/* Returns the name for the given 'state' (for use in debugging and log
661 * messages). */
662const char *
663stp_state_name(enum stp_state state)
664{
665 switch (state) {
666 case STP_DISABLED:
667 return "disabled";
668 case STP_LISTENING:
669 return "listening";
670 case STP_LEARNING:
671 return "learning";
672 case STP_FORWARDING:
673 return "forwarding";
674 case STP_BLOCKING:
675 return "blocking";
676 default:
428b2edd 677 OVS_NOT_REACHED();
829a7d02
JP
678 }
679}
680
681/* Returns true if 'state' is one in which packets received on a port should
682 * be forwarded, false otherwise.
4b5f1996 683 */
829a7d02
JP
684bool
685stp_forward_in_state(enum stp_state state)
686{
4b5f1996 687 return (state & STP_FORWARDING) != 0;
829a7d02
JP
688}
689
690/* Returns true if 'state' is one in which MAC learning should be done on
691 * packets received on a port, false otherwise.
4b5f1996 692 */
829a7d02
JP
693bool
694stp_learn_in_state(enum stp_state state)
695{
4b5f1996 696 return (state & (STP_LEARNING | STP_FORWARDING)) != 0;
829a7d02
JP
697}
698
bacdb85a
AW
699/* Returns true if 'state' is one in which bpdus should be forwarded on a
700 * port, false otherwise.
701 *
702 * Returns true if 'state' is STP_DISABLED, since in that case the port does
703 * not generate the bpdu and should just forward it (e.g. patch port on pif
704 * bridge). */
0d1cee12 705bool
bacdb85a 706stp_should_forward_bpdu(enum stp_state state)
0d1cee12
K
707{
708 return (state &
bacdb85a
AW
709 ( STP_DISABLED | STP_LISTENING | STP_LEARNING
710 | STP_FORWARDING)) != 0;
0d1cee12
K
711}
712
3310b570
JP
713/* Returns the name for the given 'role' (for use in debugging and log
714 * messages). */
715const char *
716stp_role_name(enum stp_role role)
717{
718 switch (role) {
719 case STP_ROLE_ROOT:
720 return "root";
721 case STP_ROLE_DESIGNATED:
722 return "designated";
723 case STP_ROLE_ALTERNATE:
724 return "alternate";
725 case STP_ROLE_DISABLED:
726 return "disabled";
727 default:
428b2edd 728 OVS_NOT_REACHED();
3310b570
JP
729 }
730}
731
829a7d02
JP
732/* Notifies the STP entity that bridge protocol data unit 'bpdu', which is
733 * 'bpdu_size' bytes in length, was received on port 'p'.
734 *
735 * This function may call the 'send_bpdu' function provided to stp_create(). */
736void
737stp_received_bpdu(struct stp_port *p, const void *bpdu, size_t bpdu_size)
738{
739 struct stp *stp = p->stp;
740 const struct stp_bpdu_header *header;
741
bd54dbcd 742 ovs_mutex_lock(&mutex);
829a7d02 743 if (p->state == STP_DISABLED) {
bd54dbcd 744 goto out;
829a7d02
JP
745 }
746
747 if (bpdu_size < sizeof(struct stp_bpdu_header)) {
34582733 748 VLOG_WARN("%s: received runt %"PRIuSIZE"-byte BPDU", stp->name, bpdu_size);
80740385 749 p->error_count++;
bd54dbcd 750 goto out;
829a7d02
JP
751 }
752
753 header = bpdu;
754 if (header->protocol_id != htons(STP_PROTOCOL_ID)) {
755 VLOG_WARN("%s: received BPDU with unexpected protocol ID %"PRIu16,
756 stp->name, ntohs(header->protocol_id));
80740385 757 p->error_count++;
bd54dbcd 758 goto out;
829a7d02
JP
759 }
760 if (header->protocol_version != STP_PROTOCOL_VERSION) {
761 VLOG_DBG("%s: received BPDU with unexpected protocol version %"PRIu8,
762 stp->name, header->protocol_version);
763 }
764
765 switch (header->bpdu_type) {
766 case STP_TYPE_CONFIG:
767 if (bpdu_size < sizeof(struct stp_config_bpdu)) {
34582733 768 VLOG_WARN("%s: received config BPDU with invalid size %"PRIuSIZE,
829a7d02 769 stp->name, bpdu_size);
80740385 770 p->error_count++;
bd54dbcd 771 goto out;
829a7d02
JP
772 }
773 stp_received_config_bpdu(stp, p, bpdu);
774 break;
775
776 case STP_TYPE_TCN:
777 if (bpdu_size != sizeof(struct stp_tcn_bpdu)) {
34582733 778 VLOG_WARN("%s: received TCN BPDU with invalid size %"PRIuSIZE,
829a7d02 779 stp->name, bpdu_size);
80740385 780 p->error_count++;
bd54dbcd 781 goto out;
829a7d02
JP
782 }
783 stp_received_tcn_bpdu(stp, p);
784 break;
785
786 default:
787 VLOG_WARN("%s: received BPDU of unexpected type %"PRIu8,
788 stp->name, header->bpdu_type);
80740385 789 p->error_count++;
bd54dbcd 790 goto out;
829a7d02 791 }
80740385 792 p->rx_count++;
bd54dbcd
EJ
793
794out:
795 ovs_mutex_unlock(&mutex);
829a7d02
JP
796}
797
798/* Returns the STP entity in which 'p' is nested. */
799struct stp *
800stp_port_get_stp(struct stp_port *p)
801{
bd54dbcd
EJ
802 struct stp *stp;
803
804 ovs_mutex_lock(&mutex);
805 stp = p->stp;
806 ovs_mutex_unlock(&mutex);
807 return stp;
829a7d02
JP
808}
809
11306274
AW
810void
811stp_port_set_name(struct stp_port *p, const char *name)
812{
813 char *old;
814
815 ovs_mutex_lock(&mutex);
816 old = p->port_name;
817 p->port_name = xstrdup(name);
818 free(old);
819 ovs_mutex_unlock(&mutex);
820}
821
3310b570
JP
822/* Sets the 'aux' member of 'p'.
823 *
824 * The 'aux' member will be reset to NULL when stp_port_disable() is
825 * called or stp_port_enable() is called when the port is in a Disabled
826 * state. */
827void
828stp_port_set_aux(struct stp_port *p, void *aux)
829{
bd54dbcd 830 ovs_mutex_lock(&mutex);
3310b570 831 p->aux = aux;
bd54dbcd 832 ovs_mutex_unlock(&mutex);
3310b570
JP
833}
834
835/* Returns the 'aux' member of 'p'. */
836void *
837stp_port_get_aux(struct stp_port *p)
838{
bd54dbcd
EJ
839 void *aux;
840
841 ovs_mutex_lock(&mutex);
842 aux = p->aux;
843 ovs_mutex_unlock(&mutex);
844 return aux;
3310b570
JP
845}
846
829a7d02
JP
847/* Returns the index of port 'p' within its bridge. */
848int
849stp_port_no(const struct stp_port *p)
850{
bd54dbcd
EJ
851 struct stp *stp;
852 int index;
853
854 ovs_mutex_lock(&mutex);
855 stp = p->stp;
cb22974d 856 ovs_assert(p >= stp->ports && p < &stp->ports[ARRAY_SIZE(stp->ports)]);
bd54dbcd
EJ
857 index = p - p->stp->ports;
858 ovs_mutex_unlock(&mutex);
859 return index;
829a7d02
JP
860}
861
862/* Returns the state of port 'p'. */
863enum stp_state
864stp_port_get_state(const struct stp_port *p)
865{
bd54dbcd
EJ
866 enum stp_state state;
867
868 ovs_mutex_lock(&mutex);
869 state = p->state;
870 ovs_mutex_unlock(&mutex);
871 return state;
829a7d02
JP
872}
873
3310b570 874/* Returns the role of port 'p'. */
926c9a4a 875static enum stp_role
876stp_port_get_role(const struct stp_port *p) OVS_REQUIRES(mutex)
3310b570 877{
bd54dbcd
EJ
878 struct stp_port *root_port;
879 enum stp_role role;
3310b570 880
bd54dbcd 881 root_port = p->stp->root_port;
3310b570 882 if (root_port && root_port->port_id == p->port_id) {
bd54dbcd 883 role = STP_ROLE_ROOT;
3310b570 884 } else if (stp_is_designated_port(p)) {
bd54dbcd 885 role = STP_ROLE_DESIGNATED;
3310b570 886 } else if (p->state == STP_DISABLED) {
bd54dbcd 887 role = STP_ROLE_DISABLED;
3310b570 888 } else {
bd54dbcd 889 role = STP_ROLE_ALTERNATE;
3310b570 890 }
bd54dbcd 891 return role;
3310b570
JP
892}
893
80740385 894/* Retrieves BPDU transmit and receive counts for 'p'. */
bd54dbcd
EJ
895void
896stp_port_get_counts(const struct stp_port *p,
897 int *tx_count, int *rx_count, int *error_count)
80740385 898{
bd54dbcd 899 ovs_mutex_lock(&mutex);
80740385
JP
900 *tx_count = p->tx_count;
901 *rx_count = p->rx_count;
902 *error_count = p->error_count;
bd54dbcd 903 ovs_mutex_unlock(&mutex);
80740385
JP
904}
905
926c9a4a 906void
907stp_port_get_status(const struct stp_port *p,
908 int *port_id, enum stp_state *state, enum stp_role *role)
909{
910 ovs_mutex_lock(&mutex);
911 *port_id = p->port_id;
912 *state = p->state;
913 *role = stp_port_get_role(p);
914 ovs_mutex_unlock(&mutex);
915}
916
829a7d02
JP
917/* Disables STP on port 'p'. */
918void
919stp_port_disable(struct stp_port *p)
920{
bd54dbcd
EJ
921 struct stp *stp;
922
923 ovs_mutex_lock(&mutex);
924 stp = p->stp;
829a7d02
JP
925 if (p->state != STP_DISABLED) {
926 bool root = stp_is_root_bridge(stp);
927 stp_become_designated_port(p);
928 stp_set_port_state(p, STP_DISABLED);
929 p->topology_change_ack = false;
930 p->config_pending = false;
931 stp_stop_timer(&p->message_age_timer);
932 stp_stop_timer(&p->forward_delay_timer);
933 stp_configuration_update(stp);
934 stp_port_state_selection(stp);
935 if (stp_is_root_bridge(stp) && !root) {
936 stp_become_root_bridge(stp);
937 }
3310b570 938 p->aux = NULL;
829a7d02 939 }
bd54dbcd 940 ovs_mutex_unlock(&mutex);
829a7d02
JP
941}
942
943/* Enables STP on port 'p'. The port will initially be in "blocking" state. */
944void
945stp_port_enable(struct stp_port *p)
946{
bd54dbcd 947 ovs_mutex_lock(&mutex);
829a7d02
JP
948 if (p->state == STP_DISABLED) {
949 stp_initialize_port(p, STP_BLOCKING);
950 stp_port_state_selection(p->stp);
951 }
bd54dbcd 952 ovs_mutex_unlock(&mutex);
829a7d02
JP
953}
954
955/* Sets the priority of port 'p' to 'new_priority'. Lower numerical values
956 * are interpreted as higher priorities. */
957void
958stp_port_set_priority(struct stp_port *p, uint8_t new_priority)
959{
bd54dbcd
EJ
960 uint16_t new_port_id;
961
962 ovs_mutex_lock(&mutex);
963 new_port_id = (p->port_id & 0xff) | (new_priority << 8);
829a7d02
JP
964 if (p->port_id != new_port_id) {
965 struct stp *stp = p->stp;
966 if (stp_is_designated_port(p)) {
967 p->designated_port = new_port_id;
968 }
969 p->port_id = new_port_id;
970 if (stp->bridge_id == p->designated_bridge
971 && p->port_id < p->designated_port) {
972 stp_become_designated_port(p);
973 stp_port_state_selection(stp);
974 }
975 }
bd54dbcd 976 ovs_mutex_unlock(&mutex);
829a7d02
JP
977}
978
3310b570
JP
979/* Convert 'speed' (measured in Mb/s) into the path cost. */
980uint16_t
981stp_convert_speed_to_cost(unsigned int speed)
982{
bd54dbcd
EJ
983 uint16_t ret;
984
985 ovs_mutex_lock(&mutex);
986 ret = speed >= 10000 ? 2 /* 10 Gb/s. */
987 : speed >= 1000 ? 4 /* 1 Gb/s. */
988 : speed >= 100 ? 19 /* 100 Mb/s. */
989 : speed >= 16 ? 62 /* 16 Mb/s. */
990 : speed >= 10 ? 100 /* 10 Mb/s. */
991 : speed >= 4 ? 250 /* 4 Mb/s. */
992 : 19; /* 100 Mb/s (guess). */
993 ovs_mutex_unlock(&mutex);
994 return ret;
3310b570
JP
995}
996
829a7d02
JP
997/* Sets the path cost of port 'p' to 'path_cost'. Lower values are generally
998 * used to indicate faster links. Use stp_port_set_speed() to automatically
999 * generate a default path cost from a link speed. */
1000void
1001stp_port_set_path_cost(struct stp_port *p, uint16_t path_cost)
1002{
bd54dbcd 1003 ovs_mutex_lock(&mutex);
829a7d02
JP
1004 if (p->path_cost != path_cost) {
1005 struct stp *stp = p->stp;
1006 p->path_cost = path_cost;
1007 stp_configuration_update(stp);
1008 stp_port_state_selection(stp);
1009 }
bd54dbcd 1010 ovs_mutex_unlock(&mutex);
829a7d02
JP
1011}
1012
1013/* Sets the path cost of port 'p' based on 'speed' (measured in Mb/s). */
1014void
1015stp_port_set_speed(struct stp_port *p, unsigned int speed)
1016{
3310b570 1017 stp_port_set_path_cost(p, stp_convert_speed_to_cost(speed));
829a7d02
JP
1018}
1019
1020/* Enables topology change detection on port 'p'. */
1021void
1022stp_port_enable_change_detection(struct stp_port *p)
1023{
1024 p->change_detection_enabled = true;
1025}
1026
1027/* Disables topology change detection on port 'p'. */
1028void
1029stp_port_disable_change_detection(struct stp_port *p)
1030{
1031 p->change_detection_enabled = false;
1032}
1033\f
1034static void
bd3950dd 1035stp_transmit_config(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1036{
1037 struct stp *stp = p->stp;
1038 bool root = stp_is_root_bridge(stp);
1039 if (!root && !stp->root_port) {
1040 return;
1041 }
1042 if (p->hold_timer.active) {
11306274
AW
1043 VLOG_DBG_RL(&stp_rl, "bridge: %s, port: %s, transmit config bpdu pending",
1044 stp->name, p->port_name);
829a7d02
JP
1045 p->config_pending = true;
1046 } else {
1047 struct stp_config_bpdu config;
1048 memset(&config, 0, sizeof config);
1049 config.header.protocol_id = htons(STP_PROTOCOL_ID);
1050 config.header.protocol_version = STP_PROTOCOL_VERSION;
1051 config.header.bpdu_type = STP_TYPE_CONFIG;
1052 config.flags = 0;
1053 if (p->topology_change_ack) {
3310b570 1054 config.flags |= STP_CONFIG_TOPOLOGY_CHANGE_ACK;
829a7d02
JP
1055 }
1056 if (stp->topology_change) {
3310b570 1057 config.flags |= STP_CONFIG_TOPOLOGY_CHANGE;
829a7d02
JP
1058 }
1059 config.root_id = htonll(stp->designated_root);
1060 config.root_path_cost = htonl(stp->root_path_cost);
1061 config.bridge_id = htonll(stp->bridge_id);
1062 config.port_id = htons(p->port_id);
1063 if (root) {
1064 config.message_age = htons(0);
1065 } else {
1066 config.message_age = htons(stp->root_port->message_age_timer.value
1067 + MESSAGE_AGE_INCREMENT);
1068 }
1069 config.max_age = htons(stp->max_age);
1070 config.hello_time = htons(stp->hello_time);
1071 config.forward_delay = htons(stp->forward_delay);
1072 if (ntohs(config.message_age) < stp->max_age) {
1073 p->topology_change_ack = false;
1074 p->config_pending = false;
11306274
AW
1075 VLOG_DBG_RL(&stp_rl, "bridge: %s, port: %s, transmit config bpdu",
1076 stp->name, p->port_name);
829a7d02
JP
1077 stp_send_bpdu(p, &config, sizeof config);
1078 stp_start_timer(&p->hold_timer, 0);
1079 }
1080 }
1081}
1082
1083static bool
1084stp_supersedes_port_info(const struct stp_port *p,
1085 const struct stp_config_bpdu *config)
bd3950dd 1086 OVS_REQUIRES(mutex)
829a7d02
JP
1087{
1088 if (ntohll(config->root_id) != p->designated_root) {
1089 return ntohll(config->root_id) < p->designated_root;
1090 } else if (ntohl(config->root_path_cost) != p->designated_cost) {
1091 return ntohl(config->root_path_cost) < p->designated_cost;
1092 } else if (ntohll(config->bridge_id) != p->designated_bridge) {
1093 return ntohll(config->bridge_id) < p->designated_bridge;
1094 } else {
1095 return (ntohll(config->bridge_id) != p->stp->bridge_id
1096 || ntohs(config->port_id) <= p->designated_port);
1097 }
1098}
1099
1100static void
1101stp_record_config_information(struct stp_port *p,
1102 const struct stp_config_bpdu *config)
bd3950dd 1103 OVS_REQUIRES(mutex)
829a7d02
JP
1104{
1105 p->designated_root = ntohll(config->root_id);
1106 p->designated_cost = ntohl(config->root_path_cost);
1107 p->designated_bridge = ntohll(config->bridge_id);
1108 p->designated_port = ntohs(config->port_id);
1109 stp_start_timer(&p->message_age_timer, ntohs(config->message_age));
1110}
1111
1112static void
1113stp_record_config_timeout_values(struct stp *stp,
1114 const struct stp_config_bpdu *config)
bd3950dd 1115 OVS_REQUIRES(mutex)
829a7d02
JP
1116{
1117 stp->max_age = ntohs(config->max_age);
1118 stp->hello_time = ntohs(config->hello_time);
1119 stp->forward_delay = ntohs(config->forward_delay);
3310b570 1120 stp->topology_change = config->flags & STP_CONFIG_TOPOLOGY_CHANGE;
829a7d02
JP
1121}
1122
1123static bool
bd3950dd 1124stp_is_designated_port(const struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1125{
1126 return (p->designated_bridge == p->stp->bridge_id
1127 && p->designated_port == p->port_id);
1128}
1129
1130static void
bd3950dd 1131stp_config_bpdu_generation(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1132{
1133 struct stp_port *p;
1134
1135 FOR_EACH_ENABLED_PORT (p, stp) {
1136 if (stp_is_designated_port(p)) {
1137 stp_transmit_config(p);
1138 }
1139 }
1140}
1141
1142static void
bd3950dd 1143stp_transmit_tcn(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1144{
1145 struct stp_port *p = stp->root_port;
1146 struct stp_tcn_bpdu tcn_bpdu;
11306274 1147
829a7d02
JP
1148 if (!p) {
1149 return;
1150 }
11306274
AW
1151 VLOG_DBG_RL(&stp_rl, "bridge: %s, root port: %s, transmit tcn", stp->name,
1152 p->port_name);
829a7d02
JP
1153 tcn_bpdu.header.protocol_id = htons(STP_PROTOCOL_ID);
1154 tcn_bpdu.header.protocol_version = STP_PROTOCOL_VERSION;
1155 tcn_bpdu.header.bpdu_type = STP_TYPE_TCN;
1156 stp_send_bpdu(p, &tcn_bpdu, sizeof tcn_bpdu);
1157}
1158
1159static void
bd3950dd 1160stp_configuration_update(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1161{
1162 stp_root_selection(stp);
1163 stp_designated_port_selection(stp);
f23d157c 1164 seq_change(connectivity_seq_get());
829a7d02
JP
1165}
1166
1167static bool
1168stp_supersedes_root(const struct stp_port *root, const struct stp_port *p)
bd3950dd 1169 OVS_REQUIRES(mutex)
829a7d02
JP
1170{
1171 int p_cost = p->designated_cost + p->path_cost;
1172 int root_cost = root->designated_cost + root->path_cost;
1173
1174 if (p->designated_root != root->designated_root) {
1175 return p->designated_root < root->designated_root;
1176 } else if (p_cost != root_cost) {
1177 return p_cost < root_cost;
1178 } else if (p->designated_bridge != root->designated_bridge) {
1179 return p->designated_bridge < root->designated_bridge;
1180 } else if (p->designated_port != root->designated_port) {
1181 return p->designated_port < root->designated_port;
1182 } else {
1183 return p->port_id < root->port_id;
1184 }
1185}
1186
1187static void
bd3950dd 1188stp_root_selection(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1189{
1190 struct stp_port *p, *root;
1191
1192 root = NULL;
1193 FOR_EACH_ENABLED_PORT (p, stp) {
1194 if (stp_is_designated_port(p)
1195 || p->designated_root >= stp->bridge_id) {
1196 continue;
1197 }
1198 if (root && !stp_supersedes_root(root, p)) {
1199 continue;
1200 }
1201 root = p;
1202 }
1203 stp->root_port = root;
1204 if (!root) {
1205 stp->designated_root = stp->bridge_id;
1206 stp->root_path_cost = 0;
1207 } else {
1208 stp->designated_root = root->designated_root;
1209 stp->root_path_cost = root->designated_cost + root->path_cost;
1210 }
1211}
1212
1213static void
bd3950dd 1214stp_designated_port_selection(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1215{
1216 struct stp_port *p;
1217
1218 FOR_EACH_ENABLED_PORT (p, stp) {
1219 if (stp_is_designated_port(p)
1220 || p->designated_root != stp->designated_root
1221 || stp->root_path_cost < p->designated_cost
1222 || (stp->root_path_cost == p->designated_cost
1223 && (stp->bridge_id < p->designated_bridge
1224 || (stp->bridge_id == p->designated_bridge
1225 && p->port_id <= p->designated_port))))
1226 {
1227 stp_become_designated_port(p);
1228 }
1229 }
1230}
1231
1232static void
bd3950dd 1233stp_become_designated_port(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1234{
1235 struct stp *stp = p->stp;
1236 p->designated_root = stp->designated_root;
1237 p->designated_cost = stp->root_path_cost;
1238 p->designated_bridge = stp->bridge_id;
1239 p->designated_port = p->port_id;
1240}
1241
1242static void
bd3950dd 1243stp_port_state_selection(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1244{
1245 struct stp_port *p;
1246
1247 FOR_EACH_ENABLED_PORT (p, stp) {
1248 if (p == stp->root_port) {
1249 p->config_pending = false;
1250 p->topology_change_ack = false;
1251 stp_make_forwarding(p);
1252 } else if (stp_is_designated_port(p)) {
1253 stp_stop_timer(&p->message_age_timer);
1254 stp_make_forwarding(p);
1255 } else {
1256 p->config_pending = false;
1257 p->topology_change_ack = false;
1258 stp_make_blocking(p);
1259 }
1260 }
1261}
1262
1263static void
bd3950dd 1264stp_make_forwarding(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1265{
1266 if (p->state == STP_BLOCKING) {
1267 stp_set_port_state(p, STP_LISTENING);
1268 stp_start_timer(&p->forward_delay_timer, 0);
1269 }
1270}
1271
1272static void
bd3950dd 1273stp_make_blocking(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1274{
1275 if (!(p->state & (STP_DISABLED | STP_BLOCKING))) {
1276 if (p->state & (STP_FORWARDING | STP_LEARNING)) {
1277 if (p->change_detection_enabled) {
1278 stp_topology_change_detection(p->stp);
1279 }
1280 }
1281 stp_set_port_state(p, STP_BLOCKING);
1282 stp_stop_timer(&p->forward_delay_timer);
1283 }
1284}
1285
1286static void
1287stp_set_port_state(struct stp_port *p, enum stp_state state)
bd3950dd 1288 OVS_REQUIRES(mutex)
829a7d02
JP
1289{
1290 if (state != p->state && !p->state_changed) {
1291 p->state_changed = true;
1292 if (p < p->stp->first_changed_port) {
1293 p->stp->first_changed_port = p;
1294 }
f23d157c 1295 seq_change(connectivity_seq_get());
829a7d02
JP
1296 }
1297 p->state = state;
1298}
1299
1300static void
bd3950dd 1301stp_topology_change_detection(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02 1302{
634408e0
EJ
1303 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1304
829a7d02
JP
1305 if (stp_is_root_bridge(stp)) {
1306 stp->topology_change = true;
1307 stp_start_timer(&stp->topology_change_timer, 0);
1308 } else if (!stp->topology_change_detected) {
1309 stp_transmit_tcn(stp);
1310 stp_start_timer(&stp->tcn_timer, 0);
1311 }
6ae50723 1312 stp->fdb_needs_flush = true;
829a7d02 1313 stp->topology_change_detected = true;
f23d157c 1314 seq_change(connectivity_seq_get());
634408e0 1315 VLOG_INFO_RL(&rl, "%s: detected topology change.", stp->name);
829a7d02
JP
1316}
1317
1318static void
bd3950dd 1319stp_topology_change_acknowledged(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1320{
1321 stp->topology_change_detected = false;
1322 stp_stop_timer(&stp->tcn_timer);
1323}
1324
1325static void
bd3950dd 1326stp_acknowledge_topology_change(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1327{
1328 p->topology_change_ack = true;
1329 stp_transmit_config(p);
1330}
1331
1332static void
1333stp_received_config_bpdu(struct stp *stp, struct stp_port *p,
1334 const struct stp_config_bpdu *config)
bd3950dd 1335 OVS_REQUIRES(mutex)
829a7d02
JP
1336{
1337 if (ntohs(config->message_age) >= ntohs(config->max_age)) {
1338 VLOG_WARN("%s: received config BPDU with message age (%u) greater "
1339 "than max age (%u)",
1340 stp->name,
1341 ntohs(config->message_age), ntohs(config->max_age));
1342 return;
1343 }
1344 if (p->state != STP_DISABLED) {
1345 bool root = stp_is_root_bridge(stp);
1346 if (stp_supersedes_port_info(p, config)) {
1347 stp_record_config_information(p, config);
1348 stp_configuration_update(stp);
1349 stp_port_state_selection(stp);
1350 if (!stp_is_root_bridge(stp) && root) {
1351 stp_stop_timer(&stp->hello_timer);
1352 if (stp->topology_change_detected) {
1353 stp_stop_timer(&stp->topology_change_timer);
1354 stp_transmit_tcn(stp);
1355 stp_start_timer(&stp->tcn_timer, 0);
1356 }
1357 }
1358 if (p == stp->root_port) {
1359 stp_record_config_timeout_values(stp, config);
1360 stp_config_bpdu_generation(stp);
3310b570 1361 if (config->flags & STP_CONFIG_TOPOLOGY_CHANGE_ACK) {
829a7d02
JP
1362 stp_topology_change_acknowledged(stp);
1363 }
6ae50723
EJ
1364 if (config->flags & STP_CONFIG_TOPOLOGY_CHANGE) {
1365 stp->fdb_needs_flush = true;
1366 }
829a7d02
JP
1367 }
1368 } else if (stp_is_designated_port(p)) {
1369 stp_transmit_config(p);
1370 }
1371 }
1372}
1373
1374static void
1375stp_received_tcn_bpdu(struct stp *stp, struct stp_port *p)
bd3950dd 1376 OVS_REQUIRES(mutex)
829a7d02
JP
1377{
1378 if (p->state != STP_DISABLED) {
1379 if (stp_is_designated_port(p)) {
1380 stp_topology_change_detection(stp);
1381 stp_acknowledge_topology_change(p);
1382 }
1383 }
1384}
1385
1386static void
bd3950dd 1387stp_hello_timer_expiry(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1388{
1389 stp_config_bpdu_generation(stp);
1390 stp_start_timer(&stp->hello_timer, 0);
1391}
1392
1393static void
bd3950dd 1394stp_message_age_timer_expiry(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1395{
1396 struct stp *stp = p->stp;
1397 bool root = stp_is_root_bridge(stp);
11306274
AW
1398
1399 VLOG_DBG_RL(&stp_rl, "bridge: %s, port: %s, message age timer expired",
1400 stp->name, p->port_name);
829a7d02
JP
1401 stp_become_designated_port(p);
1402 stp_configuration_update(stp);
1403 stp_port_state_selection(stp);
1404 if (stp_is_root_bridge(stp) && !root) {
1405 stp->max_age = stp->bridge_max_age;
1406 stp->hello_time = stp->bridge_hello_time;
1407 stp->forward_delay = stp->bridge_forward_delay;
1408 stp_topology_change_detection(stp);
1409 stp_stop_timer(&stp->tcn_timer);
1410 stp_config_bpdu_generation(stp);
1411 stp_start_timer(&stp->hello_timer, 0);
1412 }
1413}
1414
1415static bool
bd3950dd 1416stp_is_designated_for_some_port(const struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1417{
1418 const struct stp_port *p;
1419
1420 FOR_EACH_ENABLED_PORT (p, stp) {
1421 if (p->designated_bridge == stp->bridge_id) {
1422 return true;
1423 }
1424 }
1425 return false;
1426}
1427
1428static void
bd3950dd 1429stp_forward_delay_timer_expiry(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1430{
1431 if (p->state == STP_LISTENING) {
1432 stp_set_port_state(p, STP_LEARNING);
1433 stp_start_timer(&p->forward_delay_timer, 0);
1434 } else if (p->state == STP_LEARNING) {
1435 stp_set_port_state(p, STP_FORWARDING);
1436 if (stp_is_designated_for_some_port(p->stp)) {
1437 if (p->change_detection_enabled) {
1438 stp_topology_change_detection(p->stp);
1439 }
1440 }
1441 }
1442}
1443
1444static void
bd3950dd 1445stp_tcn_timer_expiry(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1446{
1447 stp_transmit_tcn(stp);
1448 stp_start_timer(&stp->tcn_timer, 0);
1449}
1450
1451static void
bd3950dd 1452stp_topology_change_timer_expiry(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1453{
1454 stp->topology_change_detected = false;
1455 stp->topology_change = false;
1456}
1457
1458static void
bd3950dd 1459stp_hold_timer_expiry(struct stp_port *p) OVS_REQUIRES(mutex)
829a7d02
JP
1460{
1461 if (p->config_pending) {
1462 stp_transmit_config(p);
1463 }
1464}
1465
1466static void
1467stp_initialize_port(struct stp_port *p, enum stp_state state)
bd3950dd 1468 OVS_REQUIRES(mutex)
829a7d02 1469{
cb22974d 1470 ovs_assert(state & (STP_DISABLED | STP_BLOCKING));
829a7d02 1471 stp_become_designated_port(p);
fb20b0bf
JR
1472
1473 if (!p->state && state == STP_DISABLED) {
1474 p->state = state; /* Do not trigger state change when initializing. */
1475 } else {
1476 stp_set_port_state(p, state);
1477 }
829a7d02
JP
1478 p->topology_change_ack = false;
1479 p->config_pending = false;
1480 p->change_detection_enabled = true;
3310b570 1481 p->aux = NULL;
829a7d02
JP
1482 stp_stop_timer(&p->message_age_timer);
1483 stp_stop_timer(&p->forward_delay_timer);
1484 stp_stop_timer(&p->hold_timer);
80740385 1485 p->tx_count = p->rx_count = p->error_count = 0;
829a7d02
JP
1486}
1487
1488static void
bd3950dd 1489stp_become_root_bridge(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1490{
1491 stp->max_age = stp->bridge_max_age;
1492 stp->hello_time = stp->bridge_hello_time;
1493 stp->forward_delay = stp->bridge_forward_delay;
1494 stp_topology_change_detection(stp);
1495 stp_stop_timer(&stp->tcn_timer);
1496 stp_config_bpdu_generation(stp);
1497 stp_start_timer(&stp->hello_timer, 0);
1498}
1499
1500static void
bd3950dd 1501stp_start_timer(struct stp_timer *timer, int value) OVS_REQUIRES(mutex)
829a7d02
JP
1502{
1503 timer->value = value;
1504 timer->active = true;
1505}
1506
1507static void
bd3950dd 1508stp_stop_timer(struct stp_timer *timer) OVS_REQUIRES(mutex)
829a7d02
JP
1509{
1510 timer->active = false;
1511}
1512
1513static bool
1514stp_timer_expired(struct stp_timer *timer, int elapsed, int timeout)
bd3950dd 1515 OVS_REQUIRES(mutex)
829a7d02
JP
1516{
1517 if (timer->active) {
1518 timer->value += elapsed;
1519 if (timer->value >= timeout) {
1520 timer->active = false;
1521 return true;
1522 }
1523 }
1524 return false;
1525}
1526
1527/* Returns the number of whole STP timer ticks in 'ms' milliseconds. There
1528 * are 256 STP timer ticks per second. */
1529static int
1530ms_to_timer(int ms)
1531{
1532 return ms * 0x100 / 1000;
1533}
1534
829a7d02
JP
1535/* Returns the number of whole milliseconds in 'timer' STP timer ticks. There
1536 * are 256 STP timer ticks per second. */
1537static int
1538timer_to_ms(int timer)
1539{
1540 return timer * 1000 / 0x100;
1541}
1542
1543static int
1544clamp(int x, int min, int max)
1545{
1546 return x < min ? min : x > max ? max : x;
1547}
1548
1549static void
bd3950dd 1550stp_update_bridge_timers(struct stp *stp) OVS_REQUIRES(mutex)
829a7d02
JP
1551{
1552 int ht, ma, fd;
1553
1554 ht = clamp(stp->rq_hello_time, 1000, 10000);
1555 ma = clamp(stp->rq_max_age, MAX(2 * (ht + 1000), 6000), 40000);
1556 fd = clamp(stp->rq_forward_delay, ma / 2 + 1000, 30000);
1557
1558 stp->bridge_hello_time = ms_to_timer(ht);
1559 stp->bridge_max_age = ms_to_timer(ma);
1560 stp->bridge_forward_delay = ms_to_timer(fd);
1561
1562 if (stp_is_root_bridge(stp)) {
1563 stp->max_age = stp->bridge_max_age;
1564 stp->hello_time = stp->bridge_hello_time;
1565 stp->forward_delay = stp->bridge_forward_delay;
1566 }
1567}
1568
1569static void
1570stp_send_bpdu(struct stp_port *p, const void *bpdu, size_t bpdu_size)
bd3950dd 1571 OVS_REQUIRES(mutex)
829a7d02
JP
1572{
1573 struct eth_header *eth;
1574 struct llc_header *llc;
cf62fa4c 1575 struct dp_packet *pkt;
829a7d02
JP
1576
1577 /* Skeleton. */
cf62fa4c
PS
1578 pkt = dp_packet_new(ETH_HEADER_LEN + LLC_HEADER_LEN + bpdu_size);
1579 eth = dp_packet_put_zeros(pkt, sizeof *eth);
1580 llc = dp_packet_put_zeros(pkt, sizeof *llc);
82eb5b0a 1581 dp_packet_reset_offsets(pkt);
cf62fa4c 1582 dp_packet_set_l3(pkt, dp_packet_put(pkt, bpdu, bpdu_size));
829a7d02
JP
1583
1584 /* 802.2 header. */
74ff3298 1585 eth->eth_dst = eth_addr_stp;
829a7d02 1586 /* p->stp->send_bpdu() must fill in source address. */
cf62fa4c 1587 eth->eth_type = htons(dp_packet_size(pkt) - ETH_HEADER_LEN);
829a7d02
JP
1588
1589 /* LLC header. */
1590 llc->llc_dsap = STP_LLC_DSAP;
1591 llc->llc_ssap = STP_LLC_SSAP;
1592 llc->llc_cntl = STP_LLC_CNTL;
1593
1594 p->stp->send_bpdu(pkt, stp_port_no(p), p->stp->aux);
80740385 1595 p->tx_count++;
829a7d02 1596}
fe4a02e4
EJ
1597\f
1598/* Unixctl. */
1599
1600static struct stp *
bd3950dd 1601stp_find(const char *name) OVS_REQUIRES(mutex)
fe4a02e4
EJ
1602{
1603 struct stp *stp;
1604
bd54dbcd 1605 LIST_FOR_EACH (stp, node, all_stps) {
fe4a02e4
EJ
1606 if (!strcmp(stp->name, name)) {
1607 return stp;
1608 }
1609 }
1610 return NULL;
1611}
1612
1613static void
1614stp_unixctl_tcn(struct unixctl_conn *conn, int argc,
1615 const char *argv[], void *aux OVS_UNUSED)
1616{
bd54dbcd 1617 ovs_mutex_lock(&mutex);
fe4a02e4
EJ
1618 if (argc > 1) {
1619 struct stp *stp = stp_find(argv[1]);
1620
1621 if (!stp) {
bde9f75d 1622 unixctl_command_reply_error(conn, "no such stp object");
bd54dbcd 1623 goto out;
fe4a02e4
EJ
1624 }
1625 stp_topology_change_detection(stp);
1626 } else {
1627 struct stp *stp;
1628
bd54dbcd 1629 LIST_FOR_EACH (stp, node, all_stps) {
fe4a02e4
EJ
1630 stp_topology_change_detection(stp);
1631 }
1632 }
1633
bde9f75d 1634 unixctl_command_reply(conn, "OK");
bd54dbcd
EJ
1635
1636out:
1637 ovs_mutex_unlock(&mutex);
fe4a02e4 1638}
5f206eb6 1639
1640static void
1641stp_bridge_id_details(struct ds *ds, const stp_identifier bridge_id,
1642 const int hello_time, const int max_age,
1643 const int forward_delay)
1644 OVS_REQUIRES(mutex)
1645{
1646 uint16_t priority = bridge_id >> 48;
aa141053 1647 ds_put_format(ds, " stp-priority %"PRIu16"\n", priority);
5f206eb6 1648
1649 struct eth_addr mac;
1650 const uint64_t mac_bits = (UINT64_C(1) << 48) - 1;
1651 eth_addr_from_uint64(bridge_id & mac_bits, &mac);
aa141053
BP
1652 ds_put_format(ds, " stp-system-id "ETH_ADDR_FMT"\n",
1653 ETH_ADDR_ARGS(mac));
1654 ds_put_format(ds, " stp-hello-time %ds\n",
5f206eb6 1655 timer_to_ms(hello_time) / 1000);
aa141053
BP
1656 ds_put_format(ds, " stp-max-age %ds\n", timer_to_ms(max_age) / 1000);
1657 ds_put_format(ds, " stp-fwd-delay %ds\n",
5f206eb6 1658 timer_to_ms(forward_delay) / 1000);
1659}
1660
1661static void
1662stp_print_details(struct ds *ds, const struct stp *stp)
1663 OVS_REQUIRES(mutex)
1664{
1665 const uint16_t port_no_bits = (UINT16_C(1) << 8) - 1;
1666
1667 ds_put_format(ds, "---- %s ----\n", stp->name);
1668 ds_put_cstr(ds, "Root ID:\n");
1669
1670 stp_bridge_id_details(ds, stp->designated_root, stp->bridge_hello_time,
1671 stp->bridge_max_age, stp->bridge_forward_delay);
1672
1673 if (stp_is_root_bridge(stp)) {
aa141053 1674 ds_put_cstr(ds, " This bridge is the root\n");
5f206eb6 1675 } else {
aa141053
BP
1676 ds_put_format(ds, " root-port %s\n", stp->root_port->port_name);
1677 ds_put_format(ds, " root-path-cost %u\n", stp->root_path_cost);
5f206eb6 1678 }
1679
1680 ds_put_cstr(ds, "\n");
1681
1682 ds_put_cstr(ds, "Bridge ID:\n");
1683 stp_bridge_id_details(ds, stp->bridge_id, stp->hello_time,
1684 stp->max_age, stp->forward_delay);
1685
1686 ds_put_cstr(ds, "\n");
1687
1688 const struct stp_port *p;
aa141053 1689 ds_put_format(ds, " %-11.10s%-11.10s%-11.10s%-6.5s%-8.7s\n",
5f206eb6 1690 "Interface", "Role", "State", "Cost", "Pri.Nbr");
aa141053 1691 ds_put_cstr(ds, " ---------- ---------- ---------- ----- -------\n");
5f206eb6 1692 FOR_EACH_ENABLED_PORT (p, stp) {
aa141053 1693 ds_put_format(ds, " %-11.10s", p->port_name);
5f206eb6 1694 ds_put_format(ds, "%-11.10s", stp_role_name(stp_port_get_role(p)));
1695 ds_put_format(ds, "%-11.10s", stp_state_name(p->state));
1696 ds_put_format(ds, "%-6d", p->path_cost);
1697 ds_put_format(ds, "%d.%d\n", p->port_id >> 8,
1698 p->port_id & port_no_bits);
1699 }
1700
1701 ds_put_cstr(ds, "\n");
1702}
1703
1704static void
1705stp_unixctl_show(struct unixctl_conn *conn, int argc,
1706 const char *argv[], void *aux OVS_UNUSED)
1707{
1708 struct ds ds = DS_EMPTY_INITIALIZER;
1709
1710 ovs_mutex_lock(&mutex);
1711 if (argc > 1) {
1712 struct stp *stp = stp_find(argv[1]);
1713
1714 if (!stp) {
1715 unixctl_command_reply_error(conn, "no such stp object");
1716 goto out;
1717 }
1718
1719 stp_print_details(&ds, stp);
1720 } else {
1721 struct stp *stp;
1722
1723 LIST_FOR_EACH (stp, node, all_stps) {
1724 stp_print_details(&ds, stp);
1725 }
1726 }
1727
1728 unixctl_command_reply(conn, ds_cstr(&ds));
1729 ds_destroy(&ds);
1730
1731out:
1732 ovs_mutex_unlock(&mutex);
1733}