]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/blame - mm/mremap.c
RDMA/nes: Slight optimization of Ethernet address compare
[mirror_ubuntu-zesty-kernel.git] / mm / mremap.c
CommitLineData
1da177e4
LT
1/*
2 * mm/mremap.c
3 *
4 * (C) Copyright 1996 Linus Torvalds
5 *
046c6884 6 * Address space accounting code <alan@lxorguk.ukuu.org.uk>
1da177e4
LT
7 * (C) Copyright 2002 Red Hat Inc, All Rights Reserved
8 */
9
10#include <linux/mm.h>
11#include <linux/hugetlb.h>
1da177e4 12#include <linux/shm.h>
1ff82995 13#include <linux/ksm.h>
1da177e4
LT
14#include <linux/mman.h>
15#include <linux/swap.h>
c59ede7b 16#include <linux/capability.h>
1da177e4 17#include <linux/fs.h>
6dec97dc 18#include <linux/swapops.h>
1da177e4
LT
19#include <linux/highmem.h>
20#include <linux/security.h>
21#include <linux/syscalls.h>
cddb8a5c 22#include <linux/mmu_notifier.h>
cf4aebc2 23#include <linux/sched/sysctl.h>
1da177e4
LT
24
25#include <asm/uaccess.h>
26#include <asm/cacheflush.h>
27#include <asm/tlbflush.h>
28
ba470de4
RR
29#include "internal.h"
30
7be7a546 31static pmd_t *get_old_pmd(struct mm_struct *mm, unsigned long addr)
1da177e4
LT
32{
33 pgd_t *pgd;
34 pud_t *pud;
35 pmd_t *pmd;
36
37 pgd = pgd_offset(mm, addr);
38 if (pgd_none_or_clear_bad(pgd))
39 return NULL;
40
41 pud = pud_offset(pgd, addr);
42 if (pud_none_or_clear_bad(pud))
43 return NULL;
44
45 pmd = pmd_offset(pud, addr);
37a1c49a 46 if (pmd_none(*pmd))
1da177e4
LT
47 return NULL;
48
7be7a546 49 return pmd;
1da177e4
LT
50}
51
8ac1f832
AA
52static pmd_t *alloc_new_pmd(struct mm_struct *mm, struct vm_area_struct *vma,
53 unsigned long addr)
1da177e4
LT
54{
55 pgd_t *pgd;
56 pud_t *pud;
c74df32c 57 pmd_t *pmd;
1da177e4
LT
58
59 pgd = pgd_offset(mm, addr);
1da177e4
LT
60 pud = pud_alloc(mm, pgd, addr);
61 if (!pud)
c74df32c 62 return NULL;
7be7a546 63
1da177e4 64 pmd = pmd_alloc(mm, pud, addr);
57a8f0cd 65 if (!pmd)
c74df32c 66 return NULL;
7be7a546 67
8ac1f832 68 VM_BUG_ON(pmd_trans_huge(*pmd));
c74df32c 69
7be7a546 70 return pmd;
1da177e4
LT
71}
72
6dec97dc
CG
73static pte_t move_soft_dirty_pte(pte_t pte)
74{
75 /*
76 * Set soft dirty bit so we can notice
77 * in userspace the ptes were moved.
78 */
79#ifdef CONFIG_MEM_SOFT_DIRTY
80 if (pte_present(pte))
81 pte = pte_mksoft_dirty(pte);
82 else if (is_swap_pte(pte))
83 pte = pte_swp_mksoft_dirty(pte);
84 else if (pte_file(pte))
85 pte = pte_file_mksoft_dirty(pte);
86#endif
87 return pte;
88}
89
7be7a546
HD
90static void move_ptes(struct vm_area_struct *vma, pmd_t *old_pmd,
91 unsigned long old_addr, unsigned long old_end,
92 struct vm_area_struct *new_vma, pmd_t *new_pmd,
38a76013 93 unsigned long new_addr, bool need_rmap_locks)
1da177e4
LT
94{
95 struct address_space *mapping = NULL;
38a76013 96 struct anon_vma *anon_vma = NULL;
1da177e4 97 struct mm_struct *mm = vma->vm_mm;
7be7a546 98 pte_t *old_pte, *new_pte, pte;
4c21e2f2 99 spinlock_t *old_ptl, *new_ptl;
1da177e4 100
38a76013
ML
101 /*
102 * When need_rmap_locks is true, we take the i_mmap_mutex and anon_vma
103 * locks to ensure that rmap will always observe either the old or the
104 * new ptes. This is the easiest way to avoid races with
105 * truncate_pagecache(), page migration, etc...
106 *
107 * When need_rmap_locks is false, we use other ways to avoid
108 * such races:
109 *
110 * - During exec() shift_arg_pages(), we use a specially tagged vma
111 * which rmap call sites look for using is_vma_temporary_stack().
112 *
113 * - During mremap(), new_vma is often known to be placed after vma
114 * in rmap traversal order. This ensures rmap will always observe
115 * either the old pte, or the new pte, or both (the page table locks
116 * serialize access to individual ptes, but only rmap traversal
117 * order guarantees that we won't miss both the old and new ptes).
118 */
119 if (need_rmap_locks) {
120 if (vma->vm_file) {
121 mapping = vma->vm_file->f_mapping;
122 mutex_lock(&mapping->i_mmap_mutex);
123 }
124 if (vma->anon_vma) {
125 anon_vma = vma->anon_vma;
4fc3f1d6 126 anon_vma_lock_write(anon_vma);
38a76013 127 }
1da177e4 128 }
1da177e4 129
4c21e2f2
HD
130 /*
131 * We don't have to worry about the ordering of src and dst
132 * pte locks because exclusive mmap_sem prevents deadlock.
133 */
c74df32c 134 old_pte = pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl);
ece0e2b6 135 new_pte = pte_offset_map(new_pmd, new_addr);
4c21e2f2
HD
136 new_ptl = pte_lockptr(mm, new_pmd);
137 if (new_ptl != old_ptl)
f20dc5f7 138 spin_lock_nested(new_ptl, SINGLE_DEPTH_NESTING);
6606c3e0 139 arch_enter_lazy_mmu_mode();
7be7a546
HD
140
141 for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE,
142 new_pte++, new_addr += PAGE_SIZE) {
143 if (pte_none(*old_pte))
144 continue;
7b6efc2b 145 pte = ptep_get_and_clear(mm, old_addr, old_pte);
7be7a546 146 pte = move_pte(pte, new_vma->vm_page_prot, old_addr, new_addr);
6dec97dc
CG
147 pte = move_soft_dirty_pte(pte);
148 set_pte_at(mm, new_addr, new_pte, pte);
1da177e4 149 }
7be7a546 150
6606c3e0 151 arch_leave_lazy_mmu_mode();
4c21e2f2
HD
152 if (new_ptl != old_ptl)
153 spin_unlock(new_ptl);
ece0e2b6 154 pte_unmap(new_pte - 1);
c74df32c 155 pte_unmap_unlock(old_pte - 1, old_ptl);
108d6642 156 if (anon_vma)
08b52706 157 anon_vma_unlock_write(anon_vma);
1da177e4 158 if (mapping)
3d48ae45 159 mutex_unlock(&mapping->i_mmap_mutex);
1da177e4
LT
160}
161
7be7a546
HD
162#define LATENCY_LIMIT (64 * PAGE_SIZE)
163
b6a2fea3 164unsigned long move_page_tables(struct vm_area_struct *vma,
1da177e4 165 unsigned long old_addr, struct vm_area_struct *new_vma,
38a76013
ML
166 unsigned long new_addr, unsigned long len,
167 bool need_rmap_locks)
1da177e4 168{
7be7a546
HD
169 unsigned long extent, next, old_end;
170 pmd_t *old_pmd, *new_pmd;
7b6efc2b 171 bool need_flush = false;
2ec74c3e
SG
172 unsigned long mmun_start; /* For mmu_notifiers */
173 unsigned long mmun_end; /* For mmu_notifiers */
1da177e4 174
7be7a546
HD
175 old_end = old_addr + len;
176 flush_cache_range(vma, old_addr, old_end);
1da177e4 177
2ec74c3e
SG
178 mmun_start = old_addr;
179 mmun_end = old_end;
180 mmu_notifier_invalidate_range_start(vma->vm_mm, mmun_start, mmun_end);
7b6efc2b 181
7be7a546 182 for (; old_addr < old_end; old_addr += extent, new_addr += extent) {
1da177e4 183 cond_resched();
7be7a546 184 next = (old_addr + PMD_SIZE) & PMD_MASK;
ebed4846 185 /* even if next overflowed, extent below will be ok */
7be7a546 186 extent = next - old_addr;
ebed4846
AA
187 if (extent > old_end - old_addr)
188 extent = old_end - old_addr;
7be7a546
HD
189 old_pmd = get_old_pmd(vma->vm_mm, old_addr);
190 if (!old_pmd)
191 continue;
8ac1f832 192 new_pmd = alloc_new_pmd(vma->vm_mm, vma, new_addr);
7be7a546
HD
193 if (!new_pmd)
194 break;
37a1c49a
AA
195 if (pmd_trans_huge(*old_pmd)) {
196 int err = 0;
197 if (extent == HPAGE_PMD_SIZE)
198 err = move_huge_pmd(vma, new_vma, old_addr,
199 new_addr, old_end,
200 old_pmd, new_pmd);
201 if (err > 0) {
202 need_flush = true;
203 continue;
204 } else if (!err) {
e180377f 205 split_huge_page_pmd(vma, old_addr, old_pmd);
37a1c49a
AA
206 }
207 VM_BUG_ON(pmd_trans_huge(*old_pmd));
208 }
209 if (pmd_none(*new_pmd) && __pte_alloc(new_vma->vm_mm, new_vma,
210 new_pmd, new_addr))
211 break;
7be7a546
HD
212 next = (new_addr + PMD_SIZE) & PMD_MASK;
213 if (extent > next - new_addr)
214 extent = next - new_addr;
215 if (extent > LATENCY_LIMIT)
216 extent = LATENCY_LIMIT;
217 move_ptes(vma, old_pmd, old_addr, old_addr + extent,
38a76013 218 new_vma, new_pmd, new_addr, need_rmap_locks);
7b6efc2b 219 need_flush = true;
1da177e4 220 }
7b6efc2b
AA
221 if (likely(need_flush))
222 flush_tlb_range(vma, old_end-len, old_addr);
223
2ec74c3e 224 mmu_notifier_invalidate_range_end(vma->vm_mm, mmun_start, mmun_end);
7be7a546
HD
225
226 return len + old_addr - old_end; /* how much done */
1da177e4
LT
227}
228
229static unsigned long move_vma(struct vm_area_struct *vma,
230 unsigned long old_addr, unsigned long old_len,
81909b84 231 unsigned long new_len, unsigned long new_addr, bool *locked)
1da177e4
LT
232{
233 struct mm_struct *mm = vma->vm_mm;
234 struct vm_area_struct *new_vma;
235 unsigned long vm_flags = vma->vm_flags;
236 unsigned long new_pgoff;
237 unsigned long moved_len;
238 unsigned long excess = 0;
365e9c87 239 unsigned long hiwater_vm;
1da177e4 240 int split = 0;
7103ad32 241 int err;
38a76013 242 bool need_rmap_locks;
1da177e4
LT
243
244 /*
245 * We'd prefer to avoid failure later on in do_munmap:
246 * which may split one vma into three before unmapping.
247 */
248 if (mm->map_count >= sysctl_max_map_count - 3)
249 return -ENOMEM;
250
1ff82995
HD
251 /*
252 * Advise KSM to break any KSM pages in the area to be moved:
253 * it would be confusing if they were to turn up at the new
254 * location, where they happen to coincide with different KSM
255 * pages recently unmapped. But leave vma->vm_flags as it was,
256 * so KSM can come around to merge on vma and new_vma afterwards.
257 */
7103ad32
HD
258 err = ksm_madvise(vma, old_addr, old_addr + old_len,
259 MADV_UNMERGEABLE, &vm_flags);
260 if (err)
261 return err;
1ff82995 262
1da177e4 263 new_pgoff = vma->vm_pgoff + ((old_addr - vma->vm_start) >> PAGE_SHIFT);
38a76013
ML
264 new_vma = copy_vma(&vma, new_addr, new_len, new_pgoff,
265 &need_rmap_locks);
1da177e4
LT
266 if (!new_vma)
267 return -ENOMEM;
268
38a76013
ML
269 moved_len = move_page_tables(vma, old_addr, new_vma, new_addr, old_len,
270 need_rmap_locks);
1da177e4
LT
271 if (moved_len < old_len) {
272 /*
273 * On error, move entries back from new area to old,
274 * which will succeed since page tables still there,
275 * and then proceed to unmap new area instead of old.
276 */
38a76013
ML
277 move_page_tables(new_vma, new_addr, vma, old_addr, moved_len,
278 true);
1da177e4
LT
279 vma = new_vma;
280 old_len = new_len;
281 old_addr = new_addr;
282 new_addr = -ENOMEM;
283 }
284
285 /* Conceal VM_ACCOUNT so old reservation is not undone */
286 if (vm_flags & VM_ACCOUNT) {
287 vma->vm_flags &= ~VM_ACCOUNT;
288 excess = vma->vm_end - vma->vm_start - old_len;
289 if (old_addr > vma->vm_start &&
290 old_addr + old_len < vma->vm_end)
291 split = 1;
292 }
293
71799062 294 /*
365e9c87
HD
295 * If we failed to move page tables we still do total_vm increment
296 * since do_munmap() will decrement it by old_len == new_len.
297 *
298 * Since total_vm is about to be raised artificially high for a
299 * moment, we need to restore high watermark afterwards: if stats
300 * are taken meanwhile, total_vm and hiwater_vm appear too high.
301 * If this were a serious issue, we'd add a flag to do_munmap().
71799062 302 */
365e9c87 303 hiwater_vm = mm->hiwater_vm;
ab50b8ed 304 vm_stat_account(mm, vma->vm_flags, vma->vm_file, new_len>>PAGE_SHIFT);
71799062 305
1da177e4
LT
306 if (do_munmap(mm, old_addr, old_len) < 0) {
307 /* OOM: unable to split vma, just get accounts right */
308 vm_unacct_memory(excess >> PAGE_SHIFT);
309 excess = 0;
310 }
365e9c87 311 mm->hiwater_vm = hiwater_vm;
1da177e4
LT
312
313 /* Restore VM_ACCOUNT if one or two pieces of vma left */
314 if (excess) {
315 vma->vm_flags |= VM_ACCOUNT;
316 if (split)
317 vma->vm_next->vm_flags |= VM_ACCOUNT;
318 }
319
1da177e4
LT
320 if (vm_flags & VM_LOCKED) {
321 mm->locked_vm += new_len >> PAGE_SHIFT;
81909b84 322 *locked = true;
1da177e4
LT
323 }
324
325 return new_addr;
326}
327
54f5de70
AV
328static struct vm_area_struct *vma_to_resize(unsigned long addr,
329 unsigned long old_len, unsigned long new_len, unsigned long *p)
330{
331 struct mm_struct *mm = current->mm;
332 struct vm_area_struct *vma = find_vma(mm, addr);
333
334 if (!vma || vma->vm_start > addr)
335 goto Efault;
336
337 if (is_vm_hugetlb_page(vma))
338 goto Einval;
339
340 /* We can't remap across vm area boundaries */
341 if (old_len > vma->vm_end - addr)
342 goto Efault;
343
982134ba
LT
344 /* Need to be careful about a growing mapping */
345 if (new_len > old_len) {
346 unsigned long pgoff;
347
348 if (vma->vm_flags & (VM_DONTEXPAND | VM_PFNMAP))
54f5de70 349 goto Efault;
982134ba
LT
350 pgoff = (addr - vma->vm_start) >> PAGE_SHIFT;
351 pgoff += vma->vm_pgoff;
352 if (pgoff + (new_len >> PAGE_SHIFT) < pgoff)
353 goto Einval;
54f5de70
AV
354 }
355
356 if (vma->vm_flags & VM_LOCKED) {
357 unsigned long locked, lock_limit;
358 locked = mm->locked_vm << PAGE_SHIFT;
59e99e5b 359 lock_limit = rlimit(RLIMIT_MEMLOCK);
54f5de70
AV
360 locked += new_len - old_len;
361 if (locked > lock_limit && !capable(CAP_IPC_LOCK))
362 goto Eagain;
363 }
364
365 if (!may_expand_vm(mm, (new_len - old_len) >> PAGE_SHIFT))
366 goto Enomem;
367
368 if (vma->vm_flags & VM_ACCOUNT) {
369 unsigned long charged = (new_len - old_len) >> PAGE_SHIFT;
191c5424 370 if (security_vm_enough_memory_mm(mm, charged))
54f5de70
AV
371 goto Efault;
372 *p = charged;
373 }
374
375 return vma;
376
377Efault: /* very odd choice for most of the cases, but... */
378 return ERR_PTR(-EFAULT);
379Einval:
380 return ERR_PTR(-EINVAL);
381Enomem:
382 return ERR_PTR(-ENOMEM);
383Eagain:
384 return ERR_PTR(-EAGAIN);
385}
386
81909b84
ML
387static unsigned long mremap_to(unsigned long addr, unsigned long old_len,
388 unsigned long new_addr, unsigned long new_len, bool *locked)
ecc1a899
AV
389{
390 struct mm_struct *mm = current->mm;
391 struct vm_area_struct *vma;
392 unsigned long ret = -EINVAL;
393 unsigned long charged = 0;
097eed10 394 unsigned long map_flags;
ecc1a899
AV
395
396 if (new_addr & ~PAGE_MASK)
397 goto out;
398
399 if (new_len > TASK_SIZE || new_addr > TASK_SIZE - new_len)
400 goto out;
401
402 /* Check if the location we're moving into overlaps the
403 * old location at all, and fail if it does.
404 */
405 if ((new_addr <= addr) && (new_addr+new_len) > addr)
406 goto out;
407
408 if ((addr <= new_addr) && (addr+old_len) > new_addr)
409 goto out;
410
ecc1a899
AV
411 ret = do_munmap(mm, new_addr, new_len);
412 if (ret)
413 goto out;
414
415 if (old_len >= new_len) {
416 ret = do_munmap(mm, addr+new_len, old_len - new_len);
417 if (ret && old_len != new_len)
418 goto out;
419 old_len = new_len;
420 }
421
422 vma = vma_to_resize(addr, old_len, new_len, &charged);
423 if (IS_ERR(vma)) {
424 ret = PTR_ERR(vma);
425 goto out;
426 }
427
097eed10
AV
428 map_flags = MAP_FIXED;
429 if (vma->vm_flags & VM_MAYSHARE)
430 map_flags |= MAP_SHARED;
9206de95 431
097eed10
AV
432 ret = get_unmapped_area(vma->vm_file, new_addr, new_len, vma->vm_pgoff +
433 ((addr - vma->vm_start) >> PAGE_SHIFT),
434 map_flags);
ecc1a899 435 if (ret & ~PAGE_MASK)
097eed10
AV
436 goto out1;
437
81909b84 438 ret = move_vma(vma, addr, old_len, new_len, new_addr, locked);
097eed10
AV
439 if (!(ret & ~PAGE_MASK))
440 goto out;
441out1:
442 vm_unacct_memory(charged);
ecc1a899
AV
443
444out:
445 return ret;
446}
447
1a0ef85f
AV
448static int vma_expandable(struct vm_area_struct *vma, unsigned long delta)
449{
f106af4e 450 unsigned long end = vma->vm_end + delta;
9206de95 451 if (end < vma->vm_end) /* overflow */
f106af4e 452 return 0;
9206de95 453 if (vma->vm_next && vma->vm_next->vm_start < end) /* intersection */
f106af4e
AV
454 return 0;
455 if (get_unmapped_area(NULL, vma->vm_start, end - vma->vm_start,
456 0, MAP_FIXED) & ~PAGE_MASK)
1a0ef85f 457 return 0;
1a0ef85f
AV
458 return 1;
459}
460
1da177e4
LT
461/*
462 * Expand (or shrink) an existing mapping, potentially moving it at the
463 * same time (controlled by the MREMAP_MAYMOVE flag and available VM space)
464 *
465 * MREMAP_FIXED option added 5-Dec-1999 by Benjamin LaHaise
466 * This option implies MREMAP_MAYMOVE.
467 */
63a81db1
AV
468SYSCALL_DEFINE5(mremap, unsigned long, addr, unsigned long, old_len,
469 unsigned long, new_len, unsigned long, flags,
470 unsigned long, new_addr)
1da177e4 471{
d0de32d9 472 struct mm_struct *mm = current->mm;
1da177e4
LT
473 struct vm_area_struct *vma;
474 unsigned long ret = -EINVAL;
475 unsigned long charged = 0;
81909b84 476 bool locked = false;
1da177e4
LT
477
478 if (flags & ~(MREMAP_FIXED | MREMAP_MAYMOVE))
9a2458a6
RV
479 return ret;
480
481 if (flags & MREMAP_FIXED && !(flags & MREMAP_MAYMOVE))
482 return ret;
1da177e4
LT
483
484 if (addr & ~PAGE_MASK)
9a2458a6 485 return ret;
1da177e4
LT
486
487 old_len = PAGE_ALIGN(old_len);
488 new_len = PAGE_ALIGN(new_len);
489
490 /*
491 * We allow a zero old-len as a special case
492 * for DOS-emu "duplicate shm area" thing. But
493 * a zero new-len is nonsensical.
494 */
495 if (!new_len)
9a2458a6
RV
496 return ret;
497
498 down_write(&current->mm->mmap_sem);
1da177e4 499
1da177e4 500 if (flags & MREMAP_FIXED) {
9a2458a6
RV
501 ret = mremap_to(addr, old_len, new_addr, new_len,
502 &locked);
ecc1a899 503 goto out;
1da177e4
LT
504 }
505
506 /*
507 * Always allow a shrinking remap: that just unmaps
508 * the unnecessary pages..
509 * do_munmap does all the needed commit accounting
510 */
511 if (old_len >= new_len) {
d0de32d9 512 ret = do_munmap(mm, addr+new_len, old_len - new_len);
1da177e4
LT
513 if (ret && old_len != new_len)
514 goto out;
515 ret = addr;
ecc1a899 516 goto out;
1da177e4
LT
517 }
518
519 /*
ecc1a899 520 * Ok, we need to grow..
1da177e4 521 */
54f5de70
AV
522 vma = vma_to_resize(addr, old_len, new_len, &charged);
523 if (IS_ERR(vma)) {
524 ret = PTR_ERR(vma);
1da177e4 525 goto out;
119f657c 526 }
1da177e4 527
1da177e4 528 /* old_len exactly to the end of the area..
1da177e4 529 */
ecc1a899 530 if (old_len == vma->vm_end - addr) {
1da177e4 531 /* can we just expand the current mapping? */
1a0ef85f 532 if (vma_expandable(vma, new_len - old_len)) {
1da177e4
LT
533 int pages = (new_len - old_len) >> PAGE_SHIFT;
534
5beb4930
RR
535 if (vma_adjust(vma, vma->vm_start, addr + new_len,
536 vma->vm_pgoff, NULL)) {
537 ret = -ENOMEM;
538 goto out;
539 }
1da177e4 540
d0de32d9 541 vm_stat_account(mm, vma->vm_flags, vma->vm_file, pages);
1da177e4 542 if (vma->vm_flags & VM_LOCKED) {
d0de32d9 543 mm->locked_vm += pages;
81909b84
ML
544 locked = true;
545 new_addr = addr;
1da177e4
LT
546 }
547 ret = addr;
548 goto out;
549 }
550 }
551
552 /*
553 * We weren't able to just expand or shrink the area,
554 * we need to create a new one and move it..
555 */
556 ret = -ENOMEM;
557 if (flags & MREMAP_MAYMOVE) {
ecc1a899
AV
558 unsigned long map_flags = 0;
559 if (vma->vm_flags & VM_MAYSHARE)
560 map_flags |= MAP_SHARED;
561
562 new_addr = get_unmapped_area(vma->vm_file, 0, new_len,
93587414
AV
563 vma->vm_pgoff +
564 ((addr - vma->vm_start) >> PAGE_SHIFT),
565 map_flags);
ecc1a899
AV
566 if (new_addr & ~PAGE_MASK) {
567 ret = new_addr;
568 goto out;
1da177e4 569 }
ecc1a899 570
81909b84 571 ret = move_vma(vma, addr, old_len, new_len, new_addr, &locked);
1da177e4
LT
572 }
573out:
574 if (ret & ~PAGE_MASK)
575 vm_unacct_memory(charged);
1da177e4 576 up_write(&current->mm->mmap_sem);
81909b84
ML
577 if (locked && new_len > old_len)
578 mm_populate(new_addr + old_len, new_len - old_len);
1da177e4
LT
579 return ret;
580}