]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/blame - net/bridge/br_if.c
Revert "bridge: do not add port to router list when receives query with source 0...
[mirror_ubuntu-bionic-kernel.git] / net / bridge / br_if.c
CommitLineData
1da177e4
LT
1/*
2 * Userspace interface
3 * Linux ethernet bridge
4 *
5 * Authors:
6 * Lennert Buytenhek <buytenh@gnu.org>
7 *
1da177e4
LT
8 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License
10 * as published by the Free Software Foundation; either version
11 * 2 of the License, or (at your option) any later version.
12 */
13
14#include <linux/kernel.h>
15#include <linux/netdevice.h>
77f98598 16#include <linux/etherdevice.h>
c06ee961 17#include <linux/netpoll.h>
1da177e4
LT
18#include <linux/ethtool.h>
19#include <linux/if_arp.h>
20#include <linux/module.h>
21#include <linux/init.h>
22#include <linux/rtnetlink.h>
46f25dff 23#include <linux/if_ether.h>
5a0e3ad6 24#include <linux/slab.h>
c6e970a0 25#include <net/dsa.h>
1da177e4 26#include <net/sock.h>
407af329 27#include <linux/if_vlan.h>
56607386 28#include <net/switchdev.h>
6e340a7a 29#include <net/net_namespace.h>
1da177e4
LT
30
31#include "br_private.h"
32
33/*
34 * Determine initial path cost based on speed.
35 * using recommendations from 802.1d standard
36 *
61a44b9c 37 * Since driver might sleep need to not be holding any locks.
1da177e4 38 */
4433f420 39static int port_cost(struct net_device *dev)
1da177e4 40{
702b26a2 41 struct ethtool_link_ksettings ecmd;
b4a488d1 42
702b26a2
DD
43 if (!__ethtool_get_link_ksettings(dev, &ecmd)) {
44 switch (ecmd.base.speed) {
fa3df928
JP
45 case SPEED_10000:
46 return 2;
47 case SPEED_1000:
48 return 4;
49 case SPEED_100:
50 return 19;
51 case SPEED_10:
52 return 100;
1da177e4
LT
53 }
54 }
55
56 /* Old silly heuristics based on name */
57 if (!strncmp(dev->name, "lec", 3))
58 return 7;
59
60 if (!strncmp(dev->name, "plip", 4))
61 return 2500;
62
63 return 100; /* assume old 10Mbps */
64}
65
4433f420 66
1a81a2e0 67/* Check for port carrier transitions. */
269def7c 68void br_port_carrier_check(struct net_bridge_port *p)
4433f420 69{
269def7c
SH
70 struct net_device *dev = p->dev;
71 struct net_bridge *br = p->br;
6e86b890 72
8f3359bd 73 if (!(p->flags & BR_ADMIN_COST) &&
74 netif_running(dev) && netif_oper_up(dev))
6e86b890
SH
75 p->path_cost = port_cost(dev);
76
aa7c6e5f 77 if (!netif_running(br->dev))
78 return;
79
80 spin_lock_bh(&br->lock);
576eb625 81 if (netif_running(dev) && netif_oper_up(dev)) {
aa7c6e5f 82 if (p->state == BR_STATE_DISABLED)
83 br_stp_enable_port(p);
84 } else {
85 if (p->state != BR_STATE_DISABLED)
86 br_stp_disable_port(p);
4433f420 87 }
aa7c6e5f 88 spin_unlock_bh(&br->lock);
4433f420
SH
89}
90
2796d0c6
VY
91static void br_port_set_promisc(struct net_bridge_port *p)
92{
93 int err = 0;
94
95 if (br_promisc_port(p))
96 return;
97
98 err = dev_set_promiscuity(p->dev, 1);
99 if (err)
100 return;
101
102 br_fdb_unsync_static(p->br, p);
103 p->flags |= BR_PROMISC;
104}
105
106static void br_port_clear_promisc(struct net_bridge_port *p)
107{
108 int err;
109
110 /* Check if the port is already non-promisc or if it doesn't
111 * support UNICAST filtering. Without unicast filtering support
112 * we'll end up re-enabling promisc mode anyway, so just check for
113 * it here.
114 */
115 if (!br_promisc_port(p) || !(p->dev->priv_flags & IFF_UNICAST_FLT))
116 return;
117
118 /* Since we'll be clearing the promisc mode, program the port
119 * first so that we don't have interruption in traffic.
120 */
121 err = br_fdb_sync_static(p->br, p);
122 if (err)
123 return;
124
125 dev_set_promiscuity(p->dev, -1);
126 p->flags &= ~BR_PROMISC;
127}
128
129/* When a port is added or removed or when certain port flags
130 * change, this function is called to automatically manage
131 * promiscuity setting of all the bridge ports. We are always called
132 * under RTNL so can skip using rcu primitives.
133 */
134void br_manage_promisc(struct net_bridge *br)
135{
136 struct net_bridge_port *p;
137 bool set_all = false;
138
139 /* If vlan filtering is disabled or bridge interface is placed
140 * into promiscuous mode, place all ports in promiscuous mode.
141 */
1f51445a 142 if ((br->dev->flags & IFF_PROMISC) || !br_vlan_enabled(br->dev))
2796d0c6
VY
143 set_all = true;
144
145 list_for_each_entry(p, &br->port_list, list) {
146 if (set_all) {
147 br_port_set_promisc(p);
148 } else {
149 /* If the number of auto-ports is <= 1, then all other
150 * ports will have their output configuration
151 * statically specified through fdbs. Since ingress
152 * on the auto-port becomes forwarding/egress to other
153 * ports and egress configuration is statically known,
154 * we can say that ingress configuration of the
155 * auto-port is also statically known.
156 * This lets us disable promiscuous mode and write
157 * this config to hw.
158 */
e0a47d1f
TM
159 if (br->auto_cnt == 0 ||
160 (br->auto_cnt == 1 && br_auto_port(p)))
2796d0c6
VY
161 br_port_clear_promisc(p);
162 else
163 br_port_set_promisc(p);
164 }
165 }
166}
167
e028e4b8
VY
168static void nbp_update_port_count(struct net_bridge *br)
169{
170 struct net_bridge_port *p;
171 u32 cnt = 0;
172
173 list_for_each_entry(p, &br->port_list, list) {
174 if (br_auto_port(p))
175 cnt++;
176 }
2796d0c6
VY
177 if (br->auto_cnt != cnt) {
178 br->auto_cnt = cnt;
179 br_manage_promisc(br);
180 }
181}
182
183static void nbp_delete_promisc(struct net_bridge_port *p)
184{
025559ee 185 /* If port is currently promiscuous, unset promiscuity.
2796d0c6
VY
186 * Otherwise, it is a static port so remove all addresses
187 * from it.
188 */
189 dev_set_allmulti(p->dev, -1);
190 if (br_promisc_port(p))
191 dev_set_promiscuity(p->dev, -1);
192 else
193 br_fdb_unsync_static(p->br, p);
e028e4b8
VY
194}
195
bab1deea
SH
196static void release_nbp(struct kobject *kobj)
197{
198 struct net_bridge_port *p
199 = container_of(kobj, struct net_bridge_port, kobj);
200 kfree(p);
201}
202
6e340a7a
TH
203static void brport_get_ownership(struct kobject *kobj, kuid_t *uid, kgid_t *gid)
204{
205 struct net_bridge_port *p = kobj_to_brport(kobj);
206
207 net_ns_get_ownership(dev_net(p->dev), uid, gid);
208}
209
bab1deea
SH
210static struct kobj_type brport_ktype = {
211#ifdef CONFIG_SYSFS
212 .sysfs_ops = &brport_sysfs_ops,
213#endif
214 .release = release_nbp,
6e340a7a 215 .get_ownership = brport_get_ownership,
bab1deea
SH
216};
217
1da177e4
LT
218static void destroy_nbp(struct net_bridge_port *p)
219{
220 struct net_device *dev = p->dev;
221
1da177e4
LT
222 p->br = NULL;
223 p->dev = NULL;
224 dev_put(dev);
225
bab1deea 226 kobject_put(&p->kobj);
1da177e4
LT
227}
228
229static void destroy_nbp_rcu(struct rcu_head *head)
230{
231 struct net_bridge_port *p =
232 container_of(head, struct net_bridge_port, rcu);
233 destroy_nbp(p);
234}
235
45493d47
PA
236static unsigned get_max_headroom(struct net_bridge *br)
237{
238 unsigned max_headroom = 0;
239 struct net_bridge_port *p;
240
241 list_for_each_entry(p, &br->port_list, list) {
242 unsigned dev_headroom = netdev_get_fwd_headroom(p->dev);
243
244 if (dev_headroom > max_headroom)
245 max_headroom = dev_headroom;
246 }
247
248 return max_headroom;
249}
250
251static void update_headroom(struct net_bridge *br, int new_hr)
252{
253 struct net_bridge_port *p;
254
255 list_for_each_entry(p, &br->port_list, list)
256 netdev_set_rx_headroom(p->dev, new_hr);
257
258 br->dev->needed_headroom = new_hr;
259}
260
3f4cfc2d
SH
261/* Delete port(interface) from bridge is done in two steps.
262 * via RCU. First step, marks device as down. That deletes
263 * all the timers and stops new packets from flowing through.
264 *
265 * Final cleanup doesn't occur until after all CPU's finished
266 * processing packets.
267 *
268 * Protected from multiple admin operations by RTNL mutex
269 */
1da177e4
LT
270static void del_nbp(struct net_bridge_port *p)
271{
272 struct net_bridge *br = p->br;
273 struct net_device *dev = p->dev;
274
b3bcb72e 275 sysfs_remove_link(br->ifobj, p->dev->name);
bab1deea 276
2796d0c6 277 nbp_delete_promisc(p);
1da177e4
LT
278
279 spin_lock_bh(&br->lock);
280 br_stp_disable_port(p);
281 spin_unlock_bh(&br->lock);
282
92899063 283 br_ifinfo_notify(RTM_DELLINK, NULL, p);
b86c4503 284
1da177e4 285 list_del_rcu(&p->list);
45493d47
PA
286 if (netdev_get_fwd_headroom(dev) == br->dev->needed_headroom)
287 update_headroom(br, get_max_headroom(br));
288 netdev_reset_rx_headroom(dev);
1da177e4 289
f409d0ed 290 nbp_vlan_flush(p);
1ea2d020 291 br_fdb_delete_by_port(br, p, 0, 1);
56607386
JP
292 switchdev_deferred_process();
293
e028e4b8
VY
294 nbp_update_port_count(br);
295
0f49579a
JP
296 netdev_upper_dev_unlink(dev, br->dev);
297
f350a0a8
JP
298 dev->priv_flags &= ~IFF_BRIDGE_PORT;
299
ab95bfe0 300 netdev_rx_handler_unregister(dev);
b3f1be4b 301
3fe2d7c7
HX
302 br_multicast_del_port(p);
303
125a12cc 304 kobject_uevent(&p->kobj, KOBJ_REMOVE);
bab1deea
SH
305 kobject_del(&p->kobj);
306
91d2c34a
HX
307 br_netpoll_disable(p);
308
1da177e4
LT
309 call_rcu(&p->rcu, destroy_nbp_rcu);
310}
311
1ce5cce8 312/* Delete bridge device */
313void br_dev_delete(struct net_device *dev, struct list_head *head)
1da177e4 314{
1ce5cce8 315 struct net_bridge *br = netdev_priv(dev);
1da177e4
LT
316 struct net_bridge_port *p, *n;
317
318 list_for_each_entry_safe(p, n, &br->port_list, list) {
1da177e4
LT
319 del_nbp(p);
320 }
321
821f1b21
RP
322 br_recalculate_neigh_suppress_enabled(br);
323
1ea2d020 324 br_fdb_delete_by_port(br, NULL, 0, 1);
f8730420 325
f7cdee8a 326 cancel_delayed_work_sync(&br->gc_work);
1da177e4
LT
327
328 br_sysfs_delbr(br->dev);
8c56ba05 329 unregister_netdevice_queue(br->dev, head);
1da177e4
LT
330}
331
1da177e4
LT
332/* find an available port number */
333static int find_portno(struct net_bridge *br)
334{
335 int index;
336 struct net_bridge_port *p;
337 unsigned long *inuse;
338
3b781fa1 339 inuse = kcalloc(BITS_TO_LONGS(BR_MAX_PORTS), sizeof(unsigned long),
1da177e4
LT
340 GFP_KERNEL);
341 if (!inuse)
342 return -ENOMEM;
343
1da177e4
LT
344 set_bit(0, inuse); /* zero is reserved */
345 list_for_each_entry(p, &br->port_list, list) {
346 set_bit(p->port_no, inuse);
347 }
348 index = find_first_zero_bit(inuse, BR_MAX_PORTS);
349 kfree(inuse);
350
351 return (index >= BR_MAX_PORTS) ? -EXFULL : index;
352}
353
4433f420 354/* called with RTNL but without bridge lock */
9d6f229f 355static struct net_bridge_port *new_nbp(struct net_bridge *br,
4433f420 356 struct net_device *dev)
1da177e4 357{
1da177e4 358 struct net_bridge_port *p;
1080ab95 359 int index, err;
9d6f229f 360
1da177e4
LT
361 index = find_portno(br);
362 if (index < 0)
363 return ERR_PTR(index);
364
cee48541 365 p = kzalloc(sizeof(*p), GFP_KERNEL);
1da177e4
LT
366 if (p == NULL)
367 return ERR_PTR(-ENOMEM);
368
1da177e4
LT
369 p->br = br;
370 dev_hold(dev);
371 p->dev = dev;
4433f420 372 p->path_cost = port_cost(dev);
9d6f229f 373 p->priority = 0x8000 >> BR_PORT_BITS;
1da177e4 374 p->port_no = index;
99f906e9 375 p->flags = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
1da177e4 376 br_init_port(p);
775dd692 377 br_set_state(p, BR_STATE_DISABLED);
d32439c0 378 br_stp_port_timer_init(p);
1080ab95
NA
379 err = br_multicast_add_port(p);
380 if (err) {
381 dev_put(dev);
382 kfree(p);
383 p = ERR_PTR(err);
384 }
1da177e4
LT
385
386 return p;
387}
388
4aa678ba 389int br_add_bridge(struct net *net, const char *name)
1da177e4
LT
390{
391 struct net_device *dev;
11f3a6bd 392 int res;
1da177e4 393
c835a677 394 dev = alloc_netdev(sizeof(struct net_bridge), name, NET_NAME_UNKNOWN,
bb900b27 395 br_dev_setup);
396
9d6f229f 397 if (!dev)
1da177e4
LT
398 return -ENOMEM;
399
bb900b27 400 dev_net_set(dev, net);
149ddd83 401 dev->rtnl_link_ops = &br_link_ops;
e340a90e 402
11f3a6bd
ED
403 res = register_netdev(dev);
404 if (res)
405 free_netdev(dev);
406 return res;
1da177e4
LT
407}
408
4aa678ba 409int br_del_bridge(struct net *net, const char *name)
1da177e4
LT
410{
411 struct net_device *dev;
412 int ret = 0;
413
414 rtnl_lock();
4aa678ba 415 dev = __dev_get_by_name(net, name);
9d6f229f 416 if (dev == NULL)
1da177e4
LT
417 ret = -ENXIO; /* Could not find device */
418
419 else if (!(dev->priv_flags & IFF_EBRIDGE)) {
420 /* Attempt to delete non bridge device! */
421 ret = -EPERM;
422 }
423
424 else if (dev->flags & IFF_UP) {
425 /* Not shutdown yet. */
426 ret = -EBUSY;
9d6f229f 427 }
1da177e4 428
9d6f229f 429 else
1ce5cce8 430 br_dev_delete(dev, NULL);
1da177e4
LT
431
432 rtnl_unlock();
433 return ret;
434}
435
46f25dff 436/* MTU of the bridge pseudo-device: ETH_DATA_LEN or the minimum of the ports */
1da177e4
LT
437int br_min_mtu(const struct net_bridge *br)
438{
439 const struct net_bridge_port *p;
440 int mtu = 0;
441
442 ASSERT_RTNL();
443
444 if (list_empty(&br->port_list))
46f25dff 445 mtu = ETH_DATA_LEN;
1da177e4
LT
446 else {
447 list_for_each_entry(p, &br->port_list, list) {
448 if (!mtu || p->dev->mtu < mtu)
449 mtu = p->dev->mtu;
450 }
451 }
452 return mtu;
453}
454
ae74f100
ED
455static void br_set_gso_limits(struct net_bridge *br)
456{
457 unsigned int gso_max_size = GSO_MAX_SIZE;
458 u16 gso_max_segs = GSO_MAX_SEGS;
459 const struct net_bridge_port *p;
460
461 list_for_each_entry(p, &br->port_list, list) {
462 gso_max_size = min(gso_max_size, p->dev->gso_max_size);
463 gso_max_segs = min(gso_max_segs, p->dev->gso_max_segs);
464 }
465 br->dev->gso_max_size = gso_max_size;
466 br->dev->gso_max_segs = gso_max_segs;
467}
468
81d35307
SH
469/*
470 * Recomputes features using slave's features
471 */
c8f44aff
MM
472netdev_features_t br_features_recompute(struct net_bridge *br,
473 netdev_features_t features)
81d35307
SH
474{
475 struct net_bridge_port *p;
c8f44aff 476 netdev_features_t mask;
81d35307 477
b63365a2 478 if (list_empty(&br->port_list))
c4d27ef9 479 return features;
b63365a2 480
c4d27ef9 481 mask = features;
b63365a2 482 features &= ~NETIF_F_ONE_FOR_ALL;
81d35307
SH
483
484 list_for_each_entry(p, &br->port_list, list) {
b63365a2
HX
485 features = netdev_increment_features(features,
486 p->dev->features, mask);
81d35307 487 }
f902e881 488 features = netdev_add_tso_features(features, mask);
81d35307 489
c4d27ef9 490 return features;
81d35307
SH
491}
492
1da177e4 493/* called with RTNL */
ca752be0
DA
494int br_add_if(struct net_bridge *br, struct net_device *dev,
495 struct netlink_ext_ack *extack)
1da177e4
LT
496{
497 struct net_bridge_port *p;
498 int err = 0;
45493d47 499 unsigned br_hr, dev_hr;
edf947f1 500 bool changed_addr;
1da177e4 501
8db0a2ee
FF
502 /* Don't allow bridging non-ethernet like devices, or DSA-enabled
503 * master network devices since the bridge layer rx_handler prevents
504 * the DSA fake ethertype handler to be invoked, so we do not strip off
505 * the DSA switch tag protocol header and the bridge layer just return
506 * RX_HANDLER_CONSUMED, stopping RX processing for these frames.
507 */
1056bd51 508 if ((dev->flags & IFF_LOOPBACK) ||
77f98598 509 dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN ||
8db0a2ee
FF
510 !is_valid_ether_addr(dev->dev_addr) ||
511 netdev_uses_dsa(dev))
1da177e4
LT
512 return -EINVAL;
513
1056bd51 514 /* No bridging of bridges */
ca752be0
DA
515 if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit) {
516 NL_SET_ERR_MSG(extack,
517 "Can not enslave a bridge to a bridge");
1da177e4 518 return -ELOOP;
ca752be0 519 }
1da177e4 520
a5f6b4b6
HL
521 /* Device has master upper dev */
522 if (netdev_master_upper_dev_get(dev))
1da177e4
LT
523 return -EBUSY;
524
ad4bb6f8 525 /* No bridging devices that dislike that (e.g. wireless) */
ca752be0
DA
526 if (dev->priv_flags & IFF_DONT_BRIDGE) {
527 NL_SET_ERR_MSG(extack,
528 "Device does not allow enslaving to a bridge");
ad4bb6f8 529 return -EOPNOTSUPP;
ca752be0 530 }
ad4bb6f8 531
bab1deea
SH
532 p = new_nbp(br, dev);
533 if (IS_ERR(p))
1da177e4
LT
534 return PTR_ERR(p);
535
bb8ed630
AW
536 call_netdevice_notifiers(NETDEV_JOIN, dev);
537
2796d0c6 538 err = dev_set_allmulti(dev, 1);
bc3f9076
WC
539 if (err)
540 goto put_back;
541
e32cc736
GKH
542 err = kobject_init_and_add(&p->kobj, &brport_ktype, &(dev->dev.kobj),
543 SYSFS_BRIDGE_PORT_ATTR);
bab1deea
SH
544 if (err)
545 goto err1;
1da177e4 546
bab1deea
SH
547 err = br_sysfs_addif(p);
548 if (err)
549 goto err2;
1da177e4 550
a8779ec1 551 err = br_netpoll_enable(p);
93d8bf9f 552 if (err)
91d2c34a
HX
553 goto err3;
554
0f49579a 555 err = netdev_rx_handler_register(dev, br_handle_frame, p);
ab95bfe0 556 if (err)
9b1536c4 557 goto err4;
f350a0a8 558
0f49579a
JP
559 dev->priv_flags |= IFF_BRIDGE_PORT;
560
ca752be0 561 err = netdev_master_upper_dev_link(dev, br->dev, NULL, NULL, extack);
afc6151a 562 if (err)
9b1536c4 563 goto err5;
afc6151a 564
6bc506b4
IS
565 err = nbp_switchdev_mark_set(p);
566 if (err)
567 goto err6;
568
0187bdfb 569 dev_disable_lro(dev);
bab1deea
SH
570
571 list_add_rcu(&p->list, &br->port_list);
572
e028e4b8
VY
573 nbp_update_port_count(br);
574
c4d27ef9
MM
575 netdev_update_features(br->dev);
576
45493d47
PA
577 br_hr = br->dev->needed_headroom;
578 dev_hr = netdev_get_fwd_headroom(dev);
579 if (br_hr < dev_hr)
580 update_headroom(br, dev_hr);
581 else
582 netdev_set_rx_headroom(dev, br_hr);
fd094808 583
a4b816d8
TM
584 if (br_fdb_insert(br, p, dev->dev_addr, 0))
585 netdev_err(dev, "failed insert local address bridge forwarding table\n");
586
08474cc1
ER
587 err = nbp_vlan_init(p);
588 if (err) {
5be5a2df 589 netdev_err(dev, "failed to initialize vlan filtering on this port\n");
6bc506b4 590 goto err7;
08474cc1 591 }
5be5a2df 592
bab1deea 593 spin_lock_bh(&br->lock);
edf947f1 594 changed_addr = br_stp_recalculate_bridge_id(br);
de79059e 595
576eb625 596 if (netif_running(dev) && netif_oper_up(dev) &&
de79059e
AS
597 (br->dev->flags & IFF_UP))
598 br_stp_enable_port(p);
bab1deea
SH
599 spin_unlock_bh(&br->lock);
600
92899063 601 br_ifinfo_notify(RTM_NEWLINK, NULL, p);
b86c4503 602
edf947f1 603 if (changed_addr)
56139fc5 604 call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
edf947f1 605
bab1deea 606 dev_set_mtu(br->dev, br_min_mtu(br));
ae74f100 607 br_set_gso_limits(br);
269def7c 608
bab1deea 609 kobject_uevent(&p->kobj, KOBJ_ADD);
1da177e4 610
bab1deea 611 return 0;
afc6151a 612
6bc506b4 613err7:
08474cc1
ER
614 list_del_rcu(&p->list);
615 br_fdb_delete_by_port(br, p, 0, 1);
616 nbp_update_port_count(br);
6bc506b4 617err6:
08474cc1 618 netdev_upper_dev_unlink(dev, br->dev);
9b1536c4 619err5:
0f49579a
JP
620 dev->priv_flags &= ~IFF_BRIDGE_PORT;
621 netdev_rx_handler_unregister(dev);
9b1536c4
G
622err4:
623 br_netpoll_disable(p);
91d2c34a
HX
624err3:
625 sysfs_remove_link(br->ifobj, p->dev->name);
bab1deea 626err2:
c587aea9 627 kobject_put(&p->kobj);
30df94f8 628 p = NULL; /* kobject_put frees */
77f98598 629err1:
019ee792 630 dev_set_allmulti(dev, -1);
43af8532
VL
631put_back:
632 dev_put(dev);
bc3f9076 633 kfree(p);
1da177e4
LT
634 return err;
635}
636
637/* called with RTNL */
638int br_del_if(struct net_bridge *br, struct net_device *dev)
639{
f350a0a8 640 struct net_bridge_port *p;
9be6dd65 641 bool changed_addr;
f350a0a8 642
ec1e5610 643 p = br_port_get_rtnl(dev);
b5ed54e9 644 if (!p || p->br != br)
1da177e4
LT
645 return -EINVAL;
646
d30362c0
AW
647 /* Since more than one interface can be attached to a bridge,
648 * there still maybe an alternate path for netconsole to use;
649 * therefore there is no reason for a NETDEV_RELEASE event.
650 */
1da177e4
LT
651 del_nbp(p);
652
4c906c27 653 dev_set_mtu(br->dev, br_min_mtu(br));
ae74f100 654 br_set_gso_limits(br);
4c906c27 655
1da177e4 656 spin_lock_bh(&br->lock);
9be6dd65 657 changed_addr = br_stp_recalculate_bridge_id(br);
1da177e4
LT
658 spin_unlock_bh(&br->lock);
659
9be6dd65
AW
660 if (changed_addr)
661 call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
662
c4d27ef9
MM
663 netdev_update_features(br->dev);
664
1da177e4
LT
665 return 0;
666}
e028e4b8
VY
667
668void br_port_flags_change(struct net_bridge_port *p, unsigned long mask)
669{
670 struct net_bridge *br = p->br;
671
672 if (mask & BR_AUTO_MASK)
673 nbp_update_port_count(br);
821f1b21
RP
674
675 if (mask & BR_NEIGH_SUPPRESS)
676 br_recalculate_neigh_suppress_enabled(br);
e028e4b8 677}