]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/blame - net/dccp/options.c
[DCCP]: Reuse ktime_get_real() calls again
[mirror_ubuntu-eoan-kernel.git] / net / dccp / options.c
CommitLineData
7c657876
ACM
1/*
2 * net/dccp/options.c
3 *
4 * An implementation of the DCCP protocol
1bc09869
IM
5 * Copyright (c) 2005 Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
6 * Copyright (c) 2005 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
e6bccd35 7 * Copyright (c) 2005 Ian McDonald <ian.mcdonald@jandi.co.nz>
7c657876
ACM
8 *
9 * This program is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU General Public License
11 * as published by the Free Software Foundation; either version
12 * 2 of the License, or (at your option) any later version.
13 */
7c657876
ACM
14#include <linux/dccp.h>
15#include <linux/module.h>
16#include <linux/types.h>
17#include <linux/kernel.h>
18#include <linux/skbuff.h>
19
ae31c339 20#include "ackvec.h"
7c657876
ACM
21#include "ccid.h"
22#include "dccp.h"
afe00251 23#include "feat.h"
7c657876 24
afb0a34d
GR
25int sysctl_dccp_feat_sequence_window = DCCPF_INITIAL_SEQUENCE_WINDOW;
26int sysctl_dccp_feat_rx_ccid = DCCPF_INITIAL_CCID;
27int sysctl_dccp_feat_tx_ccid = DCCPF_INITIAL_CCID;
28int sysctl_dccp_feat_ack_ratio = DCCPF_INITIAL_ACK_RATIO;
29int sysctl_dccp_feat_send_ack_vector = DCCPF_INITIAL_SEND_ACK_VECTOR;
30int sysctl_dccp_feat_send_ndp_count = DCCPF_INITIAL_SEND_NDP_COUNT;
7c657876 31
a4bf3902 32void dccp_minisock_init(struct dccp_minisock *dmsk)
7c657876 33{
afb0a34d
GR
34 dmsk->dccpms_sequence_window = sysctl_dccp_feat_sequence_window;
35 dmsk->dccpms_rx_ccid = sysctl_dccp_feat_rx_ccid;
36 dmsk->dccpms_tx_ccid = sysctl_dccp_feat_tx_ccid;
37 dmsk->dccpms_ack_ratio = sysctl_dccp_feat_ack_ratio;
38 dmsk->dccpms_send_ack_vector = sysctl_dccp_feat_send_ack_vector;
39 dmsk->dccpms_send_ndp_count = sysctl_dccp_feat_send_ndp_count;
7c657876
ACM
40}
41
42static u32 dccp_decode_value_var(const unsigned char *bf, const u8 len)
43{
44 u32 value = 0;
45
46 if (len > 3)
47 value += *bf++ << 24;
48 if (len > 2)
49 value += *bf++ << 16;
50 if (len > 1)
51 value += *bf++ << 8;
52 if (len > 0)
53 value += *bf;
54
55 return value;
56}
57
58int dccp_parse_options(struct sock *sk, struct sk_buff *skb)
59{
60 struct dccp_sock *dp = dccp_sk(sk);
7c657876
ACM
61 const struct dccp_hdr *dh = dccp_hdr(skb);
62 const u8 pkt_type = DCCP_SKB_CB(skb)->dccpd_type;
bdf13d20 63 u64 ackno = DCCP_SKB_CB(skb)->dccpd_ack_seq;
7c657876
ACM
64 unsigned char *options = (unsigned char *)dh + dccp_hdr_len(skb);
65 unsigned char *opt_ptr = options;
7690af3f
ACM
66 const unsigned char *opt_end = (unsigned char *)dh +
67 (dh->dccph_doff * 4);
7c657876
ACM
68 struct dccp_options_received *opt_recv = &dp->dccps_options_received;
69 unsigned char opt, len;
70 unsigned char *value;
1c14ac0a 71 u32 elapsed_time;
afe00251
AB
72 int rc;
73 int mandatory = 0;
7c657876
ACM
74
75 memset(opt_recv, 0, sizeof(*opt_recv));
76
fb950496 77 opt = len = 0;
7c657876
ACM
78 while (opt_ptr != opt_end) {
79 opt = *opt_ptr++;
80 len = 0;
81 value = NULL;
82
83 /* Check if this isn't a single byte option */
84 if (opt > DCCPO_MAX_RESERVED) {
85 if (opt_ptr == opt_end)
86 goto out_invalid_option;
87
88 len = *opt_ptr++;
89 if (len < 3)
90 goto out_invalid_option;
91 /*
92 * Remove the type and len fields, leaving
93 * just the value size
94 */
95 len -= 2;
96 value = opt_ptr;
97 opt_ptr += len;
98
99 if (opt_ptr > opt_end)
100 goto out_invalid_option;
101 }
102
103 switch (opt) {
104 case DCCPO_PADDING:
105 break;
afe00251
AB
106 case DCCPO_MANDATORY:
107 if (mandatory)
108 goto out_invalid_option;
6df9424a
ACM
109 if (pkt_type != DCCP_PKT_DATA)
110 mandatory = 1;
afe00251 111 break;
7c657876
ACM
112 case DCCPO_NDP_COUNT:
113 if (len > 3)
114 goto out_invalid_option;
115
116 opt_recv->dccpor_ndp = dccp_decode_value_var(value, len);
09dbc389 117 dccp_pr_debug("%s rx opt: NDP count=%d\n", dccp_role(sk),
7690af3f 118 opt_recv->dccpor_ndp);
7c657876 119 break;
afe00251
AB
120 case DCCPO_CHANGE_L:
121 /* fall through */
122 case DCCPO_CHANGE_R:
123 if (len < 2)
124 goto out_invalid_option;
125 rc = dccp_feat_change_recv(sk, opt, *value, value + 1,
126 len - 1);
127 /*
128 * When there is a change error, change_recv is
129 * responsible for dealing with it. i.e. reply with an
130 * empty confirm.
131 * If the change was mandatory, then we need to die.
132 */
133 if (rc && mandatory)
134 goto out_invalid_option;
135 break;
136 case DCCPO_CONFIRM_L:
137 /* fall through */
138 case DCCPO_CONFIRM_R:
139 if (len < 2)
140 goto out_invalid_option;
141 if (dccp_feat_confirm_recv(sk, opt, *value,
142 value + 1, len - 1))
143 goto out_invalid_option;
144 break;
7c657876 145 case DCCPO_ACK_VECTOR_0:
ae31c339 146 case DCCPO_ACK_VECTOR_1:
7c657876 147 if (pkt_type == DCCP_PKT_DATA)
e5a6de91 148 break;
7c657876 149
a4bf3902 150 if (dccp_msk(sk)->dccpms_send_ack_vector &&
bdf13d20 151 dccp_ackvec_parse(sk, skb, &ackno, opt, value, len))
ae31c339 152 goto out_invalid_option;
7c657876
ACM
153 break;
154 case DCCPO_TIMESTAMP:
155 if (len != 4)
156 goto out_invalid_option;
157
60fe62e7 158 opt_recv->dccpor_timestamp = ntohl(*(__be32 *)value);
7c657876
ACM
159
160 dp->dccps_timestamp_echo = opt_recv->dccpor_timestamp;
19ac2146 161 dp->dccps_timestamp_time = ktime_get_real();
7c657876 162
09dbc389
GR
163 dccp_pr_debug("%s rx opt: TIMESTAMP=%u, ackno=%llu\n",
164 dccp_role(sk), opt_recv->dccpor_timestamp,
f6ccf554 165 (unsigned long long)
7c657876
ACM
166 DCCP_SKB_CB(skb)->dccpd_ack_seq);
167 break;
168 case DCCPO_TIMESTAMP_ECHO:
1bc09869 169 if (len != 4 && len != 6 && len != 8)
7c657876
ACM
170 goto out_invalid_option;
171
60fe62e7 172 opt_recv->dccpor_timestamp_echo = ntohl(*(__be32 *)value);
7c657876 173
09dbc389 174 dccp_pr_debug("%s rx opt: TIMESTAMP_ECHO=%u, len=%d, "
f73f7097 175 "ackno=%llu", dccp_role(sk),
7690af3f 176 opt_recv->dccpor_timestamp_echo,
f6ccf554
DM
177 len + 2,
178 (unsigned long long)
1bc09869
IM
179 DCCP_SKB_CB(skb)->dccpd_ack_seq);
180
1bc09869 181
f73f7097
GR
182 if (len == 4) {
183 dccp_pr_debug_cat("\n");
1c14ac0a 184 break;
f73f7097 185 }
1c14ac0a
ACM
186
187 if (len == 6)
60fe62e7 188 elapsed_time = ntohs(*(__be16 *)(value + 4));
1c14ac0a 189 else
60fe62e7 190 elapsed_time = ntohl(*(__be32 *)(value + 4));
1c14ac0a 191
f73f7097
GR
192 dccp_pr_debug_cat(", ELAPSED_TIME=%d\n", elapsed_time);
193
1c14ac0a
ACM
194 /* Give precedence to the biggest ELAPSED_TIME */
195 if (elapsed_time > opt_recv->dccpor_elapsed_time)
196 opt_recv->dccpor_elapsed_time = elapsed_time;
7c657876
ACM
197 break;
198 case DCCPO_ELAPSED_TIME:
1bc09869 199 if (len != 2 && len != 4)
7c657876
ACM
200 goto out_invalid_option;
201
202 if (pkt_type == DCCP_PKT_DATA)
203 continue;
1bc09869
IM
204
205 if (len == 2)
60fe62e7 206 elapsed_time = ntohs(*(__be16 *)value);
1bc09869 207 else
60fe62e7 208 elapsed_time = ntohl(*(__be32 *)value);
1c14ac0a
ACM
209
210 if (elapsed_time > opt_recv->dccpor_elapsed_time)
211 opt_recv->dccpor_elapsed_time = elapsed_time;
1bc09869 212
09dbc389
GR
213 dccp_pr_debug("%s rx opt: ELAPSED_TIME=%d\n",
214 dccp_role(sk), elapsed_time);
7c657876
ACM
215 break;
216 /*
0e64e94e 217 * From RFC 4340, sec. 10.3:
7c657876 218 *
7690af3f
ACM
219 * Option numbers 128 through 191 are for
220 * options sent from the HC-Sender to the
221 * HC-Receiver; option numbers 192 through 255
222 * are for options sent from the HC-Receiver to
223 * the HC-Sender.
7c657876
ACM
224 */
225 case 128 ... 191: {
226 const u16 idx = value - options;
227
7690af3f
ACM
228 if (ccid_hc_rx_parse_options(dp->dccps_hc_rx_ccid, sk,
229 opt, len, idx,
230 value) != 0)
7c657876
ACM
231 goto out_invalid_option;
232 }
233 break;
234 case 192 ... 255: {
235 const u16 idx = value - options;
236
7690af3f
ACM
237 if (ccid_hc_tx_parse_options(dp->dccps_hc_tx_ccid, sk,
238 opt, len, idx,
239 value) != 0)
7c657876
ACM
240 goto out_invalid_option;
241 }
242 break;
243 default:
59348b19
GR
244 DCCP_CRIT("DCCP(%p): option %d(len=%d) not "
245 "implemented, ignoring", sk, opt, len);
7c657876 246 break;
c9eaf173 247 }
afe00251
AB
248
249 if (opt != DCCPO_MANDATORY)
250 mandatory = 0;
7c657876
ACM
251 }
252
6df9424a
ACM
253 /* mandatory was the last byte in option list -> reset connection */
254 if (mandatory)
255 goto out_invalid_option;
256
7c657876
ACM
257 return 0;
258
259out_invalid_option:
260 DCCP_INC_STATS_BH(DCCP_MIB_INVALIDOPT);
261 DCCP_SKB_CB(skb)->dccpd_reset_code = DCCP_RESET_CODE_OPTION_ERROR;
59348b19 262 DCCP_WARN("DCCP(%p): invalid option %d, len=%d", sk, opt, len);
7c657876
ACM
263 return -1;
264}
265
b61fafc4
ACM
266EXPORT_SYMBOL_GPL(dccp_parse_options);
267
7c657876
ACM
268static void dccp_encode_value_var(const u32 value, unsigned char *to,
269 const unsigned int len)
270{
271 if (len > 3)
272 *to++ = (value & 0xFF000000) >> 24;
273 if (len > 2)
274 *to++ = (value & 0xFF0000) >> 16;
275 if (len > 1)
276 *to++ = (value & 0xFF00) >> 8;
277 if (len > 0)
278 *to++ = (value & 0xFF);
279}
280
281static inline int dccp_ndp_len(const int ndp)
282{
283 return likely(ndp <= 0xFF) ? 1 : ndp <= 0xFFFF ? 2 : 3;
284}
285
2d0817d1 286int dccp_insert_option(struct sock *sk, struct sk_buff *skb,
7c657876
ACM
287 const unsigned char option,
288 const void *value, const unsigned char len)
289{
290 unsigned char *to;
291
2d0817d1
ACM
292 if (DCCP_SKB_CB(skb)->dccpd_opt_len + len + 2 > DCCP_MAX_OPT_LEN)
293 return -1;
7c657876
ACM
294
295 DCCP_SKB_CB(skb)->dccpd_opt_len += len + 2;
296
297 to = skb_push(skb, len + 2);
298 *to++ = option;
299 *to++ = len + 2;
300
301 memcpy(to, value, len);
2d0817d1 302 return 0;
7c657876
ACM
303}
304
305EXPORT_SYMBOL_GPL(dccp_insert_option);
306
2d0817d1 307static int dccp_insert_option_ndp(struct sock *sk, struct sk_buff *skb)
7c657876
ACM
308{
309 struct dccp_sock *dp = dccp_sk(sk);
310 int ndp = dp->dccps_ndp_count;
311
312 if (dccp_non_data_packet(skb))
313 ++dp->dccps_ndp_count;
314 else
315 dp->dccps_ndp_count = 0;
316
317 if (ndp > 0) {
318 unsigned char *ptr;
319 const int ndp_len = dccp_ndp_len(ndp);
320 const int len = ndp_len + 2;
321
322 if (DCCP_SKB_CB(skb)->dccpd_opt_len + len > DCCP_MAX_OPT_LEN)
2d0817d1 323 return -1;
7c657876
ACM
324
325 DCCP_SKB_CB(skb)->dccpd_opt_len += len;
326
327 ptr = skb_push(skb, len);
328 *ptr++ = DCCPO_NDP_COUNT;
329 *ptr++ = len;
330 dccp_encode_value_var(ndp, ptr, ndp_len);
331 }
2d0817d1
ACM
332
333 return 0;
7c657876
ACM
334}
335
336static inline int dccp_elapsed_time_len(const u32 elapsed_time)
337{
b1c9fe7b 338 return elapsed_time == 0 ? 0 : elapsed_time <= 0xFFFF ? 2 : 4;
7c657876
ACM
339}
340
2d0817d1
ACM
341int dccp_insert_option_elapsed_time(struct sock *sk, struct sk_buff *skb,
342 u32 elapsed_time)
7c657876 343{
7c657876
ACM
344 const int elapsed_time_len = dccp_elapsed_time_len(elapsed_time);
345 const int len = 2 + elapsed_time_len;
346 unsigned char *to;
347
1bc09869 348 if (elapsed_time_len == 0)
2d0817d1 349 return 0;
7c657876 350
2d0817d1
ACM
351 if (DCCP_SKB_CB(skb)->dccpd_opt_len + len > DCCP_MAX_OPT_LEN)
352 return -1;
7c657876
ACM
353
354 DCCP_SKB_CB(skb)->dccpd_opt_len += len;
355
356 to = skb_push(skb, len);
357 *to++ = DCCPO_ELAPSED_TIME;
358 *to++ = len;
359
1bc09869 360 if (elapsed_time_len == 2) {
60fe62e7 361 const __be16 var16 = htons((u16)elapsed_time);
1bc09869
IM
362 memcpy(to, &var16, 2);
363 } else {
60fe62e7 364 const __be32 var32 = htonl(elapsed_time);
1bc09869
IM
365 memcpy(to, &var32, 4);
366 }
7c657876 367
2d0817d1 368 return 0;
7c657876
ACM
369}
370
d4b81ff7 371EXPORT_SYMBOL_GPL(dccp_insert_option_elapsed_time);
7c657876 372
2d0817d1 373int dccp_insert_option_timestamp(struct sock *sk, struct sk_buff *skb)
7c657876 374{
23474895 375 __be32 now = htonl(((suseconds_t)ktime_to_us(ktime_get_real())) / 10);
1bc09869
IM
376 /* yes this will overflow but that is the point as we want a
377 * 10 usec 32 bit timer which mean it wraps every 11.9 hours */
378
2d0817d1 379 return dccp_insert_option(sk, skb, DCCPO_TIMESTAMP, &now, sizeof(now));
7c657876
ACM
380}
381
d4b81ff7
ACM
382EXPORT_SYMBOL_GPL(dccp_insert_option_timestamp);
383
2d0817d1
ACM
384static int dccp_insert_option_timestamp_echo(struct sock *sk,
385 struct sk_buff *skb)
7c657876
ACM
386{
387 struct dccp_sock *dp = dccp_sk(sk);
60fe62e7 388 __be32 tstamp_echo;
b0e56780 389 int len, elapsed_time_len;
7c657876 390 unsigned char *to;
19ac2146
ACM
391 const suseconds_t delta = ktime_us_delta(ktime_get_real(),
392 dp->dccps_timestamp_time);
393 u32 elapsed_time = delta / 10;
b0e56780
ACM
394 elapsed_time_len = dccp_elapsed_time_len(elapsed_time);
395 len = 6 + elapsed_time_len;
396
2d0817d1
ACM
397 if (DCCP_SKB_CB(skb)->dccpd_opt_len + len > DCCP_MAX_OPT_LEN)
398 return -1;
7c657876
ACM
399
400 DCCP_SKB_CB(skb)->dccpd_opt_len += len;
401
402 to = skb_push(skb, len);
403 *to++ = DCCPO_TIMESTAMP_ECHO;
404 *to++ = len;
405
406 tstamp_echo = htonl(dp->dccps_timestamp_echo);
407 memcpy(to, &tstamp_echo, 4);
408 to += 4;
afe00251 409
1bc09869 410 if (elapsed_time_len == 2) {
60fe62e7 411 const __be16 var16 = htons((u16)elapsed_time);
1bc09869
IM
412 memcpy(to, &var16, 2);
413 } else if (elapsed_time_len == 4) {
60fe62e7 414 const __be32 var32 = htonl(elapsed_time);
1bc09869
IM
415 memcpy(to, &var32, 4);
416 }
7c657876 417
7c657876 418 dp->dccps_timestamp_echo = 0;
19ac2146 419 dp->dccps_timestamp_time = ktime_set(0, 0);
2d0817d1 420 return 0;
7c657876
ACM
421}
422
afe00251 423static int dccp_insert_feat_opt(struct sk_buff *skb, u8 type, u8 feat,
c9eaf173 424 u8 *val, u8 len)
afe00251
AB
425{
426 u8 *to;
427
428 if (DCCP_SKB_CB(skb)->dccpd_opt_len + len + 3 > DCCP_MAX_OPT_LEN) {
59348b19 429 DCCP_WARN("packet too small for feature %d option!\n", feat);
afe00251
AB
430 return -1;
431 }
432
433 DCCP_SKB_CB(skb)->dccpd_opt_len += len + 3;
434
435 to = skb_push(skb, len + 3);
436 *to++ = type;
437 *to++ = len + 3;
438 *to++ = feat;
439
440 if (len)
441 memcpy(to, val, len);
afe00251 442
c02fdc0e
GR
443 dccp_pr_debug("%s(%s (%d), ...), length %d\n",
444 dccp_feat_typename(type),
445 dccp_feat_name(feat), feat, len);
afe00251
AB
446 return 0;
447}
448
2d0817d1 449static int dccp_insert_options_feat(struct sock *sk, struct sk_buff *skb)
afe00251
AB
450{
451 struct dccp_sock *dp = dccp_sk(sk);
a4bf3902 452 struct dccp_minisock *dmsk = dccp_msk(sk);
afe00251
AB
453 struct dccp_opt_pend *opt, *next;
454 int change = 0;
455
456 /* confirm any options [NN opts] */
a4bf3902 457 list_for_each_entry_safe(opt, next, &dmsk->dccpms_conf, dccpop_node) {
afe00251
AB
458 dccp_insert_feat_opt(skb, opt->dccpop_type,
459 opt->dccpop_feat, opt->dccpop_val,
460 opt->dccpop_len);
461 /* fear empty confirms */
462 if (opt->dccpop_val)
463 kfree(opt->dccpop_val);
464 kfree(opt);
465 }
a4bf3902 466 INIT_LIST_HEAD(&dmsk->dccpms_conf);
afe00251
AB
467
468 /* see which features we need to send */
a4bf3902 469 list_for_each_entry(opt, &dmsk->dccpms_pending, dccpop_node) {
afe00251
AB
470 /* see if we need to send any confirm */
471 if (opt->dccpop_sc) {
472 dccp_insert_feat_opt(skb, opt->dccpop_type + 1,
473 opt->dccpop_feat,
474 opt->dccpop_sc->dccpoc_val,
475 opt->dccpop_sc->dccpoc_len);
476
477 BUG_ON(!opt->dccpop_sc->dccpoc_val);
478 kfree(opt->dccpop_sc->dccpoc_val);
479 kfree(opt->dccpop_sc);
480 opt->dccpop_sc = NULL;
481 }
482
483 /* any option not confirmed, re-send it */
484 if (!opt->dccpop_conf) {
485 dccp_insert_feat_opt(skb, opt->dccpop_type,
486 opt->dccpop_feat, opt->dccpop_val,
487 opt->dccpop_len);
488 change++;
489 }
490 }
491
492 /* Retransmit timer.
493 * If this is the master listening sock, we don't set a timer on it. It
494 * should be fine because if the dude doesn't receive our RESPONSE
495 * [which will contain the CHANGE] he will send another REQUEST which
496 * will "retrnasmit" the change.
497 */
498 if (change && dp->dccps_role != DCCP_ROLE_LISTEN) {
499 dccp_pr_debug("reset feat negotiation timer %p\n", sk);
500
501 /* XXX don't reset the timer on re-transmissions. I.e. reset it
502 * only when sending new stuff i guess. Currently the timer
503 * never backs off because on re-transmission it just resets it!
504 */
505 inet_csk_reset_xmit_timer(sk, ICSK_TIME_RETRANS,
506 inet_csk(sk)->icsk_rto, DCCP_RTO_MAX);
507 }
2d0817d1
ACM
508
509 return 0;
afe00251
AB
510}
511
2d0817d1 512int dccp_insert_options(struct sock *sk, struct sk_buff *skb)
7c657876
ACM
513{
514 struct dccp_sock *dp = dccp_sk(sk);
a4bf3902 515 struct dccp_minisock *dmsk = dccp_msk(sk);
7c657876
ACM
516
517 DCCP_SKB_CB(skb)->dccpd_opt_len = 0;
518
a4bf3902 519 if (dmsk->dccpms_send_ndp_count &&
2d0817d1
ACM
520 dccp_insert_option_ndp(sk, skb))
521 return -1;
7c657876
ACM
522
523 if (!dccp_packet_without_ack(skb)) {
a4bf3902 524 if (dmsk->dccpms_send_ack_vector &&
2d0817d1
ACM
525 dccp_ackvec_pending(dp->dccps_hc_rx_ackvec) &&
526 dccp_insert_option_ackvec(sk, skb))
527 return -1;
528
529 if (dp->dccps_timestamp_echo != 0 &&
530 dccp_insert_option_timestamp_echo(sk, skb))
531 return -1;
7c657876
ACM
532 }
533
507d37cf 534 if (dp->dccps_hc_rx_insert_options) {
2d0817d1
ACM
535 if (ccid_hc_rx_insert_options(dp->dccps_hc_rx_ccid, sk, skb))
536 return -1;
507d37cf
ACM
537 dp->dccps_hc_rx_insert_options = 0;
538 }
7c657876 539
afe00251 540 /* Feature negotiation */
2d0817d1
ACM
541 /* Data packets can't do feat negotiation */
542 if (DCCP_SKB_CB(skb)->dccpd_type != DCCP_PKT_DATA &&
543 DCCP_SKB_CB(skb)->dccpd_type != DCCP_PKT_DATAACK &&
544 dccp_insert_options_feat(sk, skb))
545 return -1;
afe00251 546
89560b53
GR
547 /*
548 * Obtain RTT sample from Request/Response exchange.
549 * This is currently used in CCID 3 initialisation.
550 */
551 if (DCCP_SKB_CB(skb)->dccpd_type == DCCP_PKT_REQUEST &&
552 dccp_insert_option_timestamp(sk, skb))
553 return -1;
554
7c657876
ACM
555 /* XXX: insert other options when appropriate */
556
557 if (DCCP_SKB_CB(skb)->dccpd_opt_len != 0) {
558 /* The length of all options has to be a multiple of 4 */
559 int padding = DCCP_SKB_CB(skb)->dccpd_opt_len % 4;
560
561 if (padding != 0) {
562 padding = 4 - padding;
563 memset(skb_push(skb, padding), 0, padding);
564 DCCP_SKB_CB(skb)->dccpd_opt_len += padding;
565 }
566 }
2d0817d1
ACM
567
568 return 0;
7c657876 569}