]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/blame - net/netfilter/nf_flow_table_core.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
[mirror_ubuntu-jammy-kernel.git] / net / netfilter / nf_flow_table_core.c
CommitLineData
09c434b8 1// SPDX-License-Identifier: GPL-2.0-only
ac2a6666
PNA
2#include <linux/kernel.h>
3#include <linux/init.h>
4#include <linux/module.h>
5#include <linux/netfilter.h>
6#include <linux/rhashtable.h>
7#include <linux/netdevice.h>
4f3780c0
FF
8#include <net/ip.h>
9#include <net/ip6_route.h>
c0ea1bcb 10#include <net/netfilter/nf_tables.h>
ac2a6666
PNA
11#include <net/netfilter/nf_flow_table.h>
12#include <net/netfilter/nf_conntrack.h>
13#include <net/netfilter/nf_conntrack_core.h>
40d102cd 14#include <net/netfilter/nf_conntrack_l4proto.h>
ac2a6666
PNA
15#include <net/netfilter/nf_conntrack_tuple.h>
16
84453a90
FF
17static DEFINE_MUTEX(flowtable_lock);
18static LIST_HEAD(flowtables);
19
047b300e 20static void
458a1828 21flow_offload_fill_dir(struct flow_offload *flow,
047b300e
FF
22 enum flow_offload_tuple_dir dir)
23{
24 struct flow_offload_tuple *ft = &flow->tuplehash[dir].tuple;
458a1828 25 struct nf_conntrack_tuple *ctt = &flow->ct->tuplehash[dir].tuple;
047b300e
FF
26
27 ft->dir = dir;
28
29 switch (ctt->src.l3num) {
30 case NFPROTO_IPV4:
31 ft->src_v4 = ctt->src.u3.in;
32 ft->dst_v4 = ctt->dst.u3.in;
33 break;
34 case NFPROTO_IPV6:
35 ft->src_v6 = ctt->src.u3.in6;
36 ft->dst_v6 = ctt->dst.u3.in6;
37 break;
38 }
39
40 ft->l3proto = ctt->src.l3num;
41 ft->l4proto = ctt->dst.protonum;
42 ft->src_port = ctt->src.u.tcp.port;
43 ft->dst_port = ctt->dst.u.tcp.port;
047b300e
FF
44}
45
f1363e05 46struct flow_offload *flow_offload_alloc(struct nf_conn *ct)
ac2a6666 47{
ac2a6666
PNA
48 struct flow_offload *flow;
49
50 if (unlikely(nf_ct_is_dying(ct) ||
51 !atomic_inc_not_zero(&ct->ct_general.use)))
52 return NULL;
53
62248df8
PNA
54 flow = kzalloc(sizeof(*flow), GFP_ATOMIC);
55 if (!flow)
ac2a6666
PNA
56 goto err_ct_refcnt;
57
b32d2f34 58 flow->ct = ct;
ac2a6666 59
458a1828 60 flow_offload_fill_dir(flow, FLOW_OFFLOAD_DIR_ORIGINAL);
61 flow_offload_fill_dir(flow, FLOW_OFFLOAD_DIR_REPLY);
ac2a6666
PNA
62
63 if (ct->status & IPS_SRC_NAT)
64 flow->flags |= FLOW_OFFLOAD_SNAT;
df1e2025 65 if (ct->status & IPS_DST_NAT)
ac2a6666
PNA
66 flow->flags |= FLOW_OFFLOAD_DNAT;
67
68 return flow;
69
ac2a6666
PNA
70err_ct_refcnt:
71 nf_ct_put(ct);
72
73 return NULL;
74}
75EXPORT_SYMBOL_GPL(flow_offload_alloc);
76
f1363e05
PNA
77static int flow_offload_fill_route(struct flow_offload *flow,
78 const struct nf_flow_route *route,
79 enum flow_offload_tuple_dir dir)
80{
81 struct flow_offload_tuple *flow_tuple = &flow->tuplehash[dir].tuple;
82 struct dst_entry *other_dst = route->tuple[!dir].dst;
83 struct dst_entry *dst = route->tuple[dir].dst;
84
85 if (!dst_hold_safe(route->tuple[dir].dst))
86 return -1;
87
88 switch (flow_tuple->l3proto) {
89 case NFPROTO_IPV4:
90 flow_tuple->mtu = ip_dst_mtu_maybe_forward(dst, true);
91 break;
92 case NFPROTO_IPV6:
93 flow_tuple->mtu = ip6_dst_mtu_forward(dst);
94 break;
95 }
96
97 flow_tuple->iifidx = other_dst->dev->ifindex;
98 flow_tuple->dst_cache = dst;
99
100 return 0;
101}
102
103int flow_offload_route_init(struct flow_offload *flow,
104 const struct nf_flow_route *route)
105{
106 int err;
107
108 err = flow_offload_fill_route(flow, route, FLOW_OFFLOAD_DIR_ORIGINAL);
109 if (err < 0)
110 return err;
111
112 err = flow_offload_fill_route(flow, route, FLOW_OFFLOAD_DIR_REPLY);
113 if (err < 0)
114 goto err_route_reply;
115
116 flow->type = NF_FLOW_OFFLOAD_ROUTE;
117
118 return 0;
119
120err_route_reply:
121 dst_release(route->tuple[FLOW_OFFLOAD_DIR_ORIGINAL].dst);
122
123 return err;
124}
125EXPORT_SYMBOL_GPL(flow_offload_route_init);
126
da5984e5
FF
127static void flow_offload_fixup_tcp(struct ip_ct_tcp *tcp)
128{
129 tcp->state = TCP_CONNTRACK_ESTABLISHED;
130 tcp->seen[0].td_maxwin = 0;
131 tcp->seen[1].td_maxwin = 0;
132}
133
e97d9404
FW
134#define NF_FLOWTABLE_TCP_PICKUP_TIMEOUT (120 * HZ)
135#define NF_FLOWTABLE_UDP_PICKUP_TIMEOUT (30 * HZ)
136
1e5b2471
PNA
137static inline __s32 nf_flow_timeout_delta(unsigned int timeout)
138{
139 return (__s32)(timeout - (u32)jiffies);
140}
141
142static void flow_offload_fixup_ct_timeout(struct nf_conn *ct)
da5984e5
FF
143{
144 const struct nf_conntrack_l4proto *l4proto;
1e5b2471 145 int l4num = nf_ct_protonum(ct);
da5984e5 146 unsigned int timeout;
da5984e5 147
4a60dc74 148 l4proto = nf_ct_l4proto_find(l4num);
da5984e5
FF
149 if (!l4proto)
150 return;
151
da5984e5 152 if (l4num == IPPROTO_TCP)
e97d9404 153 timeout = NF_FLOWTABLE_TCP_PICKUP_TIMEOUT;
da5984e5 154 else if (l4num == IPPROTO_UDP)
e97d9404 155 timeout = NF_FLOWTABLE_UDP_PICKUP_TIMEOUT;
da5984e5
FF
156 else
157 return;
158
1e5b2471
PNA
159 if (nf_flow_timeout_delta(ct->timeout) > (__s32)timeout)
160 ct->timeout = nfct_time_stamp + timeout;
161}
162
163static void flow_offload_fixup_ct_state(struct nf_conn *ct)
164{
165 if (nf_ct_protonum(ct) == IPPROTO_TCP)
166 flow_offload_fixup_tcp(&ct->proto.tcp);
167}
168
169static void flow_offload_fixup_ct(struct nf_conn *ct)
170{
171 flow_offload_fixup_ct_state(ct);
172 flow_offload_fixup_ct_timeout(ct);
da5984e5
FF
173}
174
f1363e05 175static void flow_offload_route_release(struct flow_offload *flow)
ac2a6666 176{
ac2a6666
PNA
177 dst_release(flow->tuplehash[FLOW_OFFLOAD_DIR_ORIGINAL].tuple.dst_cache);
178 dst_release(flow->tuplehash[FLOW_OFFLOAD_DIR_REPLY].tuple.dst_cache);
f1363e05
PNA
179}
180
181void flow_offload_free(struct flow_offload *flow)
182{
183 switch (flow->type) {
184 case NF_FLOW_OFFLOAD_ROUTE:
185 flow_offload_route_release(flow);
186 break;
187 default:
188 break;
189 }
da5984e5 190 if (flow->flags & FLOW_OFFLOAD_DYING)
b32d2f34
PNA
191 nf_ct_delete(flow->ct, 0, 0);
192 nf_ct_put(flow->ct);
62248df8 193 kfree_rcu(flow, rcu_head);
ac2a6666
PNA
194}
195EXPORT_SYMBOL_GPL(flow_offload_free);
196
a268de77
FF
197static u32 flow_offload_hash(const void *data, u32 len, u32 seed)
198{
199 const struct flow_offload_tuple *tuple = data;
200
201 return jhash(tuple, offsetof(struct flow_offload_tuple, dir), seed);
202}
203
204static u32 flow_offload_hash_obj(const void *data, u32 len, u32 seed)
205{
206 const struct flow_offload_tuple_rhash *tuplehash = data;
207
208 return jhash(&tuplehash->tuple, offsetof(struct flow_offload_tuple, dir), seed);
209}
210
211static int flow_offload_hash_cmp(struct rhashtable_compare_arg *arg,
212 const void *ptr)
213{
214 const struct flow_offload_tuple *tuple = arg->key;
215 const struct flow_offload_tuple_rhash *x = ptr;
216
217 if (memcmp(&x->tuple, tuple, offsetof(struct flow_offload_tuple, dir)))
218 return 1;
219
220 return 0;
221}
222
223static const struct rhashtable_params nf_flow_offload_rhash_params = {
224 .head_offset = offsetof(struct flow_offload_tuple_rhash, node),
225 .hashfn = flow_offload_hash,
226 .obj_hashfn = flow_offload_hash_obj,
227 .obj_cmpfn = flow_offload_hash_cmp,
228 .automatic_shrinking = true,
229};
230
ac2a6666
PNA
231int flow_offload_add(struct nf_flowtable *flow_table, struct flow_offload *flow)
232{
43c8f131
TY
233 int err;
234
daf61b02
PNA
235 flow->timeout = (u32)jiffies + NF_FLOW_TIMEOUT;
236
43c8f131
TY
237 err = rhashtable_insert_fast(&flow_table->rhashtable,
238 &flow->tuplehash[0].node,
239 nf_flow_offload_rhash_params);
240 if (err < 0)
241 return err;
242
243 err = rhashtable_insert_fast(&flow_table->rhashtable,
244 &flow->tuplehash[1].node,
245 nf_flow_offload_rhash_params);
246 if (err < 0) {
247 rhashtable_remove_fast(&flow_table->rhashtable,
248 &flow->tuplehash[0].node,
249 nf_flow_offload_rhash_params);
250 return err;
251 }
ac2a6666 252
c29f74e0
PNA
253 if (flow_table->flags & NF_FLOWTABLE_HW_OFFLOAD)
254 nf_flow_offload_add(flow_table, flow);
255
ac2a6666
PNA
256 return 0;
257}
258EXPORT_SYMBOL_GPL(flow_offload_add);
259
3e68db2f
PNA
260static inline bool nf_flow_has_expired(const struct flow_offload *flow)
261{
1e5b2471 262 return nf_flow_timeout_delta(flow->timeout) <= 0;
3e68db2f
PNA
263}
264
0ff90b6c
FF
265static void flow_offload_del(struct nf_flowtable *flow_table,
266 struct flow_offload *flow)
ac2a6666 267{
ac2a6666
PNA
268 rhashtable_remove_fast(&flow_table->rhashtable,
269 &flow->tuplehash[FLOW_OFFLOAD_DIR_ORIGINAL].node,
a268de77 270 nf_flow_offload_rhash_params);
ac2a6666
PNA
271 rhashtable_remove_fast(&flow_table->rhashtable,
272 &flow->tuplehash[FLOW_OFFLOAD_DIR_REPLY].node,
a268de77 273 nf_flow_offload_rhash_params);
ac2a6666 274
b32d2f34 275 clear_bit(IPS_OFFLOAD_BIT, &flow->ct->status);
da5984e5 276
3e68db2f 277 if (nf_flow_has_expired(flow))
b32d2f34 278 flow_offload_fixup_ct(flow->ct);
1e5b2471 279 else if (flow->flags & FLOW_OFFLOAD_TEARDOWN)
b32d2f34 280 flow_offload_fixup_ct_timeout(flow->ct);
3e68db2f 281
0ff90b6c 282 flow_offload_free(flow);
ac2a6666 283}
ac2a6666 284
59c466dd
FF
285void flow_offload_teardown(struct flow_offload *flow)
286{
287 flow->flags |= FLOW_OFFLOAD_TEARDOWN;
da5984e5 288
b32d2f34 289 flow_offload_fixup_ct_state(flow->ct);
59c466dd
FF
290}
291EXPORT_SYMBOL_GPL(flow_offload_teardown);
292
ac2a6666
PNA
293struct flow_offload_tuple_rhash *
294flow_offload_lookup(struct nf_flowtable *flow_table,
295 struct flow_offload_tuple *tuple)
296{
ba03137f
FF
297 struct flow_offload_tuple_rhash *tuplehash;
298 struct flow_offload *flow;
299 int dir;
300
a2d88182
TY
301 tuplehash = rhashtable_lookup(&flow_table->rhashtable, tuple,
302 nf_flow_offload_rhash_params);
ba03137f
FF
303 if (!tuplehash)
304 return NULL;
305
306 dir = tuplehash->tuple.dir;
307 flow = container_of(tuplehash, struct flow_offload, tuplehash[dir]);
308 if (flow->flags & (FLOW_OFFLOAD_DYING | FLOW_OFFLOAD_TEARDOWN))
309 return NULL;
310
b32d2f34 311 if (unlikely(nf_ct_is_dying(flow->ct)))
8cd2bc98
TY
312 return NULL;
313
ba03137f 314 return tuplehash;
ac2a6666
PNA
315}
316EXPORT_SYMBOL_GPL(flow_offload_lookup);
317
49de9c09
TY
318static int
319nf_flow_table_iterate(struct nf_flowtable *flow_table,
320 void (*iter)(struct flow_offload *flow, void *data),
321 void *data)
ac2a6666
PNA
322{
323 struct flow_offload_tuple_rhash *tuplehash;
324 struct rhashtable_iter hti;
325 struct flow_offload *flow;
0de22baa 326 int err = 0;
ac2a6666 327
0de22baa 328 rhashtable_walk_enter(&flow_table->rhashtable, &hti);
ac2a6666
PNA
329 rhashtable_walk_start(&hti);
330
331 while ((tuplehash = rhashtable_walk_next(&hti))) {
332 if (IS_ERR(tuplehash)) {
0de22baa
TY
333 if (PTR_ERR(tuplehash) != -EAGAIN) {
334 err = PTR_ERR(tuplehash);
335 break;
336 }
ac2a6666
PNA
337 continue;
338 }
339 if (tuplehash->tuple.dir)
340 continue;
341
342 flow = container_of(tuplehash, struct flow_offload, tuplehash[0]);
343
344 iter(flow, data);
345 }
ac2a6666
PNA
346 rhashtable_walk_stop(&hti);
347 rhashtable_walk_exit(&hti);
348
349 return err;
350}
ac2a6666 351
b9660987 352static void nf_flow_offload_gc_step(struct flow_offload *flow, void *data)
ac2a6666 353{
b9660987 354 struct nf_flowtable *flow_table = data;
ac2a6666 355
c29f74e0
PNA
356 if (flow->flags & FLOW_OFFLOAD_HW)
357 nf_flow_offload_stats(flow_table, flow);
358
b32d2f34 359 if (nf_flow_has_expired(flow) || nf_ct_is_dying(flow->ct) ||
c29f74e0
PNA
360 (flow->flags & (FLOW_OFFLOAD_DYING | FLOW_OFFLOAD_TEARDOWN))) {
361 if (flow->flags & FLOW_OFFLOAD_HW) {
362 if (!(flow->flags & FLOW_OFFLOAD_HW_DYING))
363 nf_flow_offload_del(flow_table, flow);
364 else if (flow->flags & FLOW_OFFLOAD_HW_DEAD)
365 flow_offload_del(flow_table, flow);
366 } else {
367 flow_offload_del(flow_table, flow);
368 }
369 }
b408c5b0
PNA
370}
371
a268de77 372static void nf_flow_offload_work_gc(struct work_struct *work)
b408c5b0
PNA
373{
374 struct nf_flowtable *flow_table;
375
376 flow_table = container_of(work, struct nf_flowtable, gc_work.work);
b9660987 377 nf_flow_table_iterate(flow_table, nf_flow_offload_gc_step, flow_table);
ac2a6666
PNA
378 queue_delayed_work(system_power_efficient_wq, &flow_table->gc_work, HZ);
379}
ac2a6666
PNA
380
381static int nf_flow_nat_port_tcp(struct sk_buff *skb, unsigned int thoff,
382 __be16 port, __be16 new_port)
383{
384 struct tcphdr *tcph;
385
386 if (!pskb_may_pull(skb, thoff + sizeof(*tcph)) ||
387 skb_try_make_writable(skb, thoff + sizeof(*tcph)))
388 return -1;
389
390 tcph = (void *)(skb_network_header(skb) + thoff);
391 inet_proto_csum_replace2(&tcph->check, skb, port, new_port, true);
392
393 return 0;
394}
395
396static int nf_flow_nat_port_udp(struct sk_buff *skb, unsigned int thoff,
397 __be16 port, __be16 new_port)
398{
399 struct udphdr *udph;
400
401 if (!pskb_may_pull(skb, thoff + sizeof(*udph)) ||
402 skb_try_make_writable(skb, thoff + sizeof(*udph)))
403 return -1;
404
405 udph = (void *)(skb_network_header(skb) + thoff);
406 if (udph->check || skb->ip_summed == CHECKSUM_PARTIAL) {
407 inet_proto_csum_replace2(&udph->check, skb, port,
408 new_port, true);
409 if (!udph->check)
410 udph->check = CSUM_MANGLED_0;
411 }
412
413 return 0;
414}
415
416static int nf_flow_nat_port(struct sk_buff *skb, unsigned int thoff,
417 u8 protocol, __be16 port, __be16 new_port)
418{
419 switch (protocol) {
420 case IPPROTO_TCP:
421 if (nf_flow_nat_port_tcp(skb, thoff, port, new_port) < 0)
422 return NF_DROP;
423 break;
424 case IPPROTO_UDP:
425 if (nf_flow_nat_port_udp(skb, thoff, port, new_port) < 0)
426 return NF_DROP;
427 break;
428 }
429
430 return 0;
431}
432
433int nf_flow_snat_port(const struct flow_offload *flow,
434 struct sk_buff *skb, unsigned int thoff,
435 u8 protocol, enum flow_offload_tuple_dir dir)
436{
437 struct flow_ports *hdr;
438 __be16 port, new_port;
439
440 if (!pskb_may_pull(skb, thoff + sizeof(*hdr)) ||
441 skb_try_make_writable(skb, thoff + sizeof(*hdr)))
442 return -1;
443
444 hdr = (void *)(skb_network_header(skb) + thoff);
445
446 switch (dir) {
447 case FLOW_OFFLOAD_DIR_ORIGINAL:
448 port = hdr->source;
449 new_port = flow->tuplehash[FLOW_OFFLOAD_DIR_REPLY].tuple.dst_port;
450 hdr->source = new_port;
451 break;
452 case FLOW_OFFLOAD_DIR_REPLY:
453 port = hdr->dest;
454 new_port = flow->tuplehash[FLOW_OFFLOAD_DIR_ORIGINAL].tuple.src_port;
455 hdr->dest = new_port;
456 break;
457 default:
458 return -1;
459 }
460
461 return nf_flow_nat_port(skb, thoff, protocol, port, new_port);
462}
463EXPORT_SYMBOL_GPL(nf_flow_snat_port);
464
465int nf_flow_dnat_port(const struct flow_offload *flow,
466 struct sk_buff *skb, unsigned int thoff,
467 u8 protocol, enum flow_offload_tuple_dir dir)
468{
469 struct flow_ports *hdr;
470 __be16 port, new_port;
471
472 if (!pskb_may_pull(skb, thoff + sizeof(*hdr)) ||
473 skb_try_make_writable(skb, thoff + sizeof(*hdr)))
474 return -1;
475
476 hdr = (void *)(skb_network_header(skb) + thoff);
477
478 switch (dir) {
479 case FLOW_OFFLOAD_DIR_ORIGINAL:
480 port = hdr->dest;
481 new_port = flow->tuplehash[FLOW_OFFLOAD_DIR_REPLY].tuple.src_port;
482 hdr->dest = new_port;
483 break;
484 case FLOW_OFFLOAD_DIR_REPLY:
485 port = hdr->source;
486 new_port = flow->tuplehash[FLOW_OFFLOAD_DIR_ORIGINAL].tuple.dst_port;
487 hdr->source = new_port;
488 break;
489 default:
490 return -1;
491 }
492
493 return nf_flow_nat_port(skb, thoff, protocol, port, new_port);
494}
495EXPORT_SYMBOL_GPL(nf_flow_dnat_port);
496
a268de77
FF
497int nf_flow_table_init(struct nf_flowtable *flowtable)
498{
499 int err;
500
501 INIT_DEFERRABLE_WORK(&flowtable->gc_work, nf_flow_offload_work_gc);
c29f74e0 502 flow_block_init(&flowtable->flow_block);
a268de77
FF
503
504 err = rhashtable_init(&flowtable->rhashtable,
505 &nf_flow_offload_rhash_params);
506 if (err < 0)
507 return err;
508
509 queue_delayed_work(system_power_efficient_wq,
510 &flowtable->gc_work, HZ);
511
84453a90
FF
512 mutex_lock(&flowtable_lock);
513 list_add(&flowtable->list, &flowtables);
514 mutex_unlock(&flowtable_lock);
515
a268de77
FF
516 return 0;
517}
518EXPORT_SYMBOL_GPL(nf_flow_table_init);
519
c0ea1bcb
PNA
520static void nf_flow_table_do_cleanup(struct flow_offload *flow, void *data)
521{
522 struct net_device *dev = data;
523
59c466dd
FF
524 if (!dev) {
525 flow_offload_teardown(flow);
c0ea1bcb 526 return;
59c466dd 527 }
b32d2f34
PNA
528
529 if (net_eq(nf_ct_net(flow->ct), dev_net(dev)) &&
a3fb3698
TY
530 (flow->tuplehash[0].tuple.iifidx == dev->ifindex ||
531 flow->tuplehash[1].tuple.iifidx == dev->ifindex))
59c466dd 532 flow_offload_dead(flow);
c0ea1bcb
PNA
533}
534
535static void nf_flow_table_iterate_cleanup(struct nf_flowtable *flowtable,
84453a90 536 struct net_device *dev)
c0ea1bcb 537{
c29f74e0 538 nf_flow_table_offload_flush(flowtable);
84453a90 539 nf_flow_table_iterate(flowtable, nf_flow_table_do_cleanup, dev);
c0ea1bcb
PNA
540 flush_delayed_work(&flowtable->gc_work);
541}
542
5f1be84a 543void nf_flow_table_cleanup(struct net_device *dev)
c0ea1bcb 544{
84453a90
FF
545 struct nf_flowtable *flowtable;
546
547 mutex_lock(&flowtable_lock);
548 list_for_each_entry(flowtable, &flowtables, list)
549 nf_flow_table_iterate_cleanup(flowtable, dev);
550 mutex_unlock(&flowtable_lock);
c0ea1bcb
PNA
551}
552EXPORT_SYMBOL_GPL(nf_flow_table_cleanup);
553
b408c5b0
PNA
554void nf_flow_table_free(struct nf_flowtable *flow_table)
555{
84453a90
FF
556 mutex_lock(&flowtable_lock);
557 list_del(&flow_table->list);
558 mutex_unlock(&flowtable_lock);
a268de77 559 cancel_delayed_work_sync(&flow_table->gc_work);
b408c5b0 560 nf_flow_table_iterate(flow_table, nf_flow_table_do_cleanup, NULL);
b9660987 561 nf_flow_table_iterate(flow_table, nf_flow_offload_gc_step, flow_table);
a268de77 562 rhashtable_destroy(&flow_table->rhashtable);
b408c5b0
PNA
563}
564EXPORT_SYMBOL_GPL(nf_flow_table_free);
565
c29f74e0
PNA
566static int __init nf_flow_table_module_init(void)
567{
568 return nf_flow_table_offload_init();
569}
570
571static void __exit nf_flow_table_module_exit(void)
572{
573 nf_flow_table_offload_exit();
574}
575
576module_init(nf_flow_table_module_init);
577module_exit(nf_flow_table_module_exit);
578
ac2a6666
PNA
579MODULE_LICENSE("GPL");
580MODULE_AUTHOR("Pablo Neira Ayuso <pablo@netfilter.org>");