]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/blame - net/tipc/node.c
tipc: introduce new function tipc_msg_create()
[mirror_ubuntu-bionic-kernel.git] / net / tipc / node.c
CommitLineData
b97bf3fd
PL
1/*
2 * net/tipc/node.c: TIPC node management routines
c4307285 3 *
16e166b8 4 * Copyright (c) 2000-2006, 2012-2014, Ericsson AB
46651c59 5 * Copyright (c) 2005-2006, 2010-2014, Wind River Systems
b97bf3fd
PL
6 * All rights reserved.
7 *
9ea1fd3c 8 * Redistribution and use in source and binary forms, with or without
b97bf3fd
PL
9 * modification, are permitted provided that the following conditions are met:
10 *
9ea1fd3c
PL
11 * 1. Redistributions of source code must retain the above copyright
12 * notice, this list of conditions and the following disclaimer.
13 * 2. Redistributions in binary form must reproduce the above copyright
14 * notice, this list of conditions and the following disclaimer in the
15 * documentation and/or other materials provided with the distribution.
16 * 3. Neither the names of the copyright holders nor the names of its
17 * contributors may be used to endorse or promote products derived from
18 * this software without specific prior written permission.
b97bf3fd 19 *
9ea1fd3c
PL
20 * Alternatively, this software may be distributed under the terms of the
21 * GNU General Public License ("GPL") version 2 as published by the Free
22 * Software Foundation.
23 *
24 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
25 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
26 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
27 * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
28 * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
29 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
30 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
31 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
32 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
33 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
b97bf3fd
PL
34 * POSSIBILITY OF SUCH DAMAGE.
35 */
36
37#include "core.h"
38#include "config.h"
39#include "node.h"
b97bf3fd 40#include "name_distr.h"
b97bf3fd 41
a635b46b
AS
42#define NODE_HTABLE_SIZE 512
43
6c00055a
DM
44static void node_lost_contact(struct tipc_node *n_ptr);
45static void node_established_contact(struct tipc_node *n_ptr);
b97bf3fd 46
672d99e1
AS
47static struct hlist_head node_htable[NODE_HTABLE_SIZE];
48LIST_HEAD(tipc_node_list);
49static u32 tipc_num_nodes;
dde20266 50static u32 tipc_num_links;
46651c59 51static DEFINE_SPINLOCK(node_list_lock);
34e46258 52
a635b46b
AS
53/*
54 * A trivial power-of-two bitmask technique is used for speed, since this
55 * operation is done for every incoming TIPC packet. The number of hash table
56 * entries has been chosen so that no hash chain exceeds 8 nodes and will
57 * usually be much smaller (typically only a single node).
58 */
872f24db 59static unsigned int tipc_hashfn(u32 addr)
a635b46b
AS
60{
61 return addr & (NODE_HTABLE_SIZE - 1);
62}
63
1ec2bb08 64/*
672d99e1
AS
65 * tipc_node_find - locate specified node object, if it exists
66 */
672d99e1
AS
67struct tipc_node *tipc_node_find(u32 addr)
68{
69 struct tipc_node *node;
672d99e1 70
336ebf5b 71 if (unlikely(!in_own_cluster_exact(addr)))
672d99e1
AS
72 return NULL;
73
6c7a762e
YX
74 rcu_read_lock();
75 hlist_for_each_entry_rcu(node, &node_htable[tipc_hashfn(addr)], hash) {
46651c59 76 if (node->addr == addr) {
6c7a762e 77 rcu_read_unlock();
672d99e1 78 return node;
46651c59 79 }
672d99e1 80 }
6c7a762e 81 rcu_read_unlock();
672d99e1
AS
82 return NULL;
83}
84
6c00055a 85struct tipc_node *tipc_node_create(u32 addr)
b97bf3fd 86{
672d99e1 87 struct tipc_node *n_ptr, *temp_node;
b97bf3fd 88
46651c59 89 spin_lock_bh(&node_list_lock);
2ecb0924 90
5af54792 91 n_ptr = kzalloc(sizeof(*n_ptr), GFP_ATOMIC);
a10bd924 92 if (!n_ptr) {
46651c59 93 spin_unlock_bh(&node_list_lock);
2cf8aa19 94 pr_warn("Node creation failed, no memory\n");
a10bd924
AS
95 return NULL;
96 }
97
a10bd924 98 n_ptr->addr = addr;
51a8e4de 99 spin_lock_init(&n_ptr->lock);
672d99e1
AS
100 INIT_HLIST_NODE(&n_ptr->hash);
101 INIT_LIST_HEAD(&n_ptr->list);
a10bd924 102 INIT_LIST_HEAD(&n_ptr->nsub);
8f92df6a 103
6c7a762e 104 hlist_add_head_rcu(&n_ptr->hash, &node_htable[tipc_hashfn(addr)]);
672d99e1 105
6c7a762e 106 list_for_each_entry_rcu(temp_node, &tipc_node_list, list) {
672d99e1
AS
107 if (n_ptr->addr < temp_node->addr)
108 break;
109 }
6c7a762e 110 list_add_tail_rcu(&n_ptr->list, &temp_node->list);
aecb9bb8 111 n_ptr->action_flags = TIPC_WAIT_PEER_LINKS_DOWN;
fc0eea69 112 n_ptr->signature = INVALID_NODE_SIG;
672d99e1
AS
113
114 tipc_num_nodes++;
a10bd924 115
46651c59 116 spin_unlock_bh(&node_list_lock);
b97bf3fd
PL
117 return n_ptr;
118}
119
46651c59 120static void tipc_node_delete(struct tipc_node *n_ptr)
b97bf3fd 121{
6c7a762e
YX
122 list_del_rcu(&n_ptr->list);
123 hlist_del_rcu(&n_ptr->hash);
124 kfree_rcu(n_ptr, rcu);
8f92df6a 125
672d99e1 126 tipc_num_nodes--;
b97bf3fd
PL
127}
128
46651c59
YX
129void tipc_node_stop(void)
130{
131 struct tipc_node *node, *t_node;
132
133 spin_lock_bh(&node_list_lock);
134 list_for_each_entry_safe(node, t_node, &tipc_node_list, list)
135 tipc_node_delete(node);
136 spin_unlock_bh(&node_list_lock);
137}
138
b97bf3fd 139/**
4323add6 140 * tipc_node_link_up - handle addition of link
c4307285 141 *
b97bf3fd
PL
142 * Link becomes active (alone or shared) or standby, depending on its priority.
143 */
a18c4bc3 144void tipc_node_link_up(struct tipc_node *n_ptr, struct tipc_link *l_ptr)
b97bf3fd 145{
a18c4bc3 146 struct tipc_link **active = &n_ptr->active_links[0];
a89778d8 147 u32 addr = n_ptr->addr;
b97bf3fd 148
5392d646 149 n_ptr->working_links++;
a89778d8
EH
150 tipc_nametbl_publish(TIPC_LINK_STATE, addr, addr, TIPC_NODE_SCOPE,
151 l_ptr->bearer_id, addr);
2cf8aa19 152 pr_info("Established link <%s> on network plane %c\n",
7a2f7d18 153 l_ptr->name, l_ptr->net_plane);
c4307285 154
b97bf3fd 155 if (!active[0]) {
b97bf3fd
PL
156 active[0] = active[1] = l_ptr;
157 node_established_contact(n_ptr);
16e166b8 158 goto exit;
b97bf3fd 159 }
c4307285 160 if (l_ptr->priority < active[0]->priority) {
2cf8aa19 161 pr_info("New link <%s> becomes standby\n", l_ptr->name);
16e166b8 162 goto exit;
b97bf3fd 163 }
247f0f3c 164 tipc_link_dup_queue_xmit(active[0], l_ptr);
c4307285 165 if (l_ptr->priority == active[0]->priority) {
b97bf3fd 166 active[0] = l_ptr;
16e166b8 167 goto exit;
b97bf3fd 168 }
2cf8aa19 169 pr_info("Old link <%s> becomes standby\n", active[0]->name);
a10bd924 170 if (active[1] != active[0])
2cf8aa19 171 pr_info("Old link <%s> becomes standby\n", active[1]->name);
b97bf3fd 172 active[0] = active[1] = l_ptr;
16e166b8
JPM
173exit:
174 /* Leave room for changeover header when returning 'mtu' to users: */
175 n_ptr->act_mtus[0] = active[0]->max_pkt - INT_H_SIZE;
176 n_ptr->act_mtus[1] = active[1]->max_pkt - INT_H_SIZE;
b97bf3fd
PL
177}
178
179/**
180 * node_select_active_links - select active link
181 */
6c00055a 182static void node_select_active_links(struct tipc_node *n_ptr)
b97bf3fd 183{
a18c4bc3 184 struct tipc_link **active = &n_ptr->active_links[0];
b97bf3fd
PL
185 u32 i;
186 u32 highest_prio = 0;
187
c4307285 188 active[0] = active[1] = NULL;
b97bf3fd
PL
189
190 for (i = 0; i < MAX_BEARERS; i++) {
a18c4bc3 191 struct tipc_link *l_ptr = n_ptr->links[i];
b97bf3fd 192
4323add6 193 if (!l_ptr || !tipc_link_is_up(l_ptr) ||
b97bf3fd
PL
194 (l_ptr->priority < highest_prio))
195 continue;
196
197 if (l_ptr->priority > highest_prio) {
c4307285 198 highest_prio = l_ptr->priority;
b97bf3fd
PL
199 active[0] = active[1] = l_ptr;
200 } else {
201 active[1] = l_ptr;
202 }
203 }
204}
205
206/**
4323add6 207 * tipc_node_link_down - handle loss of link
b97bf3fd 208 */
a18c4bc3 209void tipc_node_link_down(struct tipc_node *n_ptr, struct tipc_link *l_ptr)
b97bf3fd 210{
a18c4bc3 211 struct tipc_link **active;
a89778d8 212 u32 addr = n_ptr->addr;
b97bf3fd 213
5392d646 214 n_ptr->working_links--;
a89778d8 215 tipc_nametbl_withdraw(TIPC_LINK_STATE, addr, l_ptr->bearer_id, addr);
5392d646 216
4323add6 217 if (!tipc_link_is_active(l_ptr)) {
2cf8aa19 218 pr_info("Lost standby link <%s> on network plane %c\n",
7a2f7d18 219 l_ptr->name, l_ptr->net_plane);
b97bf3fd
PL
220 return;
221 }
2cf8aa19 222 pr_info("Lost link <%s> on network plane %c\n",
7a2f7d18 223 l_ptr->name, l_ptr->net_plane);
b97bf3fd
PL
224
225 active = &n_ptr->active_links[0];
226 if (active[0] == l_ptr)
227 active[0] = active[1];
228 if (active[1] == l_ptr)
229 active[1] = active[0];
230 if (active[0] == l_ptr)
231 node_select_active_links(n_ptr);
c4307285 232 if (tipc_node_is_up(n_ptr))
170b3927 233 tipc_link_failover_send_queue(l_ptr);
c4307285 234 else
b97bf3fd 235 node_lost_contact(n_ptr);
16e166b8
JPM
236
237 /* Leave room for changeover header when returning 'mtu' to users: */
238 if (active[0]) {
239 n_ptr->act_mtus[0] = active[0]->max_pkt - INT_H_SIZE;
240 n_ptr->act_mtus[1] = active[1]->max_pkt - INT_H_SIZE;
241 return;
242 }
243
244 /* Loopback link went down? No fragmentation needed from now on. */
245 if (n_ptr->addr == tipc_own_addr) {
246 n_ptr->act_mtus[0] = MAX_MSG_SIZE;
247 n_ptr->act_mtus[1] = MAX_MSG_SIZE;
248 }
b97bf3fd
PL
249}
250
8f19afb2 251int tipc_node_active_links(struct tipc_node *n_ptr)
b97bf3fd 252{
76ae0d71 253 return n_ptr->active_links[0] != NULL;
b97bf3fd
PL
254}
255
6c00055a 256int tipc_node_is_up(struct tipc_node *n_ptr)
b97bf3fd 257{
8f19afb2 258 return tipc_node_active_links(n_ptr);
b97bf3fd
PL
259}
260
a18c4bc3 261void tipc_node_attach_link(struct tipc_node *n_ptr, struct tipc_link *l_ptr)
b97bf3fd 262{
7a2f7d18 263 n_ptr->links[l_ptr->bearer_id] = l_ptr;
dde20266
YX
264 spin_lock_bh(&node_list_lock);
265 tipc_num_links++;
266 spin_unlock_bh(&node_list_lock);
37b9c08a 267 n_ptr->link_cnt++;
b97bf3fd
PL
268}
269
a18c4bc3 270void tipc_node_detach_link(struct tipc_node *n_ptr, struct tipc_link *l_ptr)
b97bf3fd 271{
7d33939f
JPM
272 int i;
273
274 for (i = 0; i < MAX_BEARERS; i++) {
074bb43e
JPM
275 if (l_ptr != n_ptr->links[i])
276 continue;
277 n_ptr->links[i] = NULL;
dde20266
YX
278 spin_lock_bh(&node_list_lock);
279 tipc_num_links--;
280 spin_unlock_bh(&node_list_lock);
074bb43e 281 n_ptr->link_cnt--;
7d33939f 282 }
b97bf3fd
PL
283}
284
6c00055a 285static void node_established_contact(struct tipc_node *n_ptr)
b97bf3fd 286{
aecb9bb8 287 n_ptr->action_flags |= TIPC_NOTIFY_NODE_UP;
c64f7a6a 288 n_ptr->bclink.oos_state = 0;
818f4da5
YX
289 n_ptr->bclink.acked = tipc_bclink_get_last_sent();
290 tipc_bclink_add_node(n_ptr->addr);
b97bf3fd
PL
291}
292
6c00055a 293static void node_lost_contact(struct tipc_node *n_ptr)
b97bf3fd 294{
b97bf3fd
PL
295 char addr_string[16];
296 u32 i;
297
2cf8aa19
EH
298 pr_info("Lost contact with %s\n",
299 tipc_addr_string_fill(addr_string, n_ptr->addr));
c5bd4d85
AS
300
301 /* Flush broadcast link info associated with lost node */
389dd9bc 302 if (n_ptr->bclink.recv_permitted) {
d77b3831 303 kfree_skb_list(n_ptr->bclink.deferred_head);
7a54d4a9 304 n_ptr->bclink.deferred_size = 0;
c5bd4d85 305
37e22164
JPM
306 if (n_ptr->bclink.reasm_buf) {
307 kfree_skb(n_ptr->bclink.reasm_buf);
308 n_ptr->bclink.reasm_buf = NULL;
c5bd4d85
AS
309 }
310
cd3decdf 311 tipc_bclink_remove_node(n_ptr->addr);
36559591 312 tipc_bclink_acknowledge(n_ptr, INVALID_LINK_SEQ);
b97bf3fd 313
389dd9bc 314 n_ptr->bclink.recv_permitted = false;
c5bd4d85 315 }
b97bf3fd
PL
316
317 /* Abort link changeover */
318 for (i = 0; i < MAX_BEARERS; i++) {
a18c4bc3 319 struct tipc_link *l_ptr = n_ptr->links[i];
c4307285 320 if (!l_ptr)
b97bf3fd
PL
321 continue;
322 l_ptr->reset_checkpoint = l_ptr->next_in_no;
323 l_ptr->exp_msg_count = 0;
4323add6 324 tipc_link_reset_fragments(l_ptr);
b97bf3fd
PL
325 }
326
ca9cf06a
YX
327 n_ptr->action_flags &= ~TIPC_WAIT_OWN_LINKS_DOWN;
328
9d561949
YX
329 /* Notify subscribers and prevent re-contact with node until
330 * cleanup is done.
331 */
ca9cf06a
YX
332 n_ptr->action_flags |= TIPC_WAIT_PEER_LINKS_DOWN |
333 TIPC_NOTIFY_NODE_DOWN;
b97bf3fd
PL
334}
335
4323add6 336struct sk_buff *tipc_node_get_nodes(const void *req_tlv_area, int req_tlv_space)
b97bf3fd
PL
337{
338 u32 domain;
339 struct sk_buff *buf;
6c00055a 340 struct tipc_node *n_ptr;
c4307285 341 struct tipc_node_info node_info;
ea13847b 342 u32 payload_size;
b97bf3fd
PL
343
344 if (!TLV_CHECK(req_tlv_area, req_tlv_space, TIPC_TLV_NET_ADDR))
4323add6 345 return tipc_cfg_reply_error_string(TIPC_CFG_TLV_ERROR);
b97bf3fd 346
3e6c8cd5 347 domain = ntohl(*(__be32 *)TLV_DATA(req_tlv_area));
4323add6
PL
348 if (!tipc_addr_domain_valid(domain))
349 return tipc_cfg_reply_error_string(TIPC_CFG_INVALID_VALUE
350 " (network address)");
b97bf3fd 351
46651c59 352 spin_lock_bh(&node_list_lock);
672d99e1 353 if (!tipc_num_nodes) {
46651c59 354 spin_unlock_bh(&node_list_lock);
c4307285 355 return tipc_cfg_reply_none();
1aad72d6 356 }
b97bf3fd 357
08c80e9a 358 /* For now, get space for all other nodes */
672d99e1 359 payload_size = TLV_SPACE(sizeof(node_info)) * tipc_num_nodes;
1aad72d6 360 if (payload_size > 32768u) {
46651c59 361 spin_unlock_bh(&node_list_lock);
ea13847b
AS
362 return tipc_cfg_reply_error_string(TIPC_CFG_NOT_SUPPORTED
363 " (too many nodes)");
1aad72d6 364 }
2220646a
YX
365 spin_unlock_bh(&node_list_lock);
366
ea13847b 367 buf = tipc_cfg_reply_alloc(payload_size);
2220646a 368 if (!buf)
b97bf3fd
PL
369 return NULL;
370
371 /* Add TLVs for all nodes in scope */
6c7a762e
YX
372 rcu_read_lock();
373 list_for_each_entry_rcu(n_ptr, &tipc_node_list, list) {
672d99e1 374 if (!tipc_in_scope(domain, n_ptr->addr))
b97bf3fd 375 continue;
c4307285
YH
376 node_info.addr = htonl(n_ptr->addr);
377 node_info.up = htonl(tipc_node_is_up(n_ptr));
378 tipc_cfg_append_tlv(buf, TIPC_TLV_NODE_INFO,
4323add6 379 &node_info, sizeof(node_info));
b97bf3fd 380 }
6c7a762e 381 rcu_read_unlock();
b97bf3fd
PL
382 return buf;
383}
384
4323add6 385struct sk_buff *tipc_node_get_links(const void *req_tlv_area, int req_tlv_space)
b97bf3fd
PL
386{
387 u32 domain;
388 struct sk_buff *buf;
6c00055a 389 struct tipc_node *n_ptr;
c4307285 390 struct tipc_link_info link_info;
ea13847b 391 u32 payload_size;
b97bf3fd
PL
392
393 if (!TLV_CHECK(req_tlv_area, req_tlv_space, TIPC_TLV_NET_ADDR))
4323add6 394 return tipc_cfg_reply_error_string(TIPC_CFG_TLV_ERROR);
b97bf3fd 395
3e6c8cd5 396 domain = ntohl(*(__be32 *)TLV_DATA(req_tlv_area));
4323add6
PL
397 if (!tipc_addr_domain_valid(domain))
398 return tipc_cfg_reply_error_string(TIPC_CFG_INVALID_VALUE
399 " (network address)");
b97bf3fd 400
b58343f9 401 if (!tipc_own_addr)
c4307285
YH
402 return tipc_cfg_reply_none();
403
46651c59 404 spin_lock_bh(&node_list_lock);
7a54d4a9 405 /* Get space for all unicast links + broadcast link */
dde20266 406 payload_size = TLV_SPACE((sizeof(link_info)) * (tipc_num_links + 1));
1aad72d6 407 if (payload_size > 32768u) {
46651c59 408 spin_unlock_bh(&node_list_lock);
ea13847b
AS
409 return tipc_cfg_reply_error_string(TIPC_CFG_NOT_SUPPORTED
410 " (too many links)");
1aad72d6 411 }
dde20266
YX
412 spin_unlock_bh(&node_list_lock);
413
ea13847b 414 buf = tipc_cfg_reply_alloc(payload_size);
dde20266 415 if (!buf)
b97bf3fd
PL
416 return NULL;
417
418 /* Add TLV for broadcast link */
a3796f89 419 link_info.dest = htonl(tipc_cluster_mask(tipc_own_addr));
c4307285 420 link_info.up = htonl(1);
4b704d59 421 strlcpy(link_info.str, tipc_bclink_name, TIPC_MAX_LINK_NAME);
4323add6 422 tipc_cfg_append_tlv(buf, TIPC_TLV_LINK_INFO, &link_info, sizeof(link_info));
b97bf3fd
PL
423
424 /* Add TLVs for any other links in scope */
6c7a762e
YX
425 rcu_read_lock();
426 list_for_each_entry_rcu(n_ptr, &tipc_node_list, list) {
c4307285 427 u32 i;
b97bf3fd 428
672d99e1 429 if (!tipc_in_scope(domain, n_ptr->addr))
b97bf3fd 430 continue;
1aad72d6 431 tipc_node_lock(n_ptr);
c4307285
YH
432 for (i = 0; i < MAX_BEARERS; i++) {
433 if (!n_ptr->links[i])
434 continue;
435 link_info.dest = htonl(n_ptr->addr);
436 link_info.up = htonl(tipc_link_is_up(n_ptr->links[i]));
437 strcpy(link_info.str, n_ptr->links[i]->name);
438 tipc_cfg_append_tlv(buf, TIPC_TLV_LINK_INFO,
4323add6 439 &link_info, sizeof(link_info));
c4307285 440 }
1aad72d6 441 tipc_node_unlock(n_ptr);
b97bf3fd 442 }
6c7a762e 443 rcu_read_unlock();
b97bf3fd
PL
444 return buf;
445}
78acb1f9
EH
446
447/**
448 * tipc_node_get_linkname - get the name of a link
449 *
450 * @bearer_id: id of the bearer
451 * @node: peer node address
452 * @linkname: link name output buffer
453 *
454 * Returns 0 on success
455 */
456int tipc_node_get_linkname(u32 bearer_id, u32 addr, char *linkname, size_t len)
457{
458 struct tipc_link *link;
459 struct tipc_node *node = tipc_node_find(addr);
460
d7bb74c3 461 if ((bearer_id >= MAX_BEARERS) || !node)
78acb1f9
EH
462 return -EINVAL;
463 tipc_node_lock(node);
464 link = node->links[bearer_id];
465 if (link) {
466 strncpy(linkname, link->name, len);
467 tipc_node_unlock(node);
468 return 0;
469 }
470 tipc_node_unlock(node);
471 return -EINVAL;
472}
9db9fdd1
YX
473
474void tipc_node_unlock(struct tipc_node *node)
475{
476 LIST_HEAD(nsub_list);
ca0c4273 477 u32 addr = 0;
9db9fdd1 478
aecb9bb8 479 if (likely(!node->action_flags)) {
9db9fdd1
YX
480 spin_unlock_bh(&node->lock);
481 return;
482 }
483
aecb9bb8 484 if (node->action_flags & TIPC_NOTIFY_NODE_DOWN) {
9db9fdd1 485 list_replace_init(&node->nsub, &nsub_list);
aecb9bb8 486 node->action_flags &= ~TIPC_NOTIFY_NODE_DOWN;
9db9fdd1 487 }
aecb9bb8 488 if (node->action_flags & TIPC_NOTIFY_NODE_UP) {
aecb9bb8 489 node->action_flags &= ~TIPC_NOTIFY_NODE_UP;
dbdf6d24 490 addr = node->addr;
ca0c4273 491 }
9db9fdd1
YX
492 spin_unlock_bh(&node->lock);
493
494 if (!list_empty(&nsub_list))
495 tipc_nodesub_notify(&nsub_list);
dbdf6d24
JPM
496 if (addr)
497 tipc_named_node_up(addr);
9db9fdd1 498}