]>
Commit | Line | Data |
---|---|---|
0a920b5b AW |
1 | #!/usr/bin/perl -w |
2 | # (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit) | |
00df344f | 3 | # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) |
0a920b5b AW |
4 | # (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc) |
5 | # Licensed under the terms of the GNU GPL License version 2 | |
6 | ||
7 | use strict; | |
8 | ||
9 | my $P = $0; | |
00df344f | 10 | $P =~ s@.*/@@g; |
0a920b5b | 11 | |
dea79cd3 | 12 | my $V = '0.22'; |
0a920b5b AW |
13 | |
14 | use Getopt::Long qw(:config no_auto_abbrev); | |
15 | ||
16 | my $quiet = 0; | |
17 | my $tree = 1; | |
18 | my $chk_signoff = 1; | |
19 | my $chk_patch = 1; | |
773647a0 | 20 | my $tst_only; |
6c72ffaa | 21 | my $emacs = 0; |
8905a67c | 22 | my $terse = 0; |
6c72ffaa AW |
23 | my $file = 0; |
24 | my $check = 0; | |
8905a67c AW |
25 | my $summary = 1; |
26 | my $mailback = 0; | |
13214adf | 27 | my $summary_file = 0; |
6c72ffaa | 28 | my $root; |
c2fdda0d | 29 | my %debug; |
0a920b5b | 30 | GetOptions( |
6c72ffaa | 31 | 'q|quiet+' => \$quiet, |
0a920b5b AW |
32 | 'tree!' => \$tree, |
33 | 'signoff!' => \$chk_signoff, | |
34 | 'patch!' => \$chk_patch, | |
6c72ffaa | 35 | 'emacs!' => \$emacs, |
8905a67c | 36 | 'terse!' => \$terse, |
6c72ffaa AW |
37 | 'file!' => \$file, |
38 | 'subjective!' => \$check, | |
39 | 'strict!' => \$check, | |
40 | 'root=s' => \$root, | |
8905a67c AW |
41 | 'summary!' => \$summary, |
42 | 'mailback!' => \$mailback, | |
13214adf AW |
43 | 'summary-file!' => \$summary_file, |
44 | ||
c2fdda0d | 45 | 'debug=s' => \%debug, |
773647a0 | 46 | 'test-only=s' => \$tst_only, |
0a920b5b AW |
47 | ) or exit; |
48 | ||
49 | my $exit = 0; | |
50 | ||
51 | if ($#ARGV < 0) { | |
00df344f | 52 | print "usage: $P [options] patchfile\n"; |
0a920b5b | 53 | print "version: $V\n"; |
13214adf AW |
54 | print "options: -q => quiet\n"; |
55 | print " --no-tree => run without a kernel tree\n"; | |
56 | print " --terse => one line per report\n"; | |
57 | print " --emacs => emacs compile window format\n"; | |
58 | print " --file => check a source file\n"; | |
59 | print " --strict => enable more subjective tests\n"; | |
60 | print " --root => path to the kernel tree root\n"; | |
61 | print " --no-summary => suppress the per-file summary\n"; | |
62 | print " --summary-file => include the filename in summary\n"; | |
0a920b5b AW |
63 | exit(1); |
64 | } | |
65 | ||
c2fdda0d AW |
66 | my $dbg_values = 0; |
67 | my $dbg_possible = 0; | |
7429c690 | 68 | my $dbg_type = 0; |
a1ef277e | 69 | my $dbg_attr = 0; |
c2fdda0d AW |
70 | for my $key (keys %debug) { |
71 | eval "\${dbg_$key} = '$debug{$key}';" | |
72 | } | |
73 | ||
8905a67c AW |
74 | if ($terse) { |
75 | $emacs = 1; | |
76 | $quiet++; | |
77 | } | |
78 | ||
6c72ffaa AW |
79 | if ($tree) { |
80 | if (defined $root) { | |
81 | if (!top_of_kernel_tree($root)) { | |
82 | die "$P: $root: --root does not point at a valid tree\n"; | |
83 | } | |
84 | } else { | |
85 | if (top_of_kernel_tree('.')) { | |
86 | $root = '.'; | |
87 | } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ && | |
88 | top_of_kernel_tree($1)) { | |
89 | $root = $1; | |
90 | } | |
91 | } | |
92 | ||
93 | if (!defined $root) { | |
94 | print "Must be run from the top-level dir. of a kernel tree\n"; | |
95 | exit(2); | |
96 | } | |
0a920b5b AW |
97 | } |
98 | ||
6c72ffaa AW |
99 | my $emitted_corrupt = 0; |
100 | ||
101 | our $Ident = qr{[A-Za-z_][A-Za-z\d_]*}; | |
102 | our $Storage = qr{extern|static|asmlinkage}; | |
103 | our $Sparse = qr{ | |
104 | __user| | |
105 | __kernel| | |
106 | __force| | |
107 | __iomem| | |
108 | __must_check| | |
109 | __init_refok| | |
cf655043 | 110 | __kprobes |
6c72ffaa AW |
111 | }x; |
112 | our $Attribute = qr{ | |
113 | const| | |
114 | __read_mostly| | |
115 | __kprobes| | |
24e1d81a AW |
116 | __(?:mem|cpu|dev|)(?:initdata|init)| |
117 | ____cacheline_aligned| | |
118 | ____cacheline_aligned_in_smp| | |
119 | ____cacheline_internodealigned_in_smp | |
6c72ffaa | 120 | }x; |
c45dcabd | 121 | our $Modifier; |
6c72ffaa | 122 | our $Inline = qr{inline|__always_inline|noinline}; |
6c72ffaa AW |
123 | our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]}; |
124 | our $Lval = qr{$Ident(?:$Member)*}; | |
125 | ||
126 | our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*}; | |
127 | our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)}; | |
128 | our $Operators = qr{ | |
129 | <=|>=|==|!=| | |
130 | =>|->|<<|>>|<|>|!|~| | |
c2fdda0d | 131 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% |
6c72ffaa AW |
132 | }x; |
133 | ||
8905a67c AW |
134 | our $NonptrType; |
135 | our $Type; | |
136 | our $Declare; | |
137 | ||
171ae1a4 AW |
138 | our $UTF8 = qr { |
139 | [\x09\x0A\x0D\x20-\x7E] # ASCII | |
140 | | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte | |
141 | | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs | |
142 | | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte | |
143 | | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates | |
144 | | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3 | |
145 | | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 | |
146 | | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 | |
147 | }x; | |
148 | ||
8905a67c AW |
149 | our @typeList = ( |
150 | qr{void}, | |
c45dcabd AW |
151 | qr{(?:unsigned\s+)?char}, |
152 | qr{(?:unsigned\s+)?short}, | |
153 | qr{(?:unsigned\s+)?int}, | |
154 | qr{(?:unsigned\s+)?long}, | |
155 | qr{(?:unsigned\s+)?long\s+int}, | |
156 | qr{(?:unsigned\s+)?long\s+long}, | |
157 | qr{(?:unsigned\s+)?long\s+long\s+int}, | |
8905a67c AW |
158 | qr{unsigned}, |
159 | qr{float}, | |
160 | qr{double}, | |
161 | qr{bool}, | |
8905a67c AW |
162 | qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)}, |
163 | qr{struct\s+$Ident}, | |
164 | qr{union\s+$Ident}, | |
165 | qr{enum\s+$Ident}, | |
166 | qr{${Ident}_t}, | |
167 | qr{${Ident}_handler}, | |
168 | qr{${Ident}_handler_fn}, | |
169 | ); | |
c45dcabd AW |
170 | our @modifierList = ( |
171 | qr{fastcall}, | |
172 | ); | |
8905a67c AW |
173 | |
174 | sub build_types { | |
d2172eb5 AW |
175 | my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)"; |
176 | my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)"; | |
c8cb2ca3 | 177 | $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; |
8905a67c | 178 | $NonptrType = qr{ |
d2172eb5 | 179 | (?:$Modifier\s+|const\s+)* |
cf655043 | 180 | (?: |
c45dcabd AW |
181 | (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| |
182 | (?:${all}\b) | |
cf655043 | 183 | ) |
c8cb2ca3 | 184 | (?:\s+$Modifier|\s+const)* |
8905a67c AW |
185 | }x; |
186 | $Type = qr{ | |
c45dcabd | 187 | $NonptrType |
8905a67c | 188 | (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)? |
c8cb2ca3 | 189 | (?:\s+$Inline|\s+$Modifier)* |
8905a67c AW |
190 | }x; |
191 | $Declare = qr{(?:$Storage\s+)?$Type}; | |
192 | } | |
193 | build_types(); | |
6c72ffaa AW |
194 | |
195 | $chk_signoff = 0 if ($file); | |
196 | ||
4a0df2ef AW |
197 | my @dep_includes = (); |
198 | my @dep_functions = (); | |
6c72ffaa AW |
199 | my $removal = "Documentation/feature-removal-schedule.txt"; |
200 | if ($tree && -f "$root/$removal") { | |
201 | open(REMOVE, "<$root/$removal") || | |
202 | die "$P: $removal: open failed - $!\n"; | |
0a920b5b | 203 | while (<REMOVE>) { |
f0a594c1 AW |
204 | if (/^Check:\s+(.*\S)/) { |
205 | for my $entry (split(/[, ]+/, $1)) { | |
206 | if ($entry =~ m@include/(.*)@) { | |
4a0df2ef | 207 | push(@dep_includes, $1); |
4a0df2ef | 208 | |
f0a594c1 AW |
209 | } elsif ($entry !~ m@/@) { |
210 | push(@dep_functions, $entry); | |
211 | } | |
4a0df2ef | 212 | } |
0a920b5b AW |
213 | } |
214 | } | |
215 | } | |
216 | ||
00df344f | 217 | my @rawlines = (); |
c2fdda0d AW |
218 | my @lines = (); |
219 | my $vname; | |
6c72ffaa AW |
220 | for my $filename (@ARGV) { |
221 | if ($file) { | |
222 | open(FILE, "diff -u /dev/null $filename|") || | |
223 | die "$P: $filename: diff failed - $!\n"; | |
224 | } else { | |
225 | open(FILE, "<$filename") || | |
226 | die "$P: $filename: open failed - $!\n"; | |
0a920b5b | 227 | } |
c2fdda0d AW |
228 | if ($filename eq '-') { |
229 | $vname = 'Your patch'; | |
230 | } else { | |
231 | $vname = $filename; | |
232 | } | |
6c72ffaa AW |
233 | while (<FILE>) { |
234 | chomp; | |
235 | push(@rawlines, $_); | |
236 | } | |
237 | close(FILE); | |
c2fdda0d | 238 | if (!process($filename)) { |
6c72ffaa AW |
239 | $exit = 1; |
240 | } | |
241 | @rawlines = (); | |
13214adf | 242 | @lines = (); |
0a920b5b AW |
243 | } |
244 | ||
245 | exit($exit); | |
246 | ||
247 | sub top_of_kernel_tree { | |
6c72ffaa AW |
248 | my ($root) = @_; |
249 | ||
250 | my @tree_check = ( | |
251 | "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile", | |
252 | "README", "Documentation", "arch", "include", "drivers", | |
253 | "fs", "init", "ipc", "kernel", "lib", "scripts", | |
254 | ); | |
255 | ||
256 | foreach my $check (@tree_check) { | |
257 | if (! -e $root . '/' . $check) { | |
258 | return 0; | |
259 | } | |
0a920b5b | 260 | } |
6c72ffaa | 261 | return 1; |
0a920b5b AW |
262 | } |
263 | ||
264 | sub expand_tabs { | |
265 | my ($str) = @_; | |
266 | ||
267 | my $res = ''; | |
268 | my $n = 0; | |
269 | for my $c (split(//, $str)) { | |
270 | if ($c eq "\t") { | |
271 | $res .= ' '; | |
272 | $n++; | |
273 | for (; ($n % 8) != 0; $n++) { | |
274 | $res .= ' '; | |
275 | } | |
276 | next; | |
277 | } | |
278 | $res .= $c; | |
279 | $n++; | |
280 | } | |
281 | ||
282 | return $res; | |
283 | } | |
6c72ffaa | 284 | sub copy_spacing { |
773647a0 | 285 | (my $res = shift) =~ tr/\t/ /c; |
6c72ffaa AW |
286 | return $res; |
287 | } | |
0a920b5b | 288 | |
4a0df2ef AW |
289 | sub line_stats { |
290 | my ($line) = @_; | |
291 | ||
292 | # Drop the diff line leader and expand tabs | |
293 | $line =~ s/^.//; | |
294 | $line = expand_tabs($line); | |
295 | ||
296 | # Pick the indent from the front of the line. | |
297 | my ($white) = ($line =~ /^(\s*)/); | |
298 | ||
299 | return (length($line), length($white)); | |
300 | } | |
301 | ||
773647a0 AW |
302 | my $sanitise_quote = ''; |
303 | ||
304 | sub sanitise_line_reset { | |
305 | my ($in_comment) = @_; | |
306 | ||
307 | if ($in_comment) { | |
308 | $sanitise_quote = '*/'; | |
309 | } else { | |
310 | $sanitise_quote = ''; | |
311 | } | |
312 | } | |
00df344f AW |
313 | sub sanitise_line { |
314 | my ($line) = @_; | |
315 | ||
316 | my $res = ''; | |
317 | my $l = ''; | |
318 | ||
c2fdda0d | 319 | my $qlen = 0; |
773647a0 AW |
320 | my $off = 0; |
321 | my $c; | |
00df344f | 322 | |
773647a0 AW |
323 | # Always copy over the diff marker. |
324 | $res = substr($line, 0, 1); | |
325 | ||
326 | for ($off = 1; $off < length($line); $off++) { | |
327 | $c = substr($line, $off, 1); | |
328 | ||
329 | # Comments we are wacking completly including the begin | |
330 | # and end, all to $;. | |
331 | if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') { | |
332 | $sanitise_quote = '*/'; | |
333 | ||
334 | substr($res, $off, 2, "$;$;"); | |
335 | $off++; | |
336 | next; | |
00df344f | 337 | } |
c45dcabd | 338 | if (substr($line, $off, 2) eq '*/') { |
773647a0 AW |
339 | $sanitise_quote = ''; |
340 | substr($res, $off, 2, "$;$;"); | |
341 | $off++; | |
342 | next; | |
c2fdda0d | 343 | } |
773647a0 AW |
344 | |
345 | # A \ in a string means ignore the next character. | |
346 | if (($sanitise_quote eq "'" || $sanitise_quote eq '"') && | |
347 | $c eq "\\") { | |
348 | substr($res, $off, 2, 'XX'); | |
349 | $off++; | |
350 | next; | |
00df344f | 351 | } |
773647a0 AW |
352 | # Regular quotes. |
353 | if ($c eq "'" || $c eq '"') { | |
354 | if ($sanitise_quote eq '') { | |
355 | $sanitise_quote = $c; | |
00df344f | 356 | |
773647a0 AW |
357 | substr($res, $off, 1, $c); |
358 | next; | |
359 | } elsif ($sanitise_quote eq $c) { | |
360 | $sanitise_quote = ''; | |
361 | } | |
362 | } | |
00df344f | 363 | |
773647a0 AW |
364 | #print "SQ:$sanitise_quote\n"; |
365 | if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") { | |
366 | substr($res, $off, 1, $;); | |
367 | } elsif ($off != 0 && $sanitise_quote && $c ne "\t") { | |
368 | substr($res, $off, 1, 'X'); | |
369 | } else { | |
370 | substr($res, $off, 1, $c); | |
371 | } | |
c2fdda0d AW |
372 | } |
373 | ||
374 | # The pathname on a #include may be surrounded by '<' and '>'. | |
c45dcabd | 375 | if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) { |
c2fdda0d AW |
376 | my $clean = 'X' x length($1); |
377 | $res =~ s@\<.*\>@<$clean>@; | |
378 | ||
379 | # The whole of a #error is a string. | |
c45dcabd | 380 | } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) { |
c2fdda0d | 381 | my $clean = 'X' x length($1); |
c45dcabd | 382 | $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@; |
c2fdda0d AW |
383 | } |
384 | ||
00df344f AW |
385 | return $res; |
386 | } | |
387 | ||
8905a67c AW |
388 | sub ctx_statement_block { |
389 | my ($linenr, $remain, $off) = @_; | |
390 | my $line = $linenr - 1; | |
391 | my $blk = ''; | |
392 | my $soff = $off; | |
393 | my $coff = $off - 1; | |
773647a0 | 394 | my $coff_set = 0; |
8905a67c | 395 | |
13214adf AW |
396 | my $loff = 0; |
397 | ||
8905a67c AW |
398 | my $type = ''; |
399 | my $level = 0; | |
cf655043 | 400 | my $p; |
8905a67c AW |
401 | my $c; |
402 | my $len = 0; | |
13214adf AW |
403 | |
404 | my $remainder; | |
8905a67c | 405 | while (1) { |
773647a0 | 406 | #warn "CSB: blk<$blk> remain<$remain>\n"; |
8905a67c AW |
407 | # If we are about to drop off the end, pull in more |
408 | # context. | |
409 | if ($off >= $len) { | |
410 | for (; $remain > 0; $line++) { | |
c2fdda0d | 411 | next if ($lines[$line] =~ /^-/); |
8905a67c | 412 | $remain--; |
13214adf | 413 | $loff = $len; |
c2fdda0d | 414 | $blk .= $lines[$line] . "\n"; |
8905a67c AW |
415 | $len = length($blk); |
416 | $line++; | |
417 | last; | |
418 | } | |
419 | # Bail if there is no further context. | |
420 | #warn "CSB: blk<$blk> off<$off> len<$len>\n"; | |
13214adf | 421 | if ($off >= $len) { |
8905a67c AW |
422 | last; |
423 | } | |
424 | } | |
cf655043 | 425 | $p = $c; |
8905a67c | 426 | $c = substr($blk, $off, 1); |
13214adf | 427 | $remainder = substr($blk, $off); |
8905a67c | 428 | |
773647a0 | 429 | #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n"; |
8905a67c AW |
430 | # Statement ends at the ';' or a close '}' at the |
431 | # outermost level. | |
432 | if ($level == 0 && $c eq ';') { | |
433 | last; | |
434 | } | |
435 | ||
13214adf | 436 | # An else is really a conditional as long as its not else if |
773647a0 AW |
437 | if ($level == 0 && $coff_set == 0 && |
438 | (!defined($p) || $p =~ /(?:\s|\}|\+)/) && | |
439 | $remainder =~ /^(else)(?:\s|{)/ && | |
440 | $remainder !~ /^else\s+if\b/) { | |
441 | $coff = $off + length($1) - 1; | |
442 | $coff_set = 1; | |
443 | #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n"; | |
444 | #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n"; | |
13214adf AW |
445 | } |
446 | ||
8905a67c AW |
447 | if (($type eq '' || $type eq '(') && $c eq '(') { |
448 | $level++; | |
449 | $type = '('; | |
450 | } | |
451 | if ($type eq '(' && $c eq ')') { | |
452 | $level--; | |
453 | $type = ($level != 0)? '(' : ''; | |
454 | ||
455 | if ($level == 0 && $coff < $soff) { | |
456 | $coff = $off; | |
773647a0 AW |
457 | $coff_set = 1; |
458 | #warn "CSB: mark coff<$coff>\n"; | |
8905a67c AW |
459 | } |
460 | } | |
461 | if (($type eq '' || $type eq '{') && $c eq '{') { | |
462 | $level++; | |
463 | $type = '{'; | |
464 | } | |
465 | if ($type eq '{' && $c eq '}') { | |
466 | $level--; | |
467 | $type = ($level != 0)? '{' : ''; | |
468 | ||
469 | if ($level == 0) { | |
470 | last; | |
471 | } | |
472 | } | |
473 | $off++; | |
474 | } | |
a3bb97a7 | 475 | # We are truly at the end, so shuffle to the next line. |
13214adf | 476 | if ($off == $len) { |
a3bb97a7 | 477 | $loff = $len + 1; |
13214adf AW |
478 | $line++; |
479 | $remain--; | |
480 | } | |
8905a67c AW |
481 | |
482 | my $statement = substr($blk, $soff, $off - $soff + 1); | |
483 | my $condition = substr($blk, $soff, $coff - $soff + 1); | |
484 | ||
485 | #warn "STATEMENT<$statement>\n"; | |
486 | #warn "CONDITION<$condition>\n"; | |
487 | ||
773647a0 | 488 | #print "coff<$coff> soff<$off> loff<$loff>\n"; |
13214adf AW |
489 | |
490 | return ($statement, $condition, | |
491 | $line, $remain + 1, $off - $loff + 1, $level); | |
492 | } | |
493 | ||
cf655043 AW |
494 | sub statement_lines { |
495 | my ($stmt) = @_; | |
496 | ||
497 | # Strip the diff line prefixes and rip blank lines at start and end. | |
498 | $stmt =~ s/(^|\n)./$1/g; | |
499 | $stmt =~ s/^\s*//; | |
500 | $stmt =~ s/\s*$//; | |
501 | ||
502 | my @stmt_lines = ($stmt =~ /\n/g); | |
503 | ||
504 | return $#stmt_lines + 2; | |
505 | } | |
506 | ||
507 | sub statement_rawlines { | |
508 | my ($stmt) = @_; | |
509 | ||
510 | my @stmt_lines = ($stmt =~ /\n/g); | |
511 | ||
512 | return $#stmt_lines + 2; | |
513 | } | |
514 | ||
515 | sub statement_block_size { | |
516 | my ($stmt) = @_; | |
517 | ||
518 | $stmt =~ s/(^|\n)./$1/g; | |
519 | $stmt =~ s/^\s*{//; | |
520 | $stmt =~ s/}\s*$//; | |
521 | $stmt =~ s/^\s*//; | |
522 | $stmt =~ s/\s*$//; | |
523 | ||
524 | my @stmt_lines = ($stmt =~ /\n/g); | |
525 | my @stmt_statements = ($stmt =~ /;/g); | |
526 | ||
527 | my $stmt_lines = $#stmt_lines + 2; | |
528 | my $stmt_statements = $#stmt_statements + 1; | |
529 | ||
530 | if ($stmt_lines > $stmt_statements) { | |
531 | return $stmt_lines; | |
532 | } else { | |
533 | return $stmt_statements; | |
534 | } | |
535 | } | |
536 | ||
13214adf AW |
537 | sub ctx_statement_full { |
538 | my ($linenr, $remain, $off) = @_; | |
539 | my ($statement, $condition, $level); | |
540 | ||
541 | my (@chunks); | |
542 | ||
cf655043 | 543 | # Grab the first conditional/block pair. |
13214adf AW |
544 | ($statement, $condition, $linenr, $remain, $off, $level) = |
545 | ctx_statement_block($linenr, $remain, $off); | |
773647a0 | 546 | #print "F: c<$condition> s<$statement> remain<$remain>\n"; |
cf655043 AW |
547 | push(@chunks, [ $condition, $statement ]); |
548 | if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) { | |
549 | return ($level, $linenr, @chunks); | |
550 | } | |
551 | ||
552 | # Pull in the following conditional/block pairs and see if they | |
553 | # could continue the statement. | |
13214adf | 554 | for (;;) { |
13214adf AW |
555 | ($statement, $condition, $linenr, $remain, $off, $level) = |
556 | ctx_statement_block($linenr, $remain, $off); | |
cf655043 | 557 | #print "C: c<$condition> s<$statement> remain<$remain>\n"; |
773647a0 | 558 | last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s)); |
cf655043 AW |
559 | #print "C: push\n"; |
560 | push(@chunks, [ $condition, $statement ]); | |
13214adf AW |
561 | } |
562 | ||
563 | return ($level, $linenr, @chunks); | |
8905a67c AW |
564 | } |
565 | ||
4a0df2ef | 566 | sub ctx_block_get { |
f0a594c1 | 567 | my ($linenr, $remain, $outer, $open, $close, $off) = @_; |
4a0df2ef AW |
568 | my $line; |
569 | my $start = $linenr - 1; | |
4a0df2ef AW |
570 | my $blk = ''; |
571 | my @o; | |
572 | my @c; | |
573 | my @res = (); | |
574 | ||
f0a594c1 | 575 | my $level = 0; |
00df344f AW |
576 | for ($line = $start; $remain > 0; $line++) { |
577 | next if ($rawlines[$line] =~ /^-/); | |
578 | $remain--; | |
579 | ||
580 | $blk .= $rawlines[$line]; | |
f0a594c1 AW |
581 | foreach my $c (split(//, $rawlines[$line])) { |
582 | ##print "C<$c>L<$level><$open$close>O<$off>\n"; | |
583 | if ($off > 0) { | |
584 | $off--; | |
585 | next; | |
586 | } | |
4a0df2ef | 587 | |
f0a594c1 AW |
588 | if ($c eq $close && $level > 0) { |
589 | $level--; | |
590 | last if ($level == 0); | |
591 | } elsif ($c eq $open) { | |
592 | $level++; | |
593 | } | |
594 | } | |
4a0df2ef | 595 | |
f0a594c1 | 596 | if (!$outer || $level <= 1) { |
00df344f | 597 | push(@res, $rawlines[$line]); |
4a0df2ef AW |
598 | } |
599 | ||
f0a594c1 | 600 | last if ($level == 0); |
4a0df2ef AW |
601 | } |
602 | ||
f0a594c1 | 603 | return ($level, @res); |
4a0df2ef AW |
604 | } |
605 | sub ctx_block_outer { | |
606 | my ($linenr, $remain) = @_; | |
607 | ||
f0a594c1 AW |
608 | my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0); |
609 | return @r; | |
4a0df2ef AW |
610 | } |
611 | sub ctx_block { | |
612 | my ($linenr, $remain) = @_; | |
613 | ||
f0a594c1 AW |
614 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
615 | return @r; | |
653d4876 AW |
616 | } |
617 | sub ctx_statement { | |
f0a594c1 AW |
618 | my ($linenr, $remain, $off) = @_; |
619 | ||
620 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off); | |
621 | return @r; | |
622 | } | |
623 | sub ctx_block_level { | |
653d4876 AW |
624 | my ($linenr, $remain) = @_; |
625 | ||
f0a594c1 | 626 | return ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
4a0df2ef | 627 | } |
9c0ca6f9 AW |
628 | sub ctx_statement_level { |
629 | my ($linenr, $remain, $off) = @_; | |
630 | ||
631 | return ctx_block_get($linenr, $remain, 0, '(', ')', $off); | |
632 | } | |
4a0df2ef AW |
633 | |
634 | sub ctx_locate_comment { | |
635 | my ($first_line, $end_line) = @_; | |
636 | ||
637 | # Catch a comment on the end of the line itself. | |
beae6332 | 638 | my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@); |
4a0df2ef AW |
639 | return $current_comment if (defined $current_comment); |
640 | ||
641 | # Look through the context and try and figure out if there is a | |
642 | # comment. | |
643 | my $in_comment = 0; | |
644 | $current_comment = ''; | |
645 | for (my $linenr = $first_line; $linenr < $end_line; $linenr++) { | |
00df344f AW |
646 | my $line = $rawlines[$linenr - 1]; |
647 | #warn " $line\n"; | |
4a0df2ef AW |
648 | if ($linenr == $first_line and $line =~ m@^.\s*\*@) { |
649 | $in_comment = 1; | |
650 | } | |
651 | if ($line =~ m@/\*@) { | |
652 | $in_comment = 1; | |
653 | } | |
654 | if (!$in_comment && $current_comment ne '') { | |
655 | $current_comment = ''; | |
656 | } | |
657 | $current_comment .= $line . "\n" if ($in_comment); | |
658 | if ($line =~ m@\*/@) { | |
659 | $in_comment = 0; | |
660 | } | |
661 | } | |
662 | ||
663 | chomp($current_comment); | |
664 | return($current_comment); | |
665 | } | |
666 | sub ctx_has_comment { | |
667 | my ($first_line, $end_line) = @_; | |
668 | my $cmt = ctx_locate_comment($first_line, $end_line); | |
669 | ||
00df344f | 670 | ##print "LINE: $rawlines[$end_line - 1 ]\n"; |
4a0df2ef AW |
671 | ##print "CMMT: $cmt\n"; |
672 | ||
673 | return ($cmt ne ''); | |
674 | } | |
675 | ||
4d001e4d AW |
676 | sub raw_line { |
677 | my ($linenr, $cnt) = @_; | |
678 | ||
679 | my $offset = $linenr - 1; | |
680 | $cnt++; | |
681 | ||
682 | my $line; | |
683 | while ($cnt) { | |
684 | $line = $rawlines[$offset++]; | |
685 | next if (defined($line) && $line =~ /^-/); | |
686 | $cnt--; | |
687 | } | |
688 | ||
689 | return $line; | |
690 | } | |
691 | ||
6c72ffaa AW |
692 | sub cat_vet { |
693 | my ($vet) = @_; | |
694 | my ($res, $coded); | |
9c0ca6f9 | 695 | |
6c72ffaa AW |
696 | $res = ''; |
697 | while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) { | |
698 | $res .= $1; | |
699 | if ($2 ne '') { | |
700 | $coded = sprintf("^%c", unpack('C', $2) + 64); | |
701 | $res .= $coded; | |
9c0ca6f9 AW |
702 | } |
703 | } | |
6c72ffaa | 704 | $res =~ s/$/\$/; |
9c0ca6f9 | 705 | |
6c72ffaa | 706 | return $res; |
9c0ca6f9 AW |
707 | } |
708 | ||
c2fdda0d | 709 | my $av_preprocessor = 0; |
cf655043 | 710 | my $av_pending; |
c2fdda0d | 711 | my @av_paren_type; |
1f65f947 | 712 | my $av_pend_colon; |
c2fdda0d AW |
713 | |
714 | sub annotate_reset { | |
715 | $av_preprocessor = 0; | |
cf655043 AW |
716 | $av_pending = '_'; |
717 | @av_paren_type = ('E'); | |
1f65f947 | 718 | $av_pend_colon = 'O'; |
c2fdda0d AW |
719 | } |
720 | ||
6c72ffaa AW |
721 | sub annotate_values { |
722 | my ($stream, $type) = @_; | |
0a920b5b | 723 | |
6c72ffaa | 724 | my $res; |
1f65f947 | 725 | my $var = '_' x length($stream); |
6c72ffaa AW |
726 | my $cur = $stream; |
727 | ||
c2fdda0d | 728 | print "$stream\n" if ($dbg_values > 1); |
6c72ffaa | 729 | |
6c72ffaa | 730 | while (length($cur)) { |
773647a0 | 731 | @av_paren_type = ('E') if ($#av_paren_type < 0); |
cf655043 | 732 | print " <" . join('', @av_paren_type) . |
171ae1a4 | 733 | "> <$type> <$av_pending>" if ($dbg_values > 1); |
6c72ffaa | 734 | if ($cur =~ /^(\s+)/o) { |
c2fdda0d AW |
735 | print "WS($1)\n" if ($dbg_values > 1); |
736 | if ($1 =~ /\n/ && $av_preprocessor) { | |
cf655043 | 737 | $type = pop(@av_paren_type); |
c2fdda0d | 738 | $av_preprocessor = 0; |
6c72ffaa AW |
739 | } |
740 | ||
8ea3eb9a | 741 | } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) { |
c2fdda0d | 742 | print "DECLARE($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
743 | $type = 'T'; |
744 | ||
389a2fe5 AW |
745 | } elsif ($cur =~ /^($Modifier)\s*/) { |
746 | print "MODIFIER($1)\n" if ($dbg_values > 1); | |
747 | $type = 'T'; | |
748 | ||
c45dcabd | 749 | } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) { |
171ae1a4 | 750 | print "DEFINE($1,$2)\n" if ($dbg_values > 1); |
c2fdda0d | 751 | $av_preprocessor = 1; |
171ae1a4 AW |
752 | push(@av_paren_type, $type); |
753 | if ($2 ne '') { | |
754 | $av_pending = 'N'; | |
755 | } | |
756 | $type = 'E'; | |
757 | ||
c45dcabd | 758 | } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) { |
171ae1a4 AW |
759 | print "UNDEF($1)\n" if ($dbg_values > 1); |
760 | $av_preprocessor = 1; | |
761 | push(@av_paren_type, $type); | |
6c72ffaa | 762 | |
c45dcabd | 763 | } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) { |
cf655043 | 764 | print "PRE_START($1)\n" if ($dbg_values > 1); |
c2fdda0d | 765 | $av_preprocessor = 1; |
cf655043 AW |
766 | |
767 | push(@av_paren_type, $type); | |
768 | push(@av_paren_type, $type); | |
171ae1a4 | 769 | $type = 'E'; |
cf655043 | 770 | |
c45dcabd | 771 | } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) { |
cf655043 AW |
772 | print "PRE_RESTART($1)\n" if ($dbg_values > 1); |
773 | $av_preprocessor = 1; | |
774 | ||
775 | push(@av_paren_type, $av_paren_type[$#av_paren_type]); | |
776 | ||
171ae1a4 | 777 | $type = 'E'; |
cf655043 | 778 | |
c45dcabd | 779 | } elsif ($cur =~ /^(\#\s*(?:endif))/o) { |
cf655043 AW |
780 | print "PRE_END($1)\n" if ($dbg_values > 1); |
781 | ||
782 | $av_preprocessor = 1; | |
783 | ||
784 | # Assume all arms of the conditional end as this | |
785 | # one does, and continue as if the #endif was not here. | |
786 | pop(@av_paren_type); | |
787 | push(@av_paren_type, $type); | |
171ae1a4 | 788 | $type = 'E'; |
6c72ffaa AW |
789 | |
790 | } elsif ($cur =~ /^(\\\n)/o) { | |
c2fdda0d | 791 | print "PRECONT($1)\n" if ($dbg_values > 1); |
6c72ffaa | 792 | |
171ae1a4 AW |
793 | } elsif ($cur =~ /^(__attribute__)\s*\(?/o) { |
794 | print "ATTR($1)\n" if ($dbg_values > 1); | |
795 | $av_pending = $type; | |
796 | $type = 'N'; | |
797 | ||
6c72ffaa | 798 | } elsif ($cur =~ /^(sizeof)\s*(\()?/o) { |
c2fdda0d | 799 | print "SIZEOF($1)\n" if ($dbg_values > 1); |
6c72ffaa | 800 | if (defined $2) { |
cf655043 | 801 | $av_pending = 'V'; |
6c72ffaa AW |
802 | } |
803 | $type = 'N'; | |
804 | ||
14b111c1 | 805 | } elsif ($cur =~ /^(if|while|for)\b/o) { |
c2fdda0d | 806 | print "COND($1)\n" if ($dbg_values > 1); |
14b111c1 | 807 | $av_pending = 'E'; |
6c72ffaa AW |
808 | $type = 'N'; |
809 | ||
1f65f947 AW |
810 | } elsif ($cur =~/^(case)/o) { |
811 | print "CASE($1)\n" if ($dbg_values > 1); | |
812 | $av_pend_colon = 'C'; | |
813 | $type = 'N'; | |
814 | ||
14b111c1 | 815 | } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) { |
c2fdda0d | 816 | print "KEYWORD($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
817 | $type = 'N'; |
818 | ||
819 | } elsif ($cur =~ /^(\()/o) { | |
c2fdda0d | 820 | print "PAREN('$1')\n" if ($dbg_values > 1); |
cf655043 AW |
821 | push(@av_paren_type, $av_pending); |
822 | $av_pending = '_'; | |
6c72ffaa AW |
823 | $type = 'N'; |
824 | ||
825 | } elsif ($cur =~ /^(\))/o) { | |
cf655043 AW |
826 | my $new_type = pop(@av_paren_type); |
827 | if ($new_type ne '_') { | |
828 | $type = $new_type; | |
c2fdda0d AW |
829 | print "PAREN('$1') -> $type\n" |
830 | if ($dbg_values > 1); | |
6c72ffaa | 831 | } else { |
c2fdda0d | 832 | print "PAREN('$1')\n" if ($dbg_values > 1); |
6c72ffaa AW |
833 | } |
834 | ||
c8cb2ca3 | 835 | } elsif ($cur =~ /^($Ident)\s*\(/o) { |
c2fdda0d | 836 | print "FUNC($1)\n" if ($dbg_values > 1); |
c8cb2ca3 | 837 | $type = 'V'; |
cf655043 | 838 | $av_pending = 'V'; |
6c72ffaa | 839 | |
1f65f947 AW |
840 | } elsif ($cur =~ /^($Ident\s*):/) { |
841 | if ($type eq 'E') { | |
842 | $av_pend_colon = 'L'; | |
843 | } elsif ($type eq 'T') { | |
844 | $av_pend_colon = 'B'; | |
845 | } | |
846 | print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1); | |
847 | $type = 'V'; | |
848 | ||
6c72ffaa | 849 | } elsif ($cur =~ /^($Ident|$Constant)/o) { |
c2fdda0d | 850 | print "IDENT($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
851 | $type = 'V'; |
852 | ||
853 | } elsif ($cur =~ /^($Assignment)/o) { | |
c2fdda0d | 854 | print "ASSIGN($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
855 | $type = 'N'; |
856 | ||
cf655043 | 857 | } elsif ($cur =~/^(;|{|})/) { |
c2fdda0d | 858 | print "END($1)\n" if ($dbg_values > 1); |
13214adf | 859 | $type = 'E'; |
1f65f947 AW |
860 | $av_pend_colon = 'O'; |
861 | ||
862 | } elsif ($cur =~ /^(\?)/o) { | |
863 | print "QUESTION($1)\n" if ($dbg_values > 1); | |
864 | $type = 'N'; | |
865 | ||
866 | } elsif ($cur =~ /^(:)/o) { | |
867 | print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1); | |
868 | ||
869 | substr($var, length($res), 1, $av_pend_colon); | |
870 | if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') { | |
871 | $type = 'E'; | |
872 | } else { | |
873 | $type = 'N'; | |
874 | } | |
875 | $av_pend_colon = 'O'; | |
13214adf | 876 | |
1f65f947 | 877 | } elsif ($cur =~ /^(;|\[)/o) { |
13214adf | 878 | print "CLOSE($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
879 | $type = 'N'; |
880 | ||
0d413866 | 881 | } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) { |
74048ed8 AW |
882 | my $variant; |
883 | ||
884 | print "OPV($1)\n" if ($dbg_values > 1); | |
885 | if ($type eq 'V') { | |
886 | $variant = 'B'; | |
887 | } else { | |
888 | $variant = 'U'; | |
889 | } | |
890 | ||
891 | substr($var, length($res), 1, $variant); | |
892 | $type = 'N'; | |
893 | ||
6c72ffaa | 894 | } elsif ($cur =~ /^($Operators)/o) { |
c2fdda0d | 895 | print "OP($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
896 | if ($1 ne '++' && $1 ne '--') { |
897 | $type = 'N'; | |
898 | } | |
899 | ||
900 | } elsif ($cur =~ /(^.)/o) { | |
c2fdda0d | 901 | print "C($1)\n" if ($dbg_values > 1); |
6c72ffaa AW |
902 | } |
903 | if (defined $1) { | |
904 | $cur = substr($cur, length($1)); | |
905 | $res .= $type x length($1); | |
906 | } | |
9c0ca6f9 | 907 | } |
0a920b5b | 908 | |
1f65f947 | 909 | return ($res, $var); |
0a920b5b AW |
910 | } |
911 | ||
8905a67c | 912 | sub possible { |
13214adf | 913 | my ($possible, $line) = @_; |
8905a67c | 914 | |
c45dcabd | 915 | print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1); |
0221f55c | 916 | if ($possible !~ /^(?:$Modifier|$Storage|$Type|DEFINE_\S+)$/ && |
8905a67c | 917 | $possible ne 'goto' && $possible ne 'return' && |
8905a67c | 918 | $possible ne 'case' && $possible ne 'else' && |
d3ddcf47 | 919 | $possible ne 'asm' && $possible ne '__asm__' && |
c45dcabd AW |
920 | $possible !~ /^(typedef|struct|enum)\b/) { |
921 | # Check for modifiers. | |
922 | $possible =~ s/\s*$Storage\s*//g; | |
923 | $possible =~ s/\s*$Sparse\s*//g; | |
924 | if ($possible =~ /^\s*$/) { | |
925 | ||
926 | } elsif ($possible =~ /\s/) { | |
927 | $possible =~ s/\s*$Type\s*//g; | |
d2506586 AW |
928 | for my $modifier (split(' ', $possible)) { |
929 | warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible); | |
930 | push(@modifierList, $modifier); | |
931 | } | |
c45dcabd AW |
932 | |
933 | } else { | |
934 | warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible); | |
935 | push(@typeList, $possible); | |
936 | } | |
8905a67c AW |
937 | build_types(); |
938 | } | |
939 | } | |
940 | ||
6c72ffaa AW |
941 | my $prefix = ''; |
942 | ||
f0a594c1 | 943 | sub report { |
773647a0 AW |
944 | if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) { |
945 | return 0; | |
946 | } | |
8905a67c AW |
947 | my $line = $prefix . $_[0]; |
948 | ||
949 | $line = (split('\n', $line))[0] . "\n" if ($terse); | |
950 | ||
13214adf | 951 | push(our @report, $line); |
773647a0 AW |
952 | |
953 | return 1; | |
f0a594c1 AW |
954 | } |
955 | sub report_dump { | |
13214adf | 956 | our @report; |
f0a594c1 | 957 | } |
de7d4f0e | 958 | sub ERROR { |
773647a0 AW |
959 | if (report("ERROR: $_[0]\n")) { |
960 | our $clean = 0; | |
961 | our $cnt_error++; | |
962 | } | |
de7d4f0e AW |
963 | } |
964 | sub WARN { | |
773647a0 AW |
965 | if (report("WARNING: $_[0]\n")) { |
966 | our $clean = 0; | |
967 | our $cnt_warn++; | |
968 | } | |
de7d4f0e AW |
969 | } |
970 | sub CHK { | |
773647a0 | 971 | if ($check && report("CHECK: $_[0]\n")) { |
6c72ffaa AW |
972 | our $clean = 0; |
973 | our $cnt_chk++; | |
974 | } | |
de7d4f0e AW |
975 | } |
976 | ||
6ecd9674 AW |
977 | sub check_absolute_file { |
978 | my ($absolute, $herecurr) = @_; | |
979 | my $file = $absolute; | |
980 | ||
981 | ##print "absolute<$absolute>\n"; | |
982 | ||
983 | # See if any suffix of this path is a path within the tree. | |
984 | while ($file =~ s@^[^/]*/@@) { | |
985 | if (-f "$root/$file") { | |
986 | ##print "file<$file>\n"; | |
987 | last; | |
988 | } | |
989 | } | |
990 | if (! -f _) { | |
991 | return 0; | |
992 | } | |
993 | ||
994 | # It is, so see if the prefix is acceptable. | |
995 | my $prefix = $absolute; | |
996 | substr($prefix, -length($file)) = ''; | |
997 | ||
998 | ##print "prefix<$prefix>\n"; | |
999 | if ($prefix ne ".../") { | |
1000 | WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr); | |
1001 | } | |
1002 | } | |
1003 | ||
0a920b5b AW |
1004 | sub process { |
1005 | my $filename = shift; | |
0a920b5b AW |
1006 | |
1007 | my $linenr=0; | |
1008 | my $prevline=""; | |
c2fdda0d | 1009 | my $prevrawline=""; |
0a920b5b | 1010 | my $stashline=""; |
c2fdda0d | 1011 | my $stashrawline=""; |
0a920b5b | 1012 | |
4a0df2ef | 1013 | my $length; |
0a920b5b AW |
1014 | my $indent; |
1015 | my $previndent=0; | |
1016 | my $stashindent=0; | |
1017 | ||
de7d4f0e | 1018 | our $clean = 1; |
0a920b5b AW |
1019 | my $signoff = 0; |
1020 | my $is_patch = 0; | |
1021 | ||
13214adf | 1022 | our @report = (); |
6c72ffaa AW |
1023 | our $cnt_lines = 0; |
1024 | our $cnt_error = 0; | |
1025 | our $cnt_warn = 0; | |
1026 | our $cnt_chk = 0; | |
1027 | ||
0a920b5b AW |
1028 | # Trace the real file/line as we go. |
1029 | my $realfile = ''; | |
1030 | my $realline = 0; | |
1031 | my $realcnt = 0; | |
1032 | my $here = ''; | |
1033 | my $in_comment = 0; | |
c2fdda0d | 1034 | my $comment_edge = 0; |
0a920b5b AW |
1035 | my $first_line = 0; |
1036 | ||
13214adf AW |
1037 | my $prev_values = 'E'; |
1038 | ||
1039 | # suppression flags | |
773647a0 | 1040 | my %suppress_ifbraces; |
653d4876 | 1041 | |
c2fdda0d | 1042 | # Pre-scan the patch sanitizing the lines. |
de7d4f0e | 1043 | # Pre-scan the patch looking for any __setup documentation. |
c2fdda0d | 1044 | # |
de7d4f0e AW |
1045 | my @setup_docs = (); |
1046 | my $setup_docs = 0; | |
773647a0 AW |
1047 | |
1048 | sanitise_line_reset(); | |
c2fdda0d AW |
1049 | my $line; |
1050 | foreach my $rawline (@rawlines) { | |
773647a0 AW |
1051 | $linenr++; |
1052 | $line = $rawline; | |
c2fdda0d | 1053 | |
773647a0 | 1054 | if ($rawline=~/^\+\+\+\s+(\S+)/) { |
de7d4f0e AW |
1055 | $setup_docs = 0; |
1056 | if ($1 =~ m@Documentation/kernel-parameters.txt$@) { | |
1057 | $setup_docs = 1; | |
1058 | } | |
773647a0 AW |
1059 | #next; |
1060 | } | |
1061 | if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { | |
1062 | $realline=$1-1; | |
1063 | if (defined $2) { | |
1064 | $realcnt=$3+1; | |
1065 | } else { | |
1066 | $realcnt=1+1; | |
1067 | } | |
c45dcabd | 1068 | $in_comment = 0; |
773647a0 AW |
1069 | |
1070 | # Guestimate if this is a continuing comment. Run | |
1071 | # the context looking for a comment "edge". If this | |
1072 | # edge is a close comment then we must be in a comment | |
1073 | # at context start. | |
1074 | my $edge; | |
01fa9147 AW |
1075 | my $cnt = $realcnt; |
1076 | for (my $ln = $linenr + 1; $cnt > 0; $ln++) { | |
1077 | next if (defined $rawlines[$ln - 1] && | |
1078 | $rawlines[$ln - 1] =~ /^-/); | |
1079 | $cnt--; | |
1080 | #print "RAW<$rawlines[$ln - 1]>\n"; | |
1081 | ($edge) = (defined $rawlines[$ln - 1] && | |
1082 | $rawlines[$ln - 1] =~ m@(/\*|\*/)@); | |
773647a0 AW |
1083 | last if (defined $edge); |
1084 | } | |
1085 | if (defined $edge && $edge eq '*/') { | |
1086 | $in_comment = 1; | |
1087 | } | |
1088 | ||
1089 | # Guestimate if this is a continuing comment. If this | |
1090 | # is the start of a diff block and this line starts | |
1091 | # ' *' then it is very likely a comment. | |
1092 | if (!defined $edge && | |
1093 | $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@) | |
1094 | { | |
1095 | $in_comment = 1; | |
1096 | } | |
1097 | ||
1098 | ##print "COMMENT:$in_comment edge<$edge> $rawline\n"; | |
1099 | sanitise_line_reset($in_comment); | |
1100 | ||
171ae1a4 | 1101 | } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) { |
773647a0 | 1102 | # Standardise the strings and chars within the input to |
171ae1a4 | 1103 | # simplify matching -- only bother with positive lines. |
773647a0 | 1104 | $line = sanitise_line($rawline); |
de7d4f0e | 1105 | } |
773647a0 AW |
1106 | push(@lines, $line); |
1107 | ||
1108 | if ($realcnt > 1) { | |
1109 | $realcnt-- if ($line =~ /^(?:\+| |$)/); | |
1110 | } else { | |
1111 | $realcnt = 0; | |
1112 | } | |
1113 | ||
1114 | #print "==>$rawline\n"; | |
1115 | #print "-->$line\n"; | |
de7d4f0e AW |
1116 | |
1117 | if ($setup_docs && $line =~ /^\+/) { | |
1118 | push(@setup_docs, $line); | |
1119 | } | |
1120 | } | |
1121 | ||
6c72ffaa AW |
1122 | $prefix = ''; |
1123 | ||
773647a0 AW |
1124 | $realcnt = 0; |
1125 | $linenr = 0; | |
0a920b5b AW |
1126 | foreach my $line (@lines) { |
1127 | $linenr++; | |
1128 | ||
c2fdda0d | 1129 | my $rawline = $rawlines[$linenr - 1]; |
6c72ffaa | 1130 | |
0a920b5b | 1131 | #extract the line range in the file after the patch is applied |
6c72ffaa | 1132 | if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
0a920b5b | 1133 | $is_patch = 1; |
4a0df2ef | 1134 | $first_line = $linenr + 1; |
0a920b5b AW |
1135 | $realline=$1-1; |
1136 | if (defined $2) { | |
1137 | $realcnt=$3+1; | |
1138 | } else { | |
1139 | $realcnt=1+1; | |
1140 | } | |
c2fdda0d | 1141 | annotate_reset(); |
13214adf AW |
1142 | $prev_values = 'E'; |
1143 | ||
773647a0 | 1144 | %suppress_ifbraces = (); |
0a920b5b | 1145 | next; |
0a920b5b | 1146 | |
4a0df2ef AW |
1147 | # track the line number as we move through the hunk, note that |
1148 | # new versions of GNU diff omit the leading space on completely | |
1149 | # blank context lines so we need to count that too. | |
773647a0 | 1150 | } elsif ($line =~ /^( |\+|$)/) { |
0a920b5b | 1151 | $realline++; |
d8aaf121 | 1152 | $realcnt-- if ($realcnt != 0); |
0a920b5b | 1153 | |
4a0df2ef | 1154 | # Measure the line length and indent. |
c2fdda0d | 1155 | ($length, $indent) = line_stats($rawline); |
0a920b5b AW |
1156 | |
1157 | # Track the previous line. | |
1158 | ($prevline, $stashline) = ($stashline, $line); | |
1159 | ($previndent, $stashindent) = ($stashindent, $indent); | |
c2fdda0d AW |
1160 | ($prevrawline, $stashrawline) = ($stashrawline, $rawline); |
1161 | ||
773647a0 | 1162 | #warn "line<$line>\n"; |
6c72ffaa | 1163 | |
d8aaf121 AW |
1164 | } elsif ($realcnt == 1) { |
1165 | $realcnt--; | |
0a920b5b AW |
1166 | } |
1167 | ||
1168 | #make up the handle for any error we report on this line | |
773647a0 AW |
1169 | $prefix = "$filename:$realline: " if ($emacs && $file); |
1170 | $prefix = "$filename:$linenr: " if ($emacs && !$file); | |
1171 | ||
6c72ffaa AW |
1172 | $here = "#$linenr: " if (!$file); |
1173 | $here = "#$realline: " if ($file); | |
773647a0 AW |
1174 | |
1175 | # extract the filename as it passes | |
1176 | if ($line=~/^\+\+\+\s+(\S+)/) { | |
1177 | $realfile = $1; | |
1178 | $realfile =~ s@^[^/]*/@@; | |
1179 | ||
c1ab3326 | 1180 | if ($realfile =~ m@^include/asm/@) { |
773647a0 AW |
1181 | ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n"); |
1182 | } | |
1183 | next; | |
1184 | } | |
1185 | ||
389834b6 | 1186 | $here .= "FILE: $realfile:$realline:" if ($realcnt != 0); |
0a920b5b | 1187 | |
c2fdda0d AW |
1188 | my $hereline = "$here\n$rawline\n"; |
1189 | my $herecurr = "$here\n$rawline\n"; | |
1190 | my $hereprev = "$here\n$prevrawline\n$rawline\n"; | |
0a920b5b | 1191 | |
6c72ffaa AW |
1192 | $cnt_lines++ if ($realcnt != 0); |
1193 | ||
0a920b5b | 1194 | #check the patch for a signoff: |
d8aaf121 | 1195 | if ($line =~ /^\s*signed-off-by:/i) { |
4a0df2ef AW |
1196 | # This is a signoff, if ugly, so do not double report. |
1197 | $signoff++; | |
0a920b5b | 1198 | if (!($line =~ /^\s*Signed-off-by:/)) { |
de7d4f0e AW |
1199 | WARN("Signed-off-by: is the preferred form\n" . |
1200 | $herecurr); | |
0a920b5b AW |
1201 | } |
1202 | if ($line =~ /^\s*signed-off-by:\S/i) { | |
773647a0 | 1203 | WARN("space required after Signed-off-by:\n" . |
de7d4f0e | 1204 | $herecurr); |
0a920b5b AW |
1205 | } |
1206 | } | |
1207 | ||
00df344f | 1208 | # Check for wrappage within a valid hunk of the file |
8905a67c | 1209 | if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { |
de7d4f0e | 1210 | ERROR("patch seems to be corrupt (line wrapped?)\n" . |
6c72ffaa | 1211 | $herecurr) if (!$emitted_corrupt++); |
de7d4f0e AW |
1212 | } |
1213 | ||
6ecd9674 AW |
1214 | # Check for absolute kernel paths. |
1215 | if ($tree) { | |
1216 | while ($line =~ m{(?:^|\s)(/\S*)}g) { | |
1217 | my $file = $1; | |
1218 | ||
1219 | if ($file =~ m{^(.*?)(?::\d+)+:?$} && | |
1220 | check_absolute_file($1, $herecurr)) { | |
1221 | # | |
1222 | } else { | |
1223 | check_absolute_file($file, $herecurr); | |
1224 | } | |
1225 | } | |
1226 | } | |
1227 | ||
de7d4f0e AW |
1228 | # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php |
1229 | if (($realfile =~ /^$/ || $line =~ /^\+/) && | |
171ae1a4 AW |
1230 | $rawline !~ m/^$UTF8*$/) { |
1231 | my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/); | |
1232 | ||
1233 | my $blank = copy_spacing($rawline); | |
1234 | my $ptr = substr($blank, 0, length($utf8_prefix)) . "^"; | |
1235 | my $hereptr = "$hereline$ptr\n"; | |
1236 | ||
1237 | ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr); | |
00df344f AW |
1238 | } |
1239 | ||
1240 | #ignore lines being removed | |
1241 | if ($line=~/^-/) {next;} | |
0a920b5b | 1242 | |
00df344f AW |
1243 | # check we are in a valid source file if not then ignore this hunk |
1244 | next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); | |
0a920b5b AW |
1245 | |
1246 | #trailing whitespace | |
9c0ca6f9 | 1247 | if ($line =~ /^\+.*\015/) { |
c2fdda0d | 1248 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
9c0ca6f9 AW |
1249 | ERROR("DOS line endings\n" . $herevet); |
1250 | ||
c2fdda0d AW |
1251 | } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) { |
1252 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; | |
de7d4f0e | 1253 | ERROR("trailing whitespace\n" . $herevet); |
0a920b5b AW |
1254 | } |
1255 | #80 column limit | |
c45dcabd | 1256 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
f4c014c0 AW |
1257 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
1258 | $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && | |
1259 | $length > 80) | |
c45dcabd | 1260 | { |
de7d4f0e | 1261 | WARN("line over 80 characters\n" . $herecurr); |
0a920b5b AW |
1262 | } |
1263 | ||
8905a67c AW |
1264 | # check for adding lines without a newline. |
1265 | if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) { | |
1266 | WARN("adding a line without newline at end of file\n" . $herecurr); | |
1267 | } | |
1268 | ||
b9ea10d6 AW |
1269 | # check we are in a valid source file C or perl if not then ignore this hunk |
1270 | next if ($realfile !~ /\.(h|c|pl)$/); | |
0a920b5b AW |
1271 | |
1272 | # at the beginning of a line any tabs must come first and anything | |
1273 | # more than 8 must use tabs. | |
c2fdda0d AW |
1274 | if ($rawline =~ /^\+\s* \t\s*\S/ || |
1275 | $rawline =~ /^\+\s* \s*/) { | |
1276 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; | |
171ae1a4 | 1277 | ERROR("code indent should use tabs where possible\n" . $herevet); |
0a920b5b AW |
1278 | } |
1279 | ||
b9ea10d6 AW |
1280 | # check we are in a valid C source file if not then ignore this hunk |
1281 | next if ($realfile !~ /\.(h|c)$/); | |
1282 | ||
c2fdda0d | 1283 | # check for RCS/CVS revision markers |
cf655043 | 1284 | if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { |
c2fdda0d AW |
1285 | WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr); |
1286 | } | |
22f2a2ef | 1287 | |
9c0ca6f9 | 1288 | # Check for potential 'bare' types |
f5fe35dd | 1289 | my ($stat, $cond, $line_nr_next, $remain_next); |
9c9ba34e | 1290 | if ($realcnt && $line =~ /.\s*\S/) { |
f5fe35dd AW |
1291 | ($stat, $cond, $line_nr_next, $remain_next) = |
1292 | ctx_statement_block($linenr, $realcnt, 0); | |
171ae1a4 AW |
1293 | $stat =~ s/\n./\n /g; |
1294 | $cond =~ s/\n./\n /g; | |
1295 | ||
1296 | my $s = $stat; | |
1297 | $s =~ s/{.*$//s; | |
cf655043 | 1298 | |
c2fdda0d | 1299 | # Ignore goto labels. |
171ae1a4 | 1300 | if ($s =~ /$Ident:\*$/s) { |
c2fdda0d AW |
1301 | |
1302 | # Ignore functions being called | |
171ae1a4 | 1303 | } elsif ($s =~ /^.\s*$Ident\s*\(/s) { |
c2fdda0d | 1304 | |
c45dcabd | 1305 | # declarations always start with types |
d2506586 | 1306 | } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) { |
c45dcabd AW |
1307 | my $type = $1; |
1308 | $type =~ s/\s+/ /g; | |
1309 | possible($type, "A:" . $s); | |
1310 | ||
8905a67c | 1311 | # definitions in global scope can only start with types |
171ae1a4 | 1312 | } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/s) { |
c45dcabd | 1313 | possible($1, "B:" . $s); |
c2fdda0d | 1314 | } |
8905a67c AW |
1315 | |
1316 | # any (foo ... *) is a pointer cast, and foo is a type | |
171ae1a4 | 1317 | while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) { |
c45dcabd | 1318 | possible($1, "C:" . $s); |
8905a67c AW |
1319 | } |
1320 | ||
1321 | # Check for any sort of function declaration. | |
1322 | # int foo(something bar, other baz); | |
1323 | # void (*store_gdt)(x86_descr_ptr *); | |
171ae1a4 | 1324 | if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) { |
8905a67c | 1325 | my ($name_len) = length($1); |
8905a67c | 1326 | |
cf655043 | 1327 | my $ctx = $s; |
773647a0 | 1328 | substr($ctx, 0, $name_len + 1, ''); |
8905a67c | 1329 | $ctx =~ s/\)[^\)]*$//; |
cf655043 | 1330 | |
8905a67c | 1331 | for my $arg (split(/\s*,\s*/, $ctx)) { |
c45dcabd | 1332 | if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) { |
8905a67c | 1333 | |
c45dcabd | 1334 | possible($1, "D:" . $s); |
8905a67c AW |
1335 | } |
1336 | } | |
9c0ca6f9 | 1337 | } |
8905a67c | 1338 | |
9c0ca6f9 AW |
1339 | } |
1340 | ||
653d4876 AW |
1341 | # |
1342 | # Checks which may be anchored in the context. | |
1343 | # | |
00df344f | 1344 | |
653d4876 AW |
1345 | # Check for switch () and associated case and default |
1346 | # statements should be at the same indent. | |
00df344f AW |
1347 | if ($line=~/\bswitch\s*\(.*\)/) { |
1348 | my $err = ''; | |
1349 | my $sep = ''; | |
1350 | my @ctx = ctx_block_outer($linenr, $realcnt); | |
1351 | shift(@ctx); | |
1352 | for my $ctx (@ctx) { | |
1353 | my ($clen, $cindent) = line_stats($ctx); | |
1354 | if ($ctx =~ /^\+\s*(case\s+|default:)/ && | |
1355 | $indent != $cindent) { | |
1356 | $err .= "$sep$ctx\n"; | |
1357 | $sep = ''; | |
1358 | } else { | |
1359 | $sep = "[...]\n"; | |
1360 | } | |
1361 | } | |
1362 | if ($err ne '') { | |
9c0ca6f9 | 1363 | ERROR("switch and case should be at the same indent\n$hereline$err"); |
de7d4f0e AW |
1364 | } |
1365 | } | |
e2a763c2 | 1366 | if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && |
1bdab9e5 AW |
1367 | $line !~ /\G(?: |
1368 | (?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| | |
1369 | \s*return\s+ | |
1370 | )/xg) | |
1371 | { | |
e2a763c2 AW |
1372 | ERROR("trailing statements should be on next line\n" . $herecurr); |
1373 | } | |
de7d4f0e AW |
1374 | |
1375 | # if/while/etc brace do not go on next line, unless defining a do while loop, | |
1376 | # or if that brace on the next line is for something else | |
c45dcabd | 1377 | if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) { |
773647a0 AW |
1378 | my $pre_ctx = "$1$2"; |
1379 | ||
9c0ca6f9 | 1380 | my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0); |
de7d4f0e AW |
1381 | my $ctx_cnt = $realcnt - $#ctx - 1; |
1382 | my $ctx = join("\n", @ctx); | |
1383 | ||
548596d5 AW |
1384 | my $ctx_ln = $linenr; |
1385 | my $ctx_skip = $realcnt; | |
773647a0 | 1386 | |
548596d5 AW |
1387 | while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt && |
1388 | defined $lines[$ctx_ln - 1] && | |
1389 | $lines[$ctx_ln - 1] =~ /^-/)) { | |
1390 | ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n"; | |
1391 | $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/); | |
de7d4f0e | 1392 | $ctx_ln++; |
de7d4f0e | 1393 | } |
548596d5 | 1394 | |
53210168 AW |
1395 | #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n"; |
1396 | #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n"; | |
de7d4f0e | 1397 | |
773647a0 AW |
1398 | if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) { |
1399 | ERROR("that open brace { should be on the previous line\n" . | |
c45dcabd | 1400 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
00df344f | 1401 | } |
773647a0 AW |
1402 | if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ && |
1403 | $ctx =~ /\)\s*\;\s*$/ && | |
1404 | defined $lines[$ctx_ln - 1]) | |
1405 | { | |
9c0ca6f9 AW |
1406 | my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]); |
1407 | if ($nindent > $indent) { | |
773647a0 | 1408 | WARN("trailing semicolon indicates no statements, indent implies otherwise\n" . |
c45dcabd | 1409 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
9c0ca6f9 AW |
1410 | } |
1411 | } | |
00df344f AW |
1412 | } |
1413 | ||
4d001e4d AW |
1414 | # Check relative indent for conditionals and blocks. |
1415 | if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { | |
1416 | my ($s, $c) = ($stat, $cond); | |
1417 | ||
1418 | substr($s, 0, length($c), ''); | |
1419 | ||
1420 | # Make sure we remove the line prefixes as we have | |
1421 | # none on the first line, and are going to readd them | |
1422 | # where necessary. | |
1423 | $s =~ s/\n./\n/gs; | |
1424 | ||
1425 | # Find out how long the conditional actually is. | |
1426 | my $cond_lines = 0 + $c =~ /\n/gs; | |
1427 | ||
1428 | # We want to check the first line inside the block | |
1429 | # starting at the end of the conditional, so remove: | |
1430 | # 1) any blank line termination | |
1431 | # 2) any opening brace { on end of the line | |
1432 | # 3) any do (...) { | |
1433 | my $continuation = 0; | |
1434 | my $check = 0; | |
1435 | $s =~ s/^.*\bdo\b//; | |
1436 | $s =~ s/^\s*{//; | |
1437 | if ($s =~ s/^\s*\\//) { | |
1438 | $continuation = 1; | |
1439 | } | |
9bd49efe | 1440 | if ($s =~ s/^\s*?\n//) { |
4d001e4d AW |
1441 | $check = 1; |
1442 | $cond_lines++; | |
1443 | } | |
1444 | ||
1445 | # Also ignore a loop construct at the end of a | |
1446 | # preprocessor statement. | |
1447 | if (($prevline =~ /^.\s*#\s*define\s/ || | |
1448 | $prevline =~ /\\\s*$/) && $continuation == 0) { | |
1449 | $check = 0; | |
1450 | } | |
1451 | ||
9bd49efe AW |
1452 | my $cond_ptr = -1; |
1453 | while ($cond_ptr != $cond_lines) { | |
1454 | $cond_ptr = $cond_lines; | |
1455 | ||
1456 | # Ignore: | |
1457 | # 1) blank lines, they should be at 0, | |
1458 | # 2) preprocessor lines, and | |
1459 | # 3) labels. | |
1460 | if ($s =~ /^\s*?\n/ || | |
1461 | $s =~ /^\s*#\s*?/ || | |
1462 | $s =~ /^\s*$Ident\s*:/) { | |
1463 | $s =~ s/^.*?\n//; | |
1464 | $cond_lines++; | |
1465 | } | |
4d001e4d AW |
1466 | } |
1467 | ||
1468 | my (undef, $sindent) = line_stats("+" . $s); | |
1469 | my $stat_real = raw_line($linenr, $cond_lines); | |
1470 | ||
1471 | # Check if either of these lines are modified, else | |
1472 | # this is not this patch's fault. | |
1473 | if (!defined($stat_real) || | |
1474 | $stat !~ /^\+/ && $stat_real !~ /^\+/) { | |
1475 | $check = 0; | |
1476 | } | |
1477 | if (defined($stat_real) && $cond_lines > 1) { | |
1478 | $stat_real = "[...]\n$stat_real"; | |
1479 | } | |
1480 | ||
9bd49efe | 1481 | #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n"; |
4d001e4d AW |
1482 | |
1483 | if ($check && (($sindent % 8) != 0 || | |
1484 | ($sindent <= $indent && $s ne ''))) { | |
1485 | WARN("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n"); | |
1486 | } | |
1487 | } | |
1488 | ||
6c72ffaa AW |
1489 | # Track the 'values' across context and added lines. |
1490 | my $opline = $line; $opline =~ s/^./ /; | |
1f65f947 AW |
1491 | my ($curr_values, $curr_vars) = |
1492 | annotate_values($opline . "\n", $prev_values); | |
6c72ffaa | 1493 | $curr_values = $prev_values . $curr_values; |
c2fdda0d AW |
1494 | if ($dbg_values) { |
1495 | my $outline = $opline; $outline =~ s/\t/ /g; | |
cf655043 AW |
1496 | print "$linenr > .$outline\n"; |
1497 | print "$linenr > $curr_values\n"; | |
1f65f947 | 1498 | print "$linenr > $curr_vars\n"; |
c2fdda0d | 1499 | } |
6c72ffaa AW |
1500 | $prev_values = substr($curr_values, -1); |
1501 | ||
00df344f AW |
1502 | #ignore lines not being added |
1503 | if ($line=~/^[^\+]/) {next;} | |
1504 | ||
653d4876 | 1505 | # TEST: allow direct testing of the type matcher. |
7429c690 AW |
1506 | if ($dbg_type) { |
1507 | if ($line =~ /^.\s*$Declare\s*$/) { | |
1508 | ERROR("TEST: is type\n" . $herecurr); | |
1509 | } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) { | |
1510 | ERROR("TEST: is not type ($1 is)\n". $herecurr); | |
1511 | } | |
653d4876 AW |
1512 | next; |
1513 | } | |
a1ef277e AW |
1514 | # TEST: allow direct testing of the attribute matcher. |
1515 | if ($dbg_attr) { | |
1516 | if ($line =~ /^.\s*$Attribute\s*$/) { | |
1517 | ERROR("TEST: is attr\n" . $herecurr); | |
1518 | } elsif ($dbg_attr > 1 && $line =~ /^.+($Attribute)/) { | |
1519 | ERROR("TEST: is not attr ($1 is)\n". $herecurr); | |
1520 | } | |
1521 | next; | |
1522 | } | |
653d4876 | 1523 | |
f0a594c1 AW |
1524 | # check for initialisation to aggregates open brace on the next line |
1525 | if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ && | |
1526 | $line =~ /^.\s*{/) { | |
773647a0 | 1527 | ERROR("that open brace { should be on the previous line\n" . $hereprev); |
f0a594c1 AW |
1528 | } |
1529 | ||
653d4876 AW |
1530 | # |
1531 | # Checks which are anchored on the added line. | |
1532 | # | |
1533 | ||
1534 | # check for malformed paths in #include statements (uses RAW line) | |
c45dcabd | 1535 | if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) { |
653d4876 AW |
1536 | my $path = $1; |
1537 | if ($path =~ m{//}) { | |
de7d4f0e AW |
1538 | ERROR("malformed #include filename\n" . |
1539 | $herecurr); | |
653d4876 | 1540 | } |
653d4876 | 1541 | } |
00df344f | 1542 | |
0a920b5b | 1543 | # no C99 // comments |
00df344f | 1544 | if ($line =~ m{//}) { |
de7d4f0e | 1545 | ERROR("do not use C99 // comments\n" . $herecurr); |
0a920b5b | 1546 | } |
00df344f | 1547 | # Remove C99 comments. |
0a920b5b | 1548 | $line =~ s@//.*@@; |
6c72ffaa | 1549 | $opline =~ s@//.*@@; |
0a920b5b AW |
1550 | |
1551 | #EXPORT_SYMBOL should immediately follow its function closing }. | |
653d4876 AW |
1552 | if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) || |
1553 | ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { | |
1554 | my $name = $1; | |
0a920b5b AW |
1555 | if (($prevline !~ /^}/) && |
1556 | ($prevline !~ /^\+}/) && | |
653d4876 | 1557 | ($prevline !~ /^ }/) && |
cf655043 AW |
1558 | ($prevline !~ /^.DECLARE_$Ident\(\Q$name\E\)/) && |
1559 | ($prevline !~ /^.LIST_HEAD\(\Q$name\E\)/) && | |
171ae1a4 | 1560 | ($prevline !~ /^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(/) && |
cf655043 | 1561 | ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[)/)) { |
de7d4f0e | 1562 | WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr); |
0a920b5b AW |
1563 | } |
1564 | } | |
1565 | ||
f0a594c1 | 1566 | # check for external initialisers. |
c45dcabd | 1567 | if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { |
f0a594c1 AW |
1568 | ERROR("do not initialise externals to 0 or NULL\n" . |
1569 | $herecurr); | |
1570 | } | |
653d4876 | 1571 | # check for static initialisers. |
9c9ba34e | 1572 | if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) { |
de7d4f0e AW |
1573 | ERROR("do not initialise statics to 0 or NULL\n" . |
1574 | $herecurr); | |
0a920b5b AW |
1575 | } |
1576 | ||
653d4876 AW |
1577 | # check for new typedefs, only function parameters and sparse annotations |
1578 | # make sense. | |
1579 | if ($line =~ /\btypedef\s/ && | |
9c0ca6f9 | 1580 | $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ && |
c45dcabd | 1581 | $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && |
653d4876 | 1582 | $line !~ /\b__bitwise(?:__|)\b/) { |
de7d4f0e | 1583 | WARN("do not add new typedefs\n" . $herecurr); |
0a920b5b AW |
1584 | } |
1585 | ||
1586 | # * goes on variable not on type | |
d8aaf121 | 1587 | if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) { |
de7d4f0e AW |
1588 | ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" . |
1589 | $herecurr); | |
d8aaf121 AW |
1590 | |
1591 | } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) { | |
de7d4f0e AW |
1592 | ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" . |
1593 | $herecurr); | |
d8aaf121 | 1594 | |
234fff65 | 1595 | } elsif ($line =~ m{\b$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) { |
de7d4f0e AW |
1596 | ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" . |
1597 | $herecurr); | |
d8aaf121 | 1598 | |
234fff65 | 1599 | } elsif ($line =~ m{\b$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) { |
de7d4f0e AW |
1600 | ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" . |
1601 | $herecurr); | |
0a920b5b AW |
1602 | } |
1603 | ||
1604 | # # no BUG() or BUG_ON() | |
1605 | # if ($line =~ /\b(BUG|BUG_ON)\b/) { | |
1606 | # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n"; | |
1607 | # print "$herecurr"; | |
1608 | # $clean = 0; | |
1609 | # } | |
1610 | ||
8905a67c | 1611 | if ($line =~ /\bLINUX_VERSION_CODE\b/) { |
c2fdda0d | 1612 | WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); |
8905a67c AW |
1613 | } |
1614 | ||
00df344f AW |
1615 | # printk should use KERN_* levels. Note that follow on printk's on the |
1616 | # same line do not need a level, so we use the current block context | |
1617 | # to try and find and validate the current printk. In summary the current | |
1618 | # printk includes all preceeding printk's which have no newline on the end. | |
1619 | # we assume the first bad printk is the one to report. | |
f0a594c1 | 1620 | if ($line =~ /\bprintk\((?!KERN_)\s*"/) { |
00df344f AW |
1621 | my $ok = 0; |
1622 | for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) { | |
1623 | #print "CHECK<$lines[$ln - 1]\n"; | |
1624 | # we have a preceeding printk if it ends | |
1625 | # with "\n" ignore it, else it is to blame | |
1626 | if ($lines[$ln - 1] =~ m{\bprintk\(}) { | |
1627 | if ($rawlines[$ln - 1] !~ m{\\n"}) { | |
1628 | $ok = 1; | |
1629 | } | |
1630 | last; | |
1631 | } | |
1632 | } | |
1633 | if ($ok == 0) { | |
de7d4f0e | 1634 | WARN("printk() should include KERN_ facility level\n" . $herecurr); |
00df344f | 1635 | } |
0a920b5b AW |
1636 | } |
1637 | ||
653d4876 AW |
1638 | # function brace can't be on same line, except for #defines of do while, |
1639 | # or if closed on same line | |
c45dcabd AW |
1640 | if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and |
1641 | !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) { | |
de7d4f0e | 1642 | ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); |
0a920b5b | 1643 | } |
653d4876 | 1644 | |
8905a67c AW |
1645 | # open braces for enum, union and struct go on the same line. |
1646 | if ($line =~ /^.\s*{/ && | |
1647 | $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { | |
1648 | ERROR("open brace '{' following $1 go on the same line\n" . $hereprev); | |
1649 | } | |
1650 | ||
8d31cfce AW |
1651 | # check for spacing round square brackets; allowed: |
1652 | # 1. with a type on the left -- int [] a; | |
fe2a7dbc AW |
1653 | # 2. at the beginning of a line for slice initialisers -- [0...10] = 5, |
1654 | # 3. inside a curly brace -- = { [0...10] = 5 } | |
8d31cfce AW |
1655 | while ($line =~ /(.*?\s)\[/g) { |
1656 | my ($where, $prefix) = ($-[1], $1); | |
1657 | if ($prefix !~ /$Type\s+$/ && | |
fe2a7dbc AW |
1658 | ($where != 0 || $prefix !~ /^.\s+$/) && |
1659 | $prefix !~ /{\s+$/) { | |
8d31cfce AW |
1660 | ERROR("space prohibited before open square bracket '['\n" . $herecurr); |
1661 | } | |
1662 | } | |
1663 | ||
f0a594c1 | 1664 | # check for spaces between functions and their parentheses. |
6c72ffaa | 1665 | while ($line =~ /($Ident)\s+\(/g) { |
c2fdda0d | 1666 | my $name = $1; |
773647a0 AW |
1667 | my $ctx_before = substr($line, 0, $-[1]); |
1668 | my $ctx = "$ctx_before$name"; | |
c2fdda0d AW |
1669 | |
1670 | # Ignore those directives where spaces _are_ permitted. | |
773647a0 AW |
1671 | if ($name =~ /^(?: |
1672 | if|for|while|switch|return|case| | |
1673 | volatile|__volatile__| | |
1674 | __attribute__|format|__extension__| | |
1675 | asm|__asm__)$/x) | |
1676 | { | |
c2fdda0d AW |
1677 | |
1678 | # cpp #define statements have non-optional spaces, ie | |
1679 | # if there is a space between the name and the open | |
1680 | # parenthesis it is simply not a parameter group. | |
c45dcabd | 1681 | } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { |
773647a0 AW |
1682 | |
1683 | # cpp #elif statement condition may start with a ( | |
c45dcabd | 1684 | } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) { |
c2fdda0d AW |
1685 | |
1686 | # If this whole things ends with a type its most | |
1687 | # likely a typedef for a function. | |
773647a0 | 1688 | } elsif ($ctx =~ /$Type$/) { |
c2fdda0d AW |
1689 | |
1690 | } else { | |
773647a0 | 1691 | WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr); |
6c72ffaa | 1692 | } |
f0a594c1 | 1693 | } |
653d4876 | 1694 | # Check operator spacing. |
0a920b5b | 1695 | if (!($line=~/\#\s*include/)) { |
9c0ca6f9 AW |
1696 | my $ops = qr{ |
1697 | <<=|>>=|<=|>=|==|!=| | |
1698 | \+=|-=|\*=|\/=|%=|\^=|\|=|&=| | |
1699 | =>|->|<<|>>|<|>|=|!|~| | |
1f65f947 AW |
1700 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%| |
1701 | \?|: | |
9c0ca6f9 | 1702 | }x; |
cf655043 | 1703 | my @elements = split(/($ops|;)/, $opline); |
00df344f | 1704 | my $off = 0; |
6c72ffaa AW |
1705 | |
1706 | my $blank = copy_spacing($opline); | |
1707 | ||
0a920b5b | 1708 | for (my $n = 0; $n < $#elements; $n += 2) { |
4a0df2ef AW |
1709 | $off += length($elements[$n]); |
1710 | ||
773647a0 AW |
1711 | # Pick up the preceeding and succeeding characters. |
1712 | my $ca = substr($opline, 0, $off); | |
1713 | my $cc = ''; | |
1714 | if (length($opline) >= ($off + length($elements[$n + 1]))) { | |
1715 | $cc = substr($opline, $off + length($elements[$n + 1])); | |
1716 | } | |
1717 | my $cb = "$ca$;$cc"; | |
1718 | ||
4a0df2ef AW |
1719 | my $a = ''; |
1720 | $a = 'V' if ($elements[$n] ne ''); | |
1721 | $a = 'W' if ($elements[$n] =~ /\s$/); | |
cf655043 | 1722 | $a = 'C' if ($elements[$n] =~ /$;$/); |
4a0df2ef AW |
1723 | $a = 'B' if ($elements[$n] =~ /(\[|\()$/); |
1724 | $a = 'O' if ($elements[$n] eq ''); | |
773647a0 | 1725 | $a = 'E' if ($ca =~ /^\s*$/); |
4a0df2ef | 1726 | |
0a920b5b | 1727 | my $op = $elements[$n + 1]; |
4a0df2ef AW |
1728 | |
1729 | my $c = ''; | |
0a920b5b | 1730 | if (defined $elements[$n + 2]) { |
4a0df2ef AW |
1731 | $c = 'V' if ($elements[$n + 2] ne ''); |
1732 | $c = 'W' if ($elements[$n + 2] =~ /^\s/); | |
cf655043 | 1733 | $c = 'C' if ($elements[$n + 2] =~ /^$;/); |
4a0df2ef AW |
1734 | $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/); |
1735 | $c = 'O' if ($elements[$n + 2] eq ''); | |
22f2a2ef | 1736 | $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/); |
4a0df2ef AW |
1737 | } else { |
1738 | $c = 'E'; | |
0a920b5b AW |
1739 | } |
1740 | ||
4a0df2ef AW |
1741 | my $ctx = "${a}x${c}"; |
1742 | ||
1743 | my $at = "(ctx:$ctx)"; | |
1744 | ||
6c72ffaa | 1745 | my $ptr = substr($blank, 0, $off) . "^"; |
de7d4f0e | 1746 | my $hereptr = "$hereline$ptr\n"; |
0a920b5b | 1747 | |
74048ed8 | 1748 | # Pull out the value of this operator. |
6c72ffaa | 1749 | my $op_type = substr($curr_values, $off + 1, 1); |
0a920b5b | 1750 | |
1f65f947 AW |
1751 | # Get the full operator variant. |
1752 | my $opv = $op . substr($curr_vars, $off, 1); | |
1753 | ||
13214adf AW |
1754 | # Ignore operators passed as parameters. |
1755 | if ($op_type ne 'V' && | |
1756 | $ca =~ /\s$/ && $cc =~ /^\s*,/) { | |
1757 | ||
cf655043 AW |
1758 | # # Ignore comments |
1759 | # } elsif ($op =~ /^$;+$/) { | |
13214adf | 1760 | |
d8aaf121 | 1761 | # ; should have either the end of line or a space or \ after it |
13214adf | 1762 | } elsif ($op eq ';') { |
cf655043 AW |
1763 | if ($ctx !~ /.x[WEBC]/ && |
1764 | $cc !~ /^\\/ && $cc !~ /^;/) { | |
773647a0 | 1765 | ERROR("space required after that '$op' $at\n" . $hereptr); |
d8aaf121 AW |
1766 | } |
1767 | ||
1768 | # // is a comment | |
1769 | } elsif ($op eq '//') { | |
0a920b5b | 1770 | |
1f65f947 AW |
1771 | # No spaces for: |
1772 | # -> | |
1773 | # : when part of a bitfield | |
1774 | } elsif ($op eq '->' || $opv eq ':B') { | |
4a0df2ef | 1775 | if ($ctx =~ /Wx.|.xW/) { |
773647a0 | 1776 | ERROR("spaces prohibited around that '$op' $at\n" . $hereptr); |
0a920b5b AW |
1777 | } |
1778 | ||
1779 | # , must have a space on the right. | |
1780 | } elsif ($op eq ',') { | |
cf655043 | 1781 | if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) { |
773647a0 | 1782 | ERROR("space required after that '$op' $at\n" . $hereptr); |
0a920b5b AW |
1783 | } |
1784 | ||
9c0ca6f9 | 1785 | # '*' as part of a type definition -- reported already. |
74048ed8 | 1786 | } elsif ($opv eq '*_') { |
9c0ca6f9 AW |
1787 | #warn "'*' is part of type\n"; |
1788 | ||
1789 | # unary operators should have a space before and | |
1790 | # none after. May be left adjacent to another | |
1791 | # unary operator, or a cast | |
1792 | } elsif ($op eq '!' || $op eq '~' || | |
74048ed8 | 1793 | $opv eq '*U' || $opv eq '-U' || |
0d413866 | 1794 | $opv eq '&U' || $opv eq '&&U') { |
cf655043 | 1795 | if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { |
773647a0 | 1796 | ERROR("space required before that '$op' $at\n" . $hereptr); |
0a920b5b | 1797 | } |
74048ed8 | 1798 | if ($op eq '*' && $cc =~/\s*const\b/) { |
171ae1a4 AW |
1799 | # A unary '*' may be const |
1800 | ||
1801 | } elsif ($ctx =~ /.xW/) { | |
773647a0 | 1802 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
0a920b5b AW |
1803 | } |
1804 | ||
1805 | # unary ++ and unary -- are allowed no space on one side. | |
1806 | } elsif ($op eq '++' or $op eq '--') { | |
773647a0 AW |
1807 | if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) { |
1808 | ERROR("space required one side of that '$op' $at\n" . $hereptr); | |
1809 | } | |
1810 | if ($ctx =~ /Wx[BE]/ || | |
1811 | ($ctx =~ /Wx./ && $cc =~ /^;/)) { | |
1812 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); | |
0a920b5b | 1813 | } |
773647a0 AW |
1814 | if ($ctx =~ /ExW/) { |
1815 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); | |
653d4876 | 1816 | } |
0a920b5b | 1817 | |
773647a0 | 1818 | |
0a920b5b | 1819 | # << and >> may either have or not have spaces both sides |
9c0ca6f9 AW |
1820 | } elsif ($op eq '<<' or $op eq '>>' or |
1821 | $op eq '&' or $op eq '^' or $op eq '|' or | |
1822 | $op eq '+' or $op eq '-' or | |
c2fdda0d AW |
1823 | $op eq '*' or $op eq '/' or |
1824 | $op eq '%') | |
0a920b5b | 1825 | { |
773647a0 | 1826 | if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { |
de7d4f0e AW |
1827 | ERROR("need consistent spacing around '$op' $at\n" . |
1828 | $hereptr); | |
0a920b5b AW |
1829 | } |
1830 | ||
1f65f947 AW |
1831 | # A colon needs no spaces before when it is |
1832 | # terminating a case value or a label. | |
1833 | } elsif ($opv eq ':C' || $opv eq ':L') { | |
1834 | if ($ctx =~ /Wx./) { | |
1835 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); | |
1836 | } | |
1837 | ||
0a920b5b | 1838 | # All the others need spaces both sides. |
cf655043 | 1839 | } elsif ($ctx !~ /[EWC]x[CWE]/) { |
1f65f947 AW |
1840 | my $ok = 0; |
1841 | ||
22f2a2ef | 1842 | # Ignore email addresses <foo@bar> |
1f65f947 AW |
1843 | if (($op eq '<' && |
1844 | $cc =~ /^\S+\@\S+>/) || | |
1845 | ($op eq '>' && | |
1846 | $ca =~ /<\S+\@\S+$/)) | |
1847 | { | |
1848 | $ok = 1; | |
1849 | } | |
1850 | ||
1851 | # Ignore ?: | |
1852 | if (($opv eq ':O' && $ca =~ /\?$/) || | |
1853 | ($op eq '?' && $cc =~ /^:/)) { | |
1854 | $ok = 1; | |
1855 | } | |
1856 | ||
1857 | if ($ok == 0) { | |
773647a0 | 1858 | ERROR("spaces required around that '$op' $at\n" . $hereptr); |
22f2a2ef | 1859 | } |
0a920b5b | 1860 | } |
4a0df2ef | 1861 | $off += length($elements[$n + 1]); |
0a920b5b AW |
1862 | } |
1863 | } | |
1864 | ||
f0a594c1 AW |
1865 | # check for multiple assignments |
1866 | if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) { | |
6c72ffaa | 1867 | CHK("multiple assignments should be avoided\n" . $herecurr); |
f0a594c1 AW |
1868 | } |
1869 | ||
22f2a2ef AW |
1870 | ## # check for multiple declarations, allowing for a function declaration |
1871 | ## # continuation. | |
1872 | ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ && | |
1873 | ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) { | |
1874 | ## | |
1875 | ## # Remove any bracketed sections to ensure we do not | |
1876 | ## # falsly report the parameters of functions. | |
1877 | ## my $ln = $line; | |
1878 | ## while ($ln =~ s/\([^\(\)]*\)//g) { | |
1879 | ## } | |
1880 | ## if ($ln =~ /,/) { | |
1881 | ## WARN("declaring multiple variables together should be avoided\n" . $herecurr); | |
1882 | ## } | |
1883 | ## } | |
f0a594c1 | 1884 | |
0a920b5b | 1885 | #need space before brace following if, while, etc |
22f2a2ef AW |
1886 | if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) || |
1887 | $line =~ /do{/) { | |
773647a0 | 1888 | ERROR("space required before the open brace '{'\n" . $herecurr); |
de7d4f0e AW |
1889 | } |
1890 | ||
1891 | # closing brace should have a space following it when it has anything | |
1892 | # on the line | |
1893 | if ($line =~ /}(?!(?:,|;|\)))\S/) { | |
773647a0 | 1894 | ERROR("space required after that close brace '}'\n" . $herecurr); |
0a920b5b AW |
1895 | } |
1896 | ||
22f2a2ef AW |
1897 | # check spacing on square brackets |
1898 | if ($line =~ /\[\s/ && $line !~ /\[\s*$/) { | |
773647a0 | 1899 | ERROR("space prohibited after that open square bracket '['\n" . $herecurr); |
22f2a2ef AW |
1900 | } |
1901 | if ($line =~ /\s\]/) { | |
773647a0 | 1902 | ERROR("space prohibited before that close square bracket ']'\n" . $herecurr); |
22f2a2ef AW |
1903 | } |
1904 | ||
c45dcabd | 1905 | # check spacing on parentheses |
9c0ca6f9 AW |
1906 | if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ && |
1907 | $line !~ /for\s*\(\s+;/) { | |
773647a0 | 1908 | ERROR("space prohibited after that open parenthesis '('\n" . $herecurr); |
22f2a2ef | 1909 | } |
13214adf | 1910 | if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ && |
c45dcabd AW |
1911 | $line !~ /for\s*\(.*;\s+\)/ && |
1912 | $line !~ /:\s+\)/) { | |
773647a0 | 1913 | ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr); |
22f2a2ef AW |
1914 | } |
1915 | ||
0a920b5b | 1916 | #goto labels aren't indented, allow a single space however |
4a0df2ef | 1917 | if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and |
0a920b5b | 1918 | !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) { |
de7d4f0e | 1919 | WARN("labels should not be indented\n" . $herecurr); |
0a920b5b AW |
1920 | } |
1921 | ||
c45dcabd AW |
1922 | # Return is not a function. |
1923 | if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { | |
1924 | my $spacing = $1; | |
1925 | my $value = $2; | |
1926 | ||
1927 | # Flatten any parentheses and braces | |
fee61c47 | 1928 | $value =~ s/\)\(/\) \(/g; |
c45dcabd AW |
1929 | while ($value =~ s/\([^\(\)]*\)/1/) { |
1930 | } | |
1931 | ||
1932 | if ($value =~ /^(?:$Ident|-?$Constant)$/) { | |
1933 | ERROR("return is not a function, parentheses are not required\n" . $herecurr); | |
1934 | ||
1935 | } elsif ($spacing !~ /\s+/) { | |
1936 | ERROR("space required before the open parenthesis '('\n" . $herecurr); | |
1937 | } | |
1938 | } | |
1939 | ||
0a920b5b | 1940 | # Need a space before open parenthesis after if, while etc |
4a0df2ef | 1941 | if ($line=~/\b(if|while|for|switch)\(/) { |
773647a0 | 1942 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
0a920b5b AW |
1943 | } |
1944 | ||
f5fe35dd AW |
1945 | # Check for illegal assignment in if conditional -- and check for trailing |
1946 | # statements after the conditional. | |
53210168 | 1947 | if ($line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { |
171ae1a4 | 1948 | my ($s, $c) = ($stat, $cond); |
8905a67c AW |
1949 | |
1950 | if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) { | |
c2fdda0d | 1951 | ERROR("do not use assignment in if condition\n" . $herecurr); |
8905a67c AW |
1952 | } |
1953 | ||
1954 | # Find out what is on the end of the line after the | |
1955 | # conditional. | |
773647a0 | 1956 | substr($s, 0, length($c), ''); |
8905a67c | 1957 | $s =~ s/\n.*//g; |
13214adf | 1958 | $s =~ s/$;//g; # Remove any comments |
53210168 AW |
1959 | if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ && |
1960 | $c !~ /}\s*while\s*/) | |
773647a0 | 1961 | { |
8905a67c AW |
1962 | ERROR("trailing statements should be on next line\n" . $herecurr); |
1963 | } | |
1964 | } | |
1965 | ||
13214adf AW |
1966 | # Check for bitwise tests written as boolean |
1967 | if ($line =~ / | |
1968 | (?: | |
1969 | (?:\[|\(|\&\&|\|\|) | |
1970 | \s*0[xX][0-9]+\s* | |
1971 | (?:\&\&|\|\|) | |
1972 | | | |
1973 | (?:\&\&|\|\|) | |
1974 | \s*0[xX][0-9]+\s* | |
1975 | (?:\&\&|\|\||\)|\]) | |
1976 | )/x) | |
1977 | { | |
1978 | WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr); | |
1979 | } | |
1980 | ||
8905a67c | 1981 | # if and else should not have general statements after it |
13214adf AW |
1982 | if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) { |
1983 | my $s = $1; | |
1984 | $s =~ s/$;//g; # Remove any comments | |
1985 | if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) { | |
1986 | ERROR("trailing statements should be on next line\n" . $herecurr); | |
1987 | } | |
0a920b5b AW |
1988 | } |
1989 | ||
1990 | # Check for }<nl>else {, these must be at the same | |
1991 | # indent level to be relevant to each other. | |
1992 | if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and | |
1993 | $previndent == $indent) { | |
de7d4f0e | 1994 | ERROR("else should follow close brace '}'\n" . $hereprev); |
0a920b5b AW |
1995 | } |
1996 | ||
c2fdda0d AW |
1997 | if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and |
1998 | $previndent == $indent) { | |
1999 | my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0); | |
2000 | ||
2001 | # Find out what is on the end of the line after the | |
2002 | # conditional. | |
773647a0 | 2003 | substr($s, 0, length($c), ''); |
c2fdda0d AW |
2004 | $s =~ s/\n.*//g; |
2005 | ||
2006 | if ($s =~ /^\s*;/) { | |
2007 | ERROR("while should follow close brace '}'\n" . $hereprev); | |
2008 | } | |
2009 | } | |
2010 | ||
0a920b5b AW |
2011 | #studly caps, commented out until figure out how to distinguish between use of existing and adding new |
2012 | # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { | |
2013 | # print "No studly caps, use _\n"; | |
2014 | # print "$herecurr"; | |
2015 | # $clean = 0; | |
2016 | # } | |
2017 | ||
2018 | #no spaces allowed after \ in define | |
c45dcabd | 2019 | if ($line=~/\#\s*define.*\\\s$/) { |
de7d4f0e | 2020 | WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr); |
0a920b5b AW |
2021 | } |
2022 | ||
653d4876 | 2023 | #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line) |
c45dcabd | 2024 | if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) { |
e09dec48 AW |
2025 | my $file = "$1.h"; |
2026 | my $checkfile = "include/linux/$file"; | |
2027 | if (-f "$root/$checkfile" && | |
2028 | $realfile ne $checkfile && | |
c45dcabd AW |
2029 | $1 ne 'irq') |
2030 | { | |
e09dec48 AW |
2031 | if ($realfile =~ m{^arch/}) { |
2032 | CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr); | |
2033 | } else { | |
2034 | WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr); | |
2035 | } | |
0a920b5b AW |
2036 | } |
2037 | } | |
2038 | ||
653d4876 AW |
2039 | # multi-statement macros should be enclosed in a do while loop, grab the |
2040 | # first statement and ensure its the whole macro if its not enclosed | |
cf655043 | 2041 | # in a known good container |
b8f96a31 AW |
2042 | if ($realfile !~ m@/vmlinux.lds.h$@ && |
2043 | $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) { | |
d8aaf121 AW |
2044 | my $ln = $linenr; |
2045 | my $cnt = $realcnt; | |
c45dcabd AW |
2046 | my ($off, $dstat, $dcond, $rest); |
2047 | my $ctx = ''; | |
653d4876 | 2048 | |
c45dcabd AW |
2049 | my $args = defined($1); |
2050 | ||
2051 | # Find the end of the macro and limit our statement | |
2052 | # search to that. | |
2053 | while ($cnt > 0 && defined $lines[$ln - 1] && | |
2054 | $lines[$ln - 1] =~ /^(?:-|..*\\$)/) | |
2055 | { | |
2056 | $ctx .= $rawlines[$ln - 1] . "\n"; | |
a3bb97a7 | 2057 | $cnt-- if ($lines[$ln - 1] !~ /^-/); |
c45dcabd | 2058 | $ln++; |
c45dcabd AW |
2059 | } |
2060 | $ctx .= $rawlines[$ln - 1]; | |
2061 | ||
2062 | ($dstat, $dcond, $ln, $cnt, $off) = | |
2063 | ctx_statement_block($linenr, $ln - $linenr + 1, 0); | |
2064 | #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n"; | |
a3bb97a7 | 2065 | #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n"; |
c45dcabd AW |
2066 | |
2067 | # Extract the remainder of the define (if any) and | |
2068 | # rip off surrounding spaces, and trailing \'s. | |
2069 | $rest = ''; | |
636d140a AW |
2070 | while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) { |
2071 | #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n"; | |
a3bb97a7 AW |
2072 | if ($off != 0 || $lines[$ln - 1] !~ /^-/) { |
2073 | $rest .= substr($lines[$ln - 1], $off) . "\n"; | |
2074 | $cnt--; | |
2075 | } | |
c45dcabd | 2076 | $ln++; |
c45dcabd AW |
2077 | $off = 0; |
2078 | } | |
2079 | $rest =~ s/\\\n.//g; | |
2080 | $rest =~ s/^\s*//s; | |
2081 | $rest =~ s/\s*$//s; | |
2082 | ||
2083 | # Clean up the original statement. | |
2084 | if ($args) { | |
2085 | substr($dstat, 0, length($dcond), ''); | |
2086 | } else { | |
2087 | $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//; | |
d8aaf121 | 2088 | } |
292f1a9b | 2089 | $dstat =~ s/$;//g; |
c45dcabd AW |
2090 | $dstat =~ s/\\\n.//g; |
2091 | $dstat =~ s/^\s*//s; | |
2092 | $dstat =~ s/\s*$//s; | |
de7d4f0e | 2093 | |
c45dcabd AW |
2094 | # Flatten any parentheses and braces |
2095 | while ($dstat =~ s/\([^\(\)]*\)/1/) { | |
2096 | } | |
2097 | while ($dstat =~ s/\{[^\{\}]*\}/1/) { | |
de7d4f0e | 2098 | } |
d8aaf121 | 2099 | |
c45dcabd AW |
2100 | my $exceptions = qr{ |
2101 | $Declare| | |
2102 | module_param_named| | |
2103 | MODULE_PARAM_DESC| | |
2104 | DECLARE_PER_CPU| | |
2105 | DEFINE_PER_CPU| | |
2106 | __typeof__\( | |
2107 | }x; | |
a3bb97a7 | 2108 | #print "REST<$rest>\n"; |
c45dcabd AW |
2109 | if ($rest ne '') { |
2110 | if ($rest !~ /while\s*\(/ && | |
2111 | $dstat !~ /$exceptions/) | |
2112 | { | |
de7d4f0e | 2113 | ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n"); |
c45dcabd AW |
2114 | } |
2115 | ||
2116 | } elsif ($ctx !~ /;/) { | |
2117 | if ($dstat ne '' && | |
2118 | $dstat !~ /^(?:$Ident|-?$Constant)$/ && | |
2119 | $dstat !~ /$exceptions/ && | |
2120 | $dstat =~ /$Operators/) | |
2121 | { | |
de7d4f0e | 2122 | ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n"); |
d8aaf121 | 2123 | } |
653d4876 | 2124 | } |
0a920b5b AW |
2125 | } |
2126 | ||
f0a594c1 | 2127 | # check for redundant bracing round if etc |
13214adf AW |
2128 | if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) { |
2129 | my ($level, $endln, @chunks) = | |
cf655043 | 2130 | ctx_statement_full($linenr, $realcnt, 1); |
13214adf | 2131 | #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n"; |
cf655043 AW |
2132 | #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n"; |
2133 | if ($#chunks > 0 && $level == 0) { | |
13214adf AW |
2134 | my $allowed = 0; |
2135 | my $seen = 0; | |
773647a0 | 2136 | my $herectx = $here . "\n"; |
cf655043 | 2137 | my $ln = $linenr - 1; |
13214adf AW |
2138 | for my $chunk (@chunks) { |
2139 | my ($cond, $block) = @{$chunk}; | |
2140 | ||
773647a0 AW |
2141 | # If the condition carries leading newlines, then count those as offsets. |
2142 | my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s); | |
2143 | my $offset = statement_rawlines($whitespace) - 1; | |
2144 | ||
2145 | #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n"; | |
2146 | ||
2147 | # We have looked at and allowed this specific line. | |
2148 | $suppress_ifbraces{$ln + $offset} = 1; | |
2149 | ||
2150 | $herectx .= "$rawlines[$ln + $offset]\n[...]\n"; | |
cf655043 AW |
2151 | $ln += statement_rawlines($block) - 1; |
2152 | ||
773647a0 | 2153 | substr($block, 0, length($cond), ''); |
13214adf AW |
2154 | |
2155 | $seen++ if ($block =~ /^\s*{/); | |
2156 | ||
cf655043 AW |
2157 | #print "cond<$cond> block<$block> allowed<$allowed>\n"; |
2158 | if (statement_lines($cond) > 1) { | |
2159 | #print "APW: ALLOWED: cond<$cond>\n"; | |
13214adf AW |
2160 | $allowed = 1; |
2161 | } | |
2162 | if ($block =~/\b(?:if|for|while)\b/) { | |
cf655043 | 2163 | #print "APW: ALLOWED: block<$block>\n"; |
13214adf AW |
2164 | $allowed = 1; |
2165 | } | |
cf655043 AW |
2166 | if (statement_block_size($block) > 1) { |
2167 | #print "APW: ALLOWED: lines block<$block>\n"; | |
13214adf AW |
2168 | $allowed = 1; |
2169 | } | |
2170 | } | |
2171 | if ($seen && !$allowed) { | |
cf655043 | 2172 | WARN("braces {} are not necessary for any arm of this statement\n" . $herectx); |
13214adf AW |
2173 | } |
2174 | } | |
2175 | } | |
773647a0 | 2176 | if (!defined $suppress_ifbraces{$linenr - 1} && |
13214adf | 2177 | $line =~ /\b(if|while|for|else)\b/) { |
cf655043 AW |
2178 | my $allowed = 0; |
2179 | ||
2180 | # Check the pre-context. | |
2181 | if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { | |
2182 | #print "APW: ALLOWED: pre<$1>\n"; | |
2183 | $allowed = 1; | |
2184 | } | |
773647a0 AW |
2185 | |
2186 | my ($level, $endln, @chunks) = | |
2187 | ctx_statement_full($linenr, $realcnt, $-[0]); | |
2188 | ||
cf655043 AW |
2189 | # Check the condition. |
2190 | my ($cond, $block) = @{$chunks[0]}; | |
773647a0 | 2191 | #print "CHECKING<$linenr> cond<$cond> block<$block>\n"; |
cf655043 | 2192 | if (defined $cond) { |
773647a0 | 2193 | substr($block, 0, length($cond), ''); |
cf655043 AW |
2194 | } |
2195 | if (statement_lines($cond) > 1) { | |
2196 | #print "APW: ALLOWED: cond<$cond>\n"; | |
2197 | $allowed = 1; | |
2198 | } | |
2199 | if ($block =~/\b(?:if|for|while)\b/) { | |
2200 | #print "APW: ALLOWED: block<$block>\n"; | |
2201 | $allowed = 1; | |
2202 | } | |
2203 | if (statement_block_size($block) > 1) { | |
2204 | #print "APW: ALLOWED: lines block<$block>\n"; | |
2205 | $allowed = 1; | |
2206 | } | |
2207 | # Check the post-context. | |
2208 | if (defined $chunks[1]) { | |
2209 | my ($cond, $block) = @{$chunks[1]}; | |
2210 | if (defined $cond) { | |
773647a0 | 2211 | substr($block, 0, length($cond), ''); |
cf655043 AW |
2212 | } |
2213 | if ($block =~ /^\s*\{/) { | |
2214 | #print "APW: ALLOWED: chunk-1 block<$block>\n"; | |
2215 | $allowed = 1; | |
2216 | } | |
2217 | } | |
2218 | if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) { | |
2219 | my $herectx = $here . "\n";; | |
f055663c | 2220 | my $cnt = statement_rawlines($block); |
cf655043 | 2221 | |
f055663c AW |
2222 | for (my $n = 0; $n < $cnt; $n++) { |
2223 | $herectx .= raw_line($linenr, $n) . "\n";; | |
f0a594c1 | 2224 | } |
cf655043 AW |
2225 | |
2226 | WARN("braces {} are not necessary for single statement blocks\n" . $herectx); | |
f0a594c1 AW |
2227 | } |
2228 | } | |
2229 | ||
653d4876 | 2230 | # don't include deprecated include files (uses RAW line) |
4a0df2ef | 2231 | for my $inc (@dep_includes) { |
c45dcabd | 2232 | if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) { |
de7d4f0e | 2233 | ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
0a920b5b AW |
2234 | } |
2235 | } | |
2236 | ||
4a0df2ef AW |
2237 | # don't use deprecated functions |
2238 | for my $func (@dep_functions) { | |
00df344f | 2239 | if ($line =~ /\b$func\b/) { |
de7d4f0e | 2240 | ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
4a0df2ef AW |
2241 | } |
2242 | } | |
2243 | ||
2244 | # no volatiles please | |
6c72ffaa AW |
2245 | my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; |
2246 | if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { | |
de7d4f0e | 2247 | WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); |
4a0df2ef AW |
2248 | } |
2249 | ||
9c0ca6f9 AW |
2250 | # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated |
2251 | if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) { | |
2252 | ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr); | |
2253 | } | |
2254 | ||
00df344f | 2255 | # warn about #if 0 |
c45dcabd | 2256 | if ($line =~ /^.\s*\#\s*if\s+0\b/) { |
de7d4f0e AW |
2257 | CHK("if this code is redundant consider removing it\n" . |
2258 | $herecurr); | |
4a0df2ef AW |
2259 | } |
2260 | ||
f0a594c1 AW |
2261 | # check for needless kfree() checks |
2262 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { | |
2263 | my $expr = $1; | |
2264 | if ($line =~ /\bkfree\(\Q$expr\E\);/) { | |
3c232147 | 2265 | WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev); |
f0a594c1 AW |
2266 | } |
2267 | } | |
4c432a8f GKH |
2268 | # check for needless usb_free_urb() checks |
2269 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { | |
2270 | my $expr = $1; | |
2271 | if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { | |
2272 | WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev); | |
2273 | } | |
2274 | } | |
f0a594c1 | 2275 | |
00df344f | 2276 | # warn about #ifdefs in C files |
c45dcabd | 2277 | # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { |
00df344f AW |
2278 | # print "#ifdef in C files should be avoided\n"; |
2279 | # print "$herecurr"; | |
2280 | # $clean = 0; | |
2281 | # } | |
2282 | ||
22f2a2ef | 2283 | # warn about spacing in #ifdefs |
c45dcabd | 2284 | if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) { |
22f2a2ef AW |
2285 | ERROR("exactly one space required after that #$1\n" . $herecurr); |
2286 | } | |
2287 | ||
4a0df2ef | 2288 | # check for spinlock_t definitions without a comment. |
171ae1a4 AW |
2289 | if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ || |
2290 | $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) { | |
4a0df2ef AW |
2291 | my $which = $1; |
2292 | if (!ctx_has_comment($first_line, $linenr)) { | |
de7d4f0e | 2293 | CHK("$1 definition without comment\n" . $herecurr); |
4a0df2ef AW |
2294 | } |
2295 | } | |
2296 | # check for memory barriers without a comment. | |
2297 | if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { | |
2298 | if (!ctx_has_comment($first_line, $linenr)) { | |
de7d4f0e | 2299 | CHK("memory barrier without comment\n" . $herecurr); |
4a0df2ef AW |
2300 | } |
2301 | } | |
2302 | # check of hardware specific defines | |
c45dcabd | 2303 | if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) { |
de7d4f0e | 2304 | CHK("architecture specific defines should be avoided\n" . $herecurr); |
0a920b5b | 2305 | } |
653d4876 | 2306 | |
de7d4f0e AW |
2307 | # check the location of the inline attribute, that it is between |
2308 | # storage class and type. | |
9c0ca6f9 AW |
2309 | if ($line =~ /\b$Type\s+$Inline\b/ || |
2310 | $line =~ /\b$Inline\s+$Storage\b/) { | |
de7d4f0e AW |
2311 | ERROR("inline keyword should sit between storage class and type\n" . $herecurr); |
2312 | } | |
2313 | ||
8905a67c AW |
2314 | # Check for __inline__ and __inline, prefer inline |
2315 | if ($line =~ /\b(__inline__|__inline)\b/) { | |
2316 | WARN("plain inline is preferred over $1\n" . $herecurr); | |
2317 | } | |
2318 | ||
de7d4f0e | 2319 | # check for new externs in .c files. |
171ae1a4 | 2320 | if ($realfile =~ /\.c$/ && defined $stat && |
c45dcabd | 2321 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |
171ae1a4 | 2322 | { |
c45dcabd AW |
2323 | my $function_name = $1; |
2324 | my $paren_space = $2; | |
171ae1a4 AW |
2325 | |
2326 | my $s = $stat; | |
2327 | if (defined $cond) { | |
2328 | substr($s, 0, length($cond), ''); | |
2329 | } | |
c45dcabd AW |
2330 | if ($s =~ /^\s*;/ && |
2331 | $function_name ne 'uninitialized_var') | |
2332 | { | |
171ae1a4 AW |
2333 | WARN("externs should be avoided in .c files\n" . $herecurr); |
2334 | } | |
2335 | ||
2336 | if ($paren_space =~ /\n/) { | |
2337 | WARN("arguments for function declarations should follow identifier\n" . $herecurr); | |
2338 | } | |
9c9ba34e AW |
2339 | |
2340 | } elsif ($realfile =~ /\.c$/ && defined $stat && | |
2341 | $stat =~ /^.\s*extern\s+/) | |
2342 | { | |
2343 | WARN("externs should be avoided in .c files\n" . $herecurr); | |
de7d4f0e AW |
2344 | } |
2345 | ||
2346 | # checks for new __setup's | |
2347 | if ($rawline =~ /\b__setup\("([^"]*)"/) { | |
2348 | my $name = $1; | |
2349 | ||
2350 | if (!grep(/$name/, @setup_docs)) { | |
2351 | CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr); | |
2352 | } | |
653d4876 | 2353 | } |
9c0ca6f9 AW |
2354 | |
2355 | # check for pointless casting of kmalloc return | |
2356 | if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) { | |
2357 | WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); | |
2358 | } | |
13214adf AW |
2359 | |
2360 | # check for gcc specific __FUNCTION__ | |
2361 | if ($line =~ /__FUNCTION__/) { | |
2362 | WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); | |
2363 | } | |
773647a0 AW |
2364 | |
2365 | # check for semaphores used as mutexes | |
171ae1a4 | 2366 | if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) { |
773647a0 AW |
2367 | WARN("mutexes are preferred for single holder semaphores\n" . $herecurr); |
2368 | } | |
2369 | # check for semaphores used as mutexes | |
171ae1a4 | 2370 | if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) { |
773647a0 AW |
2371 | WARN("consider using a completion\n" . $herecurr); |
2372 | } | |
2373 | # recommend strict_strto* over simple_strto* | |
2374 | if ($line =~ /\bsimple_(strto.*?)\s*\(/) { | |
2375 | WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr); | |
2376 | } | |
f3db6639 ME |
2377 | # check for __initcall(), use device_initcall() explicitly please |
2378 | if ($line =~ /^.\s*__initcall\s*\(/) { | |
2379 | WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); | |
2380 | } | |
773647a0 AW |
2381 | |
2382 | # use of NR_CPUS is usually wrong | |
2383 | # ignore definitions of NR_CPUS and usage to define arrays as likely right | |
2384 | if ($line =~ /\bNR_CPUS\b/ && | |
c45dcabd AW |
2385 | $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ && |
2386 | $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ && | |
171ae1a4 AW |
2387 | $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ && |
2388 | $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ && | |
2389 | $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/) | |
773647a0 AW |
2390 | { |
2391 | WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); | |
2392 | } | |
9c9ba34e AW |
2393 | |
2394 | # check for %L{u,d,i} in strings | |
2395 | my $string; | |
2396 | while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) { | |
2397 | $string = substr($rawline, $-[1], $+[1] - $-[1]); | |
2a1bc5d5 | 2398 | $string =~ s/%%/__/g; |
9c9ba34e AW |
2399 | if ($string =~ /(?<!%)%L[udi]/) { |
2400 | WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr); | |
2401 | last; | |
2402 | } | |
2403 | } | |
13214adf AW |
2404 | } |
2405 | ||
2406 | # If we have no input at all, then there is nothing to report on | |
2407 | # so just keep quiet. | |
2408 | if ($#rawlines == -1) { | |
2409 | exit(0); | |
0a920b5b AW |
2410 | } |
2411 | ||
8905a67c AW |
2412 | # In mailback mode only produce a report in the negative, for |
2413 | # things that appear to be patches. | |
2414 | if ($mailback && ($clean == 1 || !$is_patch)) { | |
2415 | exit(0); | |
2416 | } | |
2417 | ||
2418 | # This is not a patch, and we are are in 'no-patch' mode so | |
2419 | # just keep quiet. | |
2420 | if (!$chk_patch && !$is_patch) { | |
2421 | exit(0); | |
2422 | } | |
2423 | ||
2424 | if (!$is_patch) { | |
de7d4f0e | 2425 | ERROR("Does not appear to be a unified-diff format patch\n"); |
0a920b5b AW |
2426 | } |
2427 | if ($is_patch && $chk_signoff && $signoff == 0) { | |
de7d4f0e | 2428 | ERROR("Missing Signed-off-by: line(s)\n"); |
0a920b5b AW |
2429 | } |
2430 | ||
8905a67c | 2431 | print report_dump(); |
13214adf AW |
2432 | if ($summary && !($clean == 1 && $quiet == 1)) { |
2433 | print "$filename " if ($summary_file); | |
8905a67c AW |
2434 | print "total: $cnt_error errors, $cnt_warn warnings, " . |
2435 | (($check)? "$cnt_chk checks, " : "") . | |
2436 | "$cnt_lines lines checked\n"; | |
2437 | print "\n" if ($quiet == 0); | |
f0a594c1 | 2438 | } |
8905a67c | 2439 | |
0a920b5b | 2440 | if ($clean == 1 && $quiet == 0) { |
c2fdda0d | 2441 | print "$vname has no obvious style problems and is ready for submission.\n" |
0a920b5b AW |
2442 | } |
2443 | if ($clean == 0 && $quiet == 0) { | |
c2fdda0d | 2444 | print "$vname has style problems, please review. If any of these errors\n"; |
0a920b5b AW |
2445 | print "are false positives report them to the maintainer, see\n"; |
2446 | print "CHECKPATCH in MAINTAINERS.\n"; | |
2447 | } | |
13214adf | 2448 | |
0a920b5b AW |
2449 | return $clean; |
2450 | } |