]>
Commit | Line | Data |
---|---|---|
0ad19a3f | 1 | /* |
2 | * lxc: linux Container library | |
3 | * | |
4 | * (C) Copyright IBM Corp. 2007, 2008 | |
5 | * | |
6 | * Authors: | |
9afe19d6 | 7 | * Daniel Lezcano <daniel.lezcano at free.fr> |
35a02107 CB |
8 | * Serge Hallyn <serge@hallyn.com> |
9 | * Christian Brauner <christian.brauner@ubuntu.com> | |
0ad19a3f | 10 | * |
11 | * This library is free software; you can redistribute it and/or | |
12 | * modify it under the terms of the GNU Lesser General Public | |
13 | * License as published by the Free Software Foundation; either | |
14 | * version 2.1 of the License, or (at your option) any later version. | |
15 | * | |
16 | * This library is distributed in the hope that it will be useful, | |
17 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
18 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
19 | * Lesser General Public License for more details. | |
20 | * | |
21 | * You should have received a copy of the GNU Lesser General Public | |
22 | * License along with this library; if not, write to the Free Software | |
250b1eec | 23 | * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA |
0ad19a3f | 24 | */ |
25 | ||
f3787121 | 26 | #define _GNU_SOURCE |
f549edcc GK |
27 | #include "config.h" |
28 | ||
f3787121 | 29 | #include <alloca.h> |
0ad19a3f | 30 | #include <dirent.h> |
31 | #include <errno.h> | |
b0a33c1e | 32 | #include <fcntl.h> |
c476bdce | 33 | #include <grp.h> |
37515ebd | 34 | #include <poll.h> |
f3787121 CB |
35 | #include <signal.h> |
36 | #include <stdio.h> | |
37 | #include <stdlib.h> | |
38 | #include <string.h> | |
39 | #include <unistd.h> | |
0ad19a3f | 40 | #include <sys/file.h> |
f4d507d5 | 41 | #include <sys/mount.h> |
f3787121 | 42 | #include <sys/param.h> |
0ad19a3f | 43 | #include <sys/prctl.h> |
f3787121 CB |
44 | #include <sys/socket.h> |
45 | #include <sys/stat.h> | |
46 | #include <sys/syscall.h> | |
ddceb1f9 | 47 | #include <sys/types.h> |
b0a33c1e | 48 | #include <sys/un.h> |
f3787121 | 49 | #include <sys/wait.h> |
ff218c25 | 50 | |
e37dda71 | 51 | #if HAVE_LIBCAP |
495d2046 SG |
52 | #include <sys/capability.h> |
53 | #endif | |
54 | ||
995acccc | 55 | #if !HAVE_DECL_PR_CAPBSET_DROP |
656994bb MH |
56 | #define PR_CAPBSET_DROP 24 |
57 | #endif | |
58 | ||
995acccc | 59 | #if !HAVE_DECL_PR_SET_NO_NEW_PRIVS |
955e2a02 CB |
60 | #define PR_SET_NO_NEW_PRIVS 38 |
61 | #endif | |
62 | ||
995acccc | 63 | #if !HAVE_DECL_PR_GET_NO_NEW_PRIVS |
955e2a02 CB |
64 | #define PR_GET_NO_NEW_PRIVS 39 |
65 | #endif | |
66 | ||
f3787121 CB |
67 | #include "af_unix.h" |
68 | #include "caps.h" | |
563f2f2c | 69 | #include "cgroup.h" |
f3787121 | 70 | #include "commands.h" |
bbf5cf35 | 71 | #include "commands_utils.h" |
f3787121 | 72 | #include "conf.h" |
74c6e2b0 | 73 | #include "confile_utils.h" |
f3787121 | 74 | #include "console.h" |
e2bcd7db | 75 | #include "error.h" |
1cc8bd4b | 76 | #include "list.h" |
f3787121 | 77 | #include "log.h" |
f2d5a09d | 78 | #include "lxccontainer.h" |
f3787121 CB |
79 | #include "lxclock.h" |
80 | #include "lxcseccomp.h" | |
f3787121 | 81 | #include "mainloop.h" |
63376d7d | 82 | #include "monitor.h" |
f549edcc | 83 | #include "namespace.h" |
811ef482 | 84 | #include "network.h" |
f3787121 | 85 | #include "start.h" |
28d832c4 | 86 | #include "storage.h" |
f2d5a09d | 87 | #include "storage_utils.h" |
f3787121 CB |
88 | #include "sync.h" |
89 | #include "utils.h" | |
fe4de9a6 | 90 | #include "lsm/lsm.h" |
36eb9bde CLG |
91 | |
92 | lxc_log_define(lxc_start, lxc); | |
93 | ||
f01f7975 | 94 | extern void mod_all_rdeps(struct lxc_container *c, bool inc); |
790255cf | 95 | static bool do_destroy_container(struct lxc_handler *handler); |
28272964 CB |
96 | static int lxc_rmdir_onedev_wrapper(void *data); |
97 | static void lxc_destroy_container_on_signal(struct lxc_handler *handler, | |
98 | const char *name); | |
99 | ||
c8154066 SH |
100 | static void print_top_failing_dir(const char *path) |
101 | { | |
102 | size_t len = strlen(path); | |
f3787121 | 103 | char *copy = alloca(len + 1), *p, *e, saved; |
c8154066 SH |
104 | strcpy(copy, path); |
105 | ||
106 | p = copy; | |
107 | e = copy + len; | |
108 | while (p < e) { | |
f3787121 CB |
109 | while (p < e && *p == '/') |
110 | p++; | |
111 | while (p < e && *p != '/') | |
112 | p++; | |
c8154066 SH |
113 | saved = *p; |
114 | *p = '\0'; | |
115 | if (access(copy, X_OK)) { | |
408da065 CB |
116 | SYSERROR("Could not access %s. Please grant it x " |
117 | "access, or add an ACL for the container " | |
118 | "root.", copy); | |
c8154066 SH |
119 | return; |
120 | } | |
121 | *p = saved; | |
122 | } | |
123 | } | |
124 | ||
408da065 CB |
125 | static void close_ns(int ns_fd[LXC_NS_MAX]) |
126 | { | |
9f30a190 MM |
127 | int i; |
128 | ||
9f30a190 MM |
129 | for (i = 0; i < LXC_NS_MAX; i++) { |
130 | if (ns_fd[i] > -1) { | |
131 | close(ns_fd[i]); | |
132 | ns_fd[i] = -1; | |
133 | } | |
134 | } | |
9f30a190 MM |
135 | } |
136 | ||
4d8ac866 | 137 | /* preserve_ns: open /proc/@pid/ns/@ns for each namespace specified |
62d05d9b | 138 | * in clone_flags. |
4d8ac866 | 139 | * Return true on success, false on failure. |
62d05d9b | 140 | */ |
4d8ac866 | 141 | static bool preserve_ns(int ns_fd[LXC_NS_MAX], int clone_flags, pid_t pid) |
f3787121 | 142 | { |
62d05d9b | 143 | int i, ret; |
9f30a190 | 144 | |
9f30a190 MM |
145 | for (i = 0; i < LXC_NS_MAX; i++) |
146 | ns_fd[i] = -1; | |
147 | ||
4d8ac866 CB |
148 | ret = lxc_preserve_ns(pid, ""); |
149 | if (ret < 0) { | |
150 | SYSERROR("Kernel does not support attaching to namespaces."); | |
62d05d9b | 151 | return false; |
4d8ac866 CB |
152 | } else { |
153 | close(ret); | |
cd43d2d1 SH |
154 | } |
155 | ||
9f30a190 MM |
156 | for (i = 0; i < LXC_NS_MAX; i++) { |
157 | if ((clone_flags & ns_info[i].clone_flag) == 0) | |
158 | continue; | |
28d9e29e | 159 | |
4d8ac866 | 160 | ns_fd[i] = lxc_preserve_ns(pid, ns_info[i].proc_name); |
9f30a190 MM |
161 | if (ns_fd[i] < 0) |
162 | goto error; | |
fa3a5b22 CB |
163 | |
164 | DEBUG("Preserved %s namespace via fd %d", ns_info[i].proc_name, ns_fd[i]); | |
9f30a190 MM |
165 | } |
166 | ||
62d05d9b | 167 | return true; |
9f30a190 MM |
168 | |
169 | error: | |
4d8ac866 CB |
170 | if (errno == ENOENT) |
171 | SYSERROR("Kernel does not support attaching to %s namespaces.", ns_info[i].proc_name); | |
172 | else | |
173 | SYSERROR("Failed to open file descriptor for %s namespace: %s.", ns_info[i].proc_name, strerror(errno)); | |
9f30a190 | 174 | close_ns(ns_fd); |
62d05d9b | 175 | return false; |
9f30a190 MM |
176 | } |
177 | ||
80090207 CLG |
178 | static int match_fd(int fd) |
179 | { | |
180 | return (fd == 0 || fd == 1 || fd == 2); | |
181 | } | |
182 | ||
47a46cf1 CB |
183 | int lxc_check_inherited(struct lxc_conf *conf, bool closeall, |
184 | int *fds_to_ignore, size_t len_fds) | |
80090207 | 185 | { |
74f96976 | 186 | struct dirent *direntp; |
80090207 | 187 | int fd, fddir; |
47a46cf1 | 188 | size_t i; |
80090207 | 189 | DIR *dir; |
80090207 | 190 | |
d2cf4c37 SH |
191 | if (conf && conf->close_all_fds) |
192 | closeall = true; | |
193 | ||
b119f362 | 194 | restart: |
80090207 CLG |
195 | dir = opendir("/proc/self/fd"); |
196 | if (!dir) { | |
13277ec4 | 197 | WARN("Failed to open directory: %s.", strerror(errno)); |
80090207 CLG |
198 | return -1; |
199 | } | |
200 | ||
201 | fddir = dirfd(dir); | |
202 | ||
74f96976 | 203 | while ((direntp = readdir(dir))) { |
d39b10eb CB |
204 | struct lxc_list *cur; |
205 | bool matched = false; | |
206 | ||
80090207 CLG |
207 | if (!strcmp(direntp->d_name, ".")) |
208 | continue; | |
209 | ||
210 | if (!strcmp(direntp->d_name, "..")) | |
211 | continue; | |
212 | ||
d4cff0d2 CB |
213 | if (lxc_safe_int(direntp->d_name, &fd) < 0) { |
214 | INFO("Could not parse file descriptor for: %s", direntp->d_name); | |
215 | continue; | |
216 | } | |
80090207 | 217 | |
47a46cf1 CB |
218 | for (i = 0; i < len_fds; i++) |
219 | if (fds_to_ignore[i] == fd) | |
220 | break; | |
221 | ||
222 | if (fd == fddir || fd == lxc_log_fd || | |
223 | (i < len_fds && fd == fds_to_ignore[i])) | |
80090207 CLG |
224 | continue; |
225 | ||
d39b10eb | 226 | /* Keep state clients that wait on reboots. */ |
3ee9e4fb CB |
227 | if (conf) { |
228 | lxc_list_for_each(cur, &conf->state_clients) { | |
229 | struct lxc_state_client *client = cur->elem; | |
d39b10eb | 230 | |
3ee9e4fb CB |
231 | if (client->clientfd != fd) |
232 | continue; | |
d39b10eb | 233 | |
3ee9e4fb CB |
234 | matched = true; |
235 | break; | |
236 | } | |
d39b10eb CB |
237 | } |
238 | ||
239 | if (matched) | |
240 | continue; | |
241 | ||
858377e4 SH |
242 | if (current_config && fd == current_config->logfd) |
243 | continue; | |
244 | ||
80090207 CLG |
245 | if (match_fd(fd)) |
246 | continue; | |
80090207 | 247 | |
d2cf4c37 | 248 | if (closeall) { |
b119f362 SH |
249 | close(fd); |
250 | closedir(dir); | |
28d9e29e | 251 | INFO("Closed inherited fd %d", fd); |
b119f362 SH |
252 | goto restart; |
253 | } | |
28d9e29e | 254 | WARN("Inherited fd %d", fd); |
80090207 CLG |
255 | } |
256 | ||
408da065 | 257 | /* Only enable syslog at this point to avoid the above logging function |
64c57ea1 BD |
258 | * to open a new fd and make the check_inherited function enter an |
259 | * infinite loop. | |
260 | */ | |
261 | lxc_log_enable_syslog(); | |
262 | ||
92c7f629 GK |
263 | closedir(dir); /* cannot fail */ |
264 | return 0; | |
80090207 CLG |
265 | } |
266 | ||
83ee7875 | 267 | static int setup_signal_fd(sigset_t *oldmask) |
b0a33c1e | 268 | { |
269 | sigset_t mask; | |
270 | int fd; | |
271 | ||
408da065 | 272 | /* Block everything except serious error signals. */ |
f3304a29 FW |
273 | if (sigfillset(&mask) || |
274 | sigdelset(&mask, SIGILL) || | |
275 | sigdelset(&mask, SIGSEGV) || | |
276 | sigdelset(&mask, SIGBUS) || | |
b5159817 | 277 | sigdelset(&mask, SIGWINCH) || |
f3304a29 | 278 | sigprocmask(SIG_BLOCK, &mask, oldmask)) { |
408da065 | 279 | SYSERROR("Failed to set signal mask."); |
b0a33c1e | 280 | return -1; |
281 | } | |
282 | ||
283 | fd = signalfd(-1, &mask, 0); | |
284 | if (fd < 0) { | |
408da065 | 285 | SYSERROR("Failed to create signal file descriptor."); |
b0a33c1e | 286 | return -1; |
287 | } | |
288 | ||
289 | if (fcntl(fd, F_SETFD, FD_CLOEXEC)) { | |
408da065 | 290 | SYSERROR("Failed to set FD_CLOEXEC on the signal file descriptor: %d.", fd); |
b0a33c1e | 291 | close(fd); |
292 | return -1; | |
293 | } | |
294 | ||
408da065 | 295 | DEBUG("Set SIGCHLD handler with file descriptor: %d.", fd); |
1ac470c0 | 296 | |
b0a33c1e | 297 | return fd; |
298 | } | |
299 | ||
84c92abd | 300 | static int signal_handler(int fd, uint32_t events, void *data, |
f3787121 | 301 | struct lxc_epoll_descr *descr) |
b0a33c1e | 302 | { |
15cd25fd | 303 | int ret; |
3c319edb CB |
304 | siginfo_t info; |
305 | struct signalfd_siginfo siginfo; | |
306 | struct lxc_handler *hdlr = data; | |
15cd25fd DL |
307 | |
308 | ret = read(fd, &siginfo, sizeof(siginfo)); | |
309 | if (ret < 0) { | |
408da065 | 310 | ERROR("Failed to read signal info from signal file descriptor: %d.", fd); |
15cd25fd DL |
311 | return -1; |
312 | } | |
313 | ||
314 | if (ret != sizeof(siginfo)) { | |
408da065 | 315 | ERROR("Unexpected size for siginfo struct."); |
15cd25fd DL |
316 | return -1; |
317 | } | |
318 | ||
408da065 | 319 | /* Check whether init is running. */ |
80507ee8 | 320 | info.si_pid = 0; |
3c319edb CB |
321 | ret = waitid(P_PID, hdlr->pid, &info, WEXITED | WNOWAIT | WNOHANG); |
322 | if (ret == 0 && info.si_pid == hdlr->pid) | |
323 | hdlr->init_died = true; | |
80507ee8 | 324 | |
f3304a29 | 325 | if (siginfo.ssi_signo != SIGCHLD) { |
3c319edb CB |
326 | kill(hdlr->pid, siginfo.ssi_signo); |
327 | INFO("Forwarded signal %d to pid %d.", siginfo.ssi_signo, hdlr->pid); | |
328 | return hdlr->init_died ? LXC_MAINLOOP_CLOSE : 0; | |
f3304a29 FW |
329 | } |
330 | ||
408da065 CB |
331 | if (siginfo.ssi_code == CLD_STOPPED) { |
332 | INFO("Container init process was stopped."); | |
3c319edb | 333 | return hdlr->init_died ? LXC_MAINLOOP_CLOSE : 0; |
408da065 CB |
334 | } else if (siginfo.ssi_code == CLD_CONTINUED) { |
335 | INFO("Container init process was continued."); | |
3c319edb | 336 | return hdlr->init_died ? LXC_MAINLOOP_CLOSE : 0; |
15cd25fd | 337 | } |
1ac470c0 | 338 | |
408da065 CB |
339 | /* More robustness, protect ourself from a SIGCHLD sent |
340 | * by a process different from the container init. | |
82d89dce | 341 | */ |
3c319edb CB |
342 | if (siginfo.ssi_pid != hdlr->pid) { |
343 | NOTICE("Received SIGCHLD from pid %d instead of container init %d.", siginfo.ssi_pid, hdlr->pid); | |
344 | return hdlr->init_died ? LXC_MAINLOOP_CLOSE : 0; | |
82d89dce DL |
345 | } |
346 | ||
3c319edb CB |
347 | DEBUG("Container init process %d exited.", hdlr->pid); |
348 | return LXC_MAINLOOP_CLOSE; | |
b0a33c1e | 349 | } |
350 | ||
5e5576a4 CB |
351 | static int lxc_serve_state_clients(const char *name, |
352 | struct lxc_handler *handler, | |
353 | lxc_state_t state) | |
66aeffc7 | 354 | { |
dbc9832d CB |
355 | ssize_t ret; |
356 | struct lxc_list *cur, *next; | |
d39b10eb | 357 | struct lxc_state_client *client; |
dbc9832d CB |
358 | struct lxc_msg msg = {.type = lxc_msg_state, .value = state}; |
359 | ||
bc631984 | 360 | process_lock(); |
66aeffc7 | 361 | handler->state = state; |
9dfa4041 | 362 | TRACE("Set container state to %s", lxc_state2str(state)); |
dbc9832d | 363 | |
d39b10eb | 364 | if (lxc_list_empty(&handler->conf->state_clients)) { |
9dfa4041 | 365 | TRACE("No state clients registered"); |
dbc9832d | 366 | process_unlock(); |
65ee1673 | 367 | lxc_monitor_send_state(name, state, handler->lxcpath); |
dbc9832d CB |
368 | return 0; |
369 | } | |
370 | ||
371 | strncpy(msg.name, name, sizeof(msg.name)); | |
372 | msg.name[sizeof(msg.name) - 1] = 0; | |
373 | ||
d39b10eb | 374 | lxc_list_for_each_safe(cur, &handler->conf->state_clients, next) { |
dbc9832d CB |
375 | client = cur->elem; |
376 | ||
d39b10eb | 377 | if (client->states[state] == 0) { |
9dfa4041 | 378 | TRACE("State %s not registered for state client %d", |
dbc9832d CB |
379 | lxc_state2str(state), client->clientfd); |
380 | continue; | |
381 | } | |
382 | ||
9dfa4041 | 383 | TRACE("Sending state %s to state client %d", |
dbc9832d CB |
384 | lxc_state2str(state), client->clientfd); |
385 | ||
386 | again: | |
387 | ret = send(client->clientfd, &msg, sizeof(msg), 0); | |
ee8377bd CB |
388 | if (ret <= 0) { |
389 | if (errno == EINTR) { | |
390 | TRACE("Caught EINTR; retrying"); | |
dbc9832d | 391 | goto again; |
ee8377bd | 392 | } |
dbc9832d | 393 | |
9dfa4041 CB |
394 | ERROR("%s - Failed to send message to client", |
395 | strerror(errno)); | |
dbc9832d CB |
396 | } |
397 | ||
398 | /* kick client from list */ | |
399 | close(client->clientfd); | |
400 | lxc_list_del(cur); | |
401 | free(cur->elem); | |
402 | free(cur); | |
403 | } | |
404 | process_unlock(); | |
405 | ||
5e5576a4 CB |
406 | return 0; |
407 | } | |
408 | ||
409 | static int lxc_serve_state_socket_pair(const char *name, | |
410 | struct lxc_handler *handler, | |
411 | lxc_state_t state) | |
412 | { | |
413 | ssize_t ret; | |
414 | ||
415 | if (!handler->backgrounded || | |
416 | handler->state_socket_pair[1] < 0 || | |
417 | state == STARTING) | |
418 | return 0; | |
419 | ||
420 | /* Close read end of the socket pair. */ | |
421 | close(handler->state_socket_pair[0]); | |
422 | handler->state_socket_pair[0] = -1; | |
423 | ||
ee8377bd | 424 | again: |
5e5576a4 CB |
425 | ret = lxc_abstract_unix_send_credential(handler->state_socket_pair[1], |
426 | &(int){state}, sizeof(int)); | |
ee8377bd CB |
427 | if (ret != sizeof(int)) { |
428 | if (errno == EINTR) | |
429 | goto again; | |
5e5576a4 CB |
430 | SYSERROR("Failed to send state to %d", |
431 | handler->state_socket_pair[1]); | |
ee8377bd CB |
432 | return -1; |
433 | } | |
5e5576a4 CB |
434 | |
435 | TRACE("Sent container state \"%s\" to %d", lxc_state2str(state), | |
436 | handler->state_socket_pair[1]); | |
437 | ||
438 | /* Close write end of the socket pair. */ | |
439 | close(handler->state_socket_pair[1]); | |
440 | handler->state_socket_pair[1] = -1; | |
441 | ||
442 | return 0; | |
443 | } | |
444 | ||
445 | int lxc_set_state(const char *name, struct lxc_handler *handler, | |
446 | lxc_state_t state) | |
447 | { | |
448 | int ret; | |
449 | ||
450 | ret = lxc_serve_state_socket_pair(name, handler, state); | |
451 | if (ret < 0) { | |
452 | ERROR("Failed to synchronize via anonymous pair of unix sockets"); | |
453 | return -1; | |
454 | } | |
455 | ||
456 | ret = lxc_serve_state_clients(name, handler, state); | |
457 | if (ret < 0) | |
458 | return -1; | |
459 | ||
dbc9832d CB |
460 | /* This function will try to connect to the legacy lxc-monitord state |
461 | * server and only exists for backwards compatibility. | |
462 | */ | |
9123e471 | 463 | lxc_monitor_send_state(name, state, handler->lxcpath); |
dbc9832d | 464 | |
66aeffc7 DL |
465 | return 0; |
466 | } | |
467 | ||
735f2c6e | 468 | int lxc_poll(const char *name, struct lxc_handler *handler) |
b0a33c1e | 469 | { |
3c319edb | 470 | int ret; |
30a33fbd | 471 | bool has_console = (handler->conf->rootfs.path != NULL); |
3c319edb | 472 | struct lxc_epoll_descr descr, descr_console; |
b0a33c1e | 473 | |
3c319edb CB |
474 | ret = lxc_mainloop_open(&descr); |
475 | if (ret < 0) { | |
476 | ERROR("Failed to create mainloop"); | |
50c8bf05 | 477 | goto out_sigfd; |
b0a33c1e | 478 | } |
479 | ||
30a33fbd CB |
480 | if (has_console) { |
481 | ret = lxc_mainloop_open(&descr_console); | |
482 | if (ret < 0) { | |
483 | ERROR("Failed to create console mainloop"); | |
484 | goto out_mainloop; | |
485 | } | |
3c319edb CB |
486 | } |
487 | ||
1cc8bd4b | 488 | ret = lxc_mainloop_add_handler(&descr, handler->sigfd, signal_handler, handler); |
3c319edb | 489 | if (ret < 0) { |
1cc8bd4b | 490 | ERROR("Failed to add signal handler for %d to mainloop", handler->sigfd); |
3c319edb | 491 | goto out_mainloop_console; |
b0a33c1e | 492 | } |
493 | ||
30a33fbd CB |
494 | if (has_console) { |
495 | struct lxc_console *console = &handler->conf->console; | |
63376d7d | 496 | |
30a33fbd CB |
497 | ret = lxc_console_mainloop_add(&descr, console); |
498 | if (ret < 0) { | |
499 | ERROR("Failed to add console handlers to mainloop"); | |
500 | goto out_mainloop_console; | |
501 | } | |
502 | ||
503 | ret = lxc_console_mainloop_add(&descr_console, console); | |
504 | if (ret < 0) { | |
505 | ERROR("Failed to add console handlers to console mainloop"); | |
506 | goto out_mainloop_console; | |
507 | } | |
563f2f2c DL |
508 | } |
509 | ||
3c319edb CB |
510 | ret = lxc_cmd_mainloop_add(name, &descr, handler); |
511 | if (ret < 0) { | |
512 | ERROR("Failed to add command handler to mainloop"); | |
513 | goto out_mainloop_console; | |
514 | } | |
b0a33c1e | 515 | |
3c319edb | 516 | TRACE("Mainloop is ready"); |
b0a33c1e | 517 | |
3c319edb | 518 | ret = lxc_mainloop(&descr, -1); |
1cc8bd4b CB |
519 | close(descr.epfd); |
520 | descr.epfd = -EBADF; | |
521 | if (ret < 0 || !handler->init_died) | |
522 | goto out_mainloop; | |
523 | ||
30a33fbd CB |
524 | if (has_console) |
525 | ret = lxc_mainloop(&descr_console, 0); | |
526 | ||
3c319edb CB |
527 | |
528 | out_mainloop: | |
b0a33c1e | 529 | lxc_mainloop_close(&descr); |
1cc8bd4b | 530 | TRACE("Closed mainloop"); |
408da065 | 531 | |
3c319edb | 532 | out_mainloop_console: |
30a33fbd CB |
533 | if (has_console) { |
534 | lxc_mainloop_close(&descr_console); | |
535 | TRACE("Closed console mainloop"); | |
536 | } | |
3c319edb | 537 | |
b0a33c1e | 538 | out_sigfd: |
1cc8bd4b CB |
539 | close(handler->sigfd); |
540 | TRACE("Closed signal file descriptor %d", handler->sigfd); | |
541 | handler->sigfd = -EBADF; | |
408da065 | 542 | |
1cc8bd4b | 543 | return ret; |
b0a33c1e | 544 | } |
545 | ||
41784e4e CB |
546 | void lxc_zero_handler(struct lxc_handler *handler) |
547 | { | |
548 | int i; | |
549 | ||
550 | memset(handler, 0, sizeof(struct lxc_handler)); | |
551 | ||
552 | handler->clone_flags = -1; | |
553 | ||
554 | handler->pinfd = -1; | |
555 | ||
556 | handler->sigfd = -1; | |
557 | ||
558 | for (i = 0; i < LXC_NS_MAX; i++) | |
559 | handler->nsfd[i] = -1; | |
560 | ||
561 | handler->data_sock[0] = -1; | |
562 | handler->data_sock[1] = -1; | |
563 | ||
564 | handler->state_socket_pair[0] = -1; | |
565 | handler->state_socket_pair[1] = -1; | |
566 | ||
567 | handler->sync_sock[0] = -1; | |
568 | handler->sync_sock[1] = -1; | |
569 | } | |
570 | ||
1cc8bd4b CB |
571 | static void lxc_put_nsfds(struct lxc_handler *handler) |
572 | { | |
573 | int i; | |
574 | ||
575 | for (i = 0; i < LXC_NS_MAX; i++) { | |
576 | if (handler->nsfd[i] < 0) | |
577 | continue; | |
578 | ||
579 | close(handler->nsfd[i]); | |
580 | handler->nsfd[i] = -EBADF; | |
581 | } | |
582 | } | |
583 | ||
f2e07cb6 CB |
584 | void lxc_free_handler(struct lxc_handler *handler) |
585 | { | |
1cc8bd4b CB |
586 | if (handler->pinfd >= 0) |
587 | close(handler->pinfd); | |
588 | ||
589 | if (handler->sigfd >= 0) | |
590 | close(handler->sigfd); | |
591 | ||
592 | lxc_put_nsfds(handler); | |
593 | ||
594 | if (handler->conf && handler->conf->reboot == 0) | |
595 | if (handler->conf->maincmd_fd) | |
596 | close(handler->conf->maincmd_fd); | |
f2e07cb6 | 597 | |
5e5576a4 CB |
598 | if (handler->state_socket_pair[0] >= 0) |
599 | close(handler->state_socket_pair[0]); | |
600 | ||
601 | if (handler->state_socket_pair[1] >= 0) | |
602 | close(handler->state_socket_pair[1]); | |
603 | ||
f2e07cb6 CB |
604 | handler->conf = NULL; |
605 | free(handler); | |
1cc8bd4b | 606 | handler = NULL; |
f2e07cb6 CB |
607 | } |
608 | ||
aa460476 | 609 | struct lxc_handler *lxc_init_handler(const char *name, struct lxc_conf *conf, |
5e5576a4 | 610 | const char *lxcpath, bool daemonize) |
59eb99ba | 611 | { |
5e5576a4 | 612 | int i, ret; |
3a0f472d DL |
613 | struct lxc_handler *handler; |
614 | ||
615 | handler = malloc(sizeof(*handler)); | |
aa460476 CB |
616 | if (!handler) { |
617 | ERROR("failed to allocate memory"); | |
3a0f472d | 618 | return NULL; |
aa460476 | 619 | } |
59eb99ba DL |
620 | |
621 | memset(handler, 0, sizeof(*handler)); | |
622 | ||
790255cf CB |
623 | /* Note that am_unpriv() checks the effective uid. We probably don't |
624 | * care if we are real root only if we are running as root so this | |
625 | * should be fine. | |
626 | */ | |
d0fbc7ba | 627 | handler->am_root = !am_unpriv(); |
c6012571 | 628 | handler->data_sock[0] = handler->data_sock[1] = -1; |
fae349da | 629 | handler->conf = conf; |
9123e471 | 630 | handler->lxcpath = lxcpath; |
5c068da9 | 631 | handler->pinfd = -1; |
1cc8bd4b CB |
632 | handler->sigfd = -EBADF; |
633 | handler->init_died = false; | |
5e5576a4 | 634 | handler->state_socket_pair[0] = handler->state_socket_pair[1] = -1; |
d39b10eb CB |
635 | if (handler->conf->reboot == 0) |
636 | lxc_list_init(&handler->conf->state_clients); | |
fae349da | 637 | |
b6b2b194 WB |
638 | for (i = 0; i < LXC_NS_MAX; i++) |
639 | handler->nsfd[i] = -1; | |
640 | ||
f0ecc19d | 641 | handler->name = name; |
3bdf52d7 | 642 | |
5e5576a4 CB |
643 | if (daemonize && !handler->conf->reboot) { |
644 | /* Create socketpair() to synchronize on daemonized startup. | |
645 | * When the container reboots we don't need to synchronize again | |
646 | * currently so don't open another socketpair(). | |
647 | */ | |
648 | ret = socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, | |
649 | handler->state_socket_pair); | |
650 | if (ret < 0) { | |
651 | ERROR("Failed to create anonymous pair of unix sockets"); | |
652 | goto on_error; | |
653 | } | |
654 | TRACE("Created anonymous pair {%d,%d} of unix sockets", | |
655 | handler->state_socket_pair[0], | |
656 | handler->state_socket_pair[1]); | |
657 | } | |
658 | ||
d39b10eb CB |
659 | if (handler->conf->reboot == 0) { |
660 | handler->conf->maincmd_fd = lxc_cmd_init(name, lxcpath, "command"); | |
661 | if (handler->conf->maincmd_fd < 0) { | |
662 | ERROR("Failed to set up command socket"); | |
663 | goto on_error; | |
664 | } | |
aa460476 | 665 | } |
9dfa4041 | 666 | TRACE("Unix domain socket %d for command server is ready", |
aa460476 CB |
667 | handler->conf->maincmd_fd); |
668 | ||
669 | return handler; | |
670 | ||
f2e07cb6 CB |
671 | on_error: |
672 | lxc_free_handler(handler); | |
aa460476 CB |
673 | |
674 | return NULL; | |
675 | } | |
676 | ||
677 | int lxc_init(const char *name, struct lxc_handler *handler) | |
678 | { | |
a2c09be0 | 679 | int ret; |
4a03ded4 | 680 | const char *loglevel; |
aa460476 CB |
681 | struct lxc_conf *conf = handler->conf; |
682 | ||
683 | lsm_init(); | |
684 | TRACE("initialized LSM"); | |
d2e30e99 | 685 | |
8f2c3a70 | 686 | if (lxc_read_seccomp_config(conf) != 0) { |
408da065 | 687 | ERROR("Failed loading seccomp policy."); |
d2e30e99 | 688 | goto out_close_maincmd_fd; |
8f2c3a70 | 689 | } |
dbc9832d | 690 | TRACE("read seccomp policy"); |
8f2c3a70 | 691 | |
408da065 | 692 | /* Begin by setting the state to STARTING. */ |
25c2aca5 | 693 | if (lxc_set_state(name, handler, STARTING)) { |
408da065 | 694 | ERROR("Failed to set state for container \"%s\" to \"%s\".", name, lxc_state2str(STARTING)); |
051151de | 695 | goto out_close_maincmd_fd; |
0ad19a3f | 696 | } |
dbc9832d | 697 | TRACE("set container state to \"STARTING\""); |
0ad19a3f | 698 | |
408da065 CB |
699 | /* Start of environment variable setup for hooks. */ |
700 | if (name && setenv("LXC_NAME", name, 1)) | |
701 | SYSERROR("Failed to set environment variable: LXC_NAME=%s.", name); | |
702 | ||
703 | if (conf->rcfile && setenv("LXC_CONFIG_FILE", conf->rcfile, 1)) | |
704 | SYSERROR("Failed to set environment variable: LXC_CONFIG_FILE=%s.", conf->rcfile); | |
705 | ||
706 | if (conf->rootfs.mount && setenv("LXC_ROOTFS_MOUNT", conf->rootfs.mount, 1)) | |
707 | SYSERROR("Failed to set environment variable: LXC_ROOTFS_MOUNT=%s.", conf->rootfs.mount); | |
708 | ||
709 | if (conf->rootfs.path && setenv("LXC_ROOTFS_PATH", conf->rootfs.path, 1)) | |
710 | SYSERROR("Failed to set environment variable: LXC_ROOTFS_PATH=%s.", conf->rootfs.path); | |
711 | ||
712 | if (conf->console.path && setenv("LXC_CONSOLE", conf->console.path, 1)) | |
713 | SYSERROR("Failed to set environment variable: LXC_CONSOLE=%s.", conf->console.path); | |
714 | ||
715 | if (conf->console.log_path && setenv("LXC_CONSOLE_LOGPATH", conf->console.log_path, 1)) | |
716 | SYSERROR("Failed to set environment variable: LXC_CONSOLE_LOGPATH=%s.", conf->console.log_path); | |
717 | ||
718 | if (setenv("LXC_CGNS_AWARE", "1", 1)) | |
719 | SYSERROR("Failed to set environment variable LXC_CGNS_AWARE=1."); | |
b8f88d9b | 720 | |
4a03ded4 CB |
721 | loglevel = lxc_log_priority_to_string(lxc_log_get_level()); |
722 | if (setenv("LXC_LOG_LEVEL", loglevel, 1)) | |
723 | SYSERROR("Failed to set environment variable LXC_LOG_LEVEL=%s", loglevel); | |
a2c09be0 CB |
724 | |
725 | if (conf->hooks_version == 0) | |
726 | ret = setenv("LXC_HOOK_VERSION", "0", 1); | |
727 | else | |
728 | ret = setenv("LXC_HOOK_VERSION", "1", 1); | |
729 | if (ret < 0) | |
730 | SYSERROR("Failed to set environment variable LXC_HOOK_VERSION=%u", conf->hooks_version); | |
408da065 | 731 | /* End of environment variable setup for hooks. */ |
f7bee6c6 | 732 | |
dbc9832d CB |
733 | TRACE("set environment variables"); |
734 | ||
14a7b0f9 | 735 | if (run_lxc_hooks(name, "pre-start", conf, NULL)) { |
408da065 | 736 | ERROR("Failed to run lxc.hook.pre-start for container \"%s\".", name); |
773fb9ca SH |
737 | goto out_aborting; |
738 | } | |
dbc9832d | 739 | TRACE("ran pre-start hooks"); |
26ddeedd | 740 | |
408da065 CB |
741 | /* The signal fd has to be created before forking otherwise if the child |
742 | * process exits before we setup the signal fd, the event will be lost | |
743 | * and the command will be stuck. | |
744 | */ | |
83ee7875 | 745 | handler->sigfd = setup_signal_fd(&handler->oldmask); |
59eb99ba | 746 | if (handler->sigfd < 0) { |
408da065 | 747 | ERROR("Failed to setup SIGCHLD fd handler."); |
b5159817 DE |
748 | goto out_delete_tty; |
749 | } | |
dbc9832d | 750 | TRACE("set up signal fd"); |
b5159817 | 751 | |
408da065 | 752 | /* Do this after setting up signals since it might unblock SIGWINCH. */ |
4d1ffb0a CB |
753 | ret = lxc_console_create(conf); |
754 | if (ret < 0) { | |
755 | ERROR("Failed to create console"); | |
b5159817 | 756 | goto out_restore_sigmask; |
b0a33c1e | 757 | } |
4d1ffb0a | 758 | TRACE("Created console"); |
b0a33c1e | 759 | |
7cfeddd7 CB |
760 | ret = lxc_pty_map_ids(conf, &conf->console); |
761 | if (ret < 0) { | |
408da065 | 762 | ERROR("Failed to shift tty into container."); |
c4d10a05 SH |
763 | goto out_restore_sigmask; |
764 | } | |
dbc9832d | 765 | TRACE("shifted tty ids"); |
c4d10a05 | 766 | |
dbc9832d | 767 | INFO("container \"%s\" is initialized", name); |
aa460476 | 768 | return 0; |
59eb99ba | 769 | |
b5159817 DE |
770 | out_restore_sigmask: |
771 | sigprocmask(SIG_SETMASK, &handler->oldmask, NULL); | |
59eb99ba | 772 | out_delete_tty: |
fae349da | 773 | lxc_delete_tty(&conf->tty_info); |
59eb99ba | 774 | out_aborting: |
25c2aca5 | 775 | lxc_set_state(name, handler, ABORTING); |
d2e30e99 DE |
776 | out_close_maincmd_fd: |
777 | close(conf->maincmd_fd); | |
778 | conf->maincmd_fd = -1; | |
aa460476 | 779 | return -1; |
59eb99ba DL |
780 | } |
781 | ||
3b72c4a0 | 782 | void lxc_fini(const char *name, struct lxc_handler *handler) |
59eb99ba | 783 | { |
b3286b62 | 784 | int i, rc; |
18b3b9c1 | 785 | pid_t self; |
dbc9832d | 786 | struct lxc_list *cur, *next; |
dbc9832d | 787 | char *namespaces[LXC_NS_MAX + 1]; |
b3286b62 | 788 | size_t namespace_count = 0; |
b6b2b194 | 789 | |
408da065 CB |
790 | /* The STOPPING state is there for future cleanup code which can take |
791 | * awhile. | |
59eb99ba | 792 | */ |
25c2aca5 | 793 | lxc_set_state(name, handler, STOPPING); |
b6b2b194 | 794 | |
0059379f | 795 | self = lxc_raw_getpid(); |
b3286b62 | 796 | for (i = 0; i < LXC_NS_MAX; i++) { |
18b3b9c1 CB |
797 | if (handler->nsfd[i] < 0) |
798 | continue; | |
799 | ||
800 | if (handler->conf->hooks_version == 0) | |
801 | rc = asprintf(&namespaces[namespace_count], | |
802 | "%s:/proc/%d/fd/%d", ns_info[i].proc_name, | |
803 | self, handler->nsfd[i]); | |
804 | else | |
805 | rc = asprintf(&namespaces[namespace_count], | |
806 | "/proc/%d/fd/%d", self, handler->nsfd[i]); | |
807 | if (rc == -1) { | |
808 | SYSERROR("Failed to allocate memory."); | |
809 | break; | |
b3286b62 | 810 | } |
18b3b9c1 CB |
811 | |
812 | if (handler->conf->hooks_version == 0) { | |
813 | namespace_count++; | |
814 | continue; | |
815 | } | |
816 | ||
817 | rc = setenv(ns_info[i].env_name, namespaces[namespace_count], 1); | |
818 | if (rc < 0) | |
819 | SYSERROR("Failed to set environment variable %s=%s", | |
820 | ns_info[i].env_name, namespaces[namespace_count]); | |
821 | else | |
822 | TRACE("Set environment variable %s=%s", | |
823 | ns_info[i].env_name, namespaces[namespace_count]); | |
824 | ||
825 | namespace_count++; | |
b3286b62 WB |
826 | } |
827 | namespaces[namespace_count] = NULL; | |
c154af98 | 828 | |
408da065 CB |
829 | if (handler->conf->reboot && setenv("LXC_TARGET", "reboot", 1)) |
830 | SYSERROR("Failed to set environment variable: LXC_TARGET=reboot."); | |
831 | ||
832 | if (!handler->conf->reboot && setenv("LXC_TARGET", "stop", 1)) | |
833 | SYSERROR("Failed to set environment variable: LXC_TARGET=stop."); | |
c154af98 | 834 | |
18b3b9c1 | 835 | if (handler->conf->hooks_version == 0) |
14a7b0f9 | 836 | rc = run_lxc_hooks(name, "stop", handler->conf, namespaces); |
18b3b9c1 | 837 | else |
14a7b0f9 | 838 | rc = run_lxc_hooks(name, "stop", handler->conf, NULL); |
c154af98 | 839 | |
b3286b62 WB |
840 | while (namespace_count--) |
841 | free(namespaces[namespace_count]); | |
28d9e29e | 842 | |
4288b79f CB |
843 | cgroup_destroy(handler); |
844 | ||
d39b10eb | 845 | if (handler->conf->reboot == 0) { |
f893d898 CB |
846 | /* For all new state clients simply close the command socket. |
847 | * This will inform all state clients that the container is | |
848 | * STOPPED and also prevents a race between a open()/close() on | |
849 | * the command socket causing a new process to get ECONNREFUSED | |
850 | * because we haven't yet closed the command socket. | |
851 | */ | |
d39b10eb CB |
852 | close(handler->conf->maincmd_fd); |
853 | handler->conf->maincmd_fd = -1; | |
c3184275 CB |
854 | TRACE("Closed command socket"); |
855 | ||
856 | /* This function will try to connect to the legacy lxc-monitord | |
857 | * state server and only exists for backwards compatibility. | |
858 | */ | |
859 | lxc_monitor_send_state(name, STOPPED, handler->lxcpath); | |
860 | ||
861 | /* The command socket is closed so no one can acces the command | |
862 | * socket anymore so there's no need to lock it. | |
863 | */ | |
864 | handler->state = STOPPED; | |
865 | TRACE("Set container state to \"STOPPED\""); | |
f893d898 CB |
866 | } else { |
867 | lxc_set_state(name, handler, STOPPED); | |
d39b10eb | 868 | } |
4288b79f | 869 | |
14a7b0f9 | 870 | if (run_lxc_hooks(name, "post-stop", handler->conf, NULL)) { |
408da065 | 871 | ERROR("Failed to run lxc.hook.post-stop for container \"%s\".", name); |
f3787121 CB |
872 | if (handler->conf->reboot) { |
873 | WARN("Container will be stopped instead of rebooted."); | |
874 | handler->conf->reboot = 0; | |
408da065 CB |
875 | if (setenv("LXC_TARGET", "stop", 1)) |
876 | WARN("Failed to set environment variable: LXC_TARGET=stop."); | |
f3787121 CB |
877 | } |
878 | } | |
26ddeedd | 879 | |
408da065 | 880 | /* Reset mask set by setup_signal_fd. */ |
8f64a3f6 | 881 | if (sigprocmask(SIG_SETMASK, &handler->oldmask, NULL)) |
408da065 | 882 | WARN("Failed to restore signal mask."); |
8f64a3f6 | 883 | |
b5159817 | 884 | lxc_console_delete(&handler->conf->console); |
b2431939 | 885 | lxc_delete_tty(&handler->conf->tty_info); |
dbc9832d | 886 | |
dbc9832d CB |
887 | /* The command socket is now closed, no more state clients can register |
888 | * themselves from now on. So free the list of state clients. | |
889 | */ | |
d39b10eb CB |
890 | lxc_list_for_each_safe(cur, &handler->conf->state_clients, next) { |
891 | struct lxc_state_client *client = cur->elem; | |
892 | ||
893 | /* Keep state clients that want to be notified about reboots. */ | |
894 | if ((handler->conf->reboot > 0) && (client->states[RUNNING] == 2)) | |
895 | continue; | |
896 | ||
dbc9832d CB |
897 | /* close state client socket */ |
898 | close(client->clientfd); | |
899 | lxc_list_del(cur); | |
900 | free(cur->elem); | |
901 | free(cur); | |
902 | } | |
903 | ||
2c5f2ede | 904 | if (handler->conf->ephemeral == 1 && handler->conf->reboot != 1) |
28272964 | 905 | lxc_destroy_container_on_signal(handler, name); |
2c5f2ede | 906 | |
1cc8bd4b | 907 | lxc_free_handler(handler); |
59eb99ba DL |
908 | } |
909 | ||
735f2c6e | 910 | void lxc_abort(const char *name, struct lxc_handler *handler) |
59eb99ba | 911 | { |
73e608b2 SH |
912 | int ret, status; |
913 | ||
25c2aca5 | 914 | lxc_set_state(name, handler, ABORTING); |
7d9fb3e9 DL |
915 | if (handler->pid > 0) |
916 | kill(handler->pid, SIGKILL); | |
408da065 CB |
917 | while ((ret = waitpid(-1, &status, 0)) > 0) { |
918 | ; | |
919 | } | |
59eb99ba DL |
920 | } |
921 | ||
18225d19 CB |
922 | static int lxc_set_death_signal(int signal) |
923 | { | |
924 | int ret; | |
925 | pid_t ppid; | |
926 | ||
927 | ret = prctl(PR_SET_PDEATHSIG, signal, 0, 0, 0); | |
928 | ||
929 | /* Check whether we have been orphaned. */ | |
930 | ppid = (pid_t)syscall(SYS_getppid); | |
931 | if (ppid == 1) { | |
932 | pid_t self; | |
933 | ||
934 | self = lxc_raw_getpid(); | |
935 | ret = kill(self, SIGKILL); | |
936 | if (ret < 0) | |
937 | return -1; | |
938 | } | |
939 | ||
940 | if (ret < 0) { | |
941 | SYSERROR("Failed to set PR_SET_PDEATHSIG to %d", signal); | |
942 | return -1; | |
943 | } | |
944 | ||
945 | return 0; | |
946 | } | |
947 | ||
ffe1e01a | 948 | static int do_start(void *data) |
50e98013 | 949 | { |
8bf3abfb | 950 | int ret; |
7c661726 | 951 | struct lxc_list *iterator; |
7a55c157 | 952 | char path[PATH_MAX]; |
fa3a5b22 | 953 | struct lxc_handler *handler = data; |
928b1f04 YT |
954 | bool have_cap_setgid; |
955 | uid_t new_uid; | |
956 | gid_t new_gid; | |
5af9369b | 957 | int devnull_fd = -1; |
50e98013 | 958 | |
18225d19 | 959 | lxc_sync_fini_parent(handler); |
50e98013 | 960 | |
408da065 CB |
961 | /* This prctl must be before the synchro, so if the parent dies before |
962 | * we set the parent death signal, we will detect its death with the | |
963 | * synchro right after, otherwise we have a window where the parent can | |
964 | * exit before we set the pdeath signal leading to a unsupervized | |
965 | * container. | |
743ecd2e | 966 | */ |
18225d19 | 967 | ret = lxc_set_death_signal(SIGKILL); |
912314fc CB |
968 | if (ret < 0) { |
969 | SYSERROR("Failed to set PR_SET_PDEATHSIG to SIGKILL"); | |
18225d19 | 970 | goto out_warn_father; |
743ecd2e DL |
971 | } |
972 | ||
18225d19 CB |
973 | ret = sigprocmask(SIG_SETMASK, &handler->oldmask, NULL); |
974 | if (ret < 0) { | |
975 | SYSERROR("Failed to set signal mask"); | |
976 | goto out_warn_father; | |
977 | } | |
50e98013 | 978 | |
408da065 | 979 | /* Don't leak the pinfd to the container. */ |
d39b10eb | 980 | if (handler->pinfd >= 0) |
0d03360a | 981 | close(handler->pinfd); |
2b0e17e4 | 982 | |
18225d19 CB |
983 | ret = lxc_sync_wait_parent(handler, LXC_SYNC_STARTUP); |
984 | if (ret < 0) | |
985 | goto out_warn_father; | |
5b1e83cb | 986 | |
408da065 CB |
987 | /* Unshare CLONE_NEWNET after CLONE_NEWUSER. See |
988 | * https://github.com/lxc/lxd/issues/1978. | |
989 | */ | |
5b1e83cb | 990 | if ((handler->clone_flags & (CLONE_NEWNET | CLONE_NEWUSER)) == |
408da065 | 991 | (CLONE_NEWNET | CLONE_NEWUSER)) { |
5b1e83cb SH |
992 | ret = unshare(CLONE_NEWNET); |
993 | if (ret < 0) { | |
408da065 | 994 | SYSERROR("Failed to unshare CLONE_NEWNET."); |
5b1e83cb SH |
995 | goto out_warn_father; |
996 | } | |
408da065 | 997 | INFO("Unshared CLONE_NEWNET."); |
5b1e83cb SH |
998 | } |
999 | ||
408da065 CB |
1000 | /* Tell the parent task it can begin to configure the container and wait |
1001 | * for it to finish. | |
3c22086f CLG |
1002 | */ |
1003 | if (lxc_sync_barrier_parent(handler, LXC_SYNC_CONFIGURE)) | |
9d7f9e52 | 1004 | return -1; |
50e98013 | 1005 | |
7ab1ba02 CB |
1006 | if (lxc_network_recv_veth_names_from_parent(handler) < 0) { |
1007 | ERROR("Failed to receive veth names from parent"); | |
658979c5 | 1008 | goto out_warn_father; |
7ab1ba02 | 1009 | } |
658979c5 | 1010 | |
408da065 | 1011 | /* If we are in a new user namespace, become root there to have |
d08f8d2f | 1012 | * privilege over our namespace. |
f6d3e3e4 SH |
1013 | */ |
1014 | if (!lxc_list_empty(&handler->conf->id_map)) { | |
4160c3a0 CB |
1015 | uid_t nsuid = (handler->conf->root_nsuid_map != NULL) |
1016 | ? 0 | |
1017 | : handler->conf->init_uid; | |
1018 | gid_t nsgid = (handler->conf->root_nsgid_map != NULL) | |
1019 | ? 0 | |
1020 | : handler->conf->init_gid; | |
1021 | ||
1022 | ret = lxc_switch_uid_gid(nsuid, nsgid); | |
4b826b1f | 1023 | if (ret < 0) |
f6d3e3e4 | 1024 | goto out_warn_father; |
d08f8d2f CB |
1025 | |
1026 | /* Drop groups only after we switched to a valid gid in the new | |
1027 | * user namespace. | |
1028 | */ | |
4b826b1f | 1029 | ret = lxc_setgroups(0, NULL); |
a19b974f | 1030 | if (ret < 0 && (handler->am_root || errno != EPERM)) |
c476bdce | 1031 | goto out_warn_father; |
4b826b1f CB |
1032 | |
1033 | if (!handler->am_root) { | |
1034 | ret = prctl(PR_SET_DUMPABLE, 1, 0, 0, 0); | |
1035 | if (ret < 0) | |
1036 | goto out_warn_father; | |
1037 | } | |
912314fc CB |
1038 | |
1039 | /* set{g,u}id() clears deathsignal */ | |
18225d19 | 1040 | ret = lxc_set_death_signal(SIGKILL); |
912314fc CB |
1041 | if (ret < 0) { |
1042 | SYSERROR("Failed to set PR_SET_PDEATHSIG to SIGKILL"); | |
1043 | goto out_warn_father; | |
1044 | } | |
f6d3e3e4 SH |
1045 | } |
1046 | ||
99b71824 | 1047 | if (access(handler->lxcpath, X_OK)) { |
c8154066 SH |
1048 | print_top_failing_dir(handler->lxcpath); |
1049 | goto out_warn_father; | |
1050 | } | |
1051 | ||
a91cde21 | 1052 | ret = snprintf(path, sizeof(path), "%s/dev/null", handler->conf->rootfs.mount); |
408da065 | 1053 | if (ret < 0 || ret >= sizeof(path)) |
7a55c157 | 1054 | goto out_warn_father; |
7a55c157 TA |
1055 | |
1056 | /* In order to checkpoint restore, we need to have everything in the | |
1057 | * same mount namespace. However, some containers may not have a | |
1058 | * reasonable /dev (in particular, they may not have /dev/null), so we | |
1059 | * can't set init's std fds to /dev/null by opening it from inside the | |
1060 | * container. | |
1061 | * | |
1062 | * If that's the case, fall back to using the host's /dev/null. This | |
1063 | * means that migration won't work, but at least we won't spew output | |
1064 | * where it isn't wanted. | |
1065 | */ | |
1066 | if (handler->backgrounded && !handler->conf->autodev && access(path, F_OK) < 0) { | |
c44de748 AM |
1067 | devnull_fd = open_devnull(); |
1068 | ||
1069 | if (devnull_fd < 0) | |
1070 | goto out_warn_father; | |
408da065 CB |
1071 | WARN("Using /dev/null from the host for container init's " |
1072 | "standard file descriptors. Migration will not work."); | |
c44de748 AM |
1073 | } |
1074 | ||
408da065 | 1075 | /* Ask father to setup cgroups and wait for him to finish. */ |
544a48a0 | 1076 | if (lxc_sync_barrier_parent(handler, LXC_SYNC_CGROUP)) |
c44de748 | 1077 | goto out_error; |
544a48a0 | 1078 | |
deefdf8a CB |
1079 | /* Unshare cgroup namespace after we have setup our cgroups. If we do it |
1080 | * earlier we end up with a wrong view of /proc/self/cgroup. For | |
1081 | * example, assume we unshare(CLONE_NEWCGROUP) first, and then create | |
1082 | * the cgroup for the container, say /sys/fs/cgroup/cpuset/lxc/c, then | |
1083 | * /proc/self/cgroup would show us: | |
1084 | * | |
1085 | * 8:cpuset:/lxc/c | |
1086 | * | |
1087 | * whereas it should actually show | |
1088 | * | |
1089 | * 8:cpuset:/ | |
1090 | */ | |
5af9369b | 1091 | if (handler->clone_flags & CLONE_NEWCGROUP) { |
deefdf8a CB |
1092 | if (unshare(CLONE_NEWCGROUP) < 0) { |
1093 | INFO("Failed to unshare CLONE_NEWCGROUP."); | |
1094 | goto out_warn_father; | |
1095 | } | |
1096 | INFO("Unshared CLONE_NEWCGROUP."); | |
1097 | } | |
1098 | ||
149857af CB |
1099 | /* Add the requested environment variables to the current environment to |
1100 | * allow them to be used by the various hooks, such as the start hook | |
1101 | * above. | |
98ff08ca | 1102 | */ |
98ff08ca CB |
1103 | lxc_list_for_each(iterator, &handler->conf->environment) { |
1104 | if (putenv((char *)iterator->elem)) { | |
1105 | SYSERROR("Failed to set environment variable: %s.", (char *)iterator->elem); | |
1106 | goto out_warn_father; | |
1107 | } | |
1108 | } | |
1109 | ||
f4152036 | 1110 | /* Setup the container, ip, names, utsname, ... */ |
3b988b33 | 1111 | ret = lxc_setup(handler); |
7729f8e5 | 1112 | close(handler->data_sock[1]); |
8bf3abfb | 1113 | close(handler->data_sock[0]); |
7729f8e5 | 1114 | if (ret < 0) { |
f4152036 CB |
1115 | ERROR("Failed to setup container \"%s\".", handler->name); |
1116 | goto out_warn_father; | |
1117 | } | |
1118 | ||
408da065 | 1119 | /* Set the label to change to when we exec(2) the container's init. */ |
7aff4f43 | 1120 | if (lsm_process_label_set(NULL, handler->conf, 1, 1) < 0) |
e075f5d9 | 1121 | goto out_warn_father; |
5112cd70 | 1122 | |
029cdff5 | 1123 | /* Set PR_SET_NO_NEW_PRIVS after we changed the lsm label. If we do it |
408da065 CB |
1124 | * before we aren't allowed anymore. |
1125 | */ | |
029cdff5 CB |
1126 | if (handler->conf->no_new_privs) { |
1127 | if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) < 0) { | |
1128 | SYSERROR("Could not set PR_SET_NO_NEW_PRIVS to block execve() gainable privileges."); | |
1129 | goto out_warn_father; | |
1130 | } | |
1131 | DEBUG("Set PR_SET_NO_NEW_PRIVS to block execve() gainable privileges."); | |
1132 | } | |
1133 | ||
0d9acb99 DE |
1134 | /* Some init's such as busybox will set sane tty settings on stdin, |
1135 | * stdout, stderr which it thinks is the console. We already set them | |
1136 | * the way we wanted on the real terminal, and we want init to do its | |
408da065 CB |
1137 | * setup on its console ie. the pty allocated in lxc_console_create() so |
1138 | * make sure that that pty is stdin,stdout,stderr. | |
0d9acb99 | 1139 | */ |
5d113f65 CB |
1140 | if (handler->conf->console.slave >= 0) { |
1141 | if (handler->backgrounded || handler->conf->is_execute == 0) | |
1142 | ret = set_stdfds(handler->conf->console.slave); | |
1143 | else | |
1144 | ret = lxc_console_set_stdfds(handler->conf->console.slave); | |
1145 | if (ret < 0) { | |
c5b93afb LF |
1146 | ERROR("Failed to redirect std{in,out,err} to pty file " |
1147 | "descriptor %d", | |
1148 | handler->conf->console.slave); | |
1149 | goto out_warn_father; | |
1150 | } | |
5d113f65 | 1151 | } |
0d9acb99 | 1152 | |
408da065 | 1153 | /* If we mounted a temporary proc, then unmount it now. */ |
5112cd70 | 1154 | tmp_proc_unmount(handler->conf); |
e075f5d9 | 1155 | |
8f2c3a70 SH |
1156 | if (lxc_seccomp_load(handler->conf) != 0) |
1157 | goto out_warn_father; | |
1158 | ||
14a7b0f9 | 1159 | if (run_lxc_hooks(handler->name, "start", handler->conf, NULL)) { |
408da065 | 1160 | ERROR("Failed to run lxc.hook.start for container \"%s\".", handler->name); |
773fb9ca SH |
1161 | goto out_warn_father; |
1162 | } | |
fc25b815 | 1163 | |
773fb9ca | 1164 | close(handler->sigfd); |
26ddeedd | 1165 | |
7a55c157 TA |
1166 | if (devnull_fd < 0) { |
1167 | devnull_fd = open_devnull(); | |
1168 | ||
1169 | if (devnull_fd < 0) | |
1170 | goto out_warn_father; | |
1171 | } | |
1172 | ||
c5b93afb LF |
1173 | if (handler->conf->console.slave < 0 && handler->backgrounded) |
1174 | if (set_stdfds(devnull_fd) < 0) { | |
1175 | ERROR("Failed to redirect std{in,out,err} to " | |
1176 | "\"/dev/null\""); | |
1177 | goto out_warn_father; | |
1178 | } | |
507cee36 | 1179 | |
c44de748 AM |
1180 | if (devnull_fd >= 0) { |
1181 | close(devnull_fd); | |
1182 | devnull_fd = -1; | |
1183 | } | |
1184 | ||
8c9a7665 TA |
1185 | setsid(); |
1186 | ||
3c491553 L |
1187 | if (handler->conf->init_cwd && chdir(handler->conf->init_cwd)) { |
1188 | SYSERROR("Could not change directory to \"%s\"", handler->conf->init_cwd); | |
1189 | goto out_warn_father; | |
1190 | } | |
1191 | ||
f4152036 CB |
1192 | if (lxc_sync_barrier_parent(handler, LXC_SYNC_CGROUP_LIMITS)) |
1193 | goto out_warn_father; | |
1194 | ||
149857af CB |
1195 | /* Reset the environment variables the user requested in a clear |
1196 | * environment. | |
1197 | */ | |
1198 | if (clearenv()) { | |
1199 | SYSERROR("Failed to clear environment."); | |
1200 | /* Don't error out though. */ | |
1201 | } | |
1202 | ||
1203 | lxc_list_for_each(iterator, &handler->conf->environment) { | |
1204 | if (putenv((char *)iterator->elem)) { | |
1205 | SYSERROR("Failed to set environment variable: %s.", (char *)iterator->elem); | |
1206 | goto out_warn_father; | |
1207 | } | |
1208 | } | |
1209 | ||
98ff08ca CB |
1210 | if (putenv("container=lxc")) { |
1211 | SYSERROR("Failed to set environment variable: container=lxc."); | |
1212 | goto out_warn_father; | |
1213 | } | |
1214 | ||
1215 | if (handler->conf->pty_names) { | |
1216 | if (putenv(handler->conf->pty_names)) { | |
1217 | SYSERROR("Failed to set environment variable for container ptys."); | |
1218 | goto out_warn_father; | |
1219 | } | |
1220 | } | |
1221 | ||
76bdf299 CB |
1222 | /* The container has been setup. We can now switch to an unprivileged |
1223 | * uid/gid. | |
1224 | */ | |
928b1f04 YT |
1225 | new_uid = handler->conf->init_uid; |
1226 | new_gid = handler->conf->init_gid; | |
76bdf299 | 1227 | |
928b1f04 YT |
1228 | /* If we are in a new user namespace we already dropped all |
1229 | * groups when we switched to root in the new user namespace | |
1230 | * further above. Only drop groups if we can, so ensure that we | |
1231 | * have necessary privilege. | |
1232 | */ | |
1233 | #if HAVE_LIBCAP | |
1234 | have_cap_setgid = lxc_proc_cap_is_set(CAP_SETGID, CAP_EFFECTIVE); | |
1235 | #else | |
1236 | have_cap_setgid = false; | |
1237 | #endif | |
1238 | if (lxc_list_empty(&handler->conf->id_map) && have_cap_setgid) { | |
1239 | if (lxc_setgroups(0, NULL) < 0) | |
76bdf299 CB |
1240 | goto out_warn_father; |
1241 | } | |
1242 | ||
928b1f04 YT |
1243 | if (lxc_switch_uid_gid(new_uid, new_gid) < 0) |
1244 | goto out_warn_father; | |
1245 | ||
408da065 CB |
1246 | /* After this call, we are in error because this ops should not return |
1247 | * as it execs. | |
1248 | */ | |
c4ea60df | 1249 | handler->ops->start(handler, handler->data); |
50e98013 DL |
1250 | |
1251 | out_warn_father: | |
408da065 CB |
1252 | /* We want the parent to know something went wrong, so we return a |
1253 | * special error code. | |
1254 | */ | |
d1ccb562 | 1255 | lxc_sync_wake_parent(handler, LXC_SYNC_ERROR); |
c44de748 AM |
1256 | |
1257 | out_error: | |
1258 | if (devnull_fd >= 0) | |
1259 | close(devnull_fd); | |
1260 | ||
50e98013 DL |
1261 | return -1; |
1262 | } | |
1263 | ||
ae467c54 | 1264 | static int lxc_recv_ttys_from_child(struct lxc_handler *handler) |
e8bd4e43 | 1265 | { |
ae467c54 | 1266 | int i; |
ae467c54 CB |
1267 | struct lxc_pty_info *pty_info; |
1268 | int ret = -1; | |
c6012571 | 1269 | int sock = handler->data_sock[1]; |
e8bd4e43 | 1270 | struct lxc_conf *conf = handler->conf; |
e8bd4e43 SH |
1271 | struct lxc_tty_info *tty_info = &conf->tty_info; |
1272 | ||
1273 | if (!conf->tty) | |
1274 | return 0; | |
1275 | ||
408da065 CB |
1276 | tty_info->pty_info = malloc(sizeof(*tty_info->pty_info) * conf->tty); |
1277 | if (!tty_info->pty_info) | |
e8bd4e43 | 1278 | return -1; |
e8bd4e43 | 1279 | |
672c1e58 CB |
1280 | for (i = 0; i < conf->tty; i++) { |
1281 | int ttyfds[2]; | |
1282 | ||
1283 | ret = lxc_abstract_unix_recv_fds(sock, ttyfds, 2, NULL, 0); | |
1284 | if (ret < 0) | |
1285 | break; | |
ae467c54 | 1286 | |
672c1e58 | 1287 | pty_info = &tty_info->pty_info[i]; |
e8bd4e43 | 1288 | pty_info->busy = 0; |
672c1e58 CB |
1289 | pty_info->master = ttyfds[0]; |
1290 | pty_info->slave = ttyfds[1]; | |
1291 | TRACE("Received pty with master fd %d and slave fd %d from " | |
ae467c54 | 1292 | "parent", pty_info->master, pty_info->slave); |
e8bd4e43 | 1293 | } |
ae467c54 | 1294 | if (ret < 0) |
672c1e58 | 1295 | ERROR("Failed to receive %d ttys from child: %s", conf->tty, |
ae467c54 CB |
1296 | strerror(errno)); |
1297 | else | |
672c1e58 CB |
1298 | TRACE("Received %d ttys from child", conf->tty); |
1299 | ||
1300 | tty_info->nbtty = conf->tty; | |
ae467c54 CB |
1301 | |
1302 | return ret; | |
e8bd4e43 SH |
1303 | } |
1304 | ||
5af9369b | 1305 | int resolve_clone_flags(struct lxc_handler *handler) |
f813849c | 1306 | { |
03df7ab5 | 1307 | handler->clone_flags = CLONE_NEWNS; |
f813849c | 1308 | |
fa3a5b22 CB |
1309 | if (!handler->conf->inherit_ns[LXC_NS_USER]) { |
1310 | if (!lxc_list_empty(&handler->conf->id_map)) | |
1311 | handler->clone_flags |= CLONE_NEWUSER; | |
1312 | } else { | |
1313 | INFO("Inheriting user namespace"); | |
1314 | } | |
f813849c | 1315 | |
28d9e29e | 1316 | if (!handler->conf->inherit_ns[LXC_NS_NET]) { |
408da065 | 1317 | if (!lxc_requests_empty_network(handler)) |
f813849c TA |
1318 | handler->clone_flags |= CLONE_NEWNET; |
1319 | } else { | |
28d9e29e | 1320 | INFO("Inheriting net namespace"); |
f813849c TA |
1321 | } |
1322 | ||
28d9e29e | 1323 | if (!handler->conf->inherit_ns[LXC_NS_IPC]) |
f813849c | 1324 | handler->clone_flags |= CLONE_NEWIPC; |
408da065 | 1325 | else |
28d9e29e | 1326 | INFO("Inheriting ipc namespace"); |
f813849c | 1327 | |
28d9e29e | 1328 | if (!handler->conf->inherit_ns[LXC_NS_UTS]) |
f813849c | 1329 | handler->clone_flags |= CLONE_NEWUTS; |
408da065 | 1330 | else |
28d9e29e | 1331 | INFO("Inheriting uts namespace"); |
03df7ab5 | 1332 | |
28d9e29e | 1333 | if (!handler->conf->inherit_ns[LXC_NS_PID]) |
03df7ab5 L |
1334 | handler->clone_flags |= CLONE_NEWPID; |
1335 | else | |
28d9e29e | 1336 | INFO("Inheriting pid namespace"); |
5af9369b CB |
1337 | |
1338 | if (cgns_supported()) { | |
1339 | if (!handler->conf->inherit_ns[LXC_NS_CGROUP]) | |
1340 | handler->clone_flags |= CLONE_NEWCGROUP; | |
1341 | else | |
1342 | INFO("Inheriting cgroup namespace"); | |
1343 | } else if (handler->conf->inherit_ns[LXC_NS_CGROUP]) { | |
1344 | return -EINVAL; | |
1345 | } | |
1346 | ||
1347 | return 0; | |
f813849c TA |
1348 | } |
1349 | ||
8deca6c9 CB |
1350 | /* Note that this function is used with clone(CLONE_VM). Some glibc versions |
1351 | * used to reset the pid/tid to -1 when CLONE_VM was used without CLONE_THREAD. | |
1352 | * But since the memory between parent and child is shared on CLONE_VM this | |
1353 | * would invalidate the getpid() cache that glibc used to maintain and so | |
1354 | * getpid() in the child would return the parent's pid. This is all fixed in | |
1355 | * newer glibc versions where the getpid() cache is removed and the pid/tid is | |
1356 | * not reset anymore. | |
1357 | * However, if for whatever reason you - dear commiter - somehow need to get the | |
1358 | * pid of the dummy intermediate process for do_share_ns() you need to call | |
0059379f CB |
1359 | * lxc_raw_getpid(). The next lxc_raw_clone() call does not employ CLONE_VM and |
1360 | * will be fine. | |
8deca6c9 CB |
1361 | */ |
1362 | static inline int do_share_ns(void *arg) | |
fa3a5b22 | 1363 | { |
8deca6c9 | 1364 | int i, flags, ret; |
fa3a5b22 CB |
1365 | struct lxc_handler *handler = arg; |
1366 | ||
8deca6c9 CB |
1367 | for (i = 0; i < LXC_NS_MAX; i++) { |
1368 | if (handler->nsfd[i] < 0) | |
1369 | continue; | |
fa3a5b22 | 1370 | |
8deca6c9 | 1371 | ret = setns(handler->nsfd[i], 0); |
fa3a5b22 | 1372 | if (ret < 0) |
8deca6c9 | 1373 | return -1; |
fa3a5b22 | 1374 | |
8deca6c9 | 1375 | DEBUG("Inherited %s namespace", ns_info[i].proc_name); |
fa3a5b22 CB |
1376 | } |
1377 | ||
8deca6c9 CB |
1378 | flags = handler->on_clone_flags; |
1379 | flags |= CLONE_PARENT; | |
ac2ba696 | 1380 | handler->pid = lxc_raw_clone_cb(do_start, handler, flags); |
8deca6c9 | 1381 | if (handler->pid < 0) |
fa3a5b22 CB |
1382 | return -1; |
1383 | ||
8deca6c9 | 1384 | return 0; |
fa3a5b22 CB |
1385 | } |
1386 | ||
480588e6 CB |
1387 | /* lxc_spawn() performs crucial setup tasks and clone()s the new process which |
1388 | * exec()s the requested container binary. | |
1389 | * Note that lxc_spawn() runs in the parent namespaces. Any operations performed | |
1390 | * right here should be double checked if they'd pose a security risk. (For | |
1391 | * example, any {u}mount() operations performed here will be reflected on the | |
1392 | * host!) | |
1393 | */ | |
74a3920a | 1394 | static int lxc_spawn(struct lxc_handler *handler) |
59eb99ba | 1395 | { |
8deca6c9 | 1396 | int i, ret; |
08dd2805 | 1397 | char pidstr[20]; |
57927bf2 CB |
1398 | bool wants_to_map_ids; |
1399 | struct lxc_list *id_map; | |
6e5fc7a5 | 1400 | const char *name = handler->name; |
28d9e29e | 1401 | const char *lxcpath = handler->lxcpath; |
8deca6c9 | 1402 | bool cgroups_connected = false, share_ns = false; |
28d9e29e | 1403 | struct lxc_conf *conf = handler->conf; |
9f30a190 | 1404 | |
28d9e29e | 1405 | id_map = &conf->id_map; |
57927bf2 | 1406 | wants_to_map_ids = !lxc_list_empty(id_map); |
2f2623ec | 1407 | |
28d9e29e CB |
1408 | for (i = 0; i < LXC_NS_MAX; i++) { |
1409 | if (!conf->inherit_ns[i]) | |
1410 | continue; | |
1411 | ||
28d9e29e CB |
1412 | handler->nsfd[i] = lxc_inherit_namespace(conf->inherit_ns[i], lxcpath, ns_info[i].proc_name); |
1413 | if (handler->nsfd[i] < 0) | |
1414 | return -1; | |
fa3a5b22 | 1415 | |
8deca6c9 | 1416 | share_ns = true; |
28d9e29e | 1417 | } |
50e98013 | 1418 | |
3c22086f | 1419 | if (lxc_sync_init(handler)) |
9d7f9e52 | 1420 | return -1; |
0ad19a3f | 1421 | |
b9f522c5 | 1422 | ret = socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, |
790255cf | 1423 | handler->data_sock); |
c6012571 | 1424 | if (ret < 0) { |
e8bd4e43 SH |
1425 | lxc_sync_fini(handler); |
1426 | return -1; | |
1427 | } | |
1428 | ||
5af9369b CB |
1429 | ret = resolve_clone_flags(handler); |
1430 | if (ret < 0) { | |
1431 | lxc_sync_fini(handler); | |
1432 | return -1; | |
1433 | } | |
9f30a190 | 1434 | |
f813849c | 1435 | if (handler->clone_flags & CLONE_NEWNET) { |
28d9e29e | 1436 | if (!lxc_list_empty(&conf->network)) { |
26b797f3 | 1437 | |
9f30a190 MM |
1438 | /* Find gateway addresses from the link device, which is |
1439 | * no longer accessible inside the container. Do this | |
1440 | * before creating network interfaces, since goto | |
408da065 CB |
1441 | * out_delete_net does not work before lxc_clone. |
1442 | */ | |
9f30a190 | 1443 | if (lxc_find_gateway_addresses(handler)) { |
408da065 | 1444 | ERROR("Failed to find gateway addresses."); |
9f30a190 MM |
1445 | lxc_sync_fini(handler); |
1446 | return -1; | |
1447 | } | |
1448 | ||
408da065 CB |
1449 | /* That should be done before the clone because we will |
1450 | * fill the netdev index and use them in the child. | |
9f30a190 | 1451 | */ |
811ef482 | 1452 | if (lxc_create_network_priv(handler)) { |
408da065 | 1453 | ERROR("Failed to create the network."); |
9f30a190 MM |
1454 | lxc_sync_fini(handler); |
1455 | return -1; | |
1456 | } | |
19a26f82 | 1457 | } |
82d5ae15 DL |
1458 | } |
1459 | ||
d4ef7c50 | 1460 | if (!cgroup_init(handler)) { |
408da065 | 1461 | ERROR("Failed initializing cgroup support."); |
33ad9f1a CS |
1462 | goto out_delete_net; |
1463 | } | |
1464 | ||
7e4dfe0b SH |
1465 | cgroups_connected = true; |
1466 | ||
d4ef7c50 | 1467 | if (!cgroup_create(handler)) { |
408da065 | 1468 | ERROR("Failed creating cgroups."); |
47d8fb3b CS |
1469 | goto out_delete_net; |
1470 | } | |
1471 | ||
408da065 CB |
1472 | /* If the rootfs is not a blockdev, prevent the container from marking |
1473 | * it readonly. | |
1474 | * If the container is unprivileged then skip rootfs pinning. | |
0c547523 | 1475 | */ |
0ee35059 | 1476 | if (!wants_to_map_ids) { |
28d9e29e | 1477 | handler->pinfd = pin_rootfs(conf->rootfs.path); |
5e32a990 | 1478 | if (handler->pinfd == -1) |
408da065 | 1479 | INFO("Failed to pin the rootfs for container \"%s\".", handler->name); |
5e32a990 | 1480 | } |
0c547523 | 1481 | |
408da065 | 1482 | /* Create a process in a new set of namespaces. */ |
8deca6c9 | 1483 | handler->on_clone_flags = handler->clone_flags; |
408da065 CB |
1484 | if (handler->clone_flags & CLONE_NEWUSER) { |
1485 | /* If CLONE_NEWUSER and CLONE_NEWNET was requested, we need to | |
1486 | * clone a new user namespace first and only later unshare our | |
1487 | * network namespace to ensure that network devices ownership is | |
1488 | * set up correctly. | |
1489 | */ | |
8deca6c9 | 1490 | handler->on_clone_flags &= ~CLONE_NEWNET; |
408da065 | 1491 | } |
5af9369b CB |
1492 | /* The cgroup namespace gets unshare()ed not clone()ed. */ |
1493 | handler->on_clone_flags &= ~CLONE_NEWCGROUP; | |
732375f5 | 1494 | |
4e232466 CB |
1495 | if (share_ns) { |
1496 | pid_t attacher_pid; | |
1497 | ||
1498 | attacher_pid = lxc_clone(do_share_ns, handler, CLONE_VFORK | CLONE_VM | CLONE_FILES); | |
1499 | if (attacher_pid < 0) { | |
1500 | SYSERROR(LXC_CLONE_ERROR); | |
1501 | goto out_delete_net; | |
1502 | } | |
1503 | ||
1504 | ret = wait_for_pid(attacher_pid); | |
1505 | if (ret < 0) { | |
1506 | SYSERROR("Intermediate process failed"); | |
1507 | goto out_delete_net; | |
1508 | } | |
1509 | } else { | |
ac2ba696 | 1510 | handler->pid = lxc_raw_clone_cb(do_start, handler, handler->on_clone_flags); |
4e232466 CB |
1511 | } |
1512 | if (handler->pid < 0) { | |
1513 | SYSERROR(LXC_CLONE_ERROR); | |
7fef7a06 | 1514 | goto out_delete_net; |
0ad19a3f | 1515 | } |
fa3a5b22 | 1516 | TRACE("Cloned child process %d", handler->pid); |
1bd8d726 | 1517 | |
9662e444 | 1518 | for (i = 0; i < LXC_NS_MAX; i++) |
8deca6c9 | 1519 | if (handler->on_clone_flags & ns_info[i].clone_flag) |
28d9e29e | 1520 | INFO("Cloned %s", ns_info[i].flag_name); |
0ad19a3f | 1521 | |
8bf3abfb | 1522 | if (!preserve_ns(handler->nsfd, handler->on_clone_flags, handler->pid)) { |
28d9e29e CB |
1523 | ERROR("Failed to preserve cloned namespaces for lxc.hook.stop"); |
1524 | goto out_delete_net; | |
1525 | } | |
b6b2b194 | 1526 | |
3c22086f CLG |
1527 | lxc_sync_fini_child(handler); |
1528 | ||
408da065 CB |
1529 | /* Map the container uids. The container became an invalid userid the |
1530 | * moment it was cloned with CLONE_NEWUSER. This call doesn't change | |
1531 | * anything immediately, but allows the container to setuid(0) (0 being | |
1532 | * mapped to something else on the host.) later to become a valid uid | |
1533 | * again. | |
1534 | */ | |
fa3a5b22 CB |
1535 | if (wants_to_map_ids) { |
1536 | if (!handler->conf->inherit_ns[LXC_NS_USER]) { | |
1537 | ret = lxc_map_ids(id_map, handler->pid); | |
1538 | if (ret < 0) { | |
1539 | ERROR("Failed to set up id mapping."); | |
1540 | goto out_delete_net; | |
1541 | } | |
1542 | } | |
5b1e83cb SH |
1543 | } |
1544 | ||
9e2bdae4 | 1545 | if (lxc_sync_wake_child(handler, LXC_SYNC_STARTUP)) |
5b1e83cb | 1546 | goto out_delete_net; |
5b1e83cb | 1547 | |
9e2bdae4 | 1548 | if (lxc_sync_wait_child(handler, LXC_SYNC_CONFIGURE)) |
5b1e83cb | 1549 | goto out_delete_net; |
0ad19a3f | 1550 | |
d4ef7c50 | 1551 | if (!cgroup_create_legacy(handler)) { |
408da065 | 1552 | ERROR("Failed to setup legacy cgroups for container \"%s\".", name); |
ae5c8b8e | 1553 | goto out_delete_net; |
33ad9f1a | 1554 | } |
9daf6f5d | 1555 | if (!cgroup_setup_limits(handler, false)) { |
408da065 | 1556 | ERROR("Failed to setup cgroup limits for container \"%s\".", name); |
6031a6e5 DE |
1557 | goto out_delete_net; |
1558 | } | |
1559 | ||
d4ef7c50 | 1560 | if (!cgroup_enter(handler)) |
7fef7a06 | 1561 | goto out_delete_net; |
218d4250 | 1562 | |
0996e18a SH |
1563 | if (!cgroup_chown(handler)) |
1564 | goto out_delete_net; | |
1565 | ||
fa3a5b22 CB |
1566 | /* Now we're ready to preserve the network namespace */ |
1567 | ret = lxc_preserve_ns(handler->pid, "net"); | |
1568 | if (ret < 0) { | |
1569 | ERROR("%s - Failed to preserve net namespace", strerror(errno)); | |
1570 | goto out_delete_net; | |
1571 | } | |
1572 | handler->nsfd[LXC_NS_NET] = ret; | |
1573 | DEBUG("Preserved net namespace via fd %d", ret); | |
1574 | ||
408da065 | 1575 | /* Create the network configuration. */ |
d5088cf2 | 1576 | if (handler->clone_flags & CLONE_NEWNET) { |
74c6e2b0 CB |
1577 | if (lxc_network_move_created_netdev_priv(handler->lxcpath, |
1578 | handler->name, | |
28d9e29e | 1579 | &conf->network, |
74c6e2b0 | 1580 | handler->pid)) { |
408da065 | 1581 | ERROR("Failed to create the configured network."); |
7fef7a06 | 1582 | goto out_delete_net; |
82d5ae15 | 1583 | } |
74c6e2b0 CB |
1584 | |
1585 | if (lxc_create_network_unpriv(handler->lxcpath, handler->name, | |
28d9e29e | 1586 | &conf->network, |
74c6e2b0 CB |
1587 | handler->pid)) { |
1588 | ERROR("Failed to create the configured network."); | |
1589 | goto out_delete_net; | |
1590 | } | |
0ad19a3f | 1591 | } |
1592 | ||
7ab1ba02 CB |
1593 | if (lxc_network_send_veth_names_to_child(handler) < 0) { |
1594 | ERROR("Failed to send veth names to child"); | |
1595 | goto out_delete_net; | |
658979c5 SH |
1596 | } |
1597 | ||
61d7a733 YT |
1598 | if (!lxc_list_empty(&conf->procs)) { |
1599 | ret = setup_proc_filesystem(&conf->procs, handler->pid); | |
1600 | if (ret < 0) | |
1601 | goto out_delete_net; | |
1602 | } | |
1603 | ||
408da065 CB |
1604 | /* Tell the child to continue its initialization. We'll get |
1605 | * LXC_SYNC_CGROUP when it is ready for us to setup cgroups. | |
3c22086f CLG |
1606 | */ |
1607 | if (lxc_sync_barrier_child(handler, LXC_SYNC_POST_CONFIGURE)) | |
544a48a0 SH |
1608 | goto out_delete_net; |
1609 | ||
28d9e29e | 1610 | if (!lxc_list_empty(&conf->limits) && setup_resource_limits(&conf->limits, handler->pid)) { |
c6d09e15 | 1611 | ERROR("failed to setup resource limits for '%s'", name); |
84ff3af7 | 1612 | goto out_delete_net; |
c6d09e15 WB |
1613 | } |
1614 | ||
f4152036 CB |
1615 | if (lxc_sync_barrier_child(handler, LXC_SYNC_CGROUP_UNSHARE)) |
1616 | goto out_delete_net; | |
1617 | ||
9daf6f5d | 1618 | if (!cgroup_setup_limits(handler, true)) { |
408da065 | 1619 | ERROR("Failed to setup the devices cgroup for container \"%s\".", name); |
b98f7d6e | 1620 | goto out_delete_net; |
544a48a0 | 1621 | } |
f4152036 | 1622 | TRACE("Set up cgroup device limits"); |
544a48a0 | 1623 | |
73d28d42 | 1624 | cgroup_disconnect(); |
7e4dfe0b | 1625 | cgroups_connected = false; |
73d28d42 | 1626 | |
8bf3abfb CB |
1627 | if (handler->clone_flags & CLONE_NEWCGROUP) { |
1628 | /* Now we're ready to preserve the cgroup namespace */ | |
1629 | ret = lxc_preserve_ns(handler->pid, "cgroup"); | |
1630 | if (ret < 0) { | |
1631 | ERROR("%s - Failed to preserve cgroup namespace", strerror(errno)); | |
1632 | goto out_delete_net; | |
1633 | } | |
1634 | handler->nsfd[LXC_NS_CGROUP] = ret; | |
1635 | DEBUG("Preserved cgroup namespace via fd %d", ret); | |
1636 | } | |
1637 | ||
08dd2805 SH |
1638 | snprintf(pidstr, 20, "%d", handler->pid); |
1639 | if (setenv("LXC_PID", pidstr, 1)) | |
1640 | SYSERROR("Failed to set environment variable: LXC_PID=%s.", pidstr); | |
1641 | ||
1642 | /* Run any host-side start hooks */ | |
14a7b0f9 | 1643 | if (run_lxc_hooks(name, "start-host", conf, NULL)) { |
08dd2805 SH |
1644 | ERROR("Failed to run lxc.hook.start-host for container \"%s\".", name); |
1645 | return -1; | |
1646 | } | |
1647 | ||
408da065 CB |
1648 | /* Tell the child to complete its initialization and wait for it to exec |
1649 | * or return an error. (The child will never return | |
08dd2805 | 1650 | * LXC_SYNC_READY_START+1. It will either close the sync pipe, causing |
408da065 CB |
1651 | * lxc_sync_barrier_child to return success, or return a different |
1652 | * value, causing us to error out). | |
544a48a0 | 1653 | */ |
08dd2805 | 1654 | if (lxc_sync_barrier_child(handler, LXC_SYNC_READY_START)) |
3c22086f | 1655 | return -1; |
0ad19a3f | 1656 | |
790255cf CB |
1657 | if (lxc_network_recv_name_and_ifindex_from_child(handler) < 0) { |
1658 | ERROR("Failed to receive names and ifindices for network " | |
1659 | "devices from child"); | |
1660 | goto out_delete_net; | |
1661 | } | |
1662 | ||
1663 | /* Now all networks are created, network devices are moved into place, | |
1664 | * and the correct names and ifindeces in the respective namespaces have | |
1665 | * been recorded. The corresponding structs have now all been filled. So | |
1666 | * log them for debugging purposes. | |
1667 | */ | |
28d9e29e | 1668 | lxc_log_configured_netdevs(conf); |
790255cf | 1669 | |
f4152036 CB |
1670 | /* Read tty fds allocated by child. */ |
1671 | if (lxc_recv_ttys_from_child(handler) < 0) { | |
1672 | ERROR("Failed to receive tty info from child process."); | |
1673 | goto out_delete_net; | |
1674 | } | |
1675 | ||
23c53af9 | 1676 | if (handler->ops->post_start(handler, handler->data)) |
e6126dbe MN |
1677 | goto out_abort; |
1678 | ||
25c2aca5 | 1679 | if (lxc_set_state(name, handler, RUNNING)) { |
408da065 CB |
1680 | ERROR("Failed to set state for container \"%s\" to \"%s\".", name, |
1681 | lxc_state2str(RUNNING)); | |
59eb99ba | 1682 | goto out_abort; |
3f21c114 | 1683 | } |
22ebac19 | 1684 | |
3c22086f | 1685 | lxc_sync_fini(handler); |
0c547523 | 1686 | |
e6126dbe | 1687 | return 0; |
1ac470c0 | 1688 | |
7fef7a06 | 1689 | out_delete_net: |
7e4dfe0b SH |
1690 | if (cgroups_connected) |
1691 | cgroup_disconnect(); | |
1bd8d726 | 1692 | |
bb84beda CB |
1693 | if (handler->clone_flags & CLONE_NEWNET) |
1694 | lxc_delete_network(handler); | |
1bd8d726 | 1695 | |
59eb99ba DL |
1696 | out_abort: |
1697 | lxc_abort(name, handler); | |
3c22086f | 1698 | lxc_sync_fini(handler); |
5c068da9 SH |
1699 | if (handler->pinfd >= 0) { |
1700 | close(handler->pinfd); | |
1701 | handler->pinfd = -1; | |
1702 | } | |
1703 | ||
b79fcd86 | 1704 | return -1; |
59eb99ba | 1705 | } |
0ad19a3f | 1706 | |
aa460476 | 1707 | int __lxc_start(const char *name, struct lxc_handler *handler, |
507cee36 TA |
1708 | struct lxc_operations* ops, void *data, const char *lxcpath, |
1709 | bool backgrounded) | |
59eb99ba | 1710 | { |
59eb99ba | 1711 | int status; |
aa460476 | 1712 | int err = -1; |
aa460476 | 1713 | struct lxc_conf *conf = handler->conf; |
80090207 | 1714 | |
aa460476 | 1715 | if (lxc_init(name, handler) < 0) { |
408da065 | 1716 | ERROR("Failed to initialize container \"%s\".", name); |
66aeffc7 | 1717 | return -1; |
0ad19a3f | 1718 | } |
ee70bf78 CLG |
1719 | handler->ops = ops; |
1720 | handler->data = data; | |
507cee36 | 1721 | handler->backgrounded = backgrounded; |
e6126dbe | 1722 | |
76a26f55 | 1723 | if (!attach_block_device(handler->conf)) { |
408da065 | 1724 | ERROR("Failed to attach block device."); |
76a26f55 SH |
1725 | goto out_fini_nonet; |
1726 | } | |
1727 | ||
35120d9c | 1728 | if (geteuid() == 0 && !lxc_list_empty(&conf->id_map)) { |
408da065 | 1729 | /* If the backing store is a device, mount it here and now. */ |
35120d9c SH |
1730 | if (rootfs_is_blockdev(conf)) { |
1731 | if (unshare(CLONE_NEWNS) < 0) { | |
408da065 | 1732 | ERROR("Failed to unshare CLONE_NEWNS."); |
35120d9c SH |
1733 | goto out_fini_nonet; |
1734 | } | |
408da065 CB |
1735 | INFO("Unshared CLONE_NEWNS."); |
1736 | ||
6a0c909a | 1737 | remount_all_slave(); |
35120d9c | 1738 | if (do_rootfs_setup(conf, name, lxcpath) < 0) { |
408da065 | 1739 | ERROR("Error setting up rootfs mount as root before spawn."); |
35120d9c SH |
1740 | goto out_fini_nonet; |
1741 | } | |
408da065 | 1742 | INFO("Set up container rootfs as host root."); |
35120d9c SH |
1743 | } |
1744 | } | |
1745 | ||
23c53af9 | 1746 | err = lxc_spawn(handler); |
59eb99ba | 1747 | if (err) { |
408da065 | 1748 | ERROR("Failed to spawn container \"%s\".", name); |
76a26f55 | 1749 | goto out_detach_blockdev; |
0ad19a3f | 1750 | } |
a9e1109e CB |
1751 | /* close parent side of data socket */ |
1752 | close(handler->data_sock[0]); | |
1753 | handler->data_sock[0] = -1; | |
1754 | close(handler->data_sock[1]); | |
1755 | handler->data_sock[1] = -1; | |
0ad19a3f | 1756 | |
8bee8851 WB |
1757 | handler->conf->reboot = 0; |
1758 | ||
3a0f472d | 1759 | err = lxc_poll(name, handler); |
e043236e | 1760 | if (err) { |
408da065 | 1761 | ERROR("LXC mainloop exited with error: %d.", err); |
59eb99ba DL |
1762 | goto out_abort; |
1763 | } | |
0ad19a3f | 1764 | |
3a0f472d | 1765 | while (waitpid(handler->pid, &status, 0) < 0 && errno == EINTR) |
1bc5cc8c | 1766 | continue; |
e043236e | 1767 | |
408da065 CB |
1768 | /* If the child process exited but was not signaled, it didn't call |
1769 | * reboot. This should mean it was an lxc-execute which simply exited. | |
1770 | * In any case, treat it as a 'halt'. | |
8b004f07 | 1771 | */ |
d028235d | 1772 | if (WIFSIGNALED(status)) { |
8b004f07 SH |
1773 | switch(WTERMSIG(status)) { |
1774 | case SIGINT: /* halt */ | |
408da065 | 1775 | DEBUG("Container \"%s\" is halting.", name); |
8b004f07 SH |
1776 | break; |
1777 | case SIGHUP: /* reboot */ | |
408da065 | 1778 | DEBUG("Container \"%s\" is rebooting.", name); |
8b004f07 SH |
1779 | handler->conf->reboot = 1; |
1780 | break; | |
c2b9bd9e | 1781 | case SIGSYS: /* seccomp */ |
408da065 | 1782 | DEBUG("Container \"%s\" violated its seccomp policy.", name); |
c2b9bd9e | 1783 | break; |
8b004f07 | 1784 | default: |
408da065 | 1785 | DEBUG("Unknown exit status for container \"%s\" init %d.", name, WTERMSIG(status)); |
8b004f07 SH |
1786 | break; |
1787 | } | |
d028235d | 1788 | } |
828695d9 | 1789 | |
b809f232 CB |
1790 | err = lxc_restore_phys_nics_to_netns(handler); |
1791 | if (err < 0) | |
1792 | ERROR("Failed to move physical network devices back to parent " | |
1793 | "network namespace"); | |
ce5782df | 1794 | |
5c068da9 SH |
1795 | if (handler->pinfd >= 0) { |
1796 | close(handler->pinfd); | |
1797 | handler->pinfd = -1; | |
1798 | } | |
1799 | ||
1787abca | 1800 | lxc_monitor_send_exit_code(name, status, handler->lxcpath); |
3a0f472d | 1801 | err = lxc_error_set_and_log(handler->pid, status); |
1bd8d726 | 1802 | |
9d7f9e52 | 1803 | out_fini: |
bb84beda | 1804 | lxc_delete_network(handler); |
74a2b586 | 1805 | |
76a26f55 SH |
1806 | out_detach_blockdev: |
1807 | detach_block_device(handler->conf); | |
1808 | ||
74a2b586 | 1809 | out_fini_nonet: |
3a0f472d | 1810 | lxc_fini(name, handler); |
0ad19a3f | 1811 | return err; |
1812 | ||
59eb99ba | 1813 | out_abort: |
3a0f472d | 1814 | lxc_abort(name, handler); |
9d7f9e52 | 1815 | goto out_fini; |
0ad19a3f | 1816 | } |
ee70bf78 CLG |
1817 | |
1818 | struct start_args { | |
1819 | char *const *argv; | |
1820 | }; | |
1821 | ||
1822 | static int start(struct lxc_handler *handler, void* data) | |
1823 | { | |
1824 | struct start_args *arg = data; | |
1825 | ||
408da065 | 1826 | NOTICE("Exec'ing \"%s\".", arg->argv[0]); |
ee70bf78 CLG |
1827 | |
1828 | execvp(arg->argv[0], arg->argv); | |
408da065 | 1829 | SYSERROR("Failed to exec \"%s\".", arg->argv[0]); |
ee70bf78 CLG |
1830 | return 0; |
1831 | } | |
1832 | ||
1833 | static int post_start(struct lxc_handler *handler, void* data) | |
1834 | { | |
1835 | struct start_args *arg = data; | |
1836 | ||
408da065 | 1837 | NOTICE("Started \"%s\" with pid \"%d\".", arg->argv[0], handler->pid); |
ee70bf78 CLG |
1838 | return 0; |
1839 | } | |
1840 | ||
1841 | static struct lxc_operations start_ops = { | |
1842 | .start = start, | |
1843 | .post_start = post_start | |
1844 | }; | |
1845 | ||
aa460476 | 1846 | int lxc_start(const char *name, char *const argv[], struct lxc_handler *handler, |
507cee36 | 1847 | const char *lxcpath, bool backgrounded) |
ee70bf78 CLG |
1848 | { |
1849 | struct start_args start_arg = { | |
1850 | .argv = argv, | |
1851 | }; | |
1852 | ||
aa460476 | 1853 | return __lxc_start(name, handler, &start_ops, &start_arg, lxcpath, backgrounded); |
ee70bf78 | 1854 | } |
28272964 CB |
1855 | |
1856 | static void lxc_destroy_container_on_signal(struct lxc_handler *handler, | |
1857 | const char *name) | |
1858 | { | |
1859 | char destroy[MAXPATHLEN]; | |
1860 | bool bret = true; | |
1861 | int ret = 0; | |
f01f7975 | 1862 | struct lxc_container *c; |
df31363a | 1863 | if (handler->conf->rootfs.path && handler->conf->rootfs.mount) { |
790255cf | 1864 | bret = do_destroy_container(handler); |
28272964 | 1865 | if (!bret) { |
408da065 | 1866 | ERROR("Error destroying rootfs for container \"%s\".", name); |
28272964 CB |
1867 | return; |
1868 | } | |
1869 | } | |
408da065 | 1870 | INFO("Destroyed rootfs for container \"%s\".", name); |
28272964 CB |
1871 | |
1872 | ret = snprintf(destroy, MAXPATHLEN, "%s/%s", handler->lxcpath, name); | |
1873 | if (ret < 0 || ret >= MAXPATHLEN) { | |
408da065 | 1874 | ERROR("Error destroying directory for container \"%s\".", name); |
28272964 CB |
1875 | return; |
1876 | } | |
1877 | ||
f01f7975 CB |
1878 | c = lxc_container_new(name, handler->lxcpath); |
1879 | if (c) { | |
1880 | if (container_disk_lock(c)) { | |
408da065 | 1881 | INFO("Could not update lxc_snapshots file."); |
f01f7975 CB |
1882 | lxc_container_put(c); |
1883 | } else { | |
1884 | mod_all_rdeps(c, false); | |
1885 | container_disk_unlock(c); | |
1886 | lxc_container_put(c); | |
1887 | } | |
1888 | } | |
1889 | ||
d0fbc7ba | 1890 | if (!handler->am_root) |
94b0a3ac CB |
1891 | ret = userns_exec_full(handler->conf, lxc_rmdir_onedev_wrapper, |
1892 | destroy, "lxc_rmdir_onedev_wrapper"); | |
28272964 CB |
1893 | else |
1894 | ret = lxc_rmdir_onedev(destroy, NULL); | |
1895 | ||
1896 | if (ret < 0) { | |
408da065 | 1897 | ERROR("Error destroying directory for container \"%s\".", name); |
28272964 CB |
1898 | return; |
1899 | } | |
408da065 | 1900 | INFO("Destroyed directory for container \"%s\".", name); |
28272964 CB |
1901 | } |
1902 | ||
1903 | static int lxc_rmdir_onedev_wrapper(void *data) | |
1904 | { | |
1905 | char *arg = (char *) data; | |
1906 | return lxc_rmdir_onedev(arg, NULL); | |
1907 | } | |
1908 | ||
790255cf | 1909 | static bool do_destroy_container(struct lxc_handler *handler) { |
94b0a3ac CB |
1910 | int ret; |
1911 | ||
d0fbc7ba | 1912 | if (!handler->am_root) { |
94b0a3ac CB |
1913 | ret = userns_exec_full(handler->conf, storage_destroy_wrapper, |
1914 | handler->conf, "storage_destroy_wrapper"); | |
1915 | if (ret < 0) | |
d028235d | 1916 | return false; |
10bc1861 | 1917 | |
d028235d SG |
1918 | return true; |
1919 | } | |
10bc1861 | 1920 | |
790255cf | 1921 | return storage_destroy(handler->conf); |
28272964 | 1922 | } |