]> git.proxmox.com Git - mirror_lxc.git/blame - src/lxc/start.c
Fixed file descriptor leak for network namespace
[mirror_lxc.git] / src / lxc / start.c
CommitLineData
0ad19a3f 1/*
2 * lxc: linux Container library
3 *
4 * (C) Copyright IBM Corp. 2007, 2008
5 *
6 * Authors:
9afe19d6 7 * Daniel Lezcano <daniel.lezcano at free.fr>
35a02107
CB
8 * Serge Hallyn <serge@hallyn.com>
9 * Christian Brauner <christian.brauner@ubuntu.com>
0ad19a3f 10 *
11 * This library is free software; you can redistribute it and/or
12 * modify it under the terms of the GNU Lesser General Public
13 * License as published by the Free Software Foundation; either
14 * version 2.1 of the License, or (at your option) any later version.
15 *
16 * This library is distributed in the hope that it will be useful,
17 * but WITHOUT ANY WARRANTY; without even the implied warranty of
18 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
19 * Lesser General Public License for more details.
20 *
21 * You should have received a copy of the GNU Lesser General Public
22 * License along with this library; if not, write to the Free Software
250b1eec 23 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
0ad19a3f 24 */
25
d38dd64a
CB
26#ifndef _GNU_SOURCE
27#define _GNU_SOURCE 1
28#endif
0ad19a3f 29#include <dirent.h>
30#include <errno.h>
b0a33c1e 31#include <fcntl.h>
c476bdce 32#include <grp.h>
37515ebd 33#include <poll.h>
b467714b 34#include <pthread.h>
f3787121
CB
35#include <signal.h>
36#include <stdio.h>
37#include <stdlib.h>
38#include <string.h>
0ad19a3f 39#include <sys/file.h>
f4d507d5 40#include <sys/mount.h>
f3787121 41#include <sys/param.h>
0ad19a3f 42#include <sys/prctl.h>
f3787121
CB
43#include <sys/socket.h>
44#include <sys/stat.h>
45#include <sys/syscall.h>
ddceb1f9 46#include <sys/types.h>
b0a33c1e 47#include <sys/un.h>
f3787121 48#include <sys/wait.h>
d38dd64a 49#include <unistd.h>
495d2046 50
f3787121
CB
51#include "af_unix.h"
52#include "caps.h"
563f2f2c 53#include "cgroup.h"
f3787121 54#include "commands.h"
bbf5cf35 55#include "commands_utils.h"
f3787121 56#include "conf.h"
d38dd64a 57#include "config.h"
74c6e2b0 58#include "confile_utils.h"
e2bcd7db 59#include "error.h"
7fbb15ec 60#include "file_utils.h"
1cc8bd4b 61#include "list.h"
f3787121 62#include "log.h"
d38dd64a 63#include "lsm/lsm.h"
f2d5a09d 64#include "lxccontainer.h"
f3787121
CB
65#include "lxclock.h"
66#include "lxcseccomp.h"
3ef9b3d3 67#include "macro.h"
f3787121 68#include "mainloop.h"
4ffeaf27 69#include "memory_utils.h"
63376d7d 70#include "monitor.h"
f549edcc 71#include "namespace.h"
811ef482 72#include "network.h"
38e5c2db 73#include "raw_syscalls.h"
f3787121 74#include "start.h"
6be5397b
CB
75#include "storage/storage.h"
76#include "storage/storage_utils.h"
0ed9b1bc 77#include "sync.h"
59524108 78#include "syscall_wrappers.h"
0ed9b1bc
CB
79#include "terminal.h"
80#include "utils.h"
36eb9bde 81
d38dd64a
CB
82#if HAVE_LIBCAP
83#include <sys/capability.h>
84#endif
85
9de31d5a
CB
86#ifndef HAVE_STRLCPY
87#include "include/strlcpy.h"
88#endif
89
ac2cecc4 90lxc_log_define(start, lxc);
36eb9bde 91
f01f7975 92extern void mod_all_rdeps(struct lxc_container *c, bool inc);
790255cf 93static bool do_destroy_container(struct lxc_handler *handler);
28272964
CB
94static int lxc_rmdir_onedev_wrapper(void *data);
95static void lxc_destroy_container_on_signal(struct lxc_handler *handler,
96 const char *name);
97
c8154066
SH
98static void print_top_failing_dir(const char *path)
99{
dcd9a847 100 __do_free char *copy = NULL;
9e5f5f2f 101 int ret;
4ffeaf27 102 char *e, *p, saved;
cbb9c7c7 103
4ffeaf27 104 copy = must_copy_string(path);
c8154066 105 p = copy;
4ffeaf27 106 e = copy + strlen(path);
cbb9c7c7 107
c8154066 108 while (p < e) {
f3787121
CB
109 while (p < e && *p == '/')
110 p++;
9e5f5f2f 111
f3787121
CB
112 while (p < e && *p != '/')
113 p++;
9e5f5f2f 114
c8154066
SH
115 saved = *p;
116 *p = '\0';
9e5f5f2f
CB
117
118 ret = access(copy, X_OK);
119 if (ret != 0) {
408da065
CB
120 SYSERROR("Could not access %s. Please grant it x "
121 "access, or add an ACL for the container "
9e5f5f2f 122 "root", copy);
c8154066
SH
123 return;
124 }
125 *p = saved;
126 }
127}
128
5032bf39 129static void lxc_put_nsfds(struct lxc_handler *handler)
408da065 130{
9f30a190
MM
131 int i;
132
9f30a190 133 for (i = 0; i < LXC_NS_MAX; i++) {
5032bf39 134 if (handler->nsfd[i] < 0)
39cd919c
CB
135 continue;
136
5032bf39
CB
137 close(handler->nsfd[i]);
138 handler->nsfd[i] = -EBADF;
9f30a190 139 }
9f30a190
MM
140}
141
4cb53844
CB
142static int lxc_try_preserve_ns(const int pid, const char *ns)
143{
144 int fd;
145
146 fd = lxc_preserve_ns(pid, ns);
147 if (fd < 0) {
148 if (errno != ENOENT) {
149 SYSERROR("Failed to preserve %s namespace", ns);
150 return -EINVAL;
151 }
152
a24c5678 153 SYSWARN("Kernel does not support preserving %s namespaces", ns);
4cb53844
CB
154 return -EOPNOTSUPP;
155 }
156
157 return fd;
158}
159
160/* lxc_try_preserve_namespaces: open /proc/@pid/ns/@ns for each namespace
161 * specified in ns_clone_flags.
4d8ac866 162 * Return true on success, false on failure.
62d05d9b 163 */
4cb53844
CB
164static bool lxc_try_preserve_namespaces(struct lxc_handler *handler,
165 int ns_clone_flags, pid_t pid)
f3787121 166{
9fef3355 167 int i;
9f30a190 168
9f30a190 169 for (i = 0; i < LXC_NS_MAX; i++)
5032bf39 170 handler->nsfd[i] = -EBADF;
cd43d2d1 171
9f30a190 172 for (i = 0; i < LXC_NS_MAX; i++) {
4cb53844
CB
173 int fd;
174
becad0ec 175 if ((ns_clone_flags & ns_info[i].clone_flag) == 0)
9f30a190 176 continue;
28d9e29e 177
4cb53844
CB
178 fd = lxc_try_preserve_ns(pid, ns_info[i].proc_name);
179 if (fd < 0) {
4cb53844
CB
180 /* Do not fail to start container on kernels that do
181 * not support interacting with namespaces through
182 * /proc.
183 */
184 if (fd == -EOPNOTSUPP)
185 continue;
fa3a5b22 186
4cb53844
CB
187 lxc_put_nsfds(handler);
188 return false;
189 }
190
191 handler->nsfd[i] = fd;
192 DEBUG("Preserved %s namespace via fd %d", ns_info[i].proc_name,
193 handler->nsfd[i]);
9f30a190
MM
194 }
195
62d05d9b 196 return true;
9f30a190
MM
197}
198
ec1dc633 199static inline bool match_stdfds(int fd)
80090207 200{
ec1dc633 201 return (fd == STDIN_FILENO || fd == STDOUT_FILENO || fd == STDERR_FILENO);
80090207
CLG
202}
203
4c03724e 204#ifdef HAVE_DLOG
205static bool match_dlog_fds(struct dirent *direntp)
206{
207 char path[PATH_MAX] = {0};
208 char link[PATH_MAX] = {0};
209 ssize_t linklen;
210 int ret;
211
212 ret = snprintf(path, PATH_MAX, "/proc/self/fd/%s", direntp->d_name);
213 if (ret < 0 || ret >= PATH_MAX) {
214 ERROR("Failed to create file descriptor name");
215 return false;
216 }
217
218 linklen = readlink(path, link, PATH_MAX);
219 if (linklen < 0) {
220 SYSERROR("Failed to read link path - \"%s\"", path);
221 return false;
222 } else if (linklen >= PATH_MAX) {
223 ERROR("The name of link path is too long - \"%s\"", path);
224 return false;
225 }
226
227 if (strcmp(link, "/dev/log_main") == 0 ||
228 strcmp(link, "/dev/log_system") == 0 ||
229 strcmp(link, "/dev/log_radio") == 0)
230 return true;
231
232 return false;
233}
234#endif
235
47a46cf1
CB
236int lxc_check_inherited(struct lxc_conf *conf, bool closeall,
237 int *fds_to_ignore, size_t len_fds)
80090207 238{
80090207 239 int fd, fddir;
47a46cf1 240 size_t i;
80090207 241 DIR *dir;
a5a70219 242 struct dirent *direntp;
80090207 243
d2cf4c37
SH
244 if (conf && conf->close_all_fds)
245 closeall = true;
246
b119f362 247restart:
80090207
CLG
248 dir = opendir("/proc/self/fd");
249 if (!dir) {
a24c5678 250 SYSWARN("Failed to open directory");
80090207
CLG
251 return -1;
252 }
253
254 fddir = dirfd(dir);
255
74f96976 256 while ((direntp = readdir(dir))) {
a5a70219 257 int ret;
d39b10eb
CB
258 struct lxc_list *cur;
259 bool matched = false;
260
a5a70219 261 if (strcmp(direntp->d_name, ".") == 0)
80090207
CLG
262 continue;
263
a5a70219 264 if (strcmp(direntp->d_name, "..") == 0)
80090207
CLG
265 continue;
266
a5a70219
CB
267 ret = lxc_safe_int(direntp->d_name, &fd);
268 if (ret < 0) {
269 INFO("Could not parse file descriptor for \"%s\"", direntp->d_name);
d4cff0d2
CB
270 continue;
271 }
80090207 272
47a46cf1
CB
273 for (i = 0; i < len_fds; i++)
274 if (fds_to_ignore[i] == fd)
275 break;
276
277 if (fd == fddir || fd == lxc_log_fd ||
278 (i < len_fds && fd == fds_to_ignore[i]))
80090207
CLG
279 continue;
280
d39b10eb 281 /* Keep state clients that wait on reboots. */
3ee9e4fb
CB
282 if (conf) {
283 lxc_list_for_each(cur, &conf->state_clients) {
284 struct lxc_state_client *client = cur->elem;
d39b10eb 285
3ee9e4fb
CB
286 if (client->clientfd != fd)
287 continue;
d39b10eb 288
3ee9e4fb
CB
289 matched = true;
290 break;
291 }
d39b10eb
CB
292 }
293
294 if (matched)
295 continue;
296
858377e4
SH
297 if (current_config && fd == current_config->logfd)
298 continue;
299
ec1dc633 300 if (match_stdfds(fd))
80090207 301 continue;
80090207 302
1d5e5f26 303#ifdef HAVE_DLOG
304 if (match_dlog_fds(direntp))
305 continue;
306
307#endif
d2cf4c37 308 if (closeall) {
b119f362
SH
309 close(fd);
310 closedir(dir);
28d9e29e 311 INFO("Closed inherited fd %d", fd);
b119f362
SH
312 goto restart;
313 }
28d9e29e 314 WARN("Inherited fd %d", fd);
80090207
CLG
315 }
316
408da065 317 /* Only enable syslog at this point to avoid the above logging function
64c57ea1
BD
318 * to open a new fd and make the check_inherited function enter an
319 * infinite loop.
320 */
321 lxc_log_enable_syslog();
322
92c7f629
GK
323 closedir(dir); /* cannot fail */
324 return 0;
80090207
CLG
325}
326
83ee7875 327static int setup_signal_fd(sigset_t *oldmask)
b0a33c1e 328{
7288dfb6 329 int ret;
b0a33c1e 330 sigset_t mask;
7288dfb6 331 const int signals[] = {SIGBUS, SIGILL, SIGSEGV, SIGWINCH};
b0a33c1e 332
408da065 333 /* Block everything except serious error signals. */
df0795b1
CB
334 ret = sigfillset(&mask);
335 if (ret < 0)
336 return -EBADF;
337
9b10bef5 338 for (int sig = 0; sig < (sizeof(signals) / sizeof(signals[0])); sig++) {
df0795b1
CB
339 ret = sigdelset(&mask, signals[sig]);
340 if (ret < 0)
341 return -EBADF;
b0a33c1e 342 }
343
b467714b 344 ret = pthread_sigmask(SIG_BLOCK, &mask, oldmask);
df0795b1
CB
345 if (ret < 0) {
346 SYSERROR("Failed to set signal mask");
347 return -EBADF;
b0a33c1e 348 }
349
df0795b1
CB
350 ret = signalfd(-1, &mask, SFD_CLOEXEC);
351 if (ret < 0) {
352 SYSERROR("Failed to create signal file descriptor");
353 return -EBADF;
b0a33c1e 354 }
355
df0795b1 356 TRACE("Created signal file descriptor %d", ret);
1ac470c0 357
df0795b1 358 return ret;
b0a33c1e 359}
360
84c92abd 361static int signal_handler(int fd, uint32_t events, void *data,
f3787121 362 struct lxc_epoll_descr *descr)
b0a33c1e 363{
15cd25fd 364 int ret;
3c319edb
CB
365 siginfo_t info;
366 struct signalfd_siginfo siginfo;
367 struct lxc_handler *hdlr = data;
15cd25fd 368
489f39be 369 ret = lxc_read_nointr(fd, &siginfo, sizeof(siginfo));
15cd25fd 370 if (ret < 0) {
6e94162a 371 ERROR("Failed to read signal info from signal file descriptor %d", fd);
b2a48508 372 return LXC_MAINLOOP_ERROR;
15cd25fd
DL
373 }
374
375 if (ret != sizeof(siginfo)) {
6e94162a
CB
376 ERROR("Unexpected size for struct signalfd_siginfo");
377 return -EINVAL;
15cd25fd
DL
378 }
379
408da065 380 /* Check whether init is running. */
80507ee8 381 info.si_pid = 0;
3c319edb
CB
382 ret = waitid(P_PID, hdlr->pid, &info, WEXITED | WNOWAIT | WNOHANG);
383 if (ret == 0 && info.si_pid == hdlr->pid)
384 hdlr->init_died = true;
80507ee8 385
cd5177e9
TA
386 /* Try to figure out a reasonable exit status to report. */
387 if (hdlr->init_died) {
388 switch (info.si_code) {
389 case CLD_EXITED:
390 hdlr->exit_status = info.si_status << 8;
391 break;
392 case CLD_KILLED:
393 case CLD_DUMPED:
394 case CLD_STOPPED:
395 hdlr->exit_status = info.si_status << 8 | 0x7f;
396 break;
397 case CLD_CONTINUED:
398 /* Huh? The waitid() told us it's dead *and* continued? */
399 WARN("Init %d dead and continued?", hdlr->pid);
400 hdlr->exit_status = 1;
401 break;
402 default:
20993a97 403 ERROR("Unknown si_code: %d", info.si_code);
55e1311e 404 hdlr->exit_status = 1;
cd5177e9
TA
405 }
406 }
407
d4b5d7a8 408 if (siginfo.ssi_signo == SIGHUP) {
33942046
CB
409 if (hdlr->pidfd >= 0)
410 lxc_raw_pidfd_send_signal(hdlr->pidfd, SIGTERM, NULL, 0);
411 else if (hdlr->proc_pidfd >= 0)
d9bb2fba
CB
412 lxc_raw_pidfd_send_signal(hdlr->proc_pidfd, SIGTERM, NULL, 0);
413 else
414 kill(hdlr->pid, SIGTERM);
d4b5d7a8 415 INFO("Killing %d since terminal hung up", hdlr->pid);
9b10bef5
CB
416 return hdlr->init_died ? LXC_MAINLOOP_CLOSE
417 : LXC_MAINLOOP_CONTINUE;
d4b5d7a8
TA
418 }
419
9cb94384 420 if (siginfo.ssi_signo != SIGCHLD) {
33942046
CB
421 if (hdlr->pidfd >= 0)
422 lxc_raw_pidfd_send_signal(hdlr->pidfd,
423 siginfo.ssi_signo, NULL, 0);
424 else if (hdlr->proc_pidfd >= 0)
d9bb2fba
CB
425 lxc_raw_pidfd_send_signal(hdlr->proc_pidfd,
426 siginfo.ssi_signo, NULL, 0);
427 else
428 kill(hdlr->pid, siginfo.ssi_signo);
9cb94384 429 INFO("Forwarded signal %d to pid %d", siginfo.ssi_signo, hdlr->pid);
9b10bef5
CB
430 return hdlr->init_died ? LXC_MAINLOOP_CLOSE
431 : LXC_MAINLOOP_CONTINUE;
9cb94384
TA
432 }
433
3a9e949f
TA
434 /* More robustness, protect ourself from a SIGCHLD sent
435 * by a process different from the container init.
436 */
437 if (siginfo.ssi_pid != hdlr->pid) {
6e94162a
CB
438 NOTICE("Received %d from pid %d instead of container init %d",
439 siginfo.ssi_signo, siginfo.ssi_pid, hdlr->pid);
9b10bef5
CB
440 return hdlr->init_died ? LXC_MAINLOOP_CLOSE
441 : LXC_MAINLOOP_CONTINUE;
3a9e949f
TA
442 }
443
408da065 444 if (siginfo.ssi_code == CLD_STOPPED) {
6e94162a 445 INFO("Container init process was stopped");
9b10bef5
CB
446 return hdlr->init_died ? LXC_MAINLOOP_CLOSE
447 : LXC_MAINLOOP_CONTINUE;
448 }
449
450 if (siginfo.ssi_code == CLD_CONTINUED) {
6e94162a 451 INFO("Container init process was continued");
9b10bef5
CB
452 return hdlr->init_died ? LXC_MAINLOOP_CLOSE
453 : LXC_MAINLOOP_CONTINUE;
15cd25fd 454 }
1ac470c0 455
6e94162a 456 DEBUG("Container init process %d exited", hdlr->pid);
9b10bef5 457
3c319edb 458 return LXC_MAINLOOP_CLOSE;
b0a33c1e 459}
460
974a8aba
CB
461int lxc_serve_state_clients(const char *name, struct lxc_handler *handler,
462 lxc_state_t state)
66aeffc7 463{
9de31d5a 464 size_t retlen;
dbc9832d
CB
465 ssize_t ret;
466 struct lxc_list *cur, *next;
dbc9832d
CB
467 struct lxc_msg msg = {.type = lxc_msg_state, .value = state};
468
974a8aba
CB
469 if (state == THAWED)
470 handler->state = RUNNING;
471 else
472 handler->state = state;
473
9dfa4041 474 TRACE("Set container state to %s", lxc_state2str(state));
dbc9832d 475
d39b10eb 476 if (lxc_list_empty(&handler->conf->state_clients)) {
9dfa4041 477 TRACE("No state clients registered");
dbc9832d
CB
478 return 0;
479 }
480
9de31d5a
CB
481 retlen = strlcpy(msg.name, name, sizeof(msg.name));
482 if (retlen >= sizeof(msg.name))
483 return -E2BIG;
dbc9832d 484
d39b10eb 485 lxc_list_for_each_safe(cur, &handler->conf->state_clients, next) {
d85617bc 486 struct lxc_state_client *client = cur->elem;
dbc9832d 487
d39b10eb 488 if (client->states[state] == 0) {
9dfa4041 489 TRACE("State %s not registered for state client %d",
dbc9832d
CB
490 lxc_state2str(state), client->clientfd);
491 continue;
492 }
493
9dfa4041 494 TRACE("Sending state %s to state client %d",
dbc9832d
CB
495 lxc_state2str(state), client->clientfd);
496
7fbb15ec
CB
497 ret = lxc_send_nointr(client->clientfd, &msg, sizeof(msg), MSG_NOSIGNAL);
498 if (ret <= 0)
6d1400b5 499 SYSERROR("Failed to send message to client");
dbc9832d
CB
500
501 /* kick client from list */
dbc9832d 502 lxc_list_del(cur);
300d1cb4 503 close(client->clientfd);
dbc9832d
CB
504 free(cur->elem);
505 free(cur);
506 }
dbc9832d 507
5e5576a4
CB
508 return 0;
509}
510
511static int lxc_serve_state_socket_pair(const char *name,
512 struct lxc_handler *handler,
513 lxc_state_t state)
514{
515 ssize_t ret;
516
bb955810 517 if (!handler->daemonize ||
5e5576a4
CB
518 handler->state_socket_pair[1] < 0 ||
519 state == STARTING)
520 return 0;
521
522 /* Close read end of the socket pair. */
523 close(handler->state_socket_pair[0]);
524 handler->state_socket_pair[0] = -1;
525
ee8377bd 526again:
5e5576a4
CB
527 ret = lxc_abstract_unix_send_credential(handler->state_socket_pair[1],
528 &(int){state}, sizeof(int));
9044b79e 529 if (ret < 0) {
530 SYSERROR("Failed to send state to %d", handler->state_socket_pair[1]);
531
ee8377bd
CB
532 if (errno == EINTR)
533 goto again;
9044b79e 534
535 return -1;
536 }
537
538 if (ret != sizeof(int)) {
539 ERROR("Message too long : %d", handler->state_socket_pair[1]);
ee8377bd
CB
540 return -1;
541 }
5e5576a4
CB
542
543 TRACE("Sent container state \"%s\" to %d", lxc_state2str(state),
544 handler->state_socket_pair[1]);
545
546 /* Close write end of the socket pair. */
547 close(handler->state_socket_pair[1]);
548 handler->state_socket_pair[1] = -1;
549
550 return 0;
551}
552
553int lxc_set_state(const char *name, struct lxc_handler *handler,
554 lxc_state_t state)
555{
556 int ret;
557
558 ret = lxc_serve_state_socket_pair(name, handler, state);
559 if (ret < 0) {
560 ERROR("Failed to synchronize via anonymous pair of unix sockets");
561 return -1;
562 }
563
564 ret = lxc_serve_state_clients(name, handler, state);
565 if (ret < 0)
566 return -1;
567
dbc9832d
CB
568 /* This function will try to connect to the legacy lxc-monitord state
569 * server and only exists for backwards compatibility.
570 */
9123e471 571 lxc_monitor_send_state(name, state, handler->lxcpath);
dbc9832d 572
66aeffc7
DL
573 return 0;
574}
575
735f2c6e 576int lxc_poll(const char *name, struct lxc_handler *handler)
b0a33c1e 577{
3c319edb 578 int ret;
86530b0a 579 bool has_console = true;
3c319edb 580 struct lxc_epoll_descr descr, descr_console;
b0a33c1e 581
03760215
CB
582 if (handler->conf->console.path &&
583 strcmp(handler->conf->console.path, "none") == 0)
86530b0a
L
584 has_console = false;
585
3c319edb
CB
586 ret = lxc_mainloop_open(&descr);
587 if (ret < 0) {
588 ERROR("Failed to create mainloop");
50c8bf05 589 goto out_sigfd;
b0a33c1e 590 }
591
30a33fbd
CB
592 if (has_console) {
593 ret = lxc_mainloop_open(&descr_console);
594 if (ret < 0) {
595 ERROR("Failed to create console mainloop");
596 goto out_mainloop;
597 }
3c319edb
CB
598 }
599
1cc8bd4b 600 ret = lxc_mainloop_add_handler(&descr, handler->sigfd, signal_handler, handler);
3c319edb 601 if (ret < 0) {
1cc8bd4b 602 ERROR("Failed to add signal handler for %d to mainloop", handler->sigfd);
3c319edb 603 goto out_mainloop_console;
b0a33c1e 604 }
605
2ac0f627
CB
606 ret = lxc_seccomp_setup_proxy(&handler->conf->seccomp, &descr, handler);
607 if (ret < 0) {
608 ERROR("Failed to setup seccomp proxy");
c3e3c21a 609 goto out_mainloop_console;
2ac0f627 610 }
cdb2a47f 611
30a33fbd 612 if (has_console) {
dcad02f8 613 struct lxc_terminal *console = &handler->conf->console;
63376d7d 614
093bce5f 615 ret = lxc_terminal_mainloop_add(&descr, console);
30a33fbd
CB
616 if (ret < 0) {
617 ERROR("Failed to add console handlers to mainloop");
618 goto out_mainloop_console;
619 }
620
093bce5f 621 ret = lxc_terminal_mainloop_add(&descr_console, console);
30a33fbd
CB
622 if (ret < 0) {
623 ERROR("Failed to add console handlers to console mainloop");
624 goto out_mainloop_console;
625 }
a54585ad
L
626
627 handler->conf->console.descr = &descr;
563f2f2c
DL
628 }
629
3c319edb
CB
630 ret = lxc_cmd_mainloop_add(name, &descr, handler);
631 if (ret < 0) {
632 ERROR("Failed to add command handler to mainloop");
633 goto out_mainloop_console;
634 }
b0a33c1e 635
3c319edb 636 TRACE("Mainloop is ready");
b0a33c1e 637
3c319edb 638 ret = lxc_mainloop(&descr, -1);
1cc8bd4b
CB
639 close(descr.epfd);
640 descr.epfd = -EBADF;
641 if (ret < 0 || !handler->init_died)
42b09f94 642 goto out_mainloop_console;
1cc8bd4b 643
30a33fbd
CB
644 if (has_console)
645 ret = lxc_mainloop(&descr_console, 0);
646
3c319edb 647out_mainloop_console:
30a33fbd
CB
648 if (has_console) {
649 lxc_mainloop_close(&descr_console);
650 TRACE("Closed console mainloop");
651 }
3c319edb 652
42b09f94
CB
653out_mainloop:
654 lxc_mainloop_close(&descr);
655 TRACE("Closed mainloop");
656
b0a33c1e 657out_sigfd:
1cc8bd4b
CB
658 close(handler->sigfd);
659 TRACE("Closed signal file descriptor %d", handler->sigfd);
660 handler->sigfd = -EBADF;
408da065 661
1cc8bd4b 662 return ret;
b0a33c1e 663}
664
41784e4e
CB
665void lxc_zero_handler(struct lxc_handler *handler)
666{
667 int i;
668
669 memset(handler, 0, sizeof(struct lxc_handler));
670
41784e4e
CB
671 handler->pinfd = -1;
672
33942046
CB
673 handler->pidfd = -EBADF;
674
d9bb2fba
CB
675 handler->proc_pidfd = -EBADF;
676
41784e4e
CB
677 handler->sigfd = -1;
678
679 for (i = 0; i < LXC_NS_MAX; i++)
680 handler->nsfd[i] = -1;
681
682 handler->data_sock[0] = -1;
683 handler->data_sock[1] = -1;
684
685 handler->state_socket_pair[0] = -1;
686 handler->state_socket_pair[1] = -1;
687
688 handler->sync_sock[0] = -1;
689 handler->sync_sock[1] = -1;
690}
691
f2e07cb6
CB
692void lxc_free_handler(struct lxc_handler *handler)
693{
1cc8bd4b
CB
694 if (handler->pinfd >= 0)
695 close(handler->pinfd);
696
33942046
CB
697 if (handler->pidfd >= 0)
698 close(handler->pidfd);
699
d9bb2fba
CB
700 if (handler->proc_pidfd >= 0)
701 close(handler->proc_pidfd);
702
1cc8bd4b
CB
703 if (handler->sigfd >= 0)
704 close(handler->sigfd);
705
706 lxc_put_nsfds(handler);
707
80308d07 708 if (handler->conf && handler->conf->reboot == REBOOT_NONE)
0d0d3655 709 if (handler->conf->maincmd_fd >= 0)
9044b79e 710 lxc_abstract_unix_close(handler->conf->maincmd_fd);
f2e07cb6 711
5e5576a4
CB
712 if (handler->state_socket_pair[0] >= 0)
713 close(handler->state_socket_pair[0]);
714
715 if (handler->state_socket_pair[1] >= 0)
716 close(handler->state_socket_pair[1]);
717
9b10bef5
CB
718 if (handler->cgroup_ops)
719 cgroup_exit(handler->cgroup_ops);
720
f2e07cb6
CB
721 handler->conf = NULL;
722 free(handler);
1cc8bd4b 723 handler = NULL;
f2e07cb6
CB
724}
725
aa460476 726struct lxc_handler *lxc_init_handler(const char *name, struct lxc_conf *conf,
5e5576a4 727 const char *lxcpath, bool daemonize)
59eb99ba 728{
5e5576a4 729 int i, ret;
3a0f472d
DL
730 struct lxc_handler *handler;
731
732 handler = malloc(sizeof(*handler));
fdecbc9c 733 if (!handler)
3a0f472d 734 return NULL;
9044b79e 735
59eb99ba
DL
736 memset(handler, 0, sizeof(*handler));
737
fdecbc9c
CB
738 /* Note that am_guest_unpriv() checks the effective uid. We
739 * probably don't care if we are real root only if we are running
740 * as root so this should be fine.
790255cf 741 */
e0010464 742 handler->am_root = !am_guest_unpriv();
c6012571 743 handler->data_sock[0] = handler->data_sock[1] = -1;
fae349da 744 handler->conf = conf;
9123e471 745 handler->lxcpath = lxcpath;
5c068da9 746 handler->pinfd = -1;
33942046 747 handler->pidfd = -EBADF;
d9bb2fba 748 handler->proc_pidfd = -EBADF;
1cc8bd4b
CB
749 handler->sigfd = -EBADF;
750 handler->init_died = false;
5e5576a4 751 handler->state_socket_pair[0] = handler->state_socket_pair[1] = -1;
80308d07 752 if (handler->conf->reboot == REBOOT_NONE)
d39b10eb 753 lxc_list_init(&handler->conf->state_clients);
fae349da 754
b6b2b194
WB
755 for (i = 0; i < LXC_NS_MAX; i++)
756 handler->nsfd[i] = -1;
757
f0ecc19d 758 handler->name = name;
3bdf52d7 759
80308d07 760 if (daemonize && handler->conf->reboot == REBOOT_NONE) {
5e5576a4 761 /* Create socketpair() to synchronize on daemonized startup.
fdecbc9c
CB
762 * When the container reboots we don't need to synchronize
763 * again currently so don't open another socketpair().
5e5576a4
CB
764 */
765 ret = socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0,
766 handler->state_socket_pair);
767 if (ret < 0) {
768 ERROR("Failed to create anonymous pair of unix sockets");
769 goto on_error;
770 }
9044b79e 771
5e5576a4
CB
772 TRACE("Created anonymous pair {%d,%d} of unix sockets",
773 handler->state_socket_pair[0],
774 handler->state_socket_pair[1]);
775 }
776
80308d07 777 if (handler->conf->reboot == REBOOT_NONE) {
d39b10eb
CB
778 handler->conf->maincmd_fd = lxc_cmd_init(name, lxcpath, "command");
779 if (handler->conf->maincmd_fd < 0) {
780 ERROR("Failed to set up command socket");
781 goto on_error;
782 }
aa460476 783 }
9044b79e 784
9dfa4041 785 TRACE("Unix domain socket %d for command server is ready",
aa460476
CB
786 handler->conf->maincmd_fd);
787
788 return handler;
789
f2e07cb6
CB
790on_error:
791 lxc_free_handler(handler);
aa460476
CB
792
793 return NULL;
794}
795
796int lxc_init(const char *name, struct lxc_handler *handler)
797{
a2c09be0 798 int ret;
4a03ded4 799 const char *loglevel;
aa460476
CB
800 struct lxc_conf *conf = handler->conf;
801
434c8e15
CB
802 handler->monitor_pid = lxc_raw_getpid();
803
aa460476 804 lsm_init();
2170b263 805 TRACE("Initialized LSM");
d2e30e99 806
2170b263
CB
807 ret = lxc_read_seccomp_config(conf);
808 if (ret < 0) {
809 ERROR("Failed loading seccomp policy");
d2e30e99 810 goto out_close_maincmd_fd;
8f2c3a70 811 }
2170b263 812 TRACE("Read seccomp policy");
8f2c3a70 813
408da065 814 /* Begin by setting the state to STARTING. */
2170b263
CB
815 ret = lxc_set_state(name, handler, STARTING);
816 if (ret < 0) {
817 ERROR("Failed to set state to \"%s\"", lxc_state2str(STARTING));
051151de 818 goto out_close_maincmd_fd;
0ad19a3f 819 }
46800e77 820 TRACE("Set container state to \"STARTING\"");
0ad19a3f 821
408da065 822 /* Start of environment variable setup for hooks. */
24c2a48d
CB
823 ret = setenv("LXC_NAME", name, 1);
824 if (ret < 0)
825 SYSERROR("Failed to set environment variable: LXC_NAME=%s", name);
408da065 826
2170b263
CB
827 if (conf->rcfile) {
828 ret = setenv("LXC_CONFIG_FILE", conf->rcfile, 1);
829 if (ret < 0)
830 SYSERROR("Failed to set environment variable: "
831 "LXC_CONFIG_FILE=%s", conf->rcfile);
832 }
408da065 833
2170b263
CB
834 if (conf->rootfs.mount) {
835 ret = setenv("LXC_ROOTFS_MOUNT", conf->rootfs.mount, 1);
836 if (ret < 0)
837 SYSERROR("Failed to set environment variable: "
838 "LXC_ROOTFS_MOUNT=%s", conf->rootfs.mount);
839 }
408da065 840
2170b263
CB
841 if (conf->rootfs.path) {
842 ret = setenv("LXC_ROOTFS_PATH", conf->rootfs.path, 1);
843 if (ret < 0)
844 SYSERROR("Failed to set environment variable: "
845 "LXC_ROOTFS_PATH=%s", conf->rootfs.path);
846 }
408da065 847
2170b263
CB
848 if (conf->console.path) {
849 ret = setenv("LXC_CONSOLE", conf->console.path, 1);
850 if (ret < 0)
851 SYSERROR("Failed to set environment variable: "
852 "LXC_CONSOLE=%s", conf->console.path);
853 }
408da065 854
2170b263
CB
855 if (conf->console.log_path) {
856 ret = setenv("LXC_CONSOLE_LOGPATH", conf->console.log_path, 1);
857 if (ret < 0)
858 SYSERROR("Failed to set environment variable: "
859 "LXC_CONSOLE_LOGPATH=%s", conf->console.log_path);
860 }
408da065 861
2170b263
CB
862 if (cgns_supported()) {
863 ret = setenv("LXC_CGNS_AWARE", "1", 1);
864 if (ret < 0)
865 SYSERROR("Failed to set environment variable "
866 "LXC_CGNS_AWARE=1");
867 }
b8f88d9b 868
4a03ded4 869 loglevel = lxc_log_priority_to_string(lxc_log_get_level());
2170b263
CB
870 ret = setenv("LXC_LOG_LEVEL", loglevel, 1);
871 if (ret < 0)
872 SYSERROR("Set environment variable LXC_LOG_LEVEL=%s",
873 loglevel);
a2c09be0
CB
874
875 if (conf->hooks_version == 0)
876 ret = setenv("LXC_HOOK_VERSION", "0", 1);
877 else
878 ret = setenv("LXC_HOOK_VERSION", "1", 1);
879 if (ret < 0)
880 SYSERROR("Failed to set environment variable LXC_HOOK_VERSION=%u", conf->hooks_version);
408da065 881 /* End of environment variable setup for hooks. */
f7bee6c6 882
2170b263 883 TRACE("Set environment variables");
dbc9832d 884
2170b263
CB
885 ret = run_lxc_hooks(name, "pre-start", conf, NULL);
886 if (ret < 0) {
887 ERROR("Failed to run lxc.hook.pre-start for container \"%s\"", name);
773fb9ca
SH
888 goto out_aborting;
889 }
2170b263 890 TRACE("Ran pre-start hooks");
26ddeedd 891
408da065
CB
892 /* The signal fd has to be created before forking otherwise if the child
893 * process exits before we setup the signal fd, the event will be lost
894 * and the command will be stuck.
895 */
83ee7875 896 handler->sigfd = setup_signal_fd(&handler->oldmask);
59eb99ba 897 if (handler->sigfd < 0) {
408da065 898 ERROR("Failed to setup SIGCHLD fd handler.");
b5159817
DE
899 goto out_delete_tty;
900 }
2170b263 901 TRACE("Set up signal fd");
b5159817 902
408da065 903 /* Do this after setting up signals since it might unblock SIGWINCH. */
564e31c4 904 ret = lxc_terminal_setup(conf);
4d1ffb0a
CB
905 if (ret < 0) {
906 ERROR("Failed to create console");
b5159817 907 goto out_restore_sigmask;
b0a33c1e 908 }
4d1ffb0a 909 TRACE("Created console");
b0a33c1e 910
2f835b4b 911 ret = lxc_terminal_map_ids(conf, &conf->console);
7cfeddd7 912 if (ret < 0) {
2170b263 913 ERROR("Failed to chown console");
5b74eb3c 914 goto out_delete_terminal;
c4d10a05 915 }
2170b263 916 TRACE("Chowned console");
c4d10a05 917
5a087e05 918 handler->cgroup_ops = cgroup_init(handler->conf);
2202afc9
CB
919 if (!handler->cgroup_ops) {
920 ERROR("Failed to initialize cgroup driver");
5b74eb3c 921 goto out_delete_terminal;
2202afc9
CB
922 }
923 TRACE("Initialized cgroup driver");
924
1800f924
WB
925 ret = lsm_process_prepare(conf, handler->lxcpath);
926 if (ret < 0) {
927 ERROR("Failed to initialize LSM");
928 goto out_destroy_cgroups;
929 }
930 TRACE("Initialized LSM");
931
2170b263 932 INFO("Container \"%s\" is initialized", name);
aa460476 933 return 0;
59eb99ba 934
1800f924 935out_destroy_cgroups:
434c8e15
CB
936 handler->cgroup_ops->payload_destroy(handler->cgroup_ops, handler);
937 handler->cgroup_ops->monitor_destroy(handler->cgroup_ops, handler);
1800f924 938
5b74eb3c
CB
939out_delete_terminal:
940 lxc_terminal_delete(&handler->conf->console);
ea918412 941
b5159817 942out_restore_sigmask:
4c496daa 943 (void)pthread_sigmask(SIG_SETMASK, &handler->oldmask, NULL);
ea918412 944
59eb99ba 945out_delete_tty:
0e4be3cf 946 lxc_delete_tty(&conf->ttys);
ea918412 947
59eb99ba 948out_aborting:
4c496daa 949 (void)lxc_set_state(name, handler, ABORTING);
ea918412 950
d2e30e99 951out_close_maincmd_fd:
9044b79e 952 lxc_abstract_unix_close(conf->maincmd_fd);
d2e30e99 953 conf->maincmd_fd = -1;
aa460476 954 return -1;
59eb99ba
DL
955}
956
3b72c4a0 957void lxc_fini(const char *name, struct lxc_handler *handler)
59eb99ba 958{
c097467f 959 int i, ret;
18b3b9c1 960 pid_t self;
dbc9832d 961 struct lxc_list *cur, *next;
dbc9832d 962 char *namespaces[LXC_NS_MAX + 1];
b3286b62 963 size_t namespace_count = 0;
2202afc9 964 struct cgroup_ops *cgroup_ops = handler->cgroup_ops;
b6b2b194 965
408da065
CB
966 /* The STOPPING state is there for future cleanup code which can take
967 * awhile.
59eb99ba 968 */
25c2aca5 969 lxc_set_state(name, handler, STOPPING);
b6b2b194 970
0059379f 971 self = lxc_raw_getpid();
b3286b62 972 for (i = 0; i < LXC_NS_MAX; i++) {
18b3b9c1
CB
973 if (handler->nsfd[i] < 0)
974 continue;
975
976 if (handler->conf->hooks_version == 0)
c097467f 977 ret = asprintf(&namespaces[namespace_count],
18b3b9c1
CB
978 "%s:/proc/%d/fd/%d", ns_info[i].proc_name,
979 self, handler->nsfd[i]);
980 else
c097467f 981 ret = asprintf(&namespaces[namespace_count],
18b3b9c1 982 "/proc/%d/fd/%d", self, handler->nsfd[i]);
c097467f
CB
983 if (ret == -1) {
984 SYSERROR("Failed to allocate memory");
18b3b9c1 985 break;
b3286b62 986 }
18b3b9c1
CB
987
988 if (handler->conf->hooks_version == 0) {
989 namespace_count++;
990 continue;
991 }
992
c097467f
CB
993 ret = setenv(ns_info[i].env_name, namespaces[namespace_count], 1);
994 if (ret < 0)
18b3b9c1
CB
995 SYSERROR("Failed to set environment variable %s=%s",
996 ns_info[i].env_name, namespaces[namespace_count]);
997 else
998 TRACE("Set environment variable %s=%s",
999 ns_info[i].env_name, namespaces[namespace_count]);
1000
1001 namespace_count++;
b3286b62
WB
1002 }
1003 namespaces[namespace_count] = NULL;
c154af98 1004
80308d07 1005 if (handler->conf->reboot > REBOOT_NONE) {
c097467f
CB
1006 ret = setenv("LXC_TARGET", "reboot", 1);
1007 if (ret < 0)
1008 SYSERROR("Failed to set environment variable: "
1009 "LXC_TARGET=reboot");
1010 }
408da065 1011
80308d07 1012 if (handler->conf->reboot == REBOOT_NONE) {
c097467f
CB
1013 ret = setenv("LXC_TARGET", "stop", 1);
1014 if (ret < 0)
1015 SYSERROR("Failed to set environment variable: "
1016 "LXC_TARGET=stop");
1017 }
c154af98 1018
18b3b9c1 1019 if (handler->conf->hooks_version == 0)
c097467f 1020 ret = run_lxc_hooks(name, "stop", handler->conf, namespaces);
18b3b9c1 1021 else
c097467f
CB
1022 ret = run_lxc_hooks(name, "stop", handler->conf, NULL);
1023 if (ret < 0)
1024 ERROR("Failed to run \"lxc.hook.stop\" hook");
c154af98 1025
b3286b62
WB
1026 while (namespace_count--)
1027 free(namespaces[namespace_count]);
28d9e29e 1028
1800f924
WB
1029 lsm_process_cleanup(handler->conf, handler->lxcpath);
1030
434c8e15
CB
1031 cgroup_ops->payload_destroy(cgroup_ops, handler);
1032 cgroup_ops->monitor_destroy(cgroup_ops, handler);
4288b79f 1033
80308d07 1034 if (handler->conf->reboot == REBOOT_NONE) {
f893d898
CB
1035 /* For all new state clients simply close the command socket.
1036 * This will inform all state clients that the container is
1037 * STOPPED and also prevents a race between a open()/close() on
1038 * the command socket causing a new process to get ECONNREFUSED
1039 * because we haven't yet closed the command socket.
1040 */
9044b79e 1041 lxc_abstract_unix_close(handler->conf->maincmd_fd);
d39b10eb 1042 handler->conf->maincmd_fd = -1;
c3184275
CB
1043 TRACE("Closed command socket");
1044
1045 /* This function will try to connect to the legacy lxc-monitord
1046 * state server and only exists for backwards compatibility.
1047 */
1048 lxc_monitor_send_state(name, STOPPED, handler->lxcpath);
1049
1050 /* The command socket is closed so no one can acces the command
1051 * socket anymore so there's no need to lock it.
1052 */
1053 handler->state = STOPPED;
1054 TRACE("Set container state to \"STOPPED\"");
f893d898
CB
1055 } else {
1056 lxc_set_state(name, handler, STOPPED);
d39b10eb 1057 }
4288b79f 1058
048493a3
CB
1059 /* Avoid lingering namespace references. */
1060 lxc_put_nsfds(handler);
1061
46800e77
CB
1062 ret = run_lxc_hooks(name, "post-stop", handler->conf, NULL);
1063 if (ret < 0) {
c097467f 1064 ERROR("Failed to run lxc.hook.post-stop for container \"%s\"", name);
80308d07 1065 if (handler->conf->reboot > REBOOT_NONE) {
c097467f 1066 WARN("Container will be stopped instead of rebooted");
80308d07 1067 handler->conf->reboot = REBOOT_NONE;
c097467f
CB
1068
1069 ret = setenv("LXC_TARGET", "stop", 1);
1070 if (ret < 0)
1071 WARN("Failed to set environment variable: "
1072 "LXC_TARGET=stop");
f3787121
CB
1073 }
1074 }
26ddeedd 1075
408da065 1076 /* Reset mask set by setup_signal_fd. */
b467714b 1077 ret = pthread_sigmask(SIG_SETMASK, &handler->oldmask, NULL);
c097467f 1078 if (ret < 0)
a24c5678 1079 SYSWARN("Failed to restore signal mask");
8f64a3f6 1080
2aac071b 1081 lxc_terminal_delete(&handler->conf->console);
0e4be3cf 1082 lxc_delete_tty(&handler->conf->ttys);
dbc9832d 1083
dbc9832d
CB
1084 /* The command socket is now closed, no more state clients can register
1085 * themselves from now on. So free the list of state clients.
1086 */
d39b10eb
CB
1087 lxc_list_for_each_safe(cur, &handler->conf->state_clients, next) {
1088 struct lxc_state_client *client = cur->elem;
1089
1090 /* Keep state clients that want to be notified about reboots. */
80308d07
CB
1091 if ((handler->conf->reboot > REBOOT_NONE) &&
1092 (client->states[RUNNING] == 2))
d39b10eb
CB
1093 continue;
1094
dbc9832d 1095 /* close state client socket */
dbc9832d 1096 lxc_list_del(cur);
c097467f 1097 close(client->clientfd);
dbc9832d
CB
1098 free(cur->elem);
1099 free(cur);
1100 }
1101
80308d07 1102 if (handler->conf->ephemeral == 1 && handler->conf->reboot != REBOOT_REQ)
28272964 1103 lxc_destroy_container_on_signal(handler, name);
2c5f2ede 1104
1cc8bd4b 1105 lxc_free_handler(handler);
59eb99ba
DL
1106}
1107
735f2c6e 1108void lxc_abort(const char *name, struct lxc_handler *handler)
59eb99ba 1109{
33942046
CB
1110 int ret = 0;
1111 int status;
73e608b2 1112
25c2aca5 1113 lxc_set_state(name, handler, ABORTING);
0e4f9d51 1114
33942046
CB
1115 if (handler->pidfd > 0)
1116 ret = lxc_raw_pidfd_send_signal(handler->pidfd, SIGKILL, NULL, 0);
1117 else if (handler->proc_pidfd > 0)
d9bb2fba 1118 ret = lxc_raw_pidfd_send_signal(handler->proc_pidfd, SIGKILL, NULL, 0);
33942046
CB
1119 else if (handler->pid > 0)
1120 ret = kill(handler->pid, SIGKILL);
1121 if (ret < 0)
1122 SYSERROR("Failed to send SIGKILL to %d", handler->pid);
0e4f9d51 1123
33942046
CB
1124 do {
1125 ret = waitpid(-1, &status, 0);
1126 } while (ret > 0);
59eb99ba
DL
1127}
1128
ffe1e01a 1129static int do_start(void *data)
50e98013 1130{
cdb2a47f 1131 struct lxc_handler *handler = data;
eab649dc
CB
1132 ATTR_UNUSED __do_close_prot_errno int data_sock0 = handler->data_sock[0],
1133 data_sock1 = handler->data_sock[1];
8bf3abfb 1134 int ret;
7a55c157 1135 char path[PATH_MAX];
928b1f04
YT
1136 uid_t new_uid;
1137 gid_t new_gid;
e96a536c 1138 struct lxc_list *iterator;
964581c2
CB
1139 uid_t nsuid = 0;
1140 gid_t nsgid = 0;
5af9369b 1141 int devnull_fd = -1;
50e98013 1142
18225d19 1143 lxc_sync_fini_parent(handler);
50e98013 1144
408da065
CB
1145 /* This prctl must be before the synchro, so if the parent dies before
1146 * we set the parent death signal, we will detect its death with the
1147 * synchro right after, otherwise we have a window where the parent can
1148 * exit before we set the pdeath signal leading to a unsupervized
1149 * container.
743ecd2e 1150 */
b765aa88 1151 ret = lxc_set_death_signal(SIGKILL, handler->monitor_pid);
912314fc
CB
1152 if (ret < 0) {
1153 SYSERROR("Failed to set PR_SET_PDEATHSIG to SIGKILL");
18225d19 1154 goto out_warn_father;
743ecd2e
DL
1155 }
1156
611ddd34
CB
1157 ret = lxc_ambient_caps_up();
1158 if (ret < 0) {
6f5e532f 1159 ERROR("Failed to raise ambient capabilities");
611ddd34
CB
1160 goto out_warn_father;
1161 }
1162
b467714b 1163 ret = pthread_sigmask(SIG_SETMASK, &handler->oldmask, NULL);
18225d19
CB
1164 if (ret < 0) {
1165 SYSERROR("Failed to set signal mask");
1166 goto out_warn_father;
1167 }
50e98013 1168
408da065 1169 /* Don't leak the pinfd to the container. */
d39b10eb 1170 if (handler->pinfd >= 0)
0d03360a 1171 close(handler->pinfd);
2b0e17e4 1172
18225d19
CB
1173 ret = lxc_sync_wait_parent(handler, LXC_SYNC_STARTUP);
1174 if (ret < 0)
1175 goto out_warn_father;
5b1e83cb 1176
408da065
CB
1177 /* Unshare CLONE_NEWNET after CLONE_NEWUSER. See
1178 * https://github.com/lxc/lxd/issues/1978.
1179 */
becad0ec 1180 if ((handler->ns_clone_flags & (CLONE_NEWNET | CLONE_NEWUSER)) ==
408da065 1181 (CLONE_NEWNET | CLONE_NEWUSER)) {
5b1e83cb
SH
1182 ret = unshare(CLONE_NEWNET);
1183 if (ret < 0) {
e96a536c 1184 SYSERROR("Failed to unshare CLONE_NEWNET");
5b1e83cb
SH
1185 goto out_warn_father;
1186 }
e96a536c 1187 INFO("Unshared CLONE_NEWNET");
5b1e83cb
SH
1188 }
1189
408da065
CB
1190 /* Tell the parent task it can begin to configure the container and wait
1191 * for it to finish.
3c22086f 1192 */
e96a536c
CB
1193 ret = lxc_sync_barrier_parent(handler, LXC_SYNC_CONFIGURE);
1194 if (ret < 0)
611ddd34 1195 goto out_error;
50e98013 1196
e96a536c
CB
1197 ret = lxc_network_recv_veth_names_from_parent(handler);
1198 if (ret < 0) {
7ab1ba02 1199 ERROR("Failed to receive veth names from parent");
658979c5 1200 goto out_warn_father;
7ab1ba02 1201 }
658979c5 1202
408da065 1203 /* If we are in a new user namespace, become root there to have
d08f8d2f 1204 * privilege over our namespace.
f6d3e3e4
SH
1205 */
1206 if (!lxc_list_empty(&handler->conf->id_map)) {
964581c2
CB
1207 if (!handler->conf->root_nsuid_map)
1208 nsuid = handler->conf->init_uid;
1209
1210 if (!handler->conf->root_nsgid_map)
1211 nsgid = handler->conf->init_gid;
4160c3a0 1212
464c4611 1213 if (!lxc_switch_uid_gid(nsuid, nsgid))
f6d3e3e4 1214 goto out_warn_father;
d08f8d2f
CB
1215
1216 /* Drop groups only after we switched to a valid gid in the new
1217 * user namespace.
1218 */
8af07f82
CB
1219 if (!lxc_setgroups(0, NULL) &&
1220 (handler->am_root || errno != EPERM))
c476bdce 1221 goto out_warn_father;
4b826b1f 1222
b81689a1
CB
1223 ret = prctl(PR_SET_DUMPABLE, prctl_arg(1), prctl_arg(0),
1224 prctl_arg(0), prctl_arg(0));
d7883725
CB
1225 if (ret < 0)
1226 goto out_warn_father;
912314fc
CB
1227
1228 /* set{g,u}id() clears deathsignal */
f08a5cc4 1229 ret = lxc_set_death_signal(SIGKILL, handler->monitor_pid);
912314fc
CB
1230 if (ret < 0) {
1231 SYSERROR("Failed to set PR_SET_PDEATHSIG to SIGKILL");
1232 goto out_warn_father;
1233 }
f6d3e3e4
SH
1234 }
1235
e96a536c
CB
1236 ret = access(handler->lxcpath, X_OK);
1237 if (ret != 0) {
c8154066
SH
1238 print_top_failing_dir(handler->lxcpath);
1239 goto out_warn_father;
1240 }
1241
e96a536c
CB
1242 ret = snprintf(path, sizeof(path), "%s/dev/null",
1243 handler->conf->rootfs.mount);
408da065 1244 if (ret < 0 || ret >= sizeof(path))
7a55c157 1245 goto out_warn_father;
7a55c157
TA
1246
1247 /* In order to checkpoint restore, we need to have everything in the
1248 * same mount namespace. However, some containers may not have a
1249 * reasonable /dev (in particular, they may not have /dev/null), so we
1250 * can't set init's std fds to /dev/null by opening it from inside the
1251 * container.
1252 *
1253 * If that's the case, fall back to using the host's /dev/null. This
1254 * means that migration won't work, but at least we won't spew output
1255 * where it isn't wanted.
1256 */
bb955810 1257 if (handler->daemonize && !handler->conf->autodev) {
e96a536c
CB
1258 ret = access(path, F_OK);
1259 if (ret != 0) {
1260 devnull_fd = open_devnull();
c44de748 1261
e96a536c
CB
1262 if (devnull_fd < 0)
1263 goto out_warn_father;
1264 WARN("Using /dev/null from the host for container "
1265 "init's standard file descriptors. Migration will "
1266 "not work");
1267 }
c44de748
AM
1268 }
1269
408da065 1270 /* Ask father to setup cgroups and wait for him to finish. */
e96a536c
CB
1271 ret = lxc_sync_barrier_parent(handler, LXC_SYNC_CGROUP);
1272 if (ret < 0)
c44de748 1273 goto out_error;
544a48a0 1274
deefdf8a
CB
1275 /* Unshare cgroup namespace after we have setup our cgroups. If we do it
1276 * earlier we end up with a wrong view of /proc/self/cgroup. For
1277 * example, assume we unshare(CLONE_NEWCGROUP) first, and then create
1278 * the cgroup for the container, say /sys/fs/cgroup/cpuset/lxc/c, then
1279 * /proc/self/cgroup would show us:
1280 *
1281 * 8:cpuset:/lxc/c
1282 *
1283 * whereas it should actually show
1284 *
1285 * 8:cpuset:/
1286 */
becad0ec 1287 if (handler->ns_clone_flags & CLONE_NEWCGROUP) {
e96a536c
CB
1288 ret = unshare(CLONE_NEWCGROUP);
1289 if (ret < 0) {
bca7c59c
CB
1290 if (errno != EINVAL) {
1291 SYSERROR("Failed to unshare CLONE_NEWCGROUP");
1292 goto out_warn_father;
1293 }
1294
1295 handler->ns_clone_flags &= ~CLONE_NEWCGROUP;
1296 SYSINFO("Kernel does not support CLONE_NEWCGROUP");
1297 } else {
1298 INFO("Unshared CLONE_NEWCGROUP");
deefdf8a 1299 }
deefdf8a
CB
1300 }
1301
149857af
CB
1302 /* Add the requested environment variables to the current environment to
1303 * allow them to be used by the various hooks, such as the start hook
1304 * above.
98ff08ca 1305 */
98ff08ca 1306 lxc_list_for_each(iterator, &handler->conf->environment) {
e96a536c
CB
1307 ret = putenv((char *)iterator->elem);
1308 if (ret < 0) {
1309 SYSERROR("Failed to set environment variable: %s",
1310 (char *)iterator->elem);
98ff08ca
CB
1311 goto out_warn_father;
1312 }
1313 }
1314
f4152036 1315 /* Setup the container, ip, names, utsname, ... */
3b988b33 1316 ret = lxc_setup(handler);
7729f8e5 1317 if (ret < 0) {
e96a536c 1318 ERROR("Failed to setup container \"%s\"", handler->name);
f4152036
CB
1319 goto out_warn_father;
1320 }
1321
408da065 1322 /* Set the label to change to when we exec(2) the container's init. */
1800f924 1323 ret = lsm_process_label_set(NULL, handler->conf, true);
e96a536c 1324 if (ret < 0)
e075f5d9 1325 goto out_warn_father;
5112cd70 1326
029cdff5 1327 /* Set PR_SET_NO_NEW_PRIVS after we changed the lsm label. If we do it
408da065
CB
1328 * before we aren't allowed anymore.
1329 */
029cdff5 1330 if (handler->conf->no_new_privs) {
b81689a1
CB
1331 ret = prctl(PR_SET_NO_NEW_PRIVS, prctl_arg(1), prctl_arg(0),
1332 prctl_arg(0), prctl_arg(0));
e96a536c
CB
1333 if (ret < 0) {
1334 SYSERROR("Could not set PR_SET_NO_NEW_PRIVS to block "
1335 "execve() gainable privileges");
029cdff5
CB
1336 goto out_warn_father;
1337 }
e96a536c
CB
1338 DEBUG("Set PR_SET_NO_NEW_PRIVS to block execve() gainable "
1339 "privileges");
029cdff5
CB
1340 }
1341
0d9acb99
DE
1342 /* Some init's such as busybox will set sane tty settings on stdin,
1343 * stdout, stderr which it thinks is the console. We already set them
1344 * the way we wanted on the real terminal, and we want init to do its
564e31c4 1345 * setup on its console ie. the pty allocated in lxc_terminal_setup() so
408da065 1346 * make sure that that pty is stdin,stdout,stderr.
0d9acb99 1347 */
5d113f65 1348 if (handler->conf->console.slave >= 0) {
bb955810 1349 if (handler->daemonize || !handler->conf->is_execute)
5d113f65
CB
1350 ret = set_stdfds(handler->conf->console.slave);
1351 else
ae6d3913 1352 ret = lxc_terminal_set_stdfds(handler->conf->console.slave);
5d113f65 1353 if (ret < 0) {
c5b93afb 1354 ERROR("Failed to redirect std{in,out,err} to pty file "
e96a536c 1355 "descriptor %d", handler->conf->console.slave);
c5b93afb
LF
1356 goto out_warn_father;
1357 }
5d113f65 1358 }
0d9acb99 1359
408da065 1360 /* If we mounted a temporary proc, then unmount it now. */
5112cd70 1361 tmp_proc_unmount(handler->conf);
e075f5d9 1362
e96a536c
CB
1363 ret = lxc_seccomp_load(handler->conf);
1364 if (ret < 0)
8f2c3a70
SH
1365 goto out_warn_father;
1366
c3e3c21a
CB
1367 ret = lxc_seccomp_send_notifier_fd(&handler->conf->seccomp, data_sock0);
1368 if (ret < 0) {
1369 SYSERROR("Failed to send seccomp notify fd to parent");
1370 goto out_warn_father;
cdb2a47f 1371 }
cdb2a47f 1372
e96a536c
CB
1373 ret = run_lxc_hooks(handler->name, "start", handler->conf, NULL);
1374 if (ret < 0) {
1375 ERROR("Failed to run lxc.hook.start for container \"%s\"",
1376 handler->name);
773fb9ca
SH
1377 goto out_warn_father;
1378 }
fc25b815 1379
773fb9ca 1380 close(handler->sigfd);
26ddeedd 1381
bb955810 1382 if (handler->conf->console.slave < 0 && handler->daemonize) {
f4c177c3
CB
1383 if (devnull_fd < 0) {
1384 devnull_fd = open_devnull();
1385 if (devnull_fd < 0)
1386 goto out_warn_father;
1387 }
1388
e96a536c
CB
1389 ret = set_stdfds(devnull_fd);
1390 if (ret < 0) {
1391 ERROR("Failed to redirect std{in,out,err} to \"/dev/null\"");
c5b93afb
LF
1392 goto out_warn_father;
1393 }
e96a536c 1394 }
507cee36 1395
c44de748
AM
1396 if (devnull_fd >= 0) {
1397 close(devnull_fd);
1398 devnull_fd = -1;
1399 }
1400
8c9a7665
TA
1401 setsid();
1402
e96a536c
CB
1403 if (handler->conf->init_cwd) {
1404 ret = chdir(handler->conf->init_cwd);
1405 if (ret < 0) {
1406 SYSERROR("Could not change directory to \"%s\"",
1407 handler->conf->init_cwd);
1408 goto out_warn_father;
1409 }
3c491553
L
1410 }
1411
e96a536c
CB
1412 ret = lxc_sync_barrier_parent(handler, LXC_SYNC_CGROUP_LIMITS);
1413 if (ret < 0)
f4152036
CB
1414 goto out_warn_father;
1415
149857af
CB
1416 /* Reset the environment variables the user requested in a clear
1417 * environment.
1418 */
e96a536c
CB
1419 ret = clearenv();
1420 /* Don't error out though. */
1421 if (ret < 0)
149857af 1422 SYSERROR("Failed to clear environment.");
149857af
CB
1423
1424 lxc_list_for_each(iterator, &handler->conf->environment) {
e96a536c
CB
1425 ret = putenv((char *)iterator->elem);
1426 if (ret < 0) {
1427 SYSERROR("Failed to set environment variable: %s",
1428 (char *)iterator->elem);
149857af
CB
1429 goto out_warn_father;
1430 }
1431 }
1432
e96a536c
CB
1433 ret = putenv("container=lxc");
1434 if (ret < 0) {
1435 SYSERROR("Failed to set environment variable: container=lxc");
98ff08ca
CB
1436 goto out_warn_father;
1437 }
1438
885766f5
CB
1439 if (handler->conf->ttys.tty_names) {
1440 ret = putenv(handler->conf->ttys.tty_names);
e96a536c
CB
1441 if (ret < 0) {
1442 SYSERROR("Failed to set environment variable for container ptys");
98ff08ca
CB
1443 goto out_warn_father;
1444 }
1445 }
1446
76bdf299
CB
1447 /* The container has been setup. We can now switch to an unprivileged
1448 * uid/gid.
1449 */
928b1f04
YT
1450 new_uid = handler->conf->init_uid;
1451 new_gid = handler->conf->init_gid;
76bdf299 1452
964581c2
CB
1453 /* Avoid unnecessary syscalls. */
1454 if (new_uid == nsuid)
1455 new_uid = LXC_INVALID_UID;
1456
1457 if (new_gid == nsgid)
1458 new_gid = LXC_INVALID_GID;
1459
464c4611 1460 if (!lxc_switch_uid_gid(new_uid, new_gid))
928b1f04
YT
1461 goto out_warn_father;
1462
8af07f82
CB
1463 /* If we are in a new user namespace we already dropped all groups when
1464 * we switched to root in the new user namespace further above. Only
1465 * drop groups if we can, so ensure that we have necessary privilege.
1466 */
1467 if (lxc_list_empty(&handler->conf->id_map))
1468 #if HAVE_LIBCAP
1469 if (lxc_proc_cap_is_set(CAP_SETGID, CAP_EFFECTIVE))
1470 #endif
1471 if (!lxc_setgroups(0, NULL))
1472 goto out_warn_father;
1473
611ddd34
CB
1474 ret = lxc_ambient_caps_down();
1475 if (ret < 0) {
6f5e532f 1476 ERROR("Failed to clear ambient capabilities");
611ddd34
CB
1477 goto out_warn_father;
1478 }
1479
258f8051 1480 if (handler->conf->monitor_signal_pdeath != SIGKILL) {
97d8f4b7 1481 ret = lxc_set_death_signal(handler->conf->monitor_signal_pdeath, handler->monitor_pid);
258f8051
CB
1482 if (ret < 0) {
1483 SYSERROR("Failed to set PR_SET_PDEATHSIG to %d",
1484 handler->conf->monitor_signal_pdeath);
1485 goto out_warn_father;
1486 }
1487 }
1488
408da065
CB
1489 /* After this call, we are in error because this ops should not return
1490 * as it execs.
1491 */
c4ea60df 1492 handler->ops->start(handler, handler->data);
50e98013
DL
1493
1494out_warn_father:
408da065
CB
1495 /* We want the parent to know something went wrong, so we return a
1496 * special error code.
1497 */
d1ccb562 1498 lxc_sync_wake_parent(handler, LXC_SYNC_ERROR);
c44de748
AM
1499
1500out_error:
1501 if (devnull_fd >= 0)
1502 close(devnull_fd);
1503
50e98013
DL
1504 return -1;
1505}
1506
ae467c54 1507static int lxc_recv_ttys_from_child(struct lxc_handler *handler)
e8bd4e43 1508{
ae467c54 1509 int i;
2520facd 1510 struct lxc_terminal_info *tty;
ae467c54 1511 int ret = -1;
c6012571 1512 int sock = handler->data_sock[1];
e8bd4e43 1513 struct lxc_conf *conf = handler->conf;
0e4be3cf 1514 struct lxc_tty_info *ttys = &conf->ttys;
e8bd4e43 1515
885766f5 1516 if (!conf->ttys.max)
e8bd4e43
SH
1517 return 0;
1518
885766f5 1519 ttys->tty = malloc(sizeof(*ttys->tty) * ttys->max);
0e4be3cf 1520 if (!ttys->tty)
e8bd4e43 1521 return -1;
e8bd4e43 1522
885766f5 1523 for (i = 0; i < conf->ttys.max; i++) {
672c1e58
CB
1524 int ttyfds[2];
1525
1526 ret = lxc_abstract_unix_recv_fds(sock, ttyfds, 2, NULL, 0);
1527 if (ret < 0)
1528 break;
ae467c54 1529
0e4be3cf 1530 tty = &ttys->tty[i];
2520facd
CB
1531 tty->busy = 0;
1532 tty->master = ttyfds[0];
1533 tty->slave = ttyfds[1];
672c1e58 1534 TRACE("Received pty with master fd %d and slave fd %d from "
2520facd 1535 "parent", tty->master, tty->slave);
e8bd4e43 1536 }
6d1400b5 1537
ae467c54 1538 if (ret < 0)
6d1400b5 1539 SYSERROR("Failed to receive %zu ttys from child", ttys->max);
ae467c54 1540 else
885766f5 1541 TRACE("Received %zu ttys from child", ttys->max);
ae467c54
CB
1542
1543 return ret;
e8bd4e43
SH
1544}
1545
5af9369b 1546int resolve_clone_flags(struct lxc_handler *handler)
f813849c 1547{
8bc8c715
CB
1548 int i;
1549 struct lxc_conf *conf = handler->conf;
f813849c 1550
8bc8c715 1551 for (i = 0; i < LXC_NS_MAX; i++) {
f7a0c6ee
CB
1552 if (conf->ns_keep) {
1553 if (!(conf->ns_keep & ns_info[i].clone_flag))
becad0ec 1554 handler->ns_clone_flags |= ns_info[i].clone_flag;
f7a0c6ee
CB
1555 } else if (conf->ns_clone) {
1556 if ((conf->ns_clone & ns_info[i].clone_flag))
becad0ec 1557 handler->ns_clone_flags |= ns_info[i].clone_flag;
8bc8c715
CB
1558 } else {
1559 if (i == LXC_NS_USER && lxc_list_empty(&handler->conf->id_map))
1560 continue;
1561
1562 if (i == LXC_NS_NET && lxc_requests_empty_network(handler))
1563 continue;
1564
7bd05339
CB
1565 if (i == LXC_NS_CGROUP && !cgns_supported())
1566 continue;
1567
becad0ec 1568 handler->ns_clone_flags |= ns_info[i].clone_flag;
8bc8c715 1569 }
03df7ab5 1570
8bc8c715
CB
1571 if (!conf->ns_share[i])
1572 continue;
5af9369b 1573
becad0ec 1574 handler->ns_clone_flags &= ~ns_info[i].clone_flag;
8bc8c715 1575 TRACE("Sharing %s namespace", ns_info[i].proc_name);
5af9369b
CB
1576 }
1577
1578 return 0;
f813849c
TA
1579}
1580
8deca6c9
CB
1581/* Note that this function is used with clone(CLONE_VM). Some glibc versions
1582 * used to reset the pid/tid to -1 when CLONE_VM was used without CLONE_THREAD.
1583 * But since the memory between parent and child is shared on CLONE_VM this
1584 * would invalidate the getpid() cache that glibc used to maintain and so
1585 * getpid() in the child would return the parent's pid. This is all fixed in
1586 * newer glibc versions where the getpid() cache is removed and the pid/tid is
1587 * not reset anymore.
b35ddc5b 1588 * However, if for whatever reason you - dear committer - somehow need to get the
8deca6c9 1589 * pid of the dummy intermediate process for do_share_ns() you need to call
0059379f
CB
1590 * lxc_raw_getpid(). The next lxc_raw_clone() call does not employ CLONE_VM and
1591 * will be fine.
8deca6c9
CB
1592 */
1593static inline int do_share_ns(void *arg)
fa3a5b22 1594{
8deca6c9 1595 int i, flags, ret;
fa3a5b22
CB
1596 struct lxc_handler *handler = arg;
1597
8deca6c9
CB
1598 for (i = 0; i < LXC_NS_MAX; i++) {
1599 if (handler->nsfd[i] < 0)
1600 continue;
fa3a5b22 1601
8deca6c9 1602 ret = setns(handler->nsfd[i], 0);
c0b48eff
CB
1603 if (ret < 0) {
1604 /*
1605 * Note that joining a user and/or mount namespace
1606 * requires the process is not multithreaded otherwise
1607 * setns() will fail here.
1608 */
1609 SYSERROR("Failed to inherit %s namespace",
1610 ns_info[i].proc_name);
8deca6c9 1611 return -1;
c0b48eff 1612 }
fa3a5b22 1613
8deca6c9 1614 DEBUG("Inherited %s namespace", ns_info[i].proc_name);
fa3a5b22
CB
1615 }
1616
becad0ec 1617 flags = handler->ns_on_clone_flags;
8deca6c9 1618 flags |= CLONE_PARENT;
33942046
CB
1619 handler->pid = lxc_raw_clone_cb(do_start, handler, CLONE_PIDFD | flags,
1620 &handler->pidfd);
8deca6c9 1621 if (handler->pid < 0)
fa3a5b22
CB
1622 return -1;
1623
8deca6c9 1624 return 0;
fa3a5b22
CB
1625}
1626
d9bb2fba
CB
1627static int proc_pidfd_open(pid_t pid)
1628{
1629 __do_close_prot_errno int proc_pidfd = -EBADF;
1630 char path[100];
1631
1632 snprintf(path, sizeof(path), "/proc/%d", pid);
1633 proc_pidfd = open(path, O_DIRECTORY | O_RDONLY | O_CLOEXEC);
1634 if (proc_pidfd < 0) {
1635 SYSERROR("Failed to open %s", path);
1636 return -1;
1637 }
1638
1639 /* Test whether we can send signals. */
1640 if (lxc_raw_pidfd_send_signal(proc_pidfd, 0, NULL, 0)) {
1641 SYSERROR("Failed to send signal through pidfd");
1642 return -1;
1643 }
1644
1645 return move_fd(proc_pidfd);
1646}
1647
480588e6
CB
1648/* lxc_spawn() performs crucial setup tasks and clone()s the new process which
1649 * exec()s the requested container binary.
1650 * Note that lxc_spawn() runs in the parent namespaces. Any operations performed
1651 * right here should be double checked if they'd pose a security risk. (For
1652 * example, any {u}mount() operations performed here will be reflected on the
1653 * host!)
1654 */
74a3920a 1655static int lxc_spawn(struct lxc_handler *handler)
59eb99ba 1656{
cdb2a47f 1657 __do_close_prot_errno int data_sock0 = -EBADF, data_sock1 = -EBADF;
8deca6c9 1658 int i, ret;
08dd2805 1659 char pidstr[20];
57927bf2
CB
1660 bool wants_to_map_ids;
1661 struct lxc_list *id_map;
6e5fc7a5 1662 const char *name = handler->name;
28d9e29e 1663 const char *lxcpath = handler->lxcpath;
2202afc9 1664 bool share_ns = false;
28d9e29e 1665 struct lxc_conf *conf = handler->conf;
2202afc9 1666 struct cgroup_ops *cgroup_ops = handler->cgroup_ops;
9f30a190 1667
28d9e29e 1668 id_map = &conf->id_map;
57927bf2 1669 wants_to_map_ids = !lxc_list_empty(id_map);
2f2623ec 1670
28d9e29e 1671 for (i = 0; i < LXC_NS_MAX; i++) {
b074bbf1 1672 if (!conf->ns_share[i])
28d9e29e
CB
1673 continue;
1674
b074bbf1 1675 handler->nsfd[i] = lxc_inherit_namespace(conf->ns_share[i], lxcpath, ns_info[i].proc_name);
28d9e29e
CB
1676 if (handler->nsfd[i] < 0)
1677 return -1;
fa3a5b22 1678
8deca6c9 1679 share_ns = true;
28d9e29e 1680 }
50e98013 1681
cfc62c60
CB
1682 ret = lxc_sync_init(handler);
1683 if (ret < 0)
9d7f9e52 1684 return -1;
0ad19a3f 1685
b9f522c5 1686 ret = socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0,
790255cf 1687 handler->data_sock);
95ef0d7c
CB
1688 if (ret < 0)
1689 goto out_sync_fini;
cdb2a47f
CB
1690 data_sock0 = handler->data_sock[0];
1691 data_sock1 = handler->data_sock[1];
e8bd4e43 1692
5af9369b 1693 ret = resolve_clone_flags(handler);
95ef0d7c
CB
1694 if (ret < 0)
1695 goto out_sync_fini;
9f30a190 1696
becad0ec 1697 if (handler->ns_clone_flags & CLONE_NEWNET) {
28d9e29e 1698 if (!lxc_list_empty(&conf->network)) {
26b797f3 1699
9f30a190
MM
1700 /* Find gateway addresses from the link device, which is
1701 * no longer accessible inside the container. Do this
1702 * before creating network interfaces, since goto
408da065
CB
1703 * out_delete_net does not work before lxc_clone.
1704 */
cfc62c60
CB
1705 ret = lxc_find_gateway_addresses(handler);
1706 if (ret < 0) {
1707 ERROR("Failed to find gateway addresses");
95ef0d7c 1708 goto out_sync_fini;
9f30a190
MM
1709 }
1710
408da065
CB
1711 /* That should be done before the clone because we will
1712 * fill the netdev index and use them in the child.
9f30a190 1713 */
cfc62c60
CB
1714 ret = lxc_create_network_priv(handler);
1715 if (ret < 0) {
1716 ERROR("Failed to create the network");
78852a0c 1717 goto out_delete_net;
9f30a190 1718 }
19a26f82 1719 }
82d5ae15
DL
1720 }
1721
e8b181f5 1722 if (!cgroup_ops->payload_create(cgroup_ops, handler)) {
cfc62c60 1723 ERROR("Failed creating cgroups");
47d8fb3b
CS
1724 goto out_delete_net;
1725 }
1726
408da065
CB
1727 /* If the rootfs is not a blockdev, prevent the container from marking
1728 * it readonly.
1729 * If the container is unprivileged then skip rootfs pinning.
0c547523 1730 */
0ee35059 1731 if (!wants_to_map_ids) {
28d9e29e 1732 handler->pinfd = pin_rootfs(conf->rootfs.path);
5e32a990 1733 if (handler->pinfd == -1)
cfc62c60 1734 INFO("Failed to pin the rootfs for container \"%s\"", handler->name);
5e32a990 1735 }
0c547523 1736
408da065 1737 /* Create a process in a new set of namespaces. */
becad0ec
CB
1738 handler->ns_on_clone_flags = handler->ns_clone_flags;
1739 if (handler->ns_clone_flags & CLONE_NEWUSER) {
408da065
CB
1740 /* If CLONE_NEWUSER and CLONE_NEWNET was requested, we need to
1741 * clone a new user namespace first and only later unshare our
1742 * network namespace to ensure that network devices ownership is
1743 * set up correctly.
1744 */
becad0ec 1745 handler->ns_on_clone_flags &= ~CLONE_NEWNET;
408da065 1746 }
5af9369b 1747 /* The cgroup namespace gets unshare()ed not clone()ed. */
becad0ec 1748 handler->ns_on_clone_flags &= ~CLONE_NEWCGROUP;
732375f5 1749
4e232466
CB
1750 if (share_ns) {
1751 pid_t attacher_pid;
1752
cfc62c60 1753 attacher_pid = lxc_clone(do_share_ns, handler,
33258b95 1754 CLONE_VFORK | CLONE_VM | CLONE_FILES, NULL);
4e232466
CB
1755 if (attacher_pid < 0) {
1756 SYSERROR(LXC_CLONE_ERROR);
1757 goto out_delete_net;
1758 }
1759
1760 ret = wait_for_pid(attacher_pid);
1761 if (ret < 0) {
1762 SYSERROR("Intermediate process failed");
1763 goto out_delete_net;
1764 }
1765 } else {
cfc62c60 1766 handler->pid = lxc_raw_clone_cb(do_start, handler,
33942046
CB
1767 CLONE_PIDFD | handler->ns_on_clone_flags,
1768 &handler->pidfd);
4e232466
CB
1769 }
1770 if (handler->pid < 0) {
1771 SYSERROR(LXC_CLONE_ERROR);
7fef7a06 1772 goto out_delete_net;
0ad19a3f 1773 }
fa3a5b22 1774 TRACE("Cloned child process %d", handler->pid);
1bd8d726 1775
33942046
CB
1776 if (handler->pidfd < 0) {
1777 handler->proc_pidfd = proc_pidfd_open(handler->pid);
1778 if (handler->proc_pidfd < 0 && (errno != ENOSYS))
1779 goto out_delete_net;
1780 }
d9bb2fba 1781
9662e444 1782 for (i = 0; i < LXC_NS_MAX; i++)
becad0ec 1783 if (handler->ns_on_clone_flags & ns_info[i].clone_flag)
28d9e29e 1784 INFO("Cloned %s", ns_info[i].flag_name);
0ad19a3f 1785
4cb53844 1786 if (!lxc_try_preserve_namespaces(handler, handler->ns_on_clone_flags, handler->pid)) {
28d9e29e
CB
1787 ERROR("Failed to preserve cloned namespaces for lxc.hook.stop");
1788 goto out_delete_net;
1789 }
b6b2b194 1790
3c22086f
CLG
1791 lxc_sync_fini_child(handler);
1792
408da065
CB
1793 /* Map the container uids. The container became an invalid userid the
1794 * moment it was cloned with CLONE_NEWUSER. This call doesn't change
1795 * anything immediately, but allows the container to setuid(0) (0 being
1796 * mapped to something else on the host.) later to become a valid uid
1797 * again.
1798 */
fa3a5b22 1799 if (wants_to_map_ids) {
df3c5314 1800 if (!handler->conf->ns_share[LXC_NS_USER] &&
46186acd 1801 (handler->conf->ns_keep & CLONE_NEWUSER) == 0) {
fa3a5b22
CB
1802 ret = lxc_map_ids(id_map, handler->pid);
1803 if (ret < 0) {
1804 ERROR("Failed to set up id mapping.");
1805 goto out_delete_net;
1806 }
1807 }
5b1e83cb
SH
1808 }
1809
cfc62c60
CB
1810 ret = lxc_sync_wake_child(handler, LXC_SYNC_STARTUP);
1811 if (ret < 0)
5b1e83cb 1812 goto out_delete_net;
5b1e83cb 1813
cfc62c60
CB
1814 ret = lxc_sync_wait_child(handler, LXC_SYNC_CONFIGURE);
1815 if (ret < 0)
5b1e83cb 1816 goto out_delete_net;
0ad19a3f 1817
2202afc9 1818 if (!cgroup_ops->setup_limits(cgroup_ops, handler->conf, false)) {
cfc62c60 1819 ERROR("Failed to setup cgroup limits for container \"%s\"", name);
6031a6e5
DE
1820 goto out_delete_net;
1821 }
1822
e8b181f5 1823 if (!cgroup_ops->payload_enter(cgroup_ops, handler->pid))
7fef7a06 1824 goto out_delete_net;
218d4250 1825
2202afc9 1826 if (!cgroup_ops->chown(cgroup_ops, handler->conf))
0996e18a
SH
1827 goto out_delete_net;
1828
aa0c0e7b
RK
1829 /* If not done yet, we're now ready to preserve the network namespace */
1830 if (handler->nsfd[LXC_NS_NET] < 0) {
1831 ret = lxc_try_preserve_ns(handler->pid, "net");
1832 if (ret < 0) {
1833 if (ret != -EOPNOTSUPP) {
1834 SYSERROR("Failed to preserve net namespace");
1835 goto out_delete_net;
1836 }
1837 } else {
1838 handler->nsfd[LXC_NS_NET] = ret;
1839 DEBUG("Preserved net namespace via fd %d", ret);
4cb53844 1840 }
fa3a5b22 1841 }
aa0c0e7b
RK
1842 ret = lxc_netns_set_nsid(handler->nsfd[LXC_NS_NET]);
1843 if (ret < 0)
1844 SYSWARN("Failed to allocate new network namespace id");
1845 else
1846 TRACE("Allocated new network namespace id");
fa3a5b22 1847
408da065 1848 /* Create the network configuration. */
becad0ec 1849 if (handler->ns_clone_flags & CLONE_NEWNET) {
cfc62c60
CB
1850 ret = lxc_network_move_created_netdev_priv(handler->lxcpath,
1851 handler->name,
1852 &conf->network,
1853 handler->pid);
1854 if (ret < 0) {
1855 ERROR("Failed to create the configured network");
7fef7a06 1856 goto out_delete_net;
82d5ae15 1857 }
74c6e2b0 1858
cfc62c60 1859 ret = lxc_create_network_unpriv(handler->lxcpath, handler->name,
4d781681 1860 &conf->network, handler->pid, conf->hooks_version);
cfc62c60
CB
1861 if (ret < 0) {
1862 ERROR("Failed to create the configured network");
74c6e2b0
CB
1863 goto out_delete_net;
1864 }
0ad19a3f 1865 }
1866
cfc62c60
CB
1867 ret = lxc_network_send_veth_names_to_child(handler);
1868 if (ret < 0) {
7ab1ba02
CB
1869 ERROR("Failed to send veth names to child");
1870 goto out_delete_net;
658979c5
SH
1871 }
1872
61d7a733
YT
1873 if (!lxc_list_empty(&conf->procs)) {
1874 ret = setup_proc_filesystem(&conf->procs, handler->pid);
1875 if (ret < 0)
1876 goto out_delete_net;
1877 }
1878
408da065
CB
1879 /* Tell the child to continue its initialization. We'll get
1880 * LXC_SYNC_CGROUP when it is ready for us to setup cgroups.
3c22086f 1881 */
cfc62c60
CB
1882 ret = lxc_sync_barrier_child(handler, LXC_SYNC_POST_CONFIGURE);
1883 if (ret < 0)
544a48a0
SH
1884 goto out_delete_net;
1885
cfc62c60
CB
1886 if (!lxc_list_empty(&conf->limits)) {
1887 ret = setup_resource_limits(&conf->limits, handler->pid);
1888 if (ret < 0) {
1889 ERROR("Failed to setup resource limits");
1890 goto out_delete_net;
1891 }
c6d09e15
WB
1892 }
1893
cfc62c60
CB
1894 ret = lxc_sync_barrier_child(handler, LXC_SYNC_CGROUP_UNSHARE);
1895 if (ret < 0)
f4152036
CB
1896 goto out_delete_net;
1897
2202afc9 1898 if (!cgroup_ops->setup_limits(cgroup_ops, handler->conf, true)) {
cfc62c60 1899 ERROR("Failed to setup legacy device cgroup controller limits");
b98f7d6e 1900 goto out_delete_net;
544a48a0 1901 }
cfc62c60 1902 TRACE("Set up legacy device cgroup controller limits");
544a48a0 1903
becad0ec 1904 if (handler->ns_clone_flags & CLONE_NEWCGROUP) {
8bf3abfb 1905 /* Now we're ready to preserve the cgroup namespace */
4cb53844 1906 ret = lxc_try_preserve_ns(handler->pid, "cgroup");
8bf3abfb 1907 if (ret < 0) {
4cb53844 1908 if (ret != -EOPNOTSUPP) {
6d1400b5 1909 SYSERROR("Failed to preserve cgroup namespace");
4cb53844
CB
1910 goto out_delete_net;
1911 }
1912 } else {
1913 handler->nsfd[LXC_NS_CGROUP] = ret;
1914 DEBUG("Preserved cgroup namespace via fd %d", ret);
8bf3abfb 1915 }
8bf3abfb
CB
1916 }
1917
5b7f756a
CB
1918 ret = snprintf(pidstr, 20, "%d", handler->pid);
1919 if (ret < 0 || ret >= 20)
1920 goto out_delete_net;
1921
cfc62c60
CB
1922 ret = setenv("LXC_PID", pidstr, 1);
1923 if (ret < 0)
1924 SYSERROR("Failed to set environment variable: LXC_PID=%s", pidstr);
08dd2805
SH
1925
1926 /* Run any host-side start hooks */
cfc62c60
CB
1927 ret = run_lxc_hooks(name, "start-host", conf, NULL);
1928 if (ret < 0) {
1929 ERROR("Failed to run lxc.hook.start-host");
341ed84c 1930 goto out_delete_net;
08dd2805
SH
1931 }
1932
408da065
CB
1933 /* Tell the child to complete its initialization and wait for it to exec
1934 * or return an error. (The child will never return
08dd2805 1935 * LXC_SYNC_READY_START+1. It will either close the sync pipe, causing
408da065
CB
1936 * lxc_sync_barrier_child to return success, or return a different
1937 * value, causing us to error out).
544a48a0 1938 */
cfc62c60
CB
1939 ret = lxc_sync_barrier_child(handler, LXC_SYNC_READY_START);
1940 if (ret < 0)
341ed84c 1941 goto out_delete_net;
0ad19a3f 1942
cfc62c60
CB
1943 ret = lxc_network_recv_name_and_ifindex_from_child(handler);
1944 if (ret < 0) {
790255cf
CB
1945 ERROR("Failed to receive names and ifindices for network "
1946 "devices from child");
1947 goto out_delete_net;
1948 }
1949
1950 /* Now all networks are created, network devices are moved into place,
ad2ddfcd 1951 * and the correct names and ifindices in the respective namespaces have
790255cf
CB
1952 * been recorded. The corresponding structs have now all been filled. So
1953 * log them for debugging purposes.
1954 */
28d9e29e 1955 lxc_log_configured_netdevs(conf);
790255cf 1956
f4152036 1957 /* Read tty fds allocated by child. */
cfc62c60
CB
1958 ret = lxc_recv_ttys_from_child(handler);
1959 if (ret < 0) {
1960 ERROR("Failed to receive tty info from child process");
f4152036
CB
1961 goto out_delete_net;
1962 }
1963
c3e3c21a
CB
1964 ret = lxc_seccomp_recv_notifier_fd(&handler->conf->seccomp, data_sock1);
1965 if (ret < 0) {
1966 SYSERROR("Failed to receive seccomp notify fd from child");
1967 goto out_delete_net;
cdb2a47f 1968 }
cdb2a47f 1969
cfc62c60
CB
1970 ret = handler->ops->post_start(handler, handler->data);
1971 if (ret < 0)
e6126dbe
MN
1972 goto out_abort;
1973
cfc62c60
CB
1974 ret = lxc_set_state(name, handler, RUNNING);
1975 if (ret < 0) {
1976 ERROR("Failed to set state to \"%s\"", lxc_state2str(RUNNING));
59eb99ba 1977 goto out_abort;
3f21c114 1978 }
22ebac19 1979
3c22086f 1980 lxc_sync_fini(handler);
0c547523 1981
e6126dbe 1982 return 0;
1ac470c0 1983
7fef7a06 1984out_delete_net:
becad0ec 1985 if (handler->ns_clone_flags & CLONE_NEWNET)
bb84beda 1986 lxc_delete_network(handler);
1bd8d726 1987
59eb99ba
DL
1988out_abort:
1989 lxc_abort(name, handler);
95ef0d7c
CB
1990
1991out_sync_fini:
3c22086f 1992 lxc_sync_fini(handler);
5c068da9
SH
1993 if (handler->pinfd >= 0) {
1994 close(handler->pinfd);
1995 handler->pinfd = -1;
1996 }
1997
b79fcd86 1998 return -1;
59eb99ba 1999}
0ad19a3f 2000
aa460476 2001int __lxc_start(const char *name, struct lxc_handler *handler,
507cee36 2002 struct lxc_operations* ops, void *data, const char *lxcpath,
bb955810 2003 bool daemonize, int *error_num)
59eb99ba 2004{
c30e9b19 2005 int ret, status;
aa460476 2006 struct lxc_conf *conf = handler->conf;
72068e74 2007 struct cgroup_ops *cgroup_ops;
80090207 2008
c30e9b19
CB
2009 ret = lxc_init(name, handler);
2010 if (ret < 0) {
2011 ERROR("Failed to initialize container \"%s\"", name);
39cb2d9e 2012 goto out_fini_nonet;
0ad19a3f 2013 }
ee70bf78
CLG
2014 handler->ops = ops;
2015 handler->data = data;
bb955810 2016 handler->daemonize = daemonize;
72068e74 2017 cgroup_ops = handler->cgroup_ops;
e6126dbe 2018
76a26f55 2019 if (!attach_block_device(handler->conf)) {
c30e9b19 2020 ERROR("Failed to attach block device");
575ea467 2021 ret = -1;
76a26f55
SH
2022 goto out_fini_nonet;
2023 }
2024
72068e74
CB
2025 if (!cgroup_ops->monitor_create(cgroup_ops, handler)) {
2026 ERROR("Failed to create monitor cgroup");
575ea467 2027 ret = -1;
eeef32bb
CB
2028 goto out_fini_nonet;
2029 }
2030
434c8e15 2031 if (!cgroup_ops->monitor_enter(cgroup_ops, handler->monitor_pid)) {
eeef32bb 2032 ERROR("Failed to enter monitor cgroup");
575ea467 2033 ret = -1;
72068e74
CB
2034 goto out_fini_nonet;
2035 }
2036
35120d9c 2037 if (geteuid() == 0 && !lxc_list_empty(&conf->id_map)) {
408da065 2038 /* If the backing store is a device, mount it here and now. */
35120d9c 2039 if (rootfs_is_blockdev(conf)) {
c30e9b19
CB
2040 ret = unshare(CLONE_NEWNS);
2041 if (ret < 0) {
2042 ERROR("Failed to unshare CLONE_NEWNS");
35120d9c
SH
2043 goto out_fini_nonet;
2044 }
c30e9b19 2045 INFO("Unshared CLONE_NEWNS");
408da065 2046
6a0c909a 2047 remount_all_slave();
8ce1abc2 2048 ret = lxc_setup_rootfs_prepare_root(conf, name, lxcpath);
c30e9b19
CB
2049 if (ret < 0) {
2050 ERROR("Error setting up rootfs mount as root before spawn");
35120d9c
SH
2051 goto out_fini_nonet;
2052 }
c30e9b19 2053 INFO("Set up container rootfs as host root");
35120d9c
SH
2054 }
2055 }
2056
c30e9b19
CB
2057 ret = lxc_spawn(handler);
2058 if (ret < 0) {
2059 ERROR("Failed to spawn container \"%s\"", name);
76a26f55 2060 goto out_detach_blockdev;
0ad19a3f 2061 }
2062
80308d07 2063 handler->conf->reboot = REBOOT_NONE;
8bee8851 2064
c30e9b19
CB
2065 ret = lxc_poll(name, handler);
2066 if (ret) {
2067 ERROR("LXC mainloop exited with error: %d", ret);
59eb99ba
DL
2068 goto out_abort;
2069 }
0ad19a3f 2070
321db026
DJ
2071 if (!handler->init_died && handler->pid > 0) {
2072 ERROR("Child process is not killed");
575ea467 2073 ret = -1;
321db026
DJ
2074 goto out_abort;
2075 }
2076
c30e9b19
CB
2077 status = lxc_wait_for_pid_status(handler->pid);
2078 if (status < 0)
2079 SYSERROR("Failed to retrieve status for %d", handler->pid);
e043236e 2080
408da065
CB
2081 /* If the child process exited but was not signaled, it didn't call
2082 * reboot. This should mean it was an lxc-execute which simply exited.
2083 * In any case, treat it as a 'halt'.
8b004f07 2084 */
d028235d 2085 if (WIFSIGNALED(status)) {
8b004f07
SH
2086 switch(WTERMSIG(status)) {
2087 case SIGINT: /* halt */
c30e9b19 2088 DEBUG("Container \"%s\" is halting", name);
8b004f07
SH
2089 break;
2090 case SIGHUP: /* reboot */
c30e9b19 2091 DEBUG("Container \"%s\" is rebooting", name);
80308d07 2092 handler->conf->reboot = REBOOT_REQ;
8b004f07 2093 break;
c2b9bd9e 2094 case SIGSYS: /* seccomp */
c30e9b19 2095 DEBUG("Container \"%s\" violated its seccomp policy", name);
c2b9bd9e 2096 break;
8b004f07 2097 default:
c30e9b19 2098 DEBUG("Unknown exit status for container \"%s\" init %d", name, WTERMSIG(status));
8b004f07
SH
2099 break;
2100 }
d028235d 2101 }
828695d9 2102
c30e9b19
CB
2103 ret = lxc_restore_phys_nics_to_netns(handler);
2104 if (ret < 0)
b809f232
CB
2105 ERROR("Failed to move physical network devices back to parent "
2106 "network namespace");
ce5782df 2107
5c068da9
SH
2108 if (handler->pinfd >= 0) {
2109 close(handler->pinfd);
2110 handler->pinfd = -1;
2111 }
2112
1787abca 2113 lxc_monitor_send_exit_code(name, status, handler->lxcpath);
eb808539 2114 lxc_error_set_and_log(handler->pid, status);
a3b4f3d6
TA
2115 if (error_num)
2116 *error_num = handler->exit_status;
1bd8d726 2117
9d7f9e52 2118out_fini:
bb84beda 2119 lxc_delete_network(handler);
74a2b586 2120
76a26f55
SH
2121out_detach_blockdev:
2122 detach_block_device(handler->conf);
2123
74a2b586 2124out_fini_nonet:
3a0f472d 2125 lxc_fini(name, handler);
c30e9b19 2126 return ret;
0ad19a3f 2127
59eb99ba 2128out_abort:
3a0f472d 2129 lxc_abort(name, handler);
9d7f9e52 2130 goto out_fini;
0ad19a3f 2131}
ee70bf78
CLG
2132
2133struct start_args {
2134 char *const *argv;
2135};
2136
2137static int start(struct lxc_handler *handler, void* data)
2138{
2139 struct start_args *arg = data;
2140
984984e4 2141 NOTICE("Exec'ing \"%s\"", arg->argv[0]);
ee70bf78
CLG
2142
2143 execvp(arg->argv[0], arg->argv);
984984e4 2144 SYSERROR("Failed to exec \"%s\"", arg->argv[0]);
ee70bf78
CLG
2145 return 0;
2146}
2147
2148static int post_start(struct lxc_handler *handler, void* data)
2149{
2150 struct start_args *arg = data;
2151
4c8e880e 2152 NOTICE("Started \"%s\" with pid \"%d\"", arg->argv[0], handler->pid);
ee70bf78
CLG
2153 return 0;
2154}
2155
2156static struct lxc_operations start_ops = {
2157 .start = start,
2158 .post_start = post_start
2159};
2160
aa460476 2161int lxc_start(const char *name, char *const argv[], struct lxc_handler *handler,
bb955810 2162 const char *lxcpath, bool daemonize, int *error_num)
ee70bf78
CLG
2163{
2164 struct start_args start_arg = {
2165 .argv = argv,
2166 };
2167
b2efeb0b 2168 TRACE("Doing lxc_start");
bb955810 2169 return __lxc_start(name, handler, &start_ops, &start_arg, lxcpath, daemonize, error_num);
ee70bf78 2170}
28272964
CB
2171
2172static void lxc_destroy_container_on_signal(struct lxc_handler *handler,
2173 const char *name)
2174{
245100a0 2175 char destroy[PATH_MAX];
f01f7975 2176 struct lxc_container *c;
ae3beac9
CB
2177 int ret = 0;
2178 bool bret = true;
2179
df31363a 2180 if (handler->conf->rootfs.path && handler->conf->rootfs.mount) {
790255cf 2181 bret = do_destroy_container(handler);
28272964 2182 if (!bret) {
ae3beac9 2183 ERROR("Error destroying rootfs for container \"%s\"", name);
28272964
CB
2184 return;
2185 }
2186 }
ae3beac9 2187 INFO("Destroyed rootfs for container \"%s\"", name);
28272964 2188
245100a0
CB
2189 ret = snprintf(destroy, PATH_MAX, "%s/%s", handler->lxcpath, name);
2190 if (ret < 0 || ret >= PATH_MAX) {
ae3beac9 2191 ERROR("Error destroying directory for container \"%s\"", name);
28272964
CB
2192 return;
2193 }
2194
f01f7975
CB
2195 c = lxc_container_new(name, handler->lxcpath);
2196 if (c) {
2197 if (container_disk_lock(c)) {
ae3beac9 2198 INFO("Could not update lxc_snapshots file");
f01f7975
CB
2199 lxc_container_put(c);
2200 } else {
2201 mod_all_rdeps(c, false);
2202 container_disk_unlock(c);
2203 lxc_container_put(c);
2204 }
2205 }
2206
d0fbc7ba 2207 if (!handler->am_root)
94b0a3ac
CB
2208 ret = userns_exec_full(handler->conf, lxc_rmdir_onedev_wrapper,
2209 destroy, "lxc_rmdir_onedev_wrapper");
28272964
CB
2210 else
2211 ret = lxc_rmdir_onedev(destroy, NULL);
2212
2213 if (ret < 0) {
ae3beac9 2214 ERROR("Error destroying directory for container \"%s\"", name);
28272964
CB
2215 return;
2216 }
ae3beac9 2217 INFO("Destroyed directory for container \"%s\"", name);
28272964
CB
2218}
2219
2220static int lxc_rmdir_onedev_wrapper(void *data)
2221{
2222 char *arg = (char *) data;
2223 return lxc_rmdir_onedev(arg, NULL);
2224}
2225
134df645
CB
2226static bool do_destroy_container(struct lxc_handler *handler)
2227{
94b0a3ac
CB
2228 int ret;
2229
d0fbc7ba 2230 if (!handler->am_root) {
94b0a3ac
CB
2231 ret = userns_exec_full(handler->conf, storage_destroy_wrapper,
2232 handler->conf, "storage_destroy_wrapper");
2233 if (ret < 0)
d028235d 2234 return false;
10bc1861 2235
d028235d
SG
2236 return true;
2237 }
10bc1861 2238
790255cf 2239 return storage_destroy(handler->conf);
28272964 2240}