]>
Commit | Line | Data |
---|---|---|
f20569fa | 1 | error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` |
923072b8 | 2 | --> $DIR/bind_instead_of_map_multipart.rs:6:13 |
f20569fa XL |
3 | | |
4 | LL | let _ = Some("42").and_then(|s| if s.len() < 42 { Some(0) } else { Some(s.len()) }); | |
5 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
6 | | | |
7 | note: the lint level is defined here | |
923072b8 | 8 | --> $DIR/bind_instead_of_map_multipart.rs:2:9 |
f20569fa XL |
9 | | |
10 | LL | #![deny(clippy::bind_instead_of_map)] | |
11 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
12 | help: try this | |
13 | | | |
14 | LL | let _ = Some("42").map(|s| if s.len() < 42 { 0 } else { s.len() }); | |
94222f64 | 15 | | ~~~ ~ ~~~~~~~ |
f20569fa XL |
16 | |
17 | error: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` | |
923072b8 | 18 | --> $DIR/bind_instead_of_map_multipart.rs:9:13 |
f20569fa XL |
19 | | |
20 | LL | let _ = Ok::<_, ()>("42").and_then(|s| if s.len() < 42 { Ok(0) } else { Ok(s.len()) }); | |
21 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
22 | | | |
23 | help: try this | |
24 | | | |
25 | LL | let _ = Ok::<_, ()>("42").map(|s| if s.len() < 42 { 0 } else { s.len() }); | |
94222f64 | 26 | | ~~~ ~ ~~~~~~~ |
f20569fa XL |
27 | |
28 | error: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` | |
923072b8 | 29 | --> $DIR/bind_instead_of_map_multipart.rs:12:13 |
f20569fa XL |
30 | | |
31 | LL | let _ = Err::<(), _>("42").or_else(|s| if s.len() < 42 { Err(s.len() + 20) } else { Err(s.len()) }); | |
32 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
33 | | | |
34 | help: try this | |
35 | | | |
36 | LL | let _ = Err::<(), _>("42").map_err(|s| if s.len() < 42 { s.len() + 20 } else { s.len() }); | |
94222f64 | 37 | | ~~~~~~~ ~~~~~~~~~~~~ ~~~~~~~ |
f20569fa XL |
38 | |
39 | error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` | |
923072b8 | 40 | --> $DIR/bind_instead_of_map_multipart.rs:20:5 |
f20569fa XL |
41 | | |
42 | LL | / Some("42").and_then(|s| { | |
43 | LL | | if { | |
44 | LL | | if s == "43" { | |
45 | LL | | return Some(43); | |
46 | ... | | |
47 | LL | | } | |
48 | LL | | }); | |
49 | | |______^ | |
50 | | | |
51 | help: try this | |
52 | | | |
94222f64 | 53 | LL ~ Some("42").map(|s| { |
f20569fa XL |
54 | LL | if { |
55 | LL | if s == "43" { | |
94222f64 | 56 | LL ~ return 43; |
f20569fa XL |
57 | LL | } |
58 | LL | s == "42" | |
923072b8 FG |
59 | LL | } { |
60 | LL ~ return 45; | |
61 | LL | } | |
62 | LL | match s.len() { | |
63 | LL ~ 10 => 2, | |
64 | LL | 20 => { | |
f20569fa | 65 | ... |
923072b8 FG |
66 | LL | if foo() { |
67 | LL ~ return 20; | |
68 | LL | } | |
69 | LL | println!("foo"); | |
70 | LL ~ 3 | |
71 | LL | }; | |
72 | LL | } | |
73 | LL ~ 20 | |
74 | LL | }, | |
75 | LL ~ 40 => 30, | |
76 | LL ~ _ => 1, | |
77 | | | |
f20569fa XL |
78 | |
79 | error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` | |
923072b8 | 80 | --> $DIR/bind_instead_of_map_multipart.rs:61:13 |
f20569fa XL |
81 | | |
82 | LL | let _ = Some("").and_then(|s| if s.len() == 20 { Some(m!()) } else { Some(Some(20)) }); | |
83 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
84 | | | |
85 | help: try this | |
86 | | | |
87 | LL | let _ = Some("").map(|s| if s.len() == 20 { m!() } else { Some(20) }); | |
94222f64 | 88 | | ~~~ ~~~~ ~~~~~~~~ |
f20569fa XL |
89 | |
90 | error: aborting due to 5 previous errors | |
91 |