]>
Commit | Line | Data |
---|---|---|
f20569fa | 1 | error: use Vec::sort here instead |
781aab86 | 2 | --> $DIR/unnecessary_sort_by.rs:12:5 |
f20569fa XL |
3 | | |
4 | LL | vec.sort_by(|a, b| a.cmp(b)); | |
5 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort()` | |
6 | | | |
7 | = note: `-D clippy::unnecessary-sort-by` implied by `-D warnings` | |
781aab86 | 8 | = help: to override `-D warnings` add `#[allow(clippy::unnecessary_sort_by)]` |
f20569fa XL |
9 | |
10 | error: use Vec::sort here instead | |
781aab86 | 11 | --> $DIR/unnecessary_sort_by.rs:13:5 |
f20569fa XL |
12 | | |
13 | LL | vec.sort_unstable_by(|a, b| a.cmp(b)); | |
14 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable()` | |
15 | ||
16 | error: use Vec::sort_by_key here instead | |
781aab86 | 17 | --> $DIR/unnecessary_sort_by.rs:14:5 |
f20569fa XL |
18 | | |
19 | LL | vec.sort_by(|a, b| (a + 5).abs().cmp(&(b + 5).abs())); | |
20 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_by_key(|a| (a + 5).abs())` | |
21 | ||
22 | error: use Vec::sort_by_key here instead | |
781aab86 | 23 | --> $DIR/unnecessary_sort_by.rs:15:5 |
f20569fa XL |
24 | | |
25 | LL | vec.sort_unstable_by(|a, b| id(-a).cmp(&id(-b))); | |
26 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable_by_key(|a| id(-a))` | |
27 | ||
28 | error: use Vec::sort_by_key here instead | |
781aab86 | 29 | --> $DIR/unnecessary_sort_by.rs:18:5 |
f20569fa XL |
30 | | |
31 | LL | vec.sort_by(|a, b| (b + 5).abs().cmp(&(a + 5).abs())); | |
5e7ed085 | 32 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_by_key(|b| std::cmp::Reverse((b + 5).abs()))` |
f20569fa XL |
33 | |
34 | error: use Vec::sort_by_key here instead | |
781aab86 | 35 | --> $DIR/unnecessary_sort_by.rs:19:5 |
f20569fa XL |
36 | | |
37 | LL | vec.sort_unstable_by(|a, b| id(-b).cmp(&id(-a))); | |
5e7ed085 | 38 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable_by_key(|b| std::cmp::Reverse(id(-b)))` |
f20569fa XL |
39 | |
40 | error: use Vec::sort_by_key here instead | |
781aab86 | 41 | --> $DIR/unnecessary_sort_by.rs:29:5 |
f20569fa XL |
42 | | |
43 | LL | vec.sort_by(|a, b| (***a).abs().cmp(&(***b).abs())); | |
44 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_by_key(|a| (***a).abs())` | |
45 | ||
46 | error: use Vec::sort_by_key here instead | |
781aab86 | 47 | --> $DIR/unnecessary_sort_by.rs:30:5 |
f20569fa XL |
48 | | |
49 | LL | vec.sort_unstable_by(|a, b| (***a).abs().cmp(&(***b).abs())); | |
50 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable_by_key(|a| (***a).abs())` | |
51 | ||
52 | error: use Vec::sort_by_key here instead | |
781aab86 | 53 | --> $DIR/unnecessary_sort_by.rs:89:9 |
f20569fa XL |
54 | | |
55 | LL | args.sort_by(|a, b| a.name().cmp(&b.name())); | |
56 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_by_key(|a| a.name())` | |
57 | ||
58 | error: use Vec::sort_by_key here instead | |
781aab86 | 59 | --> $DIR/unnecessary_sort_by.rs:90:9 |
f20569fa XL |
60 | | |
61 | LL | args.sort_unstable_by(|a, b| a.name().cmp(&b.name())); | |
62 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_unstable_by_key(|a| a.name())` | |
63 | ||
64 | error: use Vec::sort_by_key here instead | |
781aab86 | 65 | --> $DIR/unnecessary_sort_by.rs:92:9 |
f20569fa XL |
66 | | |
67 | LL | args.sort_by(|a, b| b.name().cmp(&a.name())); | |
5e7ed085 | 68 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_by_key(|b| std::cmp::Reverse(b.name()))` |
f20569fa XL |
69 | |
70 | error: use Vec::sort_by_key here instead | |
781aab86 | 71 | --> $DIR/unnecessary_sort_by.rs:93:9 |
f20569fa XL |
72 | | |
73 | LL | args.sort_unstable_by(|a, b| b.name().cmp(&a.name())); | |
5e7ed085 | 74 | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_unstable_by_key(|b| std::cmp::Reverse(b.name()))` |
f20569fa XL |
75 | |
76 | error: aborting due to 12 previous errors | |
77 |