]> git.proxmox.com Git - mirror_qemu.git/blame - tests/test-keyval.c
projects / mirror_qemu.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
libqtest: Fix qmp() & friends to abort on JSON parse errors
[mirror_qemu.git] / tests / test-keyval.c
CommitLineData
d454dbe0
MA		 1/*
2 * Unit tests for parsing of KEY=VALUE,... strings
3 *
4 * Copyright (C) 2017 Red Hat Inc.
5 *
6 * Authors:
7 * Markus Armbruster <armbru@redhat.com>,
8 *
9 * This work is licensed under the terms of the GNU GPL, version 2 or later.
10 * See the COPYING file in the top-level directory.
11 */
12
13#include "qemu/osdep.h"
14#include "qapi/error.h"
9e3943f8
MA		 15#include "qapi/qobject-input-visitor.h"
16#include "qemu/cutils.h"
d454dbe0
MA		 17#include "qemu/option.h"
18
19static void test_keyval_parse(void)
20{
21 Error *err = NULL;
22 QDict *qdict, *sub_qdict;
23 char long_key[129];
24 char *params;
25
26 /* Nothing */
27 qdict = keyval_parse("", NULL, &error_abort);
28 g_assert_cmpuint(qdict_size(qdict), ==, 0);
29 QDECREF(qdict);
30
31 /* Empty key (qemu_opts_parse() accepts this) */
32 qdict = keyval_parse("=val", NULL, &err);
33 error_free_or_abort(&err);
34 g_assert(!qdict);
35
36 /* Empty key fragment */
37 qdict = keyval_parse(".", NULL, &err);
38 error_free_or_abort(&err);
39 g_assert(!qdict);
40 qdict = keyval_parse("key.", NULL, &err);
41 error_free_or_abort(&err);
42 g_assert(!qdict);
43
44 /* Overlong key */
45 memset(long_key, 'a', 127);
46 long_key[127] = 'z';
47 long_key[128] = 0;
48 params = g_strdup_printf("k.%s=v", long_key);
49 qdict = keyval_parse(params + 2, NULL, &err);
50 error_free_or_abort(&err);
51 g_assert(!qdict);
52
53 /* Overlong key fragment */
54 qdict = keyval_parse(params, NULL, &err);
55 error_free_or_abort(&err);
56 g_assert(!qdict);
57 g_free(params);
58
59 /* Long key (qemu_opts_parse() accepts and truncates silently) */
60 params = g_strdup_printf("k.%s=v", long_key + 1);
61 qdict = keyval_parse(params + 2, NULL, &error_abort);
62 g_assert_cmpuint(qdict_size(qdict), ==, 1);
63 g_assert_cmpstr(qdict_get_try_str(qdict, long_key + 1), ==, "v");
64 QDECREF(qdict);
65
66 /* Long key fragment */
67 qdict = keyval_parse(params, NULL, &error_abort);
68 g_assert_cmpuint(qdict_size(qdict), ==, 1);
69 sub_qdict = qdict_get_qdict(qdict, "k");
70 g_assert(sub_qdict);
71 g_assert_cmpuint(qdict_size(sub_qdict), ==, 1);
72 g_assert_cmpstr(qdict_get_try_str(sub_qdict, long_key + 1), ==, "v");
73 QDECREF(qdict);
74 g_free(params);
75
76 /* Multiple keys, last one wins */
77 qdict = keyval_parse("a=1,b=2,,x,a=3", NULL, &error_abort);
78 g_assert_cmpuint(qdict_size(qdict), ==, 2);
79 g_assert_cmpstr(qdict_get_try_str(qdict, "a"), ==, "3");
80 g_assert_cmpstr(qdict_get_try_str(qdict, "b"), ==, "2,x");
81 QDECREF(qdict);
82
83 /* Even when it doesn't in qemu_opts_parse() */
84 qdict = keyval_parse("id=foo,id=bar", NULL, &error_abort);
85 g_assert_cmpuint(qdict_size(qdict), ==, 1);
86 g_assert_cmpstr(qdict_get_try_str(qdict, "id"), ==, "bar");
87 QDECREF(qdict);
88
89 /* Dotted keys */
90 qdict = keyval_parse("a.b.c=1,a.b.c=2,d=3", NULL, &error_abort);
91 g_assert_cmpuint(qdict_size(qdict), ==, 2);
92 sub_qdict = qdict_get_qdict(qdict, "a");
93 g_assert(sub_qdict);
94 g_assert_cmpuint(qdict_size(sub_qdict), ==, 1);
95 sub_qdict = qdict_get_qdict(sub_qdict, "b");
96 g_assert(sub_qdict);
97 g_assert_cmpuint(qdict_size(sub_qdict), ==, 1);
98 g_assert_cmpstr(qdict_get_try_str(sub_qdict, "c"), ==, "2");
99 g_assert_cmpstr(qdict_get_try_str(qdict, "d"), ==, "3");
100 QDECREF(qdict);
101
102 /* Inconsistent dotted keys */
103 qdict = keyval_parse("a.b=1,a=2", NULL, &err);
104 error_free_or_abort(&err);
105 g_assert(!qdict);
106 qdict = keyval_parse("a.b=1,a.b.c=2", NULL, &err);
107 error_free_or_abort(&err);
108 g_assert(!qdict);
109
110 /* Trailing comma is ignored */
111 qdict = keyval_parse("x=y,", NULL, &error_abort);
112 g_assert_cmpuint(qdict_size(qdict), ==, 1);
113 g_assert_cmpstr(qdict_get_try_str(qdict, "x"), ==, "y");
114 QDECREF(qdict);
115
116 /* Except when it isn't */
117 qdict = keyval_parse(",", NULL, &err);
118 error_free_or_abort(&err);
119 g_assert(!qdict);
120
121 /* Value containing ,id= not misinterpreted as qemu_opts_parse() does */
122 qdict = keyval_parse("x=,,id=bar", NULL, &error_abort);
123 g_assert_cmpuint(qdict_size(qdict), ==, 1);
124 g_assert_cmpstr(qdict_get_try_str(qdict, "x"), ==, ",id=bar");
125 QDECREF(qdict);
126
127 /* Anti-social ID is left to caller (qemu_opts_parse() rejects it) */
128 qdict = keyval_parse("id=666", NULL, &error_abort);
129 g_assert_cmpuint(qdict_size(qdict), ==, 1);
130 g_assert_cmpstr(qdict_get_try_str(qdict, "id"), ==, "666");
131 QDECREF(qdict);
132
133 /* Implied value not supported (unlike qemu_opts_parse()) */
134 qdict = keyval_parse("an,noaus,noaus=", NULL, &err);
135 error_free_or_abort(&err);
136 g_assert(!qdict);
137
138 /* Implied value, key "no" (qemu_opts_parse(): negated empty key) */
139 qdict = keyval_parse("no", NULL, &err);
140 error_free_or_abort(&err);
141 g_assert(!qdict);
142
143 /* Implied key */
144 qdict = keyval_parse("an,aus=off,noaus=", "implied", &error_abort);
145 g_assert_cmpuint(qdict_size(qdict), ==, 3);
146 g_assert_cmpstr(qdict_get_try_str(qdict, "implied"), ==, "an");
147 g_assert_cmpstr(qdict_get_try_str(qdict, "aus"), ==, "off");
148 g_assert_cmpstr(qdict_get_try_str(qdict, "noaus"), ==, "");
149 QDECREF(qdict);
150
151 /* Implied dotted key */
152 qdict = keyval_parse("val", "eins.zwei", &error_abort);
153 g_assert_cmpuint(qdict_size(qdict), ==, 1);
154 sub_qdict = qdict_get_qdict(qdict, "eins");
155 g_assert(sub_qdict);
156 g_assert_cmpuint(qdict_size(sub_qdict), ==, 1);
157 g_assert_cmpstr(qdict_get_try_str(sub_qdict, "zwei"), ==, "val");
158 QDECREF(qdict);
159
160 /* Implied key with empty value (qemu_opts_parse() accepts this) */
161 qdict = keyval_parse(",", "implied", &err);
162 error_free_or_abort(&err);
163 g_assert(!qdict);
164
165 /* Likewise (qemu_opts_parse(): implied key with comma value) */
166 qdict = keyval_parse(",,,a=1", "implied", &err);
167 error_free_or_abort(&err);
168 g_assert(!qdict);
169
170 /* Empty key is not an implied key */
171 qdict = keyval_parse("=val", "implied", &err);
172 error_free_or_abort(&err);
173 g_assert(!qdict);
174}
175
9e3943f8
MA		 176static void test_keyval_visit_bool(void)
177{
178 Error *err = NULL;
179 Visitor *v;
180 QDict *qdict;
181 bool b;
182
183 qdict = keyval_parse("bool1=on,bool2=off", NULL, &error_abort);
184 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
185 QDECREF(qdict);
186 visit_start_struct(v, NULL, NULL, 0, &error_abort);
187 visit_type_bool(v, "bool1", &b, &error_abort);
188 g_assert(b);
189 visit_type_bool(v, "bool2", &b, &error_abort);
190 g_assert(!b);
191 visit_check_struct(v, &error_abort);
192 visit_end_struct(v, NULL);
193 visit_free(v);
194
195 qdict = keyval_parse("bool1=offer", NULL, &error_abort);
196 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
197 QDECREF(qdict);
198 visit_start_struct(v, NULL, NULL, 0, &error_abort);
199 visit_type_bool(v, "bool1", &b, &err);
200 error_free_or_abort(&err);
201 visit_end_struct(v, NULL);
202 visit_free(v);
203}
204
205static void test_keyval_visit_number(void)
206{
207 Error *err = NULL;
208 Visitor *v;
209 QDict *qdict;
210 uint64_t u;
211
212 /* Lower limit zero */
213 qdict = keyval_parse("number1=0", NULL, &error_abort);
214 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
215 QDECREF(qdict);
216 visit_start_struct(v, NULL, NULL, 0, &error_abort);
217 visit_type_uint64(v, "number1", &u, &error_abort);
218 g_assert_cmpuint(u, ==, 0);
219 visit_check_struct(v, &error_abort);
220 visit_end_struct(v, NULL);
221 visit_free(v);
222
223 /* Upper limit 2^64-1 */
224 qdict = keyval_parse("number1=18446744073709551615,number2=-1",
225 NULL, &error_abort);
226 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
227 QDECREF(qdict);
228 visit_start_struct(v, NULL, NULL, 0, &error_abort);
229 visit_type_uint64(v, "number1", &u, &error_abort);
230 g_assert_cmphex(u, ==, UINT64_MAX);
231 visit_type_uint64(v, "number2", &u, &error_abort);
232 g_assert_cmphex(u, ==, UINT64_MAX);
233 visit_check_struct(v, &error_abort);
234 visit_end_struct(v, NULL);
235 visit_free(v);
236
237 /* Above upper limit */
238 qdict = keyval_parse("number1=18446744073709551616",
239 NULL, &error_abort);
240 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
241 QDECREF(qdict);
242 visit_start_struct(v, NULL, NULL, 0, &error_abort);
243 visit_type_uint64(v, "number1", &u, &err);
244 error_free_or_abort(&err);
245 visit_end_struct(v, NULL);
246 visit_free(v);
247
248 /* Below lower limit */
249 qdict = keyval_parse("number1=-18446744073709551616",
250 NULL, &error_abort);
251 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
252 QDECREF(qdict);
253 visit_start_struct(v, NULL, NULL, 0, &error_abort);
254 visit_type_uint64(v, "number1", &u, &err);
255 error_free_or_abort(&err);
256 visit_end_struct(v, NULL);
257 visit_free(v);
258
259 /* Hex and octal */
260 qdict = keyval_parse("number1=0x2a,number2=052",
261 NULL, &error_abort);
262 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
263 QDECREF(qdict);
264 visit_start_struct(v, NULL, NULL, 0, &error_abort);
265 visit_type_uint64(v, "number1", &u, &error_abort);
266 g_assert_cmpuint(u, ==, 42);
267 visit_type_uint64(v, "number2", &u, &error_abort);
268 g_assert_cmpuint(u, ==, 42);
269 visit_check_struct(v, &error_abort);
270 visit_end_struct(v, NULL);
271 visit_free(v);
272
273 /* Trailing crap */
274 qdict = keyval_parse("number1=3.14,number2=08",
275 NULL, &error_abort);
276 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
277 QDECREF(qdict);
278 visit_start_struct(v, NULL, NULL, 0, &error_abort);
279 visit_type_uint64(v, "number1", &u, &err);
280 error_free_or_abort(&err);
281 visit_type_uint64(v, "number2", &u, &err);
282 error_free_or_abort(&err);
283 visit_end_struct(v, NULL);
284 visit_free(v);
285}
286
287static void test_keyval_visit_size(void)
288{
289 Error *err = NULL;
290 Visitor *v;
291 QDict *qdict;
292 uint64_t sz;
293
294 /* Lower limit zero */
295 qdict = keyval_parse("sz1=0", NULL, &error_abort);
296 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
297 QDECREF(qdict);
298 visit_start_struct(v, NULL, NULL, 0, &error_abort);
299 visit_type_size(v, "sz1", &sz, &error_abort);
300 g_assert_cmpuint(sz, ==, 0);
301 visit_check_struct(v, &error_abort);
302 visit_end_struct(v, NULL);
303 visit_free(v);
304
305 /* Note: precision is 53 bits since we're parsing with strtod() */
306
307 /* Around limit of precision: 2^53-1, 2^53, 2^53+1 */
308 qdict = keyval_parse("sz1=9007199254740991,"
309 "sz2=9007199254740992,"
310 "sz3=9007199254740993",
311 NULL, &error_abort);
312 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
313 QDECREF(qdict);
314 visit_start_struct(v, NULL, NULL, 0, &error_abort);
315 visit_type_size(v, "sz1", &sz, &error_abort);
316 g_assert_cmphex(sz, ==, 0x1fffffffffffff);
317 visit_type_size(v, "sz2", &sz, &error_abort);
318 g_assert_cmphex(sz, ==, 0x20000000000000);
319 visit_type_size(v, "sz3", &sz, &error_abort);
320 g_assert_cmphex(sz, ==, 0x20000000000000);
321 visit_check_struct(v, &error_abort);
322 visit_end_struct(v, NULL);
323 visit_free(v);
324
325 /* Close to signed upper limit 0x7ffffffffffffc00 (53 msbs set) */
326 qdict = keyval_parse("sz1=9223372036854774784," /* 7ffffffffffffc00 */
327 "sz2=9223372036854775295", /* 7ffffffffffffdff */
328 NULL, &error_abort);
329 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
330 QDECREF(qdict);
331 visit_start_struct(v, NULL, NULL, 0, &error_abort);
332 visit_type_size(v, "sz1", &sz, &error_abort);
333 g_assert_cmphex(sz, ==, 0x7ffffffffffffc00);
334 visit_type_size(v, "sz2", &sz, &error_abort);
335 g_assert_cmphex(sz, ==, 0x7ffffffffffffc00);
336 visit_check_struct(v, &error_abort);
337 visit_end_struct(v, NULL);
338 visit_free(v);
339
340 /* Close to actual upper limit 0xfffffffffffff800 (53 msbs set) */
341 qdict = keyval_parse("sz1=18446744073709549568," /* fffffffffffff800 */
342 "sz2=18446744073709550591", /* fffffffffffffbff */
343 NULL, &error_abort);
344 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
345 QDECREF(qdict);
346 visit_start_struct(v, NULL, NULL, 0, &error_abort);
347 visit_type_size(v, "sz1", &sz, &error_abort);
348 g_assert_cmphex(sz, ==, 0xfffffffffffff800);
349 visit_type_size(v, "sz2", &sz, &error_abort);
350 g_assert_cmphex(sz, ==, 0xfffffffffffff800);
351 visit_check_struct(v, &error_abort);
352 visit_end_struct(v, NULL);
353 visit_free(v);
354
355 /* Beyond limits */
356 qdict = keyval_parse("sz1=-1,"
357 "sz2=18446744073709550592", /* fffffffffffffc00 */
358 NULL, &error_abort);
359 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
360 QDECREF(qdict);
361 visit_start_struct(v, NULL, NULL, 0, &error_abort);
362 visit_type_size(v, "sz1", &sz, &err);
363 error_free_or_abort(&err);
364 visit_type_size(v, "sz2", &sz, &err);
365 error_free_or_abort(&err);
366 visit_end_struct(v, NULL);
367 visit_free(v);
368
369 /* Suffixes */
370 qdict = keyval_parse("sz1=8b,sz2=1.5k,sz3=2M,sz4=0.1G,sz5=16777215T",
371 NULL, &error_abort);
372 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
373 QDECREF(qdict);
374 visit_start_struct(v, NULL, NULL, 0, &error_abort);
375 visit_type_size(v, "sz1", &sz, &error_abort);
376 g_assert_cmpuint(sz, ==, 8);
377 visit_type_size(v, "sz2", &sz, &error_abort);
378 g_assert_cmpuint(sz, ==, 1536);
379 visit_type_size(v, "sz3", &sz, &error_abort);
380 g_assert_cmphex(sz, ==, 2 * M_BYTE);
381 visit_type_size(v, "sz4", &sz, &error_abort);
382 g_assert_cmphex(sz, ==, G_BYTE / 10);
383 visit_type_size(v, "sz5", &sz, &error_abort);
384 g_assert_cmphex(sz, ==, 16777215 * T_BYTE);
385 visit_check_struct(v, &error_abort);
386 visit_end_struct(v, NULL);
387 visit_free(v);
388
389 /* Beyond limit with suffix */
390 qdict = keyval_parse("sz1=16777216T", NULL, &error_abort);
391 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
392 QDECREF(qdict);
393 visit_start_struct(v, NULL, NULL, 0, &error_abort);
394 visit_type_size(v, "sz1", &sz, &err);
395 error_free_or_abort(&err);
396 visit_end_struct(v, NULL);
397 visit_free(v);
398
399 /* Trailing crap */
400 qdict = keyval_parse("sz1=16E,sz2=16Gi", NULL, &error_abort);
401 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
402 QDECREF(qdict);
403 visit_start_struct(v, NULL, NULL, 0, &error_abort);
404 visit_type_size(v, "sz1", &sz, &err);
405 error_free_or_abort(&err);
406 visit_type_size(v, "sz2", &sz, &err);
407 error_free_or_abort(&err);
408 visit_end_struct(v, NULL);
409 visit_free(v);
410}
411
412static void test_keyval_visit_dict(void)
413{
414 Error *err = NULL;
415 Visitor *v;
416 QDict *qdict;
417 int64_t i;
418
419 qdict = keyval_parse("a.b.c=1,a.b.c=2,d=3", NULL, &error_abort);
420 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
421 QDECREF(qdict);
422 visit_start_struct(v, NULL, NULL, 0, &error_abort);
423 visit_start_struct(v, "a", NULL, 0, &error_abort);
424 visit_start_struct(v, "b", NULL, 0, &error_abort);
425 visit_type_int(v, "c", &i, &error_abort);
426 g_assert_cmpint(i, ==, 2);
427 visit_check_struct(v, &error_abort);
428 visit_end_struct(v, NULL);
429 visit_check_struct(v, &error_abort);
430 visit_end_struct(v, NULL);
431 visit_type_int(v, "d", &i, &error_abort);
432 g_assert_cmpint(i, ==, 3);
433 visit_check_struct(v, &error_abort);
434 visit_end_struct(v, NULL);
435 visit_free(v);
436
437 qdict = keyval_parse("a.b=", NULL, &error_abort);
438 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
439 QDECREF(qdict);
440 visit_start_struct(v, NULL, NULL, 0, &error_abort);
441 visit_start_struct(v, "a", NULL, 0, &error_abort);
442 visit_type_int(v, "c", &i, &err); /* a.c missing */
443 error_free_or_abort(&err);
444 visit_check_struct(v, &err);
445 error_free_or_abort(&err); /* a.b unexpected */
446 visit_end_struct(v, NULL);
447 visit_check_struct(v, &error_abort);
448 visit_end_struct(v, NULL);
449 visit_free(v);
450}
451
452static void test_keyval_visit_optional(void)
453{
454 Visitor *v;
455 QDict *qdict;
456 bool present;
457 int64_t i;
458
459 qdict = keyval_parse("a.b=1", NULL, &error_abort);
460 v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
461 QDECREF(qdict);
462 visit_start_struct(v, NULL, NULL, 0, &error_abort);
463 visit_optional(v, "b", &present);
464 g_assert(!present); /* b missing */
465 visit_optional(v, "a", &present);
466 g_assert(present); /* a present */
467 visit_start_struct(v, "a", NULL, 0, &error_abort);
468 visit_optional(v, "b", &present);
469 g_assert(present); /* a.b present */
470 visit_type_int(v, "b", &i, &error_abort);
471 g_assert_cmpint(i, ==, 1);
472 visit_optional(v, "a", &present);
473 g_assert(!present); /* a.a missing */
474 visit_check_struct(v, &error_abort);
475 visit_end_struct(v, NULL);
476 visit_check_struct(v, &error_abort);
477 visit_end_struct(v, NULL);
478 visit_free(v);
479}
480
d454dbe0
MA		 481int main(int argc, char *argv[])
482{
483 g_test_init(&argc, &argv, NULL);
484 g_test_add_func("/keyval/keyval_parse", test_keyval_parse);
9e3943f8
MA		 485 g_test_add_func("/keyval/visit/bool", test_keyval_visit_bool);
486 g_test_add_func("/keyval/visit/number", test_keyval_visit_number);
487 g_test_add_func("/keyval/visit/size", test_keyval_visit_size);
488 g_test_add_func("/keyval/visit/dict", test_keyval_visit_dict);
489 g_test_add_func("/keyval/visit/optional", test_keyval_visit_optional);
d454dbe0
MA		 490 g_test_run();
491 return 0;
492}
QEMU mirror