]>
Commit | Line | Data |
---|---|---|
8035e428 IM |
1 | /* |
2 | * builtin-annotate.c | |
3 | * | |
4 | * Builtin annotate command: Analyze the perf.data input file, | |
5 | * look up and read DSOs and symbol information and display | |
6 | * a histogram of results, along various sorting keys. | |
7 | */ | |
8 | #include "builtin.h" | |
9 | ||
78f7defe | 10 | #include "util/util.h" |
8035e428 | 11 | #include "util/color.h" |
5da50258 | 12 | #include <linux/list.h> |
8035e428 | 13 | #include "util/cache.h" |
43cbcd8a | 14 | #include <linux/rbtree.h> |
8035e428 | 15 | #include "util/symbol.h" |
8035e428 IM |
16 | |
17 | #include "perf.h" | |
8f28827a | 18 | #include "util/debug.h" |
8035e428 | 19 | |
e248de33 ACM |
20 | #include "util/evlist.h" |
21 | #include "util/evsel.h" | |
78f7defe | 22 | #include "util/annotate.h" |
62daacb5 | 23 | #include "util/event.h" |
4b6ab94e | 24 | #include <subcmd/parse-options.h> |
8035e428 | 25 | #include "util/parse-events.h" |
6baa0a5a | 26 | #include "util/thread.h" |
dd68ada2 | 27 | #include "util/sort.h" |
3d1d07ec | 28 | #include "util/hist.h" |
94c744b6 | 29 | #include "util/session.h" |
45694aa7 | 30 | #include "util/tool.h" |
f5fc1412 | 31 | #include "util/data.h" |
68e94f4e | 32 | #include "arch/common.h" |
70fbe057 | 33 | #include "util/block-range.h" |
8035e428 | 34 | |
fc67297b | 35 | #include <dlfcn.h> |
5d67be97 AB |
36 | #include <linux/bitmap.h> |
37 | ||
d20deb64 | 38 | struct perf_annotate { |
45694aa7 | 39 | struct perf_tool tool; |
fa10f316 NK |
40 | struct perf_session *session; |
41 | bool use_tui, use_stdio, use_gtk; | |
7009cc34 ACM |
42 | bool full_paths; |
43 | bool print_line; | |
18c9e5c5 | 44 | bool skip_missing; |
7009cc34 ACM |
45 | const char *sym_hist_filter; |
46 | const char *cpu_list; | |
47 | DECLARE_BITMAP(cpu_bitmap, MAX_NR_CPUS); | |
d20deb64 | 48 | }; |
5d67be97 | 49 | |
70fbe057 PZ |
50 | /* |
51 | * Given one basic block: | |
52 | * | |
53 | * from to branch_i | |
54 | * * ----> * | |
55 | * | | |
56 | * | block | |
57 | * v | |
58 | * * ----> * | |
59 | * from to branch_i+1 | |
60 | * | |
61 | * where the horizontal are the branches and the vertical is the executed | |
62 | * block of instructions. | |
63 | * | |
64 | * We count, for each 'instruction', the number of blocks that covered it as | |
65 | * well as count the ratio each branch is taken. | |
66 | * | |
67 | * We can do this without knowing the actual instruction stream by keeping | |
68 | * track of the address ranges. We break down ranges such that there is no | |
69 | * overlap and iterate from the start until the end. | |
70 | * | |
71 | * @acme: once we parse the objdump output _before_ processing the samples, | |
72 | * we can easily fold the branch.cycles IPC bits in. | |
73 | */ | |
74 | static void process_basic_block(struct addr_map_symbol *start, | |
75 | struct addr_map_symbol *end, | |
76 | struct branch_flags *flags) | |
77 | { | |
78 | struct symbol *sym = start->sym; | |
79 | struct annotation *notes = sym ? symbol__annotation(sym) : NULL; | |
80 | struct block_range_iter iter; | |
81 | struct block_range *entry; | |
82 | ||
83 | /* | |
84 | * Sanity; NULL isn't executable and the CPU cannot execute backwards | |
85 | */ | |
86 | if (!start->addr || start->addr > end->addr) | |
87 | return; | |
88 | ||
89 | iter = block_range__create(start->addr, end->addr); | |
90 | if (!block_range_iter__valid(&iter)) | |
91 | return; | |
92 | ||
93 | /* | |
94 | * First block in range is a branch target. | |
95 | */ | |
96 | entry = block_range_iter(&iter); | |
97 | assert(entry->is_target); | |
98 | entry->entry++; | |
99 | ||
100 | do { | |
101 | entry = block_range_iter(&iter); | |
102 | ||
103 | entry->coverage++; | |
104 | entry->sym = sym; | |
105 | ||
106 | if (notes) | |
107 | notes->max_coverage = max(notes->max_coverage, entry->coverage); | |
108 | ||
109 | } while (block_range_iter__next(&iter)); | |
110 | ||
111 | /* | |
112 | * Last block in rage is a branch. | |
113 | */ | |
114 | entry = block_range_iter(&iter); | |
115 | assert(entry->is_branch); | |
116 | entry->taken++; | |
117 | if (flags->predicted) | |
118 | entry->pred++; | |
119 | } | |
120 | ||
121 | static void process_branch_stack(struct branch_stack *bs, struct addr_location *al, | |
122 | struct perf_sample *sample) | |
123 | { | |
124 | struct addr_map_symbol *prev = NULL; | |
125 | struct branch_info *bi; | |
126 | int i; | |
127 | ||
128 | if (!bs || !bs->nr) | |
129 | return; | |
130 | ||
131 | bi = sample__resolve_bstack(sample, al); | |
132 | if (!bi) | |
133 | return; | |
134 | ||
135 | for (i = bs->nr - 1; i >= 0; i--) { | |
136 | /* | |
137 | * XXX filter against symbol | |
138 | */ | |
139 | if (prev) | |
140 | process_basic_block(prev, &bi[i].from, &bi[i].flags); | |
141 | prev = &bi[i].to; | |
142 | } | |
143 | ||
144 | free(bi); | |
145 | } | |
146 | ||
d04b35f8 | 147 | static int perf_evsel__add_sample(struct perf_evsel *evsel, |
fd36f3dd | 148 | struct perf_sample *sample, |
d20deb64 ACM |
149 | struct addr_location *al, |
150 | struct perf_annotate *ann) | |
8035e428 | 151 | { |
4ea062ed | 152 | struct hists *hists = evsel__hists(evsel); |
628ada0c | 153 | struct hist_entry *he; |
e248de33 | 154 | int ret; |
628ada0c | 155 | |
7009cc34 ACM |
156 | if (ann->sym_hist_filter != NULL && |
157 | (al->sym == NULL || | |
158 | strcmp(ann->sym_hist_filter, al->sym->name) != 0)) { | |
628ada0c | 159 | /* We're only interested in a symbol named sym_hist_filter */ |
facf3f06 ACM |
160 | /* |
161 | * FIXME: why isn't this done in the symbol_filter when loading | |
162 | * the DSO? | |
163 | */ | |
628ada0c ACM |
164 | if (al->sym != NULL) { |
165 | rb_erase(&al->sym->rb_node, | |
166 | &al->map->dso->symbols[al->map->type]); | |
167 | symbol__delete(al->sym); | |
c0b4dffb | 168 | dso__reset_find_symbol_cache(al->map->dso); |
628ada0c ACM |
169 | } |
170 | return 0; | |
171 | } | |
172 | ||
70fbe057 PZ |
173 | /* |
174 | * XXX filtered samples can still have branch entires pointing into our | |
175 | * symbol and are missed. | |
176 | */ | |
177 | process_branch_stack(sample->branch_stack, al, sample); | |
178 | ||
fd36f3dd NK |
179 | sample->period = 1; |
180 | sample->weight = 1; | |
181 | ||
0102ef3e | 182 | he = hists__add_entry(hists, al, NULL, NULL, NULL, sample, true); |
9735abf1 | 183 | if (he == NULL) |
8035e428 | 184 | return -ENOMEM; |
628ada0c | 185 | |
00e55218 | 186 | ret = hist_entry__inc_addr_samples(he, evsel->idx, al->addr); |
4ea062ed | 187 | hists__inc_nr_samples(hists, true); |
e248de33 | 188 | return ret; |
8035e428 IM |
189 | } |
190 | ||
45694aa7 | 191 | static int process_sample_event(struct perf_tool *tool, |
d20deb64 | 192 | union perf_event *event, |
8115d60c | 193 | struct perf_sample *sample, |
9e69c210 | 194 | struct perf_evsel *evsel, |
743eb868 | 195 | struct machine *machine) |
8035e428 | 196 | { |
45694aa7 | 197 | struct perf_annotate *ann = container_of(tool, struct perf_annotate, tool); |
1ed091c4 | 198 | struct addr_location al; |
b91fc39f | 199 | int ret = 0; |
6baa0a5a | 200 | |
bb3eb566 | 201 | if (machine__resolve(machine, &al, sample) < 0) { |
29a9f66d ACM |
202 | pr_warning("problem processing %d event, skipping it.\n", |
203 | event->header.type); | |
8035e428 IM |
204 | return -1; |
205 | } | |
206 | ||
7009cc34 | 207 | if (ann->cpu_list && !test_bit(sample->cpu, ann->cpu_bitmap)) |
b91fc39f | 208 | goto out_put; |
5d67be97 | 209 | |
d20deb64 | 210 | if (!al.filtered && perf_evsel__add_sample(evsel, sample, &al, ann)) { |
29a9f66d ACM |
211 | pr_warning("problem incrementing symbol count, " |
212 | "skipping event\n"); | |
b91fc39f | 213 | ret = -1; |
8035e428 | 214 | } |
b91fc39f ACM |
215 | out_put: |
216 | addr_location__put(&al); | |
217 | return ret; | |
8035e428 IM |
218 | } |
219 | ||
db8fd07a NK |
220 | static int hist_entry__tty_annotate(struct hist_entry *he, |
221 | struct perf_evsel *evsel, | |
d20deb64 | 222 | struct perf_annotate *ann) |
0b73da3f | 223 | { |
db8fd07a | 224 | return symbol__tty_annotate(he->ms.sym, he->ms.map, evsel, |
7009cc34 | 225 | ann->print_line, ann->full_paths, 0, 0); |
0b73da3f IM |
226 | } |
227 | ||
c824c433 | 228 | static void hists__find_annotations(struct hists *hists, |
db8fd07a | 229 | struct perf_evsel *evsel, |
d20deb64 | 230 | struct perf_annotate *ann) |
0b73da3f | 231 | { |
c824c433 | 232 | struct rb_node *nd = rb_first(&hists->entries), *next; |
cf958003 | 233 | int key = K_RIGHT; |
0b73da3f | 234 | |
46e3e055 | 235 | while (nd) { |
ed52ce2e | 236 | struct hist_entry *he = rb_entry(nd, struct hist_entry, rb_node); |
78f7defe | 237 | struct annotation *notes; |
0b73da3f | 238 | |
46e3e055 ACM |
239 | if (he->ms.sym == NULL || he->ms.map->dso->annotate_warned) |
240 | goto find_next; | |
0b73da3f | 241 | |
78f7defe | 242 | notes = symbol__annotation(he->ms.sym); |
ce6f4fab | 243 | if (notes->src == NULL) { |
46e3e055 | 244 | find_next: |
cf958003 | 245 | if (key == K_LEFT) |
46e3e055 ACM |
246 | nd = rb_prev(nd); |
247 | else | |
248 | nd = rb_next(nd); | |
e4204992 | 249 | continue; |
46e3e055 | 250 | } |
e4204992 | 251 | |
2b676bf0 | 252 | if (use_browser == 2) { |
18c9e5c5 | 253 | int ret; |
fc67297b NK |
254 | int (*annotate)(struct hist_entry *he, |
255 | struct perf_evsel *evsel, | |
256 | struct hist_browser_timer *hbt); | |
257 | ||
258 | annotate = dlsym(perf_gtk_handle, | |
259 | "hist_entry__gtk_annotate"); | |
260 | if (annotate == NULL) { | |
261 | ui__error("GTK browser not found!\n"); | |
262 | return; | |
263 | } | |
18c9e5c5 | 264 | |
fc67297b | 265 | ret = annotate(he, evsel, NULL); |
18c9e5c5 NK |
266 | if (!ret || !ann->skip_missing) |
267 | return; | |
268 | ||
269 | /* skip missing symbols */ | |
270 | nd = rb_next(nd); | |
2b676bf0 | 271 | } else if (use_browser == 1) { |
db8fd07a | 272 | key = hist_entry__tui_annotate(he, evsel, NULL); |
46e3e055 | 273 | switch (key) { |
18c9e5c5 NK |
274 | case -1: |
275 | if (!ann->skip_missing) | |
276 | return; | |
277 | /* fall through */ | |
cf958003 | 278 | case K_RIGHT: |
b50e003d | 279 | next = rb_next(nd); |
46e3e055 | 280 | break; |
cf958003 | 281 | case K_LEFT: |
b50e003d | 282 | next = rb_prev(nd); |
46e3e055 | 283 | break; |
b50e003d ACM |
284 | default: |
285 | return; | |
46e3e055 | 286 | } |
b50e003d ACM |
287 | |
288 | if (next != NULL) | |
289 | nd = next; | |
46e3e055 | 290 | } else { |
db8fd07a | 291 | hist_entry__tty_annotate(he, evsel, ann); |
46e3e055 ACM |
292 | nd = rb_next(nd); |
293 | /* | |
294 | * Since we have a hist_entry per IP for the same | |
ce6f4fab | 295 | * symbol, free he->ms.sym->src to signal we already |
46e3e055 ACM |
296 | * processed this symbol. |
297 | */ | |
d4957633 | 298 | zfree(¬es->src->cycles_hist); |
04662523 | 299 | zfree(¬es->src); |
46e3e055 | 300 | } |
0b73da3f | 301 | } |
0b73da3f IM |
302 | } |
303 | ||
d20deb64 | 304 | static int __cmd_annotate(struct perf_annotate *ann) |
8035e428 | 305 | { |
bab81b62 | 306 | int ret; |
fa10f316 | 307 | struct perf_session *session = ann->session; |
e248de33 ACM |
308 | struct perf_evsel *pos; |
309 | u64 total_nr_samples; | |
94c744b6 | 310 | |
7009cc34 ACM |
311 | if (ann->cpu_list) { |
312 | ret = perf_session__cpu_bitmap(session, ann->cpu_list, | |
313 | ann->cpu_bitmap); | |
5d67be97 | 314 | if (ret) |
fa10f316 | 315 | goto out; |
5d67be97 AB |
316 | } |
317 | ||
68e94f4e | 318 | if (!objdump_path) { |
eebd0bfc | 319 | ret = perf_env__lookup_objdump(&session->header.env); |
68e94f4e | 320 | if (ret) |
fa10f316 | 321 | goto out; |
68e94f4e IT |
322 | } |
323 | ||
b7b61cbe | 324 | ret = perf_session__process_events(session); |
bab81b62 | 325 | if (ret) |
fa10f316 | 326 | goto out; |
8035e428 | 327 | |
62daacb5 | 328 | if (dump_trace) { |
c8446b9b | 329 | perf_session__fprintf_nr_events(session, stdout); |
2a1731fb | 330 | perf_evlist__fprintf_nr_events(session->evlist, stdout); |
fa10f316 | 331 | goto out; |
62daacb5 | 332 | } |
8035e428 | 333 | |
da21d1b5 | 334 | if (verbose > 3) |
b3165f41 | 335 | perf_session__fprintf(session, stdout); |
8035e428 | 336 | |
da21d1b5 | 337 | if (verbose > 2) |
cbf69680 | 338 | perf_session__fprintf_dsos(session, stdout); |
8035e428 | 339 | |
e248de33 | 340 | total_nr_samples = 0; |
e5cadb93 | 341 | evlist__for_each_entry(session->evlist, pos) { |
4ea062ed | 342 | struct hists *hists = evsel__hists(pos); |
e248de33 ACM |
343 | u32 nr_samples = hists->stats.nr_events[PERF_RECORD_SAMPLE]; |
344 | ||
345 | if (nr_samples > 0) { | |
346 | total_nr_samples += nr_samples; | |
c1fb5651 | 347 | hists__collapse_resort(hists, NULL); |
f9db0d0f KL |
348 | /* Don't sort callchain */ |
349 | perf_evsel__reset_sample_bit(pos, CALLCHAIN); | |
452ce03b | 350 | perf_evsel__output_resort(pos, NULL); |
b1dd4432 NK |
351 | |
352 | if (symbol_conf.event_group && | |
353 | !perf_evsel__is_group_leader(pos)) | |
354 | continue; | |
355 | ||
db8fd07a | 356 | hists__find_annotations(hists, pos, ann); |
e248de33 ACM |
357 | } |
358 | } | |
8035e428 | 359 | |
e248de33 | 360 | if (total_nr_samples == 0) { |
fa10f316 NK |
361 | ui__error("The %s file has no samples!\n", session->file->path); |
362 | goto out; | |
e248de33 | 363 | } |
7a60ba94 | 364 | |
fc67297b NK |
365 | if (use_browser == 2) { |
366 | void (*show_annotations)(void); | |
367 | ||
368 | show_annotations = dlsym(perf_gtk_handle, | |
369 | "perf_gtk__show_annotations"); | |
370 | if (show_annotations == NULL) { | |
371 | ui__error("GTK browser not found!\n"); | |
fa10f316 | 372 | goto out; |
fc67297b NK |
373 | } |
374 | show_annotations(); | |
375 | } | |
7a60ba94 | 376 | |
fa10f316 | 377 | out: |
bab81b62 | 378 | return ret; |
8035e428 IM |
379 | } |
380 | ||
381 | static const char * const annotate_usage[] = { | |
99345254 | 382 | "perf annotate [<options>]", |
8035e428 IM |
383 | NULL |
384 | }; | |
385 | ||
b0ad8ea6 | 386 | int cmd_annotate(int argc, const char **argv) |
d20deb64 ACM |
387 | { |
388 | struct perf_annotate annotate = { | |
45694aa7 | 389 | .tool = { |
d20deb64 ACM |
390 | .sample = process_sample_event, |
391 | .mmap = perf_event__process_mmap, | |
5c5e854b | 392 | .mmap2 = perf_event__process_mmap2, |
d20deb64 | 393 | .comm = perf_event__process_comm, |
ec4622f5 | 394 | .exit = perf_event__process_exit, |
f62d3f0f | 395 | .fork = perf_event__process_fork, |
f3b3614a | 396 | .namespaces = perf_event__process_namespaces, |
0a8cb85c | 397 | .ordered_events = true, |
d20deb64 ACM |
398 | .ordering_requires_timestamps = true, |
399 | }, | |
d20deb64 | 400 | }; |
fa10f316 | 401 | struct perf_data_file file = { |
fa10f316 NK |
402 | .mode = PERF_DATA_MODE_READ, |
403 | }; | |
d20deb64 | 404 | const struct option options[] = { |
70cb4e96 | 405 | OPT_STRING('i', "input", &input_name, "file", |
8035e428 | 406 | "input file name"), |
ac73c5a9 ACM |
407 | OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]", |
408 | "only consider symbols in these dsos"), | |
7009cc34 | 409 | OPT_STRING('s', "symbol", &annotate.sym_hist_filter, "symbol", |
0b73da3f | 410 | "symbol to annotate"), |
fa10f316 | 411 | OPT_BOOLEAN('f', "force", &file.force, "don't complain, do it"), |
c0555642 | 412 | OPT_INCR('v', "verbose", &verbose, |
8035e428 | 413 | "be more verbose (show symbol address, etc)"), |
eddaef88 | 414 | OPT_BOOLEAN('q', "quiet", &quiet, "do now show any message"), |
8035e428 IM |
415 | OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, |
416 | "dump raw trace in ASCII"), | |
2b676bf0 | 417 | OPT_BOOLEAN(0, "gtk", &annotate.use_gtk, "Use the GTK interface"), |
7009cc34 ACM |
418 | OPT_BOOLEAN(0, "tui", &annotate.use_tui, "Use the TUI interface"), |
419 | OPT_BOOLEAN(0, "stdio", &annotate.use_stdio, "Use the stdio interface"), | |
b32d133a ACM |
420 | OPT_STRING('k', "vmlinux", &symbol_conf.vmlinux_name, |
421 | "file", "vmlinux pathname"), | |
422 | OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules, | |
42976487 | 423 | "load module symbols - WARNING: use only with -k and LIVE kernel"), |
7009cc34 | 424 | OPT_BOOLEAN('l', "print-line", &annotate.print_line, |
301406b9 | 425 | "print matching source lines (may be slow)"), |
7009cc34 | 426 | OPT_BOOLEAN('P', "full-paths", &annotate.full_paths, |
42976487 | 427 | "Don't shorten the displayed pathnames"), |
18c9e5c5 NK |
428 | OPT_BOOLEAN(0, "skip-missing", &annotate.skip_missing, |
429 | "Skip symbols that cannot be annotated"), | |
c8e66720 | 430 | OPT_STRING('C', "cpu", &annotate.cpu_list, "cpu", "list of cpus to profile"), |
a7066709 HK |
431 | OPT_CALLBACK(0, "symfs", NULL, "directory", |
432 | "Look for files with symbols relative to this directory", | |
433 | symbol__config_symfs), | |
64c6f0c7 | 434 | OPT_BOOLEAN(0, "source", &symbol_conf.annotate_src, |
3e6a2a7f | 435 | "Interleave source code with assembly code (default)"), |
64c6f0c7 | 436 | OPT_BOOLEAN(0, "asm-raw", &symbol_conf.annotate_asm_raw, |
3e6a2a7f | 437 | "Display raw encoding of assembly instructions (default)"), |
f69b64f7 AK |
438 | OPT_STRING('M', "disassembler-style", &disassembler_style, "disassembler style", |
439 | "Specify disassembler style (e.g. -M intel for intel syntax)"), | |
7a4ec938 MB |
440 | OPT_STRING(0, "objdump", &objdump_path, "path", |
441 | "objdump binary to use for disassembly and annotations"), | |
b1dd4432 NK |
442 | OPT_BOOLEAN(0, "group", &symbol_conf.event_group, |
443 | "Show event group information together"), | |
0c4a5bce ML |
444 | OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period, |
445 | "Show a column with the sum of periods"), | |
53fe4ba1 ACM |
446 | OPT_CALLBACK_DEFAULT(0, "stdio-color", NULL, "mode", |
447 | "'always' (default), 'never' or 'auto' only applicable to --stdio mode", | |
448 | stdio__config_color, "always"), | |
8035e428 | 449 | OPT_END() |
d20deb64 | 450 | }; |
a635fc51 ACM |
451 | int ret = hists__init(); |
452 | ||
453 | if (ret < 0) | |
454 | return ret; | |
8035e428 | 455 | |
655000e7 | 456 | argc = parse_options(argc, argv, options, annotate_usage, 0); |
50e19ef9 NK |
457 | if (argc) { |
458 | /* | |
459 | * Special case: if there's an argument left then assume that | |
460 | * it's a symbol filter: | |
461 | */ | |
462 | if (argc > 1) | |
463 | usage_with_options(annotate_usage, options); | |
464 | ||
465 | annotate.sym_hist_filter = argv[0]; | |
466 | } | |
655000e7 | 467 | |
eddaef88 NK |
468 | if (quiet) |
469 | perf_quiet_option(); | |
470 | ||
44848cdb ML |
471 | file.path = input_name; |
472 | ||
fa10f316 NK |
473 | annotate.session = perf_session__new(&file, false, &annotate.tool); |
474 | if (annotate.session == NULL) | |
52e02834 | 475 | return -1; |
fa10f316 | 476 | |
b01141f4 ACM |
477 | ret = symbol__annotation_init(); |
478 | if (ret < 0) | |
479 | goto out_delete; | |
480 | ||
75be6cf4 ACM |
481 | symbol_conf.try_vmlinux_path = true; |
482 | ||
0a7e6d1b | 483 | ret = symbol__init(&annotate.session->header.env); |
fa10f316 NK |
484 | if (ret < 0) |
485 | goto out_delete; | |
8035e428 | 486 | |
40184c46 | 487 | if (setup_sorting(NULL) < 0) |
55309985 | 488 | usage_with_options(annotate_usage, options); |
8035e428 | 489 | |
3df668e7 NK |
490 | if (annotate.use_stdio) |
491 | use_browser = 0; | |
492 | else if (annotate.use_tui) | |
493 | use_browser = 1; | |
494 | else if (annotate.use_gtk) | |
495 | use_browser = 2; | |
496 | ||
497 | setup_browser(true); | |
498 | ||
fa10f316 NK |
499 | ret = __cmd_annotate(&annotate); |
500 | ||
501 | out_delete: | |
502 | /* | |
503 | * Speed up the exit process, for large files this can | |
504 | * take quite a while. | |
505 | * | |
506 | * XXX Enable this when using valgrind or if we ever | |
507 | * librarize this command. | |
508 | * | |
509 | * Also experiment with obstacks to see how much speed | |
510 | * up we'll get here. | |
511 | * | |
512 | * perf_session__delete(session); | |
513 | */ | |
514 | return ret; | |
8035e428 | 515 | } |