]>
Commit | Line | Data |
---|---|---|
3cbe33df | 1 | /* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc. |
c93b1d6a | 2 | * |
a14bc59f BP |
3 | * Licensed under the Apache License, Version 2.0 (the "License"); |
4 | * you may not use this file except in compliance with the License. | |
5 | * You may obtain a copy of the License at: | |
064af421 | 6 | * |
a14bc59f | 7 | * http://www.apache.org/licenses/LICENSE-2.0 |
064af421 | 8 | * |
a14bc59f BP |
9 | * Unless required by applicable law or agreed to in writing, software |
10 | * distributed under the License is distributed on an "AS IS" BASIS, | |
11 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
12 | * See the License for the specific language governing permissions and | |
13 | * limitations under the License. | |
064af421 BP |
14 | */ |
15 | ||
16 | #include <config.h> | |
17 | #include "bridge.h" | |
064af421 | 18 | #include <errno.h> |
064af421 | 19 | #include <inttypes.h> |
064af421 | 20 | #include <stdlib.h> |
842733c3 | 21 | |
a5fb0e29 | 22 | #include "async-append.h" |
ccc09689 | 23 | #include "bfd.h" |
064af421 | 24 | #include "bitmap.h" |
b31bcf60 | 25 | #include "cfm.h" |
7f8f2757 | 26 | #include "connectivity.h" |
064af421 | 27 | #include "coverage.h" |
a7ff9bd7 | 28 | #include "daemon.h" |
064af421 | 29 | #include "dirs.h" |
842733c3 | 30 | #include "dpif.h" |
064af421 | 31 | #include "dynamic-string.h" |
064af421 | 32 | #include "hash.h" |
d9a8717a | 33 | #include "hmap.h" |
f145afdc | 34 | #include "hmapx.h" |
cd11000b | 35 | #include "jsonrpc.h" |
6aa74308 | 36 | #include "lacp.h" |
064af421 | 37 | #include "list.h" |
99eef98b | 38 | #include "ovs-lldp.h" |
e764773c | 39 | #include "mac-learning.h" |
dc2b70ba | 40 | #include "mcast-snooping.h" |
254750ce | 41 | #include "meta-flow.h" |
064af421 | 42 | #include "netdev.h" |
178742f9 | 43 | #include "nx-match.h" |
064af421 | 44 | #include "ofp-print.h" |
7beaa082 | 45 | #include "ofp-util.h" |
064af421 | 46 | #include "ofpbuf.h" |
9a54394a | 47 | #include "ofproto/bond.h" |
8cd4882f | 48 | #include "ofproto/ofproto.h" |
7c5a3bbf | 49 | #include "ovs-numa.h" |
064af421 | 50 | #include "poll-loop.h" |
e21c6643 | 51 | #include "if-notifier.h" |
7f8f2757 | 52 | #include "seq.h" |
76343538 | 53 | #include "sha1.h" |
6c88d577 | 54 | #include "shash.h" |
79f1cbe9 | 55 | #include "smap.h" |
064af421 | 56 | #include "socket-util.h" |
5bd31620 | 57 | #include "stream.h" |
fe55ad15 | 58 | #include "stream-ssl.h" |
b3c01ed3 | 59 | #include "sset.h" |
ce887677 | 60 | #include "system-stats.h" |
064af421 BP |
61 | #include "timeval.h" |
62 | #include "util.h" | |
da285df4 | 63 | #include "unixctl.h" |
52a90c29 | 64 | #include "vlandev.h" |
eaa67ba8 | 65 | #include "lib/vswitch-idl.h" |
064af421 | 66 | #include "xenserver.h" |
e6211adc | 67 | #include "openvswitch/vlog.h" |
72b06300 | 68 | #include "sflow_api.h" |
0fb7b915 | 69 | #include "vlan-bitmap.h" |
3e5aeeb5 | 70 | #include "packets.h" |
064af421 | 71 | |
d98e6007 | 72 | VLOG_DEFINE_THIS_MODULE(bridge); |
064af421 | 73 | |
d76f09ea BP |
74 | COVERAGE_DEFINE(bridge_reconfigure); |
75 | ||
064af421 | 76 | struct iface { |
2a73b1d7 BP |
77 | /* These members are always valid. |
78 | * | |
79 | * They are immutable: they never change between iface_create() and | |
80 | * iface_destroy(). */ | |
ca6ba700 | 81 | struct ovs_list port_elem; /* Element in struct port's "ifaces" list. */ |
ebea37cc | 82 | struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */ |
2a73b1d7 | 83 | struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */ |
064af421 | 84 | struct port *port; /* Containing port. */ |
064af421 | 85 | char *name; /* Host network device name. */ |
0c6aea3f | 86 | struct netdev *netdev; /* Network device. */ |
2a73b1d7 | 87 | ofp_port_t ofp_port; /* OpenFlow port number. */ |
6a5f9a8f | 88 | uint64_t change_seq; |
2a73b1d7 BP |
89 | |
90 | /* These members are valid only within bridge_reconfigure(). */ | |
6cefe1da | 91 | const char *type; /* Usually same as cfg->type. */ |
76343538 | 92 | const struct ovsrec_interface *cfg; |
064af421 BP |
93 | }; |
94 | ||
064af421 | 95 | struct mirror { |
fa066f01 BP |
96 | struct uuid uuid; /* UUID of this "mirror" record in database. */ |
97 | struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */ | |
064af421 | 98 | struct bridge *bridge; |
064af421 | 99 | char *name; |
9d24de3b | 100 | const struct ovsrec_mirror *cfg; |
064af421 BP |
101 | }; |
102 | ||
064af421 | 103 | struct port { |
8052fb14 | 104 | struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */ |
6e492d81 | 105 | struct bridge *bridge; |
8052fb14 BP |
106 | char *name; |
107 | ||
1e0b752d | 108 | const struct ovsrec_port *cfg; |
064af421 BP |
109 | |
110 | /* An ordinary bridge port has 1 interface. | |
111 | * A bridge port for bonding has at least 2 interfaces. */ | |
ca6ba700 | 112 | struct ovs_list ifaces; /* List of "struct iface"s. */ |
064af421 BP |
113 | }; |
114 | ||
064af421 | 115 | struct bridge { |
764072fd | 116 | struct hmap_node node; /* In 'all_bridges'. */ |
064af421 | 117 | char *name; /* User-specified arbitrary name. */ |
66da9bef | 118 | char *type; /* Datapath type. */ |
74ff3298 JR |
119 | struct eth_addr ea; /* Bridge Ethernet Address. */ |
120 | struct eth_addr default_ea; /* Default MAC. */ | |
1e0b752d | 121 | const struct ovsrec_bridge *cfg; |
064af421 | 122 | |
064af421 BP |
123 | /* OpenFlow switch processing. */ |
124 | struct ofproto *ofproto; /* OpenFlow switch. */ | |
125 | ||
064af421 | 126 | /* Bridge ports. */ |
8052fb14 | 127 | struct hmap ports; /* "struct port"s indexed by name. */ |
892815f5 | 128 | struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */ |
ebea37cc | 129 | struct hmap iface_by_name; /* "struct iface"s indexed by name. */ |
064af421 | 130 | |
064af421 | 131 | /* Port mirroring. */ |
fa066f01 | 132 | struct hmap mirrors; /* "struct mirror" indexed by UUID. */ |
cfea354b | 133 | |
99eef98b DF |
134 | /* Auto Attach */ |
135 | struct hmap mappings; /* "struct" indexed by UUID */ | |
136 | ||
2a73b1d7 BP |
137 | /* Used during reconfiguration. */ |
138 | struct shash wanted_ports; | |
139 | ||
cfea354b BP |
140 | /* Synthetic local port if necessary. */ |
141 | struct ovsrec_port synth_local_port; | |
142 | struct ovsrec_interface synth_local_iface; | |
143 | struct ovsrec_interface *synth_local_ifacep; | |
064af421 BP |
144 | }; |
145 | ||
99eef98b DF |
146 | struct aa_mapping { |
147 | struct hmap_node hmap_node; /* In struct bridge's "mappings" hmap. */ | |
148 | struct bridge *bridge; | |
72c642e5 BP |
149 | uint32_t isid; |
150 | uint16_t vlan; | |
99eef98b DF |
151 | char *br_name; |
152 | }; | |
153 | ||
764072fd BP |
154 | /* All bridges, indexed by name. */ |
155 | static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges); | |
064af421 | 156 | |
c5187f17 BP |
157 | /* OVSDB IDL used to obtain configuration. */ |
158 | static struct ovsdb_idl *idl; | |
159 | ||
63ff04e8 BP |
160 | /* We want to complete daemonization, fully detaching from our parent process, |
161 | * only after we have completed our initial configuration, committed our state | |
162 | * to the database, and received confirmation back from the database server | |
163 | * that it applied the commit. This allows our parent process to know that, | |
164 | * post-detach, ephemeral fields such as datapath-id and ofport are very likely | |
165 | * to have already been filled in. (It is only "very likely" rather than | |
166 | * certain because there is always a slim possibility that the transaction will | |
167 | * fail or that some other client has added new bridges, ports, etc. while | |
168 | * ovs-vswitchd was configuring using an old configuration.) | |
169 | * | |
170 | * We only need to do this once for our initial configuration at startup, so | |
171 | * 'initial_config_done' tracks whether we've already done it. While we are | |
172 | * waiting for a response to our commit, 'daemonize_txn' tracks the transaction | |
173 | * itself and is otherwise NULL. */ | |
174 | static bool initial_config_done; | |
175 | static struct ovsdb_idl_txn *daemonize_txn; | |
176 | ||
854a94d9 BP |
177 | /* Most recently processed IDL sequence number. */ |
178 | static unsigned int idl_seqno; | |
179 | ||
7f8f2757 JS |
180 | /* Track changes to port connectivity. */ |
181 | static uint64_t connectivity_seqno = LLONG_MIN; | |
182 | ||
6a5f9a8f AW |
183 | /* Status update to database. |
184 | * | |
185 | * Some information in the database must be kept as up-to-date as possible to | |
186 | * allow controllers to respond rapidly to network outages. Those status are | |
187 | * updated via the 'status_txn'. | |
188 | * | |
189 | * We use the global connectivity sequence number to detect the status change. | |
190 | * Also, to prevent the status update from sending too much to the database, | |
191 | * we check the return status of each update transaction and do not start new | |
192 | * update if the previous transaction status is 'TXN_INCOMPLETE'. | |
193 | * | |
194 | * 'statux_txn' is NULL if there is no ongoing status update. | |
15c9fbd8 AW |
195 | * |
196 | * If the previous database transaction was failed (is not 'TXN_SUCCESS', | |
197 | * 'TXN_UNCHANGED' or 'TXN_INCOMPLETE'), 'status_txn_try_again' is set to true, | |
198 | * which will cause the main thread wake up soon and retry the status update. | |
6a5f9a8f AW |
199 | */ |
200 | static struct ovsdb_idl_txn *status_txn; | |
15c9fbd8 | 201 | static bool status_txn_try_again; |
6a5f9a8f AW |
202 | |
203 | /* When the status update transaction returns 'TXN_INCOMPLETE', should register a | |
204 | * timeout in 'STATUS_CHECK_AGAIN_MSEC' to check again. */ | |
205 | #define STATUS_CHECK_AGAIN_MSEC 100 | |
206 | ||
131d04dc AW |
207 | /* Statistics update to database. */ |
208 | static struct ovsdb_idl_txn *stats_txn; | |
209 | ||
35a22d8c | 210 | /* Each time this timer expires, the bridge fetches interface and mirror |
cd0cd65f | 211 | * statistics and pushes them into the database. */ |
12eb035b AW |
212 | static int stats_timer_interval; |
213 | static long long int stats_timer = LLONG_MIN; | |
018f1525 | 214 | |
99eef98b DF |
215 | /* Each time this timer expires, the bridge fetches the list of port/VLAN |
216 | * membership that has been modified by the AA. | |
217 | */ | |
218 | #define AA_REFRESH_INTERVAL (1000) /* In milliseconds. */ | |
219 | static long long int aa_refresh_timer = LLONG_MIN; | |
220 | ||
e21c6643 TLSC |
221 | /* Whenever system interfaces are added, removed or change state, the bridge |
222 | * will be reconfigured. | |
223 | */ | |
224 | static struct if_notifier *ifnotifier; | |
225 | static bool ifaces_changed = false; | |
226 | ||
66da9bef | 227 | static void add_del_bridges(const struct ovsrec_open_vswitch *); |
aeed7879 | 228 | static void bridge_run__(void); |
66da9bef | 229 | static void bridge_create(const struct ovsrec_bridge *); |
064af421 BP |
230 | static void bridge_destroy(struct bridge *); |
231 | static struct bridge *bridge_lookup(const char *name); | |
8ca79daa | 232 | static unixctl_cb_func bridge_unixctl_dump_flows; |
fa05809b | 233 | static unixctl_cb_func bridge_unixctl_reconnect; |
1a048029 | 234 | static size_t bridge_get_controllers(const struct bridge *br, |
76ce9432 | 235 | struct ovsrec_controller ***controllersp); |
2a73b1d7 BP |
236 | static void bridge_collect_wanted_ports(struct bridge *, |
237 | const unsigned long *splinter_vlans, | |
238 | struct shash *wanted_ports); | |
239 | static void bridge_delete_ofprotos(void); | |
240 | static void bridge_delete_or_reconfigure_ports(struct bridge *); | |
241 | static void bridge_del_ports(struct bridge *, | |
242 | const struct shash *wanted_ports); | |
243 | static void bridge_add_ports(struct bridge *, | |
244 | const struct shash *wanted_ports); | |
245 | ||
6f90b8f4 BP |
246 | static void bridge_configure_datapath_id(struct bridge *); |
247 | static void bridge_configure_netflow(struct bridge *); | |
8402c74b | 248 | static void bridge_configure_forward_bpdu(struct bridge *); |
c4069512 | 249 | static void bridge_configure_mac_table(struct bridge *); |
dc2b70ba | 250 | static void bridge_configure_mcast_snooping(struct bridge *); |
6f90b8f4 | 251 | static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number); |
29089a54 | 252 | static void bridge_configure_ipfix(struct bridge *); |
7af77bbd | 253 | static void bridge_configure_spanning_tree(struct bridge *); |
254750ce | 254 | static void bridge_configure_tables(struct bridge *); |
8b6ff729 | 255 | static void bridge_configure_dp_desc(struct bridge *); |
99eef98b DF |
256 | static void bridge_configure_aa(struct bridge *); |
257 | static void bridge_aa_refresh_queued(struct bridge *); | |
258 | static bool bridge_aa_need_refresh(struct bridge *); | |
fa066f01 BP |
259 | static void bridge_configure_remotes(struct bridge *, |
260 | const struct sockaddr_in *managers, | |
261 | size_t n_managers); | |
74ff3298 | 262 | static void bridge_pick_local_hw_addr(struct bridge *, struct eth_addr *ea, |
07c318f4 | 263 | struct iface **hw_addr_iface); |
064af421 | 264 | static uint64_t bridge_pick_datapath_id(struct bridge *, |
74ff3298 | 265 | const struct eth_addr bridge_ea, |
07c318f4 | 266 | struct iface *hw_addr_iface); |
064af421 | 267 | static uint64_t dpid_from_hash(const void *, size_t nbytes); |
e8192d80 BP |
268 | static bool bridge_has_bond_fake_iface(const struct bridge *, |
269 | const char *name); | |
270 | static bool port_is_bond_fake_iface(const struct port *); | |
064af421 | 271 | |
e8fe3026 | 272 | static unixctl_cb_func qos_unixctl_show; |
8c4c1387 | 273 | |
66da9bef | 274 | static struct port *port_create(struct bridge *, const struct ovsrec_port *); |
66da9bef | 275 | static void port_del_ifaces(struct port *); |
064af421 BP |
276 | static void port_destroy(struct port *); |
277 | static struct port *port_lookup(const struct bridge *, const char *name); | |
fa066f01 BP |
278 | static void port_configure(struct port *); |
279 | static struct lacp_settings *port_configure_lacp(struct port *, | |
280 | struct lacp_settings *); | |
df53d41c | 281 | static void port_configure_bond(struct port *, struct bond_settings *); |
06b592bc | 282 | static bool port_is_synthetic(const struct port *); |
fa066f01 | 283 | |
35a22d8c BP |
284 | static void reconfigure_system_stats(const struct ovsrec_open_vswitch *); |
285 | static void run_system_stats(void); | |
286 | ||
fa066f01 BP |
287 | static void bridge_configure_mirrors(struct bridge *); |
288 | static struct mirror *mirror_create(struct bridge *, | |
289 | const struct ovsrec_mirror *); | |
064af421 | 290 | static void mirror_destroy(struct mirror *); |
9d24de3b JP |
291 | static bool mirror_configure(struct mirror *); |
292 | static void mirror_refresh_stats(struct mirror *); | |
064af421 | 293 | |
fa066f01 | 294 | static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *); |
2a73b1d7 BP |
295 | static bool iface_create(struct bridge *, const struct ovsrec_interface *, |
296 | const struct ovsrec_port *); | |
05ba03e0 JP |
297 | static bool iface_is_internal(const struct ovsrec_interface *iface, |
298 | const struct ovsrec_bridge *br); | |
b54441b3 BP |
299 | static const char *iface_get_type(const struct ovsrec_interface *, |
300 | const struct ovsrec_bridge *); | |
064af421 | 301 | static void iface_destroy(struct iface *); |
96be8de5 | 302 | static void iface_destroy__(struct iface *); |
064af421 | 303 | static struct iface *iface_lookup(const struct bridge *, const char *name); |
e8fe3026 | 304 | static struct iface *iface_find(const char *name); |
892815f5 | 305 | static struct iface *iface_from_ofp_port(const struct bridge *, |
4e022ec0 | 306 | ofp_port_t ofp_port); |
21a955fc | 307 | static void iface_set_mac(const struct bridge *, const struct port *, struct iface *); |
4e022ec0 | 308 | static void iface_set_ofport(const struct ovsrec_interface *, ofp_port_t ofport); |
bbe6109d | 309 | static void iface_clear_db_record(const struct ovsrec_interface *if_cfg, char *errp); |
66da9bef BP |
310 | static void iface_configure_qos(struct iface *, const struct ovsrec_qos *); |
311 | static void iface_configure_cfm(struct iface *); | |
8f3fe844 | 312 | static void iface_refresh_cfm_stats(struct iface *); |
1101a0b4 | 313 | static void iface_refresh_stats(struct iface *); |
6a5f9a8f AW |
314 | static void iface_refresh_netdev_status(struct iface *); |
315 | static void iface_refresh_ofproto_status(struct iface *); | |
cfea354b | 316 | static bool iface_is_synthetic(const struct iface *); |
4abb8608 BP |
317 | static ofp_port_t iface_get_requested_ofp_port( |
318 | const struct ovsrec_interface *); | |
4e022ec0 | 319 | static ofp_port_t iface_pick_ofport(const struct ovsrec_interface *); |
52a90c29 | 320 | |
842733c3 | 321 | |
52a90c29 BP |
322 | /* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.) |
323 | * | |
324 | * This is deprecated. It is only for compatibility with broken device drivers | |
325 | * in old versions of Linux that do not properly support VLANs when VLAN | |
326 | * devices are not used. When broken device drivers are no longer in | |
327 | * widespread use, we will delete these interfaces. */ | |
328 | ||
329 | /* True if VLAN splinters are enabled on any interface, false otherwise.*/ | |
330 | static bool vlan_splinters_enabled_anywhere; | |
331 | ||
332 | static bool vlan_splinters_is_enabled(const struct ovsrec_interface *); | |
333 | static unsigned long int *collect_splinter_vlans( | |
334 | const struct ovsrec_open_vswitch *); | |
335 | static void configure_splinter_port(struct port *); | |
336 | static void add_vlan_splinter_ports(struct bridge *, | |
337 | const unsigned long int *splinter_vlans, | |
338 | struct shash *ports); | |
b0408fca | 339 | |
842733c3 MG |
340 | static void discover_types(const struct ovsrec_open_vswitch *cfg); |
341 | ||
b0408fca JP |
342 | static void |
343 | bridge_init_ofproto(const struct ovsrec_open_vswitch *cfg) | |
344 | { | |
345 | struct shash iface_hints; | |
346 | static bool initialized = false; | |
347 | int i; | |
348 | ||
349 | if (initialized) { | |
350 | return; | |
351 | } | |
352 | ||
353 | shash_init(&iface_hints); | |
354 | ||
b099cd5f EJ |
355 | if (cfg) { |
356 | for (i = 0; i < cfg->n_bridges; i++) { | |
357 | const struct ovsrec_bridge *br_cfg = cfg->bridges[i]; | |
358 | int j; | |
359 | ||
360 | for (j = 0; j < br_cfg->n_ports; j++) { | |
361 | struct ovsrec_port *port_cfg = br_cfg->ports[j]; | |
362 | int k; | |
363 | ||
364 | for (k = 0; k < port_cfg->n_interfaces; k++) { | |
365 | struct ovsrec_interface *if_cfg = port_cfg->interfaces[k]; | |
366 | struct iface_hint *iface_hint; | |
367 | ||
368 | iface_hint = xmalloc(sizeof *iface_hint); | |
369 | iface_hint->br_name = br_cfg->name; | |
370 | iface_hint->br_type = br_cfg->datapath_type; | |
558e2cc5 | 371 | iface_hint->ofp_port = iface_pick_ofport(if_cfg); |
b099cd5f EJ |
372 | |
373 | shash_add(&iface_hints, if_cfg->name, iface_hint); | |
374 | } | |
b0408fca JP |
375 | } |
376 | } | |
377 | } | |
378 | ||
379 | ofproto_init(&iface_hints); | |
380 | ||
381 | shash_destroy_free_data(&iface_hints); | |
382 | initialized = true; | |
383 | } | |
e21c6643 TLSC |
384 | |
385 | static void | |
386 | if_change_cb(void *aux OVS_UNUSED) | |
387 | { | |
388 | ifaces_changed = true; | |
389 | } | |
064af421 BP |
390 | \f |
391 | /* Public functions. */ | |
392 | ||
c5187f17 BP |
393 | /* Initializes the bridge module, configuring it to obtain its configuration |
394 | * from an OVSDB server accessed over 'remote', which should be a string in a | |
395 | * form acceptable to ovsdb_idl_create(). */ | |
064af421 | 396 | void |
c5187f17 BP |
397 | bridge_init(const char *remote) |
398 | { | |
399 | /* Create connection to database. */ | |
fba6bd1d | 400 | idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true, true); |
854a94d9 | 401 | idl_seqno = ovsdb_idl_get_seqno(idl); |
06b6d651 | 402 | ovsdb_idl_set_lock(idl, "ovs_vswitchd"); |
8cdec725 | 403 | ovsdb_idl_verify_write_only(idl); |
c5187f17 | 404 | |
ef73f86c BP |
405 | ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg); |
406 | ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics); | |
842733c3 MG |
407 | ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_datapath_types); |
408 | ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_iface_types); | |
e85bbd75 | 409 | ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids); |
62f3aaed BP |
410 | ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version); |
411 | ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version); | |
412 | ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type); | |
413 | ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version); | |
e85bbd75 | 414 | |
62f3aaed | 415 | ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id); |
b5cbbcf6 | 416 | ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_version); |
21f7563c | 417 | ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status); |
9efd308e DV |
418 | ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_rstp_status); |
419 | ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_stp_enable); | |
420 | ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_rstp_enable); | |
e85bbd75 BP |
421 | ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids); |
422 | ||
21f7563c | 423 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status); |
9efd308e DV |
424 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_rstp_status); |
425 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_rstp_statistics); | |
80740385 | 426 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_statistics); |
3e5aeeb5 | 427 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_bond_active_slave); |
e85bbd75 | 428 | ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids); |
99eef98b DF |
429 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_trunks); |
430 | ovsdb_idl_omit_alert(idl, &ovsrec_port_col_vlan_mode); | |
62f3aaed BP |
431 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state); |
432 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex); | |
433 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed); | |
434 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state); | |
65c3058c | 435 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets); |
df867eda | 436 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mac_in_use); |
ea401d9a | 437 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ifindex); |
62f3aaed | 438 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu); |
ef73f86c BP |
439 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport); |
440 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics); | |
62f3aaed | 441 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status); |
b4117094 | 442 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault); |
b9380396 | 443 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault_status); |
1de11730 | 444 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids); |
76c4290d | 445 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_flap_count); |
3967a833 | 446 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_health); |
4104aaf1 | 447 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_opstate); |
ccc09689 | 448 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_bfd_status); |
b4117094 | 449 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current); |
bbe6109d | 450 | ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_error); |
e85bbd75 BP |
451 | ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids); |
452 | ||
62f3aaed BP |
453 | ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected); |
454 | ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role); | |
455 | ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status); | |
456 | ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids); | |
457 | ||
62f3aaed BP |
458 | ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids); |
459 | ||
460 | ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids); | |
461 | ||
462 | ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids); | |
9d24de3b | 463 | ovsdb_idl_omit_alert(idl, &ovsrec_mirror_col_statistics); |
62f3aaed BP |
464 | |
465 | ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids); | |
62f3aaed | 466 | ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids); |
29089a54 RL |
467 | ovsdb_idl_omit(idl, &ovsrec_ipfix_col_external_ids); |
468 | ovsdb_idl_omit(idl, &ovsrec_flow_sample_collector_set_col_external_ids); | |
62f3aaed BP |
469 | |
470 | ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids); | |
471 | ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe); | |
472 | ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected); | |
473 | ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff); | |
474 | ovsdb_idl_omit(idl, &ovsrec_manager_col_status); | |
475 | ||
476 | ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids); | |
477 | ||
c5187f17 | 478 | /* Register unixctl commands. */ |
0e15264f BP |
479 | unixctl_command_register("qos/show", "interface", 1, 1, |
480 | qos_unixctl_show, NULL); | |
481 | unixctl_command_register("bridge/dump-flows", "bridge", 1, 1, | |
7ff2009a | 482 | bridge_unixctl_dump_flows, NULL); |
0e15264f | 483 | unixctl_command_register("bridge/reconnect", "[bridge]", 0, 1, |
7ff2009a | 484 | bridge_unixctl_reconnect, NULL); |
5827ce14 | 485 | lacp_init(); |
c5187f17 | 486 | bond_init(); |
9ac3fce4 | 487 | cfm_init(); |
0fc1f5c0 | 488 | bfd_init(); |
7c5a3bbf | 489 | ovs_numa_init(); |
fe4a02e4 | 490 | stp_init(); |
99eef98b | 491 | lldp_init(); |
9efd308e | 492 | rstp_init(); |
e21c6643 | 493 | ifnotifier = if_notifier_create(if_change_cb, NULL); |
c5187f17 BP |
494 | } |
495 | ||
ee45ad81 BP |
496 | void |
497 | bridge_exit(void) | |
498 | { | |
499 | struct bridge *br, *next_br; | |
500 | ||
e21c6643 | 501 | if_notifier_destroy(ifnotifier); |
764072fd | 502 | HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) { |
ee45ad81 BP |
503 | bridge_destroy(br); |
504 | } | |
505 | ovsdb_idl_destroy(idl); | |
506 | } | |
507 | ||
cd11000b BP |
508 | /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP |
509 | * addresses and ports into '*managersp' and '*n_managersp'. The caller is | |
510 | * responsible for freeing '*managersp' (with free()). | |
511 | * | |
512 | * You may be asking yourself "why does ovs-vswitchd care?", because | |
513 | * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd | |
514 | * should not be and in fact is not directly involved in that. But | |
515 | * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so | |
516 | * it has to tell in-band control where the managers are to enable that. | |
f0a5ac68 AW |
517 | * (Thus, only managers connected in-band and with non-loopback addresses |
518 | * are collected.) | |
cd11000b BP |
519 | */ |
520 | static void | |
94db5407 BP |
521 | collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg, |
522 | struct sockaddr_in **managersp, size_t *n_managersp) | |
cd11000b BP |
523 | { |
524 | struct sockaddr_in *managers = NULL; | |
525 | size_t n_managers = 0; | |
b3c01ed3 | 526 | struct sset targets; |
94db5407 BP |
527 | size_t i; |
528 | ||
289df16d AE |
529 | /* Collect all of the potential targets from the "targets" columns of the |
530 | * rows pointed to by "manager_options", excluding any that are | |
531 | * out-of-band. */ | |
b3c01ed3 | 532 | sset_init(&targets); |
94db5407 BP |
533 | for (i = 0; i < ovs_cfg->n_manager_options; i++) { |
534 | struct ovsrec_manager *m = ovs_cfg->manager_options[i]; | |
535 | ||
536 | if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) { | |
b3c01ed3 | 537 | sset_find_and_delete(&targets, m->target); |
94db5407 | 538 | } else { |
b3c01ed3 | 539 | sset_add(&targets, m->target); |
94db5407 BP |
540 | } |
541 | } | |
cd11000b | 542 | |
94db5407 | 543 | /* Now extract the targets' IP addresses. */ |
b3c01ed3 BP |
544 | if (!sset_is_empty(&targets)) { |
545 | const char *target; | |
cd11000b | 546 | |
b3c01ed3 BP |
547 | managers = xmalloc(sset_count(&targets) * sizeof *managers); |
548 | SSET_FOR_EACH (target, &targets) { | |
02334943 JR |
549 | union { |
550 | struct sockaddr_storage ss; | |
551 | struct sockaddr_in in; | |
552 | } sa; | |
cd11000b | 553 | |
f0a5ac68 | 554 | /* Ignore loopback. */ |
d4763d1d | 555 | if (stream_parse_target_with_default_port(target, OVSDB_PORT, |
02334943 | 556 | &sa.ss) |
f0a5ac68 AW |
557 | && sa.ss.ss_family == AF_INET |
558 | && sa.in.sin_addr.s_addr != htonl(INADDR_LOOPBACK)) { | |
02334943 | 559 | managers[n_managers++] = sa.in; |
cd11000b BP |
560 | } |
561 | } | |
562 | } | |
b3c01ed3 | 563 | sset_destroy(&targets); |
cd11000b BP |
564 | |
565 | *managersp = managers; | |
566 | *n_managersp = n_managers; | |
567 | } | |
568 | ||
c5187f17 | 569 | static void |
76343538 | 570 | bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg) |
064af421 | 571 | { |
52a90c29 | 572 | unsigned long int *splinter_vlans; |
2a73b1d7 BP |
573 | struct sockaddr_in *managers; |
574 | struct bridge *br, *next; | |
575 | int sflow_bridge_number; | |
576 | size_t n_managers; | |
064af421 BP |
577 | |
578 | COVERAGE_INC(bridge_reconfigure); | |
579 | ||
e79a6c83 EJ |
580 | ofproto_set_flow_limit(smap_get_int(&ovs_cfg->other_config, "flow-limit", |
581 | OFPROTO_FLOW_LIMIT_DEFAULT)); | |
72310b04 JS |
582 | ofproto_set_max_idle(smap_get_int(&ovs_cfg->other_config, "max-idle", |
583 | OFPROTO_MAX_IDLE_DEFAULT)); | |
f2eee189 | 584 | ofproto_set_cpu_mask(smap_get(&ovs_cfg->other_config, "pmd-cpu-mask")); |
380f49c4 | 585 | |
6567010f | 586 | ofproto_set_threads( |
e79a6c83 EJ |
587 | smap_get_int(&ovs_cfg->other_config, "n-handler-threads", 0), |
588 | smap_get_int(&ovs_cfg->other_config, "n-revalidator-threads", 0)); | |
448a4b2f | 589 | |
bae7208e | 590 | /* Destroy "struct bridge"s, "struct port"s, and "struct iface"s according |
2a73b1d7 | 591 | * to 'ovs_cfg', with only very minimal configuration otherwise. |
66da9bef | 592 | * |
bae7208e EJ |
593 | * This is mostly an update to bridge data structures. Nothing is pushed |
594 | * down to ofproto or lower layers. */ | |
66da9bef | 595 | add_del_bridges(ovs_cfg); |
52a90c29 | 596 | splinter_vlans = collect_splinter_vlans(ovs_cfg); |
764072fd | 597 | HMAP_FOR_EACH (br, node, &all_bridges) { |
2a73b1d7 BP |
598 | bridge_collect_wanted_ports(br, splinter_vlans, &br->wanted_ports); |
599 | bridge_del_ports(br, &br->wanted_ports); | |
76343538 | 600 | } |
52a90c29 | 601 | free(splinter_vlans); |
064af421 | 602 | |
2a73b1d7 BP |
603 | /* Start pushing configuration changes down to the ofproto layer: |
604 | * | |
605 | * - Delete ofprotos that are no longer configured. | |
606 | * | |
607 | * - Delete ports that are no longer configured. | |
608 | * | |
609 | * - Reconfigure existing ports to their desired configurations, or | |
610 | * delete them if not possible. | |
611 | * | |
612 | * We have to do all the deletions before we can do any additions, because | |
613 | * the ports to be added might require resources that will be freed up by | |
614 | * deletions (they might especially overlap in name). */ | |
615 | bridge_delete_ofprotos(); | |
bae7208e | 616 | HMAP_FOR_EACH (br, node, &all_bridges) { |
2a73b1d7 BP |
617 | if (br->ofproto) { |
618 | bridge_delete_or_reconfigure_ports(br); | |
76343538 | 619 | } |
064af421 | 620 | } |
35a22d8c | 621 | |
2a73b1d7 BP |
622 | /* Finish pushing configuration changes to the ofproto layer: |
623 | * | |
624 | * - Create ofprotos that are missing. | |
625 | * | |
626 | * - Add ports that are missing. */ | |
627 | HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) { | |
628 | if (!br->ofproto) { | |
629 | int error; | |
bae7208e | 630 | |
2a73b1d7 BP |
631 | error = ofproto_create(br->name, br->type, &br->ofproto); |
632 | if (error) { | |
633 | VLOG_ERR("failed to create bridge %s: %s", br->name, | |
634 | ovs_strerror(error)); | |
635 | shash_destroy(&br->wanted_ports); | |
636 | bridge_destroy(br); | |
b5cbbcf6 AZ |
637 | } else { |
638 | /* Trigger storing datapath version. */ | |
639 | seq_change(connectivity_seq_get()); | |
e56365a5 | 640 | } |
064af421 BP |
641 | } |
642 | } | |
e8192d80 | 643 | HMAP_FOR_EACH (br, node, &all_bridges) { |
2a73b1d7 BP |
644 | bridge_add_ports(br, &br->wanted_ports); |
645 | shash_destroy(&br->wanted_ports); | |
064af421 | 646 | } |
064af421 | 647 | |
2a73b1d7 | 648 | reconfigure_system_stats(ovs_cfg); |
bae7208e | 649 | |
66da9bef BP |
650 | /* Complete the configuration. */ |
651 | sflow_bridge_number = 0; | |
652 | collect_in_band_managers(ovs_cfg, &managers, &n_managers); | |
764072fd | 653 | HMAP_FOR_EACH (br, node, &all_bridges) { |
8052fb14 | 654 | struct port *port; |
064af421 | 655 | |
f145afdc BP |
656 | /* We need the datapath ID early to allow LACP ports to use it as the |
657 | * default system ID. */ | |
658 | bridge_configure_datapath_id(br); | |
659 | ||
8052fb14 | 660 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { |
83db7968 | 661 | struct iface *iface; |
52df17e7 | 662 | |
fa066f01 | 663 | port_configure(port); |
c1c9c9c4 | 664 | |
48e1b7fb | 665 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { |
59804c80 | 666 | iface_set_ofport(iface->cfg, iface->ofp_port); |
bbe6109d TG |
667 | /* Clear eventual previous errors */ |
668 | ovsrec_interface_set_error(iface->cfg, NULL); | |
66da9bef BP |
669 | iface_configure_cfm(iface); |
670 | iface_configure_qos(iface, port->cfg->qos); | |
21a955fc | 671 | iface_set_mac(br, port, iface); |
ccc09689 EJ |
672 | ofproto_port_set_bfd(br->ofproto, iface->ofp_port, |
673 | &iface->cfg->bfd); | |
99eef98b DF |
674 | ofproto_port_set_lldp(br->ofproto, iface->ofp_port, |
675 | &iface->cfg->lldp); | |
064af421 BP |
676 | } |
677 | } | |
fa066f01 | 678 | bridge_configure_mirrors(br); |
8402c74b | 679 | bridge_configure_forward_bpdu(br); |
c4069512 | 680 | bridge_configure_mac_table(br); |
dc2b70ba | 681 | bridge_configure_mcast_snooping(br); |
fa066f01 | 682 | bridge_configure_remotes(br, managers, n_managers); |
66da9bef BP |
683 | bridge_configure_netflow(br); |
684 | bridge_configure_sflow(br, &sflow_bridge_number); | |
29089a54 | 685 | bridge_configure_ipfix(br); |
7af77bbd | 686 | bridge_configure_spanning_tree(br); |
254750ce | 687 | bridge_configure_tables(br); |
8b6ff729 | 688 | bridge_configure_dp_desc(br); |
99eef98b | 689 | bridge_configure_aa(br); |
064af421 | 690 | } |
66da9bef | 691 | free(managers); |
aeed7879 BP |
692 | |
693 | /* The ofproto-dpif provider does some final reconfiguration in its | |
694 | * ->type_run() function. We have to call it before notifying the database | |
695 | * client that reconfiguration is complete, otherwise there is a very | |
696 | * narrow race window in which e.g. ofproto/trace will not recognize the | |
697 | * new configuration (sometimes this causes unit test failures). */ | |
698 | bridge_run__(); | |
66da9bef | 699 | } |
064af421 | 700 | |
bae7208e EJ |
701 | /* Delete ofprotos which aren't configured or have the wrong type. Create |
702 | * ofprotos which don't exist but need to. */ | |
66da9bef | 703 | static void |
2a73b1d7 | 704 | bridge_delete_ofprotos(void) |
66da9bef | 705 | { |
2a73b1d7 | 706 | struct bridge *br; |
f79e673f BP |
707 | struct sset names; |
708 | struct sset types; | |
66da9bef | 709 | const char *type; |
6c88d577 | 710 | |
bae7208e | 711 | /* Delete ofprotos with no bridge or with the wrong type. */ |
f79e673f BP |
712 | sset_init(&names); |
713 | sset_init(&types); | |
714 | ofproto_enumerate_types(&types); | |
715 | SSET_FOR_EACH (type, &types) { | |
66da9bef | 716 | const char *name; |
3a6ccc8c | 717 | |
f79e673f BP |
718 | ofproto_enumerate_names(type, &names); |
719 | SSET_FOR_EACH (name, &names) { | |
bae7208e | 720 | br = bridge_lookup(name); |
66da9bef | 721 | if (!br || strcmp(type, br->type)) { |
f79e673f | 722 | ofproto_delete(name, type); |
3a6ccc8c | 723 | } |
b31bcf60 EJ |
724 | } |
725 | } | |
f79e673f BP |
726 | sset_destroy(&names); |
727 | sset_destroy(&types); | |
2a73b1d7 | 728 | } |
76343538 | 729 | |
2a73b1d7 BP |
730 | static ofp_port_t * |
731 | add_ofp_port(ofp_port_t port, ofp_port_t *ports, size_t *n, size_t *allocated) | |
732 | { | |
733 | if (*n >= *allocated) { | |
734 | ports = x2nrealloc(ports, allocated, sizeof *ports); | |
735 | } | |
736 | ports[(*n)++] = port; | |
737 | return ports; | |
738 | } | |
bae7208e | 739 | |
2a73b1d7 BP |
740 | static void |
741 | bridge_delete_or_reconfigure_ports(struct bridge *br) | |
742 | { | |
743 | struct ofproto_port ofproto_port; | |
744 | struct ofproto_port_dump dump; | |
745 | ||
96be8de5 BP |
746 | struct sset ofproto_ports; |
747 | struct port *port, *port_next; | |
748 | ||
2a73b1d7 BP |
749 | /* List of "ofp_port"s to delete. We make a list instead of deleting them |
750 | * right away because ofproto implementations aren't necessarily able to | |
751 | * iterate through a changing list of ports in an entirely robust way. */ | |
752 | ofp_port_t *del; | |
753 | size_t n, allocated; | |
754 | size_t i; | |
755 | ||
756 | del = NULL; | |
757 | n = allocated = 0; | |
96be8de5 | 758 | sset_init(&ofproto_ports); |
bae7208e | 759 | |
96be8de5 BP |
760 | /* Main task: Iterate over the ports in 'br->ofproto' and remove the ports |
761 | * that are not configured in the database. (This commonly happens when | |
762 | * ports have been deleted, e.g. with "ovs-vsctl del-port".) | |
763 | * | |
764 | * Side tasks: Reconfigure the ports that are still in 'br'. Delete ports | |
765 | * that have the wrong OpenFlow port number (and arrange to add them back | |
766 | * with the correct OpenFlow port number). */ | |
2a73b1d7 | 767 | OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) { |
4abb8608 | 768 | ofp_port_t requested_ofp_port; |
2a73b1d7 | 769 | struct iface *iface; |
bae7208e | 770 | |
96be8de5 BP |
771 | sset_add(&ofproto_ports, ofproto_port.name); |
772 | ||
2a73b1d7 BP |
773 | iface = iface_lookup(br, ofproto_port.name); |
774 | if (!iface) { | |
775 | /* No such iface is configured, so we should delete this | |
776 | * ofproto_port. | |
777 | * | |
778 | * As a corner case exception, keep the port if it's a bond fake | |
779 | * interface. */ | |
780 | if (bridge_has_bond_fake_iface(br, ofproto_port.name) | |
781 | && !strcmp(ofproto_port.type, "internal")) { | |
bae7208e EJ |
782 | continue; |
783 | } | |
2a73b1d7 BP |
784 | goto delete; |
785 | } | |
bae7208e | 786 | |
2a73b1d7 | 787 | if (strcmp(ofproto_port.type, iface->type) |
bbe6109d | 788 | || netdev_set_config(iface->netdev, &iface->cfg->options, NULL)) { |
2a73b1d7 BP |
789 | /* The interface is the wrong type or can't be configured. |
790 | * Delete it. */ | |
791 | goto delete; | |
bae7208e EJ |
792 | } |
793 | ||
4abb8608 BP |
794 | /* If the requested OpenFlow port for 'iface' changed, and it's not |
795 | * already the correct port, then we might want to temporarily delete | |
796 | * this interface, so we can add it back again with the new OpenFlow | |
797 | * port number. */ | |
798 | requested_ofp_port = iface_get_requested_ofp_port(iface->cfg); | |
799 | if (iface->ofp_port != OFPP_LOCAL && | |
800 | requested_ofp_port != OFPP_NONE && | |
801 | requested_ofp_port != iface->ofp_port) { | |
802 | ofp_port_t victim_request; | |
803 | struct iface *victim; | |
804 | ||
805 | /* Check for an existing OpenFlow port currently occupying | |
806 | * 'iface''s requested port number. If there isn't one, then | |
807 | * delete this port. Otherwise we need to consider further. */ | |
808 | victim = iface_from_ofp_port(br, requested_ofp_port); | |
809 | if (!victim) { | |
810 | goto delete; | |
811 | } | |
812 | ||
813 | /* 'victim' is a port currently using 'iface''s requested port | |
814 | * number. Unless 'victim' specifically requested that port | |
815 | * number, too, then we can delete both 'iface' and 'victim' | |
816 | * temporarily. (We'll add both of them back again later with new | |
817 | * OpenFlow port numbers.) | |
818 | * | |
819 | * If 'victim' did request port number 'requested_ofp_port', just | |
820 | * like 'iface', then that's a configuration inconsistency that we | |
821 | * can't resolve. We might as well let it keep its current port | |
822 | * number. */ | |
823 | victim_request = iface_get_requested_ofp_port(victim->cfg); | |
824 | if (victim_request != requested_ofp_port) { | |
825 | del = add_ofp_port(victim->ofp_port, del, &n, &allocated); | |
826 | iface_destroy(victim); | |
827 | goto delete; | |
828 | } | |
829 | } | |
830 | ||
2a73b1d7 BP |
831 | /* Keep it. */ |
832 | continue; | |
833 | ||
834 | delete: | |
835 | iface_destroy(iface); | |
836 | del = add_ofp_port(ofproto_port.ofp_port, del, &n, &allocated); | |
837 | } | |
2a73b1d7 BP |
838 | for (i = 0; i < n; i++) { |
839 | ofproto_port_del(br->ofproto, del[i]); | |
840 | } | |
841 | free(del); | |
96be8de5 BP |
842 | |
843 | /* Iterate over this module's idea of interfaces in 'br'. Remove any ports | |
844 | * that we didn't see when we iterated through the datapath, i.e. ports | |
845 | * that disappeared underneath use. This is an unusual situation, but it | |
846 | * can happen in some cases: | |
847 | * | |
848 | * - An admin runs a command like "ovs-dpctl del-port" (which is a bad | |
849 | * idea but could happen). | |
850 | * | |
851 | * - The port represented a device that disappeared, e.g. a tuntap | |
852 | * device destroyed via "tunctl -d", a physical Ethernet device | |
853 | * whose module was just unloaded via "rmmod", or a virtual NIC for a | |
854 | * VM whose VM was just terminated. */ | |
855 | HMAP_FOR_EACH_SAFE (port, port_next, hmap_node, &br->ports) { | |
856 | struct iface *iface, *iface_next; | |
857 | ||
858 | LIST_FOR_EACH_SAFE (iface, iface_next, port_elem, &port->ifaces) { | |
859 | if (!sset_contains(&ofproto_ports, iface->name)) { | |
860 | iface_destroy__(iface); | |
861 | } | |
862 | } | |
863 | ||
864 | if (list_is_empty(&port->ifaces)) { | |
865 | port_destroy(port); | |
866 | } | |
867 | } | |
868 | sset_destroy(&ofproto_ports); | |
2a73b1d7 BP |
869 | } |
870 | ||
871 | static void | |
4abb8608 BP |
872 | bridge_add_ports__(struct bridge *br, const struct shash *wanted_ports, |
873 | bool with_requested_port) | |
2a73b1d7 BP |
874 | { |
875 | struct shash_node *port_node; | |
876 | ||
877 | SHASH_FOR_EACH (port_node, wanted_ports) { | |
878 | const struct ovsrec_port *port_cfg = port_node->data; | |
879 | size_t i; | |
880 | ||
881 | for (i = 0; i < port_cfg->n_interfaces; i++) { | |
882 | const struct ovsrec_interface *iface_cfg = port_cfg->interfaces[i]; | |
4abb8608 BP |
883 | ofp_port_t requested_ofp_port; |
884 | ||
885 | requested_ofp_port = iface_get_requested_ofp_port(iface_cfg); | |
886 | if ((requested_ofp_port != OFPP_NONE) == with_requested_port) { | |
887 | struct iface *iface = iface_lookup(br, iface_cfg->name); | |
2a73b1d7 | 888 | |
4abb8608 BP |
889 | if (!iface) { |
890 | iface_create(br, iface_cfg, port_cfg); | |
891 | } | |
2a73b1d7 | 892 | } |
bae7208e | 893 | } |
66da9bef | 894 | } |
093e47f4 | 895 | } |
c3827f61 | 896 | |
4abb8608 BP |
897 | static void |
898 | bridge_add_ports(struct bridge *br, const struct shash *wanted_ports) | |
899 | { | |
900 | /* First add interfaces that request a particular port number. */ | |
901 | bridge_add_ports__(br, wanted_ports, true); | |
902 | ||
903 | /* Then add interfaces that want automatic port number assignment. | |
904 | * We add these afterward to avoid accidentally taking a specifically | |
905 | * requested port number. */ | |
906 | bridge_add_ports__(br, wanted_ports, false); | |
907 | } | |
908 | ||
fa066f01 BP |
909 | static void |
910 | port_configure(struct port *port) | |
911 | { | |
912 | const struct ovsrec_port *cfg = port->cfg; | |
913 | struct bond_settings bond_settings; | |
914 | struct lacp_settings lacp_settings; | |
915 | struct ofproto_bundle_settings s; | |
916 | struct iface *iface; | |
82057f51 | 917 | |
52a90c29 BP |
918 | if (cfg->vlan_mode && !strcmp(cfg->vlan_mode, "splinter")) { |
919 | configure_splinter_port(port); | |
920 | return; | |
921 | } | |
922 | ||
fa066f01 BP |
923 | /* Get name. */ |
924 | s.name = port->name; | |
3a6ccc8c | 925 | |
fa066f01 BP |
926 | /* Get slaves. */ |
927 | s.n_slaves = 0; | |
928 | s.slaves = xmalloc(list_size(&port->ifaces) * sizeof *s.slaves); | |
929 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { | |
892815f5 | 930 | s.slaves[s.n_slaves++] = iface->ofp_port; |
fa066f01 | 931 | } |
c3827f61 | 932 | |
fa066f01 BP |
933 | /* Get VLAN tag. */ |
934 | s.vlan = -1; | |
acaf1486 BP |
935 | if (cfg->tag && *cfg->tag >= 0 && *cfg->tag <= 4095) { |
936 | s.vlan = *cfg->tag; | |
fa066f01 | 937 | } |
b0ec0f27 | 938 | |
fa066f01 BP |
939 | /* Get VLAN trunks. */ |
940 | s.trunks = NULL; | |
ecac4ebf | 941 | if (cfg->n_trunks) { |
fa066f01 | 942 | s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks); |
ecac4ebf BP |
943 | } |
944 | ||
945 | /* Get VLAN mode. */ | |
946 | if (cfg->vlan_mode) { | |
947 | if (!strcmp(cfg->vlan_mode, "access")) { | |
948 | s.vlan_mode = PORT_VLAN_ACCESS; | |
949 | } else if (!strcmp(cfg->vlan_mode, "trunk")) { | |
950 | s.vlan_mode = PORT_VLAN_TRUNK; | |
951 | } else if (!strcmp(cfg->vlan_mode, "native-tagged")) { | |
952 | s.vlan_mode = PORT_VLAN_NATIVE_TAGGED; | |
953 | } else if (!strcmp(cfg->vlan_mode, "native-untagged")) { | |
954 | s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED; | |
955 | } else { | |
956 | /* This "can't happen" because ovsdb-server should prevent it. */ | |
65a0903b TG |
957 | VLOG_WARN("port %s: unknown VLAN mode %s, falling " |
958 | "back to trunk mode", port->name, cfg->vlan_mode); | |
ecac4ebf BP |
959 | s.vlan_mode = PORT_VLAN_TRUNK; |
960 | } | |
961 | } else { | |
962 | if (s.vlan >= 0) { | |
963 | s.vlan_mode = PORT_VLAN_ACCESS; | |
964 | if (cfg->n_trunks) { | |
65a0903b TG |
965 | VLOG_WARN("port %s: ignoring trunks in favor of implicit vlan", |
966 | port->name); | |
ecac4ebf BP |
967 | } |
968 | } else { | |
969 | s.vlan_mode = PORT_VLAN_TRUNK; | |
970 | } | |
064af421 | 971 | } |
a699f614 EJ |
972 | s.use_priority_tags = smap_get_bool(&cfg->other_config, "priority-tags", |
973 | false); | |
064af421 | 974 | |
fa066f01 BP |
975 | /* Get LACP settings. */ |
976 | s.lacp = port_configure_lacp(port, &lacp_settings); | |
977 | if (s.lacp) { | |
978 | size_t i = 0; | |
064af421 | 979 | |
fa066f01 BP |
980 | s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves); |
981 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { | |
982 | iface_configure_lacp(iface, &s.lacp_slaves[i++]); | |
064af421 | 983 | } |
fa066f01 BP |
984 | } else { |
985 | s.lacp_slaves = NULL; | |
986 | } | |
064af421 | 987 | |
fa066f01 BP |
988 | /* Get bond settings. */ |
989 | if (s.n_slaves > 1) { | |
fa066f01 | 990 | s.bond = &bond_settings; |
df53d41c | 991 | port_configure_bond(port, &bond_settings); |
fa066f01 BP |
992 | } else { |
993 | s.bond = NULL; | |
1670c579 EJ |
994 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { |
995 | netdev_set_miimon_interval(iface->netdev, 0); | |
996 | } | |
fa066f01 | 997 | } |
093e47f4 | 998 | |
fa066f01 BP |
999 | /* Register. */ |
1000 | ofproto_bundle_register(port->bridge->ofproto, port, &s); | |
76343538 | 1001 | |
fa066f01 | 1002 | /* Clean up. */ |
4e51de4c | 1003 | free(s.slaves); |
fa066f01 BP |
1004 | free(s.trunks); |
1005 | free(s.lacp_slaves); | |
1006 | } | |
76343538 | 1007 | |
6f90b8f4 BP |
1008 | /* Pick local port hardware address and datapath ID for 'br'. */ |
1009 | static void | |
1010 | bridge_configure_datapath_id(struct bridge *br) | |
1011 | { | |
74ff3298 | 1012 | struct eth_addr ea; |
6f90b8f4 BP |
1013 | uint64_t dpid; |
1014 | struct iface *local_iface; | |
1015 | struct iface *hw_addr_iface; | |
1016 | char *dpid_string; | |
76343538 | 1017 | |
74ff3298 | 1018 | bridge_pick_local_hw_addr(br, &ea, &hw_addr_iface); |
892815f5 | 1019 | local_iface = iface_from_ofp_port(br, OFPP_LOCAL); |
6f90b8f4 BP |
1020 | if (local_iface) { |
1021 | int error = netdev_set_etheraddr(local_iface->netdev, ea); | |
1022 | if (error) { | |
1023 | static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); | |
1024 | VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge " | |
1025 | "Ethernet address: %s", | |
10a89ef0 | 1026 | br->name, ovs_strerror(error)); |
6f90b8f4 BP |
1027 | } |
1028 | } | |
74ff3298 | 1029 | br->ea = ea; |
76343538 | 1030 | |
6f90b8f4 | 1031 | dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface); |
e825ace2 BP |
1032 | if (dpid != ofproto_get_datapath_id(br->ofproto)) { |
1033 | VLOG_INFO("bridge %s: using datapath ID %016"PRIx64, br->name, dpid); | |
1034 | ofproto_set_datapath_id(br->ofproto, dpid); | |
1035 | } | |
76343538 | 1036 | |
6f90b8f4 BP |
1037 | dpid_string = xasprintf("%016"PRIx64, dpid); |
1038 | ovsrec_bridge_set_datapath_id(br->cfg, dpid_string); | |
1039 | free(dpid_string); | |
1040 | } | |
064af421 | 1041 | |
7beaa082 SH |
1042 | /* Returns a bitmap of "enum ofputil_protocol"s that are allowed for use with |
1043 | * 'br'. */ | |
1044 | static uint32_t | |
1045 | bridge_get_allowed_versions(struct bridge *br) | |
1046 | { | |
3852cc1b | 1047 | if (!br->cfg->n_protocols) { |
7beaa082 | 1048 | return 0; |
3852cc1b | 1049 | } |
7beaa082 | 1050 | |
aa233d57 BP |
1051 | return ofputil_versions_from_strings(br->cfg->protocols, |
1052 | br->cfg->n_protocols); | |
7beaa082 SH |
1053 | } |
1054 | ||
6f90b8f4 BP |
1055 | /* Set NetFlow configuration on 'br'. */ |
1056 | static void | |
1057 | bridge_configure_netflow(struct bridge *br) | |
1058 | { | |
1059 | struct ovsrec_netflow *cfg = br->cfg->netflow; | |
1060 | struct netflow_options opts; | |
72b06300 | 1061 | |
6f90b8f4 BP |
1062 | if (!cfg) { |
1063 | ofproto_set_netflow(br->ofproto, NULL); | |
1064 | return; | |
1065 | } | |
a4af0040 | 1066 | |
6f90b8f4 | 1067 | memset(&opts, 0, sizeof opts); |
72b06300 | 1068 | |
6f90b8f4 BP |
1069 | /* Get default NetFlow configuration from datapath. |
1070 | * Apply overrides from 'cfg'. */ | |
1071 | ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id); | |
1072 | if (cfg->engine_type) { | |
1073 | opts.engine_type = *cfg->engine_type; | |
1074 | } | |
1075 | if (cfg->engine_id) { | |
1076 | opts.engine_id = *cfg->engine_id; | |
1077 | } | |
72b06300 | 1078 | |
6f90b8f4 BP |
1079 | /* Configure active timeout interval. */ |
1080 | opts.active_timeout = cfg->active_timeout; | |
1081 | if (!opts.active_timeout) { | |
1082 | opts.active_timeout = -1; | |
1083 | } else if (opts.active_timeout < 0) { | |
1084 | VLOG_WARN("bridge %s: active timeout interval set to negative " | |
1085 | "value, using default instead (%d seconds)", br->name, | |
1086 | NF_ACTIVE_TIMEOUT_DEFAULT); | |
1087 | opts.active_timeout = -1; | |
1088 | } | |
72b06300 | 1089 | |
6f90b8f4 BP |
1090 | /* Add engine ID to interface number to disambiguate bridgs? */ |
1091 | opts.add_id_to_iface = cfg->add_id_to_interface; | |
1092 | if (opts.add_id_to_iface) { | |
1093 | if (opts.engine_id > 0x7f) { | |
1094 | VLOG_WARN("bridge %s: NetFlow port mangling may conflict with " | |
1095 | "another vswitch, choose an engine id less than 128", | |
1096 | br->name); | |
1097 | } | |
1098 | if (hmap_count(&br->ports) > 508) { | |
1099 | VLOG_WARN("bridge %s: NetFlow port mangling will conflict with " | |
1100 | "another port when more than 508 ports are used", | |
1101 | br->name); | |
1102 | } | |
1103 | } | |
72b06300 | 1104 | |
6f90b8f4 BP |
1105 | /* Collectors. */ |
1106 | sset_init(&opts.collectors); | |
1107 | sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets); | |
a4af0040 | 1108 | |
6f90b8f4 BP |
1109 | /* Configure. */ |
1110 | if (ofproto_set_netflow(br->ofproto, &opts)) { | |
1111 | VLOG_ERR("bridge %s: problem setting netflow collectors", br->name); | |
1112 | } | |
1113 | sset_destroy(&opts.collectors); | |
1114 | } | |
72b06300 | 1115 | |
6f90b8f4 BP |
1116 | /* Set sFlow configuration on 'br'. */ |
1117 | static void | |
1118 | bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number) | |
1119 | { | |
1120 | const struct ovsrec_sflow *cfg = br->cfg->sflow; | |
1121 | struct ovsrec_controller **controllers; | |
1122 | struct ofproto_sflow_options oso; | |
1123 | size_t n_controllers; | |
1124 | size_t i; | |
72b06300 | 1125 | |
6f90b8f4 BP |
1126 | if (!cfg) { |
1127 | ofproto_set_sflow(br->ofproto, NULL); | |
1128 | return; | |
064af421 | 1129 | } |
8052fb14 | 1130 | |
6f90b8f4 | 1131 | memset(&oso, 0, sizeof oso); |
52df17e7 | 1132 | |
6f90b8f4 BP |
1133 | sset_init(&oso.targets); |
1134 | sset_add_array(&oso.targets, cfg->targets, cfg->n_targets); | |
c1c9c9c4 | 1135 | |
6f90b8f4 BP |
1136 | oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE; |
1137 | if (cfg->sampling) { | |
1138 | oso.sampling_rate = *cfg->sampling; | |
064af421 | 1139 | } |
6f90b8f4 BP |
1140 | |
1141 | oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL; | |
1142 | if (cfg->polling) { | |
1143 | oso.polling_interval = *cfg->polling; | |
064af421 | 1144 | } |
093e47f4 | 1145 | |
6f90b8f4 BP |
1146 | oso.header_len = SFL_DEFAULT_HEADER_SIZE; |
1147 | if (cfg->header) { | |
1148 | oso.header_len = *cfg->header; | |
1149 | } | |
392730c4 | 1150 | |
6f90b8f4 BP |
1151 | oso.sub_id = (*sflow_bridge_number)++; |
1152 | oso.agent_device = cfg->agent; | |
392730c4 | 1153 | |
6f90b8f4 BP |
1154 | oso.control_ip = NULL; |
1155 | n_controllers = bridge_get_controllers(br, &controllers); | |
1156 | for (i = 0; i < n_controllers; i++) { | |
1157 | if (controllers[i]->local_ip) { | |
1158 | oso.control_ip = controllers[i]->local_ip; | |
1159 | break; | |
b31bcf60 EJ |
1160 | } |
1161 | } | |
6f90b8f4 | 1162 | ofproto_set_sflow(br->ofproto, &oso); |
b31bcf60 | 1163 | |
6f90b8f4 BP |
1164 | sset_destroy(&oso.targets); |
1165 | } | |
a7ff9bd7 | 1166 | |
88afd5fc RL |
1167 | /* Returns whether a IPFIX row is valid. */ |
1168 | static bool | |
1169 | ovsrec_ipfix_is_valid(const struct ovsrec_ipfix *ipfix) | |
1170 | { | |
1171 | return ipfix && ipfix->n_targets > 0; | |
1172 | } | |
1173 | ||
3388e51a RL |
1174 | /* Returns whether a Flow_Sample_Collector_Set row is valid. */ |
1175 | static bool | |
1176 | ovsrec_fscs_is_valid(const struct ovsrec_flow_sample_collector_set *fscs, | |
1177 | const struct bridge *br) | |
1178 | { | |
88afd5fc | 1179 | return ovsrec_ipfix_is_valid(fscs->ipfix) && fscs->bridge == br->cfg; |
3388e51a RL |
1180 | } |
1181 | ||
29089a54 RL |
1182 | /* Set IPFIX configuration on 'br'. */ |
1183 | static void | |
1184 | bridge_configure_ipfix(struct bridge *br) | |
1185 | { | |
1186 | const struct ovsrec_ipfix *be_cfg = br->cfg->ipfix; | |
88afd5fc | 1187 | bool valid_be_cfg = ovsrec_ipfix_is_valid(be_cfg); |
29089a54 RL |
1188 | const struct ovsrec_flow_sample_collector_set *fe_cfg; |
1189 | struct ofproto_ipfix_bridge_exporter_options be_opts; | |
1190 | struct ofproto_ipfix_flow_exporter_options *fe_opts = NULL; | |
1191 | size_t n_fe_opts = 0; | |
1192 | ||
1193 | OVSREC_FLOW_SAMPLE_COLLECTOR_SET_FOR_EACH(fe_cfg, idl) { | |
3388e51a | 1194 | if (ovsrec_fscs_is_valid(fe_cfg, br)) { |
29089a54 RL |
1195 | n_fe_opts++; |
1196 | } | |
1197 | } | |
1198 | ||
88afd5fc | 1199 | if (!valid_be_cfg && n_fe_opts == 0) { |
29089a54 RL |
1200 | ofproto_set_ipfix(br->ofproto, NULL, NULL, 0); |
1201 | return; | |
1202 | } | |
1203 | ||
88afd5fc | 1204 | if (valid_be_cfg) { |
29089a54 RL |
1205 | memset(&be_opts, 0, sizeof be_opts); |
1206 | ||
1207 | sset_init(&be_opts.targets); | |
1208 | sset_add_array(&be_opts.targets, be_cfg->targets, be_cfg->n_targets); | |
1209 | ||
1210 | if (be_cfg->sampling) { | |
1211 | be_opts.sampling_rate = *be_cfg->sampling; | |
1212 | } else { | |
1213 | be_opts.sampling_rate = SFL_DEFAULT_SAMPLING_RATE; | |
1214 | } | |
1215 | if (be_cfg->obs_domain_id) { | |
1216 | be_opts.obs_domain_id = *be_cfg->obs_domain_id; | |
1217 | } | |
1218 | if (be_cfg->obs_point_id) { | |
1219 | be_opts.obs_point_id = *be_cfg->obs_point_id; | |
1220 | } | |
978427a5 RL |
1221 | if (be_cfg->cache_active_timeout) { |
1222 | be_opts.cache_active_timeout = *be_cfg->cache_active_timeout; | |
1223 | } | |
1224 | if (be_cfg->cache_max_flows) { | |
1225 | be_opts.cache_max_flows = *be_cfg->cache_max_flows; | |
1226 | } | |
8b7ea2d4 WZ |
1227 | |
1228 | be_opts.enable_tunnel_sampling = smap_get_bool(&be_cfg->other_config, | |
1229 | "enable-tunnel-sampling", true); | |
1230 | ||
1231 | be_opts.enable_input_sampling = !smap_get_bool(&be_cfg->other_config, | |
1232 | "enable-input-sampling", false); | |
1233 | ||
1234 | be_opts.enable_output_sampling = !smap_get_bool(&be_cfg->other_config, | |
1235 | "enable-output-sampling", false); | |
29089a54 RL |
1236 | } |
1237 | ||
1238 | if (n_fe_opts > 0) { | |
1239 | struct ofproto_ipfix_flow_exporter_options *opts; | |
1240 | fe_opts = xcalloc(n_fe_opts, sizeof *fe_opts); | |
1241 | opts = fe_opts; | |
1242 | OVSREC_FLOW_SAMPLE_COLLECTOR_SET_FOR_EACH(fe_cfg, idl) { | |
3388e51a | 1243 | if (ovsrec_fscs_is_valid(fe_cfg, br)) { |
29089a54 RL |
1244 | opts->collector_set_id = fe_cfg->id; |
1245 | sset_init(&opts->targets); | |
1246 | sset_add_array(&opts->targets, fe_cfg->ipfix->targets, | |
1247 | fe_cfg->ipfix->n_targets); | |
978427a5 RL |
1248 | opts->cache_active_timeout = fe_cfg->ipfix->cache_active_timeout |
1249 | ? *fe_cfg->ipfix->cache_active_timeout : 0; | |
1250 | opts->cache_max_flows = fe_cfg->ipfix->cache_max_flows | |
1251 | ? *fe_cfg->ipfix->cache_max_flows : 0; | |
29089a54 RL |
1252 | opts++; |
1253 | } | |
1254 | } | |
1255 | } | |
1256 | ||
88afd5fc | 1257 | ofproto_set_ipfix(br->ofproto, valid_be_cfg ? &be_opts : NULL, fe_opts, |
29089a54 RL |
1258 | n_fe_opts); |
1259 | ||
88afd5fc | 1260 | if (valid_be_cfg) { |
29089a54 RL |
1261 | sset_destroy(&be_opts.targets); |
1262 | } | |
1263 | ||
1264 | if (n_fe_opts > 0) { | |
1265 | struct ofproto_ipfix_flow_exporter_options *opts = fe_opts; | |
1266 | size_t i; | |
1267 | for (i = 0; i < n_fe_opts; i++) { | |
1268 | sset_destroy(&opts->targets); | |
1269 | opts++; | |
1270 | } | |
1271 | free(fe_opts); | |
1272 | } | |
1273 | } | |
1274 | ||
21f7563c JP |
1275 | static void |
1276 | port_configure_stp(const struct ofproto *ofproto, struct port *port, | |
1277 | struct ofproto_port_stp_settings *port_s, | |
1278 | int *port_num_counter, unsigned long *port_num_bitmap) | |
1279 | { | |
1280 | const char *config_str; | |
1281 | struct iface *iface; | |
1282 | ||
079b5942 | 1283 | if (!smap_get_bool(&port->cfg->other_config, "stp-enable", true)) { |
21f7563c JP |
1284 | port_s->enable = false; |
1285 | return; | |
1286 | } else { | |
1287 | port_s->enable = true; | |
1288 | } | |
1289 | ||
1290 | /* STP over bonds is not supported. */ | |
1291 | if (!list_is_singleton(&port->ifaces)) { | |
1292 | VLOG_ERR("port %s: cannot enable STP on bonds, disabling", | |
1293 | port->name); | |
1294 | port_s->enable = false; | |
1295 | return; | |
1296 | } | |
1297 | ||
1298 | iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem); | |
1299 | ||
1300 | /* Internal ports shouldn't participate in spanning tree, so | |
1301 | * skip them. */ | |
1302 | if (!strcmp(iface->type, "internal")) { | |
1303 | VLOG_DBG("port %s: disable STP on internal ports", port->name); | |
1304 | port_s->enable = false; | |
1305 | return; | |
1306 | } | |
1307 | ||
1308 | /* STP on mirror output ports is not supported. */ | |
1309 | if (ofproto_is_mirror_output_bundle(ofproto, port)) { | |
1310 | VLOG_DBG("port %s: disable STP on mirror ports", port->name); | |
1311 | port_s->enable = false; | |
1312 | return; | |
1313 | } | |
1314 | ||
a699f614 | 1315 | config_str = smap_get(&port->cfg->other_config, "stp-port-num"); |
21f7563c JP |
1316 | if (config_str) { |
1317 | unsigned long int port_num = strtoul(config_str, NULL, 0); | |
1318 | int port_idx = port_num - 1; | |
1319 | ||
1320 | if (port_num < 1 || port_num > STP_MAX_PORTS) { | |
1321 | VLOG_ERR("port %s: invalid stp-port-num", port->name); | |
1322 | port_s->enable = false; | |
1323 | return; | |
1324 | } | |
1325 | ||
1326 | if (bitmap_is_set(port_num_bitmap, port_idx)) { | |
1327 | VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling", | |
1328 | port->name, port_num); | |
1329 | port_s->enable = false; | |
1330 | return; | |
1331 | } | |
1332 | bitmap_set1(port_num_bitmap, port_idx); | |
1333 | port_s->port_num = port_idx; | |
1334 | } else { | |
6019f124 | 1335 | if (*port_num_counter >= STP_MAX_PORTS) { |
21f7563c JP |
1336 | VLOG_ERR("port %s: too many STP ports, disabling", port->name); |
1337 | port_s->enable = false; | |
1338 | return; | |
1339 | } | |
1340 | ||
1341 | port_s->port_num = (*port_num_counter)++; | |
1342 | } | |
1343 | ||
a699f614 | 1344 | config_str = smap_get(&port->cfg->other_config, "stp-path-cost"); |
21f7563c JP |
1345 | if (config_str) { |
1346 | port_s->path_cost = strtoul(config_str, NULL, 10); | |
1347 | } else { | |
6c038611 | 1348 | enum netdev_features current; |
d02a5f8e | 1349 | unsigned int mbps; |
21f7563c | 1350 | |
d02a5f8e BP |
1351 | netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL); |
1352 | mbps = netdev_features_to_bps(current, 100 * 1000 * 1000) / 1000000; | |
1353 | port_s->path_cost = stp_convert_speed_to_cost(mbps); | |
21f7563c JP |
1354 | } |
1355 | ||
a699f614 | 1356 | config_str = smap_get(&port->cfg->other_config, "stp-port-priority"); |
21f7563c JP |
1357 | if (config_str) { |
1358 | port_s->priority = strtoul(config_str, NULL, 0); | |
1359 | } else { | |
1360 | port_s->priority = STP_DEFAULT_PORT_PRIORITY; | |
1361 | } | |
1362 | } | |
1363 | ||
9efd308e DV |
1364 | static void |
1365 | port_configure_rstp(const struct ofproto *ofproto, struct port *port, | |
1366 | struct ofproto_port_rstp_settings *port_s, int *port_num_counter) | |
1367 | { | |
1368 | const char *config_str; | |
1369 | struct iface *iface; | |
1370 | ||
1371 | if (!smap_get_bool(&port->cfg->other_config, "rstp-enable", true)) { | |
1372 | port_s->enable = false; | |
1373 | return; | |
1374 | } else { | |
1375 | port_s->enable = true; | |
1376 | } | |
1377 | ||
1378 | /* RSTP over bonds is not supported. */ | |
1379 | if (!list_is_singleton(&port->ifaces)) { | |
1380 | VLOG_ERR("port %s: cannot enable RSTP on bonds, disabling", | |
1381 | port->name); | |
1382 | port_s->enable = false; | |
1383 | return; | |
1384 | } | |
1385 | ||
1386 | iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem); | |
1387 | ||
1388 | /* Internal ports shouldn't participate in spanning tree, so | |
1389 | * skip them. */ | |
1390 | if (!strcmp(iface->type, "internal")) { | |
1391 | VLOG_DBG("port %s: disable RSTP on internal ports", port->name); | |
1392 | port_s->enable = false; | |
1393 | return; | |
1394 | } | |
1395 | ||
1396 | /* RSTP on mirror output ports is not supported. */ | |
1397 | if (ofproto_is_mirror_output_bundle(ofproto, port)) { | |
1398 | VLOG_DBG("port %s: disable RSTP on mirror ports", port->name); | |
1399 | port_s->enable = false; | |
1400 | return; | |
1401 | } | |
1402 | ||
1403 | config_str = smap_get(&port->cfg->other_config, "rstp-port-num"); | |
1404 | if (config_str) { | |
1405 | unsigned long int port_num = strtoul(config_str, NULL, 0); | |
1406 | if (port_num < 1 || port_num > RSTP_MAX_PORTS) { | |
1407 | VLOG_ERR("port %s: invalid rstp-port-num", port->name); | |
1408 | port_s->enable = false; | |
1409 | return; | |
1410 | } | |
1411 | port_s->port_num = port_num; | |
4b30ba05 | 1412 | } else { |
9efd308e DV |
1413 | if (*port_num_counter >= RSTP_MAX_PORTS) { |
1414 | VLOG_ERR("port %s: too many RSTP ports, disabling", port->name); | |
1415 | port_s->enable = false; | |
1416 | return; | |
1417 | } | |
4b30ba05 JR |
1418 | /* If rstp-port-num is not specified, use 0. |
1419 | * rstp_port_set_port_number() will look for the first free one. */ | |
9efd308e DV |
1420 | port_s->port_num = 0; |
1421 | } | |
1422 | ||
1423 | config_str = smap_get(&port->cfg->other_config, "rstp-path-cost"); | |
1424 | if (config_str) { | |
1425 | port_s->path_cost = strtoul(config_str, NULL, 10); | |
1426 | } else { | |
1427 | enum netdev_features current; | |
1428 | unsigned int mbps; | |
1429 | ||
1430 | netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL); | |
1431 | mbps = netdev_features_to_bps(current, 100 * 1000 * 1000) / 1000000; | |
1432 | port_s->path_cost = rstp_convert_speed_to_cost(mbps); | |
1433 | } | |
1434 | ||
1435 | config_str = smap_get(&port->cfg->other_config, "rstp-port-priority"); | |
1436 | if (config_str) { | |
1437 | port_s->priority = strtoul(config_str, NULL, 0); | |
1438 | } else { | |
1439 | port_s->priority = RSTP_DEFAULT_PORT_PRIORITY; | |
1440 | } | |
1441 | ||
67e8c1ac JR |
1442 | config_str = smap_get(&port->cfg->other_config, "rstp-admin-p2p-mac"); |
1443 | if (config_str) { | |
1444 | port_s->admin_p2p_mac_state = strtoul(config_str, NULL, 0); | |
1445 | } else { | |
1446 | port_s->admin_p2p_mac_state = RSTP_ADMIN_P2P_MAC_FORCE_TRUE; | |
1447 | } | |
1448 | ||
1449 | port_s->admin_port_state = smap_get_bool(&port->cfg->other_config, | |
1450 | "rstp-admin-port-state", true); | |
1451 | ||
9efd308e DV |
1452 | port_s->admin_edge_port = smap_get_bool(&port->cfg->other_config, |
1453 | "rstp-port-admin-edge", false); | |
1454 | port_s->auto_edge = smap_get_bool(&port->cfg->other_config, | |
1455 | "rstp-port-auto-edge", true); | |
1456 | port_s->mcheck = smap_get_bool(&port->cfg->other_config, | |
1457 | "rstp-port-mcheck", false); | |
1458 | } | |
1459 | ||
21f7563c JP |
1460 | /* Set spanning tree configuration on 'br'. */ |
1461 | static void | |
7af77bbd | 1462 | bridge_configure_stp(struct bridge *br, bool enable_stp) |
21f7563c | 1463 | { |
7af77bbd | 1464 | if (!enable_stp) { |
9efd308e | 1465 | ofproto_set_stp(br->ofproto, NULL); |
21f7563c JP |
1466 | } else { |
1467 | struct ofproto_stp_settings br_s; | |
1468 | const char *config_str; | |
1469 | struct port *port; | |
1470 | int port_num_counter; | |
1471 | unsigned long *port_num_bitmap; | |
1472 | ||
a699f614 | 1473 | config_str = smap_get(&br->cfg->other_config, "stp-system-id"); |
21f7563c | 1474 | if (config_str) { |
74ff3298 | 1475 | struct eth_addr ea; |
21f7563c | 1476 | |
74ff3298 | 1477 | if (eth_addr_from_string(config_str, &ea)) { |
21f7563c JP |
1478 | br_s.system_id = eth_addr_to_uint64(ea); |
1479 | } else { | |
1480 | br_s.system_id = eth_addr_to_uint64(br->ea); | |
1481 | VLOG_ERR("bridge %s: invalid stp-system-id, defaulting " | |
1482 | "to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea)); | |
1483 | } | |
1484 | } else { | |
1485 | br_s.system_id = eth_addr_to_uint64(br->ea); | |
1486 | } | |
1487 | ||
a699f614 | 1488 | config_str = smap_get(&br->cfg->other_config, "stp-priority"); |
21f7563c JP |
1489 | if (config_str) { |
1490 | br_s.priority = strtoul(config_str, NULL, 0); | |
1491 | } else { | |
1492 | br_s.priority = STP_DEFAULT_BRIDGE_PRIORITY; | |
1493 | } | |
1494 | ||
a699f614 | 1495 | config_str = smap_get(&br->cfg->other_config, "stp-hello-time"); |
21f7563c JP |
1496 | if (config_str) { |
1497 | br_s.hello_time = strtoul(config_str, NULL, 10) * 1000; | |
1498 | } else { | |
1499 | br_s.hello_time = STP_DEFAULT_HELLO_TIME; | |
1500 | } | |
1501 | ||
a699f614 | 1502 | config_str = smap_get(&br->cfg->other_config, "stp-max-age"); |
21f7563c JP |
1503 | if (config_str) { |
1504 | br_s.max_age = strtoul(config_str, NULL, 10) * 1000; | |
1505 | } else { | |
1506 | br_s.max_age = STP_DEFAULT_MAX_AGE; | |
1507 | } | |
1508 | ||
a699f614 | 1509 | config_str = smap_get(&br->cfg->other_config, "stp-forward-delay"); |
21f7563c JP |
1510 | if (config_str) { |
1511 | br_s.fwd_delay = strtoul(config_str, NULL, 10) * 1000; | |
1512 | } else { | |
1513 | br_s.fwd_delay = STP_DEFAULT_FWD_DELAY; | |
1514 | } | |
1515 | ||
1516 | /* Configure STP on the bridge. */ | |
1517 | if (ofproto_set_stp(br->ofproto, &br_s)) { | |
1518 | VLOG_ERR("bridge %s: could not enable STP", br->name); | |
1519 | return; | |
1520 | } | |
1521 | ||
1522 | /* Users must either set the port number with the "stp-port-num" | |
1523 | * configuration on all ports or none. If manual configuration | |
1524 | * is not done, then we allocate them sequentially. */ | |
1525 | port_num_counter = 0; | |
1526 | port_num_bitmap = bitmap_allocate(STP_MAX_PORTS); | |
1527 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { | |
1528 | struct ofproto_port_stp_settings port_s; | |
1529 | struct iface *iface; | |
1530 | ||
1531 | port_configure_stp(br->ofproto, port, &port_s, | |
1532 | &port_num_counter, port_num_bitmap); | |
1533 | ||
1534 | /* As bonds are not supported, just apply configuration to | |
1535 | * all interfaces. */ | |
1536 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { | |
1537 | if (ofproto_port_set_stp(br->ofproto, iface->ofp_port, | |
1538 | &port_s)) { | |
1539 | VLOG_ERR("port %s: could not enable STP", port->name); | |
1540 | continue; | |
1541 | } | |
1542 | } | |
1543 | } | |
1544 | ||
b71273f6 | 1545 | if (bitmap_scan(port_num_bitmap, 1, 0, STP_MAX_PORTS) != STP_MAX_PORTS |
21f7563c JP |
1546 | && port_num_counter) { |
1547 | VLOG_ERR("bridge %s: must manually configure all STP port " | |
1548 | "IDs or none, disabling", br->name); | |
1549 | ofproto_set_stp(br->ofproto, NULL); | |
1550 | } | |
1551 | bitmap_free(port_num_bitmap); | |
1552 | } | |
1553 | } | |
1554 | ||
9efd308e | 1555 | static void |
7af77bbd | 1556 | bridge_configure_rstp(struct bridge *br, bool enable_rstp) |
9efd308e | 1557 | { |
7af77bbd | 1558 | if (!enable_rstp) { |
9efd308e | 1559 | ofproto_set_rstp(br->ofproto, NULL); |
9efd308e DV |
1560 | } else { |
1561 | struct ofproto_rstp_settings br_s; | |
1562 | const char *config_str; | |
1563 | struct port *port; | |
1564 | int port_num_counter; | |
1565 | ||
1566 | config_str = smap_get(&br->cfg->other_config, "rstp-address"); | |
1567 | if (config_str) { | |
74ff3298 | 1568 | struct eth_addr ea; |
9efd308e | 1569 | |
74ff3298 | 1570 | if (eth_addr_from_string(config_str, &ea)) { |
9efd308e DV |
1571 | br_s.address = eth_addr_to_uint64(ea); |
1572 | } | |
1573 | else { | |
1574 | br_s.address = eth_addr_to_uint64(br->ea); | |
1575 | VLOG_ERR("bridge %s: invalid rstp-address, defaulting " | |
1576 | "to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea)); | |
1577 | } | |
1578 | } | |
1579 | else { | |
1580 | br_s.address = eth_addr_to_uint64(br->ea); | |
1581 | } | |
1582 | ||
1583 | config_str = smap_get(&br->cfg->other_config, "rstp-priority"); | |
1584 | if (config_str) { | |
1585 | br_s.priority = strtoul(config_str, NULL, 0); | |
1586 | } else { | |
1587 | br_s.priority = RSTP_DEFAULT_PRIORITY; | |
1588 | } | |
1589 | ||
1590 | config_str = smap_get(&br->cfg->other_config, "rstp-ageing-time"); | |
1591 | if (config_str) { | |
1592 | br_s.ageing_time = strtoul(config_str, NULL, 0); | |
1593 | } else { | |
1594 | br_s.ageing_time = RSTP_DEFAULT_AGEING_TIME; | |
1595 | } | |
1596 | ||
1597 | config_str = smap_get(&br->cfg->other_config, | |
1598 | "rstp-force-protocol-version"); | |
1599 | if (config_str) { | |
1600 | br_s.force_protocol_version = strtoul(config_str, NULL, 0); | |
1601 | } else { | |
1602 | br_s.force_protocol_version = FPV_DEFAULT; | |
1603 | } | |
1604 | ||
1605 | config_str = smap_get(&br->cfg->other_config, "rstp-max-age"); | |
1606 | if (config_str) { | |
1607 | br_s.bridge_max_age = strtoul(config_str, NULL, 10); | |
1608 | } else { | |
1609 | br_s.bridge_max_age = RSTP_DEFAULT_BRIDGE_MAX_AGE; | |
1610 | } | |
1611 | ||
1612 | config_str = smap_get(&br->cfg->other_config, "rstp-forward-delay"); | |
1613 | if (config_str) { | |
1614 | br_s.bridge_forward_delay = strtoul(config_str, NULL, 10); | |
1615 | } else { | |
1616 | br_s.bridge_forward_delay = RSTP_DEFAULT_BRIDGE_FORWARD_DELAY; | |
1617 | } | |
1618 | ||
1619 | config_str = smap_get(&br->cfg->other_config, | |
1620 | "rstp-transmit-hold-count"); | |
1621 | if (config_str) { | |
1622 | br_s.transmit_hold_count = strtoul(config_str, NULL, 10); | |
1623 | } else { | |
1624 | br_s.transmit_hold_count = RSTP_DEFAULT_TRANSMIT_HOLD_COUNT; | |
1625 | } | |
1626 | ||
1627 | /* Configure RSTP on the bridge. */ | |
1628 | if (ofproto_set_rstp(br->ofproto, &br_s)) { | |
1629 | VLOG_ERR("bridge %s: could not enable RSTP", br->name); | |
1630 | return; | |
1631 | } | |
1632 | ||
1633 | port_num_counter = 0; | |
1634 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { | |
1635 | struct ofproto_port_rstp_settings port_s; | |
1636 | struct iface *iface; | |
1637 | ||
1638 | port_configure_rstp(br->ofproto, port, &port_s, | |
1639 | &port_num_counter); | |
1640 | ||
1641 | /* As bonds are not supported, just apply configuration to | |
1642 | * all interfaces. */ | |
1643 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { | |
1644 | if (ofproto_port_set_rstp(br->ofproto, iface->ofp_port, | |
1645 | &port_s)) { | |
1646 | VLOG_ERR("port %s: could not enable RSTP", port->name); | |
1647 | continue; | |
1648 | } | |
1649 | } | |
1650 | } | |
1651 | } | |
1652 | } | |
1653 | ||
7af77bbd BP |
1654 | static void |
1655 | bridge_configure_spanning_tree(struct bridge *br) | |
1656 | { | |
1657 | bool enable_rstp = br->cfg->rstp_enable; | |
1658 | bool enable_stp = br->cfg->stp_enable; | |
1659 | ||
1660 | if (enable_rstp && enable_stp) { | |
1661 | VLOG_WARN("%s: RSTP and STP are mutually exclusive but both are " | |
1662 | "configured; enabling RSTP", br->name); | |
1663 | enable_stp = false; | |
1664 | } | |
1665 | ||
1666 | bridge_configure_stp(br, enable_stp); | |
1667 | bridge_configure_rstp(br, enable_rstp); | |
1668 | } | |
1669 | ||
e8192d80 BP |
1670 | static bool |
1671 | bridge_has_bond_fake_iface(const struct bridge *br, const char *name) | |
1672 | { | |
1673 | const struct port *port = port_lookup(br, name); | |
1674 | return port && port_is_bond_fake_iface(port); | |
093e47f4 BP |
1675 | } |
1676 | ||
e8192d80 BP |
1677 | static bool |
1678 | port_is_bond_fake_iface(const struct port *port) | |
093e47f4 | 1679 | { |
e8192d80 BP |
1680 | return port->cfg->bond_fake_iface && !list_is_short(&port->ifaces); |
1681 | } | |
093e47f4 | 1682 | |
66da9bef BP |
1683 | static void |
1684 | add_del_bridges(const struct ovsrec_open_vswitch *cfg) | |
1685 | { | |
1686 | struct bridge *br, *next; | |
e6448d2f | 1687 | struct shash_node *node; |
66da9bef BP |
1688 | struct shash new_br; |
1689 | size_t i; | |
1690 | ||
1691 | /* Collect new bridges' names and types. */ | |
1692 | shash_init(&new_br); | |
1693 | for (i = 0; i < cfg->n_bridges; i++) { | |
5af5b532 | 1694 | static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); |
66da9bef | 1695 | const struct ovsrec_bridge *br_cfg = cfg->bridges[i]; |
5af5b532 | 1696 | |
3cbe33df | 1697 | if (strchr(br_cfg->name, '/') || strchr(br_cfg->name, '\\')) { |
5af5b532 | 1698 | /* Prevent remote ovsdb-server users from accessing arbitrary |
3cbe33df BP |
1699 | * directories, e.g. consider a bridge named "../../../etc/". |
1700 | * | |
1701 | * Prohibiting "\" is only necessary on Windows but it's no great | |
1702 | * loss elsewhere. */ | |
5af5b532 BP |
1703 | VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"", |
1704 | br_cfg->name); | |
1705 | } else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) { | |
1706 | VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name); | |
66da9bef BP |
1707 | } |
1708 | } | |
1709 | ||
1710 | /* Get rid of deleted bridges or those whose types have changed. | |
1711 | * Update 'cfg' of bridges that still exist. */ | |
1712 | HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) { | |
1713 | br->cfg = shash_find_data(&new_br, br->name); | |
f79e673f BP |
1714 | if (!br->cfg || strcmp(br->type, ofproto_normalize_type( |
1715 | br->cfg->datapath_type))) { | |
66da9bef BP |
1716 | bridge_destroy(br); |
1717 | } | |
1718 | } | |
1719 | ||
1720 | /* Add new bridges. */ | |
e6448d2f DDP |
1721 | SHASH_FOR_EACH(node, &new_br) { |
1722 | const struct ovsrec_bridge *br_cfg = node->data; | |
66da9bef BP |
1723 | struct bridge *br = bridge_lookup(br_cfg->name); |
1724 | if (!br) { | |
1725 | bridge_create(br_cfg); | |
1726 | } | |
1727 | } | |
1728 | ||
1729 | shash_destroy(&new_br); | |
1730 | } | |
1731 | ||
2a485ee8 BP |
1732 | /* Configures 'netdev' based on the "options" column in 'iface_cfg'. |
1733 | * Returns 0 if successful, otherwise a positive errno value. */ | |
1734 | static int | |
1735 | iface_set_netdev_config(const struct ovsrec_interface *iface_cfg, | |
bbe6109d | 1736 | struct netdev *netdev, char **errp) |
2a485ee8 | 1737 | { |
bbe6109d | 1738 | return netdev_set_config(netdev, &iface_cfg->options, errp); |
2a485ee8 BP |
1739 | } |
1740 | ||
fb2ec1e9 YT |
1741 | /* Opens a network device for 'if_cfg' and configures it. Adds the network |
1742 | * device to br->ofproto and stores the OpenFlow port number in '*ofp_portp'. | |
cc086465 BP |
1743 | * |
1744 | * If successful, returns 0 and stores the network device in '*netdevp'. On | |
1745 | * failure, returns a positive errno value and stores NULL in '*netdevp'. */ | |
1746 | static int | |
1747 | iface_do_create(const struct bridge *br, | |
2a73b1d7 BP |
1748 | const struct ovsrec_interface *iface_cfg, |
1749 | const struct ovsrec_port *port_cfg, | |
bbe6109d TG |
1750 | ofp_port_t *ofp_portp, struct netdev **netdevp, |
1751 | char **errp) | |
cc086465 | 1752 | { |
2291eb08 | 1753 | struct netdev *netdev = NULL; |
cc086465 BP |
1754 | int error; |
1755 | ||
94a53842 AW |
1756 | if (netdev_is_reserved_name(iface_cfg->name)) { |
1757 | VLOG_WARN("could not create interface %s, name is reserved", | |
1758 | iface_cfg->name); | |
1759 | error = EINVAL; | |
1760 | goto error; | |
1761 | } | |
1762 | ||
cc086465 BP |
1763 | error = netdev_open(iface_cfg->name, |
1764 | iface_get_type(iface_cfg, br->cfg), &netdev); | |
1765 | if (error) { | |
bbe6109d TG |
1766 | VLOG_WARN_BUF(errp, "could not open network device %s (%s)", |
1767 | iface_cfg->name, ovs_strerror(error)); | |
cc086465 BP |
1768 | goto error; |
1769 | } | |
1770 | ||
bbe6109d | 1771 | error = iface_set_netdev_config(iface_cfg, netdev, errp); |
cc086465 BP |
1772 | if (error) { |
1773 | goto error; | |
1774 | } | |
1775 | ||
2a73b1d7 BP |
1776 | *ofp_portp = iface_pick_ofport(iface_cfg); |
1777 | error = ofproto_port_add(br->ofproto, netdev, ofp_portp); | |
1778 | if (error) { | |
1779 | goto error; | |
cc086465 BP |
1780 | } |
1781 | ||
2a73b1d7 BP |
1782 | VLOG_INFO("bridge %s: added interface %s on port %d", |
1783 | br->name, iface_cfg->name, *ofp_portp); | |
1784 | ||
1839c356 | 1785 | if (port_cfg->vlan_mode && !strcmp(port_cfg->vlan_mode, "splinter")) { |
4b609110 | 1786 | netdev_turn_flags_on(netdev, NETDEV_UP, NULL); |
cc086465 BP |
1787 | } |
1788 | ||
1789 | *netdevp = netdev; | |
1790 | return 0; | |
1791 | ||
1792 | error: | |
1793 | *netdevp = NULL; | |
1794 | netdev_close(netdev); | |
1795 | return error; | |
1796 | } | |
1797 | ||
bae7208e | 1798 | /* Creates a new iface on 'br' based on 'if_cfg'. The new iface has OpenFlow |
c60c33fb | 1799 | * port number 'ofp_port'. If ofp_port is OFPP_NONE, an OpenFlow port is |
bae7208e | 1800 | * automatically allocated for the iface. Takes ownership of and |
01546f5d BP |
1801 | * deallocates 'if_cfg'. |
1802 | * | |
1803 | * Return true if an iface is successfully created, false otherwise. */ | |
1804 | static bool | |
2a73b1d7 BP |
1805 | iface_create(struct bridge *br, const struct ovsrec_interface *iface_cfg, |
1806 | const struct ovsrec_port *port_cfg) | |
66da9bef | 1807 | { |
cc086465 | 1808 | struct netdev *netdev; |
bae7208e | 1809 | struct iface *iface; |
2a73b1d7 | 1810 | ofp_port_t ofp_port; |
bae7208e | 1811 | struct port *port; |
bbe6109d | 1812 | char *errp = NULL; |
bae7208e | 1813 | int error; |
52a90c29 | 1814 | |
a6b7506d | 1815 | /* Do the bits that can fail up front. */ |
cb22974d | 1816 | ovs_assert(!iface_lookup(br, iface_cfg->name)); |
bbe6109d | 1817 | error = iface_do_create(br, iface_cfg, port_cfg, &ofp_port, &netdev, &errp); |
bae7208e | 1818 | if (error) { |
bbe6109d TG |
1819 | iface_clear_db_record(iface_cfg, errp); |
1820 | free(errp); | |
2a73b1d7 | 1821 | return false; |
bae7208e | 1822 | } |
c7e7bb21 | 1823 | |
cc086465 BP |
1824 | /* Get or create the port structure. */ |
1825 | port = port_lookup(br, port_cfg->name); | |
1826 | if (!port) { | |
1827 | port = port_create(br, port_cfg); | |
bae7208e EJ |
1828 | } |
1829 | ||
cc086465 BP |
1830 | /* Create the iface structure. */ |
1831 | iface = xzalloc(sizeof *iface); | |
1832 | list_push_back(&port->ifaces, &iface->port_elem); | |
1833 | hmap_insert(&br->iface_by_name, &iface->name_node, | |
1834 | hash_string(iface_cfg->name, 0)); | |
1835 | iface->port = port; | |
1836 | iface->name = xstrdup(iface_cfg->name); | |
2a73b1d7 | 1837 | iface->ofp_port = ofp_port; |
cc086465 BP |
1838 | iface->netdev = netdev; |
1839 | iface->type = iface_get_type(iface_cfg, br->cfg); | |
1840 | iface->cfg = iface_cfg; | |
2a73b1d7 BP |
1841 | hmap_insert(&br->ifaces, &iface->ofp_port_node, |
1842 | hash_ofp_port(ofp_port)); | |
8b5da7a6 | 1843 | |
cc086465 BP |
1844 | /* Populate initial status in database. */ |
1845 | iface_refresh_stats(iface); | |
6a5f9a8f | 1846 | iface_refresh_netdev_status(iface); |
bae7208e EJ |
1847 | |
1848 | /* Add bond fake iface if necessary. */ | |
1849 | if (port_is_bond_fake_iface(port)) { | |
8b5da7a6 BP |
1850 | struct ofproto_port ofproto_port; |
1851 | ||
bae7208e EJ |
1852 | if (ofproto_port_query_by_name(br->ofproto, port->name, |
1853 | &ofproto_port)) { | |
1854 | struct netdev *netdev; | |
1855 | int error; | |
1856 | ||
1857 | error = netdev_open(port->name, "internal", &netdev); | |
1858 | if (!error) { | |
4abb8608 | 1859 | ofp_port_t fake_ofp_port = OFPP_NONE; |
0d7bb1b4 | 1860 | ofproto_port_add(br->ofproto, netdev, &fake_ofp_port); |
bae7208e | 1861 | netdev_close(netdev); |
66da9bef | 1862 | } else { |
bae7208e | 1863 | VLOG_WARN("could not open network device %s (%s)", |
10a89ef0 | 1864 | port->name, ovs_strerror(error)); |
66da9bef | 1865 | } |
bae7208e EJ |
1866 | } else { |
1867 | /* Already exists, nothing to do. */ | |
1868 | ofproto_port_destroy(&ofproto_port); | |
66da9bef BP |
1869 | } |
1870 | } | |
01546f5d | 1871 | |
2a73b1d7 | 1872 | return true; |
66da9bef BP |
1873 | } |
1874 | ||
8402c74b SS |
1875 | /* Set forward BPDU option. */ |
1876 | static void | |
1877 | bridge_configure_forward_bpdu(struct bridge *br) | |
1878 | { | |
a699f614 EJ |
1879 | ofproto_set_forward_bpdu(br->ofproto, |
1880 | smap_get_bool(&br->cfg->other_config, | |
1881 | "forward-bpdu", | |
1882 | false)); | |
8402c74b SS |
1883 | } |
1884 | ||
c4069512 | 1885 | /* Set MAC learning table configuration for 'br'. */ |
e764773c | 1886 | static void |
c4069512 | 1887 | bridge_configure_mac_table(struct bridge *br) |
e764773c BP |
1888 | { |
1889 | const char *idle_time_str; | |
1890 | int idle_time; | |
1891 | ||
c4069512 BP |
1892 | const char *mac_table_size_str; |
1893 | int mac_table_size; | |
1894 | ||
a699f614 | 1895 | idle_time_str = smap_get(&br->cfg->other_config, "mac-aging-time"); |
e764773c BP |
1896 | idle_time = (idle_time_str && atoi(idle_time_str) |
1897 | ? atoi(idle_time_str) | |
1898 | : MAC_ENTRY_DEFAULT_IDLE_TIME); | |
c4069512 BP |
1899 | |
1900 | mac_table_size_str = smap_get(&br->cfg->other_config, "mac-table-size"); | |
1901 | mac_table_size = (mac_table_size_str && atoi(mac_table_size_str) | |
1902 | ? atoi(mac_table_size_str) | |
1903 | : MAC_DEFAULT_MAX); | |
1904 | ||
1905 | ofproto_set_mac_table_config(br->ofproto, idle_time, mac_table_size); | |
e764773c BP |
1906 | } |
1907 | ||
dc2b70ba FL |
1908 | /* Set multicast snooping table configuration for 'br'. */ |
1909 | static void | |
1910 | bridge_configure_mcast_snooping(struct bridge *br) | |
1911 | { | |
1912 | if (!br->cfg->mcast_snooping_enable) { | |
1913 | ofproto_set_mcast_snooping(br->ofproto, NULL); | |
1914 | } else { | |
1915 | struct port *port; | |
1916 | struct ofproto_mcast_snooping_settings br_s; | |
1917 | const char *idle_time_str; | |
1918 | const char *max_entries_str; | |
1919 | ||
1920 | idle_time_str = smap_get(&br->cfg->other_config, | |
1921 | "mcast-snooping-aging-time"); | |
1922 | br_s.idle_time = (idle_time_str && atoi(idle_time_str) | |
1923 | ? atoi(idle_time_str) | |
1924 | : MCAST_ENTRY_DEFAULT_IDLE_TIME); | |
1925 | ||
1926 | max_entries_str = smap_get(&br->cfg->other_config, | |
1927 | "mcast-snooping-table-size"); | |
1928 | br_s.max_entries = (max_entries_str && atoi(max_entries_str) | |
1929 | ? atoi(max_entries_str) | |
1930 | : MCAST_DEFAULT_MAX_ENTRIES); | |
1931 | ||
1932 | br_s.flood_unreg = !smap_get_bool(&br->cfg->other_config, | |
1933 | "mcast-snooping-disable-flood-unregistered", | |
1934 | false); | |
1935 | ||
1936 | /* Configure multicast snooping on the bridge */ | |
1937 | if (ofproto_set_mcast_snooping(br->ofproto, &br_s)) { | |
1938 | VLOG_ERR("bridge %s: could not enable multicast snooping", | |
1939 | br->name); | |
1940 | return; | |
1941 | } | |
1942 | ||
1943 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { | |
8e04a33f FL |
1944 | struct ofproto_mcast_snooping_port_settings port_s; |
1945 | port_s.flood = smap_get_bool(&port->cfg->other_config, | |
dc2b70ba | 1946 | "mcast-snooping-flood", false); |
8e04a33f FL |
1947 | port_s.flood_reports = smap_get_bool(&port->cfg->other_config, |
1948 | "mcast-snooping-flood-reports", false); | |
1949 | if (ofproto_port_set_mcast_snooping(br->ofproto, port, &port_s)) { | |
dc2b70ba FL |
1950 | VLOG_ERR("port %s: could not configure mcast snooping", |
1951 | port->name); | |
1952 | } | |
1953 | } | |
1954 | } | |
1955 | } | |
1956 | ||
064af421 | 1957 | static void |
74ff3298 | 1958 | find_local_hw_addr(const struct bridge *br, struct eth_addr *ea, |
21a955fc | 1959 | const struct port *fake_br, struct iface **hw_addr_iface) |
064af421 | 1960 | { |
f145afdc | 1961 | struct hmapx mirror_output_ports; |
8052fb14 | 1962 | struct port *port; |
3a48ace3 | 1963 | bool found_addr = false; |
064af421 | 1964 | int error; |
f145afdc | 1965 | int i; |
064af421 | 1966 | |
f145afdc BP |
1967 | /* Mirror output ports don't participate in picking the local hardware |
1968 | * address. ofproto can't help us find out whether a given port is a | |
1969 | * mirror output because we haven't configured mirrors yet, so we need to | |
1970 | * accumulate them ourselves. */ | |
1971 | hmapx_init(&mirror_output_ports); | |
1972 | for (i = 0; i < br->cfg->n_mirrors; i++) { | |
1973 | struct ovsrec_mirror *m = br->cfg->mirrors[i]; | |
1974 | if (m->output_port) { | |
1975 | hmapx_add(&mirror_output_ports, m->output_port); | |
1976 | } | |
1977 | } | |
1978 | ||
141f4942 BP |
1979 | /* Otherwise choose the minimum non-local MAC address among all of the |
1980 | * interfaces. */ | |
8052fb14 | 1981 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { |
74ff3298 | 1982 | struct eth_addr iface_ea; |
83db7968 | 1983 | struct iface *candidate; |
58b7527e BP |
1984 | struct iface *iface; |
1985 | ||
1986 | /* Mirror output ports don't participate. */ | |
f145afdc | 1987 | if (hmapx_contains(&mirror_output_ports, port->cfg)) { |
064af421 BP |
1988 | continue; |
1989 | } | |
58b7527e BP |
1990 | |
1991 | /* Choose the MAC address to represent the port. */ | |
83db7968 | 1992 | iface = NULL; |
74ff3298 JR |
1993 | if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, |
1994 | &iface_ea)) { | |
ba09980a BP |
1995 | /* Find the interface with this Ethernet address (if any) so that |
1996 | * we can provide the correct devname to the caller. */ | |
83db7968 | 1997 | LIST_FOR_EACH (candidate, port_elem, &port->ifaces) { |
74ff3298 JR |
1998 | struct eth_addr candidate_ea; |
1999 | if (!netdev_get_etheraddr(candidate->netdev, &candidate_ea) | |
ba09980a BP |
2000 | && eth_addr_equals(iface_ea, candidate_ea)) { |
2001 | iface = candidate; | |
2002 | } | |
2003 | } | |
58b7527e BP |
2004 | } else { |
2005 | /* Choose the interface whose MAC address will represent the port. | |
2006 | * The Linux kernel bonding code always chooses the MAC address of | |
2007 | * the first slave added to a bond, and the Fedora networking | |
2008 | * scripts always add slaves to a bond in alphabetical order, so | |
2009 | * for compatibility we choose the interface with the name that is | |
2010 | * first in alphabetical order. */ | |
83db7968 BP |
2011 | LIST_FOR_EACH (candidate, port_elem, &port->ifaces) { |
2012 | if (!iface || strcmp(candidate->name, iface->name) < 0) { | |
58b7527e BP |
2013 | iface = candidate; |
2014 | } | |
2015 | } | |
2016 | ||
2017 | /* The local port doesn't count (since we're trying to choose its | |
141f4942 | 2018 | * MAC address anyway). */ |
892815f5 | 2019 | if (iface->ofp_port == OFPP_LOCAL) { |
064af421 BP |
2020 | continue; |
2021 | } | |
58b7527e | 2022 | |
21a955fc HS |
2023 | /* For fake bridges we only choose from ports with the same tag */ |
2024 | if (fake_br && fake_br->cfg && fake_br->cfg->tag) { | |
2025 | if (!port->cfg->tag) { | |
2026 | continue; | |
2027 | } | |
2028 | if (*port->cfg->tag != *fake_br->cfg->tag) { | |
2029 | continue; | |
2030 | } | |
2031 | } | |
2032 | ||
58b7527e | 2033 | /* Grab MAC. */ |
74ff3298 | 2034 | error = netdev_get_etheraddr(iface->netdev, &iface_ea); |
58b7527e | 2035 | if (error) { |
58b7527e | 2036 | continue; |
064af421 BP |
2037 | } |
2038 | } | |
58b7527e BP |
2039 | |
2040 | /* Compare against our current choice. */ | |
2041 | if (!eth_addr_is_multicast(iface_ea) && | |
141f4942 | 2042 | !eth_addr_is_local(iface_ea) && |
58b7527e BP |
2043 | !eth_addr_is_reserved(iface_ea) && |
2044 | !eth_addr_is_zero(iface_ea) && | |
74ff3298 | 2045 | (!found_addr || eth_addr_compare_3way(iface_ea, *ea) < 0)) |
58b7527e | 2046 | { |
74ff3298 | 2047 | *ea = iface_ea; |
8fef8c71 | 2048 | *hw_addr_iface = iface; |
3a48ace3 | 2049 | found_addr = true; |
58b7527e | 2050 | } |
064af421 | 2051 | } |
f145afdc | 2052 | |
51b67a10 | 2053 | if (!found_addr) { |
74ff3298 | 2054 | *ea = br->default_ea; |
51b67a10 JP |
2055 | *hw_addr_iface = NULL; |
2056 | } | |
2057 | ||
f145afdc | 2058 | hmapx_destroy(&mirror_output_ports); |
064af421 BP |
2059 | } |
2060 | ||
4bc1cfde | 2061 | static void |
74ff3298 | 2062 | bridge_pick_local_hw_addr(struct bridge *br, struct eth_addr *ea, |
4bc1cfde HS |
2063 | struct iface **hw_addr_iface) |
2064 | { | |
2065 | const char *hwaddr; | |
2066 | *hw_addr_iface = NULL; | |
2067 | ||
2068 | /* Did the user request a particular MAC? */ | |
2069 | hwaddr = smap_get(&br->cfg->other_config, "hwaddr"); | |
2070 | if (hwaddr && eth_addr_from_string(hwaddr, ea)) { | |
74ff3298 | 2071 | if (eth_addr_is_multicast(*ea)) { |
4bc1cfde | 2072 | VLOG_ERR("bridge %s: cannot set MAC address to multicast " |
74ff3298 JR |
2073 | "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(*ea)); |
2074 | } else if (eth_addr_is_zero(*ea)) { | |
4bc1cfde HS |
2075 | VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name); |
2076 | } else { | |
2077 | return; | |
2078 | } | |
2079 | } | |
2080 | ||
2081 | /* Find a local hw address */ | |
21a955fc | 2082 | find_local_hw_addr(br, ea, NULL, hw_addr_iface); |
4bc1cfde HS |
2083 | } |
2084 | ||
064af421 BP |
2085 | /* Choose and returns the datapath ID for bridge 'br' given that the bridge |
2086 | * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of | |
07c318f4 BP |
2087 | * an interface on 'br', then that interface must be passed in as |
2088 | * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then | |
2089 | * 'hw_addr_iface' must be passed in as a null pointer. */ | |
064af421 BP |
2090 | static uint64_t |
2091 | bridge_pick_datapath_id(struct bridge *br, | |
74ff3298 | 2092 | const struct eth_addr bridge_ea, |
07c318f4 | 2093 | struct iface *hw_addr_iface) |
064af421 BP |
2094 | { |
2095 | /* | |
2096 | * The procedure for choosing a bridge MAC address will, in the most | |
2097 | * ordinary case, also choose a unique MAC that we can use as a datapath | |
2098 | * ID. In some special cases, though, multiple bridges will end up with | |
2099 | * the same MAC address. This is OK for the bridges, but it will confuse | |
2100 | * the OpenFlow controller, because each datapath needs a unique datapath | |
2101 | * ID. | |
2102 | * | |
2103 | * Datapath IDs must be unique. It is also very desirable that they be | |
2104 | * stable from one run to the next, so that policy set on a datapath | |
2105 | * "sticks". | |
2106 | */ | |
093e47f4 | 2107 | const char *datapath_id; |
064af421 BP |
2108 | uint64_t dpid; |
2109 | ||
a699f614 | 2110 | datapath_id = smap_get(&br->cfg->other_config, "datapath-id"); |
093e47f4 | 2111 | if (datapath_id && dpid_from_string(datapath_id, &dpid)) { |
064af421 BP |
2112 | return dpid; |
2113 | } | |
2114 | ||
03eae5f8 | 2115 | if (!hw_addr_iface) { |
064af421 BP |
2116 | /* |
2117 | * A purely internal bridge, that is, one that has no non-virtual | |
03eae5f8 | 2118 | * network devices on it at all, is difficult because it has no |
064af421 BP |
2119 | * natural unique identifier at all. |
2120 | * | |
2121 | * When the host is a XenServer, we handle this case by hashing the | |
2122 | * host's UUID with the name of the bridge. Names of bridges are | |
2123 | * persistent across XenServer reboots, although they can be reused if | |
2124 | * an internal network is destroyed and then a new one is later | |
2125 | * created, so this is fairly effective. | |
2126 | * | |
2127 | * When the host is not a XenServer, we punt by using a random MAC | |
2128 | * address on each run. | |
2129 | */ | |
2130 | const char *host_uuid = xenserver_get_host_uuid(); | |
2131 | if (host_uuid) { | |
2132 | char *combined = xasprintf("%s,%s", host_uuid, br->name); | |
2133 | dpid = dpid_from_hash(combined, strlen(combined)); | |
2134 | free(combined); | |
2135 | return dpid; | |
2136 | } | |
2137 | } | |
2138 | ||
2139 | return eth_addr_to_uint64(bridge_ea); | |
2140 | } | |
2141 | ||
2142 | static uint64_t | |
2143 | dpid_from_hash(const void *data, size_t n) | |
2144 | { | |
74ff3298 JR |
2145 | union { |
2146 | uint8_t bytes[SHA1_DIGEST_SIZE]; | |
2147 | struct eth_addr ea; | |
2148 | } hash; | |
2149 | ||
2150 | sha1_bytes(data, n, hash.bytes); | |
2151 | eth_addr_mark_random(&hash.ea); | |
2152 | return eth_addr_to_uint64(hash.ea); | |
064af421 BP |
2153 | } |
2154 | ||
ea83a2fc | 2155 | static void |
6a5f9a8f | 2156 | iface_refresh_netdev_status(struct iface *iface) |
ea83a2fc | 2157 | { |
79f1cbe9 | 2158 | struct smap smap; |
ea763e0e | 2159 | |
6c038611 | 2160 | enum netdev_features current; |
6a5f9a8f AW |
2161 | enum netdev_flags flags; |
2162 | const char *link_state; | |
74ff3298 | 2163 | struct eth_addr mac; |
6a5f9a8f AW |
2164 | int64_t bps, mtu_64, ifindex64, link_resets; |
2165 | int mtu, error; | |
e210037e | 2166 | |
cfea354b BP |
2167 | if (iface_is_synthetic(iface)) { |
2168 | return; | |
2169 | } | |
2170 | ||
15c9fbd8 AW |
2171 | if (iface->change_seq == netdev_get_change_seq(iface->netdev) |
2172 | && !status_txn_try_again) { | |
6a5f9a8f AW |
2173 | return; |
2174 | } | |
2175 | ||
2176 | iface->change_seq = netdev_get_change_seq(iface->netdev); | |
2177 | ||
79f1cbe9 | 2178 | smap_init(&smap); |
ea763e0e | 2179 | |
275707c3 | 2180 | if (!netdev_get_status(iface->netdev, &smap)) { |
a699f614 | 2181 | ovsrec_interface_set_status(iface->cfg, &smap); |
ea763e0e | 2182 | } else { |
a699f614 | 2183 | ovsrec_interface_set_status(iface->cfg, NULL); |
ea763e0e EJ |
2184 | } |
2185 | ||
79f1cbe9 | 2186 | smap_destroy(&smap); |
e210037e | 2187 | |
6a5f9a8f AW |
2188 | error = netdev_get_flags(iface->netdev, &flags); |
2189 | if (!error) { | |
2190 | const char *state = flags & NETDEV_UP ? "up" : "down"; | |
2191 | ||
2192 | ovsrec_interface_set_admin_state(iface->cfg, state); | |
2193 | } else { | |
2194 | ovsrec_interface_set_admin_state(iface->cfg, NULL); | |
2195 | } | |
2196 | ||
2197 | link_state = netdev_get_carrier(iface->netdev) ? "up" : "down"; | |
2198 | ovsrec_interface_set_link_state(iface->cfg, link_state); | |
2199 | ||
2200 | link_resets = netdev_get_carrier_resets(iface->netdev); | |
2201 | ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1); | |
2202 | ||
e210037e | 2203 | error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL); |
d02a5f8e BP |
2204 | bps = !error ? netdev_features_to_bps(current, 0) : 0; |
2205 | if (bps) { | |
e210037e AE |
2206 | ovsrec_interface_set_duplex(iface->cfg, |
2207 | netdev_features_is_full_duplex(current) | |
2208 | ? "full" : "half"); | |
e210037e | 2209 | ovsrec_interface_set_link_speed(iface->cfg, &bps, 1); |
d0db8de2 | 2210 | } else { |
e210037e AE |
2211 | ovsrec_interface_set_duplex(iface->cfg, NULL); |
2212 | ovsrec_interface_set_link_speed(iface->cfg, NULL, 0); | |
2213 | } | |
2214 | ||
e210037e | 2215 | error = netdev_get_mtu(iface->netdev, &mtu); |
9b020780 | 2216 | if (!error) { |
e210037e AE |
2217 | mtu_64 = mtu; |
2218 | ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1); | |
8d6db33e | 2219 | } else { |
e210037e AE |
2220 | ovsrec_interface_set_mtu(iface->cfg, NULL, 0); |
2221 | } | |
df867eda | 2222 | |
74ff3298 | 2223 | error = netdev_get_etheraddr(iface->netdev, &mac); |
df867eda | 2224 | if (!error) { |
b0d390e5 | 2225 | char mac_string[ETH_ADDR_STRLEN + 1]; |
df867eda | 2226 | |
b0d390e5 BP |
2227 | snprintf(mac_string, sizeof mac_string, |
2228 | ETH_ADDR_FMT, ETH_ADDR_ARGS(mac)); | |
df867eda JP |
2229 | ovsrec_interface_set_mac_in_use(iface->cfg, mac_string); |
2230 | } else { | |
2231 | ovsrec_interface_set_mac_in_use(iface->cfg, NULL); | |
2232 | } | |
ea401d9a NM |
2233 | |
2234 | /* The netdev may return a negative number (such as -EOPNOTSUPP) | |
2235 | * if there is no valid ifindex number. */ | |
2236 | ifindex64 = netdev_get_ifindex(iface->netdev); | |
2237 | if (ifindex64 < 0) { | |
2238 | ifindex64 = 0; | |
2239 | } | |
2240 | ovsrec_interface_set_ifindex(iface->cfg, &ifindex64, 1); | |
ea83a2fc EJ |
2241 | } |
2242 | ||
6a5f9a8f AW |
2243 | static void |
2244 | iface_refresh_ofproto_status(struct iface *iface) | |
2245 | { | |
8f5514fe | 2246 | int current; |
6a5f9a8f AW |
2247 | |
2248 | if (iface_is_synthetic(iface)) { | |
2249 | return; | |
2250 | } | |
2251 | ||
2252 | current = ofproto_port_is_lacp_current(iface->port->bridge->ofproto, | |
2253 | iface->ofp_port); | |
2254 | if (current >= 0) { | |
2255 | bool bl = current; | |
2256 | ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1); | |
2257 | } else { | |
2258 | ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0); | |
2259 | } | |
2260 | ||
8f5514fe | 2261 | if (ofproto_port_cfm_status_changed(iface->port->bridge->ofproto, |
15c9fbd8 AW |
2262 | iface->ofp_port) |
2263 | || status_txn_try_again) { | |
8f5514fe AW |
2264 | iface_refresh_cfm_stats(iface); |
2265 | } | |
6a5f9a8f | 2266 | |
8f5514fe | 2267 | if (ofproto_port_bfd_status_changed(iface->port->bridge->ofproto, |
15c9fbd8 AW |
2268 | iface->ofp_port) |
2269 | || status_txn_try_again) { | |
8f5514fe AW |
2270 | struct smap smap; |
2271 | ||
2272 | smap_init(&smap); | |
2273 | ofproto_port_get_bfd_status(iface->port->bridge->ofproto, | |
2274 | iface->ofp_port, &smap); | |
6a5f9a8f | 2275 | ovsrec_interface_set_bfd_status(iface->cfg, &smap); |
8f5514fe | 2276 | smap_destroy(&smap); |
6a5f9a8f | 2277 | } |
6a5f9a8f AW |
2278 | } |
2279 | ||
353079d0 EJ |
2280 | /* Writes 'iface''s CFM statistics to the database. 'iface' must not be |
2281 | * synthetic. */ | |
8f3fe844 | 2282 | static void |
b31bcf60 EJ |
2283 | iface_refresh_cfm_stats(struct iface *iface) |
2284 | { | |
93b8df38 | 2285 | const struct ovsrec_interface *cfg = iface->cfg; |
685acfd9 | 2286 | struct cfm_status status; |
88bf179a | 2287 | int error; |
9a9e3786 | 2288 | |
88bf179a AW |
2289 | error = ofproto_port_get_cfm_status(iface->port->bridge->ofproto, |
2290 | iface->ofp_port, &status); | |
8f5514fe | 2291 | if (error > 0) { |
9a9e3786 BP |
2292 | ovsrec_interface_set_cfm_fault(cfg, NULL, 0); |
2293 | ovsrec_interface_set_cfm_fault_status(cfg, NULL, 0); | |
2294 | ovsrec_interface_set_cfm_remote_opstate(cfg, NULL); | |
76c4290d | 2295 | ovsrec_interface_set_cfm_flap_count(cfg, NULL, 0); |
9a9e3786 BP |
2296 | ovsrec_interface_set_cfm_health(cfg, NULL, 0); |
2297 | ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0); | |
2298 | } else { | |
b9380396 | 2299 | const char *reasons[CFM_FAULT_N_REASONS]; |
9a9e3786 | 2300 | int64_t cfm_health = status.health; |
76c4290d | 2301 | int64_t cfm_flap_count = status.flap_count; |
9a9e3786 | 2302 | bool faulted = status.faults != 0; |
b9380396 EJ |
2303 | size_t i, j; |
2304 | ||
9a9e3786 BP |
2305 | ovsrec_interface_set_cfm_fault(cfg, &faulted, 1); |
2306 | ||
b9380396 EJ |
2307 | j = 0; |
2308 | for (i = 0; i < CFM_FAULT_N_REASONS; i++) { | |
2309 | int reason = 1 << i; | |
9a9e3786 | 2310 | if (status.faults & reason) { |
b9380396 EJ |
2311 | reasons[j++] = cfm_fault_reason_to_str(reason); |
2312 | } | |
2313 | } | |
47058293 | 2314 | ovsrec_interface_set_cfm_fault_status(cfg, reasons, j); |
1c0333b6 | 2315 | |
76c4290d AW |
2316 | ovsrec_interface_set_cfm_flap_count(cfg, &cfm_flap_count, 1); |
2317 | ||
18637fdc BP |
2318 | if (status.remote_opstate >= 0) { |
2319 | const char *remote_opstate = status.remote_opstate ? "up" : "down"; | |
2320 | ovsrec_interface_set_cfm_remote_opstate(cfg, remote_opstate); | |
2321 | } else { | |
2322 | ovsrec_interface_set_cfm_remote_opstate(cfg, NULL); | |
2323 | } | |
2324 | ||
9a9e3786 BP |
2325 | ovsrec_interface_set_cfm_remote_mpids(cfg, |
2326 | (const int64_t *)status.rmps, | |
2327 | status.n_rmps); | |
4cd9ab26 BP |
2328 | if (cfm_health >= 0) { |
2329 | ovsrec_interface_set_cfm_health(cfg, &cfm_health, 1); | |
2330 | } else { | |
2331 | ovsrec_interface_set_cfm_health(cfg, NULL, 0); | |
2332 | } | |
13b1b2ae EJ |
2333 | |
2334 | free(status.rmps); | |
3967a833 | 2335 | } |
b31bcf60 EJ |
2336 | } |
2337 | ||
018f1525 BP |
2338 | static void |
2339 | iface_refresh_stats(struct iface *iface) | |
2340 | { | |
98dbe2dd BP |
2341 | #define IFACE_STATS \ |
2342 | IFACE_STAT(rx_packets, "rx_packets") \ | |
2343 | IFACE_STAT(tx_packets, "tx_packets") \ | |
2344 | IFACE_STAT(rx_bytes, "rx_bytes") \ | |
2345 | IFACE_STAT(tx_bytes, "tx_bytes") \ | |
2346 | IFACE_STAT(rx_dropped, "rx_dropped") \ | |
2347 | IFACE_STAT(tx_dropped, "tx_dropped") \ | |
2348 | IFACE_STAT(rx_errors, "rx_errors") \ | |
2349 | IFACE_STAT(tx_errors, "tx_errors") \ | |
2350 | IFACE_STAT(rx_frame_errors, "rx_frame_err") \ | |
2351 | IFACE_STAT(rx_over_errors, "rx_over_err") \ | |
2352 | IFACE_STAT(rx_crc_errors, "rx_crc_err") \ | |
2353 | IFACE_STAT(collisions, "collisions") | |
2354 | ||
c2553db9 BP |
2355 | #define IFACE_STAT(MEMBER, NAME) + 1 |
2356 | enum { N_IFACE_STATS = IFACE_STATS }; | |
98dbe2dd | 2357 | #undef IFACE_STAT |
c2553db9 | 2358 | int64_t values[N_IFACE_STATS]; |
47058293 | 2359 | const char *keys[N_IFACE_STATS]; |
c2553db9 | 2360 | int n; |
018f1525 BP |
2361 | |
2362 | struct netdev_stats stats; | |
2363 | ||
cfea354b BP |
2364 | if (iface_is_synthetic(iface)) { |
2365 | return; | |
2366 | } | |
2367 | ||
018f1525 BP |
2368 | /* Intentionally ignore return value, since errors will set 'stats' to |
2369 | * all-1s, and we will deal with that correctly below. */ | |
2370 | netdev_get_stats(iface->netdev, &stats); | |
2371 | ||
c2553db9 BP |
2372 | /* Copy statistics into keys[] and values[]. */ |
2373 | n = 0; | |
2374 | #define IFACE_STAT(MEMBER, NAME) \ | |
2375 | if (stats.MEMBER != UINT64_MAX) { \ | |
2376 | keys[n] = NAME; \ | |
2377 | values[n] = stats.MEMBER; \ | |
2378 | n++; \ | |
2379 | } | |
98dbe2dd BP |
2380 | IFACE_STATS; |
2381 | #undef IFACE_STAT | |
c2553db9 | 2382 | ovs_assert(n <= N_IFACE_STATS); |
018f1525 | 2383 | |
c2553db9 | 2384 | ovsrec_interface_set_statistics(iface->cfg, keys, values, n); |
98dbe2dd | 2385 | #undef IFACE_STATS |
018f1525 BP |
2386 | } |
2387 | ||
b5cbbcf6 AZ |
2388 | static void |
2389 | br_refresh_datapath_info(struct bridge *br) | |
2390 | { | |
2391 | const char *version; | |
2392 | ||
2393 | version = (br->ofproto && br->ofproto->ofproto_class->get_datapath_version | |
2394 | ? br->ofproto->ofproto_class->get_datapath_version(br->ofproto) | |
2395 | : NULL); | |
2396 | ||
2397 | ovsrec_bridge_set_datapath_version(br->cfg, | |
2398 | version ? version : "<unknown>"); | |
2399 | } | |
2400 | ||
21f7563c JP |
2401 | static void |
2402 | br_refresh_stp_status(struct bridge *br) | |
2403 | { | |
a699f614 | 2404 | struct smap smap = SMAP_INITIALIZER(&smap); |
21f7563c JP |
2405 | struct ofproto *ofproto = br->ofproto; |
2406 | struct ofproto_stp_status status; | |
21f7563c JP |
2407 | |
2408 | if (ofproto_get_stp_status(ofproto, &status)) { | |
2409 | return; | |
2410 | } | |
2411 | ||
2412 | if (!status.enabled) { | |
a699f614 | 2413 | ovsrec_bridge_set_status(br->cfg, NULL); |
21f7563c JP |
2414 | return; |
2415 | } | |
2416 | ||
a699f614 EJ |
2417 | smap_add_format(&smap, "stp_bridge_id", STP_ID_FMT, |
2418 | STP_ID_ARGS(status.bridge_id)); | |
2419 | smap_add_format(&smap, "stp_designated_root", STP_ID_FMT, | |
2420 | STP_ID_ARGS(status.designated_root)); | |
2421 | smap_add_format(&smap, "stp_root_path_cost", "%d", status.root_path_cost); | |
21f7563c | 2422 | |
a699f614 EJ |
2423 | ovsrec_bridge_set_status(br->cfg, &smap); |
2424 | smap_destroy(&smap); | |
21f7563c JP |
2425 | } |
2426 | ||
2427 | static void | |
2428 | port_refresh_stp_status(struct port *port) | |
2429 | { | |
2430 | struct ofproto *ofproto = port->bridge->ofproto; | |
2431 | struct iface *iface; | |
2432 | struct ofproto_port_stp_status status; | |
a699f614 | 2433 | struct smap smap; |
21f7563c | 2434 | |
06b592bc EJ |
2435 | if (port_is_synthetic(port)) { |
2436 | return; | |
2437 | } | |
2438 | ||
21f7563c JP |
2439 | /* STP doesn't currently support bonds. */ |
2440 | if (!list_is_singleton(&port->ifaces)) { | |
a699f614 | 2441 | ovsrec_port_set_status(port->cfg, NULL); |
21f7563c JP |
2442 | return; |
2443 | } | |
2444 | ||
2445 | iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem); | |
21f7563c JP |
2446 | if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) { |
2447 | return; | |
2448 | } | |
2449 | ||
2450 | if (!status.enabled) { | |
a699f614 | 2451 | ovsrec_port_set_status(port->cfg, NULL); |
21f7563c JP |
2452 | return; |
2453 | } | |
2454 | ||
80740385 | 2455 | /* Set Status column. */ |
a699f614 EJ |
2456 | smap_init(&smap); |
2457 | smap_add_format(&smap, "stp_port_id", STP_PORT_ID_FMT, status.port_id); | |
2458 | smap_add(&smap, "stp_state", stp_state_name(status.state)); | |
2459 | smap_add_format(&smap, "stp_sec_in_state", "%u", status.sec_in_state); | |
2460 | smap_add(&smap, "stp_role", stp_role_name(status.role)); | |
2461 | ovsrec_port_set_status(port->cfg, &smap); | |
2462 | smap_destroy(&smap); | |
fd28ce3a JS |
2463 | } |
2464 | ||
2465 | static void | |
2466 | port_refresh_stp_stats(struct port *port) | |
2467 | { | |
2468 | struct ofproto *ofproto = port->bridge->ofproto; | |
2469 | struct iface *iface; | |
2470 | struct ofproto_port_stp_stats stats; | |
47058293 | 2471 | const char *keys[3]; |
fd28ce3a JS |
2472 | int64_t int_values[3]; |
2473 | ||
2474 | if (port_is_synthetic(port)) { | |
2475 | return; | |
2476 | } | |
2477 | ||
2478 | /* STP doesn't currently support bonds. */ | |
2479 | if (!list_is_singleton(&port->ifaces)) { | |
2480 | return; | |
2481 | } | |
2482 | ||
2483 | iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem); | |
2484 | if (ofproto_port_get_stp_stats(ofproto, iface->ofp_port, &stats)) { | |
2485 | return; | |
2486 | } | |
2487 | ||
2488 | if (!stats.enabled) { | |
2489 | ovsrec_port_set_statistics(port->cfg, NULL, NULL, 0); | |
2490 | return; | |
2491 | } | |
80740385 JP |
2492 | |
2493 | /* Set Statistics column. */ | |
2494 | keys[0] = "stp_tx_count"; | |
fd28ce3a | 2495 | int_values[0] = stats.tx_count; |
80740385 | 2496 | keys[1] = "stp_rx_count"; |
fd28ce3a | 2497 | int_values[1] = stats.rx_count; |
80740385 | 2498 | keys[2] = "stp_error_count"; |
fd28ce3a | 2499 | int_values[2] = stats.error_count; |
80740385 JP |
2500 | |
2501 | ovsrec_port_set_statistics(port->cfg, keys, int_values, | |
2502 | ARRAY_SIZE(int_values)); | |
21f7563c JP |
2503 | } |
2504 | ||
9efd308e DV |
2505 | static void |
2506 | br_refresh_rstp_status(struct bridge *br) | |
2507 | { | |
2508 | struct smap smap = SMAP_INITIALIZER(&smap); | |
2509 | struct ofproto *ofproto = br->ofproto; | |
2510 | struct ofproto_rstp_status status; | |
2511 | ||
2512 | if (ofproto_get_rstp_status(ofproto, &status)) { | |
2513 | return; | |
2514 | } | |
2515 | if (!status.enabled) { | |
2516 | ovsrec_bridge_set_rstp_status(br->cfg, NULL); | |
2517 | return; | |
2518 | } | |
2519 | smap_add_format(&smap, "rstp_bridge_id", RSTP_ID_FMT, | |
2520 | RSTP_ID_ARGS(status.bridge_id)); | |
9c64e6b8 | 2521 | smap_add_format(&smap, "rstp_root_path_cost", "%"PRIu32, |
9efd308e DV |
2522 | status.root_path_cost); |
2523 | smap_add_format(&smap, "rstp_root_id", RSTP_ID_FMT, | |
2524 | RSTP_ID_ARGS(status.root_id)); | |
2525 | smap_add_format(&smap, "rstp_designated_id", RSTP_ID_FMT, | |
2526 | RSTP_ID_ARGS(status.designated_id)); | |
2527 | smap_add_format(&smap, "rstp_designated_port_id", RSTP_PORT_ID_FMT, | |
2528 | status.designated_port_id); | |
2529 | smap_add_format(&smap, "rstp_bridge_port_id", RSTP_PORT_ID_FMT, | |
2530 | status.bridge_port_id); | |
2531 | ovsrec_bridge_set_rstp_status(br->cfg, &smap); | |
2532 | smap_destroy(&smap); | |
2533 | } | |
2534 | ||
2535 | static void | |
2536 | port_refresh_rstp_status(struct port *port) | |
2537 | { | |
2538 | struct ofproto *ofproto = port->bridge->ofproto; | |
2539 | struct iface *iface; | |
2540 | struct ofproto_port_rstp_status status; | |
2550f026 BP |
2541 | const char *keys[4]; |
2542 | int64_t int_values[4]; | |
9efd308e DV |
2543 | struct smap smap; |
2544 | ||
2545 | if (port_is_synthetic(port)) { | |
2546 | return; | |
2547 | } | |
2548 | ||
2549 | /* RSTP doesn't currently support bonds. */ | |
2550 | if (!list_is_singleton(&port->ifaces)) { | |
2551 | ovsrec_port_set_rstp_status(port->cfg, NULL); | |
2552 | return; | |
2553 | } | |
2554 | ||
2555 | iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem); | |
2556 | if (ofproto_port_get_rstp_status(ofproto, iface->ofp_port, &status)) { | |
2557 | return; | |
2558 | } | |
2559 | ||
2560 | if (!status.enabled) { | |
2561 | ovsrec_port_set_rstp_status(port->cfg, NULL); | |
2562 | ovsrec_port_set_rstp_statistics(port->cfg, NULL, NULL, 0); | |
2563 | return; | |
2564 | } | |
2565 | /* Set Status column. */ | |
2566 | smap_init(&smap); | |
2567 | ||
2568 | smap_add_format(&smap, "rstp_port_id", RSTP_PORT_ID_FMT, | |
2569 | status.port_id); | |
2570 | smap_add_format(&smap, "rstp_port_role", "%s", | |
2571 | rstp_port_role_name(status.role)); | |
2572 | smap_add_format(&smap, "rstp_port_state", "%s", | |
2573 | rstp_state_name(status.state)); | |
9c64e6b8 JR |
2574 | smap_add_format(&smap, "rstp_designated_bridge_id", RSTP_ID_FMT, |
2575 | RSTP_ID_ARGS(status.designated_bridge_id)); | |
2576 | smap_add_format(&smap, "rstp_designated_port_id", RSTP_PORT_ID_FMT, | |
2577 | status.designated_port_id); | |
2578 | smap_add_format(&smap, "rstp_designated_path_cost", "%"PRIu32, | |
2579 | status.designated_path_cost); | |
9efd308e DV |
2580 | |
2581 | ovsrec_port_set_rstp_status(port->cfg, &smap); | |
2582 | smap_destroy(&smap); | |
2583 | ||
2584 | /* Set Statistics column. */ | |
2585 | keys[0] = "rstp_tx_count"; | |
2586 | int_values[0] = status.tx_count; | |
2587 | keys[1] = "rstp_rx_count"; | |
2588 | int_values[1] = status.rx_count; | |
2589 | keys[2] = "rstp_uptime"; | |
2590 | int_values[2] = status.uptime; | |
2550f026 BP |
2591 | keys[3] = "rstp_error_count"; |
2592 | int_values[3] = status.error_count; | |
9efd308e DV |
2593 | ovsrec_port_set_rstp_statistics(port->cfg, keys, int_values, |
2594 | ARRAY_SIZE(int_values)); | |
2595 | } | |
2596 | ||
3e5aeeb5 AZ |
2597 | static void |
2598 | port_refresh_bond_status(struct port *port, bool force_update) | |
2599 | { | |
74ff3298 | 2600 | struct eth_addr mac; |
3e5aeeb5 AZ |
2601 | |
2602 | /* Return if port is not a bond */ | |
2603 | if (list_is_singleton(&port->ifaces)) { | |
2604 | return; | |
2605 | } | |
2606 | ||
74ff3298 | 2607 | if (bond_get_changed_active_slave(port->name, &mac, force_update)) { |
3e5aeeb5 AZ |
2608 | struct ds mac_s; |
2609 | ||
2610 | ds_init(&mac_s); | |
2611 | ds_put_format(&mac_s, ETH_ADDR_FMT, ETH_ADDR_ARGS(mac)); | |
2612 | ovsrec_port_set_bond_active_slave(port->cfg, ds_cstr(&mac_s)); | |
2613 | ds_destroy(&mac_s); | |
2614 | } | |
2615 | } | |
2616 | ||
3fe80505 BP |
2617 | static bool |
2618 | enable_system_stats(const struct ovsrec_open_vswitch *cfg) | |
2619 | { | |
a699f614 | 2620 | return smap_get_bool(&cfg->other_config, "enable-statistics", false); |
3fe80505 BP |
2621 | } |
2622 | ||
ce887677 | 2623 | static void |
35a22d8c | 2624 | reconfigure_system_stats(const struct ovsrec_open_vswitch *cfg) |
ce887677 | 2625 | { |
35a22d8c | 2626 | bool enable = enable_system_stats(cfg); |
ce887677 | 2627 | |
35a22d8c BP |
2628 | system_stats_enable(enable); |
2629 | if (!enable) { | |
2630 | ovsrec_open_vswitch_set_statistics(cfg, NULL); | |
3fe80505 | 2631 | } |
35a22d8c BP |
2632 | } |
2633 | ||
2634 | static void | |
2635 | run_system_stats(void) | |
2636 | { | |
2637 | const struct ovsrec_open_vswitch *cfg = ovsrec_open_vswitch_first(idl); | |
2638 | struct smap *stats; | |
2639 | ||
2640 | stats = system_stats_run(); | |
2641 | if (stats && cfg) { | |
2642 | struct ovsdb_idl_txn *txn; | |
2643 | struct ovsdb_datum datum; | |
2644 | ||
2645 | txn = ovsdb_idl_txn_create(idl); | |
2646 | ovsdb_datum_from_smap(&datum, stats); | |
2647 | ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics, | |
2648 | &datum); | |
2649 | ovsdb_idl_txn_commit(txn); | |
2650 | ovsdb_idl_txn_destroy(txn); | |
ce887677 | 2651 | |
35a22d8c BP |
2652 | free(stats); |
2653 | } | |
ce887677 BP |
2654 | } |
2655 | ||
61c75840 | 2656 | static const char * |
f4f1ea7e | 2657 | ofp12_controller_role_to_str(enum ofp12_controller_role role) |
bffc0589 AE |
2658 | { |
2659 | switch (role) { | |
f4f1ea7e | 2660 | case OFPCR12_ROLE_EQUAL: |
bffc0589 | 2661 | return "other"; |
f4f1ea7e | 2662 | case OFPCR12_ROLE_MASTER: |
bffc0589 | 2663 | return "master"; |
f4f1ea7e | 2664 | case OFPCR12_ROLE_SLAVE: |
bffc0589 | 2665 | return "slave"; |
f4f1ea7e | 2666 | case OFPCR12_ROLE_NOCHANGE: |
bffc0589 AE |
2667 | default: |
2668 | return "*** INVALID ROLE ***"; | |
2669 | } | |
2670 | } | |
2671 | ||
2672 | static void | |
5d279086 | 2673 | refresh_controller_status(void) |
bffc0589 | 2674 | { |
5d279086 | 2675 | struct bridge *br; |
bffc0589 AE |
2676 | struct shash info; |
2677 | const struct ovsrec_controller *cfg; | |
2678 | ||
5d279086 AE |
2679 | shash_init(&info); |
2680 | ||
2681 | /* Accumulate status for controllers on all bridges. */ | |
2682 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
2683 | ofproto_get_ofproto_controller_info(br->ofproto, &info); | |
2684 | } | |
bffc0589 | 2685 | |
5d279086 | 2686 | /* Update each controller in the database with current status. */ |
bffc0589 | 2687 | OVSREC_CONTROLLER_FOR_EACH(cfg, idl) { |
eb9b8307 AE |
2688 | struct ofproto_controller_info *cinfo = |
2689 | shash_find_data(&info, cfg->target); | |
2690 | ||
2691 | if (cinfo) { | |
2692 | ovsrec_controller_set_is_connected(cfg, cinfo->is_connected); | |
f4f1ea7e BP |
2693 | ovsrec_controller_set_role(cfg, ofp12_controller_role_to_str( |
2694 | cinfo->role)); | |
f5ad2e5f | 2695 | ovsrec_controller_set_status(cfg, &cinfo->pairs); |
eb9b8307 AE |
2696 | } else { |
2697 | ovsrec_controller_set_is_connected(cfg, false); | |
2698 | ovsrec_controller_set_role(cfg, NULL); | |
a699f614 | 2699 | ovsrec_controller_set_status(cfg, NULL); |
eb9b8307 | 2700 | } |
bffc0589 AE |
2701 | } |
2702 | ||
2703 | ofproto_free_ofproto_controller_info(&info); | |
2704 | } | |
b40dcae7 | 2705 | \f |
9c537baf AW |
2706 | /* Update interface and mirror statistics if necessary. */ |
2707 | static void | |
2708 | run_stats_update(void) | |
2709 | { | |
9c537baf AW |
2710 | const struct ovsrec_open_vswitch *cfg = ovsrec_open_vswitch_first(idl); |
2711 | int stats_interval; | |
2712 | ||
2713 | if (!cfg) { | |
2714 | return; | |
2715 | } | |
2716 | ||
2717 | /* Statistics update interval should always be greater than or equal to | |
2718 | * 5000 ms. */ | |
2719 | stats_interval = MAX(smap_get_int(&cfg->other_config, | |
2720 | "stats-update-interval", | |
2721 | 5000), 5000); | |
2722 | if (stats_timer_interval != stats_interval) { | |
2723 | stats_timer_interval = stats_interval; | |
2724 | stats_timer = LLONG_MIN; | |
2725 | } | |
2726 | ||
2727 | if (time_msec() >= stats_timer) { | |
2728 | enum ovsdb_idl_txn_status status; | |
2729 | ||
2730 | /* Rate limit the update. Do not start a new update if the | |
2731 | * previous one is not done. */ | |
2732 | if (!stats_txn) { | |
2733 | struct bridge *br; | |
2734 | ||
2735 | stats_txn = ovsdb_idl_txn_create(idl); | |
2736 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
2737 | struct port *port; | |
2738 | struct mirror *m; | |
2739 | ||
2740 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { | |
2741 | struct iface *iface; | |
2742 | ||
2743 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { | |
2744 | iface_refresh_stats(iface); | |
2745 | } | |
2746 | port_refresh_stp_stats(port); | |
2747 | } | |
2748 | HMAP_FOR_EACH (m, hmap_node, &br->mirrors) { | |
2749 | mirror_refresh_stats(m); | |
2750 | } | |
2751 | } | |
2752 | refresh_controller_status(); | |
2753 | } | |
2754 | ||
2755 | status = ovsdb_idl_txn_commit(stats_txn); | |
2756 | if (status != TXN_INCOMPLETE) { | |
2757 | stats_timer = time_msec() + stats_timer_interval; | |
2758 | ovsdb_idl_txn_destroy(stats_txn); | |
2759 | stats_txn = NULL; | |
2760 | } | |
2761 | } | |
2762 | } | |
2763 | ||
131d04dc AW |
2764 | static void |
2765 | stats_update_wait(void) | |
2766 | { | |
2767 | /* If the 'stats_txn' is non-null (transaction incomplete), waits for the | |
2768 | * transaction to complete. Otherwise, waits for the 'stats_timer'. */ | |
2769 | if (stats_txn) { | |
2770 | ovsdb_idl_txn_wait(stats_txn); | |
2771 | } else { | |
2772 | poll_timer_wait_until(stats_timer); | |
2773 | } | |
2774 | } | |
2775 | ||
9c537baf AW |
2776 | /* Update bridge/port/interface status if necessary. */ |
2777 | static void | |
2778 | run_status_update(void) | |
2779 | { | |
ba8ec115 JS |
2780 | if (!status_txn) { |
2781 | uint64_t seq; | |
9c537baf AW |
2782 | |
2783 | /* Rate limit the update. Do not start a new update if the | |
2784 | * previous one is not done. */ | |
ba8ec115 JS |
2785 | seq = seq_read(connectivity_seq_get()); |
2786 | if (seq != connectivity_seqno || status_txn_try_again) { | |
9c537baf AW |
2787 | struct bridge *br; |
2788 | ||
2789 | connectivity_seqno = seq; | |
2790 | status_txn = ovsdb_idl_txn_create(idl); | |
2791 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
2792 | struct port *port; | |
2793 | ||
2794 | br_refresh_stp_status(br); | |
2795 | br_refresh_rstp_status(br); | |
b5cbbcf6 | 2796 | br_refresh_datapath_info(br); |
9c537baf AW |
2797 | HMAP_FOR_EACH (port, hmap_node, &br->ports) { |
2798 | struct iface *iface; | |
2799 | ||
2800 | port_refresh_stp_status(port); | |
2801 | port_refresh_rstp_status(port); | |
3e5aeeb5 | 2802 | port_refresh_bond_status(port, status_txn_try_again); |
9c537baf AW |
2803 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { |
2804 | iface_refresh_netdev_status(iface); | |
2805 | iface_refresh_ofproto_status(iface); | |
2806 | } | |
2807 | } | |
2808 | } | |
2809 | } | |
ba8ec115 JS |
2810 | } |
2811 | ||
2812 | /* Commit the transaction and get the status. If the transaction finishes, | |
2813 | * then destroy the transaction. Otherwise, keep it so that we can check | |
2814 | * progress the next time that this function is called. */ | |
2815 | if (status_txn) { | |
2816 | enum ovsdb_idl_txn_status status; | |
9c537baf AW |
2817 | |
2818 | status = ovsdb_idl_txn_commit(status_txn); | |
2819 | if (status != TXN_INCOMPLETE) { | |
2820 | ovsdb_idl_txn_destroy(status_txn); | |
2821 | status_txn = NULL; | |
2822 | ||
2823 | /* Sets the 'status_txn_try_again' if the transaction fails. */ | |
2824 | if (status == TXN_SUCCESS || status == TXN_UNCHANGED) { | |
2825 | status_txn_try_again = false; | |
2826 | } else { | |
2827 | status_txn_try_again = true; | |
2828 | } | |
2829 | } | |
2830 | } | |
99eef98b DF |
2831 | |
2832 | /* Refresh AA port status if necessary. */ | |
2833 | if (time_msec() >= aa_refresh_timer) { | |
2834 | struct bridge *br; | |
2835 | ||
2836 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
2837 | if (bridge_aa_need_refresh(br)) { | |
2838 | struct ovsdb_idl_txn *txn; | |
2839 | ||
2840 | txn = ovsdb_idl_txn_create(idl); | |
2841 | bridge_aa_refresh_queued(br); | |
2842 | ovsdb_idl_txn_commit(txn); | |
2843 | ovsdb_idl_txn_destroy(txn); | |
2844 | } | |
2845 | } | |
2846 | ||
2847 | aa_refresh_timer = time_msec() + AA_REFRESH_INTERVAL; | |
2848 | } | |
9c537baf AW |
2849 | } |
2850 | ||
2851 | static void | |
2852 | status_update_wait(void) | |
2853 | { | |
2854 | /* If the 'status_txn' is non-null (transaction incomplete), waits for the | |
2855 | * transaction to complete. If the status update to database needs to be | |
2856 | * run again (transaction fails), registers a timeout in | |
2857 | * 'STATUS_CHECK_AGAIN_MSEC'. Otherwise, waits on the global connectivity | |
2858 | * sequence number. */ | |
2859 | if (status_txn) { | |
2860 | ovsdb_idl_txn_wait(status_txn); | |
2861 | } else if (status_txn_try_again) { | |
2862 | poll_timer_wait_until(time_msec() + STATUS_CHECK_AGAIN_MSEC); | |
2863 | } else { | |
2864 | seq_wait(connectivity_seq_get(), connectivity_seqno); | |
2865 | } | |
2866 | } | |
2867 | ||
aeed7879 BP |
2868 | static void |
2869 | bridge_run__(void) | |
2870 | { | |
2871 | struct bridge *br; | |
2872 | struct sset types; | |
2873 | const char *type; | |
2874 | ||
2875 | /* Let each datapath type do the work that it needs to do. */ | |
2876 | sset_init(&types); | |
2877 | ofproto_enumerate_types(&types); | |
2878 | SSET_FOR_EACH (type, &types) { | |
2879 | ofproto_type_run(type); | |
2880 | } | |
2881 | sset_destroy(&types); | |
2882 | ||
2883 | /* Let each bridge do the work that it needs to do. */ | |
2884 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
2885 | ofproto_run(br->ofproto); | |
2886 | } | |
2887 | } | |
2888 | ||
c5187f17 | 2889 | void |
064af421 BP |
2890 | bridge_run(void) |
2891 | { | |
8c0f519f | 2892 | static struct ovsrec_open_vswitch null_cfg; |
d54ff998 BP |
2893 | const struct ovsrec_open_vswitch *cfg; |
2894 | ||
52a90c29 | 2895 | bool vlan_splinters_changed; |
064af421 | 2896 | |
8c0f519f | 2897 | ovsrec_open_vswitch_init(&null_cfg); |
edce886c | 2898 | |
2a73b1d7 | 2899 | ovsdb_idl_run(idl); |
06b6d651 | 2900 | |
e21c6643 TLSC |
2901 | if_notifier_run(); |
2902 | ||
2a73b1d7 BP |
2903 | if (ovsdb_idl_is_lock_contended(idl)) { |
2904 | static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); | |
2905 | struct bridge *br, *next_br; | |
06b6d651 | 2906 | |
2a73b1d7 BP |
2907 | VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, " |
2908 | "disabling this process (pid %ld) until it goes away", | |
2909 | (long int) getpid()); | |
bae7208e | 2910 | |
2a73b1d7 BP |
2911 | HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) { |
2912 | bridge_destroy(br); | |
06b6d651 | 2913 | } |
2a73b1d7 BP |
2914 | /* Since we will not be running system_stats_run() in this process |
2915 | * with the current situation of multiple ovs-vswitchd daemons, | |
2916 | * disable system stats collection. */ | |
2917 | system_stats_enable(false); | |
2918 | return; | |
b3cceba0 AW |
2919 | } else if (!ovsdb_idl_has_lock(idl) |
2920 | || !ovsdb_idl_has_ever_connected(idl)) { | |
2921 | /* Returns if not holding the lock or not done retrieving db | |
2922 | * contents. */ | |
2a73b1d7 | 2923 | return; |
06b6d651 BP |
2924 | } |
2925 | cfg = ovsrec_open_vswitch_first(idl); | |
2926 | ||
b0408fca JP |
2927 | /* Initialize the ofproto library. This only needs to run once, but |
2928 | * it must be done after the configuration is set. If the | |
2929 | * initialization has already occurred, bridge_init_ofproto() | |
2930 | * returns immediately. */ | |
2931 | bridge_init_ofproto(cfg); | |
2932 | ||
40358701 GS |
2933 | /* Once the value of flow-restore-wait is false, we no longer should |
2934 | * check its value from the database. */ | |
2935 | if (cfg && ofproto_get_flow_restore_wait()) { | |
2936 | ofproto_set_flow_restore_wait(smap_get_bool(&cfg->other_config, | |
2937 | "flow-restore-wait", false)); | |
2938 | } | |
2939 | ||
aeed7879 | 2940 | bridge_run__(); |
c5187f17 | 2941 | |
d6da96ce BP |
2942 | /* Re-configure SSL. We do this on every trip through the main loop, |
2943 | * instead of just when the database changes, because the contents of the | |
2944 | * key and certificate files can change without the database changing. | |
2945 | * | |
2946 | * We do this before bridge_reconfigure() because that function might | |
2947 | * initiate SSL connections and thus requires SSL to be configured. */ | |
2948 | if (cfg && cfg->ssl) { | |
2949 | const struct ovsrec_ssl *ssl = cfg->ssl; | |
2950 | ||
2951 | stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate); | |
2952 | stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert); | |
2953 | } | |
bf8f2167 | 2954 | |
2a73b1d7 BP |
2955 | /* If VLAN splinters are in use, then we need to reconfigure if VLAN |
2956 | * usage has changed. */ | |
2957 | vlan_splinters_changed = false; | |
2958 | if (vlan_splinters_enabled_anywhere) { | |
9c537baf AW |
2959 | struct bridge *br; |
2960 | ||
2a73b1d7 BP |
2961 | HMAP_FOR_EACH (br, node, &all_bridges) { |
2962 | if (ofproto_has_vlan_usage_changed(br->ofproto)) { | |
2963 | vlan_splinters_changed = true; | |
2964 | break; | |
52a90c29 BP |
2965 | } |
2966 | } | |
2967 | } | |
2968 | ||
e21c6643 TLSC |
2969 | if (ovsdb_idl_get_seqno(idl) != idl_seqno || vlan_splinters_changed |
2970 | || ifaces_changed) { | |
2a73b1d7 | 2971 | struct ovsdb_idl_txn *txn; |
ff02e9a5 | 2972 | |
e21c6643 TLSC |
2973 | ifaces_changed = false; |
2974 | ||
2a73b1d7 BP |
2975 | idl_seqno = ovsdb_idl_get_seqno(idl); |
2976 | txn = ovsdb_idl_txn_create(idl); | |
2977 | bridge_reconfigure(cfg ? cfg : &null_cfg); | |
ff02e9a5 | 2978 | |
2a73b1d7 BP |
2979 | if (cfg) { |
2980 | ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg); | |
842733c3 | 2981 | discover_types(cfg); |
064af421 | 2982 | } |
018f1525 | 2983 | |
2a73b1d7 BP |
2984 | /* If we are completing our initial configuration for this run |
2985 | * of ovs-vswitchd, then keep the transaction around to monitor | |
2986 | * it for completion. */ | |
2987 | if (initial_config_done) { | |
15c9fbd8 AW |
2988 | /* Always sets the 'status_txn_try_again' to check again, |
2989 | * in case that this transaction fails. */ | |
2990 | status_txn_try_again = true; | |
2a73b1d7 BP |
2991 | ovsdb_idl_txn_commit(txn); |
2992 | ovsdb_idl_txn_destroy(txn); | |
2993 | } else { | |
2994 | initial_config_done = true; | |
2995 | daemonize_txn = txn; | |
2996 | } | |
bae7208e EJ |
2997 | } |
2998 | ||
63ff04e8 BP |
2999 | if (daemonize_txn) { |
3000 | enum ovsdb_idl_txn_status status = ovsdb_idl_txn_commit(daemonize_txn); | |
3001 | if (status != TXN_INCOMPLETE) { | |
3002 | ovsdb_idl_txn_destroy(daemonize_txn); | |
3003 | daemonize_txn = NULL; | |
3004 | ||
3005 | /* ovs-vswitchd has completed initialization, so allow the | |
3006 | * process that forked us to exit successfully. */ | |
3007 | daemonize_complete(); | |
3008 | ||
888e0cf4 | 3009 | vlog_enable_async(); |
a5fb0e29 | 3010 | |
63ff04e8 BP |
3011 | VLOG_INFO_ONCE("%s (Open vSwitch) %s", program_name, VERSION); |
3012 | } | |
3013 | } | |
3014 | ||
9c537baf AW |
3015 | run_stats_update(); |
3016 | run_status_update(); | |
35a22d8c | 3017 | run_system_stats(); |
064af421 BP |
3018 | } |
3019 | ||
3020 | void | |
3021 | bridge_wait(void) | |
3022 | { | |
11a574a7 JP |
3023 | struct sset types; |
3024 | const char *type; | |
3025 | ||
c5187f17 | 3026 | ovsdb_idl_wait(idl); |
63ff04e8 BP |
3027 | if (daemonize_txn) { |
3028 | ovsdb_idl_txn_wait(daemonize_txn); | |
3029 | } | |
c7e7bb21 | 3030 | |
e21c6643 TLSC |
3031 | if_notifier_wait(); |
3032 | if (ifaces_changed) { | |
3033 | poll_immediate_wake(); | |
3034 | } | |
3035 | ||
11a574a7 JP |
3036 | sset_init(&types); |
3037 | ofproto_enumerate_types(&types); | |
3038 | SSET_FOR_EACH (type, &types) { | |
3039 | ofproto_type_wait(type); | |
3040 | } | |
3041 | sset_destroy(&types); | |
3042 | ||
06b6d651 BP |
3043 | if (!hmap_is_empty(&all_bridges)) { |
3044 | struct bridge *br; | |
6586adf5 | 3045 | |
06b6d651 BP |
3046 | HMAP_FOR_EACH (br, node, &all_bridges) { |
3047 | ofproto_wait(br->ofproto); | |
3048 | } | |
131d04dc | 3049 | stats_update_wait(); |
500ce35e | 3050 | status_update_wait(); |
6586adf5 | 3051 | } |
35a22d8c BP |
3052 | |
3053 | system_stats_wait(); | |
064af421 | 3054 | } |
0d085684 BP |
3055 | |
3056 | /* Adds some memory usage statistics for bridges into 'usage', for use with | |
3057 | * memory_report(). */ | |
3058 | void | |
3059 | bridge_get_memory_usage(struct simap *usage) | |
3060 | { | |
3061 | struct bridge *br; | |
1c030aa5 EJ |
3062 | struct sset types; |
3063 | const char *type; | |
3064 | ||
3065 | sset_init(&types); | |
3066 | ofproto_enumerate_types(&types); | |
3067 | SSET_FOR_EACH (type, &types) { | |
3068 | ofproto_type_get_memory_usage(type, usage); | |
3069 | } | |
3070 | sset_destroy(&types); | |
0d085684 BP |
3071 | |
3072 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
3073 | ofproto_get_memory_usage(br->ofproto, usage); | |
3074 | } | |
3075 | } | |
8c4c1387 | 3076 | \f |
e8fe3026 EJ |
3077 | /* QoS unixctl user interface functions. */ |
3078 | ||
3079 | struct qos_unixctl_show_cbdata { | |
3080 | struct ds *ds; | |
3081 | struct iface *iface; | |
3082 | }; | |
3083 | ||
3084 | static void | |
89454bf4 BP |
3085 | qos_unixctl_show_queue(unsigned int queue_id, |
3086 | const struct smap *details, | |
3087 | struct iface *iface, | |
3088 | struct ds *ds) | |
e8fe3026 | 3089 | { |
e8fe3026 | 3090 | struct netdev_queue_stats stats; |
79f1cbe9 | 3091 | struct smap_node *node; |
e8fe3026 EJ |
3092 | int error; |
3093 | ||
3094 | ds_put_cstr(ds, "\n"); | |
3095 | if (queue_id) { | |
3096 | ds_put_format(ds, "Queue %u:\n", queue_id); | |
3097 | } else { | |
3098 | ds_put_cstr(ds, "Default:\n"); | |
3099 | } | |
3100 | ||
79f1cbe9 EJ |
3101 | SMAP_FOR_EACH (node, details) { |
3102 | ds_put_format(ds, "\t%s: %s\n", node->key, node->value); | |
e8fe3026 EJ |
3103 | } |
3104 | ||
3105 | error = netdev_get_queue_stats(iface->netdev, queue_id, &stats); | |
3106 | if (!error) { | |
3107 | if (stats.tx_packets != UINT64_MAX) { | |
3108 | ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets); | |
3109 | } | |
3110 | ||
3111 | if (stats.tx_bytes != UINT64_MAX) { | |
3112 | ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes); | |
3113 | } | |
3114 | ||
3115 | if (stats.tx_errors != UINT64_MAX) { | |
3116 | ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors); | |
3117 | } | |
3118 | } else { | |
3119 | ds_put_format(ds, "\tFailed to get statistics for queue %u: %s", | |
10a89ef0 | 3120 | queue_id, ovs_strerror(error)); |
e8fe3026 EJ |
3121 | } |
3122 | } | |
3123 | ||
3124 | static void | |
0e15264f BP |
3125 | qos_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED, |
3126 | const char *argv[], void *aux OVS_UNUSED) | |
e8fe3026 EJ |
3127 | { |
3128 | struct ds ds = DS_EMPTY_INITIALIZER; | |
79f1cbe9 | 3129 | struct smap smap = SMAP_INITIALIZER(&smap); |
e8fe3026 EJ |
3130 | struct iface *iface; |
3131 | const char *type; | |
79f1cbe9 | 3132 | struct smap_node *node; |
e8fe3026 | 3133 | |
0e15264f | 3134 | iface = iface_find(argv[1]); |
e8fe3026 | 3135 | if (!iface) { |
bde9f75d | 3136 | unixctl_command_reply_error(conn, "no such interface"); |
e8fe3026 EJ |
3137 | return; |
3138 | } | |
3139 | ||
79f1cbe9 | 3140 | netdev_get_qos(iface->netdev, &type, &smap); |
e8fe3026 EJ |
3141 | |
3142 | if (*type != '\0') { | |
89454bf4 BP |
3143 | struct netdev_queue_dump dump; |
3144 | struct smap details; | |
3145 | unsigned int queue_id; | |
3146 | ||
e8fe3026 EJ |
3147 | ds_put_format(&ds, "QoS: %s %s\n", iface->name, type); |
3148 | ||
79f1cbe9 EJ |
3149 | SMAP_FOR_EACH (node, &smap) { |
3150 | ds_put_format(&ds, "%s: %s\n", node->key, node->value); | |
e8fe3026 EJ |
3151 | } |
3152 | ||
89454bf4 BP |
3153 | smap_init(&details); |
3154 | NETDEV_QUEUE_FOR_EACH (&queue_id, &details, &dump, iface->netdev) { | |
3155 | qos_unixctl_show_queue(queue_id, &details, iface, &ds); | |
e8fe3026 | 3156 | } |
89454bf4 BP |
3157 | smap_destroy(&details); |
3158 | ||
bde9f75d | 3159 | unixctl_command_reply(conn, ds_cstr(&ds)); |
e8fe3026 EJ |
3160 | } else { |
3161 | ds_put_format(&ds, "QoS not configured on %s\n", iface->name); | |
bde9f75d | 3162 | unixctl_command_reply_error(conn, ds_cstr(&ds)); |
e8fe3026 EJ |
3163 | } |
3164 | ||
79f1cbe9 | 3165 | smap_destroy(&smap); |
e8fe3026 EJ |
3166 | ds_destroy(&ds); |
3167 | } | |
3168 | \f | |
064af421 | 3169 | /* Bridge reconfiguration functions. */ |
66da9bef | 3170 | static void |
1a6f1e2a | 3171 | bridge_create(const struct ovsrec_bridge *br_cfg) |
064af421 BP |
3172 | { |
3173 | struct bridge *br; | |
064af421 | 3174 | |
cb22974d | 3175 | ovs_assert(!bridge_lookup(br_cfg->name)); |
ec6fde61 | 3176 | br = xzalloc(sizeof *br); |
064af421 | 3177 | |
1a6f1e2a | 3178 | br->name = xstrdup(br_cfg->name); |
f79e673f | 3179 | br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type)); |
1a6f1e2a | 3180 | br->cfg = br_cfg; |
e3f55cb8 BP |
3181 | |
3182 | /* Derive the default Ethernet address from the bridge's UUID. This should | |
3183 | * be unique and it will be stable between ovs-vswitchd runs. */ | |
74ff3298 JR |
3184 | memcpy(&br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN); |
3185 | eth_addr_mark_random(&br->default_ea); | |
064af421 | 3186 | |
8052fb14 | 3187 | hmap_init(&br->ports); |
d9a8717a | 3188 | hmap_init(&br->ifaces); |
ebea37cc | 3189 | hmap_init(&br->iface_by_name); |
fa066f01 | 3190 | hmap_init(&br->mirrors); |
4a1ee6ae | 3191 | |
99eef98b | 3192 | hmap_init(&br->mappings); |
764072fd | 3193 | hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0)); |
064af421 BP |
3194 | } |
3195 | ||
3196 | static void | |
3197 | bridge_destroy(struct bridge *br) | |
3198 | { | |
3199 | if (br) { | |
fa066f01 BP |
3200 | struct mirror *mirror, *next_mirror; |
3201 | struct port *port, *next_port; | |
064af421 | 3202 | |
fa066f01 | 3203 | HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) { |
8052fb14 | 3204 | port_destroy(port); |
064af421 | 3205 | } |
fa066f01 BP |
3206 | HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) { |
3207 | mirror_destroy(mirror); | |
f76e2dfc | 3208 | } |
bae7208e | 3209 | |
764072fd | 3210 | hmap_remove(&all_bridges, &br->node); |
6d6ab93e | 3211 | ofproto_destroy(br->ofproto); |
d9a8717a | 3212 | hmap_destroy(&br->ifaces); |
8052fb14 | 3213 | hmap_destroy(&br->ports); |
ebea37cc | 3214 | hmap_destroy(&br->iface_by_name); |
fa066f01 | 3215 | hmap_destroy(&br->mirrors); |
99eef98b | 3216 | hmap_destroy(&br->mappings); |
064af421 | 3217 | free(br->name); |
66da9bef | 3218 | free(br->type); |
064af421 BP |
3219 | free(br); |
3220 | } | |
3221 | } | |
3222 | ||
3223 | static struct bridge * | |
3224 | bridge_lookup(const char *name) | |
3225 | { | |
3226 | struct bridge *br; | |
3227 | ||
764072fd | 3228 | HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) { |
064af421 BP |
3229 | if (!strcmp(br->name, name)) { |
3230 | return br; | |
3231 | } | |
3232 | } | |
3233 | return NULL; | |
3234 | } | |
3235 | ||
4f2cad2c JP |
3236 | /* Handle requests for a listing of all flows known by the OpenFlow |
3237 | * stack, including those normally hidden. */ | |
3238 | static void | |
0e15264f BP |
3239 | bridge_unixctl_dump_flows(struct unixctl_conn *conn, int argc OVS_UNUSED, |
3240 | const char *argv[], void *aux OVS_UNUSED) | |
4f2cad2c JP |
3241 | { |
3242 | struct bridge *br; | |
3243 | struct ds results; | |
d295e8e9 | 3244 | |
0e15264f | 3245 | br = bridge_lookup(argv[1]); |
4f2cad2c | 3246 | if (!br) { |
bde9f75d | 3247 | unixctl_command_reply_error(conn, "Unknown bridge"); |
4f2cad2c JP |
3248 | return; |
3249 | } | |
3250 | ||
3251 | ds_init(&results); | |
3252 | ofproto_get_all_flows(br->ofproto, &results); | |
3253 | ||
bde9f75d | 3254 | unixctl_command_reply(conn, ds_cstr(&results)); |
4f2cad2c JP |
3255 | ds_destroy(&results); |
3256 | } | |
3257 | ||
fa05809b BP |
3258 | /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller |
3259 | * connections and reconnect. If BRIDGE is not specified, then all bridges | |
3260 | * drop their controller connections and reconnect. */ | |
3261 | static void | |
0e15264f BP |
3262 | bridge_unixctl_reconnect(struct unixctl_conn *conn, int argc, |
3263 | const char *argv[], void *aux OVS_UNUSED) | |
fa05809b BP |
3264 | { |
3265 | struct bridge *br; | |
0e15264f BP |
3266 | if (argc > 1) { |
3267 | br = bridge_lookup(argv[1]); | |
fa05809b | 3268 | if (!br) { |
bde9f75d | 3269 | unixctl_command_reply_error(conn, "Unknown bridge"); |
fa05809b BP |
3270 | return; |
3271 | } | |
3272 | ofproto_reconnect_controllers(br->ofproto); | |
3273 | } else { | |
764072fd | 3274 | HMAP_FOR_EACH (br, node, &all_bridges) { |
fa05809b BP |
3275 | ofproto_reconnect_controllers(br->ofproto); |
3276 | } | |
3277 | } | |
bde9f75d | 3278 | unixctl_command_reply(conn, NULL); |
fa05809b BP |
3279 | } |
3280 | ||
76ce9432 | 3281 | static size_t |
1a048029 | 3282 | bridge_get_controllers(const struct bridge *br, |
76ce9432 | 3283 | struct ovsrec_controller ***controllersp) |
064af421 | 3284 | { |
76ce9432 BP |
3285 | struct ovsrec_controller **controllers; |
3286 | size_t n_controllers; | |
064af421 | 3287 | |
1a048029 JP |
3288 | controllers = br->cfg->controller; |
3289 | n_controllers = br->cfg->n_controller; | |
76343538 | 3290 | |
76ce9432 BP |
3291 | if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) { |
3292 | controllers = NULL; | |
3293 | n_controllers = 0; | |
064af421 | 3294 | } |
76343538 | 3295 | |
76ce9432 BP |
3296 | if (controllersp) { |
3297 | *controllersp = controllers; | |
3298 | } | |
3299 | return n_controllers; | |
064af421 BP |
3300 | } |
3301 | ||
bae7208e | 3302 | static void |
2a73b1d7 BP |
3303 | bridge_collect_wanted_ports(struct bridge *br, |
3304 | const unsigned long int *splinter_vlans, | |
3305 | struct shash *wanted_ports) | |
bae7208e | 3306 | { |
6ae39834 | 3307 | size_t i; |
064af421 | 3308 | |
2a73b1d7 | 3309 | shash_init(wanted_ports); |
bae7208e | 3310 | |
76343538 BP |
3311 | for (i = 0; i < br->cfg->n_ports; i++) { |
3312 | const char *name = br->cfg->ports[i]->name; | |
2a73b1d7 | 3313 | if (!shash_add_once(wanted_ports, name, br->cfg->ports[i])) { |
76343538 BP |
3314 | VLOG_WARN("bridge %s: %s specified twice as bridge port", |
3315 | br->name, name); | |
3316 | } | |
3317 | } | |
b5827b24 | 3318 | if (bridge_get_controllers(br, NULL) |
2a73b1d7 | 3319 | && !shash_find(wanted_ports, br->name)) { |
cfea354b BP |
3320 | VLOG_WARN("bridge %s: no port named %s, synthesizing one", |
3321 | br->name, br->name); | |
72865317 | 3322 | |
a699f614 EJ |
3323 | ovsrec_interface_init(&br->synth_local_iface); |
3324 | ovsrec_port_init(&br->synth_local_port); | |
3325 | ||
cfea354b BP |
3326 | br->synth_local_port.interfaces = &br->synth_local_ifacep; |
3327 | br->synth_local_port.n_interfaces = 1; | |
3328 | br->synth_local_port.name = br->name; | |
3329 | ||
3330 | br->synth_local_iface.name = br->name; | |
66da9bef | 3331 | br->synth_local_iface.type = "internal"; |
cfea354b BP |
3332 | |
3333 | br->synth_local_ifacep = &br->synth_local_iface; | |
3334 | ||
2a73b1d7 | 3335 | shash_add(wanted_ports, br->name, &br->synth_local_port); |
064af421 | 3336 | } |
064af421 | 3337 | |
52a90c29 | 3338 | if (splinter_vlans) { |
2a73b1d7 | 3339 | add_vlan_splinter_ports(br, splinter_vlans, wanted_ports); |
52a90c29 | 3340 | } |
2a73b1d7 BP |
3341 | } |
3342 | ||
3343 | /* Deletes "struct port"s and "struct iface"s under 'br' which aren't | |
3344 | * consistent with 'br->cfg'. Updates 'br->if_cfg_queue' with interfaces which | |
3345 | * 'br' needs to complete its configuration. */ | |
3346 | static void | |
3347 | bridge_del_ports(struct bridge *br, const struct shash *wanted_ports) | |
3348 | { | |
3349 | struct shash_node *port_node; | |
3350 | struct port *port, *next; | |
52a90c29 | 3351 | |
4a1ee6ae | 3352 | /* Get rid of deleted ports. |
a70e4b2a | 3353 | * Get rid of deleted interfaces on ports that still exist. */ |
8052fb14 | 3354 | HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) { |
2a73b1d7 | 3355 | port->cfg = shash_find_data(wanted_ports, port->name); |
66da9bef | 3356 | if (!port->cfg) { |
4a1ee6ae BP |
3357 | port_destroy(port); |
3358 | } else { | |
66da9bef | 3359 | port_del_ifaces(port); |
064af421 BP |
3360 | } |
3361 | } | |
4a1ee6ae | 3362 | |
2a73b1d7 BP |
3363 | /* Update iface->cfg and iface->type in interfaces that still exist. */ |
3364 | SHASH_FOR_EACH (port_node, wanted_ports) { | |
bae7208e EJ |
3365 | const struct ovsrec_port *port = port_node->data; |
3366 | size_t i; | |
3367 | ||
3368 | for (i = 0; i < port->n_interfaces; i++) { | |
3369 | const struct ovsrec_interface *cfg = port->interfaces[i]; | |
3370 | struct iface *iface = iface_lookup(br, cfg->name); | |
046f1f89 | 3371 | const char *type = iface_get_type(cfg, br->cfg); |
bae7208e EJ |
3372 | |
3373 | if (iface) { | |
3374 | iface->cfg = cfg; | |
046f1f89 | 3375 | iface->type = type; |
0faed346 EJ |
3376 | } else if (!strcmp(type, "null")) { |
3377 | VLOG_WARN_ONCE("%s: The null interface type is deprecated and" | |
3378 | " may be removed in February 2013. Please email" | |
3379 | " dev@openvswitch.org with concerns.", | |
3380 | cfg->name); | |
3381 | } else { | |
2a73b1d7 | 3382 | /* We will add new interfaces later. */ |
bae7208e | 3383 | } |
ceb4559f | 3384 | } |
064af421 | 3385 | } |
064af421 BP |
3386 | } |
3387 | ||
7d674866 BP |
3388 | /* Initializes 'oc' appropriately as a management service controller for |
3389 | * 'br'. | |
3390 | * | |
3391 | * The caller must free oc->target when it is no longer needed. */ | |
3392 | static void | |
3393 | bridge_ofproto_controller_for_mgmt(const struct bridge *br, | |
3394 | struct ofproto_controller *oc) | |
3395 | { | |
b43c6fe2 | 3396 | oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name); |
7d674866 BP |
3397 | oc->max_backoff = 0; |
3398 | oc->probe_interval = 60; | |
3399 | oc->band = OFPROTO_OUT_OF_BAND; | |
7d674866 BP |
3400 | oc->rate_limit = 0; |
3401 | oc->burst_limit = 0; | |
9886b662 | 3402 | oc->enable_async_msgs = true; |
10bf2380 | 3403 | oc->dscp = 0; |
7d674866 BP |
3404 | } |
3405 | ||
3406 | /* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */ | |
3407 | static void | |
3408 | bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c, | |
3409 | struct ofproto_controller *oc) | |
3410 | { | |
a699f614 | 3411 | int dscp; |
f125905c | 3412 | |
7d674866 BP |
3413 | oc->target = c->target; |
3414 | oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8; | |
3415 | oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5; | |
3416 | oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band") | |
3417 | ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND); | |
7d674866 BP |
3418 | oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0; |
3419 | oc->burst_limit = (c->controller_burst_limit | |
3420 | ? *c->controller_burst_limit : 0); | |
9886b662 BP |
3421 | oc->enable_async_msgs = (!c->enable_async_messages |
3422 | || *c->enable_async_messages); | |
a699f614 EJ |
3423 | dscp = smap_get_int(&c->other_config, "dscp", DSCP_DEFAULT); |
3424 | if (dscp < 0 || dscp > 63) { | |
3425 | dscp = DSCP_DEFAULT; | |
f125905c | 3426 | } |
a699f614 | 3427 | oc->dscp = dscp; |
7d674866 BP |
3428 | } |
3429 | ||
3430 | /* Configures the IP stack for 'br''s local interface properly according to the | |
3431 | * configuration in 'c'. */ | |
3432 | static void | |
3433 | bridge_configure_local_iface_netdev(struct bridge *br, | |
3434 | struct ovsrec_controller *c) | |
3435 | { | |
3436 | struct netdev *netdev; | |
3437 | struct in_addr mask, gateway; | |
3438 | ||
3439 | struct iface *local_iface; | |
3440 | struct in_addr ip; | |
3441 | ||
7d674866 | 3442 | /* If there's no local interface or no IP address, give up. */ |
892815f5 | 3443 | local_iface = iface_from_ofp_port(br, OFPP_LOCAL); |
e7695092 | 3444 | if (!local_iface || !c->local_ip || !ip_parse(c->local_ip, &ip.s_addr)) { |
7d674866 BP |
3445 | return; |
3446 | } | |
3447 | ||
3448 | /* Bring up the local interface. */ | |
3449 | netdev = local_iface->netdev; | |
4b609110 | 3450 | netdev_turn_flags_on(netdev, NETDEV_UP, NULL); |
7d674866 BP |
3451 | |
3452 | /* Configure the IP address and netmask. */ | |
3453 | if (!c->local_netmask | |
e7695092 | 3454 | || !ip_parse(c->local_netmask, &mask.s_addr) |
7d674866 BP |
3455 | || !mask.s_addr) { |
3456 | mask.s_addr = guess_netmask(ip.s_addr); | |
3457 | } | |
3458 | if (!netdev_set_in4(netdev, ip, mask)) { | |
3459 | VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT, | |
ed36537e | 3460 | br->name, IP_ARGS(ip.s_addr), IP_ARGS(mask.s_addr)); |
7d674866 BP |
3461 | } |
3462 | ||
3463 | /* Configure the default gateway. */ | |
3464 | if (c->local_gateway | |
e7695092 | 3465 | && ip_parse(c->local_gateway, &gateway.s_addr) |
7d674866 BP |
3466 | && gateway.s_addr) { |
3467 | if (!netdev_add_router(netdev, gateway)) { | |
3468 | VLOG_INFO("bridge %s: configured gateway "IP_FMT, | |
ed36537e | 3469 | br->name, IP_ARGS(gateway.s_addr)); |
7d674866 BP |
3470 | } |
3471 | } | |
3472 | } | |
3473 | ||
cb4ef1ea BP |
3474 | /* Returns true if 'a' and 'b' are the same except that any number of slashes |
3475 | * in either string are treated as equal to any number of slashes in the other, | |
329e3462 PR |
3476 | * e.g. "x///y" is equal to "x/y". |
3477 | * | |
3478 | * Also, if 'b_stoplen' bytes from 'b' are found to be equal to corresponding | |
3479 | * bytes from 'a', the function considers this success. Specify 'b_stoplen' as | |
3480 | * SIZE_MAX to compare all of 'a' to all of 'b' rather than just a prefix of | |
3481 | * 'b' against a prefix of 'a'. | |
3482 | */ | |
cb4ef1ea | 3483 | static bool |
329e3462 | 3484 | equal_pathnames(const char *a, const char *b, size_t b_stoplen) |
cb4ef1ea | 3485 | { |
329e3462 | 3486 | const char *b_start = b; |
4a1d4e86 BP |
3487 | for (;;) { |
3488 | if (b - b_start >= b_stoplen) { | |
3489 | return true; | |
3490 | } else if (*a != *b) { | |
3491 | return false; | |
3492 | } else if (*a == '/') { | |
cb4ef1ea BP |
3493 | a += strspn(a, "/"); |
3494 | b += strspn(b, "/"); | |
3495 | } else if (*a == '\0') { | |
3496 | return true; | |
3497 | } else { | |
3498 | a++; | |
3499 | b++; | |
3500 | } | |
3501 | } | |
cb4ef1ea BP |
3502 | } |
3503 | ||
064af421 | 3504 | static void |
fa066f01 BP |
3505 | bridge_configure_remotes(struct bridge *br, |
3506 | const struct sockaddr_in *managers, size_t n_managers) | |
064af421 | 3507 | { |
a699f614 | 3508 | bool disable_in_band; |
b1da6250 | 3509 | |
76ce9432 BP |
3510 | struct ovsrec_controller **controllers; |
3511 | size_t n_controllers; | |
7d674866 | 3512 | |
66da9bef | 3513 | enum ofproto_fail_mode fail_mode; |
7d674866 BP |
3514 | |
3515 | struct ofproto_controller *ocs; | |
3516 | size_t n_ocs; | |
3517 | size_t i; | |
064af421 | 3518 | |
8731b2b6 | 3519 | /* Check if we should disable in-band control on this bridge. */ |
a699f614 EJ |
3520 | disable_in_band = smap_get_bool(&br->cfg->other_config, "disable-in-band", |
3521 | false); | |
8731b2b6 | 3522 | |
b1da6250 | 3523 | /* Set OpenFlow queue ID for in-band control. */ |
a699f614 EJ |
3524 | ofproto_set_in_band_queue(br->ofproto, |
3525 | smap_get_int(&br->cfg->other_config, | |
3526 | "in-band-queue", -1)); | |
b1da6250 | 3527 | |
8731b2b6 JP |
3528 | if (disable_in_band) { |
3529 | ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0); | |
3530 | } else { | |
3531 | ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers); | |
3532 | } | |
cd11000b | 3533 | |
1a048029 | 3534 | n_controllers = bridge_get_controllers(br, &controllers); |
064af421 | 3535 | |
7d674866 BP |
3536 | ocs = xmalloc((n_controllers + 1) * sizeof *ocs); |
3537 | n_ocs = 0; | |
064af421 | 3538 | |
7d674866 BP |
3539 | bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]); |
3540 | for (i = 0; i < n_controllers; i++) { | |
3541 | struct ovsrec_controller *c = controllers[i]; | |
76ce9432 | 3542 | |
7d674866 BP |
3543 | if (!strncmp(c->target, "punix:", 6) |
3544 | || !strncmp(c->target, "unix:", 5)) { | |
3545 | static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); | |
cb4ef1ea BP |
3546 | char *whitelist; |
3547 | ||
329e3462 PR |
3548 | if (!strncmp(c->target, "unix:", 5)) { |
3549 | /* Connect to a listening socket */ | |
3550 | whitelist = xasprintf("unix:%s/", ovs_rundir()); | |
2c487bc8 PR |
3551 | if (strchr(c->target, '/') && |
3552 | !equal_pathnames(c->target, whitelist, | |
3553 | strlen(whitelist))) { | |
3554 | /* Absolute path specified, but not in ovs_rundir */ | |
329e3462 PR |
3555 | VLOG_ERR_RL(&rl, "bridge %s: Not connecting to socket " |
3556 | "controller \"%s\" due to possibility for " | |
3557 | "remote exploit. Instead, specify socket " | |
3558 | "in whitelisted \"%s\" or connect to " | |
3559 | "\"unix:%s/%s.mgmt\" (which is always " | |
3560 | "available without special configuration).", | |
3561 | br->name, c->target, whitelist, | |
cb4ef1ea | 3562 | ovs_rundir(), br->name); |
329e3462 PR |
3563 | free(whitelist); |
3564 | continue; | |
3565 | } | |
3566 | } else { | |
14dd55a3 | 3567 | whitelist = xasprintf("punix:%s/%s.", |
329e3462 | 3568 | ovs_rundir(), br->name); |
14dd55a3 AW |
3569 | if (!equal_pathnames(c->target, whitelist, strlen(whitelist)) |
3570 | || strchr(c->target + strlen(whitelist), '/')) { | |
329e3462 PR |
3571 | /* Prevent remote ovsdb-server users from accessing |
3572 | * arbitrary Unix domain sockets and overwriting arbitrary | |
3573 | * local files. */ | |
3574 | VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket " | |
3575 | "controller \"%s\" due to possibility of " | |
3576 | "overwriting local files. Instead, specify " | |
14dd55a3 AW |
3577 | "path in whitelisted format \"%s*\" or " |
3578 | "connect to \"unix:%s/%s.mgmt\" (which is " | |
3579 | "always available without special " | |
3580 | "configuration).", | |
329e3462 PR |
3581 | br->name, c->target, whitelist, |
3582 | ovs_rundir(), br->name); | |
3583 | free(whitelist); | |
3584 | continue; | |
3585 | } | |
cb4ef1ea | 3586 | } |
4d6fb5eb | 3587 | |
cb4ef1ea | 3588 | free(whitelist); |
4d6fb5eb EJ |
3589 | } |
3590 | ||
7d674866 | 3591 | bridge_configure_local_iface_netdev(br, c); |
8731b2b6 JP |
3592 | bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]); |
3593 | if (disable_in_band) { | |
3594 | ocs[n_ocs].band = OFPROTO_OUT_OF_BAND; | |
f620b43a | 3595 | } |
8731b2b6 | 3596 | n_ocs++; |
be02e7c3 | 3597 | } |
be02e7c3 | 3598 | |
7beaa082 SH |
3599 | ofproto_set_controllers(br->ofproto, ocs, n_ocs, |
3600 | bridge_get_allowed_versions(br)); | |
7d674866 BP |
3601 | free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */ |
3602 | free(ocs); | |
66da9bef BP |
3603 | |
3604 | /* Set the fail-mode. */ | |
3605 | fail_mode = !br->cfg->fail_mode | |
3606 | || !strcmp(br->cfg->fail_mode, "standalone") | |
3607 | ? OFPROTO_FAIL_STANDALONE | |
3608 | : OFPROTO_FAIL_SECURE; | |
3609 | ofproto_set_fail_mode(br->ofproto, fail_mode); | |
3610 | ||
3611 | /* Configure OpenFlow controller connection snooping. */ | |
3612 | if (!ofproto_has_snoops(br->ofproto)) { | |
3613 | struct sset snoops; | |
5827ce14 | 3614 | |
66da9bef BP |
3615 | sset_init(&snoops); |
3616 | sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop", | |
3617 | ovs_rundir(), br->name)); | |
3618 | ofproto_set_snoops(br->ofproto, &snoops); | |
3619 | sset_destroy(&snoops); | |
064af421 BP |
3620 | } |
3621 | } | |
254750ce BP |
3622 | |
3623 | static void | |
3624 | bridge_configure_tables(struct bridge *br) | |
3625 | { | |
3626 | static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); | |
3627 | int n_tables; | |
13751fd8 | 3628 | int i, j, k; |
254750ce BP |
3629 | |
3630 | n_tables = ofproto_get_n_tables(br->ofproto); | |
3631 | j = 0; | |
3632 | for (i = 0; i < n_tables; i++) { | |
3633 | struct ofproto_table_settings s; | |
480cda3a | 3634 | bool use_default_prefixes = true; |
254750ce BP |
3635 | |
3636 | s.name = NULL; | |
3637 | s.max_flows = UINT_MAX; | |
3638 | s.groups = NULL; | |
82c22d34 | 3639 | s.enable_eviction = false; |
254750ce | 3640 | s.n_groups = 0; |
13751fd8 JR |
3641 | s.n_prefix_fields = 0; |
3642 | memset(s.prefix_fields, ~0, sizeof(s.prefix_fields)); | |
254750ce BP |
3643 | |
3644 | if (j < br->cfg->n_flow_tables && i == br->cfg->key_flow_tables[j]) { | |
3645 | struct ovsrec_flow_table *cfg = br->cfg->value_flow_tables[j++]; | |
3646 | ||
3647 | s.name = cfg->name; | |
3648 | if (cfg->n_flow_limit && *cfg->flow_limit < UINT_MAX) { | |
3649 | s.max_flows = *cfg->flow_limit; | |
3650 | } | |
254750ce | 3651 | |
82c22d34 BP |
3652 | s.enable_eviction = (cfg->overflow_policy |
3653 | && !strcmp(cfg->overflow_policy, "evict")); | |
3654 | if (cfg->n_groups) { | |
254750ce BP |
3655 | s.groups = xmalloc(cfg->n_groups * sizeof *s.groups); |
3656 | for (k = 0; k < cfg->n_groups; k++) { | |
3657 | const char *string = cfg->groups[k]; | |
3658 | char *msg; | |
3659 | ||
3660 | msg = mf_parse_subfield__(&s.groups[k], &string); | |
3661 | if (msg) { | |
3662 | VLOG_WARN_RL(&rl, "bridge %s table %d: error parsing " | |
3663 | "'groups' (%s)", br->name, i, msg); | |
3664 | free(msg); | |
3665 | } else if (*string) { | |
3666 | VLOG_WARN_RL(&rl, "bridge %s table %d: 'groups' " | |
3667 | "element '%s' contains trailing garbage", | |
3668 | br->name, i, cfg->groups[k]); | |
3669 | } else { | |
3670 | s.n_groups++; | |
3671 | } | |
3672 | } | |
3673 | } | |
82c22d34 | 3674 | |
13751fd8 JR |
3675 | /* Prefix lookup fields. */ |
3676 | s.n_prefix_fields = 0; | |
3677 | for (k = 0; k < cfg->n_prefixes; k++) { | |
3678 | const char *name = cfg->prefixes[k]; | |
f017d986 JR |
3679 | const struct mf_field *mf; |
3680 | ||
3681 | if (strcmp(name, "none") == 0) { | |
480cda3a JR |
3682 | use_default_prefixes = false; |
3683 | s.n_prefix_fields = 0; | |
3684 | break; | |
f017d986 JR |
3685 | } |
3686 | mf = mf_from_name(name); | |
13751fd8 JR |
3687 | if (!mf) { |
3688 | VLOG_WARN("bridge %s: 'prefixes' with unknown field: %s", | |
3689 | br->name, name); | |
3690 | continue; | |
3691 | } | |
3692 | if (mf->flow_be32ofs < 0 || mf->n_bits % 32) { | |
3693 | VLOG_WARN("bridge %s: 'prefixes' with incompatible field: " | |
3694 | "%s", br->name, name); | |
3695 | continue; | |
3696 | } | |
3697 | if (s.n_prefix_fields >= ARRAY_SIZE(s.prefix_fields)) { | |
3698 | VLOG_WARN("bridge %s: 'prefixes' with too many fields, " | |
3699 | "field not used: %s", br->name, name); | |
3700 | continue; | |
3701 | } | |
480cda3a | 3702 | use_default_prefixes = false; |
13751fd8 JR |
3703 | s.prefix_fields[s.n_prefix_fields++] = mf->id; |
3704 | } | |
480cda3a JR |
3705 | } |
3706 | if (use_default_prefixes) { | |
3707 | /* Use default values. */ | |
3708 | s.n_prefix_fields = ARRAY_SIZE(default_prefix_fields); | |
3709 | memcpy(s.prefix_fields, default_prefix_fields, | |
3710 | sizeof default_prefix_fields); | |
3711 | } else { | |
3712 | int k; | |
3713 | struct ds ds = DS_EMPTY_INITIALIZER; | |
3714 | for (k = 0; k < s.n_prefix_fields; k++) { | |
3715 | if (k) { | |
3716 | ds_put_char(&ds, ','); | |
13751fd8 | 3717 | } |
480cda3a JR |
3718 | ds_put_cstr(&ds, mf_from_id(s.prefix_fields[k])->name); |
3719 | } | |
3720 | if (s.n_prefix_fields == 0) { | |
3721 | ds_put_cstr(&ds, "none"); | |
13751fd8 | 3722 | } |
480cda3a JR |
3723 | VLOG_INFO("bridge %s table %d: Prefix lookup with: %s.", |
3724 | br->name, i, ds_cstr(&ds)); | |
3725 | ds_destroy(&ds); | |
254750ce BP |
3726 | } |
3727 | ||
3728 | ofproto_configure_table(br->ofproto, i, &s); | |
3729 | ||
3730 | free(s.groups); | |
3731 | } | |
3732 | for (; j < br->cfg->n_flow_tables; j++) { | |
3733 | VLOG_WARN_RL(&rl, "bridge %s: ignoring configuration for flow table " | |
3734 | "%"PRId64" not supported by this datapath", br->name, | |
3735 | br->cfg->key_flow_tables[j]); | |
3736 | } | |
3737 | } | |
8b6ff729 BP |
3738 | |
3739 | static void | |
3740 | bridge_configure_dp_desc(struct bridge *br) | |
3741 | { | |
3742 | ofproto_set_dp_desc(br->ofproto, | |
3743 | smap_get(&br->cfg->other_config, "dp-desc")); | |
3744 | } | |
99eef98b DF |
3745 | |
3746 | static struct aa_mapping * | |
3747 | bridge_aa_mapping_find(struct bridge *br, const int64_t isid) | |
3748 | { | |
3749 | struct aa_mapping *m; | |
3750 | ||
3751 | HMAP_FOR_EACH_IN_BUCKET (m, | |
3752 | hmap_node, | |
3753 | hash_bytes(&isid, sizeof isid, 0), | |
3754 | &br->mappings) { | |
3755 | if (isid == m->isid) { | |
3756 | return m; | |
3757 | } | |
3758 | } | |
3759 | return NULL; | |
3760 | } | |
3761 | ||
3762 | static struct aa_mapping * | |
3763 | bridge_aa_mapping_create(struct bridge *br, | |
3764 | const int64_t isid, | |
3765 | const int64_t vlan) | |
3766 | { | |
3767 | struct aa_mapping *m; | |
3768 | ||
3769 | m = xzalloc(sizeof *m); | |
3770 | m->bridge = br; | |
3771 | m->isid = isid; | |
3772 | m->vlan = vlan; | |
3773 | m->br_name = xstrdup(br->name); | |
3774 | hmap_insert(&br->mappings, | |
3775 | &m->hmap_node, | |
3776 | hash_bytes(&isid, sizeof isid, 0)); | |
3777 | ||
3778 | return m; | |
3779 | } | |
3780 | ||
3781 | static void | |
3782 | bridge_aa_mapping_destroy(struct aa_mapping *m) | |
3783 | { | |
3784 | if (m) { | |
3785 | struct bridge *br = m->bridge; | |
3786 | ||
3787 | if (br->ofproto) { | |
3788 | ofproto_aa_mapping_unregister(br->ofproto, m); | |
3789 | } | |
3790 | ||
3791 | hmap_remove(&br->mappings, &m->hmap_node); | |
3792 | if (m->br_name) { | |
3793 | free(m->br_name); | |
3794 | } | |
3795 | free(m); | |
3796 | } | |
3797 | } | |
3798 | ||
3799 | static bool | |
3800 | bridge_aa_mapping_configure(struct aa_mapping *m) | |
3801 | { | |
3802 | struct aa_mapping_settings s; | |
3803 | ||
3804 | s.isid = m->isid; | |
3805 | s.vlan = m->vlan; | |
3806 | ||
3807 | /* Configure. */ | |
3808 | ofproto_aa_mapping_register(m->bridge->ofproto, m, &s); | |
3809 | ||
3810 | return true; | |
3811 | } | |
3812 | ||
3813 | static void | |
3814 | bridge_configure_aa(struct bridge *br) | |
3815 | { | |
3816 | const struct ovsdb_datum *mc; | |
3817 | struct ovsrec_autoattach *auto_attach = br->cfg->auto_attach; | |
3818 | struct aa_settings aa_s; | |
3819 | struct aa_mapping *m, *next; | |
3820 | size_t i; | |
3821 | ||
3822 | if (!auto_attach) { | |
3823 | ofproto_set_aa(br->ofproto, NULL, NULL); | |
3824 | return; | |
3825 | } | |
3826 | ||
3827 | memset(&aa_s, 0, sizeof aa_s); | |
3828 | aa_s.system_description = auto_attach->system_description; | |
3829 | aa_s.system_name = auto_attach->system_name; | |
3830 | ofproto_set_aa(br->ofproto, NULL, &aa_s); | |
3831 | ||
3832 | mc = ovsrec_autoattach_get_mappings(auto_attach, | |
3833 | OVSDB_TYPE_INTEGER, | |
3834 | OVSDB_TYPE_INTEGER); | |
3835 | HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mappings) { | |
3836 | union ovsdb_atom atom; | |
3837 | ||
3838 | atom.integer = m->isid; | |
3839 | if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) { | |
72c642e5 BP |
3840 | VLOG_INFO("Deleting isid=%"PRIu32", vlan=%"PRIu16, |
3841 | m->isid, m->vlan); | |
99eef98b DF |
3842 | bridge_aa_mapping_destroy(m); |
3843 | } | |
3844 | } | |
3845 | ||
3846 | /* Add new mappings and reconfigure existing ones. */ | |
3847 | for (i = 0; i < auto_attach->n_mappings; ++i) { | |
3848 | struct aa_mapping *m = | |
3849 | bridge_aa_mapping_find(br, auto_attach->key_mappings[i]); | |
3850 | ||
3851 | if (!m) { | |
3852 | VLOG_INFO("Adding isid=%"PRId64", vlan=%"PRId64, | |
3853 | auto_attach->key_mappings[i], | |
3854 | auto_attach->value_mappings[i]); | |
3855 | m = bridge_aa_mapping_create(br, | |
3856 | auto_attach->key_mappings[i], | |
3857 | auto_attach->value_mappings[i]); | |
3858 | ||
3859 | if (!bridge_aa_mapping_configure(m)) { | |
3860 | bridge_aa_mapping_destroy(m); | |
3861 | } | |
3862 | } | |
3863 | } | |
3864 | } | |
3865 | ||
3866 | static bool | |
3867 | bridge_aa_need_refresh(struct bridge *br) | |
3868 | { | |
3869 | return ofproto_aa_vlan_get_queue_size(br->ofproto) > 0; | |
3870 | } | |
3871 | ||
3872 | static void | |
3873 | bridge_aa_update_trunks(struct port *port, struct bridge_aa_vlan *m) | |
3874 | { | |
3875 | int64_t *trunks = NULL; | |
3876 | unsigned int i = 0; | |
3877 | bool found = false, reconfigure = false; | |
3878 | ||
3879 | for (i = 0; i < port->cfg->n_trunks; i++) { | |
3880 | if (port->cfg->trunks[i] == m->vlan) { | |
3881 | found = true; | |
3882 | break; | |
3883 | } | |
3884 | } | |
3885 | ||
3886 | switch (m->oper) { | |
3887 | case BRIDGE_AA_VLAN_OPER_ADD: | |
3888 | if (!found) { | |
3889 | trunks = xmalloc(sizeof *trunks * (port->cfg->n_trunks + 1)); | |
3890 | ||
3891 | for (i = 0; i < port->cfg->n_trunks; i++) { | |
3892 | trunks[i] = port->cfg->trunks[i]; | |
3893 | } | |
3894 | trunks[i++] = m->vlan; | |
3895 | reconfigure = true; | |
3896 | } | |
3897 | ||
3898 | break; | |
3899 | ||
3900 | case BRIDGE_AA_VLAN_OPER_REMOVE: | |
3901 | if (found) { | |
3902 | unsigned int j = 0; | |
3903 | ||
3904 | trunks = xmalloc(sizeof *trunks * (port->cfg->n_trunks - 1)); | |
3905 | ||
3906 | for (i = 0; i < port->cfg->n_trunks; i++) { | |
3907 | if (port->cfg->trunks[i] != m->vlan) { | |
3908 | trunks[j++] = port->cfg->trunks[i]; | |
3909 | } | |
3910 | } | |
3911 | i = j; | |
3912 | reconfigure = true; | |
3913 | } | |
3914 | ||
3915 | break; | |
3916 | ||
3917 | case BRIDGE_AA_VLAN_OPER_UNDEF: | |
3918 | default: | |
3919 | VLOG_WARN("unrecognized operation %u", m->oper); | |
3920 | break; | |
3921 | } | |
3922 | ||
3923 | if (reconfigure) { | |
3924 | /* VLAN switching under trunk mode cause the trunk port to switch all | |
3925 | * VLANs, see ovs-vswitchd.conf.db | |
3926 | */ | |
3927 | if (i == 0) { | |
3928 | static char *vlan_mode_access = "access"; | |
3929 | ovsrec_port_set_vlan_mode(port->cfg, vlan_mode_access); | |
3930 | } | |
3931 | ||
3932 | if (i == 1) { | |
3933 | static char *vlan_mode_trunk = "trunk"; | |
3934 | ovsrec_port_set_vlan_mode(port->cfg, vlan_mode_trunk); | |
3935 | } | |
3936 | ||
3937 | ovsrec_port_set_trunks(port->cfg, trunks, i); | |
3938 | ||
3939 | /* Force reconfigure of the port. */ | |
3940 | port_configure(port); | |
3941 | } | |
3942 | } | |
3943 | ||
3944 | static void | |
3945 | bridge_aa_refresh_queued(struct bridge *br) | |
3946 | { | |
3947 | struct ovs_list *list = xmalloc(sizeof *list); | |
494356bf | 3948 | struct bridge_aa_vlan *node, *next; |
99eef98b DF |
3949 | |
3950 | list_init(list); | |
3951 | ofproto_aa_vlan_get_queued(br->ofproto, list); | |
3952 | ||
494356bf | 3953 | LIST_FOR_EACH_SAFE (node, next, list_node, list) { |
99eef98b DF |
3954 | struct port *port; |
3955 | ||
3956 | VLOG_INFO("ifname=%s, vlan=%u, oper=%u", node->port_name, node->vlan, | |
3957 | node->oper); | |
3958 | ||
3959 | port = port_lookup(br, node->port_name); | |
3960 | if (port) { | |
3961 | bridge_aa_update_trunks(port, node); | |
3962 | } | |
3963 | ||
3964 | list_remove(&node->list_node); | |
3965 | free(node->port_name); | |
3966 | free(node); | |
3967 | } | |
3968 | ||
3969 | free(list); | |
3970 | } | |
3971 | ||
064af421 | 3972 | \f |
fa066f01 | 3973 | /* Port functions. */ |
064af421 | 3974 | |
f620b43a | 3975 | static struct port * |
fa066f01 | 3976 | port_create(struct bridge *br, const struct ovsrec_port *cfg) |
064af421 | 3977 | { |
f620b43a BP |
3978 | struct port *port; |
3979 | ||
3980 | port = xzalloc(sizeof *port); | |
3981 | port->bridge = br; | |
fa066f01 BP |
3982 | port->name = xstrdup(cfg->name); |
3983 | port->cfg = cfg; | |
f620b43a BP |
3984 | list_init(&port->ifaces); |
3985 | ||
3986 | hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0)); | |
f620b43a | 3987 | return port; |
064af421 BP |
3988 | } |
3989 | ||
fa066f01 | 3990 | /* Deletes interfaces from 'port' that are no longer configured for it. */ |
064af421 | 3991 | static void |
fa066f01 | 3992 | port_del_ifaces(struct port *port) |
064af421 | 3993 | { |
f620b43a BP |
3994 | struct iface *iface, *next; |
3995 | struct sset new_ifaces; | |
3996 | size_t i; | |
064af421 | 3997 | |
f620b43a BP |
3998 | /* Collect list of new interfaces. */ |
3999 | sset_init(&new_ifaces); | |
fa066f01 BP |
4000 | for (i = 0; i < port->cfg->n_interfaces; i++) { |
4001 | const char *name = port->cfg->interfaces[i]->name; | |
93f331d3 | 4002 | const char *type = port->cfg->interfaces[i]->type; |
00794817 BP |
4003 | if (strcmp(type, "null")) { |
4004 | sset_add(&new_ifaces, name); | |
4005 | } | |
f620b43a | 4006 | } |
064af421 | 4007 | |
f620b43a BP |
4008 | /* Get rid of deleted interfaces. */ |
4009 | LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) { | |
4010 | if (!sset_contains(&new_ifaces, iface->name)) { | |
4011 | iface_destroy(iface); | |
064af421 | 4012 | } |
064af421 | 4013 | } |
f620b43a BP |
4014 | |
4015 | sset_destroy(&new_ifaces); | |
064af421 BP |
4016 | } |
4017 | ||
064af421 BP |
4018 | static void |
4019 | port_destroy(struct port *port) | |
4020 | { | |
4021 | if (port) { | |
4022 | struct bridge *br = port->bridge; | |
83db7968 | 4023 | struct iface *iface, *next; |
064af421 | 4024 | |
fa066f01 BP |
4025 | if (br->ofproto) { |
4026 | ofproto_bundle_unregister(br->ofproto, port); | |
064af421 BP |
4027 | } |
4028 | ||
83db7968 | 4029 | LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) { |
2a73b1d7 | 4030 | iface_destroy__(iface); |
064af421 BP |
4031 | } |
4032 | ||
8052fb14 | 4033 | hmap_remove(&br->ports, &port->hmap_node); |
064af421 BP |
4034 | free(port->name); |
4035 | free(port); | |
064af421 BP |
4036 | } |
4037 | } | |
4038 | ||
064af421 BP |
4039 | static struct port * |
4040 | port_lookup(const struct bridge *br, const char *name) | |
4041 | { | |
8052fb14 BP |
4042 | struct port *port; |
4043 | ||
4044 | HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0), | |
4045 | &br->ports) { | |
4046 | if (!strcmp(port->name, name)) { | |
4047 | return port; | |
4048 | } | |
4049 | } | |
4050 | return NULL; | |
064af421 BP |
4051 | } |
4052 | ||
7a673515 BP |
4053 | static bool |
4054 | enable_lacp(struct port *port, bool *activep) | |
4055 | { | |
4056 | if (!port->cfg->lacp) { | |
4057 | /* XXX when LACP implementation has been sufficiently tested, enable by | |
4058 | * default and make active on bonded ports. */ | |
4059 | return false; | |
4060 | } else if (!strcmp(port->cfg->lacp, "off")) { | |
4061 | return false; | |
4062 | } else if (!strcmp(port->cfg->lacp, "active")) { | |
4063 | *activep = true; | |
4064 | return true; | |
4065 | } else if (!strcmp(port->cfg->lacp, "passive")) { | |
4066 | *activep = false; | |
4067 | return true; | |
4068 | } else { | |
4069 | VLOG_WARN("port %s: unknown LACP mode %s", | |
4070 | port->name, port->cfg->lacp); | |
4071 | return false; | |
4072 | } | |
4073 | } | |
4074 | ||
fa066f01 BP |
4075 | static struct lacp_settings * |
4076 | port_configure_lacp(struct port *port, struct lacp_settings *s) | |
5827ce14 | 4077 | { |
e567943d | 4078 | const char *lacp_time, *system_id; |
b5a25389 | 4079 | int priority; |
5827ce14 | 4080 | |
fa066f01 BP |
4081 | if (!enable_lacp(port, &s->active)) { |
4082 | return NULL; | |
abd4a95d EJ |
4083 | } |
4084 | ||
fa066f01 | 4085 | s->name = port->name; |
e567943d | 4086 | |
a699f614 | 4087 | system_id = smap_get(&port->cfg->other_config, "lacp-system-id"); |
a9bf011b | 4088 | if (system_id) { |
c2c28dfd BP |
4089 | if (!ovs_scan(system_id, ETH_ADDR_SCAN_FMT, |
4090 | ETH_ADDR_SCAN_ARGS(s->id))) { | |
a9bf011b EJ |
4091 | VLOG_WARN("port %s: LACP system ID (%s) must be an Ethernet" |
4092 | " address.", port->name, system_id); | |
4093 | return NULL; | |
4094 | } | |
4095 | } else { | |
74ff3298 | 4096 | s->id = port->bridge->ea; |
e567943d | 4097 | } |
b5a25389 | 4098 | |
69fdadb1 EJ |
4099 | if (eth_addr_is_zero(s->id)) { |
4100 | VLOG_WARN("port %s: Invalid zero LACP system ID.", port->name); | |
4101 | return NULL; | |
4102 | } | |
4103 | ||
b5a25389 | 4104 | /* Prefer bondable links if unspecified. */ |
a699f614 EJ |
4105 | priority = smap_get_int(&port->cfg->other_config, "lacp-system-priority", |
4106 | 0); | |
fa066f01 BP |
4107 | s->priority = (priority > 0 && priority <= UINT16_MAX |
4108 | ? priority | |
4109 | : UINT16_MAX - !list_is_short(&port->ifaces)); | |
b5a25389 | 4110 | |
a699f614 EJ |
4111 | lacp_time = smap_get(&port->cfg->other_config, "lacp-time"); |
4112 | s->fast = lacp_time && !strcasecmp(lacp_time, "fast"); | |
9dd165e0 RK |
4113 | |
4114 | s->fallback_ab_cfg = smap_get_bool(&port->cfg->other_config, | |
4115 | "lacp-fallback-ab", false); | |
4116 | ||
fa066f01 BP |
4117 | return s; |
4118 | } | |
5827ce14 | 4119 | |
fa066f01 BP |
4120 | static void |
4121 | iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s) | |
4122 | { | |
00794817 | 4123 | int priority, portid, key; |
5827ce14 | 4124 | |
a699f614 EJ |
4125 | portid = smap_get_int(&iface->cfg->other_config, "lacp-port-id", 0); |
4126 | priority = smap_get_int(&iface->cfg->other_config, "lacp-port-priority", | |
4127 | 0); | |
4128 | key = smap_get_int(&iface->cfg->other_config, "lacp-aggregation-key", 0); | |
fa066f01 BP |
4129 | |
4130 | if (portid <= 0 || portid > UINT16_MAX) { | |
4e022ec0 | 4131 | portid = ofp_to_u16(iface->ofp_port); |
5827ce14 EJ |
4132 | } |
4133 | ||
fa066f01 BP |
4134 | if (priority <= 0 || priority > UINT16_MAX) { |
4135 | priority = UINT16_MAX; | |
4136 | } | |
5827ce14 | 4137 | |
00794817 BP |
4138 | if (key < 0 || key > UINT16_MAX) { |
4139 | key = 0; | |
5827ce14 | 4140 | } |
00794817 | 4141 | |
fa066f01 | 4142 | s->name = iface->name; |
fa066f01 BP |
4143 | s->id = portid; |
4144 | s->priority = priority; | |
00794817 | 4145 | s->key = key; |
bb5bc6c0 BP |
4146 | } |
4147 | ||
c25c91fd | 4148 | static void |
df53d41c | 4149 | port_configure_bond(struct port *port, struct bond_settings *s) |
c25c91fd | 4150 | { |
f620b43a | 4151 | const char *detect_s; |
7a673515 | 4152 | struct iface *iface; |
3e5aeeb5 | 4153 | const char *mac_s; |
1670c579 | 4154 | int miimon_interval; |
c25c91fd | 4155 | |
fa066f01 | 4156 | s->name = port->name; |
4df08875 | 4157 | s->balance = BM_AB; |
4c57c3bc EJ |
4158 | if (port->cfg->bond_mode) { |
4159 | if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) { | |
4160 | VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s", | |
4161 | port->name, port->cfg->bond_mode, | |
4162 | bond_mode_to_string(s->balance)); | |
4163 | } | |
4164 | } else { | |
4165 | static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); | |
4166 | ||
4df08875 EJ |
4167 | /* XXX: Post version 1.5.*, the default bond_mode changed from SLB to |
4168 | * active-backup. At some point we should remove this warning. */ | |
4c57c3bc | 4169 | VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that" |
4df08875 EJ |
4170 | " in previous versions, the default bond_mode was" |
4171 | " balance-slb", port->name, | |
4c57c3bc | 4172 | bond_mode_to_string(s->balance)); |
f620b43a | 4173 | } |
6c2d2a9f BP |
4174 | if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) { |
4175 | VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, " | |
4176 | "please use another bond type or disable flood_vlans", | |
4177 | port->name); | |
4178 | } | |
bb5bc6c0 | 4179 | |
a699f614 EJ |
4180 | miimon_interval = smap_get_int(&port->cfg->other_config, |
4181 | "bond-miimon-interval", 0); | |
1670c579 EJ |
4182 | if (miimon_interval <= 0) { |
4183 | miimon_interval = 200; | |
f620b43a BP |
4184 | } |
4185 | ||
a699f614 EJ |
4186 | detect_s = smap_get(&port->cfg->other_config, "bond-detect-mode"); |
4187 | if (!detect_s || !strcmp(detect_s, "carrier")) { | |
1670c579 EJ |
4188 | miimon_interval = 0; |
4189 | } else if (strcmp(detect_s, "miimon")) { | |
4190 | VLOG_WARN("port %s: unsupported bond-detect-mode %s, " | |
4191 | "defaulting to carrier", port->name, detect_s); | |
4192 | miimon_interval = 0; | |
f620b43a BP |
4193 | } |
4194 | ||
fa066f01 BP |
4195 | s->up_delay = MAX(0, port->cfg->bond_updelay); |
4196 | s->down_delay = MAX(0, port->cfg->bond_downdelay); | |
a699f614 EJ |
4197 | s->basis = smap_get_int(&port->cfg->other_config, "bond-hash-basis", 0); |
4198 | s->rebalance_interval = smap_get_int(&port->cfg->other_config, | |
4199 | "bond-rebalance-interval", 10000); | |
bc1b010c | 4200 | if (s->rebalance_interval && s->rebalance_interval < 1000) { |
fa066f01 | 4201 | s->rebalance_interval = 1000; |
f620b43a BP |
4202 | } |
4203 | ||
9dd165e0 RK |
4204 | s->lacp_fallback_ab_cfg = smap_get_bool(&port->cfg->other_config, |
4205 | "lacp-fallback-ab", false); | |
4206 | ||
7a673515 | 4207 | LIST_FOR_EACH (iface, port_elem, &port->ifaces) { |
1670c579 | 4208 | netdev_set_miimon_interval(iface->netdev, miimon_interval); |
064af421 | 4209 | } |
3e5aeeb5 AZ |
4210 | |
4211 | mac_s = port->cfg->bond_active_slave; | |
4212 | if (!mac_s || !ovs_scan(mac_s, ETH_ADDR_SCAN_FMT, | |
4213 | ETH_ADDR_SCAN_ARGS(s->active_slave_mac))) { | |
4214 | /* OVSDB did not store the last active interface */ | |
74ff3298 | 4215 | s->active_slave_mac = eth_addr_zero; |
3e5aeeb5 | 4216 | } |
064af421 | 4217 | } |
06b592bc EJ |
4218 | |
4219 | /* Returns true if 'port' is synthetic, that is, if we constructed it locally | |
4220 | * instead of obtaining it from the database. */ | |
4221 | static bool | |
4222 | port_is_synthetic(const struct port *port) | |
4223 | { | |
4224 | return ovsdb_idl_row_is_synthetic(&port->cfg->header_); | |
4225 | } | |
064af421 BP |
4226 | \f |
4227 | /* Interface functions. */ | |
4228 | ||
05ba03e0 JP |
4229 | static bool |
4230 | iface_is_internal(const struct ovsrec_interface *iface, | |
4231 | const struct ovsrec_bridge *br) | |
4232 | { | |
4233 | /* The local port and "internal" ports are always "internal". */ | |
4234 | return !strcmp(iface->type, "internal") || !strcmp(iface->name, br->name); | |
4235 | } | |
4236 | ||
b54441b3 BP |
4237 | /* Returns the correct network device type for interface 'iface' in bridge |
4238 | * 'br'. */ | |
4239 | static const char * | |
4240 | iface_get_type(const struct ovsrec_interface *iface, | |
4241 | const struct ovsrec_bridge *br) | |
4242 | { | |
b4f4b737 JP |
4243 | const char *type; |
4244 | ||
4245 | /* The local port always has type "internal". Other ports take | |
4246 | * their type from the database and default to "system" if none is | |
4247 | * specified. */ | |
05ba03e0 | 4248 | if (iface_is_internal(iface, br)) { |
b4f4b737 | 4249 | type = "internal"; |
acf60855 | 4250 | } else { |
b4f4b737 | 4251 | type = iface->type[0] ? iface->type : "system"; |
acf60855 | 4252 | } |
b4f4b737 JP |
4253 | |
4254 | return ofproto_port_open_type(br->datapath_type, type); | |
064af421 BP |
4255 | } |
4256 | ||
4257 | static void | |
2a73b1d7 | 4258 | iface_destroy__(struct iface *iface) |
064af421 BP |
4259 | { |
4260 | if (iface) { | |
4261 | struct port *port = iface->port; | |
4262 | struct bridge *br = port->bridge; | |
c17f0d5e | 4263 | |
c60c33fb | 4264 | if (br->ofproto && iface->ofp_port != OFPP_NONE) { |
892815f5 | 4265 | ofproto_port_unregister(br->ofproto, iface->ofp_port); |
5827ce14 EJ |
4266 | } |
4267 | ||
c60c33fb | 4268 | if (iface->ofp_port != OFPP_NONE) { |
892815f5 | 4269 | hmap_remove(&br->ifaces, &iface->ofp_port_node); |
064af421 BP |
4270 | } |
4271 | ||
83db7968 | 4272 | list_remove(&iface->port_elem); |
ebea37cc | 4273 | hmap_remove(&br->iface_by_name, &iface->name_node); |
064af421 | 4274 | |
fe83f81d RW |
4275 | /* The user is changing configuration here, so netdev_remove needs to be |
4276 | * used as opposed to netdev_close */ | |
4277 | netdev_remove(iface->netdev); | |
064af421 | 4278 | |
a740f0de JG |
4279 | free(iface->name); |
4280 | free(iface); | |
064af421 BP |
4281 | } |
4282 | } | |
4283 | ||
2a73b1d7 BP |
4284 | static void |
4285 | iface_destroy(struct iface *iface) | |
4286 | { | |
4287 | if (iface) { | |
4288 | struct port *port = iface->port; | |
4289 | ||
4290 | iface_destroy__(iface); | |
4291 | if (list_is_empty(&port->ifaces)) { | |
4292 | port_destroy(port); | |
4293 | } | |
4294 | } | |
4295 | } | |
4296 | ||
064af421 BP |
4297 | static struct iface * |
4298 | iface_lookup(const struct bridge *br, const char *name) | |
4299 | { | |
ebea37cc BP |
4300 | struct iface *iface; |
4301 | ||
4302 | HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0), | |
4303 | &br->iface_by_name) { | |
4304 | if (!strcmp(iface->name, name)) { | |
4305 | return iface; | |
4306 | } | |
4307 | } | |
4308 | ||
4309 | return NULL; | |
064af421 BP |
4310 | } |
4311 | ||
e8fe3026 EJ |
4312 | static struct iface * |
4313 | iface_find(const char *name) | |
4314 | { | |
4315 | const struct bridge *br; | |
4316 | ||
764072fd | 4317 | HMAP_FOR_EACH (br, node, &all_bridges) { |
e8fe3026 EJ |
4318 | struct iface *iface = iface_lookup(br, name); |
4319 | ||
4320 | if (iface) { | |
4321 | return iface; | |
4322 | } | |
4323 | } | |
4324 | return NULL; | |
4325 | } | |
4326 | ||
064af421 | 4327 | static struct iface * |
4e022ec0 | 4328 | iface_from_ofp_port(const struct bridge *br, ofp_port_t ofp_port) |
064af421 | 4329 | { |
d9a8717a BP |
4330 | struct iface *iface; |
4331 | ||
f9c0c3ec | 4332 | HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node, hash_ofp_port(ofp_port), |
4e022ec0 | 4333 | &br->ifaces) { |
892815f5 | 4334 | if (iface->ofp_port == ofp_port) { |
d9a8717a BP |
4335 | return iface; |
4336 | } | |
4337 | } | |
4338 | return NULL; | |
064af421 | 4339 | } |
557d8e6c | 4340 | |
52df17e7 BP |
4341 | /* Set Ethernet address of 'iface', if one is specified in the configuration |
4342 | * file. */ | |
4343 | static void | |
21a955fc | 4344 | iface_set_mac(const struct bridge *br, const struct port *port, struct iface *iface) |
52df17e7 | 4345 | { |
74ff3298 | 4346 | struct eth_addr ea, *mac = NULL; |
21a955fc | 4347 | struct iface *hw_addr_iface; |
52df17e7 | 4348 | |
ddd43de9 HS |
4349 | if (strcmp(iface->type, "internal")) { |
4350 | return; | |
4351 | } | |
4352 | ||
74ff3298 JR |
4353 | if (iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, &ea)) { |
4354 | mac = &ea; | |
21a955fc HS |
4355 | } else if (port->cfg->fake_bridge) { |
4356 | /* Fake bridge and no MAC set in the configuration. Pick a local one. */ | |
74ff3298 JR |
4357 | find_local_hw_addr(br, &ea, port, &hw_addr_iface); |
4358 | mac = &ea; | |
ddd43de9 HS |
4359 | } |
4360 | ||
4361 | if (mac) { | |
892815f5 | 4362 | if (iface->ofp_port == OFPP_LOCAL) { |
ede2fd6d BP |
4363 | VLOG_ERR("interface %s: ignoring mac in Interface record " |
4364 | "(use Bridge record to set local port's mac)", | |
4365 | iface->name); | |
74ff3298 | 4366 | } else if (eth_addr_is_multicast(*mac)) { |
52df17e7 BP |
4367 | VLOG_ERR("interface %s: cannot set MAC to multicast address", |
4368 | iface->name); | |
52df17e7 | 4369 | } else { |
74ff3298 | 4370 | int error = netdev_set_etheraddr(iface->netdev, *mac); |
52df17e7 BP |
4371 | if (error) { |
4372 | VLOG_ERR("interface %s: setting MAC failed (%s)", | |
10a89ef0 | 4373 | iface->name, ovs_strerror(error)); |
52df17e7 BP |
4374 | } |
4375 | } | |
4376 | } | |
4377 | } | |
c1c9c9c4 | 4378 | |
bcd49a45 BP |
4379 | /* Sets the ofport column of 'if_cfg' to 'ofport'. */ |
4380 | static void | |
4e022ec0 | 4381 | iface_set_ofport(const struct ovsrec_interface *if_cfg, ofp_port_t ofport) |
bcd49a45 | 4382 | { |
cfea354b | 4383 | if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) { |
820b35a3 BP |
4384 | int64_t port = ofport == OFPP_NONE ? -1 : ofp_to_u16(ofport); |
4385 | ovsrec_interface_set_ofport(if_cfg, &port, 1); | |
bcd49a45 BP |
4386 | } |
4387 | } | |
4388 | ||
3fc5a86a BP |
4389 | /* Clears all of the fields in 'if_cfg' that indicate interface status, and |
4390 | * sets the "ofport" field to -1. | |
4391 | * | |
4392 | * This is appropriate when 'if_cfg''s interface cannot be created or is | |
4393 | * otherwise invalid. */ | |
4394 | static void | |
bbe6109d | 4395 | iface_clear_db_record(const struct ovsrec_interface *if_cfg, char *errp) |
3fc5a86a BP |
4396 | { |
4397 | if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) { | |
59804c80 | 4398 | iface_set_ofport(if_cfg, OFPP_NONE); |
bbe6109d | 4399 | ovsrec_interface_set_error(if_cfg, errp); |
a699f614 | 4400 | ovsrec_interface_set_status(if_cfg, NULL); |
3fc5a86a BP |
4401 | ovsrec_interface_set_admin_state(if_cfg, NULL); |
4402 | ovsrec_interface_set_duplex(if_cfg, NULL); | |
4403 | ovsrec_interface_set_link_speed(if_cfg, NULL, 0); | |
4404 | ovsrec_interface_set_link_state(if_cfg, NULL); | |
df867eda | 4405 | ovsrec_interface_set_mac_in_use(if_cfg, NULL); |
3fc5a86a BP |
4406 | ovsrec_interface_set_mtu(if_cfg, NULL, 0); |
4407 | ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0); | |
b9380396 | 4408 | ovsrec_interface_set_cfm_fault_status(if_cfg, NULL, 0); |
3fc5a86a BP |
4409 | ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0); |
4410 | ovsrec_interface_set_lacp_current(if_cfg, NULL, 0); | |
4411 | ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0); | |
ea401d9a | 4412 | ovsrec_interface_set_ifindex(if_cfg, NULL, 0); |
3fc5a86a BP |
4413 | } |
4414 | } | |
4415 | ||
c1c9c9c4 | 4416 | static bool |
44fca7f9 | 4417 | queue_ids_include(const struct ovsdb_datum *queues, int64_t target) |
c1c9c9c4 | 4418 | { |
44fca7f9 | 4419 | union ovsdb_atom atom; |
c1c9c9c4 | 4420 | |
44fca7f9 BP |
4421 | atom.integer = target; |
4422 | return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX; | |
c1c9c9c4 BP |
4423 | } |
4424 | ||
c1c9c9c4 | 4425 | static void |
66da9bef | 4426 | iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos) |
c1c9c9c4 | 4427 | { |
8b36f51e EJ |
4428 | struct ofpbuf queues_buf; |
4429 | ||
4430 | ofpbuf_init(&queues_buf, 0); | |
4431 | ||
677d9158 | 4432 | if (!qos || qos->type[0] == '\0') { |
c1c9c9c4 BP |
4433 | netdev_set_qos(iface->netdev, NULL, NULL); |
4434 | } else { | |
89454bf4 BP |
4435 | const struct ovsdb_datum *queues; |
4436 | struct netdev_queue_dump dump; | |
4437 | unsigned int queue_id; | |
4438 | struct smap details; | |
6a6e60bd | 4439 | bool queue_zero; |
c1c9c9c4 BP |
4440 | size_t i; |
4441 | ||
4442 | /* Configure top-level Qos for 'iface'. */ | |
a699f614 | 4443 | netdev_set_qos(iface->netdev, qos->type, &qos->other_config); |
c1c9c9c4 BP |
4444 | |
4445 | /* Deconfigure queues that were deleted. */ | |
89454bf4 BP |
4446 | queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER, |
4447 | OVSDB_TYPE_UUID); | |
4448 | smap_init(&details); | |
4449 | NETDEV_QUEUE_FOR_EACH (&queue_id, &details, &dump, iface->netdev) { | |
4450 | if (!queue_ids_include(queues, queue_id)) { | |
4451 | netdev_delete_queue(iface->netdev, queue_id); | |
4452 | } | |
4453 | } | |
4454 | smap_destroy(&details); | |
c1c9c9c4 BP |
4455 | |
4456 | /* Configure queues for 'iface'. */ | |
6a6e60bd | 4457 | queue_zero = false; |
c1c9c9c4 BP |
4458 | for (i = 0; i < qos->n_queues; i++) { |
4459 | const struct ovsrec_queue *queue = qos->value_queues[i]; | |
4460 | unsigned int queue_id = qos->key_queues[i]; | |
4461 | ||
6a6e60bd BP |
4462 | if (queue_id == 0) { |
4463 | queue_zero = true; | |
4464 | } | |
4465 | ||
8b36f51e EJ |
4466 | if (queue->n_dscp == 1) { |
4467 | struct ofproto_port_queue *port_queue; | |
4468 | ||
4469 | port_queue = ofpbuf_put_uninit(&queues_buf, | |
4470 | sizeof *port_queue); | |
4471 | port_queue->queue = queue_id; | |
4472 | port_queue->dscp = queue->dscp[0]; | |
4473 | } | |
4474 | ||
a699f614 | 4475 | netdev_set_queue(iface->netdev, queue_id, &queue->other_config); |
c1c9c9c4 | 4476 | } |
6a6e60bd | 4477 | if (!queue_zero) { |
a699f614 EJ |
4478 | struct smap details; |
4479 | ||
79f1cbe9 | 4480 | smap_init(&details); |
2c999774 | 4481 | netdev_set_queue(iface->netdev, 0, &details); |
79f1cbe9 | 4482 | smap_destroy(&details); |
6a6e60bd | 4483 | } |
c1c9c9c4 | 4484 | } |
fa066f01 | 4485 | |
c60c33fb | 4486 | if (iface->ofp_port != OFPP_NONE) { |
6fd6ed71 PS |
4487 | const struct ofproto_port_queue *port_queues = queues_buf.data; |
4488 | size_t n_queues = queues_buf.size / sizeof *port_queues; | |
8b36f51e EJ |
4489 | |
4490 | ofproto_port_set_queues(iface->port->bridge->ofproto, iface->ofp_port, | |
4491 | port_queues, n_queues); | |
4492 | } | |
4493 | ||
fa066f01 | 4494 | netdev_set_policing(iface->netdev, |
c7952afb BP |
4495 | MIN(UINT32_MAX, iface->cfg->ingress_policing_rate), |
4496 | MIN(UINT32_MAX, iface->cfg->ingress_policing_burst)); | |
8b36f51e EJ |
4497 | |
4498 | ofpbuf_uninit(&queues_buf); | |
c1c9c9c4 | 4499 | } |
b31bcf60 EJ |
4500 | |
4501 | static void | |
66da9bef | 4502 | iface_configure_cfm(struct iface *iface) |
b31bcf60 | 4503 | { |
93b8df38 | 4504 | const struct ovsrec_interface *cfg = iface->cfg; |
a699f614 | 4505 | const char *opstate_str; |
189cb9e4 | 4506 | const char *cfm_ccm_vlan; |
a5610457 | 4507 | struct cfm_settings s; |
b363bae4 | 4508 | struct smap netdev_args; |
b31bcf60 | 4509 | |
144216a3 | 4510 | if (!cfg->n_cfm_mpid) { |
892815f5 | 4511 | ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port); |
b31bcf60 EJ |
4512 | return; |
4513 | } | |
4514 | ||
b363bae4 EJ |
4515 | s.check_tnl_key = false; |
4516 | smap_init(&netdev_args); | |
4517 | if (!netdev_get_config(iface->netdev, &netdev_args)) { | |
4518 | const char *key = smap_get(&netdev_args, "key"); | |
4519 | const char *in_key = smap_get(&netdev_args, "in_key"); | |
4520 | ||
4521 | s.check_tnl_key = (key && !strcmp(key, "flow")) | |
4522 | || (in_key && !strcmp(in_key, "flow")); | |
4523 | } | |
4524 | smap_destroy(&netdev_args); | |
4525 | ||
a5610457 | 4526 | s.mpid = *cfg->cfm_mpid; |
a699f614 EJ |
4527 | s.interval = smap_get_int(&iface->cfg->other_config, "cfm_interval", 0); |
4528 | cfm_ccm_vlan = smap_get(&iface->cfg->other_config, "cfm_ccm_vlan"); | |
4529 | s.ccm_pcp = smap_get_int(&iface->cfg->other_config, "cfm_ccm_pcp", 0); | |
4530 | ||
a5610457 EJ |
4531 | if (s.interval <= 0) { |
4532 | s.interval = 1000; | |
b31bcf60 | 4533 | } |
b31bcf60 | 4534 | |
a699f614 EJ |
4535 | if (!cfm_ccm_vlan) { |
4536 | s.ccm_vlan = 0; | |
4537 | } else if (!strcasecmp("random", cfm_ccm_vlan)) { | |
189cb9e4 EJ |
4538 | s.ccm_vlan = CFM_RANDOM_VLAN; |
4539 | } else { | |
4540 | s.ccm_vlan = atoi(cfm_ccm_vlan); | |
4541 | if (s.ccm_vlan == CFM_RANDOM_VLAN) { | |
4542 | s.ccm_vlan = 0; | |
4543 | } | |
4544 | } | |
4545 | ||
a699f614 EJ |
4546 | s.extended = smap_get_bool(&iface->cfg->other_config, "cfm_extended", |
4547 | false); | |
90967e95 | 4548 | s.demand = smap_get_bool(&iface->cfg->other_config, "cfm_demand", false); |
ef9819b5 | 4549 | |
a699f614 EJ |
4550 | opstate_str = smap_get(&iface->cfg->other_config, "cfm_opstate"); |
4551 | s.opup = !opstate_str || !strcasecmp("up", opstate_str); | |
86dc6501 | 4552 | |
a5610457 | 4553 | ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s); |
b31bcf60 | 4554 | } |
0b8024eb | 4555 | |
cfea354b BP |
4556 | /* Returns true if 'iface' is synthetic, that is, if we constructed it locally |
4557 | * instead of obtaining it from the database. */ | |
4558 | static bool | |
4559 | iface_is_synthetic(const struct iface *iface) | |
4560 | { | |
4561 | return ovsdb_idl_row_is_synthetic(&iface->cfg->header_); | |
4562 | } | |
f125905c | 4563 | |
4e022ec0 | 4564 | static ofp_port_t |
4abb8608 BP |
4565 | iface_validate_ofport__(size_t n, int64_t *ofport) |
4566 | { | |
4567 | return (n && *ofport >= 1 && *ofport < ofp_to_u16(OFPP_MAX) | |
4568 | ? u16_to_ofp(*ofport) | |
4569 | : OFPP_NONE); | |
4570 | } | |
4571 | ||
4572 | static ofp_port_t | |
4573 | iface_get_requested_ofp_port(const struct ovsrec_interface *cfg) | |
558e2cc5 | 4574 | { |
4abb8608 | 4575 | return iface_validate_ofport__(cfg->n_ofport_request, cfg->ofport_request); |
558e2cc5 GS |
4576 | } |
4577 | ||
4abb8608 BP |
4578 | static ofp_port_t |
4579 | iface_pick_ofport(const struct ovsrec_interface *cfg) | |
4580 | { | |
4581 | ofp_port_t requested_ofport = iface_get_requested_ofp_port(cfg); | |
4582 | return (requested_ofport != OFPP_NONE | |
4583 | ? requested_ofport | |
4584 | : iface_validate_ofport__(cfg->n_ofport, cfg->ofport)); | |
4585 | } | |
064af421 BP |
4586 | \f |
4587 | /* Port mirroring. */ | |
4588 | ||
dd0d105c BP |
4589 | static struct mirror * |
4590 | mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid) | |
4591 | { | |
fa066f01 | 4592 | struct mirror *m; |
dd0d105c | 4593 | |
fa066f01 BP |
4594 | HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) { |
4595 | if (uuid_equals(uuid, &m->uuid)) { | |
dd0d105c BP |
4596 | return m; |
4597 | } | |
4598 | } | |
4599 | return NULL; | |
4600 | } | |
4601 | ||
064af421 | 4602 | static void |
fa066f01 | 4603 | bridge_configure_mirrors(struct bridge *br) |
064af421 | 4604 | { |
fa066f01 BP |
4605 | const struct ovsdb_datum *mc; |
4606 | unsigned long *flood_vlans; | |
4607 | struct mirror *m, *next; | |
4608 | size_t i; | |
064af421 | 4609 | |
dd0d105c | 4610 | /* Get rid of deleted mirrors. */ |
fa066f01 BP |
4611 | mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID); |
4612 | HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) { | |
4613 | union ovsdb_atom atom; | |
4614 | ||
4615 | atom.uuid = m->uuid; | |
4616 | if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) { | |
4617 | mirror_destroy(m); | |
064af421 BP |
4618 | } |
4619 | } | |
4620 | ||
dd0d105c | 4621 | /* Add new mirrors and reconfigure existing ones. */ |
37e7f427 | 4622 | for (i = 0; i < br->cfg->n_mirrors; i++) { |
fa066f01 | 4623 | const struct ovsrec_mirror *cfg = br->cfg->mirrors[i]; |
dd0d105c | 4624 | struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid); |
fa066f01 BP |
4625 | if (!m) { |
4626 | m = mirror_create(br, cfg); | |
064af421 | 4627 | } |
9d24de3b JP |
4628 | m->cfg = cfg; |
4629 | if (!mirror_configure(m)) { | |
fa066f01 | 4630 | mirror_destroy(m); |
064af421 BP |
4631 | } |
4632 | } | |
f2d7fd66 | 4633 | |
8f30d09a | 4634 | /* Update flooded vlans (for RSPAN). */ |
fa066f01 BP |
4635 | flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans, |
4636 | br->cfg->n_flood_vlans); | |
4637 | ofproto_set_flood_vlans(br->ofproto, flood_vlans); | |
4638 | bitmap_free(flood_vlans); | |
064af421 BP |
4639 | } |
4640 | ||
fa066f01 BP |
4641 | static struct mirror * |
4642 | mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg) | |
064af421 BP |
4643 | { |
4644 | struct mirror *m; | |
064af421 | 4645 | |
fa066f01 | 4646 | m = xzalloc(sizeof *m); |
8bbc128e | 4647 | m->uuid = cfg->header_.uuid; |
fa066f01 | 4648 | hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid)); |
064af421 | 4649 | m->bridge = br; |
dd0d105c | 4650 | m->name = xstrdup(cfg->name); |
37e7f427 | 4651 | |
fa066f01 | 4652 | return m; |
064af421 BP |
4653 | } |
4654 | ||
4655 | static void | |
4656 | mirror_destroy(struct mirror *m) | |
4657 | { | |
4658 | if (m) { | |
4659 | struct bridge *br = m->bridge; | |
064af421 | 4660 | |
fa066f01 BP |
4661 | if (br->ofproto) { |
4662 | ofproto_mirror_unregister(br->ofproto, m); | |
064af421 BP |
4663 | } |
4664 | ||
fa066f01 | 4665 | hmap_remove(&br->mirrors, &m->hmap_node); |
786880a5 | 4666 | free(m->name); |
064af421 | 4667 | free(m); |
064af421 BP |
4668 | } |
4669 | } | |
4670 | ||
4671 | static void | |
fa066f01 BP |
4672 | mirror_collect_ports(struct mirror *m, |
4673 | struct ovsrec_port **in_ports, int n_in_ports, | |
4674 | void ***out_portsp, size_t *n_out_portsp) | |
064af421 | 4675 | { |
fa066f01 BP |
4676 | void **out_ports = xmalloc(n_in_ports * sizeof *out_ports); |
4677 | size_t n_out_ports = 0; | |
064af421 BP |
4678 | size_t i; |
4679 | ||
fa066f01 BP |
4680 | for (i = 0; i < n_in_ports; i++) { |
4681 | const char *name = in_ports[i]->name; | |
4682 | struct port *port = port_lookup(m->bridge, name); | |
4683 | if (port) { | |
4684 | out_ports[n_out_ports++] = port; | |
064af421 | 4685 | } else { |
37e7f427 BP |
4686 | VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent " |
4687 | "port %s", m->bridge->name, m->name, name); | |
064af421 BP |
4688 | } |
4689 | } | |
fa066f01 BP |
4690 | *out_portsp = out_ports; |
4691 | *n_out_portsp = n_out_ports; | |
064af421 BP |
4692 | } |
4693 | ||
4694 | static bool | |
9d24de3b | 4695 | mirror_configure(struct mirror *m) |
064af421 | 4696 | { |
9d24de3b | 4697 | const struct ovsrec_mirror *cfg = m->cfg; |
fa066f01 | 4698 | struct ofproto_mirror_settings s; |
064af421 | 4699 | |
dd0d105c BP |
4700 | /* Set name. */ |
4701 | if (strcmp(cfg->name, m->name)) { | |
4702 | free(m->name); | |
4703 | m->name = xstrdup(cfg->name); | |
4704 | } | |
fa066f01 | 4705 | s.name = m->name; |
dd0d105c | 4706 | |
fa066f01 | 4707 | /* Get output port or VLAN. */ |
37e7f427 | 4708 | if (cfg->output_port) { |
fa066f01 | 4709 | s.out_bundle = port_lookup(m->bridge, cfg->output_port->name); |
abe529af | 4710 | if (!s.out_bundle) { |
37e7f427 BP |
4711 | VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge", |
4712 | m->bridge->name, m->name); | |
fa066f01 | 4713 | return false; |
064af421 | 4714 | } |
fa066f01 | 4715 | s.out_vlan = UINT16_MAX; |
064af421 | 4716 | |
37e7f427 BP |
4717 | if (cfg->output_vlan) { |
4718 | VLOG_ERR("bridge %s: mirror %s specifies both output port and " | |
4719 | "output vlan; ignoring output vlan", | |
4720 | m->bridge->name, m->name); | |
064af421 | 4721 | } |
37e7f427 | 4722 | } else if (cfg->output_vlan) { |
fa066f01 BP |
4723 | /* The database should prevent invalid VLAN values. */ |
4724 | s.out_bundle = NULL; | |
4725 | s.out_vlan = *cfg->output_vlan; | |
064af421 | 4726 | } else { |
37e7f427 BP |
4727 | VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring", |
4728 | m->bridge->name, m->name); | |
fa066f01 | 4729 | return false; |
064af421 BP |
4730 | } |
4731 | ||
fa066f01 | 4732 | /* Get port selection. */ |
939ff267 | 4733 | if (cfg->select_all) { |
fa066f01 BP |
4734 | size_t n_ports = hmap_count(&m->bridge->ports); |
4735 | void **ports = xmalloc(n_ports * sizeof *ports); | |
abe529af | 4736 | struct port *port; |
fa066f01 BP |
4737 | size_t i; |
4738 | ||
4739 | i = 0; | |
8052fb14 | 4740 | HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) { |
fa066f01 | 4741 | ports[i++] = port; |
939ff267 | 4742 | } |
fa066f01 BP |
4743 | |
4744 | s.srcs = ports; | |
4745 | s.n_srcs = n_ports; | |
4746 | ||
4747 | s.dsts = ports; | |
4748 | s.n_dsts = n_ports; | |
939ff267 | 4749 | } else { |
fa066f01 BP |
4750 | /* Get ports, dropping ports that don't exist. |
4751 | * The IDL ensures that there are no duplicates. */ | |
939ff267 | 4752 | mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port, |
fa066f01 | 4753 | &s.srcs, &s.n_srcs); |
939ff267 | 4754 | mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port, |
fa066f01 | 4755 | &s.dsts, &s.n_dsts); |
064af421 BP |
4756 | } |
4757 | ||
fa066f01 BP |
4758 | /* Get VLAN selection. */ |
4759 | s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan); | |
4760 | ||
4761 | /* Configure. */ | |
4762 | ofproto_mirror_register(m->bridge->ofproto, m, &s); | |
4763 | ||
064af421 | 4764 | /* Clean up. */ |
fa066f01 BP |
4765 | if (s.srcs != s.dsts) { |
4766 | free(s.dsts); | |
4767 | } | |
4768 | free(s.srcs); | |
4769 | free(s.src_vlans); | |
4770 | ||
4771 | return true; | |
064af421 | 4772 | } |
52a90c29 BP |
4773 | \f |
4774 | /* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.) | |
4775 | * | |
4776 | * This is deprecated. It is only for compatibility with broken device drivers | |
4777 | * in old versions of Linux that do not properly support VLANs when VLAN | |
4778 | * devices are not used. When broken device drivers are no longer in | |
4779 | * widespread use, we will delete these interfaces. */ | |
4780 | ||
37344ffa EJ |
4781 | static struct ovsrec_port **recs; |
4782 | static size_t n_recs, allocated_recs; | |
52a90c29 | 4783 | |
37344ffa EJ |
4784 | /* Adds 'rec' to a list of recs that have to be destroyed when the VLAN |
4785 | * splinters are reconfigured. */ | |
52a90c29 | 4786 | static void |
37344ffa | 4787 | register_rec(struct ovsrec_port *rec) |
52a90c29 | 4788 | { |
37344ffa EJ |
4789 | if (n_recs >= allocated_recs) { |
4790 | recs = x2nrealloc(recs, &allocated_recs, sizeof *recs); | |
52a90c29 | 4791 | } |
37344ffa | 4792 | recs[n_recs++] = rec; |
52a90c29 BP |
4793 | } |
4794 | ||
37344ffa | 4795 | /* Frees all of the ports registered with register_reg(). */ |
52a90c29 | 4796 | static void |
37344ffa | 4797 | free_registered_recs(void) |
52a90c29 BP |
4798 | { |
4799 | size_t i; | |
4800 | ||
37344ffa EJ |
4801 | for (i = 0; i < n_recs; i++) { |
4802 | struct ovsrec_port *port = recs[i]; | |
4803 | size_t j; | |
4804 | ||
4805 | for (j = 0; j < port->n_interfaces; j++) { | |
4806 | struct ovsrec_interface *iface = port->interfaces[j]; | |
4807 | free(iface->name); | |
4808 | free(iface); | |
4809 | } | |
4810 | ||
a699f614 | 4811 | smap_destroy(&port->other_config); |
37344ffa EJ |
4812 | free(port->interfaces); |
4813 | free(port->name); | |
4814 | free(port->tag); | |
37344ffa | 4815 | free(port); |
52a90c29 | 4816 | } |
37344ffa | 4817 | n_recs = 0; |
52a90c29 BP |
4818 | } |
4819 | ||
4820 | /* Returns true if VLAN splinters are enabled on 'iface_cfg', false | |
4821 | * otherwise. */ | |
4822 | static bool | |
4823 | vlan_splinters_is_enabled(const struct ovsrec_interface *iface_cfg) | |
4824 | { | |
a699f614 EJ |
4825 | return smap_get_bool(&iface_cfg->other_config, "enable-vlan-splinters", |
4826 | false); | |
52a90c29 BP |
4827 | } |
4828 | ||
4829 | /* Figures out the set of VLANs that are in use for the purpose of VLAN | |
4830 | * splinters. | |
4831 | * | |
4832 | * If VLAN splinters are enabled on at least one interface and any VLANs are in | |
4833 | * use, returns a 4096-bit bitmap with a 1-bit for each in-use VLAN (bits 0 and | |
4834 | * 4095 will not be set). The caller is responsible for freeing the bitmap, | |
4835 | * with free(). | |
4836 | * | |
4837 | * If VLANs splinters are not enabled on any interface or if no VLANs are in | |
4838 | * use, returns NULL. | |
4839 | * | |
4840 | * Updates 'vlan_splinters_enabled_anywhere'. */ | |
4841 | static unsigned long int * | |
4842 | collect_splinter_vlans(const struct ovsrec_open_vswitch *ovs_cfg) | |
4843 | { | |
4844 | unsigned long int *splinter_vlans; | |
4845 | struct sset splinter_ifaces; | |
4846 | const char *real_dev_name; | |
4847 | struct shash *real_devs; | |
4848 | struct shash_node *node; | |
4849 | struct bridge *br; | |
4850 | size_t i; | |
4851 | ||
7c70698f BP |
4852 | /* Free space allocated for synthesized ports and interfaces, since we're |
4853 | * in the process of reconstructing all of them. */ | |
37344ffa | 4854 | free_registered_recs(); |
7c70698f | 4855 | |
45c580a3 | 4856 | splinter_vlans = bitmap_allocate(4096); |
52a90c29 | 4857 | sset_init(&splinter_ifaces); |
45c580a3 | 4858 | vlan_splinters_enabled_anywhere = false; |
52a90c29 BP |
4859 | for (i = 0; i < ovs_cfg->n_bridges; i++) { |
4860 | struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i]; | |
4861 | size_t j; | |
4862 | ||
4863 | for (j = 0; j < br_cfg->n_ports; j++) { | |
4864 | struct ovsrec_port *port_cfg = br_cfg->ports[j]; | |
4865 | int k; | |
4866 | ||
4867 | for (k = 0; k < port_cfg->n_interfaces; k++) { | |
4868 | struct ovsrec_interface *iface_cfg = port_cfg->interfaces[k]; | |
4869 | ||
4870 | if (vlan_splinters_is_enabled(iface_cfg)) { | |
45c580a3 | 4871 | vlan_splinters_enabled_anywhere = true; |
52a90c29 | 4872 | sset_add(&splinter_ifaces, iface_cfg->name); |
52a90c29 BP |
4873 | vlan_bitmap_from_array__(port_cfg->trunks, |
4874 | port_cfg->n_trunks, | |
4875 | splinter_vlans); | |
4876 | } | |
4877 | } | |
45c580a3 BP |
4878 | |
4879 | if (port_cfg->tag && *port_cfg->tag > 0 && *port_cfg->tag < 4095) { | |
4880 | bitmap_set1(splinter_vlans, *port_cfg->tag); | |
4881 | } | |
52a90c29 BP |
4882 | } |
4883 | } | |
4884 | ||
45c580a3 BP |
4885 | if (!vlan_splinters_enabled_anywhere) { |
4886 | free(splinter_vlans); | |
52a90c29 BP |
4887 | sset_destroy(&splinter_ifaces); |
4888 | return NULL; | |
4889 | } | |
4890 | ||
4891 | HMAP_FOR_EACH (br, node, &all_bridges) { | |
4892 | if (br->ofproto) { | |
4893 | ofproto_get_vlan_usage(br->ofproto, splinter_vlans); | |
4894 | } | |
4895 | } | |
4896 | ||
4897 | /* Don't allow VLANs 0 or 4095 to be splintered. VLAN 0 should appear on | |
4898 | * the real device. VLAN 4095 is reserved and Linux doesn't allow a VLAN | |
4899 | * device to be created for it. */ | |
4900 | bitmap_set0(splinter_vlans, 0); | |
4901 | bitmap_set0(splinter_vlans, 4095); | |
4902 | ||
4903 | /* Delete all VLAN devices that we don't need. */ | |
4904 | vlandev_refresh(); | |
4905 | real_devs = vlandev_get_real_devs(); | |
4906 | SHASH_FOR_EACH (node, real_devs) { | |
4907 | const struct vlan_real_dev *real_dev = node->data; | |
4908 | const struct vlan_dev *vlan_dev; | |
4909 | bool real_dev_has_splinters; | |
4910 | ||
4911 | real_dev_has_splinters = sset_contains(&splinter_ifaces, | |
4912 | real_dev->name); | |
4913 | HMAP_FOR_EACH (vlan_dev, hmap_node, &real_dev->vlan_devs) { | |
4914 | if (!real_dev_has_splinters | |
4915 | || !bitmap_is_set(splinter_vlans, vlan_dev->vid)) { | |
4916 | struct netdev *netdev; | |
4917 | ||
4918 | if (!netdev_open(vlan_dev->name, "system", &netdev)) { | |
4919 | if (!netdev_get_in4(netdev, NULL, NULL) || | |
4920 | !netdev_get_in6(netdev, NULL)) { | |
52a90c29 BP |
4921 | /* It has an IP address configured, so we don't own |
4922 | * it. Don't delete it. */ | |
b41c3e5c AW |
4923 | } else { |
4924 | vlandev_del(vlan_dev->name); | |
52a90c29 BP |
4925 | } |
4926 | netdev_close(netdev); | |
4927 | } | |
4928 | } | |
4929 | ||
4930 | } | |
4931 | } | |
4932 | ||
4933 | /* Add all VLAN devices that we need. */ | |
4934 | SSET_FOR_EACH (real_dev_name, &splinter_ifaces) { | |
4935 | int vid; | |
4936 | ||
4937 | BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) { | |
4938 | if (!vlandev_get_name(real_dev_name, vid)) { | |
4939 | vlandev_add(real_dev_name, vid); | |
4940 | } | |
4941 | } | |
4942 | } | |
4943 | ||
4944 | vlandev_refresh(); | |
4945 | ||
4946 | sset_destroy(&splinter_ifaces); | |
4947 | ||
b71273f6 | 4948 | if (bitmap_scan(splinter_vlans, 1, 0, 4096) >= 4096) { |
52a90c29 BP |
4949 | free(splinter_vlans); |
4950 | return NULL; | |
4951 | } | |
4952 | return splinter_vlans; | |
4953 | } | |
4954 | ||
4955 | /* Pushes the configure of VLAN splinter port 'port' (e.g. eth0.9) down to | |
4956 | * ofproto. */ | |
4957 | static void | |
4958 | configure_splinter_port(struct port *port) | |
4959 | { | |
4960 | struct ofproto *ofproto = port->bridge->ofproto; | |
4e022ec0 | 4961 | ofp_port_t realdev_ofp_port; |
52a90c29 BP |
4962 | const char *realdev_name; |
4963 | struct iface *vlandev, *realdev; | |
4964 | ||
4965 | ofproto_bundle_unregister(port->bridge->ofproto, port); | |
4966 | ||
4967 | vlandev = CONTAINER_OF(list_front(&port->ifaces), struct iface, | |
4968 | port_elem); | |
4969 | ||
a699f614 | 4970 | realdev_name = smap_get(&port->cfg->other_config, "realdev"); |
52a90c29 BP |
4971 | realdev = iface_lookup(port->bridge, realdev_name); |
4972 | realdev_ofp_port = realdev ? realdev->ofp_port : 0; | |
4973 | ||
4974 | ofproto_port_set_realdev(ofproto, vlandev->ofp_port, realdev_ofp_port, | |
4975 | *port->cfg->tag); | |
4976 | } | |
4977 | ||
4978 | static struct ovsrec_port * | |
4979 | synthesize_splinter_port(const char *real_dev_name, | |
4980 | const char *vlan_dev_name, int vid) | |
4981 | { | |
4982 | struct ovsrec_interface *iface; | |
4983 | struct ovsrec_port *port; | |
4984 | ||
a699f614 EJ |
4985 | iface = xmalloc(sizeof *iface); |
4986 | ovsrec_interface_init(iface); | |
52a90c29 BP |
4987 | iface->name = xstrdup(vlan_dev_name); |
4988 | iface->type = "system"; | |
4989 | ||
a699f614 EJ |
4990 | port = xmalloc(sizeof *port); |
4991 | ovsrec_port_init(port); | |
52a90c29 BP |
4992 | port->interfaces = xmemdup(&iface, sizeof iface); |
4993 | port->n_interfaces = 1; | |
4994 | port->name = xstrdup(vlan_dev_name); | |
4995 | port->vlan_mode = "splinter"; | |
4996 | port->tag = xmalloc(sizeof *port->tag); | |
4997 | *port->tag = vid; | |
a699f614 EJ |
4998 | |
4999 | smap_add(&port->other_config, "realdev", real_dev_name); | |
52a90c29 | 5000 | |
37344ffa | 5001 | register_rec(port); |
52a90c29 BP |
5002 | return port; |
5003 | } | |
5004 | ||
5005 | /* For each interface with 'br' that has VLAN splinters enabled, adds a | |
5006 | * corresponding ovsrec_port to 'ports' for each splinter VLAN marked with a | |
5007 | * 1-bit in the 'splinter_vlans' bitmap. */ | |
5008 | static void | |
5009 | add_vlan_splinter_ports(struct bridge *br, | |
5010 | const unsigned long int *splinter_vlans, | |
5011 | struct shash *ports) | |
5012 | { | |
5013 | size_t i; | |
5014 | ||
52a90c29 BP |
5015 | /* We iterate through 'br->cfg->ports' instead of 'ports' here because |
5016 | * we're modifying 'ports'. */ | |
5017 | for (i = 0; i < br->cfg->n_ports; i++) { | |
5018 | const char *name = br->cfg->ports[i]->name; | |
5019 | struct ovsrec_port *port_cfg = shash_find_data(ports, name); | |
5020 | size_t j; | |
5021 | ||
5022 | for (j = 0; j < port_cfg->n_interfaces; j++) { | |
5023 | struct ovsrec_interface *iface_cfg = port_cfg->interfaces[j]; | |
5024 | ||
5025 | if (vlan_splinters_is_enabled(iface_cfg)) { | |
5026 | const char *real_dev_name; | |
5027 | uint16_t vid; | |
5028 | ||
5029 | real_dev_name = iface_cfg->name; | |
5030 | BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) { | |
5031 | const char *vlan_dev_name; | |
5032 | ||
5033 | vlan_dev_name = vlandev_get_name(real_dev_name, vid); | |
5034 | if (vlan_dev_name | |
5035 | && !shash_find(ports, vlan_dev_name)) { | |
5036 | shash_add(ports, vlan_dev_name, | |
5037 | synthesize_splinter_port( | |
5038 | real_dev_name, vlan_dev_name, vid)); | |
5039 | } | |
5040 | } | |
5041 | } | |
5042 | } | |
5043 | } | |
5044 | } | |
9d24de3b JP |
5045 | |
5046 | static void | |
5047 | mirror_refresh_stats(struct mirror *m) | |
5048 | { | |
5049 | struct ofproto *ofproto = m->bridge->ofproto; | |
5050 | uint64_t tx_packets, tx_bytes; | |
47058293 | 5051 | const char *keys[2]; |
9d24de3b JP |
5052 | int64_t values[2]; |
5053 | size_t stat_cnt = 0; | |
5054 | ||
5055 | if (ofproto_mirror_get_stats(ofproto, m, &tx_packets, &tx_bytes)) { | |
5056 | ovsrec_mirror_set_statistics(m->cfg, NULL, NULL, 0); | |
5057 | return; | |
5058 | } | |
5059 | ||
5060 | if (tx_packets != UINT64_MAX) { | |
5061 | keys[stat_cnt] = "tx_packets"; | |
5062 | values[stat_cnt] = tx_packets; | |
5063 | stat_cnt++; | |
5064 | } | |
5065 | if (tx_bytes != UINT64_MAX) { | |
5066 | keys[stat_cnt] = "tx_bytes"; | |
5067 | values[stat_cnt] = tx_bytes; | |
5068 | stat_cnt++; | |
5069 | } | |
5070 | ||
5071 | ovsrec_mirror_set_statistics(m->cfg, keys, values, stat_cnt); | |
5072 | } | |
842733c3 MG |
5073 | |
5074 | /* | |
5075 | * Add registered netdev and dpif types to ovsdb to allow external | |
5076 | * applications to query the capabilities of the Open vSwitch instance | |
5077 | * running on the node. | |
5078 | */ | |
5079 | static void | |
5080 | discover_types(const struct ovsrec_open_vswitch *cfg) | |
5081 | { | |
5082 | struct sset types; | |
5083 | ||
5084 | /* Datapath types. */ | |
5085 | sset_init(&types); | |
5086 | dp_enumerate_types(&types); | |
5087 | const char **datapath_types = sset_array(&types); | |
5088 | ovsrec_open_vswitch_set_datapath_types(cfg, datapath_types, | |
5089 | sset_count(&types)); | |
5090 | free(datapath_types); | |
5091 | sset_destroy(&types); | |
5092 | ||
5093 | /* Port types. */ | |
5094 | sset_init(&types); | |
5095 | netdev_enumerate_types(&types); | |
5096 | const char **iface_types = sset_array(&types); | |
5097 | ovsrec_open_vswitch_set_iface_types(cfg, iface_types, sset_count(&types)); | |
5098 | free(iface_types); | |
5099 | sset_destroy(&types); | |
5100 | } |