block/qcow2-snapshot.c

   1 /*
   2  * Block driver for the QCOW version 2 format
   3  *
   4  * Copyright (c) 2004-2006 Fabrice Bellard
   5  *
   6  * Permission is hereby granted, free of charge, to any person obtaining a copy
   7  * of this software and associated documentation files (the "Software"), to deal
   8  * in the Software without restriction, including without limitation the rights
   9  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  10  * copies of the Software, and to permit persons to whom the Software is
  11  * furnished to do so, subject to the following conditions:
  12  *
  13  * The above copyright notice and this permission notice shall be included in
  14  * all copies or substantial portions of the Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  21  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  22  * THE SOFTWARE.
  23  */
  24
  25 #include "qemu/osdep.h"
  26 #include "qapi/error.h"
  27 #include "block/block_int.h"
  28 #include "qcow2.h"
  29 #include "qemu/bswap.h"
  30 #include "qemu/error-report.h"
  31 #include "qemu/cutils.h"
  32
  33 void qcow2_free_snapshots(BlockDriverState *bs)
  34 {
  35     BDRVQcow2State *s = bs->opaque;
  36     int i;
  37
  38     for(i = 0; i < s->nb_snapshots; i++) {
  39         g_free(s->snapshots[i].name);
  40         g_free(s->snapshots[i].id_str);
  41     }
  42     g_free(s->snapshots);
  43     s->snapshots = NULL;
  44     s->nb_snapshots = 0;
  45 }
  46
  47 int qcow2_read_snapshots(BlockDriverState *bs)
  48 {
  49     BDRVQcow2State *s = bs->opaque;
  50     QCowSnapshotHeader h;
  51     QCowSnapshotExtraData extra;
  52     QCowSnapshot *sn;
  53     int i, id_str_size, name_size;
  54     int64_t offset;
  55     uint32_t extra_data_size;
  56     int ret;
  57
  58     if (!s->nb_snapshots) {
  59         s->snapshots = NULL;
  60         s->snapshots_size = 0;
  61         return 0;
  62     }
  63
  64     offset = s->snapshots_offset;
  65     s->snapshots = g_new0(QCowSnapshot, s->nb_snapshots);
  66
  67     for(i = 0; i < s->nb_snapshots; i++) {
  68         /* Read statically sized part of the snapshot header */
  69         offset = ROUND_UP(offset, 8);
  70         ret = bdrv_pread(bs->file, offset, &h, sizeof(h));
  71         if (ret < 0) {
  72             goto fail;
  73         }
  74
  75         offset += sizeof(h);
  76         sn = s->snapshots + i;
  77         sn->l1_table_offset = be64_to_cpu(h.l1_table_offset);
  78         sn->l1_size = be32_to_cpu(h.l1_size);
  79         sn->vm_state_size = be32_to_cpu(h.vm_state_size);
  80         sn->date_sec = be32_to_cpu(h.date_sec);
  81         sn->date_nsec = be32_to_cpu(h.date_nsec);
  82         sn->vm_clock_nsec = be64_to_cpu(h.vm_clock_nsec);
  83         extra_data_size = be32_to_cpu(h.extra_data_size);
  84
  85         id_str_size = be16_to_cpu(h.id_str_size);
  86         name_size = be16_to_cpu(h.name_size);
  87
  88         /* Read extra data */
  89         ret = bdrv_pread(bs->file, offset, &extra,
  90                          MIN(sizeof(extra), extra_data_size));
  91         if (ret < 0) {
  92             goto fail;
  93         }
  94         offset += extra_data_size;
  95
  96         if (extra_data_size >= 8) {
  97             sn->vm_state_size = be64_to_cpu(extra.vm_state_size_large);
  98         }
  99
 100         if (extra_data_size >= 16) {
 101             sn->disk_size = be64_to_cpu(extra.disk_size);
 102         } else {
 103             sn->disk_size = bs->total_sectors * BDRV_SECTOR_SIZE;
 104         }
 105
 106         /* Read snapshot ID */
 107         sn->id_str = g_malloc(id_str_size + 1);
 108         ret = bdrv_pread(bs->file, offset, sn->id_str, id_str_size);
 109         if (ret < 0) {
 110             goto fail;
 111         }
 112         offset += id_str_size;
 113         sn->id_str[id_str_size] = '\0';
 114
 115         /* Read snapshot name */
 116         sn->name = g_malloc(name_size + 1);
 117         ret = bdrv_pread(bs->file, offset, sn->name, name_size);
 118         if (ret < 0) {
 119             goto fail;
 120         }
 121         offset += name_size;
 122         sn->name[name_size] = '\0';
 123
 124         if (offset - s->snapshots_offset > QCOW_MAX_SNAPSHOTS_SIZE) {
 125             ret = -EFBIG;
 126             goto fail;
 127         }
 128     }
 129
 130     assert(offset - s->snapshots_offset <= INT_MAX);
 131     s->snapshots_size = offset - s->snapshots_offset;
 132     return 0;
 133
 134 fail:
 135     qcow2_free_snapshots(bs);
 136     return ret;
 137 }
 138
 139 /* add at the end of the file a new list of snapshots */
 140 static int qcow2_write_snapshots(BlockDriverState *bs)
 141 {
 142     BDRVQcow2State *s = bs->opaque;
 143     QCowSnapshot *sn;
 144     QCowSnapshotHeader h;
 145     QCowSnapshotExtraData extra;
 146     int i, name_size, id_str_size, snapshots_size;
 147     struct {
 148         uint32_t nb_snapshots;
 149         uint64_t snapshots_offset;
 150     } QEMU_PACKED header_data;
 151     int64_t offset, snapshots_offset = 0;
 152     int ret;
 153
 154     /* compute the size of the snapshots */
 155     offset = 0;
 156     for(i = 0; i < s->nb_snapshots; i++) {
 157         sn = s->snapshots + i;
 158         offset = ROUND_UP(offset, 8);
 159         offset += sizeof(h);
 160         offset += sizeof(extra);
 161         offset += strlen(sn->id_str);
 162         offset += strlen(sn->name);
 163
 164         if (offset > QCOW_MAX_SNAPSHOTS_SIZE) {
 165             ret = -EFBIG;
 166             goto fail;
 167         }
 168     }
 169
 170     assert(offset <= INT_MAX);
 171     snapshots_size = offset;
 172
 173     /* Allocate space for the new snapshot list */
 174     snapshots_offset = qcow2_alloc_clusters(bs, snapshots_size);
 175     offset = snapshots_offset;
 176     if (offset < 0) {
 177         ret = offset;
 178         goto fail;
 179     }
 180     ret = bdrv_flush(bs);
 181     if (ret < 0) {
 182         goto fail;
 183     }
 184
 185     /* The snapshot list position has not yet been updated, so these clusters
 186      * must indeed be completely free */
 187     ret = qcow2_pre_write_overlap_check(bs, 0, offset, snapshots_size);
 188     if (ret < 0) {
 189         goto fail;
 190     }
 191
 192
 193     /* Write all snapshots to the new list */
 194     for(i = 0; i < s->nb_snapshots; i++) {
 195         sn = s->snapshots + i;
 196         memset(&h, 0, sizeof(h));
 197         h.l1_table_offset = cpu_to_be64(sn->l1_table_offset);
 198         h.l1_size = cpu_to_be32(sn->l1_size);
 199         /* If it doesn't fit in 32 bit, older implementations should treat it
 200          * as a disk-only snapshot rather than truncate the VM state */
 201         if (sn->vm_state_size <= 0xffffffff) {
 202             h.vm_state_size = cpu_to_be32(sn->vm_state_size);
 203         }
 204         h.date_sec = cpu_to_be32(sn->date_sec);
 205         h.date_nsec = cpu_to_be32(sn->date_nsec);
 206         h.vm_clock_nsec = cpu_to_be64(sn->vm_clock_nsec);
 207         h.extra_data_size = cpu_to_be32(sizeof(extra));
 208
 209         memset(&extra, 0, sizeof(extra));
 210         extra.vm_state_size_large = cpu_to_be64(sn->vm_state_size);
 211         extra.disk_size = cpu_to_be64(sn->disk_size);
 212
 213         id_str_size = strlen(sn->id_str);
 214         name_size = strlen(sn->name);
 215         assert(id_str_size <= UINT16_MAX && name_size <= UINT16_MAX);
 216         h.id_str_size = cpu_to_be16(id_str_size);
 217         h.name_size = cpu_to_be16(name_size);
 218         offset = ROUND_UP(offset, 8);
 219
 220         ret = bdrv_pwrite(bs->file, offset, &h, sizeof(h));
 221         if (ret < 0) {
 222             goto fail;
 223         }
 224         offset += sizeof(h);
 225
 226         ret = bdrv_pwrite(bs->file, offset, &extra, sizeof(extra));
 227         if (ret < 0) {
 228             goto fail;
 229         }
 230         offset += sizeof(extra);
 231
 232         ret = bdrv_pwrite(bs->file, offset, sn->id_str, id_str_size);
 233         if (ret < 0) {
 234             goto fail;
 235         }
 236         offset += id_str_size;
 237
 238         ret = bdrv_pwrite(bs->file, offset, sn->name, name_size);
 239         if (ret < 0) {
 240             goto fail;
 241         }
 242         offset += name_size;
 243     }
 244
 245     /*
 246      * Update the header to point to the new snapshot table. This requires the
 247      * new table and its refcounts to be stable on disk.
 248      */
 249     ret = bdrv_flush(bs);
 250     if (ret < 0) {
 251         goto fail;
 252     }
 253
 254     QEMU_BUILD_BUG_ON(offsetof(QCowHeader, snapshots_offset) !=
 255         offsetof(QCowHeader, nb_snapshots) + sizeof(header_data.nb_snapshots));
 256
 257     header_data.nb_snapshots        = cpu_to_be32(s->nb_snapshots);
 258     header_data.snapshots_offset    = cpu_to_be64(snapshots_offset);
 259
 260     ret = bdrv_pwrite_sync(bs->file, offsetof(QCowHeader, nb_snapshots),
 261                            &header_data, sizeof(header_data));
 262     if (ret < 0) {
 263         goto fail;
 264     }
 265
 266     /* free the old snapshot table */
 267     qcow2_free_clusters(bs, s->snapshots_offset, s->snapshots_size,
 268                         QCOW2_DISCARD_SNAPSHOT);
 269     s->snapshots_offset = snapshots_offset;
 270     s->snapshots_size = snapshots_size;
 271     return 0;
 272
 273 fail:
 274     if (snapshots_offset > 0) {
 275         qcow2_free_clusters(bs, snapshots_offset, snapshots_size,
 276                             QCOW2_DISCARD_ALWAYS);
 277     }
 278     return ret;
 279 }
 280
 281 static void find_new_snapshot_id(BlockDriverState *bs,
 282                                  char *id_str, int id_str_size)
 283 {
 284     BDRVQcow2State *s = bs->opaque;
 285     QCowSnapshot *sn;
 286     int i;
 287     unsigned long id, id_max = 0;
 288
 289     for(i = 0; i < s->nb_snapshots; i++) {
 290         sn = s->snapshots + i;
 291         id = strtoul(sn->id_str, NULL, 10);
 292         if (id > id_max)
 293             id_max = id;
 294     }
 295     snprintf(id_str, id_str_size, "%lu", id_max + 1);
 296 }
 297
 298 static int find_snapshot_by_id_and_name(BlockDriverState *bs,
 299                                         const char *id,
 300                                         const char *name)
 301 {
 302     BDRVQcow2State *s = bs->opaque;
 303     int i;
 304
 305     if (id && name) {
 306         for (i = 0; i < s->nb_snapshots; i++) {
 307             if (!strcmp(s->snapshots[i].id_str, id) &&
 308                 !strcmp(s->snapshots[i].name, name)) {
 309                 return i;
 310             }
 311         }
 312     } else if (id) {
 313         for (i = 0; i < s->nb_snapshots; i++) {
 314             if (!strcmp(s->snapshots[i].id_str, id)) {
 315                 return i;
 316             }
 317         }
 318     } else if (name) {
 319         for (i = 0; i < s->nb_snapshots; i++) {
 320             if (!strcmp(s->snapshots[i].name, name)) {
 321                 return i;
 322             }
 323         }
 324     }
 325
 326     return -1;
 327 }
 328
 329 static int find_snapshot_by_id_or_name(BlockDriverState *bs,
 330                                        const char *id_or_name)
 331 {
 332     int ret;
 333
 334     ret = find_snapshot_by_id_and_name(bs, id_or_name, NULL);
 335     if (ret >= 0) {
 336         return ret;
 337     }
 338     return find_snapshot_by_id_and_name(bs, NULL, id_or_name);
 339 }
 340
 341 /* if no id is provided, a new one is constructed */
 342 int qcow2_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
 343 {
 344     BDRVQcow2State *s = bs->opaque;
 345     QCowSnapshot *new_snapshot_list = NULL;
 346     QCowSnapshot *old_snapshot_list = NULL;
 347     QCowSnapshot sn1, *sn = &sn1;
 348     int i, ret;
 349     uint64_t *l1_table = NULL;
 350     int64_t l1_table_offset;
 351
 352     if (s->nb_snapshots >= QCOW_MAX_SNAPSHOTS) {
 353         return -EFBIG;
 354     }
 355
 356     memset(sn, 0, sizeof(*sn));
 357
 358     /* Generate an ID */
 359     find_new_snapshot_id(bs, sn_info->id_str, sizeof(sn_info->id_str));
 360
 361     /* Populate sn with passed data */
 362     sn->id_str = g_strdup(sn_info->id_str);
 363     sn->name = g_strdup(sn_info->name);
 364
 365     sn->disk_size = bs->total_sectors * BDRV_SECTOR_SIZE;
 366     sn->vm_state_size = sn_info->vm_state_size;
 367     sn->date_sec = sn_info->date_sec;
 368     sn->date_nsec = sn_info->date_nsec;
 369     sn->vm_clock_nsec = sn_info->vm_clock_nsec;
 370
 371     /* Allocate the L1 table of the snapshot and copy the current one there. */
 372     l1_table_offset = qcow2_alloc_clusters(bs, s->l1_size * sizeof(uint64_t));
 373     if (l1_table_offset < 0) {
 374         ret = l1_table_offset;
 375         goto fail;
 376     }
 377
 378     sn->l1_table_offset = l1_table_offset;
 379     sn->l1_size = s->l1_size;
 380
 381     l1_table = g_try_new(uint64_t, s->l1_size);
 382     if (s->l1_size && l1_table == NULL) {
 383         ret = -ENOMEM;
 384         goto fail;
 385     }
 386
 387     for(i = 0; i < s->l1_size; i++) {
 388         l1_table[i] = cpu_to_be64(s->l1_table[i]);
 389     }
 390
 391     ret = qcow2_pre_write_overlap_check(bs, 0, sn->l1_table_offset,
 392                                         s->l1_size * sizeof(uint64_t));
 393     if (ret < 0) {
 394         goto fail;
 395     }
 396
 397     ret = bdrv_pwrite(bs->file, sn->l1_table_offset, l1_table,
 398                       s->l1_size * sizeof(uint64_t));
 399     if (ret < 0) {
 400         goto fail;
 401     }
 402
 403     g_free(l1_table);
 404     l1_table = NULL;
 405
 406     /*
 407      * Increase the refcounts of all clusters and make sure everything is
 408      * stable on disk before updating the snapshot table to contain a pointer
 409      * to the new L1 table.
 410      */
 411     ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, 1);
 412     if (ret < 0) {
 413         goto fail;
 414     }
 415
 416     /* Append the new snapshot to the snapshot list */
 417     new_snapshot_list = g_new(QCowSnapshot, s->nb_snapshots + 1);
 418     if (s->snapshots) {
 419         memcpy(new_snapshot_list, s->snapshots,
 420                s->nb_snapshots * sizeof(QCowSnapshot));
 421         old_snapshot_list = s->snapshots;
 422     }
 423     s->snapshots = new_snapshot_list;
 424     s->snapshots[s->nb_snapshots++] = *sn;
 425
 426     ret = qcow2_write_snapshots(bs);
 427     if (ret < 0) {
 428         g_free(s->snapshots);
 429         s->snapshots = old_snapshot_list;
 430         s->nb_snapshots--;
 431         goto fail;
 432     }
 433
 434     g_free(old_snapshot_list);
 435
 436     /* The VM state isn't needed any more in the active L1 table; in fact, it
 437      * hurts by causing expensive COW for the next snapshot. */
 438     qcow2_cluster_discard(bs, qcow2_vm_state_offset(s),
 439                           ROUND_UP(sn->vm_state_size, s->cluster_size),
 440                           QCOW2_DISCARD_NEVER, false);
 441
 442 #ifdef DEBUG_ALLOC
 443     {
 444       BdrvCheckResult result = {0};
 445       qcow2_check_refcounts(bs, &result, 0);
 446     }
 447 #endif
 448     return 0;
 449
 450 fail:
 451     g_free(sn->id_str);
 452     g_free(sn->name);
 453     g_free(l1_table);
 454
 455     return ret;
 456 }
 457
 458 /* copy the snapshot 'snapshot_name' into the current disk image */
 459 int qcow2_snapshot_goto(BlockDriverState *bs, const char *snapshot_id)
 460 {
 461     BDRVQcow2State *s = bs->opaque;
 462     QCowSnapshot *sn;
 463     Error *local_err = NULL;
 464     int i, snapshot_index;
 465     int cur_l1_bytes, sn_l1_bytes;
 466     int ret;
 467     uint64_t *sn_l1_table = NULL;
 468
 469     /* Search the snapshot */
 470     snapshot_index = find_snapshot_by_id_or_name(bs, snapshot_id);
 471     if (snapshot_index < 0) {
 472         return -ENOENT;
 473     }
 474     sn = &s->snapshots[snapshot_index];
 475
 476     ret = qcow2_validate_table(bs, sn->l1_table_offset, sn->l1_size,
 477                                sizeof(uint64_t), QCOW_MAX_L1_SIZE,
 478                                "Snapshot L1 table", &local_err);
 479     if (ret < 0) {
 480         error_report_err(local_err);
 481         goto fail;
 482     }
 483
 484     if (sn->disk_size != bs->total_sectors * BDRV_SECTOR_SIZE) {
 485         error_report("qcow2: Loading snapshots with different disk "
 486             "size is not implemented");
 487         ret = -ENOTSUP;
 488         goto fail;
 489     }
 490
 491     /*
 492      * Make sure that the current L1 table is big enough to contain the whole
 493      * L1 table of the snapshot. If the snapshot L1 table is smaller, the
 494      * current one must be padded with zeros.
 495      */
 496     ret = qcow2_grow_l1_table(bs, sn->l1_size, true);
 497     if (ret < 0) {
 498         goto fail;
 499     }
 500
 501     cur_l1_bytes = s->l1_size * sizeof(uint64_t);
 502     sn_l1_bytes = sn->l1_size * sizeof(uint64_t);
 503
 504     /*
 505      * Copy the snapshot L1 table to the current L1 table.
 506      *
 507      * Before overwriting the old current L1 table on disk, make sure to
 508      * increase all refcounts for the clusters referenced by the new one.
 509      * Decrease the refcount referenced by the old one only when the L1
 510      * table is overwritten.
 511      */
 512     sn_l1_table = g_try_malloc0(cur_l1_bytes);
 513     if (cur_l1_bytes && sn_l1_table == NULL) {
 514         ret = -ENOMEM;
 515         goto fail;
 516     }
 517
 518     ret = bdrv_pread(bs->file, sn->l1_table_offset,
 519                      sn_l1_table, sn_l1_bytes);
 520     if (ret < 0) {
 521         goto fail;
 522     }
 523
 524     ret = qcow2_update_snapshot_refcount(bs, sn->l1_table_offset,
 525                                          sn->l1_size, 1);
 526     if (ret < 0) {
 527         goto fail;
 528     }
 529
 530     ret = qcow2_pre_write_overlap_check(bs, QCOW2_OL_ACTIVE_L1,
 531                                         s->l1_table_offset, cur_l1_bytes);
 532     if (ret < 0) {
 533         goto fail;
 534     }
 535
 536     ret = bdrv_pwrite_sync(bs->file, s->l1_table_offset, sn_l1_table,
 537                            cur_l1_bytes);
 538     if (ret < 0) {
 539         goto fail;
 540     }
 541
 542     /*
 543      * Decrease refcount of clusters of current L1 table.
 544      *
 545      * At this point, the in-memory s->l1_table points to the old L1 table,
 546      * whereas on disk we already have the new one.
 547      *
 548      * qcow2_update_snapshot_refcount special cases the current L1 table to use
 549      * the in-memory data instead of really using the offset to load a new one,
 550      * which is why this works.
 551      */
 552     ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset,
 553                                          s->l1_size, -1);
 554
 555     /*
 556      * Now update the in-memory L1 table to be in sync with the on-disk one. We
 557      * need to do this even if updating refcounts failed.
 558      */
 559     for(i = 0;i < s->l1_size; i++) {
 560         s->l1_table[i] = be64_to_cpu(sn_l1_table[i]);
 561     }
 562
 563     if (ret < 0) {
 564         goto fail;
 565     }
 566
 567     g_free(sn_l1_table);
 568     sn_l1_table = NULL;
 569
 570     /*
 571      * Update QCOW_OFLAG_COPIED in the active L1 table (it may have changed
 572      * when we decreased the refcount of the old snapshot.
 573      */
 574     ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, 0);
 575     if (ret < 0) {
 576         goto fail;
 577     }
 578
 579 #ifdef DEBUG_ALLOC
 580     {
 581         BdrvCheckResult result = {0};
 582         qcow2_check_refcounts(bs, &result, 0);
 583     }
 584 #endif
 585     return 0;
 586
 587 fail:
 588     g_free(sn_l1_table);
 589     return ret;
 590 }
 591
 592 int qcow2_snapshot_delete(BlockDriverState *bs,
 593                           const char *snapshot_id,
 594                           const char *name,
 595                           Error **errp)
 596 {
 597     BDRVQcow2State *s = bs->opaque;
 598     QCowSnapshot sn;
 599     int snapshot_index, ret;
 600
 601     /* Search the snapshot */
 602     snapshot_index = find_snapshot_by_id_and_name(bs, snapshot_id, name);
 603     if (snapshot_index < 0) {
 604         error_setg(errp, "Can't find the snapshot");
 605         return -ENOENT;
 606     }
 607     sn = s->snapshots[snapshot_index];
 608
 609     ret = qcow2_validate_table(bs, sn.l1_table_offset, sn.l1_size,
 610                                sizeof(uint64_t), QCOW_MAX_L1_SIZE,
 611                                "Snapshot L1 table", errp);
 612     if (ret < 0) {
 613         return ret;
 614     }
 615
 616     /* Remove it from the snapshot list */
 617     memmove(s->snapshots + snapshot_index,
 618             s->snapshots + snapshot_index + 1,
 619             (s->nb_snapshots - snapshot_index - 1) * sizeof(sn));
 620     s->nb_snapshots--;
 621     ret = qcow2_write_snapshots(bs);
 622     if (ret < 0) {
 623         error_setg_errno(errp, -ret,
 624                          "Failed to remove snapshot from snapshot list");
 625         return ret;
 626     }
 627
 628     /*
 629      * The snapshot is now unused, clean up. If we fail after this point, we
 630      * won't recover but just leak clusters.
 631      */
 632     g_free(sn.id_str);
 633     g_free(sn.name);
 634
 635     /*
 636      * Now decrease the refcounts of clusters referenced by the snapshot and
 637      * free the L1 table.
 638      */
 639     ret = qcow2_update_snapshot_refcount(bs, sn.l1_table_offset,
 640                                          sn.l1_size, -1);
 641     if (ret < 0) {
 642         error_setg_errno(errp, -ret, "Failed to free the cluster and L1 table");
 643         return ret;
 644     }
 645     qcow2_free_clusters(bs, sn.l1_table_offset, sn.l1_size * sizeof(uint64_t),
 646                         QCOW2_DISCARD_SNAPSHOT);
 647
 648     /* must update the copied flag on the current cluster offsets */
 649     ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, 0);
 650     if (ret < 0) {
 651         error_setg_errno(errp, -ret,
 652                          "Failed to update snapshot status in disk");
 653         return ret;
 654     }
 655
 656 #ifdef DEBUG_ALLOC
 657     {
 658         BdrvCheckResult result = {0};
 659         qcow2_check_refcounts(bs, &result, 0);
 660     }
 661 #endif
 662     return 0;
 663 }
 664
 665 int qcow2_snapshot_list(BlockDriverState *bs, QEMUSnapshotInfo **psn_tab)
 666 {
 667     BDRVQcow2State *s = bs->opaque;
 668     QEMUSnapshotInfo *sn_tab, *sn_info;
 669     QCowSnapshot *sn;
 670     int i;
 671
 672     if (!s->nb_snapshots) {
 673         *psn_tab = NULL;
 674         return s->nb_snapshots;
 675     }
 676
 677     sn_tab = g_new0(QEMUSnapshotInfo, s->nb_snapshots);
 678     for(i = 0; i < s->nb_snapshots; i++) {
 679         sn_info = sn_tab + i;
 680         sn = s->snapshots + i;
 681         pstrcpy(sn_info->id_str, sizeof(sn_info->id_str),
 682                 sn->id_str);
 683         pstrcpy(sn_info->name, sizeof(sn_info->name),
 684                 sn->name);
 685         sn_info->vm_state_size = sn->vm_state_size;
 686         sn_info->date_sec = sn->date_sec;
 687         sn_info->date_nsec = sn->date_nsec;
 688         sn_info->vm_clock_nsec = sn->vm_clock_nsec;
 689     }
 690     *psn_tab = sn_tab;
 691     return s->nb_snapshots;
 692 }
 693
 694 int qcow2_snapshot_load_tmp(BlockDriverState *bs,
 695                             const char *snapshot_id,
 696                             const char *name,
 697                             Error **errp)
 698 {
 699     int i, snapshot_index;
 700     BDRVQcow2State *s = bs->opaque;
 701     QCowSnapshot *sn;
 702     uint64_t *new_l1_table;
 703     int new_l1_bytes;
 704     int ret;
 705
 706     assert(bs->read_only);
 707
 708     /* Search the snapshot */
 709     snapshot_index = find_snapshot_by_id_and_name(bs, snapshot_id, name);
 710     if (snapshot_index < 0) {
 711         error_setg(errp,
 712                    "Can't find snapshot");
 713         return -ENOENT;
 714     }
 715     sn = &s->snapshots[snapshot_index];
 716
 717     /* Allocate and read in the snapshot's L1 table */
 718     ret = qcow2_validate_table(bs, sn->l1_table_offset, sn->l1_size,
 719                                sizeof(uint64_t), QCOW_MAX_L1_SIZE,
 720                                "Snapshot L1 table", errp);
 721     if (ret < 0) {
 722         return ret;
 723     }
 724     new_l1_bytes = sn->l1_size * sizeof(uint64_t);
 725     new_l1_table = qemu_try_blockalign(bs->file->bs,
 726                                        ROUND_UP(new_l1_bytes, 512));
 727     if (new_l1_table == NULL) {
 728         return -ENOMEM;
 729     }
 730
 731     ret = bdrv_pread(bs->file, sn->l1_table_offset,
 732                      new_l1_table, new_l1_bytes);
 733     if (ret < 0) {
 734         error_setg(errp, "Failed to read l1 table for snapshot");
 735         qemu_vfree(new_l1_table);
 736         return ret;
 737     }
 738
 739     /* Switch the L1 table */
 740     qemu_vfree(s->l1_table);
 741
 742     s->l1_size = sn->l1_size;
 743     s->l1_table_offset = sn->l1_table_offset;
 744     s->l1_table = new_l1_table;
 745
 746     for(i = 0;i < s->l1_size; i++) {
 747         be64_to_cpus(&s->l1_table[i]);
 748     }
 749
 750     return 0;
 751 }