1 From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2 From: Fiona Ebner <f.ebner@proxmox.com>
3 Date: Fri, 17 Nov 2023 11:18:06 +0100
4 Subject: [PATCH] Revert "x86: acpi: workaround Windows not handling name
5 references in Package properly"
7 This reverts commit 44d975ef340e2f21f236f9520c53e1b30d2213a4.
9 As reported in the community forum [0] and reproduced locally this
10 breaks VirtIO network adapters in (at least) the German ISO of Windows
11 Server 2022. The fix itself was for
13 > Issue is not fatal but as result acpi-index/"PCI Label ID" property
14 > is either not shown in device details page or shows incorrect value.
16 so revert and tolerate that as a stop-gap, rather than have the
17 devices not working at all.
19 [0]: https://forum.proxmox.com/threads/92094/post-605684
21 Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
23 hw/i386/acpi-build.c | 8 ++------
24 1 file changed, 2 insertions(+), 6 deletions(-)
26 diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
27 index 1e178341de..d8694b338e 100644
28 --- a/hw/i386/acpi-build.c
29 +++ b/hw/i386/acpi-build.c
30 @@ -357,13 +357,9 @@ Aml *aml_pci_device_dsm(void)
32 Aml *params = aml_local(0);
33 Aml *pkg = aml_package(2);
34 - aml_append(pkg, aml_int(0));
35 - aml_append(pkg, aml_int(0));
36 + aml_append(pkg, aml_name("BSEL"));
37 + aml_append(pkg, aml_name("ASUN"));
38 aml_append(method, aml_store(pkg, params));
40 - aml_store(aml_name("BSEL"), aml_index(params, aml_int(0))));
42 - aml_store(aml_name("ASUN"), aml_index(params, aml_int(1))));
44 aml_return(aml_call5("PDSM", aml_arg(0), aml_arg(1),
45 aml_arg(2), aml_arg(3), params))