1 From 46fd4bb673a91d40352c95e9d3f62f63b5021053 Mon Sep 17 00:00:00 2001
2 From: Stefan Priebe <s.priebe@profihost.ag>
3 Date: Fri, 29 Nov 2013 22:17:03 +0100
4 Subject: [PATCH] internal-snapshot-async-qemu1.7.patch
9 hmp-commands.hx | 34 ++++
12 include/block/block.h | 1 +
13 include/sysemu/sysemu.h | 5 +-
15 qapi-schema.json | 46 +++++
16 qemu-options.hx | 13 ++
17 qmp-commands.hx | 31 +++
18 savevm-async.c | 478 +++++++++++++++++++++++++++++++++++++++++++++++
21 14 files changed, 692 insertions(+), 7 deletions(-)
22 create mode 100644 savevm-async.c
24 Index: new/Makefile.objs
25 ===================================================================
26 --- new.orig/Makefile.objs 2014-07-16 12:01:32.000000000 +0200
27 +++ new/Makefile.objs 2014-07-16 12:01:37.000000000 +0200
29 common-obj-y += qemu-char.o #aio.o
30 common-obj-y += block-migration.o
31 common-obj-y += page_cache.o xbzrle.o
32 +common-obj-y += savevm-async.o
34 common-obj-$(CONFIG_POSIX) += migration-exec.o migration-unix.o migration-fd.o
37 ===================================================================
38 --- new.orig/block.c 2014-07-16 11:53:55.000000000 +0200
39 +++ new/block.c 2014-07-16 12:01:37.000000000 +0200
41 bdrv_set_backing_hd(bs_top, bs_new);
44 -static void bdrv_delete(BlockDriverState *bs)
45 +void bdrv_delete(BlockDriverState *bs)
49 Index: new/hmp-commands.hx
50 ===================================================================
51 --- new.orig/hmp-commands.hx 2014-07-16 12:01:35.000000000 +0200
52 +++ new/hmp-commands.hx 2014-07-16 12:01:37.000000000 +0200
54 show current migration capabilities
55 @item info migrate_cache_size
56 show current migration XBZRLE cache size
60 show balloon information
62 @@ -1824,3 +1826,35 @@
68 + .name = "savevm-start",
69 + .args_type = "statefile:s?",
70 + .params = "[statefile]",
71 + .help = "Prepare for snapshot and halt VM. Save VM state to statefile.",
72 + .mhandler.cmd = hmp_savevm_start,
76 + .name = "snapshot-drive",
77 + .args_type = "device:s,name:s",
78 + .params = "device name",
79 + .help = "Create internal snapshot.",
80 + .mhandler.cmd = hmp_snapshot_drive,
84 + .name = "delete-drive-snapshot",
85 + .args_type = "device:s,name:s",
86 + .params = "device name",
87 + .help = "Delete internal snapshot.",
88 + .mhandler.cmd = hmp_delete_drive_snapshot,
92 + .name = "savevm-end",
95 + .help = "Resume VM after snaphot.",
96 + .mhandler.cmd = hmp_savevm_end,
99 ===================================================================
100 --- new.orig/hmp.c 2014-07-16 12:01:35.000000000 +0200
101 +++ new/hmp.c 2014-07-16 12:01:37.000000000 +0200
102 @@ -1805,3 +1805,60 @@
104 monitor_printf(mon, "\n");
107 +void hmp_savevm_start(Monitor *mon, const QDict *qdict)
109 + Error *errp = NULL;
110 + const char *statefile = qdict_get_try_str(qdict, "statefile");
112 + qmp_savevm_start(statefile != NULL, statefile, &errp);
113 + hmp_handle_error(mon, &errp);
116 +void hmp_snapshot_drive(Monitor *mon, const QDict *qdict)
118 + Error *errp = NULL;
119 + const char *name = qdict_get_str(qdict, "name");
120 + const char *device = qdict_get_str(qdict, "device");
122 + qmp_snapshot_drive(device, name, &errp);
123 + hmp_handle_error(mon, &errp);
126 +void hmp_delete_drive_snapshot(Monitor *mon, const QDict *qdict)
128 + Error *errp = NULL;
129 + const char *name = qdict_get_str(qdict, "name");
130 + const char *device = qdict_get_str(qdict, "device");
132 + qmp_delete_drive_snapshot(device, name, &errp);
133 + hmp_handle_error(mon, &errp);
136 +void hmp_savevm_end(Monitor *mon, const QDict *qdict)
138 + Error *errp = NULL;
140 + qmp_savevm_end(&errp);
141 + hmp_handle_error(mon, &errp);
144 +void hmp_info_savevm(Monitor *mon, const QDict *qdict)
147 + info = qmp_query_savevm(NULL);
149 + if (info->has_status) {
150 + monitor_printf(mon, "savevm status: %s\n", info->status);
151 + monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
154 + monitor_printf(mon, "savevm status: not running\n");
156 + if (info->has_bytes) {
157 + monitor_printf(mon, "Bytes saved: %"PRIu64"\n", info->bytes);
159 + if (info->has_error) {
160 + monitor_printf(mon, "Error: %s\n", info->error);
164 ===================================================================
165 --- new.orig/hmp.h 2014-07-16 12:01:34.000000000 +0200
166 +++ new/hmp.h 2014-07-16 12:01:37.000000000 +0200
168 void hmp_info_uuid(Monitor *mon, const QDict *qdict);
169 void hmp_info_chardev(Monitor *mon, const QDict *qdict);
170 void hmp_info_mice(Monitor *mon, const QDict *qdict);
171 +void hmp_info_savevm(Monitor *mon, const QDict *qdict);
172 void hmp_info_migrate(Monitor *mon, const QDict *qdict);
173 void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict);
174 void hmp_info_migrate_cache_size(Monitor *mon, const QDict *qdict);
176 void hmp_netdev_del(Monitor *mon, const QDict *qdict);
177 void hmp_getfd(Monitor *mon, const QDict *qdict);
178 void hmp_closefd(Monitor *mon, const QDict *qdict);
179 +void hmp_savevm_start(Monitor *mon, const QDict *qdict);
180 +void hmp_snapshot_drive(Monitor *mon, const QDict *qdict);
181 +void hmp_delete_drive_snapshot(Monitor *mon, const QDict *qdict);
182 +void hmp_savevm_end(Monitor *mon, const QDict *qdict);
183 void hmp_send_key(Monitor *mon, const QDict *qdict);
184 void hmp_screen_dump(Monitor *mon, const QDict *qdict);
185 void hmp_nbd_server_start(Monitor *mon, const QDict *qdict);
186 Index: new/include/block/block.h
187 ===================================================================
188 --- new.orig/include/block/block.h 2014-07-16 11:53:55.000000000 +0200
189 +++ new/include/block/block.h 2014-07-16 12:01:37.000000000 +0200
191 const char *backing_file);
192 int bdrv_get_backing_file_depth(BlockDriverState *bs);
193 int bdrv_truncate(BlockDriverState *bs, int64_t offset);
194 +void bdrv_delete(BlockDriverState *bs);
195 int64_t bdrv_getlength(BlockDriverState *bs);
196 int64_t bdrv_get_allocated_file_size(BlockDriverState *bs);
197 void bdrv_get_geometry(BlockDriverState *bs, uint64_t *nb_sectors_ptr);
198 Index: new/include/sysemu/sysemu.h
199 ===================================================================
200 --- new.orig/include/sysemu/sysemu.h 2014-07-16 11:53:55.000000000 +0200
201 +++ new/include/sysemu/sysemu.h 2014-07-16 12:01:37.000000000 +0200
204 void do_savevm(Monitor *mon, const QDict *qdict);
205 int load_vmstate(const char *name);
206 +int load_state_from_blockdev(const char *filename);
207 void do_delvm(Monitor *mon, const QDict *qdict);
208 void do_info_snapshots(Monitor *mon, const QDict *qdict);
210 void qemu_announce_self(void);
212 bool qemu_savevm_state_blocked(Error **errp);
213 -void qemu_savevm_state_begin(QEMUFile *f,
214 +int qemu_savevm_state_begin(QEMUFile *f,
215 const MigrationParams *params);
216 int qemu_savevm_state_iterate(QEMUFile *f);
217 -void qemu_savevm_state_complete(QEMUFile *f);
218 +int qemu_savevm_state_complete(QEMUFile *f);
219 void qemu_savevm_state_cancel(void);
220 uint64_t qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size);
221 int qemu_loadvm_state(QEMUFile *f);
223 ===================================================================
224 --- new.orig/monitor.c 2014-07-16 12:01:34.000000000 +0200
225 +++ new/monitor.c 2014-07-16 12:01:37.000000000 +0200
226 @@ -2876,6 +2876,13 @@
227 .mhandler.cmd = hmp_info_migrate_cache_size,
233 + .help = "show savevm status",
234 + .mhandler.cmd = hmp_info_savevm,
240 Index: new/qapi-schema.json
241 ===================================================================
242 --- new.orig/qapi-schema.json 2014-07-16 12:01:35.000000000 +0200
243 +++ new/qapi-schema.json 2014-07-16 12:01:37.000000000 +0200
246 '*setup-time': 'int'} }
251 +# Information about current migration process.
253 +# @status: #optional string describing the current savevm status.
254 +# This can be 'active', 'completed', 'failed'.
255 +# If this field is not returned, no savevm process
256 +# has been initiated
258 +# @error: #optional string containing error message is status is failed.
260 +# @total-time: #optional total amount of milliseconds since savevm started.
261 +# If savevm has ended, it returns the total save time
263 +# @bytes: #optional total amount of data transfered
267 +{ 'type': 'SaveVMInfo',
268 + 'data': {'*status': 'str', '*error': 'str',
269 + '*total-time': 'int', '*bytes': 'int'} }
274 +# Returns information about current savevm process.
276 +# Returns: @SaveVMInfo
280 +{ 'command': 'query-savevm', 'returns': 'SaveVMInfo' }
287 @@ -2644,8 +2680,18 @@
292 { 'command': 'query-target', 'returns': 'TargetInfo' }
294 +{ 'command': 'savevm-start', 'data': { '*statefile': 'str' } }
296 +{ 'command': 'snapshot-drive', 'data': { 'device': 'str', 'name': 'str' } }
298 +{ 'command': 'delete-drive-snapshot', 'data': { 'device': 'str', 'name': 'str' } }
300 +{ 'command': 'savevm-end' }
306 Index: new/qemu-options.hx
307 ===================================================================
308 --- new.orig/qemu-options.hx 2014-07-16 12:01:27.000000000 +0200
309 +++ new/qemu-options.hx 2014-07-16 12:01:37.000000000 +0200
310 @@ -2951,6 +2951,19 @@
311 Start right away with a saved state (@code{loadvm} in monitor)
314 +DEF("loadstate", HAS_ARG, QEMU_OPTION_loadstate, \
315 + "-loadstate file\n" \
316 + " start right away with a saved state\n",
319 +@item -loadstate @var{file}
321 +Start right away with a saved state. This option does not rollback
322 +disk state like @code{loadvm}, so user must make sure that disk
323 +have correct state. @var{file} can be any valid device URL. See the section
324 +for "Device URL Syntax" for more information.
328 DEF("daemonize", 0, QEMU_OPTION_daemonize, \
329 "-daemonize daemonize QEMU after initializing\n", QEMU_ARCH_ALL)
330 Index: new/qmp-commands.hx
331 ===================================================================
332 --- new.orig/qmp-commands.hx 2014-07-16 12:01:34.000000000 +0200
333 +++ new/qmp-commands.hx 2014-07-16 12:01:37.000000000 +0200
334 @@ -3786,3 +3786,34 @@
341 + .name = "savevm-start",
342 + .args_type = "statefile:s?",
343 + .mhandler.cmd_new = qmp_marshal_input_savevm_start,
347 + .name = "snapshot-drive",
348 + .args_type = "device:s,name:s",
349 + .mhandler.cmd_new = qmp_marshal_input_snapshot_drive,
353 + .name = "delete-drive-snapshot",
354 + .args_type = "device:s,name:s",
355 + .mhandler.cmd_new = qmp_marshal_input_delete_drive_snapshot,
359 + .name = "savevm-end",
361 + .mhandler.cmd_new = qmp_marshal_input_savevm_end,
365 + .name = "query-savevm",
367 + .mhandler.cmd_new = qmp_marshal_input_query_savevm,
369 Index: new/savevm-async.c
370 ===================================================================
371 --- /dev/null 1970-01-01 00:00:00.000000000 +0000
372 +++ new/savevm-async.c 2014-07-16 12:01:37.000000000 +0200
374 +#include "qemu-common.h"
375 +#include "qapi/qmp/qerror.h"
376 +#include "sysemu/sysemu.h"
377 +#include "qmp-commands.h"
378 +#include "qemu-options.h"
379 +#include "migration/qemu-file.h"
380 +#include "qom/qom-qobject.h"
381 +#include "migration/migration.h"
382 +#include "block/snapshot.h"
383 +#include "block/qapi.h"
384 +#include "block/block.h"
385 +#include "qemu/timer.h"
387 +/* #define DEBUG_SAVEVM_STATE */
389 +#ifdef DEBUG_SAVEVM_STATE
390 +#define DPRINTF(fmt, ...) \
391 + do { printf("savevm-async: " fmt, ## __VA_ARGS__); } while (0)
393 +#define DPRINTF(fmt, ...) \
401 + SAVE_STATE_COMPLETED,
405 +static struct SnapshotState {
406 + BlockDriverState *bs;
411 + int saved_vm_running;
413 + int64_t total_time;
416 +SaveVMInfo *qmp_query_savevm(Error **errp)
418 + SaveVMInfo *info = g_malloc0(sizeof(*info));
419 + struct SnapshotState *s = &snap_state;
421 + if (s->state != SAVE_STATE_DONE) {
422 + info->has_bytes = true;
423 + info->bytes = s->bs_pos;
424 + switch (s->state) {
425 + case SAVE_STATE_ERROR:
426 + info->has_status = true;
427 + info->status = g_strdup("failed");
428 + info->has_total_time = true;
429 + info->total_time = s->total_time;
431 + info->has_error = true;
432 + info->error = g_strdup(error_get_pretty(s->error));
435 + case SAVE_STATE_ACTIVE:
436 + info->has_status = true;
437 + info->status = g_strdup("active");
438 + info->has_total_time = true;
439 + info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME)
442 + case SAVE_STATE_COMPLETED:
443 + info->has_status = true;
444 + info->status = g_strdup("completed");
445 + info->has_total_time = true;
446 + info->total_time = s->total_time;
454 +static int save_snapshot_cleanup(void)
458 + DPRINTF("save_snapshot_cleanup\n");
460 + snap_state.total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) -
461 + snap_state.total_time;
463 + if (snap_state.file) {
464 + ret = qemu_fclose(snap_state.file);
467 + if (snap_state.bs) {
468 + /* try to truncate, but ignore errors (will fail on block devices).
469 + * note: bdrv_read() need whole blocks, so we round up
471 + size_t size = (snap_state.bs_pos + BDRV_SECTOR_SIZE) & BDRV_SECTOR_MASK;
472 + bdrv_truncate(snap_state.bs, size);
473 + bdrv_op_unblock_all(snap_state.bs, snap_state.blocker);
474 + error_free(snap_state.blocker);
475 + snap_state.blocker = NULL;
476 + bdrv_unref(snap_state.bs);
477 + snap_state.bs = NULL;
483 +static void save_snapshot_error(const char *fmt, ...)
489 + msg = g_strdup_vprintf(fmt, ap);
492 + DPRINTF("save_snapshot_error: %s\n", msg);
494 + if (!snap_state.error) {
495 + error_set(&snap_state.error, ERROR_CLASS_GENERIC_ERROR, "%s", msg);
500 + snap_state.state = SAVE_STATE_ERROR;
502 + save_snapshot_cleanup();
505 +static void save_snapshot_completed(void)
507 + DPRINTF("save_snapshot_completed\n");
509 + if (save_snapshot_cleanup() < 0) {
510 + snap_state.state = SAVE_STATE_ERROR;
512 + snap_state.state = SAVE_STATE_COMPLETED;
516 +static int block_state_close(void *opaque)
518 + snap_state.file = NULL;
519 + return bdrv_flush(snap_state.bs);
522 +static int block_state_put_buffer(void *opaque, const uint8_t *buf,
523 + int64_t pos, int size)
527 + assert(pos == snap_state.bs_pos);
529 + if ((ret = bdrv_pwrite(snap_state.bs, snap_state.bs_pos, buf, size)) > 0) {
530 + snap_state.bs_pos += ret;
536 +static void process_savevm_co(void *opaque)
540 + MigrationParams params = {
545 + snap_state.state = SAVE_STATE_ACTIVE;
547 + qemu_mutex_unlock_iothread();
548 + ret = qemu_savevm_state_begin(snap_state.file, ¶ms);
549 + qemu_mutex_lock_iothread();
552 + save_snapshot_error("qemu_savevm_state_begin failed");
556 + while (snap_state.state == SAVE_STATE_ACTIVE) {
557 + uint64_t pending_size;
559 + pending_size = qemu_savevm_state_pending(snap_state.file, 0);
561 + if (pending_size) {
562 + ret = qemu_savevm_state_iterate(snap_state.file);
564 + save_snapshot_error("qemu_savevm_state_iterate error %d", ret);
567 + DPRINTF("savevm inerate pending size %lu ret %d\n", pending_size, ret);
569 + DPRINTF("done iterating\n");
570 + if (runstate_is_running()) {
571 + vm_stop(RUN_STATE_SAVE_VM);
573 + DPRINTF("savevm inerate finished\n");
574 + qemu_savevm_state_complete(snap_state.file);
575 + DPRINTF("save complete\n");
576 + save_snapshot_completed();
580 + /* stop the VM if we get to the end of available space,
581 + * or if pending_size is just a few MB
583 + maxlen = bdrv_getlength(snap_state.bs) - 30*1024*1024;
584 + if ((pending_size < 100000) ||
585 + ((snap_state.bs_pos + pending_size) >= maxlen)) {
586 + if (runstate_is_running()) {
587 + vm_stop(RUN_STATE_SAVE_VM);
593 +static const QEMUFileOps block_file_ops = {
594 + .put_buffer = block_state_put_buffer,
595 + .close = block_state_close,
599 +void qmp_savevm_start(bool has_statefile, const char *statefile, Error **errp)
601 + BlockDriver *drv = NULL;
602 + Error *local_err = NULL;
604 + int bdrv_oflags = BDRV_O_CACHE_WB | BDRV_O_RDWR;
607 + if (snap_state.state != SAVE_STATE_DONE) {
608 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
609 + "VM snapshot already started\n");
613 + /* initialize snapshot info */
614 + snap_state.saved_vm_running = runstate_is_running();
615 + snap_state.bs_pos = 0;
616 + snap_state.total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
617 + snap_state.blocker = NULL;
619 + if (snap_state.error) {
620 + error_free(snap_state.error);
621 + snap_state.error = NULL;
624 + if (!has_statefile) {
625 + vm_stop(RUN_STATE_SAVE_VM);
626 + snap_state.state = SAVE_STATE_COMPLETED;
630 + if (qemu_savevm_state_blocked(errp)) {
634 + /* Open the image */
635 + snap_state.bs = bdrv_new("vmstate", &error_abort);
636 + ret = bdrv_open(&snap_state.bs, statefile, NULL, NULL, bdrv_oflags, drv, &local_err);
639 + error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
643 + snap_state.file = qemu_fopen_ops(&snap_state, &block_file_ops);
645 + if (!snap_state.file) {
646 + error_set(errp, ERROR_CLASS_GENERIC_ERROR, "failed to open '%s'", statefile);
651 + error_setg(&snap_state.blocker, "block device is in use by savevm");
652 + bdrv_op_block_all(snap_state.bs, snap_state.blocker);
653 + bdrv_ref(snap_state.bs);
655 + Coroutine *co = qemu_coroutine_create(process_savevm_co);
656 + qemu_coroutine_enter(co, NULL);
662 + save_snapshot_error("setup failed");
664 + if (snap_state.saved_vm_running) {
669 +void qmp_savevm_end(Error **errp)
671 + if (snap_state.state == SAVE_STATE_DONE) {
672 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
673 + "VM snapshot not started\n");
677 + if (snap_state.saved_vm_running) {
681 + snap_state.state = SAVE_STATE_DONE;
684 +void qmp_snapshot_drive(const char *device, const char *name, Error **errp)
686 + BlockDriverState *bs;
687 + QEMUSnapshotInfo sn1, *sn = &sn1;
695 + if (snap_state.state != SAVE_STATE_COMPLETED) {
696 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
697 + "VM snapshot not ready/started\n");
701 + bs = bdrv_find(device);
703 + error_set(errp, QERR_DEVICE_NOT_FOUND, device);
707 + if (!bdrv_is_inserted(bs)) {
708 + error_set(errp, QERR_DEVICE_HAS_NO_MEDIUM, device);
712 + if (bdrv_is_read_only(bs)) {
713 + error_set(errp, QERR_DEVICE_IS_READ_ONLY, device);
717 + if (!bdrv_can_snapshot(bs)) {
718 + error_set(errp, QERR_UNSUPPORTED);
722 + if (bdrv_snapshot_find(bs, sn, name) >= 0) {
723 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
724 + "snapshot '%s' already exists", name);
729 + memset(sn, 0, sizeof(*sn));
733 + sn->date_sec = tb.time;
734 + sn->date_nsec = tb.millitm * 1000000;
736 + gettimeofday(&tv, NULL);
737 + sn->date_sec = tv.tv_sec;
738 + sn->date_nsec = tv.tv_usec * 1000;
740 + sn->vm_clock_nsec = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
742 + pstrcpy(sn->name, sizeof(sn->name), name);
744 + sn->vm_state_size = 0; /* do not save state */
746 + ret = bdrv_snapshot_create(bs, sn);
748 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
749 + "Error while creating snapshot on '%s'\n", device);
754 +void qmp_delete_drive_snapshot(const char *device, const char *name,
757 + BlockDriverState *bs;
758 + QEMUSnapshotInfo sn1, *sn = &sn1;
759 + Error *local_err = NULL;
763 + bs = bdrv_find(device);
765 + error_set(errp, QERR_DEVICE_NOT_FOUND, device);
768 + if (bdrv_is_read_only(bs)) {
769 + error_set(errp, QERR_DEVICE_IS_READ_ONLY, device);
773 + if (!bdrv_can_snapshot(bs)) {
774 + error_set(errp, QERR_UNSUPPORTED);
778 + if (bdrv_snapshot_find(bs, sn, name) < 0) {
779 + /* return success if snapshot does not exists */
783 + ret = bdrv_snapshot_delete(bs, NULL, name, &local_err);
785 + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
786 + "Error while deleting snapshot on '%s'\n", device);
791 +static int loadstate_get_buffer(void *opaque, uint8_t *buf, int64_t pos,
794 + BlockDriverState *bs = (BlockDriverState *)opaque;
795 + int64_t maxlen = bdrv_getlength(bs);
796 + if (pos > maxlen) {
799 + if ((pos + size) > maxlen) {
800 + size = maxlen - pos - 1;
805 + return bdrv_pread(bs, pos, buf, size);
808 +static const QEMUFileOps loadstate_file_ops = {
809 + .get_buffer = loadstate_get_buffer,
812 +int load_state_from_blockdev(const char *filename)
814 + BlockDriverState *bs = NULL;
815 + BlockDriver *drv = NULL;
816 + Error *local_err = NULL;
817 + Error *blocker = NULL;
822 + bs = bdrv_new("vmstate", &error_abort);
823 + ret = bdrv_open(&bs, filename, NULL, NULL, BDRV_O_CACHE_WB, drv, &local_err);
824 + error_setg(&blocker, "block device is in use by load state");
825 + bdrv_op_block_all(bs, blocker);
829 + error_report("Could not open VM state file");
833 + /* restore the VM state */
834 + f = qemu_fopen_ops(bs, &loadstate_file_ops);
836 + error_report("Could not open VM state file");
841 + qemu_system_reset(VMRESET_SILENT);
842 + ret = qemu_loadvm_state(f);
846 + error_report("Error %d while loading VM state", ret);
854 + bdrv_op_unblock_all(bs, blocker);
855 + error_free(blocker);
861 ===================================================================
862 --- new.orig/savevm.c 2014-07-16 11:53:55.000000000 +0200
863 +++ new/savevm.c 2014-07-16 12:01:37.000000000 +0200
864 @@ -596,11 +596,11 @@
868 -void qemu_savevm_state_begin(QEMUFile *f,
869 +int qemu_savevm_state_begin(QEMUFile *f,
870 const MigrationParams *params)
876 trace_savevm_state_begin();
877 QTAILQ_FOREACH(se, &savevm_handlers, entry) {
890 -void qemu_savevm_state_complete(QEMUFile *f)
891 +int qemu_savevm_state_complete(QEMUFile *f)
896 trace_savevm_section_end(se->idstr, se->section_id);
898 qemu_file_set_error(f, ret);
906 qemu_put_byte(f, QEMU_VM_EOF);
908 + return qemu_file_get_error(f);
911 uint64_t qemu_savevm_state_pending(QEMUFile *f, uint64_t max_size)
913 ===================================================================
914 --- new.orig/vl.c 2014-07-16 12:01:30.000000000 +0200
915 +++ new/vl.c 2014-07-16 12:01:37.000000000 +0200
916 @@ -2920,6 +2920,7 @@
919 const char *loadvm = NULL;
920 + const char *loadstate = NULL;
921 MachineClass *machine_class;
922 const char *cpu_model;
923 const char *vga_model = NULL;
924 @@ -3614,6 +3615,9 @@
925 case QEMU_OPTION_loadvm:
928 + case QEMU_OPTION_loadstate:
929 + loadstate = optarg;
931 case QEMU_OPTION_full_screen:
934 @@ -4558,6 +4562,10 @@
935 if (load_vmstate(loadvm) < 0) {
938 + } else if (loadstate) {
939 + if (load_state_from_blockdev(loadstate) < 0) {
944 qdev_prop_check_global();