]> git.proxmox.com Git - mirror_frr.git/blob - doc/developer/topotests.rst
Merge pull request #6054 from sarav511/dr2ndr
[mirror_frr.git] / doc / developer / topotests.rst
1 .. _topotests:
2
3 Topotests
4 =========
5
6 Topotests is a suite of topology tests for FRR built on top of Mininet.
7
8 Installation and Setup
9 ----------------------
10
11 Only tested with Ubuntu 16.04 and Ubuntu 18.04 (which uses Mininet 2.2.x).
12
13 Instructions are the same for all setups (i.e. ExaBGP is only used for BGP
14 tests).
15
16 Installing Mininet Infrastructure
17 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
18
19 .. code:: shell
20
21 apt-get install mininet
22 apt-get install python-pip
23 apt-get install iproute
24 pip install ipaddr
25 pip install "pytest<5"
26 pip install exabgp==3.4.17 (Newer 4.0 version of exabgp is not yet
27 supported)
28 useradd -d /var/run/exabgp/ -s /bin/false exabgp
29
30 Enable Coredumps
31 """"""""""""""""
32
33 Optional, will give better output.
34
35 .. code:: shell
36
37 apt-get install gdb
38 disable apport (which move core files)
39
40 Set ``enabled=0`` in ``/etc/default/apport``.
41
42 Next, update security limits by changing :file:`/etc/security/limits.conf` to::
43
44 #<domain> <type> <item> <value>
45 * soft core unlimited
46 root soft core unlimited
47 * hard core unlimited
48 root hard core unlimited
49
50 Reboot for options to take effect.
51
52 FRR Installation
53 ^^^^^^^^^^^^^^^^
54
55 FRR needs to be installed separately. It is assume to be configured like the
56 standard Ubuntu Packages:
57
58 - Binaries in :file:`/usr/lib/frr`
59 - State Directory :file:`/var/run/frr`
60 - Running under user ``frr``, group ``frr``
61 - vtygroup: ``frrvty``
62 - config directory: :file:`/etc/frr`
63 - For FRR Packages, install the dbg package as well for coredump decoding
64
65 No FRR config needs to be done and no FRR daemons should be run ahead of the
66 test. They are all started as part of the test.
67
68 Manual FRR build
69 """"""""""""""""
70
71 If you prefer to manually build FRR, then use the following suggested config:
72
73 .. code:: shell
74
75 ./configure \
76 --prefix=/usr \
77 --localstatedir=/var/run/frr \
78 --sbindir=/usr/lib/frr \
79 --sysconfdir=/etc/frr \
80 --enable-vtysh \
81 --enable-pimd \
82 --enable-sharpd \
83 --enable-multipath=64 \
84 --enable-user=frr \
85 --enable-group=frr \
86 --enable-vty-group=frrvty \
87 --with-pkg-extra-version=-my-manual-build
88
89 And create ``frr`` user and ``frrvty`` group as follows:
90
91 .. code:: shell
92
93 addgroup --system --gid 92 frr
94 addgroup --system --gid 85 frrvty
95 adduser --system --ingroup frr --home /var/run/frr/ \
96 --gecos "FRRouting suite" --shell /bin/false frr
97 usermod -G frrvty frr
98
99 Executing Tests
100 ---------------
101
102 Execute all tests with output to console
103 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
104
105 .. code:: shell
106
107 py.test -s -v --tb=no
108
109 The above command must be executed from inside the topotests directory.
110
111 All test\_\* scripts in subdirectories are detected and executed (unless
112 disabled in ``pytest.ini`` file).
113
114 ``--tb=no`` disables the python traceback which might be irrelevant unless the
115 test script itself is debugged.
116
117 Execute single test
118 ^^^^^^^^^^^^^^^^^^^
119
120 .. code:: shell
121
122 cd test_to_be_run
123 ./test_to_be_run.py
124
125 For example, and assuming you are inside the frr directory:
126
127 .. code:: shell
128
129 cd tests/topotests/bgp_l3vpn_to_bgp_vrf
130 ./test_bgp_l3vpn_to_bgp_vrf.py
131
132 For further options, refer to pytest documentation.
133
134 Test will set exit code which can be used with ``git bisect``.
135
136 For the simulated topology, see the description in the python file.
137
138 If you need to clear the mininet setup between tests (if it isn't cleanly
139 shutdown), then use the ``mn -c`` command to clean up the environment.
140
141 StdErr log from daemos after exit
142 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
143
144 To enable the reporting of any messages seen on StdErr after the daemons exit,
145 the following env variable can be set::
146
147 export TOPOTESTS_CHECK_STDERR=Yes
148
149 (The value doesn't matter at this time. The check is whether the env
150 variable exists or not.) There is no pass/fail on this reporting; the
151 Output will be reported to the console.
152
153 Collect Memory Leak Information
154 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
155
156 FRR processes can report unfreed memory allocations upon exit. To
157 enable the reporting of memory leaks, define an environment variable
158 ``TOPOTESTS_CHECK_MEMLEAK`` with the file prefix, i.e.::
159
160 export TOPOTESTS_CHECK_MEMLEAK="/home/mydir/memleak_"
161
162 This will enable the check and output to console and the writing of
163 the information to files with the given prefix (followed by testname),
164 ie :file:`/home/mydir/memcheck_test_bgp_multiview_topo1.txt` in case
165 of a memory leak.
166
167 Running Topotests with AddressSanitizer
168 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
169
170 Topotests can be run with AddressSanitizer. It requires GCC 4.8 or newer.
171 (Ubuntu 16.04 as suggested here is fine with GCC 5 as default). For more
172 information on AddressSanitizer, see
173 https://github.com/google/sanitizers/wiki/AddressSanitizer.
174
175 The checks are done automatically in the library call of ``checkRouterRunning``
176 (ie at beginning of tests when there is a check for all daemons running). No
177 changes or extra configuration for topotests is required beside compiling the
178 suite with AddressSanitizer enabled.
179
180 If a daemon crashed, then the errorlog is checked for AddressSanitizer output.
181 If found, then this is added with context (calling test) to
182 :file:`/tmp/AddressSanitizer.txt` in Markdown compatible format.
183
184 Compiling for GCC AddressSanitizer requires to use ``gcc`` as a linker as well
185 (instead of ``ld``). Here is a suggest way to compile frr with AddressSanitizer
186 for ``master`` branch:
187
188 .. code:: shell
189
190 git clone https://github.com/FRRouting/frr.git
191 cd frr
192 ./bootstrap.sh
193 ./configure \
194 --enable-address-sanitizer \
195 --prefix=/usr/lib/frr --sysconfdir=/etc/frr \
196 --localstatedir=/var/run/frr \
197 --sbindir=/usr/lib/frr --bindir=/usr/lib/frr \
198 --enable-exampledir=/usr/lib/frr/examples \
199 --with-moduledir=/usr/lib/frr/modules \
200 --enable-multipath=0 --enable-rtadv \
201 --enable-tcp-zebra --enable-fpm --enable-pimd \
202 --enable-sharpd
203 make
204 sudo make install
205 # Create symlink for vtysh, so topotest finds it in /usr/lib/frr
206 sudo ln -s /usr/lib/frr/vtysh /usr/bin/
207
208 and create ``frr`` user and ``frrvty`` group as shown above.
209
210 .. _topotests_docker:
211
212 Running Tests with Docker
213 -------------------------
214
215 There is a Docker image which allows to run topotests.
216
217 Quickstart
218 ^^^^^^^^^^
219
220 If you have Docker installed, you can run the topotests in Docker. The easiest
221 way to do this, is to use the make targets from this repository.
222
223 Your current user needs to have access to the Docker daemon. Alternatively you
224 can run these commands as root.
225
226 .. code:: console
227
228 make topotests
229
230 This command will pull the most recent topotests image from Dockerhub, compile
231 FRR inside of it, and run the topotests.
232
233 Advanced Usage
234 ^^^^^^^^^^^^^^
235
236 Internally, the topotests make target uses a shell script to pull the image and
237 spawn the Docker container.
238
239 There are several environment variables which can be used to modify the
240 behavior of the script, these can be listed by calling it with ``-h``:
241
242 .. code:: console
243
244 ./tests/topotests/docker/frr-topotests.sh -h
245
246 For example, a volume is used to cache build artifacts between multiple runs of
247 the image. If you need to force a complete recompile, you can set
248 ``TOPOTEST_CLEAN``:
249
250 .. code:: console
251
252 TOPOTEST_CLEAN=1 ./tests/topotests/docker/frr-topotests.sh
253
254 By default, ``frr-topotests.sh`` will build frr and run pytest. If you append
255 arguments and the first one starts with ``/`` or ``./``, they will replace the
256 call to pytest. If the appended arguments do not match this patttern, they will
257 be provided to pytest as arguments. So, to run a specific test with more
258 verbose logging:
259
260 .. code:: console
261
262 ./tests/topotests/docker/frr-topotests.sh -vv -s all-protocol-startup/test_all_protocol_startup.py
263
264 And to compile FRR but drop into a shell instead of running pytest:
265
266 .. code:: console
267
268 ./tests/topotests/docker/frr-topotests.sh /bin/bash
269
270 Development
271 ^^^^^^^^^^^
272
273 The Docker image just includes all the components to run the topotests, but not
274 the topotests themselves. So if you just want to write tests and don't want to
275 make changes to the environment provided by the Docker image. You don't need to
276 build your own Docker image if you do not want to.
277
278 When developing new tests, there is one caveat though: The startup script of
279 the container will run a ``git-clean`` on its copy of the FRR tree to avoid any
280 pollution of the container with build artefacts from the host. This will also
281 result in your newly written tests being unavailable in the container unless at
282 least added to the index with ``git-add``.
283
284 If you do want to test changes to the Docker image, you can locally build the
285 image and run the tests without pulling from the registry using the following
286 commands:
287
288 .. code:: console
289
290 make topotests-build
291 TOPOTEST_PULL=0 make topotests
292
293
294 .. _topotests-guidelines:
295
296 Guidelines
297 ----------
298
299 Executing Tests
300 ^^^^^^^^^^^^^^^
301
302 To run the whole suite of tests the following commands must be executed at the
303 top level directory of topotest:
304
305 .. code:: shell
306
307 $ # Change to the top level directory of topotests.
308 $ cd path/to/topotests
309 $ # Tests must be run as root, since Mininet requires it.
310 $ sudo pytest
311
312 In order to run a specific test, you can use the following command:
313
314 .. code:: shell
315
316 $ # running a specific topology
317 $ sudo pytest ospf-topo1/
318 $ # or inside the test folder
319 $ cd ospf-topo1
320 $ sudo pytest # to run all tests inside the directory
321 $ sudo pytest test_ospf_topo1.py # to run a specific test
322 $ # or outside the test folder
323 $ cd ..
324 $ sudo pytest ospf-topo1/test_ospf_topo1.py # to run a specific one
325
326 The output of the tested daemons will be available at the temporary folder of
327 your machine:
328
329 .. code:: shell
330
331 $ ls /tmp/topotest/ospf-topo1.test_ospf-topo1/r1
332 ...
333 zebra.err # zebra stderr output
334 zebra.log # zebra log file
335 zebra.out # zebra stdout output
336 ...
337
338 You can also run memory leak tests to get reports:
339
340 .. code:: shell
341
342 $ # Set the environment variable to apply to a specific test...
343 $ sudo env TOPOTESTS_CHECK_MEMLEAK="/tmp/memleak_report_" pytest ospf-topo1/test_ospf_topo1.py
344 $ # ...or apply to all tests adding this line to the configuration file
345 $ echo 'memleak_path = /tmp/memleak_report_' >> pytest.ini
346 $ # You can also use your editor
347 $ $EDITOR pytest.ini
348 $ # After running tests you should see your files:
349 $ ls /tmp/memleak_report_*
350 memleak_report_test_ospf_topo1.txt
351
352 Writing a New Test
353 ^^^^^^^^^^^^^^^^^^
354
355 This section will guide you in all recommended steps to produce a standard
356 topology test.
357
358 This is the recommended test writing routine:
359
360 - Write a topology (Graphviz recommended)
361 - Obtain configuration files
362 - Write the test itself
363 - Format the new code using `black <https://github.com/psf/black>`_
364 - Create a Pull Request
365
366 Topotest File Hierarchy
367 """""""""""""""""""""""
368
369 Before starting to write any tests one must know the file hierarchy. The
370 repository hierarchy looks like this:
371
372 .. code:: shell
373
374 $ cd path/to/topotest
375 $ find ./*
376 ...
377 ./README.md # repository read me
378 ./GUIDELINES.md # this file
379 ./conftest.py # test hooks - pytest related functions
380 ./example-test # example test folder
381 ./example-test/__init__.py # python package marker - must always exist.
382 ./example-test/test_template.jpg # generated topology picture - see next section
383 ./example-test/test_template.dot # Graphviz dot file
384 ./example-test/test_template.py # the topology plus the test
385 ...
386 ./ospf-topo1 # the ospf topology test
387 ./ospf-topo1/r1 # router 1 configuration files
388 ./ospf-topo1/r1/zebra.conf # zebra configuration file
389 ./ospf-topo1/r1/ospfd.conf # ospf configuration file
390 ./ospf-topo1/r1/ospfroute.txt # 'show ip ospf' output reference file
391 # removed other for shortness sake
392 ...
393 ./lib # shared test/topology functions
394 ./lib/topogen.py # topogen implementation
395 ./lib/topotest.py # topotest implementation
396
397 Guidelines for creating/editing topotest:
398
399 - New topologies that don't fit the existing directories should create its own
400 - Always remember to add the ``__init__.py`` to new folders, this makes auto
401 complete engines and pylint happy
402 - Router (Quagga/FRR) specific code should go on topotest.py
403 - Generic/repeated router actions should have an abstraction in
404 topogen.TopoRouter.
405 - Generic/repeated non-router code should go to topotest.py
406 - pytest related code should go to conftest.py (e.g. specialized asserts)
407
408 Defining the Topology
409 """""""""""""""""""""
410
411 The first step to write a new test is to define the topology. This step can be
412 done in many ways, but the recommended is to use Graphviz to generate a drawing
413 of the topology. It allows us to see the topology graphically and to see the
414 names of equipment, links and addresses.
415
416 Here is an example of Graphviz dot file that generates the template topology
417 :file:`tests/topotests/example-test/test_template.dot` (the inlined code might
418 get outdated, please see the linked file)::
419
420 graph template {
421 label="template";
422
423 # Routers
424 r1 [
425 shape=doubleoctagon,
426 label="r1",
427 fillcolor="#f08080",
428 style=filled,
429 ];
430 r2 [
431 shape=doubleoctagon,
432 label="r2",
433 fillcolor="#f08080",
434 style=filled,
435 ];
436
437 # Switches
438 s1 [
439 shape=oval,
440 label="s1\n192.168.0.0/24",
441 fillcolor="#d0e0d0",
442 style=filled,
443 ];
444 s2 [
445 shape=oval,
446 label="s2\n192.168.1.0/24",
447 fillcolor="#d0e0d0",
448 style=filled,
449 ];
450
451 # Connections
452 r1 -- s1 [label="eth0\n.1"];
453
454 r1 -- s2 [label="eth1\n.100"];
455 r2 -- s2 [label="eth0\n.1"];
456 }
457
458 Here is the produced graph:
459
460 .. graphviz::
461
462 graph template {
463 label="template";
464
465 # Routers
466 r1 [
467 shape=doubleoctagon,
468 label="r1",
469 fillcolor="#f08080",
470 style=filled,
471 ];
472 r2 [
473 shape=doubleoctagon,
474 label="r2",
475 fillcolor="#f08080",
476 style=filled,
477 ];
478
479 # Switches
480 s1 [
481 shape=oval,
482 label="s1\n192.168.0.0/24",
483 fillcolor="#d0e0d0",
484 style=filled,
485 ];
486 s2 [
487 shape=oval,
488 label="s2\n192.168.1.0/24",
489 fillcolor="#d0e0d0",
490 style=filled,
491 ];
492
493 # Connections
494 r1 -- s1 [label="eth0\n.1"];
495
496 r1 -- s2 [label="eth1\n.100"];
497 r2 -- s2 [label="eth0\n.1"];
498 }
499
500 Generating / Obtaining Configuration Files
501 """"""""""""""""""""""""""""""""""""""""""
502
503 In order to get the configuration files or command output for each router, we
504 need to run the topology and execute commands in ``vtysh``. The quickest way to
505 achieve that is writing the topology building code and running the topology.
506
507 To bootstrap your test topology, do the following steps:
508
509 - Copy the template test
510
511 .. code:: shell
512
513 $ mkdir new-topo/
514 $ touch new-topo/__init__.py
515 $ cp example-test/test_template.py new-topo/test_new_topo.py
516
517 - Modify the template according to your dot file
518
519 Here is the template topology described in the previous section in python code:
520
521 .. code:: py
522
523 class TemplateTopo(Topo):
524 "Test topology builder"
525 def build(self, *_args, **_opts):
526 "Build function"
527 tgen = get_topogen(self)
528
529 # Create 2 routers
530 for routern in range(1, 3):
531 tgen.add_router('r{}'.format(routern))
532
533 # Create a switch with just one router connected to it to simulate a
534 # empty network.
535 switch = tgen.add_switch('s1')
536 switch.add_link(tgen.gears['r1'])
537
538 # Create a connection between r1 and r2
539 switch = tgen.add_switch('s2')
540 switch.add_link(tgen.gears['r1'])
541 switch.add_link(tgen.gears['r2'])
542
543 - Run the topology
544
545 Topogen allows us to run the topology without running any tests, you can do
546 that using the following example commands:
547
548 .. code:: shell
549
550 $ # Running your bootstraped topology
551 $ sudo pytest -s --topology-only new-topo/test_new_topo.py
552 $ # Running the test_template.py topology
553 $ sudo pytest -s --topology-only example-test/test_template.py
554 $ # Running the ospf_topo1.py topology
555 $ sudo pytest -s --topology-only ospf-topo1/test_ospf_topo1.py
556
557 Parameters explanation:
558
559 .. program:: pytest
560
561 .. option:: -s
562
563 Actives input/output capture. This is required by mininet in order to show
564 the interactive shell.
565
566 .. option:: --topology-only
567
568 Don't run any tests, just build the topology.
569
570 After executing the commands above, you should get the following terminal
571 output:
572
573 .. code:: shell
574
575 === test session starts ===
576 platform linux2 -- Python 2.7.12, pytest-3.1.2, py-1.4.34, pluggy-0.4.0
577 rootdir: /media/sf_src/topotests, inifile: pytest.ini
578 collected 3 items
579
580 ospf-topo1/test_ospf_topo1.py *** Starting controller
581
582 *** Starting 6 switches
583 switch1 switch2 switch3 switch4 switch5 switch6 ...
584 r2: frr zebra started
585 r2: frr ospfd started
586 r3: frr zebra started
587 r3: frr ospfd started
588 r1: frr zebra started
589 r1: frr ospfd started
590 r4: frr zebra started
591 r4: frr ospfd started
592 *** Starting CLI:
593 mininet>
594
595 The last line shows us that we are now using the Mininet CLI (Command Line
596 Interface), from here you can call your router ``vtysh`` or even bash.
597
598 Here are some commands example:
599
600 .. code:: shell
601
602 mininet> r1 ping 10.0.3.1
603 PING 10.0.3.1 (10.0.3.1) 56(84) bytes of data.
604 64 bytes from 10.0.3.1: icmp_seq=1 ttl=64 time=0.576 ms
605 64 bytes from 10.0.3.1: icmp_seq=2 ttl=64 time=0.083 ms
606 64 bytes from 10.0.3.1: icmp_seq=3 ttl=64 time=0.088 ms
607 ^C
608 --- 10.0.3.1 ping statistics ---
609 3 packets transmitted, 3 received, 0% packet loss, time 1998ms
610 rtt min/avg/max/mdev = 0.083/0.249/0.576/0.231 ms
611
612
613
614 mininet> r1 ping 10.0.3.3
615 PING 10.0.3.3 (10.0.3.3) 56(84) bytes of data.
616 64 bytes from 10.0.3.3: icmp_seq=1 ttl=64 time=2.87 ms
617 64 bytes from 10.0.3.3: icmp_seq=2 ttl=64 time=0.080 ms
618 64 bytes from 10.0.3.3: icmp_seq=3 ttl=64 time=0.091 ms
619 ^C
620 --- 10.0.3.3 ping statistics ---
621 3 packets transmitted, 3 received, 0% packet loss, time 2003ms
622 rtt min/avg/max/mdev = 0.080/1.014/2.872/1.313 ms
623
624
625
626 mininet> r3 vtysh
627
628 Hello, this is FRRouting (version 3.1-devrzalamena-build).
629 Copyright 1996-2005 Kunihiro Ishiguro, et al.
630
631 frr-1# show running-config
632 Building configuration...
633
634 Current configuration:
635 !
636 frr version 3.1-devrzalamena-build
637 frr defaults traditional
638 hostname r3
639 no service integrated-vtysh-config
640 !
641 log file zebra.log
642 !
643 log file ospfd.log
644 !
645 interface r3-eth0
646 ip address 10.0.3.1/24
647 !
648 interface r3-eth1
649 ip address 10.0.10.1/24
650 !
651 interface r3-eth2
652 ip address 172.16.0.2/24
653 !
654 router ospf
655 ospf router-id 10.0.255.3
656 redistribute kernel
657 redistribute connected
658 redistribute static
659 network 10.0.3.0/24 area 0
660 network 10.0.10.0/24 area 0
661 network 172.16.0.0/24 area 1
662 !
663 line vty
664 !
665 end
666 frr-1#
667
668 After you successfully configured your topology, you can obtain the
669 configuration files (per-daemon) using the following commands:
670
671 .. code:: shell
672
673 mininet> r3 vtysh -d ospfd
674
675 Hello, this is FRRouting (version 3.1-devrzalamena-build).
676 Copyright 1996-2005 Kunihiro Ishiguro, et al.
677
678 frr-1# show running-config
679 Building configuration...
680
681 Current configuration:
682 !
683 frr version 3.1-devrzalamena-build
684 frr defaults traditional
685 no service integrated-vtysh-config
686 !
687 log file ospfd.log
688 !
689 router ospf
690 ospf router-id 10.0.255.3
691 redistribute kernel
692 redistribute connected
693 redistribute static
694 network 10.0.3.0/24 area 0
695 network 10.0.10.0/24 area 0
696 network 172.16.0.0/24 area 1
697 !
698 line vty
699 !
700 end
701 frr-1#
702
703 Writing Tests
704 """""""""""""
705
706 Test topologies should always be bootstrapped from
707 :file:`tests/topotests/example-test/test_template.py` because it contains
708 important boilerplate code that can't be avoided, like:
709
710 - imports: os, sys, pytest, topotest/topogen and mininet topology class
711 - The global variable CWD (Current Working directory): which is most likely
712 going to be used to reference the routers configuration file location
713
714 Example:
715
716 .. code:: py
717
718 # For all registered routers, load the zebra configuration file
719 for rname, router in router_list.iteritems():
720 router.load_config(
721 TopoRouter.RD_ZEBRA,
722 os.path.join(CWD, '{}/zebra.conf'.format(rname))
723 )
724 # os.path.join() joins the CWD string with arguments adding the necessary
725 # slashes ('/'). Arguments must not begin with '/'.
726
727 - The topology class that inherits from Mininet Topo class:
728
729 .. code:: py
730
731 class TemplateTopo(Topo):
732 def build(self, *_args, **_opts):
733 tgen = get_topogen(self)
734 # topology build code
735
736 - pytest ``setup_module()`` and ``teardown_module()`` to start the topology
737
738 .. code:: py
739
740 def setup_module(_m):
741 tgen = Topogen(TemplateTopo)
742 tgen.start_topology('debug')
743
744 def teardown_module(_m):
745 tgen = get_topogen()
746 tgen.stop_topology()
747
748 - ``__main__`` initialization code (to support running the script directly)
749
750 .. code:: py
751
752 if __name__ == '__main__':
753 sys.exit(pytest.main(["-s"]))
754
755 Requirements:
756
757 - Test code should always be declared inside functions that begin with the
758 ``test_`` prefix. Functions beginning with different prefixes will not be run
759 by pytest.
760 - Configuration files and long output commands should go into separated files
761 inside folders named after the equipment.
762 - Tests must be able to run without any interaction. To make sure your test
763 conforms with this, run it without the :option:`-s` parameter.
764 - Use `black <https://github.com/psf/black>`_ code formatter before creating
765 a pull request. This ensures we have a unified code style.
766
767 Tips:
768
769 - Keep results in stack variables, so people inspecting code with ``pdb`` can
770 easily print their values.
771
772 Don't do this:
773
774 .. code:: py
775
776 assert foobar(router1, router2)
777
778 Do this instead:
779
780 .. code:: py
781
782 result = foobar(router1, router2)
783 assert result
784
785 - Use ``assert`` messages to indicate where the test failed.
786
787 Example:
788
789 .. code:: py
790
791 for router in router_list:
792 # ...
793 assert condition, 'Router "{}" condition failed'.format(router.name)
794
795 Debugging Execution
796 ^^^^^^^^^^^^^^^^^^^
797
798 The most effective ways to inspect topology tests are:
799
800 - Run pytest with ``--pdb`` option. This option will cause a pdb shell to
801 appear when an assertion fails
802
803 Example: ``pytest -s --pdb ospf-topo1/test_ospf_topo1.py``
804
805 - Set a breakpoint in the test code with ``pdb``
806
807 Example:
808
809 .. code:: py
810
811 # Add the pdb import at the beginning of the file
812 import pdb
813 # ...
814
815 # Add a breakpoint where you think the problem is
816 def test_bla():
817 # ...
818 pdb.set_trace()
819 # ...
820
821 The `Python Debugger <https://docs.python.org/2.7/library/pdb.html>`__ (pdb)
822 shell allows us to run many useful operations like:
823
824 - Setting breaking point on file/function/conditions (e.g. ``break``,
825 ``condition``)
826 - Inspecting variables (e.g. ``p`` (print), ``pp`` (pretty print))
827 - Running python code
828
829 .. tip::
830
831 The TopoGear (equipment abstraction class) implements the ``__str__`` method
832 that allows the user to inspect equipment information.
833
834 Example of pdb usage:
835
836 .. code:: shell
837
838 > /media/sf_src/topotests/ospf-topo1/test_ospf_topo1.py(121)test_ospf_convergence()
839 -> for rnum in range(1, 5):
840 (Pdb) help
841 Documented commands (type help <topic>):
842 ========================================
843 EOF bt cont enable jump pp run unt
844 a c continue exit l q s until
845 alias cl d h list quit step up
846 args clear debug help n r tbreak w
847 b commands disable ignore next restart u whatis
848 break condition down j p return unalias where
849
850 Miscellaneous help topics:
851 ==========================
852 exec pdb
853
854 Undocumented commands:
855 ======================
856 retval rv
857
858 (Pdb) list
859 116 title2="Expected output")
860 117
861 118 def test_ospf_convergence():
862 119 "Test OSPF daemon convergence"
863 120 pdb.set_trace()
864 121 -> for rnum in range(1, 5):
865 122 router = 'r{}'.format(rnum)
866 123
867 124 # Load expected results from the command
868 125 reffile = os.path.join(CWD, '{}/ospfroute.txt'.format(router))
869 126 expected = open(reffile).read()
870 (Pdb) step
871 > /media/sf_src/topotests/ospf-topo1/test_ospf_topo1.py(122)test_ospf_convergence()
872 -> router = 'r{}'.format(rnum)
873 (Pdb) step
874 > /media/sf_src/topotests/ospf-topo1/test_ospf_topo1.py(125)test_ospf_convergence()
875 -> reffile = os.path.join(CWD, '{}/ospfroute.txt'.format(router))
876 (Pdb) print rnum
877 1
878 (Pdb) print router
879 r1
880 (Pdb) tgen = get_topogen()
881 (Pdb) pp tgen.gears[router]
882 <lib.topogen.TopoRouter object at 0x7f74e06c9850>
883 (Pdb) pp str(tgen.gears[router])
884 'TopoGear<name="r1",links=["r1-eth0"<->"s1-eth0","r1-eth1"<->"s3-eth0"]> TopoRouter<>'
885 (Pdb) l 125
886 120 pdb.set_trace()
887 121 for rnum in range(1, 5):
888 122 router = 'r{}'.format(rnum)
889 123
890 124 # Load expected results from the command
891 125 -> reffile = os.path.join(CWD, '{}/ospfroute.txt'.format(router))
892 126 expected = open(reffile).read()
893 127
894 128 # Run test function until we get an result. Wait at most 60 seconds.
895 129 test_func = partial(compare_show_ip_ospf, router, expected)
896 130 result, diff = topotest.run_and_expect(test_func, '',
897 (Pdb) router1 = tgen.gears[router]
898 (Pdb) router1.vtysh_cmd('show ip ospf route')
899 '============ OSPF network routing table ============\r\nN 10.0.1.0/24 [10] area: 0.0.0.0\r\n directly attached to r1-eth0\r\nN 10.0.2.0/24 [20] area: 0.0.0.0\r\n via 10.0.3.3, r1-eth1\r\nN 10.0.3.0/24 [10] area: 0.0.0.0\r\n directly attached to r1-eth1\r\nN 10.0.10.0/24 [20] area: 0.0.0.0\r\n via 10.0.3.1, r1-eth1\r\nN IA 172.16.0.0/24 [20] area: 0.0.0.0\r\n via 10.0.3.1, r1-eth1\r\nN IA 172.16.1.0/24 [30] area: 0.0.0.0\r\n via 10.0.3.1, r1-eth1\r\n\r\n============ OSPF router routing table =============\r\nR 10.0.255.2 [10] area: 0.0.0.0, ASBR\r\n via 10.0.3.3, r1-eth1\r\nR 10.0.255.3 [10] area: 0.0.0.0, ABR, ASBR\r\n via 10.0.3.1, r1-eth1\r\nR 10.0.255.4 IA [20] area: 0.0.0.0, ASBR\r\n via 10.0.3.1, r1-eth1\r\n\r\n============ OSPF external routing table ===========\r\n\r\n\r\n'
900 (Pdb) tgen.mininet_cli()
901 *** Starting CLI:
902 mininet>
903
904 To enable more debug messages in other Topogen subsystems (like Mininet), more
905 logging messages can be displayed by modifying the test configuration file
906 ``pytest.ini``:
907
908 .. code:: ini
909
910 [topogen]
911 # Change the default verbosity line from 'info'...
912 #verbosity = info
913 # ...to 'debug'
914 verbosity = debug
915
916 Instructions for use, write or debug topologies can be found in :ref:`topotests-guidelines`.
917 To learn/remember common code snippets see :ref:`topotests-snippets`.
918
919 Before creating a new topology, make sure that there isn't one already that
920 does what you need. If nothing is similar, then you may create a new topology,
921 preferably, using the newest template
922 (:file:`tests/topotests/example-test/test_template.py`).
923
924 .. include:: topotests-snippets.rst
925
926 License
927 -------
928
929 All the configs and scripts are licensed under a ISC-style license. See Python
930 scripts for details.