2 * Copyright © 2013 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
21 * DEALINGS IN THE SOFTWARE.
23 * Author: Jani Nikula <jani.nikula@intel.com>
27 #include <drm/drm_crtc.h>
28 #include <drm/drm_edid.h>
29 #include <drm/i915_drm.h>
30 #include <linux/slab.h>
32 #include "intel_drv.h"
33 #include "intel_dsi.h"
34 #include "intel_dsi_cmd.h"
36 /* the sub-encoders aka panel drivers */
37 static const struct intel_dsi_device intel_dsi_devices
[] = {
41 static void vlv_cck_modify(struct drm_i915_private
*dev_priv
, u32 reg
, u32 val
,
44 u32 tmp
= vlv_cck_read(dev_priv
, reg
);
47 vlv_cck_write(dev_priv
, reg
, tmp
);
50 static void band_gap_wa(struct drm_i915_private
*dev_priv
)
52 mutex_lock(&dev_priv
->dpio_lock
);
54 /* Enable bandgap fix in GOP driver */
55 vlv_cck_modify(dev_priv
, 0x6D, 0x00010000, 0x00030000);
57 vlv_cck_modify(dev_priv
, 0x6E, 0x00010000, 0x00030000);
59 vlv_cck_modify(dev_priv
, 0x6F, 0x00010000, 0x00030000);
61 vlv_cck_modify(dev_priv
, 0x00, 0x00008000, 0x00008000);
63 vlv_cck_modify(dev_priv
, 0x00, 0x00000000, 0x00008000);
66 /* Turn Display Trunk on */
67 vlv_cck_modify(dev_priv
, 0x6B, 0x00020000, 0x00030000);
70 vlv_cck_modify(dev_priv
, 0x6C, 0x00020000, 0x00030000);
73 vlv_cck_modify(dev_priv
, 0x6D, 0x00020000, 0x00030000);
75 vlv_cck_modify(dev_priv
, 0x6E, 0x00020000, 0x00030000);
77 vlv_cck_modify(dev_priv
, 0x6F, 0x00020000, 0x00030000);
79 mutex_unlock(&dev_priv
->dpio_lock
);
81 /* Need huge delay, otherwise clock is not stable */
85 static struct intel_dsi
*intel_attached_dsi(struct drm_connector
*connector
)
87 return container_of(intel_attached_encoder(connector
),
88 struct intel_dsi
, base
);
91 static inline bool is_vid_mode(struct intel_dsi
*intel_dsi
)
93 return intel_dsi
->dev
.type
== INTEL_DSI_VIDEO_MODE
;
96 static inline bool is_cmd_mode(struct intel_dsi
*intel_dsi
)
98 return intel_dsi
->dev
.type
== INTEL_DSI_COMMAND_MODE
;
101 static void intel_dsi_hot_plug(struct intel_encoder
*encoder
)
106 static bool intel_dsi_compute_config(struct intel_encoder
*encoder
,
107 struct intel_crtc_config
*config
)
109 struct intel_dsi
*intel_dsi
= container_of(encoder
, struct intel_dsi
,
111 struct intel_connector
*intel_connector
= intel_dsi
->attached_connector
;
112 struct drm_display_mode
*fixed_mode
= intel_connector
->panel
.fixed_mode
;
113 struct drm_display_mode
*adjusted_mode
= &config
->adjusted_mode
;
114 struct drm_display_mode
*mode
= &config
->requested_mode
;
119 intel_fixed_panel_mode(fixed_mode
, adjusted_mode
);
121 if (intel_dsi
->dev
.dev_ops
->mode_fixup
)
122 return intel_dsi
->dev
.dev_ops
->mode_fixup(&intel_dsi
->dev
,
123 mode
, adjusted_mode
);
128 static void intel_dsi_pre_pll_enable(struct intel_encoder
*encoder
)
132 vlv_enable_dsi_pll(encoder
);
135 static void intel_dsi_pre_enable(struct intel_encoder
*encoder
)
140 static void intel_dsi_enable(struct intel_encoder
*encoder
)
142 struct drm_i915_private
*dev_priv
= encoder
->base
.dev
->dev_private
;
143 struct intel_crtc
*intel_crtc
= to_intel_crtc(encoder
->base
.crtc
);
144 struct intel_dsi
*intel_dsi
= enc_to_intel_dsi(&encoder
->base
);
145 int pipe
= intel_crtc
->pipe
;
150 if (intel_dsi
->dev
.dev_ops
->panel_reset
)
151 intel_dsi
->dev
.dev_ops
->panel_reset(&intel_dsi
->dev
);
153 temp
= I915_READ(MIPI_DEVICE_READY(pipe
));
154 if ((temp
& DEVICE_READY
) == 0) {
155 temp
&= ~ULPS_STATE_MASK
;
156 I915_WRITE(MIPI_DEVICE_READY(pipe
), temp
| DEVICE_READY
);
157 } else if (temp
& ULPS_STATE_MASK
) {
158 temp
&= ~ULPS_STATE_MASK
;
159 I915_WRITE(MIPI_DEVICE_READY(pipe
), temp
| ULPS_STATE_EXIT
);
161 * We need to ensure that there is a minimum of 1 ms time
162 * available before clearing the UPLS exit state.
165 I915_WRITE(MIPI_DEVICE_READY(pipe
), temp
);
168 if (intel_dsi
->dev
.dev_ops
->send_otp_cmds
)
169 intel_dsi
->dev
.dev_ops
->send_otp_cmds(&intel_dsi
->dev
);
171 if (is_cmd_mode(intel_dsi
))
172 I915_WRITE(MIPI_MAX_RETURN_PKT_SIZE(pipe
), 8 * 4);
174 if (is_vid_mode(intel_dsi
)) {
175 msleep(20); /* XXX */
176 dpi_send_cmd(intel_dsi
, TURN_ON
);
179 /* assert ip_tg_enable signal */
180 temp
= I915_READ(MIPI_PORT_CTRL(pipe
));
181 I915_WRITE(MIPI_PORT_CTRL(pipe
), temp
| DPI_ENABLE
);
182 POSTING_READ(MIPI_PORT_CTRL(pipe
));
185 if (intel_dsi
->dev
.dev_ops
->enable
)
186 intel_dsi
->dev
.dev_ops
->enable(&intel_dsi
->dev
);
189 static void intel_dsi_disable(struct intel_encoder
*encoder
)
191 struct drm_i915_private
*dev_priv
= encoder
->base
.dev
->dev_private
;
192 struct intel_crtc
*intel_crtc
= to_intel_crtc(encoder
->base
.crtc
);
193 struct intel_dsi
*intel_dsi
= enc_to_intel_dsi(&encoder
->base
);
194 int pipe
= intel_crtc
->pipe
;
199 intel_dsi
->dev
.dev_ops
->disable(&intel_dsi
->dev
);
201 if (is_vid_mode(intel_dsi
)) {
202 dpi_send_cmd(intel_dsi
, SHUTDOWN
);
205 /* de-assert ip_tg_enable signal */
206 temp
= I915_READ(MIPI_PORT_CTRL(pipe
));
207 I915_WRITE(MIPI_PORT_CTRL(pipe
), temp
& ~DPI_ENABLE
);
208 POSTING_READ(MIPI_PORT_CTRL(pipe
));
213 temp
= I915_READ(MIPI_DEVICE_READY(pipe
));
214 if (temp
& DEVICE_READY
) {
215 temp
&= ~DEVICE_READY
;
216 temp
&= ~ULPS_STATE_MASK
;
217 I915_WRITE(MIPI_DEVICE_READY(pipe
), temp
);
221 static void intel_dsi_post_disable(struct intel_encoder
*encoder
)
225 vlv_disable_dsi_pll(encoder
);
228 static bool intel_dsi_get_hw_state(struct intel_encoder
*encoder
,
231 struct drm_i915_private
*dev_priv
= encoder
->base
.dev
->dev_private
;
237 /* XXX: this only works for one DSI output */
238 for (p
= PIPE_A
; p
<= PIPE_B
; p
++) {
239 port
= I915_READ(MIPI_PORT_CTRL(p
));
240 func
= I915_READ(MIPI_DSI_FUNC_PRG(p
));
242 if ((port
& DPI_ENABLE
) || (func
& CMD_MODE_DATA_WIDTH_MASK
)) {
243 if (I915_READ(MIPI_DEVICE_READY(p
)) & DEVICE_READY
) {
253 static void intel_dsi_get_config(struct intel_encoder
*encoder
,
254 struct intel_crtc_config
*pipe_config
)
258 /* XXX: read flags, set to adjusted_mode */
261 static enum drm_mode_status
262 intel_dsi_mode_valid(struct drm_connector
*connector
,
263 struct drm_display_mode
*mode
)
265 struct intel_connector
*intel_connector
= to_intel_connector(connector
);
266 struct drm_display_mode
*fixed_mode
= intel_connector
->panel
.fixed_mode
;
267 struct intel_dsi
*intel_dsi
= intel_attached_dsi(connector
);
271 if (mode
->flags
& DRM_MODE_FLAG_DBLSCAN
) {
272 DRM_DEBUG_KMS("MODE_NO_DBLESCAN\n");
273 return MODE_NO_DBLESCAN
;
277 if (mode
->hdisplay
> fixed_mode
->hdisplay
)
279 if (mode
->vdisplay
> fixed_mode
->vdisplay
)
283 return intel_dsi
->dev
.dev_ops
->mode_valid(&intel_dsi
->dev
, mode
);
286 /* return txclkesc cycles in terms of divider and duration in us */
287 static u16
txclkesc(u32 divider
, unsigned int us
)
290 case ESCAPE_CLOCK_DIVIDER_1
:
293 case ESCAPE_CLOCK_DIVIDER_2
:
295 case ESCAPE_CLOCK_DIVIDER_4
:
300 /* return pixels in terms of txbyteclkhs */
301 static u16
txbyteclkhs(u16 pixels
, int bpp
, int lane_count
)
303 return DIV_ROUND_UP(DIV_ROUND_UP(pixels
* bpp
, 8), lane_count
);
306 static void set_dsi_timings(struct drm_encoder
*encoder
,
307 const struct drm_display_mode
*mode
)
309 struct drm_device
*dev
= encoder
->dev
;
310 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
311 struct intel_crtc
*intel_crtc
= to_intel_crtc(encoder
->crtc
);
312 struct intel_dsi
*intel_dsi
= enc_to_intel_dsi(encoder
);
313 int pipe
= intel_crtc
->pipe
;
314 unsigned int bpp
= intel_crtc
->config
.pipe_bpp
;
315 unsigned int lane_count
= intel_dsi
->lane_count
;
317 u16 hactive
, hfp
, hsync
, hbp
, vfp
, vsync
, vbp
;
319 hactive
= mode
->hdisplay
;
320 hfp
= mode
->hsync_start
- mode
->hdisplay
;
321 hsync
= mode
->hsync_end
- mode
->hsync_start
;
322 hbp
= mode
->htotal
- mode
->hsync_end
;
324 vfp
= mode
->vsync_start
- mode
->vdisplay
;
325 vsync
= mode
->vsync_end
- mode
->vsync_start
;
326 vbp
= mode
->vtotal
- mode
->vsync_end
;
328 /* horizontal values are in terms of high speed byte clock */
329 hactive
= txbyteclkhs(hactive
, bpp
, lane_count
);
330 hfp
= txbyteclkhs(hfp
, bpp
, lane_count
);
331 hsync
= txbyteclkhs(hsync
, bpp
, lane_count
);
332 hbp
= txbyteclkhs(hbp
, bpp
, lane_count
);
334 I915_WRITE(MIPI_HACTIVE_AREA_COUNT(pipe
), hactive
);
335 I915_WRITE(MIPI_HFP_COUNT(pipe
), hfp
);
337 /* meaningful for video mode non-burst sync pulse mode only, can be zero
338 * for non-burst sync events and burst modes */
339 I915_WRITE(MIPI_HSYNC_PADDING_COUNT(pipe
), hsync
);
340 I915_WRITE(MIPI_HBP_COUNT(pipe
), hbp
);
342 /* vertical values are in terms of lines */
343 I915_WRITE(MIPI_VFP_COUNT(pipe
), vfp
);
344 I915_WRITE(MIPI_VSYNC_PADDING_COUNT(pipe
), vsync
);
345 I915_WRITE(MIPI_VBP_COUNT(pipe
), vbp
);
348 static void intel_dsi_mode_set(struct intel_encoder
*intel_encoder
)
350 struct drm_encoder
*encoder
= &intel_encoder
->base
;
351 struct drm_device
*dev
= encoder
->dev
;
352 struct drm_i915_private
*dev_priv
= dev
->dev_private
;
353 struct intel_crtc
*intel_crtc
= to_intel_crtc(encoder
->crtc
);
354 struct intel_dsi
*intel_dsi
= enc_to_intel_dsi(encoder
);
355 struct drm_display_mode
*adjusted_mode
=
356 &intel_crtc
->config
.adjusted_mode
;
357 int pipe
= intel_crtc
->pipe
;
358 unsigned int bpp
= intel_crtc
->config
.pipe_bpp
;
361 DRM_DEBUG_KMS("pipe %c\n", pipe_name(pipe
));
363 /* Update the DSI PLL */
364 vlv_enable_dsi_pll(intel_encoder
);
366 /* XXX: Location of the call */
367 band_gap_wa(dev_priv
);
369 /* escape clock divider, 20MHz, shared for A and C. device ready must be
370 * off when doing this! txclkesc? */
371 tmp
= I915_READ(MIPI_CTRL(0));
372 tmp
&= ~ESCAPE_CLOCK_DIVIDER_MASK
;
373 I915_WRITE(MIPI_CTRL(0), tmp
| ESCAPE_CLOCK_DIVIDER_1
);
375 /* read request priority is per pipe */
376 tmp
= I915_READ(MIPI_CTRL(pipe
));
377 tmp
&= ~READ_REQUEST_PRIORITY_MASK
;
378 I915_WRITE(MIPI_CTRL(pipe
), tmp
| READ_REQUEST_PRIORITY_HIGH
);
380 /* XXX: why here, why like this? handling in irq handler?! */
381 I915_WRITE(MIPI_INTR_STAT(pipe
), 0xffffffff);
382 I915_WRITE(MIPI_INTR_EN(pipe
), 0xffffffff);
384 I915_WRITE(MIPI_DPHY_PARAM(pipe
),
385 0x3c << EXIT_ZERO_COUNT_SHIFT
|
386 0x1f << TRAIL_COUNT_SHIFT
|
387 0xc5 << CLK_ZERO_COUNT_SHIFT
|
388 0x1f << PREPARE_COUNT_SHIFT
);
390 I915_WRITE(MIPI_DPI_RESOLUTION(pipe
),
391 adjusted_mode
->vdisplay
<< VERTICAL_ADDRESS_SHIFT
|
392 adjusted_mode
->hdisplay
<< HORIZONTAL_ADDRESS_SHIFT
);
394 set_dsi_timings(encoder
, adjusted_mode
);
396 val
= intel_dsi
->lane_count
<< DATA_LANES_PRG_REG_SHIFT
;
397 if (is_cmd_mode(intel_dsi
)) {
398 val
|= intel_dsi
->channel
<< CMD_MODE_CHANNEL_NUMBER_SHIFT
;
399 val
|= CMD_MODE_DATA_WIDTH_8_BIT
; /* XXX */
401 val
|= intel_dsi
->channel
<< VID_MODE_CHANNEL_NUMBER_SHIFT
;
403 /* XXX: cross-check bpp vs. pixel format? */
404 val
|= intel_dsi
->pixel_format
;
406 I915_WRITE(MIPI_DSI_FUNC_PRG(pipe
), val
);
408 /* timeouts for recovery. one frame IIUC. if counter expires, EOT and
412 * In burst mode, value greater than one DPI line Time in byte clock
413 * (txbyteclkhs) To timeout this timer 1+ of the above said value is
416 * In non-burst mode, Value greater than one DPI frame time in byte
417 * clock(txbyteclkhs) To timeout this timer 1+ of the above said value
420 * In DBI only mode, value greater than one DBI frame time in byte
421 * clock(txbyteclkhs) To timeout this timer 1+ of the above said value
425 if (is_vid_mode(intel_dsi
) &&
426 intel_dsi
->video_mode_format
== VIDEO_MODE_BURST
) {
427 I915_WRITE(MIPI_HS_TX_TIMEOUT(pipe
),
428 txbyteclkhs(adjusted_mode
->htotal
, bpp
,
429 intel_dsi
->lane_count
) + 1);
431 I915_WRITE(MIPI_HS_TX_TIMEOUT(pipe
),
432 txbyteclkhs(adjusted_mode
->vtotal
*
433 adjusted_mode
->htotal
,
434 bpp
, intel_dsi
->lane_count
) + 1);
436 I915_WRITE(MIPI_LP_RX_TIMEOUT(pipe
), 8309); /* max */
437 I915_WRITE(MIPI_TURN_AROUND_TIMEOUT(pipe
), 0x14); /* max */
438 I915_WRITE(MIPI_DEVICE_RESET_TIMER(pipe
), 0xffff); /* max */
442 /* in terms of low power clock */
443 I915_WRITE(MIPI_INIT_COUNT(pipe
), txclkesc(ESCAPE_CLOCK_DIVIDER_1
, 100));
445 /* recovery disables */
446 I915_WRITE(MIPI_EOT_DISABLE(pipe
), intel_dsi
->eot_disable
);
448 /* in terms of txbyteclkhs. actual high to low switch +
449 * MIPI_STOP_STATE_STALL * MIPI_LP_BYTECLK.
451 * XXX: write MIPI_STOP_STATE_STALL?
453 I915_WRITE(MIPI_HIGH_LOW_SWITCH_COUNT(pipe
), 0x46);
455 /* XXX: low power clock equivalence in terms of byte clock. the number
456 * of byte clocks occupied in one low power clock. based on txbyteclkhs
457 * and txclkesc. txclkesc time / txbyteclk time * (105 +
458 * MIPI_STOP_STATE_STALL) / 105.???
460 I915_WRITE(MIPI_LP_BYTECLK(pipe
), 4);
462 /* the bw essential for transmitting 16 long packets containing 252
463 * bytes meant for dcs write memory command is programmed in this
464 * register in terms of byte clocks. based on dsi transfer rate and the
465 * number of lanes configured the time taken to transmit 16 long packets
466 * in a dsi stream varies. */
467 I915_WRITE(MIPI_DBI_BW_CTRL(pipe
), 0x820);
469 I915_WRITE(MIPI_CLK_LANE_SWITCH_TIME_CNT(pipe
),
470 0xa << LP_HS_SSW_CNT_SHIFT
|
471 0x14 << HS_LP_PWR_SW_CNT_SHIFT
);
473 if (is_vid_mode(intel_dsi
))
474 I915_WRITE(MIPI_VIDEO_MODE_FORMAT(pipe
),
475 intel_dsi
->video_mode_format
);
478 static enum drm_connector_status
479 intel_dsi_detect(struct drm_connector
*connector
, bool force
)
481 struct intel_dsi
*intel_dsi
= intel_attached_dsi(connector
);
483 return intel_dsi
->dev
.dev_ops
->detect(&intel_dsi
->dev
);
486 static int intel_dsi_get_modes(struct drm_connector
*connector
)
488 struct intel_connector
*intel_connector
= to_intel_connector(connector
);
489 struct drm_display_mode
*mode
;
493 if (!intel_connector
->panel
.fixed_mode
) {
494 DRM_DEBUG_KMS("no fixed mode\n");
498 mode
= drm_mode_duplicate(connector
->dev
,
499 intel_connector
->panel
.fixed_mode
);
501 DRM_DEBUG_KMS("drm_mode_duplicate failed\n");
505 drm_mode_probed_add(connector
, mode
);
509 static void intel_dsi_destroy(struct drm_connector
*connector
)
511 struct intel_connector
*intel_connector
= to_intel_connector(connector
);
514 intel_panel_fini(&intel_connector
->panel
);
515 drm_connector_cleanup(connector
);
519 static const struct drm_encoder_funcs intel_dsi_funcs
= {
520 .destroy
= intel_encoder_destroy
,
523 static const struct drm_connector_helper_funcs intel_dsi_connector_helper_funcs
= {
524 .get_modes
= intel_dsi_get_modes
,
525 .mode_valid
= intel_dsi_mode_valid
,
526 .best_encoder
= intel_best_encoder
,
529 static const struct drm_connector_funcs intel_dsi_connector_funcs
= {
530 .dpms
= intel_connector_dpms
,
531 .detect
= intel_dsi_detect
,
532 .destroy
= intel_dsi_destroy
,
533 .fill_modes
= drm_helper_probe_single_connector_modes
,
536 bool intel_dsi_init(struct drm_device
*dev
)
538 struct intel_dsi
*intel_dsi
;
539 struct intel_encoder
*intel_encoder
;
540 struct drm_encoder
*encoder
;
541 struct intel_connector
*intel_connector
;
542 struct drm_connector
*connector
;
543 struct drm_display_mode
*fixed_mode
= NULL
;
544 const struct intel_dsi_device
*dsi
;
549 intel_dsi
= kzalloc(sizeof(*intel_dsi
), GFP_KERNEL
);
553 intel_connector
= kzalloc(sizeof(*intel_connector
), GFP_KERNEL
);
554 if (!intel_connector
) {
559 intel_encoder
= &intel_dsi
->base
;
560 encoder
= &intel_encoder
->base
;
561 intel_dsi
->attached_connector
= intel_connector
;
563 connector
= &intel_connector
->base
;
565 drm_encoder_init(dev
, encoder
, &intel_dsi_funcs
, DRM_MODE_ENCODER_DSI
);
567 /* XXX: very likely not all of these are needed */
568 intel_encoder
->hot_plug
= intel_dsi_hot_plug
;
569 intel_encoder
->compute_config
= intel_dsi_compute_config
;
570 intel_encoder
->pre_pll_enable
= intel_dsi_pre_pll_enable
;
571 intel_encoder
->pre_enable
= intel_dsi_pre_enable
;
572 intel_encoder
->enable
= intel_dsi_enable
;
573 intel_encoder
->mode_set
= intel_dsi_mode_set
;
574 intel_encoder
->disable
= intel_dsi_disable
;
575 intel_encoder
->post_disable
= intel_dsi_post_disable
;
576 intel_encoder
->get_hw_state
= intel_dsi_get_hw_state
;
577 intel_encoder
->get_config
= intel_dsi_get_config
;
579 intel_connector
->get_hw_state
= intel_connector_get_hw_state
;
581 for (i
= 0; i
< ARRAY_SIZE(intel_dsi_devices
); i
++) {
582 dsi
= &intel_dsi_devices
[i
];
583 intel_dsi
->dev
= *dsi
;
585 if (dsi
->dev_ops
->init(&intel_dsi
->dev
))
589 if (i
== ARRAY_SIZE(intel_dsi_devices
)) {
590 DRM_DEBUG_KMS("no device found\n");
594 intel_encoder
->type
= INTEL_OUTPUT_DSI
;
595 intel_encoder
->crtc_mask
= (1 << 0); /* XXX */
597 intel_encoder
->cloneable
= false;
598 drm_connector_init(dev
, connector
, &intel_dsi_connector_funcs
,
599 DRM_MODE_CONNECTOR_DSI
);
601 drm_connector_helper_add(connector
, &intel_dsi_connector_helper_funcs
);
603 connector
->display_info
.subpixel_order
= SubPixelHorizontalRGB
; /*XXX*/
604 connector
->interlace_allowed
= false;
605 connector
->doublescan_allowed
= false;
607 intel_connector_attach_encoder(intel_connector
, intel_encoder
);
609 drm_sysfs_connector_add(connector
);
611 fixed_mode
= dsi
->dev_ops
->get_modes(&intel_dsi
->dev
);
613 DRM_DEBUG_KMS("no fixed mode\n");
617 fixed_mode
->type
|= DRM_MODE_TYPE_PREFERRED
;
618 intel_panel_init(&intel_connector
->panel
, fixed_mode
);
623 drm_encoder_cleanup(&intel_encoder
->base
);
625 kfree(intel_connector
);