hw/acpi/memory_hotplug.c

   1 #include "qemu/osdep.h"
   2 #include "hw/acpi/memory_hotplug.h"
   3 #include "hw/acpi/pc-hotplug.h"
   4 #include "hw/mem/pc-dimm.h"
   5 #include "hw/boards.h"
   6 #include "hw/qdev-core.h"
   7 #include "trace.h"
   8 #include "qapi-event.h"
   9
  10 static ACPIOSTInfo *acpi_memory_device_status(int slot, MemStatus *mdev)
  11 {
  12     ACPIOSTInfo *info = g_new0(ACPIOSTInfo, 1);
  13
  14     info->slot_type = ACPI_SLOT_TYPE_DIMM;
  15     info->slot = g_strdup_printf("%d", slot);
  16     info->source = mdev->ost_event;
  17     info->status = mdev->ost_status;
  18     if (mdev->dimm) {
  19         DeviceState *dev = DEVICE(mdev->dimm);
  20         if (dev->id) {
  21             info->device = g_strdup(dev->id);
  22             info->has_device = true;
  23         }
  24     }
  25     return info;
  26 }
  27
  28 void acpi_memory_ospm_status(MemHotplugState *mem_st, ACPIOSTInfoList ***list)
  29 {
  30     int i;
  31
  32     for (i = 0; i < mem_st->dev_count; i++) {
  33         ACPIOSTInfoList *elem = g_new0(ACPIOSTInfoList, 1);
  34         elem->value = acpi_memory_device_status(i, &mem_st->devs[i]);
  35         elem->next = NULL;
  36         **list = elem;
  37         *list = &elem->next;
  38     }
  39 }
  40
  41 static uint64_t acpi_memory_hotplug_read(void *opaque, hwaddr addr,
  42                                          unsigned int size)
  43 {
  44     uint32_t val = 0;
  45     MemHotplugState *mem_st = opaque;
  46     MemStatus *mdev;
  47     Object *o;
  48
  49     if (mem_st->selector >= mem_st->dev_count) {
  50         trace_mhp_acpi_invalid_slot_selected(mem_st->selector);
  51         return 0;
  52     }
  53
  54     mdev = &mem_st->devs[mem_st->selector];
  55     o = OBJECT(mdev->dimm);
  56     switch (addr) {
  57     case 0x0: /* Lo part of phys address where DIMM is mapped */
  58         val = o ? object_property_get_int(o, PC_DIMM_ADDR_PROP, NULL) : 0;
  59         trace_mhp_acpi_read_addr_lo(mem_st->selector, val);
  60         break;
  61     case 0x4: /* Hi part of phys address where DIMM is mapped */
  62         val = o ? object_property_get_int(o, PC_DIMM_ADDR_PROP, NULL) >> 32 : 0;
  63         trace_mhp_acpi_read_addr_hi(mem_st->selector, val);
  64         break;
  65     case 0x8: /* Lo part of DIMM size */
  66         val = o ? object_property_get_int(o, PC_DIMM_SIZE_PROP, NULL) : 0;
  67         trace_mhp_acpi_read_size_lo(mem_st->selector, val);
  68         break;
  69     case 0xc: /* Hi part of DIMM size */
  70         val = o ? object_property_get_int(o, PC_DIMM_SIZE_PROP, NULL) >> 32 : 0;
  71         trace_mhp_acpi_read_size_hi(mem_st->selector, val);
  72         break;
  73     case 0x10: /* node proximity for _PXM method */
  74         val = o ? object_property_get_int(o, PC_DIMM_NODE_PROP, NULL) : 0;
  75         trace_mhp_acpi_read_pxm(mem_st->selector, val);
  76         break;
  77     case 0x14: /* pack and return is_* fields */
  78         val |= mdev->is_enabled   ? 1 : 0;
  79         val |= mdev->is_inserting ? 2 : 0;
  80         val |= mdev->is_removing  ? 4 : 0;
  81         trace_mhp_acpi_read_flags(mem_st->selector, val);
  82         break;
  83     default:
  84         val = ~0;
  85         break;
  86     }
  87     return val;
  88 }
  89
  90 static void acpi_memory_hotplug_write(void *opaque, hwaddr addr, uint64_t data,
  91                                       unsigned int size)
  92 {
  93     MemHotplugState *mem_st = opaque;
  94     MemStatus *mdev;
  95     ACPIOSTInfo *info;
  96     DeviceState *dev = NULL;
  97     HotplugHandler *hotplug_ctrl = NULL;
  98     Error *local_err = NULL;
  99
 100     if (!mem_st->dev_count) {
 101         return;
 102     }
 103
 104     if (addr) {
 105         if (mem_st->selector >= mem_st->dev_count) {
 106             trace_mhp_acpi_invalid_slot_selected(mem_st->selector);
 107             return;
 108         }
 109     }
 110
 111     switch (addr) {
 112     case 0x0: /* DIMM slot selector */
 113         mem_st->selector = data;
 114         trace_mhp_acpi_write_slot(mem_st->selector);
 115         break;
 116     case 0x4: /* _OST event  */
 117         mdev = &mem_st->devs[mem_st->selector];
 118         if (data == 1) {
 119             /* TODO: handle device insert OST event */
 120         } else if (data == 3) {
 121             /* TODO: handle device remove OST event */
 122         }
 123         mdev->ost_event = data;
 124         trace_mhp_acpi_write_ost_ev(mem_st->selector, mdev->ost_event);
 125         break;
 126     case 0x8: /* _OST status */
 127         mdev = &mem_st->devs[mem_st->selector];
 128         mdev->ost_status = data;
 129         trace_mhp_acpi_write_ost_status(mem_st->selector, mdev->ost_status);
 130         /* TODO: implement memory removal on guest signal */
 131
 132         info = acpi_memory_device_status(mem_st->selector, mdev);
 133         qapi_event_send_acpi_device_ost(info, &error_abort);
 134         qapi_free_ACPIOSTInfo(info);
 135         break;
 136     case 0x14: /* set is_* fields  */
 137         mdev = &mem_st->devs[mem_st->selector];
 138         if (data & 2) { /* clear insert event */
 139             mdev->is_inserting  = false;
 140             trace_mhp_acpi_clear_insert_evt(mem_st->selector);
 141         } else if (data & 4) {
 142             mdev->is_removing = false;
 143             trace_mhp_acpi_clear_remove_evt(mem_st->selector);
 144         } else if (data & 8) {
 145             if (!mdev->is_enabled) {
 146                 trace_mhp_acpi_ejecting_invalid_slot(mem_st->selector);
 147                 break;
 148             }
 149
 150             dev = DEVICE(mdev->dimm);
 151             hotplug_ctrl = qdev_get_hotplug_handler(dev);
 152             /* call pc-dimm unplug cb */
 153             hotplug_handler_unplug(hotplug_ctrl, dev, &local_err);
 154             if (local_err) {
 155                 trace_mhp_acpi_pc_dimm_delete_failed(mem_st->selector);
 156                 qapi_event_send_mem_unplug_error(dev->id,
 157                                                  error_get_pretty(local_err),
 158                                                  &error_abort);
 159                 error_free(local_err);
 160                 break;
 161             }
 162             trace_mhp_acpi_pc_dimm_deleted(mem_st->selector);
 163         }
 164         break;
 165     default:
 166         break;
 167     }
 168
 169 }
 170 static const MemoryRegionOps acpi_memory_hotplug_ops = {
 171     .read = acpi_memory_hotplug_read,
 172     .write = acpi_memory_hotplug_write,
 173     .endianness = DEVICE_LITTLE_ENDIAN,
 174     .valid = {
 175         .min_access_size = 1,
 176         .max_access_size = 4,
 177     },
 178 };
 179
 180 void acpi_memory_hotplug_init(MemoryRegion *as, Object *owner,
 181                               MemHotplugState *state)
 182 {
 183     MachineState *machine = MACHINE(qdev_get_machine());
 184
 185     state->dev_count = machine->ram_slots;
 186     if (!state->dev_count) {
 187         return;
 188     }
 189
 190     state->devs = g_malloc0(sizeof(*state->devs) * state->dev_count);
 191     memory_region_init_io(&state->io, owner, &acpi_memory_hotplug_ops, state,
 192                           "acpi-mem-hotplug", ACPI_MEMORY_HOTPLUG_IO_LEN);
 193     memory_region_add_subregion(as, ACPI_MEMORY_HOTPLUG_BASE, &state->io);
 194 }
 195
 196 /**
 197  * acpi_memory_slot_status:
 198  * @mem_st: memory hotplug state
 199  * @dev: device
 200  * @errp: set in case of an error
 201  *
 202  * Obtain a single memory slot status.
 203  *
 204  * This function will be called by memory unplug request cb and unplug cb.
 205  */
 206 static MemStatus *
 207 acpi_memory_slot_status(MemHotplugState *mem_st,
 208                         DeviceState *dev, Error **errp)
 209 {
 210     Error *local_err = NULL;
 211     int slot = object_property_get_int(OBJECT(dev), PC_DIMM_SLOT_PROP,
 212                                        &local_err);
 213
 214     if (local_err) {
 215         error_propagate(errp, local_err);
 216         return NULL;
 217     }
 218
 219     if (slot >= mem_st->dev_count) {
 220         char *dev_path = object_get_canonical_path(OBJECT(dev));
 221         error_setg(errp, "acpi_memory_slot_status: "
 222                    "device [%s] returned invalid memory slot[%d]",
 223                     dev_path, slot);
 224         g_free(dev_path);
 225         return NULL;
 226     }
 227
 228     return &mem_st->devs[slot];
 229 }
 230
 231 void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st,
 232                          DeviceState *dev, Error **errp)
 233 {
 234     MemStatus *mdev;
 235     DeviceClass *dc = DEVICE_GET_CLASS(dev);
 236
 237     if (!dc->hotpluggable) {
 238         return;
 239     }
 240
 241     mdev = acpi_memory_slot_status(mem_st, dev, errp);
 242     if (!mdev) {
 243         return;
 244     }
 245
 246     mdev->dimm = dev;
 247     mdev->is_enabled = true;
 248     if (dev->hotplugged) {
 249         mdev->is_inserting = true;
 250         acpi_send_event(DEVICE(hotplug_dev), ACPI_MEMORY_HOTPLUG_STATUS);
 251     }
 252 }
 253
 254 void acpi_memory_unplug_request_cb(HotplugHandler *hotplug_dev,
 255                                    MemHotplugState *mem_st,
 256                                    DeviceState *dev, Error **errp)
 257 {
 258     MemStatus *mdev;
 259
 260     mdev = acpi_memory_slot_status(mem_st, dev, errp);
 261     if (!mdev) {
 262         return;
 263     }
 264
 265     mdev->is_removing = true;
 266     acpi_send_event(DEVICE(hotplug_dev), ACPI_MEMORY_HOTPLUG_STATUS);
 267 }
 268
 269 void acpi_memory_unplug_cb(MemHotplugState *mem_st,
 270                            DeviceState *dev, Error **errp)
 271 {
 272     MemStatus *mdev;
 273
 274     mdev = acpi_memory_slot_status(mem_st, dev, errp);
 275     if (!mdev) {
 276         return;
 277     }
 278
 279     mdev->is_enabled = false;
 280     mdev->dimm = NULL;
 281 }
 282
 283 static const VMStateDescription vmstate_memhp_sts = {
 284     .name = "memory hotplug device state",
 285     .version_id = 1,
 286     .minimum_version_id = 1,
 287     .minimum_version_id_old = 1,
 288     .fields      = (VMStateField[]) {
 289         VMSTATE_BOOL(is_enabled, MemStatus),
 290         VMSTATE_BOOL(is_inserting, MemStatus),
 291         VMSTATE_UINT32(ost_event, MemStatus),
 292         VMSTATE_UINT32(ost_status, MemStatus),
 293         VMSTATE_END_OF_LIST()
 294     }
 295 };
 296
 297 const VMStateDescription vmstate_memory_hotplug = {
 298     .name = "memory hotplug state",
 299     .version_id = 1,
 300     .minimum_version_id = 1,
 301     .minimum_version_id_old = 1,
 302     .fields      = (VMStateField[]) {
 303         VMSTATE_UINT32(selector, MemHotplugState),
 304         VMSTATE_STRUCT_VARRAY_POINTER_UINT32(devs, MemHotplugState, dev_count,
 305                                              vmstate_memhp_sts, MemStatus),
 306         VMSTATE_END_OF_LIST()
 307     }
 308 };
 309
 310 void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem,
 311                               uint16_t io_base, uint16_t io_len)
 312 {
 313     Aml *ifctx;
 314     Aml *method;
 315     Aml *pci_scope;
 316     Aml *mem_ctrl_dev;
 317
 318     /* scope for memory hotplug controller device node */
 319     pci_scope = aml_scope("_SB.PCI0");
 320     mem_ctrl_dev = aml_device(MEMORY_HOTPLUG_DEVICE);
 321     {
 322         Aml *crs;
 323         Aml *field;
 324         Aml *one = aml_int(1);
 325         Aml *zero = aml_int(0);
 326         Aml *ret_val = aml_local(0);
 327         Aml *slot_arg0 = aml_arg(0);
 328         Aml *slots_nr = aml_name(MEMORY_SLOTS_NUMBER);
 329         Aml *ctrl_lock = aml_name(MEMORY_SLOT_LOCK);
 330         Aml *slot_selector = aml_name(MEMORY_SLOT_SLECTOR);
 331
 332         aml_append(mem_ctrl_dev, aml_name_decl("_HID", aml_string("PNP0A06")));
 333         aml_append(mem_ctrl_dev,
 334             aml_name_decl("_UID", aml_string("Memory hotplug resources")));
 335
 336         assert(nr_mem <= ACPI_MAX_RAM_SLOTS);
 337         aml_append(mem_ctrl_dev,
 338             aml_name_decl(MEMORY_SLOTS_NUMBER, aml_int(nr_mem))
 339         );
 340
 341         crs = aml_resource_template();
 342         aml_append(crs,
 343             aml_io(AML_DECODE16, io_base, io_base, 0, io_len)
 344         );
 345         aml_append(mem_ctrl_dev, aml_name_decl("_CRS", crs));
 346
 347         aml_append(mem_ctrl_dev, aml_operation_region(
 348             MEMORY_HOTPLUG_IO_REGION, AML_SYSTEM_IO,
 349             aml_int(io_base), io_len)
 350         );
 351
 352         field = aml_field(MEMORY_HOTPLUG_IO_REGION, AML_DWORD_ACC,
 353                           AML_NOLOCK, AML_PRESERVE);
 354         aml_append(field, /* read only */
 355             aml_named_field(MEMORY_SLOT_ADDR_LOW, 32));
 356         aml_append(field, /* read only */
 357             aml_named_field(MEMORY_SLOT_ADDR_HIGH, 32));
 358         aml_append(field, /* read only */
 359             aml_named_field(MEMORY_SLOT_SIZE_LOW, 32));
 360         aml_append(field, /* read only */
 361             aml_named_field(MEMORY_SLOT_SIZE_HIGH, 32));
 362         aml_append(field, /* read only */
 363             aml_named_field(MEMORY_SLOT_PROXIMITY, 32));
 364         aml_append(mem_ctrl_dev, field);
 365
 366         field = aml_field(MEMORY_HOTPLUG_IO_REGION, AML_BYTE_ACC,
 367                           AML_NOLOCK, AML_WRITE_AS_ZEROS);
 368         aml_append(field, aml_reserved_field(160 /* bits, Offset(20) */));
 369         aml_append(field, /* 1 if enabled, read only */
 370             aml_named_field(MEMORY_SLOT_ENABLED, 1));
 371         aml_append(field,
 372             /*(read) 1 if has a insert event. (write) 1 to clear event */
 373             aml_named_field(MEMORY_SLOT_INSERT_EVENT, 1));
 374         aml_append(field,
 375             /* (read) 1 if has a remove event. (write) 1 to clear event */
 376             aml_named_field(MEMORY_SLOT_REMOVE_EVENT, 1));
 377         aml_append(field,
 378             /* initiates device eject, write only */
 379             aml_named_field(MEMORY_SLOT_EJECT, 1));
 380         aml_append(mem_ctrl_dev, field);
 381
 382         field = aml_field(MEMORY_HOTPLUG_IO_REGION, AML_DWORD_ACC,
 383                           AML_NOLOCK, AML_PRESERVE);
 384         aml_append(field, /* DIMM selector, write only */
 385             aml_named_field(MEMORY_SLOT_SLECTOR, 32));
 386         aml_append(field, /* _OST event code, write only */
 387             aml_named_field(MEMORY_SLOT_OST_EVENT, 32));
 388         aml_append(field, /* _OST status code, write only */
 389             aml_named_field(MEMORY_SLOT_OST_STATUS, 32));
 390         aml_append(mem_ctrl_dev, field);
 391
 392         method = aml_method("_STA", 0, AML_NOTSERIALIZED);
 393         ifctx = aml_if(aml_equal(slots_nr, zero));
 394         {
 395             aml_append(ifctx, aml_return(zero));
 396         }
 397         aml_append(method, ifctx);
 398         /* present, functioning, decoding, not shown in UI */
 399         aml_append(method, aml_return(aml_int(0xB)));
 400         aml_append(mem_ctrl_dev, method);
 401
 402         aml_append(mem_ctrl_dev, aml_mutex(MEMORY_SLOT_LOCK, 0));
 403
 404         method = aml_method(MEMORY_SLOT_SCAN_METHOD, 0, AML_NOTSERIALIZED);
 405         {
 406             Aml *else_ctx;
 407             Aml *while_ctx;
 408             Aml *idx = aml_local(0);
 409             Aml *eject_req = aml_int(3);
 410             Aml *dev_chk = aml_int(1);
 411
 412             ifctx = aml_if(aml_equal(slots_nr, zero));
 413             {
 414                 aml_append(ifctx, aml_return(zero));
 415             }
 416             aml_append(method, ifctx);
 417
 418             aml_append(method, aml_store(zero, idx));
 419             aml_append(method, aml_acquire(ctrl_lock, 0xFFFF));
 420             /* build AML that:
 421              * loops over all slots and Notifies DIMMs with
 422              * Device Check or Eject Request notifications if
 423              * slot has corresponding status bit set and clears
 424              * slot status.
 425              */
 426             while_ctx = aml_while(aml_lless(idx, slots_nr));
 427             {
 428                 Aml *ins_evt = aml_name(MEMORY_SLOT_INSERT_EVENT);
 429                 Aml *rm_evt = aml_name(MEMORY_SLOT_REMOVE_EVENT);
 430
 431                 aml_append(while_ctx, aml_store(idx, slot_selector));
 432                 ifctx = aml_if(aml_equal(ins_evt, one));
 433                 {
 434                     aml_append(ifctx,
 435                                aml_call2(MEMORY_SLOT_NOTIFY_METHOD,
 436                                          idx, dev_chk));
 437                     aml_append(ifctx, aml_store(one, ins_evt));
 438                 }
 439                 aml_append(while_ctx, ifctx);
 440
 441                 else_ctx = aml_else();
 442                 ifctx = aml_if(aml_equal(rm_evt, one));
 443                 {
 444                     aml_append(ifctx,
 445                         aml_call2(MEMORY_SLOT_NOTIFY_METHOD,
 446                                   idx, eject_req));
 447                     aml_append(ifctx, aml_store(one, rm_evt));
 448                 }
 449                 aml_append(else_ctx, ifctx);
 450                 aml_append(while_ctx, else_ctx);
 451
 452                 aml_append(while_ctx, aml_add(idx, one, idx));
 453             }
 454             aml_append(method, while_ctx);
 455             aml_append(method, aml_release(ctrl_lock));
 456             aml_append(method, aml_return(one));
 457         }
 458         aml_append(mem_ctrl_dev, method);
 459
 460         method = aml_method(MEMORY_SLOT_STATUS_METHOD, 1, AML_NOTSERIALIZED);
 461         {
 462             Aml *slot_enabled = aml_name(MEMORY_SLOT_ENABLED);
 463
 464             aml_append(method, aml_store(zero, ret_val));
 465             aml_append(method, aml_acquire(ctrl_lock, 0xFFFF));
 466             aml_append(method,
 467                 aml_store(aml_to_integer(slot_arg0), slot_selector));
 468
 469             ifctx = aml_if(aml_equal(slot_enabled, one));
 470             {
 471                 aml_append(ifctx, aml_store(aml_int(0xF), ret_val));
 472             }
 473             aml_append(method, ifctx);
 474
 475             aml_append(method, aml_release(ctrl_lock));
 476             aml_append(method, aml_return(ret_val));
 477         }
 478         aml_append(mem_ctrl_dev, method);
 479
 480         method = aml_method(MEMORY_SLOT_CRS_METHOD, 1, AML_SERIALIZED);
 481         {
 482             Aml *mr64 = aml_name("MR64");
 483             Aml *mr32 = aml_name("MR32");
 484             Aml *crs_tmpl = aml_resource_template();
 485             Aml *minl = aml_name("MINL");
 486             Aml *minh = aml_name("MINH");
 487             Aml *maxl =  aml_name("MAXL");
 488             Aml *maxh =  aml_name("MAXH");
 489             Aml *lenl = aml_name("LENL");
 490             Aml *lenh = aml_name("LENH");
 491
 492             aml_append(method, aml_acquire(ctrl_lock, 0xFFFF));
 493             aml_append(method, aml_store(aml_to_integer(slot_arg0),
 494                                          slot_selector));
 495
 496             aml_append(crs_tmpl,
 497                 aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
 498                                  AML_CACHEABLE, AML_READ_WRITE,
 499                                  0, 0x0, 0xFFFFFFFFFFFFFFFEULL, 0,
 500                                  0xFFFFFFFFFFFFFFFFULL));
 501             aml_append(method, aml_name_decl("MR64", crs_tmpl));
 502             aml_append(method,
 503                 aml_create_dword_field(mr64, aml_int(14), "MINL"));
 504             aml_append(method,
 505                 aml_create_dword_field(mr64, aml_int(18), "MINH"));
 506             aml_append(method,
 507                 aml_create_dword_field(mr64, aml_int(38), "LENL"));
 508             aml_append(method,
 509                 aml_create_dword_field(mr64, aml_int(42), "LENH"));
 510             aml_append(method,
 511                 aml_create_dword_field(mr64, aml_int(22), "MAXL"));
 512             aml_append(method,
 513                 aml_create_dword_field(mr64, aml_int(26), "MAXH"));
 514
 515             aml_append(method,
 516                 aml_store(aml_name(MEMORY_SLOT_ADDR_HIGH), minh));
 517             aml_append(method,
 518                 aml_store(aml_name(MEMORY_SLOT_ADDR_LOW), minl));
 519             aml_append(method,
 520                 aml_store(aml_name(MEMORY_SLOT_SIZE_HIGH), lenh));
 521             aml_append(method,
 522                 aml_store(aml_name(MEMORY_SLOT_SIZE_LOW), lenl));
 523
 524             /* 64-bit math: MAX = MIN + LEN - 1 */
 525             aml_append(method, aml_add(minl, lenl, maxl));
 526             aml_append(method, aml_add(minh, lenh, maxh));
 527             ifctx = aml_if(aml_lless(maxl, minl));
 528             {
 529                 aml_append(ifctx, aml_add(maxh, one, maxh));
 530             }
 531             aml_append(method, ifctx);
 532             ifctx = aml_if(aml_lless(maxl, one));
 533             {
 534                 aml_append(ifctx, aml_subtract(maxh, one, maxh));
 535             }
 536             aml_append(method, ifctx);
 537             aml_append(method, aml_subtract(maxl, one, maxl));
 538
 539             /* return 32-bit _CRS if addr/size is in low mem */
 540             /* TODO: remove it since all hotplugged DIMMs are in high mem */
 541             ifctx = aml_if(aml_equal(maxh, zero));
 542             {
 543                 crs_tmpl = aml_resource_template();
 544                 aml_append(crs_tmpl,
 545                     aml_dword_memory(AML_POS_DECODE, AML_MIN_FIXED,
 546                                      AML_MAX_FIXED, AML_CACHEABLE,
 547                                      AML_READ_WRITE,
 548                                      0, 0x0, 0xFFFFFFFE, 0,
 549                                      0xFFFFFFFF));
 550                 aml_append(ifctx, aml_name_decl("MR32", crs_tmpl));
 551                 aml_append(ifctx,
 552                     aml_create_dword_field(mr32, aml_int(10), "MIN"));
 553                 aml_append(ifctx,
 554                     aml_create_dword_field(mr32, aml_int(14), "MAX"));
 555                 aml_append(ifctx,
 556                     aml_create_dword_field(mr32, aml_int(22), "LEN"));
 557                 aml_append(ifctx, aml_store(minl, aml_name("MIN")));
 558                 aml_append(ifctx, aml_store(maxl, aml_name("MAX")));
 559                 aml_append(ifctx, aml_store(lenl, aml_name("LEN")));
 560
 561                 aml_append(ifctx, aml_release(ctrl_lock));
 562                 aml_append(ifctx, aml_return(mr32));
 563             }
 564             aml_append(method, ifctx);
 565
 566             aml_append(method, aml_release(ctrl_lock));
 567             aml_append(method, aml_return(mr64));
 568         }
 569         aml_append(mem_ctrl_dev, method);
 570
 571         method = aml_method(MEMORY_SLOT_PROXIMITY_METHOD, 1,
 572                             AML_NOTSERIALIZED);
 573         {
 574             Aml *proximity = aml_name(MEMORY_SLOT_PROXIMITY);
 575
 576             aml_append(method, aml_acquire(ctrl_lock, 0xFFFF));
 577             aml_append(method, aml_store(aml_to_integer(slot_arg0),
 578                                          slot_selector));
 579             aml_append(method, aml_store(proximity, ret_val));
 580             aml_append(method, aml_release(ctrl_lock));
 581             aml_append(method, aml_return(ret_val));
 582         }
 583         aml_append(mem_ctrl_dev, method);
 584
 585         method = aml_method(MEMORY_SLOT_OST_METHOD, 4, AML_NOTSERIALIZED);
 586         {
 587             Aml *ost_evt = aml_name(MEMORY_SLOT_OST_EVENT);
 588             Aml *ost_status = aml_name(MEMORY_SLOT_OST_STATUS);
 589
 590             aml_append(method, aml_acquire(ctrl_lock, 0xFFFF));
 591             aml_append(method, aml_store(aml_to_integer(slot_arg0),
 592                                          slot_selector));
 593             aml_append(method, aml_store(aml_arg(1), ost_evt));
 594             aml_append(method, aml_store(aml_arg(2), ost_status));
 595             aml_append(method, aml_release(ctrl_lock));
 596         }
 597         aml_append(mem_ctrl_dev, method);
 598
 599         method = aml_method(MEMORY_SLOT_EJECT_METHOD, 2, AML_NOTSERIALIZED);
 600         {
 601             Aml *eject = aml_name(MEMORY_SLOT_EJECT);
 602
 603             aml_append(method, aml_acquire(ctrl_lock, 0xFFFF));
 604             aml_append(method, aml_store(aml_to_integer(slot_arg0),
 605                                          slot_selector));
 606             aml_append(method, aml_store(one, eject));
 607             aml_append(method, aml_release(ctrl_lock));
 608         }
 609         aml_append(mem_ctrl_dev, method);
 610     }
 611     aml_append(pci_scope, mem_ctrl_dev);
 612     aml_append(table, pci_scope);
 613 }
 614
 615 void build_memory_devices(Aml *sb_scope, int nr_mem,
 616                           uint16_t io_base, uint16_t io_len)
 617 {
 618     int i;
 619     Aml *dev;
 620     Aml *method;
 621     Aml *ifctx;
 622
 623     /* build memory devices */
 624     for (i = 0; i < nr_mem; i++) {
 625         #define BASEPATH "\\_SB.PCI0." MEMORY_HOTPLUG_DEVICE "."
 626         const char *s;
 627
 628         dev = aml_device("MP%02X", i);
 629         aml_append(dev, aml_name_decl("_UID", aml_string("0x%02X", i)));
 630         aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0C80")));
 631
 632         method = aml_method("_CRS", 0, AML_NOTSERIALIZED);
 633         s = BASEPATH MEMORY_SLOT_CRS_METHOD;
 634         aml_append(method, aml_return(aml_call1(s, aml_name("_UID"))));
 635         aml_append(dev, method);
 636
 637         method = aml_method("_STA", 0, AML_NOTSERIALIZED);
 638         s = BASEPATH MEMORY_SLOT_STATUS_METHOD;
 639         aml_append(method, aml_return(aml_call1(s, aml_name("_UID"))));
 640         aml_append(dev, method);
 641
 642         method = aml_method("_PXM", 0, AML_NOTSERIALIZED);
 643         s = BASEPATH MEMORY_SLOT_PROXIMITY_METHOD;
 644         aml_append(method, aml_return(aml_call1(s, aml_name("_UID"))));
 645         aml_append(dev, method);
 646
 647         method = aml_method("_OST", 3, AML_NOTSERIALIZED);
 648         s = BASEPATH MEMORY_SLOT_OST_METHOD;
 649
 650         aml_append(method, aml_return(aml_call4(
 651             s, aml_name("_UID"), aml_arg(0), aml_arg(1), aml_arg(2)
 652         )));
 653         aml_append(dev, method);
 654
 655         method = aml_method("_EJ0", 1, AML_NOTSERIALIZED);
 656         s = BASEPATH MEMORY_SLOT_EJECT_METHOD;
 657         aml_append(method, aml_return(aml_call2(
 658                    s, aml_name("_UID"), aml_arg(0))));
 659         aml_append(dev, method);
 660
 661         aml_append(sb_scope, dev);
 662     }
 663
 664     /* build Method(MEMORY_SLOT_NOTIFY_METHOD, 2) {
 665      *     If (LEqual(Arg0, 0x00)) {Notify(MP00, Arg1)} ... }
 666      */
 667     method = aml_method(MEMORY_SLOT_NOTIFY_METHOD, 2, AML_NOTSERIALIZED);
 668     for (i = 0; i < nr_mem; i++) {
 669         ifctx = aml_if(aml_equal(aml_arg(0), aml_int(i)));
 670         aml_append(ifctx,
 671             aml_notify(aml_name("MP%.02X", i), aml_arg(1))
 672         );
 673         aml_append(method, ifctx);
 674     }
 675     aml_append(sb_scope, method);
 676 }