]> git.proxmox.com Git - mirror_qemu.git/blob - hw/scsi/vhost-user-scsi.c
vhost: fix memory leak in vhost_user_scsi_realize
[mirror_qemu.git] / hw / scsi / vhost-user-scsi.c
1 /*
2 * vhost-user-scsi host device
3 *
4 * Copyright (c) 2016 Nutanix Inc. All rights reserved.
5 *
6 * Author:
7 * Felipe Franciosi <felipe@nutanix.com>
8 *
9 * This work is largely based on the "vhost-scsi" implementation by:
10 * Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
11 * Nicholas Bellinger <nab@risingtidesystems.com>
12 *
13 * This work is licensed under the terms of the GNU LGPL, version 2 or later.
14 * See the COPYING.LIB file in the top-level directory.
15 *
16 */
17
18 #include "qemu/osdep.h"
19 #include "qapi/error.h"
20 #include "qemu/error-report.h"
21 #include "qom/object.h"
22 #include "hw/fw-path-provider.h"
23 #include "hw/qdev-core.h"
24 #include "hw/virtio/vhost.h"
25 #include "hw/virtio/vhost-backend.h"
26 #include "hw/virtio/vhost-user-scsi.h"
27 #include "hw/virtio/virtio.h"
28 #include "hw/virtio/virtio-access.h"
29 #include "chardev/char-fe.h"
30
31 /* Features supported by the host application */
32 static const int user_feature_bits[] = {
33 VIRTIO_F_NOTIFY_ON_EMPTY,
34 VIRTIO_RING_F_INDIRECT_DESC,
35 VIRTIO_RING_F_EVENT_IDX,
36 VIRTIO_SCSI_F_HOTPLUG,
37 VHOST_INVALID_FEATURE_BIT
38 };
39
40 static void vhost_user_scsi_set_status(VirtIODevice *vdev, uint8_t status)
41 {
42 VHostUserSCSI *s = (VHostUserSCSI *)vdev;
43 VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
44 bool start = (status & VIRTIO_CONFIG_S_DRIVER_OK) && vdev->vm_running;
45
46 if (vsc->dev.started == start) {
47 return;
48 }
49
50 if (start) {
51 int ret;
52
53 ret = vhost_scsi_common_start(vsc);
54 if (ret < 0) {
55 error_report("unable to start vhost-user-scsi: %s", strerror(-ret));
56 exit(1);
57 }
58 } else {
59 vhost_scsi_common_stop(vsc);
60 }
61 }
62
63 static void vhost_dummy_handle_output(VirtIODevice *vdev, VirtQueue *vq)
64 {
65 }
66
67 static void vhost_user_scsi_realize(DeviceState *dev, Error **errp)
68 {
69 VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
70 VHostUserSCSI *s = VHOST_USER_SCSI(dev);
71 VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
72 struct vhost_virtqueue *vqs = NULL;
73 Error *err = NULL;
74 int ret;
75
76 if (!vs->conf.chardev.chr) {
77 error_setg(errp, "vhost-user-scsi: missing chardev");
78 return;
79 }
80
81 virtio_scsi_common_realize(dev, vhost_dummy_handle_output,
82 vhost_dummy_handle_output,
83 vhost_dummy_handle_output, &err);
84 if (err != NULL) {
85 error_propagate(errp, err);
86 return;
87 }
88
89 if (!vhost_user_init(&s->vhost_user, &vs->conf.chardev, errp)) {
90 return;
91 }
92
93 vsc->dev.nvqs = 2 + vs->conf.num_queues;
94 vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);
95 vsc->dev.vq_index = 0;
96 vsc->dev.backend_features = 0;
97 vqs = vsc->dev.vqs;
98
99 ret = vhost_dev_init(&vsc->dev, &s->vhost_user,
100 VHOST_BACKEND_TYPE_USER, 0);
101 if (ret < 0) {
102 error_setg(errp, "vhost-user-scsi: vhost initialization failed: %s",
103 strerror(-ret));
104 vhost_user_cleanup(&s->vhost_user);
105 g_free(vqs);
106 return;
107 }
108
109 /* Channel and lun both are 0 for bootable vhost-user-scsi disk */
110 vsc->channel = 0;
111 vsc->lun = 0;
112 vsc->target = vs->conf.boot_tpgt;
113 }
114
115 static void vhost_user_scsi_unrealize(DeviceState *dev, Error **errp)
116 {
117 VirtIODevice *vdev = VIRTIO_DEVICE(dev);
118 VHostUserSCSI *s = VHOST_USER_SCSI(dev);
119 VHostSCSICommon *vsc = VHOST_SCSI_COMMON(s);
120 struct vhost_virtqueue *vqs = vsc->dev.vqs;
121
122 /* This will stop the vhost backend. */
123 vhost_user_scsi_set_status(vdev, 0);
124
125 vhost_dev_cleanup(&vsc->dev);
126 g_free(vqs);
127
128 virtio_scsi_common_unrealize(dev, errp);
129 vhost_user_cleanup(&s->vhost_user);
130 }
131
132 static Property vhost_user_scsi_properties[] = {
133 DEFINE_PROP_CHR("chardev", VirtIOSCSICommon, conf.chardev),
134 DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0),
135 DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1),
136 DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, conf.virtqueue_size,
137 128),
138 DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors,
139 0xFFFF),
140 DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun, 128),
141 DEFINE_PROP_BIT64("hotplug", VHostSCSICommon, host_features,
142 VIRTIO_SCSI_F_HOTPLUG,
143 true),
144 DEFINE_PROP_BIT64("param_change", VHostSCSICommon, host_features,
145 VIRTIO_SCSI_F_CHANGE,
146 true),
147 DEFINE_PROP_BIT64("t10_pi", VHostSCSICommon, host_features,
148 VIRTIO_SCSI_F_T10_PI,
149 false),
150 DEFINE_PROP_END_OF_LIST(),
151 };
152
153 static const VMStateDescription vmstate_vhost_scsi = {
154 .name = "virtio-scsi",
155 .minimum_version_id = 1,
156 .version_id = 1,
157 .fields = (VMStateField[]) {
158 VMSTATE_VIRTIO_DEVICE,
159 VMSTATE_END_OF_LIST()
160 },
161 };
162
163 static void vhost_user_scsi_class_init(ObjectClass *klass, void *data)
164 {
165 DeviceClass *dc = DEVICE_CLASS(klass);
166 VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
167 FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(klass);
168
169 dc->props = vhost_user_scsi_properties;
170 dc->vmsd = &vmstate_vhost_scsi;
171 set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
172 vdc->realize = vhost_user_scsi_realize;
173 vdc->unrealize = vhost_user_scsi_unrealize;
174 vdc->get_features = vhost_scsi_common_get_features;
175 vdc->set_config = vhost_scsi_common_set_config;
176 vdc->set_status = vhost_user_scsi_set_status;
177 fwc->get_dev_path = vhost_scsi_common_get_fw_dev_path;
178 }
179
180 static void vhost_user_scsi_instance_init(Object *obj)
181 {
182 VHostSCSICommon *vsc = VHOST_SCSI_COMMON(obj);
183
184 vsc->feature_bits = user_feature_bits;
185
186 /* Add the bootindex property for this object */
187 device_add_bootindex_property(obj, &vsc->bootindex, "bootindex", NULL,
188 DEVICE(vsc), NULL);
189 }
190
191 static const TypeInfo vhost_user_scsi_info = {
192 .name = TYPE_VHOST_USER_SCSI,
193 .parent = TYPE_VHOST_SCSI_COMMON,
194 .instance_size = sizeof(VHostUserSCSI),
195 .class_init = vhost_user_scsi_class_init,
196 .instance_init = vhost_user_scsi_instance_init,
197 .interfaces = (InterfaceInfo[]) {
198 { TYPE_FW_PATH_PROVIDER },
199 { }
200 },
201 };
202
203 static void virtio_register_types(void)
204 {
205 type_register_static(&vhost_user_scsi_info);
206 }
207
208 type_init(virtio_register_types)