1 /* Copyright (c) 2013, 2014 Nicira, Inc.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License. */
18 #include <sys/types.h>
19 #include <arpa/inet.h>
20 #include <netinet/in_systm.h>
21 #include <netinet/ip.h>
23 #include "byte-order.h"
24 #include "connectivity.h"
27 #include "dynamic-string.h"
35 #include "ovs-thread.h"
36 #include "openvswitch/types.h"
38 #include "poll-loop.h"
43 #include "unaligned.h"
48 VLOG_DEFINE_THIS_MODULE(bfd
);
52 * The goal of this module is to replace CFM with something both more flexible
53 * and standards compliant. In service of this goal, the following needs to be
57 * * Implement Demand mode.
58 * * Go through the RFC line by line and verify we comply.
59 * * Test against a hardware implementation. Preferably a popular one.
60 * * Delete BFD packets with nw_ttl != 255 in the datapath to prevent DOS
65 * - Set TOS/PCP on the outer tunnel header when encapped.
67 * - Sending BFD messages should be in its own thread/process.
69 * - Scale testing. How does it operate when there are large number of bfd
70 * sessions? Do we ever have random flaps? What's the CPU utilization?
72 * - Rely on data traffic for liveness by using BFD demand mode.
73 * If we're receiving traffic on a port, we can safely assume it's up (modulo
74 * unidrectional failures). BFD has a demand mode in which it can stay quiet
75 * unless it feels the need to check the status of the port. Using this, we
76 * can implement a strategy in which BFD only sends control messages on dark
79 * - Depending on how one interprets the spec, it appears that a BFD session
80 * can never change bfd.LocalDiag to "No Diagnostic". We should verify that
81 * this is what hardware implementations actually do. Seems like "No
82 * Diagnostic" should be set once a BFD session state goes UP. */
87 FLAG_MULTIPOINT
= 1 << 0,
96 STATE_ADMIN_DOWN
= 0 << 6,
103 DIAG_NONE
= 0, /* No Diagnostic. */
104 DIAG_EXPIRED
= 1, /* Control Detection Time Expired. */
105 DIAG_ECHO_FAILED
= 2, /* Echo Function Failed. */
106 DIAG_RMT_DOWN
= 3, /* Neighbor Signaled Session Down. */
107 DIAG_FWD_RESET
= 4, /* Forwarding Plane Reset. */
108 DIAG_PATH_DOWN
= 5, /* Path Down. */
109 DIAG_CPATH_DOWN
= 6, /* Concatenated Path Down. */
110 DIAG_ADMIN_DOWN
= 7, /* Administratively Down. */
111 DIAG_RCPATH_DOWN
= 8 /* Reverse Concatenated Path Down. */
114 /* RFC 5880 Section 4.1
116 * 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
117 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
118 * |Vers | Diag |Sta|P|F|C|A|D|M| Detect Mult | Length |
119 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
120 * | My Discriminator |
121 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
122 * | Your Discriminator |
123 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
124 * | Desired Min TX Interval |
125 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
126 * | Required Min RX Interval |
127 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
128 * | Required Min Echo RX Interval |
129 * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ */
131 uint8_t vers_diag
; /* Version and diagnostic. */
132 uint8_t flags
; /* 2bit State field followed by flags. */
133 uint8_t mult
; /* Fault detection multiplier. */
134 uint8_t length
; /* Length of this BFD message. */
135 ovs_be32 my_disc
; /* My discriminator. */
136 ovs_be32 your_disc
; /* Your discriminator. */
137 ovs_be32 min_tx
; /* Desired minimum tx interval. */
138 ovs_be32 min_rx
; /* Required minimum rx interval. */
139 ovs_be32 min_rx_echo
; /* Required minimum echo rx interval. */
141 BUILD_ASSERT_DECL(BFD_PACKET_LEN
== sizeof(struct msg
));
143 #define DIAG_MASK 0x1f
145 #define STATE_MASK 0xC0
146 #define FLAGS_MASK 0x3f
149 struct hmap_node node
; /* In 'all_bfds'. */
150 uint32_t disc
; /* bfd.LocalDiscr. Key in 'all_bfds' hmap. */
152 char *name
; /* Name used for logging. */
154 bool cpath_down
; /* Concatenated Path Down. */
155 uint8_t mult
; /* bfd.DetectMult. */
157 struct netdev
*netdev
;
158 uint64_t rx_packets
; /* Packets received by 'netdev'. */
160 enum state state
; /* bfd.SessionState. */
161 enum state rmt_state
; /* bfd.RemoteSessionState. */
163 enum diag diag
; /* bfd.LocalDiag. */
164 enum diag rmt_diag
; /* Remote diagnostic. */
166 enum flags flags
; /* Flags sent on messages. */
167 enum flags rmt_flags
; /* Flags last received. */
169 uint32_t rmt_disc
; /* bfd.RemoteDiscr. */
171 uint8_t eth_dst
[ETH_ADDR_LEN
];/* Ethernet destination address. */
172 bool eth_dst_set
; /* 'eth_dst' set through database. */
174 ovs_be32 ip_src
; /* IPv4 source address. */
175 ovs_be32 ip_dst
; /* IPv4 destination address. */
177 uint16_t udp_src
; /* UDP source port. */
179 /* All timers in milliseconds. */
180 long long int rmt_min_rx
; /* bfd.RemoteMinRxInterval. */
181 long long int rmt_min_tx
; /* Remote minimum TX interval. */
183 long long int cfg_min_tx
; /* Configured minimum TX rate. */
184 long long int cfg_min_rx
; /* Configured required minimum RX rate. */
185 long long int poll_min_tx
; /* Min TX negotating in a poll sequence. */
186 long long int poll_min_rx
; /* Min RX negotating in a poll sequence. */
187 long long int min_tx
; /* bfd.DesiredMinTxInterval. */
188 long long int min_rx
; /* bfd.RequiredMinRxInterval. */
190 long long int last_tx
; /* Last TX time. */
191 long long int next_tx
; /* Next TX time. */
192 long long int detect_time
; /* RFC 5880 6.8.4 Detection time. */
194 bool last_forwarding
; /* Last calculation of forwarding flag. */
195 int forwarding_override
; /* Manual override of 'forwarding' status. */
197 atomic_bool check_tnl_key
; /* Verify tunnel key of inbound packets? */
198 struct ovs_refcount ref_cnt
;
200 /* When forward_if_rx is true, bfd_forwarding() will return
201 * true as long as there are incoming packets received.
202 * Note, forwarding_override still has higher priority. */
203 bool forwarding_if_rx
;
204 long long int forwarding_if_rx_detect_time
;
206 /* BFD decay related variables. */
207 bool in_decay
; /* True when bfd is in decay. */
208 int decay_min_rx
; /* min_rx is set to decay_min_rx when */
210 int decay_rx_ctl
; /* Count bfd packets received within decay */
211 /* detect interval. */
212 uint64_t decay_rx_packets
; /* Packets received by 'netdev'. */
213 long long int decay_detect_time
; /* Decay detection time. */
215 uint64_t flap_count
; /* Counts bfd forwarding flaps. */
218 static struct ovs_mutex mutex
= OVS_MUTEX_INITIALIZER
;
219 static struct hmap all_bfds__
= HMAP_INITIALIZER(&all_bfds__
);
220 static struct hmap
*const all_bfds
OVS_GUARDED_BY(mutex
) = &all_bfds__
;
222 static bool bfd_lookup_ip(const char *host_name
, struct in_addr
*)
224 static bool bfd_forwarding__(struct bfd
*) OVS_REQUIRES(mutex
);
225 static bool bfd_in_poll(const struct bfd
*) OVS_REQUIRES(mutex
);
226 static void bfd_poll(struct bfd
*bfd
) OVS_REQUIRES(mutex
);
227 static const char *bfd_diag_str(enum diag
) OVS_REQUIRES(mutex
);
228 static const char *bfd_state_str(enum state
) OVS_REQUIRES(mutex
);
229 static long long int bfd_min_tx(const struct bfd
*) OVS_REQUIRES(mutex
);
230 static long long int bfd_tx_interval(const struct bfd
*)
232 static long long int bfd_rx_interval(const struct bfd
*)
234 static void bfd_set_next_tx(struct bfd
*) OVS_REQUIRES(mutex
);
235 static void bfd_set_state(struct bfd
*, enum state
, enum diag
)
237 static uint32_t generate_discriminator(void) OVS_REQUIRES(mutex
);
238 static void bfd_put_details(struct ds
*, const struct bfd
*)
240 static uint64_t bfd_rx_packets(const struct bfd
*) OVS_REQUIRES(mutex
);
241 static void bfd_try_decay(struct bfd
*) OVS_REQUIRES(mutex
);
242 static void bfd_decay_update(struct bfd
*) OVS_REQUIRES(mutex
);
244 static void bfd_forwarding_if_rx_update(struct bfd
*) OVS_REQUIRES(mutex
);
245 static void bfd_unixctl_show(struct unixctl_conn
*, int argc
,
246 const char *argv
[], void *aux OVS_UNUSED
);
247 static void bfd_unixctl_set_forwarding_override(struct unixctl_conn
*,
248 int argc
, const char *argv
[],
249 void *aux OVS_UNUSED
);
250 static void log_msg(enum vlog_level
, const struct msg
*, const char *message
,
251 const struct bfd
*) OVS_REQUIRES(mutex
);
253 static struct vlog_rate_limit rl
= VLOG_RATE_LIMIT_INIT(20, 20);
255 /* Returns true if the interface on which 'bfd' is running may be used to
256 * forward traffic according to the BFD session state. */
258 bfd_forwarding(struct bfd
*bfd
) OVS_EXCLUDED(mutex
)
262 ovs_mutex_lock(&mutex
);
263 ret
= bfd_forwarding__(bfd
);
264 ovs_mutex_unlock(&mutex
);
268 /* When forwarding_if_rx is enabled, if there are packets received,
269 * updates forwarding_if_rx_detect_time. */
271 bfd_account_rx(struct bfd
*bfd
, const struct dpif_flow_stats
*stats
)
273 if (stats
->n_packets
&& bfd
->forwarding_if_rx
) {
274 ovs_mutex_lock(&mutex
);
275 bfd_forwarding__(bfd
);
276 bfd_forwarding_if_rx_update(bfd
);
277 bfd_forwarding__(bfd
);
278 ovs_mutex_unlock(&mutex
);
282 /* Returns a 'smap' of key value pairs representing the status of 'bfd'
283 * intended for the OVS database. */
285 bfd_get_status(const struct bfd
*bfd
, struct smap
*smap
)
288 ovs_mutex_lock(&mutex
);
289 smap_add(smap
, "forwarding",
290 bfd_forwarding__(CONST_CAST(struct bfd
*, bfd
))
292 smap_add(smap
, "state", bfd_state_str(bfd
->state
));
293 smap_add(smap
, "diagnostic", bfd_diag_str(bfd
->diag
));
294 smap_add_format(smap
, "flap_count", "%"PRIu64
, bfd
->flap_count
);
296 if (bfd
->state
!= STATE_DOWN
) {
297 smap_add(smap
, "remote_state", bfd_state_str(bfd
->rmt_state
));
298 smap_add(smap
, "remote_diagnostic", bfd_diag_str(bfd
->rmt_diag
));
300 ovs_mutex_unlock(&mutex
);
303 /* Initializes, destroys, or reconfigures the BFD session 'bfd' (named 'name'),
304 * according to the database configuration contained in 'cfg'. Takes ownership
305 * of 'bfd', which may be NULL. Returns a BFD object which may be used as a
306 * handle for the session, or NULL if BFD is not enabled according to 'cfg'.
307 * Also returns NULL if cfg is NULL. */
309 bfd_configure(struct bfd
*bfd
, const char *name
, const struct smap
*cfg
,
310 struct netdev
*netdev
) OVS_EXCLUDED(mutex
)
312 static struct ovsthread_once once
= OVSTHREAD_ONCE_INITIALIZER
;
313 static atomic_uint16_t udp_src
= ATOMIC_VAR_INIT(0);
316 long long int min_tx
, min_rx
;
317 bool need_poll
= false;
318 bool cfg_min_rx_changed
= false;
319 bool cpath_down
, forwarding_if_rx
;
320 const char *hwaddr
, *ip_src
, *ip_dst
;
321 struct in_addr in_addr
;
322 uint8_t ea
[ETH_ADDR_LEN
];
324 if (ovsthread_once_start(&once
)) {
325 unixctl_command_register("bfd/show", "[interface]", 0, 1,
326 bfd_unixctl_show
, NULL
);
327 unixctl_command_register("bfd/set-forwarding",
328 "[interface] normal|false|true", 1, 2,
329 bfd_unixctl_set_forwarding_override
, NULL
);
330 ovsthread_once_done(&once
);
333 if (!cfg
|| !smap_get_bool(cfg
, "enable", false)) {
338 ovs_mutex_lock(&mutex
);
340 bfd
= xzalloc(sizeof *bfd
);
341 bfd
->name
= xstrdup(name
);
342 bfd
->forwarding_override
= -1;
343 bfd
->disc
= generate_discriminator();
344 hmap_insert(all_bfds
, &bfd
->node
, bfd
->disc
);
346 bfd
->diag
= DIAG_NONE
;
349 ovs_refcount_init(&bfd
->ref_cnt
);
350 bfd
->netdev
= netdev_ref(netdev
);
351 bfd
->rx_packets
= bfd_rx_packets(bfd
);
352 bfd
->in_decay
= false;
355 /* RFC 5881 section 4
356 * The source port MUST be in the range 49152 through 65535. The same
357 * UDP source port number MUST be used for all BFD Control packets
358 * associated with a particular session. The source port number SHOULD
359 * be unique among all BFD sessions on the system. */
360 atomic_add(&udp_src
, 1, &bfd
->udp_src
);
361 bfd
->udp_src
= (bfd
->udp_src
% 16384) + 49152;
363 bfd_set_state(bfd
, STATE_DOWN
, DIAG_NONE
);
365 memcpy(bfd
->eth_dst
, eth_addr_bfd
, ETH_ADDR_LEN
);
368 atomic_store(&bfd
->check_tnl_key
,
369 smap_get_bool(cfg
, "check_tnl_key", false));
370 min_tx
= smap_get_int(cfg
, "min_tx", 100);
371 min_tx
= MAX(min_tx
, 100);
372 if (bfd
->cfg_min_tx
!= min_tx
) {
373 bfd
->cfg_min_tx
= min_tx
;
374 if (bfd
->state
!= STATE_UP
375 || (!bfd_in_poll(bfd
) && bfd
->cfg_min_tx
< bfd
->min_tx
)) {
376 bfd
->min_tx
= bfd
->cfg_min_tx
;
381 min_rx
= smap_get_int(cfg
, "min_rx", 1000);
382 min_rx
= MAX(min_rx
, 100);
383 if (bfd
->cfg_min_rx
!= min_rx
) {
384 bfd
->cfg_min_rx
= min_rx
;
385 if (bfd
->state
!= STATE_UP
386 || (!bfd_in_poll(bfd
) && bfd
->cfg_min_rx
> bfd
->min_rx
)) {
387 bfd
->min_rx
= bfd
->cfg_min_rx
;
389 cfg_min_rx_changed
= true;
393 decay_min_rx
= smap_get_int(cfg
, "decay_min_rx", 0);
394 if (bfd
->decay_min_rx
!= decay_min_rx
|| cfg_min_rx_changed
) {
395 if (decay_min_rx
> 0 && decay_min_rx
< bfd
->cfg_min_rx
) {
396 VLOG_WARN("%s: decay_min_rx cannot be less than %lld ms",
397 bfd
->name
, bfd
->cfg_min_rx
);
398 bfd
->decay_min_rx
= 0;
400 bfd
->decay_min_rx
= decay_min_rx
;
403 bfd
->in_decay
= false;
404 bfd_decay_update(bfd
);
408 cpath_down
= smap_get_bool(cfg
, "cpath_down", false);
409 if (bfd
->cpath_down
!= cpath_down
) {
410 bfd
->cpath_down
= cpath_down
;
411 bfd_set_state(bfd
, bfd
->state
, DIAG_NONE
);
415 hwaddr
= smap_get(cfg
, "bfd_dst_mac");
416 if (hwaddr
&& eth_addr_from_string(hwaddr
, ea
) && !eth_addr_is_zero(ea
)) {
417 memcpy(bfd
->eth_dst
, ea
, ETH_ADDR_LEN
);
418 bfd
->eth_dst_set
= true;
419 } else if (bfd
->eth_dst_set
) {
420 memcpy(bfd
->eth_dst
, eth_addr_bfd
, ETH_ADDR_LEN
);
421 bfd
->eth_dst_set
= false;
424 ip_src
= smap_get(cfg
, "bfd_src_ip");
425 if (ip_src
&& bfd_lookup_ip(ip_src
, &in_addr
)) {
426 memcpy(&bfd
->ip_src
, &in_addr
, sizeof in_addr
);
428 bfd
->ip_src
= htonl(0xA9FE0100); /* 169.254.1.0. */
431 ip_dst
= smap_get(cfg
, "bfd_dst_ip");
432 if (ip_dst
&& bfd_lookup_ip(ip_dst
, &in_addr
)) {
433 memcpy(&bfd
->ip_dst
, &in_addr
, sizeof in_addr
);
435 bfd
->ip_dst
= htonl(0xA9FE0101); /* 169.254.1.1. */
438 forwarding_if_rx
= smap_get_bool(cfg
, "forwarding_if_rx", false);
439 if (bfd
->forwarding_if_rx
!= forwarding_if_rx
) {
440 bfd
->forwarding_if_rx
= forwarding_if_rx
;
441 if (bfd
->state
== STATE_UP
&& bfd
->forwarding_if_rx
) {
442 bfd_forwarding_if_rx_update(bfd
);
444 bfd
->forwarding_if_rx_detect_time
= 0;
451 ovs_mutex_unlock(&mutex
);
456 bfd_ref(const struct bfd
*bfd_
)
458 struct bfd
*bfd
= CONST_CAST(struct bfd
*, bfd_
);
460 ovs_refcount_ref(&bfd
->ref_cnt
);
466 bfd_unref(struct bfd
*bfd
) OVS_EXCLUDED(mutex
)
468 if (bfd
&& ovs_refcount_unref(&bfd
->ref_cnt
) == 1) {
469 ovs_mutex_lock(&mutex
);
470 hmap_remove(all_bfds
, &bfd
->node
);
471 netdev_close(bfd
->netdev
);
474 ovs_mutex_unlock(&mutex
);
479 bfd_wait(const struct bfd
*bfd
) OVS_EXCLUDED(mutex
)
481 poll_timer_wait_until(bfd_wake_time(bfd
));
484 /* Returns the next wake up time. */
486 bfd_wake_time(const struct bfd
*bfd
) OVS_EXCLUDED(mutex
)
488 long long int retval
;
494 ovs_mutex_lock(&mutex
);
495 if (bfd
->flags
& FLAG_FINAL
) {
498 retval
= bfd
->next_tx
;
499 if (bfd
->state
> STATE_DOWN
) {
500 retval
= MIN(bfd
->detect_time
, retval
);
503 ovs_mutex_unlock(&mutex
);
508 bfd_run(struct bfd
*bfd
) OVS_EXCLUDED(mutex
)
513 ovs_mutex_lock(&mutex
);
515 old_in_decay
= bfd
->in_decay
;
517 if (bfd
->state
> STATE_DOWN
&& now
>= bfd
->detect_time
) {
518 bfd_set_state(bfd
, STATE_DOWN
, DIAG_EXPIRED
);
520 bfd_forwarding__(bfd
);
522 /* Decay may only happen when state is STATE_UP, bfd->decay_min_rx is
523 * configured, and decay_detect_time is reached. */
524 if (bfd
->state
== STATE_UP
&& bfd
->decay_min_rx
> 0
525 && now
>= bfd
->decay_detect_time
) {
529 if (bfd
->min_tx
!= bfd
->cfg_min_tx
530 || (bfd
->min_rx
!= bfd
->cfg_min_rx
&& bfd
->min_rx
!= bfd
->decay_min_rx
)
531 || bfd
->in_decay
!= old_in_decay
) {
534 ovs_mutex_unlock(&mutex
);
538 bfd_should_send_packet(const struct bfd
*bfd
) OVS_EXCLUDED(mutex
)
541 ovs_mutex_lock(&mutex
);
542 ret
= bfd
->flags
& FLAG_FINAL
|| time_msec() >= bfd
->next_tx
;
543 ovs_mutex_unlock(&mutex
);
548 bfd_put_packet(struct bfd
*bfd
, struct ofpbuf
*p
,
549 uint8_t eth_src
[ETH_ADDR_LEN
]) OVS_EXCLUDED(mutex
)
551 long long int min_tx
, min_rx
;
552 struct udp_header
*udp
;
553 struct eth_header
*eth
;
554 struct ip_header
*ip
;
557 ovs_mutex_lock(&mutex
);
559 long long int delay
= time_msec() - bfd
->next_tx
;
560 long long int interval
= bfd_tx_interval(bfd
);
561 if (delay
> interval
* 3 / 2) {
562 VLOG_INFO("%s: long delay of %lldms (expected %lldms) sending BFD"
563 " control message", bfd
->name
, delay
, interval
);
567 /* RFC 5880 Section 6.5
568 * A BFD Control packet MUST NOT have both the Poll (P) and Final (F) bits
570 ovs_assert(!(bfd
->flags
& FLAG_POLL
) || !(bfd
->flags
& FLAG_FINAL
));
572 ofpbuf_reserve(p
, 2); /* Properly align after the ethernet header. */
573 eth
= ofpbuf_put_uninit(p
, sizeof *eth
);
574 memcpy(eth
->eth_src
, eth_src
, ETH_ADDR_LEN
);
575 memcpy(eth
->eth_dst
, bfd
->eth_dst
, ETH_ADDR_LEN
);
576 eth
->eth_type
= htons(ETH_TYPE_IP
);
578 ip
= ofpbuf_put_zeros(p
, sizeof *ip
);
579 ip
->ip_ihl_ver
= IP_IHL_VER(5, 4);
580 ip
->ip_tot_len
= htons(sizeof *ip
+ sizeof *udp
+ sizeof *msg
);
582 ip
->ip_tos
= IPTOS_LOWDELAY
| IPTOS_THROUGHPUT
;
583 ip
->ip_proto
= IPPROTO_UDP
;
584 put_16aligned_be32(&ip
->ip_src
, bfd
->ip_src
);
585 put_16aligned_be32(&ip
->ip_dst
, bfd
->ip_dst
);
586 ip
->ip_csum
= csum(ip
, sizeof *ip
);
588 udp
= ofpbuf_put_zeros(p
, sizeof *udp
);
589 udp
->udp_src
= htons(bfd
->udp_src
);
590 udp
->udp_dst
= htons(BFD_DEST_PORT
);
591 udp
->udp_len
= htons(sizeof *udp
+ sizeof *msg
);
593 msg
= ofpbuf_put_uninit(p
, sizeof *msg
);
594 msg
->vers_diag
= (BFD_VERSION
<< 5) | bfd
->diag
;
595 msg
->flags
= (bfd
->state
& STATE_MASK
) | bfd
->flags
;
597 msg
->mult
= bfd
->mult
;
598 msg
->length
= BFD_PACKET_LEN
;
599 msg
->my_disc
= htonl(bfd
->disc
);
600 msg
->your_disc
= htonl(bfd
->rmt_disc
);
601 msg
->min_rx_echo
= htonl(0);
603 if (bfd_in_poll(bfd
)) {
604 min_tx
= bfd
->poll_min_tx
;
605 min_rx
= bfd
->poll_min_rx
;
607 min_tx
= bfd_min_tx(bfd
);
608 min_rx
= bfd
->min_rx
;
611 msg
->min_tx
= htonl(min_tx
* 1000);
612 msg
->min_rx
= htonl(min_rx
* 1000);
614 bfd
->flags
&= ~FLAG_FINAL
;
616 log_msg(VLL_DBG
, msg
, "Sending BFD Message", bfd
);
618 bfd
->last_tx
= time_msec();
619 bfd_set_next_tx(bfd
);
620 ovs_mutex_unlock(&mutex
);
624 bfd_should_process_flow(const struct bfd
*bfd_
, const struct flow
*flow
,
625 struct flow_wildcards
*wc
)
627 struct bfd
*bfd
= CONST_CAST(struct bfd
*, bfd_
);
630 memset(&wc
->masks
.dl_dst
, 0xff, sizeof wc
->masks
.dl_dst
);
631 if (bfd
->eth_dst_set
&& memcmp(bfd
->eth_dst
, flow
->dl_dst
, ETH_ADDR_LEN
)) {
635 memset(&wc
->masks
.nw_proto
, 0xff, sizeof wc
->masks
.nw_proto
);
636 memset(&wc
->masks
.tp_dst
, 0xff, sizeof wc
->masks
.tp_dst
);
638 atomic_read(&bfd
->check_tnl_key
, &check_tnl_key
);
640 memset(&wc
->masks
.tunnel
.tun_id
, 0xff, sizeof wc
->masks
.tunnel
.tun_id
);
642 return (flow
->dl_type
== htons(ETH_TYPE_IP
)
643 && flow
->nw_proto
== IPPROTO_UDP
644 && flow
->tp_dst
== htons(BFD_DEST_PORT
)
645 && (!check_tnl_key
|| flow
->tunnel
.tun_id
== htonll(0)));
649 bfd_process_packet(struct bfd
*bfd
, const struct flow
*flow
,
650 const struct ofpbuf
*p
) OVS_EXCLUDED(mutex
)
652 uint32_t rmt_min_rx
, pkt_your_disc
;
653 enum state rmt_state
;
657 const uint8_t *l7
= ofpbuf_get_udp_payload(p
);
660 return; /* No UDP payload. */
663 /* This function is designed to follow section RFC 5880 6.8.6 closely. */
665 ovs_mutex_lock(&mutex
);
666 /* Increments the decay rx counter. */
669 bfd_forwarding__(bfd
);
671 if (flow
->nw_ttl
!= 255) {
672 /* XXX Should drop in the kernel to prevent DOS. */
676 msg
= ofpbuf_at(p
, l7
- (uint8_t *)p
->data
, BFD_PACKET_LEN
);
678 VLOG_INFO_RL(&rl
, "%s: Received too-short BFD control message (only "
679 "%"PRIdPTR
" bytes long, at least %d required).",
680 bfd
->name
, (uint8_t *) ofpbuf_tail(p
) - l7
,
685 /* RFC 5880 Section 6.8.6
686 * If the Length field is greater than the payload of the encapsulating
687 * protocol, the packet MUST be discarded.
689 * Note that we make this check implicity. Above we use ofpbuf_at() to
690 * ensure that there are at least BFD_PACKET_LEN bytes in the payload of
691 * the encapsulating protocol. Below we require msg->length to be exactly
692 * BFD_PACKET_LEN bytes. */
694 flags
= msg
->flags
& FLAGS_MASK
;
695 rmt_state
= msg
->flags
& STATE_MASK
;
696 version
= msg
->vers_diag
>> VERS_SHIFT
;
698 log_msg(VLL_DBG
, msg
, "Received BFD control message", bfd
);
700 if (version
!= BFD_VERSION
) {
701 log_msg(VLL_WARN
, msg
, "Incorrect version", bfd
);
705 /* Technically this should happen after the length check. We don't support
706 * authentication however, so it's simpler to do the check first. */
707 if (flags
& FLAG_AUTH
) {
708 log_msg(VLL_WARN
, msg
, "Authenticated control message with"
709 " authentication disabled", bfd
);
713 if (msg
->length
!= BFD_PACKET_LEN
) {
714 log_msg(VLL_WARN
, msg
, "Unexpected length", bfd
);
715 if (msg
->length
< BFD_PACKET_LEN
) {
721 log_msg(VLL_WARN
, msg
, "Zero multiplier", bfd
);
725 if (flags
& FLAG_MULTIPOINT
) {
726 log_msg(VLL_WARN
, msg
, "Unsupported multipoint flag", bfd
);
731 log_msg(VLL_WARN
, msg
, "NULL my_disc", bfd
);
735 pkt_your_disc
= ntohl(msg
->your_disc
);
737 /* Technically, we should use the your discriminator field to figure
738 * out which 'struct bfd' this packet is destined towards. That way a
739 * bfd session could migrate from one interface to another
740 * transparently. This doesn't fit in with the OVS structure very
741 * well, so in this respect, we are not compliant. */
742 if (pkt_your_disc
!= bfd
->disc
) {
743 log_msg(VLL_WARN
, msg
, "Incorrect your_disc", bfd
);
746 } else if (rmt_state
> STATE_DOWN
) {
747 log_msg(VLL_WARN
, msg
, "Null your_disc", bfd
);
751 if (bfd
->rmt_state
!= rmt_state
) {
752 seq_change(connectivity_seq_get());
755 bfd
->rmt_disc
= ntohl(msg
->my_disc
);
756 bfd
->rmt_state
= rmt_state
;
757 bfd
->rmt_flags
= flags
;
758 bfd
->rmt_diag
= msg
->vers_diag
& DIAG_MASK
;
760 if (flags
& FLAG_FINAL
&& bfd_in_poll(bfd
)) {
761 bfd
->min_tx
= bfd
->poll_min_tx
;
762 bfd
->min_rx
= bfd
->poll_min_rx
;
763 bfd
->flags
&= ~FLAG_POLL
;
764 log_msg(VLL_INFO
, msg
, "Poll sequence terminated", bfd
);
767 if (flags
& FLAG_POLL
) {
768 /* RFC 5880 Section 6.5
769 * When the other system receives a Poll, it immediately transmits a
770 * BFD Control packet with the Final (F) bit set, independent of any
771 * periodic BFD Control packets it may be sending
772 * (see section 6.8.7). */
773 bfd
->flags
&= ~FLAG_POLL
;
774 bfd
->flags
|= FLAG_FINAL
;
777 rmt_min_rx
= MAX(ntohl(msg
->min_rx
) / 1000, 1);
778 if (bfd
->rmt_min_rx
!= rmt_min_rx
) {
779 bfd
->rmt_min_rx
= rmt_min_rx
;
781 bfd_set_next_tx(bfd
);
783 log_msg(VLL_INFO
, msg
, "New remote min_rx", bfd
);
786 bfd
->rmt_min_tx
= MAX(ntohl(msg
->min_tx
) / 1000, 1);
787 bfd
->detect_time
= bfd_rx_interval(bfd
) * bfd
->mult
+ time_msec();
789 if (bfd
->state
== STATE_ADMIN_DOWN
) {
790 VLOG_DBG_RL(&rl
, "Administratively down, dropping control message.");
794 if (rmt_state
== STATE_ADMIN_DOWN
) {
795 if (bfd
->state
!= STATE_DOWN
) {
796 bfd_set_state(bfd
, STATE_DOWN
, DIAG_RMT_DOWN
);
799 switch (bfd
->state
) {
801 if (rmt_state
== STATE_DOWN
) {
802 bfd_set_state(bfd
, STATE_INIT
, bfd
->diag
);
803 } else if (rmt_state
== STATE_INIT
) {
804 bfd_set_state(bfd
, STATE_UP
, bfd
->diag
);
808 if (rmt_state
> STATE_DOWN
) {
809 bfd_set_state(bfd
, STATE_UP
, bfd
->diag
);
813 if (rmt_state
<= STATE_DOWN
) {
814 bfd_set_state(bfd
, STATE_DOWN
, DIAG_RMT_DOWN
);
815 log_msg(VLL_INFO
, msg
, "Remote signaled STATE_DOWN", bfd
);
818 case STATE_ADMIN_DOWN
:
823 /* XXX: RFC 5880 Section 6.8.6 Demand mode related calculations here. */
826 bfd_forwarding__(bfd
);
827 ovs_mutex_unlock(&mutex
);
830 /* Must be called when the netdev owned by 'bfd' should change. */
832 bfd_set_netdev(struct bfd
*bfd
, const struct netdev
*netdev
)
835 ovs_mutex_lock(&mutex
);
836 if (bfd
->netdev
!= netdev
) {
837 netdev_close(bfd
->netdev
);
838 bfd
->netdev
= netdev_ref(netdev
);
839 if (bfd
->decay_min_rx
&& bfd
->state
== STATE_UP
) {
840 bfd_decay_update(bfd
);
842 if (bfd
->forwarding_if_rx
&& bfd
->state
== STATE_UP
) {
843 bfd_forwarding_if_rx_update(bfd
);
845 bfd
->rx_packets
= bfd_rx_packets(bfd
);
847 ovs_mutex_unlock(&mutex
);
851 /* Updates the forwarding flag. If override is not configured and
852 * the forwarding flag value changes, increments the flap count.
854 * Note this function may be called multiple times in a function
855 * (e.g. bfd_account_rx) before and after the bfd state or status
856 * change. This is to capture any forwarding flag flap. */
858 bfd_forwarding__(struct bfd
*bfd
) OVS_REQUIRES(mutex
)
861 bool last_forwarding
= bfd
->last_forwarding
;
863 if (bfd
->forwarding_override
!= -1) {
864 return bfd
->forwarding_override
== 1;
867 time
= bfd
->forwarding_if_rx_detect_time
;
868 bfd
->last_forwarding
= (bfd
->state
== STATE_UP
869 || (bfd
->forwarding_if_rx
&& time
> time_msec()))
870 && bfd
->rmt_diag
!= DIAG_PATH_DOWN
871 && bfd
->rmt_diag
!= DIAG_CPATH_DOWN
872 && bfd
->rmt_diag
!= DIAG_RCPATH_DOWN
;
873 if (bfd
->last_forwarding
!= last_forwarding
) {
875 seq_change(connectivity_seq_get());
877 return bfd
->last_forwarding
;
882 bfd_lookup_ip(const char *host_name
, struct in_addr
*addr
)
884 if (!inet_pton(AF_INET
, host_name
, addr
)) {
885 VLOG_ERR_RL(&rl
, "\"%s\" is not a valid IP address", host_name
);
892 bfd_in_poll(const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
894 return (bfd
->flags
& FLAG_POLL
) != 0;
898 bfd_poll(struct bfd
*bfd
) OVS_REQUIRES(mutex
)
900 if (bfd
->state
> STATE_DOWN
&& !bfd_in_poll(bfd
)
901 && !(bfd
->flags
& FLAG_FINAL
)) {
902 bfd
->poll_min_tx
= bfd
->cfg_min_tx
;
903 bfd
->poll_min_rx
= bfd
->in_decay
? bfd
->decay_min_rx
: bfd
->cfg_min_rx
;
904 bfd
->flags
|= FLAG_POLL
;
906 VLOG_INFO_RL(&rl
, "%s: Initiating poll sequence", bfd
->name
);
911 bfd_min_tx(const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
913 /* RFC 5880 Section 6.8.3
914 * When bfd.SessionState is not Up, the system MUST set
915 * bfd.DesiredMinTxInterval to a value of not less than one second
916 * (1,000,000 microseconds). This is intended to ensure that the
917 * bandwidth consumed by BFD sessions that are not Up is negligible,
918 * particularly in the case where a neighbor may not be running BFD. */
919 return (bfd
->state
== STATE_UP
? bfd
->min_tx
: MAX(bfd
->min_tx
, 1000));
923 bfd_tx_interval(const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
925 long long int interval
= bfd_min_tx(bfd
);
926 return MAX(interval
, bfd
->rmt_min_rx
);
930 bfd_rx_interval(const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
932 return MAX(bfd
->min_rx
, bfd
->rmt_min_tx
);
936 bfd_set_next_tx(struct bfd
*bfd
) OVS_REQUIRES(mutex
)
938 long long int interval
= bfd_tx_interval(bfd
);
939 interval
-= interval
* random_range(26) / 100;
940 bfd
->next_tx
= bfd
->last_tx
+ interval
;
944 bfd_flag_str(enum flags flags
)
946 struct ds ds
= DS_EMPTY_INITIALIZER
;
947 static char flag_str
[128];
953 if (flags
& FLAG_MULTIPOINT
) {
954 ds_put_cstr(&ds
, "multipoint ");
957 if (flags
& FLAG_DEMAND
) {
958 ds_put_cstr(&ds
, "demand ");
961 if (flags
& FLAG_AUTH
) {
962 ds_put_cstr(&ds
, "auth ");
965 if (flags
& FLAG_CTL
) {
966 ds_put_cstr(&ds
, "ctl ");
969 if (flags
& FLAG_FINAL
) {
970 ds_put_cstr(&ds
, "final ");
973 if (flags
& FLAG_POLL
) {
974 ds_put_cstr(&ds
, "poll ");
977 /* Do not copy the trailing whitespace. */
979 ovs_strlcpy(flag_str
, ds_cstr(&ds
), sizeof flag_str
);
985 bfd_state_str(enum state state
)
988 case STATE_ADMIN_DOWN
: return "admin_down";
989 case STATE_DOWN
: return "down";
990 case STATE_INIT
: return "init";
991 case STATE_UP
: return "up";
992 default: return "invalid";
997 bfd_diag_str(enum diag diag
) {
999 case DIAG_NONE
: return "No Diagnostic";
1000 case DIAG_EXPIRED
: return "Control Detection Time Expired";
1001 case DIAG_ECHO_FAILED
: return "Echo Function Failed";
1002 case DIAG_RMT_DOWN
: return "Neighbor Signaled Session Down";
1003 case DIAG_FWD_RESET
: return "Forwarding Plane Reset";
1004 case DIAG_PATH_DOWN
: return "Path Down";
1005 case DIAG_CPATH_DOWN
: return "Concatenated Path Down";
1006 case DIAG_ADMIN_DOWN
: return "Administratively Down";
1007 case DIAG_RCPATH_DOWN
: return "Reverse Concatenated Path Down";
1008 default: return "Invalid Diagnostic";
1013 log_msg(enum vlog_level level
, const struct msg
*p
, const char *message
,
1014 const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
1016 struct ds ds
= DS_EMPTY_INITIALIZER
;
1018 if (vlog_should_drop(THIS_MODULE
, level
, &rl
)) {
1024 "\n\tvers:%"PRIu8
" diag:\"%s\" state:%s mult:%"PRIu8
1027 "\n\tmy_disc:0x%"PRIx32
" your_disc:0x%"PRIx32
1028 "\n\tmin_tx:%"PRIu32
"us (%"PRIu32
"ms)"
1029 "\n\tmin_rx:%"PRIu32
"us (%"PRIu32
"ms)"
1030 "\n\tmin_rx_echo:%"PRIu32
"us (%"PRIu32
"ms)",
1031 bfd
->name
, message
, p
->vers_diag
>> VERS_SHIFT
,
1032 bfd_diag_str(p
->vers_diag
& DIAG_MASK
),
1033 bfd_state_str(p
->flags
& STATE_MASK
),
1034 p
->mult
, p
->length
, bfd_flag_str(p
->flags
& FLAGS_MASK
),
1035 ntohl(p
->my_disc
), ntohl(p
->your_disc
),
1036 ntohl(p
->min_tx
), ntohl(p
->min_tx
) / 1000,
1037 ntohl(p
->min_rx
), ntohl(p
->min_rx
) / 1000,
1038 ntohl(p
->min_rx_echo
), ntohl(p
->min_rx_echo
) / 1000);
1039 bfd_put_details(&ds
, bfd
);
1040 VLOG(level
, "%s", ds_cstr(&ds
));
1045 bfd_set_state(struct bfd
*bfd
, enum state state
, enum diag diag
)
1048 if (bfd
->cpath_down
) {
1049 diag
= DIAG_CPATH_DOWN
;
1052 if (bfd
->state
!= state
|| bfd
->diag
!= diag
) {
1053 if (!VLOG_DROP_INFO(&rl
)) {
1054 struct ds ds
= DS_EMPTY_INITIALIZER
;
1056 ds_put_format(&ds
, "%s: BFD state change: %s->%s"
1057 " \"%s\"->\"%s\".\n",
1058 bfd
->name
, bfd_state_str(bfd
->state
),
1059 bfd_state_str(state
), bfd_diag_str(bfd
->diag
),
1060 bfd_diag_str(diag
));
1061 bfd_put_details(&ds
, bfd
);
1062 VLOG_INFO("%s", ds_cstr(&ds
));
1069 if (bfd
->state
<= STATE_DOWN
) {
1070 bfd
->rmt_state
= STATE_DOWN
;
1071 bfd
->rmt_diag
= DIAG_NONE
;
1072 bfd
->rmt_min_rx
= 1;
1075 bfd
->rmt_min_tx
= 0;
1076 /* Resets the min_rx if in_decay. */
1077 if (bfd
->in_decay
) {
1078 bfd
->min_rx
= bfd
->cfg_min_rx
;
1079 bfd
->in_decay
= false;
1082 /* Resets the decay when state changes to STATE_UP
1083 * and decay_min_rx is configured. */
1084 if (bfd
->state
== STATE_UP
&& bfd
->decay_min_rx
) {
1085 bfd_decay_update(bfd
);
1088 seq_change(connectivity_seq_get());
1093 bfd_rx_packets(const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
1095 struct netdev_stats stats
;
1097 if (!netdev_get_stats(bfd
->netdev
, &stats
)) {
1098 return stats
.rx_packets
;
1104 /* Decays the bfd->min_rx to bfd->decay_min_rx when 'diff' is less than
1105 * the 'expect' value. */
1107 bfd_try_decay(struct bfd
*bfd
) OVS_REQUIRES(mutex
)
1109 int64_t diff
, expect
;
1111 /* The 'diff' is the difference between current interface rx_packets
1112 * stats and last-time check. The 'expect' is the recorded number of
1113 * bfd control packets received within an approximately decay_min_rx
1114 * (2000 ms if decay_min_rx is less than 2000 ms) interval.
1116 * Since the update of rx_packets stats at interface happens
1117 * asynchronously to the bfd_rx_packets() function, the 'diff' value
1118 * can be jittered. Thusly, we double the decay_rx_ctl to provide
1119 * more wiggle room. */
1120 diff
= bfd_rx_packets(bfd
) - bfd
->decay_rx_packets
;
1121 expect
= 2 * MAX(bfd
->decay_rx_ctl
, 1);
1122 bfd
->in_decay
= diff
<= expect
? true : false;
1123 bfd_decay_update(bfd
);
1126 /* Updates the rx_packets, decay_rx_ctl and decay_detect_time. */
1128 bfd_decay_update(struct bfd
* bfd
) OVS_REQUIRES(mutex
)
1130 bfd
->decay_rx_packets
= bfd_rx_packets(bfd
);
1131 bfd
->decay_rx_ctl
= 0;
1132 bfd
->decay_detect_time
= MAX(bfd
->decay_min_rx
, 2000) + time_msec();
1136 bfd_forwarding_if_rx_update(struct bfd
*bfd
) OVS_REQUIRES(mutex
)
1138 int64_t incr
= bfd_rx_interval(bfd
) * bfd
->mult
;
1139 bfd
->forwarding_if_rx_detect_time
= MAX(incr
, 2000) + time_msec();
1143 generate_discriminator(void)
1147 /* RFC 5880 Section 6.8.1
1148 * It SHOULD be set to a random (but still unique) value to improve
1149 * security. The value is otherwise outside the scope of this
1155 /* 'disc' is by definition random, so there's no reason to waste time
1157 disc
= random_uint32();
1158 HMAP_FOR_EACH_IN_BUCKET (bfd
, node
, disc
, all_bfds
) {
1159 if (bfd
->disc
== disc
) {
1170 bfd_find_by_name(const char *name
) OVS_REQUIRES(mutex
)
1174 HMAP_FOR_EACH (bfd
, node
, all_bfds
) {
1175 if (!strcmp(bfd
->name
, name
)) {
1183 bfd_put_details(struct ds
*ds
, const struct bfd
*bfd
) OVS_REQUIRES(mutex
)
1185 ds_put_format(ds
, "\tForwarding: %s\n",
1186 bfd_forwarding__(CONST_CAST(struct bfd
*, bfd
))
1187 ? "true" : "false");
1188 ds_put_format(ds
, "\tDetect Multiplier: %d\n", bfd
->mult
);
1189 ds_put_format(ds
, "\tConcatenated Path Down: %s\n",
1190 bfd
->cpath_down
? "true" : "false");
1191 ds_put_format(ds
, "\tTX Interval: Approx %lldms\n", bfd_tx_interval(bfd
));
1192 ds_put_format(ds
, "\tRX Interval: Approx %lldms\n", bfd_rx_interval(bfd
));
1193 ds_put_format(ds
, "\tDetect Time: now %+lldms\n",
1194 time_msec() - bfd
->detect_time
);
1195 ds_put_format(ds
, "\tNext TX Time: now %+lldms\n",
1196 time_msec() - bfd
->next_tx
);
1197 ds_put_format(ds
, "\tLast TX Time: now %+lldms\n",
1198 time_msec() - bfd
->last_tx
);
1200 ds_put_cstr(ds
, "\n");
1202 ds_put_format(ds
, "\tLocal Flags: %s\n", bfd_flag_str(bfd
->flags
));
1203 ds_put_format(ds
, "\tLocal Session State: %s\n",
1204 bfd_state_str(bfd
->state
));
1205 ds_put_format(ds
, "\tLocal Diagnostic: %s\n", bfd_diag_str(bfd
->diag
));
1206 ds_put_format(ds
, "\tLocal Discriminator: 0x%"PRIx32
"\n", bfd
->disc
);
1207 ds_put_format(ds
, "\tLocal Minimum TX Interval: %lldms\n",
1209 ds_put_format(ds
, "\tLocal Minimum RX Interval: %lldms\n", bfd
->min_rx
);
1211 ds_put_cstr(ds
, "\n");
1213 ds_put_format(ds
, "\tRemote Flags: %s\n", bfd_flag_str(bfd
->rmt_flags
));
1214 ds_put_format(ds
, "\tRemote Session State: %s\n",
1215 bfd_state_str(bfd
->rmt_state
));
1216 ds_put_format(ds
, "\tRemote Diagnostic: %s\n",
1217 bfd_diag_str(bfd
->rmt_diag
));
1218 ds_put_format(ds
, "\tRemote Discriminator: 0x%"PRIx32
"\n", bfd
->rmt_disc
);
1219 ds_put_format(ds
, "\tRemote Minimum TX Interval: %lldms\n",
1221 ds_put_format(ds
, "\tRemote Minimum RX Interval: %lldms\n",
1226 bfd_unixctl_show(struct unixctl_conn
*conn
, int argc
, const char *argv
[],
1227 void *aux OVS_UNUSED
) OVS_EXCLUDED(mutex
)
1229 struct ds ds
= DS_EMPTY_INITIALIZER
;
1232 ovs_mutex_lock(&mutex
);
1234 bfd
= bfd_find_by_name(argv
[1]);
1236 unixctl_command_reply_error(conn
, "no such bfd object");
1239 bfd_put_details(&ds
, bfd
);
1241 HMAP_FOR_EACH (bfd
, node
, all_bfds
) {
1242 ds_put_format(&ds
, "---- %s ----\n", bfd
->name
);
1243 bfd_put_details(&ds
, bfd
);
1246 unixctl_command_reply(conn
, ds_cstr(&ds
));
1250 ovs_mutex_unlock(&mutex
);
1255 bfd_unixctl_set_forwarding_override(struct unixctl_conn
*conn
, int argc
,
1256 const char *argv
[], void *aux OVS_UNUSED
)
1259 const char *forward_str
= argv
[argc
- 1];
1260 int forwarding_override
;
1263 ovs_mutex_lock(&mutex
);
1264 if (!strcasecmp("true", forward_str
)) {
1265 forwarding_override
= 1;
1266 } else if (!strcasecmp("false", forward_str
)) {
1267 forwarding_override
= 0;
1268 } else if (!strcasecmp("normal", forward_str
)) {
1269 forwarding_override
= -1;
1271 unixctl_command_reply_error(conn
, "unknown fault string");
1276 bfd
= bfd_find_by_name(argv
[1]);
1278 unixctl_command_reply_error(conn
, "no such BFD object");
1281 bfd
->forwarding_override
= forwarding_override
;
1283 HMAP_FOR_EACH (bfd
, node
, all_bfds
) {
1284 bfd
->forwarding_override
= forwarding_override
;
1288 unixctl_command_reply(conn
, "OK");
1291 ovs_mutex_unlock(&mutex
);