1 2006-05-12 Paul Jakma <paul.jakma@sun.com>
3 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
4 call, which is not checked for NULL return, by stripping out
5 functionality which is never used, hence fixing Coverity CID
7 (struct lsa_action) remove unused member.
8 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
9 check on ospf_lookup, CID #27.
10 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
11 call by taking the struct ospf * as argument, which the
12 caller has, fixing CID #28.
13 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
14 * ospf_zebra.c: (ospf_redistribute_unset) update call to
15 ospf_redistribute_withdraw to match.
16 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
17 NULL when passed to ospf_find_asbr_route_through_area,
18 check for NULL first, CID #14.
20 2006-05-11 Paul Jakma <paul.jakma@sun.com>
22 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
23 ensure check for NULL result, make vty messages consistent.
24 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
25 result, fixes Coverity CID #70.
26 (no_ospf_area_filter_list) Check NULL result from
27 ospf_area_lookup_by_area_id, fixes Coverity CID #69
28 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
29 NULL check by moving into check-protected block, fix CID #49.
30 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
31 range, should just lookup to see if one exists, the new range
32 is just leaked. Fixes CID #46.
33 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
34 take (struct ospf *) as thread argument, rather than (struct
35 ospf *)->default_originate, thus avoiding having to call
37 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
38 of ospf_default_originate_timer thread to match.
39 * ospfd.c: (ospf_router_id_update) ditto.
41 2006-04-24 Paul Jakma <paul.jakma@sun.com>
43 * (general) More Virtual-link fixes, again with much help in
44 testing / debug from Juergen Kammer. Primarily in SPF.
45 * ospf_spf.h: Add guard. ospf_interface.h will include this
47 * ospf_interface.h: Modify ospf_vl_lookup definition to take
48 struct ospf as argument, so as to allow for NULL area
50 (struct ospf_vl_data) Remove out_oi, instead add a struct
51 vertex_nexthop, to use as initial nexthop for backbone paths
53 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
54 NULL area to be passed to indicate "any" (first) area.
56 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
57 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
59 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
60 backbone, don't bother checking.
61 * ospf_spf.c: (static struct list vertex_list) Record vertices
62 that will need to be freed.
63 (cmp) Order network before router vertices, as required,
65 (vertex_nexthop_free) Mild additional robustness check.
66 (vertex_parent_free) Take void argument, as this function
67 is passed as list deconstructor for vertex parent list.
68 (ospf_vertex_new) More debug. Set deconstructor for parent
69 list. Track allocated vertices on the vertex_list.
70 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
71 vertices. Now frees only the given vertex.
72 (ospf_vertex_add_parent) Fix assert.
73 (ospf_nexthop_calculation) Fix calculation of nexthop for
74 VLink vertices, lookup the vl_data and use its previously
75 recorded nexthop information.
76 (ospf_spf_calculate) Vertices are freed simply by deleting
77 vertex_list nodes and letting ospf_vertex_free as deconstructor
79 (ospf_spf_calculate_timer) Trivial optimisation, leave
80 backbone SPF calculation till last to reduce SPF churn on
82 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
83 (no_ospf_area_vlink_cmd) ditto.
84 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
85 more interesting than the output interface.
87 2006-04-03 Paul Jakma <paul.jakma@sun.com>
89 * (general) Fix issues with handling of Vlinks and entries
90 in the nbrs route-table which were highlighted by the
91 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
92 Kammer for his help and efforts in testing out debug patches to
94 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
95 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
96 to create key in nbrs table for a given nbr.
97 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
98 document an expected state.
99 (ospf_nbr_add_self) Ditto.
100 (ospf_nbr_lookup_by_addr) Add an assert.
101 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
104 2006-03-27 Paul Jakma <paul.jakma@sun.com>
106 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
107 the ambiguities of ANSI and C99 C with respect to type
108 conversion. Detailed problem report and test case with
109 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
111 2006-03-25 Paul Jakma <paul.jakma@sun.com>
113 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
114 we can never ever receive packets on those. Should fix
115 case where CARP is run with address in same subnet as real
116 interface. Problem report and diagnosis thanks to:
117 Landon Fuller <landonf@opendarwin.org>.
118 However, ospf_read() still can't deal deterministically with
119 multiple interfaces in same subnet.
121 2006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
123 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
124 conversion of OSPF_MAX_SEQUENCE_NUMBER
126 2006-01-19 Paul Jakma <paul.jakma@sun.com>
128 * (general) various miscellaneous compiler warning fixes.
129 Remove redundant break statements from switch clauses
131 return from main, not exit, cause it annoys SOS.
132 Remove stray semi-colons which cause empty-statement
135 2006-01-18 Juergen Kammer <j.kammer@eurodata.de>
137 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
138 stream data until it is constructed, data reference is
139 volatile due to the potential resize in link_info_set
141 2006-01-18 Paul Jakma <paul.jakma@sun.com>
143 * ospf_lsa.c: (link_info_set) Resize the stream if required and
144 possible. Return number of links added.
145 (lsa_link_*_set) use return value from previous.
146 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
148 2006-01-17 Paul Jakma <paul.jakma@sun.com>
150 * ospf_packet.c: (ospf_verify_header) print out the types
151 involved if there's a mismatch.
152 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
154 2006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
156 * (general) Bug #234, see also [quagga-dev 3902].
157 Fix problem with nbr_self not being properly reinitialised
158 when an interface comes up, after having been down.
159 Some re-arrangement done by Paul Jakma, any bugs introduced
160 on top of Len's suggested changes are his.
161 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
162 initialisation of nbr_self parameters here.
163 * ospf_interface.c: (ospf_if_new) deleting initialisation of
164 parameters of nbr_self, just rely on call to
166 (ospf_if_cleanup) ditto.
167 * ospfd.c: (ospf_network_run) ditto.
169 2006-01-10 Juris Kalnins <juris@mt.lv>
171 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
172 struct connected in an error case.
173 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
174 undefined effect, assignment of an increment expression.
176 2006-01-10 Paul Jakma <paul.jakma@sun.com>
178 * ospfd.c: (ospf_network_run) checking to see if router-id
179 is set should be on ospf->router_id, not router_id_static.
180 This was causing ospfd to not start if router-id had not
181 been configured statically.
182 (ospf_if_update) ditto.
183 * ospf_vty.c: (config_write_ospf_distribute) trim down
186 2005-11-26 Paul Jakma <paul.jakma@sun.com>
188 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
189 array to C99 incomplete type array.
190 * (general) s/graceful/deferred/ in all files, the former term
191 is confusing wrt OSPF Graceful-Restart.
192 * ospfd.c: (ospf_deferred_shutdown_check) dont return
193 a function which returns void. SOS complains about this.
196 2005-11-20 Paul Jakma <paul.jakma@sun.com>
198 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
199 (struct ospf) remove the router_id timer thread.
200 remove export of ospf_router_id_update_timer.
201 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
202 poke interfaces into action after ID has been configured.
203 (ospf_router_id_update_timer) removed.
204 (ospf_finish_final) t_router_id_update timer is gone.
205 (ospf_network_run) router-id update timer gone.
206 call ospf_router_id_update directly if ID not configured.
207 In the per-iface loop, don't ospf_if_up interfaces if
208 ID is still not configured. The update function will call
209 ospf_if_update anyway.
210 (ospf_if_update) ID update timer is gone. Just return if no
212 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
214 * ospf_zebra.c: (ospf_router_id_update_zebra) call
215 ospf_router_id_update directly, not via timer.
216 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
217 returned LSA of ospf_summary_lsa_refresh and print warning if
219 (ospf_abr_announce_network_to_area) similar
220 (ospf_abr_announce_rtr_to_area) similar
221 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
222 (ospf_router_lsa_originate) similar
223 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
224 (ospf_summary_lsa_new) Check ID is valid.
225 (ospf_summary_lsa_originate) ditto, and check returned LSA from
226 previous function is !NULL.
227 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
229 (ospf_summary_asbr_lsa_new) ID valid check.
230 (ospf_summary_asbr_lsa_originate) similar.
232 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
234 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
235 for use with ospf_timer_dump and ospf_timeval_dump.
236 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
237 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
238 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
239 call to ospf_timer_dump.
241 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
243 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
244 in 'do {...} while(0)'.
246 2005-11-14 Paul Jakma <paul.jakma@sun.com>
248 * ospfd.c: (ospf_new) stub-shutdown should just default to
249 unconfigured, too strange otherwise.
250 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
251 preprocessor conditional on HAVE_OPAQUE_LSA.
252 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
253 no longer used, plus it wasn't in range that the command
255 * ospf_zebra.h: Depends on vty.h, include it.
257 2005-11-11 Paul Jakma <paul.jakma@sun.com>
259 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
260 the nexthops pointing to the root vertex. We may visit a
261 vertex twice or the vertex may have some inherited nexthops,
262 if we free other nexthops we could crash.
264 2005-11-04 Paul Jakma <paul.jakma@sun.com>
266 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
267 function rather than unportable timersub.
269 2005-11-03 Paul Jakma <paul.jakma@sun.com>
271 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
272 * ospf_packet.c: include checksum.h, remove the in_cksum extern
274 * ospf_te.h: Add braces, quell warning.
275 * ospf_packet.c: Change level of some warnings to
278 2005-10-29 Paul Jakma <paul.jakma@sun.com>
280 * (general) RFC3137 stub-router support
281 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
282 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
283 options, to allow shutdown to distinguish between complete
284 shutdown and shutdown of a subset of ospf instances.
286 Add stub_router_{startup,shutdown_}time, configuration of startup
287 and shutdown time for stub-router.
288 Add t_graceful_shutdown struct thread, timer for graceful
290 (struct ospf_area) Add stub_router_state - run time state of
291 stub-router for an area. Add flags for ADMIN, IS and WAS
293 Add t_stub_router, timer thread to resend router-lsa for an
295 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
296 either the given lnks cost or infinite cost if stub-router is
298 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
299 previous function for transit-links.
300 (ospf_stub_router_timer) timer thread for end of startup stub
301 router. Change state as required for the area and setup
302 re-origination of router-lsa.
303 (ospf_stub_router_check) Check/do whether stub-router should be
304 enabled, and whether it requires timer to be setup.
305 (ospf_router_lsa_new) call previous function at top.
306 (ospf_router_lsa_originate) no external callers, made static.
307 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
308 * ospf_main.c: (sigint) make static.
309 remove call to exit, as ospf_terminate now deals with
311 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
312 * ospf_vty.c: (show_ip_ospf_area) print out state of
313 stub-router, if active.
314 (show_ip_ospf) print out configuration of stub-router
315 support, and details of graceful-shutdown if the timer is
317 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
318 commands to (de-)?configure stub-router support.
319 (config_write_stub_router) write out config of stub-router.
320 (ospf_config_write) call previous.
321 (ospf_vty_init) install the new stub-router commands.
322 * ospfd.c: various functions made static.
323 (ospf_new) Set defaults for stub-router. Graceful shutdown
324 is made to default on, just to be adventerous.
325 (ospf_graceful_shutdown_finish) new function, final part of
327 (ospf_graceful_shutdown_timer) timer thread wrapper for
329 (ospf_graceful_shutdown_check) check whether to setup timer
330 for shutdown or proceed directly to final shutdown.
331 (ospf_terminate) moved here from ospf_route.c, call
332 ospf_finish for each instance.
333 (ospf_finish) renamed to ospf_finish_final and made static.
334 (ospf_finish) new function, exported wrapper around
335 ospf_graceful_shutdown_check.
336 (ospf_finish_final) complete shutdown of an instance.
337 Add missing TIMER_OFF's of two timer threads.
338 (ospf_area_free) opaque self lsa timer should be turned off.
340 2005-10-23 Paul Jakma <paul.jakma@sun.com>
342 * ospf_apiserver.c: (ospf_apiserver_term) This function should
343 not have side-effects (eg segv) if no apiserver instances are
344 active, ie be robust.
345 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
346 has not yet been run.
348 2005-10-21 Paul Jakma <paul.jakma@sun.com>
350 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
352 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
355 2005-10-21 Paul Jakma <paul.jakma@sun.com>
357 * (general) SPF millisecond resolution timer with adaptive,
358 linear back-off holdtime. Prettification of ospf_timer_dump.
359 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
360 ospf_timer_dump, but made to be more dynamic in printing out
361 the relative timeval, sliding the precision printed out
362 according to the value.
363 (ospf_timer_dump) guts moved to ospf_timeval_dump.
364 * ospf_dump.h: export ospf_timeval_dump.
365 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
366 the libzebra exported recent_time instead, as it's not
367 terribly critical to have time exactly right - the dropped
368 LSA will be retransmited to us if we don't ACK it.
369 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
370 not transmitting, just putting LSA back on update transmit list.
371 * ospfd.h: delay and holdtimes should be unsigned.
372 Add spf_max_holdtime and spf_hold_multiplier.
373 Update default defines for delay and hold time to be in msec.
374 (struct ospf) change the SPF timestamp to a struct timeval.
375 Remove ospf_timers_spf_(un)?set.
376 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
377 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
378 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
379 now, update with gettimeofday.
380 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
382 Make the holdtime be adaptive, with a linear increase in
383 holdtime ever consecutive SPF run which occurs within holdtime
384 of previous SPF, bounded by spf_max_holdtime.
385 * ospf_vty.c: Update spf timers commands.
386 (ospf_timers_spf_set) trivial helper.
387 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
388 initial hold and max hold times with millisecond resolution.
389 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
390 convert to msec, truncate to new limits.
391 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
392 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
393 (show_ip_ospf_cmd) Display SPF parameters and times.
394 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
396 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
397 the multiple spaces which were making the lines even longer.
398 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
399 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
400 widths for NBMA neighbours.
401 (show_ip_ospf_neighbor_int) Use header function.
402 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
404 (show_ip_ospf_neighbor_detail_sub) ditto
405 (ospf_vty_init) install the new SPF throttle timer commands.
407 2005-10-21 Paul Jakma <paul.jakma@sun.com>
409 * (general) OSPF fast, sub-second hello and 1s dead-interval
411 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
412 Callers typically specify a length of 9, so most see
413 millisecs unless they specify the additional length.
414 * ospf_interface.h: (struct ospf_interface) new interface param,
416 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
418 (ospf_new_if_params) Initialise fast_hello param.
419 (ospf_free_if_params) Check whether fast_hello is configured.
420 (ospf_if_new_hook) set fast_hello to default.
421 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
422 prevent funny side-effects from its if statement when this
423 macro is used conditionally by other macros.
424 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
425 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
426 to whether fast_hello is set.
427 * ospf_ism.c: Update all setting of the hello timer to use
428 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
429 former is used when hello is to be sent immediately.
431 * ospf_packet.c: (ospf_hello) hello-interval is not checked
432 for mismatch if fast_hello is set.
433 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
434 rather than a warning, as it can be perfectly normal to
435 receive packets when logical subnets are used.
436 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
438 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
439 nit, don't vty_out if this command is given, it gets tired
441 (show_ip_ospf_interface_sub) Print the hello-interval
442 according to whether fast-hello is set or not.
443 Print the extra 5 millisec characters from (ospf_timer_dump)
444 if fast-hello is configured.
445 (ospf_vty_dead_interval_set) new function, common to all
446 forms of dead-interval command, to set dead-interval and
447 fast-hello correctly. If a dead-interval is given, unset
448 fast-hello, else if a hello-multiplier is set, set
449 dead-interval to 1 and fast-hello to given multiplier.
450 (ip_ospf_dead_interval_addr_cmd) use
451 ospf_vty_dead_interval_set().
452 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
453 (no_ip_ospf_dead_interval) Unset fast-hello.
454 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
455 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
456 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
457 (config_write_interface) Write out fast-hello.
458 (ospf_config_write) Write a comment about
459 "auto-cost reference-bandwidth" having to be equal on all
460 routers. Hopefully just as noticeable as old practice of
461 writing to vty, but less annoying.
462 (ospf_vty_if_init) install the two new dead-interval
464 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
465 and OSPF_FAST_HELLO_DEFAULT.
467 2005-10-18 Paul Jakma <paul.jakma@sun.com>
469 * (general) SPF memory management cleanup and fix for rare
471 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
472 specific data, eg the backlink and the parent vertex pointer,
473 and point to the appropriate general struct vertex_nexthop.
474 (struct vertex_nexthop) remove parent vertex pointer, so
475 this struct can be shared across vertices.
476 (struct vertex) rename list child to list children. Remove
477 list of nexthops, replace with list of vertex_parents.
478 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
479 (vertex_nexthop_new) remove init of parent - field is gone
480 from struct vertex_nexthop.
481 (ospf_canonical_nexthops_free) Remove the canonical
482 vertex_nexthop memory objects. These are the vertex_nexthops
483 attached to the first level of router vertices from the root.
484 (vertex_parent_new) new function, create a vertex_parent.
485 (vertex_parent_free) ditto, but free it.
486 (ospf_vertex_new) Update to match changes to struct vertex.
487 (ospf_vertex_free) Recursively free a struct vertex and its
488 children. The parent list is used as a reference count.
489 vertex_nexthops must be free seperately, if required.
490 (ospf_vertex_dump) update to match struct vertex changes.
491 Print out backlink of parents too.
492 (ospf_vertex_add_parent) ditto.
493 (ospf_lsa_has_link) update comment.
494 (ospf_nexthop_add_unique) removed, not needed anymore.
495 (ospf_nexthop_merge) ditto.
496 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
497 Simplified to just create vertex_parent and add it.
498 (ospf_spf_flush_parents) new function, flush out the parent
500 (ospf_nexthop_calculation) Take the relevant route_lsa_link
501 as an argument, which simplifies things and removes the need
502 for the hack in ospf_nexthop_add_unique - ospf_spf_next
503 already knew exactly which link the cost calculated was for.
504 Update to match struct vertex changes too.
505 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
506 it's there's a vertex already created for W, use it, and
507 hence there's no need to free it either.
508 Update some manipulation/comparisons of distance to match.
509 Flush the parent list if a lower cost path is found.
510 (ospf_spf_route_free) unused, removed.
511 (ospf_spf_dump) match the struct vertex changes, and dump the
513 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
514 and call ospf_vertex_free on the root vertex to free the
516 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
518 * ospf_route.c: (ospf_intra_route_add) ditto
519 (ospf_route_copy_nexthops_from_vertex) ditto
521 2005-10-11 Paul Jakma <paul.jakma@sun.com>
523 * ospf_api.c: sign warnings.
524 * ospf_apiserver.c: sign warning and convert all the struct
525 in_addr initialisations so as not to make assumptions about
526 how this struct is organised, initialise the s_addr member
528 * ospf_packet.c: Add const qualifier to auth_key.
530 2005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
532 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
533 which now allows snmpwalk to work with ospfIfTable and
534 also with ospfIfMetricTable
536 2005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
538 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
539 (ospf_redist_string) New function implemented using new library
540 function zebra_route_string(). Note that there are a few differences
541 in the output that will result: the new function returns strings
542 that are lower-case, whereas the old table was mixed case. Also,
543 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
544 new function returns "ospf6".
545 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
546 and add extern const char *ospf_redist_string(u_int route_type)
548 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
549 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
550 * ospf_vty.c: Remove local hard-coded table distribute_str.
551 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
552 new library function zebra_route_string() instead of distribute_str[].
553 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
554 ospf_redistribute_default_set,ospf_redistribute_check)
555 In debug messages, use ospf_redist_string() instead of
556 LOOKUP(ospf_redistributed_proto).
558 2005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
560 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
563 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
565 * ospf_ism.c: generate SNMP traps on Interface state change
566 * ospf_nsm.c: generate SNMP traps on Neighbour state change
567 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
569 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
571 * ospf_vty.c: forece default route LSA to be re_issued whenever
572 cost is changed ( [no] ip ospf area XXX default-cost YYY)
573 Support ignore-mtu option
574 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
575 * ospf_packet.c: support ignore-mtu option
576 * ospf_interface.h: field added for skipping MTU check
577 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
578 Set mtu_ignore field to default value
579 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
580 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
582 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
583 convert OSPFIFSTATE internal status into SNMP values
585 2005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
587 * ospf_packet.c: use new md5 API
589 2005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
591 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
592 (nexthop) since it is not used in the function (except inside
593 some commented-out code).
594 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
595 Comment out the 5th argument to ospf_external_lsa_flush.
596 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
597 to ospf_external_lsa_flush.
598 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
599 uninitialized nexthop arg to ospf_external_lsa_flush.
600 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
601 to ospf_external_lsa_flush.
602 * ospfd.c: (ospf_network_set) Comment out 5th arg
603 to ospf_external_lsa_flush.
605 2005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
608 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
609 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
611 2005-08-21 Hasso Tepper <hasso at quagga.net>
613 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
614 Interface should be specified by name now.
616 2005-08-17 Hasso Tepper <hasso at quagga.net>
618 * ospf_vty.c: Check carefully if interface exists before trying to
621 2005-08-05 Hasso Tepper <hasso at quagga.net>
623 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
624 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
625 for default-information.
627 2005-07-26 Paul Jakma <paul.jakma@sun.com>
629 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
630 should be on lsa not old, which may be freed for one thing,
633 2005-07-12 Paul Jakma <paul.jakma@sun.com>
635 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
636 OSPF_ABR_CISCO be the default ABR type.
637 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
638 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
639 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
640 (ospf_config_write) test whether default abr_type against
641 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
643 2005-06-20 Hasso Tepper <hasso at quagga.net>
645 * ospf_nsm.c: Make database exchange for NSSA database work.
647 2005-06-13 Paul Jakma <paul.jakma@sun.com>
649 * ospf_spf.c: Try get more information on a SEGV under
650 ospf_spf_vertex_add_parent.
651 (ospf_vertex_free) NULL out the child and nexthop lists
652 (ospf_vertex_add_parent) nexthop and child can not be NULL
653 vertex_nexthop's parent->child list can not be NULL
654 (ospf_spf_next) w and cw are per-loop iteration variables, move
655 declarations into loop body.
657 2005-06-07 Hasso Tepper <hasso at quagga.net>
659 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
660 changes - oi->ifp->status doesn't give to us info about ISM,
663 2005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
665 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
667 2005-05-26 Paul Jakma <paul.jakma@sun.com>
669 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
670 had been fixed long ago by Sowmini.
672 2005-05-19 Paul Jakma <paul.jakma@sun.com>
674 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
676 1: this function is supposed to lookup
677 entries in the oifs ospf_interface route_table and return either
678 an existing oi or NULL to indicate not found, its caller depends
679 on this, yet this function uses route_node_get which /always/
680 returns a route_node - one is created if none exists. Use
681 route_node_lookup instead. This should fix root cause of the
682 reports of the (ospf_add_to_if) assert being hit.
683 2: oi's are inserted into this table with prefixlength set to
684 /32 (indeed, it should be a hash table, not a route_table),
685 however prefixlength to lookup was not changed, if no valid entry
686 can be inserted other than /32, then nothng but /32 should be
687 looked up. This possibly only worked by fluke..
688 Fix confirmed by 2 reporters (one list, one IRC), definitely a
689 backport candidate once it has been incubated in HEAD for a while.
690 Thanks to Patrick Friedel and Ivan Warren for testing.
692 2005-05-11 Paul Jakma <paul.jakma@sun.com>
694 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
695 with much debugging done by by scott collins <scollins@agile.tv>.
696 * ospf_lsa.c: (ospf_discard_from_db) dont call
697 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
698 never registered with ase in the first place.
699 * ospf_packet.c: (general) Disabuse opaque related code of its
700 tendency to try gather up things into temporary lists.
701 (ospf_ls_upd) remove the temporary lists opaque uses, call
702 opaque functions inline, just like all other types.
704 (ospf_recv_packet) fixup sign warning.
705 * ospf_opaque.c: (general) fix the unneeded use of lists, and
706 untwist some of the logic.
707 (ospf_opaque_self_originated_lsa_received) take a single LSA
708 as argument, not a list of them. Remove the list loop. Logic
710 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
711 move the actions up into the switch block, remove the goto's and
712 sanitise the logic near the end a bit.
713 * ospf_opaque.h: Adjust definitions of aforementioned functions
714 in ospf_opaque.c to match.
716 2005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
718 * ospf_network.c: Log ifindex on multicast membership leave/join
721 2005-05-06 Paul Jakma <paul.jakma@sun.com>
723 * (general) extern and static qualifiers added.
724 unspecified arguments in definitions fixed, typically they should
726 function casts added for callbacks.
727 Guards added to headers which lacked them.
728 Proper headers included rather than relying on incomplete
730 gcc noreturn function attribute where appropriate.
731 * ospf_opaque.c: remove the private definition of ospf_lsa's
732 ospf_lsa_refresh_delay.
733 * ospf_lsa.h: export ospf_lsa_refresh_delay
734 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
735 correct thing to do - removes need for the casts later.
736 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
737 home-brewed versions, shuts up several warnings.
738 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
739 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
740 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
741 overloading of the THREAD_ARG pointer should at least use
744 2005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
746 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
747 to approve LSAs for the case where metric has changed, lsa gets
748 flushed otherwise. (backport candidate).
750 2005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
752 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
755 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
757 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
758 function that does not exist.
760 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
762 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
763 if_lookup_by_name_len.
765 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
767 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
769 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
771 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
772 flags to help with debugging.
773 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
775 (zebra_interface_if_lookup) Make function static. Tighten up code.
777 2005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
779 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
782 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
784 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
785 interface changes, print a debug message and call ospf_if_reset()
786 to simulate down/up on the interface.
787 * ospf_interface.h: Declare new function ospf_if_reset().
788 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
789 and ospf_if_up for all ospf interfaces attached to an interface.
791 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
793 * ospf_packet.c: (ospf_write_frags) Enhance error message to
794 show MTU. Also make function static.
795 (ospf_write) Enhance error message to show interface name and MTU.
796 Also make function static.
798 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
800 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
801 bandwidth; this is useful for debugging problems. Also, the function
804 2005-03-27 Hasso Tepper <hasso at quagga.net>
806 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
809 2005-03-25 Hasso Tepper <hasso at quagga.net>
811 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
813 2005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
815 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
816 backward, then current time may be less than
817 ospf->lsa_refresher_started. This was causing invalid values
818 for ospf->lsa_refresh_queue.index resulting in infinite loops.
819 Problem fixed by casting the expression to unsigned before taking
822 2005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
824 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
825 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
826 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
827 (ospf_finish) Call stream_free(ospf->ibuf.
828 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
829 pass it to ospf_recv_packet for use in receiving the packet
830 (instead of allocating a new stream for each packet received).
831 Eliminate all calls to stream_free(ibuf).
832 (ospf_recv_packet) The struct stream *ibuf is now passed in as
833 an argument. No need to use recvfrom to peek at the packet
834 header (to see how big it is), just use ospf->ibuf which is
835 always large enough (this eliminates a system call to recvfrom).
836 Therefore, no need to allocate a stream just for this packet,
837 and no need to free it when done.
839 2005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
841 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
842 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
843 * ospf_spf.h: Add link to the LSA stat structure into vertex.
844 * ospf_spf.c: New functions cmp() and update_stat() to manage
845 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
846 ospf_install_candidate() and ospf_spf_register() functions not needed
847 any more. Update ospf_vertex_new(), ospf_spf_next() and
848 ospf_spf_calculate() functions to use pqueue instead of linked list.
850 2005-02-21 Hasso Tepper <hasso at quagga.net>
852 * ospf_ase.c: Don't show messages related to the ase calculations if
853 we are not debugging.
855 2005-02-19 Hasso Tepper <hasso at quagga.net>
857 * ospf_api.h: char isn't always signed, but it has to be it here.
859 2005-02-19 Paul Jakma <paul.jakma@sun.com>
861 * ospf_packet.c: (ospf_stream_copy) remove
862 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
864 2005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
866 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
867 packet in the queue, it must be discarded. Improve warning messages.
869 (ospf_read) Fix bug: should reset the read thread in all cases
870 to make sure we continue to get incoming messages.
872 2005-02-15 Paul Jakma <paul.jakma@sun.com>
874 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
877 2005-02-14 Paul Jakma <paul.jakma@sun.com>
879 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
881 2005-02-11 Hasso Tepper <hasso at quagga.net>
883 * ospf_lsdb.c: Fix sum of checksums calculation.
885 2005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
887 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
890 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
892 * ospf_interface.h: Reduce structure padding by putting new u_char
893 field multicast_memberships in a better spot (grouped with
894 other u_char fields type and state).
896 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
898 * ospf_interface.h: Improve passive_interface comment. Add new
899 multicast_memberships bitmask to struct ospf_interface to track
900 active multicast subscriptions. Declare new function
901 ospf_if_set_multicast.
902 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
903 multicast memberships properly based on the current
904 multicast_memberships status and the current values of the
905 ospf_interface state, type, and passive_interface status.
906 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
907 now handled by ism_change_state's call to ospf_if_set_multicast).
908 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
909 handled by ism_change_state).
910 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
911 the DRouters multicast group (now handled by ism_change_state's call
912 to ospf_if_set_multicast).
913 (ism_change_state) Add call to ospf_if_set_multicast to change
914 multicast memberships as necessary to reflect the new interface state.
915 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
916 passive interface: 1. Increase the severity of the error message
917 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
918 message (packet destination address and interface address);
919 and 3. If the packet was sent to ospf-all-routers, then try
920 to fix the multicast group memberships.
921 (ospf_read) When a packet is received on an interface whose state
922 is ISM_Down, enhance the warning message to show the packet
923 destination address, and try to update/fix the multicast group
924 memberships if the packet was sent to a multicast address.
925 When a packet is received for ospf-designated-routers, but the
926 current interface state is not DR or BDR, then increase the
927 severity level of the error message from LOG_INFO to LOG_WARNING,
928 and try to fix the multicast group memberships.
929 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
930 any ospf interface that may have changed from active to passive.
931 (no_ospf_passive_interface) Call ospf_if_set_multicast for
932 any ospf interface that may have changed from passive to active.
933 (show_ip_ospf_interface_sub) Show multicast group memberships.
935 2005-02-08 Paul Jakma <paul@dishone.st>
937 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
939 2005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
941 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
942 not for event ISM_InterfaceDown. And improve the message by
943 adding the interface flags.
945 2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
947 * ospf_network.c: (ospf_sock_init) Save errno before calling
950 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
952 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
953 an error message and return.
954 (ospf_read) If the interface state is ISM_InterfaceDown, issue
955 a warning message and ignore the packet.
957 2005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
959 * ospf_packet.h: Remove commented out definition of
960 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
962 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
963 when deciding if an update will fit.
964 (ospf_packet_authspace): Factor out calculation of size required
966 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
967 Don't confuse readers that there is a macro.
969 2004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
971 * ospf_network.c: Improve all setsockopt error messages to give detailed
972 information on the arguments.
974 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
976 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
977 messages from LOG_WARNING to LOG_INFO, since this seems to be
980 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
982 * ospf_packet.c: (ospf_read) Always look up the interface if
983 ospf_recv_packet returns NULL ifp, since some platforms such
984 as Solaris 8 appear to support ifindex retrieval but don't.
986 2004-12-22 Hasso Tepper <hasso at quagga.net>
988 * ospf_dump.c: Show debug configuration in vtysh.
989 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
990 any case if it's configured as "translate-never".
991 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
992 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
993 number of all LSAs with AS scope, this includes opaque as LSAs as
994 well, show this number separately. Show numbers and sums of
995 checksums for each type of LSAs.
996 * ospf_lsa.c: Calculate checksum before putting LSA into database.
998 2004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1000 * ospf_interface.h: Declare new function ospf_default_iftype.
1001 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1002 this logic in one place.
1003 * ospf_zebra.c: (ospf_interface_add) Use new function
1004 ospf_default_iftype.
1005 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1006 by using new function ospf_default_iftype.
1008 2004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1010 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1011 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1012 messages to include identifying information (e.g. router id).
1013 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1014 router id and state names.
1016 2004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1018 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1019 ospf_apiserver * from listnode. Remove unused variables. Follows
1020 suggestion from Jay Fenlason.
1022 2004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1024 * *.c: Change level of debug messages to LOG_DEBUG.
1026 2004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1028 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1030 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1032 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1033 from LOG_NOTICE to LOG_DEBUG.
1035 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1037 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1038 (main) Issue a startup announcement using zlog_notice.
1040 2004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1042 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1043 message and in comment.
1044 (ospf_db_desc) Warning message that a packet is being discarded
1045 should give the router id of the packet source. Fix spelling
1046 of packet in two warning messages.
1047 (ospf_ls_req) Warning message that a link state request is being
1048 discarded should give the router id of the neighbor that sent it.
1050 2004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1052 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1053 lib/debug.h has now been deleted).
1055 2004-11-25 Hasso Tepper <hasso at quagga.net>
1057 * ospf_main.c: Make group to run as configurable.
1059 2004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1061 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1062 and works (lib/zebra.h provides if OS doesn't).
1064 2004-11-15 Paul Jakma <paul@dishone.st>
1066 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1068 2004-11-12 Paul Jakma <paul@dishone.st>
1070 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1071 ignore stub area summary default. Even so it seems a strange
1072 check, add a comment to that effect.
1074 2004-11-04 Paul Jakma <paul@dishone.st>
1076 * ospfd.c: (ospf_network_match_iface) revert to previous network
1077 statement match behaviour.
1079 2004-11-02 Paul Jakma <paul@dishone.st>
1081 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1082 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1083 fixing the unfortunate borkenness introduced in moving of this code
1085 (ospf_write) remove iovp and fix up call to previous.
1086 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1087 glibc's size_t format modifier is not portable.
1089 2004-10-31 Paul Jakma <paul@dishone.st>
1091 * ospf_packet.c: (ospf_write_frags) Add debug output
1092 (ospf_write) set type early, so we can pass it to
1094 (ospf_ls_upd_packet_new) print size in debug output when too large
1095 packet is encountered.
1096 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1097 THREAD_ARG to store an integer, but it should at least use same
1098 same type to retrieve the value. Assert value is sane.
1100 2004-10-22 Paul Jakma <paul@dishone.st>
1102 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1104 * ospf_packet.c: (ospf_read) manually look up ifindex
1105 if system could not have returned one, eg openbsd, thanks to Rivo
1106 Nurges for highlighting problem and fix.
1107 Change setsockopt_pktinfo to setsockopt_ifindex.
1109 2004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1111 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1112 with dedicated subnets properly.
1113 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1114 * ospfd.c: (ospf_network_match_iface) ditto.
1115 (ospf_network_run) ditto.
1116 * ospf_interface.c: (ospf_if_is_configured) ditto.
1117 (ospf_if_lookup_by_prefix) ditto.
1118 (ospf_if_lookup_recv_if) ditto.
1119 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1120 broadcast address if present.
1122 2004-10-13 Hasso Tepper <hasso at quagga.net>
1124 * ospf_main.c: Unbreak compilation with ospfapi disabled.
1125 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1126 snmpd. Connection is initialized only if smux peer is configured.
1128 2004-10-12 Hasso Tepper <hasso at quagga.net>
1130 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1131 static variable from ospf_main.c into ospf_opaque.c.
1133 2004-10-11 Hasso Tepper <hasso at quagga.net>
1135 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1136 command line switch to enable it.
1138 2004-10-11 Paul Jakma <paul@dishone.st>
1140 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1141 remove ntohs that should have dissappeared. Take struct ip
1142 as argument, caller has to know there's an IP header at start of
1144 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1145 * ospf_packet.c: (ospf_write) correct call to
1146 sockopt_iphdrincl_swab_htosys which was munging the header.
1147 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1148 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1150 * (global) Const char update and signed/unsigned fixes.
1151 * (various headers) size defines should be unsigned.
1152 * ospf_interface.h: remove duplicated defines, include the
1153 authoritative header - though, these defines should probably
1154 be moved to a dedicated header, or ospfd.h.
1155 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1156 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
1158 2004-10-08 Hasso Tepper <hasso at quagga.net>
1160 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1161 unsigned, remove unused variables etc.
1163 2004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1165 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1166 use of variable names 'node' and 'nextnode' to avoid possible
1167 conflict with list macros. Move variable declaration inside for
1168 loop after a statement to top of function.
1170 2004-10-07 Paul Jakma <paul@dishone.st>
1172 * ospf_snmp.c: Missed list typedef update
1173 * ospf_dump.c: Include sockopt.h for header swab functions.
1175 2004-10-05 Paul Jakma <paul@dishone.st>
1177 * ospf_packet.c: replace ospf_swap_iph_to... with
1178 sockopt_iphdrincl_swab_...
1180 2004-10-03 James R. Leu <jleu at mindspring.com>
1182 * ospf_zebra.c: Read router id related messages from zebra daemon.
1183 Schedule router-id update thread if it's changed.
1184 * ospfd.c: Remove own router-id selection function. Use router id from
1185 zebra daemon if it isn't manually overriden in configuration.
1187 2004-09-27 Paul Jakma <paul@dishone.st>
1189 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1190 Apply to offset too. Print ip_cksum, lets not worry about
1191 possible 2.0.37 compile problems.
1192 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1193 HAVE_IP_HDRINCL_BSD_ORDER.
1194 (ospf_recv_packet) ditto.
1195 (ospf_write) Fixup iov argument to ospf_write_frags.
1196 (struct msghdr).msg_name is caddr_t on most platforms.
1197 (ospf_recv_packet) ditto. And msg_flags is not always there
1198 memset struct then set fields we care about rather than
1199 initialise all fields individually.
1201 2004-09-26 Hasso Tepper <hasso at quagga.net>
1203 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1204 ospf_zebra.c: Fix compiler warnings.
1206 2004-09-24 Paul Jakma <paul@dishone.st>
1208 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1209 update some list loops to LIST_LOOP. some miscellaneous indent
1211 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1212 referenced node in loop.
1213 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1214 deletes referenced nodes from apiserver_list, fixed.
1215 * ospf_interface.h: lists typedef removal cleanup.
1216 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1217 loops to LIST_LOOP. miscellaneous style and indent fixups.
1218 * ospf_te.{c,h}: ditto
1219 * ospf_packet.c: lists typedef removal cleanup.
1220 (ospf_write) ifdef fragmentation support. move actual
1221 fragmentation out to a new, similarly ifdefed, function.
1222 (ospf_write_frags) fragmented write support, moved from previous.
1224 2004-09-23 Hasso Tepper <hasso at quagga.net>
1226 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1228 2004-09-12 Paul Jakma <paul@dishone.st>
1230 * ospf_packet.c: Fix bugzilla #107
1231 (ospf_packet_max) get rid of the magic 88 constant
1232 (ospf_swab_iph_ton) new function. set ip header to network order,
1233 taking BSDisms into account.
1234 (ospf_swab_iph_toh) the inverse.
1235 (ospf_write) Add support for IP fragmentation, will only work on
1236 linux though, other kernels make it impossible. get rid of the
1238 (ospf_make_ls_upd) Bound check to end of stream, not to
1240 (ospf_ls_upd_packet_new) New function, allocate upd packet
1241 taking oversized LSAs into account.
1242 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1243 rather than statically allocating mtu sized packet buffer, which
1244 actually was wrong - it didnt take ip header into account, which
1245 should not be included in packet buffer.
1246 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1249 2004-08-31 David Wiggins <dwiggins@bbn.com>
1251 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1252 print statements. New function ospf_vertex_dump used in debugging.
1254 2004-08-31 David Wiggins <dwiggins@bbn.com>
1256 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1258 2004-08-31 David Wiggins <dwiggins@bbn.com>
1260 * ospf_route.c: When finding an alternate route, log cost as well.
1262 2004-08-31 David Wiggins <dwiggins@bbn.com>
1264 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1265 struct prefix allocated on stack.
1267 2004-08-31 David Wiggins <dwiggins@bbn.com>
1269 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1270 acks to AllSPFRouters, rather than All-DR.
1272 2004-08-27 Hasso Tepper <hasso at quagga.net>
1274 * ospf_vty.c: Don't print ospf network type under interface only
1275 if interface is in broadcast mode and interface type really is
1276 broadcast. Fixes Bugzilla #108.
1278 2004-08-27 David Wiggins <dwiggins@bbn.com>
1280 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1281 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1284 2004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1286 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
1287 buffer used to get interface index so that it compiles on other
1288 than Linux and includes the required alignment space. Probably
1289 this was only working on sparc/sparc64 because most of
1290 sockaddr_dl was not being written.
1292 2004-08-19 Paul Jakma <paul@dishone.st>
1294 * ospf_packet.c: update to match sockopt renames.
1296 2004-08-04 Paul Jakma <paul@dishone.st>
1298 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1299 Compare only against list head - all nexthops must be same cost
1300 anyway, fixes a reference-listnode-after-delete bug noted by
1302 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1303 candidates attached to root.
1305 2004-07-27 Paul Jakma <paul@dishone.st>
1307 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1308 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1309 ospf_ls_upd_queue_send() - guaranteed segfault.
1311 2004-07-27 Paul Jakma <paul@dishone.st>
1313 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1314 the LSA as then free_opaque_info_per_id() can never unlock (and
1315 free) the LSA. Reported by Gunnar Stigen.
1317 2004-07-23 Paul Jakma <paul@dishone.st>
1319 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1321 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1322 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1324 2004-07-14 Paul Jakma <paul@dishone.st>
1326 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1327 problem reported by Peter Frost amongst others, where function
1328 will spin indefinitely if update list contains LSAs greater than
1329 MTU-headers or other condition leading to update list never being
1330 cleared. Problem of what to do with these LSAs remains.
1331 (ospf_make_ls_upd) add comment about large LSA problem,
1332 indentation cleanup.
1334 2004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1336 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1338 2004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1340 * Makefile.am: Add shlib support.
1342 2004-06-10 Hasso Tepper <hasso@estpak.ee>
1344 * *: Removed ifdefs HAVE_NSSA.
1346 2004-06-06 Paul Jakma <paul@dishone.st>
1348 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1349 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1351 2004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1353 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1354 index is out of range.
1355 ospf_flood.c: endianness fix
1356 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1359 2004-05-10 Hasso Tepper <hasso@estpak.ee>
1361 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1362 to ospf_zebra.c from ospfd.c and add redistribution updates if
1363 route-map is used in redistribution.
1364 * ospf_main.c: Remove now useless call to ospf_init().
1366 2004-05-08 Paul Jakma <paul@dishone.st>
1368 * ospf_zebra.c: Sync with lib/zclient changes
1370 2004-05-05 Paul Jakma <paul@dishone.st>
1372 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1373 defined. Warn at compile and runtime. Use
1374 IPTOS_PREC_INTERNETCONTROL otherwise.
1375 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1376 some of the checks up to ospf_read, return either a
1377 virtual link oi, or NULL.
1378 (ospf_read) Cleanup, make it responsible for checks. Remove
1379 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1380 lookups to use new wrappers exported by ospf_neighbor.
1381 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1382 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1383 neighbour table by router-id for virtual-link ospf_interfaces,
1384 not by peer_addr (which breaks for asymmetric vlinks)
1385 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1387 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1388 address for either end of a virtual-link, and hence potential cost
1391 2004-04-22 Hasso Tepper <hasso@estpak.ee>
1393 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1394 to "summarize" routes in ASBR at the moment.
1396 2004-04-20 Hasso Tepper <hasso@estpak.ee>
1398 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1399 Fixes UNH OSPF_NSSA.1.2a comment.
1400 * ospf_abr.c: Originate default into stub/nssa area even if
1401 summaries are disabled.
1402 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1404 2004-04-19 Hasso Tepper <hasso@estpak.ee>
1406 * ospf_vty.c: Don't warn that export- and import-list can't be
1407 configured to backbone area if they are applied and are working
1410 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1412 * ospf_packet.c: Don't drop packets in Solaris x86.
1415 2004-03-18 Amir Guindehi <amir@datacore.ch>
1417 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1418 Quagga's ospfd in the special situation that a node's opaque
1419 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1421 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1423 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1424 should be configured with the highest cost path within the range,
1427 2004-02-17 Paul Jakma <paul@dishone.st>
1429 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1430 params, nor the interface structure, if an interface delete
1431 message is received from zebra.
1432 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1433 params and interface, ie that which was previously removed in
1434 (ospf_interface_delete) above.
1436 2004-02-11 Hasso Tepper <hasso@estpak.ee>
1437 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1438 if oi doesn't exist any more.
1440 2004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1441 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1442 LSA if it was originated with older router-id ([zebra 14710] #6).
1444 2003-12-08 Mattias Amnefelt <mattiasa@kth.se>
1446 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1449 2003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1451 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1452 while trying not to change semantics. Add ifdefed-out code to
1453 avoid matching ppp interfaces whose destination address does not
1454 also match the prefix under consideration, to help out people with
1455 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1458 2003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1460 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1461 node in body of the loop to avoid chance that route node
1462 is unlocked and deleted before the next iteration tries to
1463 get next route node.
1465 2003-05-24 Kenji Yabuuchi
1467 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1468 match for interface lookup.
1470 2003-05-18 Hasso Tepper <hasso@estpak.ee>
1472 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1475 2003-05-16 Hasso Tepper <hasso@estpak.ee>
1477 * ospf_lsa.c: Fix handling of NSSA
1479 2003-04-23 Hasso Tepper <hasso@estpak.ee>
1481 * ospf_vty.c: fix "router xxx" node commands in vtysh
1483 2003-04-19 Hasso Tepper <hasso@estpak.ee>
1485 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1486 * ospf_routemap.c: sync daemon's route-map commands to have same
1489 2003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1491 * ospf_packet.c: Add missing param to zlog
1492 * ospf_flood.c: remove unused vars
1494 2003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1496 * ospf_interface.c: fix incorrect memset
1498 2003-04-10 Amir Guindehi <amir@datacore.ch>
1500 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1502 2003-04-03 David Watson <dwatson@eecs.umich.edu>
1504 * ospf_lsa.c: byte order fix
1506 2002-03-17 Amir Guindehi <amir@datacore.ch>
1508 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1509 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1510 * ospfclient: OSPFAPI demonstration client.
1512 2003-01-23 Masahiko Endo <endo@suri.co.jp>
1514 * ospf_ism.c: NSM event schedule bug fix.
1516 2002-10-30 Greg Troxel <gdt@ir.bbn.com>
1518 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1520 2002-10-23 endo@suri.co.jp (Masahiko Endo)
1522 * ospf_opaque.c: Update Opaque LSA patch.
1524 2002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1526 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1528 2002-10-23 Juris Kalnins <juris@mt.lv>
1530 * ospf_interface.c (ospf_if_stream_unset): When write queue
1531 becomes empty stop write timer.
1533 2002-10-10 Greg Troxel <gdt@ir.bbn.com>
1535 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1538 2002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1540 * zebra-0.93 released.
1542 2002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1544 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1545 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1546 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1547 Paul Jakma <paulj@alphyra.ie>.
1549 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1552 2002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1554 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1556 2001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1558 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1559 OSPF interface information.
1560 (ospf_delete_from_if): Likewise.
1562 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1564 2001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1566 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1567 is OSPF, do not unset redistribute flag.
1569 2001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1571 * zebra-0.92a released.
1573 2001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1575 * zebra-0.92 released.
1577 2001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1579 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1580 configuration display.
1582 2001-07-24 David Watson <dwatson@eecs.umich.edu>
1584 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1585 check for an existing link before connecting the parent and child.
1586 ospf_nexthop_calculation is also modified to check for duplicate
1587 entries when copying from the parent. Finally, ospf_spf_next
1588 removes duplicates when it merges two equal cost candidates.
1590 2001-07-23 itojun@iijlab.net
1592 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1595 2001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1597 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1600 2001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1602 * ospf_zebra.c (config_write_ospf_default_metric): Display
1603 default-metric configuration.
1605 2001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1607 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
1609 2001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1611 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
1613 (ospfIfMetricEntry): Likewise.
1615 2001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1617 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
1618 Lin'Kova" <jen@stack.net>.
1620 2001-03-15 Gleb Natapov <gleb@nbase.co.il>
1622 * ospf_interface.c (ip_ospf_network): Set interface parameter.
1623 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
1625 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
1627 2001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1629 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
1630 (iph.ip_hl << 2) to iph.ip_len.
1632 2001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1634 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
1635 Suggested by: David Watson <dwatson@eecs.umich.edu>.
1637 * ospf_zebra.c (zebra_init): Remove zebra node.
1639 * ospfd.c (ospf_area_range_set): Function name is changed from
1641 (ospf_area_range_unset): New function which separated from DEFUN.
1642 New commands are added:
1643 "no area A.B.C.D range A.B.C.D/M advertise"
1644 "no area <0-4294967295> range A.B.C.D/M advertise"
1645 "no area A.B.C.D range A.B.C.D/M not-advertise"
1646 "no area <0-4294967295> range A.B.C.D/M not-advertise"
1648 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
1650 2001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
1652 * ospf_network.c (ospf_if_add_allspfrouters): Use
1653 setsockopt_multicast_ipv4.
1654 (ospf_if_drop_allspfrouters): Likewise.
1656 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
1657 (ospf_network_lsa_install): Likewise.
1658 (ospf_summary_lsa_install): Likewise.
1659 (ospf_summary_asbr_lsa_install): Likewise.
1660 (ospf_external_lsa_install): Likewise.
1661 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
1664 2001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1666 * ospf_zebra.c (ospf_interface_delete): Do not free interface
1667 structure when ospfd receive interface delete message to support
1670 2001-02-01 Dick Glasspool <dick@ipinfusion.com>
1672 * ospfd.c (area_range_notadvertise): Change area range "suppress"
1673 command to "not-advertise".
1675 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
1678 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
1679 updating the area-range, the lowest cost is now saved.
1681 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
1682 numbers rather than creating overflow during calculation.
1684 2001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1686 * zebra-0.91 is released.
1688 2001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
1690 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
1691 NSM_SeqNumberMismatch is scheduled.
1692 (ospf_ls_req): Free ls_upd when return from this function.
1693 (ospf_ls_upd_timer): When update list is empty do not call
1694 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
1697 2001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1699 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
1700 MaxAge. RFC2328 Section 14.
1701 (ospf_maxage_lsa_remover): Call above function during removing
1704 2001-01-26 Dick Glasspool <dick@ipinfusion.com>
1706 * ospf_flood.c (ospf_flood_through_as): Function is updated for
1707 NSSA Translations now done at ospf_abr.c with no change in P-bit.
1709 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
1711 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
1713 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
1715 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
1717 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
1719 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
1722 * ospfd.c (data_injection): Function to inject LSA. This is
1725 2001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1727 * ospf_route.c (ospf_route_match_same): Remove function.
1728 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
1730 * ospf_zebra.c (ospf_interface_address_delete): Add check for
1731 oi->address. Suggested by Matthew Grant
1732 <grantma@anathoth.gen.nz>.
1733 (ospf_zebra_add): Remove function.
1734 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
1736 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
1738 * ospf_zebra.c: Likewise.
1740 2001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1742 * ospf_ase.c: Remove OLD_RIB part.
1744 * ospf_route.c: Likewise.
1746 * zebra-0.90 is released.
1748 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
1751 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1753 * ospf_route.c (ospf_route_delete): Use
1754 ospf_zebra_delete_multipath.
1756 2001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
1758 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
1759 from ospf_if_free(). Rewrite whole procudure to support primary
1762 * ospf_zebra.c (ospf_interface_address_delete): Add primary
1763 address deletion process.
1765 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1767 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
1768 treatment like FreeBSD.
1770 2001-01-09 endo@suri.co.jp (Masahiko Endo)
1772 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
1773 strips IP header size from receiving IP Packet. So we adjust
1774 ip_len to whole IP packet size by adding IP header size.
1776 2001-01-08 endo@suri.co.jp (Masahiko Endo)
1778 * ospf_network.c (ospf_serv_sock): When socket() is failed return
1780 (ospf_serv_sock): Close socket when it is not used.
1782 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
1784 (ospf_write): When bind is fined, close sock.
1786 2001-01-07 Gleb Natapov <gleb@nbase.co.il>
1788 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
1789 appears when you try to configure bandwidth on the ppp interface
1790 that is not yet configured in ospfd.
1792 2001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1794 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
1795 will print nexthops for AS-external routes.
1797 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
1798 ASE route under multipath environment.
1799 (ospf_ase_compare_tables): Likewise.
1801 2001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1803 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
1805 2000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1807 * ospf_route.c (ospf_route_install): Install multipath information
1810 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
1811 multipath information to zebra daemon.
1813 2000-12-25 Dick Glasspool <dick@ipinfusion.com>
1815 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
1817 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
1820 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
1821 leave Type-7 LSA at Lock Count = 2.
1823 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
1824 NSSA no P-bit off during Area flooding, but P-bit is turned off
1825 for mulitple NSSA AS flooding.
1827 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
1830 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
1831 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
1834 2000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1836 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
1837 found LSA and if the LSA is MAXAGE we should call refresh instead
1840 2000-12-18 Dick Glasspool <dick@ipinfusion.com>
1842 * ospf_abr.c: Removed redundant "...flood" in
1843 announce_network_to_area(). Repaired nssa Unlock by using
1846 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
1848 * ospfd.c: Free up all data bases including NSSA.
1850 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
1851 discard_callback. Added routine to get ip addr from within the
1854 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
1856 * ospf_lsa.h: Added prototype for the below. struct in_addr
1857 ospf_get_ip_from_ifp (struct interface *ifp).
1859 2000-12-14 Gleb Natapov <gleb@nbase.co.il>
1861 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
1862 Now maximum packet length may be 65535 bytes (maximum IP packet
1865 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
1867 * ospfd.c (config_write_network_area): Remove unnecessary area
1870 2000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
1872 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
1874 2000-12-13 Gleb Natapov <gleb@nbase.co.il>
1876 * ospfd.c (config_write_network_area): Fix bug in
1877 config_write_network_area function.
1879 2000-12-12 Gleb Natapov <gleb@nbase.co.il>
1881 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
1882 LSA's origination and refreshment as same as other type of LSA.
1884 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
1886 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
1888 2000-12-08 Dick Glasspool <dick@ipinfusion.com>
1890 The bulk of NSSA changes are contained herein; This version will
1891 require manual setting of "always" for NSSA Translator, and will
1892 not perform aggregation yet.
1894 * ospf_dump.c: "debug ospf nssa" is added.
1896 * ospf_dump.h: Likewise.
1898 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
1900 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
1901 'never, candidate, always'. Change "suppress" to "not-advertise".
1903 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
1906 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
1909 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
1912 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
1913 NSSA translator, then do it. Approve the global list, and flush
1916 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
1917 Type-5 resulted from a Local Type-7 translation; not used for
1918 flooding, but used for flushing.
1920 * ospf_flood.c: New NSSA flooding.
1922 2000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1924 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
1926 (ospf_vl_set_security): Virtual link configuration with
1928 (ospf_vl_set_timers): Set timers for virtual link.
1930 * New commands are added.
1931 "area A.B.C.D virtual-link A.B.C.D"
1932 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
1933 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
1934 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
1935 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
1936 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
1938 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
1939 cryptographic sequence number treatment.
1940 (ospf_check_auth): OSPF input buffer is added to argument.
1941 (ospf_read): Save neighbor's cryptographic sequence number.
1943 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
1944 number when neighbor status is changed to NSM down.
1946 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
1948 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
1949 sequence number to neighbor structure.
1951 2000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1953 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
1954 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
1956 2000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1958 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
1960 (ospf_ls_upd_queue_empty): New function to empty ls update queue
1961 of the OSPF interface.
1962 (no_router_ospf): 'no router ospf' unregister redistribution
1963 requests from zebra.
1965 2000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1967 * ospf_ism.c (ism_change_status): Increment status change number.
1969 * ospf_interface.h (struct ospf_interface): Add new member for
1970 status change statistics.
1972 * Makefile.am: Update dependencies.
1974 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
1975 (ospf_interface_delete): OSPF SNMP interface delete.
1977 * ospf_snmp.h: New file is added.
1979 2000-11-23 Dick Glasspool <dick@ipinfusion.com>
1981 * ospfd.h: Add new ospf_area structure member for
1982 NSSATranslatorRole and NSSATranslator state.
1984 * ospfd.c: Provided for eventual commands to specify NSSA
1985 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
1986 decimal integer version of area-suppress.
1988 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
1990 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
1991 translator, advertise Nt bit.
1993 * ospf_route.c: 1st version of "sh ip os border-routers".
1995 2000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1997 * ospfd.c (area_vlink): Virtual link can not configured in stub
2000 2000-11-23 Gleb Natapov <gleb@nbase.co.il>
2002 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2003 slave must resend its last Database Description packet in response
2004 to duplicate Database Description packets received from the
2005 master. For this reason the slave must wait RouterDeadInterval
2006 seconds before freeing the last Database Description packet.
2007 Reception of a Database Description packet from the master after
2008 this interval will generate a SeqNumberMismatch neighbor
2009 event. RFC2328 Section 10.8
2010 (ospf_make_db_desc): DD Master flag treatment.
2012 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2013 nsm_change_status().
2014 (nsm_bad_ls_req): Likewise.
2015 (nsm_adj_ok): Likewise.
2016 (nsm_seq_number_mismatch): Likewise.
2017 (nsm_oneway_received): Likewise.
2019 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2020 last_send_ts for timestemp when last Database Description packet
2023 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2024 there. Call ospf_db_desc_resend() in any case.
2026 2000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2028 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2029 network (suppose you have only one router with interface priority
2030 0). It's router LSA does not contain the link information about
2033 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2034 interface from/to 0 ISM_NeighborChange event should be scheduled
2035 in order to elect new DR/BDR on the network.
2037 * ospf_interface.c (ip_ospf_priority): Likewise.
2039 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2040 retransmit list we need to check whether the present old LSA in
2041 retransmit list is not more recent than the new
2044 2000-11-09 Dick Glasspool <dick@ipinfusion.com>
2046 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2047 area. Any that exit the NSSA area are translated to type-5 LSA's.
2048 The instantiated image is restored after translation.
2049 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2050 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2052 (ospf_ls_ack_send): Likewise.
2054 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2055 local area. Otherwise they are allowed out the area to be
2056 translated by ospf_packet.c.
2058 * ospf_lsa.c: Undo some previous changes for NSSA.
2060 * ospf_lsdb.h: New access for type 7.
2062 2000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2064 * ospf_route.c (ospf_path_exist): New function to check nexthop
2065 and interface are in current OSPF path or not.
2066 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2067 when it is not there. Reported by Michael Rozhavsky
2068 <mrozhavsky@opticalaccess.com>
2070 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2072 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2073 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2076 2000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2078 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2080 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2082 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2085 2000-11-06 Dick Glasspool <dick@ipinfusion.com>
2087 * ospfd.h: Add ait_ntoa function prototype.
2089 * ospfd.c (ait_ntoa): New function for displaying area ID and
2091 (show_ip_ospf_interface_sub): Use ait_ntoa.
2092 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2093 (show_ip_ospf_neighbor_detail_sub): Likewise.
2095 * ospf_route.c (ospf_intra_route_add): Set external routing type
2097 (ospf_intra_add_router): Likewise.
2098 (ospf_intra_add_transit): Likewise.
2099 (ospf_intra_add_stub): Likewise.
2100 (ospf_add_discard_route): Likewise.
2101 (show_ip_ospf_route_network): Use ait_ntoa.
2102 (show_ip_ospf_route_network): Likewise.
2103 (show_ip_ospf_route_router): Likewise.
2105 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2106 (show_lsa_detail_adv_router): Likewise.
2107 (show_ip_ospf_database_summary): Likewise.
2109 * ospf_route.h (struct route_standard): Add new member
2112 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2114 (ospf_update_network_route): Likewise.
2115 (ospf_update_router_route): Likewise.
2117 2000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2119 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2120 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2122 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2124 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2125 Please specify "debug ospf event" for enable logging.
2127 * ospf_ism.c: Do not extern debug flag varible. It is done by
2129 * ospf_asbr.c: Likewise.
2130 * ospf_lsa.c: Likewise.
2131 * ospf_nsm.c: Likewise.
2132 * ospf_zebra.c: Likewise.
2134 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2137 * ospfd.c (router_ospf): Change logging from vty_out() to
2139 (ospf_area_stub_cmd): Likewise.
2141 * ospf_dump.h: Extern term_debug flags.
2142 (OSPF_DEBUG_EVENT): Add new flag.
2143 (IS_DEBUG_OSPF_EVENT): Add new macro.
2145 2000-11-03 Dick Glasspool <dick@ipinfusion.com>
2147 * ospf_flood.c (ospf_process_self_originated_lsa):
2148 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2149 (ospf_flood): Type-5's have no change. Type-7's can be received,
2150 and will Flood the AS as Type-5's They will also flood the local
2151 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2152 during re-fresh will be converted back to Type-7's (if within an
2154 (ospf_flood_through): Incoming Type-7's were allowed here if our
2155 neighbor was an NSSA. So Flood our area with the Type-7 and also
2156 if we are an ABR, flood thru AS as Type-5.
2158 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2159 area and other area.
2161 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2162 exists in DD packet, make it sure that this area is not stub.
2163 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2165 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2166 then discard the lsa. If the LSA is NSSA LSA and the area is not
2167 NSSA then discard the lsa.
2169 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2171 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2172 is not properly set when interface comes up.
2174 2000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2176 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2178 2000-11-01 Dick Glasspool <dick@ipinfusion.com>
2180 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2181 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2183 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2186 2000-10-31 Dick Glasspool <dick@ipinfusion.com>
2188 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2190 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2191 function is added. ALIASES which have "show ip ospf database
2192 nssa-external" is added.
2193 (show_ip_ospf_border_routers): New command "show ip ospf
2194 border-routers" is added.
2196 2000-10-30 Dick Glasspool <dick@ipinfusion.com>
2198 * ospfd.c (router_ospf): NSSA Enabled message is added for
2200 (ospf_area_type_set): Are type set for NSSA area.
2201 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2202 and summary information. If NSSA is enabled pass the information
2203 to ospf_area_type_set().
2204 (area_nssa): New commands are added:
2206 "area <0-4294967295> nssa"
2207 "area A.B.C.D nssa no-summary"
2208 "area <0-4294967295> nssa no-summary"
2209 (ospf_no_area_stub_cmd): Special translation of no_summary into
2210 NSSA and summary information. If external_routing is
2211 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2213 (show_ip_ospf_area): Display NSSA status.
2214 (config_write_ospf_area): Show NSSA configuration.
2216 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2219 2000-10-26 Gleb Natapov <gleb@nbase.co.il>
2221 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2222 those routers that are fully adjacent to the Designated Router;
2223 each fully adjacent router is identified by its OSPF Router ID.
2224 The Designated Router includes itself in this list. RFC2328,
2227 2000-10-23 Jochen Friedrich <jochen@scram.de>
2229 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2230 it is registered. So those variables must be static.
2232 2000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2234 * ospfd.c: Add area_default_cost_decimal_cmd and
2235 no_area_default_cost_decimal_cmd alias.
2237 2000-10-05 Gleb Natapov <gleb@nbase.co.il>
2239 * ospfd.c (ospf_network_new): Fix setting area format.
2240 (no_router_ospf): Check area existance when calling
2241 ospf_interface_down().
2243 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2246 2000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2248 * zebra-0.89 is released.
2250 2000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2252 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2254 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2257 2000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2259 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2261 2000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2263 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2266 2000-09-25 Toshiaki Takada <takada@zebra.org>
2268 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2269 Add CISCO compatible command.
2271 2000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2273 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2274 area range lookup in OSPF-MIB.
2275 (ospf_area_range_lookup_next): Likewise.
2277 2000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2279 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2282 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2283 EXTERNAL_INFO(type).
2285 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2286 ospf_vl_data_free().
2288 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2289 when ospf_vl_shutdown is called.
2290 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2293 2000-09-21 Gleb Natapov <gleb@nbase.co.il>
2295 * ospf_lsa.c: New implementation of OSPF refresh.
2297 2000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2299 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2301 2000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2303 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2305 2000-09-18 Gleb Natapov <gleb@nbase.co.il>
2307 * ospf_route.h (route_standard): Change member from `struct area'
2310 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2311 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2312 (ospf_abr_process_router_rt):
2313 * ospf_ase.c (ospf_find_asbr_route),
2314 (ospf_find_asbr_router_through_area),
2315 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2316 (process_summary_lsa), (ospf_update_network_route),
2317 (ospf_update_router_route):
2318 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2319 (ospf_intra_add_transit), (ospf_intra_add_stub),
2320 (ospf_route_table_dump), (show_ip_ospf_route_network),
2321 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2322 (ospf_prune_unreachable_routers):
2323 * ospf_spf.c (ospf_rtrs_print):
2324 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2326 2000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2328 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2331 2000-09-13 Gleb Natapov <gleb@nbase.co.il>
2333 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2335 * ospf_network.c (ospf_serv_sock_init): Add socket option
2336 SO_BINDTODEVICE on read socket.
2338 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2341 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2342 (ospf_area_add_if): New function added.
2344 2000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2346 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2349 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2350 starting SPF calculation.
2352 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2354 2000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2356 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2359 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2360 lsa_originate_count.
2361 (ospf_network_lsa_originate): Likewise.
2362 (ospf_summary_lsa_originate): Likewise.
2363 (ospf_summary_asbr_lsa_originate): Likewise.
2364 (ospf_external_lsa_originate): Likewise.
2366 2000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2368 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2369 syntax is IpAddress.
2370 (ospf_admin_stat): New function for OSPF administrative status
2373 2000-09-10 Jochen Friedrich <jochen@scram.de>
2375 * ospf_snmp.c: Implement OSPF MIB skeleton.
2377 2000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2379 * ospf_snmp.c: New file is added.
2381 2000-09-07 David Lipovkov <davidl@nbase.co.il>
2383 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2386 * ospf_interface.c (interface_config_write): Likewise.
2388 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2390 * zebra-0.88 is released.
2392 2000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2394 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2395 when Area is removed.
2397 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2399 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2400 (ZEBRA_ROUTE_CONNECT).
2401 (no_network_area): Likewise.
2403 2000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2405 * ospfd.h (struct ospf): Add distance_table and
2406 distance_{all,intra,inter,external}.
2408 * ospf_zebra.c: Add OSPF distance related functions.
2410 2000-08-15 Gleb Natapov <gleb@nbase.co.il>
2412 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2414 * ospf_lsa.c (ospf_default_external_info),
2415 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2419 (ospf_default_information_originate_metric_type_routemap),
2420 (ospf_default_information_originate_always_metric_type_routemap):
2421 Change name and add route-map function.
2422 (ospf_default_information_originate_metric_routemap),
2423 (ospf_default_information_originate_routemap),
2424 (ospf_default_information_originate_type_metric_routemap):
2427 2000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2429 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2430 restore size from two octet to four.
2432 2000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2434 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2435 AS-external-LSA in 16.6 of RFC2328.
2437 2000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2439 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2440 calculation algorithm.
2442 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2444 2000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2446 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2449 2000-08-10 Toshiaki Takada <takada@zebra.org>
2451 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2452 `auto-cost reference-bandwidth' OSPF router command added.
2454 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2456 * ospf_routemap.c (ospf_route_map_update): New function added.
2457 Add route-map event hook.
2459 2000-08-08 Toshiaki Takada <takada@zebra.org>
2461 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2462 prefix is connected route on OSPF enabled interface, suppress to
2465 2000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2467 * ospf_interface.c (ospf_if_get_output_cost):
2468 New function added. Handle bandwidth parameter for cost
2471 2000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2473 * ospf_interface.c (interface_config_write): Show interface
2474 configuration regardless interface is down.
2476 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2477 route calculate function.
2479 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2481 * ospf_routemap.c: New file added.
2483 * ospf_asbr.c (ospf_reset_route_map_set_values),
2484 (ospf_route_map_set_compare): New function added.
2486 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2487 with AS-external-LSA.
2489 2000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2491 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2492 ospf_zebra_add as metric.
2493 (ospf_ase_calculate_route_add): Likewise.
2495 * ospf_route.c (ospf_route_install): Pass or->cost to
2496 ospf_zebra_add as metric.
2498 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2499 (ospf_zebra_delete): Likewise.
2501 2000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2503 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2504 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2507 2000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2509 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2512 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2513 Point-to-Point interface.
2515 2000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2517 * ospf_flood.c (ospf_process_self_originated_lsa):
2518 Make sure to clear LSA->param (redistributed external information)
2521 2000-07-27 Gleb Natapov <gleb@nbase.co.il>
2523 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2524 (refresh_age_diff): New defun added. Refresher related parameter
2525 can be configurable.
2527 2000-07-27 Akihiro Mizutani <mizutani@dml.com>
2529 * ospf_interface.c (interface_config_write): Print `description'
2530 config directive to work.
2532 2000-07-24 Akihiro Mizutani <mizutani@dml.com>
2534 * ospf_interface.c (ospf_if_init): Use install_default for
2537 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
2539 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2540 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2541 This make sending always as many LS update/Ack combined in one ospf
2544 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
2546 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2547 LSA is AS-external-LSA.
2549 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2551 2000-07-21 Toshiaki Takada <takada@zebra.org>
2553 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2554 `default-information originate'. Fix some default originate
2557 2000-07-12 Toshiaki Takada <takada@zebra.org>
2559 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2561 2000-07-12 Toshiaki Takada <takada@zebra.org>
2563 * ospf_lsa.c (show_ip_ospf_database_router),
2564 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2565 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2566 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2567 (show_any_lsa_self): Functions removed.
2569 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2570 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2571 New functions added. Replace above functions.
2573 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2575 (show_ip_ospf_database_summary): New functions added. Replace
2578 (show_ip_ospf_database_cmd): DEFUN rearranged.
2579 (show_ip_ospf_database_type_id_cmd),
2580 (show_ip_ospf_database_type_id_adv_router_cmd),
2581 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2582 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2583 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2585 2000-07-11 Toshiaki Takada <takada@zebra.org>
2587 * ospf_asbr.c (ospf_external_info_new),
2588 (ospf_external_info_free): New functions added.
2590 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2591 origination parameter for external-LSA.
2592 Remove member `redistribute'.
2594 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2595 command executed, metric and metric-type values are overridden.
2596 If one of those is changed refresh AS-external-LSAs for appropriate
2599 2000-07-11 Michael Rozhavsky <mike@nbase.co.il>
2601 * ospf_lsa.c (ospf_summary_lsa_refresh),
2602 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
2604 * ospf_abr.c (set_metric): New function added.
2606 2000-07-07 Toshiaki Takada <takada@zebra.org>
2608 * ospf_zebra.c (ospf_default_information_originate_metric_type),
2609 (ospf_default_information_originate_type_metric): New defun added.
2610 Metic and Metric type can be set to default route.
2611 (ospf_default_information_originate_always_metric_type):
2612 (ospf_default_information_originate_always_type_metric):
2613 New defun added. Metric and Metric type can be set to default
2616 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
2619 2000-07-06 Gleb Natapov <gleb@nbase.co.il>
2621 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
2622 on the same interface the LSA was received from.
2624 2000-07-06 Michael Rozhavsky <mike@nbase.co.il>
2626 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
2627 command with `write mem'.
2629 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
2631 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
2632 zebra interface delete event.
2634 2000-07-06 Toshiaki Takada <takada@zebra.org>
2636 * ospf_zebra.c (ospf_default_information_originate),
2637 (ospf_default_information_originate_always): New DEFUN added.
2639 2000-07-05 Michael Rozhavsky <mike@nbase.co.il>
2641 * ospf_route.c (ospf_terminate): Make sure to remove external route
2642 when SIGINT received.
2644 2000-07-03 Gleb Natapov <gleb@nbase.co.il>
2646 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
2647 many structure with `no router ospf'.
2649 2000-06-30 Gleb Natapov <gleb@nbase.co.il>
2651 * ospf_neighbor.c (ospf_nbr_new),
2652 ospf_nsm.c (nsm_timer_set): Start LS update timer only
2653 when neighbor enters Exchange state.
2655 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
2657 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
2658 ospf_packet.c (ospf_db_desc_proc):
2659 Do not cancel DD retransmit timer when Master.
2661 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
2663 * ospf_abr.c (ospf_abr_announce_network_to_area),
2664 (ospf_abr_announce_rtr_to_area)
2665 ospf_ase.c (ospf_ase_rtrs_register_lsa),
2666 ospf_flood.c (ospf_process_self_originated_lsa),
2667 (ospf_flood_through_area), (ospf_ls_request_delete),
2668 ospf_interface.c (ospf_if_free),
2669 ospf_ism.c (ism_change_status),
2670 ospf_lsa.c (ospf_router_lsa_update_timer),
2671 (ospf_router_lsa_install), (ospf_network_lsa_install),
2672 (ospf_lsa_maxage_delete), (ospf_lsa_action),
2673 (ospf_schedule_lsa_flood_area),
2674 ospf_nsm.c (nsm_change_status),
2675 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
2676 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
2678 * ospf_flood.c (ospf_ls_request_free): Function deleted.
2680 * ospf_lsa.c (ospf_discard_from_db): New function added.
2682 2000-06-26 Toshiaki Takada <takada@zebra.org>
2684 * ospfd.h (ospf): struct member `external_lsa' name changed to
2687 2000-06-26 Toshiaki Takada <takada@zebra.org>
2689 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
2690 (ospf_network_lsa_install), (ospf_summary_lsa_install),
2691 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
2692 Functions re-arranged.
2694 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
2696 2000-06-20 Michael Rozhavsky <mike@nbase.co.il>
2698 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
2699 verification of LS type.
2701 2000-06-20 Gleb Natapov <gleb@nbase.co.il>
2703 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
2704 whether rn->info is NULL.
2706 2000-06-20 Toshiaki Takada <takada@zebra.org>
2708 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
2709 DR and Backup correctly with `show ip ospf interface' command.
2711 2000-06-20 Toshiaki Takada <takada@zebra.org>
2713 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
2714 (ospf_lsa_discard): These functions are used for avoiding
2715 unexpected reference to freed LSAs.
2717 2000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2719 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
2722 2000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2724 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
2726 2000-06-12 Toshiaki Takada <takada@zebra.org>
2728 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
2729 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
2732 2000-06-10 Toshiaki Takada <takada@zebra.org>
2734 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
2735 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
2736 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
2737 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
2738 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
2739 removed for migration to new_lsdb.
2741 * ospf_lsa.c (ospf_summary_lsa_install),
2742 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
2743 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
2744 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
2745 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
2746 (ospf_get_free_id_for_prefix): Funcitions removed.
2748 2000-06-09 Gleb Natapov <gleb@nbase.co.il>
2750 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
2752 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
2753 (ospf_hello): Always copy router-ID when hello is received.
2755 2000-06-08 Gleb Natapov <gleb@nbase.co.il>
2757 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
2760 2000-06-08 Michael Rozhavsky <mike@nbase.co.il>
2762 * ospf_ase.c (ospf_asbr_route_same): New function added.
2763 This function makes sure external route calculation more
2766 2000-06-07 Michael Rozhavsky <mike@nbase.co.il>
2768 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
2769 network-LSA deletion instead of using ospf_lsdb_delete.
2770 Also cancel network-LSA origination timer.
2772 2000-06-07 Levi Harper <lharper@kennedytech.com>
2774 * ospf_interface.c (ospf_if_down): Close read fd when an interface
2777 2000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2779 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
2780 avoid ambiguous else.
2782 * ospf_flood.c (ospf_external_info_check): Likewise.
2784 2000-06-05 Toshiaki Takada <takada@zebra.org>
2786 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
2788 2000-06-04 Toshiaki Takada <takada@zebra.org>
2790 * ospf_zebra.c (ospf_default_information_originate),
2791 (no_ospf_default_information_originate): New DEFUN added.
2793 2000-06-03 Toshiaki Takada <takada@zebra.org>
2795 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
2796 ospf_lsa.h to ospf_asbr.h.
2798 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
2799 (ospf_external_info_delete): Function moved from ospf_lsa.c
2802 2000-06-03 Toshiaki Takada <takada@zebra.org>
2804 * ospf_flood.c (ospf_external_info_check): New function added.
2805 (ospf_process_self_orignated_lsa): Make sure to flush
2806 self-originated AS-external-LSA, when router reboot and no longer
2807 originate those AS-external-LSA.
2809 2000-06-02 Toshiaki Takada <takada@zebra.org>
2811 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
2814 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
2815 unicast destination packets.
2817 2000-06-02 Toshiaki Takada <takada@zebra.org>
2819 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
2820 specified LSA matches.
2822 2000-06-02 Gleb Natapov <gleb@nbase.co.il>
2824 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
2827 2000-06-01 Akihiro Mizutani <mizutani@dml.com>
2829 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
2830 Replace string `OSPF information\n' with OSPF_STR.
2832 2000-06-01 Toshiaki Takada <takada@zebra.org>
2834 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
2837 2000-06-01 Toshiaki Takada <takada@zebra.org>
2839 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
2840 (config_debug_ospf_ism), (config_debug_ospf_nsm),
2841 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
2842 (term_debug_ospf_packet), (term_debug_ospf_event),
2843 (term_debug_ospf_ism), (term_debug_ospf_nsm),
2844 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
2845 variable to use for debug option flags.
2847 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
2848 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
2849 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
2852 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
2853 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
2854 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
2855 (IS_CONF_DEBUG_OSPF): New Macro added.
2857 2000-05-31 Toshiaki Takada <takada@zebra.org>
2859 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
2860 Currently this command is used for only debugging.
2862 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
2863 for network-LSA when DR has no full neighbors.
2865 * ospf_nsm.c (ospf_db_summary_clear): New function added.
2867 2000-05-30 Toshiaki Takada <takada@zebra.org>
2869 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
2870 maxage_lsa_remover when LSA is replaced.
2872 2000-05-25 Gleb Natapov <gleb@nbase.co.il>
2874 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
2875 `struct ospf_area' to remove LSA from Link State retransmission list
2876 of neighbor from only one Area.
2878 2000-05-24 Michael Rozhavsky <mike@nbase.co.il>
2880 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
2881 overriting old LSA with new LSA.
2883 2000-05-24 Gleb Natapov <gleb@nbase.co.il>
2885 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
2888 2000-05-22 Michael Rozhavsky <mike@nbase.co.il>
2890 * ospf_route.c (ospf_intra_add_stub):
2891 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
2892 value instead of u_int16_t.
2894 2000-05-22 Axel Gerlach <agerlach@datus.datus.com>
2896 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
2897 equal cost path calculation.
2899 2000-05-21 Toshiaki Takada <takada@zebra.org>
2901 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
2902 Make sure, when rotuer route is deleted, related external routes
2905 2000-05-20 Toshiaki Takada <takada@zebra.org>
2907 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
2910 2000-05-16 Toshiaki Takada <takada@zebra.org>
2912 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
2915 * ospfd.h (EXTERNAL_INFO): Macro added.
2916 Substitute `ospf_top->external_info[type]' with it.
2918 2000-05-16 Toshiaki Takada <takada@zebra.org>
2920 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
2922 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
2924 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
2925 * ospf_lsdb.c (new_lsdb_insert)
2926 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
2928 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
2930 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
2931 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
2933 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
2935 2000-05-13 Toshiaki Takada <takada@zebra.org>
2937 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
2938 time_t to struct timeval.
2939 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
2940 (tv_sub), (tv_cmp): timeval utillity functions added.
2942 2000-05-12 Toshiaki Takada <takada@zebra.org>
2944 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
2945 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
2947 router-LSA refresh timer related stuff is re-organized.
2949 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
2951 * ospf_interface.c (ospf_vl_set_params):
2952 * ospf_packet.c (ospf_check_network_mask):
2953 * ospf_spf.[ch] (ospf_spf_next):
2954 Remove field address from `struct vertex', and search for peer
2955 address of virtual link in function `ospf_vl_set_params' instead.
2957 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
2959 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
2961 2000-05-08 Thomas Molkenbur <tmo@datus.com>
2963 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
2964 with ospf_stream_dup() to fix memory leak.
2966 2000-05-08 Michael Rozhavsky <mike@nbase.co.il>
2968 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
2969 LSA update without DROther.
2971 2000-05-04 Gleb Natapov <gleb@nbase.co.il>
2973 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
2975 2000-05-03 Toshiaki Takada <takada@zebra.org>
2977 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
2978 instead linked-list.
2979 (ospf_db_summary_count), (ospf_db_summary_isempty):
2982 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
2984 2000-05-02 Gleb Natapov <gleb@nbase.co.il>
2986 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
2987 not needed any more, then free them.
2989 2000-05-02 Toshiaki Takada <takada@zebra.org>
2991 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
2992 SPF calculation timers related stuff is rearranged.
2994 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
2995 SPF timer is scheduled by SPF calculation delay and holdtime
2996 configuration variable.
2998 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
2999 forwarding address when nexthop learned by other protocols is
3002 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3003 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3006 2000-05-01 Toshiaki Takada <takada@zebra.org>
3008 * ospf_flood.c (ospf_ls_retransmit_count),
3009 (ospf_ls_retransmit_isempty): New function added.
3011 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3012 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3013 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3014 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3017 2000-04-29 Toshiaki Takada <takada@zebra.org>
3019 * ospfd.c (no_network_area): Add check Area-ID whether specified
3020 Area-ID with prefix matches config.
3022 2000-04-27 Toshiaki Takada <takada@zebra.org>
3024 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3025 remaining withdrawn routes on zebra.
3027 2000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3029 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3030 (ospf_nsm_event): Fix network-LSA re-origination problem.
3032 2000-04-24 Toshiaki Takada <takada@zebra.org>
3034 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3035 with DD retransmission.
3037 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3038 a neighbor disappears.
3040 2000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3042 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3043 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3044 flag to new LSA. when summary-LSA is reoriginatd.
3046 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3047 procedure. Change the condition of interface selection.
3049 2000-04-21 Toshiaki Takada <takada@zebra.org>
3051 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3054 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3055 `show ip ospf neighbor' related commands are re-arranged.
3057 2000-04-20 Toshiaki Takada <takada@zebra.org>
3059 * ospf_dump.c (debug_ospf_zebra): New defun added.
3060 Suppress zebra related debug information.
3062 2000-04-19 Toshiaki Takada <takada@zebra.org>
3064 * ospf_zebra.c (ospf_distribute_list_update_timer),
3065 (ospf_distribute_list_update), (ospf_filter_update):
3066 New function added. Re-organize `distribute-list' router ospf
3069 2000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3071 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3073 2000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3075 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3076 interface transmit_delay.
3078 2000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3080 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3081 Add to schedule router_lsa origination when the interface cost changes.
3083 2000-04-12 Toshiaki Takada <takada@zebra.org>
3085 * ospf_lsa.c (ospf_refresher_register_lsa),
3086 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3088 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3090 2000-03-29 Toshiaki Takada <takada@zebra.org>
3092 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3094 2000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3096 * ospf_lsa.c (ospf_network_lsa):
3097 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3100 2000-03-28 Toshiaki Takada <takada@zebra.org>
3102 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3103 (nsm_oneway_received): Fix bug of NSM state flapping between
3104 ExStart and Exchange.
3106 2000-03-28 Toshiaki Takada <takada@zebra.org>
3108 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3109 change u_int8_t to u_char.
3111 2000-03-27 Toshiaki Takada <takada@zebra.org>
3113 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3115 2000-03-27 Toshiaki Takada <takada@zebra.org>
3117 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3119 2000-03-26 Love <lha@s3.kth.se>
3121 * ospf_packet.c (ospf_write): Chack result of sendto().
3123 2000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3125 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3127 2000-03-23 Libor Pechacek <farco@clnet.cz>
3129 * ospf_lsa.c (ospf_network_lsa)
3130 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3133 2000-03-23 Toshiaki Takada <takada@zebra.org>
3135 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3136 `area A.B.C.D authentication'.
3138 2000-03-22 Toshiaki Takada <takada@zebra.org>
3140 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3141 Suppress all zlog related to LSAs with this config option.
3143 2000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3145 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3147 2000-03-21 Toshiaki Takada <takada@zebra.org>
3149 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3150 Fix bug of memory leak about linklist.
3152 * ospf_flood.c (ospf_flood_through_area): Likewise.
3154 2000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3156 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3157 to identify LSA uniquely. This fix routes lost.
3159 2000-03-18 Toshiaki Takada <takada@zebra.org>
3161 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3164 2000-03-17 Alex Zinin <zinin@amt.ru>
3166 * ospf_spf.[ch]: Bug fix.
3167 The 2nd stage of Dijkstra could consider one vertex
3168 more than once if there is more than one link
3169 between the routers, thus adding extra CPU overhead
3170 and extra next-hops.
3173 2000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3175 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3177 2000-03-14 Toshiaki Takada <takada@zebra.org>
3179 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3180 ospf_path. Actually ignore merging ospf_route with completely same
3183 2000-03-12 Toshiaki Takada <takada@zebra.org>
3185 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3186 external route tag byte order.
3188 2000-03-11 Toshiaki Takada <takada@zebra.org>
3190 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3192 2000-03-09 Toshiaki Takada <takada@zebra.org>
3194 * ospf_lsa.c (ospf_external_lsa_install),
3195 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3196 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3197 LSDB of AS-external-LSAs instead of ospf_lsdb.
3199 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3200 Use for assigning Unique Link State ID instead of
3201 ospf_get_free_id_for_prefix().
3203 2000-03-09 Toshiaki Takada <takada@zebra.org>
3205 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3206 fault reported by George Bonser <george@siteROCK.com>.
3208 2000-03-07 Libor Pechacek <farco@clnet.cz>
3210 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3212 2000-03-06 Toshiaki Takada <takada@zebra.org>
3214 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3216 2000-03-02 Alex Zinin <zinin@amt.ru>
3217 * ospfd.h, ospf_ia.h
3218 New Shortcut ABR code. Now area's flag can be configured
3219 with Default, Enable, and Disable values.
3220 More info will be in the new ver of I-D soon (see IETF web).
3222 2000-02-25 Toshiaki Takada <takada@zebra.org>
3224 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3225 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3226 (ospf_external_lsa_originate_from_queue): New function added.
3227 (ospf_external_lsa): Function removed.
3229 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3230 when listen a route from Zebra, instead creating external route.
3232 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3233 (ospf_asbr_route_add_queue_lsa),
3234 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3237 * ospf_ase.c (process_ase_lsa): Function will not be used.
3238 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3239 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3240 process_ase_lsa () is separated to these functions.
3242 OSPF AS-external-LSA origination is whole re-organized.
3244 2000-02-18 Toshiaki Takada <takada@zebra.org>
3246 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3248 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3249 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3252 2000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3254 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3255 checksum after change Advertised Router field.
3257 2000-02-09 Toshiaki Takada <takada@zebra.org>
3259 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3261 2000-02-08 Toshiaki Takada <takada@zebra.org>
3263 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3264 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3265 Router ID is chosen from all of eligible interface addresses even if
3266 it is not enable to OSPF.
3268 2000-02-08 Toshiaki Takada <takada@zebra.org>
3270 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3271 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3272 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3273 waited to install to LSDB.
3274 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3276 2000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3278 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3279 in the ACK before deleting.
3281 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3282 and no shutdown of the interface.
3284 2000-01-31 Toshiaki Takada <takada@zebra.org>
3286 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3287 packets respond to a Link State Request packet.
3289 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3291 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3292 is not configured and set virtual-link to no-backbone area,
3295 2000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3297 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3300 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3301 treatment. That should be done in OSPF flooding procedure.
3303 * ospf_flood.c (ospf_flood_through_area): Enclose
3304 ospf_check_nbr_loding inside if-else close.
3306 2000-01-31 Toshiaki Takada <takada@zebra.org>
3308 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3310 2000-01-29 Toshiaki Takada <takada@zebra.org>
3312 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3314 2000-01-28 Toshiaki Takada <takada@zebra.org>
3316 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3318 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3320 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3321 removing LSA from nbr->db_summary.
3323 2000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3325 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3326 destination when the link is point-to-point.
3327 (ospf_ls_ack_send_delayed): Likewise.
3329 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3331 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3332 pointer lookup after the node is freed.
3334 2000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3336 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3337 external route, use ospf_top->external_self.
3339 2000-01-27 Toshiaki Takada <takada@zebra.org>
3341 * ospf_lsa.c (ospf_forward_address_get): New function added.
3343 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3344 only when it should be replaced.
3346 2000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3348 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3350 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3353 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3354 change. Self originated LSA is freed but not deleted from lsdb.
3356 2000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3358 * ospf_ism.c (ism_interface_down): Don't use router_id for
3359 detecting self neighbor structure. Instead of that compare
3362 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3364 (ospf_nbr_free): Free last send packet.
3366 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3367 Instead of that src is introduced.
3369 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3371 2000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3373 * ospfd.c: Change part of passive interface implementation. For
3374 passive interface just disabling sending/receiving Hello on the
3377 2000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3379 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3380 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3381 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3382 * ospfd.c (passive_interface): New command passive-interface is
3384 (ospf_config_write): Print passive interface.
3386 2000-01-15 Toshiaki Takada <takada@zebra.org>
3388 * ospf_interface.h (crypt_key): New struct added to store
3389 multiple cryptographic autheitication keys.
3390 (ospf_interface): struct changed.
3392 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3393 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3395 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3396 multiple cryptographic authentication keys.
3398 2000-01-14 Toshiaki Takada <takada@zebra.org>
3400 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3402 Old notation `ospf *' still remains backward compatibility.
3404 1999-12-29 Alex Zinin <zinin@amt.ru>
3405 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3406 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3407 int goes down, also check DD flags correctly (bug fix)
3409 1999-12-28 Alex Zinin <zinin@amt.ru>
3410 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3412 1999-12-23 Alex Zinin <zinin@amt.ru>
3413 * added RFC1583Compatibility flag
3414 * added dynamic interface up/down functionality
3416 1999-11-19 Toshiaki Takada <takada@zebra.org>
3418 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3419 for NSM state change statistics.
3421 1999-11-19 Toshiaki Takada <takada@zebra.org>
3423 * ospfd.c (show_ip_ospf_neighbor_detail),
3424 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3426 1999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3428 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3431 1999-11-11 Toshiaki Takada <takada@zebra.org>
3433 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3434 This macro is expanded to ospf_examine_summaries ()
3435 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3436 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3437 This macro is expanded to ospf_examine_transit_summaries ()
3438 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3440 1999-11-11 Toshiaki Takada <takada@zebra.org>
3442 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3443 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3444 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3445 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3446 (ospf_find_self_external_lsa_by_prefix): Changed to
3447 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3449 1999-11-11 Toshiaki Takada <takada@zebra.org>
3451 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3452 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3454 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3455 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3458 1999-11-10 Toshiaki Takada <takada@zebra.org>
3460 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3461 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3463 1999-11-01 Alex Zinin <zinin@amt.ru>
3465 some correction to LSU processing
3467 * ospf_lsa.c ospfd.h
3468 randomize initial LSA refreshment interval
3469 and limit the size of LSA-group to 10
3470 to let randomization work more effectively.
3472 1999-10-31 Alex Zinin <zinin@amt.ru>
3474 cancel t_network_lsa_self
3475 when freeing int structure
3477 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3478 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3480 Summary and ASE LSA refreshment functions
3481 added---LSA refreshment is paced to 70 LSAs
3482 per sec to avoid link overflow. Refreshment events
3483 are further randomized within a 10 sec interval
3486 Also the sigfault of memcmp() in ospf_lsa_is_different()
3489 1999-10-30 Alex Zinin <zinin@amt.ru>
3491 Fix the bug where MAX_AGE LSAs
3492 are included into the DB summary.
3495 allocate 2*MTU input buffer instead of just MTU
3496 for the cases when the other router mistakenly
3497 sends larger packets thus causing fragmentation, etc.
3500 in nsm_reset_nbr() lists should be freed
3501 not when they are empty.
3503 1999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3505 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3506 check inside of if (ospf_top).
3508 1999-10-29 Alex Zinin <zinin@amt.ru>
3509 * ospf_lsa.c ospf_lsdb.c :
3510 add assertion in lsa and lsa->data alloc functions,
3511 as well as in lsdb_add for new->data
3513 * ospf_lsdb.c: free hash table correctly
3515 1999-10-28 John Capo <jc@irbs.com>
3517 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3520 1999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3522 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3524 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3526 1999-10-27 Alex Zinin <zinin@amt.ru>
3527 * ospfd, ospf_zebra, ospf_abr
3528 "area import-list" command is added.
3529 This command allows to filter the inter-area routes
3530 injected into an area. Access list hook function
3531 extended to invalidate area exp/imp lists.
3533 1999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3535 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3536 on an OSPF interface.
3538 1999-10-19 Jordan Mendelson <jordy@wserv.com>
3540 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3541 in ospf_ls_retransmit_lookup ().
3543 1999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3545 * ospf_route.c: Workaround about installation of OSPF routes into
3546 the zebra daemon. Add checking of existance routes. Free
3547 ospf_top->old_table if it exists.
3549 1999-10-15 Jordan Mendelson <jordy@wserv.com>
3551 * Add support for MD5 authentication.
3553 1999-10-12 Alex Zinin <zinin@amt.ru>
3554 * ospfd.c, ospfd.h, ospf_abr.c:
3555 a new command "area export-list" was added, it allows
3556 the admin. to control which intra-area routes are
3557 announced to other areas by the ABR
3559 1999-10-12 Alex Zinin <zinin@amt.ru>
3560 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3561 when "no redistribute" is used after a distribute list
3562 denying some networks was used
3564 1999-10-05 Toshiaki Takada <takada@zebra.org>
3566 * ospf_route.c (ospf_path_dup): New function added.
3568 1999-10-05 Toshiaki Takada <takada@zebra.org>
3570 * ospf_interface.[ch]: Some of VL related funciton name changed.
3572 1999-09-27 Alex Zinin <zinin@amt.ru>
3574 * ospf_zebra.c: Distribute-list functionality added
3576 1999-09-27 Toshiaki Takada <takada@zebra.org>
3578 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3581 1999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3583 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3584 instead of node->next. Reported by Hiroki Ishibashi
3585 <ishibasi@dcd.abk.nec.co.jp>.
3587 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3590 1999-09-23 Alex Zinin <zinin@amt.ru>
3592 * stub area support added
3594 1999-09-23 Alex Zinin <zinin@amt.ru>
3596 * fwd_addr in ASE-LSAs is now set correctly
3597 * ASE routing changed to check the fwd_addr
3598 and skip the route if the addr points to one
3599 of our interfaces to avoid loops.
3601 1999-09-22 Alex Zinin <zinin@amt.ru>
3604 ospf_vls_in_area() added, it returns
3605 the number of VLs configured through the area
3607 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
3608 honor correct mem alloc
3610 1999-09-22 Alex Zinin <zinin@amt.ru>
3613 Some OSPF mem types added,
3614 plus more info in "show mem"
3616 1999-09-21 Alex Zinin <zinin@amt.ru>
3619 "area range substitute" added.
3620 It can be used on NAT-enabled (IP-masquarade)
3621 routers to announce private networks
3622 from an area as public ones into the outside
3623 world (not in the RFC, btw :)
3625 1999-09-21 Alex Zinin <zinin@amt.ru>
3628 "area range suppress" added.
3629 This command allows to instruct the router
3630 to be silent about specific ranges, i.e.,
3631 it is a method of route filtering on area
3634 1999-09-21 Alex Zinin <zinin@amt.ru>
3636 * ospfd.c VLs removed when "no network area" executed
3638 1999-09-20 Alex Zinin <zinin@amt.ru>
3640 * ospf_ase.c bug fix for not-zero fwd_addr
3641 and directly connected routes.
3643 1999-09-20 Yon Uriarte <yon@plannet.de>
3645 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
3646 checking the length of OSPF packet exceeds MTU or not.
3648 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
3651 1999-09-18 Alex Zinin <zinin@amt.ru>
3653 * ospf_lsa.c bug fix for ospf_network_lsa() to
3654 include itself into the RID list
3656 1999-09-10 Alex Zinin <zinin@amt.ru>
3658 * Alternative ABR behaviors IBM/Cisco/Shortcut
3661 1999-09-10 Alex Zinin <zinin@amt.ru>
3663 * router and network-LSA origination
3664 changed to honor MinLSInterval
3666 1999-09-08 Alex Zinin <zinin@amt.ru>
3668 * modified ABR behavior to honor VLs and transit
3671 1999-09-07 Alex Zinin <zinin@amt.ru>
3673 * completed VL functionality
3675 1999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3677 * ospf_asbr.c: New file.
3678 ospf_asbr.h: New file.
3680 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
3683 1999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3685 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
3686 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
3688 1999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3690 * ospf_spf.c (ospf_spf_register): Change name from
3691 ospf_spf_route_add() to ospf_spf_register().
3692 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
3694 1999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3696 * ospf_lsa.c (ospf_external_lsa_install): Change to update
3697 lsa->data rather than install new one, when same id lsa is already
3700 1999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3702 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
3703 (ospf_network_lsa_install): Likewise.
3704 (ospf_summary_lsa_install): Likewise.
3705 (ospf_summary_asbr_lsa_install): Likewise.
3706 (ospf_external_lsa_install): Likewise.
3708 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
3711 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
3713 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
3716 1999-08-31 Toshiaki Takada <takada@zebra.org>
3718 * ospf_lsa.c (show_ip_ospf_database_summary),
3719 (show_ip_ospf_database_summary_asbr),
3720 (show_ip_ospf_database_external): New function added.
3721 `show ip ospf database summary',
3722 `show ip ospf database asbr-summary'
3723 `show ip ospf database external' command can be used.
3725 * ospf_lsa.c (ospf_lsa_count_table): New function added.
3726 (show_ip_ospf_database_all): show nothing if a type of LSA
3729 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
3731 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
3732 the node is deleted.
3734 1999-08-31 Toshiaki Takada <takada@zebra.org>
3736 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
3738 (ospf_ls_request_new), (ospf_ls_request_free),
3739 (ospf_ls_request_add), (ospf_ls_request_delete),
3740 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
3743 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
3745 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
3747 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
3750 1999-08-30 Alex Zinin <zinin@amt.ru>
3753 fix a bug with area range config write
3754 added "show ip ospf" command, it will be enhanced later on
3756 1999-08-30 Alex Zinin <zinin@amt.ru>
3759 updated ospf_router_lsa() to honor flags (B-bit)
3761 1999-08-30 Alex Zinin <zinin@amt.ru>
3764 wrote major functions implementing ABR activity
3766 1999-08-30 Alex Zinin <zinin@amt.ru>
3768 * ospf_ia.c ospf_route.c ospf_route.h
3769 fixed the bug with ospf_route.origin field.
3770 Now it holds pointer to lsa_header
3772 1999-08-30 Alex Zinin <zinin@amt.ru>
3774 * ospf_flood.c ospf_flood.h:
3775 transformed ospf_flood_if_select into ospf_flood_through_area()
3776 added new ospf_flood_if_select() and ospf_flood_through_as()
3778 1999-08-30 Toshiaki Takada <takada@zebra.org>
3780 * ospf_flood.[ch]: New file added.
3782 * ospf_packet.c (ospf_lsa_flooding),
3783 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
3785 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
3786 (ospf_remove_lsa_from_retransm_list),
3787 (ospf_nbr_remove_all_lsas_from_retransm_list),
3788 (ospf_lsa_remove_from_ls_retransmit):
3789 (ospf_lsa_retransmit): functions move to
3790 ospf_flood.c, and change function's name:
3792 ospf_put_lsa_on_retransm_list ()
3793 -> ospf_ls_retransmit_add ()
3794 ospf_remove_lsa_from_retransm_list ()
3795 -> ospf_ls_retransmit_delete ()
3796 ospf_nbr_remove_all_lsas_from_retransm_list ()
3797 -> ospf_ls_retransmit_clear ()
3798 ospf_lsa_remove_from_ls_retransmit ()
3799 -> ospf_ls_retransmit_delete_nbr_all ()
3800 ospf_lsa_retransmit ()
3801 -> ospf_ls_retransmit_add_nbr_all ()
3803 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
3804 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
3806 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3808 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
3809 route_node_lookup() instead of route_node_get().
3811 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
3813 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3815 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
3818 1999-08-29 Alex Zinin <zinin@amt.ru>
3820 MaxAge LSA deletion functions added.
3822 1999-08-29 Alex Zinin <zinin@amt.ru>
3824 ospf_nbr_lookup_by_addr(): added route_unlock_node()
3825 when function returns NULL if (rn->info == NULL)
3827 1999-08-29 Alex Zinin <zinin@amt.ru>
3829 added a hack for area range deletion
3831 1999-08-29 Alex Zinin <zinin@amt.ru>
3833 included lsdb field into struct ospf_lsa, to find
3834 LSDB easier when removing MaxAge LSAs.
3836 1999-08-29 Alex Zinin <zinin@amt.ru>
3837 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
3838 ospf_packet.c changed to honor new retransmit list
3839 management functions
3841 1999-08-29 Alex Zinin <zinin@amt.ru>
3842 * ospf_neighbor.c , .h added new retransmit list functions.
3844 1999-08-29 Alex Zinin <zinin@amt.ru>
3846 added ospf_ase, ospf_abr, ospf_ia
3848 1999-08-29 Alex Zinin <zinin@amt.ru>
3850 - changed ospf_next_hop_calculation() to include interface
3851 and nexthop addr for directly connected routers---more informative
3852 and solves problem with route installation into the kernel
3853 - changed ospf_nexthop_out_if_addr() to support routers, not only
3855 - added ospf_process_stubs();
3857 1999-08-29 Alex Zinin <zinin@amt.ru>
3859 - changed ospf_router_lsa() to provide correct links
3860 for p-t-p interfaces;
3861 - changed ospf_summary_lsa_install() to support table
3862 of self-originated summary-LSAs;
3863 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
3864 - changed ospf_lsa_install() accordingly
3865 - changed show_ip_ospf_database_router_links() to support p-t-p
3867 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3869 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
3872 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3874 * ospf_packet.c (ospf_read): Add check of IP src address.
3876 1999-08-28 Alex Zinin <zinin@amt.ru>
3878 added ospf_nbr_lookup_by_routerid()
3880 1999-08-28 Alex Zinin <zinin@amt.ru>
3882 added ABR/ASBR flag definitions and fields;
3883 added iflist field to area structure;
3884 summary_lsa_self and summary_lsa_asbr_self are changed
3886 added ranges field---configured area ranges;
3887 A separate Routers RT added;
3888 area range config commands and config write added
3891 1999-08-28 Alex Zinin <zinin@amt.ru>
3893 ospf_route_free()--added code to free the list of paths;
3894 The following functions added:
3895 ospf_intra_add_router();
3896 ospf_intra_add_transit();
3897 ospf_intra_add_stub();
3898 the last function uses new ospf_int_lookup_by_prefix();
3899 show_ip_ospf_route_cmd()--changed to support new RT structure;
3900 added ospf_cmp_routes()--general route comparision function;
3901 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
3902 they are used in ASE and IA routing;
3903 added ospf_subst_route() and ospf_add_route();
3905 1999-08-28 Alex Zinin <zinin@amt.ru>
3907 changed struct ospf_path to include output interface,
3908 changed struct ospf_route to support IA and ASE routing.
3909 added prototypes of the function used in IA and ASE modules.
3911 1999-08-28 Alex Zinin <zinin@amt.ru>
3912 * ospf_lsa.h ospf_lsa.c :
3913 added ospf_my_lsa(), an interface independent version of
3914 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
3916 1999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3918 * ospf_interface.c (interface_config_write): Add check for
3921 1999-08-25 Toshiaki Takada <takada@zebra.org>
3923 * ospf_lsa.c (ospf_lsa_dup): New function added.
3925 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
3926 interface in debug message.
3928 1999-08-25 Toshiaki Takada <takada@zebra.org>
3930 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
3932 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
3933 Delayed Link State Acknowledgment is scheduled by timer.
3935 1999-08-25 Alex Zinin <zinin@amt.ru>
3937 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
3938 a stub network instead of link to a transit network into
3939 originated router-LSA, bug fixed.
3941 1999-08-24 Toshiaki Takada <takada@zebra.org>
3943 * ospfd.c (ospf_update_router_id): New function added.
3945 * ospf_network.c (ospf_write): Create new socket per transmission.
3946 And select outgoing interface whether dst is unicast or multicast.
3948 * ospf_packet.c: LSA flooding will work.
3950 1999-08-24 VOP <vop@unity.net>
3952 * ospf_route.c: Include "sockunion.h"
3954 1999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3956 * ospf_network.c (ospf_serv_sock_init): Enclose
3957 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
3958 not have the definition.
3960 1999-08-23 Toshiaki Takada <takada@zebra.org>
3962 * ospf_packet.c: Fix bug of DD processing.
3964 1999-08-18 Toshiaki Takada <takada@zebra.org>
3966 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
3968 1999-08-17 Toshiaki Takada <takada@zebra.org>
3970 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
3971 corrected. The bug of `mes_lookup' is fixed.
3972 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
3974 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
3975 `ospf_add_router_lsa'.
3976 (ospf_network_lsa_install): The name is changed from
3977 `ospf_add_network_lsa'.
3979 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
3981 * ospf_interface.c (ospf_if_is_enable): New function added.
3983 1999-08-16 Toshiaki Takada <takada@zebra.org>
3985 * ospf_lsa.h (struct lsa_header): The name is changed from
3987 (struct ospf_lsa): New struct added to control each LSA's aging
3990 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
3992 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
3993 (ospf_lsa_different), (ospf_lsa_install): New function added.
3995 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
3997 1999-08-12 Toshiaki Takada <takada@zebra.org>
3999 * ospf_nsm.c (nsm_reset_nbr): New function added.
4000 KillNbr and LLDown neighbor event call this function.
4002 1999-08-10 Toshiaki Takada <takada@zebra.org>
4004 * ospf_packet.c (ospf_ls_retransmit)
4005 (ospf_ls_upd_timer): New function added.
4006 Set retransmission timer for Link State Update.
4008 1999-07-29 Toshiaki Takada <takada@zebra.org>
4010 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4012 1999-07-28 Toshiaki Takada <takada@zebra.org>
4014 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4015 with IPTOS_PREC_INTERNET_CONTROL.
4017 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4018 if NSM status change.
4020 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4021 Hello packet, when the neighbor goes down.
4023 1999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4025 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4027 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4030 1999-07-25 Toshiaki Takada <takada@zebra.org>
4032 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4035 1999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4037 * ospf_route.c (ospf_route_table_free): New function added.
4039 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4042 * ospfd.h (struct ospf): Add old_table.
4044 * ospf_main.c (sighup): Call of log_rotate () removed.
4046 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4047 area->lsa as self LSA. This should be area->lsa_self.
4049 1999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4051 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4052 (),ospf_zebra_delete () added.
4054 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4056 1999-07-24 Toshiaki Takada <takada@zebra.org>
4058 * ospf_lsa.c: Change LS sequence number treatment.
4059 (ospf_lsa_is_self_originated): New function added.
4060 (show_ip_ospf_database_self_originated): New DEFUN added.
4062 1999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4064 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4066 1999-07-22 Toshiaki Takada <takada@zebra.org>
4068 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4069 (ospf_nexthop_dup): function added.
4070 (ospf_nexthop_calculation): function changed.
4072 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4074 1999-07-21 Toshiaki Takada <takada@zebra.org>
4076 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4078 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4080 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4082 1999-07-21 Toshiaki Takada <takada@zebra.org>
4084 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4086 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4089 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4091 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4092 change behavior according to LSA type.
4093 (ospf_lsa_has_link): Link check function is added.
4095 1999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4097 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4098 SPF calcultion schedule addtition.
4099 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4101 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4103 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4104 header typo correction. Display of router LSA's #link added.
4106 1999-07-19 Toshiaki Takada <takada@zebra.org>
4108 * ospf_packet.c (ospf_check_network_mask): Added new function for
4109 receiving Raw IP packet on an appropriate interface.
4111 1999-07-16 Toshiaki Takada <takada@zebra.org>
4113 * ospfd.c (ospf_router_id): new DEFUN added.
4115 1999-07-15 Toshiaki Takada <takada@zebra.org>
4117 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4118 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4119 (ospf_spf_next_router), (ospf_spf_next_network),
4120 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4123 1999-07-13 Toshiaki Takada <takada@zebra.org>
4125 * ospf_ism.c: fix bug of DR Election.
4127 * ospf_nsm.c: fix bug of adjacency forming.
4129 1999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4131 * ospfd.c (ospf_init): Change to use install_default.
4133 1999-07-01 Rick Payne <rickp@rossfell.co.uk>
4135 * ospf_zebra.c (zebra_init): Install standard commands to
4138 1999-06-30 Toshiaki Takada <takada@zebra.org>
4140 * ospf_dump.c: Whole debug command is improved.
4141 (ISM|NSM) (events|status|timers) debug option added.
4142 (show_debugging_ospf): new DEFUN added.
4144 1999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4146 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4149 1999-06-29 Toshiaki Takada <takada@zebra.org>
4151 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4152 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4154 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4156 * ospf_ism.c (ospf_dr_election): fix DR Election.
4158 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4161 1999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4163 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4165 1999-06-28 Toshiaki Takada <takada@zebra.org>
4167 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4168 `show ip ospf database network' command output.
4170 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4171 Retransmission, Database Summary and Link State Request.
4173 * ospf_packet.c (ospf_ls_req_timer): New function added.
4174 Set Link State Request retransmission timer.
4176 1999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4178 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4181 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4182 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4184 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4185 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4187 1999-06-25 Toshiaki Takada <takada@zebra.org>
4189 * ospf_packet.c: fix bug of DD making.
4190 fix bug of LS-Update reading.
4192 1999-06-23 Toshiaki Takada <takada@zebra.org>
4194 * ospf_packet.c: All type of packets are changed to use
4195 fifo queue structure.
4196 (ospf_fill_header) function added.
4198 1999-06-22 Toshiaki Takada <takada@zebra.org>
4200 * ospf_packet.c (ospf_packet_new): New function added to handle
4201 sending ospf packet by fifo queue structure.
4202 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4203 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4204 (ospf_fifo_free): Likewise.
4206 1999-06-21 Toshiaki Takada <takada@zebra.org>
4208 * ospf_nsm.c (ospf_db_desc_timer): function added.
4209 (nsm_timer_set) function added.
4210 * ospf_dump.c (ospf_option_dump): function added.
4211 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4213 1999-06-20 Toshiaki Takada <takada@zebra.org>
4215 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4216 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4219 1999-06-19 Toshiaki Takada <takada@zebra.org>
4221 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4222 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4223 (if_ospf_hello_interval), (if_ospf_priority),
4224 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4225 argument changed from NUMBER to <range>.
4226 DEFUN (if_ospf_network_broadcast),
4227 DEFUN (if_ospf_network_non_broadcast),
4228 DEFUN (if_ospf_network_point_to_multipoint),
4229 DEFUN (if_ospf_network_point_to_point) functions are combined to
4230 DEFUN (if_ospf_network).
4232 1999-06-18 Toshiaki Takada <takada@zebra.org>
4234 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4235 ospf_lsa_lookup (), ospf_lsa_count () Added.
4237 1999-06-15 Toshiaki Takada <takada@zebra.org>
4239 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4240 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4241 `debug ospf ism' command shows debug message.
4242 `debuf ospf nsm' command shows debug message.
4244 1999-06-14 Toshiaki Takada <takada@zebra.org>
4246 * ospf_lsa.c: ospf_network_lsa () Added.
4247 ospf_lsa_checksum () Added.
4248 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4249 `debug ospf packet' command shows debug message.
4251 1999-06-13 Toshiaki Takada <takada@zebra.org>
4253 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4256 1999-06-11 Toshiaki Takada <takada@zebra.org>
4258 * ospf_dump.c: fix IP packet length treatment.
4260 1999-06-10 Toshiaki Takada <takada@zebra.org>
4262 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4263 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4265 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4266 ospf_make_hello (), ospf_make_db_desc () Added.
4267 ospf_db_desc_proc () Added.n
4269 * Database Description packet can be processed.
4271 1999-06-08 Toshiaki Takada <takada@zebra.org>
4273 * ospf_lsa.c: New file.
4275 1999-06-07 Toshiaki Takada <takada@zebra.org>
4277 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4279 1999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4281 * ospf_spf.[ch]: New file.
4283 1999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4285 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4287 * ospf_zebra.h (zebra_start): Remove struct zebra.
4289 1999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4291 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4292 ntohl for sprintf warning.
4294 1999-05-19 Toshiaki Takada <takada@zebra.org>
4296 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4297 if interface state changes to DR or BDR.
4299 1999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4301 * ospf_main.c (signal_init): SIGTERM call sigint.
4302 (sigint): Logging more better message.
4304 1999-05-12 Toshiaki Takada <takada@zebra.org>
4306 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4308 1999-05-11 Toshiaki Takada <takada@zebra.org>
4310 * ospf_neighbor.c: ospf_nbr_free () Added.
4312 1999-05-10 Toshiaki Takada <takada@zebra.org>
4314 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4315 * Fix bug of `no network' statement, it will work.
4317 1999-05-07 Toshiaki Takada <takada@zebra.org>
4319 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4320 updated by ospf_if_update ().
4322 1999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4324 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4326 1999-04-25 Toshiaki Takada <takada@zebra.org>
4328 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4329 DEFUN (no_if_ospf_dead_interval),
4330 DEFUN (no_if_ospf_hello_interval),
4331 DEFUN (no_if_ospf_priority),
4332 DEFUN (no_if_ospf_retransmit_interval),
4333 DEFUN (no_if_ospf_transmit_delay) Added.
4335 interface_config_write () suppress showing interface
4338 1999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4340 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4342 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4343 of ospf_network { }. So `router ospf' statement in ospfd.conf
4345 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4347 1999-04-25 Toshiaki Takada <takada@zebra.org>
4349 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4350 DEFUN (if_ospf_network_broadcast),
4351 DEFUN (if_ospf_network_non_broadcast),
4352 DEFUN (if_ospf_network_point_to_multipoint),
4353 DEFUN (if_ospf_network_point_to_point),
4354 DEFUN (no_if_ospf_network) Added.
4356 1999-04-23 Toshiaki Takada <takada@zebra.org>
4358 * ospfd.h: struct area { } changed to struct ospf_network { }.
4359 Add struct ospf_area { }.
4360 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4361 and ospf_network_free ().
4362 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4364 1999-04-22 Toshiaki Takada <takada@zebra.org>
4366 * ospf_lsa.h: New file.
4367 * ospf_packet.h: LSA related struct definition are moved to
4369 * ospf_packet.c: ospf_verify_header () Added.
4371 1999-04-21 Toshiaki Takada <takada@zebra.org>
4373 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4374 DR Election bug fixed.
4375 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4376 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4378 1999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4380 * ospf_main.c (main): access_list_init () is added for vty
4381 connection filtering.
4383 1999-04-16 Toshiaki Takada <takada@zebra.org>
4385 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4386 * ospf_neighbor.c: ospf_nbr_count () Added.
4388 1999-04-15 Toshiaki Takada <takada@zebra.org>
4390 * ospfd.h: struct ospf { } Changed.
4391 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4392 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4394 1999-04-14 Toshiaki Takada <takada@zebra.org>
4396 * ospf_ism.c: ospf_elect_dr () Added.
4397 * ospf_network.c: ospf_if_ipmulticast () Added.
4399 1999-04-11 Toshiaki Takada <takada@zebra.org>
4401 * ospf_interface.c: interface_config_write (),
4402 DEFUN (if_ip_ospf_cost),
4403 DEFUN (if_ip_ospf_dead_interval),
4404 DEFUN (if_ip_ospf_hello_interval),
4405 DEFUN (if_ip_ospf_priority),
4406 DEFUN (if_ip_ospf_retransmit_interval) and
4407 DEFUN (if_ip_ospf_transmit_delay) Added.
4409 1999-04-08 Toshiaki Takada <takada@zebra.org>
4411 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4412 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4413 * ospf_nsm.c: nsm_twoway_received () Added.
4415 1999-04-02 Toshiaki Takada <takada@zebra.org>
4417 * ospf_neighbor.c: New file.
4418 * ospf_neighbor.h: New file.
4419 * ospf_nsm.c: New file.
4420 * ospf_nsm.h: New file.
4421 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4422 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4424 1999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4426 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4428 1999-03-19 Toshiaki Takada <takada@zebra.org>
4430 * ospf_packet.c: New file.
4431 * ospf_packet.h: New file.
4432 * ospf_network.c: New file.
4433 * ospf_network.h: New file.
4434 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4436 1999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4438 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4441 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4442 for install ospfd.conf.sample as owner read only file.
4444 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4446 1999-03-15 Toshiaki Takada <takada@zebra.org>
4448 * ospf_ism.c: New file.
4449 * ospf_ism.h: New file.
4450 * ospf_dump.c: New file.
4451 * ospf_dump.h: New file.
4453 * ospfd.h: Add (struct ospf), (struct config_network),
4454 (struct message) structure.
4456 * ospf_interface.c: Add ospf_if_match_network ().
4457 * ospf_interface.h (struct ospf_interface): Change struct members.
4459 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4460 DEFUN (network_area): Added.
4462 * ospfd.conf.sample: Change sample configuration.
4464 1999-03-05 Toshiaki Takada <takada@zebra.org>
4466 * ospf_interface.c: New file.
4467 * ospf_interface.h: New file.
4468 * ospf_zebra.h: New file.
4469 * ospf_zebra.c: Add interface function for zebra daemon.
4470 * ospfd.c: New file.
4472 1999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4474 * Move IPv6 codes and files to ospf6d directory.
4476 1999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4478 * syslog support added
4480 1998-12-22 Toshiaki Takada <takada@zebra.org>
4482 * ospfd.h: New file.
4483 * ospf_lsa.h: New file.
4485 1998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4487 * Makefile.am: New file.
4488 * ospf_main.c: New file.