1 2006-05-12 Paul Jakma <paul.jakma@sun.com>
3 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
4 call, which is not checked for NULL return, by stripping out
5 functionality which is never used, hence fixing Coverity CID
7 (struct lsa_action) remove unused member.
8 (ospf_translated_nssa_refresh) Add non-assert sanity check,
9 in case DEBUG isn't defined.
10 Debug message when no type7 exists should print the ID from
11 the type5, not the type7, fixes CID #13.
12 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
13 check on ospf_lookup, CID #27.
14 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
15 call by taking the struct ospf * as argument, which the
16 caller has, fixing CID #28.
17 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
18 * ospf_zebra.c: (ospf_redistribute_unset) update call to
19 ospf_redistribute_withdraw to match.
20 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
21 NULL when passed to ospf_find_asbr_route_through_area,
22 check for NULL first, CID #14.
23 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
24 useless, it's always valid. Only possibility where it
25 couldn't be is if there is a race between abr_task and
26 cleaning up oi's, in which case a NULL check here isn't going
27 to do anything. Fixes CID #15.
29 2006-05-11 Paul Jakma <paul.jakma@sun.com>
31 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
32 ensure check for NULL result, make vty messages consistent.
33 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
34 result, fixes Coverity CID #70.
35 (no_ospf_area_filter_list) Check NULL result from
36 ospf_area_lookup_by_area_id, fixes Coverity CID #69
37 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
38 NULL check by moving into check-protected block, fix CID #49.
39 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
40 range, should just lookup to see if one exists, the new range
41 is just leaked. Fixes CID #46.
42 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
43 take (struct ospf *) as thread argument, rather than (struct
44 ospf *)->default_originate, thus avoiding having to call
46 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
47 of ospf_default_originate_timer thread to match.
48 * ospfd.c: (ospf_router_id_update) ditto.
50 2006-04-24 Paul Jakma <paul.jakma@sun.com>
52 * (general) More Virtual-link fixes, again with much help in
53 testing / debug from Juergen Kammer. Primarily in SPF.
54 * ospf_spf.h: Add guard. ospf_interface.h will include this
56 * ospf_interface.h: Modify ospf_vl_lookup definition to take
57 struct ospf as argument, so as to allow for NULL area
59 (struct ospf_vl_data) Remove out_oi, instead add a struct
60 vertex_nexthop, to use as initial nexthop for backbone paths
62 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
63 NULL area to be passed to indicate "any" (first) area.
65 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
66 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
68 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
69 backbone, don't bother checking.
70 * ospf_spf.c: (static struct list vertex_list) Record vertices
71 that will need to be freed.
72 (cmp) Order network before router vertices, as required,
74 (vertex_nexthop_free) Mild additional robustness check.
75 (vertex_parent_free) Take void argument, as this function
76 is passed as list deconstructor for vertex parent list.
77 (ospf_vertex_new) More debug. Set deconstructor for parent
78 list. Track allocated vertices on the vertex_list.
79 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
80 vertices. Now frees only the given vertex.
81 (ospf_vertex_add_parent) Fix assert.
82 (ospf_nexthop_calculation) Fix calculation of nexthop for
83 VLink vertices, lookup the vl_data and use its previously
84 recorded nexthop information.
85 (ospf_spf_calculate) Vertices are freed simply by deleting
86 vertex_list nodes and letting ospf_vertex_free as deconstructor
88 (ospf_spf_calculate_timer) Trivial optimisation, leave
89 backbone SPF calculation till last to reduce SPF churn on
91 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
92 (no_ospf_area_vlink_cmd) ditto.
93 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
94 more interesting than the output interface.
96 2006-04-03 Paul Jakma <paul.jakma@sun.com>
98 * (general) Fix issues with handling of Vlinks and entries
99 in the nbrs route-table which were highlighted by the
100 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
101 Kammer for his help and efforts in testing out debug patches to
103 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
104 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
105 to create key in nbrs table for a given nbr.
106 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
107 document an expected state.
108 (ospf_nbr_add_self) Ditto.
109 (ospf_nbr_lookup_by_addr) Add an assert.
110 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
113 2006-03-27 Paul Jakma <paul.jakma@sun.com>
115 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
116 the ambiguities of ANSI and C99 C with respect to type
117 conversion. Detailed problem report and test case with
118 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
120 2006-03-25 Paul Jakma <paul.jakma@sun.com>
122 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
123 we can never ever receive packets on those. Should fix
124 case where CARP is run with address in same subnet as real
125 interface. Problem report and diagnosis thanks to:
126 Landon Fuller <landonf@opendarwin.org>.
127 However, ospf_read() still can't deal deterministically with
128 multiple interfaces in same subnet.
130 2006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
132 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
133 conversion of OSPF_MAX_SEQUENCE_NUMBER
135 2006-01-19 Paul Jakma <paul.jakma@sun.com>
137 * (general) various miscellaneous compiler warning fixes.
138 Remove redundant break statements from switch clauses
140 return from main, not exit, cause it annoys SOS.
141 Remove stray semi-colons which cause empty-statement
144 2006-01-18 Juergen Kammer <j.kammer@eurodata.de>
146 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
147 stream data until it is constructed, data reference is
148 volatile due to the potential resize in link_info_set
150 2006-01-18 Paul Jakma <paul.jakma@sun.com>
152 * ospf_lsa.c: (link_info_set) Resize the stream if required and
153 possible. Return number of links added.
154 (lsa_link_*_set) use return value from previous.
155 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
157 2006-01-17 Paul Jakma <paul.jakma@sun.com>
159 * ospf_packet.c: (ospf_verify_header) print out the types
160 involved if there's a mismatch.
161 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
163 2006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
165 * (general) Bug #234, see also [quagga-dev 3902].
166 Fix problem with nbr_self not being properly reinitialised
167 when an interface comes up, after having been down.
168 Some re-arrangement done by Paul Jakma, any bugs introduced
169 on top of Len's suggested changes are his.
170 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
171 initialisation of nbr_self parameters here.
172 * ospf_interface.c: (ospf_if_new) deleting initialisation of
173 parameters of nbr_self, just rely on call to
175 (ospf_if_cleanup) ditto.
176 * ospfd.c: (ospf_network_run) ditto.
178 2006-01-10 Juris Kalnins <juris@mt.lv>
180 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
181 struct connected in an error case.
182 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
183 undefined effect, assignment of an increment expression.
185 2006-01-10 Paul Jakma <paul.jakma@sun.com>
187 * ospfd.c: (ospf_network_run) checking to see if router-id
188 is set should be on ospf->router_id, not router_id_static.
189 This was causing ospfd to not start if router-id had not
190 been configured statically.
191 (ospf_if_update) ditto.
192 * ospf_vty.c: (config_write_ospf_distribute) trim down
195 2005-11-26 Paul Jakma <paul.jakma@sun.com>
197 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
198 array to C99 incomplete type array.
199 * (general) s/graceful/deferred/ in all files, the former term
200 is confusing wrt OSPF Graceful-Restart.
201 * ospfd.c: (ospf_deferred_shutdown_check) dont return
202 a function which returns void. SOS complains about this.
205 2005-11-20 Paul Jakma <paul.jakma@sun.com>
207 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
208 (struct ospf) remove the router_id timer thread.
209 remove export of ospf_router_id_update_timer.
210 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
211 poke interfaces into action after ID has been configured.
212 (ospf_router_id_update_timer) removed.
213 (ospf_finish_final) t_router_id_update timer is gone.
214 (ospf_network_run) router-id update timer gone.
215 call ospf_router_id_update directly if ID not configured.
216 In the per-iface loop, don't ospf_if_up interfaces if
217 ID is still not configured. The update function will call
218 ospf_if_update anyway.
219 (ospf_if_update) ID update timer is gone. Just return if no
221 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
223 * ospf_zebra.c: (ospf_router_id_update_zebra) call
224 ospf_router_id_update directly, not via timer.
225 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
226 returned LSA of ospf_summary_lsa_refresh and print warning if
228 (ospf_abr_announce_network_to_area) similar
229 (ospf_abr_announce_rtr_to_area) similar
230 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
231 (ospf_router_lsa_originate) similar
232 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
233 (ospf_summary_lsa_new) Check ID is valid.
234 (ospf_summary_lsa_originate) ditto, and check returned LSA from
235 previous function is !NULL.
236 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
238 (ospf_summary_asbr_lsa_new) ID valid check.
239 (ospf_summary_asbr_lsa_originate) similar.
241 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
243 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
244 for use with ospf_timer_dump and ospf_timeval_dump.
245 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
246 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
247 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
248 call to ospf_timer_dump.
250 2005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
252 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
253 in 'do {...} while(0)'.
255 2005-11-14 Paul Jakma <paul.jakma@sun.com>
257 * ospfd.c: (ospf_new) stub-shutdown should just default to
258 unconfigured, too strange otherwise.
259 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
260 preprocessor conditional on HAVE_OPAQUE_LSA.
261 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
262 no longer used, plus it wasn't in range that the command
264 * ospf_zebra.h: Depends on vty.h, include it.
266 2005-11-11 Paul Jakma <paul.jakma@sun.com>
268 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
269 the nexthops pointing to the root vertex. We may visit a
270 vertex twice or the vertex may have some inherited nexthops,
271 if we free other nexthops we could crash.
273 2005-11-04 Paul Jakma <paul.jakma@sun.com>
275 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
276 function rather than unportable timersub.
278 2005-11-03 Paul Jakma <paul.jakma@sun.com>
280 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
281 * ospf_packet.c: include checksum.h, remove the in_cksum extern
283 * ospf_te.h: Add braces, quell warning.
284 * ospf_packet.c: Change level of some warnings to
287 2005-10-29 Paul Jakma <paul.jakma@sun.com>
289 * (general) RFC3137 stub-router support
290 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
291 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
292 options, to allow shutdown to distinguish between complete
293 shutdown and shutdown of a subset of ospf instances.
295 Add stub_router_{startup,shutdown_}time, configuration of startup
296 and shutdown time for stub-router.
297 Add t_graceful_shutdown struct thread, timer for graceful
299 (struct ospf_area) Add stub_router_state - run time state of
300 stub-router for an area. Add flags for ADMIN, IS and WAS
302 Add t_stub_router, timer thread to resend router-lsa for an
304 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
305 either the given lnks cost or infinite cost if stub-router is
307 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
308 previous function for transit-links.
309 (ospf_stub_router_timer) timer thread for end of startup stub
310 router. Change state as required for the area and setup
311 re-origination of router-lsa.
312 (ospf_stub_router_check) Check/do whether stub-router should be
313 enabled, and whether it requires timer to be setup.
314 (ospf_router_lsa_new) call previous function at top.
315 (ospf_router_lsa_originate) no external callers, made static.
316 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
317 * ospf_main.c: (sigint) make static.
318 remove call to exit, as ospf_terminate now deals with
320 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
321 * ospf_vty.c: (show_ip_ospf_area) print out state of
322 stub-router, if active.
323 (show_ip_ospf) print out configuration of stub-router
324 support, and details of graceful-shutdown if the timer is
326 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
327 commands to (de-)?configure stub-router support.
328 (config_write_stub_router) write out config of stub-router.
329 (ospf_config_write) call previous.
330 (ospf_vty_init) install the new stub-router commands.
331 * ospfd.c: various functions made static.
332 (ospf_new) Set defaults for stub-router. Graceful shutdown
333 is made to default on, just to be adventerous.
334 (ospf_graceful_shutdown_finish) new function, final part of
336 (ospf_graceful_shutdown_timer) timer thread wrapper for
338 (ospf_graceful_shutdown_check) check whether to setup timer
339 for shutdown or proceed directly to final shutdown.
340 (ospf_terminate) moved here from ospf_route.c, call
341 ospf_finish for each instance.
342 (ospf_finish) renamed to ospf_finish_final and made static.
343 (ospf_finish) new function, exported wrapper around
344 ospf_graceful_shutdown_check.
345 (ospf_finish_final) complete shutdown of an instance.
346 Add missing TIMER_OFF's of two timer threads.
347 (ospf_area_free) opaque self lsa timer should be turned off.
349 2005-10-23 Paul Jakma <paul.jakma@sun.com>
351 * ospf_apiserver.c: (ospf_apiserver_term) This function should
352 not have side-effects (eg segv) if no apiserver instances are
353 active, ie be robust.
354 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
355 has not yet been run.
357 2005-10-21 Paul Jakma <paul.jakma@sun.com>
359 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
361 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
364 2005-10-21 Paul Jakma <paul.jakma@sun.com>
366 * (general) SPF millisecond resolution timer with adaptive,
367 linear back-off holdtime. Prettification of ospf_timer_dump.
368 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
369 ospf_timer_dump, but made to be more dynamic in printing out
370 the relative timeval, sliding the precision printed out
371 according to the value.
372 (ospf_timer_dump) guts moved to ospf_timeval_dump.
373 * ospf_dump.h: export ospf_timeval_dump.
374 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
375 the libzebra exported recent_time instead, as it's not
376 terribly critical to have time exactly right - the dropped
377 LSA will be retransmited to us if we don't ACK it.
378 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
379 not transmitting, just putting LSA back on update transmit list.
380 * ospfd.h: delay and holdtimes should be unsigned.
381 Add spf_max_holdtime and spf_hold_multiplier.
382 Update default defines for delay and hold time to be in msec.
383 (struct ospf) change the SPF timestamp to a struct timeval.
384 Remove ospf_timers_spf_(un)?set.
385 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
386 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
387 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
388 now, update with gettimeofday.
389 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
391 Make the holdtime be adaptive, with a linear increase in
392 holdtime ever consecutive SPF run which occurs within holdtime
393 of previous SPF, bounded by spf_max_holdtime.
394 * ospf_vty.c: Update spf timers commands.
395 (ospf_timers_spf_set) trivial helper.
396 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
397 initial hold and max hold times with millisecond resolution.
398 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
399 convert to msec, truncate to new limits.
400 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
401 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
402 (show_ip_ospf_cmd) Display SPF parameters and times.
403 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
405 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
406 the multiple spaces which were making the lines even longer.
407 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
408 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
409 widths for NBMA neighbours.
410 (show_ip_ospf_neighbor_int) Use header function.
411 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
413 (show_ip_ospf_neighbor_detail_sub) ditto
414 (ospf_vty_init) install the new SPF throttle timer commands.
416 2005-10-21 Paul Jakma <paul.jakma@sun.com>
418 * (general) OSPF fast, sub-second hello and 1s dead-interval
420 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
421 Callers typically specify a length of 9, so most see
422 millisecs unless they specify the additional length.
423 * ospf_interface.h: (struct ospf_interface) new interface param,
425 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
427 (ospf_new_if_params) Initialise fast_hello param.
428 (ospf_free_if_params) Check whether fast_hello is configured.
429 (ospf_if_new_hook) set fast_hello to default.
430 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
431 prevent funny side-effects from its if statement when this
432 macro is used conditionally by other macros.
433 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
434 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
435 to whether fast_hello is set.
436 * ospf_ism.c: Update all setting of the hello timer to use
437 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
438 former is used when hello is to be sent immediately.
440 * ospf_packet.c: (ospf_hello) hello-interval is not checked
441 for mismatch if fast_hello is set.
442 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
443 rather than a warning, as it can be perfectly normal to
444 receive packets when logical subnets are used.
445 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
447 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
448 nit, don't vty_out if this command is given, it gets tired
450 (show_ip_ospf_interface_sub) Print the hello-interval
451 according to whether fast-hello is set or not.
452 Print the extra 5 millisec characters from (ospf_timer_dump)
453 if fast-hello is configured.
454 (ospf_vty_dead_interval_set) new function, common to all
455 forms of dead-interval command, to set dead-interval and
456 fast-hello correctly. If a dead-interval is given, unset
457 fast-hello, else if a hello-multiplier is set, set
458 dead-interval to 1 and fast-hello to given multiplier.
459 (ip_ospf_dead_interval_addr_cmd) use
460 ospf_vty_dead_interval_set().
461 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
462 (no_ip_ospf_dead_interval) Unset fast-hello.
463 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
464 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
465 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
466 (config_write_interface) Write out fast-hello.
467 (ospf_config_write) Write a comment about
468 "auto-cost reference-bandwidth" having to be equal on all
469 routers. Hopefully just as noticeable as old practice of
470 writing to vty, but less annoying.
471 (ospf_vty_if_init) install the two new dead-interval
473 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
474 and OSPF_FAST_HELLO_DEFAULT.
476 2005-10-18 Paul Jakma <paul.jakma@sun.com>
478 * (general) SPF memory management cleanup and fix for rare
480 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
481 specific data, eg the backlink and the parent vertex pointer,
482 and point to the appropriate general struct vertex_nexthop.
483 (struct vertex_nexthop) remove parent vertex pointer, so
484 this struct can be shared across vertices.
485 (struct vertex) rename list child to list children. Remove
486 list of nexthops, replace with list of vertex_parents.
487 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
488 (vertex_nexthop_new) remove init of parent - field is gone
489 from struct vertex_nexthop.
490 (ospf_canonical_nexthops_free) Remove the canonical
491 vertex_nexthop memory objects. These are the vertex_nexthops
492 attached to the first level of router vertices from the root.
493 (vertex_parent_new) new function, create a vertex_parent.
494 (vertex_parent_free) ditto, but free it.
495 (ospf_vertex_new) Update to match changes to struct vertex.
496 (ospf_vertex_free) Recursively free a struct vertex and its
497 children. The parent list is used as a reference count.
498 vertex_nexthops must be free seperately, if required.
499 (ospf_vertex_dump) update to match struct vertex changes.
500 Print out backlink of parents too.
501 (ospf_vertex_add_parent) ditto.
502 (ospf_lsa_has_link) update comment.
503 (ospf_nexthop_add_unique) removed, not needed anymore.
504 (ospf_nexthop_merge) ditto.
505 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
506 Simplified to just create vertex_parent and add it.
507 (ospf_spf_flush_parents) new function, flush out the parent
509 (ospf_nexthop_calculation) Take the relevant route_lsa_link
510 as an argument, which simplifies things and removes the need
511 for the hack in ospf_nexthop_add_unique - ospf_spf_next
512 already knew exactly which link the cost calculated was for.
513 Update to match struct vertex changes too.
514 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
515 it's there's a vertex already created for W, use it, and
516 hence there's no need to free it either.
517 Update some manipulation/comparisons of distance to match.
518 Flush the parent list if a lower cost path is found.
519 (ospf_spf_route_free) unused, removed.
520 (ospf_spf_dump) match the struct vertex changes, and dump the
522 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
523 and call ospf_vertex_free on the root vertex to free the
525 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
527 * ospf_route.c: (ospf_intra_route_add) ditto
528 (ospf_route_copy_nexthops_from_vertex) ditto
530 2005-10-11 Paul Jakma <paul.jakma@sun.com>
532 * ospf_api.c: sign warnings.
533 * ospf_apiserver.c: sign warning and convert all the struct
534 in_addr initialisations so as not to make assumptions about
535 how this struct is organised, initialise the s_addr member
537 * ospf_packet.c: Add const qualifier to auth_key.
539 2005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
541 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
542 which now allows snmpwalk to work with ospfIfTable and
543 also with ospfIfMetricTable
545 2005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
547 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
548 (ospf_redist_string) New function implemented using new library
549 function zebra_route_string(). Note that there are a few differences
550 in the output that will result: the new function returns strings
551 that are lower-case, whereas the old table was mixed case. Also,
552 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
553 new function returns "ospf6".
554 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
555 and add extern const char *ospf_redist_string(u_int route_type)
557 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
558 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
559 * ospf_vty.c: Remove local hard-coded table distribute_str.
560 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
561 new library function zebra_route_string() instead of distribute_str[].
562 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
563 ospf_redistribute_default_set,ospf_redistribute_check)
564 In debug messages, use ospf_redist_string() instead of
565 LOOKUP(ospf_redistributed_proto).
567 2005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
569 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
572 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
574 * ospf_ism.c: generate SNMP traps on Interface state change
575 * ospf_nsm.c: generate SNMP traps on Neighbour state change
576 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
578 2005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
580 * ospf_vty.c: forece default route LSA to be re_issued whenever
581 cost is changed ( [no] ip ospf area XXX default-cost YYY)
582 Support ignore-mtu option
583 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
584 * ospf_packet.c: support ignore-mtu option
585 * ospf_interface.h: field added for skipping MTU check
586 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
587 Set mtu_ignore field to default value
588 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
589 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
591 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
592 convert OSPFIFSTATE internal status into SNMP values
594 2005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
596 * ospf_packet.c: use new md5 API
598 2005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
600 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
601 (nexthop) since it is not used in the function (except inside
602 some commented-out code).
603 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
604 Comment out the 5th argument to ospf_external_lsa_flush.
605 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
606 to ospf_external_lsa_flush.
607 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
608 uninitialized nexthop arg to ospf_external_lsa_flush.
609 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
610 to ospf_external_lsa_flush.
611 * ospfd.c: (ospf_network_set) Comment out 5th arg
612 to ospf_external_lsa_flush.
614 2005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
617 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
618 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
620 2005-08-21 Hasso Tepper <hasso at quagga.net>
622 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
623 Interface should be specified by name now.
625 2005-08-17 Hasso Tepper <hasso at quagga.net>
627 * ospf_vty.c: Check carefully if interface exists before trying to
630 2005-08-05 Hasso Tepper <hasso at quagga.net>
632 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
633 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
634 for default-information.
636 2005-07-26 Paul Jakma <paul.jakma@sun.com>
638 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
639 should be on lsa not old, which may be freed for one thing,
642 2005-07-12 Paul Jakma <paul.jakma@sun.com>
644 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
645 OSPF_ABR_CISCO be the default ABR type.
646 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
647 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
648 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
649 (ospf_config_write) test whether default abr_type against
650 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
652 2005-06-20 Hasso Tepper <hasso at quagga.net>
654 * ospf_nsm.c: Make database exchange for NSSA database work.
656 2005-06-13 Paul Jakma <paul.jakma@sun.com>
658 * ospf_spf.c: Try get more information on a SEGV under
659 ospf_spf_vertex_add_parent.
660 (ospf_vertex_free) NULL out the child and nexthop lists
661 (ospf_vertex_add_parent) nexthop and child can not be NULL
662 vertex_nexthop's parent->child list can not be NULL
663 (ospf_spf_next) w and cw are per-loop iteration variables, move
664 declarations into loop body.
666 2005-06-07 Hasso Tepper <hasso at quagga.net>
668 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
669 changes - oi->ifp->status doesn't give to us info about ISM,
672 2005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
674 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
676 2005-05-26 Paul Jakma <paul.jakma@sun.com>
678 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
679 had been fixed long ago by Sowmini.
681 2005-05-19 Paul Jakma <paul.jakma@sun.com>
683 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
685 1: this function is supposed to lookup
686 entries in the oifs ospf_interface route_table and return either
687 an existing oi or NULL to indicate not found, its caller depends
688 on this, yet this function uses route_node_get which /always/
689 returns a route_node - one is created if none exists. Use
690 route_node_lookup instead. This should fix root cause of the
691 reports of the (ospf_add_to_if) assert being hit.
692 2: oi's are inserted into this table with prefixlength set to
693 /32 (indeed, it should be a hash table, not a route_table),
694 however prefixlength to lookup was not changed, if no valid entry
695 can be inserted other than /32, then nothng but /32 should be
696 looked up. This possibly only worked by fluke..
697 Fix confirmed by 2 reporters (one list, one IRC), definitely a
698 backport candidate once it has been incubated in HEAD for a while.
699 Thanks to Patrick Friedel and Ivan Warren for testing.
701 2005-05-11 Paul Jakma <paul.jakma@sun.com>
703 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
704 with much debugging done by by scott collins <scollins@agile.tv>.
705 * ospf_lsa.c: (ospf_discard_from_db) dont call
706 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
707 never registered with ase in the first place.
708 * ospf_packet.c: (general) Disabuse opaque related code of its
709 tendency to try gather up things into temporary lists.
710 (ospf_ls_upd) remove the temporary lists opaque uses, call
711 opaque functions inline, just like all other types.
713 (ospf_recv_packet) fixup sign warning.
714 * ospf_opaque.c: (general) fix the unneeded use of lists, and
715 untwist some of the logic.
716 (ospf_opaque_self_originated_lsa_received) take a single LSA
717 as argument, not a list of them. Remove the list loop. Logic
719 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
720 move the actions up into the switch block, remove the goto's and
721 sanitise the logic near the end a bit.
722 * ospf_opaque.h: Adjust definitions of aforementioned functions
723 in ospf_opaque.c to match.
725 2005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
727 * ospf_network.c: Log ifindex on multicast membership leave/join
730 2005-05-06 Paul Jakma <paul.jakma@sun.com>
732 * (general) extern and static qualifiers added.
733 unspecified arguments in definitions fixed, typically they should
735 function casts added for callbacks.
736 Guards added to headers which lacked them.
737 Proper headers included rather than relying on incomplete
739 gcc noreturn function attribute where appropriate.
740 * ospf_opaque.c: remove the private definition of ospf_lsa's
741 ospf_lsa_refresh_delay.
742 * ospf_lsa.h: export ospf_lsa_refresh_delay
743 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
744 correct thing to do - removes need for the casts later.
745 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
746 home-brewed versions, shuts up several warnings.
747 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
748 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
749 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
750 overloading of the THREAD_ARG pointer should at least use
753 2005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
755 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
756 to approve LSAs for the case where metric has changed, lsa gets
757 flushed otherwise. (backport candidate).
759 2005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
761 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
764 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
766 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
767 function that does not exist.
769 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
771 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
772 if_lookup_by_name_len.
774 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
776 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
778 2005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
780 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
781 flags to help with debugging.
782 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
784 (zebra_interface_if_lookup) Make function static. Tighten up code.
786 2005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
788 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
791 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
793 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
794 interface changes, print a debug message and call ospf_if_reset()
795 to simulate down/up on the interface.
796 * ospf_interface.h: Declare new function ospf_if_reset().
797 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
798 and ospf_if_up for all ospf interfaces attached to an interface.
800 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
802 * ospf_packet.c: (ospf_write_frags) Enhance error message to
803 show MTU. Also make function static.
804 (ospf_write) Enhance error message to show interface name and MTU.
805 Also make function static.
807 2005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
809 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
810 bandwidth; this is useful for debugging problems. Also, the function
813 2005-03-27 Hasso Tepper <hasso at quagga.net>
815 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
818 2005-03-25 Hasso Tepper <hasso at quagga.net>
820 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
822 2005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
824 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
825 backward, then current time may be less than
826 ospf->lsa_refresher_started. This was causing invalid values
827 for ospf->lsa_refresh_queue.index resulting in infinite loops.
828 Problem fixed by casting the expression to unsigned before taking
831 2005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
833 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
834 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
835 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
836 (ospf_finish) Call stream_free(ospf->ibuf.
837 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
838 pass it to ospf_recv_packet for use in receiving the packet
839 (instead of allocating a new stream for each packet received).
840 Eliminate all calls to stream_free(ibuf).
841 (ospf_recv_packet) The struct stream *ibuf is now passed in as
842 an argument. No need to use recvfrom to peek at the packet
843 header (to see how big it is), just use ospf->ibuf which is
844 always large enough (this eliminates a system call to recvfrom).
845 Therefore, no need to allocate a stream just for this packet,
846 and no need to free it when done.
848 2005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
850 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
851 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
852 * ospf_spf.h: Add link to the LSA stat structure into vertex.
853 * ospf_spf.c: New functions cmp() and update_stat() to manage
854 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
855 ospf_install_candidate() and ospf_spf_register() functions not needed
856 any more. Update ospf_vertex_new(), ospf_spf_next() and
857 ospf_spf_calculate() functions to use pqueue instead of linked list.
859 2005-02-21 Hasso Tepper <hasso at quagga.net>
861 * ospf_ase.c: Don't show messages related to the ase calculations if
862 we are not debugging.
864 2005-02-19 Hasso Tepper <hasso at quagga.net>
866 * ospf_api.h: char isn't always signed, but it has to be it here.
868 2005-02-19 Paul Jakma <paul.jakma@sun.com>
870 * ospf_packet.c: (ospf_stream_copy) remove
871 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
873 2005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
875 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
876 packet in the queue, it must be discarded. Improve warning messages.
878 (ospf_read) Fix bug: should reset the read thread in all cases
879 to make sure we continue to get incoming messages.
881 2005-02-15 Paul Jakma <paul.jakma@sun.com>
883 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
886 2005-02-14 Paul Jakma <paul.jakma@sun.com>
888 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
890 2005-02-11 Hasso Tepper <hasso at quagga.net>
892 * ospf_lsdb.c: Fix sum of checksums calculation.
894 2005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
896 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
899 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
901 * ospf_interface.h: Reduce structure padding by putting new u_char
902 field multicast_memberships in a better spot (grouped with
903 other u_char fields type and state).
905 2005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
907 * ospf_interface.h: Improve passive_interface comment. Add new
908 multicast_memberships bitmask to struct ospf_interface to track
909 active multicast subscriptions. Declare new function
910 ospf_if_set_multicast.
911 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
912 multicast memberships properly based on the current
913 multicast_memberships status and the current values of the
914 ospf_interface state, type, and passive_interface status.
915 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
916 now handled by ism_change_state's call to ospf_if_set_multicast).
917 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
918 handled by ism_change_state).
919 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
920 the DRouters multicast group (now handled by ism_change_state's call
921 to ospf_if_set_multicast).
922 (ism_change_state) Add call to ospf_if_set_multicast to change
923 multicast memberships as necessary to reflect the new interface state.
924 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
925 passive interface: 1. Increase the severity of the error message
926 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
927 message (packet destination address and interface address);
928 and 3. If the packet was sent to ospf-all-routers, then try
929 to fix the multicast group memberships.
930 (ospf_read) When a packet is received on an interface whose state
931 is ISM_Down, enhance the warning message to show the packet
932 destination address, and try to update/fix the multicast group
933 memberships if the packet was sent to a multicast address.
934 When a packet is received for ospf-designated-routers, but the
935 current interface state is not DR or BDR, then increase the
936 severity level of the error message from LOG_INFO to LOG_WARNING,
937 and try to fix the multicast group memberships.
938 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
939 any ospf interface that may have changed from active to passive.
940 (no_ospf_passive_interface) Call ospf_if_set_multicast for
941 any ospf interface that may have changed from passive to active.
942 (show_ip_ospf_interface_sub) Show multicast group memberships.
944 2005-02-08 Paul Jakma <paul@dishone.st>
946 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
948 2005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
950 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
951 not for event ISM_InterfaceDown. And improve the message by
952 adding the interface flags.
954 2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
956 * ospf_network.c: (ospf_sock_init) Save errno before calling
959 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
961 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
962 an error message and return.
963 (ospf_read) If the interface state is ISM_InterfaceDown, issue
964 a warning message and ignore the packet.
966 2005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
968 * ospf_packet.h: Remove commented out definition of
969 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
971 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
972 when deciding if an update will fit.
973 (ospf_packet_authspace): Factor out calculation of size required
975 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
976 Don't confuse readers that there is a macro.
978 2004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
980 * ospf_network.c: Improve all setsockopt error messages to give detailed
981 information on the arguments.
983 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
985 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
986 messages from LOG_WARNING to LOG_INFO, since this seems to be
989 2004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
991 * ospf_packet.c: (ospf_read) Always look up the interface if
992 ospf_recv_packet returns NULL ifp, since some platforms such
993 as Solaris 8 appear to support ifindex retrieval but don't.
995 2004-12-22 Hasso Tepper <hasso at quagga.net>
997 * ospf_dump.c: Show debug configuration in vtysh.
998 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
999 any case if it's configured as "translate-never".
1000 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1001 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1002 number of all LSAs with AS scope, this includes opaque as LSAs as
1003 well, show this number separately. Show numbers and sums of
1004 checksums for each type of LSAs.
1005 * ospf_lsa.c: Calculate checksum before putting LSA into database.
1007 2004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1009 * ospf_interface.h: Declare new function ospf_default_iftype.
1010 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1011 this logic in one place.
1012 * ospf_zebra.c: (ospf_interface_add) Use new function
1013 ospf_default_iftype.
1014 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1015 by using new function ospf_default_iftype.
1017 2004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1019 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1020 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1021 messages to include identifying information (e.g. router id).
1022 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1023 router id and state names.
1025 2004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1027 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1028 ospf_apiserver * from listnode. Remove unused variables. Follows
1029 suggestion from Jay Fenlason.
1031 2004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1033 * *.c: Change level of debug messages to LOG_DEBUG.
1035 2004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1037 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1039 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1041 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1042 from LOG_NOTICE to LOG_DEBUG.
1044 2004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1046 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1047 (main) Issue a startup announcement using zlog_notice.
1049 2004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1051 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1052 message and in comment.
1053 (ospf_db_desc) Warning message that a packet is being discarded
1054 should give the router id of the packet source. Fix spelling
1055 of packet in two warning messages.
1056 (ospf_ls_req) Warning message that a link state request is being
1057 discarded should give the router id of the neighbor that sent it.
1059 2004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1061 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1062 lib/debug.h has now been deleted).
1064 2004-11-25 Hasso Tepper <hasso at quagga.net>
1066 * ospf_main.c: Make group to run as configurable.
1068 2004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1070 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1071 and works (lib/zebra.h provides if OS doesn't).
1073 2004-11-15 Paul Jakma <paul@dishone.st>
1075 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1077 2004-11-12 Paul Jakma <paul@dishone.st>
1079 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1080 ignore stub area summary default. Even so it seems a strange
1081 check, add a comment to that effect.
1083 2004-11-04 Paul Jakma <paul@dishone.st>
1085 * ospfd.c: (ospf_network_match_iface) revert to previous network
1086 statement match behaviour.
1088 2004-11-02 Paul Jakma <paul@dishone.st>
1090 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1091 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1092 fixing the unfortunate borkenness introduced in moving of this code
1094 (ospf_write) remove iovp and fix up call to previous.
1095 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1096 glibc's size_t format modifier is not portable.
1098 2004-10-31 Paul Jakma <paul@dishone.st>
1100 * ospf_packet.c: (ospf_write_frags) Add debug output
1101 (ospf_write) set type early, so we can pass it to
1103 (ospf_ls_upd_packet_new) print size in debug output when too large
1104 packet is encountered.
1105 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1106 THREAD_ARG to store an integer, but it should at least use same
1107 same type to retrieve the value. Assert value is sane.
1109 2004-10-22 Paul Jakma <paul@dishone.st>
1111 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1113 * ospf_packet.c: (ospf_read) manually look up ifindex
1114 if system could not have returned one, eg openbsd, thanks to Rivo
1115 Nurges for highlighting problem and fix.
1116 Change setsockopt_pktinfo to setsockopt_ifindex.
1118 2004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1120 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1121 with dedicated subnets properly.
1122 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1123 * ospfd.c: (ospf_network_match_iface) ditto.
1124 (ospf_network_run) ditto.
1125 * ospf_interface.c: (ospf_if_is_configured) ditto.
1126 (ospf_if_lookup_by_prefix) ditto.
1127 (ospf_if_lookup_recv_if) ditto.
1128 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1129 broadcast address if present.
1131 2004-10-13 Hasso Tepper <hasso at quagga.net>
1133 * ospf_main.c: Unbreak compilation with ospfapi disabled.
1134 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1135 snmpd. Connection is initialized only if smux peer is configured.
1137 2004-10-12 Hasso Tepper <hasso at quagga.net>
1139 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1140 static variable from ospf_main.c into ospf_opaque.c.
1142 2004-10-11 Hasso Tepper <hasso at quagga.net>
1144 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1145 command line switch to enable it.
1147 2004-10-11 Paul Jakma <paul@dishone.st>
1149 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1150 remove ntohs that should have dissappeared. Take struct ip
1151 as argument, caller has to know there's an IP header at start of
1153 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1154 * ospf_packet.c: (ospf_write) correct call to
1155 sockopt_iphdrincl_swab_htosys which was munging the header.
1156 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1157 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1159 * (global) Const char update and signed/unsigned fixes.
1160 * (various headers) size defines should be unsigned.
1161 * ospf_interface.h: remove duplicated defines, include the
1162 authoritative header - though, these defines should probably
1163 be moved to a dedicated header, or ospfd.h.
1164 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1165 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
1167 2004-10-08 Hasso Tepper <hasso at quagga.net>
1169 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1170 unsigned, remove unused variables etc.
1172 2004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1174 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1175 use of variable names 'node' and 'nextnode' to avoid possible
1176 conflict with list macros. Move variable declaration inside for
1177 loop after a statement to top of function.
1179 2004-10-07 Paul Jakma <paul@dishone.st>
1181 * ospf_snmp.c: Missed list typedef update
1182 * ospf_dump.c: Include sockopt.h for header swab functions.
1184 2004-10-05 Paul Jakma <paul@dishone.st>
1186 * ospf_packet.c: replace ospf_swap_iph_to... with
1187 sockopt_iphdrincl_swab_...
1189 2004-10-03 James R. Leu <jleu at mindspring.com>
1191 * ospf_zebra.c: Read router id related messages from zebra daemon.
1192 Schedule router-id update thread if it's changed.
1193 * ospfd.c: Remove own router-id selection function. Use router id from
1194 zebra daemon if it isn't manually overriden in configuration.
1196 2004-09-27 Paul Jakma <paul@dishone.st>
1198 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1199 Apply to offset too. Print ip_cksum, lets not worry about
1200 possible 2.0.37 compile problems.
1201 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1202 HAVE_IP_HDRINCL_BSD_ORDER.
1203 (ospf_recv_packet) ditto.
1204 (ospf_write) Fixup iov argument to ospf_write_frags.
1205 (struct msghdr).msg_name is caddr_t on most platforms.
1206 (ospf_recv_packet) ditto. And msg_flags is not always there
1207 memset struct then set fields we care about rather than
1208 initialise all fields individually.
1210 2004-09-26 Hasso Tepper <hasso at quagga.net>
1212 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1213 ospf_zebra.c: Fix compiler warnings.
1215 2004-09-24 Paul Jakma <paul@dishone.st>
1217 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1218 update some list loops to LIST_LOOP. some miscellaneous indent
1220 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1221 referenced node in loop.
1222 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1223 deletes referenced nodes from apiserver_list, fixed.
1224 * ospf_interface.h: lists typedef removal cleanup.
1225 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1226 loops to LIST_LOOP. miscellaneous style and indent fixups.
1227 * ospf_te.{c,h}: ditto
1228 * ospf_packet.c: lists typedef removal cleanup.
1229 (ospf_write) ifdef fragmentation support. move actual
1230 fragmentation out to a new, similarly ifdefed, function.
1231 (ospf_write_frags) fragmented write support, moved from previous.
1233 2004-09-23 Hasso Tepper <hasso at quagga.net>
1235 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1237 2004-09-12 Paul Jakma <paul@dishone.st>
1239 * ospf_packet.c: Fix bugzilla #107
1240 (ospf_packet_max) get rid of the magic 88 constant
1241 (ospf_swab_iph_ton) new function. set ip header to network order,
1242 taking BSDisms into account.
1243 (ospf_swab_iph_toh) the inverse.
1244 (ospf_write) Add support for IP fragmentation, will only work on
1245 linux though, other kernels make it impossible. get rid of the
1247 (ospf_make_ls_upd) Bound check to end of stream, not to
1249 (ospf_ls_upd_packet_new) New function, allocate upd packet
1250 taking oversized LSAs into account.
1251 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1252 rather than statically allocating mtu sized packet buffer, which
1253 actually was wrong - it didnt take ip header into account, which
1254 should not be included in packet buffer.
1255 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1258 2004-08-31 David Wiggins <dwiggins@bbn.com>
1260 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1261 print statements. New function ospf_vertex_dump used in debugging.
1263 2004-08-31 David Wiggins <dwiggins@bbn.com>
1265 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1267 2004-08-31 David Wiggins <dwiggins@bbn.com>
1269 * ospf_route.c: When finding an alternate route, log cost as well.
1271 2004-08-31 David Wiggins <dwiggins@bbn.com>
1273 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1274 struct prefix allocated on stack.
1276 2004-08-31 David Wiggins <dwiggins@bbn.com>
1278 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1279 acks to AllSPFRouters, rather than All-DR.
1281 2004-08-27 Hasso Tepper <hasso at quagga.net>
1283 * ospf_vty.c: Don't print ospf network type under interface only
1284 if interface is in broadcast mode and interface type really is
1285 broadcast. Fixes Bugzilla #108.
1287 2004-08-27 David Wiggins <dwiggins@bbn.com>
1289 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1290 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1293 2004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1295 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
1296 buffer used to get interface index so that it compiles on other
1297 than Linux and includes the required alignment space. Probably
1298 this was only working on sparc/sparc64 because most of
1299 sockaddr_dl was not being written.
1301 2004-08-19 Paul Jakma <paul@dishone.st>
1303 * ospf_packet.c: update to match sockopt renames.
1305 2004-08-04 Paul Jakma <paul@dishone.st>
1307 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1308 Compare only against list head - all nexthops must be same cost
1309 anyway, fixes a reference-listnode-after-delete bug noted by
1311 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1312 candidates attached to root.
1314 2004-07-27 Paul Jakma <paul@dishone.st>
1316 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1317 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1318 ospf_ls_upd_queue_send() - guaranteed segfault.
1320 2004-07-27 Paul Jakma <paul@dishone.st>
1322 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1323 the LSA as then free_opaque_info_per_id() can never unlock (and
1324 free) the LSA. Reported by Gunnar Stigen.
1326 2004-07-23 Paul Jakma <paul@dishone.st>
1328 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1330 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1331 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1333 2004-07-14 Paul Jakma <paul@dishone.st>
1335 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1336 problem reported by Peter Frost amongst others, where function
1337 will spin indefinitely if update list contains LSAs greater than
1338 MTU-headers or other condition leading to update list never being
1339 cleared. Problem of what to do with these LSAs remains.
1340 (ospf_make_ls_upd) add comment about large LSA problem,
1341 indentation cleanup.
1343 2004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1345 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1347 2004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1349 * Makefile.am: Add shlib support.
1351 2004-06-10 Hasso Tepper <hasso@estpak.ee>
1353 * *: Removed ifdefs HAVE_NSSA.
1355 2004-06-06 Paul Jakma <paul@dishone.st>
1357 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1358 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1360 2004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1362 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1363 index is out of range.
1364 ospf_flood.c: endianness fix
1365 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1368 2004-05-10 Hasso Tepper <hasso@estpak.ee>
1370 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1371 to ospf_zebra.c from ospfd.c and add redistribution updates if
1372 route-map is used in redistribution.
1373 * ospf_main.c: Remove now useless call to ospf_init().
1375 2004-05-08 Paul Jakma <paul@dishone.st>
1377 * ospf_zebra.c: Sync with lib/zclient changes
1379 2004-05-05 Paul Jakma <paul@dishone.st>
1381 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1382 defined. Warn at compile and runtime. Use
1383 IPTOS_PREC_INTERNETCONTROL otherwise.
1384 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1385 some of the checks up to ospf_read, return either a
1386 virtual link oi, or NULL.
1387 (ospf_read) Cleanup, make it responsible for checks. Remove
1388 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1389 lookups to use new wrappers exported by ospf_neighbor.
1390 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1391 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1392 neighbour table by router-id for virtual-link ospf_interfaces,
1393 not by peer_addr (which breaks for asymmetric vlinks)
1394 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1396 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1397 address for either end of a virtual-link, and hence potential cost
1400 2004-04-22 Hasso Tepper <hasso@estpak.ee>
1402 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1403 to "summarize" routes in ASBR at the moment.
1405 2004-04-20 Hasso Tepper <hasso@estpak.ee>
1407 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1408 Fixes UNH OSPF_NSSA.1.2a comment.
1409 * ospf_abr.c: Originate default into stub/nssa area even if
1410 summaries are disabled.
1411 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1413 2004-04-19 Hasso Tepper <hasso@estpak.ee>
1415 * ospf_vty.c: Don't warn that export- and import-list can't be
1416 configured to backbone area if they are applied and are working
1419 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1421 * ospf_packet.c: Don't drop packets in Solaris x86.
1424 2004-03-18 Amir Guindehi <amir@datacore.ch>
1426 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1427 Quagga's ospfd in the special situation that a node's opaque
1428 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1430 2004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1432 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1433 should be configured with the highest cost path within the range,
1436 2004-02-17 Paul Jakma <paul@dishone.st>
1438 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1439 params, nor the interface structure, if an interface delete
1440 message is received from zebra.
1441 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1442 params and interface, ie that which was previously removed in
1443 (ospf_interface_delete) above.
1445 2004-02-11 Hasso Tepper <hasso@estpak.ee>
1446 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1447 if oi doesn't exist any more.
1449 2004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1450 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1451 LSA if it was originated with older router-id ([zebra 14710] #6).
1453 2003-12-08 Mattias Amnefelt <mattiasa@kth.se>
1455 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1458 2003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1460 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1461 while trying not to change semantics. Add ifdefed-out code to
1462 avoid matching ppp interfaces whose destination address does not
1463 also match the prefix under consideration, to help out people with
1464 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1467 2003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1469 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1470 node in body of the loop to avoid chance that route node
1471 is unlocked and deleted before the next iteration tries to
1472 get next route node.
1474 2003-05-24 Kenji Yabuuchi
1476 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1477 match for interface lookup.
1479 2003-05-18 Hasso Tepper <hasso@estpak.ee>
1481 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1484 2003-05-16 Hasso Tepper <hasso@estpak.ee>
1486 * ospf_lsa.c: Fix handling of NSSA
1488 2003-04-23 Hasso Tepper <hasso@estpak.ee>
1490 * ospf_vty.c: fix "router xxx" node commands in vtysh
1492 2003-04-19 Hasso Tepper <hasso@estpak.ee>
1494 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1495 * ospf_routemap.c: sync daemon's route-map commands to have same
1498 2003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1500 * ospf_packet.c: Add missing param to zlog
1501 * ospf_flood.c: remove unused vars
1503 2003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1505 * ospf_interface.c: fix incorrect memset
1507 2003-04-10 Amir Guindehi <amir@datacore.ch>
1509 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1511 2003-04-03 David Watson <dwatson@eecs.umich.edu>
1513 * ospf_lsa.c: byte order fix
1515 2002-03-17 Amir Guindehi <amir@datacore.ch>
1517 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1518 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1519 * ospfclient: OSPFAPI demonstration client.
1521 2003-01-23 Masahiko Endo <endo@suri.co.jp>
1523 * ospf_ism.c: NSM event schedule bug fix.
1525 2002-10-30 Greg Troxel <gdt@ir.bbn.com>
1527 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1529 2002-10-23 endo@suri.co.jp (Masahiko Endo)
1531 * ospf_opaque.c: Update Opaque LSA patch.
1533 2002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1535 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1537 2002-10-23 Juris Kalnins <juris@mt.lv>
1539 * ospf_interface.c (ospf_if_stream_unset): When write queue
1540 becomes empty stop write timer.
1542 2002-10-10 Greg Troxel <gdt@ir.bbn.com>
1544 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1547 2002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1549 * zebra-0.93 released.
1551 2002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1553 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1554 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1555 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1556 Paul Jakma <paulj@alphyra.ie>.
1558 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1561 2002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1563 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1565 2001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1567 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1568 OSPF interface information.
1569 (ospf_delete_from_if): Likewise.
1571 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1573 2001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1575 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1576 is OSPF, do not unset redistribute flag.
1578 2001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1580 * zebra-0.92a released.
1582 2001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1584 * zebra-0.92 released.
1586 2001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1588 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1589 configuration display.
1591 2001-07-24 David Watson <dwatson@eecs.umich.edu>
1593 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1594 check for an existing link before connecting the parent and child.
1595 ospf_nexthop_calculation is also modified to check for duplicate
1596 entries when copying from the parent. Finally, ospf_spf_next
1597 removes duplicates when it merges two equal cost candidates.
1599 2001-07-23 itojun@iijlab.net
1601 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1604 2001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1606 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1609 2001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1611 * ospf_zebra.c (config_write_ospf_default_metric): Display
1612 default-metric configuration.
1614 2001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1616 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
1618 2001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1620 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
1622 (ospfIfMetricEntry): Likewise.
1624 2001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1626 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
1627 Lin'Kova" <jen@stack.net>.
1629 2001-03-15 Gleb Natapov <gleb@nbase.co.il>
1631 * ospf_interface.c (ip_ospf_network): Set interface parameter.
1632 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
1634 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
1636 2001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1638 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
1639 (iph.ip_hl << 2) to iph.ip_len.
1641 2001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1643 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
1644 Suggested by: David Watson <dwatson@eecs.umich.edu>.
1646 * ospf_zebra.c (zebra_init): Remove zebra node.
1648 * ospfd.c (ospf_area_range_set): Function name is changed from
1650 (ospf_area_range_unset): New function which separated from DEFUN.
1651 New commands are added:
1652 "no area A.B.C.D range A.B.C.D/M advertise"
1653 "no area <0-4294967295> range A.B.C.D/M advertise"
1654 "no area A.B.C.D range A.B.C.D/M not-advertise"
1655 "no area <0-4294967295> range A.B.C.D/M not-advertise"
1657 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
1659 2001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
1661 * ospf_network.c (ospf_if_add_allspfrouters): Use
1662 setsockopt_multicast_ipv4.
1663 (ospf_if_drop_allspfrouters): Likewise.
1665 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
1666 (ospf_network_lsa_install): Likewise.
1667 (ospf_summary_lsa_install): Likewise.
1668 (ospf_summary_asbr_lsa_install): Likewise.
1669 (ospf_external_lsa_install): Likewise.
1670 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
1673 2001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1675 * ospf_zebra.c (ospf_interface_delete): Do not free interface
1676 structure when ospfd receive interface delete message to support
1679 2001-02-01 Dick Glasspool <dick@ipinfusion.com>
1681 * ospfd.c (area_range_notadvertise): Change area range "suppress"
1682 command to "not-advertise".
1684 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
1687 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
1688 updating the area-range, the lowest cost is now saved.
1690 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
1691 numbers rather than creating overflow during calculation.
1693 2001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1695 * zebra-0.91 is released.
1697 2001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
1699 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
1700 NSM_SeqNumberMismatch is scheduled.
1701 (ospf_ls_req): Free ls_upd when return from this function.
1702 (ospf_ls_upd_timer): When update list is empty do not call
1703 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
1706 2001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1708 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
1709 MaxAge. RFC2328 Section 14.
1710 (ospf_maxage_lsa_remover): Call above function during removing
1713 2001-01-26 Dick Glasspool <dick@ipinfusion.com>
1715 * ospf_flood.c (ospf_flood_through_as): Function is updated for
1716 NSSA Translations now done at ospf_abr.c with no change in P-bit.
1718 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
1720 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
1722 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
1724 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
1726 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
1728 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
1731 * ospfd.c (data_injection): Function to inject LSA. This is
1734 2001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1736 * ospf_route.c (ospf_route_match_same): Remove function.
1737 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
1739 * ospf_zebra.c (ospf_interface_address_delete): Add check for
1740 oi->address. Suggested by Matthew Grant
1741 <grantma@anathoth.gen.nz>.
1742 (ospf_zebra_add): Remove function.
1743 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
1745 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
1747 * ospf_zebra.c: Likewise.
1749 2001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1751 * ospf_ase.c: Remove OLD_RIB part.
1753 * ospf_route.c: Likewise.
1755 * zebra-0.90 is released.
1757 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
1760 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1762 * ospf_route.c (ospf_route_delete): Use
1763 ospf_zebra_delete_multipath.
1765 2001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
1767 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
1768 from ospf_if_free(). Rewrite whole procudure to support primary
1771 * ospf_zebra.c (ospf_interface_address_delete): Add primary
1772 address deletion process.
1774 2001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1776 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
1777 treatment like FreeBSD.
1779 2001-01-09 endo@suri.co.jp (Masahiko Endo)
1781 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
1782 strips IP header size from receiving IP Packet. So we adjust
1783 ip_len to whole IP packet size by adding IP header size.
1785 2001-01-08 endo@suri.co.jp (Masahiko Endo)
1787 * ospf_network.c (ospf_serv_sock): When socket() is failed return
1789 (ospf_serv_sock): Close socket when it is not used.
1791 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
1793 (ospf_write): When bind is fined, close sock.
1795 2001-01-07 Gleb Natapov <gleb@nbase.co.il>
1797 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
1798 appears when you try to configure bandwidth on the ppp interface
1799 that is not yet configured in ospfd.
1801 2001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1803 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
1804 will print nexthops for AS-external routes.
1806 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
1807 ASE route under multipath environment.
1808 (ospf_ase_compare_tables): Likewise.
1810 2001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1812 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
1814 2000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1816 * ospf_route.c (ospf_route_install): Install multipath information
1819 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
1820 multipath information to zebra daemon.
1822 2000-12-25 Dick Glasspool <dick@ipinfusion.com>
1824 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
1826 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
1829 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
1830 leave Type-7 LSA at Lock Count = 2.
1832 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
1833 NSSA no P-bit off during Area flooding, but P-bit is turned off
1834 for mulitple NSSA AS flooding.
1836 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
1839 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
1840 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
1843 2000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1845 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
1846 found LSA and if the LSA is MAXAGE we should call refresh instead
1849 2000-12-18 Dick Glasspool <dick@ipinfusion.com>
1851 * ospf_abr.c: Removed redundant "...flood" in
1852 announce_network_to_area(). Repaired nssa Unlock by using
1855 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
1857 * ospfd.c: Free up all data bases including NSSA.
1859 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
1860 discard_callback. Added routine to get ip addr from within the
1863 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
1865 * ospf_lsa.h: Added prototype for the below. struct in_addr
1866 ospf_get_ip_from_ifp (struct interface *ifp).
1868 2000-12-14 Gleb Natapov <gleb@nbase.co.il>
1870 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
1871 Now maximum packet length may be 65535 bytes (maximum IP packet
1874 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
1876 * ospfd.c (config_write_network_area): Remove unnecessary area
1879 2000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
1881 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
1883 2000-12-13 Gleb Natapov <gleb@nbase.co.il>
1885 * ospfd.c (config_write_network_area): Fix bug in
1886 config_write_network_area function.
1888 2000-12-12 Gleb Natapov <gleb@nbase.co.il>
1890 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
1891 LSA's origination and refreshment as same as other type of LSA.
1893 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
1895 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
1897 2000-12-08 Dick Glasspool <dick@ipinfusion.com>
1899 The bulk of NSSA changes are contained herein; This version will
1900 require manual setting of "always" for NSSA Translator, and will
1901 not perform aggregation yet.
1903 * ospf_dump.c: "debug ospf nssa" is added.
1905 * ospf_dump.h: Likewise.
1907 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
1909 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
1910 'never, candidate, always'. Change "suppress" to "not-advertise".
1912 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
1915 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
1918 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
1921 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
1922 NSSA translator, then do it. Approve the global list, and flush
1925 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
1926 Type-5 resulted from a Local Type-7 translation; not used for
1927 flooding, but used for flushing.
1929 * ospf_flood.c: New NSSA flooding.
1931 2000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1933 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
1935 (ospf_vl_set_security): Virtual link configuration with
1937 (ospf_vl_set_timers): Set timers for virtual link.
1939 * New commands are added.
1940 "area A.B.C.D virtual-link A.B.C.D"
1941 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
1942 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
1943 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
1944 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
1945 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
1947 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
1948 cryptographic sequence number treatment.
1949 (ospf_check_auth): OSPF input buffer is added to argument.
1950 (ospf_read): Save neighbor's cryptographic sequence number.
1952 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
1953 number when neighbor status is changed to NSM down.
1955 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
1957 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
1958 sequence number to neighbor structure.
1960 2000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1962 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
1963 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
1965 2000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
1967 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
1969 (ospf_ls_upd_queue_empty): New function to empty ls update queue
1970 of the OSPF interface.
1971 (no_router_ospf): 'no router ospf' unregister redistribution
1972 requests from zebra.
1974 2000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1976 * ospf_ism.c (ism_change_status): Increment status change number.
1978 * ospf_interface.h (struct ospf_interface): Add new member for
1979 status change statistics.
1981 * Makefile.am: Update dependencies.
1983 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
1984 (ospf_interface_delete): OSPF SNMP interface delete.
1986 * ospf_snmp.h: New file is added.
1988 2000-11-23 Dick Glasspool <dick@ipinfusion.com>
1990 * ospfd.h: Add new ospf_area structure member for
1991 NSSATranslatorRole and NSSATranslator state.
1993 * ospfd.c: Provided for eventual commands to specify NSSA
1994 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
1995 decimal integer version of area-suppress.
1997 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
1999 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2000 translator, advertise Nt bit.
2002 * ospf_route.c: 1st version of "sh ip os border-routers".
2004 2000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2006 * ospfd.c (area_vlink): Virtual link can not configured in stub
2009 2000-11-23 Gleb Natapov <gleb@nbase.co.il>
2011 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2012 slave must resend its last Database Description packet in response
2013 to duplicate Database Description packets received from the
2014 master. For this reason the slave must wait RouterDeadInterval
2015 seconds before freeing the last Database Description packet.
2016 Reception of a Database Description packet from the master after
2017 this interval will generate a SeqNumberMismatch neighbor
2018 event. RFC2328 Section 10.8
2019 (ospf_make_db_desc): DD Master flag treatment.
2021 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2022 nsm_change_status().
2023 (nsm_bad_ls_req): Likewise.
2024 (nsm_adj_ok): Likewise.
2025 (nsm_seq_number_mismatch): Likewise.
2026 (nsm_oneway_received): Likewise.
2028 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2029 last_send_ts for timestemp when last Database Description packet
2032 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2033 there. Call ospf_db_desc_resend() in any case.
2035 2000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2037 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2038 network (suppose you have only one router with interface priority
2039 0). It's router LSA does not contain the link information about
2042 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2043 interface from/to 0 ISM_NeighborChange event should be scheduled
2044 in order to elect new DR/BDR on the network.
2046 * ospf_interface.c (ip_ospf_priority): Likewise.
2048 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2049 retransmit list we need to check whether the present old LSA in
2050 retransmit list is not more recent than the new
2053 2000-11-09 Dick Glasspool <dick@ipinfusion.com>
2055 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2056 area. Any that exit the NSSA area are translated to type-5 LSA's.
2057 The instantiated image is restored after translation.
2058 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2059 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2061 (ospf_ls_ack_send): Likewise.
2063 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2064 local area. Otherwise they are allowed out the area to be
2065 translated by ospf_packet.c.
2067 * ospf_lsa.c: Undo some previous changes for NSSA.
2069 * ospf_lsdb.h: New access for type 7.
2071 2000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2073 * ospf_route.c (ospf_path_exist): New function to check nexthop
2074 and interface are in current OSPF path or not.
2075 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2076 when it is not there. Reported by Michael Rozhavsky
2077 <mrozhavsky@opticalaccess.com>
2079 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2081 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2082 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2085 2000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2087 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2089 2000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2091 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2094 2000-11-06 Dick Glasspool <dick@ipinfusion.com>
2096 * ospfd.h: Add ait_ntoa function prototype.
2098 * ospfd.c (ait_ntoa): New function for displaying area ID and
2100 (show_ip_ospf_interface_sub): Use ait_ntoa.
2101 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2102 (show_ip_ospf_neighbor_detail_sub): Likewise.
2104 * ospf_route.c (ospf_intra_route_add): Set external routing type
2106 (ospf_intra_add_router): Likewise.
2107 (ospf_intra_add_transit): Likewise.
2108 (ospf_intra_add_stub): Likewise.
2109 (ospf_add_discard_route): Likewise.
2110 (show_ip_ospf_route_network): Use ait_ntoa.
2111 (show_ip_ospf_route_network): Likewise.
2112 (show_ip_ospf_route_router): Likewise.
2114 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2115 (show_lsa_detail_adv_router): Likewise.
2116 (show_ip_ospf_database_summary): Likewise.
2118 * ospf_route.h (struct route_standard): Add new member
2121 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2123 (ospf_update_network_route): Likewise.
2124 (ospf_update_router_route): Likewise.
2126 2000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2128 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2129 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2131 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2133 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2134 Please specify "debug ospf event" for enable logging.
2136 * ospf_ism.c: Do not extern debug flag varible. It is done by
2138 * ospf_asbr.c: Likewise.
2139 * ospf_lsa.c: Likewise.
2140 * ospf_nsm.c: Likewise.
2141 * ospf_zebra.c: Likewise.
2143 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2146 * ospfd.c (router_ospf): Change logging from vty_out() to
2148 (ospf_area_stub_cmd): Likewise.
2150 * ospf_dump.h: Extern term_debug flags.
2151 (OSPF_DEBUG_EVENT): Add new flag.
2152 (IS_DEBUG_OSPF_EVENT): Add new macro.
2154 2000-11-03 Dick Glasspool <dick@ipinfusion.com>
2156 * ospf_flood.c (ospf_process_self_originated_lsa):
2157 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2158 (ospf_flood): Type-5's have no change. Type-7's can be received,
2159 and will Flood the AS as Type-5's They will also flood the local
2160 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2161 during re-fresh will be converted back to Type-7's (if within an
2163 (ospf_flood_through): Incoming Type-7's were allowed here if our
2164 neighbor was an NSSA. So Flood our area with the Type-7 and also
2165 if we are an ABR, flood thru AS as Type-5.
2167 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2168 area and other area.
2170 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2171 exists in DD packet, make it sure that this area is not stub.
2172 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2174 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2175 then discard the lsa. If the LSA is NSSA LSA and the area is not
2176 NSSA then discard the lsa.
2178 2000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2180 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2181 is not properly set when interface comes up.
2183 2000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2185 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2187 2000-11-01 Dick Glasspool <dick@ipinfusion.com>
2189 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2190 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2192 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2195 2000-10-31 Dick Glasspool <dick@ipinfusion.com>
2197 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2199 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2200 function is added. ALIASES which have "show ip ospf database
2201 nssa-external" is added.
2202 (show_ip_ospf_border_routers): New command "show ip ospf
2203 border-routers" is added.
2205 2000-10-30 Dick Glasspool <dick@ipinfusion.com>
2207 * ospfd.c (router_ospf): NSSA Enabled message is added for
2209 (ospf_area_type_set): Are type set for NSSA area.
2210 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2211 and summary information. If NSSA is enabled pass the information
2212 to ospf_area_type_set().
2213 (area_nssa): New commands are added:
2215 "area <0-4294967295> nssa"
2216 "area A.B.C.D nssa no-summary"
2217 "area <0-4294967295> nssa no-summary"
2218 (ospf_no_area_stub_cmd): Special translation of no_summary into
2219 NSSA and summary information. If external_routing is
2220 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2222 (show_ip_ospf_area): Display NSSA status.
2223 (config_write_ospf_area): Show NSSA configuration.
2225 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2228 2000-10-26 Gleb Natapov <gleb@nbase.co.il>
2230 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2231 those routers that are fully adjacent to the Designated Router;
2232 each fully adjacent router is identified by its OSPF Router ID.
2233 The Designated Router includes itself in this list. RFC2328,
2236 2000-10-23 Jochen Friedrich <jochen@scram.de>
2238 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2239 it is registered. So those variables must be static.
2241 2000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2243 * ospfd.c: Add area_default_cost_decimal_cmd and
2244 no_area_default_cost_decimal_cmd alias.
2246 2000-10-05 Gleb Natapov <gleb@nbase.co.il>
2248 * ospfd.c (ospf_network_new): Fix setting area format.
2249 (no_router_ospf): Check area existance when calling
2250 ospf_interface_down().
2252 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2255 2000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2257 * zebra-0.89 is released.
2259 2000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2261 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2263 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2266 2000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2268 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2270 2000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2272 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2275 2000-09-25 Toshiaki Takada <takada@zebra.org>
2277 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2278 Add CISCO compatible command.
2280 2000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2282 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2283 area range lookup in OSPF-MIB.
2284 (ospf_area_range_lookup_next): Likewise.
2286 2000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2288 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2291 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2292 EXTERNAL_INFO(type).
2294 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2295 ospf_vl_data_free().
2297 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2298 when ospf_vl_shutdown is called.
2299 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2302 2000-09-21 Gleb Natapov <gleb@nbase.co.il>
2304 * ospf_lsa.c: New implementation of OSPF refresh.
2306 2000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2308 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2310 2000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2312 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2314 2000-09-18 Gleb Natapov <gleb@nbase.co.il>
2316 * ospf_route.h (route_standard): Change member from `struct area'
2319 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2320 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2321 (ospf_abr_process_router_rt):
2322 * ospf_ase.c (ospf_find_asbr_route),
2323 (ospf_find_asbr_router_through_area),
2324 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2325 (process_summary_lsa), (ospf_update_network_route),
2326 (ospf_update_router_route):
2327 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2328 (ospf_intra_add_transit), (ospf_intra_add_stub),
2329 (ospf_route_table_dump), (show_ip_ospf_route_network),
2330 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2331 (ospf_prune_unreachable_routers):
2332 * ospf_spf.c (ospf_rtrs_print):
2333 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2335 2000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2337 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2340 2000-09-13 Gleb Natapov <gleb@nbase.co.il>
2342 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2344 * ospf_network.c (ospf_serv_sock_init): Add socket option
2345 SO_BINDTODEVICE on read socket.
2347 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2350 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2351 (ospf_area_add_if): New function added.
2353 2000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2355 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2358 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2359 starting SPF calculation.
2361 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2363 2000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2365 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2368 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2369 lsa_originate_count.
2370 (ospf_network_lsa_originate): Likewise.
2371 (ospf_summary_lsa_originate): Likewise.
2372 (ospf_summary_asbr_lsa_originate): Likewise.
2373 (ospf_external_lsa_originate): Likewise.
2375 2000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2377 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2378 syntax is IpAddress.
2379 (ospf_admin_stat): New function for OSPF administrative status
2382 2000-09-10 Jochen Friedrich <jochen@scram.de>
2384 * ospf_snmp.c: Implement OSPF MIB skeleton.
2386 2000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2388 * ospf_snmp.c: New file is added.
2390 2000-09-07 David Lipovkov <davidl@nbase.co.il>
2392 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2395 * ospf_interface.c (interface_config_write): Likewise.
2397 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2399 * zebra-0.88 is released.
2401 2000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2403 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2404 when Area is removed.
2406 2000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2408 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2409 (ZEBRA_ROUTE_CONNECT).
2410 (no_network_area): Likewise.
2412 2000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2414 * ospfd.h (struct ospf): Add distance_table and
2415 distance_{all,intra,inter,external}.
2417 * ospf_zebra.c: Add OSPF distance related functions.
2419 2000-08-15 Gleb Natapov <gleb@nbase.co.il>
2421 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2423 * ospf_lsa.c (ospf_default_external_info),
2424 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2428 (ospf_default_information_originate_metric_type_routemap),
2429 (ospf_default_information_originate_always_metric_type_routemap):
2430 Change name and add route-map function.
2431 (ospf_default_information_originate_metric_routemap),
2432 (ospf_default_information_originate_routemap),
2433 (ospf_default_information_originate_type_metric_routemap):
2436 2000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2438 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2439 restore size from two octet to four.
2441 2000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2443 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2444 AS-external-LSA in 16.6 of RFC2328.
2446 2000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2448 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2449 calculation algorithm.
2451 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2453 2000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2455 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2458 2000-08-10 Toshiaki Takada <takada@zebra.org>
2460 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2461 `auto-cost reference-bandwidth' OSPF router command added.
2463 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2465 * ospf_routemap.c (ospf_route_map_update): New function added.
2466 Add route-map event hook.
2468 2000-08-08 Toshiaki Takada <takada@zebra.org>
2470 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2471 prefix is connected route on OSPF enabled interface, suppress to
2474 2000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2476 * ospf_interface.c (ospf_if_get_output_cost):
2477 New function added. Handle bandwidth parameter for cost
2480 2000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2482 * ospf_interface.c (interface_config_write): Show interface
2483 configuration regardless interface is down.
2485 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2486 route calculate function.
2488 2000-08-08 Gleb Natapov <gleb@nbase.co.il>
2490 * ospf_routemap.c: New file added.
2492 * ospf_asbr.c (ospf_reset_route_map_set_values),
2493 (ospf_route_map_set_compare): New function added.
2495 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2496 with AS-external-LSA.
2498 2000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2500 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2501 ospf_zebra_add as metric.
2502 (ospf_ase_calculate_route_add): Likewise.
2504 * ospf_route.c (ospf_route_install): Pass or->cost to
2505 ospf_zebra_add as metric.
2507 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2508 (ospf_zebra_delete): Likewise.
2510 2000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2512 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2513 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2516 2000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2518 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2521 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2522 Point-to-Point interface.
2524 2000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2526 * ospf_flood.c (ospf_process_self_originated_lsa):
2527 Make sure to clear LSA->param (redistributed external information)
2530 2000-07-27 Gleb Natapov <gleb@nbase.co.il>
2532 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2533 (refresh_age_diff): New defun added. Refresher related parameter
2534 can be configurable.
2536 2000-07-27 Akihiro Mizutani <mizutani@dml.com>
2538 * ospf_interface.c (interface_config_write): Print `description'
2539 config directive to work.
2541 2000-07-24 Akihiro Mizutani <mizutani@dml.com>
2543 * ospf_interface.c (ospf_if_init): Use install_default for
2546 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
2548 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2549 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2550 This make sending always as many LS update/Ack combined in one ospf
2553 2000-07-24 Gleb Natapov <gleb@nbase.co.il>
2555 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2556 LSA is AS-external-LSA.
2558 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2560 2000-07-21 Toshiaki Takada <takada@zebra.org>
2562 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2563 `default-information originate'. Fix some default originate
2566 2000-07-12 Toshiaki Takada <takada@zebra.org>
2568 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2570 2000-07-12 Toshiaki Takada <takada@zebra.org>
2572 * ospf_lsa.c (show_ip_ospf_database_router),
2573 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2574 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2575 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2576 (show_any_lsa_self): Functions removed.
2578 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2579 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2580 New functions added. Replace above functions.
2582 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2584 (show_ip_ospf_database_summary): New functions added. Replace
2587 (show_ip_ospf_database_cmd): DEFUN rearranged.
2588 (show_ip_ospf_database_type_id_cmd),
2589 (show_ip_ospf_database_type_id_adv_router_cmd),
2590 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2591 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2592 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2594 2000-07-11 Toshiaki Takada <takada@zebra.org>
2596 * ospf_asbr.c (ospf_external_info_new),
2597 (ospf_external_info_free): New functions added.
2599 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2600 origination parameter for external-LSA.
2601 Remove member `redistribute'.
2603 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2604 command executed, metric and metric-type values are overridden.
2605 If one of those is changed refresh AS-external-LSAs for appropriate
2608 2000-07-11 Michael Rozhavsky <mike@nbase.co.il>
2610 * ospf_lsa.c (ospf_summary_lsa_refresh),
2611 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
2613 * ospf_abr.c (set_metric): New function added.
2615 2000-07-07 Toshiaki Takada <takada@zebra.org>
2617 * ospf_zebra.c (ospf_default_information_originate_metric_type),
2618 (ospf_default_information_originate_type_metric): New defun added.
2619 Metic and Metric type can be set to default route.
2620 (ospf_default_information_originate_always_metric_type):
2621 (ospf_default_information_originate_always_type_metric):
2622 New defun added. Metric and Metric type can be set to default
2625 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
2628 2000-07-06 Gleb Natapov <gleb@nbase.co.il>
2630 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
2631 on the same interface the LSA was received from.
2633 2000-07-06 Michael Rozhavsky <mike@nbase.co.il>
2635 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
2636 command with `write mem'.
2638 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
2640 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
2641 zebra interface delete event.
2643 2000-07-06 Toshiaki Takada <takada@zebra.org>
2645 * ospf_zebra.c (ospf_default_information_originate),
2646 (ospf_default_information_originate_always): New DEFUN added.
2648 2000-07-05 Michael Rozhavsky <mike@nbase.co.il>
2650 * ospf_route.c (ospf_terminate): Make sure to remove external route
2651 when SIGINT received.
2653 2000-07-03 Gleb Natapov <gleb@nbase.co.il>
2655 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
2656 many structure with `no router ospf'.
2658 2000-06-30 Gleb Natapov <gleb@nbase.co.il>
2660 * ospf_neighbor.c (ospf_nbr_new),
2661 ospf_nsm.c (nsm_timer_set): Start LS update timer only
2662 when neighbor enters Exchange state.
2664 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
2666 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
2667 ospf_packet.c (ospf_db_desc_proc):
2668 Do not cancel DD retransmit timer when Master.
2670 2000-06-29 Gleb Natapov <gleb@nbase.co.il>
2672 * ospf_abr.c (ospf_abr_announce_network_to_area),
2673 (ospf_abr_announce_rtr_to_area)
2674 ospf_ase.c (ospf_ase_rtrs_register_lsa),
2675 ospf_flood.c (ospf_process_self_originated_lsa),
2676 (ospf_flood_through_area), (ospf_ls_request_delete),
2677 ospf_interface.c (ospf_if_free),
2678 ospf_ism.c (ism_change_status),
2679 ospf_lsa.c (ospf_router_lsa_update_timer),
2680 (ospf_router_lsa_install), (ospf_network_lsa_install),
2681 (ospf_lsa_maxage_delete), (ospf_lsa_action),
2682 (ospf_schedule_lsa_flood_area),
2683 ospf_nsm.c (nsm_change_status),
2684 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
2685 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
2687 * ospf_flood.c (ospf_ls_request_free): Function deleted.
2689 * ospf_lsa.c (ospf_discard_from_db): New function added.
2691 2000-06-26 Toshiaki Takada <takada@zebra.org>
2693 * ospfd.h (ospf): struct member `external_lsa' name changed to
2696 2000-06-26 Toshiaki Takada <takada@zebra.org>
2698 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
2699 (ospf_network_lsa_install), (ospf_summary_lsa_install),
2700 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
2701 Functions re-arranged.
2703 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
2705 2000-06-20 Michael Rozhavsky <mike@nbase.co.il>
2707 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
2708 verification of LS type.
2710 2000-06-20 Gleb Natapov <gleb@nbase.co.il>
2712 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
2713 whether rn->info is NULL.
2715 2000-06-20 Toshiaki Takada <takada@zebra.org>
2717 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
2718 DR and Backup correctly with `show ip ospf interface' command.
2720 2000-06-20 Toshiaki Takada <takada@zebra.org>
2722 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
2723 (ospf_lsa_discard): These functions are used for avoiding
2724 unexpected reference to freed LSAs.
2726 2000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2728 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
2731 2000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2733 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
2735 2000-06-12 Toshiaki Takada <takada@zebra.org>
2737 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
2738 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
2741 2000-06-10 Toshiaki Takada <takada@zebra.org>
2743 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
2744 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
2745 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
2746 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
2747 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
2748 removed for migration to new_lsdb.
2750 * ospf_lsa.c (ospf_summary_lsa_install),
2751 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
2752 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
2753 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
2754 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
2755 (ospf_get_free_id_for_prefix): Funcitions removed.
2757 2000-06-09 Gleb Natapov <gleb@nbase.co.il>
2759 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
2761 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
2762 (ospf_hello): Always copy router-ID when hello is received.
2764 2000-06-08 Gleb Natapov <gleb@nbase.co.il>
2766 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
2769 2000-06-08 Michael Rozhavsky <mike@nbase.co.il>
2771 * ospf_ase.c (ospf_asbr_route_same): New function added.
2772 This function makes sure external route calculation more
2775 2000-06-07 Michael Rozhavsky <mike@nbase.co.il>
2777 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
2778 network-LSA deletion instead of using ospf_lsdb_delete.
2779 Also cancel network-LSA origination timer.
2781 2000-06-07 Levi Harper <lharper@kennedytech.com>
2783 * ospf_interface.c (ospf_if_down): Close read fd when an interface
2786 2000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2788 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
2789 avoid ambiguous else.
2791 * ospf_flood.c (ospf_external_info_check): Likewise.
2793 2000-06-05 Toshiaki Takada <takada@zebra.org>
2795 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
2797 2000-06-04 Toshiaki Takada <takada@zebra.org>
2799 * ospf_zebra.c (ospf_default_information_originate),
2800 (no_ospf_default_information_originate): New DEFUN added.
2802 2000-06-03 Toshiaki Takada <takada@zebra.org>
2804 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
2805 ospf_lsa.h to ospf_asbr.h.
2807 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
2808 (ospf_external_info_delete): Function moved from ospf_lsa.c
2811 2000-06-03 Toshiaki Takada <takada@zebra.org>
2813 * ospf_flood.c (ospf_external_info_check): New function added.
2814 (ospf_process_self_orignated_lsa): Make sure to flush
2815 self-originated AS-external-LSA, when router reboot and no longer
2816 originate those AS-external-LSA.
2818 2000-06-02 Toshiaki Takada <takada@zebra.org>
2820 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
2823 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
2824 unicast destination packets.
2826 2000-06-02 Toshiaki Takada <takada@zebra.org>
2828 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
2829 specified LSA matches.
2831 2000-06-02 Gleb Natapov <gleb@nbase.co.il>
2833 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
2836 2000-06-01 Akihiro Mizutani <mizutani@dml.com>
2838 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
2839 Replace string `OSPF information\n' with OSPF_STR.
2841 2000-06-01 Toshiaki Takada <takada@zebra.org>
2843 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
2846 2000-06-01 Toshiaki Takada <takada@zebra.org>
2848 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
2849 (config_debug_ospf_ism), (config_debug_ospf_nsm),
2850 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
2851 (term_debug_ospf_packet), (term_debug_ospf_event),
2852 (term_debug_ospf_ism), (term_debug_ospf_nsm),
2853 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
2854 variable to use for debug option flags.
2856 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
2857 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
2858 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
2861 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
2862 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
2863 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
2864 (IS_CONF_DEBUG_OSPF): New Macro added.
2866 2000-05-31 Toshiaki Takada <takada@zebra.org>
2868 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
2869 Currently this command is used for only debugging.
2871 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
2872 for network-LSA when DR has no full neighbors.
2874 * ospf_nsm.c (ospf_db_summary_clear): New function added.
2876 2000-05-30 Toshiaki Takada <takada@zebra.org>
2878 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
2879 maxage_lsa_remover when LSA is replaced.
2881 2000-05-25 Gleb Natapov <gleb@nbase.co.il>
2883 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
2884 `struct ospf_area' to remove LSA from Link State retransmission list
2885 of neighbor from only one Area.
2887 2000-05-24 Michael Rozhavsky <mike@nbase.co.il>
2889 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
2890 overriting old LSA with new LSA.
2892 2000-05-24 Gleb Natapov <gleb@nbase.co.il>
2894 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
2897 2000-05-22 Michael Rozhavsky <mike@nbase.co.il>
2899 * ospf_route.c (ospf_intra_add_stub):
2900 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
2901 value instead of u_int16_t.
2903 2000-05-22 Axel Gerlach <agerlach@datus.datus.com>
2905 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
2906 equal cost path calculation.
2908 2000-05-21 Toshiaki Takada <takada@zebra.org>
2910 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
2911 Make sure, when rotuer route is deleted, related external routes
2914 2000-05-20 Toshiaki Takada <takada@zebra.org>
2916 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
2919 2000-05-16 Toshiaki Takada <takada@zebra.org>
2921 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
2924 * ospfd.h (EXTERNAL_INFO): Macro added.
2925 Substitute `ospf_top->external_info[type]' with it.
2927 2000-05-16 Toshiaki Takada <takada@zebra.org>
2929 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
2931 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
2933 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
2934 * ospf_lsdb.c (new_lsdb_insert)
2935 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
2937 2000-05-14 Gleb Natapov <gleb@nbase.co.il>
2939 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
2940 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
2942 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
2944 2000-05-13 Toshiaki Takada <takada@zebra.org>
2946 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
2947 time_t to struct timeval.
2948 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
2949 (tv_sub), (tv_cmp): timeval utillity functions added.
2951 2000-05-12 Toshiaki Takada <takada@zebra.org>
2953 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
2954 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
2956 router-LSA refresh timer related stuff is re-organized.
2958 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
2960 * ospf_interface.c (ospf_vl_set_params):
2961 * ospf_packet.c (ospf_check_network_mask):
2962 * ospf_spf.[ch] (ospf_spf_next):
2963 Remove field address from `struct vertex', and search for peer
2964 address of virtual link in function `ospf_vl_set_params' instead.
2966 2000-05-10 Gleb Natapov <gleb@nbase.co.il>
2968 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
2970 2000-05-08 Thomas Molkenbur <tmo@datus.com>
2972 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
2973 with ospf_stream_dup() to fix memory leak.
2975 2000-05-08 Michael Rozhavsky <mike@nbase.co.il>
2977 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
2978 LSA update without DROther.
2980 2000-05-04 Gleb Natapov <gleb@nbase.co.il>
2982 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
2984 2000-05-03 Toshiaki Takada <takada@zebra.org>
2986 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
2987 instead linked-list.
2988 (ospf_db_summary_count), (ospf_db_summary_isempty):
2991 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
2993 2000-05-02 Gleb Natapov <gleb@nbase.co.il>
2995 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
2996 not needed any more, then free them.
2998 2000-05-02 Toshiaki Takada <takada@zebra.org>
3000 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3001 SPF calculation timers related stuff is rearranged.
3003 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3004 SPF timer is scheduled by SPF calculation delay and holdtime
3005 configuration variable.
3007 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3008 forwarding address when nexthop learned by other protocols is
3011 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3012 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3015 2000-05-01 Toshiaki Takada <takada@zebra.org>
3017 * ospf_flood.c (ospf_ls_retransmit_count),
3018 (ospf_ls_retransmit_isempty): New function added.
3020 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3021 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3022 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3023 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3026 2000-04-29 Toshiaki Takada <takada@zebra.org>
3028 * ospfd.c (no_network_area): Add check Area-ID whether specified
3029 Area-ID with prefix matches config.
3031 2000-04-27 Toshiaki Takada <takada@zebra.org>
3033 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3034 remaining withdrawn routes on zebra.
3036 2000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3038 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3039 (ospf_nsm_event): Fix network-LSA re-origination problem.
3041 2000-04-24 Toshiaki Takada <takada@zebra.org>
3043 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3044 with DD retransmission.
3046 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3047 a neighbor disappears.
3049 2000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3051 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3052 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3053 flag to new LSA. when summary-LSA is reoriginatd.
3055 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3056 procedure. Change the condition of interface selection.
3058 2000-04-21 Toshiaki Takada <takada@zebra.org>
3060 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3063 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3064 `show ip ospf neighbor' related commands are re-arranged.
3066 2000-04-20 Toshiaki Takada <takada@zebra.org>
3068 * ospf_dump.c (debug_ospf_zebra): New defun added.
3069 Suppress zebra related debug information.
3071 2000-04-19 Toshiaki Takada <takada@zebra.org>
3073 * ospf_zebra.c (ospf_distribute_list_update_timer),
3074 (ospf_distribute_list_update), (ospf_filter_update):
3075 New function added. Re-organize `distribute-list' router ospf
3078 2000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3080 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3082 2000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3084 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3085 interface transmit_delay.
3087 2000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3089 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3090 Add to schedule router_lsa origination when the interface cost changes.
3092 2000-04-12 Toshiaki Takada <takada@zebra.org>
3094 * ospf_lsa.c (ospf_refresher_register_lsa),
3095 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3097 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3099 2000-03-29 Toshiaki Takada <takada@zebra.org>
3101 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3103 2000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3105 * ospf_lsa.c (ospf_network_lsa):
3106 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3109 2000-03-28 Toshiaki Takada <takada@zebra.org>
3111 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3112 (nsm_oneway_received): Fix bug of NSM state flapping between
3113 ExStart and Exchange.
3115 2000-03-28 Toshiaki Takada <takada@zebra.org>
3117 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3118 change u_int8_t to u_char.
3120 2000-03-27 Toshiaki Takada <takada@zebra.org>
3122 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3124 2000-03-27 Toshiaki Takada <takada@zebra.org>
3126 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3128 2000-03-26 Love <lha@s3.kth.se>
3130 * ospf_packet.c (ospf_write): Chack result of sendto().
3132 2000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3134 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3136 2000-03-23 Libor Pechacek <farco@clnet.cz>
3138 * ospf_lsa.c (ospf_network_lsa)
3139 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3142 2000-03-23 Toshiaki Takada <takada@zebra.org>
3144 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3145 `area A.B.C.D authentication'.
3147 2000-03-22 Toshiaki Takada <takada@zebra.org>
3149 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3150 Suppress all zlog related to LSAs with this config option.
3152 2000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3154 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3156 2000-03-21 Toshiaki Takada <takada@zebra.org>
3158 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3159 Fix bug of memory leak about linklist.
3161 * ospf_flood.c (ospf_flood_through_area): Likewise.
3163 2000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3165 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3166 to identify LSA uniquely. This fix routes lost.
3168 2000-03-18 Toshiaki Takada <takada@zebra.org>
3170 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3173 2000-03-17 Alex Zinin <zinin@amt.ru>
3175 * ospf_spf.[ch]: Bug fix.
3176 The 2nd stage of Dijkstra could consider one vertex
3177 more than once if there is more than one link
3178 between the routers, thus adding extra CPU overhead
3179 and extra next-hops.
3182 2000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3184 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3186 2000-03-14 Toshiaki Takada <takada@zebra.org>
3188 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3189 ospf_path. Actually ignore merging ospf_route with completely same
3192 2000-03-12 Toshiaki Takada <takada@zebra.org>
3194 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3195 external route tag byte order.
3197 2000-03-11 Toshiaki Takada <takada@zebra.org>
3199 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3201 2000-03-09 Toshiaki Takada <takada@zebra.org>
3203 * ospf_lsa.c (ospf_external_lsa_install),
3204 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3205 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3206 LSDB of AS-external-LSAs instead of ospf_lsdb.
3208 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3209 Use for assigning Unique Link State ID instead of
3210 ospf_get_free_id_for_prefix().
3212 2000-03-09 Toshiaki Takada <takada@zebra.org>
3214 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3215 fault reported by George Bonser <george@siteROCK.com>.
3217 2000-03-07 Libor Pechacek <farco@clnet.cz>
3219 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3221 2000-03-06 Toshiaki Takada <takada@zebra.org>
3223 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3225 2000-03-02 Alex Zinin <zinin@amt.ru>
3226 * ospfd.h, ospf_ia.h
3227 New Shortcut ABR code. Now area's flag can be configured
3228 with Default, Enable, and Disable values.
3229 More info will be in the new ver of I-D soon (see IETF web).
3231 2000-02-25 Toshiaki Takada <takada@zebra.org>
3233 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3234 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3235 (ospf_external_lsa_originate_from_queue): New function added.
3236 (ospf_external_lsa): Function removed.
3238 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3239 when listen a route from Zebra, instead creating external route.
3241 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3242 (ospf_asbr_route_add_queue_lsa),
3243 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3246 * ospf_ase.c (process_ase_lsa): Function will not be used.
3247 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3248 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3249 process_ase_lsa () is separated to these functions.
3251 OSPF AS-external-LSA origination is whole re-organized.
3253 2000-02-18 Toshiaki Takada <takada@zebra.org>
3255 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3257 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3258 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3261 2000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3263 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3264 checksum after change Advertised Router field.
3266 2000-02-09 Toshiaki Takada <takada@zebra.org>
3268 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3270 2000-02-08 Toshiaki Takada <takada@zebra.org>
3272 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3273 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3274 Router ID is chosen from all of eligible interface addresses even if
3275 it is not enable to OSPF.
3277 2000-02-08 Toshiaki Takada <takada@zebra.org>
3279 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3280 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3281 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3282 waited to install to LSDB.
3283 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3285 2000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3287 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3288 in the ACK before deleting.
3290 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3291 and no shutdown of the interface.
3293 2000-01-31 Toshiaki Takada <takada@zebra.org>
3295 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3296 packets respond to a Link State Request packet.
3298 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3300 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3301 is not configured and set virtual-link to no-backbone area,
3304 2000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3306 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3309 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3310 treatment. That should be done in OSPF flooding procedure.
3312 * ospf_flood.c (ospf_flood_through_area): Enclose
3313 ospf_check_nbr_loding inside if-else close.
3315 2000-01-31 Toshiaki Takada <takada@zebra.org>
3317 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3319 2000-01-29 Toshiaki Takada <takada@zebra.org>
3321 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3323 2000-01-28 Toshiaki Takada <takada@zebra.org>
3325 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3327 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3329 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3330 removing LSA from nbr->db_summary.
3332 2000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3334 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3335 destination when the link is point-to-point.
3336 (ospf_ls_ack_send_delayed): Likewise.
3338 2000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3340 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3341 pointer lookup after the node is freed.
3343 2000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3345 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3346 external route, use ospf_top->external_self.
3348 2000-01-27 Toshiaki Takada <takada@zebra.org>
3350 * ospf_lsa.c (ospf_forward_address_get): New function added.
3352 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3353 only when it should be replaced.
3355 2000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3357 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3359 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3362 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3363 change. Self originated LSA is freed but not deleted from lsdb.
3365 2000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3367 * ospf_ism.c (ism_interface_down): Don't use router_id for
3368 detecting self neighbor structure. Instead of that compare
3371 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3373 (ospf_nbr_free): Free last send packet.
3375 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3376 Instead of that src is introduced.
3378 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3380 2000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3382 * ospfd.c: Change part of passive interface implementation. For
3383 passive interface just disabling sending/receiving Hello on the
3386 2000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3388 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3389 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3390 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3391 * ospfd.c (passive_interface): New command passive-interface is
3393 (ospf_config_write): Print passive interface.
3395 2000-01-15 Toshiaki Takada <takada@zebra.org>
3397 * ospf_interface.h (crypt_key): New struct added to store
3398 multiple cryptographic autheitication keys.
3399 (ospf_interface): struct changed.
3401 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3402 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3404 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3405 multiple cryptographic authentication keys.
3407 2000-01-14 Toshiaki Takada <takada@zebra.org>
3409 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3411 Old notation `ospf *' still remains backward compatibility.
3413 1999-12-29 Alex Zinin <zinin@amt.ru>
3414 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3415 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3416 int goes down, also check DD flags correctly (bug fix)
3418 1999-12-28 Alex Zinin <zinin@amt.ru>
3419 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3421 1999-12-23 Alex Zinin <zinin@amt.ru>
3422 * added RFC1583Compatibility flag
3423 * added dynamic interface up/down functionality
3425 1999-11-19 Toshiaki Takada <takada@zebra.org>
3427 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3428 for NSM state change statistics.
3430 1999-11-19 Toshiaki Takada <takada@zebra.org>
3432 * ospfd.c (show_ip_ospf_neighbor_detail),
3433 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3435 1999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3437 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3440 1999-11-11 Toshiaki Takada <takada@zebra.org>
3442 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3443 This macro is expanded to ospf_examine_summaries ()
3444 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3445 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3446 This macro is expanded to ospf_examine_transit_summaries ()
3447 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3449 1999-11-11 Toshiaki Takada <takada@zebra.org>
3451 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3452 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3453 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3454 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3455 (ospf_find_self_external_lsa_by_prefix): Changed to
3456 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3458 1999-11-11 Toshiaki Takada <takada@zebra.org>
3460 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3461 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3463 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3464 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3467 1999-11-10 Toshiaki Takada <takada@zebra.org>
3469 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3470 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3472 1999-11-01 Alex Zinin <zinin@amt.ru>
3474 some correction to LSU processing
3476 * ospf_lsa.c ospfd.h
3477 randomize initial LSA refreshment interval
3478 and limit the size of LSA-group to 10
3479 to let randomization work more effectively.
3481 1999-10-31 Alex Zinin <zinin@amt.ru>
3483 cancel t_network_lsa_self
3484 when freeing int structure
3486 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3487 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3489 Summary and ASE LSA refreshment functions
3490 added---LSA refreshment is paced to 70 LSAs
3491 per sec to avoid link overflow. Refreshment events
3492 are further randomized within a 10 sec interval
3495 Also the sigfault of memcmp() in ospf_lsa_is_different()
3498 1999-10-30 Alex Zinin <zinin@amt.ru>
3500 Fix the bug where MAX_AGE LSAs
3501 are included into the DB summary.
3504 allocate 2*MTU input buffer instead of just MTU
3505 for the cases when the other router mistakenly
3506 sends larger packets thus causing fragmentation, etc.
3509 in nsm_reset_nbr() lists should be freed
3510 not when they are empty.
3512 1999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3514 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3515 check inside of if (ospf_top).
3517 1999-10-29 Alex Zinin <zinin@amt.ru>
3518 * ospf_lsa.c ospf_lsdb.c :
3519 add assertion in lsa and lsa->data alloc functions,
3520 as well as in lsdb_add for new->data
3522 * ospf_lsdb.c: free hash table correctly
3524 1999-10-28 John Capo <jc@irbs.com>
3526 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3529 1999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3531 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3533 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3535 1999-10-27 Alex Zinin <zinin@amt.ru>
3536 * ospfd, ospf_zebra, ospf_abr
3537 "area import-list" command is added.
3538 This command allows to filter the inter-area routes
3539 injected into an area. Access list hook function
3540 extended to invalidate area exp/imp lists.
3542 1999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3544 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3545 on an OSPF interface.
3547 1999-10-19 Jordan Mendelson <jordy@wserv.com>
3549 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3550 in ospf_ls_retransmit_lookup ().
3552 1999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3554 * ospf_route.c: Workaround about installation of OSPF routes into
3555 the zebra daemon. Add checking of existance routes. Free
3556 ospf_top->old_table if it exists.
3558 1999-10-15 Jordan Mendelson <jordy@wserv.com>
3560 * Add support for MD5 authentication.
3562 1999-10-12 Alex Zinin <zinin@amt.ru>
3563 * ospfd.c, ospfd.h, ospf_abr.c:
3564 a new command "area export-list" was added, it allows
3565 the admin. to control which intra-area routes are
3566 announced to other areas by the ABR
3568 1999-10-12 Alex Zinin <zinin@amt.ru>
3569 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3570 when "no redistribute" is used after a distribute list
3571 denying some networks was used
3573 1999-10-05 Toshiaki Takada <takada@zebra.org>
3575 * ospf_route.c (ospf_path_dup): New function added.
3577 1999-10-05 Toshiaki Takada <takada@zebra.org>
3579 * ospf_interface.[ch]: Some of VL related funciton name changed.
3581 1999-09-27 Alex Zinin <zinin@amt.ru>
3583 * ospf_zebra.c: Distribute-list functionality added
3585 1999-09-27 Toshiaki Takada <takada@zebra.org>
3587 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3590 1999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3592 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3593 instead of node->next. Reported by Hiroki Ishibashi
3594 <ishibasi@dcd.abk.nec.co.jp>.
3596 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3599 1999-09-23 Alex Zinin <zinin@amt.ru>
3601 * stub area support added
3603 1999-09-23 Alex Zinin <zinin@amt.ru>
3605 * fwd_addr in ASE-LSAs is now set correctly
3606 * ASE routing changed to check the fwd_addr
3607 and skip the route if the addr points to one
3608 of our interfaces to avoid loops.
3610 1999-09-22 Alex Zinin <zinin@amt.ru>
3613 ospf_vls_in_area() added, it returns
3614 the number of VLs configured through the area
3616 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
3617 honor correct mem alloc
3619 1999-09-22 Alex Zinin <zinin@amt.ru>
3622 Some OSPF mem types added,
3623 plus more info in "show mem"
3625 1999-09-21 Alex Zinin <zinin@amt.ru>
3628 "area range substitute" added.
3629 It can be used on NAT-enabled (IP-masquarade)
3630 routers to announce private networks
3631 from an area as public ones into the outside
3632 world (not in the RFC, btw :)
3634 1999-09-21 Alex Zinin <zinin@amt.ru>
3637 "area range suppress" added.
3638 This command allows to instruct the router
3639 to be silent about specific ranges, i.e.,
3640 it is a method of route filtering on area
3643 1999-09-21 Alex Zinin <zinin@amt.ru>
3645 * ospfd.c VLs removed when "no network area" executed
3647 1999-09-20 Alex Zinin <zinin@amt.ru>
3649 * ospf_ase.c bug fix for not-zero fwd_addr
3650 and directly connected routes.
3652 1999-09-20 Yon Uriarte <yon@plannet.de>
3654 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
3655 checking the length of OSPF packet exceeds MTU or not.
3657 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
3660 1999-09-18 Alex Zinin <zinin@amt.ru>
3662 * ospf_lsa.c bug fix for ospf_network_lsa() to
3663 include itself into the RID list
3665 1999-09-10 Alex Zinin <zinin@amt.ru>
3667 * Alternative ABR behaviors IBM/Cisco/Shortcut
3670 1999-09-10 Alex Zinin <zinin@amt.ru>
3672 * router and network-LSA origination
3673 changed to honor MinLSInterval
3675 1999-09-08 Alex Zinin <zinin@amt.ru>
3677 * modified ABR behavior to honor VLs and transit
3680 1999-09-07 Alex Zinin <zinin@amt.ru>
3682 * completed VL functionality
3684 1999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3686 * ospf_asbr.c: New file.
3687 ospf_asbr.h: New file.
3689 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
3692 1999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3694 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
3695 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
3697 1999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3699 * ospf_spf.c (ospf_spf_register): Change name from
3700 ospf_spf_route_add() to ospf_spf_register().
3701 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
3703 1999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3705 * ospf_lsa.c (ospf_external_lsa_install): Change to update
3706 lsa->data rather than install new one, when same id lsa is already
3709 1999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3711 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
3712 (ospf_network_lsa_install): Likewise.
3713 (ospf_summary_lsa_install): Likewise.
3714 (ospf_summary_asbr_lsa_install): Likewise.
3715 (ospf_external_lsa_install): Likewise.
3717 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
3720 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
3722 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
3725 1999-08-31 Toshiaki Takada <takada@zebra.org>
3727 * ospf_lsa.c (show_ip_ospf_database_summary),
3728 (show_ip_ospf_database_summary_asbr),
3729 (show_ip_ospf_database_external): New function added.
3730 `show ip ospf database summary',
3731 `show ip ospf database asbr-summary'
3732 `show ip ospf database external' command can be used.
3734 * ospf_lsa.c (ospf_lsa_count_table): New function added.
3735 (show_ip_ospf_database_all): show nothing if a type of LSA
3738 1999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
3740 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
3741 the node is deleted.
3743 1999-08-31 Toshiaki Takada <takada@zebra.org>
3745 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
3747 (ospf_ls_request_new), (ospf_ls_request_free),
3748 (ospf_ls_request_add), (ospf_ls_request_delete),
3749 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
3752 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
3754 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
3756 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
3759 1999-08-30 Alex Zinin <zinin@amt.ru>
3762 fix a bug with area range config write
3763 added "show ip ospf" command, it will be enhanced later on
3765 1999-08-30 Alex Zinin <zinin@amt.ru>
3768 updated ospf_router_lsa() to honor flags (B-bit)
3770 1999-08-30 Alex Zinin <zinin@amt.ru>
3773 wrote major functions implementing ABR activity
3775 1999-08-30 Alex Zinin <zinin@amt.ru>
3777 * ospf_ia.c ospf_route.c ospf_route.h
3778 fixed the bug with ospf_route.origin field.
3779 Now it holds pointer to lsa_header
3781 1999-08-30 Alex Zinin <zinin@amt.ru>
3783 * ospf_flood.c ospf_flood.h:
3784 transformed ospf_flood_if_select into ospf_flood_through_area()
3785 added new ospf_flood_if_select() and ospf_flood_through_as()
3787 1999-08-30 Toshiaki Takada <takada@zebra.org>
3789 * ospf_flood.[ch]: New file added.
3791 * ospf_packet.c (ospf_lsa_flooding),
3792 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
3794 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
3795 (ospf_remove_lsa_from_retransm_list),
3796 (ospf_nbr_remove_all_lsas_from_retransm_list),
3797 (ospf_lsa_remove_from_ls_retransmit):
3798 (ospf_lsa_retransmit): functions move to
3799 ospf_flood.c, and change function's name:
3801 ospf_put_lsa_on_retransm_list ()
3802 -> ospf_ls_retransmit_add ()
3803 ospf_remove_lsa_from_retransm_list ()
3804 -> ospf_ls_retransmit_delete ()
3805 ospf_nbr_remove_all_lsas_from_retransm_list ()
3806 -> ospf_ls_retransmit_clear ()
3807 ospf_lsa_remove_from_ls_retransmit ()
3808 -> ospf_ls_retransmit_delete_nbr_all ()
3809 ospf_lsa_retransmit ()
3810 -> ospf_ls_retransmit_add_nbr_all ()
3812 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
3813 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
3815 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3817 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
3818 route_node_lookup() instead of route_node_get().
3820 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
3822 1999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3824 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
3827 1999-08-29 Alex Zinin <zinin@amt.ru>
3829 MaxAge LSA deletion functions added.
3831 1999-08-29 Alex Zinin <zinin@amt.ru>
3833 ospf_nbr_lookup_by_addr(): added route_unlock_node()
3834 when function returns NULL if (rn->info == NULL)
3836 1999-08-29 Alex Zinin <zinin@amt.ru>
3838 added a hack for area range deletion
3840 1999-08-29 Alex Zinin <zinin@amt.ru>
3842 included lsdb field into struct ospf_lsa, to find
3843 LSDB easier when removing MaxAge LSAs.
3845 1999-08-29 Alex Zinin <zinin@amt.ru>
3846 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
3847 ospf_packet.c changed to honor new retransmit list
3848 management functions
3850 1999-08-29 Alex Zinin <zinin@amt.ru>
3851 * ospf_neighbor.c , .h added new retransmit list functions.
3853 1999-08-29 Alex Zinin <zinin@amt.ru>
3855 added ospf_ase, ospf_abr, ospf_ia
3857 1999-08-29 Alex Zinin <zinin@amt.ru>
3859 - changed ospf_next_hop_calculation() to include interface
3860 and nexthop addr for directly connected routers---more informative
3861 and solves problem with route installation into the kernel
3862 - changed ospf_nexthop_out_if_addr() to support routers, not only
3864 - added ospf_process_stubs();
3866 1999-08-29 Alex Zinin <zinin@amt.ru>
3868 - changed ospf_router_lsa() to provide correct links
3869 for p-t-p interfaces;
3870 - changed ospf_summary_lsa_install() to support table
3871 of self-originated summary-LSAs;
3872 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
3873 - changed ospf_lsa_install() accordingly
3874 - changed show_ip_ospf_database_router_links() to support p-t-p
3876 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3878 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
3881 1999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3883 * ospf_packet.c (ospf_read): Add check of IP src address.
3885 1999-08-28 Alex Zinin <zinin@amt.ru>
3887 added ospf_nbr_lookup_by_routerid()
3889 1999-08-28 Alex Zinin <zinin@amt.ru>
3891 added ABR/ASBR flag definitions and fields;
3892 added iflist field to area structure;
3893 summary_lsa_self and summary_lsa_asbr_self are changed
3895 added ranges field---configured area ranges;
3896 A separate Routers RT added;
3897 area range config commands and config write added
3900 1999-08-28 Alex Zinin <zinin@amt.ru>
3902 ospf_route_free()--added code to free the list of paths;
3903 The following functions added:
3904 ospf_intra_add_router();
3905 ospf_intra_add_transit();
3906 ospf_intra_add_stub();
3907 the last function uses new ospf_int_lookup_by_prefix();
3908 show_ip_ospf_route_cmd()--changed to support new RT structure;
3909 added ospf_cmp_routes()--general route comparision function;
3910 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
3911 they are used in ASE and IA routing;
3912 added ospf_subst_route() and ospf_add_route();
3914 1999-08-28 Alex Zinin <zinin@amt.ru>
3916 changed struct ospf_path to include output interface,
3917 changed struct ospf_route to support IA and ASE routing.
3918 added prototypes of the function used in IA and ASE modules.
3920 1999-08-28 Alex Zinin <zinin@amt.ru>
3921 * ospf_lsa.h ospf_lsa.c :
3922 added ospf_my_lsa(), an interface independent version of
3923 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
3925 1999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3927 * ospf_interface.c (interface_config_write): Add check for
3930 1999-08-25 Toshiaki Takada <takada@zebra.org>
3932 * ospf_lsa.c (ospf_lsa_dup): New function added.
3934 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
3935 interface in debug message.
3937 1999-08-25 Toshiaki Takada <takada@zebra.org>
3939 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
3941 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
3942 Delayed Link State Acknowledgment is scheduled by timer.
3944 1999-08-25 Alex Zinin <zinin@amt.ru>
3946 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
3947 a stub network instead of link to a transit network into
3948 originated router-LSA, bug fixed.
3950 1999-08-24 Toshiaki Takada <takada@zebra.org>
3952 * ospfd.c (ospf_update_router_id): New function added.
3954 * ospf_network.c (ospf_write): Create new socket per transmission.
3955 And select outgoing interface whether dst is unicast or multicast.
3957 * ospf_packet.c: LSA flooding will work.
3959 1999-08-24 VOP <vop@unity.net>
3961 * ospf_route.c: Include "sockunion.h"
3963 1999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3965 * ospf_network.c (ospf_serv_sock_init): Enclose
3966 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
3967 not have the definition.
3969 1999-08-23 Toshiaki Takada <takada@zebra.org>
3971 * ospf_packet.c: Fix bug of DD processing.
3973 1999-08-18 Toshiaki Takada <takada@zebra.org>
3975 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
3977 1999-08-17 Toshiaki Takada <takada@zebra.org>
3979 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
3980 corrected. The bug of `mes_lookup' is fixed.
3981 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
3983 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
3984 `ospf_add_router_lsa'.
3985 (ospf_network_lsa_install): The name is changed from
3986 `ospf_add_network_lsa'.
3988 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
3990 * ospf_interface.c (ospf_if_is_enable): New function added.
3992 1999-08-16 Toshiaki Takada <takada@zebra.org>
3994 * ospf_lsa.h (struct lsa_header): The name is changed from
3996 (struct ospf_lsa): New struct added to control each LSA's aging
3999 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4001 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4002 (ospf_lsa_different), (ospf_lsa_install): New function added.
4004 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4006 1999-08-12 Toshiaki Takada <takada@zebra.org>
4008 * ospf_nsm.c (nsm_reset_nbr): New function added.
4009 KillNbr and LLDown neighbor event call this function.
4011 1999-08-10 Toshiaki Takada <takada@zebra.org>
4013 * ospf_packet.c (ospf_ls_retransmit)
4014 (ospf_ls_upd_timer): New function added.
4015 Set retransmission timer for Link State Update.
4017 1999-07-29 Toshiaki Takada <takada@zebra.org>
4019 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4021 1999-07-28 Toshiaki Takada <takada@zebra.org>
4023 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4024 with IPTOS_PREC_INTERNET_CONTROL.
4026 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4027 if NSM status change.
4029 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4030 Hello packet, when the neighbor goes down.
4032 1999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4034 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4036 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4039 1999-07-25 Toshiaki Takada <takada@zebra.org>
4041 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4044 1999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4046 * ospf_route.c (ospf_route_table_free): New function added.
4048 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4051 * ospfd.h (struct ospf): Add old_table.
4053 * ospf_main.c (sighup): Call of log_rotate () removed.
4055 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4056 area->lsa as self LSA. This should be area->lsa_self.
4058 1999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4060 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4061 (),ospf_zebra_delete () added.
4063 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4065 1999-07-24 Toshiaki Takada <takada@zebra.org>
4067 * ospf_lsa.c: Change LS sequence number treatment.
4068 (ospf_lsa_is_self_originated): New function added.
4069 (show_ip_ospf_database_self_originated): New DEFUN added.
4071 1999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4073 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4075 1999-07-22 Toshiaki Takada <takada@zebra.org>
4077 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4078 (ospf_nexthop_dup): function added.
4079 (ospf_nexthop_calculation): function changed.
4081 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4083 1999-07-21 Toshiaki Takada <takada@zebra.org>
4085 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4087 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4089 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4091 1999-07-21 Toshiaki Takada <takada@zebra.org>
4093 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4095 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4098 1999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4100 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4101 change behavior according to LSA type.
4102 (ospf_lsa_has_link): Link check function is added.
4104 1999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4106 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4107 SPF calcultion schedule addtition.
4108 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4110 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4112 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4113 header typo correction. Display of router LSA's #link added.
4115 1999-07-19 Toshiaki Takada <takada@zebra.org>
4117 * ospf_packet.c (ospf_check_network_mask): Added new function for
4118 receiving Raw IP packet on an appropriate interface.
4120 1999-07-16 Toshiaki Takada <takada@zebra.org>
4122 * ospfd.c (ospf_router_id): new DEFUN added.
4124 1999-07-15 Toshiaki Takada <takada@zebra.org>
4126 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4127 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4128 (ospf_spf_next_router), (ospf_spf_next_network),
4129 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4132 1999-07-13 Toshiaki Takada <takada@zebra.org>
4134 * ospf_ism.c: fix bug of DR Election.
4136 * ospf_nsm.c: fix bug of adjacency forming.
4138 1999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4140 * ospfd.c (ospf_init): Change to use install_default.
4142 1999-07-01 Rick Payne <rickp@rossfell.co.uk>
4144 * ospf_zebra.c (zebra_init): Install standard commands to
4147 1999-06-30 Toshiaki Takada <takada@zebra.org>
4149 * ospf_dump.c: Whole debug command is improved.
4150 (ISM|NSM) (events|status|timers) debug option added.
4151 (show_debugging_ospf): new DEFUN added.
4153 1999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4155 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4158 1999-06-29 Toshiaki Takada <takada@zebra.org>
4160 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4161 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4163 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4165 * ospf_ism.c (ospf_dr_election): fix DR Election.
4167 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4170 1999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4172 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4174 1999-06-28 Toshiaki Takada <takada@zebra.org>
4176 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4177 `show ip ospf database network' command output.
4179 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4180 Retransmission, Database Summary and Link State Request.
4182 * ospf_packet.c (ospf_ls_req_timer): New function added.
4183 Set Link State Request retransmission timer.
4185 1999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4187 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4190 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4191 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4193 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4194 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4196 1999-06-25 Toshiaki Takada <takada@zebra.org>
4198 * ospf_packet.c: fix bug of DD making.
4199 fix bug of LS-Update reading.
4201 1999-06-23 Toshiaki Takada <takada@zebra.org>
4203 * ospf_packet.c: All type of packets are changed to use
4204 fifo queue structure.
4205 (ospf_fill_header) function added.
4207 1999-06-22 Toshiaki Takada <takada@zebra.org>
4209 * ospf_packet.c (ospf_packet_new): New function added to handle
4210 sending ospf packet by fifo queue structure.
4211 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4212 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4213 (ospf_fifo_free): Likewise.
4215 1999-06-21 Toshiaki Takada <takada@zebra.org>
4217 * ospf_nsm.c (ospf_db_desc_timer): function added.
4218 (nsm_timer_set) function added.
4219 * ospf_dump.c (ospf_option_dump): function added.
4220 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4222 1999-06-20 Toshiaki Takada <takada@zebra.org>
4224 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4225 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4228 1999-06-19 Toshiaki Takada <takada@zebra.org>
4230 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4231 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4232 (if_ospf_hello_interval), (if_ospf_priority),
4233 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4234 argument changed from NUMBER to <range>.
4235 DEFUN (if_ospf_network_broadcast),
4236 DEFUN (if_ospf_network_non_broadcast),
4237 DEFUN (if_ospf_network_point_to_multipoint),
4238 DEFUN (if_ospf_network_point_to_point) functions are combined to
4239 DEFUN (if_ospf_network).
4241 1999-06-18 Toshiaki Takada <takada@zebra.org>
4243 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4244 ospf_lsa_lookup (), ospf_lsa_count () Added.
4246 1999-06-15 Toshiaki Takada <takada@zebra.org>
4248 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4249 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4250 `debug ospf ism' command shows debug message.
4251 `debuf ospf nsm' command shows debug message.
4253 1999-06-14 Toshiaki Takada <takada@zebra.org>
4255 * ospf_lsa.c: ospf_network_lsa () Added.
4256 ospf_lsa_checksum () Added.
4257 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4258 `debug ospf packet' command shows debug message.
4260 1999-06-13 Toshiaki Takada <takada@zebra.org>
4262 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4265 1999-06-11 Toshiaki Takada <takada@zebra.org>
4267 * ospf_dump.c: fix IP packet length treatment.
4269 1999-06-10 Toshiaki Takada <takada@zebra.org>
4271 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4272 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4274 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4275 ospf_make_hello (), ospf_make_db_desc () Added.
4276 ospf_db_desc_proc () Added.n
4278 * Database Description packet can be processed.
4280 1999-06-08 Toshiaki Takada <takada@zebra.org>
4282 * ospf_lsa.c: New file.
4284 1999-06-07 Toshiaki Takada <takada@zebra.org>
4286 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4288 1999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4290 * ospf_spf.[ch]: New file.
4292 1999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4294 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4296 * ospf_zebra.h (zebra_start): Remove struct zebra.
4298 1999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4300 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4301 ntohl for sprintf warning.
4303 1999-05-19 Toshiaki Takada <takada@zebra.org>
4305 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4306 if interface state changes to DR or BDR.
4308 1999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4310 * ospf_main.c (signal_init): SIGTERM call sigint.
4311 (sigint): Logging more better message.
4313 1999-05-12 Toshiaki Takada <takada@zebra.org>
4315 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4317 1999-05-11 Toshiaki Takada <takada@zebra.org>
4319 * ospf_neighbor.c: ospf_nbr_free () Added.
4321 1999-05-10 Toshiaki Takada <takada@zebra.org>
4323 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4324 * Fix bug of `no network' statement, it will work.
4326 1999-05-07 Toshiaki Takada <takada@zebra.org>
4328 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4329 updated by ospf_if_update ().
4331 1999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4333 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4335 1999-04-25 Toshiaki Takada <takada@zebra.org>
4337 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4338 DEFUN (no_if_ospf_dead_interval),
4339 DEFUN (no_if_ospf_hello_interval),
4340 DEFUN (no_if_ospf_priority),
4341 DEFUN (no_if_ospf_retransmit_interval),
4342 DEFUN (no_if_ospf_transmit_delay) Added.
4344 interface_config_write () suppress showing interface
4347 1999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4349 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4351 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4352 of ospf_network { }. So `router ospf' statement in ospfd.conf
4354 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4356 1999-04-25 Toshiaki Takada <takada@zebra.org>
4358 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4359 DEFUN (if_ospf_network_broadcast),
4360 DEFUN (if_ospf_network_non_broadcast),
4361 DEFUN (if_ospf_network_point_to_multipoint),
4362 DEFUN (if_ospf_network_point_to_point),
4363 DEFUN (no_if_ospf_network) Added.
4365 1999-04-23 Toshiaki Takada <takada@zebra.org>
4367 * ospfd.h: struct area { } changed to struct ospf_network { }.
4368 Add struct ospf_area { }.
4369 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4370 and ospf_network_free ().
4371 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4373 1999-04-22 Toshiaki Takada <takada@zebra.org>
4375 * ospf_lsa.h: New file.
4376 * ospf_packet.h: LSA related struct definition are moved to
4378 * ospf_packet.c: ospf_verify_header () Added.
4380 1999-04-21 Toshiaki Takada <takada@zebra.org>
4382 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4383 DR Election bug fixed.
4384 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4385 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4387 1999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4389 * ospf_main.c (main): access_list_init () is added for vty
4390 connection filtering.
4392 1999-04-16 Toshiaki Takada <takada@zebra.org>
4394 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4395 * ospf_neighbor.c: ospf_nbr_count () Added.
4397 1999-04-15 Toshiaki Takada <takada@zebra.org>
4399 * ospfd.h: struct ospf { } Changed.
4400 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4401 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4403 1999-04-14 Toshiaki Takada <takada@zebra.org>
4405 * ospf_ism.c: ospf_elect_dr () Added.
4406 * ospf_network.c: ospf_if_ipmulticast () Added.
4408 1999-04-11 Toshiaki Takada <takada@zebra.org>
4410 * ospf_interface.c: interface_config_write (),
4411 DEFUN (if_ip_ospf_cost),
4412 DEFUN (if_ip_ospf_dead_interval),
4413 DEFUN (if_ip_ospf_hello_interval),
4414 DEFUN (if_ip_ospf_priority),
4415 DEFUN (if_ip_ospf_retransmit_interval) and
4416 DEFUN (if_ip_ospf_transmit_delay) Added.
4418 1999-04-08 Toshiaki Takada <takada@zebra.org>
4420 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4421 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4422 * ospf_nsm.c: nsm_twoway_received () Added.
4424 1999-04-02 Toshiaki Takada <takada@zebra.org>
4426 * ospf_neighbor.c: New file.
4427 * ospf_neighbor.h: New file.
4428 * ospf_nsm.c: New file.
4429 * ospf_nsm.h: New file.
4430 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4431 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4433 1999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4435 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4437 1999-03-19 Toshiaki Takada <takada@zebra.org>
4439 * ospf_packet.c: New file.
4440 * ospf_packet.h: New file.
4441 * ospf_network.c: New file.
4442 * ospf_network.h: New file.
4443 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4445 1999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4447 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4450 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4451 for install ospfd.conf.sample as owner read only file.
4453 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4455 1999-03-15 Toshiaki Takada <takada@zebra.org>
4457 * ospf_ism.c: New file.
4458 * ospf_ism.h: New file.
4459 * ospf_dump.c: New file.
4460 * ospf_dump.h: New file.
4462 * ospfd.h: Add (struct ospf), (struct config_network),
4463 (struct message) structure.
4465 * ospf_interface.c: Add ospf_if_match_network ().
4466 * ospf_interface.h (struct ospf_interface): Change struct members.
4468 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4469 DEFUN (network_area): Added.
4471 * ospfd.conf.sample: Change sample configuration.
4473 1999-03-05 Toshiaki Takada <takada@zebra.org>
4475 * ospf_interface.c: New file.
4476 * ospf_interface.h: New file.
4477 * ospf_zebra.h: New file.
4478 * ospf_zebra.c: Add interface function for zebra daemon.
4479 * ospfd.c: New file.
4481 1999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4483 * Move IPv6 codes and files to ospf6d directory.
4485 1999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4487 * syslog support added
4489 1998-12-22 Toshiaki Takada <takada@zebra.org>
4491 * ospfd.h: New file.
4492 * ospf_lsa.h: New file.
4494 1998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4496 * Makefile.am: New file.
4497 * ospf_main.c: New file.