]> git.proxmox.com Git - mirror_qemu.git/blob - qapi/qmp-dispatch.c
qga: Fix crash on non-dictionary QMP argument
[mirror_qemu.git] / qapi / qmp-dispatch.c
1 /*
2 * Core Definitions for QAPI/QMP Dispatch
3 *
4 * Copyright IBM, Corp. 2011
5 *
6 * Authors:
7 * Anthony Liguori <aliguori@us.ibm.com>
8 *
9 * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
10 * See the COPYING.LIB file in the top-level directory.
11 *
12 */
13
14 #include "qemu/osdep.h"
15 #include "qapi/error.h"
16 #include "qapi/qmp/types.h"
17 #include "qapi/qmp/dispatch.h"
18 #include "qapi/qmp/json-parser.h"
19 #include "qapi/qmp/qjson.h"
20 #include "qapi-types.h"
21 #include "qapi/qmp/qerror.h"
22
23 static QDict *qmp_dispatch_check_obj(const QObject *request, Error **errp)
24 {
25 const QDictEntry *ent;
26 const char *arg_name;
27 const QObject *arg_obj;
28 bool has_exec_key = false;
29 QDict *dict = NULL;
30
31 dict = qobject_to_qdict(request);
32 if (!dict) {
33 error_setg(errp, QERR_QMP_BAD_INPUT_OBJECT,
34 "request is not a dictionary");
35 return NULL;
36 }
37
38 for (ent = qdict_first(dict); ent;
39 ent = qdict_next(dict, ent)) {
40 arg_name = qdict_entry_key(ent);
41 arg_obj = qdict_entry_value(ent);
42
43 if (!strcmp(arg_name, "execute")) {
44 if (qobject_type(arg_obj) != QTYPE_QSTRING) {
45 error_setg(errp, QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "execute",
46 "string");
47 return NULL;
48 }
49 has_exec_key = true;
50 } else if (!strcmp(arg_name, "arguments")) {
51 if (qobject_type(arg_obj) != QTYPE_QDICT) {
52 error_setg(errp, QERR_QMP_BAD_INPUT_OBJECT_MEMBER,
53 "arguments", "object");
54 return NULL;
55 }
56 } else {
57 error_setg(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
58 return NULL;
59 }
60 }
61
62 if (!has_exec_key) {
63 error_setg(errp, QERR_QMP_BAD_INPUT_OBJECT, "execute");
64 return NULL;
65 }
66
67 return dict;
68 }
69
70 static QObject *do_qmp_dispatch(QObject *request, Error **errp)
71 {
72 Error *local_err = NULL;
73 const char *command;
74 QDict *args, *dict;
75 QmpCommand *cmd;
76 QObject *ret = NULL;
77
78 dict = qmp_dispatch_check_obj(request, errp);
79 if (!dict) {
80 return NULL;
81 }
82
83 command = qdict_get_str(dict, "execute");
84 cmd = qmp_find_command(command);
85 if (cmd == NULL) {
86 error_set(errp, ERROR_CLASS_COMMAND_NOT_FOUND,
87 "The command %s has not been found", command);
88 return NULL;
89 }
90 if (!cmd->enabled) {
91 error_setg(errp, "The command %s has been disabled for this instance",
92 command);
93 return NULL;
94 }
95
96 if (!qdict_haskey(dict, "arguments")) {
97 args = qdict_new();
98 } else {
99 args = qdict_get_qdict(dict, "arguments");
100 QINCREF(args);
101 }
102
103 cmd->fn(args, &ret, &local_err);
104 if (local_err) {
105 error_propagate(errp, local_err);
106 } else if (cmd->options & QCO_NO_SUCCESS_RESP) {
107 g_assert(!ret);
108 } else if (!ret) {
109 ret = QOBJECT(qdict_new());
110 }
111
112 QDECREF(args);
113
114 return ret;
115 }
116
117 QObject *qmp_build_error_object(Error *err)
118 {
119 return qobject_from_jsonf("{ 'class': %s, 'desc': %s }",
120 QapiErrorClass_lookup[error_get_class(err)],
121 error_get_pretty(err));
122 }
123
124 QObject *qmp_dispatch(QObject *request)
125 {
126 Error *err = NULL;
127 QObject *ret;
128 QDict *rsp;
129
130 ret = do_qmp_dispatch(request, &err);
131
132 rsp = qdict_new();
133 if (err) {
134 qdict_put_obj(rsp, "error", qmp_build_error_object(err));
135 error_free(err);
136 } else if (ret) {
137 qdict_put_obj(rsp, "return", ret);
138 } else {
139 QDECREF(rsp);
140 return NULL;
141 }
142
143 return QOBJECT(rsp);
144 }