src/tools/clippy/clippy_lints/src/deprecated_lints.rs

   1 macro_rules! declare_deprecated_lint {
   2     (pub $name: ident, $_reason: expr) => {
   3         declare_lint!(pub $name, Allow, "deprecated lint")
   4     }
   5 }
   6
   7 declare_deprecated_lint! {
   8     /// **What it does:** Nothing. This lint has been deprecated.
   9     ///
  10     /// **Deprecation reason:** This used to check for `assert!(a == b)` and recommend
  11     /// replacement with `assert_eq!(a, b)`, but this is no longer needed after RFC 2011.
  12     pub SHOULD_ASSERT_EQ,
  13     "`assert!()` will be more flexible with RFC 2011"
  14 }
  15
  16 declare_deprecated_lint! {
  17     /// **What it does:** Nothing. This lint has been deprecated.
  18     ///
  19     /// **Deprecation reason:** This used to check for `Vec::extend`, which was slower than
  20     /// `Vec::extend_from_slice`. Thanks to specialization, this is no longer true.
  21     pub EXTEND_FROM_SLICE,
  22     "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice"
  23 }
  24
  25 declare_deprecated_lint! {
  26     /// **What it does:** Nothing. This lint has been deprecated.
  27     ///
  28     /// **Deprecation reason:** `Range::step_by(0)` used to be linted since it's
  29     /// an infinite iterator, which is better expressed by `iter::repeat`,
  30     /// but the method has been removed for `Iterator::step_by` which panics
  31     /// if given a zero
  32     pub RANGE_STEP_BY_ZERO,
  33     "`iterator.step_by(0)` panics nowadays"
  34 }
  35
  36 declare_deprecated_lint! {
  37     /// **What it does:** Nothing. This lint has been deprecated.
  38     ///
  39     /// **Deprecation reason:** This used to check for `Vec::as_slice`, which was unstable with good
  40     /// stable alternatives. `Vec::as_slice` has now been stabilized.
  41     pub UNSTABLE_AS_SLICE,
  42     "`Vec::as_slice` has been stabilized in 1.7"
  43 }
  44
  45 declare_deprecated_lint! {
  46     /// **What it does:** Nothing. This lint has been deprecated.
  47     ///
  48     /// **Deprecation reason:** This used to check for `Vec::as_mut_slice`, which was unstable with good
  49     /// stable alternatives. `Vec::as_mut_slice` has now been stabilized.
  50     pub UNSTABLE_AS_MUT_SLICE,
  51     "`Vec::as_mut_slice` has been stabilized in 1.7"
  52 }
  53
  54 declare_deprecated_lint! {
  55     /// **What it does:** Nothing. This lint has been deprecated.
  56     ///
  57     /// **Deprecation reason:** This lint should never have applied to non-pointer types, as transmuting
  58     /// between non-pointer types of differing alignment is well-defined behavior (it's semantically
  59     /// equivalent to a memcpy). This lint has thus been refactored into two separate lints:
  60     /// cast_ptr_alignment and transmute_ptr_to_ptr.
  61     pub MISALIGNED_TRANSMUTE,
  62     "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr"
  63 }
  64
  65 declare_deprecated_lint! {
  66     /// **What it does:** Nothing. This lint has been deprecated.
  67     ///
  68     /// **Deprecation reason:** This lint is too subjective, not having a good reason for being in clippy.
  69     /// Additionally, compound assignment operators may be overloaded separately from their non-assigning
  70     /// counterparts, so this lint may suggest a change in behavior or the code may not compile.
  71     pub ASSIGN_OPS,
  72     "using compound assignment operators (e.g., `+=`) is harmless"
  73 }
  74
  75 declare_deprecated_lint! {
  76     /// **What it does:** Nothing. This lint has been deprecated.
  77     ///
  78     /// **Deprecation reason:** The original rule will only lint for `if let`. After
  79     /// making it support to lint `match`, naming as `if let` is not suitable for it.
  80     /// So, this lint is deprecated.
  81     pub IF_LET_REDUNDANT_PATTERN_MATCHING,
  82     "this lint has been changed to redundant_pattern_matching"
  83 }
  84
  85 declare_deprecated_lint! {
  86     /// **What it does:** Nothing. This lint has been deprecated.
  87     ///
  88     /// **Deprecation reason:** This lint used to suggest replacing `let mut vec =
  89     /// Vec::with_capacity(n); vec.set_len(n);` with `let vec = vec![0; n];`. The
  90     /// replacement has very different performance characteristics so the lint is
  91     /// deprecated.
  92     pub UNSAFE_VECTOR_INITIALIZATION,
  93     "the replacement suggested by this lint had substantially different behavior"
  94 }
  95
  96 declare_deprecated_lint! {
  97     /// **What it does:** Nothing. This lint has been deprecated.
  98     ///
  99     /// **Deprecation reason:** This lint has been superseded by #[must_use] in rustc.
 100     pub UNUSED_COLLECT,
 101     "`collect` has been marked as #[must_use] in rustc and that covers all cases of this lint"
 102 }
 103
 104 declare_deprecated_lint! {
 105     /// **What it does:** Nothing. This lint has been deprecated.
 106     ///
 107     /// **Deprecation reason:** Associated-constants are now preferred.
 108     pub REPLACE_CONSTS,
 109     "associated-constants `MIN`/`MAX` of integers are preferred to `{min,max}_value()` and module constants"
 110 }
 111
 112 declare_deprecated_lint! {
 113     /// **What it does:** Nothing. This lint has been deprecated.
 114     ///
 115     /// **Deprecation reason:** The regex! macro does not exist anymore.
 116     pub REGEX_MACRO,
 117     "the regex! macro has been removed from the regex crate in 2018"
 118 }
 119
 120 declare_deprecated_lint! {
 121     /// **What it does:** Nothing. This lint has been deprecated.
 122     ///
 123     /// **Deprecation reason:** This lint has been replaced by `manual_find_map`, a
 124     /// more specific lint.
 125     pub FIND_MAP,
 126     "this lint has been replaced by `manual_find_map`, a more specific lint"
 127 }
 128
 129 declare_deprecated_lint! {
 130     /// **What it does:** Nothing. This lint has been deprecated.
 131     ///
 132     /// **Deprecation reason:** This lint has been replaced by `manual_filter_map`, a
 133     /// more specific lint.
 134     pub FILTER_MAP,
 135     "this lint has been replaced by `manual_filter_map`, a more specific lint"
 136 }