3 #![allow(dead_code, unused)]
5 use std::collections::*;
8 struct Unrelated(Vec<u8>);
10 fn next(&self) -> std::slice::Iter<u8> {
14 fn iter(&self) -> std::slice::Iter<u8> {
20 clippy::needless_range_loop,
21 clippy::explicit_iter_loop,
22 clippy::explicit_into_iter_loop,
23 clippy::iter_next_loop,
28 clippy::shadow_unrelated,
29 clippy::unnecessary_mut_passed,
32 #[allow(clippy::many_single_char_names, unused_variables)]
34 let mut vec = vec![1, 2, 3, 4];
38 // no error, id_col does not exist outside the loop
39 let mut id_col = vec![0f64; 10];
47 let out_vec = vec![1, 2, 3];
50 for _v in &vec {} // these are fine
51 for _v in &mut vec {} // these are fine
53 for _v in &[1, 2, 3] {}
55 for _v in (&mut [1, 2, 3]).iter() {} // no error
59 for _v in [0; 33].iter() {} // no error
61 let ll: LinkedList<()> = LinkedList::new();
64 let vd: VecDeque<()> = VecDeque::new();
67 let bh: BinaryHeap<()> = BinaryHeap::new();
70 let hm: HashMap<(), ()> = HashMap::new();
73 let bt: BTreeMap<(), ()> = BTreeMap::new();
76 let hs: HashSet<()> = HashSet::new();
79 let bs: BTreeSet<()> = BTreeSet::new();
82 let u = Unrelated(vec![]);
83 for _v in u.next() {} // no error
84 for _v in u.iter() {} // no error
87 vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>();
88 let _y = vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>(); // this is fine
90 // Loop with explicit counter variable
92 // Potential false positives
183 let mut _x = &mut index;
193 println!("index: {}", index);
195 fn f<T>(_: &T, _: &T) -> bool {
198 fn g<T>(_: &mut [T], _: usize, _: usize) {
201 for i in 1..vec.len() {
202 if f(&vec[i - 1], &vec[i]) {
203 g(&mut vec, i - 1, i);
207 for mid in 1..vec.len() {
208 let (_, _) = vec.split_at(mid);
212 fn partition<T: PartialOrd + Send>(v: &mut [T]) -> usize {
213 let pivot = v.len() - 1;
216 if v[j] <= v[pivot] {
225 #[warn(clippy::needless_range_loop)]
226 pub fn manual_copy_same_destination(dst: &mut [i32], d: usize, s: usize) {
227 // Same source and destination - don't trigger lint
228 for i in 0..dst.len() {
229 dst[d + i] = dst[s + i];
235 fn new_for_index(index: usize) -> Self;
236 fn index(&self) -> usize;
239 pub fn test<H: Handle>() -> H {
241 let next_handle = H::new_for_index(x);
242 println!("{}", next_handle.index());
248 // explicit_into_iter_loop bad suggestions
249 #[warn(clippy::explicit_into_iter_loop, clippy::explicit_iter_loop)]
251 fn takes_iterator<T>(iterator: &T)
253 for<'a> &'a T: IntoIterator<Item = &'a String>,
261 impl IntoIterator for &T {
263 type IntoIter = std::vec::IntoIter<Self::Item>;
264 fn into_iter(self) -> Self::IntoIter {
274 // This case is handled by `explicit_iter_loop`. No idea why.
279 // No suggestion for this.
280 // We'd have to suggest `for _ in *rr {}` which is less clear.
281 for _ in rr.into_iter() {}
285 // explicit_into_iter_loop
286 #[warn(clippy::explicit_into_iter_loop)]
290 #[allow(clippy::should_implement_trait)]
291 pub fn into_iter<T>(self) -> I<T> {
297 impl<T> Iterator for I<T> {
299 fn next(&mut self) -> Option<Self::Item> {
305 for _ in S.into_iter::<u32>() {