]> git.proxmox.com Git - mirror_frr.git/blob - tools/frr-reload.py
Merge pull request #3880 from vivek-cumulus/evpn_advertise_rmap_fix
[mirror_frr.git] / tools / frr-reload.py
1 #!/usr/bin/python
2 # Frr Reloader
3 # Copyright (C) 2014 Cumulus Networks, Inc.
4 #
5 # This file is part of Frr.
6 #
7 # Frr is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by the
9 # Free Software Foundation; either version 2, or (at your option) any
10 # later version.
11 #
12 # Frr is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15 # General Public License for more details.
16 #
17 # You should have received a copy of the GNU General Public License
18 # along with Frr; see the file COPYING. If not, write to the Free
19 # Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
20 # 02111-1307, USA.
21 #
22 """
23 This program
24 - reads a frr configuration text file
25 - reads frr's current running configuration via "vtysh -c 'show running'"
26 - compares the two configs and determines what commands to execute to
27 synchronize frr's running configuration with the configuation in the
28 text file
29 """
30
31 from __future__ import print_function, unicode_literals
32 import argparse
33 import copy
34 import logging
35 import os
36 import random
37 import re
38 import string
39 import subprocess
40 import sys
41 from collections import OrderedDict
42 try:
43 from ipaddress import IPv6Address, ip_network
44 except ImportError:
45 from ipaddr import IPv6Address, IPNetwork
46 from pprint import pformat
47
48 try:
49 dict.iteritems
50 except AttributeError:
51 # Python 3
52 def iteritems(d):
53 return iter(d.items())
54 else:
55 # Python 2
56 def iteritems(d):
57 return d.iteritems()
58
59 log = logging.getLogger(__name__)
60
61
62 class VtyshMarkException(Exception):
63 pass
64
65
66 class Context(object):
67
68 """
69 A Context object represents a section of frr configuration such as:
70 !
71 interface swp3
72 description swp3 -> r8's swp1
73 ipv6 nd suppress-ra
74 link-detect
75 !
76
77 or a single line context object such as this:
78
79 ip forwarding
80
81 """
82
83 def __init__(self, keys, lines):
84 self.keys = keys
85 self.lines = lines
86
87 # Keep a dictionary of the lines, this is to make it easy to tell if a
88 # line exists in this Context
89 self.dlines = OrderedDict()
90
91 for ligne in lines:
92 self.dlines[ligne] = True
93
94 def add_lines(self, lines):
95 """
96 Add lines to specified context
97 """
98
99 self.lines.extend(lines)
100
101 for ligne in lines:
102 self.dlines[ligne] = True
103
104
105 class Config(object):
106
107 """
108 A frr configuration is stored in a Config object. A Config object
109 contains a dictionary of Context objects where the Context keys
110 ('router ospf' for example) are our dictionary key.
111 """
112
113 def __init__(self):
114 self.lines = []
115 self.contexts = OrderedDict()
116
117 def load_from_file(self, filename):
118 """
119 Read configuration from specified file and slurp it into internal memory
120 The internal representation has been marked appropriately by passing it
121 through vtysh with the -m parameter
122 """
123 log.info('Loading Config object from file %s', filename)
124
125 try:
126 file_output = subprocess.check_output(['/usr/bin/vtysh', '-m', '-f', filename],
127 stderr=subprocess.STDOUT)
128 except subprocess.CalledProcessError as e:
129 ve = VtyshMarkException(e)
130 ve.output = e.output
131 raise ve
132
133 for line in file_output.decode('utf-8').split('\n'):
134 line = line.strip()
135
136 # Compress duplicate whitespaces
137 line = ' '.join(line.split())
138
139 if ":" in line:
140 qv6_line = get_normalized_ipv6_line(line)
141 self.lines.append(qv6_line)
142 else:
143 self.lines.append(line)
144
145 self.load_contexts()
146
147 def load_from_show_running(self):
148 """
149 Read running configuration and slurp it into internal memory
150 The internal representation has been marked appropriately by passing it
151 through vtysh with the -m parameter
152 """
153 log.info('Loading Config object from vtysh show running')
154
155 try:
156 config_text = subprocess.check_output(
157 "/usr/bin/vtysh -c 'show run' | /usr/bin/tail -n +4 | /usr/bin/vtysh -m -f -",
158 shell=True, stderr=subprocess.STDOUT)
159 except subprocess.CalledProcessError as e:
160 ve = VtyshMarkException(e)
161 ve.output = e.output
162 raise ve
163
164 for line in config_text.decode('utf-8').split('\n'):
165 line = line.strip()
166
167 if (line == 'Building configuration...' or
168 line == 'Current configuration:' or
169 not line):
170 continue
171
172 self.lines.append(line)
173
174 self.load_contexts()
175
176 def get_lines(self):
177 """
178 Return the lines read in from the configuration
179 """
180
181 return '\n'.join(self.lines)
182
183 def get_contexts(self):
184 """
185 Return the parsed context as strings for display, log etc.
186 """
187
188 for (_, ctx) in sorted(iteritems(self.contexts)):
189 print(str(ctx) + '\n')
190
191 def save_contexts(self, key, lines):
192 """
193 Save the provided key and lines as a context
194 """
195
196 if not key:
197 return
198
199 '''
200 IP addresses specified in "network" statements, "ip prefix-lists"
201 etc. can differ in the host part of the specification the user
202 provides and what the running config displays. For example, user
203 can specify 11.1.1.1/24, and the running config displays this as
204 11.1.1.0/24. Ensure we don't do a needless operation for such
205 lines. IS-IS & OSPFv3 have no "network" support.
206 '''
207 re_key_rt = re.match(r'(ip|ipv6)\s+route\s+([A-Fa-f:.0-9/]+)(.*)$', key[0])
208 if re_key_rt:
209 addr = re_key_rt.group(2)
210 if '/' in addr:
211 try:
212 if 'ipaddress' not in sys.modules:
213 newaddr = IPNetwork(addr)
214 key[0] = '%s route %s/%s%s' % (re_key_rt.group(1),
215 newaddr.network,
216 newaddr.prefixlen,
217 re_key_rt.group(3))
218 else:
219 newaddr = ip_network(addr, strict=False)
220 key[0] = '%s route %s/%s%s' % (re_key_rt.group(1),
221 str(newaddr.network_address),
222 newaddr.prefixlen,
223 re_key_rt.group(3))
224 except ValueError:
225 pass
226
227 re_key_rt = re.match(
228 r'(ip|ipv6)\s+prefix-list(.*)(permit|deny)\s+([A-Fa-f:.0-9/]+)(.*)$',
229 key[0]
230 )
231 if re_key_rt:
232 addr = re_key_rt.group(4)
233 if '/' in addr:
234 try:
235 if 'ipaddress' not in sys.modules:
236 newaddr = '%s/%s' % (IPNetwork(addr).network,
237 IPNetwork(addr).prefixlen)
238 else:
239 network_addr = ip_network(addr, strict=False)
240 newaddr = '%s/%s' % (str(network_addr.network_address),
241 network_addr.prefixlen)
242 except ValueError:
243 newaddr = addr
244 else:
245 newaddr = addr
246
247 legestr = re_key_rt.group(5)
248 re_lege = re.search(r'(.*)le\s+(\d+)\s+ge\s+(\d+)(.*)', legestr)
249 if re_lege:
250 legestr = '%sge %s le %s%s' % (re_lege.group(1),
251 re_lege.group(3),
252 re_lege.group(2),
253 re_lege.group(4))
254 re_lege = re.search(r'(.*)ge\s+(\d+)\s+le\s+(\d+)(.*)', legestr)
255
256 if (re_lege and ((re_key_rt.group(1) == "ip" and
257 re_lege.group(3) == "32") or
258 (re_key_rt.group(1) == "ipv6" and
259 re_lege.group(3) == "128"))):
260 legestr = '%sge %s%s' % (re_lege.group(1),
261 re_lege.group(2),
262 re_lege.group(4))
263
264 key[0] = '%s prefix-list%s%s %s%s' % (re_key_rt.group(1),
265 re_key_rt.group(2),
266 re_key_rt.group(3),
267 newaddr,
268 legestr)
269
270 if lines and key[0].startswith('router bgp'):
271 newlines = []
272 for line in lines:
273 re_net = re.match(r'network\s+([A-Fa-f:.0-9/]+)(.*)$', line)
274 if re_net:
275 addr = re_net.group(1)
276 if '/' not in addr and key[0].startswith('router bgp'):
277 # This is most likely an error because with no
278 # prefixlen, BGP treats the prefixlen as 8
279 addr = addr + '/8'
280
281 try:
282 if 'ipaddress' not in sys.modules:
283 newaddr = IPNetwork(addr)
284 line = 'network %s/%s %s' % (newaddr.network,
285 newaddr.prefixlen,
286 re_net.group(2))
287 else:
288 network_addr = ip_network(addr, strict=False)
289 line = 'network %s/%s %s' % (str(network_addr.network_address),
290 network_addr.prefixlen,
291 re_net.group(2))
292 newlines.append(line)
293 except ValueError:
294 # Really this should be an error. Whats a network
295 # without an IP Address following it ?
296 newlines.append(line)
297 else:
298 newlines.append(line)
299 lines = newlines
300
301 '''
302 More fixups in user specification and what running config shows.
303 "null0" in routes must be replaced by Null0.
304 '''
305 if (key[0].startswith('ip route') or key[0].startswith('ipv6 route') and
306 'null0' in key[0]):
307 key[0] = re.sub(r'\s+null0(\s*$)', ' Null0', key[0])
308
309 if lines:
310 if tuple(key) not in self.contexts:
311 ctx = Context(tuple(key), lines)
312 self.contexts[tuple(key)] = ctx
313 else:
314 ctx = self.contexts[tuple(key)]
315 ctx.add_lines(lines)
316
317 else:
318 if tuple(key) not in self.contexts:
319 ctx = Context(tuple(key), [])
320 self.contexts[tuple(key)] = ctx
321
322 def load_contexts(self):
323 """
324 Parse the configuration and create contexts for each appropriate block
325 """
326
327 current_context_lines = []
328 ctx_keys = []
329
330 '''
331 The end of a context is flagged via the 'end' keyword:
332
333 !
334 interface swp52
335 ipv6 nd suppress-ra
336 link-detect
337 !
338 end
339 router bgp 10
340 bgp router-id 10.0.0.1
341 bgp log-neighbor-changes
342 no bgp default ipv4-unicast
343 neighbor EBGP peer-group
344 neighbor EBGP advertisement-interval 1
345 neighbor EBGP timers connect 10
346 neighbor 2001:40:1:4::6 remote-as 40
347 neighbor 2001:40:1:8::a remote-as 40
348 !
349 end
350 address-family ipv6
351 neighbor IBGPv6 activate
352 neighbor 2001:10::2 peer-group IBGPv6
353 neighbor 2001:10::3 peer-group IBGPv6
354 exit-address-family
355 !
356 end
357 address-family evpn
358 neighbor LEAF activate
359 advertise-all-vni
360 vni 10100
361 rd 65000:10100
362 route-target import 10.1.1.1:10100
363 route-target export 10.1.1.1:10100
364 exit-vni
365 exit-address-family
366 !
367 end
368 router ospf
369 ospf router-id 10.0.0.1
370 log-adjacency-changes detail
371 timers throttle spf 0 50 5000
372 !
373 end
374 '''
375
376 # The code assumes that its working on the output from the "vtysh -m"
377 # command. That provides the appropriate markers to signify end of
378 # a context. This routine uses that to build the contexts for the
379 # config.
380 #
381 # There are single line contexts such as "log file /media/node/zebra.log"
382 # and multi-line contexts such as "router ospf" and subcontexts
383 # within a context such as "address-family" within "router bgp"
384 # In each of these cases, the first line of the context becomes the
385 # key of the context. So "router bgp 10" is the key for the non-address
386 # family part of bgp, "router bgp 10, address-family ipv6 unicast" is
387 # the key for the subcontext and so on.
388 ctx_keys = []
389 main_ctx_key = []
390 new_ctx = True
391
392 # the keywords that we know are single line contexts. bgp in this case
393 # is not the main router bgp block, but enabling multi-instance
394 oneline_ctx_keywords = ("access-list ",
395 "agentx",
396 "bgp ",
397 "debug ",
398 "dump ",
399 "enable ",
400 "frr ",
401 "hostname ",
402 "ip ",
403 "ipv6 ",
404 "log ",
405 "mpls",
406 "no ",
407 "password ",
408 "ptm-enable",
409 "router-id ",
410 "service ",
411 "table ",
412 "username ",
413 "zebra ")
414
415 for line in self.lines:
416
417 if not line:
418 continue
419
420 if line.startswith('!') or line.startswith('#'):
421 continue
422
423 # one line contexts
424 if new_ctx is True and any(line.startswith(keyword) for keyword in oneline_ctx_keywords):
425 self.save_contexts(ctx_keys, current_context_lines)
426
427 # Start a new context
428 main_ctx_key = []
429 ctx_keys = [line, ]
430 current_context_lines = []
431
432 log.debug('LINE %-50s: entering new context, %-50s', line, ctx_keys)
433 self.save_contexts(ctx_keys, current_context_lines)
434 new_ctx = True
435
436 elif line == "end":
437 self.save_contexts(ctx_keys, current_context_lines)
438 log.debug('LINE %-50s: exiting old context, %-50s', line, ctx_keys)
439
440 # Start a new context
441 new_ctx = True
442 main_ctx_key = []
443 ctx_keys = []
444 current_context_lines = []
445
446 elif line == "exit-vrf":
447 self.save_contexts(ctx_keys, current_context_lines)
448 current_context_lines.append(line)
449 log.debug('LINE %-50s: append to current_context_lines, %-50s', line, ctx_keys)
450
451 #Start a new context
452 new_ctx = True
453 main_ctx_key = []
454 ctx_keys = []
455 current_context_lines = []
456
457 elif line in ["exit-address-family", "exit", "exit-vnc"]:
458 # if this exit is for address-family ipv4 unicast, ignore the pop
459 if main_ctx_key:
460 self.save_contexts(ctx_keys, current_context_lines)
461
462 # Start a new context
463 ctx_keys = copy.deepcopy(main_ctx_key)
464 current_context_lines = []
465 log.debug('LINE %-50s: popping from subcontext to ctx%-50s', line, ctx_keys)
466
467 elif line == "exit-vni":
468 if sub_main_ctx_key:
469 self.save_contexts(ctx_keys, current_context_lines)
470
471 # Start a new context
472 ctx_keys = copy.deepcopy(sub_main_ctx_key)
473 current_context_lines = []
474 log.debug('LINE %-50s: popping from sub-subcontext to ctx%-50s', line, ctx_keys)
475
476 elif new_ctx is True:
477 if not main_ctx_key:
478 ctx_keys = [line, ]
479 else:
480 ctx_keys = copy.deepcopy(main_ctx_key)
481 main_ctx_key = []
482
483 current_context_lines = []
484 new_ctx = False
485 log.debug('LINE %-50s: entering new context, %-50s', line, ctx_keys)
486 elif (line.startswith("address-family ") or
487 line.startswith("vnc defaults") or
488 line.startswith("vnc l2-group") or
489 line.startswith("vnc nve-group")):
490 main_ctx_key = []
491
492 # Save old context first
493 self.save_contexts(ctx_keys, current_context_lines)
494 current_context_lines = []
495 main_ctx_key = copy.deepcopy(ctx_keys)
496 log.debug('LINE %-50s: entering sub-context, append to ctx_keys', line)
497
498 if line == "address-family ipv6":
499 ctx_keys.append("address-family ipv6 unicast")
500 elif line == "address-family ipv4":
501 ctx_keys.append("address-family ipv4 unicast")
502 elif line == "address-family evpn":
503 ctx_keys.append("address-family l2vpn evpn")
504 else:
505 ctx_keys.append(line)
506
507 elif ((line.startswith("vni ") and
508 len(ctx_keys) == 2 and
509 ctx_keys[0].startswith('router bgp') and
510 ctx_keys[1] == 'address-family l2vpn evpn')):
511
512 # Save old context first
513 self.save_contexts(ctx_keys, current_context_lines)
514 current_context_lines = []
515 sub_main_ctx_key = copy.deepcopy(ctx_keys)
516 log.debug('LINE %-50s: entering sub-sub-context, append to ctx_keys', line)
517 ctx_keys.append(line)
518
519 else:
520 # Continuing in an existing context, add non-commented lines to it
521 current_context_lines.append(line)
522 log.debug('LINE %-50s: append to current_context_lines, %-50s', line, ctx_keys)
523
524 # Save the context of the last one
525 self.save_contexts(ctx_keys, current_context_lines)
526
527
528 def line_to_vtysh_conft(ctx_keys, line, delete):
529 """
530 Return the vtysh command for the specified context line
531 """
532
533 cmd = []
534 cmd.append('vtysh')
535 cmd.append('-c')
536 cmd.append('conf t')
537
538 if line:
539 for ctx_key in ctx_keys:
540 cmd.append('-c')
541 cmd.append(ctx_key)
542
543 line = line.lstrip()
544
545 if delete:
546 cmd.append('-c')
547
548 if line.startswith('no '):
549 cmd.append('%s' % line[3:])
550 else:
551 cmd.append('no %s' % line)
552
553 else:
554 cmd.append('-c')
555 cmd.append(line)
556
557 # If line is None then we are typically deleting an entire
558 # context ('no router ospf' for example)
559 else:
560
561 if delete:
562
563 # Only put the 'no' on the last sub-context
564 for ctx_key in ctx_keys:
565 cmd.append('-c')
566
567 if ctx_key == ctx_keys[-1]:
568 cmd.append('no %s' % ctx_key)
569 else:
570 cmd.append('%s' % ctx_key)
571 else:
572 for ctx_key in ctx_keys:
573 cmd.append('-c')
574 cmd.append(ctx_key)
575
576 return cmd
577
578
579 def line_for_vtysh_file(ctx_keys, line, delete):
580 """
581 Return the command as it would appear in frr.conf
582 """
583 cmd = []
584
585 if line:
586 for (i, ctx_key) in enumerate(ctx_keys):
587 cmd.append(' ' * i + ctx_key)
588
589 line = line.lstrip()
590 indent = len(ctx_keys) * ' '
591
592 if delete:
593 if line.startswith('no '):
594 cmd.append('%s%s' % (indent, line[3:]))
595 else:
596 cmd.append('%sno %s' % (indent, line))
597
598 else:
599 cmd.append(indent + line)
600
601 # If line is None then we are typically deleting an entire
602 # context ('no router ospf' for example)
603 else:
604 if delete:
605
606 # Only put the 'no' on the last sub-context
607 for ctx_key in ctx_keys:
608
609 if ctx_key == ctx_keys[-1]:
610 cmd.append('no %s' % ctx_key)
611 else:
612 cmd.append('%s' % ctx_key)
613 else:
614 for ctx_key in ctx_keys:
615 cmd.append(ctx_key)
616
617 cmd = '\n' + '\n'.join(cmd)
618
619 # There are some commands that are on by default so their "no" form will be
620 # displayed in the config. "no bgp default ipv4-unicast" is one of these.
621 # If we need to remove this line we do so by adding "bgp default ipv4-unicast",
622 # not by doing a "no no bgp default ipv4-unicast"
623 cmd = cmd.replace('no no ', '')
624
625 return cmd
626
627
628 def get_normalized_ipv6_line(line):
629 """
630 Return a normalized IPv6 line as produced by frr,
631 with all letters in lower case and trailing and leading
632 zeros removed, and only the network portion present if
633 the IPv6 word is a network
634 """
635 norm_line = ""
636 words = line.split(' ')
637 for word in words:
638 if ":" in word:
639 norm_word = None
640 if "/" in word:
641 try:
642 if 'ipaddress' not in sys.modules:
643 v6word = IPNetwork(word)
644 norm_word = '%s/%s' % (v6word.network, v6word.prefixlen)
645 else:
646 v6word = ip_network(word, strict=False)
647 norm_word = '%s/%s' % (str(v6word.network_address), v6word.prefixlen)
648 except ValueError:
649 pass
650 if not norm_word:
651 try:
652 norm_word = '%s' % IPv6Address(word)
653 except ValueError:
654 norm_word = word
655 else:
656 norm_word = word
657 norm_line = norm_line + " " + norm_word
658
659 return norm_line.strip()
660
661
662 def line_exist(lines, target_ctx_keys, target_line, exact_match=True):
663 for (ctx_keys, line) in lines:
664 if ctx_keys == target_ctx_keys:
665 if exact_match:
666 if line == target_line:
667 return True
668 else:
669 if line.startswith(target_line):
670 return True
671 return False
672
673
674 def ignore_delete_re_add_lines(lines_to_add, lines_to_del):
675
676 # Quite possibly the most confusing (while accurate) variable names in history
677 lines_to_add_to_del = []
678 lines_to_del_to_del = []
679
680 for (ctx_keys, line) in lines_to_del:
681 deleted = False
682
683 if ctx_keys[0].startswith('router bgp') and line:
684
685 if line.startswith('neighbor '):
686 '''
687 BGP changed how it displays swpX peers that are part of peer-group. Older
688 versions of frr would display these on separate lines:
689 neighbor swp1 interface
690 neighbor swp1 peer-group FOO
691
692 but today we display via a single line
693 neighbor swp1 interface peer-group FOO
694
695 This change confuses frr-reload.py so check to see if we are deleting
696 neighbor swp1 interface peer-group FOO
697
698 and adding
699 neighbor swp1 interface
700 neighbor swp1 peer-group FOO
701
702 If so then chop the del line and the corresponding add lines
703 '''
704
705 re_swpx_int_peergroup = re.search('neighbor (\S+) interface peer-group (\S+)', line)
706 re_swpx_int_v6only_peergroup = re.search('neighbor (\S+) interface v6only peer-group (\S+)', line)
707
708 if re_swpx_int_peergroup or re_swpx_int_v6only_peergroup:
709 swpx_interface = None
710 swpx_peergroup = None
711
712 if re_swpx_int_peergroup:
713 swpx = re_swpx_int_peergroup.group(1)
714 peergroup = re_swpx_int_peergroup.group(2)
715 swpx_interface = "neighbor %s interface" % swpx
716 elif re_swpx_int_v6only_peergroup:
717 swpx = re_swpx_int_v6only_peergroup.group(1)
718 peergroup = re_swpx_int_v6only_peergroup.group(2)
719 swpx_interface = "neighbor %s interface v6only" % swpx
720
721 swpx_peergroup = "neighbor %s peer-group %s" % (swpx, peergroup)
722 found_add_swpx_interface = line_exist(lines_to_add, ctx_keys, swpx_interface)
723 found_add_swpx_peergroup = line_exist(lines_to_add, ctx_keys, swpx_peergroup)
724 tmp_ctx_keys = tuple(list(ctx_keys))
725
726 if not found_add_swpx_peergroup:
727 tmp_ctx_keys = list(ctx_keys)
728 tmp_ctx_keys.append('address-family ipv4 unicast')
729 tmp_ctx_keys = tuple(tmp_ctx_keys)
730 found_add_swpx_peergroup = line_exist(lines_to_add, tmp_ctx_keys, swpx_peergroup)
731
732 if not found_add_swpx_peergroup:
733 tmp_ctx_keys = list(ctx_keys)
734 tmp_ctx_keys.append('address-family ipv6 unicast')
735 tmp_ctx_keys = tuple(tmp_ctx_keys)
736 found_add_swpx_peergroup = line_exist(lines_to_add, tmp_ctx_keys, swpx_peergroup)
737
738 if found_add_swpx_interface and found_add_swpx_peergroup:
739 deleted = True
740 lines_to_del_to_del.append((ctx_keys, line))
741 lines_to_add_to_del.append((ctx_keys, swpx_interface))
742 lines_to_add_to_del.append((tmp_ctx_keys, swpx_peergroup))
743
744 '''
745 We changed how we display the neighbor interface command. Older
746 versions of frr would display the following:
747 neighbor swp1 interface
748 neighbor swp1 remote-as external
749 neighbor swp1 capability extended-nexthop
750
751 but today we display via a single line
752 neighbor swp1 interface remote-as external
753
754 and capability extended-nexthop is no longer needed because we
755 automatically enable it when the neighbor is of type interface.
756
757 This change confuses frr-reload.py so check to see if we are deleting
758 neighbor swp1 interface remote-as (external|internal|ASNUM)
759
760 and adding
761 neighbor swp1 interface
762 neighbor swp1 remote-as (external|internal|ASNUM)
763 neighbor swp1 capability extended-nexthop
764
765 If so then chop the del line and the corresponding add lines
766 '''
767 re_swpx_int_remoteas = re.search('neighbor (\S+) interface remote-as (\S+)', line)
768 re_swpx_int_v6only_remoteas = re.search('neighbor (\S+) interface v6only remote-as (\S+)', line)
769
770 if re_swpx_int_remoteas or re_swpx_int_v6only_remoteas:
771 swpx_interface = None
772 swpx_remoteas = None
773
774 if re_swpx_int_remoteas:
775 swpx = re_swpx_int_remoteas.group(1)
776 remoteas = re_swpx_int_remoteas.group(2)
777 swpx_interface = "neighbor %s interface" % swpx
778 elif re_swpx_int_v6only_remoteas:
779 swpx = re_swpx_int_v6only_remoteas.group(1)
780 remoteas = re_swpx_int_v6only_remoteas.group(2)
781 swpx_interface = "neighbor %s interface v6only" % swpx
782
783 swpx_remoteas = "neighbor %s remote-as %s" % (swpx, remoteas)
784 found_add_swpx_interface = line_exist(lines_to_add, ctx_keys, swpx_interface)
785 found_add_swpx_remoteas = line_exist(lines_to_add, ctx_keys, swpx_remoteas)
786 tmp_ctx_keys = tuple(list(ctx_keys))
787
788 if found_add_swpx_interface and found_add_swpx_remoteas:
789 deleted = True
790 lines_to_del_to_del.append((ctx_keys, line))
791 lines_to_add_to_del.append((ctx_keys, swpx_interface))
792 lines_to_add_to_del.append((tmp_ctx_keys, swpx_remoteas))
793
794 '''
795 We made the 'bgp bestpath as-path multipath-relax' command
796 automatically assume 'no-as-set' since the lack of this option caused
797 weird routing problems. When the running config is shown in
798 releases with this change, the no-as-set keyword is not shown as it
799 is the default. This causes frr-reload to unnecessarily unapply
800 this option only to apply it back again, causing unnecessary session
801 resets.
802 '''
803 if 'multipath-relax' in line:
804 re_asrelax_new = re.search('^bgp\s+bestpath\s+as-path\s+multipath-relax$', line)
805 old_asrelax_cmd = 'bgp bestpath as-path multipath-relax no-as-set'
806 found_asrelax_old = line_exist(lines_to_add, ctx_keys, old_asrelax_cmd)
807
808 if re_asrelax_new and found_asrelax_old:
809 deleted = True
810 lines_to_del_to_del.append((ctx_keys, line))
811 lines_to_add_to_del.append((ctx_keys, old_asrelax_cmd))
812
813 '''
814 If we are modifying the BGP table-map we need to avoid a del/add and
815 instead modify the table-map in place via an add. This is needed to
816 avoid installing all routes in the RIB the second the 'no table-map'
817 is issued.
818 '''
819 if line.startswith('table-map'):
820 found_table_map = line_exist(lines_to_add, ctx_keys, 'table-map', False)
821
822 if found_table_map:
823 lines_to_del_to_del.append((ctx_keys, line))
824
825 '''
826 More old-to-new config handling. ip import-table no longer accepts
827 distance, but we honor the old syntax. But 'show running' shows only
828 the new syntax. This causes an unnecessary 'no import-table' followed
829 by the same old 'ip import-table' which causes perturbations in
830 announced routes leading to traffic blackholes. Fix this issue.
831 '''
832 re_importtbl = re.search('^ip\s+import-table\s+(\d+)$', ctx_keys[0])
833 if re_importtbl:
834 table_num = re_importtbl.group(1)
835 for ctx in lines_to_add:
836 if ctx[0][0].startswith('ip import-table %s distance' % table_num):
837 lines_to_del_to_del.append((('ip import-table %s' % table_num,), None))
838 lines_to_add_to_del.append((ctx[0], None))
839
840 '''
841 ip/ipv6 prefix-list can be specified without a seq number. However,
842 the running config always adds 'seq x', where x is a number incremented
843 by 5 for every element, to the prefix list. So, ignore such lines as
844 well. Sample prefix-list lines:
845 ip prefix-list PR-TABLE-2 seq 5 permit 20.8.2.0/24 le 32
846 ip prefix-list PR-TABLE-2 seq 10 permit 20.8.2.0/24 le 32
847 ipv6 prefix-list vrfdev6-12 permit 2000:9:2::/64 gt 64
848 '''
849 re_ip_pfxlst = re.search('^(ip|ipv6)(\s+prefix-list\s+)(\S+\s+)(seq \d+\s+)(permit|deny)(.*)$',
850 ctx_keys[0])
851 if re_ip_pfxlst:
852 tmpline = (re_ip_pfxlst.group(1) + re_ip_pfxlst.group(2) +
853 re_ip_pfxlst.group(3) + re_ip_pfxlst.group(5) +
854 re_ip_pfxlst.group(6))
855 for ctx in lines_to_add:
856 if ctx[0][0] == tmpline:
857 lines_to_del_to_del.append((ctx_keys, None))
858 lines_to_add_to_del.append(((tmpline,), None))
859
860 if (len(ctx_keys) == 3 and
861 ctx_keys[0].startswith('router bgp') and
862 ctx_keys[1] == 'address-family l2vpn evpn' and
863 ctx_keys[2].startswith('vni')):
864
865 re_route_target = re.search('^route-target import (.*)$', line) if line is not None else False
866
867 if re_route_target:
868 rt = re_route_target.group(1).strip()
869 route_target_import_line = line
870 route_target_export_line = "route-target export %s" % rt
871 route_target_both_line = "route-target both %s" % rt
872
873 found_route_target_export_line = line_exist(lines_to_del, ctx_keys, route_target_export_line)
874 found_route_target_both_line = line_exist(lines_to_add, ctx_keys, route_target_both_line)
875
876 '''
877 If the running configs has
878 route-target import 1:1
879 route-target export 1:1
880
881 and the config we are reloading against has
882 route-target both 1:1
883
884 then we can ignore deleting the import/export and ignore adding the 'both'
885 '''
886 if found_route_target_export_line and found_route_target_both_line:
887 lines_to_del_to_del.append((ctx_keys, route_target_import_line))
888 lines_to_del_to_del.append((ctx_keys, route_target_export_line))
889 lines_to_add_to_del.append((ctx_keys, route_target_both_line))
890
891 if not deleted:
892 found_add_line = line_exist(lines_to_add, ctx_keys, line)
893
894 if found_add_line:
895 lines_to_del_to_del.append((ctx_keys, line))
896 lines_to_add_to_del.append((ctx_keys, line))
897 else:
898 '''
899 We have commands that used to be displayed in the global part
900 of 'router bgp' that are now displayed under 'address-family ipv4 unicast'
901
902 # old way
903 router bgp 64900
904 neighbor ISL advertisement-interval 0
905
906 vs.
907
908 # new way
909 router bgp 64900
910 address-family ipv4 unicast
911 neighbor ISL advertisement-interval 0
912
913 Look to see if we are deleting it in one format just to add it back in the other
914 '''
915 if ctx_keys[0].startswith('router bgp') and len(ctx_keys) > 1 and ctx_keys[1] == 'address-family ipv4 unicast':
916 tmp_ctx_keys = list(ctx_keys)[:-1]
917 tmp_ctx_keys = tuple(tmp_ctx_keys)
918
919 found_add_line = line_exist(lines_to_add, tmp_ctx_keys, line)
920
921 if found_add_line:
922 lines_to_del_to_del.append((ctx_keys, line))
923 lines_to_add_to_del.append((tmp_ctx_keys, line))
924
925 for (ctx_keys, line) in lines_to_del_to_del:
926 lines_to_del.remove((ctx_keys, line))
927
928 for (ctx_keys, line) in lines_to_add_to_del:
929 lines_to_add.remove((ctx_keys, line))
930
931 return (lines_to_add, lines_to_del)
932
933
934 def ignore_unconfigurable_lines(lines_to_add, lines_to_del):
935 """
936 There are certain commands that cannot be removed. Remove
937 those commands from lines_to_del.
938 """
939 lines_to_del_to_del = []
940
941 for (ctx_keys, line) in lines_to_del:
942
943 if (ctx_keys[0].startswith('frr version') or
944 ctx_keys[0].startswith('frr defaults') or
945 ctx_keys[0].startswith('password') or
946 ctx_keys[0].startswith('line vty') or
947
948 # This is technically "no"able but if we did so frr-reload would
949 # stop working so do not let the user shoot themselves in the foot
950 # by removing this.
951 ctx_keys[0].startswith('service integrated-vtysh-config')):
952
953 log.info("(%s, %s) cannot be removed" % (pformat(ctx_keys), line))
954 lines_to_del_to_del.append((ctx_keys, line))
955
956 for (ctx_keys, line) in lines_to_del_to_del:
957 lines_to_del.remove((ctx_keys, line))
958
959 return (lines_to_add, lines_to_del)
960
961
962 def compare_context_objects(newconf, running):
963 """
964 Create a context diff for the two specified contexts
965 """
966
967 # Compare the two Config objects to find the lines that we need to add/del
968 lines_to_add = []
969 lines_to_del = []
970 delete_bgpd = False
971
972 # Find contexts that are in newconf but not in running
973 # Find contexts that are in running but not in newconf
974 for (running_ctx_keys, running_ctx) in iteritems(running.contexts):
975
976 if running_ctx_keys not in newconf.contexts:
977
978 # We check that the len is 1 here so that we only look at ('router bgp 10')
979 # and not ('router bgp 10', 'address-family ipv4 unicast'). The
980 # latter could cause a false delete_bgpd positive if ipv4 unicast is in
981 # running but not in newconf.
982 if "router bgp" in running_ctx_keys[0] and len(running_ctx_keys) == 1:
983 delete_bgpd = True
984 lines_to_del.append((running_ctx_keys, None))
985
986 # We cannot do 'no interface' or 'no vrf' in FRR, and so deal with it
987 elif running_ctx_keys[0].startswith('interface') or running_ctx_keys[0].startswith('vrf'):
988 for line in running_ctx.lines:
989 lines_to_del.append((running_ctx_keys, line))
990
991 # If this is an address-family under 'router bgp' and we are already deleting the
992 # entire 'router bgp' context then ignore this sub-context
993 elif "router bgp" in running_ctx_keys[0] and len(running_ctx_keys) > 1 and delete_bgpd:
994 continue
995
996 # Delete an entire vni sub-context under "address-family l2vpn evpn"
997 elif ("router bgp" in running_ctx_keys[0] and
998 len(running_ctx_keys) > 2 and
999 running_ctx_keys[1].startswith('address-family l2vpn evpn') and
1000 running_ctx_keys[2].startswith('vni ')):
1001 lines_to_del.append((running_ctx_keys, None))
1002
1003 elif ("router bgp" in running_ctx_keys[0] and
1004 len(running_ctx_keys) > 1 and
1005 running_ctx_keys[1].startswith('address-family')):
1006 # There's no 'no address-family' support and so we have to
1007 # delete each line individually again
1008 for line in running_ctx.lines:
1009 lines_to_del.append((running_ctx_keys, line))
1010
1011 # Non-global context
1012 elif running_ctx_keys and not any("address-family" in key for key in running_ctx_keys):
1013 lines_to_del.append((running_ctx_keys, None))
1014
1015 elif running_ctx_keys and not any("vni" in key for key in running_ctx_keys):
1016 lines_to_del.append((running_ctx_keys, None))
1017
1018 # Global context
1019 else:
1020 for line in running_ctx.lines:
1021 lines_to_del.append((running_ctx_keys, line))
1022
1023 # Find the lines within each context to add
1024 # Find the lines within each context to del
1025 for (newconf_ctx_keys, newconf_ctx) in iteritems(newconf.contexts):
1026
1027 if newconf_ctx_keys in running.contexts:
1028 running_ctx = running.contexts[newconf_ctx_keys]
1029
1030 for line in newconf_ctx.lines:
1031 if line not in running_ctx.dlines:
1032 lines_to_add.append((newconf_ctx_keys, line))
1033
1034 for line in running_ctx.lines:
1035 if line not in newconf_ctx.dlines:
1036 lines_to_del.append((newconf_ctx_keys, line))
1037
1038 for (newconf_ctx_keys, newconf_ctx) in iteritems(newconf.contexts):
1039
1040 if newconf_ctx_keys not in running.contexts:
1041 lines_to_add.append((newconf_ctx_keys, None))
1042
1043 for line in newconf_ctx.lines:
1044 lines_to_add.append((newconf_ctx_keys, line))
1045
1046 (lines_to_add, lines_to_del) = ignore_delete_re_add_lines(lines_to_add, lines_to_del)
1047 (lines_to_add, lines_to_del) = ignore_unconfigurable_lines(lines_to_add, lines_to_del)
1048
1049 return (lines_to_add, lines_to_del)
1050
1051
1052
1053 def vtysh_config_available():
1054 """
1055 Return False if no frr daemon is running or some other vtysh session is
1056 in 'configuration terminal' mode which will prevent us from making any
1057 configuration changes.
1058 """
1059
1060 try:
1061 cmd = ['/usr/bin/vtysh', '-c', 'conf t']
1062 output = subprocess.check_output(cmd, stderr=subprocess.STDOUT).strip()
1063
1064 if 'VTY configuration is locked by other VTY' in output.decode('utf-8'):
1065 print(output)
1066 log.error("'%s' returned\n%s\n" % (' '.join(cmd), output))
1067 return False
1068
1069 except subprocess.CalledProcessError as e:
1070 msg = "vtysh could not connect with any frr daemons"
1071 print(msg)
1072 log.error(msg)
1073 return False
1074
1075 return True
1076
1077
1078 if __name__ == '__main__':
1079 # Command line options
1080 parser = argparse.ArgumentParser(description='Dynamically apply diff in frr configs')
1081 parser.add_argument('--input', help='Read running config from file instead of "show running"')
1082 group = parser.add_mutually_exclusive_group(required=True)
1083 group.add_argument('--reload', action='store_true', help='Apply the deltas', default=False)
1084 group.add_argument('--test', action='store_true', help='Show the deltas', default=False)
1085 parser.add_argument('--debug', action='store_true', help='Enable debugs', default=False)
1086 parser.add_argument('--stdout', action='store_true', help='Log to STDOUT', default=False)
1087 parser.add_argument('filename', help='Location of new frr config file')
1088 parser.add_argument('--overwrite', action='store_true', help='Overwrite frr.conf with running config output', default=False)
1089 args = parser.parse_args()
1090
1091 # Logging
1092 # For --test log to stdout
1093 # For --reload log to /var/log/frr/frr-reload.log
1094 if args.test or args.stdout:
1095 logging.basicConfig(level=logging.INFO,
1096 format='%(asctime)s %(levelname)5s: %(message)s')
1097
1098 # Color the errors and warnings in red
1099 logging.addLevelName(logging.ERROR, "\033[91m %s\033[0m" % logging.getLevelName(logging.ERROR))
1100 logging.addLevelName(logging.WARNING, "\033[91m%s\033[0m" % logging.getLevelName(logging.WARNING))
1101
1102 elif args.reload:
1103 if not os.path.isdir('/var/log/frr/'):
1104 os.makedirs('/var/log/frr/')
1105
1106 logging.basicConfig(filename='/var/log/frr/frr-reload.log',
1107 level=logging.INFO,
1108 format='%(asctime)s %(levelname)5s: %(message)s')
1109
1110 # argparse should prevent this from happening but just to be safe...
1111 else:
1112 raise Exception('Must specify --reload or --test')
1113 log = logging.getLogger(__name__)
1114
1115 # Verify the new config file is valid
1116 if not os.path.isfile(args.filename):
1117 msg = "Filename %s does not exist" % args.filename
1118 print(msg)
1119 log.error(msg)
1120 sys.exit(1)
1121
1122 if not os.path.getsize(args.filename):
1123 msg = "Filename %s is an empty file" % args.filename
1124 print(msg)
1125 log.error(msg)
1126 sys.exit(1)
1127
1128 # Verify that 'service integrated-vtysh-config' is configured
1129 vtysh_filename = '/etc/frr/vtysh.conf'
1130 service_integrated_vtysh_config = True
1131
1132 if os.path.isfile(vtysh_filename):
1133 with open(vtysh_filename, 'r') as fh:
1134 for line in fh.readlines():
1135 line = line.strip()
1136
1137 if line == 'no service integrated-vtysh-config':
1138 service_integrated_vtysh_config = False
1139 break
1140
1141 if not service_integrated_vtysh_config:
1142 msg = "'service integrated-vtysh-config' is not configured, this is required for 'service frr reload'"
1143 print(msg)
1144 log.error(msg)
1145 sys.exit(1)
1146
1147 if args.debug:
1148 log.setLevel(logging.DEBUG)
1149
1150 log.info('Called via "%s"', str(args))
1151
1152 # Create a Config object from the config generated by newconf
1153 newconf = Config()
1154 newconf.load_from_file(args.filename)
1155 reload_ok = True
1156
1157 if args.test:
1158
1159 # Create a Config object from the running config
1160 running = Config()
1161
1162 if args.input:
1163 running.load_from_file(args.input)
1164 else:
1165 running.load_from_show_running()
1166
1167 (lines_to_add, lines_to_del) = compare_context_objects(newconf, running)
1168 lines_to_configure = []
1169
1170 if lines_to_del:
1171 print("\nLines To Delete")
1172 print("===============")
1173
1174 for (ctx_keys, line) in lines_to_del:
1175
1176 if line == '!':
1177 continue
1178
1179 cmd = line_for_vtysh_file(ctx_keys, line, True)
1180 lines_to_configure.append(cmd)
1181 print(cmd)
1182
1183 if lines_to_add:
1184 print("\nLines To Add")
1185 print("============")
1186
1187 for (ctx_keys, line) in lines_to_add:
1188
1189 if line == '!':
1190 continue
1191
1192 cmd = line_for_vtysh_file(ctx_keys, line, False)
1193 lines_to_configure.append(cmd)
1194 print(cmd)
1195
1196 elif args.reload:
1197
1198 # We will not be able to do anything, go ahead and exit(1)
1199 if not vtysh_config_available():
1200 sys.exit(1)
1201
1202 log.debug('New Frr Config\n%s', newconf.get_lines())
1203
1204 # This looks a little odd but we have to do this twice...here is why
1205 # If the user had this running bgp config:
1206 #
1207 # router bgp 10
1208 # neighbor 1.1.1.1 remote-as 50
1209 # neighbor 1.1.1.1 route-map FOO out
1210 #
1211 # and this config in the newconf config file
1212 #
1213 # router bgp 10
1214 # neighbor 1.1.1.1 remote-as 999
1215 # neighbor 1.1.1.1 route-map FOO out
1216 #
1217 #
1218 # Then the script will do
1219 # - no neighbor 1.1.1.1 remote-as 50
1220 # - neighbor 1.1.1.1 remote-as 999
1221 #
1222 # The problem is the "no neighbor 1.1.1.1 remote-as 50" will also remove
1223 # the "neighbor 1.1.1.1 route-map FOO out" line...so we compare the
1224 # configs again to put this line back.
1225
1226 # There are many keywords in FRR that can only appear one time under
1227 # a context, take "bgp router-id" for example. If the config that we are
1228 # reloading against has the following:
1229 #
1230 # router bgp 10
1231 # bgp router-id 1.1.1.1
1232 # bgp router-id 2.2.2.2
1233 #
1234 # The final config needs to contain "bgp router-id 2.2.2.2". On the
1235 # first pass we will add "bgp router-id 2.2.2.2" but then on the second
1236 # pass we will see that "bgp router-id 1.1.1.1" is missing and add that
1237 # back which cancels out the "bgp router-id 2.2.2.2". The fix is for the
1238 # second pass to include all of the "adds" from the first pass.
1239 lines_to_add_first_pass = []
1240
1241 for x in range(2):
1242 running = Config()
1243 running.load_from_show_running()
1244 log.debug('Running Frr Config (Pass #%d)\n%s', x, running.get_lines())
1245
1246 (lines_to_add, lines_to_del) = compare_context_objects(newconf, running)
1247
1248 if x == 0:
1249 lines_to_add_first_pass = lines_to_add
1250 else:
1251 lines_to_add.extend(lines_to_add_first_pass)
1252
1253 # Only do deletes on the first pass. The reason being if we
1254 # configure a bgp neighbor via "neighbor swp1 interface" FRR
1255 # will automatically add:
1256 #
1257 # interface swp1
1258 # ipv6 nd ra-interval 10
1259 # no ipv6 nd suppress-ra
1260 # !
1261 #
1262 # but those lines aren't in the config we are reloading against so
1263 # on the 2nd pass they will show up in lines_to_del. This could
1264 # apply to other scenarios as well where configuring FOO adds BAR
1265 # to the config.
1266 if lines_to_del and x == 0:
1267 for (ctx_keys, line) in lines_to_del:
1268
1269 if line == '!':
1270 continue
1271
1272 # 'no' commands are tricky, we can't just put them in a file and
1273 # vtysh -f that file. See the next comment for an explanation
1274 # of their quirks
1275 cmd = line_to_vtysh_conft(ctx_keys, line, True)
1276 original_cmd = cmd
1277
1278 # Some commands in frr are picky about taking a "no" of the entire line.
1279 # OSPF is bad about this, you can't "no" the entire line, you have to "no"
1280 # only the beginning. If we hit one of these command an exception will be
1281 # thrown. Catch it and remove the last '-c', 'FOO' from cmd and try again.
1282 #
1283 # Example:
1284 # frr(config-if)# ip ospf authentication message-digest 1.1.1.1
1285 # frr(config-if)# no ip ospf authentication message-digest 1.1.1.1
1286 # % Unknown command.
1287 # frr(config-if)# no ip ospf authentication message-digest
1288 # % Unknown command.
1289 # frr(config-if)# no ip ospf authentication
1290 # frr(config-if)#
1291
1292 while True:
1293 try:
1294 _ = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
1295
1296 except subprocess.CalledProcessError:
1297
1298 # - Pull the last entry from cmd (this would be
1299 # 'no ip ospf authentication message-digest 1.1.1.1' in
1300 # our example above
1301 # - Split that last entry by whitespace and drop the last word
1302 log.info('Failed to execute %s', ' '.join(cmd))
1303 last_arg = cmd[-1].split(' ')
1304
1305 if len(last_arg) <= 2:
1306 log.error('"%s" we failed to remove this command', original_cmd)
1307 break
1308
1309 new_last_arg = last_arg[0:-1]
1310 cmd[-1] = ' '.join(new_last_arg)
1311 else:
1312 log.info('Executed "%s"', ' '.join(cmd))
1313 break
1314
1315 if lines_to_add:
1316 lines_to_configure = []
1317
1318 for (ctx_keys, line) in lines_to_add:
1319
1320 if line == '!':
1321 continue
1322
1323 cmd = line_for_vtysh_file(ctx_keys, line, False)
1324 lines_to_configure.append(cmd)
1325
1326 if lines_to_configure:
1327 random_string = ''.join(random.SystemRandom().choice(
1328 string.ascii_uppercase +
1329 string.digits) for _ in range(6))
1330
1331 filename = "/var/run/frr/reload-%s.txt" % random_string
1332 log.info("%s content\n%s" % (filename, pformat(lines_to_configure)))
1333
1334 with open(filename, 'w') as fh:
1335 for line in lines_to_configure:
1336 fh.write(line + '\n')
1337
1338 try:
1339 subprocess.check_output(['/usr/bin/vtysh', '-f', filename], stderr=subprocess.STDOUT)
1340 except subprocess.CalledProcessError as e:
1341 log.warning("frr-reload.py failed due to\n%s" % e.output)
1342 reload_ok = False
1343 os.unlink(filename)
1344
1345 # Make these changes persistent
1346 if args.overwrite or args.filename != '/etc/frr/frr.conf':
1347 subprocess.call(['/usr/bin/vtysh', '-c', 'write'])
1348
1349 if not reload_ok:
1350 sys.exit(1)