use PVE::QemuServer;
use File::Path;
use IO::File;
+use Net::IP;
+use PVE::Tools qw(run_command);
+
use Data::Dumper;
my $macros;
+my @ruleset = ();
+
sub get_shorewall_macros {
return $macros if $macros;
return $macros;
}
+my $etc_services;
+
+sub get_etc_services {
+
+ return $etc_services if $etc_services;
+
+ my $filename = "/etc/services";
+
+ my $fh = IO::File->new($filename, O_RDONLY);
+ if (!$fh) {
+ warn "unable to read '$filename' - $!\n";
+ return {};
+ }
+
+ my $services = {};
+
+ while (my $line = <$fh>) {
+ chomp ($line);
+ next if $line =~m/^#/;
+ next if ($line =~m/^\s*$/);
+
+ if ($line =~ m!^(\S+)\s+(\S+)/(tcp|udp).*$!) {
+ $services->{byid}->{$2}->{name} = $1;
+ $services->{byid}->{$2}->{$3} = 1;
+ $services->{byname}->{$1} = $services->{byid}->{$2};
+ }
+ }
+
+ close($fh);
+
+ $etc_services = $services;
+
+
+ return $etc_services;
+}
+
+my $etc_protocols;
+
+sub get_etc_protocols {
+ return $etc_protocols if $etc_protocols;
+
+ my $filename = "/etc/protocols";
+
+ my $fh = IO::File->new($filename, O_RDONLY);
+ if (!$fh) {
+ warn "unable to read '$filename' - $!\n";
+ return {};
+ }
+
+ my $protocols = {};
+
+ while (my $line = <$fh>) {
+ chomp ($line);
+ next if $line =~m/^#/;
+ next if ($line =~m/^\s*$/);
+
+ if ($line =~ m!^(\S+)\s+(\d+)\s+.*$!) {
+ $protocols->{byid}->{$2}->{name} = $1;
+ $protocols->{byname}->{$1} = $protocols->{byid}->{$2};
+ }
+ }
+
+ close($fh);
+
+ $etc_protocols = $protocols;
+
+ return $etc_protocols;
+}
+
+sub parse_address_list {
+ my ($str) = @_;
+
+ foreach my $aor (split(/,/, $str)) {
+ if (!Net::IP->new($aor)) {
+ my $err = Net::IP::Error();
+ die "invalid IP address: $err\n";
+ }
+ }
+}
+
+sub parse_port_name_number_or_range {
+ my ($str) = @_;
+
+ my $services = PVE::Firewall::get_etc_services();
+ my $nbports = 0;
+ foreach my $item (split(/,/, $str)) {
+ my $portlist = "";
+ foreach my $pon (split(':', $item, 2)) {
+ if ($pon =~ m/^\d+$/){
+ die "invalid port '$pon'\n" if $pon < 0 && $pon > 65536;
+ }else{
+ die "invalid port $services->{byname}->{$pon}\n" if !$services->{byname}->{$pon};
+ }
+ $nbports++;
+ }
+ }
+
+ return ($nbports);
+}
my $rule_format = "%-15s %-30s %-30s %-15s %-15s %-15s\n";
+sub iptables {
+ my ($cmd) = @_;
+
+ run_command("/sbin/iptables $cmd", outfunc => sub {}, errfunc => sub {});
+}
+
+sub iptables_restore {
+
+ unshift (@ruleset, '*filter');
+ push (@ruleset, 'COMMIT');
+
+ my $cmdlist = join("\n", @ruleset);
+
+ run_command("echo '$cmdlist' | /sbin/iptables-restore -n", outfunc => sub {});
+}
+
+sub iptables_addrule {
+ my ($rule) = @_;
+
+ push (@ruleset, $rule);
+}
+
+sub iptables_chain_exist {
+ my ($chain) = @_;
+
+ eval{
+ iptables("-n --list $chain");
+ };
+ return undef if $@;
+
+ return 1;
+}
+
+sub iptables_rule_exist {
+ my ($rule) = @_;
+
+ eval{
+ iptables("-C $rule");
+ };
+ return undef if $@;
+
+ return 1;
+}
+
+sub iptables_generate_rule {
+ my ($chain, $rule) = @_;
+
+ my $cmd = "-A $chain";
+
+ $cmd .= " -s $rule->{source}" if $rule->{source};
+ $cmd .= " -d $rule->{dest}" if $rule->{destination};
+ $cmd .= " -p $rule->{proto}" if $rule->{proto};
+ $cmd .= " --match multiport" if $rule->{nbdport} && $rule->{nbdport} > 1;
+ $cmd .= " --dport $rule->{dport}" if $rule->{dport};
+ $cmd .= " --match multiport" if $rule->{nbsport} && $rule->{nbsport} > 1;
+ $cmd .= " --sport $rule->{sport}" if $rule->{sport};
+ $cmd .= " -j $rule->{action}" if $rule->{action};
+
+ iptables_addrule($cmd);
+
+}
+
+sub generate_bridge_rules {
+ my ($bridge) = @_;
+
+ if(!iptables_chain_exist("BRIDGEFW-OUT")){
+ iptables_addrule(":BRIDGEFW-OUT - [0:0]");
+ }
+
+ if(!iptables_chain_exist("BRIDGEFW-IN")){
+ iptables_addrule(":BRIDGEFW-IN - [0:0]");
+ }
+
+ if(!iptables_chain_exist("proxmoxfw-FORWARD")){
+ iptables_addrule(":proxmoxfw-FORWARD - [0:0]");
+ iptables_addrule("-I FORWARD -j proxmoxfw-FORWARD");
+ iptables_addrule("-A proxmoxfw-FORWARD -m state --state RELATED,ESTABLISHED -j ACCEPT");
+ iptables_addrule("-A proxmoxfw-FORWARD -m physdev --physdev-is-in --physdev-is-bridged -j BRIDGEFW-OUT");
+ iptables_addrule("-A proxmoxfw-FORWARD -m physdev --physdev-is-out --physdev-is-bridged -j BRIDGEFW-IN");
+
+ }
+
+ generate_proxmoxfwinput();
+
+ if(!iptables_chain_exist("$bridge-IN")){
+ iptables_addrule(":$bridge-IN - [0:0]");
+ iptables_addrule("-A proxmoxfw-FORWARD -i $bridge -j DROP"); #disable interbridge routing
+ iptables_addrule("-A BRIDGEFW-IN -j $bridge-IN");
+ iptables_addrule("-A $bridge-IN -j ACCEPT");
+
+ }
+
+ if(!iptables_chain_exist("$bridge-OUT")){
+ iptables_addrule(":$bridge-OUT - [0:0]");
+ iptables_addrule("-A proxmoxfw-FORWARD -o $bridge -j DROP"); # disable interbridge routing
+ iptables_addrule("-A BRIDGEFW-OUT -j $bridge-OUT");
+
+ }
+
+}
+
+
+sub generate_tap_rules_direction {
+ my ($iface, $netid, $rules, $bridge, $direction) = @_;
+
+ my $tapchain = "$iface-$direction";
+
+ iptables_addrule(":$tapchain - [0:0]");
+
+ iptables_addrule("-A $tapchain -m state --state INVALID -j DROP");
+ iptables_addrule("-A $tapchain -m state --state RELATED,ESTABLISHED -j ACCEPT");
+
+ if (scalar(@$rules)) {
+ foreach my $rule (@$rules) {
+ next if $rule->{iface} && $rule->{iface} ne $netid;
+ if($rule->{action} =~ m/^(GROUP-(\S+))$/){
+ $rule->{action} .= "-$direction";
+ #generate empty group rule if don't exist
+ if(!iptables_chain_exist($rule->{action})){
+ generate_group_rules($2);
+ }
+ }
+ #we go to vmbr-IN if accept in out rules
+ $rule->{action} = "$bridge-IN" if $rule->{action} eq 'ACCEPT' && $direction eq 'OUT';
+ iptables_generate_rule($tapchain, $rule);
+ }
+ }
+
+ iptables_addrule("-A $tapchain -j LOG --log-prefix \"$tapchain-dropped: \" --log-level 4");
+ iptables_addrule("-A $tapchain -j DROP");
+
+ #plug the tap chain to bridge chain
+ my $physdevdirection = $direction eq 'IN' ? "out":"in";
+ my $rule = "$bridge-$direction -m physdev --physdev-$physdevdirection $iface --physdev-is-bridged -j $tapchain";
+
+ if(!iptables_rule_exist($rule)){
+ iptables_addrule("-I $rule");
+ }
+
+ if($direction eq 'OUT'){
+ #add tap->host rules
+ my $rule = "proxmoxfw-INPUT -m physdev --physdev-$physdevdirection $iface -j $tapchain";
+
+ if(!iptables_rule_exist($rule)){
+ iptables_addrule("-A $rule");
+ }
+ }
+}
+
+sub generate_tap_rules {
+ my ($net, $netid, $vmid) = @_;
+
+ my $filename = "/etc/pve/firewall/$vmid.fw";
+ my $fh = IO::File->new($filename, O_RDONLY);
+ return if !$fh;
+
+ #generate bridge rules
+ my $bridge = $net->{bridge};
+ my $tag = $net->{tag};
+ $bridge .= "v$tag" if $tag;
+
+ #generate tap chain
+ my $rules = parse_fw_rules($filename, $fh);
+
+ my $inrules = $rules->{in};
+ my $outrules = $rules->{out};
+
+ my $iface = "tap".$vmid."i".$1 if $netid =~ m/net(\d+)/;
+
+ generate_bridge_rules($bridge);
+ generate_tap_rules_direction($iface, $netid, $inrules, $bridge, 'IN');
+ generate_tap_rules_direction($iface, $netid, $outrules, $bridge, 'OUT');
+ iptables_restore();
+}
+
+sub flush_tap_rules {
+ my ($net, $netid, $vmid) = @_;
+
+ my $bridge = $net->{bridge};
+ my $iface = "tap".$vmid."i".$1 if $netid =~ m/net(\d+)/;
+
+ flush_tap_rules_direction($iface, $bridge, 'IN');
+ flush_tap_rules_direction($iface, $bridge, 'OUT');
+ iptables_restore();
+}
+
+sub flush_tap_rules_direction {
+ my ($iface, $bridge, $direction) = @_;
+
+ my $tapchain = "$iface-$direction";
+
+ if(iptables_chain_exist($tapchain)){
+ iptables_addrule("-F $tapchain");
+
+ my $physdevdirection = $direction eq 'IN' ? "out":"in";
+ my $rule = "$bridge-$direction -m physdev --physdev-$physdevdirection $iface --physdev-is-bridged -j $tapchain";
+ if(iptables_rule_exist($rule)){
+ iptables_addrule("-D $rule");
+ }
+
+ if($direction eq 'OUT'){
+ my $rule = "proxmoxfw-INPUT -m physdev --physdev-$physdevdirection $iface -j $tapchain";
+
+ if(!iptables_rule_exist($rule)){
+ iptables_addrule("-D $rule");
+ }
+ }
+
+ iptables_addrule("-X $tapchain");
+ }
+}
+
my $generate_input_rule = sub {
my ($zoneinfo, $rule, $net, $netid) = @_;
my $action = $rule->{service} ?
"$rule->{service}($rule->{action})" : $rule->{action};
- my $source;
+ my $sources = [];
- if ($zoneinfo->{$zone}->{type} eq 'bport') {
+ if (!$rule->{source}) {
+ push @$sources, 'all';
+ } elsif ($zoneinfo->{$zone}->{type} eq 'bport') {
my $bridge_zone = $zoneinfo->{$zone}->{bridge_zone} || die "internal error";
- my $bridge_ext_zone = $zoneinfo->{$bridge_zone}->{bridge_ext_zone} || die "internal error";
- my $zoneref = $zoneinfo->{$bridge_ext_zone}->{zoneref} || die "internal error";
- if (!$rule->{source}) {
- # $source = "${zoneref}";
- $source = 'all';
- } else {
- # 'all' does not work
- $source = "${zoneref}:$rule->{source}";
+ my $zoneref = $zoneinfo->{$bridge_zone}->{zoneref} || die "internal error";
+
+ # using 'all' does not work, so we create one rule for
+ # each related zone on the same bridge
+ push @$sources, "${zoneref}:$rule->{source}";
+ foreach my $z (keys %$zoneinfo) {
+ next if $z eq $zone;
+ next if !$zoneinfo->{$z}->{bridge_zone};
+ next if $zoneinfo->{$z}->{bridge_zone} ne $bridge_zone;
+ $zoneref = $zoneinfo->{$z}->{zoneref} || die "internal error";
+ push @$sources, "${zoneref}:$rule->{source}";
}
} else {
- $source = "all:$rule->{source}";
+ push @$sources, "all:$rule->{source}";
}
- return sprintf($rule_format, $action, $source, $dest, $rule->{proto} || '-',
- $rule->{dport} || '-', $rule->{sport} || '-');
+ my $out = '';
+
+ foreach my $source (@$sources) {
+ $out .= sprintf($rule_format, $action, $source, $dest, $rule->{proto} || '-',
+ $rule->{dport} || '-', $rule->{sport} || '-');
+ }
+
+ return $out;
};
my $generate_output_rule = sub {
$register_bridge = sub {
my ($bridge, $vlan) = @_;
- my $zone = 'z' . $bridge;
+ my $zone = $bridge;
return $zone if $zoneinfo->{$zone};
- my $ext_zone = "z${bridge}ext";
+ my $ext_zone = "${bridge}_ext";
$zoneinfo->{$zone} = {
type => 'bridge',
my ($bridge, $vlan, $vmzone, $tap) = @_;
my $bridge_zone = &$register_bridge($bridge, $vlan);
- my $zone = $bridge_zone . $vmzone;
+ my $zone = $bridge_zone . '_' . $vmzone;
if (!$zoneinfo->{$zone}) {
$zoneinfo->{$zone} = {
my $res = { in => [], out => [] };
- my $macros = PVE::Firewall::get_shorewall_macros();
-
+ my $macros = get_shorewall_macros();
+ my $protocols = get_etc_protocols();
+
while (defined(my $line = <$fh>)) {
next if $line =~ m/^#/;
next if $line =~ m/^\s*$/;
}
my $service;
- if ($action =~ m/^(ACCEPT|DROP|REJECT)$/) {
+ if ($action =~ m/^(ACCEPT|DROP|REJECT|GROUP-(\S+))$/) {
# OK
} elsif ($action =~ m/^(\S+)\((ACCEPT|DROP|REJECT)\)$/) {
($service, $action) = ($1, $2);
}
$proto = undef if $proto && $proto eq '-';
- if ($proto && $proto !~ m/^(icmp|tcp|udp)$/) {
+ if ($proto && !(defined($protocols->{byname}->{$proto}) ||
+ defined($protocols->{byid}->{$proto}))) {
warn "unknown protokol '$proto'\n";
next;
}
$source = undef if $source && $source eq '-';
-
-# if ($source !~ m/^(XYZ)$/) {
-# warn "unknown source '$source'\n";
-# next;
-# }
-
$dest = undef if $dest && $dest eq '-';
-# if ($dest !~ m/^XYZ)$/) {
-# warn "unknown destination '$dest'\n";
-# next;
-# }
$dport = undef if $dport && $dport eq '-';
$sport = undef if $sport && $sport eq '-';
+ my $nbdport = undef;
+ my $nbsport = undef;
+
+ eval {
+ parse_address_list($source) if $source;
+ parse_address_list($dest) if $dest;
+ $nbdport = parse_port_name_number_or_range($dport) if $dport;
+ $nbsport = parse_port_name_number_or_range($sport) if $sport;
+ };
+ if (my $err = $@) {
+ warn $err;
+ next;
+
+ }
+
my $rule = {
action => $action,
proto => $proto,
dport => $dport,
sport => $sport,
+ nbdport => $nbdport,
+ nbsport => $nbsport,
+
};
push @{$res->{$section}}, $rule;
my $list = PVE::QemuServer::config_list();
foreach my $vmid (keys %$list) {
- # next if $vmid ne '100';
+ #next if !($vmid eq '100' || $vmid eq '102');
my $cfspath = PVE::QemuServer::cfs_config_path($vmid);
if (my $conf = PVE::Cluster::cfs_read_file($cfspath)) {
$qemu->{$vmid} = $conf;