use strict;
use warnings;
-use Data::Dumper;
+
use IO::File;
+
use PVE::Tools qw(run_command trim);
use PVE::Storage::Plugin;
use PVE::Storage::LVMPlugin;
# lvcreate -n pvepool -L 20G pve
# lvconvert --type thin-pool pve/pvepool
+# NOTE: volumes which were created as linked clones of another base volume
+# are currently not tracking this relationship in their volume IDs. this is
+# generally not a problem, as LVM thin allows deletion of such base volumes
+# without affecting the linked clones. this leads to increased disk usage
+# when migrating LVM-thin volumes, which is normally prevented for linked clones.
+
use base qw(PVE::Storage::LVMPlugin);
sub type {
nodes => { optional => 1 },
disable => { optional => 1 },
content => { optional => 1 },
+ bwlimit => { optional => 1 },
};
}
+# NOTE: the fourth and fifth element of the returned array are always
+# undef, even if the volume is a linked clone of another volume. see note
+# at beginning of file.
sub parse_volname {
my ($class, $volname) = @_;
die "unsupported format '$fmt'" if $fmt ne 'raw';
- die "illegal name '$name' - sould be 'vm-$vmid-*'\n"
+ die "illegal name '$name' - should be 'vm-$vmid-*'\n"
if $name && $name !~ m/^vm-$vmid-/;
my $vgs = PVE::Storage::LVMPlugin::lvm_vgs();
die "no such volume group '$vg'\n" if !defined ($vgs->{$vg});
- my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
-
- $name = PVE::Storage::LVMPlugin::lvm_find_free_diskname($lvs, $vg, $storeid, $vmid)
+ $name = $class->find_free_diskname($storeid, $scfg, $vmid)
if !$name;
my $cmd = ['/sbin/lvcreate', '-aly', '-V', "${size}k", '--name', $name,
# remove all volume snapshots first
foreach my $lv (keys %$dat) {
- next if $lv !~ m/^snap_${volname}_(\w+)$/;
+ next if $lv !~ m/^snap_${volname}_${PVE::JSONSchema::CONFIGID_RE}$/;
my $cmd = ['/sbin/lvremove', '-f', "$vg/$lv"];
run_command($cmd, errmsg => "lvremove snapshot '$vg/$lv' error");
}
push @$res, {
volid => $volid, format => 'raw', size => $info->{lv_size}, vmid => $owner,
+ ctime => $info->{ctime},
};
}
}
return $res;
}
+sub list_thinpools {
+ my ($vg) = @_;
+
+ my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+ my $thinpools = [];
+
+ foreach my $vg (keys %$lvs) {
+ foreach my $lvname (keys %{$lvs->{$vg}}) {
+ next if $lvs->{$vg}->{$lvname}->{lv_type} ne 't';
+ my $lv = $lvs->{$vg}->{$lvname};
+ $lv->{lv} = $lvname;
+ push @$thinpools, $lv;
+ }
+ }
+
+ return $thinpools;
+}
+
sub status {
my ($class, $storeid, $scfg, $cache) = @_;
my $snapvol = "snap_${volname}_$snapname";
my $cmd = ['/sbin/lvchange', '-ay', '-K', "$vg/$snapvol"];
run_command($cmd, errmsg => "activate_volume '$vg/$snapvol' error");
+ } elsif ($volname =~ /^base-/) {
+ my $cmd = ['/sbin/lvchange', '-ay', '-K', "$vg/$volname"];
+ run_command($cmd, errmsg => "activate_volume '$vg/$volname' error");
} else {
# other volumes are active by default
}
my $snapvol = "snap_${volname}_$snapname";
my $cmd = ['/sbin/lvchange', '-an', "$vg/$snapvol"];
run_command($cmd, errmsg => "deactivate_volume '$vg/$snapvol' error");
+ } elsif ($volname =~ /^base-/) {
+ my $cmd = ['/sbin/lvchange', '-an', "$vg/$volname"];
+ run_command($cmd, errmsg => "deactivate_volume '$vg/$volname' error");
} else {
# other volumes are kept active
}
sub clone_image {
my ($class, $scfg, $storeid, $volname, $vmid, $snap) = @_;
- die "clone_image from snapshots not implemented" if $snap;
+ my $vg = $scfg->{vgname};
- my ($vtype, undef, undef, undef, undef, $isBase, $format) =
- $class->parse_volname($volname);
+ my $lv;
- die "clone_image only works on base images\n" if !$isBase;
+ if ($snap) {
+ $lv = "$vg/snap_${volname}_$snap";
+ } else {
+ my ($vtype, undef, undef, undef, undef, $isBase, $format) =
+ $class->parse_volname($volname);
- my $vg = $scfg->{vgname};
- my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+ die "clone_image only works on base images\n" if !$isBase;
+
+ $lv = "$vg/$volname";
+ }
- my $name = PVE::Storage::LVMPlugin::lvm_find_free_diskname($lvs, $vg, $storeid, $vmid);
+ my $name = $class->find_free_diskname($storeid, $scfg, $vmid);
- my $cmd = ['/sbin/lvcreate', '-n', $name, '-prw', '-kn', '-s', "$vg/$volname"];
- run_command($cmd, errmsg => "clone image '$vg/$volname' error");
+ my $cmd = ['/sbin/lvcreate', '-n', $name, '-prw', '-kn', '-s', $lv];
+ run_command($cmd, errmsg => "clone image '$lv' error");
return $name;
}
my $features = {
snapshot => { current => 1 },
- clone => { base => 1},
+ clone => { base => 1, snap => 1},
template => { current => 1},
- copy => { base => 1, current => 1},
+ copy => { base => 1, current => 1, snap => 1},
+ sparseinit => { base => 1, current => 1},
};
my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
return undef;
}
+# used in LVMPlugin->volume_import
+sub volume_import_write {
+ my ($class, $input_fh, $output_file) = @_;
+ run_command(['dd', "of=$output_file", 'conv=sparse', 'bs=64k'],
+ input => '<&'.fileno($input_fh));
+}
+
1;