# lvcreate -n pvepool -L 20G pve
# lvconvert --type thin-pool pve/pvepool
+# NOTE: volumes which were created as linked clones of another base volume
+# are currently not tracking this relationship in their volume IDs. this is
+# generally not a problem, as LVM thin allows deletion of such base volumes
+# without affecting the linked clones. this leads to increased disk usage
+# when migrating LVM-thin volumes, which is normally prevented for linked clones.
+
use base qw(PVE::Storage::LVMPlugin);
sub type {
nodes => { optional => 1 },
disable => { optional => 1 },
content => { optional => 1 },
+ bwlimit => { optional => 1 },
};
}
+# NOTE: the fourth and fifth element of the returned array are always
+# undef, even if the volume is a linked clone of another volume. see note
+# at beginning of file.
+sub parse_volname {
+ my ($class, $volname) = @_;
+
+ PVE::Storage::Plugin::parse_lvm_name($volname);
+
+ if ($volname =~ m/^((vm|base)-(\d+)-\S+)$/) {
+ return ('images', $1, $3, undef, undef, $2 eq 'base', 'raw');
+ }
+
+ die "unable to parse lvm volume name '$volname'\n";
+}
+
+sub filesystem_path {
+ my ($class, $scfg, $volname, $snapname) = @_;
+
+ my ($vtype, $name, $vmid) = $class->parse_volname($volname);
+
+ my $vg = $scfg->{vgname};
+
+ my $path = defined($snapname) ? "/dev/$vg/snap_${name}_$snapname": "/dev/$vg/$name";
+
+ return wantarray ? ($path, $vmid, $vtype) : $path;
+}
+
sub alloc_image {
my ($class, $storeid, $scfg, $vmid, $fmt, $name, $size) = @_;
die "illegal name '$name' - sould be 'vm-$vmid-*'\n"
if $name && $name !~ m/^vm-$vmid-/;
+ my $vgs = PVE::Storage::LVMPlugin::lvm_vgs();
+
my $vg = $scfg->{vgname};
- if (!$name) {
- my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($scfg->{vgname});
+ die "no such volume group '$vg'\n" if !defined ($vgs->{$vg});
- for (my $i = 1; $i < 100; $i++) {
- my $tn = "vm-$vmid-disk-$i";
- if (!defined ($lvs->{$vg}->{$tn})) {
- $name = $tn;
- last;
- }
- }
- }
+ my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+
+ $name = PVE::Storage::LVMPlugin::lvm_find_free_diskname($lvs, $vg, $storeid, $vmid)
+ if !$name;
my $cmd = ['/sbin/lvcreate', '-aly', '-V', "${size}k", '--name', $name,
'--thinpool', "$vg/$scfg->{thinpool}" ];
my ($class, $storeid, $scfg, $volname, $isBase) = @_;
my $vg = $scfg->{vgname};
- my $cmd = ['/sbin/lvremove', '-f', "$vg/$volname"];
- run_command($cmd, errmsg => "lvremove '$vg/$volname' error");
+
+ my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+
+ if (my $dat = $lvs->{$scfg->{vgname}}) {
+
+ # remove all volume snapshots first
+ foreach my $lv (keys %$dat) {
+ next if $lv !~ m/^snap_${volname}_(\w+)$/;
+ my $cmd = ['/sbin/lvremove', '-f', "$vg/$lv"];
+ run_command($cmd, errmsg => "lvremove snapshot '$vg/$lv' error");
+ }
+
+ # finally remove original (if exists)
+ if ($dat->{$volname}) {
+ my $cmd = ['/sbin/lvremove', '-f', "$vg/$volname"];
+ run_command($cmd, errmsg => "lvremove '$vg/$volname' error");
+ }
+ }
return undef;
}
foreach my $volname (keys %$dat) {
- next if $volname !~ m/^vm-(\d+)-/;
- my $owner = $1;
+ next if $volname !~ m/^(vm|base)-(\d+)-/;
+ my $owner = $2;
my $info = $dat->{$volname};
return $res;
}
+sub list_thinpools {
+ my ($vg) = @_;
+
+ my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+ my $thinpools = [];
+
+ foreach my $lvname (keys %{$lvs->{$vg}}) {
+ next if $lvs->{$vg}->{$lvname}->{lv_type} ne 't';
+ push @$thinpools, { lv => $lvname };
+ }
+
+ return $thinpools;
+}
+
sub status {
my ($class, $storeid, $scfg, $cache) = @_;
sub activate_volume {
my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
- # do nothing
+ my $vg = $scfg->{vgname};
+
+ # only snapshot volumes needs activation
+ if ($snapname) {
+ my $snapvol = "snap_${volname}_$snapname";
+ my $cmd = ['/sbin/lvchange', '-ay', '-K', "$vg/$snapvol"];
+ run_command($cmd, errmsg => "activate_volume '$vg/$snapvol' error");
+ } elsif ($volname =~ /^base-/) {
+ my $cmd = ['/sbin/lvchange', '-ay', '-K', "$vg/$volname"];
+ run_command($cmd, errmsg => "activate_volume '$vg/$volname' error");
+ } else {
+ # other volumes are active by default
+ }
}
sub deactivate_volume {
my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
- # do nothing
+ my $vg = $scfg->{vgname};
+
+ # we only deactivate snapshot volumes
+ if ($snapname) {
+ my $snapvol = "snap_${volname}_$snapname";
+ my $cmd = ['/sbin/lvchange', '-an', "$vg/$snapvol"];
+ run_command($cmd, errmsg => "deactivate_volume '$vg/$snapvol' error");
+ } elsif ($volname =~ /^base-/) {
+ my $cmd = ['/sbin/lvchange', '-an', "$vg/$volname"];
+ run_command($cmd, errmsg => "deactivate_volume '$vg/$volname' error");
+ } else {
+ # other volumes are kept active
+ }
+}
+
+sub clone_image {
+ my ($class, $scfg, $storeid, $volname, $vmid, $snap) = @_;
+
+ my $vg = $scfg->{vgname};
+
+ my $lv;
+
+ if ($snap) {
+ $lv = "$vg/snap_${volname}_$snap";
+ } else {
+ my ($vtype, undef, undef, undef, undef, $isBase, $format) =
+ $class->parse_volname($volname);
+
+ die "clone_image only works on base images\n" if !$isBase;
+
+ $lv = "$vg/$volname";
+ }
+
+ my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+
+ my $name = PVE::Storage::LVMPlugin::lvm_find_free_diskname($lvs, $vg, $storeid, $vmid);
+
+ my $cmd = ['/sbin/lvcreate', '-n', $name, '-prw', '-kn', '-s', $lv];
+ run_command($cmd, errmsg => "clone image '$lv' error");
+
+ return $name;
}
-sub volume_resize {
- my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
+sub create_base {
+ my ($class, $storeid, $scfg, $volname) = @_;
+
+ my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =
+ $class->parse_volname($volname);
+
+ die "create_base not possible with base image\n" if $isBase;
+
+ my $vg = $scfg->{vgname};
+ my $lvs = PVE::Storage::LVMPlugin::lvm_list_volumes($vg);
+
+ if (my $dat = $lvs->{$vg}) {
+ # to avoid confusion, reject if we find volume snapshots
+ foreach my $lv (keys %$dat) {
+ die "unable to create base volume - found snaphost '$lv'\n"
+ if $lv =~ m/^snap_${volname}_(\w+)$/;
+ }
+ }
+
+ my $newname = $name;
+ $newname =~ s/^vm-/base-/;
+
+ my $cmd = ['/sbin/lvrename', $vg, $volname, $newname];
+ run_command($cmd, errmsg => "lvrename '$vg/$volname' => '$vg/$newname' error");
+
+ # set inactive, read-only and activationskip flags
+ $cmd = ['/sbin/lvchange', '-an', '-pr', '-ky', "$vg/$newname"];
+ eval { run_command($cmd); };
+ warn $@ if $@;
+
+ my $newvolname = $newname;
+
+ return $newvolname;
+}
+
+# sub volume_resize {} reuse code from parent class
+
+sub volume_snapshot {
+ my ($class, $scfg, $storeid, $volname, $snap) = @_;
+
+ my $vg = $scfg->{vgname};
+ my $snapvol = "snap_${volname}_$snap";
+
+ my $cmd = ['/sbin/lvcreate', '-n', $snapvol, '-pr', '-s', "$vg/$volname"];
+ run_command($cmd, errmsg => "lvcreate snapshot '$vg/$snapvol' error");
+
+}
+
+sub volume_snapshot_rollback {
+ my ($class, $scfg, $storeid, $volname, $snap) = @_;
+
+ my $vg = $scfg->{vgname};
+ my $snapvol = "snap_${volname}_$snap";
+
+ my $cmd = ['/sbin/lvremove', '-f', "$vg/$volname"];
+ run_command($cmd, errmsg => "lvremove '$vg/$volname' error");
+
+ $cmd = ['/sbin/lvcreate', '-kn', '-n', $volname, '-s', "$vg/$snapvol"];
+ run_command($cmd, errmsg => "lvm rollback '$vg/$snapvol' error");
+}
+
+sub volume_snapshot_delete {
+ my ($class, $scfg, $storeid, $volname, $snap) = @_;
+
+ my $vg = $scfg->{vgname};
+ my $snapvol = "snap_${volname}_$snap";
- die "volume_resize is not implemented for storage type 'lvmthin'\n";
+ my $cmd = ['/sbin/lvremove', '-f', "$vg/$snapvol"];
+ run_command($cmd, errmsg => "lvremove snapshot '$vg/$snapvol' error");
}
sub volume_has_feature {
my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running) = @_;
my $features = {
- copy => { base => 1, current => 1},
+ snapshot => { current => 1 },
+ clone => { base => 1, snap => 1},
+ template => { current => 1},
+ copy => { base => 1, current => 1, snap => 1},
+ sparseinit => { base => 1, current => 1},
};
my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =