]> git.proxmox.com Git - mirror_frr.git/blobdiff - bgpd/bgp_vty.c
Merge pull request #5717 from pguibert6WIND/flowspec_issue_redistribute
[mirror_frr.git] / bgpd / bgp_vty.c
index 2ccc9cfda9cba383cfd2a174790c64324fbe2eb2..696233e7a0ea5a3114434b21670412c0c0befaf1 100644 (file)
@@ -105,7 +105,7 @@ DEFINE_HOOK(bgp_inst_config_write,
                (struct bgp *bgp, struct vty *vty),
                (bgp, vty))
 
-#define GR_NO_OPER "The Graceful Restart No Operation was executed as cmd same as previous one"
+#define GR_NO_OPER "The Graceful Restart No Operation was executed as cmd same as previous one."
 #define GR_INVALID "The Graceful Restart command used is not valid at this moment."
 static struct peer_group *listen_range_exists(struct bgp *bgp,
                                              struct prefix *range, int exact);
@@ -781,8 +781,6 @@ static int bgp_peer_clear(struct peer *peer, afi_t afi, safi_t safi,
                        if (!peer->afc[tmp_afi][tmp_safi])
                                continue;
 
-                       bgp_peer_gr_flags_update(peer);
-
                        if (stype == BGP_CLEAR_SOFT_NONE)
                                ret = peer_clear(peer, &nnode);
                        else
@@ -798,8 +796,6 @@ static int bgp_peer_clear(struct peer *peer, afi_t afi, safi_t safi,
                        if (!peer->afc[afi][tmp_safi])
                                continue;
 
-                       bgp_peer_gr_flags_update(peer);
-
                        if (stype == BGP_CLEAR_SOFT_NONE)
                                ret = peer_clear(peer, &nnode);
                        else
@@ -828,7 +824,8 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
        int ret = 0;
        bool found = false;
        struct peer *peer;
-       struct listnode *node, *nnode;
+
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
 
        /* Clear all neighbors. */
        /*
@@ -838,11 +835,27 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
         */
        if (sort == clear_all) {
                for (ALL_LIST_ELEMENTS(bgp->peer, node, nnode, peer)) {
+
+                       bgp_peer_gr_flags_update(peer);
+
+                       if (CHECK_FLAG(peer->flags,
+                                       PEER_FLAG_GRACEFUL_RESTART))
+                               gr_router_detected = true;
+
                        ret = bgp_peer_clear(peer, afi, safi, nnode,
                                                          stype);
 
                        if (ret < 0)
                                bgp_clear_vty_error(vty, peer, afi, safi, ret);
+
+               }
+
+               if (gr_router_detected &&
+                       bgp->present_zebra_gr_state == ZEBRA_GR_DISABLE) {
+                       bgp_zebra_send_capabilities(bgp, false);
+               } else if (!gr_router_detected &&
+                       bgp->present_zebra_gr_state == ZEBRA_GR_ENABLE) {
+                       bgp_zebra_send_capabilities(bgp, true);
                }
 
                /* This is to apply read-only mode on this clear. */
@@ -879,6 +892,9 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
                        }
                }
 
+               VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+               VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
+
                ret = bgp_peer_clear(peer, afi, safi, NULL, stype);
 
                /* if afi/safi not defined for this peer, let caller know */
@@ -924,6 +940,12 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
                        if (peer->sort == BGP_PEER_IBGP)
                                continue;
 
+                       bgp_peer_gr_flags_update(peer);
+
+                       if (CHECK_FLAG(peer->flags,
+                               PEER_FLAG_GRACEFUL_RESTART))
+                               gr_router_detected = true;
+
                        ret = bgp_peer_clear(peer, afi, safi, nnode, stype);
 
                        if (ret < 0)
@@ -932,6 +954,14 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
                                found = true;
                }
 
+               if (gr_router_detected &&
+                       bgp->present_zebra_gr_state == ZEBRA_GR_DISABLE) {
+                       bgp_zebra_send_capabilities(bgp, false);
+               } else if (!gr_router_detected &&
+                       bgp->present_zebra_gr_state == ZEBRA_GR_ENABLE) {
+                       bgp_zebra_send_capabilities(bgp, true);
+               }
+
                if (!found)
                        vty_out(vty,
                                "%%BGP: No external %s peer is configured\n",
@@ -948,6 +978,12 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
                        if (peer->as != as)
                                continue;
 
+                       bgp_peer_gr_flags_update(peer);
+
+                       if (CHECK_FLAG(peer->flags,
+                               PEER_FLAG_GRACEFUL_RESTART))
+                               gr_router_detected = true;
+
                        ret = bgp_peer_clear(peer, afi, safi, nnode, stype);
 
                        if (ret < 0)
@@ -956,6 +992,14 @@ static int bgp_clear(struct vty *vty, struct bgp *bgp, afi_t afi, safi_t safi,
                                found = true;
                }
 
+               if (gr_router_detected &&
+                       bgp->present_zebra_gr_state == ZEBRA_GR_DISABLE) {
+                       bgp_zebra_send_capabilities(bgp, false);
+               } else if (!gr_router_detected &&
+                       bgp->present_zebra_gr_state == ZEBRA_GR_ENABLE) {
+                       bgp_zebra_send_capabilities(bgp, true);
+               }
+
                if (!found)
                        vty_out(vty,
                                "%%BGP: No %s peer is configured with AS %s\n",
@@ -2138,55 +2182,66 @@ DEFUN (no_bgp_deterministic_med,
 
 /* "bgp graceful-restart mode" configuration. */
 DEFUN (bgp_graceful_restart,
-               bgp_graceful_restart_cmd,
-               "bgp graceful-restart",
-               "BGP specific commands\n"
-               GR_CMD
+       bgp_graceful_restart_cmd,
+       "bgp graceful-restart",
+       "BGP specific commands\n"
+       GR_CMD
       )
 {
        int ret = BGP_GR_FAILURE;
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
-               zlog_debug("BGP_GR:: bgp_graceful_restart_cmd : START ");
+               zlog_debug("[BGP_GR] bgp_graceful_restart_cmd : START ");
+
        VTY_DECLVAR_CONTEXT(bgp, bgp);
 
        ret = bgp_gr_update_all(bgp, GLOBAL_GR_CMD);
 
+       VTY_BGP_GR_ROUTER_DETECT_AND_SEND_CAPABILITY_TO_ZEBRA(bgp,
+                               bgp->peer, ret);
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
-               zlog_debug("BGP_GR:: bgp_graceful_restart_cmd : END ");
+               zlog_debug("[BGP_GR] bgp_graceful_restart_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset all peers to take effect\n");
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (no_bgp_graceful_restart,
-               no_bgp_graceful_restart_cmd,
-               "no bgp graceful-restart",
-               NO_STR
-               "BGP specific commands\n"
-               NO_GR_CMD
+       no_bgp_graceful_restart_cmd,
+       "no bgp graceful-restart",
+       NO_STR
+       "BGP specific commands\n"
+       NO_GR_CMD
       )
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
-               zlog_debug("BGP_GR:: no_bgp_graceful_restart_cmd : START ");
+               zlog_debug("[BGP_GR] no_bgp_graceful_restart_cmd : START ");
 
        int ret = BGP_GR_FAILURE;
 
        ret = bgp_gr_update_all(bgp, NO_GLOBAL_GR_CMD);
 
+       VTY_BGP_GR_ROUTER_DETECT_AND_SEND_CAPABILITY_TO_ZEBRA(bgp,
+                       bgp->peer, ret);
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
-               zlog_debug("BGP_GR:: no_bgp_graceful_restart_cmd : END ");
+               zlog_debug("[BGP_GR] no_bgp_graceful_restart_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset all peers to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (bgp_graceful_restart_stalepath_time,
-               bgp_graceful_restart_stalepath_time_cmd,
-               "bgp graceful-restart stalepath-time (1-4095)",
-               "BGP specific commands\n"
-               "Graceful restart capability parameters\n"
-               "Set the max time to hold onto restarting peer's stale paths\n"
-               "Delay value (seconds)\n")
+       bgp_graceful_restart_stalepath_time_cmd,
+       "bgp graceful-restart stalepath-time (1-4095)",
+       "BGP specific commands\n"
+       "Graceful restart capability parameters\n"
+       "Set the max time to hold onto restarting peer's stale paths\n"
+       "Delay value (seconds)\n")
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
        int idx_number = 3;
@@ -2198,12 +2253,12 @@ DEFUN (bgp_graceful_restart_stalepath_time,
 }
 
 DEFUN (bgp_graceful_restart_restart_time,
-               bgp_graceful_restart_restart_time_cmd,
-               "bgp graceful-restart restart-time (1-4095)",
-               "BGP specific commands\n"
-               "Graceful restart capability parameters\n"
-               "Set the time to wait to delete stale routes before a BGP open message is received\n"
-               "Delay value (seconds)\n")
+       bgp_graceful_restart_restart_time_cmd,
+       "bgp graceful-restart restart-time (1-4095)",
+       "BGP specific commands\n"
+       "Graceful restart capability parameters\n"
+       "Set the time to wait to delete stale routes before a BGP open message is received\n"
+       "Delay value (seconds)\n")
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
        int idx_number = 3;
@@ -2237,13 +2292,13 @@ DEFUN (bgp_graceful_restart_select_defer_time,
 }
 
 DEFUN (no_bgp_graceful_restart_stalepath_time,
-               no_bgp_graceful_restart_stalepath_time_cmd,
-               "no bgp graceful-restart stalepath-time [(1-4095)]",
-               NO_STR
-               "BGP specific commands\n"
-               "Graceful restart capability parameters\n"
-               "Set the max time to hold onto restarting peer's stale paths\n"
-               "Delay value (seconds)\n")
+       no_bgp_graceful_restart_stalepath_time_cmd,
+       "no bgp graceful-restart stalepath-time [(1-4095)]",
+       NO_STR
+       "BGP specific commands\n"
+       "Graceful restart capability parameters\n"
+       "Set the max time to hold onto restarting peer's stale paths\n"
+       "Delay value (seconds)\n")
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
 
@@ -2252,13 +2307,13 @@ DEFUN (no_bgp_graceful_restart_stalepath_time,
 }
 
 DEFUN (no_bgp_graceful_restart_restart_time,
-               no_bgp_graceful_restart_restart_time_cmd,
-               "no bgp graceful-restart restart-time [(1-4095)]",
-               NO_STR
-               "BGP specific commands\n"
-               "Graceful restart capability parameters\n"
-               "Set the time to wait to delete stale routes before a BGP open message is received\n"
-               "Delay value (seconds)\n")
+       no_bgp_graceful_restart_restart_time_cmd,
+       "no bgp graceful-restart restart-time [(1-4095)]",
+       NO_STR
+       "BGP specific commands\n"
+       "Graceful restart capability parameters\n"
+       "Set the time to wait to delete stale routes before a BGP open message is received\n"
+       "Delay value (seconds)\n")
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
 
@@ -2284,11 +2339,11 @@ DEFUN (no_bgp_graceful_restart_select_defer_time,
 }
 
 DEFUN (bgp_graceful_restart_preserve_fw,
-               bgp_graceful_restart_preserve_fw_cmd,
-               "bgp graceful-restart preserve-fw-state",
-               "BGP specific commands\n"
-               "Graceful restart capability parameters\n"
-               "Sets F-bit indication that fib is preserved while doing Graceful Restart\n")
+       bgp_graceful_restart_preserve_fw_cmd,
+       "bgp graceful-restart preserve-fw-state",
+       "BGP specific commands\n"
+       "Graceful restart capability parameters\n"
+       "Sets F-bit indication that fib is preserved while doing Graceful Restart\n")
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
        bgp_flag_set(bgp, BGP_FLAG_GR_PRESERVE_FWD);
@@ -2296,12 +2351,12 @@ DEFUN (bgp_graceful_restart_preserve_fw,
 }
 
 DEFUN (no_bgp_graceful_restart_preserve_fw,
-               no_bgp_graceful_restart_preserve_fw_cmd,
-               "no bgp graceful-restart preserve-fw-state",
-               NO_STR
-               "BGP specific commands\n"
-               "Graceful restart capability parameters\n"
-               "Unsets F-bit indication that fib is preserved while doing Graceful Restart\n")
+       no_bgp_graceful_restart_preserve_fw_cmd,
+       "no bgp graceful-restart preserve-fw-state",
+       NO_STR
+       "BGP specific commands\n"
+       "Graceful restart capability parameters\n"
+       "Unsets F-bit indication that fib is preserved while doing Graceful Restart\n")
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
        bgp_flag_unset(bgp, BGP_FLAG_GR_PRESERVE_FWD);
@@ -2309,248 +2364,356 @@ DEFUN (no_bgp_graceful_restart_preserve_fw,
 }
 
 DEFUN (bgp_graceful_restart_disable,
-               bgp_graceful_restart_disable_cmd,
-               "bgp graceful-restart-disable",
-               "BGP specific commands\n"
-               GR_DISABLE)
+       bgp_graceful_restart_disable_cmd,
+       "bgp graceful-restart-disable",
+       "BGP specific commands\n"
+       GR_DISABLE)
 {
        int ret = BGP_GR_FAILURE;
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_graceful_restart_disable_cmd : START ");
+                       "[BGP_GR] bgp_graceful_restart_disable_cmd : START ");
+
        VTY_DECLVAR_CONTEXT(bgp, bgp);
 
        ret = bgp_gr_update_all(bgp, GLOBAL_DISABLE_CMD);
 
+       VTY_BGP_GR_ROUTER_DETECT_AND_SEND_CAPABILITY_TO_ZEBRA(bgp,
+                               bgp->peer, ret);
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_graceful_restart_disable_cmd : END ");
+                       "[BGP_GR] bgp_graceful_restart_disable_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset all peers to take effect\n");
+
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (no_bgp_graceful_restart_disable,
-               no_bgp_graceful_restart_disable_cmd,
-               "no bgp graceful-restart-disable",
-               NO_STR
-               "BGP specific commands\n"
-               NO_GR_DISABLE
+       no_bgp_graceful_restart_disable_cmd,
+       "no bgp graceful-restart-disable",
+       NO_STR
+       "BGP specific commands\n"
+       NO_GR_DISABLE
       )
 {
        VTY_DECLVAR_CONTEXT(bgp, bgp);
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_graceful_restart_disable_cmd : START ");
+                       "[BGP_GR] no_bgp_graceful_restart_disable_cmd : START ");
 
        int ret = BGP_GR_FAILURE;
 
        ret = bgp_gr_update_all(bgp, NO_GLOBAL_DISABLE_CMD);
 
+       VTY_BGP_GR_ROUTER_DETECT_AND_SEND_CAPABILITY_TO_ZEBRA(bgp,
+                               bgp->peer, ret);
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_graceful_restart_disable_cmd : END ");
+                       "[BGP_GR] no_bgp_graceful_restart_disable_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset all peers to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (bgp_neighbor_graceful_restart_set,
-               bgp_neighbor_graceful_restart_set_cmd,
-               "neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart",
-               NEIGHBOR_STR
-               NEIGHBOR_ADDR_STR2
-               GR_NEIGHBOR_CMD
+       bgp_neighbor_graceful_restart_set_cmd,
+       "neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart",
+       NEIGHBOR_STR
+       NEIGHBOR_ADDR_STR2
+       GR_NEIGHBOR_CMD
       )
 {
        int idx_peer = 1;
        struct peer *peer;
        int ret = BGP_GR_FAILURE;
 
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_neighbor_graceful_restart_set_cmd : START ");
+                       "[BGP_GR] bgp_neighbor_graceful_restart_set_cmd : START ");
+
        peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
        if (!peer)
                return CMD_WARNING_CONFIG_FAILED;
 
        ret = bgp_neighbor_graceful_restart(peer, PEER_GR_CMD);
 
-       if (peer->bgp->t_startup)
-               bgp_peer_gr_flags_update(peer);
+       VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+       VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_neighbor_graceful_restart_set_cmd : END ");
+                       "[BGP_GR] bgp_neighbor_graceful_restart_set_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset this peer to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (no_bgp_neighbor_graceful_restart,
-               no_bgp_neighbor_graceful_restart_set_cmd,
-               "no neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart",
-               NO_STR
-               NEIGHBOR_STR
-               NEIGHBOR_ADDR_STR2
-               NO_GR_NEIGHBOR_CMD
+       no_bgp_neighbor_graceful_restart_set_cmd,
+       "no neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart",
+       NO_STR
+       NEIGHBOR_STR
+       NEIGHBOR_ADDR_STR2
+       NO_GR_NEIGHBOR_CMD
       )
 {
        int idx_peer = 2;
        int ret = BGP_GR_FAILURE;
        struct peer *peer;
 
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
+
        peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
        if (!peer)
                return CMD_WARNING_CONFIG_FAILED;
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_neighbor_graceful_restart_set_cmd : START ");
+                       "[BGP_GR] no_bgp_neighbor_graceful_restart_set_cmd : START ");
 
        ret = bgp_neighbor_graceful_restart(peer, NO_PEER_GR_CMD);
 
-       if (peer->bgp->t_startup)
-               bgp_peer_gr_flags_update(peer);
+       VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+       VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_neighbor_graceful_restart_set_cmd : END ");
+                       "[BGP_GR] no_bgp_neighbor_graceful_restart_set_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset this peer to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (bgp_neighbor_graceful_restart_helper_set,
-               bgp_neighbor_graceful_restart_helper_set_cmd,
-               "neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-helper",
-               NEIGHBOR_STR
-               NEIGHBOR_ADDR_STR2
-               GR_NEIGHBOR_HELPER_CMD
+       bgp_neighbor_graceful_restart_helper_set_cmd,
+       "neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-helper",
+       NEIGHBOR_STR
+       NEIGHBOR_ADDR_STR2
+       GR_NEIGHBOR_HELPER_CMD
       )
 {
        int idx_peer = 1;
        struct peer *peer;
        int ret = BGP_GR_FAILURE;
 
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_neighbor_graceful_restart_set_helper_cmd : START ");
-       peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
+                       "[BGP_GR] bgp_neighbor_graceful_restart_helper_set_cmd : START ");
 
-       if (peer->bgp->t_startup)
-               bgp_peer_gr_flags_update(peer);
+       peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
 
        if (!peer)
                return CMD_WARNING_CONFIG_FAILED;
 
 
        ret = bgp_neighbor_graceful_restart(peer, PEER_HELPER_CMD);
+
+       VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+       VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_neighbor_graceful_restart_helper_set_cmd : END ");
+                       "[BGP_GR] bgp_neighbor_graceful_restart_helper_set_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset this peer to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (no_bgp_neighbor_graceful_restart_helper,
-               no_bgp_neighbor_graceful_restart_helper_set_cmd,
-               "no neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-helper",
-               NO_STR
-               NEIGHBOR_STR
-               NEIGHBOR_ADDR_STR2
-               NO_GR_NEIGHBOR_HELPER_CMD
+       no_bgp_neighbor_graceful_restart_helper_set_cmd,
+       "no neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-helper",
+       NO_STR
+       NEIGHBOR_STR
+       NEIGHBOR_ADDR_STR2
+       NO_GR_NEIGHBOR_HELPER_CMD
       )
 {
        int idx_peer = 2;
        int ret = BGP_GR_FAILURE;
        struct peer *peer;
 
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
+
        peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
        if (!peer)
                return CMD_WARNING_CONFIG_FAILED;
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_neighbor_graceful_restart_helper_set_cmd : START ");
+                       "[BGP_GR] no_bgp_neighbor_graceful_restart_helper_set_cmd : START ");
 
        ret = bgp_neighbor_graceful_restart(peer,
                        NO_PEER_HELPER_CMD);
 
-       if (peer->bgp->t_startup)
-               bgp_peer_gr_flags_update(peer);
+       VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+       VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_neighbor_graceful_restart_set_cmd : END ");
+                       "[BGP_GR] no_bgp_neighbor_graceful_restart_helper_set_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset this peer to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (bgp_neighbor_graceful_restart_disable_set,
-               bgp_neighbor_graceful_restart_disable_set_cmd,
-               "neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-disable",
-               NEIGHBOR_STR
-               NEIGHBOR_ADDR_STR2
-               GR_NEIGHBOR_DISABLE_CMD
+       bgp_neighbor_graceful_restart_disable_set_cmd,
+       "neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-disable",
+       NEIGHBOR_STR
+       NEIGHBOR_ADDR_STR2
+       GR_NEIGHBOR_DISABLE_CMD
       )
 {
        int idx_peer = 1;
        struct peer *peer;
        int ret = BGP_GR_FAILURE;
 
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: bgp_neighbor_graceful_restart_disable_set_cmd : START ");
+                       "[BGP_GR] bgp_neighbor_graceful_restart_disable_set_cmd : START ");
 
        peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
        if (!peer)
                return CMD_WARNING_CONFIG_FAILED;
 
-
        ret = bgp_neighbor_graceful_restart(peer,
-                       PEER_DISABLE_cmd);
+                               PEER_DISABLE_CMD);
 
        if (peer->bgp->t_startup)
                bgp_peer_gr_flags_update(peer);
 
+       VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+       VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
+
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR::bgp_neighbor_graceful_restart_disable_set_cmd : END ");
+                       "[BGP_GR]bgp_neighbor_graceful_restart_disable_set_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset this peer to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
 DEFUN (no_bgp_neighbor_graceful_restart_disable,
-               no_bgp_neighbor_graceful_restart_disable_set_cmd,
-               "no neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-disable",
-               NO_STR
-               NEIGHBOR_STR
-               NEIGHBOR_ADDR_STR2
-               NO_GR_NEIGHBOR_DISABLE_CMD
+       no_bgp_neighbor_graceful_restart_disable_set_cmd,
+       "no neighbor <A.B.C.D|X:X::X:X|WORD> graceful-restart-disable",
+       NO_STR
+       NEIGHBOR_STR
+       NEIGHBOR_ADDR_STR2
+       NO_GR_NEIGHBOR_DISABLE_CMD
       )
 {
        int idx_peer = 2;
        int ret = BGP_GR_FAILURE;
        struct peer *peer;
 
+       VTY_BGP_GR_DEFINE_LOOP_VARIABLE;
+
        peer = peer_and_group_lookup_vty(vty, argv[idx_peer]->arg);
        if (!peer)
                return CMD_WARNING_CONFIG_FAILED;
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_neighbor_graceful_restart_disable_set_cmd : START ");
+                       "[BGP_GR] no_bgp_neighbor_graceful_restart_disable_set_cmd : START ");
 
        ret = bgp_neighbor_graceful_restart(peer, NO_PEER_DISABLE_CMD);
 
-       if (peer->bgp->t_startup)
-               bgp_peer_gr_flags_update(peer);
+       VTY_BGP_GR_ROUTER_DETECT(bgp, peer, peer->bgp->peer);
+       VTY_SEND_BGP_GR_CAPABILITY_TO_ZEBRA(peer->bgp, ret);
 
        if (BGP_DEBUG(graceful_restart, GRACEFUL_RESTART))
                zlog_debug(
-                               "BGP_GR:: no_bgp_neighbor_graceful_restart_set_cmd : END ");
+                       "[BGP_GR] no_bgp_neighbor_graceful_restart_disable_set_cmd : END ");
+       vty_out(vty,
+               "Graceful restart configuration changed, reset this peer to take effect\n");
 
        return bgp_vty_return(vty, ret);
 }
 
+DEFUN_HIDDEN (bgp_graceful_restart_disable_eor,
+              bgp_graceful_restart_disable_eor_cmd,
+              "bgp graceful-restart disable-eor",
+              "BGP specific commands\n"
+              "Graceful restart configuration parameters\n"
+              "Disable EOR Check\n")
+{
+       VTY_DECLVAR_CONTEXT(bgp, bgp);
+       bgp_flag_set(bgp, BGP_FLAG_GR_DISABLE_EOR);
+
+       return CMD_SUCCESS;
+}
+
+DEFUN_HIDDEN (no_bgp_graceful_restart_disable_eor,
+              no_bgp_graceful_restart_disable_eor_cmd,
+              "no bgp graceful-restart disable-eor",
+              NO_STR
+              "BGP specific commands\n"
+              "Graceful restart configuration parameters\n"
+              "Disable EOR Check\n")
+{
+       VTY_DECLVAR_CONTEXT(bgp, bgp);
+       bgp_flag_unset(bgp, BGP_FLAG_GR_DISABLE_EOR);
+
+       return CMD_SUCCESS;
+}
+
+DEFUN (bgp_graceful_restart_rib_stale_time,
+       bgp_graceful_restart_rib_stale_time_cmd,
+       "bgp graceful-restart rib-stale-time (1-3600)",
+       "BGP specific commands\n"
+       "Graceful restart configuration parameters\n"
+       "Specify the stale route removal timer in rib\n"
+       "Delay value (seconds)\n")
+{
+       VTY_DECLVAR_CONTEXT(bgp, bgp);
+       int idx_number = 3;
+       uint32_t stale_time;
+
+       stale_time = strtoul(argv[idx_number]->arg, NULL, 10);
+       bgp->rib_stale_time = stale_time;
+       /* Send the stale timer update message to RIB */
+       if (bgp_zebra_stale_timer_update(bgp))
+               return CMD_WARNING;
+
+       return CMD_SUCCESS;
+}
+
+DEFUN (no_bgp_graceful_restart_rib_stale_time,
+       no_bgp_graceful_restart_rib_stale_time_cmd,
+       "no bgp graceful-restart rib-stale-time [(1-3600)]",
+       NO_STR
+       "BGP specific commands\n"
+       "Graceful restart configuration parameters\n"
+       "Specify the stale route removal timer in rib\n"
+       "Delay value (seconds)\n")
+{
+       VTY_DECLVAR_CONTEXT(bgp, bgp);
+
+       bgp->rib_stale_time = BGP_DEFAULT_RIB_STALE_TIME;
+       /* Send the stale timer update message to RIB */
+       if (bgp_zebra_stale_timer_update(bgp))
+               return CMD_WARNING;
+
+       return CMD_SUCCESS;
+}
+
 /* "bgp graceful-shutdown" configuration */
 DEFUN (bgp_graceful_shutdown,
        bgp_graceful_shutdown_cmd,
@@ -9291,20 +9454,19 @@ static void bgp_show_peer_afi_orf_cap(struct vty *vty, struct peer *p,
        }
 }
 
-static void bgp_show_neighnor_graceful_restart_rbit(
-                                               struct vty *vty,
-                                               struct peer *p,
-                                               bool use_json,
-                                               json_object *json)
+static void bgp_show_neighnor_graceful_restart_rbit(struct vty *vty,
+                                                   struct peer *p,
+                                                   bool use_json,
+                                                   json_object *json)
 {
        bool rbit_status = 0;
 
        if (!use_json)
                vty_out(vty, "\n    R bit          : ");
 
-       if (CHECK_FLAG(p->cap, PEER_CAP_RESTART_ADV) &&
-               (CHECK_FLAG(p->cap, PEER_CAP_RESTART_RCV)) &&
-               (p->status == Established)) {
+       if (CHECK_FLAG(p->cap, PEER_CAP_RESTART_ADV)
+           && (CHECK_FLAG(p->cap, PEER_CAP_RESTART_RCV))
+           && (p->status == Established)) {
 
                if (CHECK_FLAG(p->cap, PEER_CAP_RESTART_BIT_RCV))
                        rbit_status = 1;
@@ -9314,64 +9476,57 @@ static void bgp_show_neighnor_graceful_restart_rbit(
 
        if (rbit_status) {
                if (use_json)
-                       json_object_boolean_true_add(
-                                       json, "rBit");
+                       json_object_boolean_true_add(json, "rBit");
                else
                        vty_out(vty, "True\n");
        } else {
                if (use_json)
-                       json_object_boolean_false_add(
-                                       json, "rBit");
+                       json_object_boolean_false_add(json, "rBit");
                else
                        vty_out(vty, "False\n");
        }
 }
 
-static void bgp_show_neighbor_graceful_restart_remote_mode(
-                                               struct vty *vty,
-                                               struct peer *peer,
-                                               bool use_json,
-                                               json_object *json)
+static void bgp_show_neighbor_graceful_restart_remote_mode(struct vty *vty,
+                                                          struct peer *peer,
+                                                          bool use_json,
+                                                          json_object *json)
 {
-       const char *mode = "NotReceived";
+       const char *mode = "NotApplicable";
 
        if (!use_json)
                vty_out(vty, "\n    Remote GR Mode : ");
 
-       if (CHECK_FLAG(peer->cap, PEER_CAP_RESTART_ADV) &&
-               (CHECK_FLAG(peer->cap, PEER_CAP_RESTART_RCV)) &&
-               (peer->status == Established)) {
+       if (CHECK_FLAG(peer->cap, PEER_CAP_RESTART_ADV)
+           && (peer->status == Established)) {
 
-               if ((peer->nsf_af_count == 0) &&
-                       !CHECK_FLAG(peer->cap, PEER_CAP_RESTART_RCV)) {
+               if ((peer->nsf_af_count == 0)
+                   && !CHECK_FLAG(peer->cap, PEER_CAP_RESTART_RCV)) {
 
-                       /*Gr disabled case*/
                        mode = "Disable";
 
-               } else if (peer->nsf_af_count == 0) {
+               } else if (peer->nsf_af_count == 0
+                          && CHECK_FLAG(peer->cap, PEER_CAP_RESTART_RCV)) {
 
-                       /* Helper */
                        mode = "Helper";
 
-               } else if (peer->nsf_af_count != 0) {
+               } else if (peer->nsf_af_count != 0
+                          && CHECK_FLAG(peer->cap, PEER_CAP_RESTART_RCV)) {
 
-                       /* Restart */
                        mode = "Restart";
-
                }
        }
 
        if (use_json) {
-               json_object_string_add(json,
-                               "remoteGrMode", mode);
+               json_object_string_add(json, "remoteGrMode", mode);
        } else
                vty_out(vty, mode, "\n");
 }
 
-static void  bgp_show_neighbor_graceful_restart_local_mode(struct vty *vty,
-                                               struct peer *p,
-                                               bool use_json,
-                                               json_object *json)
+static void bgp_show_neighbor_graceful_restart_local_mode(struct vty *vty,
+                                                         struct peer *p,
+                                                         bool use_json,
+                                                         json_object *json)
 {
        const char *mode = "Invalid";
 
@@ -9384,7 +9539,7 @@ static void  bgp_show_neighbor_graceful_restart_local_mode(struct vty *vty,
                mode = "Restart";
        else if (bgp_peer_gr_mode_get(p) == PEER_DISABLE)
                mode = "Disable";
-       else if (bgp_peer_gr_mode_get(p) == PEER_GLOBAL_INHERIT)
+       else if (bgp_peer_gr_mode_get(p) == PEER_GLOBAL_INHERIT) {
                if (bgp_global_gr_mode_get(p->bgp) == GLOBAL_HELPER)
                        mode = "Helper*";
                else if (bgp_global_gr_mode_get(p->bgp) == GLOBAL_GR)
@@ -9393,211 +9548,214 @@ static void  bgp_show_neighbor_graceful_restart_local_mode(struct vty *vty,
                        mode = "Disable*";
                else
                        mode = "Invalid*";
-       else
-               mode = "Invalid";
+       }
 
        if (use_json) {
-               json_object_string_add(json,
-                               "localGrMode", mode);
+               json_object_string_add(json, "localGrMode", mode);
        } else {
                vty_out(vty, mode, "\n");
        }
 }
 
-static void  bgp_show_neighbor_graceful_restart_capability_per_afi_safi(
-                                       struct vty *vty, struct peer *peer,
-                                       bool use_json, json_object *json)
+static void bgp_show_neighbor_graceful_restart_capability_per_afi_safi(
+       struct vty *vty, struct peer *peer, bool use_json, json_object *json)
 {
-       afi_t afi = AFI_MAX;
-       safi_t safi = SAFI_MAX;
+       afi_t afi;
+       safi_t safi;
        json_object *json_afi_safi = NULL;
        json_object *json_timer = NULL;
        json_object *json_endofrib_status = NULL;
+       bool eor_flag = false;
 
        for (afi = AFI_IP; afi < AFI_MAX; afi++) {
                for (safi = SAFI_UNICAST; safi <= SAFI_MPLS_VPN; safi++) {
+                       if (!peer->afc[afi][safi])
+                               continue;
 
-                       if (peer->afc_nego[afi][safi]
-                               && CHECK_FLAG(peer->cap, PEER_CAP_RESTART_ADV)
-                               && CHECK_FLAG(peer->af_cap[afi][safi],
-                               PEER_CAP_RESTART_AF_RCV)) {
+                       if (!CHECK_FLAG(peer->cap, PEER_CAP_RESTART_ADV)
+                           || !CHECK_FLAG(peer->cap, PEER_CAP_RESTART_RCV))
+                               continue;
 
-                               if (use_json) {
-                                       json_afi_safi =
-                                               json_object_new_object();
-                                       json_endofrib_status =
-                                               json_object_new_object();
-                                       json_timer =
-                                               json_object_new_object();
-                               }
+                       if (use_json) {
+                               json_afi_safi = json_object_new_object();
+                               json_endofrib_status = json_object_new_object();
+                               json_timer = json_object_new_object();
+                       }
+
+                       if (peer->eor_stime[afi][safi]
+                           >= peer->pkt_stime[afi][safi])
+                               eor_flag = true;
+                       else
+                               eor_flag = false;
 
-                               if (!use_json) {
-                                       vty_out(vty, "    %s :\n",
+                       if (!use_json) {
+                               vty_out(vty, "    %s :\n",
                                        get_afi_safi_str(afi, safi, false));
 
-                                       vty_out(vty,
-                                       "     F bit                 : ");
-                               } else
-                                       get_afi_safi_str(afi, safi, true);
+                               vty_out(vty, "     F bit                 : ");
+                       }
 
-                               if (peer->nsf[afi][safi]
-                                       && CHECK_FLAG(
-                                       peer->af_cap[afi][safi],
-                                       PEER_CAP_RESTART_AF_PRESERVE_RCV)) {
+                       if (peer->nsf[afi][safi]
+                           && CHECK_FLAG(peer->af_cap[afi][safi],
+                                         PEER_CAP_RESTART_AF_PRESERVE_RCV)) {
 
-                                       if (use_json) {
-                                               json_object_boolean_true_add(
+                               if (use_json) {
+                                       json_object_boolean_true_add(
                                                json_afi_safi, "fBit");
-                                       } else {
-                                               vty_out(vty,
-                                                       "True\n");
-                                       }
-
-                               } else {
-
-                                       if (use_json) {
-                                               json_object_boolean_false_add(
+                               } else
+                                       vty_out(vty, "True\n");
+                       } else {
+                               if (use_json)
+                                       json_object_boolean_false_add(
                                                json_afi_safi, "fBit");
-                                       } else {
-                                               vty_out(vty,
-                                                       "False\n");
-                                       }
+                               else
+                                       vty_out(vty, "False\n");
+                       }
 
-                               }
+                       if (!use_json)
+                               vty_out(vty, "     End-of-RIB Received   : ");
 
-                               if (!use_json)
-                                       vty_out(vty,
-                                       "     End-of-RIB Received   : ");
+                       if (CHECK_FLAG(peer->af_sflags[afi][safi],
+                                      PEER_STATUS_EOR_RECEIVED)) {
+                               if (use_json)
+                                       json_object_boolean_true_add(
+                                               json_endofrib_status,
+                                               "endOfRibRecv");
+                               else
+                                       vty_out(vty, "Yes\n");
+                       } else {
+                               if (use_json)
+                                       json_object_boolean_false_add(
+                                               json_endofrib_status,
+                                               "endOfRibRecv");
+                               else
+                                       vty_out(vty, "No\n");
+                       }
 
-                               if (CHECK_FLAG(peer->af_sflags[afi][safi],
-                                               PEER_STATUS_EOR_RECEIVED)) {
+                       if (!use_json)
+                               vty_out(vty, "     End-of-RIB Send       : ");
 
-                                       if (use_json) {
-                                               json_object_boolean_true_add(
+                       if (CHECK_FLAG(peer->af_sflags[afi][safi],
+                                      PEER_STATUS_EOR_SEND)) {
+                               if (use_json) {
+                                       json_object_boolean_true_add(
                                                json_endofrib_status,
-                                                       "endOfRibRecv");
-                                       } else {
-                                               vty_out(vty, "Yes\n");
-                                       }
+                                               "endOfRibSend");
 
+                                       PRINT_EOR_JSON(eor_flag);
                                } else {
-                                       if (use_json) {
-                                               json_object_boolean_false_add(
-                                               json_endofrib_status,
-                                                       "endOfRibRecv");
-                                       } else {
-                                               vty_out(vty, "No\n");
-                                       }
-                               }
-
-                               if (!use_json)
+                                       vty_out(vty, "Yes\n");
                                        vty_out(vty,
-                                       "     End-of-RIB Send       : ");
-
-                               if (CHECK_FLAG(peer->af_sflags[afi][safi],
-                                               PEER_STATUS_EOR_SEND)) {
+                                               "     EoRSentAfterUpdate   : ");
 
-                                       if (use_json) {
-                                               json_object_boolean_true_add(
+                                       PRINT_EOR(eor_flag);
+                               }
+                       } else {
+                               if (use_json) {
+                                       json_object_boolean_false_add(
                                                json_endofrib_status,
-                                                        "endOfRibSend");
-                                       } else {
-                                               vty_out(vty, "Yes\n");
-                                       }
-
-                               } else {
-                                       if (use_json) {
-                                               json_object_boolean_false_add(
+                                               "endOfRibSend");
+                                       json_object_boolean_false_add(
                                                json_endofrib_status,
-                                                       "endOfRibSend");
-                                       } else {
-                                               vty_out(vty, "No\n");
-                                       }
+                                               "endOfRibSentAfterUpdate");
+                               } else {
+                                       vty_out(vty, "No\n");
+                                       vty_out(vty,
+                                               "     EoRSentAfterUpdate   : ");
+                                       vty_out(vty, "No\n");
                                }
+                       }
 
-                               if (use_json) {
-
-                                       json_object_int_add(json_timer,
-                                               "stalePathTimer",
-                                               peer->bgp->stalepath_time);
-
-                                       if (peer->t_gr_stale != NULL) {
+                       if (use_json) {
+                               json_object_int_add(json_timer,
+                                                   "stalePathTimer",
+                                                   peer->bgp->stalepath_time);
 
-                                               json_object_int_add(
+                               if (peer->t_gr_stale != NULL) {
+                                       json_object_int_add(
                                                json_timer,
                                                "stalePathTimerRemaining",
                                                thread_timer_remain_second(
-                                               peer->t_gr_stale));
-                                       }
+                                                       peer->t_gr_stale));
+                               }
 
-                                       json_object_int_add(json_timer,
+                               /* Display Configured Selection
+                                * Deferral only when when
+                                * Gr mode is enabled.
+                                */
+                               if (CHECK_FLAG(peer->flags,
+                                              PEER_FLAG_GRACEFUL_RESTART)) {
+                                       json_object_int_add(
+                                               json_timer,
                                                "selectionDeferralTimer",
                                                peer->bgp->stalepath_time);
+                               }
 
-                                       if (peer->bgp
-                                               ->gr_info[afi][safi]
-                                               .t_select_deferral != NULL) {
+                               if (peer->bgp->gr_info[afi][safi]
+                                           .t_select_deferral
+                                   != NULL) {
 
-                                               json_object_int_add(
+                                       json_object_int_add(
                                                json_timer,
                                                "selectionDeferralTimerRemaining",
                                                thread_timer_remain_second(
-                                               peer->bgp
-                                               ->gr_info[afi][safi]
-                                               .t_select_deferral));
-                                       }
-
-                               } else {
+                                                       peer->bgp
+                                                               ->gr_info[afi]
+                                                                        [safi]
+                                                               .t_select_deferral));
+                               }
+                       } else {
+                               vty_out(vty, "     Timers:\n");
 
-                                       vty_out(vty, "     Timers:\n");
+                               vty_out(vty, "%*s", 6, "");
+                               vty_out(vty,
+                                       "Configured Stale Path Time(sec)%*s: %u\n",
+                                       8, "", peer->bgp->stalepath_time);
 
+                               if (peer->t_gr_stale != NULL) {
                                        vty_out(vty, "%*s", 6, "");
                                        vty_out(vty,
-                                       "Stale Path Time(sec)%*s: %u\n",
-                                               19, "",
-                                       peer->bgp->stalepath_time);
-
-                                       if (peer->t_gr_stale != NULL) {
-                                               vty_out(vty, "%*s", 6, "");
-                                               vty_out(vty,
                                                "Stale Path Remaining(sec)%*s: %ld\n",
                                                14, "",
                                                thread_timer_remain_second(
-                                               peer->t_gr_stale));
-                                       }
-
+                                                       peer->t_gr_stale));
+                               }
+                               /* Display Configured Selection
+                                * Deferral only when when
+                                * Gr mode is enabled.
+                                */
+                               if (CHECK_FLAG(peer->flags,
+                                              PEER_FLAG_GRACEFUL_RESTART)) {
                                        vty_out(vty, "%*s", 6, "");
                                        vty_out(vty,
-                                       "Selection Deferral Time(sec)%*s: %u\n",
-                                       11, "",
-                                       peer->bgp->select_defer_time);
+                                               "Configured Selection Deferral Time(sec): %u\n",
+                                               peer->bgp->select_defer_time);
+                               }
 
-                                       if (peer->bgp
-                                               ->gr_info[afi][safi]
-                                               .t_select_deferral != NULL) {
+                               if (peer->bgp->gr_info[afi][safi]
+                                           .t_select_deferral
+                                   != NULL) {
 
-                                               vty_out(vty, "%*s", 6, "");
-                                               vty_out(vty,
+                                       vty_out(vty, "%*s", 6, "");
+                                       vty_out(vty,
                                                "Selection Deferral Time Remaining(sec) : %ld\n",
                                                thread_timer_remain_second(
-                                               peer->bgp
-                                               ->gr_info[afi][safi]
-                                               .t_select_deferral));
-                                       }
-
-                               }
-                               if (use_json) {
-                                       json_object_object_add(json_afi_safi,
-                                                       "endOfRibStatus",
-                                                        json_endofrib_status);
-                                       json_object_object_add(json_afi_safi,
-                                                       "timers",
-                                                        json_timer);
-                                       json_object_object_add(json,
-                                               get_afi_safi_str(afi, safi, true),
-                                                        json_afi_safi);
+                                                       peer->bgp
+                                                               ->gr_info[afi]
+                                                                        [safi]
+                                                               .t_select_deferral));
                                }
                        }
+                       if (use_json) {
+                               json_object_object_add(json_afi_safi,
+                                                      "endOfRibStatus",
+                                                      json_endofrib_status);
+                               json_object_object_add(json_afi_safi, "timers",
+                                                      json_timer);
+                               json_object_object_add(
+                                       json, get_afi_safi_str(afi, safi, true),
+                                       json_afi_safi);
+                       }
                }
        }
 }
@@ -9612,39 +9770,30 @@ static void  bgp_show_neighbor_graceful_restart_time(struct vty *vty,
 
                json_timer = json_object_new_object();
 
-               json_object_int_add(json_timer,
-                                       "configuredRestartTimer",
-                                       p->bgp->restart_time);
+               json_object_int_add(json_timer, "configuredRestartTimer",
+                                   p->bgp->restart_time);
 
-               json_object_int_add(json_timer,
-                                       "recivedRestartTimer",
-                                       p->v_gr_restart);
+               json_object_int_add(json_timer, "receivedRestartTimer",
+                                   p->v_gr_restart);
 
-               if (p->t_gr_restart != NULL) {
-                       json_object_int_add(json_timer,
-                                       "restartTimerRemaining",
-                                       thread_timer_remain_second(
-                                       p->t_gr_restart)
-                                       );
-               }
+               if (p->t_gr_restart != NULL)
+                       json_object_int_add(
+                               json_timer, "restartTimerRemaining",
+                               thread_timer_remain_second(p->t_gr_restart));
 
                json_object_object_add(json, "timers", json_timer);
        } else {
 
                vty_out(vty, "    Timers :\n");
-               vty_out(vty,
-                       "     Configured Restart Time(sec)  : %u\n",
-                               p->bgp->restart_time);
+               vty_out(vty, "     Configured Restart Time(sec)  : %u\n",
+                       p->bgp->restart_time);
 
-               vty_out(vty,
-                       "     Received Restart Time(sec)    : %u\n",
-                                       p->v_gr_restart);
-               if (p->t_gr_restart != NULL) {
+               vty_out(vty, "     Received Restart Time(sec)    : %u\n",
+                       p->v_gr_restart);
+               if (p->t_gr_restart != NULL)
                        vty_out(vty,
-                       "     Restart Time Remaining(sec)   : %ld\n",
-                               thread_timer_remain_second(
-                                       p->t_gr_restart));
-               }
+                               "     Restart Time Remaining(sec)   : %ld\n",
+                               thread_timer_remain_second(p->t_gr_restart));
        }
 }
 
@@ -9656,20 +9805,19 @@ static void bgp_show_peer_gr_status(struct vty *vty, struct peer *p,
        char dn_flag[2] = {0};
        char neighborAddr[INET6_ADDRSTRLEN] = {0};
 
-       memset(dn_flag, '\0', sizeof(dn_flag));
        if (!p->conf_if && peer_dynamic_neighbor(p))
                dn_flag[0] = '*';
 
        if (p->conf_if) {
                if (use_json)
-                       json_object_string_add(json, "neighborAddr",
+                       json_object_string_add(
+                               json, "neighborAddr",
                                BGP_PEER_SU_UNSPEC(p)
-                               ? "none"
-                               : sockunion2str(&p->su, buf,
-                                       SU_ADDRSTRLEN));
+                                       ? "none"
+                                       : sockunion2str(&p->su, buf,
+                                                       SU_ADDRSTRLEN));
                else
-                       vty_out(vty, "BGP neighbor on %s: %s\n",
-                               p->conf_if,
+                       vty_out(vty, "BGP neighbor on %s: %s\n", p->conf_if,
                                BGP_PEER_SU_UNSPEC(p)
                                        ? "none"
                                        : sockunion2str(&p->su, buf,
@@ -12005,37 +12153,36 @@ static int bgp_show_neighbor_graceful_restart(struct vty *vty,
                if (use_json)
                        json_neighbor = json_object_new_object();
 
-               if (show_all == type) {
+               if (type == show_all) {
                        bgp_show_peer_gr_status(vty, peer, use_json,
-                                                       json_neighbor);
+                                               json_neighbor);
 
                        if (use_json)
-                               json_object_object_add(json,
-                                               peer->host, json_neighbor);
+                               json_object_object_add(json, peer->host,
+                                                      json_neighbor);
 
-               } else if (show_peer == type) {
+               } else if (type == show_peer) {
                        if (conf_if) {
                                if ((peer->conf_if
-                                       && !strcmp(peer->conf_if, conf_if))
-                                       || (peer->hostname
+                                    && !strcmp(peer->conf_if, conf_if))
+                                   || (peer->hostname
                                        && !strcmp(peer->hostname, conf_if))) {
                                        find = 1;
-                                       bgp_show_peer_gr_status(vty,
-                                               peer, use_json,
-                                               json_neighbor);
+                                       bgp_show_peer_gr_status(vty, peer,
+                                                               use_json,
+                                                               json_neighbor);
                                }
                        } else {
                                if (sockunion_same(&peer->su, su)) {
                                        find = 1;
-                                       bgp_show_peer_gr_status(vty,
-                                               peer, use_json,
-                                               json_neighbor);
+                                       bgp_show_peer_gr_status(vty, peer,
+                                                               use_json,
+                                                               json_neighbor);
                                }
                        }
-                       if (use_json && find) {
-                               json_object_object_add(json,
-                                               peer->host, json_neighbor);
-                       }
+                       if (use_json && find)
+                               json_object_object_add(json, peer->host,
+                                                      json_neighbor);
                }
 
                if (find)
@@ -12044,14 +12191,14 @@ static int bgp_show_neighbor_graceful_restart(struct vty *vty,
 
        if (type == show_peer && !find) {
                if (use_json)
-                       json_object_boolean_true_add(json,
-                                                       "bgpNoSuchNeighbor");
+                       json_object_boolean_true_add(json, "bgpNoSuchNeighbor");
                else
                        vty_out(vty, "%% No such neighbor\n");
        }
        if (use_json) {
-               vty_out(vty, "%s\n", json_object_to_json_string_ext(
-                                            json, JSON_C_TO_STRING_PRETTY));
+               vty_out(vty, "%s\n",
+                       json_object_to_json_string_ext(
+                               json, JSON_C_TO_STRING_PRETTY));
        } else {
                vty_out(vty, "\n");
        }
@@ -12176,32 +12323,27 @@ static void  bgp_show_neighbor_graceful_restart_vty(struct vty *vty,
 
        bgp = bgp_get_default();
 
-       if (bgp) {
-
-               if (!use_json) {
-                       bgp_show_global_graceful_restart_mode_vty(vty, bgp,
-                                               use_json, NULL);
-               }
+       if (!bgp)
+               return;
 
-               json = json_object_new_object();
-               if (ip_str) {
-                       ret = str2sockunion(ip_str, &su);
-                       if (ret < 0)
-                               bgp_show_neighbor_graceful_restart(vty,
-                                       bgp, type, NULL, ip_str,
-                                       afi, use_json, json);
-                       else
-                               bgp_show_neighbor_graceful_restart(vty,
-                                       bgp, type, &su, NULL,
-                                       afi, use_json, json);
-               } else {
-                       bgp_show_neighbor_graceful_restart(vty, bgp,
-                                       type, NULL, NULL, afi,
-                                       use_json, json);
-               }
-               json_object_free(json);
-       }
+       if (!use_json)
+               bgp_show_global_graceful_restart_mode_vty(vty, bgp, use_json,
+                                                         NULL);
 
+       json = json_object_new_object();
+       if (ip_str) {
+               ret = str2sockunion(ip_str, &su);
+               if (ret < 0)
+                       bgp_show_neighbor_graceful_restart(vty, bgp, type, NULL,
+                                                          ip_str, afi,
+                                                          use_json, json);
+               else
+                       bgp_show_neighbor_graceful_restart(
+                               vty, bgp, type, &su, NULL, afi, use_json, json);
+       } else
+               bgp_show_neighbor_graceful_restart(vty, bgp, type, NULL, NULL,
+                                                  afi, use_json, json);
+       json_object_free(json);
 }
 
 static void bgp_show_all_instances_neighbors_vty(struct vty *vty,
@@ -12362,7 +12504,6 @@ DEFUN (show_ip_bgp_neighbors_gracrful_restart,
        enum show_type sh_type;
        int idx = 0;
        afi_t afi = AFI_MAX;
-
        bool uj = use_json(argc, argv);
 
        if      (!argv_find_and_parse_afi(argv, argc, &idx, &afi))
@@ -12536,29 +12677,25 @@ static void bgp_show_global_graceful_restart_mode_vty(struct vty *vty,
 
        vty_out(vty, "\n%s", SHOW_GR_HEADER);
 
-       int bgp_global_gr_mode = bgp_global_gr_mode_get(bgp);
+       enum global_mode bgp_global_gr_mode = bgp_global_gr_mode_get(bgp);
 
        switch (bgp_global_gr_mode) {
 
        case GLOBAL_HELPER:
-               vty_out(vty,
-                               "Global Bgp GR Mode :  Helper\n");
+               vty_out(vty, "Global BGP GR Mode :  Helper\n");
                break;
 
        case GLOBAL_GR:
-               vty_out(vty,
-                       "Global Bgp GR Mode :  Restart\n");
+               vty_out(vty, "Global BGP GR Mode :  Restart\n");
                break;
 
        case GLOBAL_DISABLE:
-               vty_out(vty,
-                               "Global Bgp GR Mode :  Disable\n");
+               vty_out(vty, "Global BGP GR Mode :  Disable\n");
                break;
 
        case GLOBAL_INVALID:
-       default:
                vty_out(vty,
-                       "Global Bgp GR Mode  Invalid\n");
+                       "Global BGP GR Mode  Invalid\n");
                break;
        }
        vty_out(vty, "\n");
@@ -14420,23 +14557,25 @@ static void bgp_config_write_peer_global(struct vty *vty, struct bgp *bgp,
                        addr);
 
        if (!CHECK_FLAG(peer->peer_gr_new_status_flag,
-               PEER_GRACEFUL_RESTART_NEW_STATE_INHERIT)) {
+                       PEER_GRACEFUL_RESTART_NEW_STATE_INHERIT)) {
 
                if (CHECK_FLAG(peer->peer_gr_new_status_flag,
-                               PEER_GRACEFUL_RESTART_NEW_STATE_HELPER)) {
+                              PEER_GRACEFUL_RESTART_NEW_STATE_HELPER)) {
                        vty_out(vty,
                                " neighbor %s graceful-restart-helper\n", addr);
-               } else if (CHECK_FLAG(peer->peer_gr_new_status_flag,
-                               PEER_GRACEFUL_RESTART_NEW_STATE_RESTART)) {
+               } else if (CHECK_FLAG(
+                                  peer->peer_gr_new_status_flag,
+                                  PEER_GRACEFUL_RESTART_NEW_STATE_RESTART)) {
                        vty_out(vty,
                                " neighbor %s graceful-restart\n", addr);
-               } else if ((!(CHECK_FLAG(peer->peer_gr_new_status_flag,
-                               PEER_GRACEFUL_RESTART_NEW_STATE_HELPER))
-                               && !(CHECK_FLAG(peer->peer_gr_new_status_flag,
-                               PEER_GRACEFUL_RESTART_NEW_STATE_RESTART)))) {
-                       vty_out(vty,
-                               " neighbor %s graceful-restart-disable\n",
-                                       addr);
+               } else if (
+                       (!(CHECK_FLAG(peer->peer_gr_new_status_flag,
+                                     PEER_GRACEFUL_RESTART_NEW_STATE_HELPER))
+                        && !(CHECK_FLAG(
+                                peer->peer_gr_new_status_flag,
+                                PEER_GRACEFUL_RESTART_NEW_STATE_RESTART)))) {
+                       vty_out(vty, " neighbor %s graceful-restart-disable\n",
+                               addr);
                }
        }
 }
@@ -14990,6 +15129,12 @@ int bgp_config_write(struct vty *vty)
                        vty_out(vty,
                                " bgp graceful-restart preserve-fw-state\n");
 
+               /* Stale timer for RIB */
+               if (bgp->rib_stale_time != BGP_DEFAULT_RIB_STALE_TIME)
+                       vty_out(vty,
+                               " bgp graceful-restart rib-stale-time %u\n",
+                               bgp->rib_stale_time);
+
                /* BGP bestpath method. */
                if (bgp_flag_check(bgp, BGP_FLAG_ASPATH_IGNORE))
                        vty_out(vty, " bgp bestpath as-path ignore\n");
@@ -15393,10 +15538,16 @@ void bgp_vty_init(void)
        install_element(BGP_NODE, &bgp_graceful_restart_restart_time_cmd);
        install_element(BGP_NODE, &no_bgp_graceful_restart_restart_time_cmd);
        install_element(BGP_NODE, &bgp_graceful_restart_select_defer_time_cmd);
-       install_element(BGP_NODE, &no_bgp_graceful_restart_select_defer_time_cmd);
+       install_element(BGP_NODE,
+                       &no_bgp_graceful_restart_select_defer_time_cmd);
        install_element(BGP_NODE, &bgp_graceful_restart_preserve_fw_cmd);
        install_element(BGP_NODE, &no_bgp_graceful_restart_preserve_fw_cmd);
 
+       install_element(BGP_NODE, &bgp_graceful_restart_disable_eor_cmd);
+       install_element(BGP_NODE, &no_bgp_graceful_restart_disable_eor_cmd);
+       install_element(BGP_NODE, &bgp_graceful_restart_rib_stale_time_cmd);
+       install_element(BGP_NODE, &no_bgp_graceful_restart_rib_stale_time_cmd);
+
        /* "bgp graceful-shutdown" commands */
        install_element(BGP_NODE, &bgp_graceful_shutdown_cmd);
        install_element(BGP_NODE, &no_bgp_graceful_shutdown_cmd);
@@ -16555,21 +16706,29 @@ static void community_list_perror(struct vty *vty, int ret)
 /*community-list standard */
 DEFUN (community_list_standard,
        bgp_community_list_standard_cmd,
-       "bgp community-list <(1-99)|standard WORD> <deny|permit> AA:NN...",
+       "bgp community-list <(1-99)|standard WORD> [seq (1-4294967295)] <deny|permit> AA:NN...",
        BGP_STR
        COMMUNITY_LIST_STR
        "Community list number (standard)\n"
        "Add an standard community-list entry\n"
        "Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        COMMUNITY_VAL_STR)
 {
        char *cl_name_or_number = NULL;
+       char *seq = NULL;
        int direct = 0;
        int style = COMMUNITY_LIST_STANDARD;
        int idx = 0;
 
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
+       idx = 0;
        argv_find(argv, argc, "(1-99)", &idx);
        argv_find(argv, argc, "WORD", &idx);
        cl_name_or_number = argv[idx]->arg;
@@ -16578,8 +16737,8 @@ DEFUN (community_list_standard,
        argv_find(argv, argc, "AA:NN", &idx);
        char *str = argv_concat(argv, argc, idx);
 
-       int ret = community_list_set(bgp_clist, cl_name_or_number, str, direct,
-                                    style);
+       int ret = community_list_set(bgp_clist, cl_name_or_number, str, seq,
+                                    direct, style);
 
        XFREE(MTYPE_TMP, str);
 
@@ -16594,13 +16753,15 @@ DEFUN (community_list_standard,
 
 DEFUN (no_community_list_standard_all,
        no_bgp_community_list_standard_all_cmd,
-       "no bgp community-list <(1-99)|standard WORD> <deny|permit> AA:NN...",
+       "no bgp community-list <(1-99)|standard WORD> [seq (1-4294967295)] <deny|permit> AA:NN...",
        NO_STR
        BGP_STR
        COMMUNITY_LIST_STR
        "Community list number (standard)\n"
        "Add an standard community-list entry\n"
        "Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        COMMUNITY_VAL_STR)
@@ -16609,9 +16770,14 @@ DEFUN (no_community_list_standard_all,
        char *str = NULL;
        int direct = 0;
        int style = COMMUNITY_LIST_STANDARD;
-
+       char *seq = NULL;
        int idx = 0;
 
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
+       idx = 0;
        argv_find(argv, argc, "permit", &idx);
        argv_find(argv, argc, "deny", &idx);
 
@@ -16630,7 +16796,7 @@ DEFUN (no_community_list_standard_all,
        argv_find(argv, argc, "WORD", &idx);
        cl_name_or_number = argv[idx]->arg;
 
-       int ret = community_list_unset(bgp_clist, cl_name_or_number, str,
+       int ret = community_list_unset(bgp_clist, cl_name_or_number, str, seq,
                                       direct, style);
 
        XFREE(MTYPE_TMP, str);
@@ -16653,22 +16819,30 @@ ALIAS(no_community_list_standard_all, no_bgp_community_list_standard_all_list_cm
 /*community-list expanded */
 DEFUN (community_list_expanded_all,
        bgp_community_list_expanded_all_cmd,
-       "bgp community-list <(100-500)|expanded WORD> <deny|permit> AA:NN...",
+       "bgp community-list <(100-500)|expanded WORD> [seq (1-4294967295)] <deny|permit> AA:NN...",
        BGP_STR
        COMMUNITY_LIST_STR
        "Community list number (expanded)\n"
        "Add an expanded community-list entry\n"
        "Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        COMMUNITY_VAL_STR)
 {
        char *cl_name_or_number = NULL;
+       char *seq = NULL;
        int direct = 0;
        int style = COMMUNITY_LIST_EXPANDED;
-
        int idx = 0;
 
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
+       idx = 0;
+
        argv_find(argv, argc, "(100-500)", &idx);
        argv_find(argv, argc, "WORD", &idx);
        cl_name_or_number = argv[idx]->arg;
@@ -16677,8 +16851,8 @@ DEFUN (community_list_expanded_all,
        argv_find(argv, argc, "AA:NN", &idx);
        char *str = argv_concat(argv, argc, idx);
 
-       int ret = community_list_set(bgp_clist, cl_name_or_number, str, direct,
-                                    style);
+       int ret = community_list_set(bgp_clist, cl_name_or_number, str, seq,
+                                    direct, style);
 
        XFREE(MTYPE_TMP, str);
 
@@ -16693,24 +16867,31 @@ DEFUN (community_list_expanded_all,
 
 DEFUN (no_community_list_expanded_all,
        no_bgp_community_list_expanded_all_cmd,
-       "no bgp community-list <(100-500)|expanded WORD> <deny|permit> AA:NN...",
+       "no bgp community-list <(100-500)|expanded WORD> [seq (1-4294967295)] <deny|permit> AA:NN...",
        NO_STR
        BGP_STR
        COMMUNITY_LIST_STR
        "Community list number (expanded)\n"
        "Add an expanded community-list entry\n"
        "Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        COMMUNITY_VAL_STR)
 {
        char *cl_name_or_number = NULL;
+       char *seq = NULL;
        char *str = NULL;
        int direct = 0;
        int style = COMMUNITY_LIST_EXPANDED;
-
        int idx = 0;
 
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
+       idx = 0;
        argv_find(argv, argc, "permit", &idx);
        argv_find(argv, argc, "deny", &idx);
 
@@ -16729,7 +16910,7 @@ DEFUN (no_community_list_expanded_all,
        argv_find(argv, argc, "WORD", &idx);
        cl_name_or_number = argv[idx]->arg;
 
-       int ret = community_list_unset(bgp_clist, cl_name_or_number, str,
+       int ret = community_list_unset(bgp_clist, cl_name_or_number, str, seq,
                                       direct, style);
 
        XFREE(MTYPE_TMP, str);
@@ -16856,7 +17037,13 @@ static int lcommunity_list_set_vty(struct vty *vty, int argc,
        char *str;
        int idx = 0;
        char *cl_name;
+       char *seq = NULL;
+
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
 
+       idx = 0;
        direct = argv_find(argv, argc, "permit", &idx) ? COMMUNITY_PERMIT
                                                       : COMMUNITY_DENY;
 
@@ -16880,7 +17067,7 @@ static int lcommunity_list_set_vty(struct vty *vty, int argc,
        else
                str = NULL;
 
-       ret = lcommunity_list_set(bgp_clist, cl_name, str, direct, style);
+       ret = lcommunity_list_set(bgp_clist, cl_name, str, seq, direct, style);
 
        /* Free temporary community list string allocated by
           argv_concat().  */
@@ -16900,7 +17087,13 @@ static int lcommunity_list_unset_vty(struct vty *vty, int argc,
        int direct = 0;
        char *str = NULL;
        int idx = 0;
+       char *seq = NULL;
+
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
 
+       idx = 0;
        argv_find(argv, argc, "permit", &idx);
        argv_find(argv, argc, "deny", &idx);
 
@@ -16924,7 +17117,7 @@ static int lcommunity_list_unset_vty(struct vty *vty, int argc,
        argv_find(argv, argc, "WORD", &idx);
 
        /* Unset community list.  */
-       ret = lcommunity_list_unset(bgp_clist, argv[idx]->arg, str, direct,
+       ret = lcommunity_list_unset(bgp_clist, argv[idx]->arg, str, seq, direct,
                                    style);
 
        /* Free temporary community list string allocated by
@@ -16945,10 +17138,12 @@ static int lcommunity_list_unset_vty(struct vty *vty, int argc,
 
 DEFUN (lcommunity_list_standard,
        bgp_lcommunity_list_standard_cmd,
-       "bgp large-community-list (1-99) <deny|permit> AA:BB:CC...",
+       "bgp large-community-list (1-99) [seq (1-4294967295)] <deny|permit> AA:BB:CC...",
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Large Community list number (standard)\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        LCOMMUNITY_VAL_STR)
@@ -16959,10 +17154,12 @@ DEFUN (lcommunity_list_standard,
 
 DEFUN (lcommunity_list_expanded,
        bgp_lcommunity_list_expanded_cmd,
-       "bgp large-community-list (100-500) <deny|permit> LINE...",
+       "bgp large-community-list (100-500) [seq (1-4294967295)] <deny|permit> LINE...",
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Large Community list number (expanded)\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        "An ordered list as a regular-expression\n")
@@ -16973,11 +17170,13 @@ DEFUN (lcommunity_list_expanded,
 
 DEFUN (lcommunity_list_name_standard,
        bgp_lcommunity_list_name_standard_cmd,
-       "bgp large-community-list standard WORD <deny|permit> AA:BB:CC...",
+       "bgp large-community-list standard WORD [seq (1-4294967295)] <deny|permit> AA:BB:CC...",
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Specify standard large-community-list\n"
        "Large Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        LCOMMUNITY_VAL_STR)
@@ -16988,11 +17187,13 @@ DEFUN (lcommunity_list_name_standard,
 
 DEFUN (lcommunity_list_name_expanded,
        bgp_lcommunity_list_name_expanded_cmd,
-       "bgp large-community-list expanded WORD <deny|permit> LINE...",
+       "bgp large-community-list expanded WORD [seq (1-4294967295)] <deny|permit> LINE...",
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Specify expanded large-community-list\n"
        "Large Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        "An ordered list as a regular-expression\n")
@@ -17001,8 +17202,8 @@ DEFUN (lcommunity_list_name_expanded,
                                       LARGE_COMMUNITY_LIST_EXPANDED, 1);
 }
 
-DEFUN (no_lcommunity_list_standard_all,
-       no_bgp_lcommunity_list_standard_all_cmd,
+DEFUN (no_lcommunity_list_all,
+       no_bgp_lcommunity_list_all_cmd,
        "no bgp large-community-list <(1-99)|(100-500)|WORD>",
        NO_STR
        BGP_STR
@@ -17015,6 +17216,19 @@ DEFUN (no_lcommunity_list_standard_all,
                                         LARGE_COMMUNITY_LIST_STANDARD);
 }
 
+DEFUN (no_lcommunity_list_name_standard_all,
+       no_bgp_lcommunity_list_name_standard_all_cmd,
+       "no bgp large-community-list standard WORD",
+       NO_STR
+       BGP_STR
+       LCOMMUNITY_LIST_STR
+       "Specify standard large-community-list\n"
+       "Large Community list name\n")
+{
+       return lcommunity_list_unset_vty(vty, argc, argv,
+                                        LARGE_COMMUNITY_LIST_STANDARD);
+}
+
 DEFUN (no_lcommunity_list_name_expanded_all,
        no_bgp_lcommunity_list_name_expanded_all_cmd,
        "no bgp large-community-list expanded WORD",
@@ -17030,11 +17244,13 @@ DEFUN (no_lcommunity_list_name_expanded_all,
 
 DEFUN (no_lcommunity_list_standard,
        no_bgp_lcommunity_list_standard_cmd,
-       "no bgp large-community-list (1-99) <deny|permit> AA:AA:NN...",
+       "no bgp large-community-list (1-99) [seq (1-4294967295)] <deny|permit> AA:AA:NN...",
        NO_STR
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Large Community list number (standard)\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        LCOMMUNITY_VAL_STR)
@@ -17045,11 +17261,13 @@ DEFUN (no_lcommunity_list_standard,
 
 DEFUN (no_lcommunity_list_expanded,
        no_bgp_lcommunity_list_expanded_cmd,
-       "no bgp large-community-list (100-500) <deny|permit> LINE...",
+       "no bgp large-community-list (100-500) [seq (1-4294967295)] <deny|permit> LINE...",
        NO_STR
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Large Community list number (expanded)\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        "An ordered list as a regular-expression\n")
@@ -17060,12 +17278,14 @@ DEFUN (no_lcommunity_list_expanded,
 
 DEFUN (no_lcommunity_list_name_standard,
        no_bgp_lcommunity_list_name_standard_cmd,
-       "no bgp large-community-list standard WORD <deny|permit> AA:AA:NN...",
+       "no bgp large-community-list standard WORD [seq (1-4294967295)] <deny|permit> AA:AA:NN...",
        NO_STR
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Specify standard large-community-list\n"
        "Large Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        LCOMMUNITY_VAL_STR)
@@ -17076,12 +17296,14 @@ DEFUN (no_lcommunity_list_name_standard,
 
 DEFUN (no_lcommunity_list_name_expanded,
        no_bgp_lcommunity_list_name_expanded_cmd,
-       "no bgp large-community-list expanded WORD <deny|permit> LINE...",
+       "no bgp large-community-list expanded WORD [seq (1-4294967295)] <deny|permit> LINE...",
        NO_STR
        BGP_STR
        LCOMMUNITY_LIST_STR
        "Specify expanded large-community-list\n"
        "Large community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify large community to reject\n"
        "Specify large community to accept\n"
        "An ordered list as a regular-expression\n")
@@ -17176,12 +17398,14 @@ DEFUN (show_lcommunity_list_arg,
 
 DEFUN (extcommunity_list_standard,
        bgp_extcommunity_list_standard_cmd,
-       "bgp extcommunity-list <(1-99)|standard WORD> <deny|permit> AA:NN...",
+       "bgp extcommunity-list <(1-99)|standard WORD> [seq (1-4294967295)] <deny|permit> AA:NN...",
        BGP_STR
        EXTCOMMUNITY_LIST_STR
        "Extended Community list number (standard)\n"
        "Specify standard extcommunity-list\n"
        "Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        EXTCOMMUNITY_VAL_STR)
@@ -17189,18 +17413,24 @@ DEFUN (extcommunity_list_standard,
        int style = EXTCOMMUNITY_LIST_STANDARD;
        int direct = 0;
        char *cl_number_or_name = NULL;
+       char *seq = NULL;
 
        int idx = 0;
 
        argv_find(argv, argc, "(1-99)", &idx);
        argv_find(argv, argc, "WORD", &idx);
        cl_number_or_name = argv[idx]->arg;
+
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
        direct = argv_find(argv, argc, "permit", &idx) ? COMMUNITY_PERMIT
                                                       : COMMUNITY_DENY;
        argv_find(argv, argc, "AA:NN", &idx);
        char *str = argv_concat(argv, argc, idx);
 
-       int ret = extcommunity_list_set(bgp_clist, cl_number_or_name, str,
+       int ret = extcommunity_list_set(bgp_clist, cl_number_or_name, str, seq,
                                        direct, style);
 
        XFREE(MTYPE_TMP, str);
@@ -17215,12 +17445,14 @@ DEFUN (extcommunity_list_standard,
 
 DEFUN (extcommunity_list_name_expanded,
        bgp_extcommunity_list_name_expanded_cmd,
-       "bgp extcommunity-list <(100-500)|expanded WORD> <deny|permit> LINE...",
+       "bgp extcommunity-list <(100-500)|expanded WORD> [seq (1-4294967295)] <deny|permit> LINE...",
        BGP_STR
        EXTCOMMUNITY_LIST_STR
        "Extended Community list number (expanded)\n"
        "Specify expanded extcommunity-list\n"
        "Extended Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        "An ordered list as a regular-expression\n")
@@ -17228,17 +17460,23 @@ DEFUN (extcommunity_list_name_expanded,
        int style = EXTCOMMUNITY_LIST_EXPANDED;
        int direct = 0;
        char *cl_number_or_name = NULL;
+       char *seq = NULL;
        int idx = 0;
 
        argv_find(argv, argc, "(100-500)", &idx);
        argv_find(argv, argc, "WORD", &idx);
        cl_number_or_name = argv[idx]->arg;
+
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
        direct = argv_find(argv, argc, "permit", &idx) ? COMMUNITY_PERMIT
                                                       : COMMUNITY_DENY;
        argv_find(argv, argc, "LINE", &idx);
        char *str = argv_concat(argv, argc, idx);
 
-       int ret = extcommunity_list_set(bgp_clist, cl_number_or_name, str,
+       int ret = extcommunity_list_set(bgp_clist, cl_number_or_name, str, seq,
                                        direct, style);
 
        XFREE(MTYPE_TMP, str);
@@ -17253,13 +17491,15 @@ DEFUN (extcommunity_list_name_expanded,
 
 DEFUN (no_extcommunity_list_standard_all,
        no_bgp_extcommunity_list_standard_all_cmd,
-       "no bgp extcommunity-list <(1-99)|standard WORD> <deny|permit> AA:NN...",
+       "no bgp extcommunity-list <(1-99)|standard WORD> [seq (1-4294967295)] <deny|permit> AA:NN...",
        NO_STR
        BGP_STR
        EXTCOMMUNITY_LIST_STR
        "Extended Community list number (standard)\n"
        "Specify standard extcommunity-list\n"
        "Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        EXTCOMMUNITY_VAL_STR)
@@ -17268,11 +17508,16 @@ DEFUN (no_extcommunity_list_standard_all,
        int direct = 0;
        char *cl_number_or_name = NULL;
        char *str = NULL;
+       char *seq = NULL;
        int idx = 0;
 
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
+       idx = 0;
        argv_find(argv, argc, "permit", &idx);
        argv_find(argv, argc, "deny", &idx);
-
        if (idx) {
                direct = argv_find(argv, argc, "permit", &idx)
                                 ? COMMUNITY_PERMIT
@@ -17289,7 +17534,7 @@ DEFUN (no_extcommunity_list_standard_all,
        cl_number_or_name = argv[idx]->arg;
 
        int ret = extcommunity_list_unset(bgp_clist, cl_number_or_name, str,
-                                         direct, style);
+                                         seq, direct, style);
 
        XFREE(MTYPE_TMP, str);
 
@@ -17311,13 +17556,15 @@ ALIAS(no_extcommunity_list_standard_all,
 
 DEFUN (no_extcommunity_list_expanded_all,
        no_bgp_extcommunity_list_expanded_all_cmd,
-       "no bgp extcommunity-list <(100-500)|expanded WORD> <deny|permit> LINE...",
+       "no bgp extcommunity-list <(100-500)|expanded WORD> [seq (1-4294967295)] <deny|permit> LINE...",
        NO_STR
        BGP_STR
        EXTCOMMUNITY_LIST_STR
        "Extended Community list number (expanded)\n"
        "Specify expanded extcommunity-list\n"
        "Extended Community list name\n"
+       "Sequence number of an entry\n"
+       "Sequence number\n"
        "Specify community to reject\n"
        "Specify community to accept\n"
        "An ordered list as a regular-expression\n")
@@ -17326,8 +17573,14 @@ DEFUN (no_extcommunity_list_expanded_all,
        int direct = 0;
        char *cl_number_or_name = NULL;
        char *str = NULL;
+       char *seq = NULL;
        int idx = 0;
 
+       argv_find(argv, argc, "(1-4294967295)", &idx);
+       if (idx)
+               seq = argv[idx]->arg;
+
+       idx = 0;
        argv_find(argv, argc, "permit", &idx);
        argv_find(argv, argc, "deny", &idx);
 
@@ -17347,7 +17600,7 @@ DEFUN (no_extcommunity_list_expanded_all,
        cl_number_or_name = argv[idx]->arg;
 
        int ret = extcommunity_list_unset(bgp_clist, cl_number_or_name, str,
-                                         direct, style);
+                                         seq, direct, style);
 
        XFREE(MTYPE_TMP, str);
 
@@ -17458,18 +17711,22 @@ static int community_list_config_write(struct vty *vty)
 
        for (list = cm->num.head; list; list = list->next)
                for (entry = list->head; entry; entry = entry->next) {
-                       vty_out(vty, "bgp community-list %s %s %s\n", list->name,
+                       vty_out(vty,
+                               "bgp community-list %s seq %" PRId64 " %s %s\n",
+                               list->name, entry->seq,
                                community_direct_str(entry->direct),
                                community_list_config_str(entry));
                        write++;
                }
        for (list = cm->str.head; list; list = list->next)
                for (entry = list->head; entry; entry = entry->next) {
-                       vty_out(vty, "bgp community-list %s %s %s %s\n",
+                       vty_out(vty,
+                               "bgp community-list %s %s seq %" PRId64 " %s %s\n",
                                entry->style == COMMUNITY_LIST_STANDARD
                                        ? "standard"
                                        : "expanded",
-                               list->name, community_direct_str(entry->direct),
+                               list->name, entry->seq,
+                               community_direct_str(entry->direct),
                                community_list_config_str(entry));
                        write++;
                }
@@ -17479,18 +17736,23 @@ static int community_list_config_write(struct vty *vty)
 
        for (list = cm->num.head; list; list = list->next)
                for (entry = list->head; entry; entry = entry->next) {
-                       vty_out(vty, "bgp extcommunity-list %s %s %s\n",
-                               list->name, community_direct_str(entry->direct),
+                       vty_out(vty,
+                               "bgp extcommunity-list %s seq %" PRId64 " %s %s\n",
+                               list->name, entry->seq,
+                               community_direct_str(entry->direct),
                                community_list_config_str(entry));
                        write++;
                }
        for (list = cm->str.head; list; list = list->next)
                for (entry = list->head; entry; entry = entry->next) {
-                       vty_out(vty, "bgp extcommunity-list %s %s %s %s\n",
+                       vty_out(vty,
+                               "bgp extcommunity-list %s %s seq %" PRId64
+                               " %s %s\n",
                                entry->style == EXTCOMMUNITY_LIST_STANDARD
                                        ? "standard"
                                        : "expanded",
-                               list->name, community_direct_str(entry->direct),
+                               list->name, entry->seq,
+                               community_direct_str(entry->direct),
                                community_list_config_str(entry));
                        write++;
                }
@@ -17502,18 +17764,24 @@ static int community_list_config_write(struct vty *vty)
 
        for (list = cm->num.head; list; list = list->next)
                for (entry = list->head; entry; entry = entry->next) {
-                       vty_out(vty, "bgp large-community-list %s %s %s\n",
-                               list->name, community_direct_str(entry->direct),
+                       vty_out(vty,
+                               "bgp large-community-list %s seq %" PRId64
+                               " %s %s\n",
+                               list->name, entry->seq,
+                               community_direct_str(entry->direct),
                                community_list_config_str(entry));
                        write++;
                }
        for (list = cm->str.head; list; list = list->next)
                for (entry = list->head; entry; entry = entry->next) {
-                       vty_out(vty, "bgp large-community-list %s %s %s %s\n",
+                       vty_out(vty,
+                               "bgp large-community-list %s %s seq %" PRId64
+                               " %s %s\n",
+
                                entry->style == LARGE_COMMUNITY_LIST_STANDARD
                                        ? "standard"
                                        : "expanded",
-                               list->name, community_direct_str(entry->direct),
+                               list->name, entry->seq, community_direct_str(entry->direct),
                                community_list_config_str(entry));
                        write++;
                }
@@ -17556,7 +17824,9 @@ static void community_list_vty(void)
        install_element(CONFIG_NODE, &bgp_lcommunity_list_expanded_cmd);
        install_element(CONFIG_NODE, &bgp_lcommunity_list_name_standard_cmd);
        install_element(CONFIG_NODE, &bgp_lcommunity_list_name_expanded_cmd);
-       install_element(CONFIG_NODE, &no_bgp_lcommunity_list_standard_all_cmd);
+       install_element(CONFIG_NODE, &no_bgp_lcommunity_list_all_cmd);
+       install_element(CONFIG_NODE,
+                       &no_bgp_lcommunity_list_name_standard_all_cmd);
        install_element(CONFIG_NODE,
                        &no_bgp_lcommunity_list_name_expanded_all_cmd);
        install_element(CONFIG_NODE, &no_bgp_lcommunity_list_standard_cmd);