]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blobdiff - drivers/cpufreq/cpufreq_conservative.c
cpufreq: governor: Move common tunables to 'struct dbs_data'
[mirror_ubuntu-artful-kernel.git] / drivers / cpufreq / cpufreq_conservative.c
index 606ad74abe6e8b248b15a142c4f3fca7241c64be..4f640b028c94c883627c22a750eda47772a3eb15 100644 (file)
 
 static DEFINE_PER_CPU(struct cs_cpu_dbs_info_s, cs_cpu_dbs_info);
 
-static int cs_cpufreq_governor_dbs(struct cpufreq_policy *policy,
-                                  unsigned int event);
-
-#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE
-static
-#endif
-struct cpufreq_governor cpufreq_gov_conservative = {
-       .name                   = "conservative",
-       .governor               = cs_cpufreq_governor_dbs,
-       .max_transition_latency = TRANSITION_LATENCY_LIMIT,
-       .owner                  = THIS_MODULE,
-};
-
 static inline unsigned int get_freq_target(struct cs_dbs_tuners *cs_tuners,
                                           struct cpufreq_policy *policy)
 {
@@ -60,8 +47,9 @@ static inline unsigned int get_freq_target(struct cs_dbs_tuners *cs_tuners,
 static void cs_check_cpu(int cpu, unsigned int load)
 {
        struct cs_cpu_dbs_info_s *dbs_info = &per_cpu(cs_cpu_dbs_info, cpu);
-       struct cpufreq_policy *policy = dbs_info->cdbs.shared->policy;
-       struct dbs_data *dbs_data = policy->governor_data;
+       struct cpufreq_policy *policy = dbs_info->cdbs.policy_dbs->policy;
+       struct policy_dbs_info *policy_dbs = policy->governor_data;
+       struct dbs_data *dbs_data = policy_dbs->dbs_data;
        struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
 
        /*
@@ -72,7 +60,7 @@ static void cs_check_cpu(int cpu, unsigned int load)
                return;
 
        /* Check for frequency increase */
-       if (load > cs_tuners->up_threshold) {
+       if (load > dbs_data->up_threshold) {
                dbs_info->down_skip = 0;
 
                /* if we are already at full speed then break out early */
@@ -90,7 +78,7 @@ static void cs_check_cpu(int cpu, unsigned int load)
        }
 
        /* if sampling_down_factor is active break out early */
-       if (++dbs_info->down_skip < cs_tuners->sampling_down_factor)
+       if (++dbs_info->down_skip < dbs_data->sampling_down_factor)
                return;
        dbs_info->down_skip = 0;
 
@@ -115,54 +103,28 @@ static void cs_check_cpu(int cpu, unsigned int load)
        }
 }
 
-static unsigned int cs_dbs_timer(struct cpufreq_policy *policy, bool modify_all)
+static unsigned int cs_dbs_timer(struct cpufreq_policy *policy)
 {
-       struct dbs_data *dbs_data = policy->governor_data;
-       struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
-
-       if (modify_all)
-               dbs_check_cpu(dbs_data, policy->cpu);
+       struct policy_dbs_info *policy_dbs = policy->governor_data;
+       struct dbs_data *dbs_data = policy_dbs->dbs_data;
 
-       return delay_for_sampling_rate(cs_tuners->sampling_rate);
+       dbs_check_cpu(policy);
+       return delay_for_sampling_rate(dbs_data->sampling_rate);
 }
 
 static int dbs_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
-               void *data)
-{
-       struct cpufreq_freqs *freq = data;
-       struct cs_cpu_dbs_info_s *dbs_info =
-                                       &per_cpu(cs_cpu_dbs_info, freq->cpu);
-       struct cpufreq_policy *policy = cpufreq_cpu_get_raw(freq->cpu);
-
-       if (!policy)
-               return 0;
-
-       /* policy isn't governed by conservative governor */
-       if (policy->governor != &cpufreq_gov_conservative)
-               return 0;
-
-       /*
-        * we only care if our internally tracked freq moves outside the 'valid'
-        * ranges of frequency available to us otherwise we do not change it
-       */
-       if (dbs_info->requested_freq > policy->max
-                       || dbs_info->requested_freq < policy->min)
-               dbs_info->requested_freq = freq->new;
-
-       return 0;
-}
+                               void *data);
 
 static struct notifier_block cs_cpufreq_notifier_block = {
        .notifier_call = dbs_cpufreq_notifier,
 };
 
 /************************** sysfs interface ************************/
-static struct common_dbs_data cs_dbs_cdata;
+static struct dbs_governor cs_dbs_gov;
 
 static ssize_t store_sampling_down_factor(struct dbs_data *dbs_data,
                const char *buf, size_t count)
 {
-       struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
        unsigned int input;
        int ret;
        ret = sscanf(buf, "%u", &input);
@@ -170,14 +132,13 @@ static ssize_t store_sampling_down_factor(struct dbs_data *dbs_data,
        if (ret != 1 || input > MAX_SAMPLING_DOWN_FACTOR || input < 1)
                return -EINVAL;
 
-       cs_tuners->sampling_down_factor = input;
+       dbs_data->sampling_down_factor = input;
        return count;
 }
 
 static ssize_t store_sampling_rate(struct dbs_data *dbs_data, const char *buf,
                size_t count)
 {
-       struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
        unsigned int input;
        int ret;
        ret = sscanf(buf, "%u", &input);
@@ -185,7 +146,7 @@ static ssize_t store_sampling_rate(struct dbs_data *dbs_data, const char *buf,
        if (ret != 1)
                return -EINVAL;
 
-       cs_tuners->sampling_rate = max(input, dbs_data->min_sampling_rate);
+       dbs_data->sampling_rate = max(input, dbs_data->min_sampling_rate);
        return count;
 }
 
@@ -200,7 +161,7 @@ static ssize_t store_up_threshold(struct dbs_data *dbs_data, const char *buf,
        if (ret != 1 || input > 100 || input <= cs_tuners->down_threshold)
                return -EINVAL;
 
-       cs_tuners->up_threshold = input;
+       dbs_data->up_threshold = input;
        return count;
 }
 
@@ -214,7 +175,7 @@ static ssize_t store_down_threshold(struct dbs_data *dbs_data, const char *buf,
 
        /* cannot be lower than 11 otherwise freq will not fall */
        if (ret != 1 || input < 11 || input > 100 ||
-                       input >= cs_tuners->up_threshold)
+                       input >= dbs_data->up_threshold)
                return -EINVAL;
 
        cs_tuners->down_threshold = input;
@@ -224,7 +185,6 @@ static ssize_t store_down_threshold(struct dbs_data *dbs_data, const char *buf,
 static ssize_t store_ignore_nice_load(struct dbs_data *dbs_data,
                const char *buf, size_t count)
 {
-       struct cs_dbs_tuners *cs_tuners = dbs_data->tuners;
        unsigned int input, j;
        int ret;
 
@@ -235,10 +195,10 @@ static ssize_t store_ignore_nice_load(struct dbs_data *dbs_data,
        if (input > 1)
                input = 1;
 
-       if (input == cs_tuners->ignore_nice_load) /* nothing to do */
+       if (input == dbs_data->ignore_nice_load) /* nothing to do */
                return count;
 
-       cs_tuners->ignore_nice_load = input;
+       dbs_data->ignore_nice_load = input;
 
        /* we need to re-evaluate prev_cpu_idle */
        for_each_online_cpu(j) {
@@ -246,7 +206,7 @@ static ssize_t store_ignore_nice_load(struct dbs_data *dbs_data,
                dbs_info = &per_cpu(cs_cpu_dbs_info, j);
                dbs_info->cdbs.prev_cpu_idle = get_cpu_idle_time(j,
                                        &dbs_info->cdbs.prev_cpu_wall, 0);
-               if (cs_tuners->ignore_nice_load)
+               if (dbs_data->ignore_nice_load)
                        dbs_info->cdbs.prev_cpu_nice =
                                kcpustat_cpu(j).cpustat[CPUTIME_NICE];
        }
@@ -275,13 +235,13 @@ static ssize_t store_freq_step(struct dbs_data *dbs_data, const char *buf,
        return count;
 }
 
-show_store_one(cs, sampling_rate);
-show_store_one(cs, sampling_down_factor);
-show_store_one(cs, up_threshold);
 show_store_one(cs, down_threshold);
-show_store_one(cs, ignore_nice_load);
 show_store_one(cs, freq_step);
-declare_show_sampling_rate_min(cs);
+show_store_one_common(cs, sampling_rate);
+show_store_one_common(cs, sampling_down_factor);
+show_store_one_common(cs, up_threshold);
+show_store_one_common(cs, ignore_nice_load);
+show_one_common(cs, min_sampling_rate);
 
 gov_sys_pol_attr_rw(sampling_rate);
 gov_sys_pol_attr_rw(sampling_down_factor);
@@ -289,10 +249,10 @@ gov_sys_pol_attr_rw(up_threshold);
 gov_sys_pol_attr_rw(down_threshold);
 gov_sys_pol_attr_rw(ignore_nice_load);
 gov_sys_pol_attr_rw(freq_step);
-gov_sys_pol_attr_ro(sampling_rate_min);
+gov_sys_pol_attr_ro(min_sampling_rate);
 
 static struct attribute *dbs_attributes_gov_sys[] = {
-       &sampling_rate_min_gov_sys.attr,
+       &min_sampling_rate_gov_sys.attr,
        &sampling_rate_gov_sys.attr,
        &sampling_down_factor_gov_sys.attr,
        &up_threshold_gov_sys.attr,
@@ -308,7 +268,7 @@ static struct attribute_group cs_attr_group_gov_sys = {
 };
 
 static struct attribute *dbs_attributes_gov_pol[] = {
-       &sampling_rate_min_gov_pol.attr,
+       &min_sampling_rate_gov_pol.attr,
        &sampling_rate_gov_pol.attr,
        &sampling_down_factor_gov_pol.attr,
        &up_threshold_gov_pol.attr,
@@ -335,11 +295,11 @@ static int cs_init(struct dbs_data *dbs_data, bool notify)
                return -ENOMEM;
        }
 
-       tuners->up_threshold = DEF_FREQUENCY_UP_THRESHOLD;
        tuners->down_threshold = DEF_FREQUENCY_DOWN_THRESHOLD;
-       tuners->sampling_down_factor = DEF_SAMPLING_DOWN_FACTOR;
-       tuners->ignore_nice_load = 0;
        tuners->freq_step = DEF_FREQUENCY_STEP;
+       dbs_data->up_threshold = DEF_FREQUENCY_UP_THRESHOLD;
+       dbs_data->sampling_down_factor = DEF_SAMPLING_DOWN_FACTOR;
+       dbs_data->ignore_nice_load = 0;
 
        dbs_data->tuners = tuners;
        dbs_data->min_sampling_rate = MIN_SAMPLING_RATE_RATIO *
@@ -363,7 +323,13 @@ static void cs_exit(struct dbs_data *dbs_data, bool notify)
 
 define_get_cpu_dbs_routines(cs_cpu_dbs_info);
 
-static struct common_dbs_data cs_dbs_cdata = {
+static struct dbs_governor cs_dbs_gov = {
+       .gov = {
+               .name = "conservative",
+               .governor = cpufreq_governor_dbs,
+               .max_transition_latency = TRANSITION_LATENCY_LIMIT,
+               .owner = THIS_MODULE,
+       },
        .governor = GOV_CONSERVATIVE,
        .attr_group_gov_sys = &cs_attr_group_gov_sys,
        .attr_group_gov_pol = &cs_attr_group_gov_pol,
@@ -373,23 +339,44 @@ static struct common_dbs_data cs_dbs_cdata = {
        .gov_check_cpu = cs_check_cpu,
        .init = cs_init,
        .exit = cs_exit,
-       .mutex = __MUTEX_INITIALIZER(cs_dbs_cdata.mutex),
 };
 
-static int cs_cpufreq_governor_dbs(struct cpufreq_policy *policy,
-                                  unsigned int event)
+#define CPU_FREQ_GOV_CONSERVATIVE      (&cs_dbs_gov.gov)
+
+static int dbs_cpufreq_notifier(struct notifier_block *nb, unsigned long val,
+                               void *data)
 {
-       return cpufreq_governor_dbs(policy, &cs_dbs_cdata, event);
+       struct cpufreq_freqs *freq = data;
+       struct cs_cpu_dbs_info_s *dbs_info =
+                                       &per_cpu(cs_cpu_dbs_info, freq->cpu);
+       struct cpufreq_policy *policy = cpufreq_cpu_get_raw(freq->cpu);
+
+       if (!policy)
+               return 0;
+
+       /* policy isn't governed by conservative governor */
+       if (policy->governor != CPU_FREQ_GOV_CONSERVATIVE)
+               return 0;
+
+       /*
+        * we only care if our internally tracked freq moves outside the 'valid'
+        * ranges of frequency available to us otherwise we do not change it
+       */
+       if (dbs_info->requested_freq > policy->max
+                       || dbs_info->requested_freq < policy->min)
+               dbs_info->requested_freq = freq->new;
+
+       return 0;
 }
 
 static int __init cpufreq_gov_dbs_init(void)
 {
-       return cpufreq_register_governor(&cpufreq_gov_conservative);
+       return cpufreq_register_governor(CPU_FREQ_GOV_CONSERVATIVE);
 }
 
 static void __exit cpufreq_gov_dbs_exit(void)
 {
-       cpufreq_unregister_governor(&cpufreq_gov_conservative);
+       cpufreq_unregister_governor(CPU_FREQ_GOV_CONSERVATIVE);
 }
 
 MODULE_AUTHOR("Alexander Clouter <alex@digriz.org.uk>");
@@ -399,6 +386,11 @@ MODULE_DESCRIPTION("'cpufreq_conservative' - A dynamic cpufreq governor for "
 MODULE_LICENSE("GPL");
 
 #ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE
+struct cpufreq_governor *cpufreq_default_governor(void)
+{
+       return CPU_FREQ_GOV_CONSERVATIVE;
+}
+
 fs_initcall(cpufreq_gov_dbs_init);
 #else
 module_init(cpufreq_gov_dbs_init);