]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/blobdiff - drivers/irqchip/spear-shirq.c
irqchip: spear_shirq: Reorder the spear320 ras blocks
[mirror_ubuntu-bionic-kernel.git] / drivers / irqchip / spear-shirq.c
index 3fdda3a4026936f92c36a3d2a5c8541bbf0b5c81..7ebb1a2fbfc71559d5d3f4931ae5ccfdf38afdaf 100644 (file)
@@ -19,7 +19,6 @@
 #include <linux/io.h>
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
-#include <linux/irqchip/spear-shirq.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 
 #include "irqchip.h"
 
+/*
+ * struct shirq_regs: shared irq register configuration
+ *
+ * enb_reg: enable register offset
+ * reset_to_enb: val 1 indicates, we need to clear bit for enabling interrupt
+ * status_reg: status register offset
+ * status_reg_mask: status register valid mask
+ * clear_reg: clear register offset
+ * reset_to_clear: val 1 indicates, we need to clear bit for clearing interrupt
+ */
+struct shirq_regs {
+       u32 enb_reg;
+       u32 reset_to_enb;
+       u32 status_reg;
+       u32 clear_reg;
+       u32 reset_to_clear;
+};
+
+/*
+ * struct spear_shirq: shared irq structure
+ *
+ * base:       Base register address
+ * regs:       Register configuration for shared irq block
+ * virq_base:  Base virtual interrupt number
+ * nr_irqs:    Number of interrupts handled by this block
+ * offset:     Bit offset of the first interrupt
+ * disabled:   Group is disabled, but accounted
+ */
+struct spear_shirq {
+       void __iomem            *base;
+       struct shirq_regs       regs;
+       u32                     virq_base;
+       u32                     nr_irqs;
+       u32                     offset;
+       bool                    disabled;
+};
+
 static DEFINE_SPINLOCK(lock);
 
 /* spear300 shared irq registers offsets and masks */
@@ -34,8 +70,8 @@ static DEFINE_SPINLOCK(lock);
 #define SPEAR300_INT_STS_MASK_REG      0x58
 
 static struct spear_shirq spear300_shirq_ras1 = {
-       .irq_nr = 9,
-       .irq_bit_off = 0,
+       .offset         = 0,
+       .nr_irqs        = 9,
        .regs = {
                .enb_reg = SPEAR300_INT_ENB_MASK_REG,
                .status_reg = SPEAR300_INT_STS_MASK_REG,
@@ -51,8 +87,8 @@ static struct spear_shirq *spear300_shirq_blocks[] = {
 #define SPEAR310_INT_STS_MASK_REG      0x04
 
 static struct spear_shirq spear310_shirq_ras1 = {
-       .irq_nr = 8,
-       .irq_bit_off = 0,
+       .offset         = 0,
+       .nr_irqs        = 8,
        .regs = {
                .enb_reg = -1,
                .status_reg = SPEAR310_INT_STS_MASK_REG,
@@ -61,8 +97,8 @@ static struct spear_shirq spear310_shirq_ras1 = {
 };
 
 static struct spear_shirq spear310_shirq_ras2 = {
-       .irq_nr = 5,
-       .irq_bit_off = 8,
+       .offset         = 8,
+       .nr_irqs        = 5,
        .regs = {
                .enb_reg = -1,
                .status_reg = SPEAR310_INT_STS_MASK_REG,
@@ -71,8 +107,8 @@ static struct spear_shirq spear310_shirq_ras2 = {
 };
 
 static struct spear_shirq spear310_shirq_ras3 = {
-       .irq_nr = 1,
-       .irq_bit_off = 13,
+       .offset         = 13,
+       .nr_irqs        = 1,
        .regs = {
                .enb_reg = -1,
                .status_reg = SPEAR310_INT_STS_MASK_REG,
@@ -81,8 +117,8 @@ static struct spear_shirq spear310_shirq_ras3 = {
 };
 
 static struct spear_shirq spear310_shirq_intrcomm_ras = {
-       .irq_nr = 3,
-       .irq_bit_off = 14,
+       .offset         = 14,
+       .nr_irqs        = 3,
        .regs = {
                .enb_reg = -1,
                .status_reg = SPEAR310_INT_STS_MASK_REG,
@@ -102,20 +138,22 @@ static struct spear_shirq *spear310_shirq_blocks[] = {
 #define SPEAR320_INT_CLR_MASK_REG              0x04
 #define SPEAR320_INT_ENB_MASK_REG              0x08
 
-static struct spear_shirq spear320_shirq_ras1 = {
-       .irq_nr = 3,
-       .irq_bit_off = 7,
+static struct spear_shirq spear320_shirq_ras3 = {
+       .offset         = 0,
+       .nr_irqs        = 7,
+       .disabled       = 1,
        .regs = {
-               .enb_reg = -1,
+               .enb_reg = SPEAR320_INT_ENB_MASK_REG,
+               .reset_to_enb = 1,
                .status_reg = SPEAR320_INT_STS_MASK_REG,
                .clear_reg = SPEAR320_INT_CLR_MASK_REG,
                .reset_to_clear = 1,
        },
 };
 
-static struct spear_shirq spear320_shirq_ras2 = {
-       .irq_nr = 1,
-       .irq_bit_off = 10,
+static struct spear_shirq spear320_shirq_ras1 = {
+       .offset         = 7,
+       .nr_irqs        = 3,
        .regs = {
                .enb_reg = -1,
                .status_reg = SPEAR320_INT_STS_MASK_REG,
@@ -124,13 +162,11 @@ static struct spear_shirq spear320_shirq_ras2 = {
        },
 };
 
-static struct spear_shirq spear320_shirq_ras3 = {
-       .irq_nr = 3,
-       .irq_bit_off = 0,
-       .invalid_irq = 1,
+static struct spear_shirq spear320_shirq_ras2 = {
+       .offset         = 10,
+       .nr_irqs        = 1,
        .regs = {
-               .enb_reg = SPEAR320_INT_ENB_MASK_REG,
-               .reset_to_enb = 1,
+               .enb_reg = -1,
                .status_reg = SPEAR320_INT_STS_MASK_REG,
                .clear_reg = SPEAR320_INT_CLR_MASK_REG,
                .reset_to_clear = 1,
@@ -138,8 +174,8 @@ static struct spear_shirq spear320_shirq_ras3 = {
 };
 
 static struct spear_shirq spear320_shirq_intrcomm_ras = {
-       .irq_nr = 11,
-       .irq_bit_off = 11,
+       .offset         = 11,
+       .nr_irqs        = 11,
        .regs = {
                .enb_reg = -1,
                .status_reg = SPEAR320_INT_STS_MASK_REG,
@@ -158,7 +194,7 @@ static struct spear_shirq *spear320_shirq_blocks[] = {
 static void shirq_irq_mask_unmask(struct irq_data *d, bool mask)
 {
        struct spear_shirq *shirq = irq_data_get_irq_chip_data(d);
-       u32 val, offset = d->irq - shirq->irq_base;
+       u32 val, offset = d->irq - shirq->virq_base;
        unsigned long flags;
 
        if (shirq->regs.enb_reg == -1)
@@ -168,9 +204,9 @@ static void shirq_irq_mask_unmask(struct irq_data *d, bool mask)
        val = readl(shirq->base + shirq->regs.enb_reg);
 
        if (mask ^ shirq->regs.reset_to_enb)
-               val &= ~(0x1 << shirq->irq_bit_off << offset);
+               val &= ~(0x1 << shirq->offset << offset);
        else
-               val |= 0x1 << shirq->irq_bit_off << offset;
+               val |= 0x1 << shirq->offset << offset;
 
        writel(val, shirq->base + shirq->regs.enb_reg);
        spin_unlock_irqrestore(&lock, flags);
@@ -203,17 +239,17 @@ static void shirq_handler(unsigned irq, struct irq_desc *desc)
        chip = irq_get_chip(irq);
        chip->irq_ack(&desc->irq_data);
 
-       mask = ((0x1 << shirq->irq_nr) - 1) << shirq->irq_bit_off;
+       mask = ((0x1 << shirq->nr_irqs) - 1) << shirq->offset;
        while ((val = readl(shirq->base + shirq->regs.status_reg) &
                                mask)) {
 
-               val >>= shirq->irq_bit_off;
-               for (i = 0, j = 1; i < shirq->irq_nr; i++, j <<= 1) {
+               val >>= shirq->offset;
+               for (i = 0, j = 1; i < shirq->nr_irqs; i++, j <<= 1) {
 
                        if (!(j & val))
                                continue;
 
-                       generic_handle_irq(shirq->irq_base + i);
+                       generic_handle_irq(shirq->virq_base + i);
 
                        /* clear interrupt */
                        if (shirq->regs.clear_reg == -1)
@@ -221,38 +257,39 @@ static void shirq_handler(unsigned irq, struct irq_desc *desc)
 
                        tmp = readl(shirq->base + shirq->regs.clear_reg);
                        if (shirq->regs.reset_to_clear)
-                               tmp &= ~(j << shirq->irq_bit_off);
+                               tmp &= ~(j << shirq->offset);
                        else
-                               tmp |= (j << shirq->irq_bit_off);
+                               tmp |= (j << shirq->offset);
                        writel(tmp, shirq->base + shirq->regs.clear_reg);
                }
        }
        chip->irq_unmask(&desc->irq_data);
 }
 
-static void __init spear_shirq_register(struct spear_shirq *shirq)
+static void __init spear_shirq_register(struct spear_shirq *shirq,
+                                       int parent_irq)
 {
        int i;
 
-       if (shirq->invalid_irq)
+       if (shirq->disabled)
                return;
 
-       irq_set_chained_handler(shirq->irq, shirq_handler);
-       for (i = 0; i < shirq->irq_nr; i++) {
-               irq_set_chip_and_handler(shirq->irq_base + i,
+       irq_set_chained_handler(parent_irq, shirq_handler);
+       irq_set_handler_data(parent_irq, shirq);
+
+       for (i = 0; i < shirq->nr_irqs; i++) {
+               irq_set_chip_and_handler(shirq->virq_base + i,
                                         &shirq_chip, handle_simple_irq);
-               set_irq_flags(shirq->irq_base + i, IRQF_VALID);
-               irq_set_chip_data(shirq->irq_base + i, shirq);
+               set_irq_flags(shirq->virq_base + i, IRQF_VALID);
+               irq_set_chip_data(shirq->virq_base + i, shirq);
        }
-
-       irq_set_handler_data(shirq->irq, shirq);
 }
 
 static int __init shirq_init(struct spear_shirq **shirq_blocks, int block_nr,
                struct device_node *np)
 {
-       int i, irq_base, hwirq = 0, irq_nr = 0;
-       static struct irq_domain *shirq_domain;
+       int i, parent_irq, virq_base, hwirq = 0, nr_irqs = 0;
+       struct irq_domain *shirq_domain;
        void __iomem *base;
 
        base = of_iomap(np, 0);
@@ -262,15 +299,15 @@ static int __init shirq_init(struct spear_shirq **shirq_blocks, int block_nr,
        }
 
        for (i = 0; i < block_nr; i++)
-               irq_nr += shirq_blocks[i]->irq_nr;
+               nr_irqs += shirq_blocks[i]->nr_irqs;
 
-       irq_base = irq_alloc_descs(-1, 0, irq_nr, 0);
-       if (IS_ERR_VALUE(irq_base)) {
+       virq_base = irq_alloc_descs(-1, 0, nr_irqs, 0);
+       if (IS_ERR_VALUE(virq_base)) {
                pr_err("%s: irq desc alloc failed\n", __func__);
                goto err_unmap;
        }
 
-       shirq_domain = irq_domain_add_legacy(np, irq_nr, irq_base, 0,
+       shirq_domain = irq_domain_add_legacy(np, nr_irqs, virq_base, 0,
                        &irq_domain_simple_ops, NULL);
        if (WARN_ON(!shirq_domain)) {
                pr_warn("%s: irq domain init failed\n", __func__);
@@ -279,41 +316,41 @@ static int __init shirq_init(struct spear_shirq **shirq_blocks, int block_nr,
 
        for (i = 0; i < block_nr; i++) {
                shirq_blocks[i]->base = base;
-               shirq_blocks[i]->irq_base = irq_find_mapping(shirq_domain,
+               shirq_blocks[i]->virq_base = irq_find_mapping(shirq_domain,
                                hwirq);
-               shirq_blocks[i]->irq = irq_of_parse_and_map(np, i);
 
-               spear_shirq_register(shirq_blocks[i]);
-               hwirq += shirq_blocks[i]->irq_nr;
+               parent_irq = irq_of_parse_and_map(np, i);
+               spear_shirq_register(shirq_blocks[i], parent_irq);
+               hwirq += shirq_blocks[i]->nr_irqs;
        }
 
        return 0;
 
 err_free_desc:
-       irq_free_descs(irq_base, irq_nr);
+       irq_free_descs(virq_base, nr_irqs);
 err_unmap:
        iounmap(base);
        return -ENXIO;
 }
 
-int __init spear300_shirq_of_init(struct device_node *np,
-               struct device_node *parent)
+static int __init spear300_shirq_of_init(struct device_node *np,
+                                        struct device_node *parent)
 {
        return shirq_init(spear300_shirq_blocks,
                        ARRAY_SIZE(spear300_shirq_blocks), np);
 }
 IRQCHIP_DECLARE(spear300_shirq, "st,spear300-shirq", spear300_shirq_of_init);
 
-int __init spear310_shirq_of_init(struct device_node *np,
-               struct device_node *parent)
+static int __init spear310_shirq_of_init(struct device_node *np,
+                                        struct device_node *parent)
 {
        return shirq_init(spear310_shirq_blocks,
                        ARRAY_SIZE(spear310_shirq_blocks), np);
 }
 IRQCHIP_DECLARE(spear310_shirq, "st,spear310-shirq", spear310_shirq_of_init);
 
-int __init spear320_shirq_of_init(struct device_node *np,
-               struct device_node *parent)
+static int __init spear320_shirq_of_init(struct device_node *np,
+                                        struct device_node *parent)
 {
        return shirq_init(spear320_shirq_blocks,
                        ARRAY_SIZE(spear320_shirq_blocks), np);