]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blobdiff - drivers/media/video/msp3400.c
V4L/DVB (3233): Fixed API to set I2S speed control
[mirror_ubuntu-artful-kernel.git] / drivers / media / video / msp3400.c
index 4689dee882f38f6d8faba0a1dab9fd83920362ee..11235c1ac5c6b76cf9ba32a086525e4f8448b5a8 100644 (file)
@@ -45,7 +45,6 @@
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/i2c.h>
-#include <linux/videodev.h>
 #include <linux/init.h>
 #include <linux/smp_lock.h>
 #include <linux/kthread.h>
 #include <asm/semaphore.h>
 #include <asm/pgtable.h>
 
+#include <linux/videodev.h>
 #include <media/audiochip.h>
-#include <media/id.h>
+#include <media/v4l2-common.h>
 #include "msp3400.h"
 
+/* ---------------------------------------------------------------------- */
+
+#define I2C_MSP3400C       0x80
+#define I2C_MSP3400C_ALT   0x88
+
+#define I2C_MSP3400C_DEM   0x10
+#define I2C_MSP3400C_DFP   0x12
+
+/* Addresses to scan */
+static unsigned short normal_i2c[] = {
+       I2C_MSP3400C      >> 1,
+       I2C_MSP3400C_ALT  >> 1,
+       I2C_CLIENT_END
+};
+I2C_CLIENT_INSMOD;
+
+#define msp3400_dbg(fmt, arg...) \
+       do { \
+               if (debug) \
+                       printk(KERN_INFO "%s debug %d-%04x: " fmt, \
+                              client->driver->driver.name, \
+                              i2c_adapter_id(client->adapter), client->addr , ## arg); \
+       } while (0)
+
+/* Medium volume debug. */
+#define msp3400_dbg_mediumvol(fmt, arg...) \
+       do { \
+               if (debug >= 2) \
+                       printk(KERN_INFO "%s debug %d-%04x: " fmt, \
+                               client->driver->driver.name, \
+                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
+       } while (0)
+
+/* High volume debug. Use with care. */
+#define msp3400_dbg_highvol(fmt, arg...) \
+       do { \
+               if (debug >= 16) \
+                       printk(KERN_INFO "%s debug %d-%04x: " fmt, \
+                               client->driver->driver.name, \
+                               i2c_adapter_id(client->adapter), client->addr , ## arg); \
+       } while (0)
+
+#define msp3400_err(fmt, arg...) do { \
+       printk(KERN_ERR "%s %d-%04x: " fmt, client->driver->driver.name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+#define msp3400_warn(fmt, arg...) do { \
+       printk(KERN_WARNING "%s %d-%04x: " fmt, client->driver->driver.name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+#define msp3400_info(fmt, arg...) do { \
+       printk(KERN_INFO "%s %d-%04x: " fmt, client->driver->driver.name, \
+               i2c_adapter_id(client->adapter), client->addr , ## arg); } while (0)
+
 #define OPMODE_AUTO    -1
 #define OPMODE_MANUAL   0
 #define OPMODE_SIMPLE   1   /* use short programming (>= msp3410 only) */
@@ -91,6 +143,8 @@ struct msp3400c {
        int stereo;
        int nicam_on;
        int acb;
+       int in_scart;
+       int i2s_mode;
        int main, second;       /* sound carrier */
        int input;
        int source;             /* see msp34xxg_set_source */
@@ -100,7 +154,7 @@ struct msp3400c {
        int rxsubchans;
 
        int muted;
-       int left, right;        /* volume */
+       int left, right;        /* volume */
        int bass, treble;
 
        /* shadow register set */
@@ -113,8 +167,6 @@ struct msp3400c {
        int                  watch_stereo:1;
 };
 
-#define MIN(a,b) (((a)>(b))?(b):(a))
-#define MAX(a,b) (((a)>(b))?(a):(b))
 #define HAVE_NICAM(msp)   (((msp->rev2>>8) & 0xff) != 00)
 #define HAVE_SIMPLE(msp)  ((msp->rev1      & 0xff) >= 'D'-'@')
 #define HAVE_SIMPLER(msp) ((msp->rev1      & 0xff) >= 'G'-'@')
@@ -124,10 +176,6 @@ struct msp3400c {
 
 /* ---------------------------------------------------------------------- */
 
-#define dprintk      if (debug >= 1) printk
-#define d2printk     if (debug >= 2) printk
-#define dprintk_trace if (debug>=16) printk
-
 /* read-only */
 module_param(opmode,           int, 0444);
 
@@ -147,21 +195,6 @@ MODULE_PARM_DESC(standard, "Specify audio standard: 32 = NTSC, 64 = radio, Defau
 MODULE_PARM_DESC(amsound, "Hardwire AM sound at 6.5Hz (France), FM can autoscan");
 MODULE_PARM_DESC(dolby, "Activates Dolby processsing");
 
-/* ---------------------------------------------------------------------- */
-
-#define I2C_MSP3400C       0x80
-#define I2C_MSP3400C_ALT   0x88
-
-#define I2C_MSP3400C_DEM   0x10
-#define I2C_MSP3400C_DFP   0x12
-
-/* Addresses to scan */
-static unsigned short normal_i2c[] = {
-       I2C_MSP3400C      >> 1,
-       I2C_MSP3400C_ALT  >> 1,
-       I2C_CLIENT_END
-};
-I2C_CLIENT_INSMOD;
 
 MODULE_DESCRIPTION("device driver for msp34xx TV sound processor");
 MODULE_AUTHOR("Gerd Knorr");
@@ -186,13 +219,13 @@ static int msp3400c_reset(struct i2c_client *client)
                { client->addr, I2C_M_RD, 2, read  },
        };
 
-       dprintk_trace("trace: msp3400c_reset\n");
+       msp3400_dbg_highvol("msp3400c_reset\n");
        if ( (1 != i2c_transfer(client->adapter,&reset[0],1)) ||
             (1 != i2c_transfer(client->adapter,&reset[1],1)) ||
             (2 != i2c_transfer(client->adapter,test,2)) ) {
-               printk(KERN_ERR "msp3400: chip reset failed\n");
+               msp3400_err("chip reset failed\n");
                return -1;
-        }
+       }
        return 0;
 }
 
@@ -200,65 +233,59 @@ static int msp3400c_read(struct i2c_client *client, int dev, int addr)
 {
        int err,retval;
 
-        unsigned char write[3];
-        unsigned char read[2];
-        struct i2c_msg msgs[2] = {
-                { client->addr, 0,        3, write },
-                { client->addr, I2C_M_RD, 2, read  }
-        };
+       unsigned char write[3];
+       unsigned char read[2];
+       struct i2c_msg msgs[2] = {
+               { client->addr, 0,        3, write },
+               { client->addr, I2C_M_RD, 2, read  }
+       };
 
-        write[0] = dev+1;
-        write[1] = addr >> 8;
-        write[2] = addr & 0xff;
+       write[0] = dev+1;
+       write[1] = addr >> 8;
+       write[2] = addr & 0xff;
 
        for (err = 0; err < 3;) {
                if (2 == i2c_transfer(client->adapter,msgs,2))
                        break;
                err++;
-               printk(KERN_WARNING
-                      "msp34xx: I/O error #%d (read 0x%02x/0x%02x)\n", err,
+               msp3400_warn("I/O error #%d (read 0x%02x/0x%02x)\n", err,
                       dev, addr);
                current->state = TASK_INTERRUPTIBLE;
                schedule_timeout(msecs_to_jiffies(10));
        }
        if (3 == err) {
-               printk(KERN_WARNING
-                      "msp34xx: giving up, reseting chip. Sound will go off, sorry folks :-|\n");
+               msp3400_warn("giving up, resetting chip. Sound will go off, sorry folks :-|\n");
                msp3400c_reset(client);
                return -1;
        }
        retval = read[0] << 8 | read[1];
-       dprintk_trace("trace: msp3400c_read(0x%x, 0x%x): 0x%x\n", dev, addr,
-                     retval);
+       msp3400_dbg_highvol("msp3400c_read(0x%x, 0x%x): 0x%x\n", dev, addr, retval);
        return retval;
 }
 
 static int msp3400c_write(struct i2c_client *client, int dev, int addr, int val)
 {
        int err;
-        unsigned char buffer[5];
+       unsigned char buffer[5];
 
-        buffer[0] = dev;
-        buffer[1] = addr >> 8;
-        buffer[2] = addr &  0xff;
-        buffer[3] = val  >> 8;
-        buffer[4] = val  &  0xff;
+       buffer[0] = dev;
+       buffer[1] = addr >> 8;
+       buffer[2] = addr &  0xff;
+       buffer[3] = val  >> 8;
+       buffer[4] = val  &  0xff;
 
-       dprintk_trace("trace: msp3400c_write(0x%x, 0x%x, 0x%x)\n", dev, addr,
-                     val);
+       msp3400_dbg_highvol("msp3400c_write(0x%x, 0x%x, 0x%x)\n", dev, addr, val);
        for (err = 0; err < 3;) {
                if (5 == i2c_master_send(client, buffer, 5))
                        break;
                err++;
-               printk(KERN_WARNING
-                      "msp34xx: I/O error #%d (write 0x%02x/0x%02x)\n", err,
+               msp3400_warn("I/O error #%d (write 0x%02x/0x%02x)\n", err,
                       dev, addr);
                current->state = TASK_INTERRUPTIBLE;
                schedule_timeout(msecs_to_jiffies(10));
        }
        if (3 == err) {
-               printk(KERN_WARNING
-                      "msp34xx: giving up, reseting chip. Sound will go off, sorry folks :-|\n");
+               msp3400_warn("giving up, reseting chip. Sound will go off, sorry folks :-|\n");
                msp3400c_reset(client);
                return -1;
        }
@@ -365,12 +392,40 @@ static struct CARRIER_DETECT carrier_detect_65[] = {
 
 #define CARRIER_COUNT(x) (sizeof(x)/sizeof(struct CARRIER_DETECT))
 
-/* ----------------------------------------------------------------------- */
+/* ----------------------------------------------------------------------- *
+ * bits  9  8  5 - SCART DSP input Select:
+ *       0  0  0 - SCART 1 to DSP input (reset position)
+ *       0  1  0 - MONO to DSP input
+ *       1  0  0 - SCART 2 to DSP input
+ *       1  1  1 - Mute DSP input
+ *
+ * bits 11 10  6 - SCART 1 Output Select:
+ *       0  0  0 - undefined (reset position)
+ *       0  1  0 - SCART 2 Input to SCART 1 Output (for devices with 2 SCARTS)
+ *       1  0  0 - MONO input to SCART 1 Output
+ *       1  1  0 - SCART 1 DA to SCART 1 Output
+ *       0  0  1 - SCART 2 DA to SCART 1 Output
+ *       0  1  1 - SCART 1 Input to SCART 1 Output
+ *       1  1  1 - Mute SCART 1 Output
+ *
+ * bits 13 12  7 - SCART 2 Output Select (for devices with 2 Output SCART):
+ *       0  0  0 - SCART 1 DA to SCART 2 Output (reset position)
+ *       0  1  0 - SCART 1 Input to SCART 2 Output
+ *       1  0  0 - MONO input to SCART 2 Output
+ *       0  0  1 - SCART 2 DA to SCART 2 Output
+ *       0  1  1 - SCART 2 Input to SCART 2 Output
+ *       1  1  0 - Mute SCART 2 Output
+ *
+ * Bits 4 to 0 should be zero.
+ * ----------------------------------------------------------------------- */
 
 static int scarts[3][9] = {
        /* MASK    IN1     IN2     IN1_DA  IN2_DA  IN3     IN4     MONO    MUTE   */
+       /* SCART DSP Input select */
        { 0x0320, 0x0000, 0x0200, -1,     -1,     0x0300, 0x0020, 0x0100, 0x0320 },
+       /* SCART1 Output select */
        { 0x0c40, 0x0440, 0x0400, 0x0c00, 0x0040, 0x0000, 0x0840, 0x0800, 0x0c40 },
+       /* SCART2 Output select */
        { 0x3080, 0x1000, 0x1080, 0x0000, 0x0080, 0x2080, 0x3080, 0x2000, 0x3000 },
 };
 
@@ -382,13 +437,23 @@ static void msp3400c_set_scart(struct i2c_client *client, int in, int out)
 {
        struct msp3400c *msp = i2c_get_clientdata(client);
 
-       if (-1 == scarts[out][in])
-               return;
+       msp->in_scart=in;
+
+       if (in >= 1 && in <= 8 && out >= 0 && out <= 2) {
+               if (-1 == scarts[out][in])
+                       return;
+
+               msp->acb &= ~scarts[out][SCART_MASK];
+               msp->acb |=  scarts[out][in];
+       } else
+               msp->acb = 0xf60; /* Mute Input and SCART 1 Output */
+
+       msp3400_dbg("scart switch: %s => %d (ACB=0x%04x)\n",
+                                               scart_names[in], out, msp->acb);
+       msp3400c_write(client,I2C_MSP3400C_DFP, 0x13, msp->acb);
 
-       dprintk("msp34xx: scart switch: %s => %d\n", scart_names[in], out);
-       msp->acb &= ~scarts[out][SCART_MASK];
-       msp->acb |=  scarts[out][in];
-       msp3400c_write(client,I2C_MSP3400C_DFP, 0x0013, msp->acb);
+       /* Sets I2S speed 0 = 1.024 Mbps, 1 = 2.048 Mbps */
+       msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
 }
 
 /* ------------------------------------------------------------------------ */
@@ -408,16 +473,14 @@ static void msp3400c_setvolume(struct i2c_client *client,
        int vol = 0, val = 0, balance = 0;
 
        if (!muted) {
-               /* 0x7f instead if 0x73 here has sound quality issues,
-                * probably due to overmodulation + clipping ... */
                vol = (left > right) ? left : right;
-               val = (vol * 0x73 / 65535) << 8;
+               val = (vol * 0x7f / 65535) << 8;
        }
        if (vol > 0) {
                balance = ((right - left) * 127) / vol;
        }
 
-       dprintk("msp34xx: setvolume: mute=%s %d:%d  v=0x%02x b=0x%02x\n",
+       msp3400_dbg("setvolume: mute=%s %d:%d  v=0x%02x b=0x%02x\n",
                muted ? "on" : "off", left, right, val >> 8, balance);
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0000, val); /* loudspeaker */
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0006, val); /* headphones  */
@@ -430,7 +493,7 @@ static void msp3400c_setbass(struct i2c_client *client, int bass)
 {
        int val = ((bass-32768) * 0x60 / 65535) << 8;
 
-       dprintk("msp34xx: setbass: %d 0x%02x\n", bass, val >> 8);
+       msp3400_dbg("setbass: %d 0x%02x\n", bass, val >> 8);
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0002, val); /* loudspeaker */
 }
 
@@ -438,7 +501,7 @@ static void msp3400c_settreble(struct i2c_client *client, int treble)
 {
        int val = ((treble-32768) * 0x60 / 65535) << 8;
 
-       dprintk("msp34xx: settreble: %d 0x%02x\n",treble, val>>8);
+       msp3400_dbg("settreble: %d 0x%02x\n",treble, val>>8);
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0003, val); /* loudspeaker */
 }
 
@@ -447,7 +510,7 @@ static void msp3400c_setmode(struct i2c_client *client, int type)
        struct msp3400c *msp = i2c_get_clientdata(client);
        int i;
 
-       dprintk("msp3400: setmode: %d\n",type);
+       msp3400_dbg("setmode: %d\n",type);
        msp->mode       = type;
        msp->audmode    = V4L2_TUNER_MODE_MONO;
        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
@@ -526,8 +589,8 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
                /* this method would break everything, let's make sure
                 * it's never called
                 */
-               dprintk
-                   ("msp34xxg: DEBUG WARNING setstereo called with mode=%d instead of set_source (ignored)\n",
+               msp3400_dbg
+                   ("DEBUG WARNING setstereo called with mode=%d instead of set_source (ignored)\n",
                     mode);
                return;
        }
@@ -535,8 +598,7 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
        /* switch demodulator */
        switch (msp->mode) {
        case MSP_MODE_FM_TERRA:
-               dprintk("msp3400: FM setstereo: %s\n",
-                       strmode[mode]);
+               msp3400_dbg("FM setstereo: %s\n", strmode[mode]);
                msp3400c_setcarrier(client,msp->second,msp->main);
                switch (mode) {
                case V4L2_TUNER_MODE_STEREO:
@@ -550,7 +612,7 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
                }
                break;
        case MSP_MODE_FM_SAT:
-               dprintk("msp3400: SAT setstereo: %s\n", strmode[mode]);
+               msp3400_dbg("SAT setstereo: %s\n", strmode[mode]);
                switch (mode) {
                case V4L2_TUNER_MODE_MONO:
                        msp3400c_setcarrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
@@ -569,24 +631,24 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
        case MSP_MODE_FM_NICAM1:
        case MSP_MODE_FM_NICAM2:
        case MSP_MODE_AM_NICAM:
-               dprintk("msp3400: NICAM setstereo: %s\n",strmode[mode]);
+               msp3400_dbg("NICAM setstereo: %s\n",strmode[mode]);
                msp3400c_setcarrier(client,msp->second,msp->main);
                if (msp->nicam_on)
                        nicam=0x0100;
                break;
        case MSP_MODE_BTSC:
-               dprintk("msp3400: BTSC setstereo: %s\n",strmode[mode]);
+               msp3400_dbg("BTSC setstereo: %s\n",strmode[mode]);
                nicam=0x0300;
                break;
        case MSP_MODE_EXTERN:
-               dprintk("msp3400: extern setstereo: %s\n",strmode[mode]);
+               msp3400_dbg("extern setstereo: %s\n",strmode[mode]);
                nicam = 0x0200;
                break;
        case MSP_MODE_FM_RADIO:
-               dprintk("msp3400: FM-Radio setstereo: %s\n",strmode[mode]);
+               msp3400_dbg("FM-Radio setstereo: %s\n",strmode[mode]);
                break;
        default:
-               dprintk("msp3400: mono setstereo\n");
+               msp3400_dbg("mono setstereo\n");
                return;
        }
 
@@ -597,7 +659,7 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
                break;
        case V4L2_TUNER_MODE_MONO:
                if (msp->mode == MSP_MODE_AM_NICAM) {
-                       dprintk("msp3400: switching to AM mono\n");
+                       msp3400_dbg("switching to AM mono\n");
                        /* AM mono decoding is handled by tuner, not MSP chip */
                        /* SCART switching control register */
                        msp3400c_set_scart(client,SCART_MONO,0);
@@ -611,7 +673,7 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
                src = 0x0010 | nicam;
                break;
        }
-       dprintk("msp3400: setstereo final source/matrix = 0x%x\n", src);
+       msp3400_dbg("setstereo final source/matrix = 0x%x\n", src);
 
        if (dolby) {
                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0008,0x0520);
@@ -627,28 +689,52 @@ static void msp3400c_setstereo(struct i2c_client *client, int mode)
 }
 
 static void
-msp3400c_print_mode(struct msp3400c *msp)
+msp3400c_print_mode(struct i2c_client *client)
 {
+       struct msp3400c *msp = i2c_get_clientdata(client);
+
        if (msp->main == msp->second) {
-               dprintk("msp3400: mono sound carrier: %d.%03d MHz\n",
+               msp3400_dbg("mono sound carrier: %d.%03d MHz\n",
                       msp->main/910000,(msp->main/910)%1000);
        } else {
-               dprintk("msp3400: main sound carrier: %d.%03d MHz\n",
+               msp3400_dbg("main sound carrier: %d.%03d MHz\n",
                       msp->main/910000,(msp->main/910)%1000);
        }
        if (msp->mode == MSP_MODE_FM_NICAM1 || msp->mode == MSP_MODE_FM_NICAM2)
-               dprintk("msp3400: NICAM/FM carrier   : %d.%03d MHz\n",
+               msp3400_dbg("NICAM/FM carrier   : %d.%03d MHz\n",
                       msp->second/910000,(msp->second/910)%1000);
        if (msp->mode == MSP_MODE_AM_NICAM)
-               dprintk("msp3400: NICAM/AM carrier   : %d.%03d MHz\n",
+               msp3400_dbg("NICAM/AM carrier   : %d.%03d MHz\n",
                       msp->second/910000,(msp->second/910)%1000);
        if (msp->mode == MSP_MODE_FM_TERRA &&
            msp->main != msp->second) {
-               dprintk("msp3400: FM-stereo carrier : %d.%03d MHz\n",
+               msp3400_dbg("FM-stereo carrier : %d.%03d MHz\n",
                       msp->second/910000,(msp->second/910)%1000);
        }
 }
 
+static void msp3400c_restore_dfp(struct i2c_client *client)
+{
+       struct msp3400c *msp = i2c_get_clientdata(client);
+       int i;
+
+       for (i = 0; i < DFP_COUNT; i++) {
+               if (-1 == msp->dfp_regs[i])
+                       continue;
+               msp3400c_write(client, I2C_MSP3400C_DFP, i, msp->dfp_regs[i]);
+       }
+}
+
+/* if the dfp_regs is set, set what's in there. Otherwise, set the default value */
+static int msp3400c_write_dfp_with_default(struct i2c_client *client,
+                                       int addr, int default_value)
+{
+       struct msp3400c *msp = i2c_get_clientdata(client);
+       int value = default_value;
+       if (addr < DFP_COUNT && -1 != msp->dfp_regs[addr])
+               value = msp->dfp_regs[addr];
+       return msp3400c_write(client, I2C_MSP3400C_DFP, addr, value);
+}
 
 /* ----------------------------------------------------------------------- */
 
@@ -678,7 +764,7 @@ static int autodetect_stereo(struct i2c_client *client)
                val = msp3400c_read(client, I2C_MSP3400C_DFP, 0x18);
                if (val > 32767)
                        val -= 65536;
-               dprintk("msp34xx: stereo detect register: %d\n",val);
+               msp3400_dbg("stereo detect register: %d\n",val);
                if (val > 4096) {
                        rxsubchans = V4L2_TUNER_SUB_STEREO | V4L2_TUNER_SUB_MONO;
                } else if (val < -4096) {
@@ -692,7 +778,7 @@ static int autodetect_stereo(struct i2c_client *client)
        case MSP_MODE_FM_NICAM2:
        case MSP_MODE_AM_NICAM:
                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x23);
-               dprintk("msp34xx: nicam sync=%d, mode=%d\n",
+               msp3400_dbg("nicam sync=%d, mode=%d\n",
                        val & 1, (val & 0x1e) >> 1);
 
                if (val & 1) {
@@ -725,7 +811,7 @@ static int autodetect_stereo(struct i2c_client *client)
                break;
        case MSP_MODE_BTSC:
                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x200);
-               dprintk("msp3410: status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
+               msp3400_dbg("status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
                        val,
                        (val & 0x0002) ? "no"     : "yes",
                        (val & 0x0004) ? "no"     : "yes",
@@ -739,13 +825,13 @@ static int autodetect_stereo(struct i2c_client *client)
        }
        if (rxsubchans != msp->rxsubchans) {
                update = 1;
-               dprintk("msp34xx: watch: rxsubchans %d => %d\n",
+               msp3400_dbg("watch: rxsubchans %d => %d\n",
                        msp->rxsubchans,rxsubchans);
                msp->rxsubchans = rxsubchans;
        }
        if (newnicam != msp->nicam_on) {
                update = 1;
-               dprintk("msp34xx: watch: nicam %d => %d\n",
+               msp3400_dbg("watch: nicam %d => %d\n",
                        msp->nicam_on,newnicam);
                msp->nicam_on = newnicam;
        }
@@ -788,13 +874,14 @@ static void watch_stereo(struct i2c_client *client)
                else if (msp->stereo & VIDEO_SOUND_LANG1)
                        msp3400c_setstereo(client, V4L2_TUNER_MODE_LANG1);
                else
-                       msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
        }
 
        if (once)
                msp->watch_stereo = 0;
 }
 
+
 static int msp3400c_thread(void *data)
 {
        struct i2c_client *client = data;
@@ -802,14 +889,15 @@ static int msp3400c_thread(void *data)
        struct CARRIER_DETECT *cd;
        int count, max1,max2,val1,val2, val,this;
 
-       printk("msp3400: kthread started\n");
+
+       msp3400_info("msp3400 daemon started\n");
        for (;;) {
-               d2printk("msp3400: thread: sleep\n");
+               msp3400_dbg_mediumvol("msp3400 thread: sleep\n");
                msp34xx_sleep(msp,-1);
-               d2printk("msp3400: thread: wakeup\n");
+               msp3400_dbg_mediumvol("msp3400 thread: wakeup\n");
 
        restart:
-               dprintk("msp3410: thread: restart scan\n");
+               msp3400_dbg("thread: restart scan\n");
                msp->restart = 0;
                if (kthread_should_stop())
                        break;
@@ -817,7 +905,7 @@ static int msp3400c_thread(void *data)
                if (VIDEO_MODE_RADIO == msp->norm ||
                    MSP_MODE_EXTERN  == msp->mode) {
                        /* no carrier scan, just unmute */
-                       printk("msp3400: thread: no carrier scan\n");
+                       msp3400_info("thread: no carrier scan\n");
                        msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                        continue;
                }
@@ -834,13 +922,14 @@ static int msp3400c_thread(void *data)
                        goto restart;
 
                /* carrier detect pass #1 -- main carrier */
-               cd = carrier_detect_main; count = CARRIER_COUNT(carrier_detect_main);
+               cd = carrier_detect_main;
+               count = CARRIER_COUNT(carrier_detect_main);
 
                if (amsound && (msp->norm == VIDEO_MODE_SECAM)) {
                        /* autodetect doesn't work well with AM ... */
                        max1 = 3;
                        count = 0;
-                       dprintk("msp3400: AM sound override\n");
+                       msp3400_dbg("AM sound override\n");
                }
 
                for (this = 0; this < count; this++) {
@@ -852,7 +941,7 @@ static int msp3400c_thread(void *data)
                                val -= 65536;
                        if (val1 < val)
                                val1 = val, max1 = this;
-                       dprintk("msp3400: carrier1 val: %5d / %s\n", val,cd[this].name);
+                       msp3400_dbg("carrier1 val: %5d / %s\n", val,cd[this].name);
                }
 
                /* carrier detect pass #2 -- second (stereo) carrier */
@@ -868,13 +957,16 @@ static int msp3400c_thread(void *data)
                case 0: /* 4.5 */
                case 2: /* 6.0 */
                default:
-                       cd = NULL; count = 0;
+                       cd = NULL;
+                       count = 0;
                        break;
                }
 
                if (amsound && (msp->norm == VIDEO_MODE_SECAM)) {
                        /* autodetect doesn't work well with AM ... */
-                       cd = NULL; count = 0; max2 = 0;
+                       cd = NULL;
+                       count = 0;
+                       max2 = 0;
                }
                for (this = 0; this < count; this++) {
                        msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
@@ -885,7 +977,7 @@ static int msp3400c_thread(void *data)
                                val -= 65536;
                        if (val2 < val)
                                val2 = val, max2 = this;
-                       dprintk("msp3400: carrier2 val: %5d / %s\n", val,cd[this].name);
+                       msp3400_dbg("carrier2 val: %5d / %s\n", val,cd[this].name);
                }
 
                /* programm the msp3400 according to the results */
@@ -962,8 +1054,10 @@ static int msp3400c_thread(void *data)
 
                /* unmute */
                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
+               msp3400c_restore_dfp(client);
+
                if (debug)
-                       msp3400c_print_mode(msp);
+                       msp3400c_print_mode(client);
 
                /* monitor tv audio mode */
                while (msp->watch_stereo) {
@@ -972,7 +1066,7 @@ static int msp3400c_thread(void *data)
                        watch_stereo(client);
                }
        }
-       dprintk("msp3400: thread: exit\n");
+       msp3400_dbg("thread: exit\n");
        return 0;
 }
 
@@ -1016,11 +1110,11 @@ static inline const char *msp34xx_standard_mode_name(int mode)
        return "unknown";
 }
 
-static int msp34xx_modus(int norm)
+static int msp34xx_modus(struct i2c_client *client, int norm)
 {
        switch (norm) {
        case VIDEO_MODE_PAL:
-               dprintk("msp34xx: video mode selected to PAL\n");
+               msp3400_dbg("video mode selected to PAL\n");
 
 #if 1
                /* experimental: not sure this works with all chip versions */
@@ -1030,16 +1124,16 @@ static int msp34xx_modus(int norm)
                return 0x1003;
 #endif
        case VIDEO_MODE_NTSC:  /* BTSC */
-               dprintk("msp34xx: video mode selected to NTSC\n");
+               msp3400_dbg("video mode selected to NTSC\n");
                return 0x2003;
        case VIDEO_MODE_SECAM:
-               dprintk("msp34xx: video mode selected to SECAM\n");
+               msp3400_dbg("video mode selected to SECAM\n");
                return 0x0003;
        case VIDEO_MODE_RADIO:
-               dprintk("msp34xx: video mode selected to Radio\n");
+               msp3400_dbg("video mode selected to Radio\n");
                return 0x0003;
        case VIDEO_MODE_AUTO:
-               dprintk("msp34xx: video mode selected to Auto\n");
+               msp3400_dbg("video mode selected to Auto\n");
                return 0x2003;
        default:
                return 0x0003;
@@ -1068,21 +1162,22 @@ static int msp3410d_thread(void *data)
        struct msp3400c *msp = i2c_get_clientdata(client);
        int mode,val,i,std;
 
-       printk("msp3410: daemon started\n");
+       msp3400_info("msp3410 daemon started\n");
+
        for (;;) {
-               d2printk("msp3410: thread: sleep\n");
+               msp3400_dbg_mediumvol("msp3410 thread: sleep\n");
                msp34xx_sleep(msp,-1);
-               d2printk("msp3410: thread: wakeup\n");
+               msp3400_dbg_mediumvol("msp3410 thread: wakeup\n");
 
        restart:
-               dprintk("msp3410: thread: restart scan\n");
+               msp3400_dbg("thread: restart scan\n");
                msp->restart = 0;
                if (kthread_should_stop())
                        break;
 
                if (msp->mode == MSP_MODE_EXTERN) {
                        /* no carrier scan needed, just unmute */
-                       dprintk("msp3410: thread: no carrier scan\n");
+                       msp3400_dbg("thread: no carrier scan\n");
                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                        continue;
                }
@@ -1095,14 +1190,14 @@ static int msp3410d_thread(void *data)
                        goto restart;
 
                /* start autodetect */
-               mode = msp34xx_modus(msp->norm);
+               mode = msp34xx_modus(client, msp->norm);
                std  = msp34xx_standard(msp->norm);
                msp3400c_write(client, I2C_MSP3400C_DEM, 0x30, mode);
                msp3400c_write(client, I2C_MSP3400C_DEM, 0x20, std);
                msp->watch_stereo = 0;
 
                if (debug)
-                       dprintk("msp3410: setting mode: %s (0x%04x)\n",
+                       msp3400_dbg("setting mode: %s (0x%04x)\n",
                               msp34xx_standard_mode_name(std) ,std);
 
                if (std != 1) {
@@ -1118,13 +1213,13 @@ static int msp3410d_thread(void *data)
                                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x7e);
                                if (val < 0x07ff)
                                        break;
-                               dprintk("msp3410: detection still in progress\n");
+                               msp3400_dbg("detection still in progress\n");
                        }
                }
                for (i = 0; modelist[i].name != NULL; i++)
                        if (modelist[i].retval == val)
                                break;
-               dprintk("msp3410: current mode: %s (0x%04x)\n",
+               msp3400_dbg("current mode: %s (0x%04x)\n",
                        modelist[i].name ? modelist[i].name : "unknown",
                        val);
                msp->main   = modelist[i].main;
@@ -1132,7 +1227,7 @@ static int msp3410d_thread(void *data)
 
                if (amsound && (msp->norm == VIDEO_MODE_SECAM) && (val != 0x0009)) {
                        /* autodetection has failed, let backup */
-                       dprintk("msp3410: autodetection failed,"
+                       msp3400_dbg("autodetection failed,"
                                " switching to backup mode: %s (0x%04x)\n",
                                modelist[8].name ? modelist[8].name : "unknown",val);
                        val = 0x0009;
@@ -1206,7 +1301,9 @@ static int msp3410d_thread(void *data)
                msp3400c_setbass(client, msp->bass);
                msp3400c_settreble(client, msp->treble);
                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
-               msp3400c_write(client, I2C_MSP3400C_DFP, 0x0013, msp->acb);
+               msp3400c_write(client, I2C_MSP3400C_DFP, 0x13, msp->acb);
+               msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
+               msp3400c_restore_dfp(client);
 
                /* monitor tv audio mode */
                while (msp->watch_stereo) {
@@ -1215,7 +1312,7 @@ static int msp3410d_thread(void *data)
                        watch_stereo(client);
                }
        }
-       dprintk("msp3410: thread: exit\n");
+       msp3400_dbg("thread: exit\n");
        return 0;
 }
 
@@ -1230,7 +1327,7 @@ static void msp34xxg_set_source(struct i2c_client *client, int source);
 /* (re-)initialize the msp34xxg, according to the current norm in msp->norm
  * return 0 if it worked, -1 if it failed
  */
-static int msp34xxg_init(struct i2c_client *client)
+static int msp34xxg_reset(struct i2c_client *client)
 {
        struct msp3400c *msp = i2c_get_clientdata(client);
        int modus,std;
@@ -1245,8 +1342,10 @@ static int msp34xxg_init(struct i2c_client *client)
                           0x0f20 /* mute DSP input, mute SCART 1 */))
                return -1;
 
+       msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
+
        /* step-by-step initialisation, as described in the manual */
-       modus = msp34xx_modus(msp->norm);
+       modus = msp34xx_modus(client, msp->norm);
        std   = msp34xx_standard(msp->norm);
        modus &= ~0x03; /* STATUS_CHANGE=0 */
        modus |= 0x01;  /* AUTOMATIC_SOUND_DETECTION=1 */
@@ -1257,7 +1356,7 @@ static int msp34xxg_init(struct i2c_client *client)
                return -1;
        if (msp3400c_write(client,
                           I2C_MSP3400C_DEM,
-                          0x20/*stanard*/,
+                          0x20/*standard*/,
                           std))
                return -1;
 
@@ -1265,21 +1364,18 @@ static int msp34xxg_init(struct i2c_client *client)
           standard/audio autodetection right now */
        msp34xxg_set_source(client, msp->source);
 
-       if (msp3400c_write(client, I2C_MSP3400C_DFP,
-                          0x0e, /* AM/FM Prescale */
-                          0x3000 /* default: [15:8] 75khz deviation */))
+       if (msp3400c_write_dfp_with_default(client, 0x0e,       /* AM/FM Prescale */
+                                           0x3000
+                                           /* default: [15:8] 75khz deviation */
+           ))
                return -1;
 
-       if (msp3400c_write(client, I2C_MSP3400C_DFP,
-                          0x10, /* NICAM Prescale */
-                          0x5a00 /* default: 9db gain (as recommended) */))
+       if (msp3400c_write_dfp_with_default(client, 0x10,       /* NICAM Prescale */
+                                           0x5a00
+                                           /* default: 9db gain (as recommended) */
+           ))
                return -1;
 
-       if (msp3400c_write(client,
-                          I2C_MSP3400C_DEM,
-                          0x20, /* STANDARD SELECT  */
-                          standard /* default: 0x01 for automatic standard select*/))
-               return -1;
        return 0;
 }
 
@@ -1289,27 +1385,28 @@ static int msp34xxg_thread(void *data)
        struct msp3400c *msp = i2c_get_clientdata(client);
        int val, std, i;
 
-       printk("msp34xxg: daemon started\n");
+       msp3400_info("msp34xxg daemon started\n");
+
        msp->source = 1; /* default */
        for (;;) {
-               d2printk("msp34xxg: thread: sleep\n");
+               msp3400_dbg_mediumvol("msp34xxg thread: sleep\n");
                msp34xx_sleep(msp,-1);
-               d2printk("msp34xxg: thread: wakeup\n");
+               msp3400_dbg_mediumvol("msp34xxg thread: wakeup\n");
 
        restart:
-               dprintk("msp34xxg: thread: restart scan\n");
+               msp3400_dbg("thread: restart scan\n");
                msp->restart = 0;
                if (kthread_should_stop())
                        break;
 
                /* setup the chip*/
-               msp34xxg_init(client);
+               msp34xxg_reset(client);
                std = standard;
                if (std != 0x01)
                        goto unmute;
 
                /* watch autodetect */
-               dprintk("msp34xxg: triggered autodetect, waiting for result\n");
+               msp3400_dbg("triggered autodetect, waiting for result\n");
                for (i = 0; i < 10; i++) {
                        if (msp34xx_sleep(msp,100))
                                goto restart;
@@ -1320,19 +1417,19 @@ static int msp34xxg_thread(void *data)
                                std = val;
                                break;
                        }
-                       dprintk("msp34xxg: detection still in progress\n");
+                       msp3400_dbg("detection still in progress\n");
                }
                if (0x01 == std) {
-                       dprintk("msp34xxg: detection still in progress after 10 tries. giving up.\n");
+                       msp3400_dbg("detection still in progress after 10 tries. giving up.\n");
                        continue;
                }
 
        unmute:
-               dprintk("msp34xxg: current mode: %s (0x%04x)\n",
+               msp3400_dbg("current mode: %s (0x%04x)\n",
                        msp34xx_standard_mode_name(std), std);
 
                /* unmute: dispatch sound to scart output, set scart volume */
-               dprintk("msp34xxg: unmute\n");
+               msp3400_dbg("unmute\n");
 
                msp3400c_setbass(client, msp->bass);
                msp3400c_settreble(client, msp->treble);
@@ -1344,8 +1441,10 @@ static int msp34xxg_thread(void *data)
                                   0x13, /* ACB */
                                   msp->acb))
                        return -1;
+
+               msp3400c_write(client,I2C_MSP3400C_DEM, 0x40, msp->i2s_mode);
        }
-       dprintk("msp34xxg: thread: exit\n");
+       msp3400_dbg("thread: exit\n");
        return 0;
 }
 
@@ -1364,7 +1463,7 @@ static void msp34xxg_set_source(struct i2c_client *client, int source)
         * for MONO (source==0) downmixing set bit[7:0] to 0x30
         */
        int value = (source&0x07)<<8|(source==0 ? 0x30:0x20);
-       dprintk("msp34xxg: set source to %d (0x%x)\n", source, value);
+       msp3400_dbg("set source to %d (0x%x)\n", source, value);
        msp3400c_write(client,
                       I2C_MSP3400C_DFP,
                       0x08, /* Loudspeaker Output */
@@ -1415,7 +1514,7 @@ static void msp34xxg_detect_stereo(struct i2c_client *client)
                 * this is a problem, I'll handle SAP just like lang1/lang2.
                 */
        }
-       dprintk("msp34xxg: status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
+       msp3400_dbg("status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
                status, is_stereo, is_bilingual, msp->rxsubchans);
 }
 
@@ -1450,170 +1549,6 @@ static void msp34xxg_set_audmode(struct i2c_client *client, int audmode)
 
 /* ----------------------------------------------------------------------- */
 
-static int msp_attach(struct i2c_adapter *adap, int addr, int kind);
-static int msp_detach(struct i2c_client *client);
-static int msp_probe(struct i2c_adapter *adap);
-static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg);
-
-static int msp_suspend(struct device * dev, pm_message_t state);
-static int msp_resume(struct device * dev);
-
-static void msp_wake_thread(struct i2c_client *client);
-
-static struct i2c_driver driver = {
-       .owner          = THIS_MODULE,
-       .name           = "i2c msp3400 driver",
-        .id             = I2C_DRIVERID_MSP3400,
-        .flags          = I2C_DF_NOTIFY,
-        .attach_adapter = msp_probe,
-        .detach_client  = msp_detach,
-        .command        = msp_command,
-       .driver = {
-               .suspend = msp_suspend,
-               .resume  = msp_resume,
-       },
-};
-
-static struct i2c_client client_template =
-{
-       .name      = "(unset)",
-       .flags     = I2C_CLIENT_ALLOW_USE,
-        .driver    = &driver,
-};
-
-static int msp_attach(struct i2c_adapter *adap, int addr, int kind)
-{
-       struct msp3400c *msp;
-        struct i2c_client *c;
-       int (*thread_func)(void *data) = NULL;
-
-        client_template.adapter = adap;
-        client_template.addr = addr;
-
-        if (-1 == msp3400c_reset(&client_template)) {
-                dprintk("msp34xx: no chip found\n");
-                return -1;
-        }
-
-        if (NULL == (c = kmalloc(sizeof(struct i2c_client),GFP_KERNEL)))
-                return -ENOMEM;
-        memcpy(c,&client_template,sizeof(struct i2c_client));
-       if (NULL == (msp = kmalloc(sizeof(struct msp3400c),GFP_KERNEL))) {
-               kfree(c);
-               return -ENOMEM;
-       }
-
-       memset(msp,0,sizeof(struct msp3400c));
-       msp->left = 58880;      /* 0db gain */
-       msp->right = 58880;     /* 0db gain */
-       msp->bass = 32768;
-       msp->treble = 32768;
-       msp->input = -1;
-       msp->muted = 0;
-
-       i2c_set_clientdata(c, msp);
-       init_waitqueue_head(&msp->wq);
-
-       if (-1 == msp3400c_reset(c)) {
-               kfree(msp);
-               kfree(c);
-               dprintk("msp34xx: no chip found\n");
-               return -1;
-       }
-
-       msp->rev1 = msp3400c_read(c, I2C_MSP3400C_DFP, 0x1e);
-       if (-1 != msp->rev1)
-               msp->rev2 = msp3400c_read(c, I2C_MSP3400C_DFP, 0x1f);
-       if ((-1 == msp->rev1) || (0 == msp->rev1 && 0 == msp->rev2)) {
-               kfree(msp);
-               kfree(c);
-               dprintk("msp34xx: error while reading chip version\n");
-               return -1;
-       }
-       printk(KERN_INFO "msp34xx: rev1=0x%04x, rev2=0x%04x\n", msp->rev1, msp->rev2);
-
-       msp3400c_setvolume(c, msp->muted, msp->left, msp->right);
-
-       snprintf(c->name, sizeof(c->name), "MSP34%02d%c-%c%d",
-                (msp->rev2>>8)&0xff, (msp->rev1&0xff)+'@',
-                ((msp->rev1>>8)&0xff)+'@', msp->rev2&0x1f);
-
-       msp->opmode = opmode;
-       if (OPMODE_AUTO == msp->opmode) {
-               if (HAVE_SIMPLER(msp))
-                       msp->opmode = OPMODE_SIMPLER;
-               else if (HAVE_SIMPLE(msp))
-                       msp->opmode = OPMODE_SIMPLE;
-               else
-                       msp->opmode = OPMODE_MANUAL;
-       }
-
-       /* hello world :-) */
-       printk(KERN_INFO "msp34xx: init: chip=%s", c->name);
-       if (HAVE_NICAM(msp))
-               printk(" +nicam");
-       if (HAVE_SIMPLE(msp))
-               printk(" +simple");
-       if (HAVE_SIMPLER(msp))
-               printk(" +simpler");
-       if (HAVE_RADIO(msp))
-               printk(" +radio");
-
-       /* version-specific initialization */
-       switch (msp->opmode) {
-       case OPMODE_MANUAL:
-               printk(" mode=manual");
-               thread_func = msp3400c_thread;
-               break;
-       case OPMODE_SIMPLE:
-               printk(" mode=simple");
-               thread_func = msp3410d_thread;
-               break;
-       case OPMODE_SIMPLER:
-               printk(" mode=simpler");
-               thread_func = msp34xxg_thread;
-               break;
-       }
-       printk("\n");
-
-       /* startup control thread if needed */
-       if (thread_func) {
-               msp->kthread = kthread_run(thread_func, c, "msp34xx");
-               if (NULL == msp->kthread)
-                       printk(KERN_WARNING "msp34xx: kernel_thread() failed\n");
-               msp_wake_thread(c);
-       }
-
-       /* done */
-        i2c_attach_client(c);
-
-       return 0;
-}
-
-static int msp_detach(struct i2c_client *client)
-{
-       struct msp3400c *msp  = i2c_get_clientdata(client);
-
-       /* shutdown control thread */
-       if (msp->kthread) {
-               msp->restart = 1;
-               kthread_stop(msp->kthread);
-       }
-       msp3400c_reset(client);
-
-       i2c_detach_client(client);
-       kfree(msp);
-       kfree(client);
-       return 0;
-}
-
-static int msp_probe(struct i2c_adapter *adap)
-{
-       if (adap->class & I2C_CLASS_TV_ANALOG)
-               return i2c_probe(adap, &addr_data, msp_attach);
-       return 0;
-}
-
 static void msp_wake_thread(struct i2c_client *client)
 {
        struct msp3400c *msp  = i2c_get_clientdata(client);
@@ -1669,6 +1604,45 @@ static void msp_any_detect_stereo(struct i2c_client *client)
        }
 }
 
+static struct v4l2_queryctrl msp34xx_qctrl[] = {
+       {
+               .id            = V4L2_CID_AUDIO_VOLUME,
+               .name          = "Volume",
+               .minimum       = 0,
+               .maximum       = 65535,
+               .step          = 65535/100,
+               .default_value = 58880,
+               .flags         = 0,
+               .type          = V4L2_CTRL_TYPE_INTEGER,
+       },{
+               .id            = V4L2_CID_AUDIO_MUTE,
+               .name          = "Mute",
+               .minimum       = 0,
+               .maximum       = 1,
+               .step          = 1,
+               .default_value = 1,
+               .flags         = 0,
+               .type          = V4L2_CTRL_TYPE_BOOLEAN,
+       },{
+               .id            = V4L2_CID_AUDIO_BASS,
+               .name          = "Bass",
+               .minimum       = 0,
+               .maximum       = 65535,
+               .step          = 65535/100,
+               .default_value = 32768,
+               .type          = V4L2_CTRL_TYPE_INTEGER,
+       },{
+               .id            = V4L2_CID_AUDIO_TREBLE,
+               .name          = "Treble",
+               .minimum       = 0,
+               .maximum       = 65535,
+               .step          = 65535/100,
+               .default_value = 32768,
+               .type          = V4L2_CTRL_TYPE_INTEGER,
+       },
+};
+
+
 static void msp_any_set_audmode(struct i2c_client *client, int audmode)
 {
        struct msp3400c *msp  = i2c_get_clientdata(client);
@@ -1685,16 +1659,107 @@ static void msp_any_set_audmode(struct i2c_client *client, int audmode)
        }
 }
 
+static int msp_get_ctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+       struct msp3400c *msp  = i2c_get_clientdata(client);
+
+       switch (ctrl->id) {
+       case V4L2_CID_AUDIO_MUTE:
+               ctrl->value = msp->muted;
+               return 0;
+       case V4L2_CID_AUDIO_BALANCE:
+       {
+               int volume = max(msp->left, msp->right);
+
+               ctrl->value = (32768 * min(msp->left, msp->right)) /
+                   (volume ? volume : 1);
+               ctrl->value = (msp->left < msp->right) ?
+                   (65535 - ctrl->value) : ctrl->value;
+               if (0 == volume)
+                       ctrl->value = 32768;
+               return 0;
+       }
+       case V4L2_CID_AUDIO_BASS:
+               ctrl->value = msp->bass;
+               return 0;
+       case V4L2_CID_AUDIO_TREBLE:
+               ctrl->value = msp->treble;
+               return 0;
+       case V4L2_CID_AUDIO_VOLUME:
+               ctrl->value = max(msp->left, msp->right);
+               return 0;
+       default:
+               return -EINVAL;
+       }
+}
+
+static int msp_set_ctrl(struct i2c_client *client, struct v4l2_control *ctrl)
+{
+       struct msp3400c *msp  = i2c_get_clientdata(client);
+       int set_volume=0, balance, volume;
+
+       switch (ctrl->id) {
+       case V4L2_CID_AUDIO_MUTE:
+               if (ctrl->value>=0 && ctrl->value<2)
+                       msp->muted = ctrl->value;
+               else
+                       return -ERANGE;
+
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
+               return 0;
+       case V4L2_CID_AUDIO_BALANCE:
+               balance=ctrl->value;
+               volume = max(msp->left, msp->right);
+               set_volume=1;
+               break;
+       case V4L2_CID_AUDIO_BASS:
+               msp->bass=ctrl->value;
+               msp3400c_setbass(client, msp->bass);
+               return 0;
+       case V4L2_CID_AUDIO_TREBLE:
+               msp->treble=ctrl->value;
+               msp3400c_settreble(client, msp->treble);
+               return 0;
+       case V4L2_CID_AUDIO_VOLUME:
+               volume = max(msp->left, msp->right);
+
+               balance = (32768 * min(msp->left, msp->right)) /
+                                       (volume ? volume : 1);
+               balance = (msp->left < msp->right) ?
+                                       (65535 - balance) : balance;
+               if (0 == volume)
+                       balance = 32768;
+
+               volume=ctrl->value;
+               set_volume=1;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       if (set_volume) {
+               msp->left = (min(65536 - balance, 32768) * volume) / 32768;
+               msp->right = (min(balance, 32768) * volume) / 32768;
+
+               msp3400_dbg("volume=%d, balance=%d, left=%d, right=%d",
+                       volume,balance,msp->left,msp->right);
+
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
+       }
+       return 0;
+}
+
 static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
 {
        struct msp3400c *msp  = i2c_get_clientdata(client);
-        __u16           *sarg = arg;
+       __u16           *sarg = arg;
        int scart = 0;
 
        switch (cmd) {
 
        case AUDC_SET_INPUT:
-               dprintk("msp34xx: AUDC_SET_INPUT(%d)\n",*sarg);
+               msp3400_dbg("AUDC_SET_INPUT(%d)\n",*sarg);
+
                if (*sarg == msp->input)
                        break;
                msp->input = *sarg;
@@ -1734,9 +1799,9 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                break;
 
        case AUDC_SET_RADIO:
-               dprintk("msp34xx: AUDC_SET_RADIO\n");
+               msp3400_dbg("AUDC_SET_RADIO\n");
                msp->norm = VIDEO_MODE_RADIO;
-               dprintk("msp34xx: switching to radio mode\n");
+               msp3400_dbg("switching to radio mode\n");
                msp->watch_stereo = 0;
                switch (msp->opmode) {
                case OPMODE_MANUAL:
@@ -1753,6 +1818,30 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                        break;
                }
                break;
+               /* work-in-progress:  hook to control the DFP registers */
+       case MSP_SET_DFPREG:
+       {
+               struct msp_dfpreg *r = arg;
+               int i;
+
+               if (r->reg < 0 || r->reg >= DFP_COUNT)
+                       return -EINVAL;
+               for (i = 0; i < sizeof(bl_dfp) / sizeof(int); i++)
+                       if (r->reg == bl_dfp[i])
+                               return -EINVAL;
+               msp->dfp_regs[r->reg] = r->value;
+               msp3400c_write(client, I2C_MSP3400C_DFP, r->reg, r->value);
+               return 0;
+       }
+       case MSP_GET_DFPREG:
+       {
+               struct msp_dfpreg *r = arg;
+
+               if (r->reg < 0 || r->reg >= DFP_COUNT)
+                       return -EINVAL;
+               r->value = msp3400c_read(client, I2C_MSP3400C_DFP, r->reg);
+               return 0;
+       }
 
        /* --- v4l ioctls --- */
        /* take care: bttv does userspace copying, we'll get a
@@ -1761,7 +1850,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        {
                struct video_audio *va = arg;
 
-               dprintk("msp34xx: VIDIOCGAUDIO\n");
+               msp3400_dbg("VIDIOCGAUDIO\n");
                va->flags |= VIDEO_AUDIO_VOLUME |
                        VIDEO_AUDIO_BASS |
                        VIDEO_AUDIO_TREBLE |
@@ -1771,8 +1860,8 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
 
                if (msp->muted)
                        va->flags |= VIDEO_AUDIO_MUTE;
-               va->volume = MAX(msp->left, msp->right);
-               va->balance = (32768 * MIN(msp->left, msp->right)) /
+               va->volume = max(msp->left, msp->right);
+               va->balance = (32768 * min(msp->left, msp->right)) /
                    (va->volume ? va->volume : 1);
                va->balance = (msp->left < msp->right) ?
                    (65535 - va->balance) : va->balance;
@@ -1789,28 +1878,28 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        {
                struct video_audio *va = arg;
 
-               dprintk("msp34xx: VIDIOCSAUDIO\n");
+               msp3400_dbg("VIDIOCSAUDIO\n");
                msp->muted = (va->flags & VIDEO_AUDIO_MUTE);
-               msp->left = (MIN(65536 - va->balance, 32768) *
+               msp->left = (min(65536 - va->balance, 32768) *
                             va->volume) / 32768;
-               msp->right = (MIN(va->balance, 32768) * va->volume) / 32768;
+               msp->right = (min((int)va->balance, 32768) * va->volume) / 32768;
                msp->bass = va->bass;
                msp->treble = va->treble;
-               dprintk("msp34xx: VIDIOCSAUDIO setting va->volume to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting va->volume to %d\n",
                        va->volume);
-               dprintk("msp34xx: VIDIOCSAUDIO setting va->balance to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting va->balance to %d\n",
                        va->balance);
-               dprintk("msp34xx: VIDIOCSAUDIO setting va->flags to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting va->flags to %d\n",
                        va->flags);
-               dprintk("msp34xx: VIDIOCSAUDIO setting msp->left to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting msp->left to %d\n",
                        msp->left);
-               dprintk("msp34xx: VIDIOCSAUDIO setting msp->right to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting msp->right to %d\n",
                        msp->right);
-               dprintk("msp34xx: VIDIOCSAUDIO setting msp->bass to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting msp->bass to %d\n",
                        msp->bass);
-               dprintk("msp34xx: VIDIOCSAUDIO setting msp->treble to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting msp->treble to %d\n",
                        msp->treble);
-               dprintk("msp34xx: VIDIOCSAUDIO setting msp->mode to %d\n",
+               msp3400_dbg("VIDIOCSAUDIO setting msp->mode to %d\n",
                        msp->mode);
                msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                msp3400c_setbass(client, msp->bass);
@@ -1825,7 +1914,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        {
                struct video_channel *vc = arg;
 
-               dprintk("msp34xx: VIDIOCSCHAN (norm=%d)\n",vc->norm);
+               msp3400_dbg("VIDIOCSCHAN (norm=%d)\n",vc->norm);
                msp->norm = vc->norm;
                msp_wake_thread(client);
                break;
@@ -1835,11 +1924,21 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        case VIDIOC_S_FREQUENCY:
        {
                /* new channel -- kick audio carrier scan */
-               dprintk("msp34xx: VIDIOCSFREQ\n");
+               msp3400_dbg("VIDIOCSFREQ\n");
                msp_wake_thread(client);
                break;
        }
 
+       /* msp34xx specific */
+       case MSP_SET_MATRIX:
+       {
+               struct msp_matrix *mspm = arg;
+
+               msp3400_dbg("MSP_SET_MATRIX\n");
+               msp3400c_set_scart(client, mspm->input, mspm->output);
+               break;
+       }
+
        /* --- v4l2 ioctls --- */
        case VIDIOC_S_STD:
        {
@@ -1858,6 +1957,33 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                return 0;
        }
 
+       case VIDIOC_ENUMINPUT:
+       {
+               struct v4l2_input *i = arg;
+
+               if (i->index != 0)
+                       return -EINVAL;
+
+               i->type = V4L2_INPUT_TYPE_TUNER;
+               switch (i->index) {
+               case AUDIO_RADIO:
+                       strcpy(i->name,"Radio");
+                       break;
+               case AUDIO_EXTERN_1:
+                       strcpy(i->name,"Extern 1");
+                       break;
+               case AUDIO_EXTERN_2:
+                       strcpy(i->name,"Extern 2");
+                       break;
+               case AUDIO_TUNER:
+                       strcpy(i->name,"Television");
+                       break;
+               default:
+                       return -EINVAL;
+               }
+               return 0;
+       }
+
        case VIDIOC_G_AUDIO:
        {
                struct v4l2_audio *a = arg;
@@ -1882,7 +2008,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                }
 
                msp_any_detect_stereo(client);
-               if (msp->audmode == V4L2_TUNER_MODE_STEREO) {
+               if (msp->audmode == V4L2_TUNER_MODE_STEREO) {
                        a->capability=V4L2_AUDCAP_STEREO;
                }
 
@@ -1918,7 +2044,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                        msp3400c_set_scart(client,scart,0);
                        msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
                }
-               if (sarg->capability==V4L2_AUDCAP_STEREO) {
+               if (sarg->capability==V4L2_AUDCAP_STEREO) {
                        msp->audmode = V4L2_TUNER_MODE_STEREO;
                } else {
                        msp->audmode &= ~V4L2_TUNER_MODE_STEREO;
@@ -1949,16 +2075,92 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                break;
        }
 
-       /* msp34xx specific */
-       case MSP_SET_MATRIX:
+       case VIDIOC_G_AUDOUT:
        {
-               struct msp_matrix *mspm = arg;
+               struct v4l2_audioout *a=(struct v4l2_audioout *)arg;
+               int idx=a->index;
 
-               dprintk("msp34xx: MSP_SET_MATRIX\n");
-               msp3400c_set_scart(client, mspm->input, mspm->output);
+               memset(a,0,sizeof(*a));
+
+               switch (idx) {
+               case 0:
+                       strcpy(a->name,"Scart1 Out");
+                       break;
+               case 1:
+                       strcpy(a->name,"Scart2 Out");
+                       break;
+               case 2:
+                       strcpy(a->name,"I2S Out");
+                       break;
+               default:
+                       return -EINVAL;
+               }
+               break;
+
+       }
+       case VIDIOC_S_AUDOUT:
+       {
+               struct v4l2_audioout *a=(struct v4l2_audioout *)arg;
+
+               if (a->index<0||a->index>2)
+                       return -EINVAL;
+
+               msp3400_dbg("Setting audio out on msp34xx to input %i\n",a->index);
+               msp3400c_set_scart(client,msp->in_scart,a->index+1);
+
+               break;
+       }
+       case VIDIOC_INT_I2S_CLOCK_FREQ:
+       {
+               u32 *a=(u32 *)arg;
+
+               msp3400_dbg("Setting I2S speed to %d\n",*a);
+
+               switch (*a) {
+                       case 1024000:
+                               msp->i2s_mode=0;
+                               break;
+                       case 2048000:
+                               msp->i2s_mode=1;
+                               break;
+                       default:
+                               return -EINVAL;
+               }
                break;
        }
 
+       case VIDIOC_QUERYCTRL:
+       {
+               struct v4l2_queryctrl *qc = arg;
+               int i;
+
+               msp3400_dbg("VIDIOC_QUERYCTRL\n");
+
+               for (i = 0; i < ARRAY_SIZE(msp34xx_qctrl); i++)
+                       if (qc->id && qc->id ==  msp34xx_qctrl[i].id) {
+                               memcpy(qc, &(msp34xx_qctrl[i]),
+                                       sizeof(*qc));
+                               return 0;
+                       }
+
+               return -EINVAL;
+       }
+       case VIDIOC_G_CTRL:
+       {
+               struct v4l2_control *ctrl = arg;
+               msp3400_dbg("VIDIOC_G_CTRL\n");
+
+               return msp_get_ctrl(client, ctrl);
+       }
+       case VIDIOC_S_CTRL:
+       {
+               struct v4l2_control *ctrl = arg;
+
+               msp3400_dbg("VIDIOC_S_CTRL\n");
+
+               return msp_set_ctrl(client, ctrl);
+       }
+
        default:
                /* nothing */
                break;
@@ -1968,24 +2170,189 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
 
 static int msp_suspend(struct device * dev, pm_message_t state)
 {
-       struct i2c_client *c = container_of(dev, struct i2c_client, dev);
+       struct i2c_client *client = container_of(dev, struct i2c_client, dev);
 
-       dprintk("msp34xx: suspend\n");
-       msp3400c_reset(c);
+       msp3400_dbg("suspend\n");
+       msp3400c_reset(client);
        return 0;
 }
 
 static int msp_resume(struct device * dev)
 {
-       struct i2c_client *c = container_of(dev, struct i2c_client, dev);
+       struct i2c_client *client = container_of(dev, struct i2c_client, dev);
 
-       dprintk("msp34xx: resume\n");
-       msp_wake_thread(c);
+       msp3400_dbg("resume\n");
+       msp_wake_thread(client);
        return 0;
 }
 
 /* ----------------------------------------------------------------------- */
 
+static int msp_probe(struct i2c_adapter *adap);
+static int msp_detach(struct i2c_client *client);
+
+static struct i2c_driver driver = {
+       .owner          = THIS_MODULE,
+       .name           = "msp3400",
+       .id             = I2C_DRIVERID_MSP3400,
+       .flags          = I2C_DF_NOTIFY,
+       .attach_adapter = msp_probe,
+       .detach_client  = msp_detach,
+       .command        = msp_command,
+       .driver = {
+               .suspend = msp_suspend,
+               .resume  = msp_resume,
+       },
+};
+
+static struct i2c_client client_template =
+{
+       .name      = "(unset)",
+       .flags     = I2C_CLIENT_ALLOW_USE,
+       .driver    = &driver,
+};
+
+static int msp_attach(struct i2c_adapter *adap, int addr, int kind)
+{
+       struct msp3400c *msp;
+       struct i2c_client *client = &client_template;
+       int (*thread_func)(void *data) = NULL;
+       int i;
+
+       client_template.adapter = adap;
+       client_template.addr = addr;
+
+       if (-1 == msp3400c_reset(&client_template)) {
+               msp3400_dbg("no chip found\n");
+               return -1;
+       }
+
+       if (NULL == (client = kmalloc(sizeof(struct i2c_client),GFP_KERNEL)))
+               return -ENOMEM;
+       memcpy(client,&client_template,sizeof(struct i2c_client));
+       if (NULL == (msp = kmalloc(sizeof(struct msp3400c),GFP_KERNEL))) {
+               kfree(client);
+               return -ENOMEM;
+       }
+
+       memset(msp,0,sizeof(struct msp3400c));
+       msp->norm = VIDEO_MODE_NTSC;
+       msp->left = 58880;      /* 0db gain */
+       msp->right = 58880;     /* 0db gain */
+       msp->bass = 32768;
+       msp->treble = 32768;
+       msp->input = -1;
+       msp->muted = 0;
+       msp->i2s_mode = 0;
+       for (i = 0; i < DFP_COUNT; i++)
+               msp->dfp_regs[i] = -1;
+
+       i2c_set_clientdata(client, msp);
+       init_waitqueue_head(&msp->wq);
+
+       if (-1 == msp3400c_reset(client)) {
+               kfree(msp);
+               kfree(client);
+               msp3400_dbg("no chip found\n");
+               return -1;
+       }
+
+       msp->rev1 = msp3400c_read(client, I2C_MSP3400C_DFP, 0x1e);
+       if (-1 != msp->rev1)
+               msp->rev2 = msp3400c_read(client, I2C_MSP3400C_DFP, 0x1f);
+       if ((-1 == msp->rev1) || (0 == msp->rev1 && 0 == msp->rev2)) {
+               kfree(msp);
+               kfree(client);
+               msp3400_dbg("error while reading chip version\n");
+               return -1;
+       }
+       msp3400_dbg("rev1=0x%04x, rev2=0x%04x\n", msp->rev1, msp->rev2);
+
+       msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
+
+       snprintf(client->name, sizeof(client->name), "MSP%c4%02d%c-%c%d",
+                ((msp->rev1>>4)&0x0f) + '3',
+                (msp->rev2>>8)&0xff, (msp->rev1&0x0f)+'@',
+                ((msp->rev1>>8)&0xff)+'@', msp->rev2&0x1f);
+
+       msp->opmode = opmode;
+       if (OPMODE_AUTO == msp->opmode) {
+               if (HAVE_SIMPLER(msp))
+                       msp->opmode = OPMODE_SIMPLER;
+               else if (HAVE_SIMPLE(msp))
+                       msp->opmode = OPMODE_SIMPLE;
+               else
+                       msp->opmode = OPMODE_MANUAL;
+       }
+
+       /* hello world :-) */
+       msp3400_info("chip=%s", client->name);
+       if (HAVE_NICAM(msp))
+               printk(" +nicam");
+       if (HAVE_SIMPLE(msp))
+               printk(" +simple");
+       if (HAVE_SIMPLER(msp))
+               printk(" +simpler");
+       if (HAVE_RADIO(msp))
+               printk(" +radio");
+
+       /* version-specific initialization */
+       switch (msp->opmode) {
+       case OPMODE_MANUAL:
+               printk(" mode=manual");
+               thread_func = msp3400c_thread;
+               break;
+       case OPMODE_SIMPLE:
+               printk(" mode=simple");
+               thread_func = msp3410d_thread;
+               break;
+       case OPMODE_SIMPLER:
+               printk(" mode=simpler");
+               thread_func = msp34xxg_thread;
+               break;
+       }
+       printk("\n");
+
+       /* startup control thread if needed */
+       if (thread_func) {
+               msp->kthread = kthread_run(thread_func, client, "msp34xx");
+
+               if (NULL == msp->kthread)
+                       msp3400_warn("kernel_thread() failed\n");
+               msp_wake_thread(client);
+       }
+
+       /* done */
+       i2c_attach_client(client);
+
+       return 0;
+}
+
+static int msp_detach(struct i2c_client *client)
+{
+       struct msp3400c *msp  = i2c_get_clientdata(client);
+
+       /* shutdown control thread */
+       if (msp->kthread) {
+               msp->restart = 1;
+               kthread_stop(msp->kthread);
+       }
+       msp3400c_reset(client);
+
+       i2c_detach_client(client);
+
+       kfree(msp);
+       kfree(client);
+       return 0;
+}
+
+static int msp_probe(struct i2c_adapter *adap)
+{
+       if (adap->class & I2C_CLASS_TV_ANALOG)
+               return i2c_probe(adap, &addr_data, msp_attach);
+       return 0;
+}
+
 static int __init msp3400_init_module(void)
 {
        return i2c_add_driver(&driver);