]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blobdiff - drivers/net/wireless/rtlwifi/rtl8188ee/dm.c
rtlwifi: rtl8188ee: Update driver to match Realtek release of 06282014
[mirror_ubuntu-artful-kernel.git] / drivers / net / wireless / rtlwifi / rtl8188ee / dm.c
index f8daa61cf1c32df10b6ff69428d8aa4e434f090d..2aa34d9055f0e6eebbb9dc91f0c7a356a3a207a7 100644 (file)
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * The full GNU General Public License is included in this distribution in the
  * file called LICENSE.
  *
@@ -188,21 +184,24 @@ static void rtl88e_set_iqk_matrix(struct ieee80211_hw *hw,
                switch (rfpath) {
                case RF90_PATH_A:
                        value32 = (ele_d << 22)|((ele_c & 0x3F)<<16) | ele_a;
-                       rtl_set_bbreg(hw, ROFDM0_XATXIQIMBAL, MASKDWORD,
-                                     value32);
+                       rtl_set_bbreg(hw, ROFDM0_XATXIQIMBALANCE,
+                                     MASKDWORD, value32);
                        value32 = (ele_c & 0x000003C0) >> 6;
-                       rtl_set_bbreg(hw, ROFDM0_XCTXAFE, MASKH4BITS, value32);
+                       rtl_set_bbreg(hw, ROFDM0_XCTXAFE, MASKH4BITS,
+                                     value32);
                        value32 = ((iqk_result_x * ele_d) >> 7) & 0x01;
-                       rtl_set_bbreg(hw, ROFDM0_ECCATHRES, BIT(24), value32);
+                       rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD, BIT(24),
+                                     value32);
                        break;
                case RF90_PATH_B:
                        value32 = (ele_d << 22)|((ele_c & 0x3F)<<16) | ele_a;
-                       rtl_set_bbreg(hw, ROFDM0_XBTXIQIMBAL,
-                                     MASKDWORD, value32);
+                       rtl_set_bbreg(hw, ROFDM0_XBTXIQIMBALANCE, MASKDWORD,
+                                     value32);
                        value32 = (ele_c & 0x000003C0) >> 6;
                        rtl_set_bbreg(hw, ROFDM0_XDTXAFE, MASKH4BITS, value32);
                        value32 = ((iqk_result_x * ele_d) >> 7) & 0x01;
-                       rtl_set_bbreg(hw, ROFDM0_ECCATHRES, BIT(28), value32);
+                       rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD, BIT(28),
+                                     value32);
                        break;
                default:
                        break;
@@ -210,16 +209,20 @@ static void rtl88e_set_iqk_matrix(struct ieee80211_hw *hw,
        } else {
                switch (rfpath) {
                case RF90_PATH_A:
-                       rtl_set_bbreg(hw, ROFDM0_XATXIQIMBAL, MASKDWORD,
-                                     ofdmswing_table[ofdm_index]);
-                       rtl_set_bbreg(hw, ROFDM0_XCTXAFE, MASKH4BITS, 0x00);
-                       rtl_set_bbreg(hw, ROFDM0_ECCATHRES, BIT(24), 0x00);
+                       rtl_set_bbreg(hw, ROFDM0_XATXIQIMBALANCE,
+                                     MASKDWORD, ofdmswing_table[ofdm_index]);
+                       rtl_set_bbreg(hw, ROFDM0_XCTXAFE,
+                                     MASKH4BITS, 0x00);
+                       rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD,
+                                     BIT(24), 0x00);
                        break;
                case RF90_PATH_B:
-                       rtl_set_bbreg(hw, ROFDM0_XBTXIQIMBAL, MASKDWORD,
-                                     ofdmswing_table[ofdm_index]);
-                       rtl_set_bbreg(hw, ROFDM0_XDTXAFE, MASKH4BITS, 0x00);
-                       rtl_set_bbreg(hw, ROFDM0_ECCATHRES, BIT(28), 0x00);
+                       rtl_set_bbreg(hw, ROFDM0_XBTXIQIMBALANCE,
+                                     MASKDWORD, ofdmswing_table[ofdm_index]);
+                       rtl_set_bbreg(hw, ROFDM0_XDTXAFE,
+                                     MASKH4BITS, 0x00);
+                       rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD,
+                                     BIT(28), 0x00);
                        break;
                default:
                        break;
@@ -244,7 +247,7 @@ void rtl88e_dm_txpower_track_adjust(struct ieee80211_hw *hw,
                        pwr_val = ofdm_base - ofdm_val;
                } else {
                        *pdirection = 2;
-                       pwr_val = ofdm_val - ofdm_base;
+                       pwr_val = ofdm_base - ofdm_val;
                }
        } else if (type == 1) {
                if (cck_val <= cck_base) {
@@ -263,46 +266,75 @@ void rtl88e_dm_txpower_track_adjust(struct ieee80211_hw *hw,
                         (pwr_val << 24);
 }
 
-
-static void rtl88e_chk_tx_track(struct ieee80211_hw *hw,
-                               enum pwr_track_control_method method,
-                               u8 rfpath, u8 index)
+static void dm_tx_pwr_track_set_pwr(struct ieee80211_hw *hw,
+                                   enum pwr_track_control_method method,
+                                   u8 rfpath, u8 channel_mapped_index)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct rtl_phy *rtlphy = &(rtlpriv->phy);
+       struct rtl_phy *rtlphy = &rtlpriv->phy;
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       int jj = rtldm->swing_idx_cck;
-       int i;
 
        if (method == TXAGC) {
-               if (rtldm->swing_flag_ofdm == true ||
-                   rtldm->swing_flag_cck == true) {
-                       u8 chan = rtlphy->current_channel;
-                       rtl88e_phy_set_txpower_level(hw, chan);
+               if (rtldm->swing_flag_ofdm ||
+                   rtldm->swing_flag_cck) {
+                       rtl88e_phy_set_txpower_level(hw,
+                                                    rtlphy->current_channel);
                        rtldm->swing_flag_ofdm = false;
                        rtldm->swing_flag_cck = false;
                }
        } else if (method == BBSWING) {
                if (!rtldm->cck_inch14) {
-                       for (i = 0; i < 8; i++)
-                               rtl_write_byte(rtlpriv, 0xa22 + i,
-                                              cck_tbl_ch1_13[jj][i]);
+                       rtl_write_byte(rtlpriv, 0xa22,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][0]);
+                       rtl_write_byte(rtlpriv, 0xa23,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][1]);
+                       rtl_write_byte(rtlpriv, 0xa24,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][2]);
+                       rtl_write_byte(rtlpriv, 0xa25,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][3]);
+                       rtl_write_byte(rtlpriv, 0xa26,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][4]);
+                       rtl_write_byte(rtlpriv, 0xa27,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][5]);
+                       rtl_write_byte(rtlpriv, 0xa28,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][6]);
+                       rtl_write_byte(rtlpriv, 0xa29,
+                                      cck_tbl_ch1_13[rtldm->swing_idx_cck][7]);
                } else {
-                       for (i = 0; i < 8; i++)
-                               rtl_write_byte(rtlpriv, 0xa22 + i,
-                                              cck_tbl_ch14[jj][i]);
+                       rtl_write_byte(rtlpriv, 0xa22,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][0]);
+                       rtl_write_byte(rtlpriv, 0xa23,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][1]);
+                       rtl_write_byte(rtlpriv, 0xa24,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][2]);
+                       rtl_write_byte(rtlpriv, 0xa25,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][3]);
+                       rtl_write_byte(rtlpriv, 0xa26,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][4]);
+                       rtl_write_byte(rtlpriv, 0xa27,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][5]);
+                       rtl_write_byte(rtlpriv, 0xa28,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][6]);
+                       rtl_write_byte(rtlpriv, 0xa29,
+                                      cck_tbl_ch14[rtldm->swing_idx_cck][7]);
                }
 
                if (rfpath == RF90_PATH_A) {
-                       long x = rtlphy->iqk_matrix[index].value[0][0];
-                       long y = rtlphy->iqk_matrix[index].value[0][1];
-                       u8 indx = rtldm->swing_idx_ofdm[rfpath];
-                       rtl88e_set_iqk_matrix(hw, indx, rfpath, x, y);
+                       rtl88e_set_iqk_matrix(hw, rtldm->swing_idx_ofdm[rfpath],
+                                             rfpath, rtlphy->iqk_matrix
+                                             [channel_mapped_index].
+                                             value[0][0],
+                                             rtlphy->iqk_matrix
+                                             [channel_mapped_index].
+                                             value[0][1]);
                } else if (rfpath == RF90_PATH_B) {
-                       u8 indx = rtldm->swing_idx_ofdm[rfpath];
-                       long x = rtlphy->iqk_matrix[indx].value[0][4];
-                       long y = rtlphy->iqk_matrix[indx].value[0][5];
-                       rtl88e_set_iqk_matrix(hw, indx, rfpath, x, y);
+                       rtl88e_set_iqk_matrix(hw, rtldm->swing_idx_ofdm[rfpath],
+                                             rfpath, rtlphy->iqk_matrix
+                                             [channel_mapped_index].
+                                             value[0][4],
+                                             rtlphy->iqk_matrix
+                                             [channel_mapped_index].
+                                             value[0][5]);
                }
        } else {
                return;
@@ -317,7 +349,7 @@ static void rtl88e_dm_diginit(struct ieee80211_hw *hw)
        dm_dig->dig_enable_flag = true;
        dm_dig->cur_igvalue = rtl_get_bbreg(hw, ROFDM0_XAAGCCORE1, 0x7f);
        dm_dig->pre_igvalue = 0;
-       dm_dig->cursta_cstate = DIG_STA_DISCONNECT;
+       dm_dig->cur_sta_cstate = DIG_STA_DISCONNECT;
        dm_dig->presta_cstate = DIG_STA_DISCONNECT;
        dm_dig->curmultista_cstate = DIG_MULTISTA_DISCONNECT;
        dm_dig->rssi_lowthresh = DM_DIG_THRESH_LOW;
@@ -348,22 +380,23 @@ static u8 rtl88e_dm_initial_gain_min_pwdb(struct ieee80211_hw *hw)
        long rssi_val_min = 0;
 
        if ((dm_dig->curmultista_cstate == DIG_MULTISTA_CONNECT) &&
-           (dm_dig->cursta_cstate == DIG_STA_CONNECT)) {
+           (dm_dig->cur_sta_cstate == DIG_STA_CONNECT)) {
                if (rtlpriv->dm.entry_min_undec_sm_pwdb != 0)
                        rssi_val_min =
                            (rtlpriv->dm.entry_min_undec_sm_pwdb >
-                           rtlpriv->dm.undec_sm_pwdb) ?
+                            rtlpriv->dm.undec_sm_pwdb) ?
                            rtlpriv->dm.undec_sm_pwdb :
                            rtlpriv->dm.entry_min_undec_sm_pwdb;
                else
                        rssi_val_min = rtlpriv->dm.undec_sm_pwdb;
-       } else if (dm_dig->cursta_cstate == DIG_STA_CONNECT ||
-                  dm_dig->cursta_cstate == DIG_STA_BEFORE_CONNECT) {
+       } else if (dm_dig->cur_sta_cstate == DIG_STA_CONNECT ||
+                  dm_dig->cur_sta_cstate == DIG_STA_BEFORE_CONNECT) {
                rssi_val_min = rtlpriv->dm.undec_sm_pwdb;
        } else if (dm_dig->curmultista_cstate ==
                DIG_MULTISTA_CONNECT) {
                rssi_val_min = rtlpriv->dm.entry_min_undec_sm_pwdb;
        }
+
        return (u8)rssi_val_min;
 }
 
@@ -371,57 +404,58 @@ static void rtl88e_dm_false_alarm_counter_statistics(struct ieee80211_hw *hw)
 {
        u32 ret_value;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct false_alarm_statistics *alm_cnt = &(rtlpriv->falsealm_cnt);
+       struct false_alarm_statistics *falsealm_cnt = &rtlpriv->falsealm_cnt;
 
        rtl_set_bbreg(hw, ROFDM0_LSTF, BIT(31), 1);
        rtl_set_bbreg(hw, ROFDM1_LSTF, BIT(31), 1);
 
        ret_value = rtl_get_bbreg(hw, ROFDM0_FRAMESYNC, MASKDWORD);
-       alm_cnt->cnt_fast_fsync_fail = (ret_value&0xffff);
-       alm_cnt->cnt_sb_search_fail = ((ret_value&0xffff0000)>>16);
+       falsealm_cnt->cnt_fast_fsync_fail = (ret_value&0xffff);
+       falsealm_cnt->cnt_sb_search_fail = ((ret_value&0xffff0000)>>16);
 
        ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER1, MASKDWORD);
-       alm_cnt->cnt_ofdm_cca = (ret_value&0xffff);
-       alm_cnt->cnt_parity_fail = ((ret_value & 0xffff0000) >> 16);
+       falsealm_cnt->cnt_ofdm_cca = (ret_value&0xffff);
+       falsealm_cnt->cnt_parity_fail = ((ret_value & 0xffff0000) >> 16);
 
        ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER2, MASKDWORD);
-       alm_cnt->cnt_rate_illegal = (ret_value & 0xffff);
-       alm_cnt->cnt_crc8_fail = ((ret_value & 0xffff0000) >> 16);
+       falsealm_cnt->cnt_rate_illegal = (ret_value & 0xffff);
+       falsealm_cnt->cnt_crc8_fail = ((ret_value & 0xffff0000) >> 16);
 
        ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER3, MASKDWORD);
-       alm_cnt->cnt_mcs_fail = (ret_value & 0xffff);
-       alm_cnt->cnt_ofdm_fail = alm_cnt->cnt_parity_fail +
-                                alm_cnt->cnt_rate_illegal +
-                                alm_cnt->cnt_crc8_fail +
-                                alm_cnt->cnt_mcs_fail +
-                                alm_cnt->cnt_fast_fsync_fail +
-                                alm_cnt->cnt_sb_search_fail;
+       falsealm_cnt->cnt_mcs_fail = (ret_value & 0xffff);
+       falsealm_cnt->cnt_ofdm_fail = falsealm_cnt->cnt_parity_fail +
+               falsealm_cnt->cnt_rate_illegal +
+               falsealm_cnt->cnt_crc8_fail +
+               falsealm_cnt->cnt_mcs_fail +
+               falsealm_cnt->cnt_fast_fsync_fail +
+               falsealm_cnt->cnt_sb_search_fail;
 
        ret_value = rtl_get_bbreg(hw, REG_SC_CNT, MASKDWORD);
-       alm_cnt->cnt_bw_lsc = (ret_value & 0xffff);
-       alm_cnt->cnt_bw_usc = ((ret_value & 0xffff0000) >> 16);
+       falsealm_cnt->cnt_bw_lsc = (ret_value & 0xffff);
+       falsealm_cnt->cnt_bw_usc = ((ret_value & 0xffff0000) >> 16);
 
        rtl_set_bbreg(hw, RCCK0_FALSEALARMREPORT, BIT(12), 1);
        rtl_set_bbreg(hw, RCCK0_FALSEALARMREPORT, BIT(14), 1);
 
        ret_value = rtl_get_bbreg(hw, RCCK0_FACOUNTERLOWER, MASKBYTE0);
-       alm_cnt->cnt_cck_fail = ret_value;
+       falsealm_cnt->cnt_cck_fail = ret_value;
 
        ret_value = rtl_get_bbreg(hw, RCCK0_FACOUNTERUPPER, MASKBYTE3);
-       alm_cnt->cnt_cck_fail += (ret_value & 0xff) << 8;
+       falsealm_cnt->cnt_cck_fail += (ret_value & 0xff) << 8;
 
        ret_value = rtl_get_bbreg(hw, RCCK0_CCA_CNT, MASKDWORD);
-       alm_cnt->cnt_cck_cca = ((ret_value & 0xff) << 8) |
-                               ((ret_value&0xFF00)>>8);
-
-       alm_cnt->cnt_all = alm_cnt->cnt_fast_fsync_fail +
-                          alm_cnt->cnt_sb_search_fail +
-                          alm_cnt->cnt_parity_fail +
-                          alm_cnt->cnt_rate_illegal +
-                          alm_cnt->cnt_crc8_fail +
-                          alm_cnt->cnt_mcs_fail +
-                          alm_cnt->cnt_cck_fail;
-       alm_cnt->cnt_cca_all = alm_cnt->cnt_ofdm_cca + alm_cnt->cnt_cck_cca;
+       falsealm_cnt->cnt_cck_cca = ((ret_value & 0xff) << 8) |
+               ((ret_value&0xFF00)>>8);
+
+       falsealm_cnt->cnt_all = (falsealm_cnt->cnt_fast_fsync_fail +
+                               falsealm_cnt->cnt_sb_search_fail +
+                               falsealm_cnt->cnt_parity_fail +
+                               falsealm_cnt->cnt_rate_illegal +
+                               falsealm_cnt->cnt_crc8_fail +
+                               falsealm_cnt->cnt_mcs_fail +
+                               falsealm_cnt->cnt_cck_fail);
+       falsealm_cnt->cnt_cca_all = falsealm_cnt->cnt_ofdm_cca +
+               falsealm_cnt->cnt_cck_cca;
 
        rtl_set_bbreg(hw, ROFDM0_TRSWISOLATION, BIT(31), 1);
        rtl_set_bbreg(hw, ROFDM0_TRSWISOLATION, BIT(31), 0);
@@ -435,16 +469,15 @@ static void rtl88e_dm_false_alarm_counter_statistics(struct ieee80211_hw *hw)
        rtl_set_bbreg(hw, RCCK0_FALSEALARMREPORT, BIT(15)|BIT(14), 2);
 
        RT_TRACE(rtlpriv, COMP_DIG, DBG_TRACE,
-                "cnt_parity_fail = %d, cnt_rate_illegal = %d, "
-                "cnt_crc8_fail = %d, cnt_mcs_fail = %d\n",
-                alm_cnt->cnt_parity_fail,
-                alm_cnt->cnt_rate_illegal,
-                alm_cnt->cnt_crc8_fail, alm_cnt->cnt_mcs_fail);
+                "cnt_parity_fail = %d, cnt_rate_illegal = %d, cnt_crc8_fail = %d, cnt_mcs_fail = %d\n",
+                falsealm_cnt->cnt_parity_fail,
+                falsealm_cnt->cnt_rate_illegal,
+                falsealm_cnt->cnt_crc8_fail, falsealm_cnt->cnt_mcs_fail);
 
        RT_TRACE(rtlpriv, COMP_DIG, DBG_TRACE,
                 "cnt_ofdm_fail = %x, cnt_cck_fail = %x, cnt_all = %x\n",
-                alm_cnt->cnt_ofdm_fail,
-                alm_cnt->cnt_cck_fail, alm_cnt->cnt_all);
+                falsealm_cnt->cnt_ofdm_fail,
+                falsealm_cnt->cnt_cck_fail, falsealm_cnt->cnt_all);
 }
 
 static void rtl88e_dm_cck_packet_detection_thresh(struct ieee80211_hw *hw)
@@ -453,7 +486,7 @@ static void rtl88e_dm_cck_packet_detection_thresh(struct ieee80211_hw *hw)
        struct dig_t *dm_dig = &rtlpriv->dm_digtable;
        u8 cur_cck_cca_thresh;
 
-       if (dm_dig->cursta_cstate == DIG_STA_CONNECT) {
+       if (dm_dig->cur_sta_cstate == DIG_STA_CONNECT) {
                dm_dig->rssi_val_min = rtl88e_dm_initial_gain_min_pwdb(hw);
                if (dm_dig->rssi_val_min > 25) {
                        cur_cck_cca_thresh = 0xcd;
@@ -486,10 +519,10 @@ static void rtl88e_dm_cck_packet_detection_thresh(struct ieee80211_hw *hw)
 static void rtl88e_dm_dig(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct dig_t *dm_dig = &rtlpriv->dm_digtable;
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
-       u8 dig_min, dig_maxofmin;
+       struct dig_t *dm_dig = &rtlpriv->dm_digtable;
+       u8 dig_dynamic_min, dig_maxofmin;
        bool bfirstconnect;
        u8 dm_dig_max, dm_dig_min;
        u8 current_igi = dm_dig->cur_igvalue;
@@ -502,19 +535,19 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw)
                return;
 
        if (mac->link_state >= MAC80211_LINKED)
-               dm_dig->cursta_cstate = DIG_STA_CONNECT;
+               dm_dig->cur_sta_cstate = DIG_STA_CONNECT;
        else
-               dm_dig->cursta_cstate = DIG_STA_DISCONNECT;
+               dm_dig->cur_sta_cstate = DIG_STA_DISCONNECT;
        if (rtlpriv->mac80211.opmode == NL80211_IFTYPE_AP ||
            rtlpriv->mac80211.opmode == NL80211_IFTYPE_ADHOC)
-               dm_dig->cursta_cstate = DIG_STA_DISCONNECT;
+               dm_dig->cur_sta_cstate = DIG_STA_DISCONNECT;
 
        dm_dig_max = DM_DIG_MAX;
        dm_dig_min = DM_DIG_MIN;
        dig_maxofmin = DM_DIG_MAX_AP;
-       dig_min = dm_dig->dig_min_0;
+       dig_dynamic_min = dm_dig->dig_min_0;
        bfirstconnect = ((mac->link_state >= MAC80211_LINKED) ? true : false) &&
-                        (dm_dig->media_connect_0 == false);
+                        !dm_dig->media_connect_0;
 
        dm_dig->rssi_val_min =
                rtl88e_dm_initial_gain_min_pwdb(hw);
@@ -528,18 +561,18 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw)
                        dm_dig->rx_gain_max = dm_dig->rssi_val_min + 20;
 
                if (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) {
-                       dig_min  = dm_dig->antdiv_rssi_max;
+                       dig_dynamic_min  = dm_dig->antdiv_rssi_max;
                } else {
                        if (dm_dig->rssi_val_min < dm_dig_min)
-                               dig_min = dm_dig_min;
+                               dig_dynamic_min = dm_dig_min;
                        else if (dm_dig->rssi_val_min < dig_maxofmin)
-                               dig_min = dig_maxofmin;
+                               dig_dynamic_min = dig_maxofmin;
                        else
-                               dig_min = dm_dig->rssi_val_min;
+                               dig_dynamic_min = dm_dig->rssi_val_min;
                }
        } else {
                dm_dig->rx_gain_max = dm_dig_max;
-               dig_min = dm_dig_min;
+               dig_dynamic_min = dm_dig_min;
                RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD, "no link\n");
        }
 
@@ -551,10 +584,13 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw)
                }
 
                if (dm_dig->large_fa_hit >= 3) {
-                       if ((dm_dig->forbidden_igi + 1) > dm_dig->rx_gain_max)
-                               dm_dig->rx_gain_min = dm_dig->rx_gain_max;
+                       if ((dm_dig->forbidden_igi + 1) >
+                               dm_dig->rx_gain_max)
+                               dm_dig->rx_gain_min =
+                                       dm_dig->rx_gain_max;
                        else
-                               dm_dig->rx_gain_min = dm_dig->forbidden_igi + 1;
+                               dm_dig->rx_gain_min =
+                                       dm_dig->forbidden_igi + 1;
                        dm_dig->recover_cnt = 3600;
                }
        } else {
@@ -562,13 +598,14 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw)
                        dm_dig->recover_cnt--;
                } else {
                        if (dm_dig->large_fa_hit == 0) {
-                               if ((dm_dig->forbidden_igi - 1) < dig_min) {
-                                       dm_dig->forbidden_igi = dig_min;
-                                       dm_dig->rx_gain_min = dig_min;
+                               if ((dm_dig->forbidden_igi - 1) <
+                                   dig_dynamic_min) {
+                                       dm_dig->forbidden_igi = dig_dynamic_min;
+                                       dm_dig->rx_gain_min = dig_dynamic_min;
                                } else {
                                        dm_dig->forbidden_igi--;
                                        dm_dig->rx_gain_min =
-                                                dm_dig->forbidden_igi + 1;
+                                               dm_dig->forbidden_igi + 1;
                                }
                        } else if (dm_dig->large_fa_hit == 3) {
                                dm_dig->large_fa_hit = 0;
@@ -576,7 +613,7 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw)
                }
        }
 
-       if (dm_dig->cursta_cstate == DIG_STA_CONNECT) {
+       if (dm_dig->cur_sta_cstate == DIG_STA_CONNECT) {
                if (bfirstconnect) {
                        current_igi = dm_dig->rssi_val_min;
                } else {
@@ -606,9 +643,9 @@ static void rtl88e_dm_dig(struct ieee80211_hw *hw)
 
        dm_dig->cur_igvalue = current_igi;
        rtl88e_dm_write_dig(hw);
-       dm_dig->media_connect_0 = ((mac->link_state >= MAC80211_LINKED) ?
-                                   true : false);
-       dm_dig->dig_min_0 = dig_min;
+       dm_dig->media_connect_0 =
+               ((mac->link_state >= MAC80211_LINKED) ? true : false);
+       dm_dig->dig_min_0 = dig_dynamic_min;
 
        rtl88e_dm_cck_packet_detection_thresh(hw);
 }
@@ -626,7 +663,7 @@ static void rtl88e_dm_init_dynamic_txpower(struct ieee80211_hw *hw)
 static void rtl92c_dm_dynamic_txpower(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct rtl_phy *rtlphy = &(rtlpriv->phy);
+       struct rtl_phy *rtlphy = &rtlpriv->phy;
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        long undec_sm_pwdb;
 
@@ -641,7 +678,7 @@ static void rtl92c_dm_dynamic_txpower(struct ieee80211_hw *hw)
        if ((mac->link_state < MAC80211_LINKED) &&
            (rtlpriv->dm.entry_min_undec_sm_pwdb == 0)) {
                RT_TRACE(rtlpriv, COMP_POWER, DBG_TRACE,
-                        "Not connected\n");
+                        "Not connected to any\n");
 
                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_NORMAL;
 
@@ -664,10 +701,12 @@ static void rtl92c_dm_dynamic_txpower(struct ieee80211_hw *hw)
                                  undec_sm_pwdb);
                }
        } else {
-               undec_sm_pwdb = rtlpriv->dm.entry_min_undec_sm_pwdb;
+               undec_sm_pwdb =
+                   rtlpriv->dm.entry_min_undec_sm_pwdb;
 
                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
-                        "AP Ext Port PWDB = 0x%lx\n", undec_sm_pwdb);
+                        "AP Ext Port PWDB = 0x%lx\n",
+                         undec_sm_pwdb);
        }
 
        if (undec_sm_pwdb >= TX_POWER_NEAR_FIELD_THRESH_LVL2) {
@@ -676,17 +715,20 @@ static void rtl92c_dm_dynamic_txpower(struct ieee80211_hw *hw)
                         "TXHIGHPWRLEVEL_LEVEL1 (TxPwr = 0x0)\n");
        } else if ((undec_sm_pwdb <
                    (TX_POWER_NEAR_FIELD_THRESH_LVL2 - 3)) &&
-                  (undec_sm_pwdb >= TX_POWER_NEAR_FIELD_THRESH_LVL1)) {
+                  (undec_sm_pwdb >=
+                   TX_POWER_NEAR_FIELD_THRESH_LVL1)) {
                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_LEVEL1;
                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
                         "TXHIGHPWRLEVEL_LEVEL1 (TxPwr = 0x10)\n");
-       } else if (undec_sm_pwdb < (TX_POWER_NEAR_FIELD_THRESH_LVL1 - 5)) {
+       } else if (undec_sm_pwdb <
+                  (TX_POWER_NEAR_FIELD_THRESH_LVL1 - 5)) {
                rtlpriv->dm.dynamic_txhighpower_lvl = TXHIGHPWRLEVEL_NORMAL;
                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
                         "TXHIGHPWRLEVEL_NORMAL\n");
        }
 
-       if ((rtlpriv->dm.dynamic_txhighpower_lvl != rtlpriv->dm.last_dtp_lvl)) {
+       if ((rtlpriv->dm.dynamic_txhighpower_lvl !=
+               rtlpriv->dm.last_dtp_lvl)) {
                RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD,
                         "PHY_SetTxPowerLevel8192S() Channel = %d\n",
                          rtlphy->current_channel);
@@ -702,10 +744,9 @@ void rtl88e_dm_write_dig(struct ieee80211_hw *hw)
        struct dig_t *dm_dig = &rtlpriv->dm_digtable;
 
        RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
-                "cur_igvalue = 0x%x, "
-                 "pre_igvalue = 0x%x, back_val = %d\n",
-                 dm_dig->cur_igvalue, dm_dig->pre_igvalue,
-                 dm_dig->back_val);
+                "cur_igvalue = 0x%x, pre_igvalue = 0x%x, backoff_val = %d\n",
+                dm_dig->cur_igvalue, dm_dig->pre_igvalue,
+                dm_dig->back_val);
 
        if (dm_dig->cur_igvalue > 0x3f)
                dm_dig->cur_igvalue = 0x3f;
@@ -722,17 +763,19 @@ static void rtl88e_dm_pwdb_monitor(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        struct rtl_sta_info *drv_priv;
-       static u64 last_txok;
-       static u64 last_rx;
+       static u64 last_record_txok_cnt;
+       static u64 last_record_rxok_cnt;
        long tmp_entry_max_pwdb = 0, tmp_entry_min_pwdb = 0xff;
 
        if (rtlhal->oem_id == RT_CID_819X_HP) {
                u64 cur_txok_cnt = 0;
                u64 cur_rxok_cnt = 0;
-               cur_txok_cnt = rtlpriv->stats.txbytesunicast - last_txok;
-               cur_rxok_cnt = rtlpriv->stats.rxbytesunicast - last_rx;
-               last_txok = cur_txok_cnt;
-               last_rx = cur_rxok_cnt;
+               cur_txok_cnt = rtlpriv->stats.txbytesunicast -
+                       last_record_txok_cnt;
+               cur_rxok_cnt = rtlpriv->stats.rxbytesunicast -
+                       last_record_rxok_cnt;
+               last_record_txok_cnt = cur_txok_cnt;
+               last_record_rxok_cnt = cur_rxok_cnt;
 
                if (cur_rxok_cnt > (cur_txok_cnt * 6))
                        rtl_write_dword(rtlpriv, REG_ARFR0, 0x8f015);
@@ -743,9 +786,11 @@ static void rtl88e_dm_pwdb_monitor(struct ieee80211_hw *hw)
        /* AP & ADHOC & MESH */
        spin_lock_bh(&rtlpriv->locks.entry_list_lock);
        list_for_each_entry(drv_priv, &rtlpriv->entry_list, list) {
-               if (drv_priv->rssi_stat.undec_sm_pwdb < tmp_entry_min_pwdb)
+               if (drv_priv->rssi_stat.undec_sm_pwdb <
+                       tmp_entry_min_pwdb)
                        tmp_entry_min_pwdb = drv_priv->rssi_stat.undec_sm_pwdb;
-               if (drv_priv->rssi_stat.undec_sm_pwdb > tmp_entry_max_pwdb)
+               if (drv_priv->rssi_stat.undec_sm_pwdb >
+                       tmp_entry_max_pwdb)
                        tmp_entry_max_pwdb = drv_priv->rssi_stat.undec_sm_pwdb;
        }
        spin_unlock_bh(&rtlpriv->locks.entry_list_lock);
@@ -762,13 +807,19 @@ static void rtl88e_dm_pwdb_monitor(struct ieee80211_hw *hw)
        if (tmp_entry_min_pwdb != 0xff) {
                rtlpriv->dm.entry_min_undec_sm_pwdb = tmp_entry_min_pwdb;
                RTPRINT(rtlpriv, FDM, DM_PWDB, "EntryMinPWDB = 0x%lx(%ld)\n",
-                       tmp_entry_min_pwdb, tmp_entry_min_pwdb);
+                                       tmp_entry_min_pwdb, tmp_entry_min_pwdb);
        } else {
                rtlpriv->dm.entry_min_undec_sm_pwdb = 0;
        }
        /* Indicate Rx signal strength to FW. */
-       if (!rtlpriv->dm.useramask)
+       if (rtlpriv->dm.useramask) {
+               u8 h2c_parameter[3] = { 0 };
+
+               h2c_parameter[2] = (u8)(rtlpriv->dm.undec_sm_pwdb & 0xFF);
+               h2c_parameter[0] = 0x20;
+       } else {
                rtl_write_byte(rtlpriv, 0x4fe, rtlpriv->dm.undec_sm_pwdb);
+       }
 }
 
 void rtl88e_dm_init_edca_turbo(struct ieee80211_hw *hw)
@@ -783,7 +834,6 @@ void rtl88e_dm_init_edca_turbo(struct ieee80211_hw *hw)
 static void rtl88e_dm_check_edca_turbo(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct rtl_pci_priv *rtlpcipriv = rtl_pcipriv(hw);
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        static u64 last_txok_cnt;
        static u64 last_rxok_cnt;
@@ -793,40 +843,33 @@ static void rtl88e_dm_check_edca_turbo(struct ieee80211_hw *hw)
        u64 cur_rxok_cnt = 0;
        u32 edca_be_ul = 0x5ea42b;
        u32 edca_be_dl = 0x5ea42b;
-       bool change_edca = false;
+       bool bt_change_edca = false;
 
-       if ((last_bt_edca_ul != rtlpcipriv->bt_coexist.bt_edca_ul) ||
-           (last_bt_edca_dl != rtlpcipriv->bt_coexist.bt_edca_dl)) {
+       if ((last_bt_edca_ul != rtlpriv->btcoexist.bt_edca_ul) ||
+           (last_bt_edca_dl != rtlpriv->btcoexist.bt_edca_dl)) {
                rtlpriv->dm.current_turbo_edca = false;
-               last_bt_edca_ul = rtlpcipriv->bt_coexist.bt_edca_ul;
-               last_bt_edca_dl = rtlpcipriv->bt_coexist.bt_edca_dl;
+               last_bt_edca_ul = rtlpriv->btcoexist.bt_edca_ul;
+               last_bt_edca_dl = rtlpriv->btcoexist.bt_edca_dl;
        }
 
-       if (rtlpcipriv->bt_coexist.bt_edca_ul != 0) {
-               edca_be_ul = rtlpcipriv->bt_coexist.bt_edca_ul;
-               change_edca = true;
+       if (rtlpriv->btcoexist.bt_edca_ul != 0) {
+               edca_be_ul = rtlpriv->btcoexist.bt_edca_ul;
+               bt_change_edca = true;
        }
 
-       if (rtlpcipriv->bt_coexist.bt_edca_dl != 0) {
-               edca_be_ul = rtlpcipriv->bt_coexist.bt_edca_dl;
-               change_edca = true;
+       if (rtlpriv->btcoexist.bt_edca_dl != 0) {
+               edca_be_ul = rtlpriv->btcoexist.bt_edca_dl;
+               bt_change_edca = true;
        }
 
        if (mac->link_state != MAC80211_LINKED) {
                rtlpriv->dm.current_turbo_edca = false;
                return;
        }
+       if ((bt_change_edca) ||
+           ((!rtlpriv->dm.is_any_nonbepkts) &&
+            (!rtlpriv->dm.disable_framebursting))) {
 
-       if ((!mac->ht_enable) && (!rtlpcipriv->bt_coexist.bt_coexistence)) {
-               if (!(edca_be_ul & 0xffff0000))
-                       edca_be_ul |= 0x005e0000;
-
-               if (!(edca_be_dl & 0xffff0000))
-                       edca_be_dl |= 0x005e0000;
-       }
-
-       if ((change_edca) || ((!rtlpriv->dm.is_any_nonbepkts) &&
-                             (!rtlpriv->dm.disable_framebursting))) {
                cur_txok_cnt = rtlpriv->stats.txbytesunicast - last_txok_cnt;
                cur_rxok_cnt = rtlpriv->stats.rxbytesunicast - last_rxok_cnt;
 
@@ -851,7 +894,9 @@ static void rtl88e_dm_check_edca_turbo(struct ieee80211_hw *hw)
        } else {
                if (rtlpriv->dm.current_turbo_edca) {
                        u8 tmp = AC0_BE;
-                       rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_AC_PARAM,
+
+                       rtlpriv->cfg->ops->set_hw_reg(hw,
+                                                     HW_VAR_AC_PARAM,
                                                      &tmp);
                        rtlpriv->dm.current_turbo_edca = false;
                }
@@ -862,29 +907,29 @@ static void rtl88e_dm_check_edca_turbo(struct ieee80211_hw *hw)
        last_rxok_cnt = rtlpriv->stats.rxbytesunicast;
 }
 
-static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
-                                                            *hw)
+static void dm_txpower_track_cb_therm(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct rtl_dm   *rtldm = rtl_dm(rtl_priv(hw));
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
-       u8 thermalvalue = 0, delta, delta_lck, delta_iqk, off;
-       u8 th_avg_cnt = 0;
+       u8 thermalvalue = 0, delta, delta_lck, delta_iqk, offset;
+       u8 thermalvalue_avg_count = 0;
        u32 thermalvalue_avg = 0;
        long  ele_d, temp_cck;
-       char ofdm_index[2], cck_index = 0, ofdm_old[2] = {0, 0}, cck_old = 0;
+       char ofdm_index[2], cck_index = 0,
+               ofdm_index_old[2] = {0, 0}, cck_index_old = 0;
        int i = 0;
-       bool is2t = false;
+       /*bool is2t = false;*/
 
-       u8 ofdm_min_index = 6, rf = (is2t) ? 2 : 1;
-       u8 index_for_channel;
-       enum _dec_inc {dec, power_inc};
+       u8 ofdm_min_index = 6, rf = 1;
+       /*u8 index_for_channel;*/
+       enum _power_dec_inc {power_dec, power_inc};
 
-       /* 0.1 the following TWO tables decide the final index of
-        * OFDM/CCK swing table
+       /*0.1 the following TWO tables decide the
+        *final index of OFDM/CCK swing table
         */
-       char del_tbl_idx[2][15] = {
+       char delta_swing_table_idx[2][15]  = {
                {0, 0, 2, 3, 4, 4, 5, 6, 7, 7, 8, 9, 10, 10, 11},
                {0, 0, -1, -2, -3, -4, -4, -4, -4, -5, -7, -8, -9, -9, -10}
        };
@@ -896,9 +941,10 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
        /*Initilization (7 steps in total) */
        rtlpriv->dm.txpower_trackinginit = true;
        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
-                "rtl88e_dm_txpower_tracking_callback_thermalmeter\n");
+                "dm_txpower_track_cb_therm\n");
 
-       thermalvalue = (u8) rtl_get_rfreg(hw, RF90_PATH_A, RF_T_METER, 0xfc00);
+       thermalvalue = (u8)rtl_get_rfreg(hw, RF90_PATH_A, RF_T_METER,
+                                        0xfc00);
        if (!thermalvalue)
                return;
        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
@@ -907,55 +953,44 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                 rtlefuse->eeprom_thermalmeter);
 
        /*1. Query OFDM Default Setting: Path A*/
-       ele_d = rtl_get_bbreg(hw, ROFDM0_XATXIQIMBAL, MASKDWORD) & MASKOFDM_D;
+       ele_d = rtl_get_bbreg(hw, ROFDM0_XATXIQIMBALANCE, MASKDWORD) &
+                             MASKOFDM_D;
        for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
                if (ele_d == (ofdmswing_table[i] & MASKOFDM_D)) {
-                       ofdm_old[0] = (u8) i;
-                       rtldm->swing_idx_ofdm_base[0] = (u8)i;
+                       ofdm_index_old[0] = (u8)i;
+                       rtldm->swing_idx_ofdm_base[RF90_PATH_A] = (u8)i;
                        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
                                 "Initial pathA ele_d reg0x%x = 0x%lx, ofdm_index = 0x%x\n",
-                                ROFDM0_XATXIQIMBAL,
-                                ele_d, ofdm_old[0]);
+                                ROFDM0_XATXIQIMBALANCE,
+                                ele_d, ofdm_index_old[0]);
                        break;
                }
        }
 
-       if (is2t) {
-               ele_d = rtl_get_bbreg(hw, ROFDM0_XBTXIQIMBAL,
-                                     MASKDWORD) & MASKOFDM_D;
-               for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
-                       if (ele_d == (ofdmswing_table[i] & MASKOFDM_D)) {
-                               ofdm_old[1] = (u8)i;
-
-                               RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
-                                        DBG_LOUD,
-                                        "Initial pathB ele_d reg0x%x = 0x%lx, ofdm_index = 0x%x\n",
-                                        ROFDM0_XBTXIQIMBAL, ele_d,
-                                        ofdm_old[1]);
-                               break;
-                       }
-               }
-       }
        /*2.Query CCK default setting From 0xa24*/
        temp_cck = rtl_get_bbreg(hw, RCCK0_TXFILTER2, MASKDWORD) & MASKCCK;
        for (i = 0; i < CCK_TABLE_LENGTH; i++) {
                if (rtlpriv->dm.cck_inch14) {
                        if (memcmp(&temp_cck, &cck_tbl_ch14[i][2], 4) == 0) {
-                               cck_old = (u8)i;
+                               cck_index_old = (u8)i;
                                rtldm->swing_idx_cck_base = (u8)i;
-                               RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
+                               RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
+                                        DBG_LOUD,
                                         "Initial reg0x%x = 0x%lx, cck_index = 0x%x, ch 14 %d\n",
-                                        RCCK0_TXFILTER2, temp_cck, cck_old,
+                                        RCCK0_TXFILTER2, temp_cck,
+                                        cck_index_old,
                                         rtlpriv->dm.cck_inch14);
                                break;
                        }
                } else {
                        if (memcmp(&temp_cck, &cck_tbl_ch1_13[i][2], 4) == 0) {
-                               cck_old = (u8)i;
+                               cck_index_old = (u8)i;
                                rtldm->swing_idx_cck_base = (u8)i;
-                               RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
+                               RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
+                                        DBG_LOUD,
                                         "Initial reg0x%x = 0x%lx, cck_index = 0x%x, ch14 %d\n",
-                                        RCCK0_TXFILTER2, temp_cck, cck_old,
+                                        RCCK0_TXFILTER2, temp_cck,
+                                        cck_index_old,
                                         rtlpriv->dm.cck_inch14);
                                break;
                        }
@@ -968,8 +1003,8 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                rtlpriv->dm.thermalvalue_lck = thermalvalue;
                rtlpriv->dm.thermalvalue_iqk = thermalvalue;
                for (i = 0; i < rf; i++)
-                       rtlpriv->dm.ofdm_index[i] = ofdm_old[i];
-               rtlpriv->dm.cck_index = cck_old;
+                       rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
+               rtlpriv->dm.cck_index = cck_index_old;
        }
 
        /*4 Calculate average thermal meter*/
@@ -981,12 +1016,12 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
        for (i = 0; i < AVG_THERMAL_NUM_88E; i++) {
                if (rtldm->thermalvalue_avg[i]) {
                        thermalvalue_avg += rtldm->thermalvalue_avg[i];
-                       th_avg_cnt++;
+                       thermalvalue_avg_count++;
                }
        }
 
-       if (th_avg_cnt)
-               thermalvalue = (u8)(thermalvalue_avg / th_avg_cnt);
+       if (thermalvalue_avg_count)
+               thermalvalue = (u8)(thermalvalue_avg / thermalvalue_avg_count);
 
        /* 5 Calculate delta, delta_LCK, delta_IQK.*/
        if (rtlhal->reloadtxpowerindex) {
@@ -997,24 +1032,22 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                rtlpriv->dm.done_txpower = false;
        } else if (rtlpriv->dm.done_txpower) {
                delta = (thermalvalue > rtlpriv->dm.thermalvalue) ?
-                       (thermalvalue - rtlpriv->dm.thermalvalue) :
-                       (rtlpriv->dm.thermalvalue - thermalvalue);
+                   (thermalvalue - rtlpriv->dm.thermalvalue) :
+                   (rtlpriv->dm.thermalvalue - thermalvalue);
        } else {
                delta = (thermalvalue > rtlefuse->eeprom_thermalmeter) ?
-                       (thermalvalue - rtlefuse->eeprom_thermalmeter) :
-                       (rtlefuse->eeprom_thermalmeter - thermalvalue);
+                   (thermalvalue - rtlefuse->eeprom_thermalmeter) :
+                   (rtlefuse->eeprom_thermalmeter - thermalvalue);
        }
        delta_lck = (thermalvalue > rtlpriv->dm.thermalvalue_lck) ?
-                   (thermalvalue - rtlpriv->dm.thermalvalue_lck) :
-                   (rtlpriv->dm.thermalvalue_lck - thermalvalue);
+           (thermalvalue - rtlpriv->dm.thermalvalue_lck) :
+           (rtlpriv->dm.thermalvalue_lck - thermalvalue);
        delta_iqk = (thermalvalue > rtlpriv->dm.thermalvalue_iqk) ?
-                   (thermalvalue - rtlpriv->dm.thermalvalue_iqk) :
-                   (rtlpriv->dm.thermalvalue_iqk - thermalvalue);
+           (thermalvalue - rtlpriv->dm.thermalvalue_iqk) :
+           (rtlpriv->dm.thermalvalue_iqk - thermalvalue);
 
        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
-                "Readback Thermal Meter = 0x%x pre thermal meter 0x%x "
-                "eeprom_thermalmeter 0x%x delta 0x%x "
-                "delta_lck 0x%x delta_iqk 0x%x\n",
+                "Readback Thermal Meter = 0x%x pre thermal meter 0x%x eeprom_thermalmeter 0x%x delta 0x%x delta_lck 0x%x delta_iqk 0x%x\n",
                 thermalvalue, rtlpriv->dm.thermalvalue,
                 rtlefuse->eeprom_thermalmeter, delta, delta_lck,
                 delta_iqk);
@@ -1024,28 +1057,35 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                rtl88e_phy_lc_calibrate(hw);
        }
 
-       /* 7 If necessary, move the index of swing table to adjust Tx power. */
+       /* 7 If necessary, move the index of
+        * swing table to adjust Tx power.
+        */
        if (delta > 0 && rtlpriv->dm.txpower_track_control) {
                delta = (thermalvalue > rtlefuse->eeprom_thermalmeter) ?
-                       (thermalvalue - rtlefuse->eeprom_thermalmeter) :
-                       (rtlefuse->eeprom_thermalmeter - thermalvalue);
+                   (thermalvalue - rtlefuse->eeprom_thermalmeter) :
+                   (rtlefuse->eeprom_thermalmeter - thermalvalue);
 
                /* 7.1 Get the final CCK_index and OFDM_index for each
                 * swing table.
                 */
                if (thermalvalue > rtlefuse->eeprom_thermalmeter) {
-                       CAL_SWING_OFF(off, power_inc, IDX_MAP, delta);
+                       CAL_SWING_OFF(offset, power_inc, INDEX_MAPPING_NUM,
+                                     delta);
                        for (i = 0; i < rf; i++)
-                               ofdm_index[i] = rtldm->ofdm_index[i] +
-                                               del_tbl_idx[power_inc][off];
+                               ofdm_index[i] =
+                                 rtldm->ofdm_index[i] +
+                                 delta_swing_table_idx[power_inc][offset];
                        cck_index = rtldm->cck_index +
-                                   del_tbl_idx[power_inc][off];
+                               delta_swing_table_idx[power_inc][offset];
                } else {
-                       CAL_SWING_OFF(off, dec, IDX_MAP, delta);
+                       CAL_SWING_OFF(offset, power_dec, INDEX_MAPPING_NUM,
+                                     delta);
                        for (i = 0; i < rf; i++)
-                               ofdm_index[i] = rtldm->ofdm_index[i] +
-                                               del_tbl_idx[dec][off];
-                       cck_index = rtldm->cck_index + del_tbl_idx[dec][off];
+                               ofdm_index[i] =
+                                 rtldm->ofdm_index[i] +
+                                 delta_swing_table_idx[power_dec][offset];
+                       cck_index = rtldm->cck_index +
+                               delta_swing_table_idx[power_dec][offset];
                }
 
                /* 7.2 Handle boundary conditions of index.*/
@@ -1056,8 +1096,8 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                                ofdm_index[i] = ofdm_min_index;
                }
 
-               if (cck_index > CCK_TABLE_SIZE - 1)
-                       cck_index = CCK_TABLE_SIZE - 1;
+               if (cck_index > CCK_TABLE_SIZE-1)
+                       cck_index = CCK_TABLE_SIZE-1;
                else if (cck_index < 0)
                        cck_index = 0;
 
@@ -1065,10 +1105,7 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                if (rtlpriv->dm.txpower_track_control) {
                        rtldm->done_txpower = true;
                        rtldm->swing_idx_ofdm[RF90_PATH_A] =
-                                (u8)ofdm_index[RF90_PATH_A];
-                       if (is2t)
-                               rtldm->swing_idx_ofdm[RF90_PATH_B] =
-                                        (u8)ofdm_index[RF90_PATH_B];
+                               (u8)ofdm_index[RF90_PATH_A];
                        rtldm->swing_idx_cck = cck_index;
                        if (rtldm->swing_idx_ofdm_cur !=
                            rtldm->swing_idx_ofdm[0]) {
@@ -1082,12 +1119,7 @@ static void rtl88e_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
                                rtldm->swing_flag_cck = true;
                        }
 
-                       rtl88e_chk_tx_track(hw, TXAGC, 0, 0);
-
-                       if (is2t)
-                               rtl88e_chk_tx_track(hw, BBSWING,
-                                                   RF90_PATH_B,
-                                                   index_for_channel);
+                       dm_tx_pwr_track_set_pwr(hw, TXAGC, 0, 0);
                }
        }
 
@@ -1115,7 +1147,7 @@ static void rtl88e_dm_init_txpower_tracking(struct ieee80211_hw *hw)
        rtlpriv->dm.swing_idx_ofdm_cur = 12;
        rtlpriv->dm.swing_flag_ofdm = false;
        RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
-                "  rtlpriv->dm.txpower_tracking = %d\n",
+                "rtlpriv->dm.txpower_tracking = %d\n",
                 rtlpriv->dm.txpower_tracking);
 }
 
@@ -1137,7 +1169,7 @@ void rtl88e_dm_check_txpower_tracking(struct ieee80211_hw *hw)
        } else {
                RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
                         "Schedule TxPowerTracking !!\n");
-               rtl88e_dm_txpower_tracking_callback_thermalmeter(hw);
+                               dm_txpower_track_cb_therm(hw);
                tm_trigger = 0;
        }
 }
@@ -1145,7 +1177,7 @@ void rtl88e_dm_check_txpower_tracking(struct ieee80211_hw *hw)
 void rtl88e_dm_init_rate_adaptive_mask(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct rate_adaptive *p_ra = &(rtlpriv->ra);
+       struct rate_adaptive *p_ra = &rtlpriv->ra;
 
        p_ra->ratr_state = DM_RATR_STA_INIT;
        p_ra->pre_ratr_state = DM_RATR_STA_INIT;
@@ -1161,9 +1193,9 @@ static void rtl88e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
-       struct rate_adaptive *p_ra = &(rtlpriv->ra);
+       struct rate_adaptive *p_ra = &rtlpriv->ra;
+       u32 low_rssithresh_for_ra, high_rssithresh_for_ra;
        struct ieee80211_sta *sta = NULL;
-       u32 low_rssi, hi_rssi;
 
        if (is_hal_stop(rtlhal)) {
                RT_TRACE(rtlpriv, COMP_RATE, DBG_LOUD,
@@ -1181,26 +1213,28 @@ static void rtl88e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
            mac->opmode == NL80211_IFTYPE_STATION) {
                switch (p_ra->pre_ratr_state) {
                case DM_RATR_STA_HIGH:
-                       hi_rssi = 50;
-                       low_rssi = 20;
+                       high_rssithresh_for_ra = 50;
+                       low_rssithresh_for_ra = 20;
                        break;
                case DM_RATR_STA_MIDDLE:
-                       hi_rssi = 55;
-                       low_rssi = 20;
+                       high_rssithresh_for_ra = 55;
+                       low_rssithresh_for_ra = 20;
                        break;
                case DM_RATR_STA_LOW:
-                       hi_rssi = 50;
-                       low_rssi = 25;
+                       high_rssithresh_for_ra = 50;
+                       low_rssithresh_for_ra = 25;
                        break;
                default:
-                       hi_rssi = 50;
-                       low_rssi = 20;
+                       high_rssithresh_for_ra = 50;
+                       low_rssithresh_for_ra = 20;
                        break;
                }
 
-               if (rtlpriv->dm.undec_sm_pwdb > (long)hi_rssi)
+               if (rtlpriv->dm.undec_sm_pwdb >
+                   (long)high_rssithresh_for_ra)
                        p_ra->ratr_state = DM_RATR_STA_HIGH;
-               else if (rtlpriv->dm.undec_sm_pwdb > (long)low_rssi)
+               else if (rtlpriv->dm.undec_sm_pwdb >
+                        (long)low_rssithresh_for_ra)
                        p_ra->ratr_state = DM_RATR_STA_MIDDLE;
                else
                        p_ra->ratr_state = DM_RATR_STA_LOW;
@@ -1208,7 +1242,7 @@ static void rtl88e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
                if (p_ra->pre_ratr_state != p_ra->ratr_state) {
                        RT_TRACE(rtlpriv, COMP_RATE, DBG_LOUD,
                                 "RSSI = %ld\n",
-                                rtlpriv->dm.undec_sm_pwdb);
+                                 rtlpriv->dm.undec_sm_pwdb);
                        RT_TRACE(rtlpriv, COMP_RATE, DBG_LOUD,
                                 "RSSI_LEVEL = %d\n", p_ra->ratr_state);
                        RT_TRACE(rtlpriv, COMP_RATE, DBG_LOUD,
@@ -1219,7 +1253,7 @@ static void rtl88e_dm_refresh_rate_adaptive_mask(struct ieee80211_hw *hw)
                        sta = rtl_find_sta(hw, mac->bssid);
                        if (sta)
                                rtlpriv->cfg->ops->update_rate_tbl(hw, sta,
-                                                  p_ra->ratr_state);
+                                                                  p_ra->ratr_state);
                        rcu_read_unlock();
 
                        p_ra->pre_ratr_state = p_ra->ratr_state;
@@ -1239,56 +1273,62 @@ static void rtl92c_dm_init_dynamic_bb_powersaving(struct ieee80211_hw *hw)
        dm_pstable->rssi_val_min = 0;
 }
 
-static void rtl88e_dm_update_rx_idle_ant(struct ieee80211_hw *hw, u8 ant)
+static void rtl88e_dm_update_rx_idle_ant(struct ieee80211_hw *hw,
+                                        u8 ant)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
-       u32 def_ant, opt_ant;
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
+       u32 default_ant, optional_ant;
 
-       if (fat_tbl->rx_idle_ant != ant) {
+       if (pfat_table->rx_idle_ant != ant) {
                RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
                         "need to update rx idle ant\n");
                if (ant == MAIN_ANT) {
-                       def_ant = (fat_tbl->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
-                                  MAIN_ANT_CG_TRX : MAIN_ANT_CGCS_RX;
-                       opt_ant = (fat_tbl->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
-                                  AUX_ANT_CG_TRX : AUX_ANT_CGCS_RX;
+                       default_ant =
+                         (pfat_table->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
+                         MAIN_ANT_CG_TRX : MAIN_ANT_CGCS_RX;
+                       optional_ant =
+                         (pfat_table->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
+                         AUX_ANT_CG_TRX : AUX_ANT_CGCS_RX;
                } else {
-                       def_ant = (fat_tbl->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
-                                  AUX_ANT_CG_TRX : AUX_ANT_CGCS_RX;
-                       opt_ant = (fat_tbl->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
-                                  MAIN_ANT_CG_TRX : MAIN_ANT_CGCS_RX;
+                       default_ant =
+                          (pfat_table->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
+                          AUX_ANT_CG_TRX : AUX_ANT_CGCS_RX;
+                       optional_ant =
+                          (pfat_table->rx_idle_ant == CG_TRX_HW_ANTDIV) ?
+                          MAIN_ANT_CG_TRX : MAIN_ANT_CGCS_RX;
                }
 
                if (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) {
-                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(5) |
-                                     BIT(4) | BIT(3), def_ant);
-                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(8) |
-                                     BIT(7) | BIT(6), opt_ant);
-                       rtl_set_bbreg(hw, DM_REG_ANTSEL_CTRL_11N, BIT(14) |
-                                     BIT(13) | BIT(12), def_ant);
-                       rtl_set_bbreg(hw, DM_REG_RESP_TX_11N, BIT(6) | BIT(7),
-                                     def_ant);
+                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                                     BIT(5) | BIT(4) | BIT(3), default_ant);
+                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                                     BIT(8) | BIT(7) | BIT(6), optional_ant);
+                       rtl_set_bbreg(hw, DM_REG_ANTSEL_CTRL_11N,
+                                     BIT(14) | BIT(13) | BIT(12),
+                                     default_ant);
+                       rtl_set_bbreg(hw, DM_REG_RESP_TX_11N,
+                                     BIT(6) | BIT(7), default_ant);
                } else if (rtlefuse->antenna_div_type == CGCS_RX_HW_ANTDIV) {
-                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(5) |
-                                     BIT(4) | BIT(3), def_ant);
-                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(8) |
-                                     BIT(7) | BIT(6), opt_ant);
+                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                                     BIT(5) | BIT(4) | BIT(3), default_ant);
+                       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                                     BIT(8) | BIT(7) | BIT(6), optional_ant);
                }
        }
-       fat_tbl->rx_idle_ant = ant;
+       pfat_table->rx_idle_ant = ant;
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "RxIdleAnt %s\n",
-                ((ant == MAIN_ANT) ? ("MAIN_ANT") : ("AUX_ANT")));
+                (ant == MAIN_ANT) ? ("MAIN_ANT") : ("AUX_ANT"));
 }
 
 static void rtl88e_dm_update_tx_ant(struct ieee80211_hw *hw,
-       u8 ant, u32 mac_id)
+                                   u8 ant, u32 mac_id)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
        u8 target_ant;
 
        if (ant == MAIN_ANT)
@@ -1296,23 +1336,25 @@ static void rtl88e_dm_update_tx_ant(struct ieee80211_hw *hw,
        else
                target_ant = AUX_ANT_CG_TRX;
 
-       fat_tbl->antsel_a[mac_id] = target_ant & BIT(0);
-       fat_tbl->antsel_b[mac_id] = (target_ant & BIT(1)) >> 1;
-       fat_tbl->antsel_c[mac_id] = (target_ant & BIT(2)) >> 2;
+       pfat_table->antsel_a[mac_id] = target_ant & BIT(0);
+       pfat_table->antsel_b[mac_id] = (target_ant & BIT(1)) >> 1;
+       pfat_table->antsel_c[mac_id] = (target_ant & BIT(2)) >> 2;
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "txfrominfo target ant %s\n",
-                ((ant == MAIN_ANT) ? ("MAIN_ANT") : ("AUX_ANT")));
+               (ant == MAIN_ANT) ? ("MAIN_ANT") : ("AUX_ANT"));
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "antsel_tr_mux = 3'b%d%d%d\n",
-                fat_tbl->antsel_c[mac_id],
-                fat_tbl->antsel_b[mac_id], fat_tbl->antsel_a[mac_id]);
+               pfat_table->antsel_c[mac_id],
+               pfat_table->antsel_b[mac_id],
+               pfat_table->antsel_a[mac_id]);
 }
 
 static void rtl88e_dm_rx_hw_antena_div_init(struct ieee80211_hw *hw)
 {
        u32  value32;
+
        /*MAC Setting*/
        value32 = rtl_get_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD);
-       rtl_set_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD, value32 |
-                    (BIT(23) | BIT(25)));
+       rtl_set_bbreg(hw, DM_REG_ANTSEL_PIN_11N,
+                     MASKDWORD, value32 | (BIT(23) | BIT(25)));
        /*Pin Setting*/
        rtl_set_bbreg(hw, DM_REG_PIN_CTRL_11N, BIT(9) | BIT(8), 0);
        rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(10), 0);
@@ -1333,8 +1375,8 @@ static void rtl88e_dm_trx_hw_antenna_div_init(struct ieee80211_hw *hw)
 
        /*MAC Setting*/
        value32 = rtl_get_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD);
-       rtl_set_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD, value32 |
-                    (BIT(23) | BIT(25)));
+       rtl_set_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD,
+                     value32 | (BIT(23) | BIT(25)));
        /*Pin Setting*/
        rtl_set_bbreg(hw, DM_REG_PIN_CTRL_11N, BIT(9) | BIT(8), 0);
        rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(10), 0);
@@ -1354,28 +1396,30 @@ static void rtl88e_dm_trx_hw_antenna_div_init(struct ieee80211_hw *hw)
 static void rtl88e_dm_fast_training_init(struct ieee80211_hw *hw)
 {
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
-       u32 ant_combo = 2;
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
+       u32 ant_combination = 2;
        u32 value32, i;
 
        for (i = 0; i < 6; i++) {
-               fat_tbl->bssid[i] = 0;
-               fat_tbl->ant_sum[i] = 0;
-               fat_tbl->ant_cnt[i] = 0;
-               fat_tbl->ant_ave[i] = 0;
+               pfat_table->bssid[i] = 0;
+               pfat_table->ant_sum[i] = 0;
+               pfat_table->ant_cnt[i] = 0;
+               pfat_table->ant_ave[i] = 0;
        }
-       fat_tbl->train_idx = 0;
-       fat_tbl->fat_state = FAT_NORMAL_STATE;
+       pfat_table->train_idx = 0;
+       pfat_table->fat_state = FAT_NORMAL_STATE;
 
        /*MAC Setting*/
        value32 = rtl_get_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD);
-       rtl_set_bbreg(hw, DM_REG_ANTSEL_PIN_11N, MASKDWORD, value32 | (BIT(23) |
-                     BIT(25)));
-       value32 = rtl_get_bbreg(hw, DM_REG_ANT_TRAIN_2, MASKDWORD);
-       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_2, MASKDWORD, value32 | (BIT(16) |
-                     BIT(17)));
-       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_2, MASKLWORD, 0);
-       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_1, MASKDWORD, 0);
+       rtl_set_bbreg(hw, DM_REG_ANTSEL_PIN_11N,
+                     MASKDWORD, value32 | (BIT(23) | BIT(25)));
+       value32 = rtl_get_bbreg(hw, DM_REG_ANT_TRAIN_PARA2_11N, MASKDWORD);
+       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_PARA2_11N,
+                     MASKDWORD, value32 | (BIT(16) | BIT(17)));
+       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_PARA2_11N,
+                     MASKLWORD, 0);
+       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_PARA1_11N,
+                     MASKDWORD, 0);
 
        /*Pin Setting*/
        rtl_set_bbreg(hw, DM_REG_PIN_CTRL_11N, BIT(9) | BIT(8), 0);
@@ -1386,26 +1430,17 @@ static void rtl88e_dm_fast_training_init(struct ieee80211_hw *hw)
        /*OFDM Setting*/
        rtl_set_bbreg(hw, DM_REG_ANTDIV_PARA1_11N, MASKDWORD, 0x000000a0);
        /*antenna mapping table*/
-       if (ant_combo == 2) {
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE0, 1);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE1, 2);
-       } else if (ant_combo == 7) {
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE0, 1);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE1, 2);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE2, 2);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE3, 3);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING2_11N, MASKBYTE0, 4);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING2_11N, MASKBYTE1, 5);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING2_11N, MASKBYTE2, 6);
-               rtl_set_bbreg(hw, DM_REG_ANT_MAPPING2_11N, MASKBYTE3, 7);
-       }
+       rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE0, 1);
+       rtl_set_bbreg(hw, DM_REG_ANT_MAPPING1_11N, MASKBYTE1, 2);
 
        /*TX Setting*/
        rtl_set_bbreg(hw, DM_REG_TX_ANT_CTRL_11N, BIT(21), 1);
-       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(5) | BIT(4) | BIT(3), 0);
-       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(8) | BIT(7) | BIT(6), 1);
-       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(2) | BIT(1) | BIT(0),
-                     (ant_combo - 1));
+       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                     BIT(5) | BIT(4) | BIT(3), 0);
+       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                     BIT(8) | BIT(7) | BIT(6), 1);
+       rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N,
+                     BIT(2) | BIT(1) | BIT(0), (ant_combination - 1));
 
        rtl_set_bbreg(hw, DM_REG_IGI_A_11N, BIT(7), 1);
 }
@@ -1420,6 +1455,7 @@ static void rtl88e_dm_antenna_div_init(struct ieee80211_hw *hw)
                rtl88e_dm_trx_hw_antenna_div_init(hw);
        else if (rtlefuse->antenna_div_type == CG_TRX_SMART_ANTDIV)
                rtl88e_dm_fast_training_init(hw);
+
 }
 
 void rtl88e_dm_set_tx_ant_by_tx_info(struct ieee80211_hw *hw,
@@ -1427,38 +1463,39 @@ void rtl88e_dm_set_tx_ant_by_tx_info(struct ieee80211_hw *hw,
 {
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
 
        if ((rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) ||
-           (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV)) {
-               SET_TX_DESC_ANTSEL_A(pdesc, fat_tbl->antsel_a[mac_id]);
-               SET_TX_DESC_ANTSEL_B(pdesc, fat_tbl->antsel_b[mac_id]);
-               SET_TX_DESC_ANTSEL_C(pdesc, fat_tbl->antsel_c[mac_id]);
+           (rtlefuse->antenna_div_type == CG_TRX_SMART_ANTDIV)) {
+               SET_TX_DESC_ANTSEL_A(pdesc, pfat_table->antsel_a[mac_id]);
+               SET_TX_DESC_ANTSEL_B(pdesc, pfat_table->antsel_b[mac_id]);
+               SET_TX_DESC_ANTSEL_C(pdesc, pfat_table->antsel_c[mac_id]);
        }
 }
 
 void rtl88e_dm_ant_sel_statistics(struct ieee80211_hw *hw,
-                                 u8 antsel_tr_mux, u32 mac_id, u32 rx_pwdb_all)
+                                 u8 antsel_tr_mux, u32 mac_id,
+                                 u32 rx_pwdb_all)
 {
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
 
        if (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV) {
                if (antsel_tr_mux == MAIN_ANT_CG_TRX) {
-                       fat_tbl->main_ant_sum[mac_id] += rx_pwdb_all;
-                       fat_tbl->main_ant_cnt[mac_id]++;
+                       pfat_table->main_ant_sum[mac_id] += rx_pwdb_all;
+                       pfat_table->main_ant_cnt[mac_id]++;
                } else {
-                       fat_tbl->aux_ant_sum[mac_id] += rx_pwdb_all;
-                       fat_tbl->aux_ant_cnt[mac_id]++;
+                       pfat_table->aux_ant_sum[mac_id] += rx_pwdb_all;
+                       pfat_table->aux_ant_cnt[mac_id]++;
                }
        } else if (rtlefuse->antenna_div_type == CGCS_RX_HW_ANTDIV) {
                if (antsel_tr_mux == MAIN_ANT_CGCS_RX) {
-                       fat_tbl->main_ant_sum[mac_id] += rx_pwdb_all;
-                       fat_tbl->main_ant_cnt[mac_id]++;
+                       pfat_table->main_ant_sum[mac_id] += rx_pwdb_all;
+                       pfat_table->main_ant_cnt[mac_id]++;
                } else {
-                       fat_tbl->aux_ant_sum[mac_id] += rx_pwdb_all;
-                       fat_tbl->aux_ant_cnt[mac_id]++;
+                       pfat_table->aux_ant_sum[mac_id] += rx_pwdb_all;
+                       pfat_table->aux_ant_cnt[mac_id]++;
                }
        }
 }
@@ -1466,43 +1503,43 @@ void rtl88e_dm_ant_sel_statistics(struct ieee80211_hw *hw,
 static void rtl88e_dm_hw_ant_div(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
-       struct dig_t *dm_dig = &rtlpriv->dm_digtable;
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
        struct rtl_sta_info *drv_priv;
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
-       u32 i, min_rssi = 0xff, ant_div_max_rssi = 0, max_rssi = 0;
-       u32 local_min_rssi, local_max_rssi;
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
+       struct dig_t *dm_dig = &rtlpriv->dm_digtable;
+       u32 i, min_rssi = 0xff, ant_div_max_rssi = 0;
+       u32 max_rssi = 0, local_min_rssi, local_max_rssi;
        u32 main_rssi, aux_rssi;
        u8 rx_idle_ant = 0, target_ant = 7;
 
+       /*for sta its self*/
        i = 0;
-       main_rssi = (fat_tbl->main_ant_cnt[i] != 0) ?
-                   (fat_tbl->main_ant_sum[i] /
-                    fat_tbl->main_ant_cnt[i]) : 0;
-       aux_rssi = (fat_tbl->aux_ant_cnt[i] != 0) ?
-               (fat_tbl->aux_ant_sum[i] / fat_tbl->aux_ant_cnt[i]) : 0;
+       main_rssi = (pfat_table->main_ant_cnt[i] != 0) ?
+               (pfat_table->main_ant_sum[i] / pfat_table->main_ant_cnt[i]) : 0;
+       aux_rssi = (pfat_table->aux_ant_cnt[i] != 0) ?
+               (pfat_table->aux_ant_sum[i] / pfat_table->aux_ant_cnt[i]) : 0;
        target_ant = (main_rssi == aux_rssi) ?
-                    fat_tbl->rx_idle_ant : ((main_rssi >= aux_rssi) ?
-                    MAIN_ANT : AUX_ANT);
+               pfat_table->rx_idle_ant : ((main_rssi >= aux_rssi) ?
+               MAIN_ANT : AUX_ANT);
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
-                "main_ant_sum %d main_ant_cnt %d\n",
-                fat_tbl->main_ant_sum[i], fat_tbl->main_ant_cnt[i]);
+               "main_ant_sum %d main_ant_cnt %d\n",
+               pfat_table->main_ant_sum[i],
+               pfat_table->main_ant_cnt[i]);
        RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
                 "aux_ant_sum %d aux_ant_cnt %d\n",
-                fat_tbl->aux_ant_sum[i],
-                fat_tbl->aux_ant_cnt[i]);
-       RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
-                "main_rssi %d aux_rssi%d\n", main_rssi, aux_rssi);
+                pfat_table->aux_ant_sum[i], pfat_table->aux_ant_cnt[i]);
+       RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "main_rssi %d aux_rssi%d\n",
+                main_rssi, aux_rssi);
        local_max_rssi = (main_rssi > aux_rssi) ? main_rssi : aux_rssi;
        if ((local_max_rssi > ant_div_max_rssi) && (local_max_rssi < 40))
                ant_div_max_rssi = local_max_rssi;
        if (local_max_rssi > max_rssi)
                max_rssi = local_max_rssi;
 
-       if ((fat_tbl->rx_idle_ant == MAIN_ANT) && (main_rssi == 0))
+       if ((pfat_table->rx_idle_ant == MAIN_ANT) && (main_rssi == 0))
                main_rssi = aux_rssi;
-       else if ((fat_tbl->rx_idle_ant == AUX_ANT) && (aux_rssi == 0))
+       else if ((pfat_table->rx_idle_ant == AUX_ANT) && (aux_rssi == 0))
                aux_rssi = main_rssi;
 
        local_min_rssi = (main_rssi > aux_rssi) ? aux_rssi : main_rssi;
@@ -1518,32 +1555,33 @@ static void rtl88e_dm_hw_ant_div(struct ieee80211_hw *hw)
                spin_lock_bh(&rtlpriv->locks.entry_list_lock);
                list_for_each_entry(drv_priv, &rtlpriv->entry_list, list) {
                        i++;
-                       main_rssi = (fat_tbl->main_ant_cnt[i] != 0) ?
-                               (fat_tbl->main_ant_sum[i] /
-                                fat_tbl->main_ant_cnt[i]) : 0;
-                       aux_rssi = (fat_tbl->aux_ant_cnt[i] != 0) ?
-                                  (fat_tbl->aux_ant_sum[i] /
-                                   fat_tbl->aux_ant_cnt[i]) : 0;
+                       main_rssi = (pfat_table->main_ant_cnt[i] != 0) ?
+                               (pfat_table->main_ant_sum[i] /
+                               pfat_table->main_ant_cnt[i]) : 0;
+                       aux_rssi = (pfat_table->aux_ant_cnt[i] != 0) ?
+                               (pfat_table->aux_ant_sum[i] /
+                               pfat_table->aux_ant_cnt[i]) : 0;
                        target_ant = (main_rssi == aux_rssi) ?
-                                     fat_tbl->rx_idle_ant : ((main_rssi >=
-                                     aux_rssi) ? MAIN_ANT : AUX_ANT);
-
+                               pfat_table->rx_idle_ant : ((main_rssi >=
+                               aux_rssi) ? MAIN_ANT : AUX_ANT);
 
-                       local_max_rssi = max_t(u32, main_rssi, aux_rssi);
+                       local_max_rssi = (main_rssi > aux_rssi) ?
+                                        main_rssi : aux_rssi;
                        if ((local_max_rssi > ant_div_max_rssi) &&
                            (local_max_rssi < 40))
                                ant_div_max_rssi = local_max_rssi;
                        if (local_max_rssi > max_rssi)
                                max_rssi = local_max_rssi;
 
-                       if ((fat_tbl->rx_idle_ant == MAIN_ANT) && !main_rssi)
+                       if ((pfat_table->rx_idle_ant == MAIN_ANT) &&
+                           (main_rssi == 0))
                                main_rssi = aux_rssi;
-                       else if ((fat_tbl->rx_idle_ant == AUX_ANT) &&
+                       else if ((pfat_table->rx_idle_ant == AUX_ANT) &&
                                 (aux_rssi == 0))
                                aux_rssi = main_rssi;
 
                        local_min_rssi = (main_rssi > aux_rssi) ?
-                                         aux_rssi : main_rssi;
+                               aux_rssi : main_rssi;
                        if (local_min_rssi < min_rssi) {
                                min_rssi = local_min_rssi;
                                rx_idle_ant = target_ant;
@@ -1555,10 +1593,10 @@ static void rtl88e_dm_hw_ant_div(struct ieee80211_hw *hw)
        }
 
        for (i = 0; i < ASSOCIATE_ENTRY_NUM; i++) {
-               fat_tbl->main_ant_sum[i] = 0;
-               fat_tbl->aux_ant_sum[i] = 0;
-               fat_tbl->main_ant_cnt[i] = 0;
-               fat_tbl->aux_ant_cnt[i] = 0;
+               pfat_table->main_ant_sum[i] = 0;
+               pfat_table->aux_ant_sum[i] = 0;
+               pfat_table->main_ant_cnt[i] = 0;
+               pfat_table->aux_ant_cnt[i] = 0;
        }
 
        rtl88e_dm_update_rx_idle_ant(hw, rx_idle_ant);
@@ -1573,27 +1611,27 @@ static void rtl88e_set_next_mac_address_target(struct ieee80211_hw *hw)
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
        struct rtl_sta_info *drv_priv;
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
        u32 value32, i, j = 0;
 
        if (mac->link_state >= MAC80211_LINKED) {
                for (i = 0; i < ASSOCIATE_ENTRY_NUM; i++) {
-                       if ((fat_tbl->train_idx + 1) == ASSOCIATE_ENTRY_NUM)
-                               fat_tbl->train_idx = 0;
+                       if ((pfat_table->train_idx + 1) == ASSOCIATE_ENTRY_NUM)
+                               pfat_table->train_idx = 0;
                        else
-                               fat_tbl->train_idx++;
+                               pfat_table->train_idx++;
 
-                       if (fat_tbl->train_idx == 0) {
+                       if (pfat_table->train_idx == 0) {
                                value32 = (mac->mac_addr[5] << 8) |
-                                          mac->mac_addr[4];
-                               rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_2,
+                                         mac->mac_addr[4];
+                               rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_PARA2_11N,
                                              MASKLWORD, value32);
 
                                value32 = (mac->mac_addr[3] << 24) |
                                          (mac->mac_addr[2] << 16) |
                                          (mac->mac_addr[1] << 8) |
-                                          mac->mac_addr[0];
-                               rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_1,
+                                         mac->mac_addr[0];
+                               rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_PARA1_11N,
                                              MASKDWORD, value32);
                                break;
                        }
@@ -1602,28 +1640,29 @@ static void rtl88e_set_next_mac_address_target(struct ieee80211_hw *hw)
                            NL80211_IFTYPE_STATION) {
                                spin_lock_bh(&rtlpriv->locks.entry_list_lock);
                                list_for_each_entry(drv_priv,
-                                                   &rtlpriv->entry_list,
-                                                   list) {
+                                                   &rtlpriv->entry_list, list) {
                                        j++;
-                                       if (j != fat_tbl->train_idx)
+                                       if (j != pfat_table->train_idx)
                                                continue;
 
                                        value32 = (drv_priv->mac_addr[5] << 8) |
-                                                  drv_priv->mac_addr[4];
-                                       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_2,
+                                                 drv_priv->mac_addr[4];
+                                       rtl_set_bbreg(hw,
+                                                     DM_REG_ANT_TRAIN_PARA2_11N,
                                                      MASKLWORD, value32);
 
-                                       value32 = (drv_priv->mac_addr[3]<<24) |
-                                                 (drv_priv->mac_addr[2]<<16) |
-                                                 (drv_priv->mac_addr[1]<<8) |
-                                                  drv_priv->mac_addr[0];
-                                       rtl_set_bbreg(hw, DM_REG_ANT_TRAIN_1,
+                                       value32 = (drv_priv->mac_addr[3] << 24) |
+                                                 (drv_priv->mac_addr[2] << 16) |
+                                                 (drv_priv->mac_addr[1] << 8) |
+                                                 drv_priv->mac_addr[0];
+                                       rtl_set_bbreg(hw,
+                                                     DM_REG_ANT_TRAIN_PARA1_11N,
                                                      MASKDWORD, value32);
                                        break;
                                }
                                spin_unlock_bh(&rtlpriv->locks.entry_list_lock);
                                /*find entry, break*/
-                               if (j == fat_tbl->train_idx)
+                               if (j == pfat_table->train_idx)
                                        break;
                        }
                }
@@ -1634,23 +1673,24 @@ static void rtl88e_dm_fast_ant_training(struct ieee80211_hw *hw)
 {
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
        u32 i, max_rssi = 0;
        u8 target_ant = 2;
        bool bpkt_filter_match = false;
 
-       if (fat_tbl->fat_state == FAT_TRAINING_STATE) {
+       if (pfat_table->fat_state == FAT_TRAINING_STATE) {
                for (i = 0; i < 7; i++) {
-                       if (fat_tbl->ant_cnt[i] == 0) {
-                               fat_tbl->ant_ave[i] = 0;
+                       if (pfat_table->ant_cnt[i] == 0) {
+                               pfat_table->ant_ave[i] = 0;
                        } else {
-                               fat_tbl->ant_ave[i] = fat_tbl->ant_sum[i] /
-                                       fat_tbl->ant_cnt[i];
+                               pfat_table->ant_ave[i] =
+                                       pfat_table->ant_sum[i] /
+                                       pfat_table->ant_cnt[i];
                                bpkt_filter_match = true;
                        }
 
-                       if (fat_tbl->ant_ave[i] > max_rssi) {
-                               max_rssi = fat_tbl->ant_ave[i];
+                       if (pfat_table->ant_ave[i] > max_rssi) {
+                               max_rssi = pfat_table->ant_ave[i];
                                target_ant = (u8) i;
                        }
                }
@@ -1664,32 +1704,33 @@ static void rtl88e_dm_fast_ant_training(struct ieee80211_hw *hw)
                                      BIT(16), 0);
                        rtl_set_bbreg(hw, DM_REG_RX_ANT_CTRL_11N, BIT(8) |
                                      BIT(7) | BIT(6), target_ant);
-                       rtl_set_bbreg(hw, DM_REG_TX_ANT_CTRL_11N, BIT(21), 1);
+                       rtl_set_bbreg(hw, DM_REG_TX_ANT_CTRL_11N,
+                                     BIT(21), 1);
 
-                       fat_tbl->antsel_a[fat_tbl->train_idx] =
-                                 target_ant & BIT(0);
-                       fat_tbl->antsel_b[fat_tbl->train_idx] =
-                                (target_ant & BIT(1)) >> 1;
-                       fat_tbl->antsel_c[fat_tbl->train_idx] =
-                                (target_ant & BIT(2)) >> 2;
+                       pfat_table->antsel_a[pfat_table->train_idx] =
+                               target_ant & BIT(0);
+                       pfat_table->antsel_b[pfat_table->train_idx] =
+                               (target_ant & BIT(1)) >> 1;
+                       pfat_table->antsel_c[pfat_table->train_idx] =
+                               (target_ant & BIT(2)) >> 2;
 
                        if (target_ant == 0)
                                rtl_set_bbreg(hw, DM_REG_IGI_A_11N, BIT(7), 0);
                }
 
                for (i = 0; i < 7; i++) {
-                       fat_tbl->ant_sum[i] = 0;
-                       fat_tbl->ant_cnt[i] = 0;
+                       pfat_table->ant_sum[i] = 0;
+                       pfat_table->ant_cnt[i] = 0;
                }
 
-               fat_tbl->fat_state = FAT_NORMAL_STATE;
+               pfat_table->fat_state = FAT_NORMAL_STATE;
                return;
        }
 
-       if (fat_tbl->fat_state == FAT_NORMAL_STATE) {
+       if (pfat_table->fat_state == FAT_NORMAL_STATE) {
                rtl88e_set_next_mac_address_target(hw);
 
-               fat_tbl->fat_state = FAT_TRAINING_STATE;
+               pfat_table->fat_state = FAT_TRAINING_STATE;
                rtl_set_bbreg(hw, DM_REG_TXAGC_A_1_MCS32_11N, BIT(16), 1);
                rtl_set_bbreg(hw, DM_REG_IGI_A_11N, BIT(7), 1);
 
@@ -1711,11 +1752,11 @@ static void rtl88e_dm_antenna_diversity(struct ieee80211_hw *hw)
        struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
        struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
        struct rtl_dm *rtldm = rtl_dm(rtl_priv(hw));
-       struct fast_ant_training *fat_tbl = &(rtldm->fat_table);
+       struct fast_ant_training *pfat_table = &rtldm->fat_table;
 
        if (mac->link_state < MAC80211_LINKED) {
                RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD, "No Link\n");
-               if (fat_tbl->becomelinked == true) {
+               if (pfat_table->becomelinked) {
                        RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
                                 "need to turn off HW AntDiv\n");
                        rtl_set_bbreg(hw, DM_REG_IGI_A_11N, BIT(7), 0);
@@ -1724,12 +1765,13 @@ static void rtl88e_dm_antenna_diversity(struct ieee80211_hw *hw)
                        if (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV)
                                rtl_set_bbreg(hw, DM_REG_TX_ANT_CTRL_11N,
                                              BIT(21), 0);
-                       fat_tbl->becomelinked =
-                         (mac->link_state == MAC80211_LINKED) ? true : false;
+                       pfat_table->becomelinked =
+                               (mac->link_state == MAC80211_LINKED) ?
+                               true : false;
                }
                return;
        } else {
-               if (fat_tbl->becomelinked == false) {
+               if (!pfat_table->becomelinked) {
                        RT_TRACE(rtlpriv, COMP_DIG, DBG_LOUD,
                                 "Need to turn on HW AntDiv\n");
                        rtl_set_bbreg(hw, DM_REG_IGI_A_11N, BIT(7), 1);
@@ -1738,8 +1780,9 @@ static void rtl88e_dm_antenna_diversity(struct ieee80211_hw *hw)
                        if (rtlefuse->antenna_div_type == CG_TRX_HW_ANTDIV)
                                rtl_set_bbreg(hw, DM_REG_TX_ANT_CTRL_11N,
                                              BIT(21), 1);
-                       fat_tbl->becomelinked =
-                          (mac->link_state >= MAC80211_LINKED) ? true : false;
+                       pfat_table->becomelinked =
+                               (mac->link_state >= MAC80211_LINKED) ?
+                               true : false;
                }
        }