]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blobdiff - drivers/pinctrl/pinctrl-single.c
Merge branches 'for-4.11/upstream-fixes', 'for-4.12/accutouch', 'for-4.12/cp2112...
[mirror_ubuntu-artful-kernel.git] / drivers / pinctrl / pinctrl-single.c
index a5a0392ab8175da62001816e3f7eb7a2600f1b08..8b2d45e85baea612451812fb7cc82b88b75d8d9c 100644 (file)
 #include "core.h"
 #include "devicetree.h"
 #include "pinconf.h"
+#include "pinmux.h"
 
 #define DRIVER_NAME                    "pinctrl-single"
 #define PCS_OFF_DISABLED               ~0U
 
-/**
- * struct pcs_pingroup - pingroups for a function
- * @np:                pingroup device node pointer
- * @name:      pingroup name
- * @gpins:     array of the pins in the group
- * @ngpins:    number of pins in the group
- * @node:      list node
- */
-struct pcs_pingroup {
-       struct device_node *np;
-       const char *name;
-       int *gpins;
-       int ngpins;
-       struct list_head node;
-};
-
 /**
  * struct pcs_func_vals - mux function register offset and value pair
  * @reg:       register virtual address
@@ -176,16 +161,10 @@ struct pcs_soc_data {
  * @bits_per_mux: number of bits per mux
  * @bits_per_pin: number of bits per pin
  * @pins:      physical pins on the SoC
- * @pgtree:    pingroup index radix tree
- * @ftree:     function index radix tree
- * @pingroups: list of pingroups
- * @functions: list of functions
  * @gpiofuncs: list of gpio functions
  * @irqs:      list of interrupt registers
  * @chip:      chip container for this instance
  * @domain:    IRQ domain for this instance
- * @ngroups:   number of pingroups
- * @nfuncs:    number of functions
  * @desc:      pin controller descriptor
  * @read:      register read function to use
  * @write:     register write function to use
@@ -213,16 +192,10 @@ struct pcs_device {
        bool bits_per_mux;
        unsigned bits_per_pin;
        struct pcs_data pins;
-       struct radix_tree_root pgtree;
-       struct radix_tree_root ftree;
-       struct list_head pingroups;
-       struct list_head functions;
        struct list_head gpiofuncs;
        struct list_head irqs;
        struct irq_chip chip;
        struct irq_domain *domain;
-       unsigned ngroups;
-       unsigned nfuncs;
        struct pinctrl_desc desc;
        unsigned (*read)(void __iomem *reg);
        void (*write)(unsigned val, void __iomem *reg);
@@ -288,54 +261,6 @@ static void __maybe_unused pcs_writel(unsigned val, void __iomem *reg)
        writel(val, reg);
 }
 
-static int pcs_get_groups_count(struct pinctrl_dev *pctldev)
-{
-       struct pcs_device *pcs;
-
-       pcs = pinctrl_dev_get_drvdata(pctldev);
-
-       return pcs->ngroups;
-}
-
-static const char *pcs_get_group_name(struct pinctrl_dev *pctldev,
-                                       unsigned gselector)
-{
-       struct pcs_device *pcs;
-       struct pcs_pingroup *group;
-
-       pcs = pinctrl_dev_get_drvdata(pctldev);
-       group = radix_tree_lookup(&pcs->pgtree, gselector);
-       if (!group) {
-               dev_err(pcs->dev, "%s could not find pingroup%i\n",
-                       __func__, gselector);
-               return NULL;
-       }
-
-       return group->name;
-}
-
-static int pcs_get_group_pins(struct pinctrl_dev *pctldev,
-                                       unsigned gselector,
-                                       const unsigned **pins,
-                                       unsigned *npins)
-{
-       struct pcs_device *pcs;
-       struct pcs_pingroup *group;
-
-       pcs = pinctrl_dev_get_drvdata(pctldev);
-       group = radix_tree_lookup(&pcs->pgtree, gselector);
-       if (!group) {
-               dev_err(pcs->dev, "%s could not find pingroup%i\n",
-                       __func__, gselector);
-               return -EINVAL;
-       }
-
-       *pins = group->gpins;
-       *npins = group->ngpins;
-
-       return 0;
-}
-
 static void pcs_pin_dbg_show(struct pinctrl_dev *pctldev,
                                        struct seq_file *s,
                                        unsigned pin)
@@ -369,67 +294,21 @@ static int pcs_dt_node_to_map(struct pinctrl_dev *pctldev,
                                struct pinctrl_map **map, unsigned *num_maps);
 
 static const struct pinctrl_ops pcs_pinctrl_ops = {
-       .get_groups_count = pcs_get_groups_count,
-       .get_group_name = pcs_get_group_name,
-       .get_group_pins = pcs_get_group_pins,
+       .get_groups_count = pinctrl_generic_get_group_count,
+       .get_group_name = pinctrl_generic_get_group_name,
+       .get_group_pins = pinctrl_generic_get_group_pins,
        .pin_dbg_show = pcs_pin_dbg_show,
        .dt_node_to_map = pcs_dt_node_to_map,
        .dt_free_map = pcs_dt_free_map,
 };
 
-static int pcs_get_functions_count(struct pinctrl_dev *pctldev)
-{
-       struct pcs_device *pcs;
-
-       pcs = pinctrl_dev_get_drvdata(pctldev);
-
-       return pcs->nfuncs;
-}
-
-static const char *pcs_get_function_name(struct pinctrl_dev *pctldev,
-                                               unsigned fselector)
-{
-       struct pcs_device *pcs;
-       struct pcs_function *func;
-
-       pcs = pinctrl_dev_get_drvdata(pctldev);
-       func = radix_tree_lookup(&pcs->ftree, fselector);
-       if (!func) {
-               dev_err(pcs->dev, "%s could not find function%i\n",
-                       __func__, fselector);
-               return NULL;
-       }
-
-       return func->name;
-}
-
-static int pcs_get_function_groups(struct pinctrl_dev *pctldev,
-                                       unsigned fselector,
-                                       const char * const **groups,
-                                       unsigned * const ngroups)
-{
-       struct pcs_device *pcs;
-       struct pcs_function *func;
-
-       pcs = pinctrl_dev_get_drvdata(pctldev);
-       func = radix_tree_lookup(&pcs->ftree, fselector);
-       if (!func) {
-               dev_err(pcs->dev, "%s could not find function%i\n",
-                       __func__, fselector);
-               return -EINVAL;
-       }
-       *groups = func->pgnames;
-       *ngroups = func->npgnames;
-
-       return 0;
-}
-
 static int pcs_get_function(struct pinctrl_dev *pctldev, unsigned pin,
                            struct pcs_function **func)
 {
        struct pcs_device *pcs = pinctrl_dev_get_drvdata(pctldev);
        struct pin_desc *pdesc = pin_desc_get(pctldev, pin);
        const struct pinctrl_setting_mux *setting;
+       struct function_desc *function;
        unsigned fselector;
 
        /* If pin is not described in DTS & enabled, mux_setting is NULL. */
@@ -437,7 +316,8 @@ static int pcs_get_function(struct pinctrl_dev *pctldev, unsigned pin,
        if (!setting)
                return -ENOTSUPP;
        fselector = setting->func;
-       *func = radix_tree_lookup(&pcs->ftree, fselector);
+       function = pinmux_generic_get_function(pctldev, fselector);
+       *func = function->data;
        if (!(*func)) {
                dev_err(pcs->dev, "%s could not find function%i\n",
                        __func__, fselector);
@@ -450,6 +330,7 @@ static int pcs_set_mux(struct pinctrl_dev *pctldev, unsigned fselector,
        unsigned group)
 {
        struct pcs_device *pcs;
+       struct function_desc *function;
        struct pcs_function *func;
        int i;
 
@@ -457,7 +338,8 @@ static int pcs_set_mux(struct pinctrl_dev *pctldev, unsigned fselector,
        /* If function mask is null, needn't enable it. */
        if (!pcs->fmask)
                return 0;
-       func = radix_tree_lookup(&pcs->ftree, fselector);
+       function = pinmux_generic_get_function(pctldev, fselector);
+       func = function->data;
        if (!func)
                return -EINVAL;
 
@@ -515,9 +397,9 @@ static int pcs_request_gpio(struct pinctrl_dev *pctldev,
 }
 
 static const struct pinmux_ops pcs_pinmux_ops = {
-       .get_functions_count = pcs_get_functions_count,
-       .get_function_name = pcs_get_function_name,
-       .get_function_groups = pcs_get_function_groups,
+       .get_functions_count = pinmux_generic_get_function_count,
+       .get_function_name = pinmux_generic_get_function_name,
+       .get_function_groups = pinmux_generic_get_function_groups,
        .set_mux = pcs_set_mux,
        .gpio_request_enable = pcs_request_gpio,
 };
@@ -622,7 +504,7 @@ static int pcs_pinconf_set(struct pinctrl_dev *pctldev,
        struct pcs_device *pcs = pinctrl_dev_get_drvdata(pctldev);
        struct pcs_function *func;
        unsigned offset = 0, shift = 0, i, data, ret;
-       u16 arg;
+       u32 arg;
        int j;
 
        ret = pcs_get_function(pctldev, pin, &func);
@@ -685,7 +567,7 @@ static int pcs_pinconf_group_get(struct pinctrl_dev *pctldev,
        unsigned npins, old = 0;
        int i, ret;
 
-       ret = pcs_get_group_pins(pctldev, group, &pins, &npins);
+       ret = pinctrl_generic_get_group_pins(pctldev, group, &pins, &npins);
        if (ret)
                return ret;
        for (i = 0; i < npins; i++) {
@@ -707,7 +589,7 @@ static int pcs_pinconf_group_set(struct pinctrl_dev *pctldev,
        unsigned npins;
        int i, ret;
 
-       ret = pcs_get_group_pins(pctldev, group, &pins, &npins);
+       ret = pinctrl_generic_get_group_pins(pctldev, group, &pins, &npins);
        if (ret)
                return ret;
        for (i = 0; i < npins; i++) {
@@ -859,77 +741,24 @@ static struct pcs_function *pcs_add_function(struct pcs_device *pcs,
                                        unsigned npgnames)
 {
        struct pcs_function *function;
+       int res;
 
        function = devm_kzalloc(pcs->dev, sizeof(*function), GFP_KERNEL);
        if (!function)
                return NULL;
 
-       function->name = name;
        function->vals = vals;
        function->nvals = nvals;
-       function->pgnames = pgnames;
-       function->npgnames = npgnames;
 
-       mutex_lock(&pcs->mutex);
-       list_add_tail(&function->node, &pcs->functions);
-       radix_tree_insert(&pcs->ftree, pcs->nfuncs, function);
-       pcs->nfuncs++;
-       mutex_unlock(&pcs->mutex);
+       res = pinmux_generic_add_function(pcs->pctl, name,
+                                         pgnames, npgnames,
+                                         function);
+       if (res)
+               return NULL;
 
        return function;
 }
 
-static void pcs_remove_function(struct pcs_device *pcs,
-                               struct pcs_function *function)
-{
-       int i;
-
-       mutex_lock(&pcs->mutex);
-       for (i = 0; i < pcs->nfuncs; i++) {
-               struct pcs_function *found;
-
-               found = radix_tree_lookup(&pcs->ftree, i);
-               if (found == function)
-                       radix_tree_delete(&pcs->ftree, i);
-       }
-       list_del(&function->node);
-       mutex_unlock(&pcs->mutex);
-}
-
-/**
- * pcs_add_pingroup() - add a pingroup to the pingroup list
- * @pcs: pcs driver instance
- * @np: device node of the mux entry
- * @name: name of the pingroup
- * @gpins: array of the pins that belong to the group
- * @ngpins: number of pins in the group
- */
-static int pcs_add_pingroup(struct pcs_device *pcs,
-                                       struct device_node *np,
-                                       const char *name,
-                                       int *gpins,
-                                       int ngpins)
-{
-       struct pcs_pingroup *pingroup;
-
-       pingroup = devm_kzalloc(pcs->dev, sizeof(*pingroup), GFP_KERNEL);
-       if (!pingroup)
-               return -ENOMEM;
-
-       pingroup->name = name;
-       pingroup->np = np;
-       pingroup->gpins = gpins;
-       pingroup->ngpins = ngpins;
-
-       mutex_lock(&pcs->mutex);
-       list_add_tail(&pingroup->node, &pcs->pingroups);
-       radix_tree_insert(&pcs->pgtree, pcs->ngroups, pingroup);
-       pcs->ngroups++;
-       mutex_unlock(&pcs->mutex);
-
-       return 0;
-}
-
 /**
  * pcs_get_pin_by_offset() - get a pin index based on the register offset
  * @pcs: pcs driver instance
@@ -1100,10 +929,9 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,
        return 0;
 }
 
-static void pcs_free_pingroups(struct pcs_device *pcs);
-
 /**
  * smux_parse_one_pinctrl_entry() - parses a device tree mux entry
+ * @pctldev: pin controller device
  * @pcs: pinctrl driver instance
  * @np: device node of the mux entry
  * @map: map entry
@@ -1134,7 +962,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
 
        rows = pinctrl_count_index_with_args(np, name);
        if (rows <= 0) {
-               dev_err(pcs->dev, "Ivalid number of rows: %d\n", rows);
+               dev_err(pcs->dev, "Invalid number of rows: %d\n", rows);
                return -EINVAL;
        }
 
@@ -1186,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
                goto free_pins;
        }
 
-       res = pcs_add_pingroup(pcs, np, np->name, pins, found);
+       res = pinctrl_generic_add_group(pcs->pctl, np->name, pins, found, pcs);
        if (res < 0)
                goto free_function;
 
@@ -1205,10 +1033,10 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
        return 0;
 
 free_pingroups:
-       pcs_free_pingroups(pcs);
+       pinctrl_generic_remove_last_group(pcs->pctl);
        *num_maps = 1;
 free_function:
-       pcs_remove_function(pcs, function);
+       pinmux_generic_remove_last_function(pcs->pctl);
 
 free_pins:
        devm_kfree(pcs->dev, pins);
@@ -1320,7 +1148,7 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs,
                goto free_pins;
        }
 
-       res = pcs_add_pingroup(pcs, np, np->name, pins, found);
+       res = pinctrl_generic_add_group(pcs->pctl, np->name, pins, found, pcs);
        if (res < 0)
                goto free_function;
 
@@ -1337,11 +1165,10 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs,
        return 0;
 
 free_pingroups:
-       pcs_free_pingroups(pcs);
+       pinctrl_generic_remove_last_group(pcs->pctl);
        *num_maps = 1;
 free_function:
-       pcs_remove_function(pcs, function);
-
+       pinmux_generic_remove_last_function(pcs->pctl);
 free_pins:
        devm_kfree(pcs->dev, pins);
 
@@ -1408,60 +1235,6 @@ free_map:
        return ret;
 }
 
-/**
- * pcs_free_funcs() - free memory used by functions
- * @pcs: pcs driver instance
- */
-static void pcs_free_funcs(struct pcs_device *pcs)
-{
-       struct list_head *pos, *tmp;
-       int i;
-
-       mutex_lock(&pcs->mutex);
-       for (i = 0; i < pcs->nfuncs; i++) {
-               struct pcs_function *func;
-
-               func = radix_tree_lookup(&pcs->ftree, i);
-               if (!func)
-                       continue;
-               radix_tree_delete(&pcs->ftree, i);
-       }
-       list_for_each_safe(pos, tmp, &pcs->functions) {
-               struct pcs_function *function;
-
-               function = list_entry(pos, struct pcs_function, node);
-               list_del(&function->node);
-       }
-       mutex_unlock(&pcs->mutex);
-}
-
-/**
- * pcs_free_pingroups() - free memory used by pingroups
- * @pcs: pcs driver instance
- */
-static void pcs_free_pingroups(struct pcs_device *pcs)
-{
-       struct list_head *pos, *tmp;
-       int i;
-
-       mutex_lock(&pcs->mutex);
-       for (i = 0; i < pcs->ngroups; i++) {
-               struct pcs_pingroup *pingroup;
-
-               pingroup = radix_tree_lookup(&pcs->pgtree, i);
-               if (!pingroup)
-                       continue;
-               radix_tree_delete(&pcs->pgtree, i);
-       }
-       list_for_each_safe(pos, tmp, &pcs->pingroups) {
-               struct pcs_pingroup *pingroup;
-
-               pingroup = list_entry(pos, struct pcs_pingroup, node);
-               list_del(&pingroup->node);
-       }
-       mutex_unlock(&pcs->mutex);
-}
-
 /**
  * pcs_irq_free() - free interrupt
  * @pcs: pcs driver instance
@@ -1490,8 +1263,7 @@ static void pcs_free_resources(struct pcs_device *pcs)
 {
        pcs_irq_free(pcs);
        pinctrl_unregister(pcs->pctl);
-       pcs_free_funcs(pcs);
-       pcs_free_pingroups(pcs);
+
 #if IS_BUILTIN(CONFIG_PINCTRL_SINGLE)
        if (pcs->missing_nr_pinctrl_cells)
                of_remove_property(pcs->np, pcs->missing_nr_pinctrl_cells);
@@ -1885,8 +1657,6 @@ static int pcs_probe(struct platform_device *pdev)
        pcs->np = np;
        raw_spin_lock_init(&pcs->lock);
        mutex_init(&pcs->mutex);
-       INIT_LIST_HEAD(&pcs->pingroups);
-       INIT_LIST_HEAD(&pcs->functions);
        INIT_LIST_HEAD(&pcs->gpiofuncs);
        soc = match->data;
        pcs->flags = soc->flags;
@@ -1947,8 +1717,6 @@ static int pcs_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       INIT_RADIX_TREE(&pcs->pgtree, GFP_KERNEL);
-       INIT_RADIX_TREE(&pcs->ftree, GFP_KERNEL);
        platform_set_drvdata(pdev, pcs);
 
        switch (pcs->width) {
@@ -1979,10 +1747,9 @@ static int pcs_probe(struct platform_device *pdev)
        if (ret < 0)
                goto free;
 
-       pcs->pctl = pinctrl_register(&pcs->desc, pcs->dev, pcs);
-       if (IS_ERR(pcs->pctl)) {
+       ret = pinctrl_register_and_init(&pcs->desc, pcs->dev, pcs, &pcs->pctl);
+       if (ret) {
                dev_err(pcs->dev, "could not register single pinctrl driver\n");
-               ret = PTR_ERR(pcs->pctl);
                goto free;
        }