clean up scary strncpy(dst, src, strlen(src)) uses

[mirror_ubuntu-artful-kernel.git] / drivers / s390 / net / qeth_l3_sys.c

diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
index e70af2406ff9da388828660bb0bed2b73bf5cb71..d1c8025b0b037605c73f331b6ebd3178feed2767 100644 (file)
--- a/drivers/s390/net/qeth_l3_sys.c
+++ b/drivers/s390/net/qeth_l3_sys.c
@@ -315,10 +315,8 @@ static ssize_t qeth_l3_dev_hsuid_store(struct device *dev,
        if (qeth_configure_cq(card, QETH_CQ_ENABLED))
                return -EPERM;
 
-       for (i = 0; i < 8; i++)
-               card->options.hsuid[i] = ' ';
-       card->options.hsuid[8] = '\0';
-       strncpy(card->options.hsuid, tmp, strlen(tmp));
+       snprintf(card->options.hsuid, sizeof(card->options.hsuid),
+                "%-8s", tmp);
        ASCEBC(card->options.hsuid, 8);
        if (card->dev)
                memcpy(card->dev->perm_addr, card->options.hsuid, 9);