]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/blobdiff - drivers/staging/android/ion/ion_system_heap.c
staging: ion: remove order argument from free_buffer_page()
[mirror_ubuntu-bionic-kernel.git] / drivers / staging / android / ion / ion_system_heap.c
index c92363356ae142292fdcc29f0e1ebd758ff49e8c..e0a7e5491f59351e83bccd01e7d47dd901b9b84b 100644 (file)
@@ -34,6 +34,7 @@ static const int num_orders = ARRAY_SIZE(orders);
 static int order_to_index(unsigned int order)
 {
        int i;
+
        for (i = 0; i < num_orders; i++)
                if (order == orders[i])
                        return i;
@@ -41,7 +42,7 @@ static int order_to_index(unsigned int order)
        return -1;
 }
 
-static unsigned int order_to_size(int order)
+static inline unsigned int order_to_size(int order)
 {
        return PAGE_SIZE << order;
 }
@@ -51,12 +52,6 @@ struct ion_system_heap {
        struct ion_page_pool **pools;
 };
 
-struct page_info {
-       struct page *page;
-       unsigned int order;
-       struct list_head list;
-};
-
 static struct page *alloc_buffer_page(struct ion_system_heap *heap,
                                      struct ion_buffer *buffer,
                                      unsigned long order)
@@ -72,26 +67,25 @@ static struct page *alloc_buffer_page(struct ion_system_heap *heap,
 
                if (order > 4)
                        gfp_flags = high_order_gfp_flags;
-               page = alloc_pages(gfp_flags, order);
+               page = alloc_pages(gfp_flags | __GFP_COMP, order);
                if (!page)
                        return NULL;
                ion_pages_sync_for_device(NULL, page, PAGE_SIZE << order,
                                                DMA_BIDIRECTIONAL);
        }
-       if (!page)
-               return NULL;
 
        return page;
 }
 
 static void free_buffer_page(struct ion_system_heap *heap,
-                            struct ion_buffer *buffer, struct page *page,
-                            unsigned int order)
+                            struct ion_buffer *buffer, struct page *page)
 {
+       unsigned int order = compound_order(page);
        bool cached = ion_buffer_cached(buffer);
 
        if (!cached && !(buffer->private_flags & ION_PRIV_FLAG_SHRINKER_FREE)) {
                struct ion_page_pool *pool = heap->pools[order_to_index(order)];
+
                ion_page_pool_free(pool, page);
        } else {
                __free_pages(page, order);
@@ -99,19 +93,14 @@ static void free_buffer_page(struct ion_system_heap *heap,
 }
 
 
-static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
-                                                struct ion_buffer *buffer,
-                                                unsigned long size,
-                                                unsigned int max_order)
+static struct page *alloc_largest_available(struct ion_system_heap *heap,
+                                           struct ion_buffer *buffer,
+                                           unsigned long size,
+                                           unsigned int max_order)
 {
        struct page *page;
-       struct page_info *info;
        int i;
 
-       info = kmalloc(sizeof(struct page_info), GFP_KERNEL);
-       if (!info)
-               return NULL;
-
        for (i = 0; i < num_orders; i++) {
                if (size < order_to_size(orders[i]))
                        continue;
@@ -122,12 +111,8 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
                if (!page)
                        continue;
 
-               info->page = page;
-               info->order = orders[i];
-               INIT_LIST_HEAD(&info->list);
-               return info;
+               return page;
        }
-       kfree(info);
 
        return NULL;
 }
@@ -142,9 +127,8 @@ static int ion_system_heap_allocate(struct ion_heap *heap,
                                                        heap);
        struct sg_table *table;
        struct scatterlist *sg;
-       int ret;
        struct list_head pages;
-       struct page_info *info, *tmp_info;
+       struct page *page, *tmp_page;
        int i = 0;
        unsigned long size_remaining = PAGE_ALIGN(size);
        unsigned int max_order = orders[0];
@@ -157,54 +141,48 @@ static int ion_system_heap_allocate(struct ion_heap *heap,
 
        INIT_LIST_HEAD(&pages);
        while (size_remaining > 0) {
-               info = alloc_largest_available(sys_heap, buffer, size_remaining,
+               page = alloc_largest_available(sys_heap, buffer, size_remaining,
                                                max_order);
-               if (!info)
-                       goto err;
-               list_add_tail(&info->list, &pages);
-               size_remaining -= (1 << info->order) * PAGE_SIZE;
-               max_order = info->order;
+               if (!page)
+                       goto free_pages;
+               list_add_tail(&page->lru, &pages);
+               size_remaining -= PAGE_SIZE << compound_order(page);
+               max_order = compound_order(page);
                i++;
        }
-       table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+       table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
        if (!table)
-               goto err;
+               goto free_pages;
 
-       ret = sg_alloc_table(table, i, GFP_KERNEL);
-       if (ret)
-               goto err1;
+       if (sg_alloc_table(table, i, GFP_KERNEL))
+               goto free_table;
 
        sg = table->sgl;
-       list_for_each_entry_safe(info, tmp_info, &pages, list) {
-               struct page *page = info->page;
-               sg_set_page(sg, page, (1 << info->order) * PAGE_SIZE, 0);
+       list_for_each_entry_safe(page, tmp_page, &pages, lru) {
+               sg_set_page(sg, page, PAGE_SIZE << compound_order(page), 0);
                sg = sg_next(sg);
-               list_del(&info->list);
-               kfree(info);
+               list_del(&page->lru);
        }
 
        buffer->priv_virt = table;
        return 0;
-err1:
+
+free_table:
        kfree(table);
-err:
-       list_for_each_entry_safe(info, tmp_info, &pages, list) {
-               free_buffer_page(sys_heap, buffer, info->page, info->order);
-               kfree(info);
-       }
+free_pages:
+       list_for_each_entry_safe(page, tmp_page, &pages, lru)
+               free_buffer_page(sys_heap, buffer, page);
        return -ENOMEM;
 }
 
 static void ion_system_heap_free(struct ion_buffer *buffer)
 {
-       struct ion_heap *heap = buffer->heap;
-       struct ion_system_heap *sys_heap = container_of(heap,
+       struct ion_system_heap *sys_heap = container_of(buffer->heap,
                                                        struct ion_system_heap,
                                                        heap);
        struct sg_table *table = buffer->sg_table;
        bool cached = ion_buffer_cached(buffer);
        struct scatterlist *sg;
-       LIST_HEAD(pages);
        int i;
 
        /* uncached pages come from the page pools, zero them before returning
@@ -213,8 +191,7 @@ static void ion_system_heap_free(struct ion_buffer *buffer)
                ion_heap_buffer_zero(buffer);
 
        for_each_sg(table->sgl, sg, table->nents, i)
-               free_buffer_page(sys_heap, buffer, sg_page(sg),
-                               get_order(sg->length));
+               free_buffer_page(sys_heap, buffer, sg_page(sg));
        sg_free_table(table);
        kfree(table);
 }
@@ -242,6 +219,7 @@ static int ion_system_heap_shrink(struct ion_heap *heap, gfp_t gfp_mask,
 
        for (i = 0; i < num_orders; i++) {
                struct ion_page_pool *pool = sys_heap->pools[i];
+
                nr_total += ion_page_pool_shrink(pool, gfp_mask, nr_to_scan);
        }
 
@@ -267,14 +245,16 @@ static int ion_system_heap_debug_show(struct ion_heap *heap, struct seq_file *s,
                                                        struct ion_system_heap,
                                                        heap);
        int i;
+
        for (i = 0; i < num_orders; i++) {
                struct ion_page_pool *pool = sys_heap->pools[i];
+
                seq_printf(s, "%d order %u highmem pages in pool = %lu total\n",
                           pool->high_count, pool->order,
-                          (1 << pool->order) * PAGE_SIZE * pool->high_count);
+                          (PAGE_SIZE << pool->order) * pool->high_count);
                seq_printf(s, "%d order %u lowmem pages in pool = %lu total\n",
                           pool->low_count, pool->order,
-                          (1 << pool->order) * PAGE_SIZE * pool->low_count);
+                          (PAGE_SIZE << pool->order) * pool->low_count);
        }
        return 0;
 }
@@ -293,7 +273,7 @@ struct ion_heap *ion_system_heap_create(struct ion_platform_heap *unused)
        heap->pools = kzalloc(sizeof(struct ion_page_pool *) * num_orders,
                              GFP_KERNEL);
        if (!heap->pools)
-               goto err_alloc_pools;
+               goto free_heap;
        for (i = 0; i < num_orders; i++) {
                struct ion_page_pool *pool;
                gfp_t gfp_flags = low_order_gfp_flags;
@@ -302,18 +282,18 @@ struct ion_heap *ion_system_heap_create(struct ion_platform_heap *unused)
                        gfp_flags = high_order_gfp_flags;
                pool = ion_page_pool_create(gfp_flags, orders[i]);
                if (!pool)
-                       goto err_create_pool;
+                       goto destroy_pools;
                heap->pools[i] = pool;
        }
 
        heap->heap.debug_show = ion_system_heap_debug_show;
        return &heap->heap;
-err_create_pool:
-       for (i = 0; i < num_orders; i++)
-               if (heap->pools[i])
-                       ion_page_pool_destroy(heap->pools[i]);
+
+destroy_pools:
+       while (i--)
+               ion_page_pool_destroy(heap->pools[i]);
        kfree(heap->pools);
-err_alloc_pools:
+free_heap:
        kfree(heap);
        return ERR_PTR(-ENOMEM);
 }
@@ -356,15 +336,15 @@ static int ion_system_contig_heap_allocate(struct ion_heap *heap,
        for (i = len >> PAGE_SHIFT; i < (1 << order); i++)
                __free_page(page + i);
 
-       table = kzalloc(sizeof(struct sg_table), GFP_KERNEL);
+       table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
        if (!table) {
                ret = -ENOMEM;
-               goto out;
+               goto free_pages;
        }
 
        ret = sg_alloc_table(table, 1, GFP_KERNEL);
        if (ret)
-               goto out;
+               goto free_table;
 
        sg_set_page(table->sgl, page, len, 0);
 
@@ -374,10 +354,12 @@ static int ion_system_contig_heap_allocate(struct ion_heap *heap,
 
        return 0;
 
-out:
+free_table:
+       kfree(table);
+free_pages:
        for (i = 0; i < len >> PAGE_SHIFT; i++)
                __free_page(page + i);
-       kfree(table);
+
        return ret;
 }
 
@@ -443,4 +425,3 @@ void ion_system_contig_heap_destroy(struct ion_heap *heap)
 {
        kfree(heap);
 }
-