import 8.41.0 source

[pve-eslint.git] / eslint / lib / rules / no-new-func.js

diff --git a/eslint/lib/rules/no-new-func.js b/eslint/lib/rules/no-new-func.js
index 9af4e31cabf6d44fe55905bcaa1a7ac129270095..d58b2d715472d1582385d084d3c2a5ad0d058034 100644 (file)
--- a/eslint/lib/rules/no-new-func.js
+++ b/eslint/lib/rules/no-new-func.js
@@ -5,19 +5,31 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("./utils/ast-utils");
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+const callMethods = new Set(["apply", "bind", "call"]);
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
+/** @type {import('../shared/types').Rule} */
 module.exports = {
     meta: {
         type: "suggestion",
 
         docs: {
-            description: "disallow `new` operators with the `Function` object",
-            category: "Best Practices",
+            description: "Disallow `new` operators with the `Function` object",
             recommended: false,
-            url: "https://eslint.org/docs/rules/no-new-func"
+            url: "https://eslint.org/docs/latest/rules/no-new-func"
         },
 
         schema: [],
@@ -28,24 +40,41 @@ module.exports = {
     },
 
     create(context) {
+        const sourceCode = context.sourceCode;
 
         return {
-            "Program:exit"() {
-                const globalScope = context.getScope();
+            "Program:exit"(node) {
+                const globalScope = sourceCode.getScope(node);
                 const variable = globalScope.set.get("Function");
 
                 if (variable && variable.defs.length === 0) {
                     variable.references.forEach(ref => {
-                        const node = ref.identifier;
-                        const { parent } = node;
-
-                        if (
-                            parent &&
-                            (parent.type === "NewExpression" || parent.type === "CallExpression") &&
-                            node === parent.callee
-                        ) {
+                        const idNode = ref.identifier;
+                        const { parent } = idNode;
+                        let evalNode;
+
+                        if (parent) {
+                            if (idNode === parent.callee && (
+                                parent.type === "NewExpression" ||
+                                parent.type === "CallExpression"
+                            )) {
+                                evalNode = parent;
+                            } else if (
+                                parent.type === "MemberExpression" &&
+                                idNode === parent.object &&
+                                callMethods.has(astUtils.getStaticPropertyName(parent))
+                            ) {
+                                const maybeCallee = parent.parent.type === "ChainExpression" ? parent.parent : parent;
+
+                                if (maybeCallee.parent.type === "CallExpression" && maybeCallee.parent.callee === maybeCallee) {
+                                    evalNode = maybeCallee.parent;
+                                }
+                            }
+                        }
+
+                        if (evalNode) {
                             context.report({
-                                node: parent,
+                                node: evalNode,
                                 messageId: "noFunctionConstructor"
                             });
                         }