]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/blobdiff - fs/f2fs/node.c
f2fs: replace rw semaphore extent_tree_lock with mutex lock
[mirror_ubuntu-artful-kernel.git] / fs / f2fs / node.c
index b9078fdb37437bff3e6e46ca4f72f4680cb9109f..8ebc4c78e6a4882b95304eaecaf433af56e431fb 100644 (file)
@@ -245,12 +245,24 @@ bool need_inode_block_update(struct f2fs_sb_info *sbi, nid_t ino)
        return need_update;
 }
 
-static struct nat_entry *grab_nat_entry(struct f2fs_nm_info *nm_i, nid_t nid)
+static struct nat_entry *grab_nat_entry(struct f2fs_nm_info *nm_i, nid_t nid,
+                                                               bool no_fail)
 {
        struct nat_entry *new;
 
-       new = f2fs_kmem_cache_alloc(nat_entry_slab, GFP_NOFS);
-       f2fs_radix_tree_insert(&nm_i->nat_root, nid, new);
+       if (no_fail) {
+               new = f2fs_kmem_cache_alloc(nat_entry_slab, GFP_NOFS);
+               f2fs_radix_tree_insert(&nm_i->nat_root, nid, new);
+       } else {
+               new = kmem_cache_alloc(nat_entry_slab, GFP_NOFS);
+               if (!new)
+                       return NULL;
+               if (radix_tree_insert(&nm_i->nat_root, nid, new)) {
+                       kmem_cache_free(nat_entry_slab, new);
+                       return NULL;
+               }
+       }
+
        memset(new, 0, sizeof(struct nat_entry));
        nat_set_nid(new, nid);
        nat_reset_flag(new);
@@ -267,8 +279,9 @@ static void cache_nat_entry(struct f2fs_sb_info *sbi, nid_t nid,
 
        e = __lookup_nat_cache(nm_i, nid);
        if (!e) {
-               e = grab_nat_entry(nm_i, nid);
-               node_info_from_raw_nat(&e->ni, ne);
+               e = grab_nat_entry(nm_i, nid, false);
+               if (e)
+                       node_info_from_raw_nat(&e->ni, ne);
        } else {
                f2fs_bug_on(sbi, nat_get_ino(e) != le32_to_cpu(ne->ino) ||
                                nat_get_blkaddr(e) !=
@@ -286,7 +299,7 @@ static void set_node_addr(struct f2fs_sb_info *sbi, struct node_info *ni,
        down_write(&nm_i->nat_tree_lock);
        e = __lookup_nat_cache(nm_i, ni->nid);
        if (!e) {
-               e = grab_nat_entry(nm_i, ni->nid);
+               e = grab_nat_entry(nm_i, ni->nid, true);
                copy_node_info(&e->ni, ni);
                f2fs_bug_on(sbi, ni->blk_addr == NEW_ADDR);
        } else if (new_blkaddr == NEW_ADDR) {
@@ -958,9 +971,6 @@ int truncate_xattr_node(struct inode *inode, struct page *page)
 
        f2fs_i_xnid_write(inode, 0);
 
-       /* need to do checkpoint during fsync */
-       F2FS_I(inode)->xattr_ver = cur_cp_version(F2FS_CKPT(sbi));
-
        set_new_dnode(&dn, inode, page, npage, nid);
 
        if (page)
@@ -1018,7 +1028,7 @@ struct page *new_node_page(struct dnode_of_data *dn,
                                unsigned int ofs, struct page *ipage)
 {
        struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
-       struct node_info old_ni, new_ni;
+       struct node_info new_ni;
        struct page *page;
        int err;
 
@@ -1033,13 +1043,15 @@ struct page *new_node_page(struct dnode_of_data *dn,
                err = -ENOSPC;
                goto fail;
        }
-
-       get_node_info(sbi, dn->nid, &old_ni);
-
-       /* Reinitialize old_ni with new node page */
-       f2fs_bug_on(sbi, old_ni.blk_addr != NULL_ADDR);
-       new_ni = old_ni;
+#ifdef CONFIG_F2FS_CHECK_FS
+       get_node_info(sbi, dn->nid, &new_ni);
+       f2fs_bug_on(sbi, new_ni.blk_addr != NULL_ADDR);
+#endif
+       new_ni.nid = dn->nid;
        new_ni.ino = dn->inode->i_ino;
+       new_ni.blk_addr = NULL_ADDR;
+       new_ni.flag = 0;
+       new_ni.version = 0;
        set_node_addr(sbi, &new_ni, NEW_ADDR, false);
 
        f2fs_wait_on_page_writeback(page, NODE, true);
@@ -1305,16 +1317,99 @@ continue_unlock:
        return last_page;
 }
 
+static int __write_node_page(struct page *page, bool atomic, bool *submitted,
+                               struct writeback_control *wbc)
+{
+       struct f2fs_sb_info *sbi = F2FS_P_SB(page);
+       nid_t nid;
+       struct node_info ni;
+       struct f2fs_io_info fio = {
+               .sbi = sbi,
+               .type = NODE,
+               .op = REQ_OP_WRITE,
+               .op_flags = wbc_to_write_flags(wbc),
+               .page = page,
+               .encrypted_page = NULL,
+               .submitted = false,
+       };
+
+       trace_f2fs_writepage(page, NODE);
+
+       if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
+               goto redirty_out;
+       if (unlikely(f2fs_cp_error(sbi)))
+               goto redirty_out;
+
+       /* get old block addr of this node page */
+       nid = nid_of_node(page);
+       f2fs_bug_on(sbi, page->index != nid);
+
+       if (wbc->for_reclaim) {
+               if (!down_read_trylock(&sbi->node_write))
+                       goto redirty_out;
+       } else {
+               down_read(&sbi->node_write);
+       }
+
+       get_node_info(sbi, nid, &ni);
+
+       /* This page is already truncated */
+       if (unlikely(ni.blk_addr == NULL_ADDR)) {
+               ClearPageUptodate(page);
+               dec_page_count(sbi, F2FS_DIRTY_NODES);
+               up_read(&sbi->node_write);
+               unlock_page(page);
+               return 0;
+       }
+
+       if (atomic && !test_opt(sbi, NOBARRIER))
+               fio.op_flags |= REQ_PREFLUSH | REQ_FUA;
+
+       set_page_writeback(page);
+       fio.old_blkaddr = ni.blk_addr;
+       write_node_page(nid, &fio);
+       set_node_addr(sbi, &ni, fio.new_blkaddr, is_fsync_dnode(page));
+       dec_page_count(sbi, F2FS_DIRTY_NODES);
+       up_read(&sbi->node_write);
+
+       if (wbc->for_reclaim) {
+               f2fs_submit_merged_bio_cond(sbi, page->mapping->host, 0,
+                                               page->index, NODE, WRITE);
+               submitted = NULL;
+       }
+
+       unlock_page(page);
+
+       if (unlikely(f2fs_cp_error(sbi))) {
+               f2fs_submit_merged_bio(sbi, NODE, WRITE);
+               submitted = NULL;
+       }
+       if (submitted)
+               *submitted = fio.submitted;
+
+       return 0;
+
+redirty_out:
+       redirty_page_for_writepage(wbc, page);
+       return AOP_WRITEPAGE_ACTIVATE;
+}
+
+static int f2fs_write_node_page(struct page *page,
+                               struct writeback_control *wbc)
+{
+       return __write_node_page(page, false, NULL, wbc);
+}
+
 int fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
                        struct writeback_control *wbc, bool atomic)
 {
        pgoff_t index, end;
+       pgoff_t last_idx = ULONG_MAX;
        struct pagevec pvec;
        int ret = 0;
        struct page *last_page = NULL;
        bool marked = false;
        nid_t ino = inode->i_ino;
-       int nwritten = 0;
 
        if (atomic) {
                last_page = last_fsync_dnode(sbi, ino);
@@ -1336,6 +1431,7 @@ retry:
 
                for (i = 0; i < nr_pages; i++) {
                        struct page *page = pvec.pages[i];
+                       bool submitted = false;
 
                        if (unlikely(f2fs_cp_error(sbi))) {
                                f2fs_put_page(last_page, 0);
@@ -1384,13 +1480,15 @@ continue_unlock:
                        if (!clear_page_dirty_for_io(page))
                                goto continue_unlock;
 
-                       ret = NODE_MAPPING(sbi)->a_ops->writepage(page, wbc);
+                       ret = __write_node_page(page, atomic &&
+                                               page == last_page,
+                                               &submitted, wbc);
                        if (ret) {
                                unlock_page(page);
                                f2fs_put_page(last_page, 0);
                                break;
-                       } else {
-                               nwritten++;
+                       } else if (submitted) {
+                               last_idx = page->index;
                        }
 
                        if (page == last_page) {
@@ -1416,8 +1514,9 @@ continue_unlock:
                goto retry;
        }
 out:
-       if (nwritten)
-               f2fs_submit_merged_bio_cond(sbi, NULL, NULL, ino, NODE, WRITE);
+       if (last_idx != ULONG_MAX)
+               f2fs_submit_merged_bio_cond(sbi, NULL, ino, last_idx,
+                                                       NODE, WRITE);
        return ret ? -EIO: 0;
 }
 
@@ -1445,6 +1544,7 @@ next_step:
 
                for (i = 0; i < nr_pages; i++) {
                        struct page *page = pvec.pages[i];
+                       bool submitted = false;
 
                        if (unlikely(f2fs_cp_error(sbi))) {
                                pagevec_release(&pvec);
@@ -1498,9 +1598,10 @@ continue_unlock:
                        set_fsync_mark(page, 0);
                        set_dentry_mark(page, 0);
 
-                       if (NODE_MAPPING(sbi)->a_ops->writepage(page, wbc))
+                       ret = __write_node_page(page, false, &submitted, wbc);
+                       if (ret)
                                unlock_page(page);
-                       else
+                       else if (submitted)
                                nwritten++;
 
                        if (--wbc->nr_to_write == 0)
@@ -1564,72 +1665,6 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
        return ret;
 }
 
-static int f2fs_write_node_page(struct page *page,
-                               struct writeback_control *wbc)
-{
-       struct f2fs_sb_info *sbi = F2FS_P_SB(page);
-       nid_t nid;
-       struct node_info ni;
-       struct f2fs_io_info fio = {
-               .sbi = sbi,
-               .type = NODE,
-               .op = REQ_OP_WRITE,
-               .op_flags = wbc_to_write_flags(wbc),
-               .page = page,
-               .encrypted_page = NULL,
-       };
-
-       trace_f2fs_writepage(page, NODE);
-
-       if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
-               goto redirty_out;
-       if (unlikely(f2fs_cp_error(sbi)))
-               goto redirty_out;
-
-       /* get old block addr of this node page */
-       nid = nid_of_node(page);
-       f2fs_bug_on(sbi, page->index != nid);
-
-       if (wbc->for_reclaim) {
-               if (!down_read_trylock(&sbi->node_write))
-                       goto redirty_out;
-       } else {
-               down_read(&sbi->node_write);
-       }
-
-       get_node_info(sbi, nid, &ni);
-
-       /* This page is already truncated */
-       if (unlikely(ni.blk_addr == NULL_ADDR)) {
-               ClearPageUptodate(page);
-               dec_page_count(sbi, F2FS_DIRTY_NODES);
-               up_read(&sbi->node_write);
-               unlock_page(page);
-               return 0;
-       }
-
-       set_page_writeback(page);
-       fio.old_blkaddr = ni.blk_addr;
-       write_node_page(nid, &fio);
-       set_node_addr(sbi, &ni, fio.new_blkaddr, is_fsync_dnode(page));
-       dec_page_count(sbi, F2FS_DIRTY_NODES);
-       up_read(&sbi->node_write);
-
-       if (wbc->for_reclaim)
-               f2fs_submit_merged_bio_cond(sbi, NULL, page, 0, NODE, WRITE);
-
-       unlock_page(page);
-
-       if (unlikely(f2fs_cp_error(sbi)))
-               f2fs_submit_merged_bio(sbi, NODE, WRITE);
-
-       return 0;
-
-redirty_out:
-       redirty_page_for_writepage(wbc, page);
-       return AOP_WRITEPAGE_ACTIVATE;
-}
-
 static int f2fs_write_node_pages(struct address_space *mapping,
                            struct writeback_control *wbc)
 {
@@ -2018,18 +2053,18 @@ update_inode:
        f2fs_put_page(ipage, 1);
 }
 
-void recover_xattr_data(struct inode *inode, struct page *page, block_t blkaddr)
+int recover_xattr_data(struct inode *inode, struct page *page, block_t blkaddr)
 {
        struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
        nid_t prev_xnid = F2FS_I(inode)->i_xattr_nid;
        nid_t new_xnid = nid_of_node(page);
        struct node_info ni;
+       struct page *xpage;
 
-       /* 1: invalidate the previous xattr nid */
        if (!prev_xnid)
                goto recover_xnid;
 
-       /* Deallocate node address */
+       /* 1: invalidate the previous xattr nid */
        get_node_info(sbi, prev_xnid, &ni);
        f2fs_bug_on(sbi, ni.blk_addr == NULL_ADDR);
        invalidate_blocks(sbi, ni.blk_addr);
@@ -2037,19 +2072,27 @@ void recover_xattr_data(struct inode *inode, struct page *page, block_t blkaddr)
        set_node_addr(sbi, &ni, NULL_ADDR, false);
 
 recover_xnid:
-       /* 2: allocate new xattr nid */
+       /* 2: update xattr nid in inode */
+       remove_free_nid(sbi, new_xnid);
+       f2fs_i_xnid_write(inode, new_xnid);
        if (unlikely(!inc_valid_node_count(sbi, inode)))
                f2fs_bug_on(sbi, 1);
+       update_inode_page(inode);
+
+       /* 3: update and set xattr node page dirty */
+       xpage = grab_cache_page(NODE_MAPPING(sbi), new_xnid);
+       if (!xpage)
+               return -ENOMEM;
+
+       memcpy(F2FS_NODE(xpage), F2FS_NODE(page), PAGE_SIZE);
 
-       remove_free_nid(sbi, new_xnid);
        get_node_info(sbi, new_xnid, &ni);
        ni.ino = inode->i_ino;
        set_node_addr(sbi, &ni, NEW_ADDR, false);
-       f2fs_i_xnid_write(inode, new_xnid);
+       set_page_dirty(xpage);
+       f2fs_put_page(xpage, 1);
 
-       /* 3: update xattr blkaddr */
-       refresh_sit_entry(sbi, NEW_ADDR, blkaddr);
-       set_node_addr(sbi, &ni, blkaddr, false);
+       return 0;
 }
 
 int recover_inode_page(struct f2fs_sb_info *sbi, struct page *page)
@@ -2152,7 +2195,7 @@ static void remove_nats_in_journal(struct f2fs_sb_info *sbi)
 
                ne = __lookup_nat_cache(nm_i, nid);
                if (!ne) {
-                       ne = grab_nat_entry(nm_i, nid);
+                       ne = grab_nat_entry(nm_i, nid, true);
                        node_info_from_raw_nat(&ne->ni, &raw_ne);
                }
 
@@ -2350,6 +2393,14 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
                                        GFP_KERNEL);
        if (!nm_i->nat_bitmap)
                return -ENOMEM;
+
+#ifdef CONFIG_F2FS_CHECK_FS
+       nm_i->nat_bitmap_mir = kmemdup(version_bitmap, nm_i->bitmap_size,
+                                       GFP_KERNEL);
+       if (!nm_i->nat_bitmap_mir)
+               return -ENOMEM;
+#endif
+
        return 0;
 }
 
@@ -2424,6 +2475,9 @@ void destroy_node_manager(struct f2fs_sb_info *sbi)
        up_write(&nm_i->nat_tree_lock);
 
        kfree(nm_i->nat_bitmap);
+#ifdef CONFIG_F2FS_CHECK_FS
+       kfree(nm_i->nat_bitmap_mir);
+#endif
        sbi->nm_info = NULL;
        kfree(nm_i);
 }