#include "qemu/error-report.h"
#include "qemu/option.h"
-static QTAILQ_HEAD(FsDriverEntry_head, FsDriverListEntry) fsdriver_entries =
+/*
+ * A table to store the various file systems and their callback operations.
+ * -----------------
+ * fstype | ops
+ * -----------------
+ * local | local_ops
+ * . |
+ * . |
+ * . |
+ * . |
+ * -----------------
+ * etc
+ */
+typedef struct FsDriverTable {
+ const char *name;
+ FileOperations *ops;
+ const char **opts;
+} FsDriverTable;
+
+typedef struct FsDriverListEntry {
+ FsDriverEntry fse;
+ QTAILQ_ENTRY(FsDriverListEntry) next;
+} FsDriverListEntry;
+
+static QTAILQ_HEAD(, FsDriverListEntry) fsdriver_entries =
QTAILQ_HEAD_INITIALIZER(fsdriver_entries);
+#define COMMON_FS_DRIVER_OPTIONS "id", "fsdriver", "readonly"
+
static FsDriverTable FsDrivers[] = {
- { .name = "local", .ops = &local_ops},
-#ifdef CONFIG_OPEN_BY_HANDLE
- { .name = "handle", .ops = &handle_ops},
-#endif
- { .name = "synth", .ops = &synth_ops},
- { .name = "proxy", .ops = &proxy_ops},
+ {
+ .name = "local",
+ .ops = &local_ops,
+ .opts = (const char * []) {
+ COMMON_FS_DRIVER_OPTIONS,
+ "security_model",
+ "path",
+ "writeout",
+ "fmode",
+ "dmode",
+ "multidevs",
+ "throttling.bps-total",
+ "throttling.bps-read",
+ "throttling.bps-write",
+ "throttling.iops-total",
+ "throttling.iops-read",
+ "throttling.iops-write",
+ "throttling.bps-total-max",
+ "throttling.bps-read-max",
+ "throttling.bps-write-max",
+ "throttling.iops-total-max",
+ "throttling.iops-read-max",
+ "throttling.iops-write-max",
+ "throttling.bps-total-max-length",
+ "throttling.bps-read-max-length",
+ "throttling.bps-write-max-length",
+ "throttling.iops-total-max-length",
+ "throttling.iops-read-max-length",
+ "throttling.iops-write-max-length",
+ "throttling.iops-size",
+ NULL
+ },
+ },
+ {
+ .name = "synth",
+ .ops = &synth_ops,
+ .opts = (const char * []) {
+ COMMON_FS_DRIVER_OPTIONS,
+ NULL
+ },
+ },
+ {
+ .name = "proxy",
+ .ops = &proxy_ops,
+ .opts = (const char * []) {
+ COMMON_FS_DRIVER_OPTIONS,
+ "socket",
+ "sock_fd",
+ "writeout",
+ NULL
+ },
+ },
};
-int qemu_fsdev_add(QemuOpts *opts)
+static int validate_opt(void *opaque, const char *name, const char *value,
+ Error **errp)
+{
+ FsDriverTable *drv = opaque;
+ const char **opt;
+
+ for (opt = drv->opts; *opt; opt++) {
+ if (!strcmp(*opt, name)) {
+ return 0;
+ }
+ }
+
+ error_setg(errp, "'%s' is invalid for fsdriver '%s'", name, drv->name);
+ return -1;
+}
+
+int qemu_fsdev_add(QemuOpts *opts, Error **errp)
{
int i;
struct FsDriverListEntry *fsle;
const char *fsdriver = qemu_opt_get(opts, "fsdriver");
const char *writeout = qemu_opt_get(opts, "writeout");
bool ro = qemu_opt_get_bool(opts, "readonly", 0);
- Error *local_err = NULL;
if (!fsdev_id) {
- error_report("fsdev: No id specified");
+ error_setg(errp, "fsdev: No id specified");
return -1;
}
}
if (i == ARRAY_SIZE(FsDrivers)) {
- error_report("fsdev: fsdriver %s not found", fsdriver);
+ error_setg(errp, "fsdev: fsdriver %s not found", fsdriver);
return -1;
}
} else {
- error_report("fsdev: No fsdriver specified");
+ error_setg(errp, "fsdev: No fsdriver specified");
+ return -1;
+ }
+
+ if (qemu_opt_foreach(opts, validate_opt, &FsDrivers[i], errp)) {
return -1;
}
}
if (fsle->fse.ops->parse_opts) {
- if (fsle->fse.ops->parse_opts(opts, &fsle->fse, &local_err)) {
- error_report_err(local_err);
+ if (fsle->fse.ops->parse_opts(opts, &fsle->fse, errp)) {
g_free(fsle->fse.fsdev_id);
g_free(fsle);
return -1;