]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - ip/ipaddress.c
ip6/tunnel: Unify tclass printing
[mirror_iproute2.git] / ip / ipaddress.c
index f8c5029400949cb26f14df4ae56fc4ac0b5dea2a..f150d9190b768241421777760c9bd1698d30f212 100644 (file)
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <syslog.h>
 #include <inttypes.h>
 #include <fcntl.h>
 #include <sys/ioctl.h>
 #include <sys/socket.h>
-#include <sys/ioctl.h>
+#include <sys/param.h>
 #include <errno.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <linux/sockios.h>
 #include <linux/net_namespace.h>
 
+#include "utils.h"
 #include "rt_names.h"
 #include "utils.h"
 #include "ll_map.h"
 #include "ip_common.h"
+#include "xdp.h"
 #include "color.h"
 
 enum {
@@ -42,26 +43,7 @@ enum {
        IPADD_SAVE,
 };
 
-static struct
-{
-       int ifindex;
-       int family;
-       int oneline;
-       int showqueue;
-       inet_prefix pfx;
-       int scope, scopemask;
-       int flags, flagmask;
-       int up;
-       char *label;
-       int flushed;
-       char *flushb;
-       int flushp;
-       int flushe;
-       int group;
-       int master;
-       char *kind;
-} filter;
-
+static struct link_filter filter;
 static int do_link;
 
 static void usage(void) __attribute__((noreturn));
@@ -74,8 +56,11 @@ static void usage(void)
        fprintf(stderr, "Usage: ip address {add|change|replace} IFADDR dev IFNAME [ LIFETIME ]\n");
        fprintf(stderr, "                                                      [ CONFFLAG-LIST ]\n");
        fprintf(stderr, "       ip address del IFADDR dev IFNAME [mngtmpaddr]\n");
-       fprintf(stderr, "       ip address {show|save|flush} [ dev IFNAME ] [ scope SCOPE-ID ]\n");
+       fprintf(stderr, "       ip address {save|flush} [ dev IFNAME ] [ scope SCOPE-ID ]\n");
        fprintf(stderr, "                            [ to PREFIX ] [ FLAG-LIST ] [ label LABEL ] [up]\n");
+       fprintf(stderr, "       ip address [ show [ dev IFNAME ] [ scope SCOPE-ID ] [ master DEVICE ]\n");
+       fprintf(stderr, "                         [ type TYPE ] [ to PREFIX ] [ FLAG-LIST ]\n");
+       fprintf(stderr, "                         [ label LABEL ] [up] [ vrf NAME ] ]\n");
        fprintf(stderr, "       ip address {showdump|restore}\n");
        fprintf(stderr, "IFADDR := PREFIX | ADDR peer PREFIX\n");
        fprintf(stderr, "          [ broadcast ADDR ] [ anycast ADDR ]\n");
@@ -89,19 +74,25 @@ static void usage(void)
        fprintf(stderr, "CONFFLAG  := [ home | nodad | mngtmpaddr | noprefixroute | autojoin ]\n");
        fprintf(stderr, "LIFETIME := [ valid_lft LFT ] [ preferred_lft LFT ]\n");
        fprintf(stderr, "LFT := forever | SECONDS\n");
+       fprintf(stderr, "TYPE := { vlan | veth | vcan | vxcan | dummy | ifb | macvlan | macvtap |\n");
+       fprintf(stderr, "          bridge | bond | ipoib | ip6tnl | ipip | sit | vxlan | lowpan |\n");
+       fprintf(stderr, "          gre | gretap | erspan | ip6gre | ip6gretap | ip6erspan | vti |\n");
+       fprintf(stderr, "          nlmon | can | bond_slave | ipvlan | geneve | bridge_slave |\n");
+       fprintf(stderr, "          hsr | macsec\n");
 
        exit(-1);
 }
 
 static void print_link_flags(FILE *fp, unsigned int flags, unsigned int mdown)
 {
-       fprintf(fp, "<");
+       open_json_array(PRINT_ANY, is_json_context() ? "flags" : "<");
        if (flags & IFF_UP && !(flags & IFF_RUNNING))
-               fprintf(fp, "NO-CARRIER%s", flags ? "," : "");
+               print_string(PRINT_ANY, NULL,
+                            flags ? "%s," : "%s", "NO-CARRIER");
        flags &= ~IFF_RUNNING;
-#define _PF(f) if (flags&IFF_##f) { \
-                 flags &= ~IFF_##f ; \
-                 fprintf(fp, #f "%s", flags ? "," : ""); }
+#define _PF(f) if (flags&IFF_##f) {                                    \
+               flags &= ~IFF_##f ;                                     \
+               print_string(PRINT_ANY, NULL, flags ? "%s," : "%s", #f); }
        _PF(LOOPBACK);
        _PF(BROADCAST);
        _PF(POINTOPOINT);
@@ -122,10 +113,10 @@ static void print_link_flags(FILE *fp, unsigned int flags, unsigned int mdown)
        _PF(ECHO);
 #undef _PF
        if (flags)
-               fprintf(fp, "%x", flags);
+               print_hex(PRINT_ANY, NULL, "%x", flags);
        if (mdown)
-               fprintf(fp, ",M-DOWN");
-       fprintf(fp, "> ");
+               print_string(PRINT_ANY, NULL, ",%s", "M-DOWN");
+       close_json_array(PRINT_ANY, "> ");
 }
 
 static const char *oper_states[] = {
@@ -135,24 +126,26 @@ static const char *oper_states[] = {
 
 static void print_operstate(FILE *f, __u8 state)
 {
-       if (state >= ARRAY_SIZE(oper_states))
-               fprintf(f, "state %#x ", state);
-       else {
-               if (brief) {
-                       if (strcmp(oper_states[state], "UP") == 0)
-                               color_fprintf(f, COLOR_OPERSTATE_UP, "%-14s ", oper_states[state]);
-                       else if (strcmp(oper_states[state], "DOWN") == 0)
-                               color_fprintf(f, COLOR_OPERSTATE_DOWN, "%-14s ", oper_states[state]);
-                       else
-                               fprintf(f, "%-14s ", oper_states[state]);
-               } else {
+       if (state >= ARRAY_SIZE(oper_states)) {
+               if (is_json_context())
+                       print_uint(PRINT_JSON, "operstate_index", NULL, state);
+               else
+                       print_0xhex(PRINT_FP, NULL, "state %#x", state);
+       } else if (brief) {
+               print_color_string(PRINT_ANY,
+                                  oper_state_color(state),
+                                  "operstate",
+                                  "%-14s ",
+                                  oper_states[state]);
+       } else {
+               if (is_json_context())
+                       print_string(PRINT_JSON,
+                                    "operstate",
+                                    NULL, oper_states[state]);
+               else {
                        fprintf(f, "state ");
-                       if (strcmp(oper_states[state], "UP") == 0)
-                               color_fprintf(f, COLOR_OPERSTATE_UP, "%s ", oper_states[state]);
-                       else if (strcmp(oper_states[state], "DOWN") == 0)
-                               color_fprintf(f, COLOR_OPERSTATE_DOWN, "%s ", oper_states[state]);
-                       else
-                               fprintf(f, "%s ", oper_states[state]);
+                       color_fprintf(f, oper_state_color(state),
+                                     "%s ", oper_states[state]);
                }
        }
 }
@@ -172,15 +165,14 @@ static void print_queuelen(FILE *f, struct rtattr *tb[IFLA_MAX + 1])
        int qlen;
 
        if (tb[IFLA_TXQLEN])
-               qlen = *(int *)RTA_DATA(tb[IFLA_TXQLEN]);
+               qlen = rta_getattr_u32(tb[IFLA_TXQLEN]);
        else {
-               struct ifreq ifr;
+               struct ifreq ifr = {};
                int s = socket(AF_INET, SOCK_STREAM, 0);
 
                if (s < 0)
                        return;
 
-               memset(&ifr, 0, sizeof(ifr));
                strcpy(ifr.ifr_name, rta_getattr_str(tb[IFLA_IFNAME]));
                if (ioctl(s, SIOCGIFTXQLEN, &ifr) < 0) {
                        fprintf(f, "ioctl(SIOCGIFTXQLEN) failed: %s\n", strerror(errno));
@@ -191,7 +183,7 @@ static void print_queuelen(FILE *f, struct rtattr *tb[IFLA_MAX + 1])
                qlen = ifr.ifr_qlen;
        }
        if (qlen)
-               fprintf(f, "qlen %d", qlen);
+               print_int(PRINT_ANY, "txqlen", "qlen %d", qlen);
 }
 
 static const char *link_modes[] = {
@@ -203,38 +195,54 @@ static void print_linkmode(FILE *f, struct rtattr *tb)
        unsigned int mode = rta_getattr_u8(tb);
 
        if (mode >= ARRAY_SIZE(link_modes))
-               fprintf(f, "mode %d ", mode);
+               print_int(PRINT_ANY,
+                         "linkmode_index",
+                         "mode %d ",
+                         mode);
        else
-               fprintf(f, "mode %s ", link_modes[mode]);
+               print_string(PRINT_ANY,
+                            "linkmode",
+                            "mode %s "
+                            , link_modes[mode]);
 }
 
-static char *parse_link_kind(struct rtattr *tb)
+static char *parse_link_kind(struct rtattr *tb, bool slave)
 {
        struct rtattr *linkinfo[IFLA_INFO_MAX+1];
+       int attr = slave ? IFLA_INFO_SLAVE_KIND : IFLA_INFO_KIND;
 
        parse_rtattr_nested(linkinfo, IFLA_INFO_MAX, tb);
 
-       if (linkinfo[IFLA_INFO_KIND])
-               return RTA_DATA(linkinfo[IFLA_INFO_KIND]);
+       if (linkinfo[attr])
+               return RTA_DATA(linkinfo[attr]);
 
        return "";
 }
 
+static int match_link_kind(struct rtattr **tb, const char *kind, bool slave)
+{
+       if (!tb[IFLA_LINKINFO])
+               return -1;
+
+       return strcmp(parse_link_kind(tb[IFLA_LINKINFO], slave), kind);
+}
+
 static void print_linktype(FILE *fp, struct rtattr *tb)
 {
        struct rtattr *linkinfo[IFLA_INFO_MAX+1];
        struct link_util *lu;
        struct link_util *slave_lu;
-       char *kind;
-       char *slave_kind;
+       char slave[32];
 
        parse_rtattr_nested(linkinfo, IFLA_INFO_MAX, tb);
+       open_json_object("linkinfo");
 
        if (linkinfo[IFLA_INFO_KIND]) {
-               kind = RTA_DATA(linkinfo[IFLA_INFO_KIND]);
+               const char *kind
+                       = rta_getattr_str(linkinfo[IFLA_INFO_KIND]);
 
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    %s ", kind);
+               print_string(PRINT_FP, NULL, "%s", _SL_);
+               print_string(PRINT_ANY, "info_kind", "    %s ", kind);
 
                lu = get_link_kind(kind);
                if (lu && lu->print_opt) {
@@ -245,21 +253,32 @@ static void print_linktype(FILE *fp, struct rtattr *tb)
                                                    linkinfo[IFLA_INFO_DATA]);
                                data = attr;
                        }
+                       open_json_object("info_data");
                        lu->print_opt(lu, fp, data);
+                       close_json_object();
 
                        if (linkinfo[IFLA_INFO_XSTATS] && show_stats &&
-                           lu->print_xstats)
+                           lu->print_xstats) {
+                               open_json_object("info_xstats");
                                lu->print_xstats(lu, fp, linkinfo[IFLA_INFO_XSTATS]);
+                               close_json_object();
+                       }
                }
        }
 
        if (linkinfo[IFLA_INFO_SLAVE_KIND]) {
-               slave_kind = RTA_DATA(linkinfo[IFLA_INFO_SLAVE_KIND]);
+               const char *slave_kind
+                       = rta_getattr_str(linkinfo[IFLA_INFO_SLAVE_KIND]);
 
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    %s_slave ", slave_kind);
+               print_string(PRINT_FP, NULL, "%s", _SL_);
+               print_string(PRINT_ANY,
+                            "info_slave_kind",
+                            "    %s_slave ",
+                            slave_kind);
+
+               snprintf(slave, sizeof(slave), "%s_slave", slave_kind);
 
-               slave_lu = get_link_slave_kind(slave_kind);
+               slave_lu = get_link_kind(slave);
                if (slave_lu && slave_lu->print_opt) {
                        struct rtattr *attr[slave_lu->maxattr+1], **data = NULL;
 
@@ -268,9 +287,12 @@ static void print_linktype(FILE *fp, struct rtattr *tb)
                                                    linkinfo[IFLA_INFO_SLAVE_DATA]);
                                data = attr;
                        }
+                       open_json_object("info_slave_data");
                        slave_lu->print_opt(slave_lu, fp, data);
+                       close_json_object();
                }
        }
+       close_json_object();
 }
 
 static void print_af_spec(FILE *fp, struct rtattr *af_spec_attr)
@@ -286,22 +308,39 @@ static void print_af_spec(FILE *fp, struct rtattr *af_spec_attr)
 
        if (tb[IFLA_INET6_ADDR_GEN_MODE]) {
                __u8 mode = rta_getattr_u8(tb[IFLA_INET6_ADDR_GEN_MODE]);
+               SPRINT_BUF(b1);
 
                switch (mode) {
                case IN6_ADDR_GEN_MODE_EUI64:
-                       fprintf(fp, "addrgenmode eui64 ");
+                       print_string(PRINT_ANY,
+                                    "inet6_addr_gen_mode",
+                                    "addrgenmode %s ",
+                                    "eui64");
                        break;
                case IN6_ADDR_GEN_MODE_NONE:
-                       fprintf(fp, "addrgenmode none ");
+                       print_string(PRINT_ANY,
+                                    "inet6_addr_gen_mode",
+                                    "addrgenmode %s ",
+                                    "none");
                        break;
                case IN6_ADDR_GEN_MODE_STABLE_PRIVACY:
-                       fprintf(fp, "addrgenmode stable_secret ");
+                       print_string(PRINT_ANY,
+                                    "inet6_addr_gen_mode",
+                                    "addrgenmode %s ",
+                                    "stable_secret");
                        break;
                case IN6_ADDR_GEN_MODE_RANDOM:
-                       fprintf(fp, "addrgenmode random ");
+                       print_string(PRINT_ANY,
+                                    "inet6_addr_gen_mode",
+                                    "addrgenmode %s ",
+                                    "random");
                        break;
                default:
-                       fprintf(fp, "addrgenmode %#.2hhx ", mode);
+                       snprintf(b1, sizeof(b1), "%#.2hhx", mode);
+                       print_string(PRINT_ANY,
+                                    "inet6_addr_gen_mode",
+                                    "addrgenmode %s ",
+                                    b1);
                        break;
                }
        }
@@ -312,12 +351,8 @@ static void print_vf_stats64(FILE *fp, struct rtattr *vfstats);
 static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
 {
        struct ifla_vf_mac *vf_mac;
-       struct ifla_vf_vlan *vf_vlan;
        struct ifla_vf_tx_rate *vf_tx_rate;
-       struct ifla_vf_spoofchk *vf_spoofchk;
-       struct ifla_vf_link_state *vf_linkstate;
        struct rtattr *vf[IFLA_VF_MAX + 1] = {};
-       struct rtattr *tmp;
 
        SPRINT_BUF(b1);
 
@@ -329,72 +364,142 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
        parse_rtattr_nested(vf, IFLA_VF_MAX, vfinfo);
 
        vf_mac = RTA_DATA(vf[IFLA_VF_MAC]);
-       vf_vlan = RTA_DATA(vf[IFLA_VF_VLAN]);
        vf_tx_rate = RTA_DATA(vf[IFLA_VF_TX_RATE]);
 
-       /* Check if the spoof checking vf info type is supported by
-        * this kernel.
-        */
-       tmp = (struct rtattr *)((char *)vf[IFLA_VF_TX_RATE] +
-                       vf[IFLA_VF_TX_RATE]->rta_len);
-
-       if (tmp->rta_type != IFLA_VF_SPOOFCHK)
-               vf_spoofchk = NULL;
-       else
-               vf_spoofchk = RTA_DATA(vf[IFLA_VF_SPOOFCHK]);
+       print_string(PRINT_FP, NULL, "%s    ", _SL_);
+       print_int(PRINT_ANY, "vf", "vf %d ", vf_mac->vf);
+       print_string(PRINT_ANY, "mac", "MAC %s",
+                    ll_addr_n2a((unsigned char *) &vf_mac->mac,
+                                ETH_ALEN, 0, b1, sizeof(b1)));
+
+       if (vf[IFLA_VF_VLAN_LIST]) {
+               struct rtattr *i, *vfvlanlist = vf[IFLA_VF_VLAN_LIST];
+               int rem = RTA_PAYLOAD(vfvlanlist);
+
+               open_json_array(PRINT_JSON, "vlan_list");
+               for (i = RTA_DATA(vfvlanlist);
+                    RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
+                       struct ifla_vf_vlan_info *vf_vlan_info = RTA_DATA(i);
+                       SPRINT_BUF(b2);
+
+                       open_json_object(NULL);
+                       if (vf_vlan_info->vlan)
+                               print_int(PRINT_ANY,
+                                         "vlan",
+                                         ", vlan %d",
+                                         vf_vlan_info->vlan);
+                       if (vf_vlan_info->qos)
+                               print_int(PRINT_ANY,
+                                         "qos",
+                                         ", qos %d",
+                                         vf_vlan_info->qos);
+                       if (vf_vlan_info->vlan_proto &&
+                           vf_vlan_info->vlan_proto != htons(ETH_P_8021Q))
+                               print_string(PRINT_ANY,
+                                            "protocol",
+                                            ", vlan protocol %s",
+                                            ll_proto_n2a(
+                                                    vf_vlan_info->vlan_proto,
+                                                    b2, sizeof(b2)));
+                       close_json_object();
+               }
+               close_json_array(PRINT_JSON, NULL);
+       } else {
+               struct ifla_vf_vlan *vf_vlan = RTA_DATA(vf[IFLA_VF_VLAN]);
 
-       if (vf_spoofchk) {
-               /* Check if the link state vf info type is supported by
-                * this kernel.
-                */
-               tmp = (struct rtattr *)((char *)vf[IFLA_VF_SPOOFCHK] +
-                               vf[IFLA_VF_SPOOFCHK]->rta_len);
+               if (vf_vlan->vlan)
+                       print_int(PRINT_ANY,
+                                 "vlan",
+                                 ", vlan %d",
+                                 vf_vlan->vlan);
+               if (vf_vlan->qos)
+                       print_int(PRINT_ANY, "qos", ", qos %d", vf_vlan->qos);
+       }
 
-               if (tmp->rta_type != IFLA_VF_LINK_STATE)
-                       vf_linkstate = NULL;
-               else
-                       vf_linkstate = RTA_DATA(vf[IFLA_VF_LINK_STATE]);
-       } else
-               vf_linkstate = NULL;
-
-       fprintf(fp, "%s    vf %d MAC %s", _SL_, vf_mac->vf,
-               ll_addr_n2a((unsigned char *)&vf_mac->mac,
-               ETH_ALEN, 0, b1, sizeof(b1)));
-       if (vf_vlan->vlan)
-               fprintf(fp, ", vlan %d", vf_vlan->vlan);
-       if (vf_vlan->qos)
-               fprintf(fp, ", qos %d", vf_vlan->qos);
        if (vf_tx_rate->rate)
-               fprintf(fp, ", tx rate %d (Mbps)", vf_tx_rate->rate);
+               print_int(PRINT_ANY,
+                         "tx_rate",
+                         ", tx rate %d (Mbps)",
+                         vf_tx_rate->rate);
 
        if (vf[IFLA_VF_RATE]) {
                struct ifla_vf_rate *vf_rate = RTA_DATA(vf[IFLA_VF_RATE]);
-
-               if (vf_rate->max_tx_rate)
-                       fprintf(fp, ", max_tx_rate %dMbps", vf_rate->max_tx_rate);
-               if (vf_rate->min_tx_rate)
-                       fprintf(fp, ", min_tx_rate %dMbps", vf_rate->min_tx_rate);
+               int max_tx = vf_rate->max_tx_rate;
+               int min_tx = vf_rate->min_tx_rate;
+
+               if (is_json_context()) {
+                       open_json_object("rate");
+                       print_int(PRINT_JSON, "max_tx", NULL, max_tx);
+                       print_int(PRINT_ANY, "min_tx", NULL, min_tx);
+                       close_json_object();
+               } else {
+                       if (max_tx)
+                               fprintf(fp, ", max_tx_rate %dMbps", max_tx);
+                       if (min_tx)
+                               fprintf(fp, ", min_tx_rate %dMbps", min_tx);
+               }
        }
 
-       if (vf_spoofchk && vf_spoofchk->setting != -1) {
-               if (vf_spoofchk->setting)
-                       fprintf(fp, ", spoof checking on");
-               else
-                       fprintf(fp, ", spoof checking off");
+       if (vf[IFLA_VF_SPOOFCHK]) {
+               struct ifla_vf_spoofchk *vf_spoofchk =
+                       RTA_DATA(vf[IFLA_VF_SPOOFCHK]);
+
+               if (vf_spoofchk->setting != -1)
+                       print_bool(PRINT_ANY,
+                                  "spoofchk",
+                                  vf_spoofchk->setting ?
+                                  ", spoof checking on" : ", spoof checking off",
+                                  vf_spoofchk->setting);
        }
-       if (vf_linkstate) {
+
+       if (vf[IFLA_VF_LINK_STATE]) {
+               struct ifla_vf_link_state *vf_linkstate =
+                       RTA_DATA(vf[IFLA_VF_LINK_STATE]);
+
                if (vf_linkstate->link_state == IFLA_VF_LINK_STATE_AUTO)
-                       fprintf(fp, ", link-state auto");
+                       print_string(PRINT_ANY,
+                                    "link_state",
+                                    ", link-state %s",
+                                    "auto");
                else if (vf_linkstate->link_state == IFLA_VF_LINK_STATE_ENABLE)
-                       fprintf(fp, ", link-state enable");
+                       print_string(PRINT_ANY,
+                                    "link_state",
+                                    ", link-state %s",
+                                    "enable");
                else
-                       fprintf(fp, ", link-state disable");
+                       print_string(PRINT_ANY,
+                                    "link_state",
+                                    ", link-state %s",
+                                    "disable");
        }
+
+       if (vf[IFLA_VF_TRUST]) {
+               struct ifla_vf_trust *vf_trust = RTA_DATA(vf[IFLA_VF_TRUST]);
+
+               if (vf_trust->setting != -1)
+                       print_bool(PRINT_ANY,
+                                  "trust",
+                                  vf_trust->setting ? ", trust on" : ", trust off",
+                                  vf_trust->setting);
+       }
+
+       if (vf[IFLA_VF_RSS_QUERY_EN]) {
+               struct ifla_vf_rss_query_en *rss_query =
+                       RTA_DATA(vf[IFLA_VF_RSS_QUERY_EN]);
+
+               if (rss_query->setting != -1)
+                       print_bool(PRINT_ANY,
+                                  "query_rss_en",
+                                  rss_query->setting ? ", query_rss on"
+                                  : ", query_rss off",
+                                  rss_query->setting);
+       }
+
        if (vf[IFLA_VF_STATS] && show_stats)
                print_vf_stats64(fp, vf[IFLA_VF_STATS]);
 }
 
-static void print_num(FILE *fp, unsigned int width, uint64_t count)
+void print_num(FILE *fp, unsigned int width, uint64_t count)
 {
        const char *prefix = "kMGTPE";
        const unsigned int base = use_iec ? 1024 : 1000;
@@ -409,7 +514,8 @@ static void print_num(FILE *fp, unsigned int width, uint64_t count)
        }
 
        /* increase value by a factor of 1000/1024 and print
-        * if result is something a human can read */
+        * if result is something a human can read
+        */
        for (;;) {
                powi *= base;
                if (count / base < powi)
@@ -428,14 +534,14 @@ static void print_num(FILE *fp, unsigned int width, uint64_t count)
        }
 
        snprintf(buf, sizeof(buf), "%.*f%c%s", precision,
-               (double) count / powi, *prefix, use_iec ? "i" : "");
+                (double) count / powi, *prefix, use_iec ? "i" : "");
 
        fprintf(fp, "%-*s ", width, buf);
 }
 
 static void print_vf_stats64(FILE *fp, struct rtattr *vfstats)
 {
-       struct rtattr *vf[IFLA_VF_STATS_MAX + 1] = {};
+       struct rtattr *vf[IFLA_VF_STATS_MAX + 1];
 
        if (vfstats->rta_type != IFLA_VF_STATS) {
                fprintf(stderr, "BUG: rta type is %d\n", vfstats->rta_type);
@@ -444,155 +550,339 @@ static void print_vf_stats64(FILE *fp, struct rtattr *vfstats)
 
        parse_rtattr_nested(vf, IFLA_VF_MAX, vfstats);
 
-       /* RX stats */
-       fprintf(fp, "%s", _SL_);
-       fprintf(fp, "    RX: bytes  packets  mcast   bcast %s", _SL_);
-       fprintf(fp, "    ");
+       if (is_json_context()) {
+               open_json_object("stats");
+
+               /* RX stats */
+               open_json_object("rx");
+               print_uint(PRINT_JSON, "bytes", NULL,
+                          rta_getattr_u64(vf[IFLA_VF_STATS_RX_BYTES]));
+               print_uint(PRINT_JSON, "packets", NULL,
+                          rta_getattr_u64(vf[IFLA_VF_STATS_RX_PACKETS]));
+               print_uint(PRINT_JSON, "multicast", NULL,
+                          rta_getattr_u64(vf[IFLA_VF_STATS_MULTICAST]));
+               print_uint(PRINT_JSON, "broadcast", NULL,
+                          rta_getattr_u64(vf[IFLA_VF_STATS_BROADCAST]));
+               close_json_object();
+
+               /* TX stats */
+               open_json_object("tx");
+               print_uint(PRINT_JSON, "tx_bytes", NULL,
+                          rta_getattr_u64(vf[IFLA_VF_STATS_TX_BYTES]));
+               print_uint(PRINT_JSON, "tx_packets", NULL,
+                          rta_getattr_u64(vf[IFLA_VF_STATS_TX_PACKETS]));
+               close_json_object();
+               close_json_object();
+       } else {
+               /* RX stats */
+               fprintf(fp, "%s", _SL_);
+               fprintf(fp, "    RX: bytes  packets  mcast   bcast %s", _SL_);
+               fprintf(fp, "    ");
 
-       print_num(fp, 10, *(__u64 *)RTA_DATA(vf[IFLA_VF_STATS_RX_BYTES]));
-       print_num(fp, 8, *(__u64 *)RTA_DATA(vf[IFLA_VF_STATS_RX_PACKETS]));
-       print_num(fp, 7, *(__u64 *)RTA_DATA(vf[IFLA_VF_STATS_MULTICAST]));
-       print_num(fp, 7, *(__u64 *)RTA_DATA(vf[IFLA_VF_STATS_BROADCAST]));
+               print_num(fp, 10, rta_getattr_u64(vf[IFLA_VF_STATS_RX_BYTES]));
+               print_num(fp, 8, rta_getattr_u64(vf[IFLA_VF_STATS_RX_PACKETS]));
+               print_num(fp, 7, rta_getattr_u64(vf[IFLA_VF_STATS_MULTICAST]));
+               print_num(fp, 7, rta_getattr_u64(vf[IFLA_VF_STATS_BROADCAST]));
 
-       /* TX stats */
-       fprintf(fp, "%s", _SL_);
-       fprintf(fp, "    TX: bytes  packets %s", _SL_);
-       fprintf(fp, "    ");
+               /* TX stats */
+               fprintf(fp, "%s", _SL_);
+               fprintf(fp, "    TX: bytes  packets %s", _SL_);
+               fprintf(fp, "    ");
 
-       print_num(fp, 10, *(__u64 *)RTA_DATA(vf[IFLA_VF_STATS_TX_BYTES]));
-       print_num(fp, 8, *(__u64 *)RTA_DATA(vf[IFLA_VF_STATS_TX_PACKETS]));
+               print_num(fp, 10, rta_getattr_u64(vf[IFLA_VF_STATS_TX_BYTES]));
+               print_num(fp, 8, rta_getattr_u64(vf[IFLA_VF_STATS_TX_PACKETS]));
+       }
 }
 
 static void print_link_stats64(FILE *fp, const struct rtnl_link_stats64 *s,
                               const struct rtattr *carrier_changes)
 {
-       /* RX stats */
-       fprintf(fp, "    RX: bytes  packets  errors  dropped overrun mcast   %s%s",
-               s->rx_compressed ? "compressed" : "", _SL_);
-
-       fprintf(fp, "    ");
-       print_num(fp, 10, s->rx_bytes);
-       print_num(fp, 8, s->rx_packets);
-       print_num(fp, 7, s->rx_errors);
-       print_num(fp, 7, s->rx_dropped);
-       print_num(fp, 7, s->rx_over_errors);
-       print_num(fp, 7, s->multicast);
-       if (s->rx_compressed)
-               print_num(fp, 7, s->rx_compressed);
-
-       /* RX error stats */
-       if (show_stats > 1) {
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    RX errors: length   crc     frame   fifo    missed%s%s",
-                       s->rx_nohandler ? "   nohandler" : "",  _SL_);
-
-               fprintf(fp, "               ");
-               print_num(fp, 8, s->rx_length_errors);
-               print_num(fp, 7, s->rx_crc_errors);
-               print_num(fp, 7, s->rx_frame_errors);
-               print_num(fp, 7, s->rx_fifo_errors);
-               print_num(fp, 7, s->rx_missed_errors);
-               if (s->rx_nohandler)
-                       print_num(fp, 7, s->rx_nohandler);
+       if (is_json_context()) {
+               open_json_object("stats644");
+
+               /* RX stats */
+               open_json_object("rx");
+               print_uint(PRINT_JSON, "bytes", NULL, s->rx_bytes);
+               print_uint(PRINT_JSON, "packets", NULL, s->rx_packets);
+               print_uint(PRINT_JSON, "errors", NULL, s->rx_errors);
+               print_uint(PRINT_JSON, "dropped", NULL, s->rx_dropped);
+               print_uint(PRINT_JSON, "over_errors", NULL, s->rx_over_errors);
+               print_uint(PRINT_JSON, "multicast", NULL, s->multicast);
+               if (s->rx_compressed)
+                       print_uint(PRINT_JSON,
+                                  "compressed",
+                                  NULL, s->rx_compressed);
+
+               /* RX error stats */
+               if (show_stats > 1) {
+                       print_uint(PRINT_JSON,
+                                  "length_errors",
+                                  NULL, s->rx_length_errors);
+                       print_uint(PRINT_JSON,
+                                  "crc_errors",
+                                  NULL, s->rx_crc_errors);
+                       print_uint(PRINT_JSON,
+                                  "frame_errors",
+                                  NULL, s->rx_frame_errors);
+                       print_uint(PRINT_JSON,
+                                  "fifo_errors",
+                                  NULL, s->rx_fifo_errors);
+                       print_uint(PRINT_JSON,
+                                  "missed_errors",
+                                  NULL, s->rx_missed_errors);
+                       if (s->rx_nohandler)
+                               print_uint(PRINT_JSON,
+                                          "nohandler", NULL, s->rx_nohandler);
+               }
+               close_json_object();
+
+               /* TX stats */
+               open_json_object("tx");
+               print_uint(PRINT_JSON, "bytes", NULL, s->tx_bytes);
+               print_uint(PRINT_JSON, "packets", NULL, s->tx_packets);
+               print_uint(PRINT_JSON, "errors", NULL, s->tx_errors);
+               print_uint(PRINT_JSON, "dropped", NULL, s->tx_dropped);
+               print_uint(PRINT_JSON,
+                          "carrier_errors",
+                          NULL, s->tx_carrier_errors);
+               print_uint(PRINT_JSON, "collisions", NULL, s->collisions);
+               if (s->tx_compressed)
+                       print_uint(PRINT_JSON,
+                                  "compressed",
+                                  NULL, s->tx_compressed);
+
+               /* TX error stats */
+               if (show_stats > 1) {
+                       print_uint(PRINT_JSON,
+                                  "aborted_errors",
+                                  NULL, s->tx_aborted_errors);
+                       print_uint(PRINT_JSON,
+                                  "fifo_errors",
+                                  NULL, s->tx_fifo_errors);
+                       print_uint(PRINT_JSON,
+                                  "window_errors",
+                                  NULL, s->tx_window_errors);
+                       print_uint(PRINT_JSON,
+                                  "heartbeat_errors",
+                                  NULL, s->tx_heartbeat_errors);
+                       if (carrier_changes)
+                               print_uint(PRINT_JSON, "carrier_changes", NULL,
+                                          rta_getattr_u32(carrier_changes));
+               }
+               close_json_object();
+               close_json_object();
 
-       }
-       fprintf(fp, "%s", _SL_);
+       } else {
+               /* RX stats */
+               fprintf(fp, "    RX: bytes  packets  errors  dropped overrun mcast   %s%s",
+                       s->rx_compressed ? "compressed" : "", _SL_);
+
+               fprintf(fp, "    ");
+               print_num(fp, 10, s->rx_bytes);
+               print_num(fp, 8, s->rx_packets);
+               print_num(fp, 7, s->rx_errors);
+               print_num(fp, 7, s->rx_dropped);
+               print_num(fp, 7, s->rx_over_errors);
+               print_num(fp, 7, s->multicast);
+               if (s->rx_compressed)
+                       print_num(fp, 7, s->rx_compressed);
+
+               /* RX error stats */
+               if (show_stats > 1) {
+                       fprintf(fp, "%s", _SL_);
+                       fprintf(fp, "    RX errors: length   crc     frame   fifo    missed%s%s",
+                               s->rx_nohandler ? "   nohandler" : "", _SL_);
+
+                       fprintf(fp, "               ");
+                       print_num(fp, 8, s->rx_length_errors);
+                       print_num(fp, 7, s->rx_crc_errors);
+                       print_num(fp, 7, s->rx_frame_errors);
+                       print_num(fp, 7, s->rx_fifo_errors);
+                       print_num(fp, 7, s->rx_missed_errors);
+                       if (s->rx_nohandler)
+                               print_num(fp, 7, s->rx_nohandler);
 
-       /* TX stats */
-       fprintf(fp, "    TX: bytes  packets  errors  dropped carrier collsns %s%s",
-               s->tx_compressed ? "compressed" : "", _SL_);
-
-       fprintf(fp, "    ");
-       print_num(fp, 10, s->tx_bytes);
-       print_num(fp, 8, s->tx_packets);
-       print_num(fp, 7, s->tx_errors);
-       print_num(fp, 7, s->tx_dropped);
-       print_num(fp, 7, s->tx_carrier_errors);
-       print_num(fp, 7, s->collisions);
-       if (s->tx_compressed)
-               print_num(fp, 7, s->tx_compressed);
-
-       /* TX error stats */
-       if (show_stats > 1) {
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    TX errors: aborted  fifo   window heartbeat");
-               if (carrier_changes)
-                       fprintf(fp, " transns");
+               }
                fprintf(fp, "%s", _SL_);
 
-               fprintf(fp, "               ");
-               print_num(fp, 8, s->tx_aborted_errors);
-               print_num(fp, 7, s->tx_fifo_errors);
-               print_num(fp, 7, s->tx_window_errors);
-               print_num(fp, 7, s->tx_heartbeat_errors);
-               if (carrier_changes)
-                       print_num(fp, 7, *(uint32_t *)RTA_DATA(carrier_changes));
+               /* TX stats */
+               fprintf(fp, "    TX: bytes  packets  errors  dropped carrier collsns %s%s",
+                       s->tx_compressed ? "compressed" : "", _SL_);
+
+               fprintf(fp, "    ");
+               print_num(fp, 10, s->tx_bytes);
+               print_num(fp, 8, s->tx_packets);
+               print_num(fp, 7, s->tx_errors);
+               print_num(fp, 7, s->tx_dropped);
+               print_num(fp, 7, s->tx_carrier_errors);
+               print_num(fp, 7, s->collisions);
+               if (s->tx_compressed)
+                       print_num(fp, 7, s->tx_compressed);
+
+               /* TX error stats */
+               if (show_stats > 1) {
+                       fprintf(fp, "%s", _SL_);
+                       fprintf(fp, "    TX errors: aborted  fifo   window heartbeat");
+                       if (carrier_changes)
+                               fprintf(fp, " transns");
+                       fprintf(fp, "%s", _SL_);
+
+                       fprintf(fp, "               ");
+                       print_num(fp, 8, s->tx_aborted_errors);
+                       print_num(fp, 7, s->tx_fifo_errors);
+                       print_num(fp, 7, s->tx_window_errors);
+                       print_num(fp, 7, s->tx_heartbeat_errors);
+                       if (carrier_changes)
+                               print_num(fp, 7,
+                                         rta_getattr_u32(carrier_changes));
+               }
        }
 }
 
 static void print_link_stats32(FILE *fp, const struct rtnl_link_stats *s,
                               const struct rtattr *carrier_changes)
 {
-       /* RX stats */
-       fprintf(fp, "    RX: bytes  packets  errors  dropped overrun mcast   %s%s",
-               s->rx_compressed ? "compressed" : "", _SL_);
-
-
-       fprintf(fp, "    ");
-       print_num(fp, 10, s->rx_bytes);
-       print_num(fp, 8, s->rx_packets);
-       print_num(fp, 7, s->rx_errors);
-       print_num(fp, 7, s->rx_dropped);
-       print_num(fp, 7, s->rx_over_errors);
-       print_num(fp, 7, s->multicast);
-       if (s->rx_compressed)
-               print_num(fp, 7, s->rx_compressed);
-
-       /* RX error stats */
-       if (show_stats > 1) {
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    RX errors: length   crc     frame   fifo    missed%s%s",
-                       s->rx_nohandler ? "   nohandler" : "",  _SL_);
-               fprintf(fp, "               ");
-               print_num(fp, 8, s->rx_length_errors);
-               print_num(fp, 7, s->rx_crc_errors);
-               print_num(fp, 7, s->rx_frame_errors);
-               print_num(fp, 7, s->rx_fifo_errors);
-               print_num(fp, 7, s->rx_missed_errors);
-               if (s->rx_nohandler)
-                       print_num(fp, 7, s->rx_nohandler);
-       }
-       fprintf(fp, "%s", _SL_);
+       if (is_json_context()) {
+               open_json_object("stats");
+
+               /* RX stats */
+               open_json_object("rx");
+               print_uint(PRINT_JSON, "bytes", NULL, s->rx_bytes);
+               print_uint(PRINT_JSON, "packets", NULL, s->rx_packets);
+               print_uint(PRINT_JSON, "errors", NULL, s->rx_errors);
+               print_uint(PRINT_JSON, "dropped", NULL, s->rx_dropped);
+               print_uint(PRINT_JSON, "over_errors", NULL, s->rx_over_errors);
+               print_uint(PRINT_JSON, "multicast", NULL, s->multicast);
+               if (s->rx_compressed)
+                       print_int(PRINT_JSON,
+                                 "compressed",
+                                 NULL, s->rx_compressed);
+
+               /* RX error stats */
+               if (show_stats > 1) {
+                       print_uint(PRINT_JSON,
+                                  "length_errors",
+                                  NULL, s->rx_length_errors);
+                       print_uint(PRINT_JSON,
+                                  "crc_errors",
+                                  NULL, s->rx_crc_errors);
+                       print_uint(PRINT_JSON,
+                                  "frame_errors",
+                                  NULL, s->rx_frame_errors);
+                       print_uint(PRINT_JSON,
+                                  "fifo_errors",
+                                  NULL, s->rx_fifo_errors);
+                       print_uint(PRINT_JSON,
+                                  "missed_errors",
+                                  NULL, s->rx_missed_errors);
+                       if (s->rx_nohandler)
+                               print_int(PRINT_JSON,
+                                         "nohandler",
+                                         NULL, s->rx_nohandler);
+               }
+               close_json_object();
+
+               /* TX stats */
+               open_json_object("tx");
+               print_uint(PRINT_JSON, "bytes", NULL, s->tx_bytes);
+               print_uint(PRINT_JSON, "packets", NULL, s->tx_packets);
+               print_uint(PRINT_JSON, "errors", NULL, s->tx_errors);
+               print_uint(PRINT_JSON, "dropped", NULL, s->tx_dropped);
+               print_uint(PRINT_JSON,
+                          "carrier_errors",
+                          NULL, s->tx_carrier_errors);
+               print_uint(PRINT_JSON, "collisions", NULL, s->collisions);
+               if (s->tx_compressed)
+                       print_int(PRINT_JSON,
+                                 "compressed",
+                                 NULL, s->tx_compressed);
+
+               /* TX error stats */
+               if (show_stats > 1) {
+                       print_uint(PRINT_JSON,
+                                  "aborted_errors",
+                                  NULL, s->tx_aborted_errors);
+                       print_uint(PRINT_JSON,
+                                  "fifo_errors",
+                                  NULL, s->tx_fifo_errors);
+                       print_uint(PRINT_JSON,
+                                  "window_errors",
+                                  NULL, s->tx_window_errors);
+                       print_uint(PRINT_JSON,
+                                  "heartbeat_errors",
+                                  NULL, s->tx_heartbeat_errors);
+                       if (carrier_changes)
+                               print_uint(PRINT_JSON,
+                                          "carrier_changes",
+                                          NULL,
+                                          rta_getattr_u32(carrier_changes));
+               }
 
-       /* TX stats */
-       fprintf(fp, "    TX: bytes  packets  errors  dropped carrier collsns %s%s",
-               s->tx_compressed ? "compressed" : "", _SL_);
-
-       fprintf(fp, "    ");
-       print_num(fp, 10, s->tx_bytes);
-       print_num(fp, 8, s->tx_packets);
-       print_num(fp, 7, s->tx_errors);
-       print_num(fp, 7, s->tx_dropped);
-       print_num(fp, 7, s->tx_carrier_errors);
-       print_num(fp, 7, s->collisions);
-       if (s->tx_compressed)
-               print_num(fp, 7, s->tx_compressed);
-
-       /* TX error stats */
-       if (show_stats > 1) {
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    TX errors: aborted  fifo   window heartbeat");
-               if (carrier_changes)
-                       fprintf(fp, " transns");
+               close_json_object();
+               close_json_object();
+       } else {
+               /* RX stats */
+               fprintf(fp, "    RX: bytes  packets  errors  dropped overrun mcast   %s%s",
+                       s->rx_compressed ? "compressed" : "", _SL_);
+
+
+               fprintf(fp, "    ");
+               print_num(fp, 10, s->rx_bytes);
+               print_num(fp, 8, s->rx_packets);
+               print_num(fp, 7, s->rx_errors);
+               print_num(fp, 7, s->rx_dropped);
+               print_num(fp, 7, s->rx_over_errors);
+               print_num(fp, 7, s->multicast);
+               if (s->rx_compressed)
+                       print_num(fp, 7, s->rx_compressed);
+
+               /* RX error stats */
+               if (show_stats > 1) {
+                       fprintf(fp, "%s", _SL_);
+                       fprintf(fp, "    RX errors: length   crc     frame   fifo    missed%s%s",
+                               s->rx_nohandler ? "   nohandler" : "", _SL_);
+                       fprintf(fp, "               ");
+                       print_num(fp, 8, s->rx_length_errors);
+                       print_num(fp, 7, s->rx_crc_errors);
+                       print_num(fp, 7, s->rx_frame_errors);
+                       print_num(fp, 7, s->rx_fifo_errors);
+                       print_num(fp, 7, s->rx_missed_errors);
+                       if (s->rx_nohandler)
+                               print_num(fp, 7, s->rx_nohandler);
+               }
                fprintf(fp, "%s", _SL_);
 
-               fprintf(fp, "               ");
-               print_num(fp, 8, s->tx_aborted_errors);
-               print_num(fp, 7, s->tx_fifo_errors);
-               print_num(fp, 7, s->tx_window_errors);
-               print_num(fp, 7, s->tx_heartbeat_errors);
-               if (carrier_changes)
-                       print_num(fp, 7, *(uint32_t *)RTA_DATA(carrier_changes));
+               /* TX stats */
+               fprintf(fp, "    TX: bytes  packets  errors  dropped carrier collsns %s%s",
+                       s->tx_compressed ? "compressed" : "", _SL_);
+
+               fprintf(fp, "    ");
+               print_num(fp, 10, s->tx_bytes);
+               print_num(fp, 8, s->tx_packets);
+               print_num(fp, 7, s->tx_errors);
+               print_num(fp, 7, s->tx_dropped);
+               print_num(fp, 7, s->tx_carrier_errors);
+               print_num(fp, 7, s->collisions);
+               if (s->tx_compressed)
+                       print_num(fp, 7, s->tx_compressed);
+
+               /* TX error stats */
+               if (show_stats > 1) {
+                       fprintf(fp, "%s", _SL_);
+                       fprintf(fp, "    TX errors: aborted  fifo   window heartbeat");
+                       if (carrier_changes)
+                               fprintf(fp, " transns");
+                       fprintf(fp, "%s", _SL_);
+
+                       fprintf(fp, "               ");
+                       print_num(fp, 8, s->tx_aborted_errors);
+                       print_num(fp, 7, s->tx_fifo_errors);
+                       print_num(fp, 7, s->tx_window_errors);
+                       print_num(fp, 7, s->tx_heartbeat_errors);
+                       if (carrier_changes)
+                               print_num(fp, 7,
+                                         rta_getattr_u32(carrier_changes));
+               }
        }
 }
 
@@ -629,13 +919,14 @@ static void print_link_stats(FILE *fp, struct nlmsghdr *n)
 }
 
 int print_linkinfo_brief(const struct sockaddr_nl *who,
-                               struct nlmsghdr *n, void *arg)
+                        struct nlmsghdr *n, void *arg,
+                        struct link_filter *pfilter)
 {
        FILE *fp = (FILE *)arg;
        struct ifinfomsg *ifi = NLMSG_DATA(n);
        struct rtattr *tb[IFLA_MAX+1];
        int len = n->nlmsg_len;
-       char *name;
+       const char *name;
        char buf[32] = { 0, };
        unsigned int m_flag = 0;
 
@@ -646,91 +937,119 @@ int print_linkinfo_brief(const struct sockaddr_nl *who,
        if (len < 0)
                return -1;
 
-       if (filter.ifindex && ifi->ifi_index != filter.ifindex)
+       if (!pfilter)
+               pfilter = &filter;
+
+       if (pfilter->ifindex && ifi->ifi_index != pfilter->ifindex)
                return -1;
-       if (filter.up && !(ifi->ifi_flags&IFF_UP))
+       if (pfilter->up && !(ifi->ifi_flags&IFF_UP))
                return -1;
 
        parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi), len);
        if (tb[IFLA_IFNAME] == NULL) {
                fprintf(stderr, "BUG: device with ifindex %d has nil ifname\n", ifi->ifi_index);
+               name = "<nil>";
+       } else {
+               name = rta_getattr_str(tb[IFLA_IFNAME]);
        }
-       if (filter.label &&
-           (!filter.family || filter.family == AF_PACKET) &&
-           fnmatch(filter.label, RTA_DATA(tb[IFLA_IFNAME]), 0))
+
+       if (pfilter->label &&
+           (!pfilter->family || pfilter->family == AF_PACKET) &&
+           fnmatch(pfilter->label, RTA_DATA(tb[IFLA_IFNAME]), 0))
                return -1;
 
        if (tb[IFLA_GROUP]) {
-               int group = *(int *)RTA_DATA(tb[IFLA_GROUP]);
+               int group = rta_getattr_u32(tb[IFLA_GROUP]);
 
-               if (filter.group != -1 && group != filter.group)
+               if (pfilter->group != -1 && group != pfilter->group)
                        return -1;
        }
 
        if (tb[IFLA_MASTER]) {
-               int master = *(int *)RTA_DATA(tb[IFLA_MASTER]);
+               int master = rta_getattr_u32(tb[IFLA_MASTER]);
 
-               if (filter.master > 0 && master != filter.master)
+               if (pfilter->master > 0 && master != pfilter->master)
                        return -1;
-       } else if (filter.master > 0)
+       } else if (pfilter->master > 0)
                return -1;
 
-       if (filter.kind) {
-               if (tb[IFLA_LINKINFO]) {
-                       char *kind = parse_link_kind(tb[IFLA_LINKINFO]);
+       if (pfilter->kind && match_link_kind(tb, pfilter->kind, 0))
+               return -1;
 
-                       if (strcmp(kind, filter.kind))
-                               return -1;
-               } else {
-                       return -1;
-               }
-       }
+       if (pfilter->slave_kind && match_link_kind(tb, pfilter->slave_kind, 1))
+               return -1;
 
        if (n->nlmsg_type == RTM_DELLINK)
-               fprintf(fp, "Deleted ");
-
-       name = (char *)(tb[IFLA_IFNAME] ? rta_getattr_str(tb[IFLA_IFNAME]) : "<nil>");
+               print_bool(PRINT_ANY, "deleted", "Deleted ", true);
 
        if (tb[IFLA_LINK]) {
                SPRINT_BUF(b1);
-               int iflink = *(int *)RTA_DATA(tb[IFLA_LINK]);
+               int iflink = rta_getattr_u32(tb[IFLA_LINK]);
 
-               if (iflink == 0)
+               if (iflink == 0) {
                        snprintf(buf, sizeof(buf), "%s@NONE", name);
-               else {
-                       snprintf(buf, sizeof(buf),
-                                "%s@%s", name, ll_idx_n2a(iflink, b1));
+                       print_null(PRINT_JSON, "link", NULL, NULL);
+               } else {
+                       const char *link = ll_idx_n2a(iflink, b1);
+
+                       print_string(PRINT_JSON, "link", NULL, link);
+                       snprintf(buf, sizeof(buf), "%s@%s", name, link);
                        m_flag = ll_index_to_flags(iflink);
                        m_flag = !(m_flag & IFF_UP);
                }
        } else
                snprintf(buf, sizeof(buf), "%s", name);
 
-       fprintf(fp, "%-16s ", buf);
+       print_string(PRINT_FP, NULL, "%-16s ", buf);
+       print_string(PRINT_JSON, "ifname", NULL, name);
 
        if (tb[IFLA_OPERSTATE])
                print_operstate(fp, rta_getattr_u8(tb[IFLA_OPERSTATE]));
 
-       if (filter.family == AF_PACKET) {
+       if (pfilter->family == AF_PACKET) {
                SPRINT_BUF(b1);
+
                if (tb[IFLA_ADDRESS]) {
-                       color_fprintf(fp, COLOR_MAC, "%s ",
-                                       ll_addr_n2a(RTA_DATA(tb[IFLA_ADDRESS]),
-                                               RTA_PAYLOAD(tb[IFLA_ADDRESS]),
-                                               ifi->ifi_type,
-                                               b1, sizeof(b1)));
+                       print_color_string(PRINT_ANY, COLOR_MAC,
+                                          "address", "%s ",
+                                          ll_addr_n2a(
+                                                  RTA_DATA(tb[IFLA_ADDRESS]),
+                                                  RTA_PAYLOAD(tb[IFLA_ADDRESS]),
+                                                  ifi->ifi_type,
+                                                  b1, sizeof(b1)));
                }
        }
 
-       if (filter.family == AF_PACKET)
+       if (pfilter->family == AF_PACKET) {
                print_link_flags(fp, ifi->ifi_flags, m_flag);
-
-       if (filter.family == AF_PACKET)
-               fprintf(fp, "\n");
+               print_string(PRINT_FP, NULL, "%s", "\n");
+       }
        fflush(fp);
        return 0;
 }
 
+static const char *link_events[] = {
+       [IFLA_EVENT_NONE] = "NONE",
+       [IFLA_EVENT_REBOOT] = "REBOOT",
+       [IFLA_EVENT_FEATURES] = "FEATURE CHANGE",
+       [IFLA_EVENT_BONDING_FAILOVER] = "BONDING FAILOVER",
+       [IFLA_EVENT_NOTIFY_PEERS] = "NOTIFY PEERS",
+       [IFLA_EVENT_IGMP_RESEND] = "RESEND IGMP",
+       [IFLA_EVENT_BONDING_OPTIONS] = "BONDING OPTION"
+};
+
+static void print_link_event(FILE *f, __u32 event)
+{
+       if (event >= ARRAY_SIZE(link_events))
+               print_int(PRINT_ANY, "event", "event %d ", event);
+       else {
+               if (event)
+                       print_string(PRINT_ANY,
+                                    "event", "event %s ",
+                                    link_events[event]);
+       }
+}
+
 int print_linkinfo(const struct sockaddr_nl *who,
                   struct nlmsghdr *n, void *arg)
 {
@@ -753,90 +1072,93 @@ int print_linkinfo(const struct sockaddr_nl *who,
                return 0;
 
        parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi), len);
-       if (tb[IFLA_IFNAME] == NULL) {
+       if (tb[IFLA_IFNAME] == NULL)
                fprintf(stderr, "BUG: device with ifindex %d has nil ifname\n", ifi->ifi_index);
-       }
+
        if (filter.label &&
            (!filter.family || filter.family == AF_PACKET) &&
            fnmatch(filter.label, RTA_DATA(tb[IFLA_IFNAME]), 0))
                return 0;
 
        if (tb[IFLA_GROUP]) {
-               int group = *(int *)RTA_DATA(tb[IFLA_GROUP]);
+               int group = rta_getattr_u32(tb[IFLA_GROUP]);
 
                if (filter.group != -1 && group != filter.group)
                        return -1;
        }
 
        if (tb[IFLA_MASTER]) {
-               int master = *(int *)RTA_DATA(tb[IFLA_MASTER]);
+               int master = rta_getattr_u32(tb[IFLA_MASTER]);
 
                if (filter.master > 0 && master != filter.master)
                        return -1;
        } else if (filter.master > 0)
                return -1;
 
-       if (filter.kind) {
-               if (tb[IFLA_LINKINFO]) {
-                       char *kind = parse_link_kind(tb[IFLA_LINKINFO]);
+       if (filter.kind && match_link_kind(tb, filter.kind, 0))
+               return -1;
 
-                       if (strcmp(kind, filter.kind))
-                               return -1;
-               } else {
-                       return -1;
-               }
-       }
+       if (filter.slave_kind && match_link_kind(tb, filter.slave_kind, 1))
+               return -1;
 
        if (n->nlmsg_type == RTM_DELLINK)
-               fprintf(fp, "Deleted ");
-
-       fprintf(fp, "%d: ", ifi->ifi_index);
-       color_fprintf(fp, COLOR_IFNAME, "%s",
-               tb[IFLA_IFNAME] ? rta_getattr_str(tb[IFLA_IFNAME]) : "<nil>");
+               print_bool(PRINT_ANY, "deleted", "Deleted ", true);
+
+       print_int(PRINT_ANY, "ifindex", "%d: ", ifi->ifi_index);
+       if (tb[IFLA_IFNAME]) {
+               print_color_string(PRINT_ANY,
+                                  COLOR_IFNAME,
+                                  "ifname", "%s",
+                                  rta_getattr_str(tb[IFLA_IFNAME]));
+       } else {
+               print_null(PRINT_JSON, "ifname", NULL, NULL);
+               print_color_null(PRINT_FP, COLOR_IFNAME,
+                                "ifname", "%s", "<nil>");
+       }
 
        if (tb[IFLA_LINK]) {
-               SPRINT_BUF(b1);
-               int iflink = *(int *)RTA_DATA(tb[IFLA_LINK]);
+               int iflink = rta_getattr_u32(tb[IFLA_LINK]);
 
                if (iflink == 0)
-                       fprintf(fp, "@NONE: ");
+                       print_null(PRINT_ANY, "link", "@%s: ", "NONE");
                else {
                        if (tb[IFLA_LINK_NETNSID])
-                               fprintf(fp, "@if%d: ", iflink);
+                               print_int(PRINT_ANY,
+                                         "link_index", "@if%d: ", iflink);
                        else {
-                               fprintf(fp, "@%s: ", ll_idx_n2a(iflink, b1));
+                               SPRINT_BUF(b1);
+
+                               print_string(PRINT_ANY,
+                                            "link",
+                                            "@%s: ",
+                                            ll_idx_n2a(iflink, b1));
                                m_flag = ll_index_to_flags(iflink);
                                m_flag = !(m_flag & IFF_UP);
                        }
                }
        } else {
-               fprintf(fp, ": ");
+               print_string(PRINT_FP, NULL, ": ", NULL);
        }
        print_link_flags(fp, ifi->ifi_flags, m_flag);
 
        if (tb[IFLA_MTU])
-               fprintf(fp, "mtu %u ", *(int *)RTA_DATA(tb[IFLA_MTU]));
+               print_int(PRINT_ANY,
+                         "mtu", "mtu %u ",
+                         rta_getattr_u32(tb[IFLA_MTU]));
+       if (tb[IFLA_XDP])
+               xdp_dump(fp, tb[IFLA_XDP], do_link, false);
        if (tb[IFLA_QDISC])
-               fprintf(fp, "qdisc %s ", rta_getattr_str(tb[IFLA_QDISC]));
+               print_string(PRINT_ANY,
+                            "qdisc",
+                            "qdisc %s ",
+                            rta_getattr_str(tb[IFLA_QDISC]));
        if (tb[IFLA_MASTER]) {
                SPRINT_BUF(b1);
-               fprintf(fp, "master %s ", ll_idx_n2a(*(int *)RTA_DATA(tb[IFLA_MASTER]), b1));
-       }
 
-       if (tb[IFLA_PHYS_PORT_ID]) {
-               SPRINT_BUF(b1);
-               fprintf(fp, "portid %s ",
-                       hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_PORT_ID]),
-                                     RTA_PAYLOAD(tb[IFLA_PHYS_PORT_ID]),
-                                     b1, sizeof(b1)));
-       }
-
-       if (tb[IFLA_PHYS_SWITCH_ID]) {
-               SPRINT_BUF(b1);
-               fprintf(fp, "switchid %s ",
-                       hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
-                                     RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
-                                     b1, sizeof(b1)));
+               print_string(PRINT_ANY,
+                            "master",
+                            "master %s ",
+                            ll_idx_n2a(rta_getattr_u32(tb[IFLA_MASTER]), b1));
        }
 
        if (tb[IFLA_OPERSTATE])
@@ -847,69 +1169,156 @@ int print_linkinfo(const struct sockaddr_nl *who,
 
        if (tb[IFLA_GROUP]) {
                SPRINT_BUF(b1);
-               int group = *(int *)RTA_DATA(tb[IFLA_GROUP]);
+               int group = rta_getattr_u32(tb[IFLA_GROUP]);
 
-               fprintf(fp, "group %s ", rtnl_group_n2a(group, b1, sizeof(b1)));
+               print_string(PRINT_ANY,
+                            "group",
+                            "group %s ",
+                            rtnl_group_n2a(group, b1, sizeof(b1)));
        }
 
        if (filter.showqueue)
                print_queuelen(fp, tb);
 
+       if (tb[IFLA_EVENT])
+               print_link_event(fp, rta_getattr_u32(tb[IFLA_EVENT]));
+
        if (!filter.family || filter.family == AF_PACKET || show_details) {
                SPRINT_BUF(b1);
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "    link/%s ", ll_type_n2a(ifi->ifi_type, b1, sizeof(b1)));
 
+               print_string(PRINT_FP, NULL, "%s", _SL_);
+               print_string(PRINT_ANY,
+                            "link_type",
+                            "    link/%s ",
+                            ll_type_n2a(ifi->ifi_type, b1, sizeof(b1)));
                if (tb[IFLA_ADDRESS]) {
-                       color_fprintf(fp, COLOR_MAC, "%s",
-                                       ll_addr_n2a(RTA_DATA(tb[IFLA_ADDRESS]),
-                                               RTA_PAYLOAD(tb[IFLA_ADDRESS]),
-                                               ifi->ifi_type,
-                                               b1, sizeof(b1)));
+                       print_color_string(PRINT_ANY,
+                                          COLOR_MAC,
+                                          "address",
+                                          "%s",
+                                          ll_addr_n2a(RTA_DATA(tb[IFLA_ADDRESS]),
+                                                      RTA_PAYLOAD(tb[IFLA_ADDRESS]),
+                                                      ifi->ifi_type,
+                                                      b1, sizeof(b1)));
                }
                if (tb[IFLA_BROADCAST]) {
-                       if (ifi->ifi_flags&IFF_POINTOPOINT)
-                               fprintf(fp, " peer ");
-                       else
-                               fprintf(fp, " brd ");
-                       fprintf(fp, "%s", ll_addr_n2a(RTA_DATA(tb[IFLA_BROADCAST]),
-                                                     RTA_PAYLOAD(tb[IFLA_BROADCAST]),
-                                                     ifi->ifi_type,
-                                                     b1, sizeof(b1)));
+                       if (ifi->ifi_flags&IFF_POINTOPOINT) {
+                               print_string(PRINT_FP, NULL, " peer ", NULL);
+                               print_bool(PRINT_JSON,
+                                          "link_pointtopoint", NULL, true);
+                       } else {
+                               print_string(PRINT_FP, NULL, " brd ", NULL);
+                       }
+                       print_color_string(PRINT_ANY,
+                                          COLOR_MAC,
+                                          "broadcast",
+                                          "%s",
+                                          ll_addr_n2a(RTA_DATA(tb[IFLA_BROADCAST]),
+                                                      RTA_PAYLOAD(tb[IFLA_BROADCAST]),
+                                                      ifi->ifi_type,
+                                                      b1, sizeof(b1)));
                }
        }
 
        if (tb[IFLA_LINK_NETNSID]) {
-               int id = *(int *)RTA_DATA(tb[IFLA_LINK_NETNSID]);
+               int id = rta_getattr_u32(tb[IFLA_LINK_NETNSID]);
 
-               if (id >= 0)
-                       fprintf(fp, " link-netnsid %d", id);
-               else
-                       fprintf(fp, " link-netnsid unknown");
+               if (is_json_context()) {
+                       print_int(PRINT_JSON, "link_netnsid", NULL, id);
+               } else {
+                       if (id >= 0)
+                               print_int(PRINT_FP, NULL,
+                                         " link-netnsid %d", id);
+                       else
+                               print_string(PRINT_FP, NULL,
+                                            " link-netnsid %s", "unknown");
+               }
        }
 
        if (tb[IFLA_PROTO_DOWN]) {
                if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
-                       fprintf(fp, " protodown on ");
-       }
-
-       if (tb[IFLA_PROMISCUITY] && show_details)
-               fprintf(fp, " promiscuity %u ",
-                       *(int *)RTA_DATA(tb[IFLA_PROMISCUITY]));
-
-       if (tb[IFLA_LINKINFO] && show_details)
-               print_linktype(fp, tb[IFLA_LINKINFO]);
+                       print_bool(PRINT_ANY,
+                                  "proto_down", " protodown on ", true);
+       }
+
+       if (show_details) {
+               if (tb[IFLA_PROMISCUITY])
+                       print_uint(PRINT_ANY,
+                                  "promiscuity",
+                                  " promiscuity %u ",
+                                  rta_getattr_u32(tb[IFLA_PROMISCUITY]));
+
+               if (tb[IFLA_LINKINFO])
+                       print_linktype(fp, tb[IFLA_LINKINFO]);
+
+               if (do_link && tb[IFLA_AF_SPEC])
+                       print_af_spec(fp, tb[IFLA_AF_SPEC]);
+
+               if (tb[IFLA_NUM_TX_QUEUES])
+                       print_uint(PRINT_ANY,
+                                  "num_tx_queues",
+                                  "numtxqueues %u ",
+                                  rta_getattr_u32(tb[IFLA_NUM_TX_QUEUES]));
+
+               if (tb[IFLA_NUM_RX_QUEUES])
+                       print_uint(PRINT_ANY,
+                                  "num_rx_queues",
+                                  "numrxqueues %u ",
+                                  rta_getattr_u32(tb[IFLA_NUM_RX_QUEUES]));
+
+               if (tb[IFLA_GSO_MAX_SIZE])
+                       print_uint(PRINT_ANY,
+                                  "gso_max_size",
+                                  "gso_max_size %u ",
+                                  rta_getattr_u32(tb[IFLA_GSO_MAX_SIZE]));
+
+               if (tb[IFLA_GSO_MAX_SEGS])
+                       print_uint(PRINT_ANY,
+                                  "gso_max_segs",
+                                  "gso_max_segs %u ",
+                                  rta_getattr_u32(tb[IFLA_GSO_MAX_SEGS]));
+
+               if (tb[IFLA_PHYS_PORT_NAME])
+                       print_string(PRINT_ANY,
+                                    "phys_port_name",
+                                    "portname %s ",
+                                    rta_getattr_str(tb[IFLA_PHYS_PORT_NAME]));
+
+               if (tb[IFLA_PHYS_PORT_ID]) {
+                       SPRINT_BUF(b1);
+                       print_string(PRINT_ANY,
+                                    "phys_port_id",
+                                    "portid %s ",
+                                    hexstring_n2a(
+                                            RTA_DATA(tb[IFLA_PHYS_PORT_ID]),
+                                            RTA_PAYLOAD(tb[IFLA_PHYS_PORT_ID]),
+                                            b1, sizeof(b1)));
+               }
 
-       if (do_link && tb[IFLA_AF_SPEC] && show_details)
-               print_af_spec(fp, tb[IFLA_AF_SPEC]);
+               if (tb[IFLA_PHYS_SWITCH_ID]) {
+                       SPRINT_BUF(b1);
+                       print_string(PRINT_ANY,
+                                    "phys_switch_id",
+                                    "switchid %s ",
+                                    hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
+                                                  RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
+                                                  b1, sizeof(b1)));
+               }
+       }
 
        if ((do_link || show_details) && tb[IFLA_IFALIAS]) {
-               fprintf(fp, "%s    alias %s", _SL_,
-                       rta_getattr_str(tb[IFLA_IFALIAS]));
+               print_string(PRINT_FP, NULL, "%s    ", _SL_);
+               print_string(PRINT_ANY,
+                            "ifalias",
+                            "alias %s",
+                            rta_getattr_str(tb[IFLA_IFALIAS]));
        }
 
+       if ((do_link || show_details) && tb[IFLA_XDP])
+               xdp_dump(fp, tb[IFLA_XDP], true, true);
+
        if (do_link && show_stats) {
-               fprintf(fp, "%s", _SL_);
+               print_string(PRINT_FP, NULL, "%s", _SL_);
                __print_link_stats(fp, tb);
        }
 
@@ -917,11 +1326,16 @@ int print_linkinfo(const struct sockaddr_nl *who,
                struct rtattr *i, *vflist = tb[IFLA_VFINFO_LIST];
                int rem = RTA_PAYLOAD(vflist);
 
-               for (i = RTA_DATA(vflist); RTA_OK(i, rem); i = RTA_NEXT(i, rem))
+               open_json_array(PRINT_JSON, "vfinfo_list");
+               for (i = RTA_DATA(vflist); RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
+                       open_json_object(NULL);
                        print_vfinfo(fp, i);
+                       close_json_object();
+               }
+               close_json_array(PRINT_JSON, NULL);
        }
 
-       fprintf(fp, "\n");
+       print_string(PRINT_FP, NULL, "\n", NULL);
        fflush(fp);
        return 1;
 }
@@ -960,7 +1374,104 @@ static unsigned int get_ifa_flags(struct ifaddrmsg *ifa,
                                  struct rtattr *ifa_flags_attr)
 {
        return ifa_flags_attr ? rta_getattr_u32(ifa_flags_attr) :
-                               ifa->ifa_flags;
+               ifa->ifa_flags;
+}
+
+/* Mapping from argument to address flag mask */
+struct {
+       const char *name;
+       unsigned long value;
+} ifa_flag_names[] = {
+       { "secondary",          IFA_F_SECONDARY },
+       { "temporary",          IFA_F_SECONDARY },
+       { "nodad",              IFA_F_NODAD },
+       { "optimistic",         IFA_F_OPTIMISTIC },
+       { "dadfailed",          IFA_F_DADFAILED },
+       { "home",               IFA_F_HOMEADDRESS },
+       { "deprecated",         IFA_F_DEPRECATED },
+       { "tentative",          IFA_F_TENTATIVE },
+       { "permanent",          IFA_F_PERMANENT },
+       { "mngtmpaddr",         IFA_F_MANAGETEMPADDR },
+       { "noprefixroute",      IFA_F_NOPREFIXROUTE },
+       { "autojoin",           IFA_F_MCAUTOJOIN },
+       { "stable-privacy",     IFA_F_STABLE_PRIVACY },
+};
+
+static void print_ifa_flags(FILE *fp, const struct ifaddrmsg *ifa,
+                           unsigned int flags)
+{
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(ifa_flag_names); i++) {
+               unsigned long mask = ifa_flag_names[i].value;
+
+               if (mask == IFA_F_PERMANENT) {
+                       if (!(flags & mask))
+                               print_bool(PRINT_ANY,
+                                          "dynamic", "dynamic ", true);
+               } else if (flags & mask) {
+                       if (mask == IFA_F_SECONDARY &&
+                           ifa->ifa_family == AF_INET6) {
+                               print_bool(PRINT_ANY,
+                                          "temporary", "temporary ", true);
+                       } else {
+                               print_string(PRINT_FP, NULL,
+                                            "%s ", ifa_flag_names[i].name);
+                               print_bool(PRINT_JSON,
+                                          ifa_flag_names[i].name, NULL, true);
+                       }
+               }
+
+               flags &= ~mask;
+       }
+
+       if (flags) {
+               if (is_json_context()) {
+                       SPRINT_BUF(b1);
+
+                       snprintf(b1, sizeof(b1), "%02x", flags);
+                       print_string(PRINT_JSON, "ifa_flags", NULL, b1);
+               } else {
+                       fprintf(fp, "flags %02x ", flags);
+               }
+       }
+
+}
+
+static int get_filter(const char *arg)
+{
+       unsigned int i;
+
+       /* Special cases */
+       if (strcmp(arg, "dynamic") == 0) {
+               filter.flags &= ~IFA_F_PERMANENT;
+               filter.flagmask |= IFA_F_PERMANENT;
+       } else if (strcmp(arg, "primary") == 0) {
+               filter.flags &= ~IFA_F_SECONDARY;
+               filter.flagmask |= IFA_F_SECONDARY;
+       } else if (*arg == '-') {
+               for (i = 0; i < ARRAY_SIZE(ifa_flag_names); i++) {
+                       if (strcmp(arg + 1, ifa_flag_names[i].name))
+                               continue;
+
+                       filter.flags &= ifa_flag_names[i].value;
+                       filter.flagmask |= ifa_flag_names[i].value;
+                       return 0;
+               }
+
+               return -1;
+       } else {
+               for (i = 0; i < ARRAY_SIZE(ifa_flag_names); i++) {
+                       if (strcmp(arg, ifa_flag_names[i].name))
+                               continue;
+                       filter.flags |= ifa_flag_names[i].value;
+                       filter.flagmask |= ifa_flag_names[i].value;
+                       return 0;
+               }
+               return -1;
+       }
+
+       return 0;
 }
 
 int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
@@ -969,11 +1480,8 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
        FILE *fp = arg;
        struct ifaddrmsg *ifa = NLMSG_DATA(n);
        int len = n->nlmsg_len;
-       int deprecated = 0;
-       /* Use local copy of ifa_flags to not interfere with filtering code */
        unsigned int ifa_flags;
        struct rtattr *rta_tb[IFA_MAX+1];
-       char abuf[256];
 
        SPRINT_BUF(b1);
 
@@ -1017,10 +1525,8 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
        }
        if (filter.pfx.family) {
                if (rta_tb[IFA_LOCAL]) {
-                       inet_prefix dst;
+                       inet_prefix dst = { .family = ifa->ifa_family };
 
-                       memset(&dst, 0, sizeof(dst));
-                       dst.family = ifa->ifa_family;
                        memcpy(&dst.data, RTA_DATA(rta_tb[IFA_LOCAL]), RTA_PAYLOAD(rta_tb[IFA_LOCAL]));
                        if (inet_addr_match(&dst, &filter.pfx, filter.pfx.bitlen))
                                return 0;
@@ -1049,158 +1555,139 @@ int print_addrinfo(const struct sockaddr_nl *who, struct nlmsghdr *n,
        }
 
        if (n->nlmsg_type == RTM_DELADDR)
-               fprintf(fp, "Deleted ");
+               print_bool(PRINT_ANY, "deleted", "Deleted ", true);
 
        if (!brief) {
-               if (filter.oneline || filter.flushb)
-                       fprintf(fp, "%u: %s", ifa->ifa_index, ll_index_to_name(ifa->ifa_index));
+               if (filter.oneline || filter.flushb) {
+                       const char *dev = ll_index_to_name(ifa->ifa_index);
+
+                       if (is_json_context()) {
+                               print_int(PRINT_JSON,
+                                         "index", NULL, ifa->ifa_index);
+                               print_string(PRINT_JSON, "dev", NULL, dev);
+                       } else {
+                               fprintf(fp, "%u: %s", ifa->ifa_index, dev);
+                       }
+               }
+
+               int family = ifa->ifa_family;
+
                if (ifa->ifa_family == AF_INET)
-                       fprintf(fp, "    inet ");
+                       print_string(PRINT_ANY, "family", "    %s ", "inet");
                else if (ifa->ifa_family == AF_INET6)
-                       fprintf(fp, "    inet6 ");
+                       print_string(PRINT_ANY, "family", "    %s ", "inet6");
                else if (ifa->ifa_family == AF_DECnet)
-                       fprintf(fp, "    dnet ");
+                       print_string(PRINT_ANY, "family", "    %s ", "dnet");
                else if (ifa->ifa_family == AF_IPX)
-                       fprintf(fp, "     ipx ");
+                       print_string(PRINT_ANY, "family", "     %s ", "ipx");
                else
-                       fprintf(fp, "    family %d ", ifa->ifa_family);
+                       print_int(PRINT_ANY,
+                                 "family_index",
+                                 "    family %d ", family);
        }
 
        if (rta_tb[IFA_LOCAL]) {
-               if (ifa->ifa_family == AF_INET)
-                       color_fprintf(fp, COLOR_INET, "%s", format_host(ifa->ifa_family,
-                                               RTA_PAYLOAD(rta_tb[IFA_LOCAL]),
-                                               RTA_DATA(rta_tb[IFA_LOCAL]),
-                                               abuf, sizeof(abuf)));
-               else if (ifa->ifa_family == AF_INET6)
-                       color_fprintf(fp, COLOR_INET6, "%s", format_host(ifa->ifa_family,
-                                               RTA_PAYLOAD(rta_tb[IFA_LOCAL]),
-                                               RTA_DATA(rta_tb[IFA_LOCAL]),
-                                               abuf, sizeof(abuf)));
-               else
-                       fprintf(fp, "%s", format_host(ifa->ifa_family,
-                                               RTA_PAYLOAD(rta_tb[IFA_LOCAL]),
-                                               RTA_DATA(rta_tb[IFA_LOCAL]),
-                                               abuf, sizeof(abuf)));
-
-               if (rta_tb[IFA_ADDRESS] == NULL ||
-                   memcmp(RTA_DATA(rta_tb[IFA_ADDRESS]), RTA_DATA(rta_tb[IFA_LOCAL]),
-                          ifa->ifa_family == AF_INET ? 4 : 16) == 0) {
-                       fprintf(fp, "/%d ", ifa->ifa_prefixlen);
-               } else {
-                       fprintf(fp, " peer %s/%d ",
-                               format_host(ifa->ifa_family,
-                                           RTA_PAYLOAD(rta_tb[IFA_ADDRESS]),
-                                           RTA_DATA(rta_tb[IFA_ADDRESS]),
-                                           abuf, sizeof(abuf)),
-                               ifa->ifa_prefixlen);
+               print_color_string(PRINT_ANY,
+                                  ifa_family_color(ifa->ifa_family),
+                                  "local", "%s",
+                                  format_host_rta(ifa->ifa_family,
+                                                  rta_tb[IFA_LOCAL]));
+               if (rta_tb[IFA_ADDRESS] &&
+                   memcmp(RTA_DATA(rta_tb[IFA_ADDRESS]),
+                          RTA_DATA(rta_tb[IFA_LOCAL]),
+                          ifa->ifa_family == AF_INET ? 4 : 16)) {
+                       print_string(PRINT_FP, NULL, " %s ", "peer");
+                       print_color_string(PRINT_ANY,
+                                          ifa_family_color(ifa->ifa_family),
+                                          "address",
+                                          "%s",
+                                          format_host_rta(ifa->ifa_family,
+                                                          rta_tb[IFA_ADDRESS]));
                }
+               print_int(PRINT_ANY, "prefixlen", "/%d ", ifa->ifa_prefixlen);
        }
 
        if (brief)
                goto brief_exit;
 
        if (rta_tb[IFA_BROADCAST]) {
-               fprintf(fp, "brd %s ",
-                       format_host(ifa->ifa_family,
-                                   RTA_PAYLOAD(rta_tb[IFA_BROADCAST]),
-                                   RTA_DATA(rta_tb[IFA_BROADCAST]),
-                                   abuf, sizeof(abuf)));
+               print_string(PRINT_FP, NULL, "%s ", "brd");
+               print_color_string(PRINT_ANY,
+                                  ifa_family_color(ifa->ifa_family),
+                                  "broadcast",
+                                  "%s ",
+                                  format_host_rta(ifa->ifa_family,
+                                                  rta_tb[IFA_BROADCAST]));
        }
+
        if (rta_tb[IFA_ANYCAST]) {
-               fprintf(fp, "any %s ",
-                       format_host(ifa->ifa_family,
-                                   RTA_PAYLOAD(rta_tb[IFA_ANYCAST]),
-                                   RTA_DATA(rta_tb[IFA_ANYCAST]),
-                                   abuf, sizeof(abuf)));
-       }
-       fprintf(fp, "scope %s ", rtnl_rtscope_n2a(ifa->ifa_scope, b1, sizeof(b1)));
-       if (ifa_flags & IFA_F_SECONDARY) {
-               ifa_flags &= ~IFA_F_SECONDARY;
-               if (ifa->ifa_family == AF_INET6)
-                       fprintf(fp, "temporary ");
-               else
-                       fprintf(fp, "secondary ");
-       }
-       if (ifa_flags & IFA_F_TENTATIVE) {
-               ifa_flags &= ~IFA_F_TENTATIVE;
-               fprintf(fp, "tentative ");
-       }
-       if (ifa_flags & IFA_F_DEPRECATED) {
-               ifa_flags &= ~IFA_F_DEPRECATED;
-               deprecated = 1;
-               fprintf(fp, "deprecated ");
-       }
-       if (ifa_flags & IFA_F_HOMEADDRESS) {
-               ifa_flags &= ~IFA_F_HOMEADDRESS;
-               fprintf(fp, "home ");
-       }
-       if (ifa_flags & IFA_F_NODAD) {
-               ifa_flags &= ~IFA_F_NODAD;
-               fprintf(fp, "nodad ");
-       }
-       if (ifa_flags & IFA_F_MANAGETEMPADDR) {
-               ifa_flags &= ~IFA_F_MANAGETEMPADDR;
-               fprintf(fp, "mngtmpaddr ");
-       }
-       if (ifa_flags & IFA_F_NOPREFIXROUTE) {
-               ifa_flags &= ~IFA_F_NOPREFIXROUTE;
-               fprintf(fp, "noprefixroute ");
-       }
-       if (ifa_flags & IFA_F_MCAUTOJOIN) {
-               ifa_flags &= ~IFA_F_MCAUTOJOIN;
-               fprintf(fp, "autojoin ");
+               print_string(PRINT_FP, NULL, "%s ", "any");
+               print_color_string(PRINT_ANY,
+                                  ifa_family_color(ifa->ifa_family),
+                                  "anycast",
+                                  "%s ",
+                                  format_host_rta(ifa->ifa_family,
+                                                  rta_tb[IFA_ANYCAST]));
        }
-       if (!(ifa_flags & IFA_F_PERMANENT)) {
-               fprintf(fp, "dynamic ");
-       } else
-               ifa_flags &= ~IFA_F_PERMANENT;
-       if (ifa_flags & IFA_F_DADFAILED) {
-               ifa_flags &= ~IFA_F_DADFAILED;
-               fprintf(fp, "dadfailed ");
-       }
-       if (ifa_flags)
-               fprintf(fp, "flags %02x ", ifa_flags);
+
+       print_string(PRINT_ANY,
+                    "scope",
+                    "scope %s ",
+                    rtnl_rtscope_n2a(ifa->ifa_scope, b1, sizeof(b1)));
+
+       print_ifa_flags(fp, ifa, ifa_flags);
+
        if (rta_tb[IFA_LABEL])
-               fprintf(fp, "%s", rta_getattr_str(rta_tb[IFA_LABEL]));
+               print_string(PRINT_ANY,
+                            "label",
+                            "%s",
+                            rta_getattr_str(rta_tb[IFA_LABEL]));
+
        if (rta_tb[IFA_CACHEINFO]) {
                struct ifa_cacheinfo *ci = RTA_DATA(rta_tb[IFA_CACHEINFO]);
 
-               fprintf(fp, "%s", _SL_);
-               fprintf(fp, "       valid_lft ");
-               if (ci->ifa_valid == INFINITY_LIFE_TIME)
-                       fprintf(fp, "forever");
-               else
-                       fprintf(fp, "%usec", ci->ifa_valid);
-               fprintf(fp, " preferred_lft ");
-               if (ci->ifa_prefered == INFINITY_LIFE_TIME)
-                       fprintf(fp, "forever");
-               else {
-                       if (deprecated)
-                               fprintf(fp, "%dsec", ci->ifa_prefered);
+               print_string(PRINT_FP, NULL, "%s", _SL_);
+               print_string(PRINT_FP, NULL, "       valid_lft ", NULL);
+
+               if (ci->ifa_valid == INFINITY_LIFE_TIME) {
+                       print_uint(PRINT_JSON,
+                                  "valid_life_time",
+                                  NULL, INFINITY_LIFE_TIME);
+                       print_string(PRINT_FP, NULL, "%s", "forever");
+               } else {
+                       print_uint(PRINT_ANY,
+                                  "valid_life_time", "%usec", ci->ifa_valid);
+               }
+
+               print_string(PRINT_FP, NULL, " preferred_lft ", NULL);
+               if (ci->ifa_prefered == INFINITY_LIFE_TIME) {
+                       print_uint(PRINT_JSON,
+                                  "preferred_life_time",
+                                  NULL, INFINITY_LIFE_TIME);
+                       print_string(PRINT_FP, NULL, "%s", "forever");
+               } else {
+                       if (ifa_flags & IFA_F_DEPRECATED)
+                               print_int(PRINT_ANY,
+                                         "preferred_life_time",
+                                         "%dsec",
+                                         ci->ifa_prefered);
                        else
-                               fprintf(fp, "%usec", ci->ifa_prefered);
+                               print_uint(PRINT_ANY,
+                                          "preferred_life_time",
+                                          "%usec",
+                                          ci->ifa_prefered);
                }
        }
-       fprintf(fp, "\n");
+       print_string(PRINT_FP, NULL, "%s", "\n");
 brief_exit:
        fflush(fp);
        return 0;
 }
 
-struct nlmsg_list {
-       struct nlmsg_list *next;
-       struct nlmsghdr   h;
-};
-
-struct nlmsg_chain {
-       struct nlmsg_list *head;
-       struct nlmsg_list *tail;
-};
-
 static int print_selected_addrinfo(struct ifinfomsg *ifi,
                                   struct nlmsg_list *ainfo, FILE *fp)
 {
+       open_json_array(PRINT_JSON, "addr_info");
        for ( ; ainfo ;  ainfo = ainfo->next) {
                struct nlmsghdr *n = &ainfo->h;
                struct ifaddrmsg *ifa = NLMSG_DATA(n);
@@ -1208,7 +1695,7 @@ static int print_selected_addrinfo(struct ifinfomsg *ifi,
                if (n->nlmsg_type != RTM_NEWADDR)
                        continue;
 
-               if (n->nlmsg_len < NLMSG_LENGTH(sizeof(ifa)))
+               if (n->nlmsg_len < NLMSG_LENGTH(sizeof(*ifa)))
                        return -1;
 
                if (ifa->ifa_index != ifi->ifi_index ||
@@ -1218,10 +1705,14 @@ static int print_selected_addrinfo(struct ifinfomsg *ifi,
                if (filter.up && !(ifi->ifi_flags&IFF_UP))
                        continue;
 
+               open_json_object(NULL);
                print_addrinfo(NULL, n, fp);
+               close_json_object();
        }
+       close_json_array(PRINT_JSON, NULL);
+
        if (brief) {
-               fprintf(fp, "\n");
+               print_string(PRINT_FP, NULL, "%s", "\n");
                fflush(fp);
        }
        return 0;
@@ -1310,17 +1801,31 @@ static int show_handler(const struct sockaddr_nl *nl,
 {
        struct ifaddrmsg *ifa = NLMSG_DATA(n);
 
-       printf("if%d:\n", ifa->ifa_index);
+       open_json_object(NULL);
+       print_int(PRINT_ANY, "index", "if%d:\n", ifa->ifa_index);
        print_addrinfo(NULL, n, stdout);
+       close_json_object();
        return 0;
 }
 
 static int ipaddr_showdump(void)
 {
+       int err;
+
        if (ipadd_dump_check_magic())
                exit(-1);
 
-       exit(rtnl_from_file(stdin, &show_handler, NULL));
+       new_json_obj(json);
+       open_json_object(NULL);
+       open_json_array(PRINT_JSON, "addr_info");
+
+       err = rtnl_from_file(stdin, &show_handler, NULL);
+
+       close_json_array(PRINT_JSON, NULL);
+       close_json_object();
+       delete_json_obj();
+
+       exit(err);
 }
 
 static int restore_handler(const struct sockaddr_nl *nl,
@@ -1333,7 +1838,7 @@ static int restore_handler(const struct sockaddr_nl *nl,
 
        ll_init_map(&rth);
 
-       ret = rtnl_talk(&rth, n, n, sizeof(*n));
+       ret = rtnl_talk(&rth, n, NULL);
        if ((ret < 0) && (errno == EEXIST))
                ret = 0;
 
@@ -1348,7 +1853,7 @@ static int ipaddr_restore(void)
        exit(rtnl_from_file(stdin, &restore_handler, NULL));
 }
 
-static void free_nlmsg_chain(struct nlmsg_chain *info)
+void free_nlmsg_chain(struct nlmsg_chain *info)
 {
        struct nlmsg_list *l, *n;
 
@@ -1393,10 +1898,10 @@ static void ipaddr_filter(struct nlmsg_chain *linfo, struct nlmsg_chain *ainfo)
                                        tb[IFA_LOCAL] = tb[IFA_ADDRESS];
 
                                if (filter.pfx.family && tb[IFA_LOCAL]) {
-                                       inet_prefix dst;
+                                       inet_prefix dst = {
+                                               .family = ifa->ifa_family
+                                       };
 
-                                       memset(&dst, 0, sizeof(dst));
-                                       dst.family = ifa->ifa_family;
                                        memcpy(&dst.data, RTA_DATA(tb[IFA_LOCAL]), RTA_PAYLOAD(tb[IFA_LOCAL]));
                                        if (inet_addr_match(&dst, &filter.pfx, filter.pfx.bitlen))
                                                continue;
@@ -1481,10 +1986,73 @@ static int ipaddr_flush(void)
        return 1;
 }
 
+static int iplink_filter_req(struct nlmsghdr *nlh, int reqlen)
+{
+       int err;
+
+       err = addattr32(nlh, reqlen, IFLA_EXT_MASK, RTEXT_FILTER_VF);
+       if (err)
+               return err;
+
+       if (filter.master) {
+               err = addattr32(nlh, reqlen, IFLA_MASTER, filter.master);
+               if (err)
+                       return err;
+       }
+
+       if (filter.kind) {
+               struct rtattr *linkinfo;
+
+               linkinfo = addattr_nest(nlh, reqlen, IFLA_LINKINFO);
+
+               err = addattr_l(nlh, reqlen, IFLA_INFO_KIND, filter.kind,
+                               strlen(filter.kind));
+               if (err)
+                       return err;
+
+               addattr_nest_end(nlh, linkinfo);
+       }
+
+       return 0;
+}
+
+/* fills in linfo with link data and optionally ainfo with address info
+ * caller can walk lists as desired and must call free_nlmsg_chain for
+ * both when done
+ */
+int ip_linkaddr_list(int family, req_filter_fn_t filter_fn,
+                    struct nlmsg_chain *linfo, struct nlmsg_chain *ainfo)
+{
+       if (rtnl_wilddump_req_filter_fn(&rth, preferred_family, RTM_GETLINK,
+                                       filter_fn) < 0) {
+               perror("Cannot send dump request");
+               return 1;
+       }
+
+       if (rtnl_dump_filter(&rth, store_nlmsg, linfo) < 0) {
+               fprintf(stderr, "Dump terminated\n");
+               return 1;
+       }
+
+       if (ainfo) {
+               if (rtnl_wilddump_request(&rth, family, RTM_GETADDR) < 0) {
+                       perror("Cannot send dump request");
+                       return 1;
+               }
+
+               if (rtnl_dump_filter(&rth, store_nlmsg, ainfo) < 0) {
+                       fprintf(stderr, "Dump terminated\n");
+                       return 1;
+               }
+       }
+
+       return 0;
+}
+
 static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
 {
        struct nlmsg_chain linfo = { NULL, NULL};
-       struct nlmsg_chain ainfo = { NULL, NULL};
+       struct nlmsg_chain _ainfo = { NULL, NULL}, *ainfo = NULL;
        struct nlmsg_list *l;
        char *filter_dev = NULL;
        int no_link = 0;
@@ -1526,52 +2094,8 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
                        filter.scope = scope;
                } else if (strcmp(*argv, "up") == 0) {
                        filter.up = 1;
-               } else if (strcmp(*argv, "dynamic") == 0) {
-                       filter.flags &= ~IFA_F_PERMANENT;
-                       filter.flagmask |= IFA_F_PERMANENT;
-               } else if (strcmp(*argv, "permanent") == 0) {
-                       filter.flags |= IFA_F_PERMANENT;
-                       filter.flagmask |= IFA_F_PERMANENT;
-               } else if (strcmp(*argv, "secondary") == 0 ||
-                          strcmp(*argv, "temporary") == 0) {
-                       filter.flags |= IFA_F_SECONDARY;
-                       filter.flagmask |= IFA_F_SECONDARY;
-               } else if (strcmp(*argv, "primary") == 0) {
-                       filter.flags &= ~IFA_F_SECONDARY;
-                       filter.flagmask |= IFA_F_SECONDARY;
-               } else if (strcmp(*argv, "tentative") == 0) {
-                       filter.flags |= IFA_F_TENTATIVE;
-                       filter.flagmask |= IFA_F_TENTATIVE;
-               } else if (strcmp(*argv, "-tentative") == 0) {
-                       filter.flags &= ~IFA_F_TENTATIVE;
-                       filter.flagmask |= IFA_F_TENTATIVE;
-               } else if (strcmp(*argv, "deprecated") == 0) {
-                       filter.flags |= IFA_F_DEPRECATED;
-                       filter.flagmask |= IFA_F_DEPRECATED;
-               } else if (strcmp(*argv, "-deprecated") == 0) {
-                       filter.flags &= ~IFA_F_DEPRECATED;
-                       filter.flagmask |= IFA_F_DEPRECATED;
-               } else if (strcmp(*argv, "home") == 0) {
-                       filter.flags |= IFA_F_HOMEADDRESS;
-                       filter.flagmask |= IFA_F_HOMEADDRESS;
-               } else if (strcmp(*argv, "nodad") == 0) {
-                       filter.flags |= IFA_F_NODAD;
-                       filter.flagmask |= IFA_F_NODAD;
-               } else if (strcmp(*argv, "mngtmpaddr") == 0) {
-                       filter.flags |= IFA_F_MANAGETEMPADDR;
-                       filter.flagmask |= IFA_F_MANAGETEMPADDR;
-               } else if (strcmp(*argv, "noprefixroute") == 0) {
-                       filter.flags |= IFA_F_NOPREFIXROUTE;
-                       filter.flagmask |= IFA_F_NOPREFIXROUTE;
-               } else if (strcmp(*argv, "autojoin") == 0) {
-                       filter.flags |= IFA_F_MCAUTOJOIN;
-                       filter.flagmask |= IFA_F_MCAUTOJOIN;
-               } else if (strcmp(*argv, "dadfailed") == 0) {
-                       filter.flags |= IFA_F_DADFAILED;
-                       filter.flagmask |= IFA_F_DADFAILED;
-               } else if (strcmp(*argv, "-dadfailed") == 0) {
-                       filter.flags &= ~IFA_F_DADFAILED;
-                       filter.flagmask |= IFA_F_DADFAILED;
+               } else if (get_filter(*argv) == 0) {
+
                } else if (strcmp(*argv, "label") == 0) {
                        NEXT_ARG();
                        filter.label = *argv;
@@ -1587,13 +2111,31 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
                        if (!ifindex)
                                invarg("Device does not exist\n", *argv);
                        filter.master = ifindex;
-               } else if (do_link && strcmp(*argv, "type") == 0) {
+               } else if (strcmp(*argv, "vrf") == 0) {
+                       int ifindex;
+
                        NEXT_ARG();
-                       filter.kind = *argv;
+                       ifindex = ll_name_to_index(*argv);
+                       if (!ifindex)
+                               invarg("Not a valid VRF name\n", *argv);
+                       if (!name_is_vrf(*argv))
+                               invarg("Not a valid VRF name\n", *argv);
+                       filter.master = ifindex;
+               } else if (strcmp(*argv, "type") == 0) {
+                       int soff;
+
+                       NEXT_ARG();
+                       soff = strlen(*argv) - strlen("_slave");
+                       if (!strcmp(*argv + soff, "_slave")) {
+                               (*argv)[soff] = '\0';
+                               filter.slave_kind = *argv;
+                       } else {
+                               filter.kind = *argv;
+                       }
                } else {
-                       if (strcmp(*argv, "dev") == 0) {
+                       if (strcmp(*argv, "dev") == 0)
                                NEXT_ARG();
-                       else if (matches(*argv, "help") == 0)
+                       else if (matches(*argv, "help") == 0)
                                usage();
                        if (filter_dev)
                                duparg2("dev", *argv);
@@ -1630,6 +2172,12 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
                exit(0);
        }
 
+       /*
+        * Initialize a json_writer and open an array object
+        * if -json was specified.
+        */
+       new_json_obj(json);
+
        /*
         * If only filter_dev present and none of the other
         * link filters are present, use RTM_GETLINK to get
@@ -1638,62 +2186,56 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
        if (filter_dev && filter.group == -1 && do_link == 1) {
                if (iplink_get(0, filter_dev, RTEXT_FILTER_VF) < 0) {
                        perror("Cannot send link get request");
+                       delete_json_obj();
                        exit(1);
                }
+               delete_json_obj();
                exit(0);
        }
 
-       if (rtnl_wilddump_request(&rth, preferred_family, RTM_GETLINK) < 0) {
-               perror("Cannot send dump request");
-               exit(1);
-       }
-
-       if (rtnl_dump_filter(&rth, store_nlmsg, &linfo) < 0) {
-               fprintf(stderr, "Dump terminated\n");
-               exit(1);
-       }
-
        if (filter.family != AF_PACKET) {
+               ainfo = &_ainfo;
+
                if (filter.oneline)
                        no_link = 1;
+       }
 
-               if (rtnl_wilddump_request(&rth, filter.family, RTM_GETADDR) < 0) {
-                       perror("Cannot send dump request");
-                       exit(1);
-               }
-
-               if (rtnl_dump_filter(&rth, store_nlmsg, &ainfo) < 0) {
-                       fprintf(stderr, "Dump terminated\n");
-                       exit(1);
-               }
+       if (ip_linkaddr_list(filter.family, iplink_filter_req,
+                            &linfo, ainfo) != 0)
+               goto out;
 
-               ipaddr_filter(&linfo, &ainfo);
-       }
+       if (filter.family != AF_PACKET)
+               ipaddr_filter(&linfo, ainfo);
 
        for (l = linfo.head; l; l = l->next) {
                int res = 0;
                struct ifinfomsg *ifi = NLMSG_DATA(&l->h);
 
+               open_json_object(NULL);
                if (brief) {
-                       if (print_linkinfo_brief(NULL, &l->h, stdout) == 0)
+                       if (print_linkinfo_brief(NULL, &l->h,
+                                                stdout, NULL) == 0)
                                if (filter.family != AF_PACKET)
                                        print_selected_addrinfo(ifi,
-                                                               ainfo.head,
+                                                               ainfo->head,
                                                                stdout);
                } else if (no_link ||
-                        (res = print_linkinfo(NULL, &l->h, stdout)) >= 0) {
+                          (res = print_linkinfo(NULL, &l->h, stdout)) >= 0) {
                        if (filter.family != AF_PACKET)
                                print_selected_addrinfo(ifi,
-                                                       ainfo.head, stdout);
+                                                       ainfo->head, stdout);
                        if (res > 0 && !do_link && show_stats)
                                print_link_stats(stdout, &l->h);
                }
+               close_json_object();
        }
        fflush(stdout);
 
-       free_nlmsg_chain(&ainfo);
+out:
+       if (ainfo)
+               free_nlmsg_chain(ainfo);
        free_nlmsg_chain(&linfo);
-
+       delete_json_obj();
        return 0;
 }
 
@@ -1793,13 +2335,18 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
                struct nlmsghdr n;
                struct ifaddrmsg        ifa;
                char                    buf[256];
-       } req;
+       } req = {
+               .n.nlmsg_len = NLMSG_LENGTH(sizeof(struct ifaddrmsg)),
+               .n.nlmsg_flags = NLM_F_REQUEST | flags,
+               .n.nlmsg_type = cmd,
+               .ifa.ifa_family = preferred_family,
+       };
        char  *d = NULL;
        char  *l = NULL;
        char  *lcl_arg = NULL;
        char  *valid_lftp = NULL;
        char  *preferred_lftp = NULL;
-       inet_prefix lcl;
+       inet_prefix lcl = {};
        inet_prefix peer;
        int local_len = 0;
        int peer_len = 0;
@@ -1808,16 +2355,8 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
        int scoped = 0;
        __u32 preferred_lft = INFINITY_LIFE_TIME;
        __u32 valid_lft = INFINITY_LIFE_TIME;
-       struct ifa_cacheinfo cinfo;
        unsigned int ifa_flags = 0;
 
-       memset(&req, 0, sizeof(req));
-
-       req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct ifaddrmsg));
-       req.n.nlmsg_flags = NLM_F_REQUEST | flags;
-       req.n.nlmsg_type = cmd;
-       req.ifa.ifa_family = preferred_family;
-
        while (argc > 0) {
                if (strcmp(*argv, "peer") == 0 ||
                    strcmp(*argv, "remote") == 0) {
@@ -1900,9 +2439,8 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
                } else if (strcmp(*argv, "autojoin") == 0) {
                        ifa_flags |= IFA_F_MCAUTOJOIN;
                } else {
-                       if (strcmp(*argv, "local") == 0) {
+                       if (strcmp(*argv, "local") == 0)
                                NEXT_ARG();
-                       }
                        if (matches(*argv, "help") == 0)
                                usage();
                        if (local_len)
@@ -1933,9 +2471,9 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
        if (peer_len == 0 && local_len) {
                if (cmd == RTM_DELADDR && lcl.family == AF_INET && !(lcl.flags & PREFIXLEN_SPECIFIED)) {
                        fprintf(stderr,
-                           "Warning: Executing wildcard deletion to stay compatible with old scripts.\n" \
-                           "         Explicitly specify the prefix length (%s/%d) to avoid this warning.\n" \
-                           "         This special behaviour is likely to disappear in further releases,\n" \
+                           "Warning: Executing wildcard deletion to stay compatible with old scripts.\n"
+                           "         Explicitly specify the prefix length (%s/%d) to avoid this warning.\n"
+                           "         This special behaviour is likely to disappear in further releases,\n"
                            "         fix your scripts!\n", lcl_arg, local_len*8);
                } else {
                        peer = lcl;
@@ -1974,6 +2512,8 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
        }
 
        if (valid_lftp || preferred_lftp) {
+               struct ifa_cacheinfo cinfo = {};
+
                if (!valid_lft) {
                        fprintf(stderr, "valid_lft is zero\n");
                        return -1;
@@ -1983,7 +2523,6 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
                        return -1;
                }
 
-               memset(&cinfo, 0, sizeof(cinfo));
                cinfo.ifa_prefered = preferred_lft;
                cinfo.ifa_valid = valid_lft;
                addattr_l(&req.n, sizeof(req), IFA_CACHEINFO, &cinfo,
@@ -1995,7 +2534,7 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
                return -1;
        }
 
-       if (rtnl_talk(&rth, &req.n, NULL, 0) < 0)
+       if (rtnl_talk(&rth, &req.n, NULL) < 0)
                return -2;
 
        return 0;