]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - ip/ipmaddr.c
man: tc-taprio.8: fix syntax error
[mirror_iproute2.git] / ip / ipmaddr.c
index c3673979f97612db4dd49772d3f9a0ce736c9709..105b23a8f075a871c31a129a0e44046bd921893a 100644 (file)
@@ -13,7 +13,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <syslog.h>
 #include <fcntl.h>
 #include <sys/ioctl.h>
 #include <sys/socket.h>
@@ -29,6 +28,7 @@
 #include "rt_names.h"
 #include "utils.h"
 #include "ip_common.h"
+#include "json_print.h"
 
 static struct {
        char *dev;
@@ -93,18 +93,15 @@ static void read_dev_mcast(struct ma_info **result_p)
 
        while (fgets(buf, sizeof(buf), fp)) {
                char hexa[256];
-               struct ma_info m;
+               struct ma_info m = { .addr.family = AF_PACKET };
                int len;
                int st;
 
-               memset(&m, 0, sizeof(m));
                sscanf(buf, "%d%s%d%d%s", &m.index, m.name, &m.users, &st,
                       hexa);
                if (filter.dev && strcmp(filter.dev, m.name))
                        continue;
 
-               m.addr.family = AF_PACKET;
-
                len = parse_hex(hexa, (unsigned char *)&m.addr.data, sizeof(m.addr.data));
                if (len >= 0) {
                        struct ma_info *ma = malloc(sizeof(m));
@@ -122,27 +119,31 @@ static void read_dev_mcast(struct ma_info **result_p)
 
 static void read_igmp(struct ma_info **result_p)
 {
-       struct ma_info m;
+       struct ma_info m = {
+               .addr.family = AF_INET,
+               .addr.bitlen = 32,
+               .addr.bytelen = 4,
+       };
        char buf[256];
        FILE *fp = fopen("/proc/net/igmp", "r");
 
        if (!fp)
                return;
-       memset(&m, 0, sizeof(m));
        if (!fgets(buf, sizeof(buf), fp)) {
                fclose(fp);
                return;
        }
 
-       m.addr.family = AF_INET;
-       m.addr.bitlen = 32;
-       m.addr.bytelen = 4;
-
        while (fgets(buf, sizeof(buf), fp)) {
                struct ma_info *ma;
 
                if (buf[0] != '\t') {
+                       size_t len;
+
                        sscanf(buf, "%d%s", &m.index, m.name);
+                       len = strlen(m.name);
+                       if (m.name[len - 1] == ':')
+                               m.name[len - 1] = '\0';
                        continue;
                }
 
@@ -169,17 +170,14 @@ static void read_igmp6(struct ma_info **result_p)
 
        while (fgets(buf, sizeof(buf), fp)) {
                char hexa[256];
-               struct ma_info m;
+               struct ma_info m = { .addr.family = AF_INET6 };
                int len;
 
-               memset(&m, 0, sizeof(m));
                sscanf(buf, "%d%s%s%d", &m.index, m.name, hexa, &m.users);
 
                if (filter.dev && strcmp(filter.dev, m.name))
                        continue;
 
-               m.addr.family = AF_INET6;
-
                len = parse_hex(hexa, (unsigned char *)&m.addr.data, sizeof(m.addr.data));
                if (len >= 0) {
                        struct ma_info *ma = malloc(sizeof(m));
@@ -196,50 +194,66 @@ static void read_igmp6(struct ma_info **result_p)
 
 static void print_maddr(FILE *fp, struct ma_info *list)
 {
-       fprintf(fp, "\t");
+       print_string(PRINT_FP, NULL, "\t", NULL);
 
+       open_json_object(NULL);
        if (list->addr.family == AF_PACKET) {
                SPRINT_BUF(b1);
-               fprintf(fp, "link  %s", ll_addr_n2a((unsigned char *)list->addr.data,
-                                                   list->addr.bytelen, 0,
-                                                   b1, sizeof(b1)));
+
+               print_string(PRINT_FP, NULL, "link  ", NULL);
+               print_color_string(PRINT_ANY, COLOR_MAC, "link", "%s",
+                                  ll_addr_n2a((void *)list->addr.data, list->addr.bytelen,
+                                              0, b1, sizeof(b1)));
        } else {
-               switch (list->addr.family) {
-               case AF_INET:
-                       fprintf(fp, "inet  ");
-                       break;
-               case AF_INET6:
-                       fprintf(fp, "inet6 ");
-                       break;
-               default:
-                       fprintf(fp, "family %d ", list->addr.family);
-                       break;
-               }
-               fprintf(fp, "%s",
-                       format_host(list->addr.family,
-                                   -1, list->addr.data));
+               print_string(PRINT_ANY, "family", "%-5s ",
+                            family_name(list->addr.family));
+               print_color_string(PRINT_ANY, ifa_family_color(list->addr.family),
+                                  "address", "%s",
+                                  format_host(list->addr.family,
+                                              -1, list->addr.data));
        }
+
        if (list->users != 1)
-               fprintf(fp, " users %d", list->users);
+               print_uint(PRINT_ANY, "users", " users %u", list->users);
+
        if (list->features)
-               fprintf(fp, " %s", list->features);
-       fprintf(fp, "\n");
+               print_string(PRINT_ANY, "features", " %s", list->features);
+
+       print_string(PRINT_FP, NULL, "\n", NULL);
+       close_json_object();
 }
 
 static void print_mlist(FILE *fp, struct ma_info *list)
 {
        int cur_index = 0;
 
+       new_json_obj(json);
        for (; list; list = list->next) {
-               if (oneline) {
-                       cur_index = list->index;
-                       fprintf(fp, "%d:\t%s%s", cur_index, list->name, _SL_);
-               } else if (cur_index != list->index) {
+
+               if (list->index != cur_index || oneline) {
+                       if (cur_index) {
+                               close_json_array(PRINT_JSON, NULL);
+                               close_json_object();
+                       }
+                       open_json_object(NULL);
+
+                       print_uint(PRINT_ANY, "ifindex", "%d:", list->index);
+                       print_color_string(PRINT_ANY, COLOR_IFNAME,
+                                          "ifname", "\t%s", list->name);
+                       print_nl();
                        cur_index = list->index;
-                       fprintf(fp, "%d:\t%s\n", cur_index, list->name);
+
+                       open_json_array(PRINT_JSON, "maddr");
                }
+
                print_maddr(fp, list);
        }
+       if (cur_index) {
+               close_json_array(PRINT_JSON, NULL);
+               close_json_object();
+       }
+
+       delete_json_obj();
 }
 
 static int multiaddr_list(int argc, char **argv)
@@ -274,11 +288,10 @@ static int multiaddr_list(int argc, char **argv)
 
 static int multiaddr_modify(int cmd, int argc, char **argv)
 {
-       struct ifreq ifr;
+       struct ifreq ifr = {};
+       int family;
        int fd;
 
-       memset(&ifr, 0, sizeof(ifr));
-
        if (cmd == RTM_NEWADDR)
                cmd = SIOCADDMULTI;
        else
@@ -289,7 +302,8 @@ static int multiaddr_modify(int cmd, int argc, char **argv)
                        NEXT_ARG();
                        if (ifr.ifr_name[0])
                                duparg("dev", *argv);
-                       strncpy(ifr.ifr_name, *argv, IFNAMSIZ);
+                       if (get_ifname(ifr.ifr_name, *argv))
+                               invarg("\"dev\" not a valid ifname", *argv);
                } else {
                        if (matches(*argv, "address") == 0) {
                                NEXT_ARG();
@@ -311,7 +325,17 @@ static int multiaddr_modify(int cmd, int argc, char **argv)
                exit(-1);
        }
 
-       fd = socket(AF_INET, SOCK_DGRAM, 0);
+       switch (preferred_family) {
+       case AF_INET6:
+       case AF_PACKET:
+       case AF_INET:
+               family = preferred_family;
+               break;
+       default:
+               family = AF_INET;
+       }
+
+       fd = socket(family, SOCK_DGRAM, 0);
        if (fd < 0) {
                perror("Cannot create socket");
                exit(1);