]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - ip/link_vti.c
ip: ipnetconf: Convert to use print_on_off()
[mirror_iproute2.git] / ip / link_vti.c
index d5242ac762fdbe101978acf9ee0c4c0fadfca5b8..3a52ea870b56b6e3df15c7c882420262bfa0503e 100644 (file)
 #include "ip_common.h"
 #include "tunnel.h"
 
-
-static void print_usage(FILE *f)
+static void vti_print_help(struct link_util *lu, int argc, char **argv, FILE *f)
 {
        fprintf(f,
-               "Usage: ... vti [ remote ADDR ]\n"
-               "               [ local ADDR ]\n"
-               "               [ [i|o]key KEY ]\n"
-               "               [ dev PHYS_DEV ]\n"
-               "               [ fwmark MARK ]\n"
+               "Usage: ... %-4s        [ remote ADDR ]\n"
+               "               [ local ADDR ]\n"
+               "               [ [i|o]key KEY ]\n"
+               "               [ dev PHYS_DEV ]\n"
+               "               [ fwmark MARK ]\n"
                "\n"
-               "Where: ADDR := { IP_ADDRESS }\n"
-               "       KEY  := { DOTTED_QUAD | NUMBER }\n"
-               "       MARK := { 0x0..0xffffffff }\n"
-       );
-}
-
-static void usage(void) __attribute__((noreturn));
-static void usage(void)
-{
-       print_usage(stderr);
-       exit(-1);
+               "Where: ADDR := { IP_ADDRESS }\n"
+               "       KEY  := { DOTTED_QUAD | NUMBER }\n"
+               "       MARK := { 0x0..0xffffffff }\n",
+               lu->id);
 }
 
 static int vti_parse_opt(struct link_util *lu, int argc, char **argv,
                         struct nlmsghdr *n)
 {
-       struct ifinfomsg *ifi = (struct ifinfomsg *)(n + 1);
+       struct ifinfomsg *ifi = NLMSG_DATA(n);
        struct {
                struct nlmsghdr n;
                struct ifinfomsg i;
-               char buf[1024];
        } req = {
                .n.nlmsg_len = NLMSG_LENGTH(sizeof(*ifi)),
                .n.nlmsg_flags = NLM_F_REQUEST,
@@ -61,31 +52,36 @@ static int vti_parse_opt(struct link_util *lu, int argc, char **argv,
                .i.ifi_family = preferred_family,
                .i.ifi_index = ifi->ifi_index,
        };
+       struct nlmsghdr *answer;
        struct rtattr *tb[IFLA_MAX + 1];
        struct rtattr *linkinfo[IFLA_INFO_MAX+1];
        struct rtattr *vtiinfo[IFLA_VTI_MAX + 1];
-       unsigned int ikey = 0;
-       unsigned int okey = 0;
-       unsigned int saddr = 0;
-       unsigned int daddr = 0;
+       __be32 ikey = 0;
+       __be32 okey = 0;
+       inet_prefix saddr, daddr;
        unsigned int link = 0;
-       unsigned int fwmark = 0;
+       __u32 fwmark = 0;
        int len;
 
+       inet_prefix_reset(&saddr);
+       inet_prefix_reset(&daddr);
+
        if (!(n->nlmsg_flags & NLM_F_CREATE)) {
-               if (rtnl_talk(&rth, &req.n, &req.n, sizeof(req)) < 0) {
+               const struct rtattr *rta;
+
+               if (rtnl_talk(&rth, &req.n, &answer) < 0) {
 get_failed:
                        fprintf(stderr,
                                "Failed to get existing tunnel info.\n");
                        return -1;
                }
 
-               len = req.n.nlmsg_len;
+               len = answer->nlmsg_len;
                len -= NLMSG_LENGTH(sizeof(*ifi));
                if (len < 0)
                        goto get_failed;
 
-               parse_rtattr(tb, IFLA_MAX, IFLA_RTA(&req.i), len);
+               parse_rtattr(tb, IFLA_MAX, IFLA_RTA(NLMSG_DATA(answer)), len);
 
                if (!tb[IFLA_LINKINFO])
                        goto get_failed;
@@ -98,107 +94,67 @@ get_failed:
                parse_rtattr_nested(vtiinfo, IFLA_VTI_MAX,
                                    linkinfo[IFLA_INFO_DATA]);
 
+               rta = vtiinfo[IFLA_VTI_LOCAL];
+               if (rta && get_addr_rta(&saddr, rta, AF_INET))
+                       goto get_failed;
+
+               rta = vtiinfo[IFLA_VTI_REMOTE];
+               if (rta && get_addr_rta(&daddr, rta, AF_INET))
+                       goto get_failed;
+
                if (vtiinfo[IFLA_VTI_IKEY])
                        ikey = rta_getattr_u32(vtiinfo[IFLA_VTI_IKEY]);
 
                if (vtiinfo[IFLA_VTI_OKEY])
                        okey = rta_getattr_u32(vtiinfo[IFLA_VTI_OKEY]);
 
-               if (vtiinfo[IFLA_VTI_LOCAL])
-                       saddr = rta_getattr_u32(vtiinfo[IFLA_VTI_LOCAL]);
-
-               if (vtiinfo[IFLA_VTI_REMOTE])
-                       daddr = rta_getattr_u32(vtiinfo[IFLA_VTI_REMOTE]);
-
                if (vtiinfo[IFLA_VTI_LINK])
                        link = rta_getattr_u8(vtiinfo[IFLA_VTI_LINK]);
 
                if (vtiinfo[IFLA_VTI_FWMARK])
                        fwmark = rta_getattr_u32(vtiinfo[IFLA_VTI_FWMARK]);
+
+               free(answer);
        }
 
        while (argc > 0) {
                if (!matches(*argv, "key")) {
-                       unsigned int uval;
-
                        NEXT_ARG();
-                       if (strchr(*argv, '.'))
-                               uval = get_addr32(*argv);
-                       else {
-                               if (get_unsigned(&uval, *argv, 0) < 0) {
-                                       fprintf(stderr,
-                                               "Invalid value for \"key\": \"%s\"; it should be an unsigned integer\n", *argv);
-                                       exit(-1);
-                               }
-                               uval = htonl(uval);
-                       }
-
-                       ikey = okey = uval;
+                       ikey = okey = tnl_parse_key("key", *argv);
                } else if (!matches(*argv, "ikey")) {
-                       unsigned int uval;
-
                        NEXT_ARG();
-                       if (strchr(*argv, '.'))
-                               uval = get_addr32(*argv);
-                       else {
-                               if (get_unsigned(&uval, *argv, 0) < 0) {
-                                       fprintf(stderr, "invalid value for \"ikey\": \"%s\"; it should be an unsigned integer\n", *argv);
-                                       exit(-1);
-                               }
-                               uval = htonl(uval);
-                       }
-                       ikey = uval;
+                       ikey = tnl_parse_key("ikey", *argv);
                } else if (!matches(*argv, "okey")) {
-                       unsigned int uval;
-
                        NEXT_ARG();
-                       if (strchr(*argv, '.'))
-                               uval = get_addr32(*argv);
-                       else {
-                               if (get_unsigned(&uval, *argv, 0) < 0) {
-                                       fprintf(stderr, "invalid value for \"okey\": \"%s\"; it should be an unsigned integer\n", *argv);
-                                       exit(-1);
-                               }
-                               uval = htonl(uval);
-                       }
-                       okey = uval;
+                       okey = tnl_parse_key("okey", *argv);
                } else if (!matches(*argv, "remote")) {
                        NEXT_ARG();
-                       if (!strcmp(*argv, "any")) {
-                               fprintf(stderr, "invalid value for \"remote\": \"%s\"\n", *argv);
-                               exit(-1);
-                       } else {
-                               daddr = get_addr32(*argv);
-                       }
+                       get_addr(&daddr, *argv, AF_INET);
                } else if (!matches(*argv, "local")) {
                        NEXT_ARG();
-                       if (!strcmp(*argv, "any")) {
-                               fprintf(stderr, "invalid value for \"local\": \"%s\"\n", *argv);
-                               exit(-1);
-                       } else {
-                               saddr = get_addr32(*argv);
-                       }
+                       get_addr(&saddr, *argv, AF_INET);
                } else if (!matches(*argv, "dev")) {
                        NEXT_ARG();
-                       link = if_nametoindex(*argv);
-                       if (link == 0) {
-                               fprintf(stderr, "Cannot find device \"%s\"\n",
-                                       *argv);
-                               exit(-1);
-                       }
+                       link = ll_name_to_index(*argv);
+                       if (!link)
+                               exit(nodev(*argv));
                } else if (strcmp(*argv, "fwmark") == 0) {
                        NEXT_ARG();
                        if (get_u32(&fwmark, *argv, 0))
                                invarg("invalid fwmark\n", *argv);
-               } else
-                       usage();
+               } else {
+                       vti_print_help(lu, argc, argv, stderr);
+                       return -1;
+               }
                argc--; argv++;
        }
 
        addattr32(n, 1024, IFLA_VTI_IKEY, ikey);
        addattr32(n, 1024, IFLA_VTI_OKEY, okey);
-       addattr_l(n, 1024, IFLA_VTI_LOCAL, &saddr, 4);
-       addattr_l(n, 1024, IFLA_VTI_REMOTE, &daddr, 4);
+       if (is_addrtype_inet_not_unspec(&saddr))
+               addattr_l(n, 1024, IFLA_VTI_LOCAL, saddr.data, saddr.bytelen);
+       if (is_addrtype_inet_not_unspec(&daddr))
+               addattr_l(n, 1024, IFLA_VTI_REMOTE, daddr.data, daddr.bytelen);
        addattr32(n, 1024, IFLA_VTI_FWMARK, fwmark);
        if (link)
                addattr32(n, 1024, IFLA_VTI_LINK, link);
@@ -208,62 +164,47 @@ get_failed:
 
 static void vti_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
 {
-       const char *local = "any";
-       const char *remote = "any";
-       unsigned int link;
        char s2[64];
 
        if (!tb)
                return;
 
-       if (tb[IFLA_VTI_REMOTE]) {
-               unsigned int addr = rta_getattr_u32(tb[IFLA_VTI_REMOTE]);
-
-               if (addr)
-                       remote = format_host(AF_INET, 4, &addr);
-       }
-
-       fprintf(f, "remote %s ", remote);
-
-       if (tb[IFLA_VTI_LOCAL]) {
-               unsigned int addr = rta_getattr_u32(tb[IFLA_VTI_LOCAL]);
-
-               if (addr)
-                       local = format_host(AF_INET, 4, &addr);
-       }
-
-       fprintf(f, "local %s ", local);
+       tnl_print_endpoint("remote", tb[IFLA_VTI_REMOTE], AF_INET);
+       tnl_print_endpoint("local", tb[IFLA_VTI_LOCAL], AF_INET);
 
-       if (tb[IFLA_VTI_LINK] &&
-           (link = rta_getattr_u32(tb[IFLA_VTI_LINK]))) {
-               const char *n = if_indextoname(link, s2);
+       if (tb[IFLA_VTI_LINK]) {
+               __u32 link = rta_getattr_u32(tb[IFLA_VTI_LINK]);
 
-               if (n)
-                       fprintf(f, "dev %s ", n);
-               else
-                       fprintf(f, "dev %u ", link);
+               if (link) {
+                       print_string(PRINT_ANY, "link", "dev %s ",
+                                    ll_index_to_name(link));
+               }
        }
 
        if (tb[IFLA_VTI_IKEY]) {
-               inet_ntop(AF_INET, RTA_DATA(tb[IFLA_VTI_IKEY]), s2, sizeof(s2));
-               fprintf(f, "ikey %s ", s2);
+               struct rtattr *rta = tb[IFLA_VTI_IKEY];
+               __u32 key = rta_getattr_u32(rta);
+
+               if (key && inet_ntop(AF_INET, RTA_DATA(rta), s2, sizeof(s2)))
+                       print_string(PRINT_ANY, "ikey", "ikey %s ", s2);
        }
 
        if (tb[IFLA_VTI_OKEY]) {
-               inet_ntop(AF_INET, RTA_DATA(tb[IFLA_VTI_OKEY]), s2, sizeof(s2));
-               fprintf(f, "okey %s ", s2);
-       }
+               struct rtattr *rta = tb[IFLA_VTI_OKEY];
+               __u32 key = rta_getattr_u32(rta);
 
-       if (tb[IFLA_VTI_FWMARK] && rta_getattr_u32(tb[IFLA_VTI_FWMARK])) {
-               fprintf(f, "fwmark 0x%x ",
-                       rta_getattr_u32(tb[IFLA_VTI_FWMARK]));
+               if (key && inet_ntop(AF_INET, RTA_DATA(rta), s2, sizeof(s2)))
+                       print_string(PRINT_ANY, "okey", "okey %s ", s2);
        }
-}
 
-static void vti_print_help(struct link_util *lu, int argc, char **argv,
-       FILE *f)
-{
-       print_usage(f);
+       if (tb[IFLA_VTI_FWMARK]) {
+               __u32 fwmark = rta_getattr_u32(tb[IFLA_VTI_FWMARK]);
+
+               if (fwmark) {
+                       print_0xhex(PRINT_ANY,
+                                   "fwmark", "fwmark %#llx ", fwmark);
+               }
+       }
 }
 
 struct link_util vti_link_util = {